Home | Search | webrtc - Builders
Login

Builder iOS64 Release Build 15597 Apple OSX

Results:

Success

Trigger Info:

Projectwebrtc
Revision1d61c430d909d245b32abcd30ee53e93263c9571
Got Revision1d61c430d909d245b32abcd30ee53e93263c9571

Execution:

Steps and Logfiles:

Show:
  1. ( 374 ms ) setup_build
    running recipe: "webrtc/ios"
  2. ( 28 secs ) bot_update
    [167GB/232GB used (71%)]
  3. ( 265 ms ) read build config
  4. ( 7 secs ) gclient runhooks
  5. ( 443 ms ) lookup GN args
     
    dcheck_always_on = true
    ios_enable_code_signing = false
    is_component_build = false
    is_debug = false
    target_cpu = "arm64"
    target_os = "ios"
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  6. ( 484 ms ) compile
  7. ( 0 ) trigger

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build140-m9" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.webrtc.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544203377704590, "id": "8927779114979258160", "project": "webrtc", "tags": ["builder:iOS64 Release", "buildset:commit/git/1d61c430d909d245b32abcd30ee53e93263c9571", "buildset:commit/gitiles/webrtc.googlesource.com/src/+/1d61c430d909d245b32abcd30ee53e93263c9571", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093209177251624368", "scheduler_job_id:webrtc/iOS64 Release", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "iOS64 Release" setup_build
buildnumber 15597 setup_build
mastername "client.webrtc" setup_build
path_config "generic" setup_build
recipe "webrtc/ios" setup_build
repository "https://webrtc.googlesource.com/src/" setup_build
revision "1d61c430d909d245b32abcd30ee53e93263c9571" setup_build
got_revision "1d61c430d909d245b32abcd30ee53e93263c9571" bot_update
got_revision_cp "refs/heads/master@{#25936}" bot_update

Blamelist:

  1. braveyao (braveyaoohnoyoudont@webrtc.org)

Timing:

Create Friday, 07-Dec-18 17:22:57 UTC
Start Friday, 07-Dec-18 17:36:25 UTC
End Friday, 07-Dec-18 17:38:22 UTC
Pending 13 mins 27 secs
Execution 1 mins 57 secs

All Changes:

  1. desktopCapture: copy whole screen region when screen is zoomed on OSX

    Changed by braveyao - braveyaoohnoyoudont@webrtc.org
    Changed at Friday, 07-Dec-18 17:22:35 UTC
    Repository https://webrtc.googlesource.com/src
    Branch
    Revision 1d61c430d909d245b32abcd30ee53e93263c9571

    Comments

    desktopCapture: copy whole screen region when screen is zoomed on OSX
    
    When screen is zoomed in/out, OSX only updates the parts of Rects currently
    displayed on screen, with relative location to current top-left on screen.
    This will cause problems when we copy the dirty regions to the captured
    frame. So we invalidate the whole screen to copy all the screen contents.
    
    - With CGI method, the zooming will be ignored and the whole screen contents
    will be captured as before.
    - With IOSurface method, the zoomed screen contents will be captured.
    
    Since we can't know the zooming level and focusing location, so we have
    to copy the whole screen region for each frame during rooming. And this
    will impact peformance a bit (with IOSurface capturer about 5-10 fps
    down on MBP.)
    
    Bug: chromium:911862
    Change-Id: Icf123cde4d686ab7ce28fa731bc8dac6925492c8
    Reviewed-on: https://webrtc-review.googlesource.com/c/113101
    Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
    Commit-Queue: Brave Yao <braveyao@webrtc.org>
    Cr-Commit-Position: refs/heads/master@{#25936}

    Changed files

    • modules/desktop_capture/mac/screen_capturer_mac.mm