Builder V8-Blink Linux 64 Build 29462
Results:
Success
Trigger Info:
Project | v8 |
Revision | eab3508ac58b4cdfe30641802bec27009fb8924e |
Got Revision | eab3508ac58b4cdfe30641802bec27009fb8924e |
Execution:
- Source: Task 429415bd771e2f10
- Bot: swarm832-c4
- Recipe: blink_downstream
Steps and Logfiles:
Show:-
- - no logs -
-
( 723 ms ) lookup GN argsis_component_build = falseis_debug = falsestrip_absolute_paths_from_debug_symbols = trueuse_goma = truegoma_dir = "/b/swarming/w/ir/cache/goma/client"
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
( 14 mins 17 secs ) webkit_layout_tests (with patch)Run on OS: 'Ubuntu-14.04'Max shard duration: 0:12:18.992490 (shard #5)Min shard duration: 0:10:56.142528 (shard #3)Total tests: 91574* Passed: 82560 (82502 expected, 58 unexpected)* Skipped: 6106 (6106 expected, 0 unexpected)* Failed: 2870 (2870 expected, 0 unexpected)* Flaky: 38 (38 expected, 0 unexpected)
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm832-c4" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.v8.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548256293890012, "id": "8923529324336235536", "project": "v8", "tags": ["builder:V8-Blink Linux 64", "buildset:commit/git/eab3508ac58b4cdfe30641802bec27009fb8924e", "buildset:commit/gitiles/chromium.googlesource.com/v8/v8/+/eab3508ac58b4cdfe30641802bec27009fb8924e", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9088959386462174160", "scheduler_job_id:v8/V8-Blink Linux 64", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "V8-Blink Linux 64" | setup_build |
buildnumber | 29462 | setup_build |
mastername | "client.v8.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "blink_downstream" | setup_build |
repository | "https://chromium.googlesource.com/v8/v8" | setup_build |
revision | "eab3508ac58b4cdfe30641802bec27009fb8924e" | setup_build |
got_angle_revision | "5313c8a89964f536bff2c7f7943499f9c52e5664" | bot_update |
got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
got_cr_revision | "eda64695f7fbbaabb3c3928cdaf41d63e681efe6" | bot_update |
got_cr_revision_cp | "refs/heads/master@{#625198}" | bot_update |
got_dawn_revision | "c0f31e73e481f32d308cb6232e75e6d860d97063" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "eab3508ac58b4cdfe30641802bec27009fb8924e" | bot_update |
got_revision_cp | "refs/heads/master@{#59035}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "eab3508ac58b4cdfe30641802bec27009fb8924e" | bot_update |
got_v8_revision_cp | "refs/heads/master@{#59035}" | bot_update |
got_webrtc_revision | "71b5a7df7794bbc4103296fcd8bd740acebdc901" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26351}" | bot_update |
isolate_server | "https://isolateserver.appspot.com" | isolate webkit_layout_tests_exparchive (with patch) |
swarm_hashes | {"webkit_layout_tests_exparchive": "fadd5f492e05bc13903ce519d2f3efd4d4121080"} | isolate webkit_layout_tests_exparchive (with patch) |
Blamelist:
- Clemens Hammacher (clemenshohnoyoudont@chromium.org)
Timing:
Create | Wednesday, 23-Jan-19 15:11:33 UTC |
Start | Wednesday, 23-Jan-19 15:15:42 UTC |
End | Wednesday, 23-Jan-19 15:54:34 UTC |
Pending | 4 mins 8 secs |
Execution | 38 mins 52 secs |
All Changes:
-
Reland "[wasm] Decouple background compile jobs from NativeModule"
Changed by Clemens Hammacher - clemenshohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 15:05:02 UTC Repository https://chromium.googlesource.com/v8/v8 Branch Revision eab3508ac58b4cdfe30641802bec27009fb8924e Comments
Reland "[wasm] Decouple background compile jobs from NativeModule" This is a reland of 92d9b09c0e68382d1427ad25c70db016bb9e5b80. Patch unchanged, errors fixed by https://crrev.com/c/1430059. Original change's description: > [wasm] Decouple background compile jobs from NativeModule > > Background compile jobs should not keep the NativeModule alive, for two > reasons: > 1) We sometimes have to wait for background compilation to finish (from > a foreground task!). This introduces unnecessary latency. > 2) Giving the background compile tasks shared ownership of the > NativeModule causes the NativeModule (and the CompilationState) to > be freed from background tasks, which is error-prone (see > https://crrev.com/c/1400420). > > Instead, this CL introduces a BackgroundCompileToken which is held > alive by the NativeModule and all background compile jobs. The initial > and the final phase of compilation (getting and submitting work) > synchronize on this token to check and ensure that the NativeModule is > and stays alive. During compilation itself, the mutex is released, such > that the NativeModule can die. > The destructor of the NativeModule cancels the BackgroundCompileToken. > Immediately afterwards, the NativeModule and the CompilationState can > die. > > This change allows to remove two hacks introduced previously: The atomic > {aborted_} flag and the {FreeCallbacksTask}. > > R=mstarzinger@chromium.org > CC=titzer@chromium.org > > Bug: v8:8689, v8:7921 > Change-Id: I42e06eab3c944b0988286f2ce18e3c294535dfb6 > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel > Reviewed-on: https://chromium-review.googlesource.com/c/1421364 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59020} TBR=mstarzinger@chromium.org Bug: v8:8689, v8:7921 Change-Id: Iead972ef77c8503da7246cab48e7693b176d8f02 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Reviewed-on: https://chromium-review.googlesource.com/c/1429862 Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59035}
Changed files
- src/v8.cc
- src/wasm/compilation-environment.h
- src/wasm/module-compiler.cc
- src/wasm/wasm-code-manager.h
- src/wasm/wasm-engine.cc
- src/wasm/wasm-engine.h