Builder V8 Win64 ASAN
Build 6762
Results:
Success
Trigger Info:
Project | v8 |
Revision | eab3508ac58b4cdfe30641802bec27009fb8924e |
Got Revision | eab3508ac58b4cdfe30641802bec27009fb8924e |
Execution:
- Source: Task 429422f5d2df6b10
- Bot: swarm938-c4
- Recipe: v8
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm938-c4" | setup_build |
branch | "refs/heads/master" | setup_build |
build_config | "Release" | setup_build |
buildbucket | {"build": {"bucket": "luci.v8.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548257159530190, "id": "8923528416646953232", "project": "v8", "tags": ["builder:V8 Win64 ASAN", "buildset:commit/git/eab3508ac58b4cdfe30641802bec27009fb8924e", "buildset:commit/gitiles/chromium.googlesource.com/v8/v8/+/eab3508ac58b4cdfe30641802bec27009fb8924e", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9088958478677682160", "scheduler_job_id:v8/V8 Win64 ASAN", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "V8 Win64 ASAN" | setup_build |
buildnumber | 6762 | setup_build |
mastername | "client.v8" | setup_build |
path_config | "generic" | setup_build |
recipe | "v8" | setup_build |
repository | "https://chromium.googlesource.com/v8/v8" | setup_build |
revision | "eab3508ac58b4cdfe30641802bec27009fb8924e" | setup_build |
Blamelist:
- Clemens Hammacher (clemenshohnoyoudont@chromium.org)
- Andreas Haas (ahaasohnoyoudont@chromium.org)
Timing:
Create | Wednesday, 23-Jan-19 15:25:59 UTC |
Start | Wednesday, 23-Jan-19 15:26:01 UTC |
End | Wednesday, 23-Jan-19 15:56:42 UTC |
Pending | 1 secs |
Execution | 30 mins 41 secs |
All Changes:
-
Reland "[wasm] Decouple background compile jobs from NativeModule"
Changed by Clemens Hammacher - clemenshohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 15:05:02 UTC Repository https://chromium.googlesource.com/v8/v8 Branch Revision eab3508ac58b4cdfe30641802bec27009fb8924e Comments
Reland "[wasm] Decouple background compile jobs from NativeModule" This is a reland of 92d9b09c0e68382d1427ad25c70db016bb9e5b80. Patch unchanged, errors fixed by https://crrev.com/c/1430059. Original change's description: > [wasm] Decouple background compile jobs from NativeModule > > Background compile jobs should not keep the NativeModule alive, for two > reasons: > 1) We sometimes have to wait for background compilation to finish (from > a foreground task!). This introduces unnecessary latency. > 2) Giving the background compile tasks shared ownership of the > NativeModule causes the NativeModule (and the CompilationState) to > be freed from background tasks, which is error-prone (see > https://crrev.com/c/1400420). > > Instead, this CL introduces a BackgroundCompileToken which is held > alive by the NativeModule and all background compile jobs. The initial > and the final phase of compilation (getting and submitting work) > synchronize on this token to check and ensure that the NativeModule is > and stays alive. During compilation itself, the mutex is released, such > that the NativeModule can die. > The destructor of the NativeModule cancels the BackgroundCompileToken. > Immediately afterwards, the NativeModule and the CompilationState can > die. > > This change allows to remove two hacks introduced previously: The atomic > {aborted_} flag and the {FreeCallbacksTask}. > > R=mstarzinger@chromium.org > CC=titzer@chromium.org > > Bug: v8:8689, v8:7921 > Change-Id: I42e06eab3c944b0988286f2ce18e3c294535dfb6 > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel > Reviewed-on: https://chromium-review.googlesource.com/c/1421364 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59020} TBR=mstarzinger@chromium.org Bug: v8:8689, v8:7921 Change-Id: Iead972ef77c8503da7246cab48e7693b176d8f02 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Reviewed-on: https://chromium-review.googlesource.com/c/1429862 Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59035}
Changed files
- src/v8.cc
- src/wasm/compilation-environment.h
- src/wasm/module-compiler.cc
- src/wasm/wasm-code-manager.h
- src/wasm/wasm-engine.cc
- src/wasm/wasm-engine.h
-
[wasm] Update spec tests
Changed by Andreas Haas - ahaasohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 14:57:21 UTC Repository https://chromium.googlesource.com/v8/v8 Branch Revision 76a41418e4c793334b7adea22bdeca40599d35c5 Comments
[wasm] Update spec tests R=titzer@chromium.org Change-Id: I45693c7bc7600dde4d01d1130f3be1641c5e9250 Reviewed-on: https://chromium-review.googlesource.com/c/1430102 Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#59034}
Changed files
- DEPS
- test/wasm-spec-tests/tests.tar.gz.sha1