Builder V8 Linux64 - internal snapshot Build 20113
Results:
Success
Trigger Info:
Project | v8 |
Revision | b60eb45c82bb314df6340ae295d2578e647b72ae |
Got Revision | b60eb45c82bb314df6340ae295d2578e647b72ae |
Execution:
- Source: Task 4293f4c32b651610
- Bot: swarm338-c4
- Recipe: v8
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm338-c4" | setup_build |
branch | "refs/heads/master" | setup_build |
build_config | "Release" | setup_build |
buildbucket | {"build": {"bucket": "luci.v8.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548254131861699, "id": "8923531591387563360", "project": "v8", "tags": ["builder:V8 Linux64 - internal snapshot", "buildset:commit/git/b60eb45c82bb314df6340ae295d2578e647b72ae", "buildset:commit/gitiles/chromium.googlesource.com/v8/v8/+/b60eb45c82bb314df6340ae295d2578e647b72ae", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9088961653411057360", "scheduler_job_id:v8/V8 Linux64 - internal snapshot", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "V8 Linux64 - internal snapshot" | setup_build |
buildnumber | 20113 | setup_build |
mastername | "client.v8" | setup_build |
path_config | "generic" | setup_build |
recipe | "v8" | setup_build |
repository | "https://chromium.googlesource.com/v8/v8" | setup_build |
revision | "b60eb45c82bb314df6340ae295d2578e647b72ae" | setup_build |
Blamelist:
- Clemens Hammacher (clemenshohnoyoudont@chromium.org)
Timing:
Create | Wednesday, 23-Jan-19 14:35:31 UTC |
Start | Wednesday, 23-Jan-19 14:39:11 UTC |
End | Wednesday, 23-Jan-19 14:50:09 UTC |
Pending | 3 mins 39 secs |
Execution | 10 mins 57 secs |
All Changes:
-
[cctest] Reenable V8 disposal
Changed by Clemens Hammacher - clemenshohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 14:34:49 UTC Repository https://chromium.googlesource.com/v8/v8 Branch Revision b60eb45c82bb314df6340ae295d2578e647b72ae Comments
[cctest] Reenable V8 disposal This was disabled in 2014 (https://crrev.com/267383002), together with a comment about a broken serializer. The conditional v8 initialization was since then moved back to be unconditional, but the TearDown was never restored. Now we need it for wasm, since during tear down the wasm engine synchronizes on all background compile jobs. Omitting this leads to uses of the disposed platform (see https://crrev.com/c/1429861). R=mstarzinger@chromium.org Bug: v8:8689, v8:7921, v8:8725 Change-Id: Ia24f746094f38fc6ce349532587b622384379125 Reviewed-on: https://chromium-review.googlesource.com/c/1430059 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#59032}
Changed files
- src/api.cc
- test/cctest/cctest.cc