Builder V8 Linux64 - internal snapshot Build 20056
Results:
Success
Trigger Info:
Project | v8 |
Revision | 6962334df89773b038e99845b03d80a813149776 |
Got Revision | 6962334df89773b038e99845b03d80a813149776 |
Execution:
- Source: Task 428a0086fa25f110
- Bot: swarm2401-c4
- Recipe: v8
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm2401-c4" | setup_build |
branch | "refs/heads/master" | setup_build |
build_config | "Release" | setup_build |
buildbucket | {"build": {"bucket": "luci.v8.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548087131534000, "id": "8923706703923326848", "project": "v8", "tags": ["builder:V8 Linux64 - internal snapshot", "buildset:commit/git/6962334df89773b038e99845b03d80a813149776", "buildset:commit/gitiles/chromium.googlesource.com/v8/v8/+/6962334df89773b038e99845b03d80a813149776", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089136766054370400", "scheduler_job_id:v8/V8 Linux64 - internal snapshot", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "V8 Linux64 - internal snapshot" | setup_build |
buildnumber | 20056 | setup_build |
mastername | "client.v8" | setup_build |
path_config | "generic" | setup_build |
recipe | "v8" | setup_build |
repository | "https://chromium.googlesource.com/v8/v8" | setup_build |
revision | "6962334df89773b038e99845b03d80a813149776" | setup_build |
Blamelist:
- Clemens Hammacher (clemenshohnoyoudont@chromium.org)
Timing:
Create | Monday, 21-Jan-19 16:12:11 UTC |
Start | Monday, 21-Jan-19 16:15:47 UTC |
End | Monday, 21-Jan-19 16:26:27 UTC |
Pending | 3 mins 36 secs |
Execution | 10 mins 39 secs |
All Changes:
-
[platform] Allow to memory-map empty files
Changed by Clemens Hammacher - clemenshohnoyoudont@chromium.org Changed at Monday, 21-Jan-19 16:02:47 UTC Repository https://chromium.googlesource.com/v8/v8 Branch Revision 6962334df89773b038e99845b03d80a813149776 Comments
[platform] Allow to memory-map empty files This current fails, since {mmap} fails with EINVAL for empty mappings. The destructor already has special handling for a {nullptr} mapping, so we can just use {nullptr} for empty files. We get a similar error on windows, and can fix it the same way. On order to make presubmit checks happy, we have to skip copyright checking and checking for terminating newlines for empty files. R=mlippautz@chromium.org Change-Id: I2b73da7ff6df72d8bdd40df1fff6422e0a46881e Reviewed-on: https://chromium-review.googlesource.com/c/1424861 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58970}
Changed files
- src/base/platform/platform-posix.cc
- src/base/platform/platform-win32.cc
- test/message/empty.js
- test/message/empty.out
- tools/v8_presubmit.py