Builder V8 Linux64 - internal snapshot Build 20035

Results:

Success

Trigger Info:

Project	v8
Revision	4dbdeea2fea0f8f8fa22f11286b4e2404e318d59
Got Revision	4dbdeea2fea0f8f8fa22f11286b4e2404e318d59

Execution:

• Source: Task 4288420cd12e2b10
• Bot: swarm334-c4
• Recipe: v8

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 228 ms ) setup_build

   running recipe: "v8"
   • stdout
   • run_recipe
2. ( 39 secs ) initialization
   • - no logs -
   1. ( 443 ms ) ensure builder cache dir
      • stdout
   2. ( 32 secs ) bot_update

      [256GB/295GB used (86%)]
      • stdout
      • json.output
   3. ( 725 ms ) swarming.py --version

      0.14
      • stdout
   4. ( 104 ms ) ensure_goma
      • - no logs -
      1. ( 104 ms ) ensure_installed
         • stdout
         • json.output
   5. ( 4 secs ) gclient runhooks
      • stdout
   6. ( 443 ms ) ensure custom_deps dir
      • stdout
   7. ( 440 ms ) list test roots
      • stdout
      • listdir
   8. ( 447 ms ) read test spec (v8)
      • stdout
      • test_spec
3. ( 1 mins 17 secs ) build
   • - no logs -
   1. ( 517 ms ) lookup GN args
      • stdout
      • gn_args
   2. ( 1 secs ) generate_build_files
      • stdout
      • swarming-targets-file.txt
      • gn_args
   3. ( 2 secs ) preprocess_for_goma
      • - no logs -
      1. ( 442 ms ) goma cache directory
         • stdout
      2. ( 943 ms ) start_goma
         • stdout
         • cloudtail
      3. ( 1 secs ) start cloudtail
         • stdout
   4. ( 45 secs ) compile
      • stdout
   5. ( 66 ms ) compile confirm no-op
      • stdout
   6. ( 11 secs ) postprocess_for_goma
      • - no logs -
      1. ( 534 ms ) goma_jsonstatus
         • stdout
         • json.output
      2. ( 496 ms ) goma_stat
         • stdout
      3. ( 493 ms ) stop_goma
         • stdout
      4. ( 8 secs ) upload_log
         • stdout
         • json.output
         • compiler_proxy_log
         • ninja_log
      5. ( 1 secs ) stop cloudtail
         • stdout
   7. ( 13 secs ) isolate tests
      • stdout
      • json.output
   8. ( 1 secs ) gsutil upload
      • stdout
      • gsutil.upload
4. ( 1 secs ) trigger tests
   • - no logs -
   1. ( 1 secs ) [trigger] Check

      Run on OS: 'Ubuntu-14.04'
      • stdout
      • json.output
      • shard #0
5. ( 139 ms ) ensure swarming
   • - no logs -
   1. ( 139 ms ) ensure_installed
      • stdout
      • json.output
6. ( 8 mins 6 secs ) Check
   • stdout
   • durations
7. ( 19 ms ) recipe result
   • result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm334-c4"	setup_build
branch	"refs/heads/master"	setup_build
build_config	"Release"	setup_build
buildbucket	{"build": {"bucket": "luci.v8.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548057870914696, "id": "8923737385906847488", "project": "v8", "tags": ["builder:V8 Linux64 - internal snapshot", "buildset:commit/git/4dbdeea2fea0f8f8fa22f11286b4e2404e318d59", "buildset:commit/gitiles/chromium.googlesource.com/v8/v8/+/4dbdeea2fea0f8f8fa22f11286b4e2404e318d59", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089167448088929104", "scheduler_job_id:v8/V8 Linux64 - internal snapshot", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"V8 Linux64 - internal snapshot"	setup_build
buildnumber	20035	setup_build
mastername	"client.v8"	setup_build
path_config	"generic"	setup_build
recipe	"v8"	setup_build
repository	"https://chromium.googlesource.com/v8/v8"	setup_build
revision	"4dbdeea2fea0f8f8fa22f11286b4e2404e318d59"	setup_build

Blamelist:

1. Peter Marshall (petermarshallohnoyoudont@chromium.org)

Timing:

Create	Monday, 21-Jan-19 08:04:30 UTC
Start	Monday, 21-Jan-19 08:05:30 UTC
End	Monday, 21-Jan-19 08:15:53 UTC
Pending	59 secs
Execution	10 mins 23 secs

All Changes:

1. [cpu-profiler] Use unordered_map instead of custom hashmap in sampler

   Changed by	Peter Marshall - petermarshallohnoyoudont@chromium.org
   Changed at	Monday, 21-Jan-19 07:58:13 UTC
   Repository	https://chromium.googlesource.com/v8/v8
   Branch
   Revision	4dbdeea2fea0f8f8fa22f11286b4e2404e318d59

   Comments

   [cpu-profiler] Use unordered_map instead of custom hashmap in sampler
   
   There is no reason to use the custom map here anymore. This lets us
   get rid of the custom hash and a lot of casts.
   
   We can also store the SamplerList by value in the map rather than a
   pointer, then we don't have to manage the lifetime explicitly.
   
   Also move the SamplerList typedef inside of SamplerManager because it's
   an internal detail. Remove the include for <map> because we aren't using
   this anywhere anyway.
   
   Change-Id: I787a1b6c3ffc331ec3f36e66d5e07bd115c4cbb4
   Reviewed-on: https://chromium-review.googlesource.com/c/1419317
   Reviewed-by: Yang Guo <yangguo@chromium.org>
   Commit-Queue: Peter Marshall <petermarshall@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#58945}

   Changed files

   • src/libsampler/sampler.cc