Builder V8 Linux64 - internal snapshot Build 19997
Results:
Success
Trigger Info:
Project | v8 |
Revision | eebdb0f54dff3bc8169b65e9c079592147ae1919 |
Got Revision | eebdb0f54dff3bc8169b65e9c079592147ae1919 |
Execution:
- Source: Task 4276966e891df010
- Bot: swarm426-c4
- Recipe: v8
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm426-c4" | setup_build |
branch | "refs/heads/master" | setup_build |
build_config | "Release" | setup_build |
buildbucket | {"build": {"bucket": "luci.v8.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547761411294204, "id": "8924048246349085024", "project": "v8", "tags": ["builder:V8 Linux64 - internal snapshot", "buildset:commit/git/eebdb0f54dff3bc8169b65e9c079592147ae1919", "buildset:commit/gitiles/chromium.googlesource.com/v8/v8/+/eebdb0f54dff3bc8169b65e9c079592147ae1919", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089478308511257680", "scheduler_job_id:v8/V8 Linux64 - internal snapshot", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "V8 Linux64 - internal snapshot" | setup_build |
buildnumber | 19997 | setup_build |
mastername | "client.v8" | setup_build |
path_config | "generic" | setup_build |
recipe | "v8" | setup_build |
repository | "https://chromium.googlesource.com/v8/v8" | setup_build |
revision | "eebdb0f54dff3bc8169b65e9c079592147ae1919" | setup_build |
Blamelist:
- tzik (tzikohnoyoudont@chromium.org)
Timing:
Create | Thursday, 17-Jan-19 21:43:31 UTC |
Start | Thursday, 17-Jan-19 21:47:09 UTC |
End | Thursday, 17-Jan-19 21:59:41 UTC |
Pending | 3 mins 37 secs |
Execution | 12 mins 32 secs |
All Changes:
-
Use local MicrotaskQueue in unittests
Changed by tzik - tzikohnoyoudont@chromium.org Changed at Thursday, 17-Jan-19 21:42:52 UTC Repository https://chromium.googlesource.com/v8/v8 Branch Revision eebdb0f54dff3bc8169b65e9c079592147ae1919 Comments
Use local MicrotaskQueue in unittests MicrotaskQueueTest uses Isolate's default_microtask_queue for testing, however the instance is shared between test cases, and causes flaky failure of MicrotaskQueueTest.BufferGrowth. This CL adds a MicrotaskQueue instance for each test fixture, so that each test cases use separate ones. Also, this CL removes the DCHECK that denies non-default MicrotaskQueue to run, which is unneeded after https://crrev.com/c/1369906. Bug: v8:8124 Change-Id: I4ff236c327bf0be14f582b3ca8c802fd72661b42 Reviewed-on: https://chromium-review.googlesource.com/c/1417315 Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#58901}
Changed files
- src/execution.cc
- test/unittests/microtask-queue-unittest.cc
- test/unittests/test-utils.h