Builder V8 Linux - arm - sim - lite - debug Build 1562
Results:
Success
Trigger Info:
Project | v8 |
Revision | aecb020e27a75aa7316df6c15fc2eefcf6ffbc4e |
Got Revision | aecb020e27a75aa7316df6c15fc2eefcf6ffbc4e |
Execution:
- Source: Task 429433c68e39d410
- Bot: swarm337-c4
- Recipe: v8
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm337-c4" | setup_build |
branch | "refs/heads/master" | setup_build |
build_config | "Debug" | setup_build |
buildbucket | {"build": {"bucket": "luci.v8.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548258262161806, "id": "8923527260454671664", "project": "v8", "tags": ["builder:V8 Linux - arm - sim - lite - debug", "buildset:commit/git/aecb020e27a75aa7316df6c15fc2eefcf6ffbc4e", "buildset:commit/gitiles/chromium.googlesource.com/v8/v8/+/aecb020e27a75aa7316df6c15fc2eefcf6ffbc4e", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9088957322748063744", "scheduler_job_id:v8/V8 Linux - arm - sim - lite - debug", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "V8 Linux - arm - sim - lite - debug" | setup_build |
buildnumber | 1562 | setup_build |
mastername | "client.v8.ports" | setup_build |
path_config | "generic" | setup_build |
recipe | "v8" | setup_build |
repository | "https://chromium.googlesource.com/v8/v8" | setup_build |
revision | "aecb020e27a75aa7316df6c15fc2eefcf6ffbc4e" | setup_build |
Blamelist:
- Camillo Bruni (cbruniohnoyoudont@chromium.org)
Timing:
Create | Wednesday, 23-Jan-19 15:44:22 UTC |
Start | Wednesday, 23-Jan-19 15:44:23 UTC |
End | Wednesday, 23-Jan-19 16:06:29 UTC |
Pending | 1 secs |
Execution | 22 mins 6 secs |
All Changes:
-
[parser] Use shared buffer to create PreparseData
Changed by Camillo Bruni - cbruniohnoyoudont@chromium.org Changed at Wednesday, 23-Jan-19 15:32:06 UTC Repository https://chromium.googlesource.com/v8/v8 Branch Revision aecb020e27a75aa7316df6c15fc2eefcf6ffbc4e Comments
[parser] Use shared buffer to create PreparseData Directly access the std::vector buffer backing store to write bytes. By reserving enough space upfront we can avoid many superflous bounds checks that were previously necessary when using push_back. Change-Id: I9b2fb467809e40743b0d9409c9cccb0c6f36f8c1 Reviewed-on: https://chromium-review.googlesource.com/c/1425910 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#59036}
Changed files
- src/parsing/preparse-data-impl.h
- src/parsing/preparse-data.cc
- src/parsing/preparse-data.h
- test/cctest/parsing/test-preparser.cc