Home | Search | v8 - Builders
Login

Builder Linux - Future (dbg) Build 4396 Canonical Ubuntu

Results:

Failure telemetry_unittests

Trigger Info:

Projectv8
Revision28d424ea311f180535b9a5aceb6facfc61c9b59e
Got Revision28d424ea311f180535b9a5aceb6facfc61c9b59e

Execution:

Steps and Logfiles:

Show:
  1. ( 343 ms ) setup_build
    running recipe: "chromium"
  2. ( 228 ms ) report builders
     
    running builder/tester 'Linux - Future (dbg)' on master 'client.v8.chromium'
  3. ( 3 mins 23 secs ) bot_update
    [234GB/295GB used (79%)]
  4. ( 1 secs ) swarming.py --version
    0.14
  5. ( 28 secs ) gclient runhooks
  6. ( 281 ms ) read test spec (client.v8.chromium.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/client.v8.chromium.json
  7. ( 524 ms ) lookup GN args
     
    is_component_build = true
    is_debug = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    v8_enable_future = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 37 secs ) generate_build_files
  9. ( 10 mins 41 secs ) compile
  10. ( 11 secs ) compile confirm no-op
  11. ( 3 mins 25 secs ) isolate tests
  12. ( 481 ms ) find isolated tests
  13. ( 1 secs ) wait for tasks
  14. ( 1 secs ) gin_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  15. ( 1 secs ) devtools_closure_compile
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 33s
    Total tests: n/a
     
  16. ( 1 secs ) google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  17. ( 1 secs ) gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  18. ( 1 secs ) devtools_eslint
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 19s
    Total tests: n/a
     
  19. ( 1 secs ) chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  20. ( 1 secs ) jingle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  21. ( 1 secs ) chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 24s
  22. ( 1 secs ) compositor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 24s
  23. ( 1 secs ) device_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 26s
  24. ( 1 secs ) wait for tasks (2)
  25. ( 1 secs ) telemetry_gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 30s
    Total tests: 38
    * Passed: 38 (38 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  26. ( 1 secs ) nacl_loader_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 19s
  27. ( 1 secs ) remoting_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 29s
  28. ( 1 secs ) pdf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  29. ( 1 secs ) app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 44s
  30. ( 1 secs ) headless_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 26s
  31. ( 2 secs ) gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 35s
  32. ( 1 secs ) ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  33. ( 1 secs ) media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 34s
  34. ( 1 secs ) wait for tasks (3)
  35. ( 2 secs ) extensions_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:19.345669
  36. ( 2 secs ) services_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:06.309257
  37. ( 1 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:34.584093
  38. ( 32 secs ) wait for tasks (4)
  39. ( 1 secs ) headless_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:26.987443
  40. ( 33 secs ) wait for tasks (5)
  41. ( 3 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:12.620202
  42. ( 1 mins 5 secs ) wait for tasks (6)
  43. ( 1 secs ) extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:59.213218
  44. ( 1 secs ) content_shell_crash_test
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:03.114264
    Total tests: n/a
     
  45. ( 4 mins 1 secs ) wait for tasks (7)
  46. ( 5 secs ) unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:07:04.755669
  47. ( 6 mins 2 secs ) wait for tasks (8)
  48. ( 8 secs ) components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:13:17.954268
  49. ( 4 mins 1 secs ) wait for tasks (9)
  50. ( 1 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:18:41.498155 (shard #2)
    Min shard duration: 0:14:08.340895 (shard #1)
  51. ( 2 mins 1 secs ) wait for tasks (10)
  52. ( 1 secs ) sync_integration_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:20:08.135595
  53. ( 2 mins 2 secs ) wait for tasks (11)
  54. ( 15 secs ) net_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:22:46.464365
  55. ( 14 mins 3 secs ) wait for tasks (12)
  56. ( 11 secs ) browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:38:37.691483 (shard #0)
    Min shard duration: 0:26:50.728852 (shard #4)
  57. ( 10 mins 2 secs ) wait for tasks (13)
  58. ( 2 secs ) telemetry_unittests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:48:23.998524 (shard #0)
    Min shard duration: 0:10:38.350218 (shard #1)
    Total tests: 863
    * Passed: 810 (810 expected, 0 unexpected)
    * Skipped: 53 (53 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  59. ( 3 mins 23 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:52:33.988426
  60. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 48
    Total runtime: 9:43:15.232064
     
  61. ( 2 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2403-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.v8.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544163607681674, "id": "8927820816870279920", "project": "v8", "tags": ["builder:Linux - Future (dbg)", "buildset:commit/git/28d424ea311f180535b9a5aceb6facfc61c9b59e", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/28d424ea311f180535b9a5aceb6facfc61c9b59e", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093250878999038256", "scheduler_job_id:v8/Linux - Future (dbg)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Linux - Future (dbg)" setup_build
buildnumber 4396 setup_build
mastername "client.v8.chromium" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src" setup_build
revision "28d424ea311f180535b9a5aceb6facfc61c9b59e" setup_build
got_angle_revision "c3e3731cd3b2a3044f1bdec906c8557cc3edae77" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" bot_update
got_nacl_revision "8e13fe5e85640b063aefcb88a3ccb52abf6e28e8" bot_update
got_revision "28d424ea311f180535b9a5aceb6facfc61c9b59e" bot_update
got_revision_cp "refs/heads/master@{#614622}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "fd3bdfdac02db5d3ab67b707cfe9ca814947d18e" bot_update
got_v8_revision_cp "refs/heads/7.3.56@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
swarm_hashes_refs/heads/master(at){#614622}_without_patch {"app_shell_unittests": "6e55adcfba93692d587266279029afc8097f8b10", "browser_tests": "42a3d5c8b596cfffe3f47e9d75e8feb99211c15f", "chrome_app_unittests": "e942ced96e3d5e9d51c9112b1cc407488235388a", "chromedriver_unittests": "be59a1c22f9f0c3f41b5b0105420e4b5119e7c25", "components_browsertests": "efaba02b450e84397b6523548c8daaea35f18afa", "components_unittests": "951072e4fab379b5a035b8d70433bcc25c311dfe", "compositor_unittests": "ee8691898ead96b6f8b4069e43875d56ea4ae49a", "content_browsertests": "30a4f1a651d1831fa0542e2778eb3bdcc581cb43", "content_shell_crash_test": "7298b909e7633bf8ec1d497e5c5e5135af773d70", "content_unittests": "3d47921d927e9b309b3e51b0e90e0928fe00ae11", "device_unittests": "57b08a1dde12e6d97e0b86519e2738454fb60c2b", "devtools_closure_compile": "f81ac8166cb0e1db77469dc5fccd4a1e9f08ceee", "devtools_eslint": "5869d6cc4a0d4c4aebed7491fbfbb0eaa1aabf12", "extensions_browsertests": "0cabec3637fa0fc1ba508e7abe36403a813f29ab", "extensions_unittests": "c5ac939fd7484bfc327cfd19b8195e83440dc2c5", "gcm_unit_tests": "c81510d341366d95d16dbc69815d692989477a46", "gin_unittests": "c41600d8775a564667cc38e7c1e9a90f6994f3f2", "google_apis_unittests": "7caa72f49059637efedf69590cbfb9c44ca202f3", "gpu_unittests": "d13151bfd6b057dd2af2a33aeb4bc3a0335db95f", "headless_browsertests": "df395c1dacb4328282c837c680a2336e5077e802", "headless_unittests": "e357f53118c343d374630218093b70ba7c99395a", "interactive_ui_tests": "046e9aad2b78af3238f8fa9118ba8f90b2b991c4", "jingle_unittests": "690ba9aeb8f9e207d3da3e7b54dddcdd3d2c506c", "media_blink_unittests": "bad1a1b2d350924b5c27b78ae1f9d65eb00a1f47", "nacl_loader_unittests": "d4026cb321c27de2ea37a89cc413aa862a19ae34", "net_unittests": "7466de52987cea15cbb42d853fbdecbc95bbc4cf", "pdf_unittests": "7e4142cdbcd232b5f73744266d57712d7c1c60b8", "ppapi_unittests": "38dcf8733b4d4babf6a50a793726b977037d26a6", "remoting_unittests": "ec0aae465cb5874accb7696e54e11967c421ed74", "services_unittests": "95fff159170b2040cec290611068b62792f13925", "sync_integration_tests": "6b2dd870a658706cb45fbb513f94df648247687c", "telemetry_gpu_unittests": "513163dce5835bf830f5bccd26b24bcb8177b04b", "telemetry_unittests": "71df0c320d3c9240b9a811006bc0802488c376ed", "unit_tests": "0f59e48dc817edd6f848aae57c713c1435d8f94f"} isolate tests
swarm_hashes {"app_shell_unittests": "6e55adcfba93692d587266279029afc8097f8b10", "browser_tests": "42a3d5c8b596cfffe3f47e9d75e8feb99211c15f", "chrome_app_unittests": "e942ced96e3d5e9d51c9112b1cc407488235388a", "chromedriver_unittests": "be59a1c22f9f0c3f41b5b0105420e4b5119e7c25", "components_browsertests": "efaba02b450e84397b6523548c8daaea35f18afa", "components_unittests": "951072e4fab379b5a035b8d70433bcc25c311dfe", "compositor_unittests": "ee8691898ead96b6f8b4069e43875d56ea4ae49a", "content_browsertests": "30a4f1a651d1831fa0542e2778eb3bdcc581cb43", "content_shell_crash_test": "7298b909e7633bf8ec1d497e5c5e5135af773d70", "content_unittests": "3d47921d927e9b309b3e51b0e90e0928fe00ae11", "device_unittests": "57b08a1dde12e6d97e0b86519e2738454fb60c2b", "devtools_closure_compile": "f81ac8166cb0e1db77469dc5fccd4a1e9f08ceee", "devtools_eslint": "5869d6cc4a0d4c4aebed7491fbfbb0eaa1aabf12", "extensions_browsertests": "0cabec3637fa0fc1ba508e7abe36403a813f29ab", "extensions_unittests": "c5ac939fd7484bfc327cfd19b8195e83440dc2c5", "gcm_unit_tests": "c81510d341366d95d16dbc69815d692989477a46", "gin_unittests": "c41600d8775a564667cc38e7c1e9a90f6994f3f2", "google_apis_unittests": "7caa72f49059637efedf69590cbfb9c44ca202f3", "gpu_unittests": "d13151bfd6b057dd2af2a33aeb4bc3a0335db95f", "headless_browsertests": "df395c1dacb4328282c837c680a2336e5077e802", "headless_unittests": "e357f53118c343d374630218093b70ba7c99395a", "interactive_ui_tests": "046e9aad2b78af3238f8fa9118ba8f90b2b991c4", "jingle_unittests": "690ba9aeb8f9e207d3da3e7b54dddcdd3d2c506c", "media_blink_unittests": "bad1a1b2d350924b5c27b78ae1f9d65eb00a1f47", "nacl_loader_unittests": "d4026cb321c27de2ea37a89cc413aa862a19ae34", "net_unittests": "7466de52987cea15cbb42d853fbdecbc95bbc4cf", "pdf_unittests": "7e4142cdbcd232b5f73744266d57712d7c1c60b8", "ppapi_unittests": "38dcf8733b4d4babf6a50a793726b977037d26a6", "remoting_unittests": "ec0aae465cb5874accb7696e54e11967c421ed74", "services_unittests": "95fff159170b2040cec290611068b62792f13925", "sync_integration_tests": "6b2dd870a658706cb45fbb513f94df648247687c", "telemetry_gpu_unittests": "513163dce5835bf830f5bccd26b24bcb8177b04b", "telemetry_unittests": "71df0c320d3c9240b9a811006bc0802488c376ed", "unit_tests": "0f59e48dc817edd6f848aae57c713c1435d8f94f"} find isolated tests

Blamelist:

  1. Alan Cutter (alancutterohnoyoudont@chromium.org)
  2. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  3. Kinuko Yasuda (kinukoohnoyoudont@chromium.org)
  4. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  5. Li Lin (llinohnoyoudont@chromium.org)
  6. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  7. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  8. Sam McNally (sammcohnoyoudont@chromium.org)
  9. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  10. Adam Rice (riceaohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 06:20:07 UTC
Start Friday, 07-Dec-18 06:20:15 UTC
End Friday, 07-Dec-18 07:33:49 UTC
Pending 7 secs
Execution 1 hrs 13 mins

All Changes:

  1. Revert "Timer notification UI improvement:"

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:18:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 28d424ea311f180535b9a5aceb6facfc61c9b59e

    Comments

    Revert "Timer notification UI improvement:"
    
    This reverts commit d710a7b3ef59302c00c2e3fe1b00c788310801c6.
    
    Reason for revert: Broke compile:
    https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59395
    ../../chromeos/services/assistant/assistant_manager_service_impl.cc:33:10: fatal error: 'libassistant/shared/internal_api/alarm_timer_types.h' file not found
    #include "libassistant/shared/internal_api/alarm_timer_types.h"
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 error generated.
    
    Original change's description:
    > Timer notification UI improvement:
    > 
    > * Add timer deeplinks for:
    >   - Stop timer
    >   - Add time to timer
    > * Add "add 1 min to timer" button to timer notification.
    > 
    > Using a feature flag to guard the usage of the deeplink as
    > AlarmTimerManager is not fully available yet.
    > 
    > Bug: b:119116816
    > Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
    > Reviewed-on: https://chromium-review.googlesource.com/c/1340786
    > Commit-Queue: Li Lin <llin@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > Reviewed-by: Tao Wu <wutao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614618}
    
    TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,wutao@chromium.org,llin@chromium.org
    
    Change-Id: I8ece5ad7361e379880921e2abc55085d1de6cd88
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:119116816
    Reviewed-on: https://chromium-review.googlesource.com/c/1367081
    Reviewed-by: Alan Cutter <alancutter@chromium.org>
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614622}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  2. Report PreviewsEligibilityReason as offline when device is offline

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:11:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01c4f97005f6f162b3df6953b8f2a4efce338ec1

    Comments

    Report PreviewsEligibilityReason as offline when device is offline
    
    Currently, if the device is offline, PreviewsEligibilityReason
    records the reason for not showing previews as network quality
    unavailable.
    
    This CL changes it to record the reason as device offline.
    Network quality unavailable reason is now used for only the cases where
    NQE (network quality estimator) reports ECT as Unknown.
    
    Bug: 912725
    Change-Id: I0af0977770e2123f6ccd0317f8ebbfaed1aac9b2
    Reviewed-on: https://chromium-review.googlesource.com/c/1366835
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614621}

    Changed files

    • components/previews/content/previews_decider_impl.cc
    • components/previews/content/previews_decider_impl_unittest.cc
    • components/previews/core/previews_black_list.h
    • components/previews/core/previews_logger.cc
    • tools/metrics/histograms/enums.xml
  3. Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused

    Changed by Kinuko Yasuda - kinukoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:09:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1eb8373104f00c0ca44780a28d621dd6cf2f603

    Comments

    Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused
    
    This field was added before to keep the copy of the bundle around in
    RFHI but not really used any more.
    
    Bug: N/A
    Change-Id: Ib007ee7dc941b980bab3ad92a1de016ad14d155c
    Reviewed-on: https://chromium-review.googlesource.com/c/1365052
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614620}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h
  4. Roll src-internal 10e8db47197f..3e90e0805dd5 (6 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:50:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e595fa693a4ef17b348340dbb64cf039c765e9c7

    Comments

    Roll src-internal 10e8db47197f..3e90e0805dd5 (6 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/10e8db47197f..3e90e0805dd5
    
    
    Created with:
      gclient setdep -r src-internal@3e90e0805dd5
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ia59b4d7347cb4c123f7e30d889f30af08e8b39f8
    Reviewed-on: https://chromium-review.googlesource.com/c/1367115
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614619}

    Changed files

    • DEPS
  5. Timer notification UI improvement:

    Changed by Li Lin - llinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:41:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d710a7b3ef59302c00c2e3fe1b00c788310801c6

    Comments

    Timer notification UI improvement:
    
    * Add timer deeplinks for:
      - Stop timer
      - Add time to timer
    * Add "add 1 min to timer" button to timer notification.
    
    Using a feature flag to guard the usage of the deeplink as
    AlarmTimerManager is not fully available yet.
    
    Bug: b:119116816
    Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
    Reviewed-on: https://chromium-review.googlesource.com/c/1340786
    Commit-Queue: Li Lin <llin@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Tao Wu <wutao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614618}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  6. Crostini: migrate persisted paths from Downloads to MyFiles

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:38:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa7bc76e086df2f9428a2d583546f84f81c59d16

    Comments

    Crostini: migrate persisted paths from Downloads to MyFiles
    
    When MyFiles is enabled, check persisted paths in prefs
    and convert paths as needed.
    
    Bug: 911946
    Change-Id: I3931d196f89f31fa2ae95f7e02f9241b25d23524
    Reviewed-on: https://chromium-review.googlesource.com/c/1366458
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614617}

    Changed files

    • chrome/browser/chromeos/crostini/crostini_share_path.cc
    • chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
    • chrome/browser/chromeos/file_manager/path_util.cc
    • chrome/browser/chromeos/file_manager/path_util.h
    • chrome/browser/chromeos/file_manager/path_util_unittest.cc
  7. Update V8 to version 7.3.56.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:30:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a61841709892ab7b5fc112c935f62851a2d3831e

    Comments

    Update V8 to version 7.3.56.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/2192eb7f..fd3bdfda
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I21cf598a516538376f34825912d8dd575a2ce058
    Reviewed-on: https://chromium-review.googlesource.com/c/1367111
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614616}

    Changed files

    • DEPS
  8. Add support for returning URLs from SelectFileDialogs.

    Changed by Sam McNally - sammcohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:21:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 53fe68888c1b3e844195142b6ddba163bab85cd9

    Comments

    Add support for returning URLs from SelectFileDialogs.
    
    On ChromeOS, filesystem provider-provided files should be accessed via
    an externalfile URL. Further, hosted gdocs should be redirected to their
    URLs. Currently, this is handled within Browser.
    
    Add a |url| field to SelectedFileInfo to allow communicating these
    values from the dialog to Browser to avoid needing to leak this into
    Browser. Migrate this special-casing into the existing handling of
    SelectFileDialog results on ChromeOS, populating the |url| there.
    
    Bug: 843881
    Change-Id: I9808cdbf38fb4da26b99c8a45f8bda4fd0bee9a7
    Reviewed-on: https://chromium-review.googlesource.com/c/1360812
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614615}

    Changed files

    • chrome/browser/chromeos/extensions/file_manager/private_api_util.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/fileapi/external_file_url_util.cc
    • chrome/browser/chromeos/fileapi/external_file_url_util.h
    • chrome/browser/ui/browser.cc
    • ui/file_manager/integration_tests/file_manager/file_dialog.js
    • ui/shell_dialogs/BUILD.gn
    • ui/shell_dialogs/selected_file_info.cc
    • ui/shell_dialogs/selected_file_info.h
  9. Roll src/native_client 17af1e818981..8e13fe5e8564 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:10:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b87d9e9516460c683b698bb569d85ed8a9fd7348

    Comments

    Roll src/native_client 17af1e818981..8e13fe5e8564 (1 commits)
    
    https://chromium.googlesource.com/native_client/src/native_client.git/+log/17af1e818981..8e13fe5e8564
    
    
    git log 17af1e818981..8e13fe5e8564 --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 jchinlee@chromium.org Surface lxml for use via vpython.
    
    
    Created with:
      gclient setdep -r src/native_client@8e13fe5e8564
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:912379
    TBR=mseaborn@chromium.org
    
    Change-Id: I53ddc48b5935ca8ea3f5bd8a44d39a43341edb2a
    Reviewed-on: https://chromium-review.googlesource.com/c/1366881
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614614}

    Changed files

    • DEPS
  10. Remove EncodingStreams runtime flag

    Changed by Adam Rice - riceaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:10:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fbb267e716151d87e9bb0a394935f6944515700

    Comments

    Remove EncodingStreams runtime flag
    
    TextEncoderStream and TextDecoderStream have shipped. The flag is no
    longer needed. Remove it.
    
    BUG=898158
    
    Change-Id: Ie08d787509f075715b084c7d5e55ad7b2a0e2fb4
    Reviewed-on: https://chromium-review.googlesource.com/c/1364934
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Adam Rice <ricea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614613}

    Changed files

    • third_party/blink/renderer/modules/encoding/text_decoder_stream.idl
    • third_party/blink/renderer/modules/encoding/text_encoder_stream.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5