Builder mac_xfa_jumbo Build 975

Results:

Success

Trigger Info:

Project	pdfium
Revision	89aff068fda213f9ddc77ccdb0931e4633cf87d7
Got Revision	89aff068fda213f9ddc77ccdb0931e4633cf87d7

Execution:

• Source: Task 427150cd5fc2ed10
• Bot: vm169-m9
• Recipe: pdfium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 178 ms ) setup_build

   running recipe: "pdfium"
   • stdout
   • run_recipe
2. ( 41 secs ) bot_update

   [50GB/232GB used (21%)]
   • stdout
   • json.output
3. ( 21 secs ) gclient runhooks
   • stdout
4. ( 224 ms ) ensure_installed
   • stdout
   • json.output
5. ( 56 secs ) install xcode
   • stdout
6. ( 177 ms ) select XCode
   • stdout
7. ( 748 ms ) ensure_goma
   • - no logs -
   1. ( 748 ms ) ensure_installed
      • stdout
      • json.output
8. ( 4 secs ) gn gen
   • stdout
9. ( 14 secs ) preprocess_for_goma
   • - no logs -
   1. ( 600 ms ) goma cache directory
      • stdout
   2. ( 12 secs ) start_goma
      • stdout
      • cloudtail
   3. ( 1 secs ) start cloudtail
      • stdout
10. ( 2 mins 25 secs ) compile with ninja
    • stdout
11. ( 16 secs ) postprocess_for_goma
    • - no logs -
    1. ( 842 ms ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 816 ms ) goma_stat
       • stdout
    3. ( 822 ms ) stop_goma
       • stdout
    4. ( 12 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
       • ninja_log
    5. ( 1 secs ) stop cloudtail
       • stdout
12. ( 9 secs ) unittests
    • stdout
13. ( 44 secs ) embeddertests
    • stdout
14. ( 4 secs ) javascript tests
    • stdout
15. ( 638 ms ) get uninteresting hashes
    • stdout
    • python.inline
16. ( 22 secs ) pixel tests
    • stdout
17. ( 674 ms ) find images
    • stdout
18. ( 2 secs ) gsutil upload JSON
    • stdout
19. ( 1 mins 5 secs ) corpus tests
    • stdout
20. ( 586 ms ) find images (2)
    • stdout
21. ( 2 secs ) gsutil upload JSON (2)
    • stdout
22. ( 60 ms ) reset XCode
    • stdout
23. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"vm169-m9"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.pdfium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547672961080935, "id": "8924140993120570784", "project": "pdfium", "tags": ["builder:mac_xfa_jumbo", "buildset:commit/git/89aff068fda213f9ddc77ccdb0931e4633cf87d7", "buildset:commit/gitiles/pdfium.googlesource.com/pdfium/+/89aff068fda213f9ddc77ccdb0931e4633cf87d7", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089571055909194352", "scheduler_job_id:pdfium/mac_xfa_jumbo", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"mac_xfa_jumbo"	setup_build
buildnumber	975	setup_build
jumbo	true	setup_build
mastername	"client.pdfium"	setup_build
path_config	"generic"	setup_build
recipe	"pdfium"	setup_build
repository	"https://pdfium.googlesource.com/pdfium.git"	setup_build
revision	"89aff068fda213f9ddc77ccdb0931e4633cf87d7"	setup_build
xfa	true	setup_build
got_revision	"89aff068fda213f9ddc77ccdb0931e4633cf87d7"	bot_update

Blamelist:

1. Tom Sepez (tsepezohnoyoudont@chromium.org)

Timing:

Create	Wednesday, 16-Jan-19 21:09:21 UTC
Start	Wednesday, 16-Jan-19 21:09:32 UTC
End	Wednesday, 16-Jan-19 21:17:45 UTC
Pending	11 secs
Execution	8 mins 12 secs

All Changes:

1. Pass out parameter to GetTextNode() by pointer, not reference

   Changed by	Tom Sepez - tsepezohnoyoudont@chromium.org
   Changed at	Wednesday, 16-Jan-19 21:09:09 UTC
   Repository	https://pdfium.googlesource.com/pdfium
   Branch
   Revision	89aff068fda213f9ddc77ccdb0931e4633cf87d7

   Comments

   Pass out parameter to GetTextNode() by pointer, not reference
   
   Otherwise, it isn't clear that CXFA_TextLayout::m_bRichText
   can ever change from its initial value.
   
   Change-Id: I4502b7c31122abfd338b9700a39fc545688fcc42
   Reviewed-on: https://pdfium-review.googlesource.com/c/48392
   Reviewed-by: Lei Zhang <thestig@chromium.org>
   Commit-Queue: Tom Sepez <tsepez@chromium.org>
   

   Changed files

   • xfa/fxfa/cxfa_textlayout.cpp
   • xfa/fxfa/cxfa_textprovider.cpp
   • xfa/fxfa/cxfa_textprovider.h