Builder mac_xfa_jumbo
Build 970
Results:
Success
Trigger Info:
Project | pdfium |
Revision | f054f62ad178e1f24a7b15b4de0ec5a8c9460b3a |
Got Revision | f054f62ad178e1f24a7b15b4de0ec5a8c9460b3a |
Execution:
- Source: Task 4270a5521811e210
- Bot: vm173-m9
- Recipe: pdfium
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "vm173-m9" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.pdfium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547661721919030, "id": "8924152778235604096", "project": "pdfium", "tags": ["builder:mac_xfa_jumbo", "buildset:commit/git/f054f62ad178e1f24a7b15b4de0ec5a8c9460b3a", "buildset:commit/gitiles/pdfium.googlesource.com/pdfium/+/f054f62ad178e1f24a7b15b4de0ec5a8c9460b3a", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089582840999604144", "scheduler_job_id:pdfium/mac_xfa_jumbo", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "mac_xfa_jumbo" | setup_build |
buildnumber | 970 | setup_build |
jumbo | true | setup_build |
mastername | "client.pdfium" | setup_build |
path_config | "generic" | setup_build |
recipe | "pdfium" | setup_build |
repository | "https://pdfium.googlesource.com/pdfium.git" | setup_build |
revision | "f054f62ad178e1f24a7b15b4de0ec5a8c9460b3a" | setup_build |
xfa | true | setup_build |
got_revision | "f054f62ad178e1f24a7b15b4de0ec5a8c9460b3a" | bot_update |
Blamelist:
- Tom Sepez (tsepezohnoyoudont@chromium.org)
Timing:
Create | Wednesday, 16-Jan-19 18:02:01 UTC |
Start | Wednesday, 16-Jan-19 18:02:18 UTC |
End | Wednesday, 16-Jan-19 18:14:06 UTC |
Pending | 16 secs |
Execution | 11 mins 48 secs |
All Changes:
-
Do not check null returns from CFWL_App::Get{WidgetMgr,NoteDriver}()
Changed by Tom Sepez - tsepezohnoyoudont@chromium.org Changed at Wednesday, 16-Jan-19 18:01:24 UTC Repository https://pdfium.googlesource.com/pdfium Branch Revision f054f62ad178e1f24a7b15b4de0ec5a8c9460b3a Comments
Do not check null returns from CFWL_App::Get{WidgetMgr,NoteDriver}() They can't return null since the constructor initializes the underlying members via MakeUnique<>() each time. Change-Id: I86822b157b9f74ea9ef819719a7f1af9ed98d013 Reviewed-on: https://pdfium-review.googlesource.com/c/48333 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org>
Changed files
- xfa/fwl/cfwl_notedriver.cpp
- xfa/fwl/cfwl_widget.cpp
- xfa/fwl/cfwl_widgetmgr.cpp