Builder mac_xfa_jumbo
Build 933
Results:
Success
Trigger Info:
Project | pdfium |
Revision | a13fd3f153300a98f1c5a63cd1ac8e50152e6e26 |
Got Revision | a13fd3f153300a98f1c5a63cd1ac8e50152e6e26 |
Execution:
- Source: Task 425275482ab85010
- Bot: vm169-m9
- Recipe: pdfium
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "vm169-m9" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.pdfium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547155259193865, "id": "8924683842894217504", "project": "pdfium", "tags": ["builder:mac_xfa_jumbo", "buildset:commit/git/a13fd3f153300a98f1c5a63cd1ac8e50152e6e26", "buildset:commit/gitiles/pdfium.googlesource.com/pdfium/+/a13fd3f153300a98f1c5a63cd1ac8e50152e6e26", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9090113905341146912", "scheduler_job_id:pdfium/mac_xfa_jumbo", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "mac_xfa_jumbo" | setup_build |
buildnumber | 933 | setup_build |
jumbo | true | setup_build |
mastername | "client.pdfium" | setup_build |
path_config | "generic" | setup_build |
recipe | "pdfium" | setup_build |
repository | "https://pdfium.googlesource.com/pdfium.git" | setup_build |
revision | "a13fd3f153300a98f1c5a63cd1ac8e50152e6e26" | setup_build |
xfa | true | setup_build |
got_revision | "a13fd3f153300a98f1c5a63cd1ac8e50152e6e26" | bot_update |
Blamelist:
- Tom Sepez (tsepezohnoyoudont@chromium.org)
Timing:
Create | Thursday, 10-Jan-19 21:20:59 UTC |
Start | Thursday, 10-Jan-19 21:21:12 UTC |
End | Thursday, 10-Jan-19 21:27:07 UTC |
Pending | 13 secs |
Execution | 5 mins 55 secs |
All Changes:
-
Add FX_ prefix to all fx_unicode.h global functions.
Changed by Tom Sepez - tsepezohnoyoudont@chromium.org Changed at Thursday, 10-Jan-19 21:20:21 UTC Repository https://pdfium.googlesource.com/pdfium Branch Revision a13fd3f153300a98f1c5a63cd1ac8e50152e6e26 Comments
Add FX_ prefix to all fx_unicode.h global functions. Avoid polluting the global namespace until we someday get around to namespacing pdfium. Usually this isn't an issue because of C++ name mangling and idiosyncratic argument type names, but these just take uint32_t, so we ought not rely on that. Change-Id: I524d0c8679088ae0a549af7ecd37cda781392385 Reviewed-on: https://pdfium-review.googlesource.com/c/48092 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org>
Changed files
- core/fxcrt/cfx_char.cpp
- core/fxcrt/fx_unicode.cpp
- core/fxcrt/fx_unicode.h
- xfa/fgas/layout/cfx_rtfbreak.cpp
- xfa/fgas/layout/cfx_txtbreak.cpp