Builder mac_xfa_jumbo
Build 865
Results:
Success
Trigger Info:
Project | pdfium |
Revision | 587891b979df5a7e58897aa702db48806bd90900 |
Got Revision | 587891b979df5a7e58897aa702db48806bd90900 |
Execution:
- Source: Task 41de79ae46ffbc10
- Bot: vm172-m9
- Recipe: pdfium
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "vm172-m9" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.pdfium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1545209389618112, "id": "8926724235030101440", "project": "pdfium", "tags": ["builder:mac_xfa_jumbo", "buildset:commit/git/587891b979df5a7e58897aa702db48806bd90900", "buildset:commit/gitiles/pdfium.googlesource.com/pdfium/+/587891b979df5a7e58897aa702db48806bd90900", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9092154297122779152", "scheduler_job_id:pdfium/mac_xfa_jumbo", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "mac_xfa_jumbo" | setup_build |
buildnumber | 865 | setup_build |
jumbo | true | setup_build |
mastername | "client.pdfium" | setup_build |
path_config | "generic" | setup_build |
recipe | "pdfium" | setup_build |
repository | "https://pdfium.googlesource.com/pdfium.git" | setup_build |
revision | "587891b979df5a7e58897aa702db48806bd90900" | setup_build |
xfa | true | setup_build |
got_revision | "587891b979df5a7e58897aa702db48806bd90900" | bot_update |
Blamelist:
- Lei Zhang (thestigohnoyoudont@chromium.org)
Timing:
Create | Wednesday, 19-Dec-18 08:49:49 UTC |
Start | Wednesday, 19-Dec-18 08:50:00 UTC |
End | Wednesday, 19-Dec-18 08:55:55 UTC |
Pending | 10 secs |
Execution | 5 mins 54 secs |
All Changes:
-
Clean up CBA_FontMap.
Changed by Lei Zhang - thestigohnoyoudont@chromium.org Changed at Wednesday, 19-Dec-18 08:49:26 UTC Repository https://pdfium.googlesource.com/pdfium Branch Revision 587891b979df5a7e58897aa702db48806bd90900 Comments
Clean up CBA_FontMap. - Move CBA_FontMap_Foo structs into CBA_FontMap. - Inline a method with only 1 caller. - Make a public method private. - Remove checks for nullptr in |m_Data|. This cannot happen. Change-Id: I17b9cba2cf50a9881787bee314caad358329f60c Reviewed-on: https://pdfium-review.googlesource.com/c/47171 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org>
Changed files
- fpdfsdk/formfiller/cba_fontmap.cpp
- fpdfsdk/formfiller/cba_fontmap.h