Builder mac_xfa_jumbo Build 865

Results:

Success

Trigger Info:

Project	pdfium
Revision	587891b979df5a7e58897aa702db48806bd90900
Got Revision	587891b979df5a7e58897aa702db48806bd90900

Execution:

• Source: Task 41de79ae46ffbc10
• Bot: vm172-m9
• Recipe: pdfium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 172 ms ) setup_build

   running recipe: "pdfium"
   • stdout
   • run_recipe
2. ( 29 secs ) bot_update

   [48GB/232GB used (20%)]
   • stdout
   • json.output
3. ( 20 secs ) gclient runhooks
   • stdout
4. ( 204 ms ) ensure_installed
   • stdout
   • json.output
5. ( 52 secs ) install xcode
   • stdout
6. ( 142 ms ) select XCode
   • stdout
7. ( 315 ms ) ensure_goma
   • - no logs -
   1. ( 315 ms ) ensure_installed
      • stdout
      • json.output
8. ( 4 secs ) gn gen
   • stdout
9. ( 13 secs ) preprocess_for_goma
   • - no logs -
   1. ( 564 ms ) goma cache directory
      • stdout
   2. ( 11 secs ) start_goma
      • stdout
      • cloudtail
   3. ( 1 secs ) start cloudtail
      • stdout
10. ( 49 secs ) compile with ninja
    • stdout
11. ( 15 secs ) postprocess_for_goma
    • - no logs -
    1. ( 792 ms ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 797 ms ) goma_stat
       • stdout
    3. ( 824 ms ) stop_goma
       • stdout
    4. ( 11 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
       • ninja_log
    5. ( 1 secs ) stop cloudtail
       • stdout
12. ( 8 secs ) unittests
    • stdout
13. ( 35 secs ) embeddertests
    • stdout
14. ( 3 secs ) javascript tests
    • stdout
15. ( 657 ms ) get uninteresting hashes
    • stdout
    • python.inline
16. ( 20 secs ) pixel tests
    • stdout
17. ( 563 ms ) find images
    • stdout
18. ( 2 secs ) gsutil upload JSON
    • stdout
19. ( 59 secs ) corpus tests
    • stdout
20. ( 572 ms ) find images (2)
    • stdout
21. ( 2 secs ) gsutil upload JSON (2)
    • stdout
22. ( 62 ms ) reset XCode
    • stdout
23. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"vm172-m9"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.pdfium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1545209389618112, "id": "8926724235030101440", "project": "pdfium", "tags": ["builder:mac_xfa_jumbo", "buildset:commit/git/587891b979df5a7e58897aa702db48806bd90900", "buildset:commit/gitiles/pdfium.googlesource.com/pdfium/+/587891b979df5a7e58897aa702db48806bd90900", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9092154297122779152", "scheduler_job_id:pdfium/mac_xfa_jumbo", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"mac_xfa_jumbo"	setup_build
buildnumber	865	setup_build
jumbo	true	setup_build
mastername	"client.pdfium"	setup_build
path_config	"generic"	setup_build
recipe	"pdfium"	setup_build
repository	"https://pdfium.googlesource.com/pdfium.git"	setup_build
revision	"587891b979df5a7e58897aa702db48806bd90900"	setup_build
xfa	true	setup_build
got_revision	"587891b979df5a7e58897aa702db48806bd90900"	bot_update

Blamelist:

1. Lei Zhang (thestigohnoyoudont@chromium.org)

Timing:

Create	Wednesday, 19-Dec-18 08:49:49 UTC
Start	Wednesday, 19-Dec-18 08:50:00 UTC
End	Wednesday, 19-Dec-18 08:55:55 UTC
Pending	10 secs
Execution	5 mins 54 secs

All Changes:

1. Clean up CBA_FontMap.

   Changed by	Lei Zhang - thestigohnoyoudont@chromium.org
   Changed at	Wednesday, 19-Dec-18 08:49:26 UTC
   Repository	https://pdfium.googlesource.com/pdfium
   Branch
   Revision	587891b979df5a7e58897aa702db48806bd90900

   Comments

   Clean up CBA_FontMap.
   
   - Move CBA_FontMap_Foo structs into CBA_FontMap.
   - Inline a method with only 1 caller.
   - Make a public method private.
   - Remove checks for nullptr in |m_Data|. This cannot happen.
   
   Change-Id: I17b9cba2cf50a9881787bee314caad358329f60c
   Reviewed-on: https://pdfium-review.googlesource.com/c/47171
   Commit-Queue: Lei Zhang <thestig@chromium.org>
   Reviewed-by: Tom Sepez <tsepez@chromium.org>
   

   Changed files

   • fpdfsdk/formfiller/cba_fontmap.cpp
   • fpdfsdk/formfiller/cba_fontmap.h