Builder mac_xfa_jumbo
Build 810
Results:
Success
Trigger Info:
Project | pdfium |
Revision | 09163779000eea4d14f65f051fa6c8ca6976aa52 |
Got Revision | 09163779000eea4d14f65f051fa6c8ca6976aa52 |
Execution:
- Source: Task 41b74346bf8c8710
- Bot: vm169-m9
- Recipe: pdfium
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "vm169-m9" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.pdfium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544551513140836, "id": "8927414068516128928", "project": "pdfium", "tags": ["builder:mac_xfa_jumbo", "buildset:commit/git/09163779000eea4d14f65f051fa6c8ca6976aa52", "buildset:commit/gitiles/pdfium.googlesource.com/pdfium/+/09163779000eea4d14f65f051fa6c8ca6976aa52", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9092844131092187952", "scheduler_job_id:pdfium/mac_xfa_jumbo", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "mac_xfa_jumbo" | setup_build |
buildnumber | 810 | setup_build |
jumbo | true | setup_build |
mastername | "client.pdfium" | setup_build |
path_config | "generic" | setup_build |
recipe | "pdfium" | setup_build |
repository | "https://pdfium.googlesource.com/pdfium.git" | setup_build |
revision | "09163779000eea4d14f65f051fa6c8ca6976aa52" | setup_build |
xfa | true | setup_build |
got_revision | "09163779000eea4d14f65f051fa6c8ca6976aa52" | bot_update |
Blamelist:
- Tom Sepez (tsepezohnoyoudont@chromium.org)
Timing:
Create | Tuesday, 11-Dec-18 18:05:13 UTC |
Start | Tuesday, 11-Dec-18 18:05:56 UTC |
End | Tuesday, 11-Dec-18 18:15:27 UTC |
Pending | 42 secs |
Execution | 9 mins 31 secs |
All Changes:
-
Remove cxfa_node_statics.cpp.
Changed by Tom Sepez - tsepezohnoyoudont@chromium.org Changed at Tuesday, 11-Dec-18 18:04:57 UTC Repository https://pdfium.googlesource.com/pdfium Branch Revision 09163779000eea4d14f65f051fa6c8ca6976aa52 Comments
Remove cxfa_node_statics.cpp. CXFA_Node::Create belongs in cxfa_node.cpp. The other methods have nothing to do with nodes and belong in xfa_basic_data.cpp. Change-Id: I6b81b1e16dc3423f17a20d85f2d017beb2725c2c Reviewed-on: https://pdfium-review.googlesource.com/c/47010 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org>
Changed files
- fxjs/cfxjse_engine.cpp
- fxjs/cfxjse_resolveprocessor.cpp
- fxjs/xfa/cjx_model.cpp
- fxjs/xfa/cjx_node.cpp
- fxjs/xfa/cjx_object.cpp
- xfa/fxfa/parser/BUILD.gn
- xfa/fxfa/parser/cxfa_document_parser.cpp
- xfa/fxfa/parser/cxfa_node.cpp
- xfa/fxfa/parser/cxfa_node.h
- xfa/fxfa/parser/cxfa_node_statics.cpp
- xfa/fxfa/parser/cxfa_node_unittest.cpp
- xfa/fxfa/parser/cxfa_nodehelper.cpp
- xfa/fxfa/parser/xfa_basic_data.cpp
- xfa/fxfa/parser/xfa_basic_data.h
- xfa/fxfa/parser/xfa_basic_data_unittest.cpp
- xfa/fxfa/parser/xfa_utils.cpp