Builder linux64_debug Build 8922059298107708928
Results:
Failure gn gen Failure Uncaught Exception
Trigger Info:
Project | openscreen |
Revision | 10dea9f3b0435e11c21862e006fb1f68fc2d4ec8 |
Execution:
- Source: Task 42e7a56fb190dd10
- Bot: vm78-m1
- Recipe: openscreen
Steps and Logfiles:
Show:Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/buildbucket | {"build": {"builder": {"bucket": "ci", "builder": "linux64_debug", "project": "openscreen"}, "createTime": "2019-02-08T20:37:00.149580Z", "createdBy": "user:luci-scheduler@appspot.gserviceaccount.com", "id": "8922059298107708928", "infra": {"buildbucket": {"canary": true, "serviceConfigRevision": "ef156230f5cd7f8c23f689fa4dc7f92742cd904d"}, "recipe": {"cipdPackage": "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build", "name": "openscreen"}, "swarming": {"hostname": "chromium-swarm.appspot.com"}}, "input": {"gitilesCommit": {"host": "chromium.googlesource.com", "id": "10dea9f3b0435e11c21862e006fb1f68fc2d4ec8", "project": "openscreen", "ref": "refs/heads/master"}}, "tags": [{"key": "builder", "value": "linux64_debug"}, {"key": "buildset", "value": "commit/git/10dea9f3b0435e11c21862e006fb1f68fc2d4ec8"}, {"key": "buildset", "value": "commit/gitiles/chromium.googlesource.com/openscreen/+/10dea9f3b0435e11c21862e006fb1f68fc2d4ec8"}, {"key": "scheduler_invocation_id", "value": "9087489360516079328"}, {"key": "scheduler_job_id", "value": "openscreen/linux64_debug"}, {"key": "user_agent", "value": "luci-scheduler"}]}} | setup_build |
$recipe_engine/path | {"cache_dir": "/mnt/data/b/s/w/ir/cache", "temp_dir": "/mnt/data/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "vm78-m1" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.openscreen.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1549658220149580, "id": "8922059298107708928", "project": "openscreen", "tags": ["builder:linux64_debug", "buildset:commit/git/10dea9f3b0435e11c21862e006fb1f68fc2d4ec8", "buildset:commit/gitiles/chromium.googlesource.com/openscreen/+/10dea9f3b0435e11c21862e006fb1f68fc2d4ec8", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9087489360516079328", "scheduler_job_id:openscreen/linux64_debug", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "linux64_debug" | setup_build |
debug | true | setup_build |
is_asan | true | setup_build |
path_config | "generic" | setup_build |
recipe | "openscreen" | setup_build |
repository | "https://chromium.googlesource.com/openscreen.git" | setup_build |
revision | "10dea9f3b0435e11c21862e006fb1f68fc2d4ec8" | setup_build |
target_cpu | "x64" | setup_build |
Blamelist:
- Yuri Wiitala (miuohnoyoudont@chromium.org)
Timing:
Create | Friday, 08-Feb-19 20:37:00 UTC |
Start | Friday, 08-Feb-19 20:43:01 UTC |
End | Friday, 08-Feb-19 20:44:01 UTC |
Pending | 6 mins 1 secs |
Execution | 59 secs |
All Changes:
-
Refactor socket code into platform::UdpSocket class.
Changed by Yuri Wiitala - miuohnoyoudont@chromium.org Changed at Friday, 08-Feb-19 20:36:21 UTC Repository https://chromium.googlesource.com/openscreen Branch Revision 10dea9f3b0435e11c21862e006fb1f68fc2d4ec8 Comments
Refactor socket code into platform::UdpSocket class. This change creates a new class whose lifetime represents an open socket and auto-closes the socket upon destruction. It also uses unique_ptrs to force a code structure that is explicit about which client code owns a socket (and its lifetime), and improves safety by adding OSP_DCHECKs to document assumptions. Adds improved handling of transient versus permanent errors in client code. Fixed some bugs related to not checking and handling all possible return values. QUIC connection adapter code: Fixed a leak, where client sockets were never being closed. Change-Id: Ice1504c21bcf9e840e304acc61cef7c6cab02b7b Reviewed-on: https://chromium-review.googlesource.com/c/1441171 Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Changed files
- api/impl/internal_services.cc
- api/impl/internal_services.h
- api/impl/mdns_platform_service.cc
- api/impl/mdns_platform_service.h
- api/impl/mdns_responder_service.cc
- api/impl/mdns_responder_service.h
- api/impl/mdns_responder_service_unittest.cc
- api/impl/quic/quic_client.cc
- api/impl/quic/quic_connection_factory_impl.cc
- api/impl/quic/quic_connection_factory_impl.h
- api/impl/quic/quic_connection_impl.cc
- api/impl/quic/quic_connection_impl.h
- api/impl/testing/fake_mdns_platform_service_unittest.cc
- api/impl/testing/fake_mdns_responder_adapter.cc
- api/impl/testing/fake_mdns_responder_adapter.h
- api/impl/testing/fake_mdns_responder_adapter_unittest.cc
- base/error.h
- discovery/mdns/embedder_demo.cc
- discovery/mdns/mdns_responder_adapter.cc
- discovery/mdns/mdns_responder_adapter.h
- discovery/mdns/mdns_responder_adapter_impl.cc
- discovery/mdns/mdns_responder_adapter_impl.h
- discovery/mdns/mdns_responder_platform.cc
- discovery/mdns/mdns_responder_platform.h
- platform/BUILD.gn
- platform/api/error.h
- platform/api/event_waiter.h
- platform/api/logging.h
- platform/api/socket.h
- platform/base/event_loop.cc
- platform/base/event_loop.h
- platform/posix/error.cc
- platform/posix/event_waiter.cc
- platform/posix/socket.cc
- platform/posix/socket.h