NaCl Main Console Console

dschuff@chromium.org

Disable sysroot for ASan GN builds

The ASan runtime requires libstdc++, and the version on the bots is older
than the version in the sysroot, so ASan-built sel_ldr from the sysroot
won't run. For now we disable the sysroot (this matches the SCons build)
but the term fix would be to just use GN's libcxx build.

Bug: 868204
Change-Id: I72c70b65907b546e95e9d84b6451459fbe87e8ef
Reviewed-on: https://chromium-review.googlesource.com/c/1378589
Reviewed-by: Nico Weber <thakis@chromium.org>

dschuff@chromium.org

Update sysroot used by toolchain build

This should have gone along with faaebac4
TBR=thakis@chromium.org

Bug: 868204
Change-Id: I5b2297a70e950b2160ff90bf90a0002ef5f9adce
Reviewed-on: https://chromium-review.googlesource.com/c/1378506
Reviewed-by: Derek Schuff <dschuff@chromium.org>

dschuff@chromium.org

Run lastchange.py in DEPS hooks

This fixes the GN build on windows.

Bug: 868204
Change-Id: Ib99bc76ddfe61773066247b0b98103e3e4f22265
Reviewed-on: https://chromium-review.googlesource.com/c/1377832
Reviewed-by: Nico Weber <thakis@chromium.org>

dschuff@chromium.org

Update build_rev

This includes several other changes required for this, because our build_rev is so out of date:
* Update clang_rev, build_overrides_rev, buildtools_revision
* Update the sysroot install command in DEPS
* Update breakpad_rev and its build invocation
* Update gtest_rev and add a gtest BUILD.gn since it disappeared from build_overrides

Change-Id: I0836ab4026d3d1ac3e903f31f9e499d510040d0c
Reviewed-on: https://chromium-review.googlesource.com/c/1366282
Reviewed-by: Nico Weber <thakis@chromium.org>

efoo@chromium.org

Remove depreciated "cq_name" attribute

Bug:868204
Change-Id: Ifdc7d9fc57f5531d42d346ef70441601d18c07f0
Reviewed-on: https://chromium-review.googlesource.com/c/1368811
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

efoo@chromium.org

Update cq to trigger LUCI builders

Bug:868204
Change-Id: I762267d382f2c884c98cfeb3c98533632fed503b
Reviewed-on: https://chromium-review.googlesource.com/c/1369064
Reviewed-by: Derek Schuff <dschuff@chromium.org>

dschuff@chromium.org

Default to using clang in buildbot scripts

It matches Chrome's config

Change-Id: Id3047a734c71745a9156fa21ef2cee8834796488
No-Try: true
TBR=sbc,binji
Reviewed-on: https://chromium-review.googlesource.com/c/1367752
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Ben Smith <binji@chromium.org>

jchinlee@chromium.org

Move vpython dependency declaration higher.

Bug: 912379
Change-Id: Ifca0fc9f1e0c0c4d46a61326e0cc5cd68c50b262
Reviewed-on: https://chromium-review.googlesource.com/c/1366499
Reviewed-by: Derek Schuff <dschuff@chromium.org>

jchinlee@chromium.org

Surface lxml for use via vpython.

Bug: 912379
Change-Id: Iefa91707e71ce70bcf34c9f65f892d2deb381f62
Reviewed-on: https://chromium-review.googlesource.com/c/1366490
Reviewed-by: Derek Schuff <dschuff@chromium.org>

dschuff@chromium.org

PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS

This pulls in the following LLVM changes:

4ffbbb82cd1: (dschuff@chromium.org) Make LLVM's codereview.settings match NaCl's
28d173e84a2: (dschuff@chromium.org) Hack out build of lli tool from autoconf build
35fedaf8f2b: (dschuff@chromium.org) Revert "Hack out build of lli tool from autoconf build"
f106583f744: (dschuff@chromium.org) Hack out build of lli from autoconf build

TEST= PNaCl toolchain trybots

Change-Id: I27890e0442521777d308cba11f8f528531c693c1
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1361764
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Sam Clegg <sbc@chromium.org>

dschuff@chromium.org

Yet another whitespace change

Change-Id: I4e27a3e36a982f866c9cfce62674c4db1fb17b27
Reviewed-on: https://chromium-review.googlesource.com/c/1359433
Reviewed-by: Derek Schuff <dschuff@chromium.org>

efoo@chromium.org

Update commit queue for Nacl try builders

Bug:868204
Change-Id: I8389a4eaac0e30392538780f0fe7e7de1d5826b7
Reviewed-on: https://chromium-review.googlesource.com/c/1344646
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

efoo@chromium.org

Whitespage change to force a CL

TBR=hinoka@chromium.org

Change-Id: I873e2434eaf525b46ae638992ef5a0454a8565ce
Reviewed-on: https://chromium-review.googlesource.com/c/1344644
Commit-Queue: Eric Foo <efoo@chromium.org>
Reviewed-by: Eric Foo <efoo@chromium.org>

hinoka@chromium.org

Revert "Whitespace change to kick off LUCI jobs"

This reverts commit 2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f.

Reason for revert: Retry jobs

Original change's description:
> Whitespace change to kick off LUCI jobs
>
> TBR:hinoka@chromium.org
>
> Bug:868204
> Change-Id: I6f953df62c6a603628d358713bc76c7342e1ef45
> Reviewed-on: https://chromium-review.googlesource.com/1239737
> Reviewed-by: Eric Foo <efoo@chromium.org>
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>

TBR=hinoka@chromium.org,efoo@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 868204
Change-Id: I6795b0f87455990ab2b50333a677381635d080a1
Reviewed-on: https://chromium-review.googlesource.com/c/1285311
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

efoo@chromium.org

Whitespace change to kick off LUCI jobs

TBR:hinoka@chromium.org

Bug:868204
Change-Id: I6f953df62c6a603628d358713bc76c7342e1ef45
Reviewed-on: https://chromium-review.googlesource.com/1239737
Reviewed-by: Eric Foo <efoo@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

iannucci@chromium.org

Whitespace to trigger additional builds.

TBR=efoo@chromium.org

Bug: 861512
Change-Id: I1cea6c85a3d1afbe0f926d722a98d4a8722dda92
Reviewed-on: https://chromium-review.googlesource.com/1237322
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

martiniss@chromium.org

Whitespace change to kick off jobs

TBR=hinoka
NOTRY=true

Bug: 646142
Change-Id: Id8580221a06b48911b44d70b4e81280447ff3c65
Reviewed-on: https://chromium-review.googlesource.com/1237043
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

efoo@chromium.org

Whitespace change to kick off jobs

TBR:hinoka@chromium.org

Bug:868204
Change-Id: I4df201d74feaab3bdddc06fcf1cdafc326f0b32d
Reviewed-on: https://chromium-review.googlesource.com/1228260
Reviewed-by: Eric Foo <efoo@chromium.org>

hinoka@chromium.org

Reland "Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""""

This reverts commit 5604391f597d84ef7065eb99432fcc09cdcf7d34.

Reason for revert: New console

Original change's description:
> Revert "Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""""
>
> This reverts commit 385a05c3d606ae044fd4b35309af5765bf5150dd.
>
> Reason for revert: Fixed mastername
>
> Original change's description:
> > Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""
> >
> > This reverts commit cb6ec4b1f91af259cbdfd1bd22bb98ed5551955e.
> >
> > Reason for revert: Fixed triggering, try again.
> >
> > Original change's description:
> > > Revert "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""
> > >
> > > This reverts commit a87b168e08d3b69241b7f185e5ee3c96ed8bf478.
> > >
> > > Reason for revert: Re-trigger for toolchains
> > >
> > > Original change's description:
> > > > Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
> > > >
> > > > This reverts commit fa95e2a7489d9efe3f8dd770c204b4d968eb9b02.
> > > >
> > > > Reason for revert: Trigger luci
> > > >
> > > > Original change's description:
> > > > > Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
> > > > >
> > > > > This reverts commit aebc9e5205dcaad5d5954a18abc532316a954644.
> > > > >
> > > > > Original change's description:
> > > > > > Reland "Trigger a buildbot cycle on client.nacl.toolchain"
> > > > > >
> > > > > > This reverts commit e6ce828ef60c4c1438867b535efbbb5d9a177c0e.
> > > > > >
> > > > > > Reason for revert: The next thing has been fixed on bug 863140, so trigger another buildbot cycle.
> > > > > >
> > > > > > Original change's description:
> > > > > > > Revert "Trigger a buildbot cycle on client.nacl.toolchain"
> > > > > > >
> > > > > > > This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
> > > > > > >
> > > > > > > Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
> > > > > > >
> > > > > > > Original change's description:
> > > > > > > > Trigger a buildbot cycle on client.nacl.toolchain
> > > > > > > >
> > > > > > > > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
> > > > > > > > [1]. The logs have since been deleted, so trigger another build so we can
> > > > > > > > review the failures in the logs.
> > > > > > > >
> > > > > > > > [1] https://build.chromium.org/p/client.nacl.toolchain/console
> > > > > > > >
> > > > > > > > BUG=None
> > > > > > > > TBR=thakis
> > > > > > > > NOTRY=true
> > > > > > > > NOPRESUBMIT=true
> > > > > > > >
> > > > > > > > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
> > > > > > > > Reviewed-on: https://chromium-review.googlesource.com/1132561
> > > > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > > > > >
> > > > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > > > > > >
> > > > > > > Change-Id: I629856581810be12abba20ecbedc95754c6fe325
> > > > > > > No-Presubmit: true
> > > > > > > No-Tree-Checks: true
> > > > > > > No-Try: true
> > > > > > > Bug: None
> > > > > > > Reviewed-on: https://chromium-review.googlesource.com/1134366
> > > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > > > >
> > > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > > > > > NOTRY=true
> > > > > >
> > > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > > > >
> > > > > > Bug: None
> > > > > > Change-Id: Ie71f8351bb500fd1e6d3f6443dff05be1a529004
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/1139534
> > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > > >
> > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > > > >
> > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > > >
> > > > > NOTRY=true
> > > > > NOPRESUBMIT=true
> > > > > NOTREECHECKS=true
> > > > > Bug: None
> > > > > Change-Id: I9bd8fcb9d5dd19cfc5f704cf8adadd1a6337dd1d
> > > > > Reviewed-on: https://chromium-review.googlesource.com/1148840
> > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > >
> > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > > >
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > >
> > > > Bug: None
> > > > Change-Id: I7d84621f9163049137b6e1a7ce64b1f226bf08a6
> > > > Reviewed-on: https://chromium-review.googlesource.com/1159727
> > > > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> > >
> > > TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: None
> > > Change-Id: I507c99da5fe25d0f8a1bb8b87b360ec594e6e423
> > > Reviewed-on: https://chromium-review.googlesource.com/1199969
> > > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> >
> > TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: None
> > Change-Id: Ia25f0d747016a0f79bf46fda663906db71c8a583
> > Reviewed-on: https://chromium-review.googlesource.com/1217763
> > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
>
> TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
>
> Change-Id: Ice9ba32760b934a1194b41e280918518778e21d0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: None
> Reviewed-on: https://chromium-review.googlesource.com/1217487
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Commit-Queue: Ryan Tseng <hinoka@chromium.org>

TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I2e6eb4177ed91e1d6a6584df54f897aa773faf91
Reviewed-on: https://chromium-review.googlesource.com/1222234
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

hinoka@chromium.org

Revert "Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""""

This reverts commit 385a05c3d606ae044fd4b35309af5765bf5150dd.

Reason for revert: Fixed mastername

Original change's description:
> Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""
>
> This reverts commit cb6ec4b1f91af259cbdfd1bd22bb98ed5551955e.
>
> Reason for revert: Fixed triggering, try again.
>
> Original change's description:
> > Revert "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""
> >
> > This reverts commit a87b168e08d3b69241b7f185e5ee3c96ed8bf478.
> >
> > Reason for revert: Re-trigger for toolchains
> >
> > Original change's description:
> > > Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
> > >
> > > This reverts commit fa95e2a7489d9efe3f8dd770c204b4d968eb9b02.
> > >
> > > Reason for revert: Trigger luci
> > >
> > > Original change's description:
> > > > Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
> > > >
> > > > This reverts commit aebc9e5205dcaad5d5954a18abc532316a954644.
> > > >
> > > > Original change's description:
> > > > > Reland "Trigger a buildbot cycle on client.nacl.toolchain"
> > > > >
> > > > > This reverts commit e6ce828ef60c4c1438867b535efbbb5d9a177c0e.
> > > > >
> > > > > Reason for revert: The next thing has been fixed on bug 863140, so trigger another buildbot cycle.
> > > > >
> > > > > Original change's description:
> > > > > > Revert "Trigger a buildbot cycle on client.nacl.toolchain"
> > > > > >
> > > > > > This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
> > > > > >
> > > > > > Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
> > > > > >
> > > > > > Original change's description:
> > > > > > > Trigger a buildbot cycle on client.nacl.toolchain
> > > > > > >
> > > > > > > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
> > > > > > > [1]. The logs have since been deleted, so trigger another build so we can
> > > > > > > review the failures in the logs.
> > > > > > >
> > > > > > > [1] https://build.chromium.org/p/client.nacl.toolchain/console
> > > > > > >
> > > > > > > BUG=None
> > > > > > > TBR=thakis
> > > > > > > NOTRY=true
> > > > > > > NOPRESUBMIT=true
> > > > > > >
> > > > > > > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
> > > > > > > Reviewed-on: https://chromium-review.googlesource.com/1132561
> > > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > > > >
> > > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > > > > >
> > > > > > Change-Id: I629856581810be12abba20ecbedc95754c6fe325
> > > > > > No-Presubmit: true
> > > > > > No-Tree-Checks: true
> > > > > > No-Try: true
> > > > > > Bug: None
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/1134366
> > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > > >
> > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > > > > NOTRY=true
> > > > >
> > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > > >
> > > > > Bug: None
> > > > > Change-Id: Ie71f8351bb500fd1e6d3f6443dff05be1a529004
> > > > > Reviewed-on: https://chromium-review.googlesource.com/1139534
> > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > >
> > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > > >
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > >
> > > > NOTRY=true
> > > > NOPRESUBMIT=true
> > > > NOTREECHECKS=true
> > > > Bug: None
> > > > Change-Id: I9bd8fcb9d5dd19cfc5f704cf8adadd1a6337dd1d
> > > > Reviewed-on: https://chromium-review.googlesource.com/1148840
> > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > >
> > > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: None
> > > Change-Id: I7d84621f9163049137b6e1a7ce64b1f226bf08a6
> > > Reviewed-on: https://chromium-review.googlesource.com/1159727
> > > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> >
> > TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: None
> > Change-Id: I507c99da5fe25d0f8a1bb8b87b360ec594e6e423
> > Reviewed-on: https://chromium-review.googlesource.com/1199969
> > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
>
> TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: None
> Change-Id: Ia25f0d747016a0f79bf46fda663906db71c8a583
> Reviewed-on: https://chromium-review.googlesource.com/1217763
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>

TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org

Change-Id: Ice9ba32760b934a1194b41e280918518778e21d0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/1217487
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

hinoka@chromium.org

Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""

This reverts commit cb6ec4b1f91af259cbdfd1bd22bb98ed5551955e.

Reason for revert: Fixed triggering, try again.

Original change's description:
> Revert "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""
>
> This reverts commit a87b168e08d3b69241b7f185e5ee3c96ed8bf478.
>
> Reason for revert: Re-trigger for toolchains
>
> Original change's description:
> > Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
> >
> > This reverts commit fa95e2a7489d9efe3f8dd770c204b4d968eb9b02.
> >
> > Reason for revert: Trigger luci
> >
> > Original change's description:
> > > Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
> > >
> > > This reverts commit aebc9e5205dcaad5d5954a18abc532316a954644.
> > >
> > > Original change's description:
> > > > Reland "Trigger a buildbot cycle on client.nacl.toolchain"
> > > >
> > > > This reverts commit e6ce828ef60c4c1438867b535efbbb5d9a177c0e.
> > > >
> > > > Reason for revert: The next thing has been fixed on bug 863140, so trigger another buildbot cycle.
> > > >
> > > > Original change's description:
> > > > > Revert "Trigger a buildbot cycle on client.nacl.toolchain"
> > > > >
> > > > > This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
> > > > >
> > > > > Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
> > > > >
> > > > > Original change's description:
> > > > > > Trigger a buildbot cycle on client.nacl.toolchain
> > > > > >
> > > > > > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
> > > > > > [1]. The logs have since been deleted, so trigger another build so we can
> > > > > > review the failures in the logs.
> > > > > >
> > > > > > [1] https://build.chromium.org/p/client.nacl.toolchain/console
> > > > > >
> > > > > > BUG=None
> > > > > > TBR=thakis
> > > > > > NOTRY=true
> > > > > > NOPRESUBMIT=true
> > > > > >
> > > > > > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/1132561
> > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > > >
> > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > > > >
> > > > > Change-Id: I629856581810be12abba20ecbedc95754c6fe325
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Bug: None
> > > > > Reviewed-on: https://chromium-review.googlesource.com/1134366
> > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > >
> > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > > > NOTRY=true
> > > >
> > > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > > >
> > > > Bug: None
> > > > Change-Id: Ie71f8351bb500fd1e6d3f6443dff05be1a529004
> > > > Reviewed-on: https://chromium-review.googlesource.com/1139534
> > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > >
> > > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > NOTRY=true
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > Bug: None
> > > Change-Id: I9bd8fcb9d5dd19cfc5f704cf8adadd1a6337dd1d
> > > Reviewed-on: https://chromium-review.googlesource.com/1148840
> > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> >
> > TBR=thakis@chromium.org,thomasanderson@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: None
> > Change-Id: I7d84621f9163049137b6e1a7ce64b1f226bf08a6
> > Reviewed-on: https://chromium-review.googlesource.com/1159727
> > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
>
> TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: None
> Change-Id: I507c99da5fe25d0f8a1bb8b87b360ec594e6e423
> Reviewed-on: https://chromium-review.googlesource.com/1199969
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>

TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: Ia25f0d747016a0f79bf46fda663906db71c8a583
Reviewed-on: https://chromium-review.googlesource.com/1217763
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

hinoka@chromium.org

Revert "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""

This reverts commit a87b168e08d3b69241b7f185e5ee3c96ed8bf478.

Reason for revert: Re-trigger for toolchains

Original change's description:
> Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
>
> This reverts commit fa95e2a7489d9efe3f8dd770c204b4d968eb9b02.
>
> Reason for revert: Trigger luci
>
> Original change's description:
> > Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
> >
> > This reverts commit aebc9e5205dcaad5d5954a18abc532316a954644.
> >
> > Original change's description:
> > > Reland "Trigger a buildbot cycle on client.nacl.toolchain"
> > >
> > > This reverts commit e6ce828ef60c4c1438867b535efbbb5d9a177c0e.
> > >
> > > Reason for revert: The next thing has been fixed on bug 863140, so trigger another buildbot cycle.
> > >
> > > Original change's description:
> > > > Revert "Trigger a buildbot cycle on client.nacl.toolchain"
> > > >
> > > > This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
> > > >
> > > > Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
> > > >
> > > > Original change's description:
> > > > > Trigger a buildbot cycle on client.nacl.toolchain
> > > > >
> > > > > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
> > > > > [1]. The logs have since been deleted, so trigger another build so we can
> > > > > review the failures in the logs.
> > > > >
> > > > > [1] https://build.chromium.org/p/client.nacl.toolchain/console
> > > > >
> > > > > BUG=None
> > > > > TBR=thakis
> > > > > NOTRY=true
> > > > > NOPRESUBMIT=true
> > > > >
> > > > > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
> > > > > Reviewed-on: https://chromium-review.googlesource.com/1132561
> > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > >
> > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > > >
> > > > Change-Id: I629856581810be12abba20ecbedc95754c6fe325
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Bug: None
> > > > Reviewed-on: https://chromium-review.googlesource.com/1134366
> > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > >
> > > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > > NOTRY=true
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Bug: None
> > > Change-Id: Ie71f8351bb500fd1e6d3f6443dff05be1a529004
> > > Reviewed-on: https://chromium-review.googlesource.com/1139534
> > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> >
> > TBR=thakis@chromium.org,thomasanderson@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > NOTRY=true
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > Bug: None
> > Change-Id: I9bd8fcb9d5dd19cfc5f704cf8adadd1a6337dd1d
> > Reviewed-on: https://chromium-review.googlesource.com/1148840
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
>
> TBR=thakis@chromium.org,thomasanderson@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: None
> Change-Id: I7d84621f9163049137b6e1a7ce64b1f226bf08a6
> Reviewed-on: https://chromium-review.googlesource.com/1159727
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>

TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I507c99da5fe25d0f8a1bb8b87b360ec594e6e423
Reviewed-on: https://chromium-review.googlesource.com/1199969
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

dschuff@chromium.org

Make posix code compile with -Wimplicit-fallthrough

This is the default on GCC 7+.
When falling through switch cases it requires a comment matching a particular
regex indicating the fallthrough.
See https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html

Bug: 868204
No-Try: true
Change-Id: I66f39a113dc43ce72c5effd6c3c59c6581217b74
Reviewed-on: https://chromium-review.googlesource.com/1197703
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Petar Jovanovic <petarj@mips.com>
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>

petar.jovanovic@rt-rk.com

[mips] Fix build with newer GCC and -std=c11

Changes instances of asm() to __asm__().

It also removes the following warning:

- warning: used $at (currently $1) without ".set noat"

No-Try: true
Change-Id: I20a40481a4c53f23872bc2ecad5ddde64c95e350
Reviewed-on: https://chromium-review.googlesource.com/1186727
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>

dschuff@chromium.org

Don't run the performance tests in the emulator

Existing logic tries to also disable the perf tests in VMs based on the
slave name anyway, but that logic doesn't work on LUCI.

Bug: 868204
No-Try: true
TBR: bradnelson@chromium.org, sbc@chromium.org
Change-Id: I572ce7a4e21a3806e0b9a66dd047638b35f9b915
Reviewed-on: https://chromium-review.googlesource.com/1180098
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Derek Schuff <dschuff@chromium.org>

dschuff@chromium.org

Update more uses of gsutil for new bot config

Bug: 868204
No-Try: true
TBR: bradnelson@chromium.org, sbc@chromium.org
Change-Id: If95d0ac908da7c98673aef3a9ea75a0a370ed520
Reviewed-on: https://chromium-review.googlesource.com/1179967
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Derek Schuff <dschuff@chromium.org>

dschuff@chromium.org

Use gsutil from PATH instead of assuming its location

This makes the Spec2k bots correctly able to download the source bundle.

No-Try: true
R: bradnelson@chromium.org
Change-Id: I4ace3a85d1a4a3bb7893ed22b836d9e4402678d1
Reviewed-on: https://chromium-review.googlesource.com/1179266
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>

dschuff@chromium.org

Only run 64 bit builds on mac

NaCl hasn't shipped on 32 bit mac in a long time, and all the builders with the
new SDK actually build 64 even when you ask for 32. So update explicit builder
configs and update the "default" arch (used when the buildbot name doesn't
specify 64 or 32; it turns out macs are the only builders that do this).

Bug: 868204
Change-Id: I9ea9f268c826a9afe35cf1a901006ea0a8431e67
No-Try: true
R: bradnelson@chromium.org, sbc@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1178421
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Derek Schuff <dschuff@chromium.org>

dschuff@chromium.org

Remove perf_test_compat_osx

It implements clock_gettime, but that function has been added to the MacOS SDK, so it's no longer necessary.

Bug: 868204
No-Try: true
R: bradnelson@chromium.org, sbc@chromium.org
Test: run_trusted_performance_test
Change-Id: Id81ba50bcb8daa54e5460288f2e81674955e8afc
Reviewed-on: https://chromium-review.googlesource.com/1176827
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>

dschuff@chromium.org

Don't run builds through runtest.py

Bug:868204
No-Try: true
TBR: hinoka
Change-Id: Ie6f059d641d8c8d292c3e90616ce76ea27b8cbba
Reviewed-on: https://chromium-review.googlesource.com/1166453
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>

hinoka@google.com

[vpyhon] Add pywin32

Bug: 868204
No-Try: true
TBR: dschuff
Change-Id: I43bc18cfa7bdffb8593b9d2e7a1c7a0786196fb8
Reviewed-on: https://chromium-review.googlesource.com/1167995
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

hinoka@chromium.org

Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""

This reverts commit fa95e2a7489d9efe3f8dd770c204b4d968eb9b02.

Reason for revert: Trigger luci

Original change's description:
> Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
>
> This reverts commit aebc9e5205dcaad5d5954a18abc532316a954644.
>
> Original change's description:
> > Reland "Trigger a buildbot cycle on client.nacl.toolchain"
> >
> > This reverts commit e6ce828ef60c4c1438867b535efbbb5d9a177c0e.
> >
> > Reason for revert: The next thing has been fixed on bug 863140, so trigger another buildbot cycle.
> >
> > Original change's description:
> > > Revert "Trigger a buildbot cycle on client.nacl.toolchain"
> > >
> > > This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
> > >
> > > Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
> > >
> > > Original change's description:
> > > > Trigger a buildbot cycle on client.nacl.toolchain
> > > >
> > > > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
> > > > [1]. The logs have since been deleted, so trigger another build so we can
> > > > review the failures in the logs.
> > > >
> > > > [1] https://build.chromium.org/p/client.nacl.toolchain/console
> > > >
> > > > BUG=None
> > > > TBR=thakis
> > > > NOTRY=true
> > > > NOPRESUBMIT=true
> > > >
> > > > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
> > > > Reviewed-on: https://chromium-review.googlesource.com/1132561
> > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > >
> > > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > >
> > > Change-Id: I629856581810be12abba20ecbedc95754c6fe325
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: None
> > > Reviewed-on: https://chromium-review.googlesource.com/1134366
> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> >
> > TBR=thakis@chromium.org,thomasanderson@chromium.org
> > NOTRY=true
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: None
> > Change-Id: Ie71f8351bb500fd1e6d3f6443dff05be1a529004
> > Reviewed-on: https://chromium-review.googlesource.com/1139534
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
>
> TBR=thakis@chromium.org,thomasanderson@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> NOTRY=true
> NOPRESUBMIT=true
> NOTREECHECKS=true
> Bug: None
> Change-Id: I9bd8fcb9d5dd19cfc5f704cf8adadd1a6337dd1d
> Reviewed-on: https://chromium-review.googlesource.com/1148840
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>

TBR=thakis@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I7d84621f9163049137b6e1a7ce64b1f226bf08a6
Reviewed-on: https://chromium-review.googlesource.com/1159727
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

thomasanderson@chromium.org

Fix arm build with -std=c11

Changes instances of asm() to __asm__().

BUG=427584
R=thakis
NOTRY=true
NOPRESUBMIT=true

Change-Id: I3ea0597fbaa6ebdea792e11f049a216d2908ed9c
Reviewed-on: https://chromium-review.googlesource.com/1164412
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>

hinoka@google.com

Don't runhooks in annotated run

This is already done at the recipe level.

Bug: 868204
Change-Id: I9a7c8a9a806043bf707dde649d90a8c03cffc276
Reviewed-on: https://chromium-review.googlesource.com/1161297
Reviewed-by: Derek Schuff <dschuff@chromium.org>

hinoka@google.com

Add .vpython file with httpplib2

So that LUCI jobs can use python with the needed packages.

Bug: 868204
Change-Id: I8e4bd89a8a6fcb3db8994bcef30f5c2a92ba7d01
Reviewed-on: https://chromium-review.googlesource.com/1161289
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

hinoka@chromium.org

Revert "Reland "Whitespace change to kick off luci jobs""

This reverts commit 4942f9f51a0f2bad8681e5d1d26ff3ccc6e9d647.

Reason for revert: Kick off again

Original change's description:
> Reland "Whitespace change to kick off luci jobs"
>
> This reverts commit 77e8a21d75e27de0d9fa04f52912cf7c74b3e867.
>
> Reason for revert: Kickoff again
>
> Original change's description:
> > Revert "Whitespace change to kick off luci jobs"
> >
> > This reverts commit 0a6e2d0dcbc5640d2228e335b20e7c376f5b0136.
> >
> > Reason for revert: Kick off again
> >
> > Original change's description:
> > > Whitespace change to kick off luci jobs
> > >
> > > Bug: 868204
> > > TBR: dschuff
> > > Change-Id: I948fc9918b8192e1042492fe1a4790fbdcb724ae
> > > Reviewed-on: https://chromium-review.googlesource.com/1161054
> > > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> >
> > TBR=dschuff@chromium.org,hinoka@chromium.org
> >
> > Change-Id: I4e6185fb6f521e420ffecca31e42cc646c659e29
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 868204
> > Reviewed-on: https://chromium-review.googlesource.com/1161125
> > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> > Commit-Queue: Ryan Tseng <hinoka@chromium.org>
>
> TBR=dschuff@chromium.org,hinoka@chromium.org
>
> Change-Id: I8fff87643d3fb18e640467e9c5e451df11c7553b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 868204
> Reviewed-on: https://chromium-review.googlesource.com/1161126
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Commit-Queue: Ryan Tseng <hinoka@chromium.org>

TBR=dschuff@chromium.org,hinoka@chromium.org

Change-Id: Id9cb1311b5a388b045471ef81ff7a0fa271b12d0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868204
Reviewed-on: https://chromium-review.googlesource.com/1161127
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

hinoka@chromium.org

Reland "Whitespace change to kick off luci jobs"

This reverts commit 77e8a21d75e27de0d9fa04f52912cf7c74b3e867.

Reason for revert: Kickoff again

Original change's description:
> Revert "Whitespace change to kick off luci jobs"
>
> This reverts commit 0a6e2d0dcbc5640d2228e335b20e7c376f5b0136.
>
> Reason for revert: Kick off again
>
> Original change's description:
> > Whitespace change to kick off luci jobs
> >
> > Bug: 868204
> > TBR: dschuff
> > Change-Id: I948fc9918b8192e1042492fe1a4790fbdcb724ae
> > Reviewed-on: https://chromium-review.googlesource.com/1161054
> > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
>
> TBR=dschuff@chromium.org,hinoka@chromium.org
>
> Change-Id: I4e6185fb6f521e420ffecca31e42cc646c659e29
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 868204
> Reviewed-on: https://chromium-review.googlesource.com/1161125
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Commit-Queue: Ryan Tseng <hinoka@chromium.org>

TBR=dschuff@chromium.org,hinoka@chromium.org

Change-Id: I8fff87643d3fb18e640467e9c5e451df11c7553b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868204
Reviewed-on: https://chromium-review.googlesource.com/1161126
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

hinoka@chromium.org

Revert "Whitespace change to kick off luci jobs"

This reverts commit 0a6e2d0dcbc5640d2228e335b20e7c376f5b0136.

Reason for revert: Kick off again

Original change's description:
> Whitespace change to kick off luci jobs
>
> Bug: 868204
> TBR: dschuff
> Change-Id: I948fc9918b8192e1042492fe1a4790fbdcb724ae
> Reviewed-on: https://chromium-review.googlesource.com/1161054
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>

TBR=dschuff@chromium.org,hinoka@chromium.org

Change-Id: I4e6185fb6f521e420ffecca31e42cc646c659e29
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 868204
Reviewed-on: https://chromium-review.googlesource.com/1161125
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

hinoka@google.com

Whitespace change to kick off luci jobs

Bug: 868204
TBR: dschuff
Change-Id: I948fc9918b8192e1042492fe1a4790fbdcb724ae
Reviewed-on: https://chromium-review.googlesource.com/1161054
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

thomasanderson@chromium.org

Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain""

This reverts commit aebc9e5205dcaad5d5954a18abc532316a954644.

Original change's description:
> Reland "Trigger a buildbot cycle on client.nacl.toolchain"
>
> This reverts commit e6ce828ef60c4c1438867b535efbbb5d9a177c0e.
>
> Reason for revert: The next thing has been fixed on bug 863140, so trigger another buildbot cycle.
>
> Original change's description:
> > Revert "Trigger a buildbot cycle on client.nacl.toolchain"
> >
> > This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
> >
> > Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
> >
> > Original change's description:
> > > Trigger a buildbot cycle on client.nacl.toolchain
> > >
> > > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
> > > [1]. The logs have since been deleted, so trigger another build so we can
> > > review the failures in the logs.
> > >
> > > [1] https://build.chromium.org/p/client.nacl.toolchain/console
> > >
> > > BUG=None
> > > TBR=thakis
> > > NOTRY=true
> > > NOPRESUBMIT=true
> > >
> > > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
> > > Reviewed-on: https://chromium-review.googlesource.com/1132561
> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> >
> > TBR=thakis@chromium.org,thomasanderson@chromium.org
> >
> > Change-Id: I629856581810be12abba20ecbedc95754c6fe325
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: None
> > Reviewed-on: https://chromium-review.googlesource.com/1134366
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
>
> TBR=thakis@chromium.org,thomasanderson@chromium.org
> NOTRY=true
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: None
> Change-Id: Ie71f8351bb500fd1e6d3f6443dff05be1a529004
> Reviewed-on: https://chromium-review.googlesource.com/1139534
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>

TBR=thakis@chromium.org,thomasanderson@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: None
Change-Id: I9bd8fcb9d5dd19cfc5f704cf8adadd1a6337dd1d
Reviewed-on: https://chromium-review.googlesource.com/1148840
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>

thomasanderson@chromium.org

Reland "Trigger a buildbot cycle on client.nacl.toolchain"

This reverts commit e6ce828ef60c4c1438867b535efbbb5d9a177c0e.

Reason for revert: The next thing has been fixed on bug 863140, so trigger another buildbot cycle.

Original change's description:
> Revert "Trigger a buildbot cycle on client.nacl.toolchain"
>
> This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
>
> Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
>
> Original change's description:
> > Trigger a buildbot cycle on client.nacl.toolchain
> >
> > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
> > [1]. The logs have since been deleted, so trigger another build so we can
> > review the failures in the logs.
> >
> > [1] https://build.chromium.org/p/client.nacl.toolchain/console
> >
> > BUG=None
> > TBR=thakis
> > NOTRY=true
> > NOPRESUBMIT=true
> >
> > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
> > Reviewed-on: https://chromium-review.googlesource.com/1132561
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
>
> TBR=thakis@chromium.org,thomasanderson@chromium.org
>
> Change-Id: I629856581810be12abba20ecbedc95754c6fe325
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: None
> Reviewed-on: https://chromium-review.googlesource.com/1134366
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

TBR=thakis@chromium.org,thomasanderson@chromium.org
NOTRY=true

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: Ie71f8351bb500fd1e6d3f6443dff05be1a529004
Reviewed-on: https://chromium-review.googlesource.com/1139534
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>

thomasanderson@chromium.org

Revert "Trigger a buildbot cycle on client.nacl.toolchain"

This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.

Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue

Original change's description:
> Trigger a buildbot cycle on client.nacl.toolchain
>
> The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
> [1]. The logs have since been deleted, so trigger another build so we can
> review the failures in the logs.
>
> [1] https://build.chromium.org/p/client.nacl.toolchain/console
>
> BUG=None
> TBR=thakis
> NOTRY=true
> NOPRESUBMIT=true
>
> Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
> Reviewed-on: https://chromium-review.googlesource.com/1132561
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

TBR=thakis@chromium.org,thomasanderson@chromium.org

Change-Id: I629856581810be12abba20ecbedc95754c6fe325
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/1134366
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

thomasanderson@chromium.org

Trigger a buildbot cycle on client.nacl.toolchain

The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
[1]. The logs have since been deleted, so trigger another build so we can
review the failures in the logs.

[1] https://build.chromium.org/p/client.nacl.toolchain/console

BUG=None
TBR=thakis
NOTRY=true
NOPRESUBMIT=true

Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
Reviewed-on: https://chromium-review.googlesource.com/1132561
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

tandrii@chromium.org

cq: remove SignCLA check. Gerrit now enforces up pre-CL-upload.

Gerrit SignCLA check was enabled in
https://chromium.googlesource.com/native_client/src/native_client/+/a45590d5c7daa91f882c2212b9004a8ac5d19bc2

R=mseaborn@chromium.org,thomasanderson@chromium.org
TBR=sergiyb@chromium.org

No-Try: True
Bug: 796383
Change-Id: Ie66b885b8f4f326716a16492238a97a409b48741
Reviewed-on: https://chromium-review.googlesource.com/1096429
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>

thomasanderson@chromium.org

Remove manual references to exe_and_shlib_deps

After [1], a manual dependency on exe_and_shlib_deps is no longer necessary
since it's automatically added. This CL removes all remaining manual references
to exe_and_shlib_deps.

[1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5

BUG=chromium:845700
No-Try: True
Change-Id: I8bfa37f5efbc0824c458532ee4f4c648df56b362
Reviewed-on: https://chromium-review.googlesource.com/1087532
Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>

thomasanderson@chromium.org

Fix arm build with glibc 2.27

On earlier versions of glibc, struct sigcontext was typedef'ed to mcontext_t.
Now, it's an entirely separate struct. Fortunately, the members are all the
same, so a simple name change is all that's necessary.

This CL should be compatible with glibc 2.27 as well as earlier versions.

BUG=chromium:843240
No-Try: True
Change-Id: I30c3d5ad2a1da50f03308a4b273a2f824f966042
Reviewed-on: https://chromium-review.googlesource.com/1060158
Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>

hans@chromium.org

nacl_switch_32.S: Add comment about alignment on Windows

We spent some time in "how does this ever work" mode while tracking down
NaCl test failures in builds linked with lld, which failed to apply the
16-byte alignment to sections without explicit alignment.

Bug: 837667
No-Try: True
Change-Id: I11698a33802e5096d1f69e389734df414e341f95
Reviewed-on: https://chromium-review.googlesource.com/1046652
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Roland McGrath <mcgrathr@chromium.org>

rdevlin.cronin@chromium.org

[Native Client] Update chrome extension test

The extension in the chrome_extension test is using manifest v1, which
has been deprecated for more than five years. Update it to manifest v2.

NOTRY=true

Bug:chromium:816679
Change-Id: Ibab520e118db12cb084bd613584bcf7a387a57bf
Reviewed-on: https://chromium-review.googlesource.com/988139
Commit-Queue: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>

andybons@chromium.org

x86-64 Linux: don't update segment registers using the sig_ctx

In some cases, the linux kernel considers the values set in
mctx->gregs[REG_CSGSFS] to be invalid, preventing it from
resuming execution of the process after the rt_sigreturn syscall
and sending the process a SIGSEGV with an SI_KERNEL code.

Some NaCl tests are failing on Mac and arm-hw-perf trybots,
so committing with "No-Try: True".

R=mseaborn@chromium.org
BUG=https://crbug.com/nativeclient/4403

No-Try: True
Change-Id: I59726a7e8e7d898171a452433484a0502f93f647
Reviewed-on: https://chromium-review.googlesource.com/962675
Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>

bratell@opera.com

Fixing a broken include guard

Found when working on a PRESUBMIT check for include guards.

Some NaCl tests are failing on Mac trybots, so committing with "No-Try: True".

No-Try: True
Change-Id: I387f1327fd4ed10925cd3b3368efb81537ff5f21
Reviewed-on: https://chromium-review.googlesource.com/932663
Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
Reviewed-by: Mark Seaborn <mseaborn@chromium.org>