Home | Search | nacl - Builders
Login

Builder oneiric_32-newlib-arm_hw-pnacl-panda-opt Build 30 Canonical Ubuntu

Results:

Experimental Failure Uncaught Exception

Trigger Info:

Projectnacl
Revision8e13fe5e85640b063aefcb88a3ccb52abf6e28e8
Got Revision8e13fe5e85640b063aefcb88a3ccb52abf6e28e8

Execution:

Steps and Logfiles:

Show:
  1. ( 107 ms ) setup_build
    running recipe: "nacl"
  2. ( 2 secs ) bot_update
    [65GB/344GB used (18%)]
  3. ( 1 mins 23 secs ) gclient runhooks
  4. ( 1 ms ) Uncaught Exception
    Uncaught Exception: KeyError('parent_buildername',)

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/mnt/data/b/s/w/ir/cache", "temp_dir": "/mnt/data/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": true, "is_luci": true} setup_build
bot_id "vm316-m1" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.nacl.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544146664933041, "id": "8927838582629458752", "project": "nacl", "tags": ["builder:oneiric_32-newlib-arm_hw-pnacl-panda-opt", "buildset:commit/git/8e13fe5e85640b063aefcb88a3ccb52abf6e28e8", "buildset:commit/gitiles/chromium.googlesource.com/native_client/src/native_client/+/8e13fe5e85640b063aefcb88a3ccb52abf6e28e8", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093268646231918592", "scheduler_job_id:nacl/oneiric_32-newlib-arm_hw-pnacl-panda-opt", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "oneiric_32-newlib-arm_hw-pnacl-panda-opt" setup_build
buildnumber 30 setup_build
mastername "client.nacl" setup_build
path_config "generic" setup_build
recipe "nacl" setup_build
repository "https://chromium.googlesource.com/native_client/src/native_client.git" setup_build
revision "8e13fe5e85640b063aefcb88a3ccb52abf6e28e8" setup_build
slavetype "BuilderTester" setup_build
got_revision "8e13fe5e85640b063aefcb88a3ccb52abf6e28e8" bot_update

Blamelist:

  1. Jao-ke Chin-Lee (jchinleeohnoyoudont@chromium.org)
  2. Derek Schuff (dschuffohnoyoudont@chromium.org)
  3. Derek Schuff (dschuffohnoyoudont@chromium.org)
  4. Eric Foo (efooohnoyoudont@chromium.org)
  5. Eric Foo (efooohnoyoudont@chromium.org)
  6. Ryan Tseng (hinokaohnoyoudont@chromium.org)
  7. Eric Foo (efooohnoyoudont@chromium.org)
  8. Robert Iannucci (iannucciohnoyoudont@chromium.org)
  9. Stephen Martinis (martinissohnoyoudont@chromium.org)
  10. Eric Foo (efooohnoyoudont@chromium.org)
  11. Ryan Tseng (hinokaohnoyoudont@chromium.org)
  12. Ryan Tseng (hinokaohnoyoudont@chromium.org)
  13. Ryan Tseng (hinokaohnoyoudont@chromium.org)
  14. Ryan Tseng (hinokaohnoyoudont@chromium.org)
  15. Derek Schuff (dschuffohnoyoudont@chromium.org)
  16. Petar Jovanovic (petar.jovanovicohnoyoudont@rt-rk.com)
  17. Derek Schuff (dschuffohnoyoudont@chromium.org)
  18. Derek Schuff (dschuffohnoyoudont@chromium.org)
  19. Derek Schuff (dschuffohnoyoudont@chromium.org)
  20. Derek Schuff (dschuffohnoyoudont@chromium.org)
  21. Derek Schuff (dschuffohnoyoudont@chromium.org)
  22. Derek Schuff (dschuffohnoyoudont@chromium.org)
  23. Ryan Tseng (hinokaohnoyoudont@google.com)
  24. Ryan Tseng (hinokaohnoyoudont@chromium.org)
  25. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  26. Ryan Tseng (hinokaohnoyoudont@google.com)
  27. Ryan Tseng (hinokaohnoyoudont@google.com)
  28. Ryan Tseng (hinokaohnoyoudont@chromium.org)
  29. Ryan Tseng (hinokaohnoyoudont@chromium.org)
  30. Ryan Tseng (hinokaohnoyoudont@chromium.org)
  31. Ryan Tseng (hinokaohnoyoudont@google.com)
  32. Thomas Anderson (thomasandersonohnoyoudont@chromium.org)
  33. Thomas Anderson (thomasandersonohnoyoudont@chromium.org)
  34. Thomas Anderson (thomasandersonohnoyoudont@chromium.org)
  35. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  36. Andrii Shyshkalov (tandriiohnoyoudont@chromium.org)
  37. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  38. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  39. Hans Wennborg (hansohnoyoudont@chromium.org)
  40. Devlin Cronin (rdevlin.croninohnoyoudont@chromium.org)
  41. Andrew Bonventre (andybonsohnoyoudont@chromium.org)
  42. Daniel Bratell (bratellohnoyoudont@opera.com)
  43. Derek Schuff (dschuffohnoyoudont@chromium.org)
  44. Derek Schuff (dschuffohnoyoudont@chromium.org)
  45. Derek Schuff (dschuffohnoyoudont@chromium.org)
  46. Derek Schuff (dschuffohnoyoudont@chromium.org)
  47. Derek Schuff (dschuffohnoyoudont@chromium.org)
  48. Shenghua Zhang (shenghuazhangohnoyoudont@chromium.org)
  49. Andrii Shyshkalov (tandriiohnoyoudont@chromium.org)
  50. Nico Weber (thakisohnoyoudont@chromium.org)
  51. Derek Schuff (dschuffohnoyoudont@chromium.org)
  52. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  53. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  54. Derek Schuff (dschuffohnoyoudont@chromium.org)
  55. Wei-Yin Chen (陳威尹) (wychenohnoyoudont@chromium.org)
  56. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  57. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  58. Eric Boren (borenetohnoyoudont@google.com)
  59. Derek Schuff (dschuffohnoyoudont@chromium.org)
  60. Derek Schuff (dschuffohnoyoudont@chromium.org)
  61. Sam Clegg (sbcohnoyoudont@chromium.org)
  62. Derek Schuff (dschuffohnoyoudont@chromium.org)
  63. Derek Schuff (dschuffohnoyoudont@chromium.org)
  64. Derek Schuff (dschuffohnoyoudont@chromium.org)
  65. Derek Schuff (dschuffohnoyoudont@chromium.org)
  66. Derek Schuff (dschuffohnoyoudont@chromium.org)
  67. Derek Schuff (dschuffohnoyoudont@chromium.org)
  68. Petar Jovanovic (petar.jovanovicohnoyoudont@rt-rk.com)
  69. Erik Chen (erikchenohnoyoudont@chromium.org)
  70. Andrii Shyshkalov (tandriiohnoyoudont@chromium.org)
  71. Petar Jovanovic (petar.jovanovicohnoyoudont@rt-rk.com)
  72. Aaron Gable (agableohnoyoudont@chromium.org)
  73. Derek Schuff (dschuffohnoyoudont@chromium.org)
  74. Jim Stichnoth (stichnotohnoyoudont@chromium.org)
  75. Jim Stichnoth (stichnotohnoyoudont@chromium.org)
  76. Jim Stichnoth (stichnotohnoyoudont@chromium.org)
  77. Derek Schuff (dschuffohnoyoudont@chromium.org)
  78. stichnot (stichnotohnoyoudont@chromium.org)
  79. petarj (petarjohnoyoudont@mips.com)
  80. brucedawson (brucedawsonohnoyoudont@chromium.org)
  81. brucedawson (brucedawsonohnoyoudont@chromium.org)
  82. Aaron Gable (agableohnoyoudont@chromium.org)
  83. yyanagisawa (yyanagisawaohnoyoudont@chromium.org)
  84. petarj (petarjohnoyoudont@mips.com)
  85. petarj (petarjohnoyoudont@mips.com)
  86. petarj (petarjohnoyoudont@mips.com)
  87. thakis (thakisohnoyoudont@chromium.org)
  88. sbc (sbcohnoyoudont@chromium.org)
  89. sbc (sbcohnoyoudont@chromium.org)
  90. sbc (sbcohnoyoudont@chromium.org)
  91. bradnelson (bradnelsonohnoyoudont@chromium.org)
  92. bradnelson (bradnelsonohnoyoudont@chromium.org)
  93. bradnelson (bradnelsonohnoyoudont@chromium.org)
  94. bradnelson (bradnelsonohnoyoudont@chromium.org)
  95. erikchen (erikchenohnoyoudont@chromium.org)
  96. Roland McGrath (mcgrathrohnoyoudont@chromium.org)
  97. Jim Stichnoth (stichnotohnoyoudont@chromium.org)
  98. Jim Stichnoth (stichnotohnoyoudont@chromium.org)
  99. Jim Stichnoth (stichnotohnoyoudont@chromium.org)
  100. Jim Stichnoth (stichnotohnoyoudont@chromium.org)
  101. <blame list capped at 100 commits> ()

Timing:

Create Friday, 07-Dec-18 01:37:44 UTC
Start Friday, 07-Dec-18 02:03:22 UTC
End Friday, 07-Dec-18 02:05:00 UTC
Pending 25 mins 37 secs
Execution 1 mins 37 secs

All Changes:

  1. Surface lxml for use via vpython.

    Changed by Jao-ke Chin-Lee - jchinleeohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:37:20 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 8e13fe5e85640b063aefcb88a3ccb52abf6e28e8

    Comments

    Surface lxml for use via vpython.
    
    Bug: 912379
    Change-Id: Iefa91707e71ce70bcf34c9f65f892d2deb381f62
    Reviewed-on: https://chromium-review.googlesource.com/c/1366490
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • src/trusted/validator_ragel/dfa_parser.py.vpython
  2. PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Wednesday, 05-Dec-18 18:49:04 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 17af1e818981ebf2c492a678d4d31c9e1ee37fc7

    Comments

    PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS
    
    This pulls in the following LLVM changes:
    
    4ffbbb82cd1: (dschuff@chromium.org) Make LLVM's codereview.settings match NaCl's
    28d173e84a2: (dschuff@chromium.org) Hack out build of lli tool from autoconf build
    35fedaf8f2b: (dschuff@chromium.org) Revert "Hack out build of lli tool from autoconf build"
    f106583f744: (dschuff@chromium.org) Hack out build of lli from autoconf build
    
    TEST= PNaCl toolchain trybots
    
    Change-Id: I27890e0442521777d308cba11f8f528531c693c1
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1361764
    Commit-Queue: Derek Schuff <dschuff@chromium.org>
    Reviewed-by: Sam Clegg <sbc@chromium.org>
    

    Changed files

    • pnacl/COMPONENT_REVISIONS
  3. Yet another whitespace change

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Tuesday, 04-Dec-18 01:40:32 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 277022e0e51ae646448daf2d36a81502b8ac53b7

    Comments

    Yet another whitespace change
    
    Change-Id: I4e27a3e36a982f866c9cfce62674c4db1fb17b27
    Reviewed-on: https://chromium-review.googlesource.com/c/1359433
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • whitespace.txt
  4. Update commit queue for Nacl try builders

    Changed by Eric Foo - efooohnoyoudont@chromium.org
    Changed at Thursday, 22-Nov-18 01:42:19 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision f701a90597fc85979319447c0cd44c3b52201c78

    Comments

    Update commit queue for Nacl try builders
    
    Bug:868204
    Change-Id: I8389a4eaac0e30392538780f0fe7e7de1d5826b7
    Reviewed-on: https://chromium-review.googlesource.com/c/1344646
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
    

    Changed files

    • infra/config/cq.cfg
  5. Whitespage change to force a CL

    Changed by Eric Foo - efooohnoyoudont@chromium.org
    Changed at Wednesday, 21-Nov-18 20:43:57 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 55f40a255928a95a71a5c63b37cdf7cc6ec8acae

    Comments

    Whitespage change to force a CL
    
    TBR=hinoka@chromium.org
    
    Change-Id: I873e2434eaf525b46ae638992ef5a0454a8565ce
    Reviewed-on: https://chromium-review.googlesource.com/c/1344644
    Commit-Queue: Eric Foo <efoo@chromium.org>
    Reviewed-by: Eric Foo <efoo@chromium.org>
    

    Changed files

    • whitespace.txt
  6. Revert "Whitespace change to kick off LUCI jobs"

    Changed by Ryan Tseng - hinokaohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 23:17:15 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 99673869a3cd8731d924bd32fa486feebfdc6c4f

    Comments

    Revert "Whitespace change to kick off LUCI jobs"
    
    This reverts commit 2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f.
    
    Reason for revert: Retry jobs
    
    Original change's description:
    > Whitespace change to kick off LUCI jobs
    > 
    > TBR:hinoka@chromium.org
    > 
    > Bug:868204
    > Change-Id: I6f953df62c6a603628d358713bc76c7342e1ef45
    > Reviewed-on: https://chromium-review.googlesource.com/1239737
    > Reviewed-by: Eric Foo <efoo@chromium.org>
    > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    
    TBR=hinoka@chromium.org,efoo@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 868204
    Change-Id: I6795b0f87455990ab2b50333a677381635d080a1
    Reviewed-on: https://chromium-review.googlesource.com/c/1285311
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    

    Changed files

    • whitespace.txt
  7. Whitespace change to kick off LUCI jobs

    Changed by Eric Foo - efooohnoyoudont@chromium.org
    Changed at Tuesday, 25-Sep-18 04:10:24 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f

    Comments

    Whitespace change to kick off LUCI jobs
    
    TBR:hinoka@chromium.org
    
    Bug:868204
    Change-Id: I6f953df62c6a603628d358713bc76c7342e1ef45
    Reviewed-on: https://chromium-review.googlesource.com/1239737
    Reviewed-by: Eric Foo <efoo@chromium.org>
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    

    Changed files

    • whitespace.txt
  8. Whitespace to trigger additional builds.

    Changed by Robert Iannucci - iannucciohnoyoudont@chromium.org
    Changed at Thursday, 20-Sep-18 21:56:51 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 9f85491d8830fe6f3b8e0efa2e954f71bd9c64af

    Comments

    Whitespace to trigger additional builds.
    
    TBR=efoo@chromium.org
    
    Bug: 861512
    Change-Id: I1cea6c85a3d1afbe0f926d722a98d4a8722dda92
    Reviewed-on: https://chromium-review.googlesource.com/1237322
    Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
    

    Changed files

    • whitespace.txt
  9. Whitespace change to kick off jobs

    Changed by Stephen Martinis - martinissohnoyoudont@chromium.org
    Changed at Thursday, 20-Sep-18 18:05:25 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision b64cb7b68093f06952a5966c97e6f49dae5f455e

    Comments

    Whitespace change to kick off jobs
    
    TBR=hinoka
    NOTRY=true
    
    Bug: 646142
    Change-Id: Id8580221a06b48911b44d70b4e81280447ff3c65
    Reviewed-on: https://chromium-review.googlesource.com/1237043
    Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    

    Changed files

    • whitespace.txt
  10. Whitespace change to kick off jobs

    Changed by Eric Foo - efooohnoyoudont@chromium.org
    Changed at Monday, 17-Sep-18 21:29:20 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 6f1149defa9e40c9bd20512b5560959d381ac202

    Comments

    Whitespace change to kick off jobs
    
    TBR:hinoka@chromium.org
    
    Bug:868204
    Change-Id: I4df201d74feaab3bdddc06fcf1cdafc326f0b32d
    Reviewed-on: https://chromium-review.googlesource.com/1228260
    Reviewed-by: Eric Foo <efoo@chromium.org>
    

    Changed files

    • whitespace.txt
  11. Reland "Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""""

    Changed by Ryan Tseng - hinokaohnoyoudont@chromium.org
    Changed at Wednesday, 12-Sep-18 22:36:22 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 32b6deb45d5fbc77c5f65d35db45c48cae3c06bc

    Comments

    Reland "Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""""
    
    This reverts commit 5604391f597d84ef7065eb99432fcc09cdcf7d34.
    
    Reason for revert: New console
    
    Original change's description:
    > Revert "Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""""
    > 
    > This reverts commit 385a05c3d606ae044fd4b35309af5765bf5150dd.
    > 
    > Reason for revert: Fixed mastername
    > 
    > Original change's description:
    > > Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""
    > > 
    > > This reverts commit cb6ec4b1f91af259cbdfd1bd22bb98ed5551955e.
    > > 
    > > Reason for revert: Fixed triggering, try again.
    > > 
    > > Original change's description:
    > > > Revert "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""
    > > > 
    > > > This reverts commit a87b168e08d3b69241b7f185e5ee3c96ed8bf478.
    > > > 
    > > > Reason for revert: Re-trigger for toolchains
    > > > 
    > > > Original change's description:
    > > > > Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
    > > > > 
    > > > > This reverts commit fa95e2a7489d9efe3f8dd770c204b4d968eb9b02.
    > > > > 
    > > > > Reason for revert: Trigger luci
    > > > > 
    > > > > Original change's description:
    > > > > > Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
    > > > > > 
    > > > > > This reverts commit aebc9e5205dcaad5d5954a18abc532316a954644.
    > > > > > 
    > > > > > Original change's description:
    > > > > > > Reland "Trigger a buildbot cycle on client.nacl.toolchain"
    > > > > > >
    > > > > > > This reverts commit e6ce828ef60c4c1438867b535efbbb5d9a177c0e.
    > > > > > >
    > > > > > > Reason for revert: The next thing has been fixed on bug 863140, so trigger another buildbot cycle.
    > > > > > >
    > > > > > > Original change's description:
    > > > > > > > Revert "Trigger a buildbot cycle on client.nacl.toolchain"
    > > > > > > >
    > > > > > > > This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
    > > > > > > >
    > > > > > > > Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
    > > > > > > >
    > > > > > > > Original change's description:
    > > > > > > > > Trigger a buildbot cycle on client.nacl.toolchain
    > > > > > > > >
    > > > > > > > > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
    > > > > > > > > [1].  The logs have since been deleted, so trigger another build so we can
    > > > > > > > > review the failures in the logs.
    > > > > > > > >
    > > > > > > > > [1] https://build.chromium.org/p/client.nacl.toolchain/console
    > > > > > > > >
    > > > > > > > > BUG=None
    > > > > > > > > TBR=thakis
    > > > > > > > > NOTRY=true
    > > > > > > > > NOPRESUBMIT=true
    > > > > > > > >
    > > > > > > > > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
    > > > > > > > > Reviewed-on: https://chromium-review.googlesource.com/1132561
    > > > > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > > > > > >
    > > > > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > > > > > >
    > > > > > > > Change-Id: I629856581810be12abba20ecbedc95754c6fe325
    > > > > > > > No-Presubmit: true
    > > > > > > > No-Tree-Checks: true
    > > > > > > > No-Try: true
    > > > > > > > Bug: None
    > > > > > > > Reviewed-on: https://chromium-review.googlesource.com/1134366
    > > > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > > > > >
    > > > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > > > > > NOTRY=true
    > > > > > >
    > > > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > > > > >
    > > > > > > Bug: None
    > > > > > > Change-Id: Ie71f8351bb500fd1e6d3f6443dff05be1a529004
    > > > > > > Reviewed-on: https://chromium-review.googlesource.com/1139534
    > > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > > > 
    > > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > > > > 
    > > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > > > > 
    > > > > > NOTRY=true
    > > > > > NOPRESUBMIT=true
    > > > > > NOTREECHECKS=true
    > > > > > Bug: None
    > > > > > Change-Id: I9bd8fcb9d5dd19cfc5f704cf8adadd1a6337dd1d
    > > > > > Reviewed-on: https://chromium-review.googlesource.com/1148840
    > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > > 
    > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > > > 
    > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > > > 
    > > > > Bug: None
    > > > > Change-Id: I7d84621f9163049137b6e1a7ce64b1f226bf08a6
    > > > > Reviewed-on: https://chromium-review.googlesource.com/1159727
    > > > > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    > > > 
    > > > TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
    > > > 
    > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > > 
    > > > Bug: None
    > > > Change-Id: I507c99da5fe25d0f8a1bb8b87b360ec594e6e423
    > > > Reviewed-on: https://chromium-review.googlesource.com/1199969
    > > > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    > > 
    > > TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
    > > 
    > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > 
    > > Bug: None
    > > Change-Id: Ia25f0d747016a0f79bf46fda663906db71c8a583
    > > Reviewed-on: https://chromium-review.googlesource.com/1217763
    > > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    > 
    > TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
    > 
    > Change-Id: Ice9ba32760b934a1194b41e280918518778e21d0
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: None
    > Reviewed-on: https://chromium-review.googlesource.com/1217487
    > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    > Commit-Queue: Ryan Tseng <hinoka@chromium.org>
    
    TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: None
    Change-Id: I2e6eb4177ed91e1d6a6584df54f897aa773faf91
    Reviewed-on: https://chromium-review.googlesource.com/1222234
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    

    Changed files

    • whitespace.txt
  12. Revert "Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""""

    Changed by Ryan Tseng - hinokaohnoyoudont@chromium.org
    Changed at Monday, 10-Sep-18 22:33:21 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 5604391f597d84ef7065eb99432fcc09cdcf7d34

    Comments

    Revert "Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""""
    
    This reverts commit 385a05c3d606ae044fd4b35309af5765bf5150dd.
    
    Reason for revert: Fixed mastername
    
    Original change's description:
    > Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""
    > 
    > This reverts commit cb6ec4b1f91af259cbdfd1bd22bb98ed5551955e.
    > 
    > Reason for revert: Fixed triggering, try again.
    > 
    > Original change's description:
    > > Revert "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""
    > > 
    > > This reverts commit a87b168e08d3b69241b7f185e5ee3c96ed8bf478.
    > > 
    > > Reason for revert: Re-trigger for toolchains
    > > 
    > > Original change's description:
    > > > Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
    > > > 
    > > > This reverts commit fa95e2a7489d9efe3f8dd770c204b4d968eb9b02.
    > > > 
    > > > Reason for revert: Trigger luci
    > > > 
    > > > Original change's description:
    > > > > Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
    > > > > 
    > > > > This reverts commit aebc9e5205dcaad5d5954a18abc532316a954644.
    > > > > 
    > > > > Original change's description:
    > > > > > Reland "Trigger a buildbot cycle on client.nacl.toolchain"
    > > > > >
    > > > > > This reverts commit e6ce828ef60c4c1438867b535efbbb5d9a177c0e.
    > > > > >
    > > > > > Reason for revert: The next thing has been fixed on bug 863140, so trigger another buildbot cycle.
    > > > > >
    > > > > > Original change's description:
    > > > > > > Revert "Trigger a buildbot cycle on client.nacl.toolchain"
    > > > > > >
    > > > > > > This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
    > > > > > >
    > > > > > > Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
    > > > > > >
    > > > > > > Original change's description:
    > > > > > > > Trigger a buildbot cycle on client.nacl.toolchain
    > > > > > > >
    > > > > > > > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
    > > > > > > > [1].  The logs have since been deleted, so trigger another build so we can
    > > > > > > > review the failures in the logs.
    > > > > > > >
    > > > > > > > [1] https://build.chromium.org/p/client.nacl.toolchain/console
    > > > > > > >
    > > > > > > > BUG=None
    > > > > > > > TBR=thakis
    > > > > > > > NOTRY=true
    > > > > > > > NOPRESUBMIT=true
    > > > > > > >
    > > > > > > > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
    > > > > > > > Reviewed-on: https://chromium-review.googlesource.com/1132561
    > > > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > > > > >
    > > > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > > > > >
    > > > > > > Change-Id: I629856581810be12abba20ecbedc95754c6fe325
    > > > > > > No-Presubmit: true
    > > > > > > No-Tree-Checks: true
    > > > > > > No-Try: true
    > > > > > > Bug: None
    > > > > > > Reviewed-on: https://chromium-review.googlesource.com/1134366
    > > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > > > >
    > > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > > > > NOTRY=true
    > > > > >
    > > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > > > >
    > > > > > Bug: None
    > > > > > Change-Id: Ie71f8351bb500fd1e6d3f6443dff05be1a529004
    > > > > > Reviewed-on: https://chromium-review.googlesource.com/1139534
    > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > > 
    > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > > > 
    > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > > > 
    > > > > NOTRY=true
    > > > > NOPRESUBMIT=true
    > > > > NOTREECHECKS=true
    > > > > Bug: None
    > > > > Change-Id: I9bd8fcb9d5dd19cfc5f704cf8adadd1a6337dd1d
    > > > > Reviewed-on: https://chromium-review.googlesource.com/1148840
    > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > 
    > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > > 
    > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > > 
    > > > Bug: None
    > > > Change-Id: I7d84621f9163049137b6e1a7ce64b1f226bf08a6
    > > > Reviewed-on: https://chromium-review.googlesource.com/1159727
    > > > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    > > 
    > > TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
    > > 
    > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > 
    > > Bug: None
    > > Change-Id: I507c99da5fe25d0f8a1bb8b87b360ec594e6e423
    > > Reviewed-on: https://chromium-review.googlesource.com/1199969
    > > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    > 
    > TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: None
    > Change-Id: Ia25f0d747016a0f79bf46fda663906db71c8a583
    > Reviewed-on: https://chromium-review.googlesource.com/1217763
    > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    
    TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
    
    Change-Id: Ice9ba32760b934a1194b41e280918518778e21d0
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: None
    Reviewed-on: https://chromium-review.googlesource.com/1217487
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Commit-Queue: Ryan Tseng <hinoka@chromium.org>
    

    Changed files

    • whitespace.txt
  13. Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""

    Changed by Ryan Tseng - hinokaohnoyoudont@chromium.org
    Changed at Monday, 10-Sep-18 22:12:32 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 385a05c3d606ae044fd4b35309af5765bf5150dd

    Comments

    Reland "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""
    
    This reverts commit cb6ec4b1f91af259cbdfd1bd22bb98ed5551955e.
    
    Reason for revert: Fixed triggering, try again.
    
    Original change's description:
    > Revert "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""
    > 
    > This reverts commit a87b168e08d3b69241b7f185e5ee3c96ed8bf478.
    > 
    > Reason for revert: Re-trigger for toolchains
    > 
    > Original change's description:
    > > Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
    > > 
    > > This reverts commit fa95e2a7489d9efe3f8dd770c204b4d968eb9b02.
    > > 
    > > Reason for revert: Trigger luci
    > > 
    > > Original change's description:
    > > > Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
    > > > 
    > > > This reverts commit aebc9e5205dcaad5d5954a18abc532316a954644.
    > > > 
    > > > Original change's description:
    > > > > Reland "Trigger a buildbot cycle on client.nacl.toolchain"
    > > > >
    > > > > This reverts commit e6ce828ef60c4c1438867b535efbbb5d9a177c0e.
    > > > >
    > > > > Reason for revert: The next thing has been fixed on bug 863140, so trigger another buildbot cycle.
    > > > >
    > > > > Original change's description:
    > > > > > Revert "Trigger a buildbot cycle on client.nacl.toolchain"
    > > > > >
    > > > > > This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
    > > > > >
    > > > > > Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
    > > > > >
    > > > > > Original change's description:
    > > > > > > Trigger a buildbot cycle on client.nacl.toolchain
    > > > > > >
    > > > > > > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
    > > > > > > [1].  The logs have since been deleted, so trigger another build so we can
    > > > > > > review the failures in the logs.
    > > > > > >
    > > > > > > [1] https://build.chromium.org/p/client.nacl.toolchain/console
    > > > > > >
    > > > > > > BUG=None
    > > > > > > TBR=thakis
    > > > > > > NOTRY=true
    > > > > > > NOPRESUBMIT=true
    > > > > > >
    > > > > > > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
    > > > > > > Reviewed-on: https://chromium-review.googlesource.com/1132561
    > > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > > > >
    > > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > > > >
    > > > > > Change-Id: I629856581810be12abba20ecbedc95754c6fe325
    > > > > > No-Presubmit: true
    > > > > > No-Tree-Checks: true
    > > > > > No-Try: true
    > > > > > Bug: None
    > > > > > Reviewed-on: https://chromium-review.googlesource.com/1134366
    > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > > >
    > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > > > NOTRY=true
    > > > >
    > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > > >
    > > > > Bug: None
    > > > > Change-Id: Ie71f8351bb500fd1e6d3f6443dff05be1a529004
    > > > > Reviewed-on: https://chromium-review.googlesource.com/1139534
    > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > 
    > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > > 
    > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > > 
    > > > NOTRY=true
    > > > NOPRESUBMIT=true
    > > > NOTREECHECKS=true
    > > > Bug: None
    > > > Change-Id: I9bd8fcb9d5dd19cfc5f704cf8adadd1a6337dd1d
    > > > Reviewed-on: https://chromium-review.googlesource.com/1148840
    > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > 
    > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > 
    > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > 
    > > Bug: None
    > > Change-Id: I7d84621f9163049137b6e1a7ce64b1f226bf08a6
    > > Reviewed-on: https://chromium-review.googlesource.com/1159727
    > > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    > 
    > TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: None
    > Change-Id: I507c99da5fe25d0f8a1bb8b87b360ec594e6e423
    > Reviewed-on: https://chromium-review.googlesource.com/1199969
    > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    
    TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: None
    Change-Id: Ia25f0d747016a0f79bf46fda663906db71c8a583
    Reviewed-on: https://chromium-review.googlesource.com/1217763
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    

    Changed files

    • whitespace.txt
  14. Revert "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""

    Changed by Ryan Tseng - hinokaohnoyoudont@chromium.org
    Changed at Friday, 31-Aug-18 21:30:05 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision cb6ec4b1f91af259cbdfd1bd22bb98ed5551955e

    Comments

    Revert "Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain"""
    
    This reverts commit a87b168e08d3b69241b7f185e5ee3c96ed8bf478.
    
    Reason for revert: Re-trigger for toolchains
    
    Original change's description:
    > Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
    > 
    > This reverts commit fa95e2a7489d9efe3f8dd770c204b4d968eb9b02.
    > 
    > Reason for revert: Trigger luci
    > 
    > Original change's description:
    > > Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
    > > 
    > > This reverts commit aebc9e5205dcaad5d5954a18abc532316a954644.
    > > 
    > > Original change's description:
    > > > Reland "Trigger a buildbot cycle on client.nacl.toolchain"
    > > >
    > > > This reverts commit e6ce828ef60c4c1438867b535efbbb5d9a177c0e.
    > > >
    > > > Reason for revert: The next thing has been fixed on bug 863140, so trigger another buildbot cycle.
    > > >
    > > > Original change's description:
    > > > > Revert "Trigger a buildbot cycle on client.nacl.toolchain"
    > > > >
    > > > > This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
    > > > >
    > > > > Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
    > > > >
    > > > > Original change's description:
    > > > > > Trigger a buildbot cycle on client.nacl.toolchain
    > > > > >
    > > > > > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
    > > > > > [1].  The logs have since been deleted, so trigger another build so we can
    > > > > > review the failures in the logs.
    > > > > >
    > > > > > [1] https://build.chromium.org/p/client.nacl.toolchain/console
    > > > > >
    > > > > > BUG=None
    > > > > > TBR=thakis
    > > > > > NOTRY=true
    > > > > > NOPRESUBMIT=true
    > > > > >
    > > > > > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
    > > > > > Reviewed-on: https://chromium-review.googlesource.com/1132561
    > > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > > >
    > > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > > >
    > > > > Change-Id: I629856581810be12abba20ecbedc95754c6fe325
    > > > > No-Presubmit: true
    > > > > No-Tree-Checks: true
    > > > > No-Try: true
    > > > > Bug: None
    > > > > Reviewed-on: https://chromium-review.googlesource.com/1134366
    > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > >
    > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > > NOTRY=true
    > > >
    > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > >
    > > > Bug: None
    > > > Change-Id: Ie71f8351bb500fd1e6d3f6443dff05be1a529004
    > > > Reviewed-on: https://chromium-review.googlesource.com/1139534
    > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > 
    > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > 
    > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > 
    > > NOTRY=true
    > > NOPRESUBMIT=true
    > > NOTREECHECKS=true
    > > Bug: None
    > > Change-Id: I9bd8fcb9d5dd19cfc5f704cf8adadd1a6337dd1d
    > > Reviewed-on: https://chromium-review.googlesource.com/1148840
    > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > 
    > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: None
    > Change-Id: I7d84621f9163049137b6e1a7ce64b1f226bf08a6
    > Reviewed-on: https://chromium-review.googlesource.com/1159727
    > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    
    TBR=thakis@chromium.org,hinoka@chromium.org,thomasanderson@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: None
    Change-Id: I507c99da5fe25d0f8a1bb8b87b360ec594e6e423
    Reviewed-on: https://chromium-review.googlesource.com/1199969
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    

    Changed files

    • whitespace.txt
  15. Make posix code compile with -Wimplicit-fallthrough

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Friday, 31-Aug-18 18:24:53 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision d636a4fae3c1f4e71bd2c9a150ac6652157ac8bb

    Comments

    Make posix code compile with -Wimplicit-fallthrough
    
    This is the default on GCC 7+.
    When falling through switch cases it requires a comment matching a particular
    regex indicating the fallthrough.
    See https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
    
    Bug: 868204
    No-Try: true
    Change-Id: I66f39a113dc43ce72c5effd6c3c59c6581217b74
    Reviewed-on: https://chromium-review.googlesource.com/1197703
    Commit-Queue: Derek Schuff <dschuff@chromium.org>
    Reviewed-by: Petar Jovanovic <petarj@mips.com>
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    

    Changed files

    • src/shared/platform/nacl_host_desc_common.c
    • src/trusted/desc/nacl_desc_quota_test.c
    • src/trusted/service_runtime/linux/nacl_thread_nice.c
    • src/trusted/service_runtime/nacl_error_gio_test.c
  16. [mips] Fix build with newer GCC and -std=c11

    Changed by Petar Jovanovic - petar.jovanovicohnoyoudont@rt-rk.com
    Changed at Friday, 31-Aug-18 15:51:40 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 2b59aaeee137b835b33dafa3443f25c5b6c5756f

    Comments

    [mips] Fix build with newer GCC and -std=c11
    
    Changes instances of asm() to __asm__().
    
    It also removes the following warning:
    
    - warning: used $at (currently $1) without ".set noat"
    
    No-Try: true
    Change-Id: I20a40481a4c53f23872bc2ecad5ddde64c95e350
    Reviewed-on: https://chromium-review.googlesource.com/1186727
    Commit-Queue: Derek Schuff <dschuff@chromium.org>
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • src/trusted/platform_qualify/arch/mips/nacl_qualify_fpu.c
    • src/trusted/service_runtime/arch/mips/nacl_switch.S
    • src/trusted/service_runtime/linux/mips/sel_segments.c
    • src/trusted/service_runtime/linux/nacl_bootstrap.c
  17. Don't run the performance tests in the emulator

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Friday, 17-Aug-18 18:59:41 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 9a87d6b9de35325efb08321640879e79ed0dfcc9

    Comments

    Don't run the performance tests in the emulator
    
    Existing logic tries to also disable the perf tests in VMs based on the
    slave name anyway, but that logic doesn't work on LUCI.
    
    Bug: 868204
    No-Try: true
    TBR: bradnelson@chromium.org, sbc@chromium.org
    Change-Id: I572ce7a4e21a3806e0b9a66dd047638b35f9b915
    Reviewed-on: https://chromium-review.googlesource.com/1180098
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    Commit-Queue: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • tests/performance/nacl.scons
  18. Update more uses of gsutil for new bot config

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Friday, 17-Aug-18 16:31:47 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 1c78a7ba9366c03dc8b65c43c72c5b31b0e5f146

    Comments

    Update more uses of gsutil for new bot config
    
    Bug: 868204
    No-Try: true
    TBR: bradnelson@chromium.org, sbc@chromium.org
    Change-Id: If95d0ac908da7c98673aef3a9ea75a0a370ed520
    Reviewed-on: https://chromium-review.googlesource.com/1179967
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    Commit-Queue: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • buildbot/buildbot_toolchain_arm_trusted.sh
    • buildbot/file_up_down_load.sh
  19. Use gsutil from PATH instead of assuming its location

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Friday, 17-Aug-18 00:08:36 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 6e5fd1672be57aafb05bf0a1f1bbdc9107e0c58b

    Comments

    Use gsutil from PATH instead of assuming its location
    
    This makes the Spec2k bots correctly able to download the source bundle.
    
    No-Try: true
    R: bradnelson@chromium.org
    Change-Id: I4ace3a85d1a4a3bb7893ed22b836d9e4402678d1
    Reviewed-on: https://chromium-review.googlesource.com/1179266
    Commit-Queue: Derek Schuff <dschuff@chromium.org>
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    

    Changed files

    • buildbot/buildbot_selector.py
  20. Only run 64 bit builds on mac

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Thursday, 16-Aug-18 19:54:08 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision c43b409d96882e828c356c31f6562df4d2f4ee29

    Comments

    Only run 64 bit builds on mac
    
    NaCl hasn't shipped on 32 bit mac in a long time, and all the builders with the
    new SDK actually build 64 even when you ask for 32. So update explicit builder
    configs and update the "default" arch (used when the buildbot name doesn't
    specify 64 or 32; it turns out macs are the only builders that do this).
    
    Bug: 868204
    Change-Id: I9ea9f268c826a9afe35cf1a901006ea0a8431e67
    No-Try: true
    R: bradnelson@chromium.org, sbc@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1178421
    Reviewed-by: Bill Budge <bbudge@chromium.org>
    Commit-Queue: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • buildbot/buildbot_selector.py
  21. Remove perf_test_compat_osx

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Thursday, 16-Aug-18 01:05:10 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision cadf5787452659b381450733c9260e065842fe05

    Comments

    Remove perf_test_compat_osx
    
    It implements clock_gettime, but that function has been added to the MacOS SDK, so it's no longer necessary.
    
    Bug: 868204
    No-Try: true
    R: bradnelson@chromium.org, sbc@chromium.org
    Test: run_trusted_performance_test
    Change-Id: Id81ba50bcb8daa54e5460288f2e81674955e8afc
    Reviewed-on: https://chromium-review.googlesource.com/1176827
    Commit-Queue: Derek Schuff <dschuff@chromium.org>
    Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    

    Changed files

    • tests/performance/build.scons
    • tests/performance/perf_test_basics.cc
    • tests/performance/perf_test_compat_osx.cc
    • tests/performance/perf_test_compat_osx.h
    • tests/performance/perf_test_runner.cc
  22. Don't run builds through runtest.py

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Wednesday, 15-Aug-18 21:00:24 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 190ff372dacbde6bc1296ebd03e4f04af0896acb

    Comments

    Don't run builds through runtest.py
    
    Bug:868204
    No-Try: true
    TBR: hinoka
    Change-Id: Ie6f059d641d8c8d292c3e90616ce76ea27b8cbba
    Reviewed-on: https://chromium-review.googlesource.com/1166453
    Commit-Queue: Derek Schuff <dschuff@chromium.org>
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • buildbot/buildbot_selector.py
  23. [vpyhon] Add pywin32

    Changed by Ryan Tseng - hinokaohnoyoudont@google.com
    Changed at Wednesday, 08-Aug-18 20:23:40 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 96088f46727b75b2f6a24e1b62e5cc59ddb4612d

    Comments

    [vpyhon] Add pywin32
    
    Bug: 868204
    No-Try: true
    TBR: dschuff
    Change-Id: I43bc18cfa7bdffb8593b9d2e7a1c7a0786196fb8
    Reviewed-on: https://chromium-review.googlesource.com/1167995
    Commit-Queue: Ryan Tseng <hinoka@chromium.org>
    Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
    

    Changed files

    • .vpython
  24. Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""

    Changed by Ryan Tseng - hinokaohnoyoudont@chromium.org
    Changed at Wednesday, 08-Aug-18 00:04:32 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision a87b168e08d3b69241b7f185e5ee3c96ed8bf478

    Comments

    Reland "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
    
    This reverts commit fa95e2a7489d9efe3f8dd770c204b4d968eb9b02.
    
    Reason for revert: Trigger luci
    
    Original change's description:
    > Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
    > 
    > This reverts commit aebc9e5205dcaad5d5954a18abc532316a954644.
    > 
    > Original change's description:
    > > Reland "Trigger a buildbot cycle on client.nacl.toolchain"
    > >
    > > This reverts commit e6ce828ef60c4c1438867b535efbbb5d9a177c0e.
    > >
    > > Reason for revert: The next thing has been fixed on bug 863140, so trigger another buildbot cycle.
    > >
    > > Original change's description:
    > > > Revert "Trigger a buildbot cycle on client.nacl.toolchain"
    > > >
    > > > This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
    > > >
    > > > Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
    > > >
    > > > Original change's description:
    > > > > Trigger a buildbot cycle on client.nacl.toolchain
    > > > >
    > > > > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
    > > > > [1].  The logs have since been deleted, so trigger another build so we can
    > > > > review the failures in the logs.
    > > > >
    > > > > [1] https://build.chromium.org/p/client.nacl.toolchain/console
    > > > >
    > > > > BUG=None
    > > > > TBR=thakis
    > > > > NOTRY=true
    > > > > NOPRESUBMIT=true
    > > > >
    > > > > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
    > > > > Reviewed-on: https://chromium-review.googlesource.com/1132561
    > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > >
    > > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > >
    > > > Change-Id: I629856581810be12abba20ecbedc95754c6fe325
    > > > No-Presubmit: true
    > > > No-Tree-Checks: true
    > > > No-Try: true
    > > > Bug: None
    > > > Reviewed-on: https://chromium-review.googlesource.com/1134366
    > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > >
    > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > > NOTRY=true
    > >
    > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > >
    > > Bug: None
    > > Change-Id: Ie71f8351bb500fd1e6d3f6443dff05be1a529004
    > > Reviewed-on: https://chromium-review.googlesource.com/1139534
    > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > 
    > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > NOTRY=true
    > NOPRESUBMIT=true
    > NOTREECHECKS=true
    > Bug: None
    > Change-Id: I9bd8fcb9d5dd19cfc5f704cf8adadd1a6337dd1d
    > Reviewed-on: https://chromium-review.googlesource.com/1148840
    > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    
    TBR=thakis@chromium.org,thomasanderson@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: None
    Change-Id: I7d84621f9163049137b6e1a7ce64b1f226bf08a6
    Reviewed-on: https://chromium-review.googlesource.com/1159727
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    

    Changed files

    • whitespace.txt
  25. Fix arm build with -std=c11

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Monday, 06-Aug-18 23:11:41 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 821833667ccccf83b96b4fdaf2074c6e71f87544

    Comments

    Fix arm build with -std=c11
    
    Changes instances of asm() to __asm__().
    
    BUG=427584
    R=thakis
    NOTRY=true
    NOPRESUBMIT=true
    
    Change-Id: I3ea0597fbaa6ebdea792e11f049a216d2908ed9c
    Reviewed-on: https://chromium-review.googlesource.com/1164412
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    

    Changed files

    • src/trusted/platform_qualify/arch/arm/nacl_qualify_fpu.c
    • src/trusted/platform_qualify/arch/arm/nacl_qualify_sandbox_instrs.c
    • src/trusted/platform_qualify/arch/arm/nacl_qualify_unaligned.c
    • src/trusted/service_runtime/linux/arm/sel_segments.c
  26. Don't runhooks in annotated run

    Changed by Ryan Tseng - hinokaohnoyoudont@google.com
    Changed at Friday, 03-Aug-18 00:10:30 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 64cb8d9d67fbe924ff2c48d1fd9c73437d735344

    Comments

    Don't runhooks in annotated run
    
    This is already done at the recipe level.
    
    Bug: 868204
    Change-Id: I9a7c8a9a806043bf707dde649d90a8c03cffc276
    Reviewed-on: https://chromium-review.googlesource.com/1161297
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • buildbot/buildbot_standard.py
  27. Add .vpython file with httpplib2

    Changed by Ryan Tseng - hinokaohnoyoudont@google.com
    Changed at Thursday, 02-Aug-18 21:22:01 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision d4de71b02044390cb05e4ee5e8778e651c685d63

    Comments

    Add .vpython file with httpplib2
    
    So that LUCI jobs can use python with the needed packages.
    
    Bug: 868204
    Change-Id: I8e4bd89a8a6fcb3db8994bcef30f5c2a92ba7d01
    Reviewed-on: https://chromium-review.googlesource.com/1161289
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    Commit-Queue: Ryan Tseng <hinoka@chromium.org>
    

    Changed files

    • .vpython
  28. Revert "Reland "Whitespace change to kick off luci jobs""

    Changed by Ryan Tseng - hinokaohnoyoudont@chromium.org
    Changed at Thursday, 02-Aug-18 21:08:15 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision e686ac539e03a427ff77b7901ab901388a2a1cf7

    Comments

    Revert "Reland "Whitespace change to kick off luci jobs""
    
    This reverts commit 4942f9f51a0f2bad8681e5d1d26ff3ccc6e9d647.
    
    Reason for revert: Kick off again
    
    Original change's description:
    > Reland "Whitespace change to kick off luci jobs"
    > 
    > This reverts commit 77e8a21d75e27de0d9fa04f52912cf7c74b3e867.
    > 
    > Reason for revert: Kickoff again
    > 
    > Original change's description:
    > > Revert "Whitespace change to kick off luci jobs"
    > > 
    > > This reverts commit 0a6e2d0dcbc5640d2228e335b20e7c376f5b0136.
    > > 
    > > Reason for revert: Kick off again
    > > 
    > > Original change's description:
    > > > Whitespace change to kick off luci jobs
    > > > 
    > > > Bug: 868204
    > > > TBR: dschuff
    > > > Change-Id: I948fc9918b8192e1042492fe1a4790fbdcb724ae
    > > > Reviewed-on: https://chromium-review.googlesource.com/1161054
    > > > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    > > 
    > > TBR=dschuff@chromium.org,hinoka@chromium.org
    > > 
    > > Change-Id: I4e6185fb6f521e420ffecca31e42cc646c659e29
    > > No-Presubmit: true
    > > No-Tree-Checks: true
    > > No-Try: true
    > > Bug: 868204
    > > Reviewed-on: https://chromium-review.googlesource.com/1161125
    > > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    > > Commit-Queue: Ryan Tseng <hinoka@chromium.org>
    > 
    > TBR=dschuff@chromium.org,hinoka@chromium.org
    > 
    > Change-Id: I8fff87643d3fb18e640467e9c5e451df11c7553b
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 868204
    > Reviewed-on: https://chromium-review.googlesource.com/1161126
    > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    > Commit-Queue: Ryan Tseng <hinoka@chromium.org>
    
    TBR=dschuff@chromium.org,hinoka@chromium.org
    
    Change-Id: Id9cb1311b5a388b045471ef81ff7a0fa271b12d0
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 868204
    Reviewed-on: https://chromium-review.googlesource.com/1161127
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Commit-Queue: Ryan Tseng <hinoka@chromium.org>
    

    Changed files

    • whitespace.txt
  29. Reland "Whitespace change to kick off luci jobs"

    Changed by Ryan Tseng - hinokaohnoyoudont@chromium.org
    Changed at Thursday, 02-Aug-18 20:55:18 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 4942f9f51a0f2bad8681e5d1d26ff3ccc6e9d647

    Comments

    Reland "Whitespace change to kick off luci jobs"
    
    This reverts commit 77e8a21d75e27de0d9fa04f52912cf7c74b3e867.
    
    Reason for revert: Kickoff again
    
    Original change's description:
    > Revert "Whitespace change to kick off luci jobs"
    > 
    > This reverts commit 0a6e2d0dcbc5640d2228e335b20e7c376f5b0136.
    > 
    > Reason for revert: Kick off again
    > 
    > Original change's description:
    > > Whitespace change to kick off luci jobs
    > > 
    > > Bug: 868204
    > > TBR: dschuff
    > > Change-Id: I948fc9918b8192e1042492fe1a4790fbdcb724ae
    > > Reviewed-on: https://chromium-review.googlesource.com/1161054
    > > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    > 
    > TBR=dschuff@chromium.org,hinoka@chromium.org
    > 
    > Change-Id: I4e6185fb6f521e420ffecca31e42cc646c659e29
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 868204
    > Reviewed-on: https://chromium-review.googlesource.com/1161125
    > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    > Commit-Queue: Ryan Tseng <hinoka@chromium.org>
    
    TBR=dschuff@chromium.org,hinoka@chromium.org
    
    Change-Id: I8fff87643d3fb18e640467e9c5e451df11c7553b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 868204
    Reviewed-on: https://chromium-review.googlesource.com/1161126
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Commit-Queue: Ryan Tseng <hinoka@chromium.org>
    

    Changed files

    • whitespace.txt
  30. Revert "Whitespace change to kick off luci jobs"

    Changed by Ryan Tseng - hinokaohnoyoudont@chromium.org
    Changed at Thursday, 02-Aug-18 20:41:21 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 77e8a21d75e27de0d9fa04f52912cf7c74b3e867

    Comments

    Revert "Whitespace change to kick off luci jobs"
    
    This reverts commit 0a6e2d0dcbc5640d2228e335b20e7c376f5b0136.
    
    Reason for revert: Kick off again
    
    Original change's description:
    > Whitespace change to kick off luci jobs
    > 
    > Bug: 868204
    > TBR: dschuff
    > Change-Id: I948fc9918b8192e1042492fe1a4790fbdcb724ae
    > Reviewed-on: https://chromium-review.googlesource.com/1161054
    > Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    
    TBR=dschuff@chromium.org,hinoka@chromium.org
    
    Change-Id: I4e6185fb6f521e420ffecca31e42cc646c659e29
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 868204
    Reviewed-on: https://chromium-review.googlesource.com/1161125
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Commit-Queue: Ryan Tseng <hinoka@chromium.org>
    

    Changed files

    • whitespace.txt
  31. Whitespace change to kick off luci jobs

    Changed by Ryan Tseng - hinokaohnoyoudont@google.com
    Changed at Thursday, 02-Aug-18 18:33:06 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 0a6e2d0dcbc5640d2228e335b20e7c376f5b0136

    Comments

    Whitespace change to kick off luci jobs
    
    Bug: 868204
    TBR: dschuff
    Change-Id: I948fc9918b8192e1042492fe1a4790fbdcb724ae
    Reviewed-on: https://chromium-review.googlesource.com/1161054
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    

    Changed files

    • whitespace.txt
  32. Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain""

    Changed by Thomas Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Tuesday, 24-Jul-18 19:31:07 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision fa95e2a7489d9efe3f8dd770c204b4d968eb9b02

    Comments

    Revert "Reland "Trigger a buildbot cycle on client.nacl.toolchain""
    
    This reverts commit aebc9e5205dcaad5d5954a18abc532316a954644.
    
    Original change's description:
    > Reland "Trigger a buildbot cycle on client.nacl.toolchain"
    >
    > This reverts commit e6ce828ef60c4c1438867b535efbbb5d9a177c0e.
    >
    > Reason for revert: The next thing has been fixed on bug 863140, so trigger another buildbot cycle.
    >
    > Original change's description:
    > > Revert "Trigger a buildbot cycle on client.nacl.toolchain"
    > >
    > > This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
    > >
    > > Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
    > >
    > > Original change's description:
    > > > Trigger a buildbot cycle on client.nacl.toolchain
    > > >
    > > > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
    > > > [1].  The logs have since been deleted, so trigger another build so we can
    > > > review the failures in the logs.
    > > >
    > > > [1] https://build.chromium.org/p/client.nacl.toolchain/console
    > > >
    > > > BUG=None
    > > > TBR=thakis
    > > > NOTRY=true
    > > > NOPRESUBMIT=true
    > > >
    > > > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
    > > > Reviewed-on: https://chromium-review.googlesource.com/1132561
    > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > >
    > > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > >
    > > Change-Id: I629856581810be12abba20ecbedc95754c6fe325
    > > No-Presubmit: true
    > > No-Tree-Checks: true
    > > No-Try: true
    > > Bug: None
    > > Reviewed-on: https://chromium-review.googlesource.com/1134366
    > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    >
    > TBR=thakis@chromium.org,thomasanderson@chromium.org
    > NOTRY=true
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Bug: None
    > Change-Id: Ie71f8351bb500fd1e6d3f6443dff05be1a529004
    > Reviewed-on: https://chromium-review.googlesource.com/1139534
    > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    
    TBR=thakis@chromium.org,thomasanderson@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    NOTRY=true
    NOPRESUBMIT=true
    NOTREECHECKS=true
    Bug: None
    Change-Id: I9bd8fcb9d5dd19cfc5f704cf8adadd1a6337dd1d
    Reviewed-on: https://chromium-review.googlesource.com/1148840
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    

    Changed files

    • whitespace.txt
  33. Reland "Trigger a buildbot cycle on client.nacl.toolchain"

    Changed by Thomas Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Tuesday, 17-Jul-18 03:36:39 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision aebc9e5205dcaad5d5954a18abc532316a954644

    Comments

    Reland "Trigger a buildbot cycle on client.nacl.toolchain"
    
    This reverts commit e6ce828ef60c4c1438867b535efbbb5d9a177c0e.
    
    Reason for revert: The next thing has been fixed on bug 863140, so trigger another buildbot cycle.
    
    Original change's description:
    > Revert "Trigger a buildbot cycle on client.nacl.toolchain"
    >
    > This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
    >
    > Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
    >
    > Original change's description:
    > > Trigger a buildbot cycle on client.nacl.toolchain
    > >
    > > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
    > > [1].  The logs have since been deleted, so trigger another build so we can
    > > review the failures in the logs.
    > >
    > > [1] https://build.chromium.org/p/client.nacl.toolchain/console
    > >
    > > BUG=None
    > > TBR=thakis
    > > NOTRY=true
    > > NOPRESUBMIT=true
    > >
    > > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
    > > Reviewed-on: https://chromium-review.googlesource.com/1132561
    > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    >
    > TBR=thakis@chromium.org,thomasanderson@chromium.org
    >
    > Change-Id: I629856581810be12abba20ecbedc95754c6fe325
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: None
    > Reviewed-on: https://chromium-review.googlesource.com/1134366
    > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    
    TBR=thakis@chromium.org,thomasanderson@chromium.org
    NOTRY=true
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: None
    Change-Id: Ie71f8351bb500fd1e6d3f6443dff05be1a529004
    Reviewed-on: https://chromium-review.googlesource.com/1139534
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    

    Changed files

    • whitespace.txt
  34. Revert "Trigger a buildbot cycle on client.nacl.toolchain"

    Changed by Thomas Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:53:03 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision e6ce828ef60c4c1438867b535efbbb5d9a177c0e

    Comments

    Revert "Trigger a buildbot cycle on client.nacl.toolchain"
    
    This reverts commit 0ba35b21089a442dd4f25c35fd571d46cb4aa199.
    
    Reason for revert: Triggering another buildbot cycle to test if https://chromium-review.googlesource.com/c/chromium/tools/build/+/1133582 fixed the issue
    
    Original change's description:
    > Trigger a buildbot cycle on client.nacl.toolchain
    > 
    > The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
    > [1].  The logs have since been deleted, so trigger another build so we can
    > review the failures in the logs.
    > 
    > [1] https://build.chromium.org/p/client.nacl.toolchain/console
    > 
    > BUG=None
    > TBR=thakis
    > NOTRY=true
    > NOPRESUBMIT=true
    > 
    > Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
    > Reviewed-on: https://chromium-review.googlesource.com/1132561
    > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    
    TBR=thakis@chromium.org,thomasanderson@chromium.org
    
    Change-Id: I629856581810be12abba20ecbedc95754c6fe325
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: None
    Reviewed-on: https://chromium-review.googlesource.com/1134366
    Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    

    Changed files

    • whitespace.txt
  35. Trigger a buildbot cycle on client.nacl.toolchain

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 00:19:10 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 0ba35b21089a442dd4f25c35fd571d46cb4aa199

    Comments

    Trigger a buildbot cycle on client.nacl.toolchain
    
    The last commit (on June 15) had some buildbot failures on client.nacl.toolchain
    [1].  The logs have since been deleted, so trigger another build so we can
    review the failures in the logs.
    
    [1] https://build.chromium.org/p/client.nacl.toolchain/console
    
    BUG=None
    TBR=thakis
    NOTRY=true
    NOPRESUBMIT=true
    
    Change-Id: I7e4e725d97b6c2ed685bed666bf58cb440f20c66
    Reviewed-on: https://chromium-review.googlesource.com/1132561
    Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    

    Changed files

    • whitespace.txt
  36. cq: remove SignCLA check. Gerrit now enforces up pre-CL-upload.

    Changed by Andrii Shyshkalov - tandriiohnoyoudont@chromium.org
    Changed at Friday, 15-Jun-18 00:55:22 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 030b88a205c9ce9a82d68798bfaa059fd55216cd

    Comments

    cq: remove SignCLA check. Gerrit now enforces up pre-CL-upload.
    
    Gerrit SignCLA check was enabled in
    https://chromium.googlesource.com/native_client/src/native_client/+/a45590d5c7daa91f882c2212b9004a8ac5d19bc2
    
    R=mseaborn@chromium.org,thomasanderson@chromium.org
    TBR=sergiyb@chromium.org
    
    No-Try: True
    Bug: 796383
    Change-Id: Ie66b885b8f4f326716a16492238a97a409b48741
    Reviewed-on: https://chromium-review.googlesource.com/1096429
    Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    

    Changed files

    • infra/config/cq.cfg
  37. Remove manual references to exe_and_shlib_deps

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Wednesday, 06-Jun-18 19:04:16 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 82ff2ae08f20942bbb406d107ab42ff8d1d6fff4

    Comments

    Remove manual references to exe_and_shlib_deps
    
    After [1], a manual dependency on exe_and_shlib_deps is no longer necessary
    since it's automatically added.  This CL removes all remaining manual references
    to exe_and_shlib_deps.
    
    [1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5
    
    BUG=chromium:845700
    No-Try: True
    Change-Id: I8bfa37f5efbc0824c458532ee4f4c648df56b362
    Reviewed-on: https://chromium-review.googlesource.com/1087532
    Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    

    Changed files

    • src/nonsfi/loader/BUILD.gn
    • src/tools/tls_edit/BUILD.gn
    • src/trusted/debug_stub/BUILD.gn
    • src/trusted/service_runtime/BUILD.gn
    • src/trusted/validator/driver/BUILD.gn
  38. Fix arm build with glibc 2.27

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Tuesday, 15-May-18 23:18:13 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 93deff44b49fcbb4da0ee7961f21b6b93da194e9

    Comments

    Fix arm build with glibc 2.27
    
    On earlier versions of glibc, struct sigcontext was typedef'ed to mcontext_t.
    Now, it's an entirely separate struct.  Fortunately, the members are all the
    same, so a simple name change is all that's necessary.
    
    This CL should be compatible with glibc 2.27 as well as earlier versions.
    
    BUG=chromium:843240
    No-Try: True
    Change-Id: I30c3d5ad2a1da50f03308a4b273a2f824f966042
    Reviewed-on: https://chromium-review.googlesource.com/1060158
    Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    

    Changed files

    • src/trusted/service_runtime/linux/nacl_signal_arm.c
  39. nacl_switch_32.S: Add comment about alignment on Windows

    Changed by Hans Wennborg - hansohnoyoudont@chromium.org
    Changed at Thursday, 10-May-18 19:21:18 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision f9564e9d1b155097e5c88f292c01acbe1ddb21a4

    Comments

    nacl_switch_32.S: Add comment about alignment on Windows
    
    We spent some time in "how does this ever work" mode while tracking down
    NaCl test failures in builds linked with lld, which failed to apply the
    16-byte alignment to sections without explicit alignment.
    
    Bug: 837667
    No-Try: True
    Change-Id: I11698a33802e5096d1f69e389734df414e341f95
    Reviewed-on: https://chromium-review.googlesource.com/1046652
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: Roland McGrath <mcgrathr@chromium.org>
    

    Changed files

    • src/trusted/service_runtime/arch/x86_32/nacl_switch_32.S
  40. [Native Client] Update chrome extension test

    Changed by Devlin Cronin - rdevlin.croninohnoyoudont@chromium.org
    Changed at Friday, 30-Mar-18 18:10:32 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision ab8b219c8b5578b860f128087190d201fe55e84d

    Comments

    [Native Client] Update chrome extension test
    
    The extension in the chrome_extension test is using manifest v1, which
    has been deprecated for more than five years. Update it to manifest v2.
    
    NOTRY=true
    
    Bug:chromium:816679
    Change-Id: Ibab520e118db12cb084bd613584bcf7a387a57bf
    Reviewed-on: https://chromium-review.googlesource.com/988139
    Commit-Queue: Brad Nelson <bradnelson@chromium.org>
    Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    

    Changed files

    • tests/chrome_extension/background.html
    • tests/chrome_extension/background.js
    • tests/chrome_extension/manifest.json
  41. x86-64 Linux: don't update segment registers using the sig_ctx

    Changed by Andrew Bonventre - andybonsohnoyoudont@chromium.org
    Changed at Thursday, 15-Mar-18 23:24:45 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 303fc9961cb4231aa9828218362914ee4e51d16a

    Comments

    x86-64 Linux: don't update segment registers using the sig_ctx
    
    In some cases, the linux kernel considers the values set in
    mctx->gregs[REG_CSGSFS] to be invalid, preventing it from
    resuming execution of the process after the rt_sigreturn syscall
    and sending the process a SIGSEGV with an SI_KERNEL code.
    
    Some NaCl tests are failing on Mac and arm-hw-perf trybots,
    so committing with "No-Try: True".
    
    R=mseaborn@chromium.org
    BUG=https://crbug.com/nativeclient/4403
    
    No-Try: True
    Change-Id: I59726a7e8e7d898171a452433484a0502f93f647
    Reviewed-on: https://chromium-review.googlesource.com/962675
    Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    

    Changed files

    • src/trusted/service_runtime/linux/nacl_signal_64.c
  42. Fixing a broken include guard

    Changed by Daniel Bratell - bratellohnoyoudont@opera.com
    Changed at Wednesday, 28-Feb-18 20:20:02 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision d52121fcfeda7666d69d9df4b9d7a17bac3b61ac

    Comments

    Fixing a broken include guard
    
    Found when working on a PRESUBMIT check for include guards.
    
    Some NaCl tests are failing on Mac trybots, so committing with "No-Try: True".
    
    No-Try: True
    Change-Id: I387f1327fd4ed10925cd3b3368efb81537ff5f21
    Reviewed-on: https://chromium-review.googlesource.com/932663
    Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    

    Changed files

    • src/trusted/validator/validation_cache_internal.h
  43. Update revision for PNaCl

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Friday, 02-Feb-18 23:25:17 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 8ad1515975c09beebd2e9ea69c1f9c5ba88a5bbf

    Comments

    Update revision for PNaCl
    
    Update efa3f5d8ef135ed2463a75ac4630d1c448021400 -> b48266b051f596802addff7c8d1fc6fb9cf6bea7
    
    Pull the following PNaCl changes into NaCl:
      015356a: (dschuff@chromium.org) Update Breakpad and toolchain sysroots to Jessie
      fb5ad65: (dschuff@chromium.org) Update Goma command for toolchain host build
      ce62573: (dschuff@chromium.org) Fix CMake C_COMPILER_LAUNCHER command
      b48266b: (dschuff@chromium.org) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS
    
    BUG= <none>
    BUG= none
    R= dschuff@chromium.org
    TEST=git cl try
    (Please LGTM this change and tick the "commit" box)
    
    Change-Id: Ic0d41d928cda1f0211abcec271c34a40e350657a
    Reviewed-on: https://chromium-review.googlesource.com/900134
    Reviewed-by: Eric Holk <eholk@chromium.org>
    

    Changed files

    • toolchain_revisions/pnacl_newlib.json
    • toolchain_revisions/pnacl_newlib_raw.json
    • toolchain_revisions/pnacl_translator.json
  44. PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Friday, 02-Feb-18 18:51:39 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision b48266b051f596802addff7c8d1fc6fb9cf6bea7

    Comments

    PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS
    
    This pulls in the following LLVM change:
    
    35bf8e609e9: (dschuff@chromium.org) Fix the Mips LLVMBuild.txt
    
    BUG=none
    TEST= PNaCl toolchain trybots
    
    Change-Id: I75db4917bdd7a2c5be1c20772c5ca4dbc44f17c1
    Reviewed-on: https://chromium-review.googlesource.com/899645
    Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    

    Changed files

    • pnacl/COMPONENT_REVISIONS
  45. Update gsutil used by gsd_storage on the buildbots

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Friday, 02-Feb-18 17:01:35 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision e0b8bb536b18e91e42090c35bb3cb46dabca5032

    Comments

    Update gsutil used by gsd_storage on the buildbots
    
    TBR=bradnelson@chromium.org
    Bug: None
    Change-Id: I1bf129db820827e9868e00568cfcdc61ce65fd0c
    Reviewed-on: https://chromium-review.googlesource.com/898506
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • buildbot/buildbot_selector.py
  46. Fix CMake C_COMPILER_LAUNCHER command

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Thursday, 01-Feb-18 22:33:13 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision ce625737db63902c4c53c8731000f5a4e851fad5

    Comments

    Fix CMake C_COMPILER_LAUNCHER command
    
    It slipped through because libcxx only uses the CXX compiler.
    
    Bug: None
    Change-Id: Ifeb90fdf44214eaaa9b1c8acb729e89e8d858a03
    Reviewed-on: https://chromium-review.googlesource.com/898303
    Reviewed-by: Eric Holk <eholk@chromium.org>
    

    Changed files

    • toolchain_build/toolchain_build_pnacl.py
  47. Update Goma command for toolchain host build

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Thursday, 01-Feb-18 22:18:14 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision fb5ad65acaf6f1f974a6af764a59b8a794f2e0c7

    Comments

    Update Goma command for toolchain host build
    
    
    The goma on the bots no longer has the wrappers named after the compilers.
    
    Change-Id: Ie41d6ad4c76a401c715768407fb1c848673ab8de
    Reviewed-on: https://chromium-review.googlesource.com/897965
    Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    Commit-Queue: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • toolchain_build/toolchain_build_pnacl.py
  48. [ndk] Add android ndk deps in native_client/SConstruct

    Changed by Shenghua Zhang - shenghuazhangohnoyoudont@chromium.org
    Changed at Friday, 12-Jan-18 23:24:03 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 476698afdd0b114d72e6b4bde36691e5cc8b0bd6

    Comments

    [ndk] Add android ndk deps in native_client/SConstruct
    
    Because of the android sdk managed by CIPD (see go/use-adjective-apis),
    its deps repo ndk needs to be relocated to third_party/android_ndk.
    This CL changes the ndk root in native_client/SConstruct
    
    Bug: chromium:659808
    Change-Id: I9fecd5e72419f3a4544f9c588da708669f4aa851
    Reviewed-on: https://chromium-review.googlesource.com/858569
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • SConstruct
  49. Remove Rietveld CQ config.

    Changed by Andrii Shyshkalov - tandriiohnoyoudont@chromium.org
    Changed at Wednesday, 10-Jan-18 07:28:17 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision e09e6a3eadcc9a2e7f8fab8d653fb481e3ea075c

    Comments

    Remove Rietveld CQ config.
    
    Rietveld CQ has already been disabled and is no longer supoorted.
    
    TBR=sergiyb@chromium.org
    
    No-Try: True
    Bug: chromium:770592
    Change-Id: I4a5d44452edc09f9f69e092388f2414c0a5d0f4a
    Reviewed-on: https://chromium-review.googlesource.com/716836
    Commit-Queue: Derek Schuff <dschuff@chromium.org>
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • infra/config/cq.cfg
  50. Fix some -Wunreachable-code warnings in NaCl.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Friday, 29-Sep-17 18:36:49 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 7f07816e463da403255f0ab4f6d88004450dd09d

    Comments

    Fix some -Wunreachable-code warnings in NaCl.
    
    Bug: chromium:346399
    Change-Id: I9717adafa3ee53a6fc2d937717d34e35ce7c650a
    Reviewed-on: https://chromium-review.googlesource.com/680040
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    

    Changed files

    • src/shared/platform/win/nacl_exit.c
    • src/trusted/service_runtime/sel_ldr_standard.c
  51. Move GN arg delcarations into their own declare_args call

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Wednesday, 13-Sep-17 17:49:20 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision c5704931e21b54757b6e169c991a3e17b7890523

    Comments

    Move GN arg delcarations into their own declare_args call
    
    GN throws an error when they are declared and used in the same call.
    
    Bug: None
    Change-Id: I2eb5fdff585071a345d2765e91c69cb41180b685
    Reviewed-on: https://chromium-review.googlesource.com/665298
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • config.gni
  52. Implement readdir()

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Friday, 04-Aug-17 17:52:09 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 081ae0f5c1a70c28df835123ea7110b7600192bc

    Comments

    Implement readdir()
    
    This CL is needed because Chromium code is switching from readdir_r()
    to readdir().  It is a dependency CL of:
    https://chromium-review.googlesource.com/c/599120
    
    BUG=chromium:457759,chromium:751812
    R=bradnelson@chromium.org
    
    Change-Id: Id09ce31b1837d0dc3d4057397d50db2781cabd4d
    Reviewed-on: https://chromium-review.googlesource.com/600516
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
    

    Changed files

    • src/nonsfi/linux/directory.c
    • tests/nonsfi/directory_test.cc
  53. Add missing dependency on exe_and_shlib_deps

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Wednesday, 19-Jul-17 23:59:47 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 01a28a6069a98718184e31c10c5880496a1a9d95

    Comments

    Add missing dependency on exe_and_shlib_deps
    
    BUG=745773
    R=inglorion@chromium.org
    
    Change-Id: I9d21707a89ea3de34e4a87120c9dc86029ed3488
    Reviewed-on: https://chromium-review.googlesource.com/578136
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
    

    Changed files

    • src/nonsfi/loader/BUILD.gn
  54. Update Breakpad and toolchain sysroots to Jessie

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Saturday, 24-Jun-17 02:05:30 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 015356a98e4430dff9ce7e80ce9d2a62b04c2c4e

    Comments

    Update Breakpad and toolchain sysroots to Jessie
    
    Wheezy has been sent to the garage sale.
    
    Bug: None
    Change-Id: Ieb5fd991a08c4300174f113e749a3ede766e5eca
    Reviewed-on: https://chromium-review.googlesource.com/546948
    Reviewed-by: Sam Clegg <sbc@chromium.org>
    Commit-Queue: Sam Clegg <sbc@chromium.org>
    

    Changed files

    • buildbot/buildbot_standard.py
    • toolchain_build/toolchain_build_pnacl.py
  55. Reduce absolute paths in generated ninja files in NaCl

    Changed by Wei-Yin Chen (陳威尹) - wychenohnoyoudont@chromium.org
    Changed at Tuesday, 06-Jun-17 01:13:12 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision f88070127d32714df2714d94c9494fce951993d8

    Comments

    Reduce absolute paths in generated ninja files in NaCl
    
    BUG=chromium:723856
    NOTRY=true
    
    Change-Id: Ic9d0cca3fbc9b10edacd9de10e6d6e6ef5311f3e
    Reviewed-on: https://chromium-review.googlesource.com/513515
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    

    Changed files

    • src/trusted/service_runtime/linux/BUILD.gn
  56. Cleanup sel_ldr target

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Tuesday, 06-Jun-17 00:12:11 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision b1f13a7bdc7280b765cd821908fd75d7ea3b354a

    Comments

    Cleanup sel_ldr target
    
    sel_ldr removes the default_libs config, which adds dependencies on
    librt and libdl; it also adds the dependency on librt back.
    
    Now, libdl is needed for asan and msan builds, so this CL adds the
    default_libs config back.
    
    BUG=chromium:729820
    R=bradnelson@chromium.org
    NOTRY=true
    
    Change-Id: Ie6bd877597e565a015feaf433a46a6168c9393a2
    Reviewed-on: https://chromium-review.googlesource.com/518463
    Commit-Queue: Brad Nelson <bradnelson@chromium.org>
    Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    

    Changed files

    • src/trusted/service_runtime/BUILD.gn
  57. Replace sanitizers:deps with exe_and_shlib_deps (native_client)

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Tuesday, 23-May-17 06:16:25 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 3e3253af7d201e8793cca4f36c5163bdb58074c7

    Comments

    Replace sanitizers:deps with exe_and_shlib_deps (native_client)
    
    All targets (at least on sanitizer builds) unconditionally depend
    on //build/config/sanitizers:deps.
    
    It is necessary for bug 593874 that all targets now also depend
    on //buildtools/third_party/libc++:libcxx_proxy.  This requires
    adding a new "global dependency": //build/config:exe_and_shlib_deps.
    
    This CL updates references to sanitizers:deps to instead refer to
    //build/config:exe_and_shlib_deps.
    
    BUG=chromium:723069
    R=bradnelson@chromium.org
    NOTRY=true
    
    Change-Id: Id45d405c0eb79cf9d4d8375f04c3e69f9157671d
    Reviewed-on: https://chromium-review.googlesource.com/509938
    Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    Commit-Queue: Brad Nelson <bradnelson@chromium.org>
    

    Changed files

    • DEPS
    • src/tools/tls_edit/BUILD.gn
    • src/trusted/debug_stub/BUILD.gn
    • src/trusted/service_runtime/BUILD.gn
    • src/trusted/validator/driver/BUILD.gn
  58. Whitespace change to test the Autoroller via Gerrit

    Changed by Eric Boren - borenetohnoyoudont@google.com
    Changed at Wednesday, 12-Apr-17 18:48:26 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision d2e0e6c7942f6c7691cbb8dc1ecd41291544afea

    Comments

    Whitespace change to test the Autoroller via Gerrit
    
    Bug: skia:5787
    Change-Id: I189217fdeaad2b866211c452af7dd884454f19b5
    Reviewed-on: https://chromium-review.googlesource.com/475079
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    Commit-Queue: Mark Seaborn <mseaborn@chromium.org>
    

    Changed files

    • whitespace.txt
  59. Update revision for PNaCl

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Thursday, 30-Mar-17 20:44:24 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision aac1de245362df94cb40042e5fbc9059b0d0874b

    Comments

    Update revision for PNaCl
    
    Update 96401b521a92c91e9dac23b2e385656670ccd862 -> efa3f5d8ef135ed2463a75ac4630d1c448021400
    
    Pull the following PNaCl changes into NaCl:
      efa3f5d: (dschuff@chromium.org) Make pnacl-ld ignore --build-id flags
    
    BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4391
    R= dschuff@chromium.org, stichnot@chromium.org
    TEST=git cl try
    (Please LGTM this change and tick the "commit" box)
    
    Change-Id: I5e2f97b0ab9fb1274040472a47e6e3f104760815
    Reviewed-on: https://chromium-review.googlesource.com/463807
    Reviewed-by: Jim Stichnoth <stichnot@chromium.org>
    Commit-Queue: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • toolchain_revisions/pnacl_newlib.json
    • toolchain_revisions/pnacl_newlib_raw.json
    • toolchain_revisions/pnacl_translator.json
  60. Make pnacl-ld ignore --build-id flags

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Thursday, 30-Mar-17 18:37:48 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision efa3f5d8ef135ed2463a75ac4630d1c448021400

    Comments

    Make pnacl-ld ignore --build-id flags
    
    Previously native/translation-related linker flags were rejected by
    pnacl-ld to help users understand that they were meaningless for
    pexes. However it's easier to have the flags be uniform across
    architectures, and for the case of --build-id specifically, translated
    nexes have build IDs anyway. So make pnacl-ld igore this flag instead of
    rejecting it.
    
    R=stichnot@chromium.org
    BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4391
    
    Change-Id: I145158615443cec3c6bd4d225c82d170115a11ee
    Reviewed-on: https://chromium-review.googlesource.com/462065
    Reviewed-by: Jim Stichnoth <stichnot@chromium.org>
    

    Changed files

    • pnacl/driver/pnacl-ld.py
    • tests/toolchain/nacl.scons
    • toolchain_build/toolchain_build_pnacl.py
  61. Add newlines to NaClLog messages

    Changed by Sam Clegg - sbcohnoyoudont@chromium.org
    Changed at Tuesday, 28-Mar-17 23:42:04 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision b1766362259dca1984a765306f6a11030898fe83

    Comments

    Add newlines to NaClLog messages
    
    Change-Id: I7d1a0fc25ef892f4baf315510bd906679f794075
    Reviewed-on: https://chromium-review.googlesource.com/462024
    Reviewed-by: Ben Smith <binji@chromium.org>
    Commit-Queue: Sam Clegg <sbc@chromium.org>
    

    Changed files

    • src/shared/platform/posix/nacl_threads.c
  62. Update revision for PNaCl

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Friday, 24-Mar-17 17:14:10 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision c84029060e2aa88d98f774ccd6ccc89791d6cbb1

    Comments

    Update revision for PNaCl
    
    Update 62bfd122aee87d4eb4a7876950e18c793c626cd0 -> 96401b521a92c91e9dac23b2e385656670ccd862
    
    Pull the following PNaCl changes into NaCl:
      96401b5: (dschuff@chromium.org) Build PNaCl toolchain in Chromium sysroot
    
    BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4394
    TBR= bradnelson@chromium.org, stichnot@chromium.org
    TEST=git cl try
    (Please LGTM this change and tick the "commit" box)
    
    Change-Id: Id4421e0c54f3a0d3b03c356b72934e9f76d37afb
    Reviewed-on: https://chromium-review.googlesource.com/459064
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • toolchain_revisions/pnacl_newlib.json
    • toolchain_revisions/pnacl_newlib_raw.json
    • toolchain_revisions/pnacl_translator.json
  63. Build PNaCl toolchain in Chromium sysroot

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Friday, 24-Mar-17 04:03:31 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 96401b521a92c91e9dac23b2e385656670ccd862

    Comments

    Build PNaCl toolchain in Chromium sysroot
    
    Recently the PNaCl toolchain bots were upgraded to Ubuntu Trusty. However, many Chromium/ChromeOS
    buildbots (which use the PNaCl toolchain) still run Precise, and therefore cannot always run
    binaries built on Trusty. One solution is to build the toolchain using Chromium's sysroot,
    which has its own (older) versions of the system libraries, and should work on Precise systems.
    
    This pulls in the following Clang change:
    e34aaa1fd8: (dschuff@chromium.org) Allow disabling libXML in Clang's CMake build
    
    BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4394
    R=bradnelson@chromium.org
    
    Change-Id: I3e090edeaacfd4d94aa59b1b8096d784784b7660
    Reviewed-on: https://chromium-review.googlesource.com/458798
    Reviewed-by: Jim Stichnoth <stichnot@chromium.org>
    

    Changed files

    • pnacl/COMPONENT_REVISIONS
    • toolchain_build/toolchain_build_pnacl.py
  64. Don't pass --pnacl-use-emulator flag in trusted build environments

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Thursday, 23-Mar-17 21:54:31 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision f6448f768758e8f30e4de9092f20bd40226a719f

    Comments

    Don't pass --pnacl-use-emulator flag in trusted build environments
    
    Only untrusted (i.e. PNaCl) compilers use this flag.
    
    R=bradnelson@chromium.org
    BUG=Broken toolchain bot
    
    Change-Id: I1d168a0257a28e59f670ab86d94ff257539a9003
    Reviewed-on: https://chromium-review.googlesource.com/458535
    Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    Commit-Queue: Brad Nelson <bradnelson@chromium.org>
    

    Changed files

    • SConstruct
  65. Update revision for PNaCl

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Monday, 13-Mar-17 22:15:33 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 93a51ecd3c7873554c9f384167142e2c45edfefb

    Comments

    Update revision for PNaCl
    
    Update 5dfe030a71ca66e72c5719ef5034c2ed24706c43 -> 62bfd122aee87d4eb4a7876950e18c793c626cd0
    
    Pull the following PNaCl changes into NaCl:
      70540f6: (petar.jovanovic@rt-rk.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS
        | 63a5544: (petar.jovanovic@rt-rk.com) Cherry-pick r247546: [mips] Save a copy of MipsABIInfo ...
      42ae93a: (dschuff@chromium.org) PNaCl Driver: Accept argument to --build-id flag
    
    BUG= nativeclient:4391
    BUG= none
    R= dschuff@chromium.org, petar.jovanovic@rt-rk.com
    TEST=git cl try
    (Please LGTM this change and tick the "commit" box)
    
    Change-Id: I8ee3ff64678ea0b2f16a4a2199fc706e692de482
    Reviewed-on: https://chromium-review.googlesource.com/453878
    Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    

    Changed files

    • toolchain_revisions/pnacl_newlib.json
    • toolchain_revisions/pnacl_newlib_raw.json
    • toolchain_revisions/pnacl_translator.json
  66. Add test file missing from last commit

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Thursday, 09-Mar-17 17:13:27 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 62bfd122aee87d4eb4a7876950e18c793c626cd0

    Comments

    Add test file missing from last commit
    
    rev 42ae93 had a test but I forgot to 'git add' the expectation file.
    
    BUG=4391
    TBR=bradnelson@chromium.org
    
    Change-Id: I6401c4f9b11ae206457a5b57ebc3431fde20a626
    Reviewed-on: https://chromium-review.googlesource.com/452657
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • tests/toolchain/build_id_check_text
  67. PNaCl Driver: Accept argument to --build-id flag

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Thursday, 09-Mar-17 00:55:08 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 42ae93a39e49116f69e1a5b2056c55564a6309f0

    Comments

    PNaCl Driver: Accept argument to --build-id flag
    
    Currently we accept --build-id but not e.g. --build-id=sha1, which is
    supported by other tools. Make pnacl-ld and nativeld accept this variant
    and pass through to the underlying tools.
    
    BUG=nativeclient:4391
    
    Change-Id: I4ef61d44c530c2482d04ad8b69795355d77c0d50
    Reviewed-on: https://chromium-review.googlesource.com/451721
    Reviewed-by: Jim Stichnoth <stichnot@chromium.org>
    

    Changed files

    • pnacl/driver/nativeld.py
    • pnacl/driver/pnacl-ld.py
    • pnacl/driver/pnacl-translate.py
    • tests/toolchain/nacl.scons
    • toolchain_build/toolchain_build_pnacl.py
  68. [mips] fix register dump for MIPS arch

    Changed by Petar Jovanovic - petar.jovanovicohnoyoudont@rt-rk.com
    Changed at Wednesday, 22-Feb-17 19:03:32 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision c948e9b82582e695d16ee6696a484f82239a86d7

    Comments

    [mips] fix register dump for MIPS arch
    
    Previously, ConvertRegisters was not specialized for MIPS case and hence
    it did not correctly dump register state.
    This change fixes that.
    
    Change-Id: I082df4ebddccf9032e62a5d9a0f78b7b17e78cae
    Reviewed-on: https://chromium-review.googlesource.com/445819
    Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
    

    Changed files

    • src/untrusted/minidump_generator/minidump_generator.cc
  69. Update run_mig.py to take an optional --sdk argument.

    Changed by Erik Chen - erikchenohnoyoudont@chromium.org
    Changed at Tuesday, 21-Feb-17 21:31:44 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 81142aef3ec03dbc554e1cb0e22e4243e8aa69af

    Comments

    Update run_mig.py to take an optional --sdk argument.
    
    BUG=chromium:690734
    NOTRY=true
    
    Change-Id: I6e02fb029fe4591c0e30d6bcade57946da111637
    Reviewed-on: https://chromium-review.googlesource.com/441367
    Commit-Queue: Brad Nelson <bradnelson@chromium.org>
    Reviewed-by: Mark Mentovai <mark@chromium.org>
    Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    

    Changed files

    • src/trusted/service_runtime/BUILD.gn
    • src/trusted/service_runtime/osx/run_mig.py
  70. CQ config: add gerrit CQAbility verifier.

    Changed by Andrii Shyshkalov - tandriiohnoyoudont@chromium.org
    Changed at Friday, 17-Feb-17 09:43:52 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision ee10b35a44f89833c0048a2b242f1de734108411

    Comments

    CQ config: add gerrit CQAbility verifier.
    
    Goal is to ensure that unreviewed and untrusted code isn't sent through
    CQ to try bots, by accident or through malicious intent.
    
    R=agable@chromium.org,bradnelson@chromium.org
    BUG=chromium:692613
    NOTRY=True
    
    Change-Id: I3f725d4e9fee51e247adc40c20ace86ef2251f67
    Reviewed-on: https://chromium-review.googlesource.com/444184
    Commit-Queue: Brad Nelson <bradnelson@chromium.org>
    Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    

    Changed files

    • infra/config/cq.cfg
  71. PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS

    Changed by Petar Jovanovic - petar.jovanovicohnoyoudont@rt-rk.com
    Changed at Tuesday, 31-Jan-17 22:15:42 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 70540f6583440d4174e6d75743bb544cfbaaf204

    Comments

    PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS
    
    This pulls in the following LLVM change:
    
    63a5544: (petar.jovanovic@rt-rk.com) Cherry-pick r247546: [mips] Save a copy of MipsABIInfo ...
    
    BUG=none
    TEST= PNaCl toolchain trybots
    
    Change-Id: Iaf00b13f2f4164b047c6d21937daf1e8baec0745
    Reviewed-on: https://chromium-review.googlesource.com/435239
    Reviewed-by: Derek Schuff <dschuff@chromium.org>
    

    Changed files

    • pnacl/COMPONENT_REVISIONS
  72. Make Gerrit the default for native_client code reviews

    Changed by Aaron Gable - agableohnoyoudont@chromium.org
    Changed at Tuesday, 24-Jan-17 22:24:12 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision afa90269512fe22519d7a8445e0d54a177d63f42

    Comments

    Make Gerrit the default for native_client code reviews
    
    BUG=665593
    
    Change-Id: I9921166aeeaf5975a408c2fe339d03c732139785
    Reviewed-on: https://chromium-review.googlesource.com/430242
    Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    

    Changed files

    • codereview.settings
  73. Set bot names back to precise for trybots

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jan-17 06:08:13 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 94bbb858ca3830bcd56fb732cc6050608787f07e

    Comments

    Set bot names back to precise for trybots
    
    Infra is updating bots from Precise to Trusty and renaming them from 'precise' to 'linux'. The buildbots are finished but not the trybots. Rev 9f8fdd668b305511b605ee229533639c29a5222b updated the buildbot names but also some of the trybot names, so hack them back to 'precise' for now.
    
    R=bradnelson@google.com, bradnelson
    BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4388
    
    Review-Url: https://codereview.chromium.org/2624913002 .
    

    Changed files

    • buildbot/buildbot_selector.py
  74. Update revision for PNaCl

    Changed by Jim Stichnoth - stichnotohnoyoudont@chromium.org
    Changed at Monday, 09-Jan-17 22:42:11 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 026b76327c0c443fcf98064e315ca398c4b544d1

    Comments

    Update revision for PNaCl
    
    Update f7d719122cd7c2fe3ebc52e7c0b011c583bf3e9c -> 5dfe030a71ca66e72c5719ef5034c2ed24706c43
    
    Pull the following PNaCl changes into NaCl:
      a123a8b: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
        | 8fbddc6: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Randomly insert NOP
        | 3e37647: (capn@google.com) Abstract the ELFStreamer class.
        | 40fc819: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: nacl-other-intrinsics-mips merged to original file
        | 132ea7a: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Floating point support in ELF output
        | 41ce47c: (capn@google.com) Allow 64-bit code to be stored as ELF64.
        | 464df5b: (capn@google.com) Implement Microsoft x86-64 calling convention support.
        | cc6dea7: (jaydeep.patil@imgtec.com) [SubZero] Use DIV instruction instead of TargetHelperCall
        | 3b61d70: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: lowerUnreachable
        | cf9c12f: (jaydeep.patil@imgtec.com) [SubZero] lower float and double constants for MIPS
        | 8d16c1d: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Encoding of FP comparison instructions
        | 0465d02: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Intrinsic call Trap
        | d895447: (jaydeep.patil@imgtec.com) [SubZero] Fix floating-point comparison for MIPS
        | f5d8e09: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Remove duplicate functionalities
        | cadda79: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Instruction NOR, pseudoinstruction NOT
        | d27ce3d: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Intrinsic call Ctlz for i32
        | 6ee373f: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Fix floating point comparison crosstest
        | 0a7f99d: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Intrinsic call Cttz for i32
        | 86b60ef: (sagar.thakur@imgtec.com) [Subzero][MIPS32] Implements 64-bit shl, lshr, ashr for MIPS
        | 98405d3: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: lowerSelect for i64
        | 623f8ce: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Cross-testing enabled for MIPS32
        | 4c49b10: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Filling missing bits from genTargetHelperCallFor
        | 58eeedf: (jaydeep.patil@imgtec.com) Subzero, MIPS32: Binding intrablock labels, unconditional branch
        | 6fd9c0e: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Intrinsic calls Ctlz and Cttz for i64
        | 175cb13: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Intrinsic call Bswap for i16, i32 and i64
        | 6163c62: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: DIVU instruction encoding
        | b0f09fc: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: MOVZ instruction encoding
        | 70b6ed4: (sagar.thakur@imgtec.com) [Subzero][MIPS] Implement 64-bit integer compare operations
        | fe93fdd: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: SRAV instruction encoding
        | f53580b: (capn@google.com) Don't emit address size prefixes for native x86-64 ABI.
        | 269eed4: (sagar.thakur@imgtec.com) [Subzero][MIPS] Add RUN command line with -Om1 in test 64bit.pnacl.ll
        | 9309756: (sagar.thakur@imgtec.com) [Subzero][MIPS] Implement conditional branches with 64-bit integer compares
        | 958ddb7: (jaydeep.patil@imgtec.com) [SubZero] Vector types support for MIPS
        | 033dda7: (stichnot@chromium.org) Subzero: Remove --skip-unimplemented from ARM lit tests.
        | afe5fe2: (makdstefan@gmail.com) Subzero, MIPS32: Fix conditional mov instructions
        | 533a514: (stichnot@chromium.org) Subzero: Fix "make -f Makefile.standalone check-lit FORCEASM=1".
        | acfb3df: (capn@google.com) Implement intrinsics for loading/storing subvectors.
        | 71c6937: (capn@google.com) Optimize lowering of x86 byte and word vector unpack.
        | b093539: (capn@google.com) Optimize x86 vector shift by constant.
        | 46f4fea: (capn@google.com) Support running unit tests on Windows.
        | b001cc4: (sagar.thakur@imgtec.com) [Subzero][MIPS32] Implement bitcast operation for both 32-bit and 64-bit operands
      d564ff3: (petarj@mips.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS
        | 5a87509: (kschimpf@google.com) Create one-off tool pnacl-hack-memset
        | 1d79adf: (petar.jovanovic@rt-rk.com) Cherry-pick r237153: [Mips] Return false for isFPCloseToIncomingSP()
        | 7251d5b: (petar.jovanovic@rt-rk.com) Cherry-pick r246309: [mips] Remove incorrect DebugLoc entries from prologue
      cb27d1f: (petarj@mips.com) [MIPS] Remove explicit masks from assembly code
      01d3ae0: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
        | ec92917: (jaydeep.patil@imgtec.com) [SubZero] Legalize load, store for MIPS post lower
        | 4683237: (sagar.thakur@imgtec.com) [Subzero][MIPS32] Fix alloca alignment and offset for Om1 and O2 optimization
        | 45e4d5e: (jaydeep.patil@imgtec.com) [SubZero] Handle relocatable constants for MIPS
        | 3a01f33: (jaydeep.patil@imgtec.com) [SubZero] Implement Fcmp, ICmp, Cast and Select for vector type
        | f52cea4: (capn@google.com) Fix unpacking from a single vector.
        | 7638e27: (capn@google.com) Add x86 vector packing instructions.
        | 0e90622: (capn@google.com) Generate error on unexpected intrisics.
        | 89be887: (sagar.thakur@imgtec.com) [Subzero][MIPS32] Account for variable alloca alignment bytes in addProlog
        | 1448d95: (capn@google.com) Optimize shuffles corresponding to x86 punpckh instructions.
        | 7145e69: (stichnot@chromium.org) Subzero: Fix compiler warnings.
        | 32f9cce: (capn@google.com) Fix 64-bit pointer type for non-x32 ABIs.
        | ef8210d: (capn@google.com) Implement vector packing intrinsics.
        | 8b8af82: (capn@google.com) Implement bitcast between i32 and (emulated) v4i8.
        | e3cabda: (capn@google.com) Implement vector sign mask intrinsic.
        | d0e3030: (capn@google.com) Assert that PNaCl bitcode only uses 128-bit vector casts.
        | c9e91af: (capn@google.com) Remove verified asserts.
        | 61593fb: (capn@google.com) Fix unit tests.
        | a3688ea: (capn@google.com) Fix two-vector unpack case.
        | a7979bf: (jaydeep.patil@imgtec.com) [SubZero] Fix f64 to/from i64 moves
        | 0dabe18: (makdstefan@gmail.com) Subzero, MIPS32: Remove --skip-unimplemented from lit tests
        | 130aca7: (jaydeep.patil@imgtec.com) [SubZero] Generate relocations for MIPS
        | 73ae4fd: (capn@google.com) Preserve rsi and rdi when using Microsoft x86-64 calling convention.
        | 7ad028e: (makdstefan@gmail.com) This patch enables running a couple more of lit tests for MIPS32
        | 956cfd6: (capn@google.com) Generalize the Sqrt intrinsic to process vectors.
        | 13cde0f: (capn@google.com) Implement integer vector multiply intrinsics.
        | 67a49b5: (capn@google.com) Implement saturated vector add/subtract.
        | 0c4c07d: (jaydeep.patil@imgtec.com) [SubZero] Fix code generation for vector type
        | f8c9977: (makdstefan@gmail.com) Subzero, MIPS32: Stacksave/Stackrestore implementation
        | f0d12c3: (capn@google.com) Implement floating-point rounding intrinsic.
        | 3da9f65: (jaydeep.patil@imgtec.com) [SubZero] Generate MIPS.abiflags section
        | 21f78bb: (jaydeep.patil@imgtec.com) [SubZero] Utilize instructions with immediate operands
        | 83425de: (capn@google.com) Support 64-bit jump tables with LP64 data model.
        | 6e03343: (makdstefan@gmail.com) Subzero, MIPS32: Sandbox initial patch
        | becb85f: (sagar.thakur@imgtec.com) [Subzero][MIPS] Implements atomic intrinsics for MIPS32
        | 8208e75: (makdstefan@gmail.com) Subzero, MIPS32: Changes for improving sandbox crosstest results
        | 2220990: (capn@google.com) Fix offset adjustment in x86 address optimization.
        | ef18fc5: (capn@google.com) Match sub-vector load/store operand order to regular load/store.
        | 8be6975: (jaydeep.patil@imgtec.com) [SubZero] Fix size of arguments on stack
        | e1e1783: (capn@google.com) Fix skipping deleted instructions before replacing operands.
        | a29da90: (capn@google.com) Ensure that the sub-vector load destination is a register.
        | 579b1b3: (capn@google.com) Generalize vector shuffling to accept any operand.
        | 373913f: (stichnot@chromium.org) Subzero: Legalize the movzx argument.
        | 35bbca3: (stichnot@chromium.org) Subzero: Fix multiply defined symbols in Windows/g++ build.
      5dfe030: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
    
    BUG= <none>
    BUG= none
    BUG= pnacl-llc aborts on run_vector_extension_test for MIPS
    BUG= swiftshader:15
    BUG= swiftshader:24
    R=dschuff@chromium.org, petarj@mips.com, stichnot@chromium.org
    TEST=git cl try
    (Please LGTM this change and tick the "commit" box)
    
    Review-Url: https://codereview.chromium.org/2623603002 .
    

    Changed files

    • toolchain_revisions/pnacl_newlib.json
    • toolchain_revisions/pnacl_newlib_raw.json
    • toolchain_revisions/pnacl_translator.json
  75. PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS

    Changed by Jim Stichnoth - stichnotohnoyoudont@chromium.org
    Changed at Monday, 09-Jan-17 16:49:49 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 5dfe030a71ca66e72c5719ef5034c2ed24706c43

    Comments

    PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
    
    This pulls in the following Subzero changes:
    
    f8c695b3: (stichnot@chromium.org) Subzero: Fix a build issue against LLVM trunk.
    79810753: (stichnot@chromium.org) Subzero: Fix some build problems against LLVM trunk.
    d722ff20: (stichnot@chromium.org) Subzero: Fix build problem against LLVM trunk.
    c78be4ec: (stichnot@chromium.org) Subzero: Fix a build error against LLVM trunk.
    f2c91aa5: (capn@google.com) Fix inadvertent use of the Microsoft x86-64 calling convention.
    4b1bdae3: (capn@google.com) Fix Mac OS compilation.
    
    BUG=none
    TEST= PNaCl toolchain trybots
    R=dschuff@chromium.org
    
    Review-Url: https://codereview.chromium.org/2615363003 .
    

    Changed files

    • pnacl/COMPONENT_REVISIONS
  76. PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS

    Changed by Jim Stichnoth - stichnotohnoyoudont@chromium.org
    Changed at Wednesday, 04-Jan-17 07:04:41 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 01d3ae00d277726b8aaee572120a5ba2a31d511e

    Comments

    PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
    
    This pulls in the following Subzero changes:
    
    ec92917: (jaydeep.patil@imgtec.com) [SubZero] Legalize load, store for MIPS post lower
    4683237: (sagar.thakur@imgtec.com) [Subzero][MIPS32] Fix alloca alignment and offset for Om1 and O2 optimization
    45e4d5e: (jaydeep.patil@imgtec.com) [SubZero] Handle relocatable constants for MIPS
    3a01f33: (jaydeep.patil@imgtec.com) [SubZero] Implement Fcmp, ICmp, Cast and Select for vector type
    f52cea4: (capn@google.com) Fix unpacking from a single vector.
    7638e27: (capn@google.com) Add x86 vector packing instructions.
    0e90622: (capn@google.com) Generate error on unexpected intrisics.
    89be887: (sagar.thakur@imgtec.com) [Subzero][MIPS32] Account for variable alloca alignment bytes in addProlog
    1448d95: (capn@google.com) Optimize shuffles corresponding to x86 punpckh instructions.
    7145e69: (stichnot@chromium.org) Subzero: Fix compiler warnings.
    32f9cce: (capn@google.com) Fix 64-bit pointer type for non-x32 ABIs.
    ef8210d: (capn@google.com) Implement vector packing intrinsics.
    8b8af82: (capn@google.com) Implement bitcast between i32 and (emulated) v4i8.
    e3cabda: (capn@google.com) Implement vector sign mask intrinsic.
    d0e3030: (capn@google.com) Assert that PNaCl bitcode only uses 128-bit vector casts.
    c9e91af: (capn@google.com) Remove verified asserts.
    61593fb: (capn@google.com) Fix unit tests.
    a3688ea: (capn@google.com) Fix two-vector unpack case.
    a7979bf: (jaydeep.patil@imgtec.com) [SubZero] Fix f64 to/from i64 moves
    0dabe18: (makdstefan@gmail.com) Subzero, MIPS32: Remove --skip-unimplemented from lit tests
    130aca7: (jaydeep.patil@imgtec.com) [SubZero] Generate relocations for MIPS
    73ae4fd: (capn@google.com) Preserve rsi and rdi when using Microsoft x86-64 calling convention.
    7ad028e: (makdstefan@gmail.com) This patch enables running a couple more of lit tests for MIPS32
    956cfd6: (capn@google.com) Generalize the Sqrt intrinsic to process vectors.
    13cde0f: (capn@google.com) Implement integer vector multiply intrinsics.
    67a49b5: (capn@google.com) Implement saturated vector add/subtract.
    0c4c07d: (jaydeep.patil@imgtec.com) [SubZero] Fix code generation for vector type
    f8c9977: (makdstefan@gmail.com) Subzero, MIPS32: Stacksave/Stackrestore implementation
    f0d12c3: (capn@google.com) Implement floating-point rounding intrinsic.
    3da9f65: (jaydeep.patil@imgtec.com) [SubZero] Generate MIPS.abiflags section
    21f78bb: (jaydeep.patil@imgtec.com) [SubZero] Utilize instructions with immediate operands
    83425de: (capn@google.com) Support 64-bit jump tables with LP64 data model.
    6e03343: (makdstefan@gmail.com) Subzero, MIPS32: Sandbox initial patch
    becb85f: (sagar.thakur@imgtec.com) [Subzero][MIPS] Implements atomic intrinsics for MIPS32
    8208e75: (makdstefan@gmail.com) Subzero, MIPS32: Changes for improving sandbox crosstest results
    2220990: (capn@google.com) Fix offset adjustment in x86 address optimization.
    ef18fc5: (capn@google.com) Match sub-vector load/store operand order to regular load/store.
    8be6975: (jaydeep.patil@imgtec.com) [SubZero] Fix size of arguments on stack
    e1e1783: (capn@google.com) Fix skipping deleted instructions before replacing operands.
    a29da90: (capn@google.com) Ensure that the sub-vector load destination is a register.
    579b1b3: (capn@google.com) Generalize vector shuffling to accept any operand.
    373913f: (stichnot@chromium.org) Subzero: Legalize the movzx argument.
    35bbca3: (stichnot@chromium.org) Subzero: Fix multiply defined symbols in Windows/g++ build.
    
    BUG= swiftshader:24
    BUG= swiftshader:9
    BUG= swiftshader:22
    BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4384
    BUG= swiftshader:15
    TEST= PNaCl toolchain trybots
    R=dschuff@chromium.org
    
    Review-Url: https://codereview.chromium.org/2602613002 .
    

    Changed files

    • pnacl/COMPONENT_REVISIONS
  77. Replace linux buildbot names in buildbot_selector

    Changed by Derek Schuff - dschuffohnoyoudont@chromium.org
    Changed at Tuesday, 03-Jan-17 19:28:25 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 9f8fdd668b305511b605ee229533639c29a5222b

    Comments

    Replace linux buildbot names in buildbot_selector
    
    There are no longer any precise/lucid bots, AFAIK everything is Trusty
    now, and the builder names are now all "linux" instead of the particular
    version name.
    
    BUG=None
    R=bradnelson@chromium.org, bradnelson
    
    Review-Url: https://codereview.chromium.org/2611733002 .
    

    Changed files

    • buildbot/buildbot_selector.py
  78. Fix native_client/PRESUBMIT.py .

    Changed by stichnot - stichnotohnoyoudont@chromium.org
    Changed at Tuesday, 03-Jan-17 18:44:10 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 25f277533941cf6c733ff70ae3e7713423ba60f2

    Comments

    Fix native_client/PRESUBMIT.py .
    
    A depot_tools change - https://codereview.chromium.org/2394043002 - requires a corresponding change in our PRESUBMIT.py .
    
    Doing a "git cl try" is enough to trigger the problem.
    
    BUG= none
    NOTRY=true
    
    Review-Url: https://codereview.chromium.org/2600453006
    

    Changed files

    • PRESUBMIT.py
  79. [MIPS] Remove explicit masks from assembly code

    Changed by petarj - petarjohnoyoudont@mips.com
    Changed at Wednesday, 23-Nov-16 17:05:50 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision cb27d1fd35d71dce84de1458243f19ef23868f75

    Comments

    [MIPS] Remove explicit masks from assembly code
    
    Remove explicit masks from assembly files, since the assembler auto-
    sandboxes it.
    Code clean-up, no functional change.
    
    NOTRY=true
    
    Review-Url: https://codereview.chromium.org/2521263002
    

    Changed files

    • pnacl/support/setjmp_mips32.S
    • tests/infoleak/test_infoleak_mips.S
    • tests/math/set_rounding_mips.S
    • tests/math/test_snan_no_signal_mips.S
  80. Revert of Change some source_sets to static_library to shrink binary (patchset #1 id:1 of https://codereview.chromium.org/2519103003/ )

    Changed by brucedawson - brucedawsonohnoyoudont@chromium.org
    Changed at Tuesday, 22-Nov-16 21:32:30 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision e4a9254d3505ec07c15bb40597136e0062bec9dc

    Comments

    Revert of Change some source_sets to static_library to shrink binary (patchset #1 id:1 of https://codereview.chromium.org/2519103003/ )
    
    Reason for revert:
    It looks like this fails when rolled into Chromium, with this error:
    
    Undefined symbols for architecture x86_64:
      "_NaClSwitch", referenced from:
          _NaClSyscallSegRegsSaved in nacl_syscall_64.o
         (maybe you meant: _NaClSwitchAVX, _NaClSwitchSSE )
      "_nacl_current_thread_tls_offset", referenced from:
          _NaClSyscallSeg in nacl_syscall_64.o
          _NaClGetTlsFastPath1 in nacl_syscall_64.o
          _NaClGetTlsFastPath1End in nacl_syscall_64.o
    ld: symbol(s) not found for architecture x86_64
    
    from:
    https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_com...
    https://codereview.chromium.org/2523593005/
    
    with these gn settings:
    
    goma_dir = "/b/c/cipd/goma"
    is_component_build = true
    is_debug = true
    symbol_level = 1
    use_goma = true
    
    Original issue's description:
    > Change some source_sets to static_library to shrink binary
    >
    > The gn generated binaries are bigger than the gyp generated binaries.
    > One of the known differences was due to the nacl_global_rng and
    > g_NaCl_log_gio global variables which are in gn's chrome.dll but not in
    > gyp's. In some cases these global variables can serve as effective
    > canaries - removing them can lead to much code going away as well.
    >
    > Changing from source_set to static_library means that the linker is not
    > required to link in the associated .obj files, which can save time and
    > space.
    >
    > In this case no code was removed so the space savings was small - just
    > the 1.5 KB of space consumed by the globals.
    >
    > R=phosek@chromium.org
    > BUG=630755
    >
    > Committed: https://chromium.googlesource.com/native_client/src/native_client/+/508aaa7b011729ee6eaab3384b89a7bfd0ecba73
    
    TBR=phosek@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=630755
    
    Review-Url: https://codereview.chromium.org/2525583003
    

    Changed files

    • src/trusted/service_runtime/BUILD.gn
    • src/trusted/validator_x86/BUILD.gn
  81. Change some source_sets to static_library to shrink binary

    Changed by brucedawson - brucedawsonohnoyoudont@chromium.org
    Changed at Tuesday, 22-Nov-16 18:47:44 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 508aaa7b011729ee6eaab3384b89a7bfd0ecba73

    Comments

    Change some source_sets to static_library to shrink binary
    
    The gn generated binaries are bigger than the gyp generated binaries.
    One of the known differences was due to the nacl_global_rng and
    g_NaCl_log_gio global variables which are in gn's chrome.dll but not in
    gyp's. In some cases these global variables can serve as effective
    canaries - removing them can lead to much code going away as well.
    
    Changing from source_set to static_library means that the linker is not
    required to link in the associated .obj files, which can save time and
    space.
    
    In this case no code was removed so the space savings was small - just
    the 1.5 KB of space consumed by the globals.
    
    R=phosek@chromium.org
    BUG=630755
    
    Review-Url: https://codereview.chromium.org/2519103003
    

    Changed files

    • src/trusted/service_runtime/BUILD.gn
    • src/trusted/validator_x86/BUILD.gn
  82. Enable Gerrit CQ for native_client

    Changed by Aaron Gable - agableohnoyoudont@chromium.org
    Changed at Tuesday, 22-Nov-16 06:18:43 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 0846b7b2d30809fd8b1cc29ff80a769fb741bc59

    Comments

    Enable Gerrit CQ for native_client
    
    BUG=chromium:665593
    
    Change-Id: I1473191a3a1146da860a7309690add1058ca9988
    Reviewed-on: https://chromium-review.googlesource.com/412927
    Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    

    Changed files

    • infra/config/cq.cfg
  83. Make GOMA_DIR injected from env.

    Changed by yyanagisawa - yyanagisawaohnoyoudont@chromium.org
    Changed at Monday, 14-Nov-16 16:14:16 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 163dfeb43e76995b4265ecd4e78670f7dd432e44

    Comments

    Make GOMA_DIR injected from env.
    
    Also,
    if NOCONTROL_GOMA environment is set, the script will not start/stop goma compiler_proxy.  I am going to make goma recipe module start/stop goma compiler_proxy in the future, and the environment will be used at that time.
    
    BUG=663630
    
    Review-Url: https://codereview.chromium.org/2486313003
    

    Changed files

    • buildbot/buildbot_pnacl_toolchain.py
  84. mips: run a faster version of the barebones_regs test

    Changed by petarj - petarjohnoyoudont@mips.com
    Changed at Tuesday, 08-Nov-16 23:15:28 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 3d513f39fafc2f24b10a98d2ceee7dd0599474a5

    Comments

    mips: run a faster version of the barebones_regs test
    
    Run a faster version of the test that gets selected with -DSMALL_REGS_TEST.
    This prevents timeout failure on MIPS HW.
    
    BUG= barebones_regs test times out on MIPS HW
    TEST= run_barebones_regs_test on MIPS HW
    
    Review-Url: https://codereview.chromium.org/2490593002
    

    Changed files

    • tests/barebones/nacl.scons
  85. PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS

    Changed by petarj - petarjohnoyoudont@mips.com
    Changed at Monday, 07-Nov-16 02:09:18 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision d564ff3bb6562a4f39249c57fc264a77d6aecd94

    Comments

    PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS
    
    This pulls in the following LLVM changes:
    
    5a87509: (kschimpf@google.com) Create one-off tool pnacl-hack-memset
    1d79adf: (petar.jovanovic@rt-rk.com) Cherry-pick r237153: [Mips] Return false for isFPCloseToIncomingSP()
    7251d5b: (petar.jovanovic@rt-rk.com) Cherry-pick r246309: [mips] Remove incorrect DebugLoc entries from prologue
    
    BUG= pnacl-llc aborts on run_vector_extension_test for MIPS
    BUG= gdb_print_symbol and gdb_stack_trace tests fail on MIPS HW
    TEST= PNaCl toolchain trybots
    
    Review-Url: https://codereview.chromium.org/2479683005
    

    Changed files

    • pnacl/COMPONENT_REVISIONS
  86. [MIPS] skip building vcpuid

    Changed by petarj - petarjohnoyoudont@mips.com
    Changed at Saturday, 05-Nov-16 00:26:10 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 63d17e18381bd2859a0d68cc37b4fc0e0bdfc3d4

    Comments

    [MIPS] skip building vcpuid
    
    Skip building vcpuid library for MIPS32 and fix Chromium build error.
    
    BUG= build breakage for MIPS32
    TEST= ninja -C out/mips32 all
    
    Review-Url: https://codereview.chromium.org/2459403002
    

    Changed files

    • src/trusted/platform_qualify/BUILD.gn
  87. win: Remove workaround for clang-cl that's no longer necessary.

    Changed by thakis - thakisohnoyoudont@chromium.org
    Changed at Friday, 28-Oct-16 21:24:37 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision bba323f75e3d20d2d496a1986f91fc81b624affa

    Comments

    win: Remove workaround for clang-cl that's no longer necessary.
    
    clang-cl now understands enough of `#pragma intrinsic` that it's no longer
    necessary to explicitly include intrin.h to use SecureZeroMemory().
    Reverts https://codereview.chromium.org/2070533002
    
    BUG=chromium:592745
    
    Review-Url: https://codereview.chromium.org/2453583002
    

    Changed files

    • src/shared/platform/win/nacl_secure_random.c
  88. Roll build_rev and binutils_rev to latest chromium revision

    Changed by sbc - sbcohnoyoudont@chromium.org
    Changed at Friday, 28-Oct-16 17:31:47 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 631223764fe3ebe0de2b8109b75015abe56e34ed

    Comments

    Roll build_rev and binutils_rev to latest chromium revision
    
    BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4381
    
    Review-Url: https://codereview.chromium.org/2456233002
    

    Changed files

    • DEPS
  89. Update and fix some markdown docs

    Changed by sbc - sbcohnoyoudont@chromium.org
    Changed at Friday, 28-Oct-16 17:01:49 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision c1a895441f553a1a239810cdbde15d52e23fa6e3

    Comments

    Update and fix some markdown docs
    
    Most importantly the checkout instructions were not rendering
    correctly at:
     https://chromium.googlesource.com/native_client/src/native_client/+/master/docs/source.md
    
    Review-Url: https://codereview.chromium.org/2457813002
    

    Changed files

    • docs/build_systems.md
    • docs/chromium_integration.md
    • docs/gyp_build.md
    • docs/native_client_in_google_chrome.md
    • docs/source.md
  90. Remove old tools used by gyp build

    Changed by sbc - sbcohnoyoudont@chromium.org
    Changed at Friday, 28-Oct-16 16:16:22 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision b51481557b9ea3e0484523277d30e8c426004210

    Comments

    Remove old tools used by gyp build
    
    BUG=
    
    Review-Url: https://codereview.chromium.org/2455783004
    

    Changed files

    • build/build_nexe.py
    • build/compiler_version.py
    • build/detect_nacl_host_arch.py
    • build/scan_sources.py
    • build/test_build.py
    • build/testtar.tgz
  91. Disable pll_loader_test on arm hardware.

    Changed by bradnelson - bradnelsonohnoyoudont@chromium.org
    Changed at Saturday, 15-Oct-16 01:40:44 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 0ed980949e515a40fa79147e7f1cda70c56cf536

    Comments

    Disable pll_loader_test on arm hardware.
    
    BUG=None
    TEST=None
    R=smklein@chromium.org
    
    Review-Url: https://codereview.chromium.org/2421903004
    

    Changed files

    • tests/pnacl_dynamic_loading/nacl.scons
  92. Disable GN build on Vista-64.

    Changed by bradnelson - bradnelsonohnoyoudont@chromium.org
    Changed at Friday, 14-Oct-16 18:18:51 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 3559b3b3a0f788c71a8ec40e69ba0d490911e7aa

    Comments

    Disable GN build on Vista-64.
    
    BUG=None
    TEST=None
    TBR=dschuff@chromium.org
    NOTRY=true
    
    Review-Url: https://codereview.chromium.org/2420943003
    

    Changed files

    • buildbot/buildbot_selector.py
  93. Fix breakpad 32-bit build.

    Changed by bradnelson - bradnelsonohnoyoudont@chromium.org
    Changed at Friday, 14-Oct-16 17:35:58 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision c9a4a41cfda34cc5aedb2228896038168e7df22a

    Comments

    Fix breakpad 32-bit build.
    
    BUG=None
    TEST=None
    TBR=dschuff@chromium.org
    NOTRY=true
    
    Review-Url: https://codereview.chromium.org/2416173004
    

    Changed files

    • buildbot/buildbot_standard.py
  94. Revert use of hexfloat for wasm in spec2k tests.

    Changed by bradnelson - bradnelsonohnoyoudont@chromium.org
    Changed at Friday, 14-Oct-16 00:58:36 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision 146dca688cbdd6efc4d7d6b7a965706a95ea186b

    Comments

    Revert use of hexfloat for wasm in spec2k tests.
    
    Reverting the hexfloat portions of:
    https://codereview.chromium.org/2244023002/
    
    TBR=dschuff@chromium.org
    NOTRY=true
    NOPRESUBMIT=true
    BUG=
    
    Review-Url: https://codereview.chromium.org/2417803003
    

    Changed files

    • tests/spec2k/175.vpr/diff
    • tests/spec2k/175.vpr/diff.README
    • tests/spec2k/175.vpr/run.ref.sh
    • tests/spec2k/175.vpr/run.test.sh
    • tests/spec2k/175.vpr/run.train.sh
  95. Plumb use_system_xcode through native client.

    Changed by erikchen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 13-Oct-16 23:57:54 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision cb2b66010be5078b3c533be58727c7f474cfd20c

    Comments

    Plumb use_system_xcode through native client.
    
    NOTRY=true
    BUG=chromium:651267
    
    Review-Url: https://codereview.chromium.org/2393473002
    

    Changed files

    • src/trusted/service_runtime/BUILD.gn
    • src/trusted/service_runtime/osx/run_mig.py
  96. Update chrome_rev

    Changed by Roland McGrath - mcgrathrohnoyoudont@chromium.org
    Changed at Wednesday, 12-Oct-16 23:21:45 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision be714d07cf63b5e59921348fa1d2a5e9dc3059e5

    Comments

    Update chrome_rev
    
    This updates chrome_rev and dependent entries in DEPS.
    
    BUG= none
    R=erikchen@chromium.org
    
    Review URL: https://codereview.chromium.org/2410163005 .
    

    Changed files

    • DEPS
  97. PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS

    Changed by Jim Stichnoth - stichnotohnoyoudont@chromium.org
    Changed at Wednesday, 12-Oct-16 22:00:03 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision a123a8b25857b7402198308a6b42a5172dac30c1

    Comments

    PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
    
    This pulls in the following Subzero changes:
    
    8fbddc6: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Randomly insert NOP
    3e37647: (capn@google.com) Abstract the ELFStreamer class.
    40fc819: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: nacl-other-intrinsics-mips merged to original file
    132ea7a: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Floating point support in ELF output
    41ce47c: (capn@google.com) Allow 64-bit code to be stored as ELF64.
    464df5b: (capn@google.com) Implement Microsoft x86-64 calling convention support.
    cc6dea7: (jaydeep.patil@imgtec.com) [SubZero] Use DIV instruction instead of TargetHelperCall
    3b61d70: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: lowerUnreachable
    cf9c12f: (jaydeep.patil@imgtec.com) [SubZero] lower float and double constants for MIPS
    8d16c1d: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Encoding of FP comparison instructions
    0465d02: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Intrinsic call Trap
    d895447: (jaydeep.patil@imgtec.com) [SubZero] Fix floating-point comparison for MIPS
    f5d8e09: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Remove duplicate functionalities
    cadda79: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Instruction NOR, pseudoinstruction NOT
    d27ce3d: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Intrinsic call Ctlz for i32
    6ee373f: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Fix floating point comparison crosstest
    0a7f99d: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Intrinsic call Cttz for i32
    86b60ef: (sagar.thakur@imgtec.com) [Subzero][MIPS32] Implements 64-bit shl, lshr, ashr for MIPS
    98405d3: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: lowerSelect for i64
    623f8ce: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Cross-testing enabled for MIPS32
    4c49b10: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Filling missing bits from genTargetHelperCallFor
    58eeedf: (jaydeep.patil@imgtec.com) Subzero, MIPS32: Binding intrablock labels, unconditional branch
    6fd9c0e: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Intrinsic calls Ctlz and Cttz for i64
    175cb13: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Intrinsic call Bswap for i16, i32 and i64
    6163c62: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: DIVU instruction encoding
    b0f09fc: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: MOVZ instruction encoding
    70b6ed4: (sagar.thakur@imgtec.com) [Subzero][MIPS] Implement 64-bit integer compare operations
    fe93fdd: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: SRAV instruction encoding
    f53580b: (capn@google.com) Don't emit address size prefixes for native x86-64 ABI.
    269eed4: (sagar.thakur@imgtec.com) [Subzero][MIPS] Add RUN command line with -Om1 in test 64bit.pnacl.ll
    9309756: (sagar.thakur@imgtec.com) [Subzero][MIPS] Implement conditional branches with 64-bit integer compares
    958ddb7: (jaydeep.patil@imgtec.com) [SubZero] Vector types support for MIPS
    033dda7: (stichnot@chromium.org) Subzero: Remove --skip-unimplemented from ARM lit tests.
    afe5fe2: (makdstefan@gmail.com) Subzero, MIPS32: Fix conditional mov instructions
    533a514: (stichnot@chromium.org) Subzero: Fix "make -f Makefile.standalone check-lit FORCEASM=1".
    acfb3df: (capn@google.com) Implement intrinsics for loading/storing subvectors.
    71c6937: (capn@google.com) Optimize lowering of x86 byte and word vector unpack.
    b093539: (capn@google.com) Optimize x86 vector shift by constant.
    46f4fea: (capn@google.com) Support running unit tests on Windows.
    b001cc4: (sagar.thakur@imgtec.com) [Subzero][MIPS32] Implement bitcast operation for both 32-bit and 64-bit operands
    
    BUG= swiftshader:15
    BUG= swiftshader:7
    BUG= swiftshader:9
    TEST= PNaCl toolchain trybots
    R=dschuff@chromium.org
    
    Review URL: https://codereview.chromium.org/2408293003 .
    

    Changed files

    • pnacl/COMPONENT_REVISIONS
  98. Update revision for PNaCl

    Changed by Jim Stichnoth - stichnotohnoyoudont@chromium.org
    Changed at Thursday, 15-Sep-16 16:09:57 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision fe5bd51f9b79d27b2a3884181d4004cfccf70759

    Comments

    Update revision for PNaCl
    
    Update 25a7ef81d2dc76b58450fa2d5f97070eafa20164 -> f7d719122cd7c2fe3ebc52e7c0b011c583bf3e9c
    
    Pull the following PNaCl changes into NaCl:
      5b10ead: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
        | cbd3dbc: (tlively@google.com) Subzero: Implemented codegen for poisoning and unpoisoning stack redzones
        | e8392d8: (tlively@google.com) Subzero: Added ASan quarantine for recently freed objects
        | 9b38497: (tlively@google.com) Subzero: Elide redundant access checks within basic blocks
        | 135fbe5: (mohit.bhakkad@imgtec.com) SubZero: Add return registers for float/double types in lowerCall
        | 9a313a8: (tlively@google.com) Subzero: Replace global pointers to allocation functions
        | 48a568d: (tlively@google.com) Subzero: Replace pointers to allocation functions in loads
        | efdf412: (stichnot@chromium.org) Subzero: Fix build errors with LLVM trunk.
        | 6b0ee2a: (stichnot@chromium.org) Subzero: Include commit count in revision string.
        | 75f5229: (tlively@google.com) Subzero: Replace pointers to allocation functions in stores
        | c1d6fd5: (tlively@google.com) Subzero: Added address of bad instruction to error output
        | b1a0fb1: (jaydeep.patil@imgtec.com) [SubZero]Added InstMIPS32Load to differentiate stores from loads
        | 8b32241: (jaydeep.patil@imgtec.com) Provide repointEdges for MIPS.
        | 519fe04: (tlively@google.com) Subzero: Updated documentation to describe building spec2k benchmarks
        | 13f0ca3: (jaydeep.patil@imgtec.com) Delete unconditional branch to the next node.
        | 135f5db: (jaydeep.patil@imgtec.com) [SubZero] Generate ELF output for MIPS
        | 8b21cc5: (stichnot@chromium.org) Subzero: Fix the LLVM trunk build.
        | 29823f1: (jaydeep.patil@imgtec.com) [SubZero] Implement lowerSwitch for MIPS
        | 7c9728f: (stichnot@chromium.org) Subzero: Fix a build error against LLVM trunk.
        | 53dae72: (stichnot@chromium.org) Subzero: Deterministically sort local var stack offsets.
        | d5e7caf: (capn@google.com) Implement ICE_CACHELINE_BOUNDARY for Visual Studio.
        | cc8bc16: (stichnot@chromium.org) Subzero: Add the MIPS=1 makefile option for alternate testing mode.
        | e698313: (nicolascapens@google.com) Merge "Implement ICE_CACHELINE_BOUNDARY for Visual Studio."
        | a0b720d: (capn@google.com) Simplify ClFlags macro for older C++ standards.
        | 1d0690b: (jaydeep.patil@imgtec.com) [SubZero] Implement load and store for MIPS
        | c0f1b6f: (capn@google.com) Allow using SZTARGET without PNACL_LLVM.
        | 3db8f7a: (capn@google.com) Fix type alias compilation issue on Windows.
        | 17f04f0: (capn@google.com) Work around Visual Studio static constexpr bug.
        | dbd600d: (capn@google.com) Enable disabling API-based TLS support.
        | d739614: (capn@google.com) Fix Visual Studio compilation of types within template classes.
        | ef9d004: (capn@google.com) Fix unresolved template method definition.
        | 4d70802: (capn@google.com) Add missing header includes.
        | 0e137b2: (capn@google.com) Work around Visual Studio template specialization issue.
        | 86e5d88: (capn@google.com) Ensure NoDefinitions gets initialized only at first use.
        | a9a92a5: (capn@google.com) Fix initializing the allocator before creating empty vector.
        | 5d5b662: (stichnot@chromium.org) Subzero: Fix a build error.  Also reformat.
        | 84ea9a7: (stichnot@chromium.org) Subzero: Fix target attribute when SZTARGET is defined.
        | b85cde1: (srdjan.obucina@imgtec.com) Subzero, MIPS32: Introduction of genTargetHelperCallFor
        | 53d0568: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Intrinsic calls for ABS.fmt and SQRT.fmt
        | 5a9f714: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Handling fptrunc and fpext casting
        | 74bfa87: (stichnot@chromium.org) Subzero: x8664: Fix a "uitofp i32 to double" lowering error.
        | f315f0d: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: Floating point comparison
        | 47ef0be: (jaydeep.patil@imgtec.com) [SubZero] Implement address optimization for MIPS
      b6c1741: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
        | 038a9b9: (capn@google.com) Remove instructions instead of attempting to delete them.
        | d329766: (jaydeep.patil@imgtec.com) [SubZero] Implement GP to/from FP moves for MIPS
        | bcf2a51: (stichnot@chromium.org) Subzero: Fix ODR errors in the g++ build.
      f7d7191: (stichnot@chromium.org) PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
        | d57ed5f: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: lowerSelect for i1, i8, i16, i32, f32, f64
        | ccbb6d1: (sagar.thakur@imgtec.com) [Subzero][MIPS] Fix test nacl-other-intrinsics.ll
        | ca7a367: (stichnot@chromium.org) Subzero: Fix SUBZERO_REVISION in production builds.
    
    BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4379
    BUG= none
    BUG= swiftshader:8
    R=dschuff@chromium.org, jpp@chromium.org, stichnot@chromium.org
    TEST=git cl try
    (Please LGTM this change and tick the "commit" box)
    
    Review URL: https://codereview.chromium.org/2337013006 .
    

    Changed files

    • toolchain_revisions/pnacl_newlib.json
    • toolchain_revisions/pnacl_newlib_raw.json
    • toolchain_revisions/pnacl_translator.json
  99. PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS

    Changed by Jim Stichnoth - stichnotohnoyoudont@chromium.org
    Changed at Wednesday, 14-Sep-16 19:14:19 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision f7d719122cd7c2fe3ebc52e7c0b011c583bf3e9c

    Comments

    PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
    
    This pulls in the following Subzero changes:
    
    d57ed5f: (Srdjan.Obucina@imgtec.com) Subzero, MIPS32: lowerSelect for i1, i8, i16, i32, f32, f64
    ccbb6d1: (sagar.thakur@imgtec.com) [Subzero][MIPS] Fix test nacl-other-intrinsics.ll
    ca7a367: (stichnot@chromium.org) Subzero: Fix SUBZERO_REVISION in production builds.
    
    BUG=none
    TEST= PNaCl toolchain trybots
    R=jpp@chromium.org
    
    Review URL: https://codereview.chromium.org/2340053002 .
    

    Changed files

    • pnacl/COMPONENT_REVISIONS
  100. PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS

    Changed by Jim Stichnoth - stichnotohnoyoudont@chromium.org
    Changed at Wednesday, 14-Sep-16 15:34:47 UTC
    Repository https://chromium.googlesource.com/native_client/src/native_client
    Branch
    Revision b6c1741002bf4fd60702839329222394b26c2003

    Comments

    PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS
    
    This pulls in the following Subzero changes:
    
    038a9b9: (capn@google.com) Remove instructions instead of attempting to delete them.
    d329766: (jaydeep.patil@imgtec.com) [SubZero] Implement GP to/from FP moves for MIPS
    bcf2a51: (stichnot@chromium.org) Subzero: Fix ODR errors in the g++ build.
    
    BUG= swiftshader:8
    TEST= PNaCl toolchain trybots
    R=dschuff@chromium.org
    
    Review URL: https://codereview.chromium.org/2344513002 .
    

    Changed files

    • pnacl/COMPONENT_REVISIONS
  101. <blame list capped at 100 commits>

    Changed by <blame list capped at 100 commits> -
    Changed at N/A
    Repository
    Branch
    Revision

    Comments

    <blame list capped at 100 commits>