| Legend: | Passed | Failed | Failed Again | Running | Exception |
[kitchen] Remove --logdog-only
Not used.
R=iannucci@chromium.org
Bug: 933772
Change-Id: If2e23d6971fdc520dc07497022b1ec6921baa7f2
Reviewed-on: https://chromium-review.googlesource.com/c/1478440
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20784}
[kitchen] Remove --logdog-send-io-keepalives
Remove unused --logdog-send-io-keepalives flag.
Skia doesn't use it either.
Bug: 933772
Change-Id: I4e5dffcc60fcfa78f8a549321145b07ae710e55b
Reviewed-on: https://chromium-review.googlesource.com/c/1478439
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20783}
[kitchen] Extract globalTags computation
Reduce the huge runWithLogdogButler() by extracting globalTags copmutation.
Bug: 933772
Change-Id: I23289ddc136d87dfcad838bf8b8142d7251689ee
Reviewed-on: https://chromium-review.googlesource.com/c/1478415
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20782}
[kitchen] Reformat all files
Bug: 933772
Change-Id: I29897c7298f4534db3d4d9625440bf87ab60ada7
Reviewed-on: https://chromium-review.googlesource.com/c/1478438
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20781}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/7a5289cde745302ffd3dbc5a91a7ae30caee75b2 Fix presubmit on windows (martiniss@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8bee7fcac2f0efa11e9d630ba3bbef205f5f2717
Reviewed-on: https://chromium-review.googlesource.com/c/1479256
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20780}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/cde828fd3a3cf4b6430d08f7ed089366fe3d00a2 [V8] Tag child CQ builds with correct user_agent (sergiyb@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8b19382369947c4a7961f5bc9f6be2012bd373a6
Reviewed-on: https://chromium-review.googlesource.com/c/1479470
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20779}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/8bb8a2d5981a25aa453c7e9d27922dbbcffb0aa0 Add support for mocking tags and refactor code to avoid duplication (sergiyb@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I777edfcbebf5688275abe1c43d7b2816001ae976
Reviewed-on: https://chromium-review.googlesource.com/c/1479251
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20778}
[Monorail] Charts: remove unnecessary script tag
This was left in (or accidentally re-added) and is no longer necessary
in our new webpack world.
Bug: monorail:
Change-Id: I2eabb9f951d64e2a332a86ca85bfb48152282437
Reviewed-on: https://chromium-review.googlesource.com/c/1478410
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20777}
[tricium] Add logging when fetching buildbucket builds
Purpose: debugging
Background: Recently Julie enabled recipe-based tricium
runs for tricium-prod, which appear to be working up until
the point when tricium fetches the output. The output is in
the "tricium" field of the output properties.
This output had been previously successfully fetched, but
now it appears that
`build.GetOutput().GetProperties().GetFields()["tricium"].GetStringValue()`
is empty string, even though on milo there does appear to be a
"tricium" field in the output properties.
Bug: 931768
Change-Id: Ida185dca732781e1f0ab777e11ecf24d55f4247f
Reviewed-on: https://chromium-review.googlesource.com/c/1478013
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20776}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/b53e688e55e1fb68da5aea1b5ea19c9fef06b1d7 Keep setup-buildbot-device.sh verbosity in buildbot logs. (mast@google.com)
recipe_engine:
https://crrev.com/9db69624e0754b34e348aff98210dc7dc3e313a6 [buildbucket] Fix typo "schedule_request" (nodir@google.com)
https://crrev.com/4a00d5c0c7c3eefbf90f6b135009689a7b6ca657 Add StatusException post-process step (sergiyb@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I13c584af99bb34129e1ac032020b08429a2012df
Reviewed-on: https://chromium-review.googlesource.com/c/1478416
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20775}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/e6fa3f09de874a915cd60929e41be0288300ca97 [V8] Remove obsolete node builder (machenbach@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I79f703c23147e2ff0d7cc7015a2f22a2e950fee1
Reviewed-on: https://chromium-review.googlesource.com/c/1478414
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20774}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/7065203a1969a3128005364f09d8132f5c9044db [V8] Properly show fetched revisions on node-ci builders (machenbach@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic7471bd49cefc970f4974efa7b8410f0f8d9c26b
Reviewed-on: https://chromium-review.googlesource.com/c/1478413
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20773}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/6e017afb8033360e475733e4c1b0c4ff660efa86 Define header guards to hack around Kythe using CUDA's wrapper headers. (jsca@google.com)
depot_tools:
https://crrev.com/0e617c02945fa5ee56983bdbe6d6820ab62baf29 Change git cl comments to list robot comments. (qyearsley@chromium.org)
recipe_engine:
https://crrev.com/0b76adbaaf0c63208748ddce760c73205424155f [buildbucket] Add api.buildbucket.run (nodir@google.com)
https://crrev.com/658ffc6b4e0f12ab1b7310ef662acffcf23770ca Add an assertions recipe module for unit tests. (gbeaty@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I54629be3a5d0c40123b40febeb8b7ad2c55dc88b
Reviewed-on: https://chromium-review.googlesource.com/c/1478412
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20772}
Add windows presubmit builder for recipes
Bug: 933421
Change-Id: Ibbcd925ff84dc062e0221aa9c08e377885464196
Reviewed-on: https://chromium-review.googlesource.com/c/1478029
Auto-Submit: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20771}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/5dd2de6e90d65f1fc2a5c35aaaa55ed6fa9ba6d7 Remove recipe config for Windows Clang deterministic. (jbudorick@chromium.org)
https://crrev.com/aa7a12352810425da2f515bb5ae27bfcbfdb3f92 Add command args for flow golden tests (liyuqian@google.com)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iafbad9ba8dabd5aafce0b6029379493214c3ea64
Reviewed-on: https://chromium-review.googlesource.com/c/1478028
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20770}
crosskylabadmin: Enable repair label updates
Adding the admin service flag enables label updates for repair
tasks.
R=pprabhu@chromium.org
Bug: 888194
Change-Id: I1b333d5851de128e3065ba083f06f48885c07124
Reviewed-on: https://chromium-review.googlesource.com/c/1460436
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20769}
monorail: Display an useful title even while the issue is loading.
Bug: monorail:4960
Change-Id: If485c355a69c4681bbc56525e78f84108d851d45
Reviewed-on: https://chromium-review.googlesource.com/c/1478023
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20768}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/c0686b01c159035bac2b64a8a8556bbf5637d93d run_presubmit: remove test for legacy CQ dry_run property. (tandrii@chromium.org)
recipe_engine:
https://crrev.com/6911ee71555b62cc00d760cf1157a48066c1c0a4 [buildbucket] Add api.buildbucket.schedule() (nodir@google.com)
https://crrev.com/49fb21a5ecc4a95399cc0d4814530093acf7ded5 Add documentation for recipe module imports. (iannucci@chromium.org)
https://crrev.com/fe9038f2d3df87a17a9c4df56403b44b3cf1f277 cq: remove support for legacy CQ dry_run property. (tandrii@chromium.org)
https://crrev.com/7577eda6ad2993eb7fc5fc0ddca391af3abc75c0 [buildbucket] Fix docstring formatting (nodir@google.com)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I14f853fc2f632b5d4ea740d51597b6a4c42da3ff
Reviewed-on: https://chromium-review.googlesource.com/c/1478026
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20767}
qscheduler: use gauge instead of counter for queue_size
BUG=None
Change-Id: I32b63e90926fc43fdc015e647efc8a45014934a1
Reviewed-on: https://chromium-review.googlesource.com/c/1478020
Auto-Submit: Aviv Keshet <akeshet@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20766}
[Monorail] Fix warning log for missing phase.
Change-Id: I033e40caf6f1ad47ad5e26c06f725e313df7c709
Reviewed-on: https://chromium-review.googlesource.com/c/1478021
Reviewed-by: Jason Robbins <jrobbins@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20765}
[Monorail] Do not attempt to store prefs for anon.
R=jojwang@google.com
Change-Id: If9aa33561126ec1df580c27b4df168a18bd64bad
Reviewed-on: https://chromium-review.googlesource.com/c/1477943
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20764}
qscheduler: improve proto docstrings
Change-Id: I6f5e0b1e57a61f63ef39ef1495f2c90639a8543b
Reviewed-on: https://chromium-review.googlesource.com/c/1477935
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20763}
qscheduler: add a task queue_size gauge
Also, this is the first example of a state-related metric, so add the
groundwork for recording those.
BUG=None
Change-Id: I6048ff9a8b2b3716ffe95620b6ffcafe44a5b882
Reviewed-on: https://chromium-review.googlesource.com/c/1476269
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20762}
qscheduler: rename eventBuffer -> metricsBuffer
Change-Id: I5924848b6ba12da08349b9b6a4c484ebef0fa8b7
Reviewed-on: https://chromium-review.googlesource.com/c/1476268
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20761}
qscheduler: batcher: use different channels sizes in prod vs. test
BUG=923515
Change-Id: I0873ad6b82f07698e78e76ddcc890baa43b0b3af
Reviewed-on: https://chromium-review.googlesource.com/c/1475976
Reviewed-by: Allen Li <ayatane@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20760}
qscheduler: update package doc
The state package is also taking on the responsibility of emitting
metrics about the state or its transitions. Update package doc
accordingly
Change-Id: I42843eabfffcbab9fae179ed3f15ee0f95b26766
Reviewed-on: https://chromium-review.googlesource.com/c/1476267
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20759}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/4649b523f65514591bf1011566f94b67db752827 [autoroll] Make recipes.cfg deterministically generated. (iannucci@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic90da837e11b482b08b107de5598707e324466e2
Reviewed-on: https://chromium-review.googlesource.com/c/1478014
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20758}
qscheduler: move task event metrics to event namespace
Follow-up after this lands: delete the old metrics.
BUG=None
Change-Id: I92a007bc3cdebfd00b221f326bdf0286e1c32f37
Reviewed-on: https://chromium-review.googlesource.com/c/1476266
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20757}
[chopsui] Update the chopsui-npm workflow and <chops-header>.
* Update npm <chops-header> to newer version.
* Optimize Karma config for running tests fast in CI.
* Update dependencies to newest version and include webpack-*.
* Remove Yarn config from package.json.
* Use BSD-3-Clause license for all packages to match Chromium.
* Update README.md to reflect the new
bootstrap, demo, and deployment workflows.
Bug: chromium:856274
Change-Id: Iab0b1f1461d5266f3321e7ffdc671444756453fe
Reviewed-on: https://chromium-review.googlesource.com/c/1475942
Commit-Queue: Dave Tu <dtu@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20756}
[tricium] Add debug logging to poll to list projects
Bug: 932213
Change-Id: Ie7ca071abf3ba8d5e662f92a334819d9cab272b8
Reviewed-on: https://chromium-review.googlesource.com/c/1477934
Auto-Submit: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20755}
qscheduler: record tsmon metric about proto's size
BUG=None
Change-Id: I12cf8196be250e11544395ea6294e6ca952fbc64
Reviewed-on: https://chromium-review.googlesource.com/c/1476654
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20754}
skylab: Add internal command list drone duts
R=pprabhu@chromium.org
Bug: 929888
Change-Id: I5b14c321d1e34cd7bd8954e211a53ad7ebfdd67b
Reviewed-on: https://chromium-review.googlesource.com/c/1475978
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20753}
[Monorail] Add Issue template converting mechanism.
staging: https://20765-6a5aad0-tainted-jojwang-redux-dot-monorail-staging.appspot.com/p/chromium/issues/approval?id=898304&q=Type%3DFLT-Launch&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified
Bug: monorail:4693
Change-Id: Ic0cea9f0d923848eb74df1bccbd7e5bd7a451cfe
Reviewed-on: https://chromium-review.googlesource.com/c/1464760
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20752}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/feeb807756b73461a713a595f2ba7c414e23b4be Add bot config for Win32 ARM64 builder to chromium_tests. (gbeaty@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6c0652374c24ad6aa480035405aea47db3387177
Reviewed-on: https://chromium-review.googlesource.com/c/1478010
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20751}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/570d90502ae12ad4c7ee7938d5af23f414935ab4 Add build-side configs for chromeos-kevin-rel main waterfall bot. (bpastene@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I236f1d9fb824fd79213a61f290e53376bb2e5246
Reviewed-on: https://chromium-review.googlesource.com/c/1476669
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20750}
[Monorail] Fix return value in case of invalid chart query.
This showed up in Error Reporting on monorail-staging.
R=jeffcarp@chromium.org
Change-Id: Ica6884305ccd68e6fd5362c8730cb1fc503328b8
Reviewed-on: https://chromium-review.googlesource.com/c/1476815
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20749}
[Monorail] Add default approvers during issue conversion.
Bug: monorail:4693
Change-Id: I6992d0c18e969d92aad2e28d875d7b72db55ec83
Reviewed-on: https://chromium-review.googlesource.com/c/1475943
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20748}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/bff8ee8f6e61b400fd9e3da7b0d04c85d3d0769c [V8] Add a step with generated flakes.pyl config (sergiyb@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3017b5d6f6c8b2b91ae5769494ae56a2866e60c7
Reviewed-on: https://chromium-review.googlesource.com/c/1476665
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20747}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/ece07f119332d5718eedcd08ad49782e31022869 [V8] Add node-ci master recipe configurations (machenbach@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5c247d3ee9540aee4192fe5985b9395e680054f7
Reviewed-on: https://chromium-review.googlesource.com/c/1476664
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20746}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/4a4cd9f952b4b6a4a3671e7c0b2ddb44e6c40318 goma: update GomaStats. (yyanagisawa@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibff50d3beee53324aa203dde2d6650029aea3d67
Reviewed-on: https://chromium-review.googlesource.com/c/1476661
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20745}
[rotang] Removing the chrome UX rotation from go/chromecals
The Chrome Media UX Bug triage rotation is not used , this CL removes it
from go/chromecals
Change-Id: Ida87e9af9a6dbd30b7312bef57a51c9c155276fb
Reviewed-on: https://chromium-review.googlesource.com/c/1477091
Reviewed-by: Scott Lewis-Kelly <slewiskelly@google.com>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20744}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/9264fc78895338d88a781980b1d593b9799dae4b Revert "Stop downloading webrtc_test_resources on testers, it's only needed on builders" (oprypin@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I674e535ed1e60bd217b0588412e5f4b6464469dc
Reviewed-on: https://chromium-review.googlesource.com/c/1476658
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20743}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/5c00a22f22e448ab64e8642259a759693e46fd72 [ninjalog_uploader] add path for httplib2 (tikuta@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iadeacb8c77a2272a58b9a7d7ec60c03877303960
Reviewed-on: https://chromium-review.googlesource.com/c/1476657
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20742}
[rotang] Send email out to the rotation owners for shifts with nobody on call.
Bug: 874942
Change-Id: I4aca5602a4103e2e7f4492860256cc449d7abdeb
Reviewed-on: https://chromium-review.googlesource.com/c/1465702
Reviewed-by: Scott Lewis-Kelly <slewiskelly@google.com>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20741}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/3740f4dacf331705aa412e1295a31337909165f8 [buildbucket] Collection without mocking (nodir@google.com)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8a1f0469e7fbc56f61691488d3176433a2ff6a67
Reviewed-on: https://chromium-review.googlesource.com/c/1475986
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20740}
[Monorail] Make code-font also apply to comment textarea.
R=zhangtiff@chromium.org
Bug: monorail:4842
Change-Id: I4e8fcb360531b8459f5780f4684bc0fdcb53e4ca
Reviewed-on: https://chromium-review.googlesource.com/c/1475949
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20739}
[Monorail] Implement ability to unlink linked accounts.
This adds "Unlink" buttons to the user profile page when a user
can unlink their account.
In this CL:
+ Service-layer method UnlinkAccounts().
+ Business logic method UnlinkAccounts().
+ Users pRPC API method UnlinkAccounts().
+ JS and HTML to call that pRPC API.
Bug: monorail:94
Change-Id: If2e3d5cad25c0a028c4028c92c43253118f34a53
Reviewed-on: https://chromium-review.googlesource.com/c/1471432
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20738}
Manual roll to unstick autoroller
depot_tools:
https://crrev.com/9255c4f22809b69d9ca6c75727d3cc472c1e5518 Manual roll to unstick autoroller (iannucci@chromium.org)
recipe_engine:
https://crrev.com/7e953fd1856282691c74d0b32791e2cdd090803e [recipe_engine] Fix autoroll json output. (iannucci@chromium.org)
build:
https://crrev.com/28f3540d66aabbec2d5254083d678300037ca0e1 Manual roll to unstick autoroller (iannucci@chromium.org)
TBR=martiniss@chromium.org
Bug: 914992
Change-Id: Ie0f6dab6e7fdb81e49d3b19fad2c6b47effcbf8d
Reviewed-on: https://chromium-review.googlesource.com/c/1476255
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20737}
[recipe_autoroller] Fix exception when autoroll_recipe_options is absent.
R=martiniss@google.com
Change-Id: I20fa325a9c08a61e42ec89b9436ad8615f81289c
Reviewed-on: https://chromium-review.googlesource.com/c/1475973
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20736}
[som] git ignore .nyc_output for coverge reporting output
Change-Id: I290cf171b49f72f4ae8ce54a661c72a15371f17a
Reviewed-on: https://chromium-review.googlesource.com/c/1475946
Reviewed-by: Dave Tu <dtu@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20735}