| Legend: | Passed | Failed | Failed Again | Running | Exception |
Add the cros_flash* recipes to infra/infra.git.
Moving them from tools/build to infra/infra since the builder that runs
them belongs to the infra.cron bucket. (Which is where it belongs.)
tools/build side change:
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1383372
R=jbudorick, martiniss
CC=tandrii
Bug: 866062
Change-Id: I8aa05dee864b09601fe89e57b2a58c6d73c33e41
Reviewed-on: https://chromium-review.googlesource.com/c/1383333
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19659}
[Monorail] Filter out invalid approvers.
Bug: monorail:4530
Change-Id: I46bb7765552a83feb3f44ce75d4884283d8161c8
Reviewed-on: https://chromium-review.googlesource.com/c/1381262
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19658}
[kitchen] Stop supporting integer properties
kitchen used to support int-float differentiation in property values.
This CL removes the support.
Motivation: it turned out the protobuf library available in GAE env is old
and does not enforce floats. Better to enforce float now than having a time
bomb
Bug: 914996
Change-Id: I9c83c66a81e1cdf99047d5d28f9151f800d7c856
Reviewed-on: https://chromium-review.googlesource.com/c/1382687
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19657}
[rotang] The Angle Wrangle rotation have a member in Paris.
Bug: 915863
Change-Id: I23eef4eee15a2c19f418e1345e9358140ffde10b
Reviewed-on: https://chromium-review.googlesource.com/c/1381211
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Ola Karlsson <olakar@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19656}
[rotang] Adding in migration steps for rotations with shared calendars.
Bug: 845549
Change-Id: I677eebfa97440afb95569936022f2d7eba4bb883
Reviewed-on: https://chromium-review.googlesource.com/c/1379437
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19655}
[buildbucket] Switch to input_properties
Update code that reads input properties from expecting 'properties' parameter
to reading model.Build.input_properties.
This changes the v1 API a bit. API responses now include input properties
defined on the server. This should have no effect though.
R=vadimsh@chromium.org
Bug: 875056
Change-Id: Id5435893303793cb562485d45f00d103bc993516
Reviewed-on: https://chromium-review.googlesource.com/c/1374000
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19654}
[Monorail] Add .nyc_output to .gitignore
Every invocation of WCT dumps a few hundred files into .nyc_output/, which
is currently not ignored.
Bug: monorail:
Change-Id: Idc3b3caf9084c69887b251e9b71ad804a6f53755
Reviewed-on: https://chromium-review.googlesource.com/c/1383331
Auto-Submit: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19653}
Fix gae_ts_mon's import problem
Roll infra_libs to 5972d0e09a2c6fa4a90cce194eb09f4f1d607e46.
https://chromium-review.googlesource.com/c/infra/infra/+/1318720
meant to do that.
Fix gae_ts_mon/__init__.py's sys.modules manipulation by symlinking utils.py
and correctly patching infra_libs.utils
Change-Id: I25fcbd6107a78a600ce9577d4c89fc28e4cdece2
Reviewed-on: https://chromium-review.googlesource.com/c/1383339
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Felix Matenaar <fmatenaar@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19652}
[Findit] Cron job to sync FlakeIssues with Monorail
Syncs Findit's FlakeIssues with what's in Monorail.
1. Only bugs that have open statuses are updated, once they are closed
they will no longer be queried for updates (as an initial version).
Later, we should query closed issues as well within a time window
to prevent too many issues needing updates or checking on issues that
are too old.
2. If an existing FlakeIssue is merged in monorail (e.g. manually), a new
corresponding FlakeIssue is created and impacted FlakeIssue
merge_destination_keys are updated accordingly.
3. Updates status, labels, and last_updated_time_in_monorail for all
issues that have changes that will be used for display purposes in
Ranked Flakes.
Bug: 902967
Change-Id: I6ae69c30dd128e9dd51d312c02c1583cec5dd700
Reviewed-on: https://chromium-review.googlesource.com/c/1370562
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19651}
[Findit] Update schedule of cron job for generating flake reports to everyday 12am pst.
Since we're ready to release flake report, should update the cron job scheduleto generate flake reports daily. Though on UI, we'll only show report entries that are generated on Mondays.
Change-Id: I2d1a9b22e22e4a64d7aa5b86c8bf1dcebe5f534e
Reviewed-on: https://chromium-review.googlesource.com/c/1382576
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19650}
skylab: Request gitiles scope by default
The OAuth token is tied to the exact scopes requested, thus the scopes
used should be the same everywhere.
R=akeshet@chromium.org
Change-Id: I43b77c45697a2d4657d052cff7586c68e87eea5d
Reviewed-on: https://chromium-review.googlesource.com/c/1382604
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19649}
skylab_swarming_worker: Improve messages
Address some user concerns::
Skipping... message could be confusing and doesn't otherwise
provide much value.
Finalization is a little wordy. Epilog is slightly better.
Some users were confused that Stainless results meant task results,
clarified for people who don't know about Stainless.
R=akeshet@chromium.org
Bug: 905360
Change-Id: I5e6257ac7fb46c6fc1211cb584655e4324e57d91
Reviewed-on: https://chromium-review.googlesource.com/c/1382575
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19648}
[Findit] Flake detection -- detect hidden flakes due to test retries in test runner.
A hidden flake is a test that, within a single test step:
* Fail in 2+ runs (including the first failed run and retries by the test runner)
* Pass at least 1 run
This implies that a hidden flake is retried at least twice. This is because a
test could flake due to resource starvation when the test runner is in parallel
test execution mode.
Change-Id: Ibee620f5fe3d9928658a0d76f534d965d406e49c
Reviewed-on: https://chromium-review.googlesource.com/c/1382605
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19647}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/39deae1de8d848674466249c03dd74212f776e6c Remove duplicate recipe configs for libfuzzer bots. (bpastene@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id4ddd5f06e3bd6464c0cf66e38c5ac656dd052a6
Reviewed-on: https://chromium-review.googlesource.com/c/1382680
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19646}
[Findit] Flake Analyzer - Merge duplicate issues by culprit
Scenario:
FlakeCuprit is already pointing to a FlakeIssue. An incoming analysis
with a different Flake/FlakeIssue arrives at the same culprit.
1. If 1 issue was created by Findit while the other by a human, always
merge into the human-created issue
2. Otherwise, merge into the culprit's existing issue.
3. FlakeCulprit is always pointing to the most up-to-date FlakeIssue
4. FlakeIssue's merge_destination_key is to be set upon deduplication
5. Calling code responsible for handling updating FlakeIssues impacted
by deduplication (e.g. in OnFlakeCulpritIdentified).
Bug: 905750
Change-Id: I22818f5cdcd9535b47baa79f8336dece4cf72413
Reviewed-on: https://chromium-review.googlesource.com/c/1356852
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19645}
qscheduler: add context argument to a bunch of call sites
This paves the way for logging and metrics improvements.
BUG=None
TEST=None
Change-Id: I9a55e00bb4c6429d368833d6b17702c42281d39c
Reviewed-on: https://chromium-review.googlesource.com/c/1381270
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19644}
qscheduler: decouple qslib API from State proto representation
No behavioral change, though some of the tests had to be modified
because they relied on proto representation.
The API still depends on Config proto representation, though the
dependence is not as intertwined. This will be fixed in a future CL.
This (in the end, much bigger than I wanted) CL extracts a lot of the
proto depenence out of the qslib API, deleting several modules and
moving a bunch of code around in the process.
BUG=chromium:907292
TEST=tests pass
Change-Id: I8fe607ce9b43ad690c296e91c8078bf4617aa6bd
Reviewed-on: https://chromium-review.googlesource.com/c/1378796
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19643}
[Findit] Use Flake.GetComponent() when generating flake report entries.
Change-Id: Iebb8c75c0246ea6e42b1d44a6a11b82df1dca480
Reviewed-on: https://chromium-review.googlesource.com/c/1382609
Auto-Submit: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19642}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/9072935cdd45933f5f71d316812f9816d57d4515 Pass arguments to run.py to enable HTTPS cert install in iOS testing. (ericale@google.com)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibacbd35f3017d4fb96fb6cfbc332200bbff3060f
Reviewed-on: https://chromium-review.googlesource.com/c/1382678
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19641}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/66240de71ce260f5f3211a8ddb275da18d0a6da6 Remove all settings for LKGR and Libfuzz bots from gatekeeper. (bpastene@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I37086423f63d6b51dad7e196458f88831f449dd3
Reviewed-on: https://chromium-review.googlesource.com/c/1382677
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19640}
ChopsUI: Starting point for rewriting chops-header in lit-element.
Bug: 852887
Change-Id: I018e977f83b24ed1de2dc506d0abdf590f6912fe
Reviewed-on: https://chromium-review.googlesource.com/c/1368503
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19639}
crosskylabadmin: refactor EnsurePoolHealthy
Refactor out some helper functions
BUG=chromium:913676
Change-Id: I44a2f62989922362d2a09379a8123049e5a11d5f
Reviewed-on: https://chromium-review.googlesource.com/c/1373978
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19638}
[Monorail] Add Approval status sort clause.
Bug: monorail:4613
Change-Id: Ifd8005670763cd9d8ad0d1e7cee3716d493cae4a
Reviewed-on: https://chromium-review.googlesource.com/c/1381776
Reviewed-by: Jason Robbins <jrobbins@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19637}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/09cefa792cf2d046c20c444d23c5e1b2144ca870 Tolerate float target_bits (nodir@google.com)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I884f3a6ef1efff09b51a02478fb9df003702ba65
Reviewed-on: https://chromium-review.googlesource.com/c/1382674
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19636}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/0f411556a08120a2dae162bf5974e4b7f8641084 [libfuzzer] Add recipe configs for new libfuzzer builders (machenbach@chromium.org)
depot_tools:
https://crrev.com/24f2cc0de131c95d25fcbf30369764272f0539f2 repo: Update the repo tool to 1.24. (dgarrett@google.com)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib73936a81891c9fe075586f2fdf933ca5117bb71
Reviewed-on: https://chromium-review.googlesource.com/c/1382673
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19635}
[monorail] Show approval name in all types of approval notifications.
Bug: monorail:4674
Change-Id: I69a99c139062aa885b1c21ac206974e05bda123d
Reviewed-on: https://chromium-review.googlesource.com/c/1381269
Reviewed-by: Jason Robbins <jrobbins@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19634}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/92a20048b2445b989db7a4108be3af1c2702eda2 Tolerate float root_solution_revision_timestamp (nodir@google.com)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iddf373d872c5871c87038318f37e67d29beed490
Reviewed-on: https://chromium-review.googlesource.com/c/1382672
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19633}
[Findit] Fix small bugs in flake report
This CL will fix several small bugs in flake report
1. For flake without component, try to get component from it's tags, if still none, use 'Unknown' as default
2. Don't include the component 'Unknown' when ranking top components
3. Fix stale url when searching for a component on the entry point
4. Adjust some component sizes on UI
Change-Id: I3fcf03bf302d321e853035cfd41e5ad4bbe65308
Reviewed-on: https://chromium-review.googlesource.com/c/1381971
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19632}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/6f923b8f10d52191bb24bc3396f6f267d4201932 Zip CELab binaries and upload package (mbinette@google.com)
https://crrev.com/4d78a7ce476b11ed4b6bf2a9876803532402e37d Update presentation for isolated swarming tasks with missing shards. (erikchen@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib1b2924470914dc4b7557072605cf189bb6e8377
Reviewed-on: https://chromium-review.googlesource.com/c/1382671
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19631}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/cf56a4bfb07c8e7361d493754482a9b1177341cf [ninjalog_uploader] Add BuildTargetFromCommandLine function (tikuta@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3760ea66ece7c625966ef56148154329163da16a
Reviewed-on: https://chromium-review.googlesource.com/c/1381815
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19630}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/25717e6375b2f7147a6bb2ce0094e046ba414beb [code coverage] Fix bugs in merge logic (liaoyuke@chromium.org)
https://crrev.com/ea6037f19525f39ffc3182991629dc8622d0103d recipe_modules: Add config 'goma_rbe_tot' (sque@google.com)
https://crrev.com/7b2bb1876cb56d8a46b23dac2f955554e2c5a364 recipes: Add Linux Goma RBE ToT builder recipe (sque@google.com)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3332c3e82b8510b2921ba04c42b749fa36b7811a
Reviewed-on: https://chromium-review.googlesource.com/c/1381814
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19629}
monorail: Get all users involved in comments when listing activities
If the user made an amendment mentioning a user other than themselves,
we need to get their information too when building the response.
Bug: monorail:4110
Change-Id: I89c3245c97519e018722098277845a01fb8686d0
Reviewed-on: https://chromium-review.googlesource.com/c/1381771
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19628}
[buildbucket] Remove Build.parameters_actual
parameters_actual was needed because server might have change user-specified
parameters. Now server uses Build.input_properties, which is allowed to have
server-defined properties.
Update all usages to use Build.input_properties instead.
This has a non-obvious side effect. Struct message in the latest version of
protobuf-python does not accept integers. All numbers are floats, and
they are rendered as doubles in JSON (0 -> 0.0). In general, this is a
breaking change. crbug.com/914996 updates recipes to tolerate floats where
it used to expect integers, but this CL also has a whitelist of widely used,
deprecated properties (like buildnumber) which buildbucket converts back to
int. Updating all recipes to use that is a lot of work, and recipes must
migrate to new recipe API anyway: crbug.com/877161
R=vadimsh@chromium.org
Bug: 875056
Change-Id: I39979d3541c12542bdf572ebafda5126d56d033b
Reviewed-on: https://chromium-review.googlesource.com/c/1373312
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19627}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/69480023c20e14aeb3f544c662832406f31bae58 [auto_bisect] Tolerate floats (nodir@google.com)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3fb009712b256d00b583b9804488a45172b03415
Reviewed-on: https://chromium-review.googlesource.com/c/1381813
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19626}
[Monorail] Add ApprovalStatus Cell table.
Staging: https://19602-3ad58cf-tainted-jojwang-dot-monorail-staging.appspot.com/p/chromium/issues/list?can=2&q=Type%3DFLT-Launch&sort=&groupby=&colspec=ID+Pri+M+Stars+ReleaseBlock+Component+Status+Owner+Summary+OS+Modified+Chrome-Security%2FChromeOS-Security&nobtn=Update
Bug: monorail:4613
Change-Id: Ic8badde3198d4070bdfe835362c9284df844af7e
Reviewed-on: https://chromium-review.googlesource.com/c/1377874
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19625}
Roll infra/go/src/go.chromium.org/luci/ 1d67f2270..20acb6185 (5 commits)
https://chromium.googlesource.com/infra/luci/luci-go/+log/1d67f22707e0..20acb618582d
$ git log 1d67f2270..20acb6185 --date=short --no-merges --format='%ad %ae %s'
2018-12-18 vadimsh [cipd] Add a bit more logging to DeployInstance.
2018-12-18 vadimsh [cipd] Deal with the situation when files change case during upgrade.
2018-12-18 vadimsh [cipd] Fix directory -> symlink (and vice versa) upgrades.
2018-12-17 hinoka [milo] Introduce build.html based off of build.proto
2018-12-17 dburger Add bug links functionality for build pages
Created with:
roll-dep infra/go/src/go.chromium.org/luci
TBR=tandrii@chromium.org, iannucci@chromium.org
BUG=915278
Change-Id: I1990961496e8b4ebce04b60f2e089e8d46d3dfd7
Reviewed-on: https://chromium-review.googlesource.com/c/1381812
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19624}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/3ff54a4bc7de25bd76f32a1e524648ed78eec3f1 chromium_tests: allow builder_testers to upload. (jbudorick@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibe653763bcec9e228bca84b6007fb2e10c394798
Reviewed-on: https://chromium-review.googlesource.com/c/1381811
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19623}
monorail: Move option to expand deleted comments to kebab menu.
Bug: monorail:4110, monorail:4111
Change-Id: Iab1e8b80a9e6d3e582c18c9f36913428973e7c7a
Reviewed-on: https://chromium-review.googlesource.com/c/1378791
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Jason Robbins <jrobbins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19622}
qscheduler: rename State to StateProto
No behavioral change.
This is part of a multi-CL refactor to detach proto representation from
go API.
BUG=chromium:907292
TEST=existing tests pass
Change-Id: I8d1eedd0831a5a2d7e0b335aea831080936d7b21
Reviewed-on: https://chromium-review.googlesource.com/c/1378797
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19621}
qscheduler: separate Scheduler struct from its proto representation
No behavioral change.
This CL is part of a series of refactor CLs that will separate Scheduler
and Reconciler from their proto representation, and move the protos to
their own package.
BUG=chromium:907292
TEST=existing tests pass
Change-Id: Id3410c266a3851db73447d995972542a1ce5b468
Reviewed-on: https://chromium-review.googlesource.com/c/1378787
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19620}
Update recipes to tolerate floats
Bug: 914996
Change-Id: I8aafe308367b8649b9c76c6c4dba45146f87fedb
Reviewed-on: https://chromium-review.googlesource.com/c/1380805
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19619}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/2c899f45a94283d6a927c32860e07e181d3cb380 Tolerate float parent_buildnumber (nodir@google.com)
recipe_engine:
https://crrev.com/dc70d2e73b72e43934db0f7dd816a061aa6f428d Add post_process functions for checking the status of a step. (gbeaty@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5bc16a30963222c85895163421e48f4776d01f0f
Reviewed-on: https://chromium-review.googlesource.com/c/1381411
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19618}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/917f9c6c3efccef6973d5a5512910b1310c24ee7 Update recipes to tolerate floats (nodir@google.com)
depot_tools:
https://crrev.com/61cb9d6ba72b221fa702e74197258b94658c7a08 [ninjalog_uploader] add tests (tikuta@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I08e41d2255fc5d6f62ab689840d4b74c520e8ad1
Reviewed-on: https://chromium-review.googlesource.com/c/1380902
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19617}
Add luci configs in luci.infra.cron for CrOS DUT flash cron.
This adds two builders:
- cros-flash-scheduler-kevin: Runs every night on any Ubuntu bot & selectively
triggers builds on the 2nd builder, "cros-dut-flash".
- cros-dut-flash: Runs on any CrOS DUT swarming bot (pool:Chrome,os:ChromeOS),
and flashes its Chromebook device.
This setup might be a little weird since both builders will belong to the "cron"
bucket, but the second builder runs on machines in "pool:Chrome". Hopefully
that doesn't prove problematic.
Bug: 866062
Change-Id: I30c98174a6a233d382707984a83e68c1f6ef1355
Reviewed-on: https://chromium-review.googlesource.com/c/1380876
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19616}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/a54724cfa37f52622559bbc94bf13f56c9d074a8 [auto_bisect_staging] Tolerate floats (nodir@google.com)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib9daf9de6978c284329d2d61635013cfd26d130b
Reviewed-on: https://chromium-review.googlesource.com/c/1380901
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19615}
[tricium] Limit polling to one request with a fixed number of changes
Specifically, this CL changes the limit to 60 per minute, as an
initial number that could be adjusted later.
For smaller projects there tends to be only a few changes per minute
at most, so this will always be more than enough. For Chromium,
most of the time it appears that there is also usually only a few
published changes per minute, so this will also be sufficient for
chromium/src, even considering that we include WIP CLs.
(https://chromium-review.googlesource.com/q/project:chromium%252Fsrc+status:open)
In the rare event of a burst of >60 changes in a minute, it may
be good to limit requests anyway, to avoid OOM (which is what is
happening currently). We also hope to avoid too many requests to
Gerrit anyway, and a limit of one request per minute per project
seems reasonable.
The expected effect of this CL is that the polling of chromium/src
should succeed, and the GerritProject entity will be updated,
so then polling will start working on current CLs.
Bug: 908636
Change-Id: Ibfc40483473d4606a714fe80472ea65a32ee8fc9
Reviewed-on: https://chromium-review.googlesource.com/c/1378746
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19614}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
build:
https://crrev.com/6a83fce3c0dc225cfa5ad336a74c3931c4354aae Handle missing swarming output in standard_isolated_script_merge.py. (erikchen@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If36e8495cd28872072b73cc57effbd116ac0dbf0
Reviewed-on: https://chromium-review.googlesource.com/c/1380897
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19613}
[trcium] Clean up TODOs to update point of contact.
The name after the TODO is meant to be a point of
contact for anyone curious about the thing to do.
This CL changes Emma and Diego's TODOs to point to me,
and deletes TODOs that I'm not clear about.
Change-Id: Ib8141e29fee8ade4691e3128e08f2607c26b3ff5
Reviewed-on: https://chromium-review.googlesource.com/c/1378951
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19612}
[Findit] Use component page to show reports for all components.
Bug: 912956
Change-Id: I1d630095bb43b68e199dbca50be1eddcb9c113e3
Reviewed-on: https://chromium-review.googlesource.com/c/1370057
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19611}
Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
depot_tools:
https://crrev.com/fb8c1a203db839a0dbbed99af3617056139bad82 gclient eval: Replace monorail with crbug.com in error message. (ehmaldonado@chromium.org)
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia831be8dc01922f5772773108086e95cff12ead3
Reviewed-on: https://chromium-review.googlesource.com/c/1380896
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19610}