| Legend: | Passed | Failed | Failed Again | Running | Exception |
cros: Move *View classes into *Handler types
- DeviceDisabledScreenView
- EnableDebuggingScreenView
- EncryptionMigrationScreenView
- FingerprintSetupScreenView
- KioskAutoluanchScreenView
Also eliminate unnecessary Delegate classes on the views.
Bug: 928555
Change-Id: Ifd45f381f2fb9aaae60dbe3ec6ea1287424980bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572521
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652677}
Download Home : Fixed video view for completed videos
For completed videos
1 - We should show the play icon for completed videos
2 - We should not show the circle/square animation for
completed videos
3 - Paused state should show a download icon rather than
play button
Bug: 951839
Change-Id: I3cd1aa07777f212824fe7a110ae834fdfe4d118a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575400
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652676}
[CrOS PerfTest] Launcher Dragging
This measures the presentation time of following actions:
* gesture-drag to show the launcher from shelf to fullscreen state.
* gesture-drag to hide the fullscreen launcher.
I also moved the perf test utility classes into
separate file so that they can be used in other tests.
Bug: 948324
Change-Id: Iac4d5ca7a39ab44c0404ab927df12608cb7529de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565235
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652675}
[DevTools] Remove the nobinary-* test suites.
We're removing the --disable-internal-devtools-binary-protocol
flag so these virtual tests are no longer useful.
See also:
https://chromium-review.googlesource.com/c/chromium/src/+/1575999
Bug: 954618
Change-Id: Ia084f42b19ea11c92de9c3dc37d43249ca67d7bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576002
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652674}
[TTS] Add a test for dictionary definitions.
Adds a test to exercise the UI when a dictionary definition is
returned by the server.
BUG=936695
Change-Id: I1b18ab395a402948377d541e828e14f51f170fe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573862
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652673}
Use ASCII case conversion and fewer copies in GetWindowFeaturesFromString.
All valid inputs are ASCII, and ASCII case conversion is currently done on
both the key and value after the Unicode case conversion. While here, use
StringView to just access into the ASCII-lowered buffer without copying out
substrings for each key and value, since they're only read.
Bug: 627682
Change-Id: Ibe11bd111205c286efb12273e006837f57254e19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575125
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652672}
[remoting][FTL] Implement FtlDeviceIdProviderIos
This CL provides an FtlDeviceIdProvider implementation for the iOS
client, which generates the device ID from identifierForVendor:
https://developer.apple.com/documentation/uikit/uidevice/1620059-identifierforvendor?language=objc
Bug: 954594
Change-Id: Ieb5c373d66d17751294754c1674e86b8c7cb4ed3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575116
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652671}
Restore browser windows to correct desktop on Win10 (reland)
This is a reland of crrev.com/c/1559168, with a fix for the issue restoring
windows after minimize (crbug.com/952142).
Bug: 873414,952142
Change-Id: I421c1334396c9525dc121d2e98864b7bf1b691a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570246
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652670}
Use ASCII case conversion in color input validation.
All valid color strings are ASCII.
Bug: 627682
Change-Id: Ib169ff7c1014557ac50286435b443dc1e3104533
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574210
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652669}
Attempt to fix crash in Assistant UI close sequence.
I was unable to reproduce the crash, but based on the stack trace in
crbug/952996, my understanding of the cause is:
(1) User attempts to close Assistant UI via caption bar while animation
is in progress.
(2) This triggers an animation abort to occur which fires an animation
ended callback in UiElementContainerView.
(3) UiElementContainerView currently only handles the case where an
animation end occurs due to a new Assistant response being queued
for display.
(4) We attempt to access the queued Assistant response and crash.
Since (1) will ultimately result in the entire Assistant view hierarchy
being destroyed, the cleanest way to handle this is to just prevent
(3) - (4) from accessing invalid state.
Bug: 952996
Change-Id: I056df562a21f18ae032beaeb46fc637ecef21c1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574743
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#652668}
DevTools: remove section editing state, manual height in SSP
A) SSP used to manually set height, 'contain: strict' during edits
for performance. This CL removes them, since there is no
noticeable gain. See crbug.com/684341
B) Removes unnecessary 'editing state tracking', once used to
manually focus sections before ShadowDOM-delegatesFocus.
See also crbug.com/791494
Pre-keyboard navigation) SSP has tabIndex 0. On editingCommitted,
we ensure focus goes back to the pane.
After-keynav) Individual sections have tabIndex -1. On stopEditing,
parent pane has focus, but we manually move focus to the section.
After ShadowDOM V1) parent pane no longer has tabIndex, but uses
'delegatesFocus'. This makes moving focus around unnecessary.
However, it also introduces 'blue flickering' when users 'Tab'
navigate through properties, since focus is first delegated to
the section. This bug is not addressed in this CL.
Bug: 931145
Change-Id: If24177344ec975478fd91937daea58630b396069
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574366
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652667}
Print Preview: Clean up height/width values by moving to variables
Also create a new print_preview_vars_css.html file, to store all CSS
variables separately from common styles.
Bug: 952960, 941369
Change-Id: I24bcc3cca781d7acfe7ff075e5b954827b009745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573163
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652666}
Make dialogs not draggable by default.
Updated a few known cases that should be draggable.
Bug: 930782
Change-Id: I09ba7e0a71097317d241042e16a89f28dd27f4a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570126
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/master@{#652665}
[mojo-bindings] New associated endpoint types
Adds associated analogs for Remote, Receiver, ReceiverSet,
PendingRemote, and PendingReceiver. Basic smoke test coverage for
compile and basic operation, since implementation is in terms of types
with extensive coverage already.
Bug: 875030
Change-Id: Ib441f15da94e1c481e9f7f88d3012ceda886bbf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574365
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652664}
WebUI: Migrate content/browser/resources/ from var to let/const.
Also:
- Added an .eslintrc.js file to enforce these changes.
- Added exception for content/browser/resources/media/ which is fairly large
and should be updated separately.
Bug: 792774
Change-Id: I80b6079220cea112016e5a25c79f01f52a353890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572935
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652663}
Update Gpay logo and camera icon colors
Bug: 951103, 951111
Change-Id: Iab209ea609e4de0db4dce6b29843ec6e2860d9dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574593
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#652662}
Roll src-internal 7be19dbfabac..990de7c7fcb5 (3 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7be19dbfabac..990de7c7fcb5
Created with:
gclient setdep -r src-internal@990de7c7fcb5
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org
Change-Id: Ie858b74bd619629b906ab4dd426f41af72b121ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575876
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652661}
Add "Extended" and "None" as cookie SameSite options in DevTools
This CL adds "Extended" and "None" as possible values of SameSite for
display in DevTools, to reflect the addition of new values to the enum
net::CookieSameSite.
Bug: 953306, 953995
Change-Id: Ic04eec726cfea0d9fcdbfcb26ff268bb532e85ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575109
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652660}
Fix regression where feedback reports don't upload
This was due to a coding error in another recent CL:
crrev.com/c/1560516
Bug: 954563
Test: Generated feedback report is uploaded to server
Change-Id: I2747760b1c41ec44476f2361148a351675719b97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575174
Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: Chris Morin <cmtm@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: J Kardatzke <jkardatzke@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: J Kardatzke <jkardatzke@chromium.org>
Commit-Queue: Rahul Chaturvedi <rkc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652659}
Roll src/third_party/chromite 7ef31b3e5b93..5609aa373c8e (1 commits)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7ef31b3e5b93..5609aa373c8e
git log 7ef31b3e5b93..5609aa373c8e --date=short --no-merges --format='%ad %ae %s'
2019-04-19 dhanyaganesh@chromium.org history-aware: Extend the lookback period to a week
Created with:
gclient setdep -r src/third_party/chromite@5609aa373c8e
The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org
Change-Id: Idbc6b7135fa6ecfb8700cdd191daafed70bc3a37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575875
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652658}
Using LaunchIntent for open Android app device actions
Bug: b/129505256
Test: Manual Test
Change-Id: I0d4fbe6c6a2b0280e6bff4ce9340db13291d40a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571026
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652657}
Fix TalkBack announcement for disabled Offer to translate list item
Bug: 802284
Change-Id: I674255c3d1aa577206f677f13ad5bd30efc085ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572901
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#652656}
Perfetto: Defer taskrunner creation to be on-demand
Also queue up any tasks posted to the Perfetto task-runner-wrapper
until the Chrome taskscheduler has been created.
R=eseckler@chromium.org
TBR=yusukes@chromium.org
Change-Id: Ie9a2dd26ee529add9ce86709eef5876edbd7de27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553670
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652655}
Use ASCII case folding for encoding type.
Per spec, this should use ASCII, not Unicode, case folding:
https://html.spec.whatwg.org/#enumerated-attribute
Bug: 627682
Change-Id: I2e11153c3c391fd2a8e720b28d2412da59795c12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575085
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652654}
Use ASCII case conversion for WebElement::HasHTMLTagName.
Unicode case conversion is slower and incorrect.
Besides, all strings passed here today are ASCII.
Bug: 627682
Change-Id: Ie2f5777599c62879e3e3460e7cbd516010c56792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574790
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652653}
Print Preview: Fix destinations dialog search issues
- Add a "clear search" button to the print preview search box element.
- Remove unnecessary timeout, since a timeout has subsequently been
added to CrSearchFieldBehavior.
Bug: 954278
Change-Id: I073a991227b71213968ac8dac2994a2a3b3a2873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574609
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652652}
Modify TestExpectations for contentSecurityPolicy tests.
Attempting to deflake Windows 10 bot.
These tests are now failing instead of crashing:
http/tests/security/contentSecurityPolicy/register-bypassing-scheme-partial.html
virtual/outofblink-cors/http/tests/security/contentSecurityPolicy/register-bypassing-scheme-partial.html
These tests are now passing consistently:
http/tests/security/contentSecurityPolicy/register-bypassing-scheme-script.https.html
virtual/outofblink-cors/http/tests/security/contentSecurityPolicy/register-bypassing-scheme-script.https.html
The expectations are updated accordingly.
TBR=csharrison@chromium.org
Bug: 686118, 954586
Change-Id: Ia11e2a602908f0f647d879203f660263739bfc16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574596
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652651}
[ios] Add thegreenfrog and michaeldo as owners of //ios/web/find_in_page.
Thegreenfrog has been responsible for creating all file contents in this
directory, landing 10+ CLs in the process.
Michaeldo has reviewed a majority of those CLs.
Bug: 919685
Change-Id: I4da69fbbeee987381c632a174528f1ce606a1b22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574461
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652650}
Support StringPiece in net_string_util.h
Bug: 820198
Change-Id: I0c7689b2e866264494816eda4df400c2cf337636
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574589
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652649}
Revert "chromeos: Disable Tast test security.SELinuxFilesNonARC to unblock LKGM roll."
This reverts commit 854d09d1f360d737d15498879213d26e4bd5a105.
Reason for revert: New LKGM 12105.0.0 has landed
Original change's description:
> chromeos: Disable Tast test security.SELinuxFilesNonARC to unblock LKGM roll.
>
> Unblocks https://chromium-review.googlesource.com/c/chromium/src/+/1573380
>
> Bug: 954192
> Change-Id: If338e6fd4cb28ba8a18996c786b87cea978366fa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574598
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#652420}
TBR=stevenjb@chromium.org,achuith@chromium.org,bpastene@chromium.org,agawronska@chromium.org
Change-Id: I8171e93bf1a4f75444749ae1bb564f4986f955a2
Bug: 954192
Change-Id: I8171e93bf1a4f75444749ae1bb564f4986f955a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575112
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652648}
Populate data reduction proxy page ID for an alternate path
This path seems to be used in some webdriver tests. The populated page
ID will be sent in the data reduction proxy pingbacks.
Bug: 951913
Change-Id: Ie246963027af6ea8d3219c00c23012fc98787e9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574215
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652647}
DNR: Prevent web request extensions from adding removed headers.
r652224 added initial support for removing headers through the Declarative Net
Request API. This CL fixes an existing TODO by preventing web request extensions
from adding back headers removed by DNR.
BUG=947591
Change-Id: I8a6eb4bd3ae8d9bdd556feefb454cbd30944aa74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565613
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652646}
Roll src/third_party/catapult 1ff0422ebea4..cc0161223605 (6 commits)
https://chromium.googlesource.com/catapult.git/+log/1ff0422ebea4..cc0161223605
git log 1ff0422ebea4..cc0161223605 --date=short --no-merges --format='%ad %ae %s'
2019-04-19 benjhayden@chromium.org Migrate ExistingBugRequest, NewBugRequest to es6 module
2019-04-19 benjhayden@chromium.org Migrate cp-radio-group to es6 module
2019-04-19 benjhayden@chromium.org Migrate chart-legend to es6 module
2019-04-19 benjhayden@chromium.org Migrate cp-textarea to es6 module
2019-04-19 benjhayden@chromium.org Migrate sparkline-compound to es6 module.
2019-04-19 benjhayden@chromium.org Migrate ConfigRequest, ReportRequest to es6 modules.
Created with:
gclient setdep -r src/third_party/catapult@cc0161223605
The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:950011,chromium:950011,chromium:950011,chromium:950011,chromium:950011,chromium:950011
TBR=charliea@chromium.org
Change-Id: Ib308bab857a83aa3e2fc7d6fbac12d1b1a81698b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575874
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652645}
[Previews] Use HintUpdateData in place of ComponentUpdateData.
Continues the refactor of ComponentUpdateData out of the HintCacheStore
by using the new HintUpdateData. HintUpdateData can be constructed with
either component or fetched hints.
Bug: 932707
Change-Id: Ib84208df9922028f99854339202e1896ffe75604
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572870
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652644}
Mark element-ready-check-containing-iframe-manual.html passing on Win10.
Attempting to deflake Windows 10 bot.
According to the flakiness dashboard,
external/wpt/fullscreen/api/element-ready-check-containing-iframe-manual.html
now passes consistently. Therefore, removing it from TestExpectations.
TBR=mustaq@chromium.org
Bug: 908841, 954586
Change-Id: Ia51a032a5470454527eefab570c61d57caa73d88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575165
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652643}
AW: dump commandline state to logs for debugging
Similar to http://crrev/c/1266611, this dumps WebView's CommandLine
state (including the "--enable-features" and "--disable-features"
switches) to the log when the "dummy app"
("org.chromium.webview_log_verbosifier") is present.
Notably, this will give us an idea of whether the NetworkService is
enabled or not (FieldTrialList + CommandLine state + knowledge of
whether it is enabled-or-disabled-by-default should be sufficient).
This also adds a usage guide for the webview verbosifier app, including
the new commandline stuff.
Skipping presubmit for LOG(INFO).
NOPRESUBMIT=true
Bug: 929886, 918221
Test: Manual (following the steps in the new docs)
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I4c698d661c340f760e2a90da20439b44a56ea38b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573087
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652642}
Mark webkit_layout_tests' control-chars-08E.html passing on Win10.
Attempting to deflake Windows 10 bot.
external/wpt/css/css-text/white-space/control-chars-08E.html now passes
consistently on Windows 10, so marking it Failure only on Windows 7.
TBR=eae@chromium.org
Bug: 893490, 954586
Change-Id: Id82597d887e8579d50c3a0d73530c07657a0658c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574592
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652641}
Convert easy bits of HttpUtil to StringPiece.
Most of this file is awkwardly tied up with prtime.cc or
StringTokenizer, but convert some boring ones.
Bug: 820198
Change-Id: I339911e7cfbe6136a82d71ec1d1cd000ccc7b91a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575873
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652640}
[heap profiler] Drop multithreading support from BacktraceStorage.
The BacktraceStorage object livespan is local to ConnectionManager::HeapProfileRetrieved
and accessed from a single thread.
BUG=923459
Change-Id: I97dfa2642d5efd06461ea69cb833d4a6aba1083d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574942
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652639}
Removing usages of a deleted flag.
Deleted in https://chromium.googlesource.com/chromium/src.git/+/ba49d00fddeb39c0816090dad7d359df0dce9a1a
Bug: 74848
Change-Id: Ia3d5c796ad34857f4e84fdb3a6f53fce3f00d63b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574829
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Anthony Steinhauser <asteinhauser@google.com>
Cr-Commit-Position: refs/heads/master@{#652638}
Promote fixed-position elements with compositing descendants.
This code was accidentally removed in an earlier commit (*).
It seems fixed-position elements with compositing descendants
need to be promoted for the existing compositing system to work.
(*) https://chromium-review.googlesource.com/c/chromium/src/+/1407922
Bug: 950418
Change-Id: Iec04435bb1a20a17c54ce4f5ff35f4e00704e6b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574686
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652637}
[mojo-bindings] Clean-up/augment new binding types
Adds minor API features and fixes some bugs in the Remote/Receiver types
to support further conversion of code away from InterfacePtr etc.
Bug: 875030
Change-Id: Ia001195c8fd0feed669d3cd65f501ace55de3015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574896
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#652636}
Enable offloading for Dav1dVideoDecoder.
This moves decoding of AV1 content via dav1d to a task pool instead of
sharing the media thread -- which was apparently leading to underflow
of the audio.
This probably only fixes pausing and audio drop outs, if a video frame
is taking more than 200ms (audio buffer size) to return, we've probably
exhausted the video frame buffer too. This would result in video
apprearing frozen for a moment, but would not trigger underflow since
we have a 3 second threshold for underflow on video.
Unlike the VP9 offloading, we offload for all resolutions of AV1
content, since we seem to be getting these issues even with 360p
content.
This removes an unnecessary BindToCurrentLoop for the OutputCB in
the non-offloaded case for clarity.
BUG=940686
TEST=all existing tests pass with offloading decoder.
Change-Id: I7426a0353249646600c12019f868aa058c40e456
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574830
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652635}
Extend expiry date of LECredential histograms
Bug: 945564,945565,945566,945567,945568,945570
Test: None
Change-Id: I49a379e125084600b85cc721d0bfaac27b1d8417
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574361
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Prashant Malani <pmalani@chromium.org>
Auto-Submit: Prashant Malani <pmalani@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652634}
Changing MenuRunner::RunMenuAt to take in a MenuButtonController.
This is needed so Buttons can be not a subclass of MenuButton but still
install a MenuButtonController for the same behavior.
Bug: 901183, 819854
Change-Id: Iccd82dab68ba243f86a8784916332030a295b9ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503349
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652633}
Roll src/third_party/skia 377befab7175..ba1602896d72 (4 commits)
https://skia.googlesource.com/skia.git/+log/377befab7175..ba1602896d72
git log 377befab7175..ba1602896d72 --date=short --no-merges --format='%ad %ae %s'
2019-04-19 halcanary@google.com SkQP: new docker test code
2019-04-19 ethannicholas@google.com fixed Metal code generation for recursive functions
2019-04-19 michaelludwig@google.com Don't batch across domain modes in GrTextureOp
2019-04-19 brianosman@google.com Convexity checker: Wait for significant x-product when walking edges
Created with:
gclient setdep -r src/third_party/skia@ba1602896d72
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=herb@chromium.org
Change-Id: I8ba3c8a8c0213eb8507aee18e4ed912bb0a3a96d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575867
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652632}
Roll src-internal 40beee366962..7be19dbfabac (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/40beee366962..7be19dbfabac
Created with:
gclient setdep -r src-internal@7be19dbfabac
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org
Change-Id: Ife9c0d4d0a4a2925cbbdbc442b9db91fb8824cca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575862
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652631}
cros: Move some *View classes into *Handler files
- KioskEnableScreenView
- MarketingOptInScreenView
- WrongHwidScreenView
- SyncConsentScreenView
Also remove the Delegate classes on the moved views where applicable.
Bug: 928555
Change-Id: Ia833a286b49dda8af7c93f7b5aacebe239f021d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572539
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652630}
Add ax action internalInvalidateTree
This change allows a target process or anything outside of the context of a
source tree to request that its source tree be invalidated.
We make use of this new action in the Automation Internal browser side api, when
a client extension's automation bindings requests an enable frame. Typically,
chrome.automationInternal.enableFrame gets called whenever the extension process
encounters a new child tree. This, in turn, resets state within the tree source
and triggers a re-send of all tree data and node data on the next event.
The action is hooked up to one tree source (ARC++).
TBR=dominickn
Bug: 929522
Test: toggle on ChromeVox, interact with Play Store. Toggle off and then back on
ChromeVox, interact with Play Store. Repeat this several times. ChromeVox should
work throughout.
Change-Id: I8e2a729f079f932d06a615bb5fcca9ebbe7365f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573859
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652629}
Disable WebKitHitTestTest#testUnknownTypeUnrecognizedNode.
Test is flaky on Android CFI bot.
TBR=changwan@chromium.org
Bug: 954578
Change-Id: I325856bd34a5f86c47c9370fb32f718aeb45923a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575161
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652628}