| Legend: | Passed | Failed | Failed Again | Running | Exception |
Roll src-internal 457c7b1da33d..c46e87646eb6 (1 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/457c7b1da33d..c46e87646eb6
Created with:
gclient setdep -r src-internal@c46e87646eb6
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=mmoss@chromium.org
Change-Id: I01bde67de215aa3a38b746de4323356c981eec07
Reviewed-on: https://chromium-review.googlesource.com/c/1474605
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632933}
Roll src/third_party/depot_tools 6344e8c6379b..9255c4f22809 (1 commits)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6344e8c6379b..9255c4f22809
git log 6344e8c6379b..9255c4f22809 --date=short --no-merges --format='%ad %ae %s'
2019-02-16 iannucci@chromium.org Manual roll to unstick autoroller
Created with:
gclient setdep -r src/third_party/depot_tools@9255c4f22809
The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:914992
TBR=agable@chromium.org
Change-Id: I36da341f05158159ee52135f7631ed48b085f861
Reviewed-on: https://chromium-review.googlesource.com/c/1474607
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632932}
Update V8 to version 7.4.186.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/725f62b4..753dd191
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
Change-Id: I6c5309740452e33acd87c7ef7f4fb2c93f89c3d1
Reviewed-on: https://chromium-review.googlesource.com/c/1476187
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632931}
Roll Fuchsia SDK from 6c3c8c98f7b3 to 2a6fe16c289a
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org
Change-Id: I64291192af6404a7caee815d45da97a85b4d568c
Reviewed-on: https://chromium-review.googlesource.com/c/1476253
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632930}
Roll src/third_party/chromite ab75969f2db8..cda1bfc8a406 (1 commits)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ab75969f2db8..cda1bfc8a406
git log ab75969f2db8..cda1bfc8a406 --date=short --no-merges --format='%ad %ae %s'
2019-02-16 evanhernandez@chromium.org cros branch: Ignore nonexistent manifests.
Created with:
gclient setdep -r src/third_party/chromite@cda1bfc8a406
The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=chrome-os-gardeners@chromium.org
Change-Id: I206cf8196f2cb37a8b8a872eb11a940e4a21994a
Reviewed-on: https://chromium-review.googlesource.com/c/1476254
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632929}
Roll src/third_party/angle 9429f2163d65..028df5f51e45 (3 commits)
https://chromium.googlesource.com/angle/angle.git/+log/9429f2163d65..028df5f51e45
git log 9429f2163d65..028df5f51e45 --date=short --no-merges --format='%ad %ae %s'
2019-02-16 syoussefi@chromium.org Vulkan: Implement transfer path for texture copy
2019-02-16 jdarpinian@chromium.org Restore the active program after transform feedback
2019-02-16 jie.a.chen@intel.com Make WARN() and ERR() thread safe
Created with:
gclient setdep -r src/third_party/angle@028df5f51e45
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:832238,chromium:922936
TBR=jmadill@chromium.org
Change-Id: Id9cca245fd0f8eb24942e38596d39be6dde47911
Reviewed-on: https://chromium-review.googlesource.com/c/1474604
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632928}
Updating trunk VERSION from 3708.0 to 3709.0
# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=kariah@chromium.org
Change-Id: I0eac8227b1e814c47fa78cca32c087d494cf24e9
Reviewed-on: https://chromium-review.googlesource.com/c/1476245
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632927}
Carry forward |allow_tts| for deep link queries.
If the user taps a card in an Assistant response, we want to carry
forward the allowance/forbiddance of TTS from the preceding query.
This is analogous to what we are currently doing for suggestion chip
press handling.
The difference here is that there are potentially other sources for
deep links than just cards (e.g. notifications). If this behavior
doesn't work for those use cases we can expose an explicit |allow_tts|
parameter to the deep link for deep link creators, but I think this
should be sufficient behavior for the time being.
Bug: b:124399429
Change-Id: I00251749281591623f28e7a90b8d1e19f0fa3eed
Reviewed-on: https://chromium-review.googlesource.com/c/1476064
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#632926}
AppCache: Add/edit class descriptions.
Bug: 611938
Change-Id: Ie38d8f03a238731b4d2e08ffd5ab27e9f42bfe68
Reviewed-on: https://chromium-review.googlesource.com/c/1475088
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Staphany Park <staphany@chromium.org>
Auto-Submit: Staphany Park <staphany@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632925}
Roll src-internal 2b0d9f25840c..457c7b1da33d (2 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2b0d9f25840c..457c7b1da33d
Created with:
gclient setdep -r src-internal@457c7b1da33d
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=mmoss@chromium.org
Change-Id: I2792493b8d9747465205632730425be77d7554c7
Reviewed-on: https://chromium-review.googlesource.com/c/1476252
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632924}
Roll src/third_party/skia b7c7b7883b23..fb96c4eb131c (1 commits)
https://skia.googlesource.com/skia.git/+log/b7c7b7883b23..fb96c4eb131c
git log b7c7b7883b23..fb96c4eb131c --date=short --no-merges --format='%ad %ae %s'
2019-02-16 reed@google.com update docs for paint
Created with:
gclient setdep -r src/third_party/skia@fb96c4eb131c
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stephana@chromium.org
Change-Id: I4be7a61ec3ab3c4d830086a55c8c8bec3804cca9
Reviewed-on: https://chromium-review.googlesource.com/c/1475358
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632923}
Update V8 to version 7.4.185.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a1788557..725f62b4
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
Change-Id: I13ca922da4f5a651650b72851b6faffb928de510
Reviewed-on: https://chromium-review.googlesource.com/c/1475774
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632922}
Fix build with libstdc++
When building with libstdc++ (use_custom_libcxx=false), we get (different) build
erros when building with clang and gcc.
clang:
base/optional.h:348:61: error: no member named 'value' in
'std::is_constructible<media::learning::Value, const
base::Optional<media::learning::Value> &>'
gcc:
base/optional.h:347:57: error: incomplete type
‘std::is_constructible<media::learning::Value,
base::Optional<media::learning::Value>&>’ used in nested name specifier
BUG=931373
Change-Id: I133ff4f30398202b5726c605fafee8aa916179d3
Reviewed-on: https://chromium-review.googlesource.com/c/1475936
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632921}
Change base::JSONReader::Read()/ReadAndReturnError() to return Optional.
Update unit tests and parts of base/ to reflect this change. Convert
existing callers that did not get updated to use the deprecated version
of the API.
BUG=925165
TBR=davidben@chromium.org,pfeldman@chromium.org,rdevlin.cronin@chromium.org,sdefresne@chromium.org,xiyuan@chromium.org,yucliu@chromium.org
Change-Id: If0cffdb24db7a7e829824d26cb300175cfcbfa23
Reviewed-on: https://chromium-review.googlesource.com/c/1435825
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632920}
Roll src-internal a2ae267f99f6..2b0d9f25840c (6 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a2ae267f99f6..2b0d9f25840c
Created with:
gclient setdep -r src-internal@2b0d9f25840c
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=mmoss@chromium.org
Change-Id: I5ebae757bd10d20a1e29c3015e9f7b9ecac35af2
Reviewed-on: https://chromium-review.googlesource.com/c/1475707
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632919}
Roll src/third_party/angle b6c1c66d2547..9429f2163d65 (1 commits)
https://chromium.googlesource.com/angle/angle.git/+log/b6c1c66d2547..9429f2163d65
git log b6c1c66d2547..9429f2163d65 --date=short --no-merges --format='%ad %ae %s'
2019-02-15 ianelliott@google.com Vulkan: Add missing EGLConfigs for Android Native pixel formats
Created with:
gclient setdep -r src/third_party/angle@9429f2163d65
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org
Change-Id: Ic59ee52ca3746e21bb2a07b1b6dc745daf09ab68
Reviewed-on: https://chromium-review.googlesource.com/c/1476081
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632918}
SimpleCache: Update SimpleCachePrefetchExperiment testing config to match new experiment values.
Bug: 913107
Change-Id: I431a85393d1e4b03ae37bf39d79a36191a05867d
Reviewed-on: https://chromium-review.googlesource.com/c/1471113
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632917}
Android notification: use new API for content suggestion notification.
This CL converts content suggestion notification to use new API which
will support general notification metrics, including:
Mobile.SystemNotification.Action.Click
Mobile.SystemNotification.Content.Click
Mobile.SystemNotification.Dismiss
Bug: 898269
Change-Id: I8af3f38a558a4e2c52f28a1291edc643d3ff9e65
Reviewed-on: https://chromium-review.googlesource.com/c/1475800
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632916}
Expand shader-with-non-reserved-words suppression.
Also seen to fail on macOS with AMD GPUs.
Bug: 929009
Change-Id: I9eeeddbec2680a3694592926a8a3aebb3b68b052
Tbr: jdarpinian@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1476086
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632915}
deterministic builds: remove unused whitelist entries.
1. Revert:
- https://chromium-review.googlesource.com/c/1475028
- https://chromium-review.googlesource.com/c/1475148
They had no effect and the underlying issue is fixed now anyways.
2. Remove nacl entries that are deterministic after
- https://chromium-review.googlesource.com/c/native_client/src/native_client/+/1365356 ,
rolled into chromium in https://chromium-review.googlesource.com/c/1475163
.
Bug: 932387,906741,429358,923062
Change-Id: Icdc2d82929b8fcc263d0730baf7d9a7514f34858
Reviewed-on: https://chromium-review.googlesource.com/c/1476242
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632914}
Observe InkDrop focus changes through ViewObserver
This is less brittle than the existing mechanism since we don't need
child classes' overrides of OnFocus/OnBlur to call their parent's.
FocusRing already works by observing host focus / blur so this brings
the implementations closer together.
Unfortunately this can't easily be added directly to InkDropImpl since
the InkDrop is lazily created by, for instance, changes in focus.
Creating the InkDrop in the constructor does not work as virtual calls
do not propagate to child classes until they are constructed.
Bug: chromium:931964
Change-Id: I9d490b0368d818cac258913f8426f5e63609963d
Reviewed-on: https://chromium-review.googlesource.com/c/1475162
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632913}
Add support for AMD_framebuffer_multisample_advanced for EQAA
This patch adds support to the command decoder and GL bindings
for the AMD_framebuffer_multisample_advanced extension, which
implements AMD EQAA.
BUG=chromium:875471, b:112477942, b:110561066
TEST=test_that graphics_WebGLAquarium
Change-Id: Ib8f55c4b3ae5b6fd678a14e81b347810c002a1da
Reviewed-on: https://chromium-review.googlesource.com/c/1457339
Reviewed-by: Victor Miura <vmiura@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632912}
Expose the DownloadManager hash to the download service
Pipe the hex encoded hash from the DownloadManager to DownloadService
clients. The hash may or may not be there due to a variety of reasons
(parallel downloads, reporting the completion after restart, etc.).
However it should be there in the common case.
A follow up patch will allow clients to disable parallel downloads which
will increase the frequency with which the hash is present.
BUG=928816
Change-Id: I01a62575da8eba522b847ee1a204a14926b758d7
Reviewed-on: https://chromium-review.googlesource.com/c/1457673
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632911}
FrameSinkVideoCapturer: Ensure resurrected frames are up-to-date w/ source.
This fixes a minor logic flaw, where a resurrected frame could be used
in some rare cases where it would not contain the most up-to-date
the |dirty_rect_|, but that means that those frame captures have to
complete *before* any future resurrected frame would be guaranteed to be
up-to-date.
content: If other frame captures are in-progress, they may have cleared
Change-Id: I3d13d0bf20fc1adcf87c13772b86d62aa3b9c7ab
Reviewed-on: https://chromium-review.googlesource.com/c/1471500
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632910}
Roll src/third_party/skia 34a2a76e2094..b7c7b7883b23 (11 commits)
https://skia.googlesource.com/skia.git/+log/34a2a76e2094..b7c7b7883b23
git log 34a2a76e2094..b7c7b7883b23 --date=short --no-merges --format='%ad %ae %s'
2019-02-15 herb@google.com Remove all empty glyph processing
2019-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 0eba65b14b60..a0a80b160c6b (1 commits)
2019-02-15 robertphillips@google.com Revert "Make asFragmentProcessor entry point only take a GrRecordingContext"
2019-02-15 reed@google.com make float more primary API for paint (esp. for alpha)
2019-02-15 halcanary@google.com tools/skqp/release.sh: Add Instant and ABI XML tags
2019-02-15 robertphillips@google.com Make asFragmentProcessor entry point only take a GrRecordingContext
2019-02-15 robertphillips@google.com Switch GrSurfaceProxy's Copy methods over to GrRecordingContext
2019-02-15 robertphillips@google.com Begin switching GrRecordingContext over to having the GrDrawingManager
2019-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 2bb0864b22e7..0eba65b14b60 (21 commits)
2019-02-15 robertphillips@google.com Add addOnFlushCallbackObject at GrRecordingContext level
2019-02-15 brianosman@google.com Moved image params out to SkParticleDrawable
Created with:
gclient setdep -r src/third_party/skia@b7c7b7883b23
The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stephana@chromium.org
Change-Id: I2ead3b868bcb3ea3541c4eade102ca394300f8c9
Reviewed-on: https://chromium-review.googlesource.com/c/1474640
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632909}
Roll src/third_party/catapult 04e1b2eeb89f..1a6b610a464e (2 commits)
https://chromium.googlesource.com/catapult.git/+log/04e1b2eeb89f..1a6b610a464e
git log 04e1b2eeb89f..1a6b610a464e --date=short --no-merges --format='%ad %ae %s'
2019-02-15 rmhasan@google.com Adds ability to find out if a test is retry on failure
2019-02-15 benjhayden@chromium.org Add Diagnostic.deserialize()
Created with:
gclient setdep -r src/third_party/catapult@1a6b610a464e
The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:698902,chromium:918208
TBR=sullivan@chromium.org
Change-Id: I9ca948a8dba38195e7dc595a11d3b52519914430
Reviewed-on: https://chromium-review.googlesource.com/c/1476185
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632908}
Roll src/third_party/dawn 695b68d1009b..67a73bd9fa02 (1 commits)
https://dawn.googlesource.com/dawn.git/+log/695b68d1009b..67a73bd9fa02
git log 695b68d1009b..67a73bd9fa02 --date=short --no-merges --format='%ad %ae %s'
2019-02-15 bryan.bernhart@intel.com Memory manager: buffer uploads (Metal+refactor) - Part 3
Created with:
gclient setdep -r src/third_party/dawn@67a73bd9fa02
The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org
Change-Id: Ic94765d0f4e39aaf8e3fa881b758111d63515beb
Reviewed-on: https://chromium-review.googlesource.com/c/1476311
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632907}
Add the device_status dimension to all triggered CrOS device tests.
This will ensure the tests only run on bots with healthy devices. Note
that we're not using a bot's quarantining method to do so since we also
want tasks that can heal an unhealthy device to still run.
Bug: 866062
Change-Id: Ieac1b8f5e58c2c49813952d039337dbfba20373c
Reviewed-on: https://chromium-review.googlesource.com/c/1474287
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632906}
Add flags to skip extra VR APK installation in perf tests
Adds --disable-vrcore-install and --disable-keyboard-install to the
VR perf tests to skip the automatic installation of VrCore and the VR
keyboard, respectively. This is mainly meant for local testing on
Pixel devices that haven't had the system app version of VrCore
forcibly removed.
Bug: 932791
Change-Id: Ie574d4df56ef2e421c125ac97589ab2d88eb14ff
Reviewed-on: https://chromium-review.googlesource.com/c/1476084
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632905}
Roll src/third_party/pdfium 1c3800a88262..81e11ef441b3 (1 commits)
https://pdfium.googlesource.com/pdfium.git/+log/1c3800a88262..81e11ef441b3
git log 1c3800a88262..81e11ef441b3 --date=short --no-merges --format='%ad %ae %s'
2019-02-16 tsepez@chromium.org Fix source character counting in another bad UTF8 decoder.
Created with:
gclient setdep -r src/third_party/pdfium@81e11ef441b3
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=dsinclair@chromium.org
Change-Id: Id9c6e29c611b6bffd095371930e307843018ca15
Reviewed-on: https://chromium-review.googlesource.com/c/1475066
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632904}
[Autofill] StrikeDatabase2 iOS EGTests
Enabled the StrikeDatabase2 flag in FieldTrial configs,
initialize StrikeDatabase V2 in chrome_autofill_client_ios.mm,
and changed SaveCardInfobarEGTests to accomodate StrikeDatabase.
Bug: 884817
Change-Id: Id33b3839f5ef62cf623af6707fda198b3c547809
Reviewed-on: https://chromium-review.googlesource.com/c/1448416
Commit-Queue: Anne Lim <annelim@google.com>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#632903}
Roll src/third_party/chromite 76447257e83d..ab75969f2db8 (2 commits)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/76447257e83d..ab75969f2db8
git log 76447257e83d..ab75969f2db8 --date=short --no-merges --format='%ad %ae %s'
2019-02-16 groeck@chromium.org chromeos_config: Add generic pre-cq builders for chromeos-{4.4,4.14,4.19}
2019-02-15 chrome-bot@chromium.org Update config settings by config-updater.
Created with:
gclient setdep -r src/third_party/chromite@ab75969f2db8
The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=chrome-os-gardeners@chromium.org
Change-Id: I5bc198d6f0133c7bcd81832ca9635e5ec28fbcad
Reviewed-on: https://chromium-review.googlesource.com/c/1476310
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632902}
Updating trunk VERSION from 3707.0 to 3708.0
# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org
Change-Id: I657f8b12f7689d1a8723c6d8700c1ef54e2d34e4
Reviewed-on: https://chromium-review.googlesource.com/c/1476243
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632901}
Update Robolectric to 4.0.1
Following Ben's CL: https://crrev.com/c/1377410
Merge-With: eureka-internal/242963
Bug: 900746
Change-Id: I21c8313688a28b4d8b7e91492878d6657cb21c40
Reviewed-on: https://chromium-review.googlesource.com/c/1436148
Commit-Queue: Yun Liu <yliuyliu@google.com>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632900}
Enable experimental GPU Skia Gold test
Enables the Skia Gold-enabled version of the GPU Telemetry pixel tests
to run on NVIDIA and Intel GPU trybots and CI builders. These are marked
as an experiment, so they should not cause any visible failures.
To run the non-trybot path locally, run:
content/test/gpu/run_gpu_integration_test.py pixel \
--browser=release --test-filter=Pixel_CSS3DBlueBox \
--use-skia-gold --build-revision f00ba3 \
--upload-refimg-to-cloud-storage --passthrough \
--no-luci-auth
The above is expected to fail unless the account you use for
interacting with Google Storage buckets has been whitelisted
for the Chrome GPU Gold bucket.
Bug: 850107
Change-Id: I2fb3141a13bf10451aaab9d74d54651a797caff5
Reviewed-on: https://chromium-review.googlesource.com/c/1410269
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632899}
CacheStorage: Always complete mojo operations through the same callback.
Currently the CacheStorageDispatchingHost mojo implementations can invoke
their callbacks via different code paths. For example, if the
CacheStorageHandle has been invalidated then the mojo callback is called
directly. In contrast, if the underlying operation was actually performed
then a separate callback is first executed before calling the mojo callback.
This CL makes all cases go through the intermediate callback before invoking
the mojo callback. This gives us a common place to put histogram measurement
and tracing code.
Bug: 927537
Change-Id: Ic1f1fd6107566c64b653628121f136315b589cab
Reviewed-on: https://chromium-review.googlesource.com/c/1474110
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632898}
Revert "Reland #2: Add vp9-alpha + canvas layout test."
This reverts commit 06f1328a872f9634c096bc7abdda4120b166f7f6.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 632855 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDZmMTMyOGE4NzJmOTYzNGMwOTZiYzdhYmRkYTQxMjBiMTY2ZjdmNgw
Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/WebKit%20Mac10.13%20%28retina%29/10322
Sample Failed Step: webkit_layout_tests on ATI GPU on Mac Retina on Mac-10.13.6
Sample Flaky Test: virtual/video-surface-layer/media/alpha-video-playback.html
Original change's description:
> Reland #2: Add vp9-alpha + canvas layout test.
>
> Same as the last reland but waits for a requestAnimationFrame
> cycle to ensure the video surface layer has been painted.
>
> --------------[ Original Description Below ]--------------
>
> Simply moves the win7 expectation to win since they both use the
> same one. Formats the HTML and adds a title too. Adds an
> expectation for Linux which seems to have changed since last
> landing...
>
> --------------[ Original Description Below ]--------------
>
> Apparently we don't have any vpx-alpha layout tests, hence macOS has
> had broken support here for some time.
>
> BUG=919015
> TEST=fails without the macOS alpha fix.
> TBR=dcastagna
>
> Change-Id: If89cd6088f06a519b0b7eb1da74feb58040e7442
> Reviewed-on: https://chromium-review.googlesource.com/c/1474518
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#632855}
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=919015
Change-Id: I669a10f541a0803fef9d1723b8f9bb6526020aa7
Reviewed-on: https://chromium-review.googlesource.com/c/1476212
Cr-Commit-Position: refs/heads/master@{#632897}
Print Preview: Fix flash of Save as PDF issue
For Google Drive, we can't show the Google Drive option until the user
is signed in to Cloud Print, which was causing a brief flash of the
Save as PDF option to appear. Show the spinner until the cloud print
state updates and we know what user account is associated with the
Drive destination.
Bug: 930075
Change-Id: I979a2d7d577513bff0bef451212928f65a50c484
Reviewed-on: https://chromium-review.googlesource.com/c/1464233
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632896}
Add temporary logs to help inline update dev process
Testing this feature is particularly hard because it relies on certain
builds registered in the Play Store. To make sure the feature is
working correctly this patch adds detailed logs to state changes/calls
on the InlineUpdateController.
BUG=922714
Change-Id: I0e81f80c305f854748267826f0667f59f7b9fd7b
Reviewed-on: https://chromium-review.googlesource.com/c/1475904
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Auto-Submit: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632895}
Add helpful debug messages for testing inline flow.
When going through test scenarios for inline flows, this CL ensures
that a system toast is shown for each interaction with the Google Play
API.
A specialized Handler is created so it is possible to send empty
messages to it with specific Event numbers, instead of having to create
an event object instance every time something happens. This event
handler also removes the requirement for al lot of lambda statements.
As part of this work, this CL also removes the triggerInstall() method,
since that method only invoked downloadCompletes().
BUG=922714
Binary-Size: Using the minimum required APIs for inline update.
Change-Id: I9cee165b9ce02aeaa9f4e145326642089190ef95
Reviewed-on: https://chromium-review.googlesource.com/c/1475064
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632894}
Roll src-internal 6fb3f3d8f171..a2ae267f99f6 (6 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6fb3f3d8f171..a2ae267f99f6
Created with:
gclient setdep -r src-internal@a2ae267f99f6
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:928475
TBR=mmoss@chromium.org
Change-Id: I72ee8ef5b0ead1525a2c0b4cbe163f9023676058
Reviewed-on: https://chromium-review.googlesource.com/c/1476080
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632893}
[EoS] Update testing config for new experiment name
Bug: 932261
Change-Id: I25498858da16718d43c6a317f755c91b7b17f345
Reviewed-on: https://chromium-review.googlesource.com/c/1474675
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632892}
Fix known crashes on the tab list UI
- Early return in cases where the tab we are looking for is not in the
model (This is often the case when we hide the UI after sending a
callback and the model is cleared when the callback comes back).
- Move setOverviewModeBehavior to interface for TabModelSelector and
override that as well to rely on it for calls wondering if we are
showing the tab switcher.
BUG=931025
Change-Id: Ia338526ab05e0fbc905f6e4e33dfccde7397bd78
Reviewed-on: https://chromium-review.googlesource.com/c/1476190
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632891}
Revert "LowLatency: make WebGL backbuffer the system front buffer"
This reverts commit c82623c0dc5f8ffd9fb00abe29905f5c43da27f2.
Reason for revert: test failures on waterfall: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Audio%20Linux/33452
Original change's description:
> LowLatency: make WebGL backbuffer the system front buffer
>
> This CL adds a new type of resource, ExternalCanvasResource,
> which is used to wrap the Mailbox used by WebGL's
> DrawingBuffer's |back_color_buffer_|.
>
> When HTMLCanvas calls FinalizeFrame(), instead of making a copy
> (via PaintRenderingResultsToCanvas()), we call WebGLRenderingContextBase's
> ProvideBackBufferToResourceProvider() that calls a new method
> GetDrawingBuffer()->AsCanvasResource().
>
> This new ExternalCanvasResource is managed by a new
> CanvasResourceProviderPassThrough, which essentially returns
> that Resource over and over when requested. The PassThrough CRP
> is instantiated when using kAcceleratedDirect3DResourceUsage
> (the current kAcceleratedDirect... is renamed here to
> kAcceleratedDirect2D...)
>
> Bug: 920626
> Change-Id: I8f2f58df8747231e2b28fc42af851b610eee6924
> Reviewed-on: https://chromium-review.googlesource.com/c/1404705
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#632873}
TBR=kbr@chromium.org,mcasas@chromium.org,sunnyps@chromium.org,fserb@chromium.org
Change-Id: If3bcec48f741a54a8fa337931357e8b7007b13fa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 920626
Reviewed-on: https://chromium-review.googlesource.com/c/1476330
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632890}
Use base::JSONReader::ReadDeprecated() in various [h-z]* directories.
This is part of the process to help migrate base::JSONReader::Read() to
return base::Optional<base::Value>.
Do the same for ReadAndReturnError() and ReadToValue().
BUG=925165
TBR=eroman@chromium.org,pfeldman@chromium.org,sandersd@chromium.org,sergeyu@chromium.org,thakis@chromium.org
Change-Id: I0550baa36f24e6b27a4479543e55c8734c3c6956
Reviewed-on: https://chromium-review.googlesource.com/c/1476099
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632889}
Create extension source message port early
This is a pure refactoring CL. It slightly changes the extensions
message channel initialization flow, so that the ExtensionMessagePort
instance of the source endpoint is constructed earlier - as soon as
MessageService::OpenChannel*() is called - rather than later after all
checks and asynchronous tasks are done.
The goal is to streamline the whole initialization process in align with
native-process-initiated message channels that will be implemented soon,
because in their case the source message port will be passed as a
parameter to MessageService from non-//extensions code.
BUG=chromium:898746
TEST=existing tests
Change-Id: I057e1ef8292a2892e09465ccf973d2fbbb0cbc42
Reviewed-on: https://chromium-review.googlesource.com/c/1470192
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632888}
Automate VR reposition bar visibility test
Automates the VR Browser manual test that ensures that the repositioning
bar above the content quad does not become visible when hovered if the
keyboard is currently displayed.
Bug: 864617
Change-Id: Iedd3041e36a6ca2ccfb8e13bd5f1433d4eaff468
Reviewed-on: https://chromium-review.googlesource.com/c/1475701
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632887}
Update V8 to version 7.4.184.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8d1908ec..a1788557
Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
Change-Id: I462c057b4eb7726348fe6fc4a1dc82ce0415d570
Reviewed-on: https://chromium-review.googlesource.com/c/1475906
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#632886}
Use base::JSONReader::ReadDeprecated() in various [a-g]* directories.
This is part of the process to help migrate base::JSONReader::Read() to
return base::Optional<base::Value>.
Do the same for ReadAndReturnError() and ReadToValue().
BUG=925165
TBR=piman@chromium.org,rdevlin.cronin@chromium.org,rogerta@chromium.org,stevenjb@chromium.org
Change-Id: Ib26978fd894f1d62e9ac5caaf7ceffc9901df01e
Reviewed-on: https://chromium-review.googlesource.com/c/1476095
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632885}
[VR] Remove incorrect DCHECK(on_presentation_ended_)
We were DCHECKing that a callback member was null to avoid losing
messages. However, we already handle not getting the message in the
case that it wasn't null.
This change adds a more descriptive comment, and fixes a related subtle
bug where we could think presentation has ended even though there was
outstanding requests to start a new session.
The overriding issue is that we try to use OpenVR and Oculus APIs on one
thread (their respective render loops), but also use the api on the main
device thread to drive magic window.
Bug: 911324
Change-Id: Ib593ec605f3ebbe8cba93370b2dc93f63ec689fe
Reviewed-on: https://chromium-review.googlesource.com/c/1468342
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632884}