[fidl][dart] componentize compatibility test invocation
Also, switch from being an AOT app from a JIT app because the AOT
runtime leaks file descriptors more slowly.
As a JIT app this will fail on the first invocation of:
fx run-test fidl_compatibility_test_topaz
whereas as an AOT app it's on the fourth invocation.
[cleanup] Removed unused/deprecated packages
- no testing required, just removes unused packages.
[flutter_runner] Increase Skia graphics resource cache bytes to 16mb
This value started at 512mb, and was reduced to 8mb in efforts to fight
OOM issues that were happening at the time. The value was not tuned
w.r.t. FPS. For the image scrolling workload, just bumping it up to
16mb achieves significant "GPURasterizer::Draw" duration improvements.
The full stats from the traces I took are listed below. Most
importantly, the reduction is large enough that the majority of our
"vsync callback" + "GPURasterizer::Draw" durations are now below the
Before (8mb) -> After (16mb)
avg 12,499,036 ns -> 3,258,264 ns
max 32,923,333 ns -> 11,988,792 ns
min 1,083,625 ns -> 1,203,375 ns
std 3,663,162 ns -> 1,339,275 ns
pct_050 11,565,301 ns -> 2,631,807 ns
pct_090 16,556,576 ns -> 5,488,671 ns
See FL-153 for the traces.
It is possible that for different workloads, a larger cache size will be
required (in order to achieve 60 FPS), however for now let's try to
increase it by only the necessary amount.
[ledger] Use new PageSnapshot APIs.
[tiler] Fix check for isEmpty.
Testing: Updated unittests.
[userpicker_base_shell] Update system reboot path.
devmgr is moving from a virtual device (/dev/misc/dmctl) to services.
One of these, fuchsia.device.manager.Administrator, provides the ability
to reboot now. Switch to using this.
If63986c94f07ec4f2acda3f2b3901fbc956920c1 Encapsulated the service path
into the base system object, we reuse that work here.
Test: Ran on eve using workstation build, reset button still works.
[fuchaia_inspect] Use inspect from libinspect
Depends on https://fuchsia-review.googlesource.com/c/fuchsia/+/273808
[flutter] Avoid using APIs removed upstream.
[products] Remove unused old-style product definition
We now define the terminal product in //products in a different format.
[cleanup] Remove unused public/dart/widgets classes
[flutter_runner] Use a custom wrapper (RunnerContext) for startup handles
In the singleton app case, this is a prerequisite to Dart code
exposing stuff under out/.
[SetUI][Settings] Make settings app configurable.
This changelist replaces the hardcoded list of settings with
logic to read in the settings from a YAML configuration.
Test: fx run-host-tests settings_tests
[cleanup] remove public/lib/story/dart
[topaz] Delete old Semantics Bridge code in flutter.
This cl deletes, old semantics bridge code in flutter.
* Build: passed
* Installed on device
[tiler] Add support for min sizes, tabbing and floats.
- Separate files for model classes.
- Utils class includes tree traversal support.
- Tiler constructor needs non-null root.
- Tiler root cannot be a content tile, only row or column
- Adds 'custom' tile type for tabbed tiles.
- Collapses all tiles and their descendants for tabbed tiles
- Removes tile from hierarchy if they don't fit and tabbing
is not an option.
- Basic support for floating tiles in Tiler widget.
- Improves widget build performance by localizing build
to the area being changed.
Testing: Includes new and updated unittests.
[examples] move simple_flutter off deprecated code
[packages] Remove JSON build package
There are no longer any tools that read these files.
[chromium] Remove obsolete cipd ensure files.
All chromium prebuilts are fetched using jiri's cipd package supports.
This ensure file and script are no longer needed. This patch removes
these files to avoid confusions.
[tests] Disable tests that are flaky and under investigation
These two tests are flaking on bots. They appear to be triggering bugs
lower down in the stack being investigated in WEB-32. This disables
the tests so they don't block commits while the underlying bug is being
WEB-32 #comment disable flaking tests
[roll] Roll chromium version:76.0.3771.0
[tests] Inject account manager and device settings manager in tests that launch modular.
- These are hard dependencies that modular needs to have available
- flutter_screencap_test fails with and without the flag flip, but it still needs to be
updated to inject the services into the test environment
TESTED: ran driver_example_mod_tests, slider_mod_tests, locally on NUC
without the flag flip and saw driver_example_mod_tests, slider_mod_tests pass.
Then flipped the flag and saw those 2 tests fail. Then with this CL they pass again.
[scenic] Add fuchsia_scenic to SDK
To start off with, it contains ViewTokenPair, a handy helper type.
This helper type lets clients create ViewTokens easily without having to
interact with raw eventpairs.
[tiler] Add some more <T>s
[codec][sysmem] fuchsia.media needs fuchsia.sysmem
We're plumbing fuchsia.sysmem.BufferCollectionToken via
fuchsia.media.StreamProcessor so anything with fuchsia.media will want
[fidl][dart] Bits support: add $none, and & operator
[inspect][dart] Remove accidentally checked in file.
[flutter_runner] Fixes for the Flutter roll
[dart][zircon] update constants.dart
Ran extract_zircon_constants.py, specifically to pick up the new
definition for ZX_JOB_NO_PROCESSES which is being transitioned.
[flutter_runner] Use a Thread for the platform thread
[webview] Fix webview usage with fuchsia.web
[roll] Roll chromium version:75.0.3770.0
[fuchsia_inspect] Remove unused import
[flutter_runner] Update viewport metrics with z
[dart_runner] Allow logging, log more errors
We previously were neither initializing logging, getting access to the
log service, not logging the details of why loading a program was
This corrects that somewhat.
[flutter_runner] Increase thread stack sizes
[cleanup] Remove public/lib/module/dart
[cleanup] remove lib/setui/settings/*
[ermine] Fix broken auth overlay
The animation was not triggering, which was keeping the overlay hidden.
Test: Login flow and lanched story in ermine
[flutter_runner] Rename flow namespace to flutter
[roll] Roll chromium version:75.0.3769.0
[flutter_runner] Avoid nullptr dereference
If the `VulkanSurfaceProducer` failed to initialize then there may not be a
`logical_device_` and dereferencing it for `GetQueueHandle` will generate
[flutter_runner] Disable code garbage collection
[dart][inspect] Fix bug in Block.nameUtf8
It was returning the entire payload, not truncating to the actual name length.
Test: fx run-host-tests fuchsia_inspect_package_unittests
[dart][logger] include logger name in tags
- fx run-host-tests fuchsia_logger_package_unittests
[flutter_runner] Omit --enable_interpreter flag in AOT
[inspect][dart] Update example app instructions to reflect "fx set" changes.
[cleanup] remove public/lib/user/dart
[sdk] fuchsia_dart.api change
This is related to http://fxr/273250.
[flutter_runner] Use same usage as scenic when creating image
The vkCreateImage parameters need to match exactly when two images alias
the same memory, or else they may interpret the memory differently -
e.g. one may use AFBC, and the other may not.