Builder peridot-arm64-release Build 8926748599544237696
Results:
Failure QEMU test results
Trigger Info:
Project | fuchsia |
Revision | 43d02c51b7d7610d83d811da8251b6bc01421c5a |
Execution:
- Source: Task 41dd171f61bf5f10
- Bot: fuchsia-debian-16-c4acfc8a-us-central1-c-7bqg
- Recipe: fuchsia
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
board | "peridot/boards/arm64.gni" | setup_build |
bot_id | "fuchsia-debian-16-c4acfc8a-us-central1-c-7bqg" | setup_build |
branch | "refs/heads/master" | setup_build |
build_type | "release" | setup_build |
buildbucket | {"build": {"bucket": "luci.fuchsia.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1545186153807795, "id": "8926748599544237696", "project": "fuchsia", "tags": ["builder:peridot-arm64-release", "buildset:commit/git/43d02c51b7d7610d83d811da8251b6bc01421c5a", "buildset:commit/gitiles/fuchsia.googlesource.com/peridot/+/43d02c51b7d7610d83d811da8251b6bc01421c5a", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9092178661744608864", "scheduler_job_id:fuchsia/peridot-arm64-release", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "peridot-arm64-release" | setup_build |
gcs_bucket | "fuchsia-build" | setup_build |
manifest | "peridot/peridot" | setup_build |
packages | ["peridot/packages/buildbot"] | setup_build |
path_config | "generic" | setup_build |
project | "integration" | setup_build |
recipe | "fuchsia" | setup_build |
remote | "https://fuchsia.googlesource.com/integration" | setup_build |
repo | "peridot" | setup_build |
repository | "https://fuchsia.googlesource.com/peridot" | setup_build |
revision | "43d02c51b7d7610d83d811da8251b6bc01421c5a" | setup_build |
run_tests | true | setup_build |
target | "arm64" | setup_build |
test_in_shards | true | setup_build |
test_timeout_secs | 1200 | setup_build |
variants | ["host_asan"] | setup_build |
Blamelist:
- Steffen Meschkat (meschohnoyoudont@google.com)
Timing:
Create | Wednesday, 19-Dec-18 02:22:33 UTC |
Start | Wednesday, 19-Dec-18 02:22:39 UTC |
End | Wednesday, 19-Dec-18 02:47:08 UTC |
Pending | 5 secs |
Execution | 24 mins 29 secs |
All Changes:
-
[session_shell] Convert tests to use RequestStart().
Changed by Steffen Meschkat - meschohnoyoudont@google.com Changed at Tuesday, 18-Dec-18 23:51:11 UTC Repository https://fuchsia.googlesource.com/peridot Branch Revision 43d02c51b7d7610d83d811da8251b6bc01421c5a Comments
[session_shell] Convert tests to use RequestStart(). This removes all use of Start() to start stories and replaces it with RequestStart(), except from the session_shell test. That test continues to exercise both ways to start stories until Start() is removed altogether. Move the existing implementation of SessionShell in the session_shell test SessionShellImpl to a common location lib/testing where it can be reused by other tests. Create a common base class SessionShellBase for all test SessionShell components that uniformly creates an instance of SessionShellImpl. Also move setup of SessionShellContext and StoryProvider into the shared base class, reducing boiler plate across tests. Convert all test SessionShell components to use SessionShellBase. Convert all test SessionShell components to use RequestStart() instead of Start() to start stories. The SessionShellImpl instance in their base classes handles the ensuiing AttachView() and DetachView calls. Collateral cleanup: * Simplify requests for PuppetMaster from environment. * Uniformly use Signal() rather than Logout() to finish the test. * Remove scheduling of timeouts that are redundant with the timeout in dev_base_shell. * Remove redundant using declarations for TestPoint. * Remove one unused declaration of Await. * Convert component_context test to a sequential flow to avoid hitting timeouts, and for consistency with other tests. * Convert component_context test to use Signal() and Await() rather than Get() and Put(). MF-121 #comment Convert tests to use RequestStart(). TESTED=/pkgfs/packages/modular_tests/0/test/run_modular_tests.sh Manually verified that without the SessionShellImpl, sessionmgr crashes in an FTL_CHECK() when the SessionShell uses RequestStart(). Change-Id: I145a9dfdd7a64ada7b63d56f125cb78c2ec351a7
Changed files
- lib/common/story_provider_watcher_base.cc
- lib/common/story_provider_watcher_base.h
- lib/testing/BUILD.gn
- lib/testing/component_base.h
- lib/testing/component_main.h
- lib/testing/session_shell_base.h
- lib/testing/session_shell_impl.cc
- lib/testing/session_shell_impl.h
- tests/chain/BUILD.gn
- tests/chain/chain_test_session_shell.cc
- tests/component_context/component_context_test_module.cc
- tests/component_context/component_context_test_one_agent.cc
- tests/component_context/component_context_test_two_agent.cc
- tests/last_focus_time/BUILD.gn
- tests/last_focus_time/last_focus_time_test_session_shell.cc
- tests/link_context_entities/BUILD.gn
- tests/link_context_entities/link_context_entities_test_session_shell.cc
- tests/link_data/BUILD.gn
- tests/link_data/link_data_test_session_shell.cc
- tests/module_context/BUILD.gn
- tests/module_context/module_context_test_session_shell.cc
- tests/session_shell/BUILD.gn
- tests/session_shell/session_shell_test_session_shell.cc
- tests/story_shell/BUILD.gn
- tests/story_shell/story_shell_test_session_shell.cc
- tests/suggestion/BUILD.gn
- tests/suggestion/suggestion_test_session_shell.cc
- tests/trigger/BUILD.gn
- tests/trigger/trigger_test_session_shell.cc