Builder peridot-arm64-perf-vim2 Build 8921740718109148704
Results:
Failure Uncaught Exception
Trigger Info:
| Project | fuchsia |
| Revision | 66632b640a92fa2baaadc44b521dfc84c5044995 |
Execution:
- Source: Task 42f9c1629ee05210
- Bot: fuchsia-debian-16-c4acfc8a-us-central1-b-4slg
- Recipe: fuchsia_perf
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
| Name | Value | Source |
|---|---|---|
| $recipe_engine/buildbucket | {"build": {"builder": {"bucket": "ci", "builder": "peridot-arm64-perf-vim2", "project": "fuchsia"}, "createTime": "2019-02-12T09:00:41.711873Z", "createdBy": "user:luci-scheduler@appspot.gserviceaccount.com", "id": "8921740718109148704", "infra": {"buildbucket": {"serviceConfigRevision": "2acf9ddf085124300131f0a719a64564504c97a6"}, "recipe": {"cipdPackage": "fuchsia/infra/recipe_bundles/fuchsia.googlesource.com/infra/recipes", "name": "fuchsia_perf"}, "swarming": {"hostname": "chromium-swarm.appspot.com"}}, "input": {"gitilesCommit": {"host": "fuchsia.googlesource.com", "id": "66632b640a92fa2baaadc44b521dfc84c5044995", "project": "fuchsia", "ref": "refs/heads/master"}}, "tags": [{"key": "builder", "value": "peridot-arm64-perf-vim2"}, {"key": "buildset", "value": "commit/git/66632b640a92fa2baaadc44b521dfc84c5044995"}, {"key": "buildset", "value": "commit/gitiles/fuchsia.googlesource.com/fuchsia/+/66632b640a92fa2baaadc44b521dfc84c5044995"}, {"key": "scheduler_invocation_id", "value": "9087170780282167088"}, {"key": "scheduler_job_id", "value": "fuchsia/peridot-arm64-perf-vim2"}, {"key": "user_agent", "value": "luci-scheduler"}]}} | setup_build |
| $recipe_engine/isolated | {"server": "https://isolateserver.appspot.com"} | setup_build |
| $recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
| $recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
| $recipe_engine/swarming | {"server": "https://chromium-swarm.appspot.com"} | setup_build |
| benchmarks_package | "peridot_benchmarks" | setup_build |
| board | "peridot/boards/arm64.gni" | setup_build |
| bot_id | "fuchsia-debian-16-c4acfc8a-us-central1-b-4slg" | setup_build |
| branch | "refs/heads/master" | setup_build |
| build_type | "release" | setup_build |
| buildbucket | {"build": {"bucket": "luci.fuchsia.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1549962041711873, "id": "8921740718109148704", "project": "fuchsia", "tags": ["builder:peridot-arm64-perf-vim2", "buildset:commit/git/66632b640a92fa2baaadc44b521dfc84c5044995", "buildset:commit/gitiles/fuchsia.googlesource.com/fuchsia/+/66632b640a92fa2baaadc44b521dfc84c5044995", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9087170780282167088", "scheduler_job_id:fuchsia/peridot-arm64-perf-vim2", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
| buildername | "peridot-arm64-perf-vim2" | setup_build |
| dashboard_bots_name | "peridot-arm64-perf-vim2" | setup_build |
| dashboard_masters_name | "fuchsia.ci" | setup_build |
| device_type | "Khadas Vim2 Max" | setup_build |
| environment_label | "vim2" | setup_build |
| gcs_bucket | "fuchsia-build" | setup_build |
| manifest | "flower" | setup_build |
| packages | ["peridot/packages/buildbot"] | setup_build |
| path_config | "generic" | setup_build |
| project | "integration" | setup_build |
| recipe | "fuchsia_perf" | setup_build |
| remote | "https://fuchsia.googlesource.com/integration" | setup_build |
| repo | "peridot" | setup_build |
| repository | "https://fuchsia.googlesource.com/fuchsia" | setup_build |
| revision | "66632b640a92fa2baaadc44b521dfc84c5044995" | setup_build |
| target | "arm64" | setup_build |
| test_timeout_secs | 1200 | setup_build |
| variants | ["host_asan"] | setup_build |
Blamelist:
- mukesh agrawal (quicheohnoyoudont@google.com)
- Gabriel Kerneis (kerneisohnoyoudont@google.com)
- Suraj Malhotra (surajmalhotraohnoyoudont@google.com)
- James Tucker (raggiohnoyoudont@google.com)
- mukesh agrawal (quicheohnoyoudont@google.com)
- Nicolas Sylvain (nsylvainohnoyoudont@google.com)
- Roland McGrath (mcgrathrohnoyoudont@google.com)
- Andres Oportus (andresoportusohnoyoudont@google.com)
- Jeremy Manson (jeremymansonohnoyoudont@google.com)
- Joshua Seaton (joshuaseatonohnoyoudont@google.com)
- Adam Barth (abarthohnoyoudont@google.com)
- Josh Gargus (jjoshohnoyoudont@google.com)
- Benjamin Brittain (bwbohnoyoudont@google.com)
- Marty Faltesek (mfaltesekohnoyoudont@google.com)
- Scott Graham (scottmgohnoyoudont@google.com)
- Todd Eisenberger (teisenbeohnoyoudont@google.com)
- Pascal Perez (pascallouisohnoyoudont@google.com)
- Scott Graham (scottmgohnoyoudont@google.com)
- Sean Klein (smkleinohnoyoudont@google.com)
- Chris Kuiper (ckuiperohnoyoudont@google.com)
- Joshua Seaton (joshuaseatonohnoyoudont@google.com)
- Joshua Seaton (joshuaseatonohnoyoudont@google.com)
- Nicolas Sylvain (nsylvainohnoyoudont@google.com)
- Scott Graham (scottmgohnoyoudont@google.com)
- Scott Graham (scottmgohnoyoudont@google.com)
- Scott Graham (scottmgohnoyoudont@google.com)
- Sean Klein (smkleinohnoyoudont@google.com)
- Todd Eisenberger (teisenbeohnoyoudont@google.com)
- Todd Eisenberger (teisenbeohnoyoudont@google.com)
- Scott Graham (scottmgohnoyoudont@google.com)
- Xo Wang (xowohnoyoudont@google.com)
- Didrik Nordström (dnordstromohnoyoudont@google.com)
- Ankur Mittal (anmittalohnoyoudont@google.com)
- Jake Ehrlich (jakehehrlichohnoyoudont@google.com)
- Joshua Liebow-Feeser (joshlfohnoyoudont@google.com)
- John Bauman (jbaumanohnoyoudont@google.com)
- Todd Eisenberger (teisenbeohnoyoudont@google.com)
- Yegor Pomortsev (ypomortsevohnoyoudont@google.com)
- P.Y. Laligand (pylaligandohnoyoudont@google.com)
- George Kulakowski (kulakowskiohnoyoudont@google.com)
- Petr Hosek (phosekohnoyoudont@google.com)
- Sanjay Chouksey (sanjaycohnoyoudont@google.com)
- Ankur Mittal (anmittalohnoyoudont@google.com)
- Ankur Mittal (anmittalohnoyoudont@google.com)
- Ankur Mittal (anmittalohnoyoudont@google.com)
- Craig Tiller (ctillerohnoyoudont@google.com)
- John Bauman (jbaumanohnoyoudont@google.com)
- mukesh agrawal (quicheohnoyoudont@google.com)
- Craig Tiller (ctillerohnoyoudont@google.com)
- Scott Graham (scottmgohnoyoudont@google.com)
- Craig Stout (cstoutohnoyoudont@google.com)
- Mark Seaborn (mseabornohnoyoudont@google.com)
- Scott Graham (scottmgohnoyoudont@google.com)
- Scott Graham (scottmgohnoyoudont@google.com)
- Adam Barth (abarthohnoyoudont@chromium.org)
- Scott Graham (scottmgohnoyoudont@google.com)
- Andrew Davies (awdaviesohnoyoudont@google.com)
- Leo Lung (leolungohnoyoudont@google.com)
- Cristián Donoso (donosocohnoyoudont@google.com)
- Scott Graham (scottmgohnoyoudont@google.com)
- Dave Schuyler (dschuylerohnoyoudont@chromium.org)
- Adam Barth (abarthohnoyoudont@chromium.org)
- Martin Puryear (mpuryearohnoyoudont@google.com)
- Bruno Dal Bo (brunodalboohnoyoudont@google.com)
- Adam Barth (abarthohnoyoudont@chromium.org)
- Michael Spang (spangohnoyoudont@google.com)
- Craig Stout (cstoutohnoyoudont@google.com)
- David Stevens (stevensdohnoyoudont@google.com)
- Jocelyn Dang (jocelyndangohnoyoudont@google.com)
- Doug Evans (djeohnoyoudont@google.com)
- Fady Samuel (fsamuelohnoyoudont@google.com)
- Xo Wang (xowohnoyoudont@google.com)
- Brett Wilson (brettwohnoyoudont@google.com)
- Scott Graham (scottmgohnoyoudont@google.com)
- Craig Tiller (craig.tillerohnoyoudont@gmail.com)
- Cristián Donoso (donosocohnoyoudont@google.com)
- Scott Graham (scottmgohnoyoudont@google.com)
- Scott Graham (scottmgohnoyoudont@google.com)
- Chris Phoenix (cphoenixohnoyoudont@google.com)
- Craig Tiller (ctillerohnoyoudont@google.com)
- Christopher R. Johnson (crjohnsohnoyoudont@google.com)
- Adam Barth (abarthohnoyoudont@google.com)
- Xo Wang (xowohnoyoudont@google.com)
- Scott Graham (scottmgohnoyoudont@google.com)
- Emircan Uysaler (emircanohnoyoudont@chromium.org)
- Adam Barth (abarthohnoyoudont@chromium.org)
- Tom Turney (tturneyohnoyoudont@google.com)
- Craig Tiller (ctillerohnoyoudont@google.com)
- Joshua Seaton (joshuaseatonohnoyoudont@google.com)
- Benjamin Lerman (qsrohnoyoudont@chromium.org)
- Jeremy Manson (jeremymansonohnoyoudont@google.com)
- Adam Barth (abarthohnoyoudont@chromium.org)
- James Tucker (raggiohnoyoudont@google.com)
- Adam Barth (abarthohnoyoudont@chromium.org)
- Alex Legg (alexleggohnoyoudont@google.com)
- Petr Hosek (phosekohnoyoudont@google.com)
- Adam Barth (abarthohnoyoudont@chromium.org)
- Adrian Danis (adanisohnoyoudont@google.com)
- Adam Barth (abarthohnoyoudont@chromium.org)
- Adam Barth (abarthohnoyoudont@chromium.org)
- <blame list capped at 100 commits> ()
Timing:
| Create | Tuesday, 12-Feb-19 09:00:41 UTC |
| Start | Tuesday, 12-Feb-19 09:00:50 UTC |
| End | Tuesday, 12-Feb-19 09:29:34 UTC |
| Pending | 8 secs |
| Execution | 28 mins 43 secs |
All Changes:
-
[bt][l2cap] fix includes for Channel
Changed by mukesh agrawal - quicheohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 08:27:29 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 66632b640a92fa2baaadc44b521dfc84c5044995 Comments
[bt][l2cap] fix includes for Channel Channel references some symbols that are provided indirectly by sdu.h, rather than including the relevant headers directly. Update channel.h to include the relevant headers, so that we don't run into problems when we change the relationship betwen SDU and PDU. Bug: BT-716 Test: fx run-test bluetooth-tests -t bt-host-unittests Change-Id: I139d92b21a080d86bf906f6cd648c16bcfe79d3d
Changed files
- garnet/drivers/bluetooth/lib/l2cap/channel.h
-
[ledger] Reorder fx run-test parameters in documentation
Changed by Gabriel Kerneis - kerneisohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 08:18:31 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 78cae7903fb70c14148fbac54dafc93fed9b3965 Comments
[ledger] Reorder fx run-test parameters in documentation fx run-test now needs -t parameters to come after the package name. Test: ran documented commands Change-Id: I5b360c9b52c325c44ec597590ac4588d7958228a
Changed files
- peridot/bin/cloud_provider_firestore/README.md
- peridot/docs/ledger/testing.md
-
[banjo] Add support for more types of constants.
Changed by Suraj Malhotra - surajmalhotraohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 08:13:19 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 5c63a668d27b3b49c956de03d62545a84bf868e1 Comments
[banjo] Add support for more types of constants. In addition, a validation step post-constant ast parsing was added to validate constant types are correct. Tested: fx run-host-tests banjo_host_tests Change-Id: If67c4a7e694909fa3a18374662fe83ed7078790c
Changed files
- garnet/bin/banjo/src/ast.rs
- garnet/bin/banjo/src/backends/c.rs
- garnet/bin/banjo/src/backends/cpp.rs
- garnet/bin/banjo/src/parser.rs
- garnet/bin/banjo/test/ast/alignment.test.ast
- garnet/bin/banjo/test/ast/example-0.test.ast
- garnet/bin/banjo/test/ast/example-1.test.ast
- garnet/bin/banjo/test/ast/example-2.test.ast
- garnet/bin/banjo/test/ast/example-3.test.ast
- garnet/bin/banjo/test/ast/example-4.test.ast
- garnet/bin/banjo/test/ast/example-8.test.ast
- garnet/bin/banjo/test/ast/example-9.test.ast
- garnet/bin/banjo/test/ast/point.test.ast
- garnet/bin/banjo/test/ast/simple.test.ast
- garnet/bin/banjo/test/ast/tables.test.ast
- garnet/bin/banjo/test/ast/types.test.ast
- garnet/bin/banjo/test/ast/view.test.ast
- garnet/bin/banjo/test/ast_tests.rs
- garnet/bin/banjo/test/banjo/types.test.banjo
-
[catapult_converter] make it a shell command
Changed by James Tucker - raggiohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 07:52:37 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision d767889a2b2f63bb2dcbcf63625d809ceaae8182 Comments
[catapult_converter] make it a shell command A shell command is required to invoke this program inside a shell environment that does not share a library ABI intersection with the binaries dependencies. Test: manual invocation of benchmarks.sh Change-Id: I990c6d8d01c62daab7e6cc38e76563af70507bd7
Changed files
- garnet/bin/catapult_converter/BUILD.gn
- garnet/testing/runbenchmarks/runbenchmarks.sh
-
[bt][rfcomm] apply clang-format
Changed by mukesh agrawal - quicheohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 06:50:09 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 85b0a8bc495504b1d93d0e93e0cbf7183cf389f4 Comments
[bt][rfcomm] apply clang-format We need to modify the Session class as part of updating l2cap::Channel to invoke |rx_callback| with a ByteBuffer instead of a PDU. Apply clang-format to the Session class before-hand, to make the upcoming patch clearer. Bug: BT-716 Test: fx run-test bluetooth-tests -t bt-host-unittests Change-Id: I00ccc926c95ae043a7683321da0ba7e1a43036bf
Changed files
- garnet/drivers/bluetooth/lib/rfcomm/session.cc
-
Revert "[netstack] Route table re-architecture"
Changed by Nicolas Sylvain - nsylvainohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 06:04:53 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 7705b57b0545b7bb07c05fd400a5b22befaacbe6 Comments
Revert "[netstack] Route table re-architecture" This reverts commit 52059d0841223d5c3001d1204d37e511f747cb28. Reason for revert: breaks global integration Original change's description: > [netstack] Route table re-architecture > > Note: Part of the code implements a soft transition in the netstack.fidl to > avoid breaking Chromium. The soft transition copies and extends the > NetInterface and RouteTableEntry structs as well as the functions using them. > Once Chromium transitions away from netstack.fidl this can be removed. > > The main change cleans up and improves the route table logic by doing several > things: > > 1) > The per-interface route tables stored in netiface.NIC are removed and > consolidated in its own route_table package and RouteTable type. > > 2) > The fuchsia.netstack.fidl RouteTableTransaction interface is simplified by > replacing the current {Get,Set}RouteTable and Commit functions with simpler > {Add,Del}Route ones. This also matches the {Add,Del}ForwardingEntry APIs in the > new fuchsia.net.stack nicely. > > 3) > > The RouteTable type implements a sorted table of routes that carry additional > attributes besides the standard tcpip.Route, most importantly a metric value > that is used as a tie-breaker when sorting the table. The metric can either be > statically chosen by the user, or dynamically chosen by tracking the metric of > the interface the route points to. An according metric value is added to the > netiface.NIC struct, which can be overwritten via ifconfig command. This allows > to favor defaults routes going out a specific interface. E.g., if both WLAN and > Ethernet ports have obtained IP addresses and gateways via DHCP, setting a > lower metric on the WLAN interface can favor it over the Ethernet one so its > default route is sorted above the Ethernet's. > > In addition, static IPs assigned to an interface as well as their subnet routes > are not removed anymore when the interface goes down. Rather, Netstack > remembers whether the address was obtained dynamically (DHCP) or statically and > only removes the dynamic one. Static IPs remain assigned, but its subnet route > disabled via an extended route attribute, so it isn't used by gVisor Netstack. > Eventually, this behavior should be coming from netcfg. > > NET-1773 #done > NET-1916 #done > NET-2054 #done > NET-1978 > NET-1223 > > Tested: > - Unit-tests: fx run-test netstack_gotests > > - Manual tests on device: > Plug eth04p into MacBook, configure static IP on MacBook: > sudo ifconfig en8 inet 192.168.10.2 netmask 255.255.255.0 > > On Toulouse: > fx shell ifconfig ethp04 up > fx shell ifconfig ethp04 > (should be UP, metric 100) > > fx shell ifconfig ethp04 add 192.168.10.3/24 && fx shell ifconfig ethp04 && \ > fx shell ifconfig route show > (verify new IP is set, and new "192.168.10.0/24 via ethp04 metric 100" route entry in the proper place) > > ping 192.168.10.2 > (pinging MacBook succeeds, same goes for the other direction pinging > 192.168.10.3 from MacBook) > > fx shell ifconfig ethp04 down && fx shell ifconfig ethp04 && \ > fx shell ifconfig route show > (IP address and route remain, but are disabled) > > ping 192.168.10.2 > (Pinging either direction doesn't work) > > fx shell ifconfig ethp04 up && fx shell ifconfig ethp04 up && \ > fx shell ifconfig ethp04 && fx shell ifconfig route show > (IP and route still there, re-enabled) > > ping 192.168.10.2 > (pinging works again in both directions) > > fx shell ifconfig ethp04 metric 50 && fx shell ifconfig ethp04 && \ > fx shell ifconfig route show > (if and route metric changed to 50, route moved up one spot) > > fx shell ifconfig route add 192.168.20.0/24 iface ethp04 && \ > fx shell ifconfig ethp04 && fx shell ifconfig route show > (Route is added to the table, no gateway, metric is 50 from ethp04) > > fx shell ifconfig route add 192.168.30.0/24 iface ethp04 gateway \ > 192.168.30.1 metric 150 && fx shell ifconfig ethp04 && \ > fx shell ifconfig route show > (Route is added, with gateway, metric is 150, not tracking ethp04, sorted > below the other routes on ethp04 due to higher metric) > > fx shell ifconfig route add 0.0.0.0/0 iface ethp04 gateway 192.168.30.1 \ > metric 110 && fx shell ifconfig ethp04 && fx shell ifconfig route show > (Default is added, with gateway 192.168.30.1, metric 110 not tracking > ethp04, sorted below other default routes due to higher metric) > > fx shell ifconfig ethp04 metric 200 && fx shell ifconfig ethp04 && \ > fx shell ifconfig route show > (all routes tracking ethp04's are updated to metric=200 and the table is > resorted) > > fx shell ifconfig route del 0.0.0.0/0 iface ethp04 && \ > fx shell ifconfig ethp04 && fx shell ifconfig route show > (Removes default route on ethp04) > > fx shell ifconfig route del 192.168.30.0/24 && fx shell ifconfig ethp04 && \ > fx shell ifconfig route show > > fx shell ifconfig route del 192.168.20.0/24 && fx shell ifconfig ethp04 && \ > fx shell ifconfig route show > (Removes 192.168.{30,20}/24 routes) > > fx shell ifconfig ethp04 del 192.168.10.3/24 && fx shell ifconfig ethp04 && \ > fx shell ifconfig route show > (IP and route are removed) > > Change-Id: Id6b4232986493ec313d29d4f236461c491eeda2e TBR=stijlist@google.com,tamird@google.com,eyalsoha@google.com,brunodalbo@google.com,ckuiper@google.com Change-Id: I70843342680d315447b29db62de4b83f6bb7754c No-Presubmit: true No-Tree-Checks: true No-Try: trueChanged files
- garnet/bin/guest/integration/mock_netstack.h
- garnet/bin/guest/vmm/device/virtio_net_test.cc
- garnet/bin/netcfg/src/main.rs
- garnet/bin/netemul_runner/helpers/netstack_cfg/src/main.rs
- garnet/bin/netemul_runner/test/netstack_socks/src/child.rs
- garnet/go/src/netstack/BUILD.gn
- garnet/go/src/netstack/connectivity/connectivity.go
- garnet/go/src/netstack/connectivity/connectivity_test.go
- garnet/go/src/netstack/ifconfig/ifconfig.go
- garnet/go/src/netstack/ifconfig/ifconfig_test.go
- garnet/go/src/netstack/main.go
- garnet/go/src/netstack/netiface/netiface.go
- garnet/go/src/netstack/netiface/netiface_test.go
- garnet/go/src/netstack/netstack.go
- garnet/go/src/netstack/netstack_service.go
- garnet/go/src/netstack/netstack_service_impl_test.go
- garnet/go/src/netstack/netstack_test.go
- garnet/go/src/netstack/netstat/netstat.go
- garnet/go/src/netstack/routes/BUILD.gn
- garnet/go/src/netstack/routes/routes.go
- garnet/go/src/netstack/routes/routes_test.go
- garnet/go/src/netstack/util/parse.go
- garnet/go/src/netstack/util/parse_test.go
- garnet/packages/tests/netstack
- sdk/fidl/fuchsia.netstack/netstack.fidl
-
[magma] Fix build with magma_enable_tracing=false
Changed by Roland McGrath - mcgrathrohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 05:39:29 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision e7277fa66ae349257cc9fbfc79fd97976e1b35ae Comments
[magma] Fix build with magma_enable_tracing=false There's some bit rot in this untested configuration. Test: fx set arm64 --args=magma_enable_tracing=false --available garnet/packages/kitchen_sink && fx full-build Change-Id: Ibdf645cccbb484964b6da11343ebe45c52743ad4
Changed files
- garnet/drivers/gpu/msd-arm-mali/src/job_scheduler.cc
- garnet/lib/magma/src/magma_util/platform/zircon/zircon_platform_trace.cc
-
[cleo][audio] Add audio recording support
Changed by Andres Oportus - andresoportusohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 05:38:59 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 5e1bb87047c9b65fe05f447904e6aec669a402b2 Comments
[cleo][audio] Add audio recording support Test: record a wav file, check validity and listen to contents. $ audio record /tmp/noise.wav 10 audio record /tmp/noise.wav Recording for 10.0 seconds ZX-3345 # done Change-Id: I1a6408c890800b3d705f150cedef353c7464909d
Changed files
- zircon/system/dev/board/mt8167s_ref/mt8167-audio.cpp
-
[fidlcat] Pending comments from previous submission.
Changed by Jeremy Manson - jeremymansonohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 05:25:59 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 9c900245b0083323e7ae9788722fac6851d2c10f Comments
[fidlcat] Pending comments from previous submission. Test: fx run-test fidlcat_tests Change-Id: Ic5e1290b3ea03da16bfd9b69833bfe14c4e64acb
Changed files
- garnet/bin/fidlcat/lib/library_loader.cc
-
[zxdb] Refer to test data in build directory
Changed by Joshua Seaton - joshuaseatonohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 05:13:09 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision b26bfe60315b2e0c231860bfeba237468a889d7c Comments
[zxdb] Refer to test data in build directory A continuation of https://fuchsia-review.googlesource.com/c/garnet/+/238489 and https://fuchsia-review.googlesource.com/c/fuchsia/+/250309 Test: fuchsia-x64-release-host, an optional tryjob that runs linux tests on a separate bot: zxdb_tests passed https://ci.chromium.org/p/fuchsia/builders/luci.fuchsia.try/fuchsia-x64-release-host/b8921859779873716160 Bug: IN-819 Change-Id: Ic1888f2ed7de44aa03a8a4c8bcc9217f993027bc
Changed files
- garnet/bin/zxdb/symbols/BUILD.gn
- garnet/bin/zxdb/symbols/build_id_index_unittest.cc
- garnet/lib/debug_ipc/helper/BUILD.gn
- garnet/lib/debug_ipc/helper/elf_unittest.cc
-
[component] Remove StartupContext::CreateFromStartupInfoNotChecked
Changed by Adam Barth - abarthohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 04:51:09 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision d09d2888f155f3193f76491f4db88ec749dfd7da Comments
[component] Remove StartupContext::CreateFromStartupInfoNotChecked This function is deprecated and unused. Test: Compiles. Change-Id: Iece2972ff92d747763cfeda856d80e16838bde83
Changed files
- garnet/public/lib/component/cpp/startup_context.cc
- garnet/public/lib/component/cpp/startup_context.h
-
[escher] Final prep for Scenic/PaperRenderer2 integration.
Changed by Josh Gargus - jjoshohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 04:41:29 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision a18c1abb2cb0822f0c47eedf8ef3bc87d2cb6592 Comments
[escher] Final prep for Scenic/PaperRenderer2 integration. The biggest change is for PaperRenderer2 to always use the "latched pose buffer" representation for camera matrices, and to use a Vulkan push constant to choose the left or right eye matrix. This is the easiest way to maintain compatibility with the old PaperRenderer. Escher's CommandBuffer abstraction has a limitation where it stomps on binding-resource IDs when beginning a render pass. This CL adds DCHECKs to detect such misuse. Various Scenic clients (root_presenter and examples) are updated in anticipation of the PaperRenderer2 integration. For example, hello_scenic takes a command-line argument to specify the shadow-type to use, and also exercises clipping using the recently-added SetClipPlanesCmd. Also, the upcoming "stencil shadows" will initially only work with PointLights, so clients add these in addition to the existing ambient and directional lights. SCN-670 #comment TEST= hello_scenic, hello_base_view, hello_pose_buffer, hello_stereo escher_unittests (host and target) Change-Id: I3e9cc9576e1231321044df7af84a8a3f61e86980
Changed files
- garnet/bin/ui/root_presenter/presentation1.cc
- garnet/bin/ui/root_presenter/presentation1.h
- garnet/bin/ui/root_presenter/presentation2.cc
- garnet/bin/ui/root_presenter/presentation2.h
- garnet/examples/escher/waterfall2/waterfall_demo.cc
- garnet/examples/ui/hello_scenic/app.cc
- garnet/examples/ui/hello_scenic/app.h
- garnet/examples/ui/hello_scenic/main.cc
- garnet/examples/ui/shadertoy/client/view.cc
- garnet/lib/ui/gfx/engine/engine_renderer.cc
- garnet/public/lib/escher/BUILD.gn
- garnet/public/lib/escher/forward_declarations.h
- garnet/public/lib/escher/impl/model_display_list_builder.cc
- garnet/public/lib/escher/paper/paper_renderer2.cc
- garnet/public/lib/escher/paper/paper_renderer2.h
- garnet/public/lib/escher/paper/paper_shader_structs.h
- garnet/public/lib/escher/resources/resource.cc
- garnet/public/lib/escher/scene/camera.h
- garnet/public/lib/escher/shaders/model_renderer/main.vert
- garnet/public/lib/escher/shaders/paper/common/use.glsl
- garnet/public/lib/escher/shaders/paper/frag/main_ambient_light.frag
- garnet/public/lib/escher/test/vk/shader_program_unittest.cc
- garnet/public/lib/escher/third_party/granite/vk/command_buffer.cc
-
[banjo][test][c] Add test for unions, fix default union size, unify constant represntation
Changed by Benjamin Brittain - bwbohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 04:38:29 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision f9be3b943cea709a93a5a386b044b27b04da3760 Comments
[banjo][test][c] Add test for unions, fix default union size, unify constant represntation Test: fx run-host-tests banjo_host_tests Change-Id: I42b175500b9611700ecfa4d7efbc89ef150d3ee1
Changed files
- garnet/bin/banjo/src/ast.rs
- garnet/bin/banjo/src/backends/c.rs
- garnet/bin/banjo/test/ast/enums.test.ast
- garnet/bin/banjo/test/ast/example-4.test.ast
- garnet/bin/banjo/test/ast/example-6.test.ast
- garnet/bin/banjo/test/ast/example-9.test.ast
- garnet/bin/banjo/test/ast/simple.test.ast
- garnet/bin/banjo/test/banjo/example-4.test.banjo
- garnet/bin/banjo/test/c/example-4.h
- garnet/bin/banjo/test/codegen_tests.rs
-
[kernel][dev][hw_rng] ASSERTing in hw_rng_get_u32() in non-error case.
Changed by Marty Faltesek - mfaltesekohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 04:29:52 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 222f755e014dc4ed7eb52fef38290ad54f01cf21 Comments
[kernel][dev][hw_rng] ASSERTing in hw_rng_get_u32() in non-error case. ASSERT in hw_rng_get_u32 trips in the legitimate case when hw_rng_get_entropy() returns 0 if a platform doesn't support hardware RNG. Instead print a message if HW RNG is not present. Test: QEMU x64/arm64 no longer panics when running 'k rng32'. Test: works on pixelbook. ZX-1417 Change-Id: I5e88917e705f6baa4a4351a8adbd8eb7b73f5740
Changed files
- zircon/kernel/dev/hw_rng/debug.cpp
- zircon/kernel/dev/hw_rng/include/dev/hw_rng.h
-
[gn][zbi] Avoid implicit-int-conversion warning on clang
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 04:29:50 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 5466a0977ad7bd0177419accd9093e188cda7066 Comments
[gn][zbi] Avoid implicit-int-conversion warning on clang With warnings enabled in pending gn build, clang doesn't like using subtraction to mask for alignment. [0->1/1 ~1] CXX host-x64-linux-clang/obj/system/host/zbi/zbi.zbi.cpp.o ../system/host/zbi/zbi.cpp:1273:30: warning: higher order bits are zeroes after implicit conversion [-Wimplicit-int-conversion] size_t header_size = ZBI_BOOTFS_PAGE_ALIGN(sizeof(header) + dirsize); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../system/public/zircon/boot/image.h:287:44: note: expanded from macro 'ZBI_BOOTFS_PAGE_ALIGN' (((size) + ZBI_BOOTFS_PAGE_SIZE - 1) & -ZBI_BOOTFS_PAGE_SIZE) ~ ^~~~~~~~~~~~~~~~~~~~~ ZX-3415 #comment [gn][zbi] Avoid implicit-int-conversion warning on clang Test: CQ Change-Id: I13d5515db89694632590663d0c35ea0af1001733Changed files
- zircon/system/public/zircon/boot/image.h
-
[devhost][fidl] Implement the new fuchsia.device.Controller interface
Changed by Todd Eisenberger - teisenbeohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 03:57:23 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 59ada012c3eef73a7bcd450135d2db777a1db610 Comments
[devhost][fidl] Implement the new fuchsia.device.Controller interface Test: None ZX-3410 #comment Implement the interface Change-Id: Ifcd72c4c1a889e0e5e45131bd21833258ccd937d
Changed files
- zircon/system/core/devmgr/devhost/rpc-server.cpp
- zircon/system/ulib/driver/rules.mk
-
[fidlc] Support for byte and bytes alias
Changed by Pascal Perez - pascallouisohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 03:52:40 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 369e09bdc50c28f4976124735f94b25b7f73c890 Comments
[fidlc] Support for byte and bytes alias Adding two new built-ins, `byte` and `bytes`, to represent uint8 and vector<uint8> respectively. The `bytes` alias can be bounded, or marked nullable, i.e. it is a replacement to using a vector of uint8. We'd like to support such aliasing generically, and discussions to that effect have been ongoing, but this feels like a nice small addition while we're waiting on a larger more general solution. FIDL-483 #progress Test: added one Test: make -j 72 HOST_USE_ASAN=true tools && ./build-x64/host_tests/fidl-compiler-test Change-Id: I10660b93478a9f4b9bb148ae3df2f17df9665073
Changed files
- zircon/system/host/fidl/lib/flat_ast.cpp
- zircon/system/utest/fidl-compiler/json_generator_tests.cpp
-
[gn][libfs] Fix shortening warning in block-txn.cpp
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 03:52:38 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 19fe41c28d4e08557d0ad5f38959d74f6b03533e Comments
[gn][libfs] Fix shortening warning in block-txn.cpp Pending gn host build will be more strict and reports: [0->1/1 ~1] CXX host-x64-linux-clang/obj/system/ulib/fs/libfs.block-txn.cpp.o ../system/ulib/fs/block-txn.cpp:93:43: warning: implicit conversion loses integer precision: 'unsigned long' to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] handler_->Writeblk(dev_offset + b, data); ~~~~~~~~ ~~~~~~~~~~~^~~ ../system/ulib/fs/block-txn.cpp:95:42: warning: implicit conversion loses integer precision: 'unsigned long' to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] handler_->Readblk(dev_offset + b, data); ~~~~~~~ ~~~~~~~~~~~^~~ ZX-3415 #comment [gn][libfs] Fix shortening warning in block-txn.cpp Test: CQ Change-Id: I1df3531502b627f6fac159629b5892016e165e69Changed files
- zircon/system/ulib/fs/block-txn.cpp
-
[fdio][ns] Reimplement local filesystem in safe C++
Changed by Sean Klein - smkleinohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 03:52:15 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 895e23fb293d47e565f731d9c1c136aa2491a81b Comments
[fdio][ns] Reimplement local filesystem in safe C++ - Fix incorrect accounting of namespace refcounting (debug asserts revealed that in the previous implementation, the refcount commonly became negative). Utilize fbl::RefPtr to to automatically track references. - Alter API of |fdio_ns_destroy| to free the namespace when all strong references go out of scope. All (known) clients within Fuchsia have ignored the "in-use" error, which would have caused leaks. - Alter API of |fdio_ns_bind| to close the supplied handle on failure. - Encapsulate and isolate logic for local vnodes, connections, and filesystems into distinct classes. Minimize surface area between "safe C++" API and "raw C" API. - Add reference counting to local vnodes, which will safely permit usage of their remote objects, even if the node is unlinked. - Reimplement "flat namespace" exporting logic to track a prefix string in a single StringBuffer, populated once. This version is more efficient, as it does not require re-constructing the path back to root when each remote node is encountered. - Add multiple tests for exporting, shadowing, re-binding, destruction, etc. TEST=Multiple tests added in /boot/sys/namespace-test Change-Id: I5f908e3837061c352dc4b749dd6892015e8a2969
Changed files
- zircon/system/ulib/fdio/include/lib/fdio/namespace.h
- zircon/system/ulib/fdio/namespace.cpp
- zircon/system/ulib/fdio/namespace/local-connection.cpp
- zircon/system/ulib/fdio/namespace/local-connection.h
- zircon/system/ulib/fdio/namespace/local-filesystem.cpp
- zircon/system/ulib/fdio/namespace/local-filesystem.h
- zircon/system/ulib/fdio/namespace/local-vnode.cpp
- zircon/system/ulib/fdio/namespace/local-vnode.h
- zircon/system/ulib/fdio/namespace/namespace.cpp
- zircon/system/ulib/fdio/rules.mk
- zircon/system/ulib/memfs/memfs-local.cpp
- zircon/system/utest/namespace/namespace-test.c
- zircon/system/utest/namespace/namespace-test.cpp
- zircon/system/utest/namespace/rules.mk
-
[netstack] Route table re-architecture
Changed by Chris Kuiper - ckuiperohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 03:49:17 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 52059d0841223d5c3001d1204d37e511f747cb28 Comments
[netstack] Route table re-architecture Note: Part of the code implements a soft transition in the netstack.fidl to avoid breaking Chromium. The soft transition copies and extends the NetInterface and RouteTableEntry structs as well as the functions using them. Once Chromium transitions away from netstack.fidl this can be removed. The main change cleans up and improves the route table logic by doing several things: 1) The per-interface route tables stored in netiface.NIC are removed and consolidated in its own route_table package and RouteTable type. 2) The fuchsia.netstack.fidl RouteTableTransaction interface is simplified by replacing the current {Get,Set}RouteTable and Commit functions with simpler {Add,Del}Route ones. This also matches the {Add,Del}ForwardingEntry APIs in the new fuchsia.net.stack nicely. 3) The RouteTable type implements a sorted table of routes that carry additional attributes besides the standard tcpip.Route, most importantly a metric value that is used as a tie-breaker when sorting the table. The metric can either be statically chosen by the user, or dynamically chosen by tracking the metric of the interface the route points to. An according metric value is added to the netiface.NIC struct, which can be overwritten via ifconfig command. This allows to favor defaults routes going out a specific interface. E.g., if both WLAN and Ethernet ports have obtained IP addresses and gateways via DHCP, setting a lower metric on the WLAN interface can favor it over the Ethernet one so its default route is sorted above the Ethernet's. In addition, static IPs assigned to an interface as well as their subnet routes are not removed anymore when the interface goes down. Rather, Netstack remembers whether the address was obtained dynamically (DHCP) or statically and only removes the dynamic one. Static IPs remain assigned, but its subnet route disabled via an extended route attribute, so it isn't used by gVisor Netstack. Eventually, this behavior should be coming from netcfg. NET-1773 #done NET-1916 #done NET-2054 #done NET-1978 NET-1223 Tested: - Unit-tests: fx run-test netstack_gotests - Manual tests on device: Plug eth04p into MacBook, configure static IP on MacBook: sudo ifconfig en8 inet 192.168.10.2 netmask 255.255.255.0 On Toulouse: fx shell ifconfig ethp04 up fx shell ifconfig ethp04 (should be UP, metric 100) fx shell ifconfig ethp04 add 192.168.10.3/24 && fx shell ifconfig ethp04 && \ fx shell ifconfig route show (verify new IP is set, and new "192.168.10.0/24 via ethp04 metric 100" route entry in the proper place) ping 192.168.10.2 (pinging MacBook succeeds, same goes for the other direction pinging 192.168.10.3 from MacBook) fx shell ifconfig ethp04 down && fx shell ifconfig ethp04 && \ fx shell ifconfig route show (IP address and route remain, but are disabled) ping 192.168.10.2 (Pinging either direction doesn't work) fx shell ifconfig ethp04 up && fx shell ifconfig ethp04 up && \ fx shell ifconfig ethp04 && fx shell ifconfig route show (IP and route still there, re-enabled) ping 192.168.10.2 (pinging works again in both directions) fx shell ifconfig ethp04 metric 50 && fx shell ifconfig ethp04 && \ fx shell ifconfig route show (if and route metric changed to 50, route moved up one spot) fx shell ifconfig route add 192.168.20.0/24 iface ethp04 && \ fx shell ifconfig ethp04 && fx shell ifconfig route show (Route is added to the table, no gateway, metric is 50 from ethp04) fx shell ifconfig route add 192.168.30.0/24 iface ethp04 gateway \ 192.168.30.1 metric 150 && fx shell ifconfig ethp04 && \ fx shell ifconfig route show (Route is added, with gateway, metric is 150, not tracking ethp04, sorted below the other routes on ethp04 due to higher metric) fx shell ifconfig route add 0.0.0.0/0 iface ethp04 gateway 192.168.30.1 \ metric 110 && fx shell ifconfig ethp04 && fx shell ifconfig route show (Default is added, with gateway 192.168.30.1, metric 110 not tracking ethp04, sorted below other default routes due to higher metric) fx shell ifconfig ethp04 metric 200 && fx shell ifconfig ethp04 && \ fx shell ifconfig route show (all routes tracking ethp04's are updated to metric=200 and the table is resorted) fx shell ifconfig route del 0.0.0.0/0 iface ethp04 && \ fx shell ifconfig ethp04 && fx shell ifconfig route show (Removes default route on ethp04) fx shell ifconfig route del 192.168.30.0/24 && fx shell ifconfig ethp04 && \ fx shell ifconfig route show fx shell ifconfig route del 192.168.20.0/24 && fx shell ifconfig ethp04 && \ fx shell ifconfig route show (Removes 192.168.{30,20}/24 routes) fx shell ifconfig ethp04 del 192.168.10.3/24 && fx shell ifconfig ethp04 && \ fx shell ifconfig route show (IP and route are removed) Change-Id: Id6b4232986493ec313d29d4f236461c491eeda2eChanged files
- garnet/bin/guest/integration/mock_netstack.h
- garnet/bin/guest/vmm/device/virtio_net_test.cc
- garnet/bin/netcfg/src/main.rs
- garnet/bin/netemul_runner/helpers/netstack_cfg/src/main.rs
- garnet/bin/netemul_runner/test/netstack_socks/src/child.rs
- garnet/go/src/netstack/BUILD.gn
- garnet/go/src/netstack/connectivity/connectivity.go
- garnet/go/src/netstack/connectivity/connectivity_test.go
- garnet/go/src/netstack/ifconfig/ifconfig.go
- garnet/go/src/netstack/ifconfig/ifconfig_test.go
- garnet/go/src/netstack/main.go
- garnet/go/src/netstack/netiface/netiface.go
- garnet/go/src/netstack/netiface/netiface_test.go
- garnet/go/src/netstack/netstack.go
- garnet/go/src/netstack/netstack_service.go
- garnet/go/src/netstack/netstack_service_impl_test.go
- garnet/go/src/netstack/netstack_test.go
- garnet/go/src/netstack/netstat/netstat.go
- garnet/go/src/netstack/routes/BUILD.gn
- garnet/go/src/netstack/routes/routes.go
- garnet/go/src/netstack/routes/routes_test.go
- garnet/go/src/netstack/util/parse.go
- garnet/go/src/netstack/util/parse_test.go
- garnet/packages/tests/netstack
- sdk/fidl/fuchsia.netstack/netstack.fidl
-
[test-spec] Clean up old codepaths
Changed by Joshua Seaton - joshuaseatonohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 03:44:11 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 0d84253be72a07db38556301fea29df0344b1ba1 Comments
[test-spec] Clean up old codepaths With the use of gn's metadata, we no longer need to (1) write individual test spec files, and (2) create host_tests.json Test: gn gen Change-Id: I44205e1b7b709b461ed8f6eaadce5b90932f98e1
Changed files
- build/package.gni
- build/testing/test_spec.gni
-
[escher] Specify runtime deps
Changed by Joshua Seaton - joshuaseatonohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 03:43:22 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision e524db55265cca4be853f706ec1ac4840a57a326 Comments
[escher] Specify runtime deps The specification of runtime deps on a linux/mac test is needed for portable testing so that it may be run outside of the tree. Moreover, this change removes the dependency of these tests on tree source. See test_spec.gni in https://fuchsia-review.googlesource.com/c/fuchsia/+/249798 for how this information will be aggregated. Bug: IN-819 Test: No change to production; correct test metadata produced. Change-Id: I79fe2697a4b96bbea6a2667e79791da8c398d663
Changed files
- garnet/examples/escher/common/BUILD.gn
- garnet/examples/escher/waterfall2/waterfall_demo.cc
- garnet/public/lib/escher/fs/fuchsia_data_source.cc
- garnet/public/lib/escher/fs/fuchsia_data_source.h
- garnet/public/lib/escher/fs/hack_filesystem.cc
- garnet/public/lib/escher/fs/hack_filesystem.h
- garnet/public/lib/escher/fs/linux_data_source.cc
- garnet/public/lib/escher/fs/linux_data_source.h
- garnet/public/lib/escher/shaders/BUILD.gn
- garnet/public/lib/escher/test/BUILD.gn
-
Revert "[perfcompare] Add new entry point for perfcompare recipe to invoke"
Changed by Nicolas Sylvain - nsylvainohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 03:39:14 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 0e474a7d48676b86d42d235a4d580aa50199da3d Comments
Revert "[perfcompare] Add new entry point for perfcompare recipe to invoke" This reverts commit f26b0a7a35cced57c0ce7eab63df5c1f53221027. Reason for revert: appears to break vg bots in gi Original change's description: > [perfcompare] Add new entry point for perfcompare recipe to invoke > > Add benchmarks_perfcompare.sh. > > This initial version runs a subset of the tests that benchmarks.sh > runs, because the full set takes too much time for the bot to run > twice without going over the bot's current timeout limit. Running a > faster set of tests is also easier for development testing of the > perfcompare recipe. > > Bug: IN-646 > Test: tested via 'led' with recipe change > Change-Id: I54349d462423cd89dc051f0ae69d91f908793842 TBR=mseaborn@google.com,nathanrogers@google.com Change-Id: I890aed3617eb9b811985a7841390549f612f8018 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: IN-646
Changed files
- garnet/tests/benchmarks/BUILD.gn
- garnet/tests/benchmarks/benchmarks_perfcompare.sh
-
[gn][minfs] Avoid shortening warnings on host build of minfs
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 03:33:32 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 21ad30acfde596f93f3abdb801843ce61f568b8a Comments
[gn][minfs] Avoid shortening warnings on host build of minfs [8829->37/8923 ~58] CXX host-x64-linux-clang/obj/system/ulib/minfs/libminfs.minfs.cpp.o ../system/ulib/minfs/minfs.cpp:251:50: warning: implicit conversion loses integer precision: 'unsigned long' to 'minfs::blk_t' (aka 'unsigned int') [-Wshorten-64-to-32] ibm_block_count_ = bc.extent_lengths_[1] / kMinfsBlockSize; ~ ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~ ZX-3415 #comment [gn][minfs] Avoid shortening warnings on host build of minfs Test: CQ Change-Id: I90d7488b02302b615d5d11b9ba669cad865b181fChanged files
- zircon/system/ulib/minfs/minfs.cpp
-
[gn][fs-host] Satisfy TA_GUARDED in FileSizeRecorder
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 03:32:52 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 2b70405cd02d07dade89a1cb0fb53c4c73104516 Comments
[gn][fs-host] Satisfy TA_GUARDED in FileSizeRecorder Pending host gn build enables more warnings, and it doesn't like null checks or OpenFileSize() without holding the guard. [8874->872/9803 ~58] CXX host-x64-linux-clang/obj/system/ulib/fs-host/libfs-host.file_size_recorder.cpp.o ../system/ulib/fs-host/file_size_recorder.cpp:15:9: warning: reading variable 'sizes_file_' requires holding mutex 'sizes_file_lock_' [-Wthread-safety-analysis] if (sizes_file_) ^ ../system/ulib/fs-host/file_size_recorder.cpp:17:5: warning: reading variable 'sizes_file_' requires holding mutex 'sizes_file_lock_' [-Wthread-safety-analysis] sizes_file_.reset(open(path, O_CREAT|O_TRUNC|O_WRONLY, 0644)); ^ ../system/ulib/fs-host/file_size_recorder.cpp:18:17: warning: reading variable 'sizes_file_' requires holding mutex 'sizes_file_lock_' [-Wthread-safety-analysis] return bool{sizes_file_}; ^ ../system/ulib/fs-host/file_size_recorder.cpp:22:8: warning: reading variable 'sizes_file_' requires holding mutex 'sizes_file_lock_' [-Wthread-safety-analysis] if (!sizes_file_) { ^ 4 warnings generated. ZX-3415 #comment [gn][fs-host] Satisfy TA_GUARDED in FileSizeRecorder Test: CQ Change-Id: I1bd7ad4c17acfc7dd6947e52ea895c0fa2d3a31bChanged files
- zircon/system/ulib/fs-host/file_size_recorder.cpp
-
[gn][banjo] Fix some signedness comparison warnings in gn host build
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 03:29:31 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 708edd9fd20bea4033a44702a13e6a04af611a1e Comments
[gn][banjo] Fix some signedness comparison warnings in gn host build This ends up being a lot of ugly casts, but attempting to change the string indices to size_t was not clearly correct in all cases either. So this is just getting rid of warnings while avoiding changing behaviour in code the might be abandoned in the near future anyway. ZX-3415 #comment [gn][banjo] Fix some signedness comparison warnings in gn host build Test: CQ Change-Id: Ie49031cb89ea36f9a76fdbc2d1a843209d0be8fc
Changed files
- zircon/system/host/banjo/include/banjo/formatter.h
- zircon/system/host/banjo/include/banjo/parser.h
- zircon/system/host/banjo/lib/formatter.cpp
- zircon/system/utest/banjo-compiler/formatter_unittests.cpp
-
[fdio][ns] Convert namespace to C++
Changed by Sean Klein - smkleinohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 03:13:42 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 4ab64e67e20023239519ecd9ac15008239eccabb Comments
[fdio][ns] Convert namespace to C++ TEST=/boot/test/sys/namespace-test Change-Id: I44df3c92ea7577a040a99ea25041a7c26616a9f7
Changed files
- zircon/system/ulib/fdio/fdio.c
- zircon/system/ulib/fdio/namespace.cpp
- zircon/system/ulib/fdio/private-remoteio.h
- zircon/system/ulib/fdio/private.h
- zircon/system/ulib/fdio/rules.mk
-
[devhost][fidl] Introduce an interface for manipulating drivers
Changed by Todd Eisenberger - teisenbeohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 03:11:54 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision b93da8ad0e348286bf709f3eb94880214e6172c3 Comments
[devhost][fidl] Introduce an interface for manipulating drivers This is to replace the ioctl_device_* interface. Test: None ZX-3410 #comment Define the interface Change-Id: I5dddfd54ede31ae1df1da021ab20c0b4c7483011
Changed files
- zircon/system/fidl/fuchsia-device/controller.fidl
- zircon/system/fidl/fuchsia-device/rules.mk
-
[libdriver][tests] Re-enable tests
Changed by Todd Eisenberger - teisenbeohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 03:11:46 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision b209530070cc26af23676d0ed3c0428cd166c06d Comments
[libdriver][tests] Re-enable tests The relevant bug was fixed, so re-enable. ZX-3397 #done Test: Ran test by hand Change-Id: I48b4e07ea1c07f729b295beaf66240321c2b71e0
Changed files
- build/disabled_for_asan.gni
-
[gn][fidl] Fix some sign/shortening warnings in fidl compiler
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 02:58:51 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision ca288928ad9d2484f6b0459176dfd278dd3558d7 Comments
[gn][fidl] Fix some sign/shortening warnings in fidl compiler ZX-3415 #comment [gn][fidl] Fix some sign/shortening warnings in fidl compiler Test: CQ Change-Id: I2f25a259650fc5eb7439fab2382af0147927a59d
Changed files
- zircon/system/host/fidl/lib/ordinals.cpp
- zircon/system/host/fidl/lib/source_file.cpp
- zircon/system/host/fidl/lib/virtual_source_file.cpp
-
[bt] Add macro to propagate fatal failures in subroutines
Changed by Xo Wang - xowohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 01:51:05 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 02f07f6220f69d07d19fd8aa37fcff3e9e589600 Comments
[bt] Add macro to propagate fatal failures in subroutines Add a macro that uses ASSERT_NO_FATAL_FAILURE to check for ASSERTion failures in a subroutine along with a SCOPED_TRACE tool for marking the file and line number where the subroutine call was made. BT-691 Test: Helper not yet used by tests Change-Id: I47f54d2739149c4dcd5deae7a01e6f4d4a84fcfe
Changed files
- garnet/drivers/bluetooth/lib/common/test_helpers.h
-
[auth] Add FakeAccountHandlerContext for use with tests
Changed by Didrik Nordström - dnordstromohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 01:34:33 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision eb229aee6652d0a950bbc8e93f0d8691eb58bb1e Comments
[auth] Add FakeAccountHandlerContext for use with tests This class can be used with local tests which do not intend to test other components, and can in the future be used to synthesize auth providers necessary for integration tests. Includes a spawner which runs the server end, and returns the client end. TEST=fx run-test auth_bin_unittests Change-Id: Iee1af0ef96f3e962d6376f40c2c41839d2f78459
Changed files
- garnet/bin/auth/account_handler/src/test_util.rs
-
[cpp-vfs] Move to sdk.
Changed by Ankur Mittal - anmittalohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 01:10:05 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 76606506229ded274f0b45155216520f666e2e3b Comments
[cpp-vfs] Move to sdk. DX-387 #comment TEST=CQ Change-Id: I327a70176668dc9c3f904733faea55d364524624
Changed files
- garnet/packages/tests/vfs_cpp
- sdk/lib/vfs/cpp/BUILD.gn
- sdk/lib/vfs/cpp/OWNERS
- sdk/lib/vfs/cpp/connection.cc
- sdk/lib/vfs/cpp/connection.h
- sdk/lib/vfs/cpp/directory.cc
- sdk/lib/vfs/cpp/directory.h
- sdk/lib/vfs/cpp/file.cc
- sdk/lib/vfs/cpp/file.h
- sdk/lib/vfs/cpp/file_unittest.cc
- sdk/lib/vfs/cpp/flags.h
- sdk/lib/vfs/cpp/internal/directory_connection.cc
- sdk/lib/vfs/cpp/internal/directory_connection.h
- sdk/lib/vfs/cpp/internal/dirent_filler.cc
- sdk/lib/vfs/cpp/internal/dirent_filler.h
- sdk/lib/vfs/cpp/internal/file_connection.cc
- sdk/lib/vfs/cpp/internal/file_connection.h
- sdk/lib/vfs/cpp/internal/node_connection.cc
- sdk/lib/vfs/cpp/internal/node_connection.h
- sdk/lib/vfs/cpp/meta/vfs_cpp_unittests.cmx
- sdk/lib/vfs/cpp/node.cc
- sdk/lib/vfs/cpp/node.h
- sdk/lib/vfs/cpp/pseudo_dir.cc
- sdk/lib/vfs/cpp/pseudo_dir.h
- sdk/lib/vfs/cpp/pseudo_dir_unittest.cc
- sdk/lib/vfs/cpp/pseudo_file.cc
- sdk/lib/vfs/cpp/pseudo_file.h
- sdk/lib/vfs/cpp/pseudo_file_unittest.cc
- sdk/lib/vfs/cpp/service.cc
- sdk/lib/vfs/cpp/service.h
- sdk/lib/vfs/cpp/service_unittest.cc
-
[build] Disable three more tests for asan
Changed by Jake Ehrlich - jakehehrlichohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 00:51:08 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 767ba998b607cc884a6aa134105d67370b6b7b2d Comments
[build] Disable three more tests for asan ASan uncovered an issue with how appmgr's loader service worked. After this was fixed it revealed bugs in other ASan tests where they were loading a binary that was not included in their package. This change disables those tests for asan until such a time as they are fixed. Test: CQ Change-Id: Ib7fac147b082e6fd14f9e7f9ecc48dd0dce627a9
Changed files
- build/disabled_for_asan.gni
-
[rust][mapped-vmo] Format code according to new rustfmt.toml
Changed by Joshua Liebow-Feeser - joshlfohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 00:38:09 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 9be30b540a2bde08420d5603152e29dc0fd05bcb Comments
[rust][mapped-vmo] Format code according to new rustfmt.toml Test: Existing tests Change-Id: I7f74b99b5a42754b4856115b2445c828a35910f9
Changed files
- garnet/public/rust/mapped-vmo/src/lib.rs
-
[bus][acpi] Move sysmem under platform bus
Changed by John Bauman - jbaumanohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 00:36:51 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 09c4d4adaf5d0750364e976a21f36c13a3c6ea17 Comments
[bus][acpi] Move sysmem under platform bus This lets it register as a protocol device so other drivers under the platform bus can connect to it. Test: boot on NUC Change-Id: Ia6da70d776eda35d00d4f0cd4ec520a5af24acea
Changed files
- zircon/system/dev/bus/acpi/bus-acpi.c
- zircon/system/dev/bus/acpi/include/sysmem.h
- zircon/system/dev/bus/acpi/sysmem.c
-
[devmgr][tests] Fix ASAN issues in test utilities
Changed by Todd Eisenberger - teisenbeohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 00:34:19 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision aa3953c189b19f7182ff24d695ff479954ba3190 Comments
[devmgr][tests] Fix ASAN issues in test utilities We were exposing unique_ptrs across API boundaries, which results in ASAN issues around mismatched allocators. This patch switch to using move semantics instead of unique_ptrs. Test: Ran all affected tests under ASAN ZX-3397 #comment Fixes the framework Change-Id: I78480ef866c0973de1fe68d981a9236e8ad31f57
Changed files
- garnet/tests/zircon/libdriver-integration-test/integration-test.cc
- garnet/tests/zircon/libdriver-integration-test/integration-test.h
- garnet/tests/zircon/libdriver-integration-test/root-mock-device.cc
- garnet/tests/zircon/libdriver-integration-test/root-mock-device.h
- zircon/system/ulib/devmgr-integration-test/include/lib/devmgr-integration-test/fixture.h
- zircon/system/ulib/devmgr-integration-test/launcher.cpp
- zircon/system/ulib/driver-integration-test/include/lib/driver-integration-test/fixture.h
- zircon/system/ulib/driver-integration-test/launcher.cpp
- zircon/system/ulib/driver-integration-test/test/main.cpp
- zircon/system/ulib/ramdevice-client/include/ramdevice-client/ramnand.h
- zircon/system/ulib/ramdevice-client/ramnand.cpp
- zircon/system/utest/driver-test/main.cpp
- zircon/system/utest/platform-bus/main.cpp
-
[modular][puppetmaster] Migrate story commands to mod_name_transitional
Changed by Yegor Pomortsev - ypomortsevohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 00:32:06 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision ba4726fd857d87ab6cc9314f6b3861852271de18 Comments
[modular][puppetmaster] Migrate story commands to mod_name_transitional This is part of a soft transition to convert |mod_name| from a vector to a string. MF-148 #comment Test: CQ Change-Id: Ia25b7b003f210f6eec3f84f9aa8eba24150d935b
Changed files
- peridot/bin/module_resolver/local_module_resolver.cc
- peridot/bin/sessionctl/session_ctl_app.cc
- peridot/bin/sessionctl/session_ctl_app_unittest.cc
- peridot/bin/sessionmgr/dev_session_shell.cc
- peridot/bin/sessionmgr/puppet_master/command_runners/add_mod_command_runner_unittest.cc
- peridot/bin/sessionmgr/puppet_master/dispatch_story_command_executor_unittest.cc
- peridot/bin/sessionmgr/puppet_master/puppet_master_impl_unittest.cc
- peridot/bin/sessionmgr/puppet_master/story_command_executor_unittest.cc
- peridot/bin/suggestion_engine/suggestion_engine_impl_unittest.cc
- peridot/tests/benchmarks/story/modular_benchmark_story_session_shell.cc
- peridot/tests/embed_shell/embed_shell_test_session_shell.cc
- peridot/tests/last_focus_time/last_focus_time_test_session_shell.cc
- peridot/tests/link_context_entities/link_context_entities_test_session_shell.cc
- peridot/tests/maxwell_integration/suggestion_engine_test.cc
- peridot/tests/module_context/module_context_test_session_shell.cc
- peridot/tests/session_shell/session_shell_test_session_shell.cc
- peridot/tests/story_shell/story_shell_test_session_shell.cc
- peridot/tests/suggestion/suggestion_test_session_shell.cc
- peridot/tests/trigger/trigger_test_session_shell.cc
-
[pkg] Readd shell commands to the SDK images.
Changed by P.Y. Laligand - pylaligandohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 00:01:55 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 24a9a658280f49a3317d5a5dad07eea37236724d Comments
[pkg] Readd shell commands to the SDK images. Test: verified that /bin was back on SDK images. Bug: DX-983 #done Change-Id: I0cce9afdc928cfcfa031492b0ee38a45eb584a42
Changed files
- garnet/packages/sdk/garnet
-
[fidl][docs] Remove some explicit ordinals from fidl documentation
Changed by George Kulakowski - kulakowskiohnoyoudont@google.com Changed at Monday, 11-Feb-19 23:50:15 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 7d85d405929bb0678434d987ca2685e150cbf93c Comments
[fidl][docs] Remove some explicit ordinals from fidl documentation Test: looking at gitiles Change-Id: I2229e2fb65f91ccb5d18dd669e0644d6bbd62458
Changed files
- docs/development/api/fidl.md
- docs/development/languages/fidl/reference/attributes.md
- docs/development/languages/fidl/tutorial/tutorial-c.md
- zircon/docs/ddk/simple.md
-
[build] Disable libc++ visibility annotations in our build
Changed by Petr Hosek - phosekohnoyoudont@google.com Changed at Monday, 11-Feb-19 23:43:28 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 726e7335b82ae8033eecc4d2751f2d78aa556b42 Comments
[build] Disable libc++ visibility annotations in our build When building with -fvisibility=hidden, disable libc++ visibility annotations to make sure that -fvisibility=hidden takes effect even on symbols defined in libc++ headers. Bug: MA-554 Test: manual Change-Id: Id181cb4c8b5c542898641f788c26a98922a06564
Changed files
- build/config/BUILD.gn
-
[keyboard] Captured key input should not be dispatched.
Changed by Sanjay Chouksey - sanjaycohnoyoudont@google.com Changed at Monday, 11-Feb-19 23:36:42 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 875de3ac1a79a074de2042fb66edfeb5e3138b80 Comments
[keyboard] Captured key input should not be dispatched. This change prevents captured key input by shells to be delivered to current view in focus. Keyboard capture is a critical need of shells (session or story) to provide keyboard based shell functionality. Testing: manual Change-Id: I04edd772aa33365789b28dd24d1bc7ee233d2c02
Changed files
- garnet/bin/ui/root_presenter/presentation1.cc
- garnet/bin/ui/root_presenter/presentation2.cc
-
[run-image-test] Show deletion message
Changed by Ankur Mittal - anmittalohnoyoudont@google.com Changed at Monday, 11-Feb-19 23:14:33 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 7bb7968fd837f034089860a872b90a0956cd4750 Comments
[run-image-test] Show deletion message Showing deletion message so that people who use it have time to switch to "fx run-test". TEST=CQ Change-Id: Idc000b066043a28f7d13e50540cc240bc44baa34
Changed files
- scripts/devshell/run-image-test
-
[script] Fix header guard to ignore SDK_.
Changed by Ankur Mittal - anmittalohnoyoudont@google.com Changed at Monday, 11-Feb-19 23:13:51 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 8b670b66b8e762f710bc00d6e3b11ccb4b9c2372 Comments
[script] Fix header guard to ignore SDK_. TEST=not needed Change-Id: Idb457f646a37f4d6008692a74e611305faaba92a
Changed files
- scripts/style/check-header-guards.py
-
[cpp-vfs] Implement vfs::Service.
Changed by Ankur Mittal - anmittalohnoyoudont@google.com Changed at Monday, 11-Feb-19 23:12:49 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision bc44c3fe82db0cf63111e93476f6ba12913d4b93 Comments
[cpp-vfs] Implement vfs::Service. DX-387 #comment TEST=fx run-test vfs_cpp_tests Change-Id: I5356bb65644defae46c282a39fa289f5c86a04ee
Changed files
- garnet/public/lib/vfs/cpp/BUILD.gn
- garnet/public/lib/vfs/cpp/directory.cc
- garnet/public/lib/vfs/cpp/node.cc
- garnet/public/lib/vfs/cpp/node.h
- garnet/public/lib/vfs/cpp/service.cc
- garnet/public/lib/vfs/cpp/service.h
- garnet/public/lib/vfs/cpp/service_unittest.cc
-
[overnet] Add OWNERS files
Changed by Craig Tiller - ctillerohnoyoudont@google.com Changed at Monday, 11-Feb-19 23:10:22 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision ed3e2640eab24947aa0ac6ffb11f6de947d34ffc Comments
[overnet] Add OWNERS files Test: unnecessary Change-Id: Ia01a1d71aeebc8a41db1cba79fb490674868cf7b
Changed files
- garnet/bin/overnet/OWNERS
- garnet/examples/overnet/OWNERS
- garnet/lib/overnet/OWNERS
-
[drivers][msd-img-rgx][mtk] Add driver that enables power
Changed by John Bauman - jbaumanohnoyoudont@google.com Changed at Monday, 11-Feb-19 23:10:20 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 7d9d2df4c0e73090b2d103d722559eacf3285ea8 Comments
[drivers][msd-img-rgx][mtk] Add driver that enables power This driver binds to the device and enables power so that the GPU ID registers can be read. In the future this can either export a device that the msd-img-rgx driver binds to (similar to aml-gpu and msd-arm-mali) or link directly to the IMG driver and call into it. Test: boot on cleo. Change-Id: I7f933f736e8e91e1f053ebd18618a4d16483e6e7
Changed files
- garnet/drivers/gpu/msd-img-rgx/mtk/BUILD.gn
- garnet/drivers/gpu/msd-img-rgx/mtk/mt8167s-gpu.cpp
- garnet/lib/magma/gnbuild/magma-img-rgx/BUILD.gn
- garnet/packages/prod/all
- garnet/packages/prod/magma-img-rgx-mtk
- zircon/system/dev/board/mt8167s_ref/mt8167-gpu.cpp
-
[bt][l2cap] PDU: allow Copy()-ing zero bytes
Changed by mukesh agrawal - quicheohnoyoudont@google.com Changed at Monday, 11-Feb-19 22:51:49 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 1e65a08c3acb58867464ebe042134bc25e9837db Comments
[bt][l2cap] PDU: allow Copy()-ing zero bytes As part of the upcoming L2CAP channel modes support, we'll need to support segmentation and reassembly. And to support segmentation and reassembly, we need to make PDUs and SDUs distinct entities. After some discussion (see BT-61), we decided to represent SDUs as simple ByteBuffers, rather than something more complicated (e.g. linked-list of PDUs). This means that the Channel object will soon provide a ByteBuffer when it calls |rx_callback|, rather than a PDU. Since various existing |rx_callback|s expect to be able to receive a PDU with an empty body, we need to support passing an empty L2CAP frame body up as a ByteBuffer. To that end, remove the assertion in PDU::Copy(), which requires that the PDU have non-zero bytes available past |pos|. Bug: BT-716 Test: fx run-test bluetooth-tests -t bt-host-unittests Change-Id: I62f467b4c39f46e31b97475ed5a3910ce28ba887
Changed files
- garnet/drivers/bluetooth/lib/l2cap/pdu.cc
- garnet/drivers/bluetooth/lib/l2cap/pdu_unittest.cc
-
[overnet] Smarter compression choices
Changed by Craig Tiller - ctillerohnoyoudont@google.com Changed at Monday, 11-Feb-19 22:40:17 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 0585ff30cd62f2c044a0dec2164050108fe3d289 Comments
[overnet] Smarter compression choices Test: Ran overnet unittests Change-Id: I28d8ce56dc31774c06981f30c106595a329b9c20
Changed files
- garnet/lib/overnet/protocol/coding.cc
- garnet/lib/overnet/protocol/coding.h
- garnet/lib/overnet/protocol/fidl.h
-
[gn][fidl] Fix sign and shortening warnings in visitor_unittests
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Monday, 11-Feb-19 22:31:34 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 014389b5a26ad277e1eea5953c57cf2623a9a1ca Comments
[gn][fidl] Fix sign and shortening warnings in visitor_unittests The upcoming zircon gn build is less lenient and reports: ../system/utest/fidl-compiler/visitor_unittests.cpp:70:32: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare] int expected_end = (i + 10 < strlen(expected)) ? i + 10 : strlen(expected) - 1; ~~~~~~ ^ ~~~~~~~~~~~~~~~~ ../system/utest/fidl-compiler/visitor_unittests.cpp:70:80: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32] int expected_end = (i + 10 < strlen(expected)) ? i + 10 : strlen(expected) - 1; ~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~^~~ ../system/utest/fidl-compiler/visitor_unittests.cpp:71:30: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare] int actual_end = (i + 10 < strlen(actual)) ? i + 10 : strlen(actual) - 1; ~~~~~~ ^ ~~~~~~~~~~~~~~ ../system/utest/fidl-compiler/visitor_unittests.cpp:71:74: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32] int actual_end = (i + 10 < strlen(actual)) ? i + 10 : strlen(actual) - 1; ~~~~~~~~~~ ~~~~~~~~~~~~~~~^~~ ../system/utest/fidl-compiler/visitor_unittests.cpp:95:72: warning: implicit conversion loses integer precision: 'std::__2::basic_string<char, std::__2::char_traits<char>, std::__2::allocator<char> >::size_type' (aka 'unsigned long') to 'int' [-Wshorten-64-to-32] std::string d = targeted_diff(expected.c_str(), actual, output.size()); ~~~~~~~~~~~~~ ~~~~~~~^~~~~~ As far as I could tell, I don't think any of these intend to be negative, and now it's (somewhat) more clear that negative values will not be passed to the string() constructor. ZX-3415 #comment [gn][fidl] Fix sign and shortening warnings in visitor_unittests Test: CQ Change-Id: I83d71e95394ba1b6874a43c62c00e57f0d33e8deChanged files
- zircon/system/utest/fidl-compiler/visitor_unittests.cpp
-
[magma][msd] Remove magma_get_notification_channel_fd
Changed by Craig Stout - cstoutohnoyoudont@google.com Changed at Monday, 11-Feb-19 22:31:32 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision de1113b1a375c181d35082fb8797b04668b06d94 Comments
[magma][msd] Remove magma_get_notification_channel_fd Test: vim2:go/magma-tps#L0 pixelbook:go/magma-tps#L1 Change-Id: Id81224a74514615fc62118e827abbaf54f53c6fc
Changed files
- garnet/drivers/gpu/msd-arm-mali/tests/integration/test_fault_recovery.cc
- garnet/lib/magma/include/magma_abi/magma.h
- garnet/lib/magma/include/virtio/virtio_magma.h
- garnet/lib/magma/src/libmagma/magma.cc
- garnet/lib/magma/src/libmagma_linux/magma.cc
- garnet/lib/magma/src/libmagma_linux/virtio_magma_connection.cc
- garnet/lib/magma/src/magma_util/platform/platform_connection_client.h
- garnet/lib/magma/src/magma_util/platform/zircon/zircon_platform_connection_client.cc
- garnet/lib/magma/tests/integration/test_magma_abi.cc
- garnet/lib/magma/tests/mock/mock_magma_system.cc
- garnet/lib/magma/tests/unit_tests/test_platform_connection.cc
-
[perfcompare] Add new entry point for perfcompare recipe to invoke
Changed by Mark Seaborn - mseabornohnoyoudont@google.com Changed at Monday, 11-Feb-19 22:26:54 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision f26b0a7a35cced57c0ce7eab63df5c1f53221027 Comments
[perfcompare] Add new entry point for perfcompare recipe to invoke Add benchmarks_perfcompare.sh. This initial version runs a subset of the tests that benchmarks.sh runs, because the full set takes too much time for the bot to run twice without going over the bot's current timeout limit. Running a faster set of tests is also easier for development testing of the perfcompare recipe. Bug: IN-646 Test: tested via 'led' with recipe change Change-Id: I54349d462423cd89dc051f0ae69d91f908793842
Changed files
- garnet/tests/benchmarks/BUILD.gn
- garnet/tests/benchmarks/benchmarks_perfcompare.sh
-
[gn][fidl] Fix minor bug in MakeSquiggle()
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Monday, 11-Feb-19 22:23:24 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 6f6e494e1b886359dcb0d24e15572041b7a4fd1e Comments
[gn][fidl] Fix minor bug in MakeSquiggle() The upcoming zircon gn build is less lenient and checks fallthrough. It looks like this was intended to be a break not a fallthrough. ZX-3415 #comment [gn][fidl] Fix minor bug in MakeSquiggle() Test: CQ Change-Id: I3e424aa1e515bd53ea60ae209a4f2b1cfe025f18
Changed files
- zircon/system/host/fidl/lib/error_reporter.cpp
-
[gn][banjo] Fix fallthrough error in ddk_generator EmitMethodOutParamDecl
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Monday, 11-Feb-19 22:19:43 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 1d061be7eceaa97874e418d50779d2dc6cfeb426 Comments
[gn][banjo] Fix fallthrough error in ddk_generator EmitMethodOutParamDecl flat::Type::Kind::kArray looks like it was unintentionally falling through to kVector. ZX-3415 #comment [gn][banjo] Fix fallthrough error in ddk_generator EmitMethodOutParamDecl Test: CQ Change-Id: I59a6e1b7b8575ba894e6ae98ebc71edaf2fc7753
Changed files
- zircon/system/host/banjo/lib/ddk_generator.cpp
-
[sdk][svc] Move libsvc.so into //sdk
Changed by Adam Barth - abarthohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 22:13:10 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 94d4dd1403cfc82defefc80131c4af804136fc24 Comments
[sdk][svc] Move libsvc.so into //sdk Also, move the unit test out of the system image. Test: Compiles. Change-Id: I9e650453c023c29491c4321610527dc95fa0c42d
Changed files
- garnet/examples/fidl/echo2_server_c/BUILD.gn
- garnet/packages/tests/svc
- sdk/BUILD.gn
- sdk/lib/svc/BUILD.gn
- sdk/lib/svc/OWNERS
- sdk/lib/svc/dir.cc
- sdk/lib/svc/dir.h
- sdk/lib/svc/dir_unittest.cc
- sdk/lib/svc/meta/svc_unittests.cmx
-
[gn][minfs] Silence size_t->uin32_t in fs-host bcache test
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Monday, 11-Feb-19 22:10:09 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 957fd72b12b3e1a3084c55ab1c8b25de853f9415 Comments
[gn][minfs] Silence size_t->uin32_t in fs-host bcache test The upcoming gn build is less lenient and reports: ../system/utest/fs-host/util.cpp:73:62: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] if (minfs::Bcache::Create(&block_cache, std::move(disk), size) < 0) { ~~~~~ ^~~~ minfs appears to only expect/care about uint32_t, so silence the warning with a static_cast. ZX-3415 #comment [gn][minfs] Silence size_t->uin32_t in fs-host bcache test Test: CQ Change-Id: Icfb6a2f9c6f142910e7058244b69a7a37d9f5761Changed files
- zircon/system/utest/fs-host/util.cpp
-
[dev_finder] Change flags to conform to standards.
Changed by Andrew Davies - awdaviesohnoyoudont@google.com Changed at Monday, 11-Feb-19 22:10:07 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision f4dee2a1e198f3e6477374ff605864dcef29b822 Comments
[dev_finder] Change flags to conform to standards. DX-913 #done TEST=None Change-Id: I62f45aebe5aa031407d8e732153a33f4fda21dfb
Changed files
- garnet/bin/dev_finder/common.go
- garnet/bin/dev_finder/list.go
-
[package][cmx] Remove assert for cmx files
Changed by Leo Lung - leolungohnoyoudont@google.com Changed at Monday, 11-Feb-19 22:00:01 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision a04739e05744dab36d5dceec8f2ecd5c25e0a6d3 Comments
[package][cmx] Remove assert for cmx files Since a component now requires a cmx to launch. And it even requires a URL pointing to a cmx to launch. We can remove this. TESTED=built all with cq Change-Id: Ib0a6573fcee22147a6ac8fd78fc5ab313acf8dfa
Changed files
- build/assert_cmx.gni
- build/package.gni
-
[debugger] Added all the zx_status_t names.
Changed by Cristián Donoso - donosocohnoyoudont@google.com Changed at Monday, 11-Feb-19 21:50:02 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision d77a9d05e8b97cf97928724058cba2f3474763a1 Comments
[debugger] Added all the zx_status_t names. TEST=No functional change. Change-Id: Iea11a74c777b39007507e16aafb0292b5c29dac6
Changed files
- garnet/bin/zxdb/client/job_context_impl.cc
- garnet/bin/zxdb/client/target_impl.cc
- garnet/bin/zxdb/client/thread_impl.cc
- garnet/lib/debug_ipc/helper/zx_status.cc
- garnet/lib/debug_ipc/helper/zx_status.h
-
[gn][fidl] Fix fallthrough warning, and make ParseProtocolMember return void
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Monday, 11-Feb-19 21:45:15 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 0605b039c038acc18dc8059c8cac9b4d18d59287 Comments
[gn][fidl] Fix fallthrough warning, and make ParseProtocolMember return void bool return value was unused and was somewhat inconsistent as pointed out by the upcoming fallthrough warning in the gn build. Switch to void return to make the code a bit clearer. ZX-3415 #comment [gn][fidl] Fix fallthrough warning, and make ParseProtocolMember return void Test: CQ Change-Id: I2b275afc5eb4c62e89bd6779189f7df660a7d817
Changed files
- zircon/system/host/fidl/include/fidl/parser.h
- zircon/system/host/fidl/lib/parser.cpp
-
[System Monitor] Fix samples used and crash
Changed by Dave Schuyler - dschuylerohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:34:31 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 71ec8350e8603c5629a3f410afdb52cc98392c1d Comments
[System Monitor] Fix samples used and crash This CL changes which samples are used in a given GUI column. The prior math was inclusive on both ends; the new math is exclusive on the later value. This means that samples that were on the boundary between two columns where counted in both columns. Now they are no longer being double counted. Second, this CL checks against failing to find the *any* samples in a range, which could lead to a crash. Test: garnet/lib/system_monitor/dockyard/dockyard_unittests.cc Change-Id: I8d7f686c4236e75e5e6628d9420148a4601d7fbd
Changed files
- garnet/lib/system_monitor/dockyard/dockyard.cc
- garnet/lib/system_monitor/dockyard/dockyard.h
- garnet/lib/system_monitor/dockyard/dockyard_unittests.cc
-
[fuchsia.math] Document fuchsia.math
Changed by Adam Barth - abarthohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:31:54 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 2a72c890650c4db1c63ca85c0afaef4a0b813a57 Comments
[fuchsia.math] Document fuchsia.math Test: Just docs Change-Id: I132d8795688f1fdae77cfb6b9b0aeebafce14d08
Changed files
- sdk/fidl/fuchsia.math/math.fidl
-
[audio] ASAN fix in audio_core
Changed by Martin Puryear - mpuryearohnoyoudont@google.com Changed at Monday, 11-Feb-19 21:30:59 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 880848fcbce8c301b6fbed406b0e8b6438022765 Comments
[audio] ASAN fix in audio_core This CL addresses MTWN-233, a use-after-free bug found by ASAN when running audio_fidl_tests. The fix is to fuchsia.media.AudioCapturer, specifically DiscardAllPackets. Additionally, this CL adjusts the wait intervals on three test cases in audio_fidl_tests to match their circumstances. Finally, this CL adds a new AudioCapturer-related test case related to BindGainControl, where another ASAN-related bug was sometimes seen. MTWN-233 #done Test: build, CQ, overnight looped audio_fidl_tests on ASAN builds of both architectures Change-Id: I313d2f5d700e691dcc3930c1dc07973c831e50ab
Changed files
- build/disabled_for_asan.gni
- garnet/bin/media/audio_core/audio_capturer_impl.cc
- garnet/bin/media/audio_core/test/audio_capturer_test.cc
- garnet/bin/media/audio_core/test/audio_renderer_test.cc
- garnet/bin/media/audio_core/test/audio_test.cc
-
[netemul] Fix race condition in SanbdoxService
Changed by Bruno Dal Bo - brunodalboohnoyoudont@google.com Changed at Monday, 11-Feb-19 21:28:50 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision df55d0258b38aba00e65fb58a7b8c3d6f3754c11 Comments
[netemul] Fix race condition in SanbdoxService BUG: NET-2084 #comment Race condition between loop and main dispatcher threads was causing sandbox_service test to flake in CQ. TEST: ran all netemul tests: fx run-test netemul_sandbox_test. Ran sandbox_service test specifically for a couple hundred iterations to ensure that flakiness is gone. Change-Id: I88694b421aa62e04efb1dc44c8d03c70dcd109ca
Changed files
- garnet/bin/netemul_runner/managed_environment.cc
- garnet/bin/netemul_runner/sandbox_service.cc
-
[fuchsia.gpu.magma] Move to //sdk/fidl
Changed by Adam Barth - abarthohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 21:23:39 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision b1689da561a15ad6e7ae31266c1fd53d5d74f2b9 Comments
[fuchsia.gpu.magma] Move to //sdk/fidl All (non-test) FIDL definitions should be in //sdk/fidl. Test: Compiles. Change-Id: Ic2f4c4abbcb0ef43d661b0e66bc77eff80c0e2bb
Changed files
- garnet/drivers/gpu/msd-arm-mali/tests/integration/BUILD.gn
- garnet/drivers/gpu/msd-intel-gen/BUILD.gn
- garnet/drivers/gpu/msd-intel-gen/tests/integration/BUILD.gn
- garnet/lib/magma/src/magma_util/platform/zircon/BUILD.gn
- garnet/lib/magma/src/sys_driver/BUILD.gn
- garnet/lib/magma/src/tools/BUILD.gn
- garnet/lib/magma/tests/vkloop/BUILD.gn
- sdk/fidl/fuchsia.gpu.magma/BUILD.gn
- sdk/fidl/fuchsia.gpu.magma/magma.fidl
-
[vulkan][swapchain] Report allowed usages in VkSurfaceCapabilitiesKHR
Changed by Michael Spang - spangohnoyoudont@google.com Changed at Monday, 11-Feb-19 21:14:31 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 3d3899c51649d6044ee37a07a9e3e787290b91de Comments
[vulkan][swapchain] Report allowed usages in VkSurfaceCapabilitiesKHR Since 11af472590 ("[vulkan][swapchain] Revise image usage") several more usages are allowed, but these are not reported in VkSurfaceCapabilitiesKHR. Update vkGetPhysicalDeviceSurfaceCapabilitiesKHR implementation to report these usages. Test: angle_end2end_tests can initialize vulkan Change-Id: I839c6e32a0577c8dbd01ffe55b25a5b7a1c03039Changed files
- garnet/lib/vulkan/src/swapchain/image_pipe_surface.h
- garnet/lib/vulkan/src/swapchain/image_pipe_swapchain_layer.cc
-
[msd-intel-gen] Ensure device is reset on Destroy
Changed by Craig Stout - cstoutohnoyoudont@google.com Changed at Monday, 11-Feb-19 21:11:00 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 5654e20dc2d67f1e49d78bb433c389be12e2ecbf Comments
[msd-intel-gen] Ensure device is reset on Destroy Some tests don't start the device thread and if we don't shutdown cleanly gpu can corrupt memory.y Test= pixelbook:reboot stress test with magma_enable_developer_build=true Change-Id: I42413ee5e60813b1f6186d0e57643e52045fae4a
Changed files
- garnet/drivers/gpu/msd-intel-gen/src/msd_intel_device.cc
- garnet/drivers/gpu/msd-intel-gen/src/msd_intel_device.h
- garnet/drivers/gpu/msd-intel-gen/tests/unit_tests/test_device.cc
-
[zircon][kernel][userboot] Prevent kcounter vmo release
Changed by David Stevens - stevensdohnoyoudont@google.com Changed at Monday, 11-Feb-19 21:02:13 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision cc488f679fda34eb8e88aeeb01467638e5cd90f0 Comments
[zircon][kernel][userboot] Prevent kcounter vmo release VmObjectPaged::CreateFromROData moves pages from wired kernel memory into vmos. If those vmos are closed, the pages will be freed. Handle that situation for the kcounter vmos by either unmapping the pages from the kernel aspace or leaking a reference to the created vmo. Also rename CreateFromROData to CreateFromWiredPages and added a parameter indicating whether the vmo should have exclusive access to the pages, to try and make the api clearer. Test: CQ, kcounter Change-Id: Ie139fa74825ffe4191ec4754ab020110ecc9c410
Changed files
- zircon/kernel/lib/userboot/userboot.cpp
- zircon/kernel/lib/vdso/rodso.cpp
- zircon/kernel/vm/include/vm/vm_object_paged.h
- zircon/kernel/vm/vm_object_paged.cpp
-
[usb-request] Add c++ list wrapper.
Changed by Jocelyn Dang - jocelyndangohnoyoudont@google.com Changed at Monday, 11-Feb-19 21:01:37 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 9fae8d105e0f13ae9b03a6e4651505afbeffad80 Comments
[usb-request] Add c++ list wrapper. TEST= runtests -t usb-unittest Change-Id: Iced2817e04aafc5cd2ee5ee53452245c20945449
Changed files
- zircon/system/dev/lib/operation/include/lib/operation/operation.h
- zircon/system/dev/lib/usb/include/usb/request-cpp.h
- zircon/system/dev/test/usb/rules.mk
- zircon/system/dev/test/usb/usb-request-list-test.cpp
-
[tracing] Make trace a component package
Changed by Doug Evans - djeohnoyoudont@google.com Changed at Monday, 11-Feb-19 20:54:48 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 1d7a9f605a87b124cd53f18d2cb844e2994c7429 Comments
[tracing] Make trace a component package With the introduction of shell binaries, now we can upgrade the trace package to be a component and remove the |deprecated_system_image| flag. This also allows us to make trace a package that can be pushed independently on the target. bug: BLD-315 Tested: Tested manually by repaving the target and making sure that trace can be started from shell. fx shell trace record # records to default/persistent location /data/trace.json fx shell trace record --output-file=/tmp/trace.json # records to system-temp This patch is based on https://fuchsia-review.googlesource.com/c/garnet/+/224295 Change-Id: Ic8beb5900cc1d6b338c98e130f7e8aa6eaf4ed7e
Changed files
- garnet/bin/trace/BUILD.gn
- garnet/bin/trace/meta/trace.cmx
- garnet/bin/trace/tests/BUILD.gn
- garnet/bin/trace/tests/meta/trace_integration_tests.cmx
- garnet/bin/trace/tests/oneshot-spawn.tspec
- garnet/bin/trace/tests/run_integration_test.cc
- garnet/bin/trace/tests/run_test.cc
- garnet/bin/trace/tests/run_test.h
- garnet/bin/trace/tests/trace_integration_tests.cc
- garnet/bin/trace/trace.cmx
-
[cs] Implment handle count reporting
Changed by Fady Samuel - fsamuelohnoyoudont@google.com Changed at Monday, 11-Feb-19 20:45:04 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision de99864c69f06d8537dcf63fb2b45261b76addc6 Comments
[cs] Implment handle count reporting This CL adds handle count reporting to the inspect hierarchy of a component's system_objects directory. This CL also fixes cs to use the new inspect path introduced in https://fuchsia-review.googlesource.com/c/fuchsia/+/250263 Change-Id: Iad05d09935de7542422f240a7687ba5168bed31f Test=manually run cs -i <job_id>
Changed files
- garnet/bin/appmgr/system_objects_directory.cc
- garnet/bin/appmgr/system_objects_directory.h
- garnet/bin/cs/src/main.rs
-
[bt][l2cap] Improve FakeSignalingChannel outbound commands
Changed by Xo Wang - xowohnoyoudont@google.com Changed at Monday, 11-Feb-19 20:15:11 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 157c89401760c10062af43983a5d28ff6e4066a8 Comments
[bt][l2cap] Improve FakeSignalingChannel outbound commands Add file and line number to outbound request expectactions. Remove the need to call std::make_pair for simulated responses. Add ReceiveResponses to asynchronously trigger simulated responses to an outbound command. Fail tests that send fewer or more request commands than expected and tests that don't consume all the simulated responses. BT-691 Test: bt-host-unittests Changes to L2CAP_BrEdrCommandHandlerTest and L2CAP_BrEdrDynamicChannelTest Change-Id: I5a0eef571f3512290a9934768b114b97dac42432
Changed files
- garnet/drivers/bluetooth/lib/l2cap/bredr_command_handler_unittest.cc
- garnet/drivers/bluetooth/lib/l2cap/bredr_dynamic_channel_unittest.cc
- garnet/drivers/bluetooth/lib/l2cap/fake_signaling_channel.cc
- garnet/drivers/bluetooth/lib/l2cap/fake_signaling_channel.h
-
[debugger] Improve resume count checking in tests.
Changed by Brett Wilson - brettwohnoyoudont@google.com Changed at Monday, 11-Feb-19 20:06:56 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 8e12b3e32fbab57d5ede4005d43a2e743367ce4b Comments
[debugger] Improve resume count checking in tests. Previously tests would check the total count of resumes sent to the agent as a way to test whether the program has resumed or not. This stateful method made it diffult to follow what the value is supposed to be. Changes the getter for the resume count to reset the value. The test code can now check for 1 (resumed) or 0 (stayed stopped) which makes the test easier to follow and modify. TEST=this is Change-Id: I71654b2eaa549b6780eef6cd76f0f65a2cc320ca
Changed files
- garnet/bin/zxdb/client/finish_physical_frame_thread_controller_unittest.cc
- garnet/bin/zxdb/client/finish_thread_controller_unittest.cc
- garnet/bin/zxdb/client/mock_remote_api.cc
- garnet/bin/zxdb/client/mock_remote_api.h
- garnet/bin/zxdb/client/step_over_thread_controller_unittest.cc
- garnet/bin/zxdb/client/step_thread_controller_unittest.cc
-
[gn][banjo] Annotate some expected fallthrough with __FALLTHROUGH
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Monday, 11-Feb-19 20:05:11 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision a19cbea03af08f9e46392063a282479cd617d265 Comments
[gn][banjo] Annotate some expected fallthrough with __FALLTHROUGH This tells new enough compilers that all is well. ZX-3415 #comment [gn][banjo] Annotate some expected fallthrough with __FALLTHROUGH Test: CQ Change-Id: I266303a51ce55ac318ff363f6ad3f4fe93baa588
Changed files
- zircon/system/host/banjo/lib/lexer.cpp
-
[overnet] Compress acks better
Changed by Craig Tiller - craig.tillerohnoyoudont@gmail.com Changed at Monday, 11-Feb-19 20:01:11 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 2ead3c65f55bf85eac692337ed68ba68f7f1a8db Comments
[overnet] Compress acks better Test: Ran overnet unittests Change-Id: I51c7b4e43c8f7d181ab5f7b4cb864bcab612f78c
Changed files
- garnet/lib/overnet/BUILD.gn
- garnet/lib/overnet/packet_protocol/packet_protocol.cc
- garnet/lib/overnet/protocol/BUILD.gn
- garnet/lib/overnet/protocol/ack_frame.cc
- garnet/lib/overnet/protocol/ack_frame.h
- garnet/lib/overnet/protocol/ack_frame_fuzzer.cc
- garnet/lib/overnet/protocol/ack_frame_test.cc
- garnet/lib/overnet/protocol/varint.cc
- garnet/lib/overnet/protocol/varint.h
-
[debugger] Removing warnings
Changed by Cristián Donoso - donosocohnoyoudont@google.com Changed at Monday, 11-Feb-19 19:52:59 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 315d01b871bdf82312442180f050d0f3050db0c9 Comments
[debugger] Removing warnings TEST=No functional change Change-Id: If56aff72368d6198d748c2acd9373dd7dd15d98e
Changed files
- garnet/bin/zxdb/client/breakpoint_impl_unittest.cc
- garnet/bin/zxdb/symbols/loaded_module_symbols_unittest.cc
-
[gn][fidl] Annotate some fallthroughs to avoid warnings
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Monday, 11-Feb-19 19:49:59 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision f08e5787f4c8f11c2b8f03e852afd0e9b5ab333a Comments
[gn][fidl] Annotate some fallthroughs to avoid warnings The upcoming gn build is less lenient and has -Wimplicit-fallthrough on. Switch to __FALLTHROUGH to tell sufficiently new compilers that all is well. ZX-3415 #comment [gn][fidl] Annotate some fallthroughs to avoid warnings Test: CQ Change-Id: I650931caab29d7d1c529a8698da71fb4485f8d15
Changed files
- zircon/system/host/fidl/lib/lexer.cpp
-
[gn][banjo] Fix warning in MakeSquiggle()
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Monday, 11-Feb-19 19:36:41 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision dc67ca46ac9a14b2df8d206775459754eae15a42 Comments
[gn][banjo] Fix warning in MakeSquiggle() gn build has fallthrough warnings enabled; looks like this was intending to be a break. ZX-3415 #comment [gn][banjo] Fix warning in MakeSquiggle() Test: CQ Change-Id: Ica96133a14896c2a647b7769bf645a8f7523e74a
Changed files
- zircon/system/host/banjo/lib/error_reporter.cpp
-
[benchmarks] Move Inspect under zircon_benchmarks
Changed by Chris Phoenix - cphoenixohnoyoudont@google.com Changed at Monday, 11-Feb-19 19:32:56 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 39a09f6338c8a98b403dc97fcfc39bc8e87266ea Comments
[benchmarks] Move Inspect under zircon_benchmarks move inspect.cc and inspector.cc from instrumentation_benchmarks to zircon_benchmarks. Rename them to expose.cc and inspect.cc respectively. Remove instrumentation_benchmarks entirely, and remove it from the packages. Test: /pkgfs/packages/zircon_benchmarks/0/test/zircon_benchmarks -p --filter Inspect /pkgfs/packages/zircon_benchmarks/0/test/zircon_benchmarks -p --filter Expose CF-205 #done Change-Id: I70beb285d96c803f95473799d0b22dd903f41e52
Changed files
- garnet/bin/instrumentation_benchmarks/BUILD.gn
- garnet/bin/instrumentation_benchmarks/README.md
- garnet/bin/instrumentation_benchmarks/test_runner.cc
- garnet/bin/instrumentation_benchmarks/test_runner.h
- garnet/bin/zircon_benchmarks/BUILD.gn
- garnet/bin/zircon_benchmarks/expose.cc
- garnet/bin/zircon_benchmarks/inspect.cc
- garnet/packages/benchmarks/all
- garnet/packages/benchmarks/instrumentation
-
[overnet] Add a command line flag for verbosity for some unit tests
Changed by Craig Tiller - ctillerohnoyoudont@google.com Changed at Monday, 11-Feb-19 19:28:11 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 969a0a3b2033493f43fc1d5ff32483ce12fa3b59 Comments
[overnet] Add a command line flag for verbosity for some unit tests Test: overnet unittests Change-Id: I7a1b221fc3a64de79f86fb4996a22d0b9b98ffdd
Changed files
- garnet/lib/overnet/endpoint/BUILD.gn
- garnet/lib/overnet/endpoint/router_endpoint_integration_test.cc
- garnet/lib/overnet/packet_protocol/BUILD.gn
- garnet/lib/overnet/packet_protocol/bbr_test.cc
- garnet/lib/overnet/testing/BUILD.gn
- garnet/lib/overnet/testing/flags.cc
- garnet/lib/overnet/testing/flags.h
- garnet/lib/overnet/testing/run_all_tests.cc
-
[inspect] New matchers for inspect hierarchies
Changed by Christopher R. Johnson - crjohnsohnoyoudont@google.com Changed at Monday, 11-Feb-19 19:18:33 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 023ee947c6f9c8b99c6401e87c449eeaca410366 Comments
[inspect] New matchers for inspect hierarchies This change implements new matchers to support inspect objects, properties, and metrics using gtest. TEST=runtests CF-556: #done Change-Id: Iabc531d5a541b8dd6d9bda19aca45f8785b6eecc
Changed files
- garnet/bin/inspect_unittests/BUILD.gn
- garnet/bin/inspect_unittests/expose_unittest.cc
- garnet/bin/inspect_unittests/inspect_unittest.cc
- garnet/bin/inspect_unittests/matchers.h
- garnet/public/lib/inspect/testing/BUILD.gn
- garnet/public/lib/inspect/testing/inspect.cc
- garnet/public/lib/inspect/testing/inspect.h
-
[zircon][docs] Remove docs for internal syscalls
Changed by Adam Barth - abarthohnoyoudont@google.com Changed at Monday, 11-Feb-19 19:13:05 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision d9cacfdbc0fa95fb9b3200db0409600e52efcea5 Comments
[zircon][docs] Remove docs for internal syscalls These calls cannot be used by end-developers. We do not need to document them. Test: No behavior change. Change-Id: I4720a1b214b190a26491e7d832a7e6362324507a
Changed files
- zircon/docs/syscalls/channel_call_finish.md
- zircon/docs/syscalls/channel_call_noretry.md
- zircon/docs/syscalls/cprng_draw_once.md
-
[bt][docs] Describe how to build and run tests
Changed by Xo Wang - xowohnoyoudont@google.com Changed at Monday, 11-Feb-19 19:09:36 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 95170e159a2b189adabacd58b73be82eff78e240 Comments
[bt][docs] Describe how to build and run tests Update documentation with new package names and invocations for testing. Also do some style and formatting cleanup. BT-672 Test: Documentation only change (ran the commands touched) Change-Id: I83b31e53da2d4d55b898459d96ba78c3e6ef7fcc
Changed files
- garnet/bin/bluetooth/README.md
-
[gn][minfs] Add static_cast to silence shortening warning
Changed by Scott Graham - scottmgohnoyoudont@google.com Changed at Monday, 11-Feb-19 19:09:01 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision ad71c6d9431b4b38cabf5a82569a85b28b33dcdd Comments
[gn][minfs] Add static_cast to silence shortening warning The upcoming gn build is less lenient and says: ../system/ulib/minfs/vnode.cpp:1237:22: warning: implicit conversion loses integer precision: 'unsigned long' to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] uint32_t n = off / kMinfsBlockSize; ~ ~~~~^~~~~~~~~~~~~~~~~ This seems like an intentional shortening to u32, so explicitly cast. ZX-3415 #comment [gn][minfs] Add static_cast to silence shortening warning Test: CQ Change-Id: I3d595e9fd79a09907bc83499c1b4190d10d49476Changed files
- zircon/system/ulib/minfs/vnode.cpp
-
[scenic][example]Enable keyboard input for hello_base_view
Changed by Emircan Uysaler - emircanohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 19:07:55 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision da34187bc31f05c7d02def3162e0d15587cf3b22 Comments
[scenic][example]Enable keyboard input for hello_base_view This CL adds SetHardKeyboardDeliveryCmd commands to enable keyboard. SCN-1261 #done Test: hello_base_view Change-Id: I06a2b0d24bf4f7fa9bd3327b690d65d8214f07a8
Changed files
- garnet/examples/ui/hello_base_view/view.cc
-
[fuchsia.scenic.snapshot] Move to //sdk/fidl
Changed by Adam Barth - abarthohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 18:38:06 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision fb2f0dd3670891f02cef616a06c57086e54381b8 Comments
[fuchsia.scenic.snapshot] Move to //sdk/fidl All (non-test) FIDL definitions should be in //sdk/fidl. Test: Compiles. Change-Id: Ib7c5edf49f597d706b3495fdfbee74f5b04965dc
Changed files
- garnet/bin/ui/snapshot/BUILD.gn
- peridot/bin/sessionmgr/story_runner/BUILD.gn
- sdk/fidl/fuchsia.scenic.snapshot/BUILD.gn
- sdk/fidl/fuchsia.scenic.snapshot/loader.fidl
-
[bt] [sl4f] Parse serde JSON GATT DB descriptors
Changed by Tom Turney - tturneyohnoyoudont@google.com Changed at Monday, 11-Feb-19 18:37:32 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision bba4d20b01c949f6389e75a40a89f4b98e7c68df Comments
[bt] [sl4f] Parse serde JSON GATT DB descriptors This CL focuses on parsing the third part of the input GATT databass, GATT Descriptors. BT-677 Test: act.py -c <config> -tc FuchsiaCmdLineTest Change-Id: I92e3fe29125256419210f5fbc2b97200263b0a3e
Changed files
- garnet/bin/sl4f/src/bluetooth/gatt_server_facade.rs
-
[fidl] Expose CHANNEL_MAX_MSG_BYTES via zx library
Changed by Craig Tiller - ctillerohnoyoudont@google.com Changed at Monday, 11-Feb-19 17:00:19 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 55d1f3a1e6aa87ebeab7dae1920301afad7f4ac8 Comments
[fidl] Expose CHANNEL_MAX_MSG_BYTES via zx library Take the opportunity to make sure that we're using the actual #define to avoid skew possibilities. Test: everything still builds, a future change using this works. Change-Id: I35e971beb6bddfa63a2250befe9982838a4e556a
Changed files
- zircon/system/host/fidl/compiler/main.cpp
- zircon/system/host/fidl/include/fidl/lexer.h
- zircon/system/host/fidl/include/fidl/library_zx.h
- zircon/system/host/fidl/include/fidl/string_view.h
- zircon/system/host/fidl/lib/lexer.cpp
- zircon/system/host/fidl/lib/library_zx.cpp
- zircon/system/host/fidl/lib/source_manager.cpp
-
[network_time] Disable system_time_updater_test
Changed by Joshua Seaton - joshuaseatonohnoyoudont@google.com Changed at Monday, 11-Feb-19 15:50:09 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 5f61e0d91010b097fa19dd49853847af0d0aa40b Comments
[network_time] Disable system_time_updater_test Bug: CF-579 #comment Test: N/A Change-Id: Ic4a30258e356c0a45b861eb8e2d31ae2f84045f6
Changed files
- garnet/bin/network_time/test/BUILD.gn
-
[overnet] Fix compilation of routing table fuzzer.
Changed by Benjamin Lerman - qsrohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 15:49:36 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision f7aa37712bf876576f6d7055a09aa57cf7da815e Comments
[overnet] Fix compilation of routing table fuzzer. TEST=Code compiles. Change-Id: Ia41a6ad0f290e88a0f2dd5e641ee246096bd5b75
Changed files
- garnet/lib/overnet/routing/routing_table_fuzzer.cc
-
[fidl] Turn explicit interface ordinals into an error.
Changed by Jeremy Manson - jeremymansonohnoyoudont@google.com Changed at Monday, 11-Feb-19 15:13:56 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 21b9728ae66a1ef5f27559df10fa4b1bf5a28297 Comments
[fidl] Turn explicit interface ordinals into an error. FIDL-372 #comment [fidl] Turn explicit interface ordinals into an error. Test: fx full-build, CQ, added a negative parsing test to fidl_compiler_test Change-Id: I07210509c10cdb833efbf19d0ae1a5cf9195fd9d
Changed files
- zircon/system/host/fidl/lib/parser.cpp
- zircon/system/utest/fidl-compiler/json_generator_tests.cpp
- zircon/system/utest/fidl-compiler/parsing_tests.cpp
- zircon/system/utest/fidl-compiler/superinterface_tests.cpp
-
[fuchsia.bluetooth.host] Move to //sdk/fidl
Changed by Adam Barth - abarthohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 07:55:02 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 486b54f712672d697fea0a3777e9d4a5494ff495 Comments
[fuchsia.bluetooth.host] Move to //sdk/fidl All (non-test) FIDL definitions should be in //sdk/fidl. Test: Compiles. Change-Id: I5d589db8c84c5d72ad19a8dff5f243e27cb3ef92
Changed files
- garnet/bin/bluetooth/README.md
- garnet/bin/bluetooth/bt-gap/BUILD.gn
- garnet/bin/bluetooth/bt-gap/README.md
- garnet/bin/bluetooth/bt-mgr/BUILD.gn
- garnet/bin/bluetooth/tests/integration/BUILD.gn
- garnet/docs/bluetooth_architecture.md
- garnet/drivers/bluetooth/host/BUILD.gn
- garnet/lib/bluetooth/c/bt_host.h
- garnet/lib/rust/fuchsia-bluetooth/BUILD.gn
- sdk/fidl/fuchsia.bluetooth.host/BUILD.gn
- sdk/fidl/fuchsia.bluetooth.host/bonding.fidl
- sdk/fidl/fuchsia.bluetooth.host/host.fidl
-
[appmgr] packaged components need a package loader
Changed by James Tucker - raggiohnoyoudont@google.com Changed at Monday, 11-Feb-19 07:50:12 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 411740ca7436d4f72926f4e0a8aed2cc6bc93700 Comments
[appmgr] packaged components need a package loader There was an attempt to make programs that have "features":["shell"] able to spawn subprograms by providing the system loader to them, but this is a misfeature. It might make a handful of cases work today, but they don't work tomorrow. Most critically it blocks asan deployment, because the build system is unaware of this behavior and does not put the asan libraries of the package into the system image package. As the system image package is going away, this behavior really needs to be removed. Bug: CF-576 #done Test: CQ + topaz tryjobs Test: lsblk and other commands work under SSH Test: lsblk and other commands work in qemu serial console Test: lsblk and other commands work in run-vc Change-Id: I2677630334a05e60216a2641802190cd5025c3b5
Changed files
- docs/the-book/package_metadata.md
- garnet/bin/appmgr/realm.cc
-
[fuchsia.process] Switch to doc comments
Changed by Adam Barth - abarthohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 07:13:04 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision a146a5ffb25442bb8ad9051ed1c1ede414a26bf9 Comments
[fuchsia.process] Switch to doc comments Documentation comments should use /// rather than //. Test: Just docs. Change-Id: Ia588d5c3965fffd6c47a66194067d902e84e06a3
Changed files
- zircon/system/fidl/fuchsia-process/launcher.fidl
- zircon/system/fidl/fuchsia-process/resolver.fidl
-
[linux_guest] Roll Linux guest tests + kernel
Changed by Alex Legg - alexleggohnoyoudont@google.com Changed at Monday, 11-Feb-19 06:24:23 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 7fb526de3dd401bf56c376db781175b5cfb828e7 Comments
[linux_guest] Roll Linux guest tests + kernel TEST=guest_integration_tests Change-Id: I622f6ab3dd5d7900887b25d4ff41e9a62087c1e3
Changed files
- garnet/tools/cipd_internal.ensure
-
[build] Avoid including driver library path
Changed by Petr Hosek - phosekohnoyoudont@google.com Changed at Monday, 11-Feb-19 03:36:29 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision d86e862aa547555d353b524f5e191b06ddfec647 Comments
[build] Avoid including driver library path This is not needed since driver already handles this and it can actually lead to issues on other platforms which still put libraries into that location. Bug: TC-363 #done Test: Change-Id: I336723f4a2782970e26081cd425631e680329aa9
Changed files
- build/config/linux/BUILD.gn
-
[process.launcher] Rename Launch2 to Launch
Changed by Adam Barth - abarthohnoyoudont@chromium.org Changed at Monday, 11-Feb-19 02:00:56 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision ddaf047fc5e6f4559a596f4d059a9817e73f3bbd Comments
[process.launcher] Rename Launch2 to Launch Now that clients have migrated to the new fuchsia.process.Launcher/Launch2 method, we can repurpose the Launch method name to match Launch2 and switch clients to use Launch again. In the next CL, we will remove Launch2. Test: spawn-test Change-Id: I543f77b2beaa20ce2acaa22412532309aac5a8a3
Changed files
- garnet/bin/sys/component_manager/src/elf_runner/mod.rs
- zircon/system/fidl/fuchsia-process/launcher.fidl
- zircon/system/ulib/fdio/spawn.c
- zircon/system/ulib/process-launcher/launcher.cpp
- zircon/system/ulib/process-launcher/launcher.h
-
[guest] Re-enable vsock integration test
Changed by Adrian Danis - adanisohnoyoudont@google.com Changed at Monday, 11-Feb-19 00:41:00 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 4c0c4243609636bfa199abc0f62c9144298cce81 Comments
[guest] Re-enable vsock integration test Flakiness has been resolved in changes: Ie3cea59815a6a05bf4f2237f3012d6efcfc92d4e I01dd1d878d9db6042e4c2774bec41d5129899780 MAC-237 #done Test: fx run-test guest_integration_tests -- --gtest_filter=VsockGuestTest.ConnectDisconnect --gtest_repeat=200 Change-Id: Iee11d0d3512d0859699042a79564d9ef2328688c
Changed files
- garnet/bin/guest/integration/virtio_vsock_tests.cc
-
[guest] Move fuchsia.guest.* to //sdk/fidl
Changed by Adam Barth - abarthohnoyoudont@chromium.org Changed at Sunday, 10-Feb-19 23:44:53 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision b229310f6a03fa2665381ebf653a857591d6e9c0 Comments
[guest] Move fuchsia.guest.* to //sdk/fidl All (non-test) FIDL definitions should be in //sdk/fidl. Test: Compiles. Change-Id: I751097b2e8ed52c4130022972458bd2503b50722
Changed files
- garnet/bin/guest/manager/BUILD.gn
- garnet/bin/guest/runner/BUILD.gn
- garnet/bin/guest/vmm/BUILD.gn
- garnet/bin/guest/vmm/device/BUILD.gn
- sdk/fidl/fuchsia.guest.device/BUILD.gn
- sdk/fidl/fuchsia.guest.device/device.fidl
- sdk/fidl/fuchsia.guest.vmm/BUILD.gn
- sdk/fidl/fuchsia.guest.vmm/vmm.fidl
-
[fuchsia.wayland] Move to //sdk/fidl
Changed by Adam Barth - abarthohnoyoudont@chromium.org Changed at Sunday, 10-Feb-19 22:46:42 UTC Repository https://fuchsia.googlesource.com/fuchsia Branch Revision 343c10f2e5e36827b31ff682a9105c5006d66213 Comments
[fuchsia.wayland] Move to //sdk/fidl All (non-test) FIDL definitions should be in //sdk/fidl. Test: Compiles. Change-Id: I16a950c337c9b7d55bda07680b982106cea93ab0
Changed files
- garnet/bin/guest/pkg/biscotti_guest/bin/BUILD.gn
- garnet/public/lib/guest/BUILD.gn
- sdk/fidl/fuchsia.wayland/BUILD.gn
- sdk/fidl/fuchsia.wayland/view_producer.fidl
-
<blame list capped at 100 commits>
Changed by <blame list capped at 100 commits> - Changed at N/A Repository Branch Revision Comments
<blame list capped at 100 commits>