Home | Search | fuchsia - Builders
Login

Builder garnet-host-mac Build 8927833508911808480 Apple OSX

Results:

Success

Trigger Info:

Projectfuchsia
Revision76a2802b02b726bd81b510c1cbbf88ea9b338b75

Execution:

Steps and Logfiles:

Show:
  1. ( 111 ms ) setup_build
    running recipe: "fuchsia"
  2. ( 37 secs ) run host tests

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build351-a9" setup_build
branch "refs/heads/master" setup_build
build_type "release" setup_build
buildbucket {"build": {"bucket": "luci.fuchsia.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544151503607867, "id": "8927833508911808480", "project": "fuchsia", "tags": ["builder:garnet-host-mac", "buildset:commit/git/76a2802b02b726bd81b510c1cbbf88ea9b338b75", "buildset:commit/gitiles/fuchsia.googlesource.com/garnet/+/76a2802b02b726bd81b510c1cbbf88ea9b338b75", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093263570877092640", "scheduler_job_id:fuchsia/garnet-host-mac", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "garnet-host-mac" setup_build
gcs_bucket "fuchsia-build" setup_build
manifest "garnet/garnet" setup_build
ninja_targets ["build/gn:host_tests"] setup_build
packages ["garnet/packages/buildbot"] setup_build
path_config "generic" setup_build
project "integration" setup_build
recipe "fuchsia" setup_build
remote "https://fuchsia.googlesource.com/integration" setup_build
repo "garnet" setup_build
repository "https://fuchsia.googlesource.com/garnet" setup_build
revision "76a2802b02b726bd81b510c1cbbf88ea9b338b75" setup_build
run_host_tests true setup_build
target "x64" setup_build
variants "" setup_build

Blamelist:

  1. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 02:58:23 UTC
Start Friday, 07-Dec-18 02:58:31 UTC
End Friday, 07-Dec-18 03:11:21 UTC
Pending 8 secs
Execution 12 mins 50 secs

All Changes:

  1. [netstack] Update error tcpip->zx error mapping

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 02:57:43 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 76a2802b02b726bd81b510c1cbbf88ea9b338b75

    Comments

    [netstack] Update error tcpip->zx error mapping
    
    Current version of netstack may return new error values that are not
    properly mapped to zircon errors. In such cases netstack was returning
    ZX_ERR_INTERNAL, which is mapped to EIO in FDIO. EIO error is not
    helpful to the client and POSIX APIs are not supposed to return EIO.
    Updated tcpip->zx error mapping function to add the new errors:
    
    ErrUnknownNICID -> ZX_ERR_NOT_FOUND -> ENOENT
    ErrDuplicateNICID -> ZX_ERR_INVALID_ARGS -> EINVAL
    ErrBadLinkEndpoint -> ZX_ERR_INVALID_ARGS -> EINVAL
    ErrAborted -> ZX_ERR_CANCELED -> EBADF
    ErrNoSuchFile -> ZX_ERR_NOT_FOUND -> ENOENT
    ErrInvalidOptionValue -> ZX_ERR_INVALID_ARGS -> EINVAL
    ErrNoLinkAddress -> ZX_ERR_ADDRESS_UNREACHABLE -> ENETUNREACH
    ErrBadAddress -> ZX_ERR_INVALID_ARGS -> EINVAL
    ErrNetworkUnreachable -> ZX_ERR_ADDRESS_UNREACHABLE -> ENETUNREACH
    ErrMessageTooLong  -> ZX_ERR_OUT_OF_RANGE -> EINVAL
    ErrNoBufferSpace -> ZX_ERR_NO_RESOURCES -> ENOMEM
    
    Also renamed the function mxNetError()->zxNetError() and updated the
    log messsage to make it easier to discover error codes that are not
    mapped properly.
    
    This is expected to fix chromium bug crbug.com/910315: some FDIO calls
    were returning EIO.
    
    Test: debug builds of chromium don't DCHECK due to EIO returned from FDIO.
    
    Change-Id: Idbfc472be13c63e7048a3892b3d33c5c6906df17
    

    Changed files

    • go/src/netstack/socket_server.go