Home | Search | fuchsia - Builders
Login

Builder garnet-docs-roller Build 8927842119874946816

Results:

Success

Trigger Info:

Projectfuchsia
Revision4ccb1dcd2ddc487d88642d0189545d700df894ac

Execution:

Steps and Logfiles:

Show:
  1. ( 99 ms ) setup_build
    running recipe: "docs_roller"

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "fuchsia-debian-32-c272138d-us-central1-c-12ds" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.fuchsia.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544143291553940, "id": "8927842119874946816", "project": "fuchsia", "tags": ["builder:garnet-docs-roller", "buildset:commit/git/4ccb1dcd2ddc487d88642d0189545d700df894ac", "buildset:commit/gitiles/fuchsia.googlesource.com/garnet/+/4ccb1dcd2ddc487d88642d0189545d700df894ac", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093272181972779984", "scheduler_job_id:fuchsia/garnet-docs-roller", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "garnet-docs-roller" setup_build
gcs_bucket "fuchsia-build" setup_build
manifest "garnet/garnet" setup_build
packages ["garnet/packages/buildbot"] setup_build
path_config "generic" setup_build
project "integration" setup_build
recipe "docs_roller" setup_build
remote "https://fuchsia.googlesource.com/integration" setup_build
repository "https://fuchsia.googlesource.com/garnet" setup_build
revision "4ccb1dcd2ddc487d88642d0189545d700df894ac" setup_build

Blamelist:

  1. Brett Wilson (brettwohnoyoudont@google.com)
  2. Jaeheon Yi (jaeheonohnoyoudont@google.com)
  3. Greg Bonik (gbonikohnoyoudont@google.com)
  4. Joshua Liebow-Feeser (joshlfohnoyoudont@google.com)
  5. Adrian Danis (adanisohnoyoudont@google.com)
  6. Dale Sather (dalesatohnoyoudont@google.com)
  7. Armando Montanez (amontanezohnoyoudont@google.com)
  8. John Rosasco (rosascoohnoyoudont@google.com)
  9. Tim Detwiler (tjdetwilerohnoyoudont@google.com)
  10. Ankur Mittal (anmittalohnoyoudont@google.com)
  11. Craig Tiller (ctillerohnoyoudont@google.com)
  12. Bruce Mitchener (bruce.mitchenerohnoyoudont@gmail.com)
  13. John Rosasco (rosascoohnoyoudont@google.com)
  14. Ian McKellar (ianloicohnoyoudont@google.com)
  15. Joshua Liebow-Feeser (joshlfohnoyoudont@google.com)
  16. Tamir Duberstein (tamirdohnoyoudont@google.com)
  17. John Rosasco (rosascoohnoyoudont@google.com)
  18. Taylor Cramer (cramertjohnoyoudont@google.com)
  19. Martin Puryear (mpuryearohnoyoudont@google.com)
  20. Chunying Wang (chunyingwohnoyoudont@google.com)
  21. Gary Bressler (gebohnoyoudont@google.com)

Timing:

Create Friday, 07-Dec-18 00:41:31 UTC
Start Friday, 07-Dec-18 00:41:32 UTC
End Friday, 07-Dec-18 00:44:08 UTC
Pending 1 secs
Execution 2 mins 35 secs

All Changes:

  1. [debugger] Separate out variable finding.

    Changed by Brett Wilson - brettwohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 00:23:00 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 4ccb1dcd2ddc487d88642d0189545d700df894ac

    Comments

    [debugger] Separate out variable finding.
    
    Moves the FindVariable functionality of the SymbolEvalContext out into a
    separate file. This doesn't need much context or asynchronous calls to
    run so can be simpler.
    
    Makes variable finding use Identifier for naming rather than std::strings.
    
    Add more elaborate tests for variable finding. Add a better README.
    
    There should be no user-visible behavior change.
    
    TEST=unit
    
    Change-Id: I9a90111dc5f7599936cb2decf3290e553b479d65
    

    Changed files

    • bin/zxdb/console/verbs_symbol.cc
    • bin/zxdb/expr/BUILD.gn
    • bin/zxdb/expr/README.md
    • bin/zxdb/expr/expr_eval_context.h
    • bin/zxdb/expr/expr_node.cc
    • bin/zxdb/expr/expr_node.h
    • bin/zxdb/expr/expr_node_unittest.cc
    • bin/zxdb/expr/find_variable.cc
    • bin/zxdb/expr/find_variable.h
    • bin/zxdb/expr/find_variable_unittest.cc
    • bin/zxdb/expr/identifier.cc
    • bin/zxdb/expr/identifier.h
    • bin/zxdb/expr/resolve_collection.cc
    • bin/zxdb/expr/resolve_collection.h
    • bin/zxdb/expr/resolve_collection_unittest.cc
    • bin/zxdb/expr/symbol_eval_context.cc
    • bin/zxdb/expr/symbol_eval_context.h
    • bin/zxdb/expr/symbol_eval_context_unittest.cc
    • bin/zxdb/symbols/type_utils.cc
    • bin/zxdb/symbols/type_utils.h
  2. [baseview][input] Enable Baseview's OnInputEvent callback.

    Changed by Jaeheon Yi - jaeheonohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 23:56:59 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision ebe1b4bc6c8a2f65b201cf38ef2a23015bc3ed92

    Comments

    [baseview][input] Enable Baseview's OnInputEvent callback.
    
    This is not the flip itself to Scenic input; this is the CL that enables
    BaseView to respond to Scenic input.
    
    SCN-1149 #done
    
    SCN-938 #comment
    
    SY-908 #comment
    
    TEST=CQ and manual tests:
    {tiles, scenic input, web_runner} - PASS
    {tiles, viewmanager input, web_runner} - PASS
    
    Change-Id: I868404ed1388caf8f2fd74ee5afa51f06b5e679d
    

    Changed files

    • public/lib/ui/base_view/cpp/v1_base_view.cc
  3. [wlan][mesh] Deliver incoming mesh data to netstack

    Changed by Greg Bonik - gbonikohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 23:44:18 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision c37306d339fca836dc5290142bc2924fd5c3fd94

    Comments

    [wlan][mesh] Deliver incoming mesh data to netstack
    
    NET-1943
    
    TEST=Manually verified that netstack receives an ARP frame and attempts
    to reply. A unit test is included.
    
    Change-Id: I5d9952735b6570f0b344bc2d65ce0107499169eb
    

    Changed files

    • lib/wlan/mlme/include/wlan/mlme/mesh/mesh_mlme.h
    • lib/wlan/mlme/mesh/mesh_mlme.cpp
    • lib/wlan/mlme/tests/mesh_mlme_unittest.cpp
    • lib/wlan/mlme/tests/test_utils.h
  4. [rust-netstack] Remove now-stabilized features

    Changed by Joshua Liebow-Feeser - joshlfohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 23:30:07 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 0b70522bd28788e0e42365d0da6eaeb2031f7073

    Comments

    [rust-netstack] Remove now-stabilized features
    
    Test: Compiles
    Change-Id: I02d8d315f70981942df5ff09eca18152bfa4ac03
    

    Changed files

    • bin/recovery_netstack/core/src/lib.rs
  5. [rust] Attribute macros for writing async entry points

    Changed by Adrian Danis - adanisohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 23:17:24 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 80fbebfcc2e7c9990f70a7446a34d6d8d7ccb30f

    Comments

    [rust] Attribute macros for writing async entry points
    
    Adds a procedural macro crate intended to simplify the boilerplate for writing entry
    points that use asynchronous execution, such as `main` or `#[test]` functions
    
    Test: Performed manual testing out of tree.
    
    Change-Id: I8e7341dfc15e2af1d7818a553fee0006bedd7c2e
    

    Changed files

    • public/rust/fuchsia-async-macro/Cargo.toml
    • public/rust/fuchsia-async-macro/src/lib.rs
  6. [media] add the sbc and aptx encodings to fuchsia.media

    Changed by Dale Sather - dalesatohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 22:58:43 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 1a5d2d3f6a574b8d774ee6409cc14160d7273aa1

    Comments

    [media] add the sbc and aptx encodings to fuchsia.media
    
    The FIDL library fuchsia.media was missing constant definitions for
    the SBC and APTX audio encodings. This CL adds them.
    
    TEST: no behavior change
    
    Change-Id: Iba61d0b3ad7a59733064c73de4bb7452066bb6bd
    

    Changed files

    • public/fidl/fuchsia.media/stream_type.fidl
  7. [wlan] Fix use-after-free in TimElement unit test

    Changed by Armando Montanez - amontanezohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 22:49:43 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 3f8f2eb3fd92e2f7f3924331909c8e99702a6294

    Comments

    [wlan] Fix use-after-free in TimElement unit test
    
    The vector is freed when FindAndParseTim() returns since the vector is
    instantiated as an argument to the function. This change keeps the
    vector in memory so the checks following the function call can safely
    access the vector's contents.
    
    Test: Test now passes on ASan garnet build.
    
    Change-Id: I96338cf2fc8819c14d93f02d7492db4578a6a57d
    

    Changed files

    • lib/wlan/mlme/tests/tim_element_unittest.cpp
  8. [docs] Fixed build argument for magma testing.

    Changed by John Rosasco - rosascoohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 22:41:32 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 79aeafbf8df71722630f48fe06bc66296c371463

    Comments

    [docs] Fixed build argument for magma testing.
    
    Test: CQ
    
    Change-Id: I000ef3a90724a9c193e51383970552f2385ab1f4
    

    Changed files

    • lib/magma/docs/contributing.md
  9. [machina][vmm][wayland] Migrate to fuchsia-pkg URIs.

    Changed by Tim Detwiler - tjdetwilerohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 22:31:04 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 56d4c9e1097e9abaf8380da11e4c6cfc072422df

    Comments

    [machina][vmm][wayland] Migrate to fuchsia-pkg URIs.
    
    Test: run biscotti; manually observed logs for warnings/errors.
    Change-Id: Idded99902c01952f09910035338aac6ed928a69d
    

    Changed files

    • bin/guest/pkg/biscotti_guest/bin/guest.cc
    • bin/guest/pkg/meta/guest_package.cmx
    • bin/guest/runner/runner_impl.cc
    • bin/guest/vmm/wayland_dispatcher_impl.cc
    • bin/wayland/bridge/src/frontend.rs
    • lib/machina/virtio_balloon.cc
    • lib/machina/virtio_block.cc
    • lib/machina/virtio_console.cc
    • lib/machina/virtio_gpu.cc
    • lib/machina/virtio_input.cc
    • lib/machina/virtio_net.cc
    • lib/machina/virtio_rng.cc
    • lib/machina/virtio_wl.cc
  10. [sysmgr] Port sysmgr to use component() rule.

    Changed by Ankur Mittal - anmittalohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 22:17:31 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 6f681719040ef4f993f78bcb9257d9d112afe60e

    Comments

    [sysmgr] Port sysmgr to use component() rule.
    
    CF-157 #comment
    
    TEST=CQ
    
    Change-Id: Ie8b4d0f744dceadf92911b8e510f7c66d3a44a5d
    

    Changed files

    • bin/sysmgr/BUILD.gn
    • bin/sysmgr/meta/sysmgr.cmx
  11. [overnet] Get things ready for use.

    Changed by Craig Tiller - ctillerohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 20:59:45 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 264066f768fbc2bb66b9b5ceb5950a691d136977

    Comments

    [overnet] Get things ready for use.
    
    This is relanding a previous change, with host side fuzzing fixed.
    
    Allow FIDL messages (including channel handles) to be propagated between
    overnet instances.
    
    Add an example suite in Rust.
    
    Refactor the overnet app to better separate concerns.
    
    Propagate service & routing information between nodes.
    
    Clean up tracing API's.
    
    Initial crypto support.
    
    Enable one fuzzer.
    
    Reorganize files in lib/overnet.
    
    Rewrite/fix packet loss handling.
    
    Test: all unit tests pass, compiled locally with fx set x64 to verify host side fuzzers no longer cause problems.
    
    Change-Id: Id30f4dbb1567e4e8d0d4efb7955b01a76f158ddb
    

    Changed files

    • bin/overnet/overnetstack/BUILD.gn
    • bin/overnet/overnetstack/bound_channel.cc
    • bin/overnet/overnetstack/bound_channel.h
    • bin/overnet/overnetstack/fidl_utils.h
    • bin/overnet/overnetstack/fidl_utils_test.cc
    • bin/overnet/overnetstack/fuchsia_port.h
    • bin/overnet/overnetstack/main.cc
    • bin/overnet/overnetstack/mdns.cc
    • bin/overnet/overnetstack/mdns.h
    • bin/overnet/overnetstack/overnet_app.cc
    • bin/overnet/overnetstack/overnet_app.h
    • bin/overnet/overnetstack/run_all_tests.cc
    • bin/overnet/overnetstack/service.cc
    • bin/overnet/overnetstack/service.h
    • bin/overnet/overnetstack/udp_nub.h
    • examples/overnet/echo/client/BUILD.gn
    • examples/overnet/echo/client/src/main.rs
    • examples/overnet/echo/server/BUILD.gn
    • examples/overnet/echo/server/src/main.rs
    • examples/overnet/interface_passing/client/BUILD.gn
    • examples/overnet/interface_passing/client/src/main.rs
    • examples/overnet/interface_passing/server/BUILD.gn
    • examples/overnet/interface_passing/server/src/main.rs
    • examples/overnet/interface_passing/service/BUILD.gn
    • examples/overnet/interface_passing/service/interface_passing.fidl
    • examples/overnet/meta/overnet_example.cmx
    • lib/overnet/BUILD.gn
    • lib/overnet/datagram_stream.cc
    • lib/overnet/datagram_stream.h
    • lib/overnet/datagram_stream/BUILD.gn
    • lib/overnet/datagram_stream/datagram_stream.cc
    • lib/overnet/datagram_stream/datagram_stream.h
    • lib/overnet/datagram_stream/datagram_stream_test.cc
    • lib/overnet/datagram_stream/linearizer.cc
    • lib/overnet/datagram_stream/linearizer.h
    • lib/overnet/datagram_stream/linearizer_fuzzer.cc
    • lib/overnet/datagram_stream/linearizer_fuzzer_corpus_to_code.py
    • lib/overnet/datagram_stream/linearizer_fuzzer_helpers.h
    • lib/overnet/datagram_stream/linearizer_test.cc
    • lib/overnet/datagram_stream/receive_mode.cc
    • lib/overnet/datagram_stream/receive_mode.h
    • lib/overnet/datagram_stream/receive_mode_fuzzer.cc
    • lib/overnet/datagram_stream/receive_mode_fuzzer_corpus_to_code.py
    • lib/overnet/datagram_stream/receive_mode_fuzzer_helpers.h
    • lib/overnet/datagram_stream/receive_mode_test.cc
    • lib/overnet/endpoint/BUILD.gn
    • lib/overnet/endpoint/message_builder.cc
    • lib/overnet/endpoint/message_builder.h
    • lib/overnet/endpoint/router_endpoint.cc
    • lib/overnet/endpoint/router_endpoint.h
    • lib/overnet/endpoint/router_endpoint_integration_test.cc
    • lib/overnet/environment/BUILD.gn
    • lib/overnet/environment/timer.cc
    • lib/overnet/environment/timer.h
    • lib/overnet/environment/trace.cc
    • lib/overnet/environment/trace.h
    • lib/overnet/environment/trace_test.cc
    • lib/overnet/gen_bazel.py
    • lib/overnet/labels/BUILD.gn
    • lib/overnet/labels/node_id.cc
    • lib/overnet/labels/node_id.h
    • lib/overnet/labels/node_id_test.cc
    • lib/overnet/labels/reliability_and_ordering.cc
    • lib/overnet/labels/reliability_and_ordering.h
    • lib/overnet/labels/seq_num.cc
    • lib/overnet/labels/seq_num.h
    • lib/overnet/labels/seq_num_test.cc
    • lib/overnet/labels/stream_id.cc
    • lib/overnet/labels/stream_id.h
    • lib/overnet/linearizer.h
    • lib/overnet/links/BUILD.gn
    • lib/overnet/links/packet_link.cc
    • lib/overnet/links/packet_link.h
    • lib/overnet/links/packet_link_test.cc
    • lib/overnet/links/packet_nub.h
    • lib/overnet/links/packet_nub_test.cc
    • lib/overnet/manual_constructor.h
    • lib/overnet/packet_protocol.cc
    • lib/overnet/packet_protocol.h
    • lib/overnet/packet_protocol/BUILD.gn
    • lib/overnet/packet_protocol/aead_codec.cc
    • lib/overnet/packet_protocol/aead_codec.h
    • lib/overnet/packet_protocol/aead_codec_test.cc
    • lib/overnet/packet_protocol/bbr.cc
    • lib/overnet/packet_protocol/bbr.h
    • lib/overnet/packet_protocol/bbr_fuzzer.cc
    • lib/overnet/packet_protocol/bbr_fuzzer_helpers.h
    • lib/overnet/packet_protocol/bbr_test.cc
    • lib/overnet/packet_protocol/packet_protocol.cc
    • lib/overnet/packet_protocol/packet_protocol.h
    • lib/overnet/packet_protocol/packet_protocol_fuzzer.cc
    • lib/overnet/packet_protocol/packet_protocol_fuzzer_corpus_to_code.py
    • lib/overnet/packet_protocol/packet_protocol_fuzzer_helpers.h
    • lib/overnet/packet_protocol/packet_protocol_test.cc
    • lib/overnet/packet_protocol/windowed_filter.h
    • lib/overnet/packet_protocol_fuzzer_helpers.h
    • lib/overnet/packet_protocol_test.cc
    • lib/overnet/protocol/BUILD.gn
    • lib/overnet/protocol/ack_frame.cc
    • lib/overnet/protocol/ack_frame.h
    • lib/overnet/protocol/ack_frame_test.cc
    • lib/overnet/protocol/fork_frame.cc
    • lib/overnet/protocol/fork_frame.h
    • lib/overnet/protocol/fork_frame_test.cc
    • lib/overnet/protocol/introduction.h
    • lib/overnet/protocol/introduction_test.cc
    • lib/overnet/protocol/routable_message.cc
    • lib/overnet/protocol/routable_message.h
    • lib/overnet/protocol/routable_message_fuzzer.cc
    • lib/overnet/protocol/routable_message_test.cc
    • lib/overnet/protocol/serialization_helpers.h
    • lib/overnet/protocol/varint.cc
    • lib/overnet/protocol/varint.h
    • lib/overnet/protocol/varint_test.cc
    • lib/overnet/router_endpoint.cc
    • lib/overnet/router_endpoint.h
    • lib/overnet/router_endpoint_2node_test.cc
    • lib/overnet/routing/BUILD.gn
    • lib/overnet/routing/router.cc
    • lib/overnet/routing/router.h
    • lib/overnet/routing/router_test.cc
    • lib/overnet/routing/routing_table.cc
    • lib/overnet/routing/routing_table.h
    • lib/overnet/routing_table.cc
    • lib/overnet/scripts/summarize_beg_end.py
    • lib/overnet/scripts/trace-linearizer-speed.py
    • lib/overnet/sink.h
    • lib/overnet/sink_test.cc
    • lib/overnet/slice.cc
    • lib/overnet/testing/BUILD.gn
    • lib/overnet/testing/csv_writer.h
    • lib/overnet/testing/run_all_tests.cc
    • lib/overnet/testing/test_timer.cc
    • lib/overnet/testing/test_timer.h
    • lib/overnet/testing/test_timer_test.cc
    • lib/overnet/testing/trace_cout.cc
    • lib/overnet/testing/trace_cout.h
    • lib/overnet/trace.h
    • lib/overnet/trace_cout.h
    • lib/overnet/trace_test.cc
    • lib/overnet/vocabulary/BUILD.gn
    • lib/overnet/vocabulary/bandwidth.h
    • lib/overnet/vocabulary/callback.h
    • lib/overnet/vocabulary/callback_test.cc
    • lib/overnet/vocabulary/closed_ptr.h
    • lib/overnet/vocabulary/internal_list.h
    • lib/overnet/vocabulary/internal_list_fuzzer.cc
    • lib/overnet/vocabulary/internal_list_fuzzer_corpus_to_code.py
    • lib/overnet/vocabulary/internal_list_fuzzer_helpers.h
    • lib/overnet/vocabulary/internal_list_test.cc
    • lib/overnet/vocabulary/lazy_slice.h
    • lib/overnet/vocabulary/manual_constructor.h
    • lib/overnet/vocabulary/once_fn.h
    • lib/overnet/vocabulary/once_fn_test.cc
    • lib/overnet/vocabulary/optional.h
    • lib/overnet/vocabulary/optional_test.cc
    • lib/overnet/vocabulary/slice.cc
    • lib/overnet/vocabulary/slice.h
    • lib/overnet/vocabulary/slice_test.cc
    • lib/overnet/vocabulary/status.cc
    • lib/overnet/vocabulary/status.h
    • lib/overnet/vocabulary/status_test.cc
    • lib/overnet/vocabulary/time.h
    • packages/examples/all
    • packages/examples/overnet
    • packages/tests/overnet
    • public/fidl/fuchsia.overnet/overnet.fidl
  12. [escher] Typo fixes.

    Changed by Bruce Mitchener - bruce.mitchenerohnoyoudont@gmail.com
    Changed at Thursday, 06-Dec-18 20:55:35 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision d9d819206aa048ec9d2dc04c2bde1fe66e3a0de7

    Comments

    [escher] Typo fixes.
    
    TEST: No behavior change
    Change-Id: I945f3b3fd224e7d24872e0e022ab5da81b253a79
    

    Changed files

    • public/lib/escher/base/ownable.h
    • public/lib/escher/escher.h
    • public/lib/escher/geometry/bounding_box.h
    • public/lib/escher/geometry/indexed_triangle_mesh_clip.h
    • public/lib/escher/hmd/pose_buffer_latching_shader.h
    • public/lib/escher/impl/gpu_uploader.h
    • public/lib/escher/impl/ssdo_accelerator.h
    • public/lib/escher/paper/paper_draw_call_factory.cc
    • public/lib/escher/paper/paper_drawable.h
    • public/lib/escher/paper/paper_readme.h
    • public/lib/escher/paper/paper_renderer2.cc
    • public/lib/escher/paper/paper_shape_cache.cc
    • public/lib/escher/third_party/granite/vk/command_buffer.h
    • public/lib/escher/third_party/granite/vk/render_pass_info.cc
    • public/lib/escher/util/bitmap.h
    • public/lib/escher/util/depth_to_color.h
    • public/lib/escher/util/enum_flags.h
    • public/lib/escher/util/image_utils.h
  13. [magma] typo

    Changed by John Rosasco - rosascoohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 20:13:13 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 15565d5cb3d1203bb0d9d773224d3c099882b317

    Comments

    [magma] typo
    
    Test: CQ
    
    Change-Id: I5ca734b1f2febb698d28dd903a1aacacd1d76c36
    

    Changed files

    • lib/magma/docs/contributing.md
  14. [fidl][analysis] A script to look for types that are used once.

    Changed by Ian McKellar - ianloicohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 20:11:53 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 29b1467e42f9d08e1097597aeb61e148682ddeae

    Comments

    [fidl][analysis] A script to look for types that are used once.
    
    This looks for structs and unions that are never used or only used once,
    inside another type.
    
    This also includes a Python library that's useful for writing these
    analyses.
    
    TEST=ran the script
    
    Change-Id: Ic3433164db1f061202a376ecd3821c09e80c37cc
    

    Changed files

    • public/lib/fidl/tools/analysis/README.md
    • public/lib/fidl/tools/analysis/ir.py
    • public/lib/fidl/tools/analysis/single_use.py
  15. [rust-netstack] Fix warnings, remove allow(warnings) annotation

    Changed by Joshua Liebow-Feeser - joshlfohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 18:49:59 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision b2b754b82550441f381192b860d79bae4a7cc944

    Comments

    [rust-netstack] Fix warnings, remove allow(warnings) annotation
    
    - Fix all non-unused warnings
    - Remove #![allow(warnings)] from crate root
    - Replace with #![allow(unused)]
    
    Test: Existing unit tests pass
    Change-Id: Ib7346e887db9190aa1841328c53f00c22b877491
    

    Changed files

    • bin/recovery_netstack/core/src/device/ethernet.rs
    • bin/recovery_netstack/core/src/lib.rs
    • bin/recovery_netstack/core/src/wire/icmp/icmpv6.rs
  16. Revert "[*] Remove fuchsia.net.stack.InterfaceAddress"

    Changed by Tamir Duberstein - tamirdohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 17:49:46 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision ba6f4cb606b93c61934e031294b2906685866381

    Comments

    Revert "[*] Remove fuchsia.net.stack.InterfaceAddress"
    
    This reverts commit 308e02e82cc0ee3115adf54674ffba7587626977.
    
    Reason for revert: these types have different purposes.
    
    Original change's description:
    > [*] Remove fuchsia.net.stack.InterfaceAddress
    > 
    > Replaced with fuchsia.net.Subnet.
    > 
    > TEST: CQ
    > Change-Id: I2d1851638601cb31dd346db895a14f0760fa7cca
    
    TBR=chunyingw@google.com,tamird@google.com,tamird@gmail.com
    
    Change-Id: I58d77747af259957efb2c843de745ac82167bab7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    

    Changed files

    • bin/net-cli/BUILD.gn
    • bin/net-cli/src/main.rs
    • bin/wlan/wlan-smoke-test/src/main.rs
    • go/src/netstack/fuchsia_net_stack.go
    • lib/rust/fidl_fuchsia_net_ext/src/lib.rs
    • lib/rust/fidl_fuchsia_net_stack_ext/src/lib.rs
  17. [fidl] Fixed typo.

    Changed by John Rosasco - rosascoohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 17:47:06 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision b1536fdaeaaa8dd6e7f602cf9abdbb76e64a153f

    Comments

    [fidl] Fixed typo.
    
    Test: CQ
    
    Change-Id: I369ddf2ddb93f5fe04b2efdc74bedd8ea9964598
    

    Changed files

    • public/lib/fidl/cpp/interface_handle.h
  18. [rust][tennis] Fix warnings in Tennis and update README

    Changed by Taylor Cramer - cramertjohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 17:32:43 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 6c7f0c1d9dbd46cecb9004815106b5643551cadb

    Comments

    [rust][tennis] Fix warnings in Tennis and update README
    
    Test: CQ, no functional change
    Change-Id: Ic0983250c4a38f856d627ab62480b625e92ba274
    

    Changed files

    • bin/tennis/README.md
    • bin/tennis/bots/manual_player/src/main.rs
    • bin/tennis/src/game.rs
    • bin/tennis/src/tennis_service.rs
  19. [media][tests] Move audio_fidl_tests build/manifest

    Changed by Martin Puryear - mpuryearohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 17:22:53 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 4c6ace1080365b3b13a95f6b0c14885985630af9

    Comments

    [media][tests] Move audio_fidl_tests build/manifest
    
    In preparation for adding a second audio_core-related test binary,
    this CL moves the BUILD.gn and .cmx file for audio_fidl_tests down
    from bin/media/audio_core into the bin/mediua/audio_core/test sub-
    directory that already contains the test sources.
    
    Similarly preparing for a second test binary in the 'test' directory,
    the main.cc file has been renamed to audio_fidl_tests.cc.
    
    Test: No product change -- build, CQ
    
    Change-Id: I7a0b2bf7f29aa4c5e9aa8e030c2bb184b49d0b04
    

    Changed files

    • bin/media/audio_core/BUILD.gn
    • bin/media/audio_core/test/BUILD.gn
    • bin/media/audio_core/test/audio_fidl_tests.cc
    • bin/media/audio_core/test/meta/audio_fidl_tests.cmx
    • packages/tests/media
  20. [*] Remove fuchsia.net.stack.InterfaceAddress

    Changed by Chunying Wang - chunyingwohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:51:33 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 308e02e82cc0ee3115adf54674ffba7587626977

    Comments

    [*] Remove fuchsia.net.stack.InterfaceAddress
    
    Replaced with fuchsia.net.Subnet.
    
    TEST: CQ
    Change-Id: I2d1851638601cb31dd346db895a14f0760fa7cca
    

    Changed files

    • bin/net-cli/BUILD.gn
    • bin/net-cli/src/main.rs
    • bin/wlan/wlan-smoke-test/src/main.rs
    • go/src/netstack/fuchsia_net_stack.go
    • lib/rust/fidl_fuchsia_net_ext/src/lib.rs
    • lib/rust/fidl_fuchsia_net_stack_ext/src/lib.rs
  21. [amber] Rephrase update failed message

    Changed by Gary Bressler - gebohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:29:37 UTC
    Repository https://fuchsia.googlesource.com/garnet
    Branch
    Revision 6b011ed7b7006975e026ab767b877470be0c7f58

    Comments

    [amber] Rephrase update failed message
    
    When no update is found for a package, instead of logging this as an
    "error", state more neutrally that an update could not be found. This
    will happen if a component is started in auto_update_packages and no
    package server is running.
    
    TESTED=observed log message
    
    Change-Id: I599a69f7efa55618829367c585ed0f03c22a4961
    

    Changed files

    • go/src/amber/control_server/control_server.go