Builder linux-clang-dbg-x86 Build 8928649755236271520
Results:
Success
Trigger Info:
Project | dawn |
Revision | cf714a81c86e56827563e20c1b2750e674aec322 |
Got Revision | cf714a81c86e56827563e20c1b2750e674aec322 |
Execution:
- Source: Task 417105a9afb29810
- Bot: vm316-m1
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/mnt/data/b/s/w/ir/cache", "temp_dir": "/mnt/data/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "vm316-m1" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.dawn.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1543373070452078, "id": "8928649755236271520", "project": "dawn", "tags": ["builder:linux-clang-dbg-x86", "buildset:commit/git/cf714a81c86e56827563e20c1b2750e674aec322", "buildset:commit/gitiles/dawn.googlesource.com/dawn/+/cf714a81c86e56827563e20c1b2750e674aec322", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9094079817448559552", "scheduler_job_id:dawn/linux-clang-dbg-x86", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "linux-clang-dbg-x86" | setup_build |
debug | true | setup_build |
path_config | "generic" | setup_build |
recipe | "dawn" | setup_build |
repository | "https://dawn.googlesource.com/dawn.git" | setup_build |
revision | "cf714a81c86e56827563e20c1b2750e674aec322" | setup_build |
target_cpu | "x86" | setup_build |
got_revision | "cf714a81c86e56827563e20c1b2750e674aec322" | bot_update |
Blamelist:
- Jiawei Shao (jiawei.shaoohnoyoudont@intel.com)
Timing:
Create | Wednesday, 28-Nov-18 02:44:30 UTC |
Start | Wednesday, 28-Nov-18 02:46:44 UTC |
End | Wednesday, 28-Nov-18 02:47:26 UTC |
Pending | 2 mins 13 secs |
Execution | 42 secs |
All Changes:
-
Add checks on the texture view used as color or depth stencil attachment
Changed by Jiawei Shao - jiawei.shaoohnoyoudont@intel.com Changed at Wednesday, 28-Nov-18 02:44:17 UTC Repository https://dawn.googlesource.com/dawn Branch Revision cf714a81c86e56827563e20c1b2750e674aec322 Comments
Add checks on the texture view used as color or depth stencil attachment This patch adds checks when we set a texture view as color or depth stencil attachments: 1. The mipmap level of the texture view must be 1 as it is limited in D3D12, Metal and Vulkan. 2. The array layer count of the texture view must be 1 as currently we do not plan to support layered rendering in WebGPU. 3. The format of the texture view must be color renderable when it is used as a color attachment. 4. The format of the texture view must be a depth stencil format when it is used as a depth stencil attachment. BUG=dawn:16 TEST=dawn_unittests Change-Id: Ibce3bda20d49a725c26796aa627c5067532761ad Reviewed-on: https://dawn-review.googlesource.com/c/2661 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Changed files
- src/dawn_native/RenderPassDescriptor.cpp
- src/dawn_native/RenderPassDescriptor.h
- src/dawn_native/Texture.cpp
- src/dawn_native/Texture.h
- src/tests/unittests/validation/RenderPassDescriptorValidationTests.cpp