Builder vm-kernel-win-product-x64
Build 1672
Results:
Success
Trigger Info:
Project | dart |
Revision | 2b1e2718e7e8ab77015d3006ed46579df094a4c0 |
Got Revision | 2b1e2718e7e8ab77015d3006ed46579df094a4c0 |
Execution:
- Source: Task 428f4b477a630d10
- Bot: win10-dart-fedce810-us-central1-c-0xh3
- Recipe: dart/neo
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
-
( 1 mins 49 secs ) upload testing fileset vm-kernelswarming fileset hash: 5152ccb78d6dfb737b5686cb851d1dadaff9b91b
-
- - no logs -
-
- - no logs -
-
( 2 secs ) vm tests_shard_4 on WindowsRun on OS: 'Windows'Pending time: 25sShard duration: 0:04:15.942202
-
( 1 secs ) vm tests_shard_5 on WindowsRun on OS: 'Windows'Pending time: 26sShard duration: 0:03:43.086865
-
( 2 secs ) vm tests_shard_6 on WindowsRun on OS: 'Windows'Pending time: 35sShard duration: 0:11:47.187794
-
( 2 secs ) vm tests_shard_7 on WindowsRun on OS: 'Windows'Pending time: 47sShard duration: 0:03:26.290424
-
( 38 secs ) vm tests_shard_8 on WindowsRun on OS: 'Windows'Pending time: 0:01:36.923283Shard duration: 0:12:29.529576
-
( 2 secs ) vm tests_shard_9 on WindowsRun on OS: 'Windows'Pending time: 0:01:54.625099Shard duration: 0:03:40.170715
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "C:\\b\\s\\w\\ir\\cache", "temp_dir": "C:\\b\\s\\w\\ir\\tmp\\rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "win10-dart-fedce810-us-central1-c-0xh3" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.dart.ci.sandbox", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548175914179894, "id": "8923613608572504032", "project": "dart", "tags": ["builder:vm-kernel-win-product-x64", "buildset:commit/git/2b1e2718e7e8ab77015d3006ed46579df094a4c0", "buildset:commit/gitiles/dart.googlesource.com/sdk/+/2b1e2718e7e8ab77015d3006ed46579df094a4c0", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089043670959552288", "scheduler_job_id:dart/vm-kernel-win-product-x64", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "vm-kernel-win-product-x64" | setup_build |
buildnumber | 1672 | setup_build |
clobber | "true" | setup_build |
mastername | "client.dart" | setup_build |
path_config | "generic" | setup_build |
recipe | "dart/neo" | setup_build |
repository | "https://dart.googlesource.com/sdk/" | setup_build |
revision | "2b1e2718e7e8ab77015d3006ed46579df094a4c0" | setup_build |
got_revision | "2b1e2718e7e8ab77015d3006ed46579df094a4c0" | bot_update |
Blamelist:
- Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
- Jonas Termansen (sortieohnoyoudont@google.com)
- Vyacheslav Egorov (vegorovohnoyoudont@google.com)
Timing:
Create | Tuesday, 22-Jan-19 16:51:54 UTC |
Start | Tuesday, 22-Jan-19 17:00:40 UTC |
End | Tuesday, 22-Jan-19 17:23:10 UTC |
Pending | 8 mins 46 secs |
Execution | 22 mins 29 secs |
All Changes:
-
Fix the indexes associated with experiements
Changed by Brian Wilkerson - brianwilkersonohnoyoudont@google.com Changed at Tuesday, 22-Jan-19 16:44:29 UTC Repository https://dart.googlesource.com/sdk Branch Revision 2b1e2718e7e8ab77015d3006ed46579df094a4c0 Comments
Fix the indexes associated with experiements Change-Id: Ic6790de12b22d8aa05976bb0e2004a43bda4e5a7 Reviewed-on: https://dart-review.googlesource.com/c/90441 Reviewed-by: Dan Rubel <danrubel@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Changed files
- pkg/analyzer/lib/src/dart/analysis/experiments.dart
-
[infra] Experimentally add gclient-try builder to the CQ.
Changed by Jonas Termansen - sortieohnoyoudont@google.com Changed at Tuesday, 22-Jan-19 16:43:55 UTC Repository https://dart.googlesource.com/sdk Branch Revision f21da0eb178af436e83f42039ca02e8a6521ceab Comments
[infra] Experimentally add gclient-try builder to the CQ. Change-Id: I028c113ebbee4643c99f440e34ae3cdd80f9ea83 Reviewed-on: https://dart-review.googlesource.com/c/90485 Reviewed-by: William Hesse <whesse@google.com>
Changed files
- tools/infra/config/cq.cfg
-
[vm/io] On Windows do not consider sockets with pending operations closed.
Changed by Vyacheslav Egorov - vegorovohnoyoudont@google.com Changed at Tuesday, 22-Jan-19 16:34:54 UTC Repository https://dart.googlesource.com/sdk Branch Revision 9b01358ba0ac347151a2a20a14ffd1a6097938da Comments
[vm/io] On Windows do not consider sockets with pending operations closed. ClientSocket might have pending operations associated with it, so we should not delete it until those operations fire. This aligns ClientSocket::IsClosed with IsClosed implementation for other handles, which check if handle has any associated pending operations. The situation that sometimes arises it that if we issue Read, Disconnect operation, they might complete in the opposite order DisconnectComplete, ReadComplete, which is why we need to check for pending operations. MSDN contains sentences like these: "Please note that while the packets are queued in FIFO order they may be dequeued in a different order." It seems that a more uniform fix would be to it increment a reference count of a handle whenever an asynchronous operation is started and decrement it whenever it is completed - but such fix requires much more thorough refactoring of eventhandler_win.cc. Bug: https://github.com/flutter/flutter/issues/22558 Change-Id: I4e6a7d5fdeaa85b9903d005b5bb95338033228f1 Reviewed-on: https://dart-review.googlesource.com/c/90484 Commit-Queue: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Jonas Termansen <sortie@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Changed files
- runtime/bin/eventhandler_win.cc