Builder vm-kernel-win-product-x64 Build 1658

Results:

Success

Trigger Info:

Project	dart
Revision	8eed45d0b5d42f83cbc1673dcb9a961b76c60237
Got Revision	8eed45d0b5d42f83cbc1673dcb9a961b76c60237

Execution:

• Source: Task 428624debb1dc010
• Bot: win10-dart-fedce810-us-central1-c-h8v0
• Recipe: dart/neo

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 371 ms ) setup_build

   running recipe: "dart/neo"
   • stdout
   • run_recipe
2. ( 15 secs ) gsutil find latest build
   • stdout
   • raw_io.output_text[latest]
3. ( 2 secs ) gsutil get revision for latest build
   • stdout
   • raw_io.output_text[revision]
4. ( 2 secs ) ensure_goma
   • - no logs -
   1. ( 2 secs ) ensure_installed
      • stdout
      • json.output
5. ( 3 mins 18 secs ) bot_update

   [18GB/299GB used (6%)]
   • stdout
   • json.output
6. ( 7 secs ) clobber
   • stdout
7. ( 1 mins 18 secs ) gclient runhooks
   • stdout
8. ( 1 secs ) kill processes
   • stdout
9. ( 348 ms ) read test-matrix.json
   • stdout
   • json.output
10. ( 416 ms ) delete debug log
    • stdout
11. ( 420 ms ) write fileset analyzer_unit_tests to sdk root
    • stdout
12. ( 424 ms ) write fileset dart2js to sdk root
    • stdout
13. ( 417 ms ) write fileset dart2js_hostasserts to sdk root
    • stdout
14. ( 421 ms ) write fileset fuzzer to sdk root
    • stdout
15. ( 421 ms ) write fileset vm-kernel to sdk root
    • stdout
16. ( 393 ms ) gclient get checked-in SDK version
    • stdout
    • raw_io.output_text
17. ( 89 ms ) git show
    • stdout
18. ( 1 secs ) kill processes (2)
    • stdout
19. ( 21 secs ) preprocess_for_goma
    • - no logs -
    1. ( 421 ms ) goma cache directory
       • stdout
    2. ( 10 secs ) start_goma
       • stdout
       • cloudtail
    3. ( 11 secs ) start cloudtail
       • stdout
20. ( 1 mins 47 secs ) build dart
    • stdout
21. ( 31 secs ) postprocess_for_goma
    • - no logs -
    1. ( 623 ms ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 579 ms ) goma_stat
       • stdout
    3. ( 578 ms ) stop_goma
       • stdout
    4. ( 19 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
    5. ( 10 secs ) stop cloudtail
       • stdout
22. ( 1 mins 48 secs ) upload testing fileset vm-kernel

    swarming fileset hash: 15ad07f784593728f33aec6f51aafd9d75b0828d
    • stdout
23. ( 14 secs ) trigger shards for vm tests
    • - no logs -
    1. ( 1 secs ) [trigger] vm tests_shard_1 on Windows

       Run on OS: 'Windows'
       • stdout
       • json.output
       • shard #0
    2. ( 1 secs ) [trigger] vm tests_shard_2 on Windows

       Run on OS: 'Windows'
       • stdout
       • json.output
       • shard #0
    3. ( 1 secs ) [trigger] vm tests_shard_3 on Windows

       Run on OS: 'Windows'
       • stdout
       • json.output
       • shard #0
    4. ( 1 secs ) [trigger] vm tests_shard_4 on Windows

       Run on OS: 'Windows'
       • stdout
       • json.output
       • shard #0
    5. ( 1 secs ) [trigger] vm tests_shard_5 on Windows

       Run on OS: 'Windows'
       • stdout
       • json.output
       • shard #0
    6. ( 2 secs ) [trigger] vm tests_shard_6 on Windows

       Run on OS: 'Windows'
       • stdout
       • json.output
       • shard #0
    7. ( 1 secs ) [trigger] vm tests_shard_7 on Windows

       Run on OS: 'Windows'
       • stdout
       • json.output
       • shard #0
    8. ( 1 secs ) [trigger] vm tests_shard_8 on Windows

       Run on OS: 'Windows'
       • stdout
       • json.output
       • shard #0
    9. ( 1 secs ) [trigger] vm tests_shard_9 on Windows

       Run on OS: 'Windows'
       • stdout
       • json.output
       • shard #0
24. ( 1 mins 16 secs ) vm tests_shard_10
    • stdout
    • results.json
    • run.json
    • logs.json
25. ( 508 ms ) ensure swarming
    • - no logs -
    1. ( 508 ms ) ensure_installed
       • stdout
       • json.output
26. ( 25 mins 40 secs ) vm tests_shard_1 on Windows

    Run on OS: 'Windows'

    Pending time: 32s

    Shard duration: 0:26:32.888328
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • logs.json
    • run.json
    • results.json
    • shard #0 isolated out
    • test stdout of shard #0
27. ( 2 secs ) vm tests_shard_2 on Windows

    Run on OS: 'Windows'

    Pending time: 35s

    Shard duration: 0:20:10.182252
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • logs.json
    • run.json
    • results.json
    • shard #0 isolated out
    • test stdout of shard #0
28. ( 2 secs ) vm tests_shard_3 on Windows

    Run on OS: 'Windows'

    Pending time: 37s

    Shard duration: 0:24:10.753213
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • logs.json
    • run.json
    • results.json
    • shard #0 isolated out
    • test stdout of shard #0
29. ( 1 secs ) vm tests_shard_4 on Windows

    Run on OS: 'Windows'

    Pending time: 38s

    Shard duration: 0:24:13.082486
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • logs.json
    • run.json
    • results.json
    • shard #0 isolated out
    • test stdout of shard #0
30. ( 1 secs ) vm tests_shard_5 on Windows

    Run on OS: 'Windows'

    Pending time: 41s

    Shard duration: 0:20:08.938800
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • logs.json
    • run.json
    • results.json
    • shard #0 isolated out
    • test stdout of shard #0
31. ( 1 secs ) vm tests_shard_6 on Windows

    Run on OS: 'Windows'

    Pending time: 42s

    Shard duration: 0:16:39.356919
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • logs.json
    • run.json
    • results.json
    • shard #0 isolated out
    • test stdout of shard #0
32. ( 2 secs ) vm tests_shard_7 on Windows

    Run on OS: 'Windows'

    Pending time: 41s

    Shard duration: 0:26:29.909164
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • logs.json
    • run.json
    • results.json
    • shard #0 isolated out
    • test stdout of shard #0
33. ( 2 secs ) vm tests_shard_8 on Windows

    Run on OS: 'Windows'

    Pending time: 0:17:22.707903

    Shard duration: 0:03:52.105904
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • logs.json
    • run.json
    • results.json
    • shard #0 isolated out
    • test stdout of shard #0
34. ( 2 secs ) vm tests_shard_9 on Windows

    Run on OS: 'Windows'

    Pending time: 0:17:34.712943

    Shard duration: 0:03:16.741408
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • logs.json
    • run.json
    • results.json
    • shard #0 isolated out
    • test stdout of shard #0
35. ( 7 secs ) download previous results
    • - no logs -
    1. ( 470 ms ) ensure LATEST dir
       • stdout
    2. ( 419 ms ) ensure results.json exists
       • stdout
    3. ( 421 ms ) ensure flaky.json exists
       • stdout
    4. ( 419 ms ) ensure approved_results.json exists
       • stdout
    5. ( 3 secs ) gsutil download previous results
       • stdout
    6. ( 2 secs ) gsutil download approved results
       • stdout
36. ( 1 secs ) list tests to deflake (vm tests)
    • stdout
37. ( 3 secs ) deflake vm tests
    • stdout
    • results.json
    • run.json
    • logs.json
38. ( 1 secs ) update flakiness information
    • stdout
    • raw_io.output_text[flaky.json]
39. ( 1 secs ) find tests that began failing
    • stdout
40. ( 1 secs ) find tests that began failing (logs)
    • stdout
41. ( 1 secs ) find tests that began passing
    • stdout
42. ( 1 secs ) find unapproved failing tests
    • stdout
    • raw_io.output_text
43. ( 1 secs ) find unapproved failing tests (logs)
    • stdout
    • raw_io.output_text
44. ( 1 secs ) find unapproved passing tests
    • stdout
    • raw_io.output_text
45. ( 2 secs ) test results
    • stdout
    • unapproved failing tests
    • unapproved failing tests (logs)
    • unapproved passing tests
    • results.json
46. ( 23 secs ) upload new results
    • - no logs -
    1. ( 2 secs ) gsutil upload revision
       • stdout
       • gsutil.upload
    2. ( 4 secs ) gsutil upload logs.json
       • stdout
       • gsutil.upload
    3. ( 2 secs ) gsutil upload results.json
       • stdout
       • gsutil.upload
    4. ( 2 secs ) gsutil upload flaky.json
       • stdout
       • gsutil.upload
    5. ( 2 secs ) gsutil upload flaky_current_vm-kernel-win-product-x64.json
       • stdout
       • gsutil.upload
    6. ( 2 secs ) gsutil upload
       • stdout
       • gsutil.upload
    7. ( 2 secs ) gsutil upload runs.json
       • stdout
       • gsutil.upload
    8. ( 2 secs ) gsutil update "latest" reference
       • stdout
       • gsutil.upload
    9. ( 376 ms ) ensure_installed
       • stdout
       • json.output
    10. ( 3 secs ) upload test results to big query
        • - no logs -
        1. ( 560 ms ) upload results chunk to big query
           • stdout
        2. ( 327 ms ) upload results chunk to big query (2)
           • stdout
        3. ( 280 ms ) upload results chunk to big query (3)
           • stdout
        4. ( 295 ms ) upload results chunk to big query (4)
           • stdout
        5. ( 295 ms ) upload results chunk to big query (5)
           • stdout
        6. ( 358 ms ) upload results chunk to big query (6)
           • stdout
        7. ( 280 ms ) upload results chunk to big query (7)
           • stdout
        8. ( 264 ms ) upload results chunk to big query (8)
           • stdout
        9. ( 311 ms ) upload results chunk to big query (9)
           • stdout
        10. ( 311 ms ) upload results chunk to big query (10)
            • stdout
47. ( 1 secs ) kill processes (3)
    • stdout
48. ( 8 ms ) debug log
    • stdout
49. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "C:\\b\\s\\w\\ir\\cache", "temp_dir": "C:\\b\\s\\w\\ir\\tmp\\rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"win10-dart-fedce810-us-central1-c-h8v0"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.dart.ci.sandbox", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548022404321777, "id": "8923774575324644928", "project": "dart", "tags": ["builder:vm-kernel-win-product-x64", "buildset:commit/git/8eed45d0b5d42f83cbc1673dcb9a961b76c60237", "buildset:commit/gitiles/dart.googlesource.com/sdk/+/8eed45d0b5d42f83cbc1673dcb9a961b76c60237", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089204638153592304", "scheduler_job_id:dart/vm-kernel-win-product-x64", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"vm-kernel-win-product-x64"	setup_build
buildnumber	1658	setup_build
clobber	"true"	setup_build
mastername	"client.dart"	setup_build
path_config	"generic"	setup_build
recipe	"dart/neo"	setup_build
repository	"https://dart.googlesource.com/sdk/"	setup_build
revision	"8eed45d0b5d42f83cbc1673dcb9a961b76c60237"	setup_build
got_revision	"8eed45d0b5d42f83cbc1673dcb9a961b76c60237"	bot_update

Blamelist:

1. Konstantin Shcheglov (scheglovohnoyoudont@google.com)

Timing:

Create	Sunday, 20-Jan-19 22:13:24 UTC
Start	Sunday, 20-Jan-19 22:13:36 UTC
End	Sunday, 20-Jan-19 22:53:00 UTC
Pending	12 secs
Execution	39 mins 23 secs

All Changes:

1. Issue 3084. Don't generated 'new' in Quick Assists.

   Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
   Changed at	Sunday, 20-Jan-19 22:13:09 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	8eed45d0b5d42f83cbc1673dcb9a961b76c60237

   Comments

   Issue 3084. Don't generated 'new' in Quick Assists.
   
   This removes all 'new' is Quick Assists and their tests.
   
   Also removes /*caret*/ and start/end markers from the test code that
   is actually resolved, so that expectations should not have them as well.
   
   R=brianwilkerson@google.com
   
   Bug: https://github.com/flutter/flutter-intellij/issues/3084
   Change-Id: Ib63ea165bdc14b22fa371f93765adb1ca65a6b56
   Reviewed-on: https://dart-review.googlesource.com/c/89720
   Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
   Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
   

   Changed files

   • pkg/analysis_server/lib/src/services/correction/assist_internal.dart
   • pkg/analysis_server/test/src/services/correction/assist/add_type_annotation_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/assist_processor.dart
   • pkg/analysis_server/test/src/services/correction/assist/convert_to_int_literal_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/flutter_convert_to_children_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/flutter_convert_to_stateful_widget_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/flutter_move_down_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/flutter_move_up_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/flutter_remove_widget_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/flutter_swap_with_child_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/flutter_swap_with_parent_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/flutter_wrap_center_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/flutter_wrap_column_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/flutter_wrap_container_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/flutter_wrap_generic_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/flutter_wrap_padding_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/flutter_wrap_row_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/flutter_wrap_stream_builder_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/surround_with_block_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/surround_with_do_while_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/surround_with_for_in_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/surround_with_for_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/surround_with_if_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/surround_with_try_catch_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/surround_with_try_finally_test.dart
   • pkg/analysis_server/test/src/services/correction/assist/surround_with_while_test.dart