Builder vm-kernel-win-product-x64
Build 1607
Results:
Success
Trigger Info:
Project | dart |
Revision | e36ad1dad0e932ed28eda99a63b7562e9dad262b |
Got Revision | e36ad1dad0e932ed28eda99a63b7562e9dad262b |
Execution:
- Source: Task 42738588214d9010
- Bot: win10-dart-fedce810-us-central1-c-9zkd
- Recipe: dart/neo
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
-
( 2 mins 36 secs ) upload testing fileset vm-kernelswarming fileset hash: 534b271264f45d4c832ad587901509ae226178c3
-
- - no logs -
-
- - no logs -
-
( 10 secs ) vm tests_shard_4 on WindowsRun on OS: 'Windows'Pending time: 21sShard duration: 0:04:19.843033
-
( 2 secs ) vm tests_shard_5 on WindowsRun on OS: 'Windows'Pending time: 43sShard duration: 0:03:34.809100
-
( 2 secs ) vm tests_shard_6 on WindowsRun on OS: 'Windows'Pending time: 42sShard duration: 0:03:13.572714
-
( 7 mins 55 secs ) vm tests_shard_7 on WindowsRun on OS: 'Windows'Pending time: 40sShard duration: 0:11:45.932381
-
( 2 secs ) vm tests_shard_8 on WindowsRun on OS: 'Windows'Pending time: 43sShard duration: 0:03:57.888575
-
( 1 secs ) vm tests_shard_9 on WindowsRun on OS: 'Windows'Pending time: 42sShard duration: 0:03:45.644955
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "C:\\b\\s\\w\\ir\\cache", "temp_dir": "C:\\b\\s\\w\\ir\\tmp\\rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "win10-dart-fedce810-us-central1-c-9zkd" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.dart.ci.sandbox", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547709972119426, "id": "8924102184233311392", "project": "dart", "tags": ["builder:vm-kernel-win-product-x64", "buildset:commit/git/e36ad1dad0e932ed28eda99a63b7562e9dad262b", "buildset:commit/gitiles/dart.googlesource.com/sdk/+/e36ad1dad0e932ed28eda99a63b7562e9dad262b", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089532246680634160", "scheduler_job_id:dart/vm-kernel-win-product-x64", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "vm-kernel-win-product-x64" | setup_build |
buildnumber | 1607 | setup_build |
clobber | "true" | setup_build |
mastername | "client.dart" | setup_build |
path_config | "generic" | setup_build |
recipe | "dart/neo" | setup_build |
repository | "https://dart.googlesource.com/sdk/" | setup_build |
revision | "e36ad1dad0e932ed28eda99a63b7562e9dad262b" | setup_build |
got_revision | "e36ad1dad0e932ed28eda99a63b7562e9dad262b" | bot_update |
Blamelist:
- Kevin Millikin (kmillikinohnoyoudont@google.com)
Timing:
Create | Thursday, 17-Jan-19 07:26:12 UTC |
Start | Thursday, 17-Jan-19 07:26:22 UTC |
End | Thursday, 17-Jan-19 07:48:03 UTC |
Pending | 10 secs |
Execution | 21 mins 40 secs |
All Changes:
-
[Kernel] Build an invalid constant for evaluation errors
Changed by Kevin Millikin - kmillikinohnoyoudont@google.com Changed at Thursday, 17-Jan-19 07:26:04 UTC Repository https://dart.googlesource.com/sdk Branch Revision e36ad1dad0e932ed28eda99a63b7562e9dad262b Comments
[Kernel] Build an invalid constant for evaluation errors An invalid constant is (currently) represented by an unevaluated invalid expression. Using this instead of null fixes 63 out of 125 CFE constant-evaluation crashes with constant-update-2018 and correctly signals 26 more previously-missed compile-time errors. Change-Id: I5b4de3995b3a59978dfa08fc542ef0f027572eb6 Reviewed-on: https://dart-review.googlesource.com/c/89506 Commit-Queue: Kevin Millikin <kmillikin@google.com> Reviewed-by: Peter von der Ahé <ahe@google.com> Reviewed-by: Aske Simon Christensen <askesc@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/kernel_constants.dart
- pkg/kernel/lib/transformations/constants.dart
- pkg/kernel/lib/vm/constants_native_effects.dart
- pkg/vm/lib/bytecode/gen_bytecode.dart
- pkg/vm/lib/constants_error_reporter.dart
- tests/co19_2/co19_2-kernel.status