Builder vm-kernel-reload-linux-debug-x64 Build 2816
Results:
Success
Trigger Info:
Project | dart |
Revision | b6b4836d1de40ef709ca9dcf47c3be9e18eaf0b8 |
Got Revision | b6b4836d1de40ef709ca9dcf47c3be9e18eaf0b8 |
Execution:
- Source: Task 4295cb860e812b10
- Bot: trusty-dart-68765ebb-us-central1-b-b61d
- Recipe: dart/neo
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
-
( 42 secs ) upload testing fileset vm-kernelswarming fileset hash: 67bb2ed3c20ffaffd7109c3c29080ae7f6ca94ce
-
- - no logs -
-
- - no logs -
-
( 22 mins 59 secs ) vm tests_shard_1Run on OS: 'Linux'Pending time: 0:18:43.374473Shard duration: 0:08:01.880981
-
( 2 secs ) vm tests_shard_2Run on OS: 'Linux'Pending time: 0:18:49.638771Shard duration: 0:06:37.641428
-
( 1 secs ) vm tests_shard_3Run on OS: 'Linux'Pending time: 0:18:56.066432Shard duration: 0:07:06.530868
-
( 1 secs ) vm tests_shard_4Run on OS: 'Linux'Pending time: 0:18:59.405738Shard duration: 0:07:15.579943
-
( 1 secs ) vm tests_shard_5Run on OS: 'Linux'Pending time: 0:19:02.771645Shard duration: 0:06:46.514736
-
( 5 mins 34 secs ) vm tests_shard_6Run on OS: 'Linux'Pending time: 0:19:03.621327Shard duration: 0:13:19.440796
-
( 1 secs ) vm tests_shard_7Run on OS: 'Linux'Pending time: 0:19:07.629153Shard duration: 0:05:10.892408
-
( 1 secs ) vm tests_shard_8Run on OS: 'Linux'Pending time: 0:19:14.160720Shard duration: 0:05:42.485362
-
( 1 secs ) vm tests_shard_9Run on OS: 'Linux'Pending time: 0:19:14.350201Shard duration: 0:04:25.341475
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "trusty-dart-68765ebb-us-central1-b-b61d" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.dart.ci.sandbox", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548284984111573, "id": "8923499240459388608", "project": "dart", "tags": ["builder:vm-kernel-reload-linux-debug-x64", "buildset:commit/git/b6b4836d1de40ef709ca9dcf47c3be9e18eaf0b8", "buildset:commit/gitiles/dart.googlesource.com/sdk/+/b6b4836d1de40ef709ca9dcf47c3be9e18eaf0b8", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9088929302779764496", "scheduler_job_id:dart/vm-kernel-reload-linux-debug-x64", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "vm-kernel-reload-linux-debug-x64" | setup_build |
buildnumber | 2816 | setup_build |
clobber | "true" | setup_build |
mastername | "client.dart" | setup_build |
path_config | "generic" | setup_build |
recipe | "dart/neo" | setup_build |
repository | "https://dart.googlesource.com/sdk/" | setup_build |
revision | "b6b4836d1de40ef709ca9dcf47c3be9e18eaf0b8" | setup_build |
got_revision | "b6b4836d1de40ef709ca9dcf47c3be9e18eaf0b8" | bot_update |
Blamelist:
- Ryan Macnak (rmacnakohnoyoudont@google.com)
- Aart Bik (ajcbikohnoyoudont@google.com)
- Konstantin Shcheglov (scheglovohnoyoudont@google.com)
Timing:
Create | Wednesday, 23-Jan-19 23:09:44 UTC |
Start | Wednesday, 23-Jan-19 23:10:39 UTC |
End | Wednesday, 23-Jan-19 23:47:15 UTC |
Pending | 55 secs |
Execution | 36 mins 36 secs |
All Changes:
-
[vm] Reference type test stubs through Code; use the type as the owner of a type test stub.
Changed by Ryan Macnak - rmacnakohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 22:59:47 UTC Repository https://dart.googlesource.com/sdk Branch Revision b6b4836d1de40ef709ca9dcf47c3be9e18eaf0b8 Comments
[vm] Reference type test stubs through Code; use the type as the owner of a type test stub. Directly referencing VM isolate instructions from an isolate snapshot causes the instructions to be copied into the isolate's image page because instructions do not use the indirection of the ref array. Duplicating the instructions caused TypeTestingStubFinder::LookupByAddresss to be unable to identity the duplicate copies of the VM isolate type testing stubs. Fixes identity of StubCode::*TypeTest broken by duplication in snapshot. Fixes generating AppJIT snapshots after loading from AppJIT snapshots. Fixes attribution of ticks for type test stubs in the AOT profiler. Change-Id: I9879a85bd548e694ee36e14f795898582ccdddb0 Reviewed-on: https://dart-review.googlesource.com/c/90501 Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Reviewed-by: Zach Anderson <zra@google.com>
Changed files
- runtime/vm/clustered_snapshot.cc
- runtime/vm/clustered_snapshot.h
- runtime/vm/compiler/aot/precompiler.cc
- runtime/vm/image_snapshot.cc
- runtime/vm/object.cc
- runtime/vm/object.h
- runtime/vm/object_service.cc
- runtime/vm/object_store.h
- runtime/vm/raw_object.h
- runtime/vm/raw_object_fields.cc
- runtime/vm/raw_object_snapshot.cc
- runtime/vm/snapshot.cc
- runtime/vm/type_testing_stubs.cc
- runtime/vm/type_testing_stubs.h
-
[dart/vm] Annotate _ByteDataView to reduce code size
Changed by Aart Bik - ajcbikohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 22:48:37 UTC Repository https://dart.googlesource.com/sdk Branch Revision a1b7fad86a19f87bb5f176fd0941992e927e7936 Comments
[dart/vm] Annotate _ByteDataView to reduce code size Rationale: Slava's excellent code size difference tools enables very fine-grained analysis of the impact of changes. This CL improves Flutter Gallery size by 18984 bytes. +------------------------------------------------------+-----------------------------------------+--------------+ | Library | Method | Diff (Bytes) | +------------------------------------------------------+-----------------------------------------+--------------+ | package:flutter/src/painting/decoration_image.dart | paintImage | +936 | | dart:ui | Paint.toString | +592 | | package:flutter/src/material/tab_indicator.dart | _UnderlinePainter.paint | +552 | | package:flutter/src/material/progress_indicator.dart | _CircularProgressIndicatorPainter.paint | +308 | | package:flutter/src/services/message_codecs.dart | StandardMessageCodec.readValueOfType | +172 | | package:flutter/src/services/message_codecs.dart | StandardMessageCodec.readValue | +60 | | package:flutter/src/services/message_codecs.dart | StandardMethodCodec.decodeEnvelope | +56 | | package:flutter/src/services/message_codecs.dart | StandardMethodCodec.decodeMethodCall | +56 | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | package:flutter/src/widgets/semantics_debugger.dart | _paint | -484 | | dart:ui | Paint.maskFilter= | -568 | | dart:ui | Paint.colorFilter= | -572 | | package:flutter/src/painting/borders.dart | paintBorder | -656 | | dart:ui | _unpackPointerDataPacket | -744 | | dart:ui | Paint.isAntiAlias= | -808 | | dart:ui | Paint.strokeCap= | -812 | | dart:ui | Paint.filterQuality= | -812 | | dart:ui | Paint.isAntiAlias | -972 | | dart:ui | Paint.invertColors | -976 | +------------------------------------------------------+-----------------------------------------+--------------+ Total change -18984 bytes. https://github.com/dart-lang/sdk/issues/35323 Change-Id: Iceeb820ed506794e1ac3e7c17f8f116a22bca742 Reviewed-on: https://dart-review.googlesource.com/c/90861 Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Commit-Queue: Aart Bik <ajcbik@google.com>
Changed files
- runtime/lib/typed_data_patch.dart
-
Issue 34152. Verify file paths and report INVALID_FILE_PATH_FORMAT.
Changed by Konstantin Shcheglov - scheglovohnoyoudont@google.com Changed at Wednesday, 23-Jan-19 22:11:17 UTC Repository https://dart.googlesource.com/sdk Branch Revision 5dab28f27f525b8e2b88f0dfa19f03c5619f3234 Comments
Issue 34152. Verify file paths and report INVALID_FILE_PATH_FORMAT. R=brianwilkerson@google.com, paulberry@google.com Bug: https://github.com/dart-lang/sdk/issues/34152 Change-Id: I4a5f3634c342fbcfb3bf39c060cc658d87306312 Reviewed-on: https://dart-review.googlesource.com/c/90840 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Changed files
- pkg/analysis_server/lib/src/analysis_server.dart
- pkg/analysis_server/lib/src/domain_analysis.dart
- pkg/analysis_server/lib/src/domain_completion.dart
- pkg/analysis_server/lib/src/edit/edit_domain.dart
- pkg/analysis_server/test/analysis/get_errors_test.dart
- pkg/analysis_server/test/analysis/get_hover_test.dart
- pkg/analysis_server/test/analysis/get_navigation_test.dart
- pkg/analysis_server/test/analysis/get_signature_test.dart
- pkg/analysis_server/test/analysis/set_priority_files_test.dart
- pkg/analysis_server/test/analysis/update_content_test.dart
- pkg/analysis_server/test/domain_completion_test.dart
- pkg/analysis_server/test/edit/assists_test.dart
- pkg/analysis_server/test/edit/fixes_test.dart
- pkg/analysis_server/test/edit/organize_directives_test.dart
- pkg/analysis_server/test/edit/postfix_completion_test.dart
- pkg/analysis_server/test/edit/refactoring_test.dart
- pkg/analysis_server/test/edit/sort_members_test.dart
- pkg/analysis_server/test/edit/statement_completion_test.dart