Builder vm-kernel-reload-linux-debug-x64 Build 2816

Results:

Success

Trigger Info:

Project	dart
Revision	b6b4836d1de40ef709ca9dcf47c3be9e18eaf0b8
Got Revision	b6b4836d1de40ef709ca9dcf47c3be9e18eaf0b8

Execution:

• Source: Task 4295cb860e812b10
• Bot: trusty-dart-68765ebb-us-central1-b-b61d
• Recipe: dart/neo

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 188 ms ) setup_build

   running recipe: "dart/neo"
   • stdout
   • run_recipe
2. ( 2 secs ) gsutil find latest build
   • stdout
   • raw_io.output_text[latest]
3. ( 1 secs ) gsutil get revision for latest build
   • stdout
   • raw_io.output_text[revision]
4. ( 137 ms ) ensure_goma
   • - no logs -
   1. ( 137 ms ) ensure_installed
      • stdout
      • json.output
5. ( 13 secs ) bot_update

   [77GB/295GB used (26%)]
   • stdout
   • json.output
6. ( 814 ms ) clobber
   • stdout
7. ( 1 secs ) gclient runhooks
   • stdout
8. ( 525 ms ) kill processes
   • stdout
9. ( 338 ms ) read test-matrix.json
   • stdout
   • json.output
10. ( 413 ms ) delete debug log
    • stdout
11. ( 456 ms ) write fileset analyzer_unit_tests to sdk root
    • stdout
12. ( 457 ms ) write fileset dart2js to sdk root
    • stdout
13. ( 453 ms ) write fileset dart2js_hostasserts to sdk root
    • stdout
14. ( 453 ms ) write fileset fuzzer to sdk root
    • stdout
15. ( 461 ms ) write fileset vm-kernel to sdk root
    • stdout
16. ( 371 ms ) gclient get checked-in SDK version
    • stdout
    • raw_io.output_text
17. ( 15 ms ) git show
    • stdout
18. ( 518 ms ) kill processes (2)
    • stdout
19. ( 2 secs ) preprocess_for_goma
    • - no logs -
    1. ( 458 ms ) goma cache directory
       • stdout
    2. ( 908 ms ) start_goma
       • stdout
       • cloudtail
    3. ( 1 secs ) start cloudtail
       • stdout
20. ( 1 mins 48 secs ) build dart
    • stdout
21. ( 8 secs ) postprocess_for_goma
    • - no logs -
    1. ( 551 ms ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 527 ms ) goma_stat
       • stdout
    3. ( 544 ms ) stop_goma
       • stdout
    4. ( 5 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
    5. ( 1 secs ) stop cloudtail
       • stdout
22. ( 42 secs ) upload testing fileset vm-kernel

    swarming fileset hash: 67bb2ed3c20ffaffd7109c3c29080ae7f6ca94ce
    • stdout
23. ( 9 secs ) trigger shards for vm tests
    • - no logs -
    1. ( 1 secs ) [trigger] vm tests_shard_1

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    2. ( 1 secs ) [trigger] vm tests_shard_2

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    3. ( 1 secs ) [trigger] vm tests_shard_3

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    4. ( 1 secs ) [trigger] vm tests_shard_4

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    5. ( 1 secs ) [trigger] vm tests_shard_5

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    6. ( 1 secs ) [trigger] vm tests_shard_6

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    7. ( 898 ms ) [trigger] vm tests_shard_7

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    8. ( 964 ms ) [trigger] vm tests_shard_8

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    9. ( 977 ms ) [trigger] vm tests_shard_9

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
24. ( 3 mins 49 secs ) vm tests_shard_10
    • stdout
    • results.json
    • run.json
    • logs.json
25. ( 145 ms ) ensure swarming
    • - no logs -
    1. ( 145 ms ) ensure_installed
       • stdout
       • json.output
26. ( 22 mins 59 secs ) vm tests_shard_1

    Run on OS: 'Linux'

    Pending time: 0:18:43.374473

    Shard duration: 0:08:01.880981
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
27. ( 2 secs ) vm tests_shard_2

    Run on OS: 'Linux'

    Pending time: 0:18:49.638771

    Shard duration: 0:06:37.641428
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
28. ( 1 secs ) vm tests_shard_3

    Run on OS: 'Linux'

    Pending time: 0:18:56.066432

    Shard duration: 0:07:06.530868
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
29. ( 1 secs ) vm tests_shard_4

    Run on OS: 'Linux'

    Pending time: 0:18:59.405738

    Shard duration: 0:07:15.579943
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
30. ( 1 secs ) vm tests_shard_5

    Run on OS: 'Linux'

    Pending time: 0:19:02.771645

    Shard duration: 0:06:46.514736
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
31. ( 5 mins 34 secs ) vm tests_shard_6

    Run on OS: 'Linux'

    Pending time: 0:19:03.621327

    Shard duration: 0:13:19.440796
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
32. ( 1 secs ) vm tests_shard_7

    Run on OS: 'Linux'

    Pending time: 0:19:07.629153

    Shard duration: 0:05:10.892408
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
33. ( 1 secs ) vm tests_shard_8

    Run on OS: 'Linux'

    Pending time: 0:19:14.160720

    Shard duration: 0:05:42.485362
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
34. ( 1 secs ) vm tests_shard_9

    Run on OS: 'Linux'

    Pending time: 0:19:14.350201

    Shard duration: 0:04:25.341475
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
35. ( 5 secs ) download previous results
    • - no logs -
    1. ( 488 ms ) ensure LATEST dir
       • stdout
    2. ( 469 ms ) ensure results.json exists
       • stdout
    3. ( 465 ms ) ensure flaky.json exists
       • stdout
    4. ( 469 ms ) ensure approved_results.json exists
       • stdout
    5. ( 2 secs ) gsutil download previous results
       • stdout
    6. ( 1 secs ) gsutil download approved results
       • stdout
36. ( 714 ms ) list tests to deflake (vm tests)
    • stdout
37. ( 1 secs ) deflake vm tests
    • stdout
    • results.json
    • run.json
    • logs.json
38. ( 696 ms ) update flakiness information
    • stdout
    • raw_io.output_text[flaky.json]
39. ( 737 ms ) find tests that began failing
    • stdout
40. ( 762 ms ) find tests that began failing (logs)
    • stdout
41. ( 765 ms ) find tests that began passing
    • stdout
42. ( 770 ms ) find unapproved failing tests
    • stdout
    • raw_io.output_text
43. ( 811 ms ) find unapproved failing tests (logs)
    • stdout
    • raw_io.output_text
44. ( 717 ms ) find unapproved passing tests
    • stdout
    • raw_io.output_text
45. ( 799 ms ) find ignored flaky test failure logs
    • stdout
    • raw_io.output_text
46. ( 1 secs ) test results
    • stdout
    • unapproved failing tests
    • unapproved failing tests (logs)
    • unapproved passing tests
    • ignored flaky test failure logs
    • results.json
47. ( 16 secs ) upload new results
    • - no logs -
    1. ( 1 secs ) gsutil upload revision
       • stdout
       • gsutil.upload
    2. ( 1 secs ) gsutil upload logs.json
       • stdout
       • gsutil.upload
    3. ( 1 secs ) gsutil upload results.json
       • stdout
       • gsutil.upload
    4. ( 1 secs ) gsutil upload flaky.json
       • stdout
       • gsutil.upload
    5. ( 1 secs ) gsutil upload flaky_current_vm-kernel-reload-linux-debug-x64.json
       • stdout
       • gsutil.upload
    6. ( 1 secs ) gsutil upload
       • stdout
       • gsutil.upload
    7. ( 1 secs ) gsutil upload runs.json
       • stdout
       • gsutil.upload
    8. ( 1 secs ) gsutil update "latest" reference
       • stdout
       • gsutil.upload
    9. ( 578 ms ) ensure_installed
       • stdout
       • json.output
    10. ( 2 secs ) upload test results to big query
        • - no logs -
        1. ( 419 ms ) upload results chunk to big query
           • stdout
        2. ( 309 ms ) upload results chunk to big query (2)
           • stdout
        3. ( 304 ms ) upload results chunk to big query (3)
           • stdout
        4. ( 362 ms ) upload results chunk to big query (4)
           • stdout
        5. ( 325 ms ) upload results chunk to big query (5)
           • stdout
        6. ( 331 ms ) upload results chunk to big query (6)
           • stdout
        7. ( 215 ms ) upload results chunk to big query (7)
           • stdout
48. ( 539 ms ) kill processes (3)
    • stdout
49. ( 10 ms ) debug log
    • stdout
50. ( 1 ms ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"trusty-dart-68765ebb-us-central1-b-b61d"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.dart.ci.sandbox", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548284984111573, "id": "8923499240459388608", "project": "dart", "tags": ["builder:vm-kernel-reload-linux-debug-x64", "buildset:commit/git/b6b4836d1de40ef709ca9dcf47c3be9e18eaf0b8", "buildset:commit/gitiles/dart.googlesource.com/sdk/+/b6b4836d1de40ef709ca9dcf47c3be9e18eaf0b8", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9088929302779764496", "scheduler_job_id:dart/vm-kernel-reload-linux-debug-x64", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"vm-kernel-reload-linux-debug-x64"	setup_build
buildnumber	2816	setup_build
clobber	"true"	setup_build
mastername	"client.dart"	setup_build
path_config	"generic"	setup_build
recipe	"dart/neo"	setup_build
repository	"https://dart.googlesource.com/sdk/"	setup_build
revision	"b6b4836d1de40ef709ca9dcf47c3be9e18eaf0b8"	setup_build
got_revision	"b6b4836d1de40ef709ca9dcf47c3be9e18eaf0b8"	bot_update

Blamelist:

1. Ryan Macnak (rmacnakohnoyoudont@google.com)
2. Aart Bik (ajcbikohnoyoudont@google.com)
3. Konstantin Shcheglov (scheglovohnoyoudont@google.com)

Timing:

Create	Wednesday, 23-Jan-19 23:09:44 UTC
Start	Wednesday, 23-Jan-19 23:10:39 UTC
End	Wednesday, 23-Jan-19 23:47:15 UTC
Pending	55 secs
Execution	36 mins 36 secs

All Changes:

1. [vm] Reference type test stubs through Code; use the type as the owner of a type test stub.

   Changed by	Ryan Macnak - rmacnakohnoyoudont@google.com
   Changed at	Wednesday, 23-Jan-19 22:59:47 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	b6b4836d1de40ef709ca9dcf47c3be9e18eaf0b8

   Comments

   [vm] Reference type test stubs through Code; use the type as the owner of a type test stub.
   
   Directly referencing VM isolate instructions from an isolate snapshot causes the instructions to be copied into the isolate's image page because instructions do not use the indirection of the ref array. Duplicating the instructions caused TypeTestingStubFinder::LookupByAddresss to be unable to identity the duplicate copies of the VM isolate type testing stubs.
   
   Fixes identity of StubCode::*TypeTest broken by duplication in snapshot.
   Fixes generating AppJIT snapshots after loading from AppJIT snapshots.
   Fixes attribution of ticks for type test stubs in the AOT profiler.
   
   Change-Id: I9879a85bd548e694ee36e14f795898582ccdddb0
   Reviewed-on: https://dart-review.googlesource.com/c/90501
   Commit-Queue: Ryan Macnak <rmacnak@google.com>
   Reviewed-by: Martin Kustermann <kustermann@google.com>
   Reviewed-by: Zach Anderson <zra@google.com>
   

   Changed files

   • runtime/vm/clustered_snapshot.cc
   • runtime/vm/clustered_snapshot.h
   • runtime/vm/compiler/aot/precompiler.cc
   • runtime/vm/image_snapshot.cc
   • runtime/vm/object.cc
   • runtime/vm/object.h
   • runtime/vm/object_service.cc
   • runtime/vm/object_store.h
   • runtime/vm/raw_object.h
   • runtime/vm/raw_object_fields.cc
   • runtime/vm/raw_object_snapshot.cc
   • runtime/vm/snapshot.cc
   • runtime/vm/type_testing_stubs.cc
   • runtime/vm/type_testing_stubs.h

2. [dart/vm] Annotate _ByteDataView to reduce code size

   Changed by	Aart Bik - ajcbikohnoyoudont@google.com
   Changed at	Wednesday, 23-Jan-19 22:48:37 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	a1b7fad86a19f87bb5f176fd0941992e927e7936

   Comments

   [dart/vm] Annotate _ByteDataView to reduce code size
   
   Rationale:
   Slava's excellent code size difference tools enables
   very fine-grained analysis of the impact of changes.
   This CL improves Flutter Gallery size by 18984 bytes.
   
   +------------------------------------------------------+-----------------------------------------+--------------+
   | Library                                              | Method                                  | Diff (Bytes) |
   +------------------------------------------------------+-----------------------------------------+--------------+
   | package:flutter/src/painting/decoration_image.dart   | paintImage                              |         +936 |
   | dart:ui                                              | Paint.toString                          |         +592 |
   | package:flutter/src/material/tab_indicator.dart      | _UnderlinePainter.paint                 |         +552 |
   | package:flutter/src/material/progress_indicator.dart | _CircularProgressIndicatorPainter.paint |         +308 |
   | package:flutter/src/services/message_codecs.dart     | StandardMessageCodec.readValueOfType    |         +172 |
   | package:flutter/src/services/message_codecs.dart     | StandardMessageCodec.readValue          |          +60 |
   | package:flutter/src/services/message_codecs.dart     | StandardMethodCodec.decodeEnvelope      |          +56 |
   | package:flutter/src/services/message_codecs.dart     | StandardMethodCodec.decodeMethodCall    |          +56 |
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   | package:flutter/src/widgets/semantics_debugger.dart  | _paint                                  |         -484 |
   | dart:ui                                              | Paint.maskFilter=                       |         -568 |
   | dart:ui                                              | Paint.colorFilter=                      |         -572 |
   | package:flutter/src/painting/borders.dart            | paintBorder                             |         -656 |
   | dart:ui                                              | _unpackPointerDataPacket                |         -744 |
   | dart:ui                                              | Paint.isAntiAlias=                      |         -808 |
   | dart:ui                                              | Paint.strokeCap=                        |         -812 |
   | dart:ui                                              | Paint.filterQuality=                    |         -812 |
   | dart:ui                                              | Paint.isAntiAlias                       |         -972 |
   | dart:ui                                              | Paint.invertColors                      |         -976 |
   +------------------------------------------------------+-----------------------------------------+--------------+
   Total change -18984 bytes.
   
   https://github.com/dart-lang/sdk/issues/35323
   
   Change-Id: Iceeb820ed506794e1ac3e7c17f8f116a22bca742
   Reviewed-on: https://dart-review.googlesource.com/c/90861
   Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
   Commit-Queue: Aart Bik <ajcbik@google.com>
   

   Changed files

   • runtime/lib/typed_data_patch.dart

3. Issue 34152. Verify file paths and report INVALID_FILE_PATH_FORMAT.

   Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
   Changed at	Wednesday, 23-Jan-19 22:11:17 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	5dab28f27f525b8e2b88f0dfa19f03c5619f3234

   Comments

   Issue 34152. Verify file paths and report INVALID_FILE_PATH_FORMAT.
   
   R=brianwilkerson@google.com, paulberry@google.com
   
   Bug: https://github.com/dart-lang/sdk/issues/34152
   Change-Id: I4a5f3634c342fbcfb3bf39c060cc658d87306312
   Reviewed-on: https://dart-review.googlesource.com/c/90840
   Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
   Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
   

   Changed files

   • pkg/analysis_server/lib/src/analysis_server.dart
   • pkg/analysis_server/lib/src/domain_analysis.dart
   • pkg/analysis_server/lib/src/domain_completion.dart
   • pkg/analysis_server/lib/src/edit/edit_domain.dart
   • pkg/analysis_server/test/analysis/get_errors_test.dart
   • pkg/analysis_server/test/analysis/get_hover_test.dart
   • pkg/analysis_server/test/analysis/get_navigation_test.dart
   • pkg/analysis_server/test/analysis/get_signature_test.dart
   • pkg/analysis_server/test/analysis/set_priority_files_test.dart
   • pkg/analysis_server/test/analysis/update_content_test.dart
   • pkg/analysis_server/test/domain_completion_test.dart
   • pkg/analysis_server/test/edit/assists_test.dart
   • pkg/analysis_server/test/edit/fixes_test.dart
   • pkg/analysis_server/test/edit/organize_directives_test.dart
   • pkg/analysis_server/test/edit/postfix_completion_test.dart
   • pkg/analysis_server/test/edit/refactoring_test.dart
   • pkg/analysis_server/test/edit/sort_members_test.dart
   • pkg/analysis_server/test/edit/statement_completion_test.dart