Builder vm-kernel-reload-linux-debug-x64 Build 2665
Results:
Internal Failure
Trigger Info:
Project | dart |
Revision | 7e1aa678551e33cb9d5de485b1f2fcd79f74e59e |
Got Revision | 7e1aa678551e33cb9d5de485b1f2fcd79f74e59e |
Execution:
- Source: Task 4267579e74fb0010
- Bot: trusty-dart-68765ebb-us-central1-b-wvgp
- Recipe: dart/neo
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
-
( 45 secs ) upload testing fileset vm-kernelswarming fileset hash: b4148ed0d9edb69e22c22da6f76b38bb75b3f8a0
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "trusty-dart-68765ebb-us-central1-b-wvgp" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.dart.ci.sandbox", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547505635584219, "id": "8924316446620163440", "project": "dart", "tags": ["builder:vm-kernel-reload-linux-debug-x64", "buildset:commit/git/7e1aa678551e33cb9d5de485b1f2fcd79f74e59e", "buildset:commit/gitiles/dart.googlesource.com/sdk/+/7e1aa678551e33cb9d5de485b1f2fcd79f74e59e", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089746508745874688", "scheduler_job_id:dart/vm-kernel-reload-linux-debug-x64", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "vm-kernel-reload-linux-debug-x64" | setup_build |
buildnumber | 2665 | setup_build |
clobber | "true" | setup_build |
mastername | "client.dart" | setup_build |
path_config | "generic" | setup_build |
recipe | "dart/neo" | setup_build |
repository | "https://dart.googlesource.com/sdk/" | setup_build |
revision | "7e1aa678551e33cb9d5de485b1f2fcd79f74e59e" | setup_build |
got_revision | "7e1aa678551e33cb9d5de485b1f2fcd79f74e59e" | bot_update |
Blamelist:
- Alexander Aprelev (aamohnoyoudont@google.com)
- Konstantin Shcheglov (scheglovohnoyoudont@google.com)
Timing:
Create | Monday, 14-Jan-19 22:40:35 UTC |
Start | Monday, 14-Jan-19 22:40:43 UTC |
End | Monday, 14-Jan-19 22:57:47 UTC |
Pending | 7 secs |
Execution | 17 mins 4 secs |
All Changes:
-
Restore TLABs.
Changed by Alexander Aprelev - aamohnoyoudont@google.com Changed at Monday, 14-Jan-19 22:19:32 UTC Repository https://dart.googlesource.com/sdk Branch Revision 7e1aa678551e33cb9d5de485b1f2fcd79f74e59e Comments
Restore TLABs. This reverts https://github.com/dart-lang/sdk/commit/e9d358921dddbee84c39c951220d5a844b097bb5 and on top of original change it: - switches from FreeList used as a filler to ForwardingCorpse because it is not as strict as to be expected only in old space; - gets Verifier to accept ForwardingCorpse(as well as FreeList) in new space; - asserts that thread is at safepoint(or is busy with one of GC tasks); - has slow-path TryAllocateNewTLAB in scavenger.cc, rather than in .h; - uses "inline" space_lock Mutex instead of allocating one on the heap; - reverts back to less precise used space calculation to avoid requiring threads to be at a safepoint for calculation; - adds HeapIterationScope in two places(heap_test.cc and service.cc) to accommodate newly introduced ASSERTs. Change-Id: I42df716cff6da9651ce7737fa66d7ec2a55905b0 Reviewed-on: https://dart-review.googlesource.com/c/89041 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
Changed files
- runtime/vm/heap/heap.cc
- runtime/vm/heap/heap.h
- runtime/vm/heap/heap_test.cc
- runtime/vm/heap/scavenger.cc
- runtime/vm/heap/scavenger.h
- runtime/vm/heap/verifier.cc
- runtime/vm/isolate.cc
- runtime/vm/service.cc
- runtime/vm/thread.h
- runtime/vm/thread_registry.h
-
Issue 33930. Fix resynthesizing function typed field formal parameter types.
Changed by Konstantin Shcheglov - scheglovohnoyoudont@google.com Changed at Monday, 14-Jan-19 22:08:01 UTC Repository https://dart.googlesource.com/sdk Branch Revision 387a6440089586f4d59cc248da314e14125f97c7 Comments
Issue 33930. Fix resynthesizing function typed field formal parameter types. R=brianwilkerson@google.com, paulberry@google.com Bug: https://github.com/dart-lang/sdk/issues/33930 Change-Id: I81c14cf5edf67eaeb253daefce3b91f0002b36a2 Reviewed-on: https://dart-review.googlesource.com/c/89440 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Changed files
- pkg/analyzer/lib/src/dart/element/element.dart
- pkg/analyzer/test/src/summary/resynthesize_common.dart