Builder vm-kernel-reload-linux-debug-x64 Build 2656

Results:

Success

Trigger Info:

Project	dart
Revision	f5c69070afc86d17b76dc460b65af17ac943c018
Got Revision	f5c69070afc86d17b76dc460b65af17ac943c018

Execution:

• Source: Task 42663c3e00d2c210
• Bot: trusty-dart-68765ebb-us-central1-b-95vk
• Recipe: dart/neo

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 205 ms ) setup_build

   running recipe: "dart/neo"
   • stdout
   • run_recipe
2. ( 4 secs ) gsutil find latest build
   • stdout
   • raw_io.output_text[latest]
3. ( 1 secs ) gsutil get revision for latest build
   • stdout
   • raw_io.output_text[revision]
4. ( 173 ms ) ensure_goma
   • - no logs -
   1. ( 173 ms ) ensure_installed
      • stdout
      • json.output
5. ( 18 secs ) bot_update

   [46GB/295GB used (15%)]
   • stdout
   • json.output
6. ( 2 secs ) clobber
   • stdout
7. ( 2 secs ) gclient runhooks
   • stdout
8. ( 538 ms ) kill processes
   • stdout
9. ( 326 ms ) read test-matrix.json
   • stdout
   • json.output
10. ( 415 ms ) delete debug log
    • stdout
11. ( 436 ms ) write fileset analyzer_unit_tests to sdk root
    • stdout
12. ( 433 ms ) write fileset dart2js to sdk root
    • stdout
13. ( 434 ms ) write fileset dart2js_hostasserts to sdk root
    • stdout
14. ( 433 ms ) write fileset fuzzer to sdk root
    • stdout
15. ( 434 ms ) write fileset vm-kernel to sdk root
    • stdout
16. ( 341 ms ) gclient get checked-in SDK version
    • stdout
    • raw_io.output_text
17. ( 10 ms ) git show
    • stdout
18. ( 501 ms ) kill processes (2)
    • stdout
19. ( 4 secs ) preprocess_for_goma
    • - no logs -
    1. ( 452 ms ) goma cache directory
       • stdout
    2. ( 1 secs ) start_goma
       • stdout
       • cloudtail
    3. ( 2 secs ) start cloudtail
       • stdout
20. ( 1 mins 39 secs ) build dart
    • stdout
21. ( 10 secs ) postprocess_for_goma
    • - no logs -
    1. ( 502 ms ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 488 ms ) goma_stat
       • stdout
    3. ( 505 ms ) stop_goma
       • stdout
    4. ( 7 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
    5. ( 1 secs ) stop cloudtail
       • stdout
22. ( 59 secs ) upload testing fileset vm-kernel

    swarming fileset hash: 48797d8e7c641d58c8b1fc388a0757265245bf02
    • stdout
23. ( 9 secs ) trigger shards for vm tests
    • - no logs -
    1. ( 1 secs ) [trigger] vm tests_shard_1

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    2. ( 974 ms ) [trigger] vm tests_shard_2

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    3. ( 932 ms ) [trigger] vm tests_shard_3

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    4. ( 1 secs ) [trigger] vm tests_shard_4

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    5. ( 896 ms ) [trigger] vm tests_shard_5

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    6. ( 1 secs ) [trigger] vm tests_shard_6

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    7. ( 998 ms ) [trigger] vm tests_shard_7

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    8. ( 1 secs ) [trigger] vm tests_shard_8

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    9. ( 1 secs ) [trigger] vm tests_shard_9

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
24. ( 3 mins 20 secs ) vm tests_shard_10
    • stdout
    • results.json
    • run.json
    • logs.json
25. ( 332 ms ) ensure swarming
    • - no logs -
    1. ( 332 ms ) ensure_installed
       • stdout
       • json.output
26. ( 10 mins 2 secs ) vm tests_shard_1

    Run on OS: 'Linux'

    Pending time: 0:05:54.844208

    Shard duration: 0:07:22.928319
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
27. ( 1 secs ) vm tests_shard_2

    Run on OS: 'Linux'

    Pending time: 0:06:02.564498

    Shard duration: 0:04:07.696387
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
28. ( 2 secs ) vm tests_shard_3

    Run on OS: 'Linux'

    Pending time: 0:06:16.529029

    Shard duration: 0:06:35.771369
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
29. ( 8 secs ) vm tests_shard_4

    Run on OS: 'Linux'

    Pending time: 0:06:32.779871

    Shard duration: 0:07:06.364442
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
30. ( 13 secs ) vm tests_shard_5

    Run on OS: 'Linux'

    Pending time: 0:07:09.685338

    Shard duration: 0:06:43.249324
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
31. ( 1 secs ) vm tests_shard_6

    Run on OS: 'Linux'

    Pending time: 0:07:20.612009

    Shard duration: 0:04:00.128891
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
32. ( 1 secs ) vm tests_shard_7

    Run on OS: 'Linux'

    Pending time: 0:07:36.438637

    Shard duration: 0:04:40.545589
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
33. ( 1 secs ) vm tests_shard_8

    Run on OS: 'Linux'

    Pending time: 0:07:43.083597

    Shard duration: 0:05:50.831995
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
34. ( 1 secs ) vm tests_shard_9

    Run on OS: 'Linux'

    Pending time: 0:07:55.255166

    Shard duration: 0:04:06.049100
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
35. ( 5 secs ) download previous results
    • - no logs -
    1. ( 444 ms ) ensure LATEST dir
       • stdout
    2. ( 442 ms ) ensure results.json exists
       • stdout
    3. ( 447 ms ) ensure flaky.json exists
       • stdout
    4. ( 452 ms ) ensure approved_results.json exists
       • stdout
    5. ( 2 secs ) gsutil download previous results
       • stdout
    6. ( 1 secs ) gsutil download approved results
       • stdout
36. ( 670 ms ) list tests to deflake (vm tests)
    • stdout
37. ( 1 secs ) deflake vm tests
    • stdout
    • results.json
    • run.json
    • logs.json
38. ( 566 ms ) update flakiness information
    • stdout
    • raw_io.output_text[flaky.json]
39. ( 687 ms ) find tests that began failing
    • stdout
40. ( 758 ms ) find tests that began failing (logs)
    • stdout
41. ( 736 ms ) find tests that began passing
    • stdout
42. ( 722 ms ) find unapproved failing tests
    • stdout
    • raw_io.output_text
43. ( 737 ms ) find unapproved failing tests (logs)
    • stdout
    • raw_io.output_text
44. ( 678 ms ) find unapproved passing tests
    • stdout
    • raw_io.output_text
45. ( 967 ms ) test results
    • stdout
    • unapproved failing tests
    • unapproved failing tests (logs)
    • unapproved passing tests
    • results.json
46. ( 14 secs ) upload new results
    • - no logs -
    1. ( 1 secs ) gsutil upload revision
       • stdout
       • gsutil.upload
    2. ( 1 secs ) gsutil upload logs.json
       • stdout
       • gsutil.upload
    3. ( 1 secs ) gsutil upload results.json
       • stdout
       • gsutil.upload
    4. ( 1 secs ) gsutil upload flaky.json
       • stdout
       • gsutil.upload
    5. ( 1 secs ) gsutil upload flaky_current_vm-kernel-reload-linux-debug-x64.json
       • stdout
       • gsutil.upload
    6. ( 1 secs ) gsutil upload
       • stdout
       • gsutil.upload
    7. ( 1 secs ) gsutil upload runs.json
       • stdout
       • gsutil.upload
    8. ( 1 secs ) gsutil update "latest" reference
       • stdout
       • gsutil.upload
    9. ( 473 ms ) ensure_installed
       • stdout
       • json.output
    10. ( 2 secs ) upload test results to big query
        • - no logs -
        1. ( 406 ms ) upload results chunk to big query
           • stdout
        2. ( 312 ms ) upload results chunk to big query (2)
           • stdout
        3. ( 333 ms ) upload results chunk to big query (3)
           • stdout
        4. ( 265 ms ) upload results chunk to big query (4)
           • stdout
        5. ( 342 ms ) upload results chunk to big query (5)
           • stdout
        6. ( 322 ms ) upload results chunk to big query (6)
           • stdout
        7. ( 182 ms ) upload results chunk to big query (7)
           • stdout
47. ( 503 ms ) kill processes (3)
    • stdout
48. ( 7 ms ) debug log
    • stdout
49. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"trusty-dart-68765ebb-us-central1-b-95vk"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.dart.ci.sandbox", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547487064018724, "id": "8924335920318373968", "project": "dart", "tags": ["builder:vm-kernel-reload-linux-debug-x64", "buildset:commit/git/f5c69070afc86d17b76dc460b65af17ac943c018", "buildset:commit/gitiles/dart.googlesource.com/sdk/+/f5c69070afc86d17b76dc460b65af17ac943c018", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089765983544639472", "scheduler_job_id:dart/vm-kernel-reload-linux-debug-x64", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"vm-kernel-reload-linux-debug-x64"	setup_build
buildnumber	2656	setup_build
clobber	"true"	setup_build
mastername	"client.dart"	setup_build
path_config	"generic"	setup_build
recipe	"dart/neo"	setup_build
repository	"https://dart.googlesource.com/sdk/"	setup_build
revision	"f5c69070afc86d17b76dc460b65af17ac943c018"	setup_build
got_revision	"f5c69070afc86d17b76dc460b65af17ac943c018"	bot_update

Blamelist:

1. Danny Tuppeny (dantupohnoyoudont@google.com)

Timing:

Create	Monday, 14-Jan-19 17:31:04 UTC
Start	Monday, 14-Jan-19 17:31:10 UTC
End	Monday, 14-Jan-19 17:49:39 UTC
Pending	6 secs
Execution	18 mins 28 secs

All Changes:

1. Minor LSP refactors/tidy up

   Changed by	Danny Tuppeny - dantupohnoyoudont@google.com
   Changed at	Monday, 14-Jan-19 17:30:45 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	f5c69070afc86d17b76dc460b65af17ac943c018

   Comments

   Minor LSP refactors/tidy up
   
   Change-Id: I7402d9493c58b1e020655a3b6332edbb5425fc22
   Reviewed-on: https://dart-review.googlesource.com/c/89360
   Commit-Queue: Danny Tuppeny <dantup@google.com>
   Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
   Auto-Submit: Danny Tuppeny <dantup@google.com>
   Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
   

   Changed files

   • pkg/analysis_server/lib/src/lsp/handlers/handler_code_actions.dart
   • pkg/analysis_server/lib/src/lsp/mapping.dart
   • pkg/analysis_server/test/lsp/code_actions_fixes_test.dart
   • pkg/analysis_server/test/lsp/code_actions_source_test.dart
   • pkg/analysis_server/test/lsp/server_abstract.dart