Builder vm-kernel-precomp-win-release-simarm64-dev Build 18

Overview

Results:

Failure vm tests_shard_5 on Windows

Trigger Info:

Project	dart
Revision	bcac0033a2e77bcf6c858c768cf158f0ce74f3c5
Got Revision	bcac0033a2e77bcf6c858c768cf158f0ce74f3c5

Execution:

Source: Task 41bc4729b1383c10
Bot: win10-dart-fedce810-us-central1-c-bc98
Recipe: dart/neo

Steps and Logfiles:

Show: Expanded Default Non-Green

( 381 ms ) setup_build
running recipe: "dart/neo"
- stdout
- run_recipe
( 8 secs ) gsutil find latest build
- stdout
- raw_io.output_text[latest]
( 7 secs ) gsutil get revision for latest build
- stdout
( 188 ms ) ensure_goma
- - no logs -
1. ( 188 ms ) ensure_installed
  - stdout
  - json.output
( 1 mins 13 secs ) bot_update
[29GB/299GB used (9%)]
- stdout
- json.output
( 1 secs ) clobber
- stdout
( 1 mins 38 secs ) gclient runhooks
- stdout
( 1 secs ) kill processes
- stdout
( 361 ms ) read test-matrix.json
- stdout
- json.output
( 423 ms ) delete debug log
- stdout
( 454 ms ) write fileset analyzer_unit_tests to sdk root
- stdout
( 418 ms ) write fileset dart2js to sdk root
- stdout
( 420 ms ) write fileset dart2js_hostasserts to sdk root
- stdout
( 420 ms ) write fileset fuzzer to sdk root
- stdout
( 415 ms ) write fileset vm-kernel to sdk root
- stdout
( 426 ms ) gclient get checked-in SDK version
- stdout
- raw_io.output_text
( 204 ms ) git show
- stdout
( 1 secs ) kill processes (2)
- stdout
( 5 secs ) preprocess_for_goma
- - no logs -
1. ( 406 ms ) goma cache directory
  - stdout
2. ( 3 secs ) start_goma
  - stdout
  - cloudtail
3. ( 2 secs ) start cloudtail
  - stdout
( 1 mins 56 secs ) build dart
- stdout
( 22 secs ) postprocess_for_goma
- - no logs -
1. ( 751 ms ) goma_jsonstatus
  - stdout
  - json.output
2. ( 654 ms ) goma_stat
  - stdout
3. ( 634 ms ) stop_goma
  - stdout
4. ( 9 secs ) upload_log
5. ( 10 secs ) stop cloudtail
  - stdout
( 1 mins 59 secs ) upload testing fileset vm-kernel
swarming fileset hash: 65f4cae7d3a1d3ce763d0837ce62c5f8e15b895d
- stdout
( 13 secs ) trigger shards for vm tests
- - no logs -
1. ( 1 secs ) [trigger] vm tests_shard_1 on Windows
  Run on OS: 'Windows'
2. ( 1 secs ) [trigger] vm tests_shard_2 on Windows
  Run on OS: 'Windows'
3. ( 2 secs ) [trigger] vm tests_shard_3 on Windows
  Run on OS: 'Windows'
4. ( 1 secs ) [trigger] vm tests_shard_4 on Windows
  Run on OS: 'Windows'
5. ( 1 secs ) [trigger] vm tests_shard_5 on Windows
  Run on OS: 'Windows'
6. ( 1 secs ) [trigger] vm tests_shard_6 on Windows
  Run on OS: 'Windows'
7. ( 1 secs ) [trigger] vm tests_shard_7 on Windows
  Run on OS: 'Windows'
8. ( 1 secs ) [trigger] vm tests_shard_8 on Windows
  Run on OS: 'Windows'
9. ( 1 secs ) [trigger] vm tests_shard_9 on Windows
  Run on OS: 'Windows'
( 6 mins 32 secs ) vm tests_shard_10
- stdout
- results.json
- run.json
- logs.json
( 37 mins 12 secs ) vm tests_shard_1 on Windows
Run on OS: 'Windows'
Pending time: 0:21:59.670862
Shard duration: 0:21:45.360557
- stdout
- json.output
- swarming.summary
- Merge script log
- logs.json
- run.json
- results.json
- shard #0 isolated out
( 2 secs ) vm tests_shard_2 on Windows
Run on OS: 'Windows'
Pending time: 0:22:11.331166
Shard duration: 0:11:34.492786
- stdout
- json.output
- swarming.summary
- Merge script log
- logs.json
- run.json
- results.json
- shard #0 isolated out
( 2 secs ) vm tests_shard_3 on Windows
Run on OS: 'Windows'
Pending time: 0:23:04.672139
Shard duration: 0:10:54.576302
- stdout
- json.output
- swarming.summary
- Merge script log
- logs.json
- run.json
- results.json
- shard #0 isolated out
( 2 secs ) vm tests_shard_4 on Windows
Run on OS: 'Windows'
Pending time: 0:23:47.373506
Shard duration: 0:18:27.186290
- stdout
- json.output
- swarming.summary
- Merge script log
- logs.json
- run.json
- results.json
- shard #0 isolated out
( 5 mins 23 secs ) vm tests_shard_5 on Windows
Run on OS: 'Windows'
Pending time: 0:24:22.653105
Shard duration: 0:24:48.585451
- stdout
- json.output
- swarming.summary
- Merge script log
- logs.json
- run.json
- results.json
- shard #0 isolated out
( 1 secs ) vm tests_shard_6 on Windows
Run on OS: 'Windows'
Pending time: 0:24:35.717033
Shard duration: 0:18:18.970467
- stdout
- json.output
- swarming.summary
- Merge script log
- logs.json
- run.json
- results.json
- shard #0 isolated out
( 1 secs ) vm tests_shard_7 on Windows
Run on OS: 'Windows'
Pending time: 0:24:44.255139
Shard duration: 0:09:14.757313
- stdout
- json.output
- swarming.summary
- Merge script log
- logs.json
- run.json
- results.json
- shard #0 isolated out
( 1 secs ) vm tests_shard_8 on Windows
Run on OS: 'Windows'
Pending time: 0:25:41.678059
Shard duration: 0:15:27.327426
- stdout
- json.output
- swarming.summary
- Merge script log
- logs.json
- run.json
- results.json
- shard #0 isolated out
( 1 secs ) vm tests_shard_9 on Windows
Run on OS: 'Windows'
Pending time: 0:26:20.112357
Shard duration: 0:09:38.818853
- stdout
- json.output
- swarming.summary
- Merge script log
- logs.json
- run.json
- results.json
- shard #0 isolated out
( 12 secs ) download previous results
- - no logs -
1. ( 428 ms ) ensure LATEST dir
  - stdout
2. ( 458 ms ) ensure results.json exists
  - stdout
3. ( 417 ms ) ensure flaky.json exists
  - stdout
4. ( 427 ms ) ensure approved_results.json exists
  - stdout
5. ( 2 secs ) gsutil download previous results
  - stdout
6. ( 7 secs ) gsutil download approved results
  - stdout
( 1 secs ) list tests to deflake (vm tests)
- stdout
- raw_io.output_text
( 3 secs ) deflake vm tests
- stdout
- results.json
- run.json
- logs.json
( 1 secs ) update flakiness information
- stdout
( 1 secs ) find tests that began failing
- stdout
- raw_io.output_text
( 1 secs ) find tests that began failing (logs)
- stdout
- raw_io.output_text
( 1 secs ) find tests that began passing
- stdout
- raw_io.output_text
( 1 secs ) find unapproved failing tests
- stdout
- raw_io.output_text
( 1 secs ) find unapproved failing tests (logs)
- stdout
- raw_io.output_text
( 1 secs ) find unapproved passing tests
- stdout
- raw_io.output_text
( 2 secs ) test results
- stdout
- tests that began failing
- tests that began failing (logs)
- tests that began passing
- unapproved failing tests
- unapproved failing tests (logs)
- unapproved passing tests
- results.json
( 19 secs ) upload new results
- - no logs -
1. ( 2 secs ) gsutil upload revision
  - stdout
  - gsutil.upload
2. ( 2 secs ) gsutil upload logs.json
  - stdout
  - gsutil.upload
3. ( 2 secs ) gsutil upload results.json
  - stdout
  - gsutil.upload
4. ( 2 secs ) gsutil upload flaky.json
  - stdout
  - gsutil.upload
5. ( 2 secs ) gsutil upload
  - stdout
  - gsutil.upload
6. ( 2 secs ) gsutil upload runs.json
  - stdout
  - gsutil.upload
7. ( 2 secs ) gsutil update "latest" reference
  - stdout
  - gsutil.upload
8. ( 625 ms ) ensure_installed
  - stdout
  - json.output
9. ( 3 secs ) upload test results to big query
  - - no logs -
  1. ( 732 ms ) upload results chunk to big query
    - stdout
  2. ( 312 ms ) upload results chunk to big query (2)
    - stdout
  3. ( 309 ms ) upload results chunk to big query (3)
    - stdout
  4. ( 359 ms ) upload results chunk to big query (4)
    - stdout
  5. ( 340 ms ) upload results chunk to big query (5)
    - stdout
  6. ( 295 ms ) upload results chunk to big query (6)
    - stdout
  7. ( 310 ms ) upload results chunk to big query (7)
    - stdout
  8. ( 327 ms ) upload results chunk to big query (8)
    - stdout
  9. ( 232 ms ) upload results chunk to big query (9)
    - stdout
( 1 secs ) kill processes (3)
- stdout
( 11 ms ) debug log
- stdout
( 0 ) Failure reason
- reason

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "C:\\b\\s\\w\\ir\\cache", "temp_dir": "C:\\b\\s\\w\\ir\\tmp\\rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"win10-dart-fedce810-us-central1-c-bc98"	setup_build
branch	"refs/heads/dev"	setup_build
buildbucket	{"build": {"bucket": "luci.dart.ci.sandbox", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544635654150240, "id": "8927325840271946224", "project": "dart", "tags": ["builder:vm-kernel-precomp-win-release-simarm64-dev", "buildset:commit/git/bcac0033a2e77bcf6c858c768cf158f0ce74f3c5", "buildset:commit/gitiles/dart.googlesource.com/sdk/+/bcac0033a2e77bcf6c858c768cf158f0ce74f3c5", "gitiles_ref:refs/heads/dev", "scheduler_invocation_id:9092755902963574000", "scheduler_job_id:dart/vm-kernel-precomp-win-release-simarm64-dev", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"vm-kernel-precomp-win-release-simarm64-dev"	setup_build
buildnumber	18	setup_build
clobber	"true"	setup_build
mastername	"client.dart"	setup_build
path_config	"generic"	setup_build
recipe	"dart/neo"	setup_build
repository	"https://dart.googlesource.com/sdk/"	setup_build
revision	"bcac0033a2e77bcf6c858c768cf158f0ce74f3c5"	setup_build
got_revision	"bcac0033a2e77bcf6c858c768cf158f0ce74f3c5"	bot_update

Blamelist:

Alexander Thomas (athomohnoyoudont@google.com)
Sigmund Cherem (sigmundohnoyoudont@google.com)
Jonas Termansen (sortieohnoyoudont@google.com)
William Hesse (whesseohnoyoudont@google.com)
Lasse Reichstein Holst Nielsen (lrnohnoyoudont@google.com)
Daco Harkes (dacoharkesohnoyoudont@google.com)
Lasse Reichstein Holst Nielsen (lrnohnoyoudont@google.com)
Jonas Termansen (sortieohnoyoudont@google.com)
Lasse Reichstein Holst Nielsen (lrnohnoyoudont@google.com)
Erik Ernst (eernstohnoyoudont@google.com)
Peter von der Ahé (aheohnoyoudont@google.com)
Peter von der Ahé (aheohnoyoudont@google.com)
Peter von der Ahé (aheohnoyoudont@google.com)
Alexander Markov (alexmarkovohnoyoudont@google.com)
Bob Nystrom (rnystromohnoyoudont@google.com)
Samir Jindel (sjindelohnoyoudont@google.com)
Samir Jindel (sjindelohnoyoudont@google.com)
Alexander Markov (alexmarkovohnoyoudont@google.com)
Aart Bik (ajcbikohnoyoudont@google.com)
Ryan Macnak (rmacnakohnoyoudont@google.com)
Alexander Aprelev (aamohnoyoudont@google.com)
Martin Kustermann (kustermannohnoyoudont@google.com)
Stevie Strickland (sstricklohnoyoudont@google.com)
Paul Berry (paulberryohnoyoudont@google.com)
Lasse R.H. Nielsen (lrnohnoyoudont@google.com)
Peter von der Ahé (aheohnoyoudont@google.com)
Peter von der Ahé (aheohnoyoudont@google.com)
Peter von der Ahé (aheohnoyoudont@google.com)
Peter von der Ahé (aheohnoyoudont@google.com)
Peter von der Ahé (aheohnoyoudont@google.com)
William Hesse (whesseohnoyoudont@google.com)
Peter von der Ahé (aheohnoyoudont@google.com)
Paul Berry (paulberryohnoyoudont@google.com)
Alexander Aprelev (aamohnoyoudont@google.com)
Samir Jindel (sjindelohnoyoudont@google.com)
Jonas Termansen (sortieohnoyoudont@google.com)
Jacob MacDonald (jakemacohnoyoudont@google.com)
danrubel (danrubelohnoyoudont@google.com)
Jens Johansen (jensjohnoyoudont@google.com)
Daco Harkes (dacoharkesohnoyoudont@google.com)
Jens Johansen (jensjohnoyoudont@google.com)
Jens Johansen (jensjohnoyoudont@google.com)
Jens Johansen (jensjohnoyoudont@google.com)
Aske Simon Christensen (askescohnoyoudont@google.com)
Aske Simon Christensen (askescohnoyoudont@google.com)
Jens Johansen (jensjohnoyoudont@google.com)
Vyacheslav Egorov (vegorovohnoyoudont@google.com)
Daco Harkes (dacoharkesohnoyoudont@google.com)
Aske Simon Christensen (askescohnoyoudont@google.com)
Jens Johansen (jensjohnoyoudont@google.com)
Martin Kustermann (kustermannohnoyoudont@google.com)
Johnni Winther (johnniwintherohnoyoudont@google.com)
Lasse Reichstein Holst Nielsen (lrnohnoyoudont@google.com)
Jens Johansen (jensjohnoyoudont@google.com)
Ryan Macnak (rmacnakohnoyoudont@google.com)
Kevin Moore (kevmooohnoyoudont@google.com)
Kevin Moore (kevmooohnoyoudont@google.com)
Ryan Macnak (rmacnakohnoyoudont@google.com)
Ryan Macnak (rmacnakohnoyoudont@google.com)
Ryan Macnak (rmacnakohnoyoudont@google.com)
Sigmund Cherem (sigmundohnoyoudont@google.com)
Paul Berry (paulberryohnoyoudont@google.com)
Zach Anderson (zraohnoyoudont@google.com)
Aske Simon Christensen (askescohnoyoudont@google.com)
Aske Simon Christensen (askescohnoyoudont@google.com)
Aske Simon Christensen (askescohnoyoudont@google.com)
Aske Simon Christensen (askescohnoyoudont@google.com)
Aske Simon Christensen (askescohnoyoudont@google.com)
Aske Simon Christensen (askescohnoyoudont@google.com)
Aske Simon Christensen (askescohnoyoudont@google.com)
Aske Simon Christensen (askescohnoyoudont@google.com)
Martin Kustermann (kustermannohnoyoudont@google.com)
Martin Kustermann (kustermannohnoyoudont@google.com)
Jens Johansen (jensjohnoyoudont@google.com)
Jens Johansen (jensjohnoyoudont@google.com)
Johnni Winther (johnniwintherohnoyoudont@google.com)
Kevin Moore (kevmooohnoyoudont@google.com)
Aart Bik (ajcbikohnoyoudont@google.com)
Aart Bik (ajcbikohnoyoudont@google.com)
Paul Berry (paulberryohnoyoudont@google.com)
Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
danrubel (danrubelohnoyoudont@google.com)
Ryan Macnak (rmacnakohnoyoudont@google.com)
Sigmund Cherem (sigmundohnoyoudont@google.com)
Martin Kustermann (kustermannohnoyoudont@google.com)
Jens Johansen (jensjohnoyoudont@google.com)
Jonas Termansen (sortieohnoyoudont@google.com)
William Hesse (whesseohnoyoudont@google.com)
Jens Johansen (jensjohnoyoudont@google.com)
Jens Johansen (jensjohnoyoudont@google.com)
Jens Johansen (jensjohnoyoudont@google.com)
Martin Kustermann (kustermannohnoyoudont@google.com)
Martin Kustermann (kustermannohnoyoudont@google.com)
Martin Kustermann (kustermannohnoyoudont@google.com)
Nate Bosch (nboschohnoyoudont@google.com)
Régis Crelier (regisohnoyoudont@google.com)
pq (pquitslundohnoyoudont@google.com)
Zach Anderson (zraohnoyoudont@google.com)
Zach Anderson (zraohnoyoudont@google.com)
Konstantin Shcheglov (scheglovohnoyoudont@google.com)
<blame list capped at 100 commits> ()

Timing:

Create	Wednesday, 12-Dec-18 17:27:34 UTC
Start	Wednesday, 12-Dec-18 17:38:46 UTC
End	Wednesday, 12-Dec-18 18:38:38 UTC
Pending	11 mins 12 secs
Execution	59 mins 51 secs

All Changes:

Version 2.2.0-dev.1.0

Changed by	Alexander Thomas - athomohnoyoudont@google.com
Changed at	Wednesday, 12-Dec-18 17:04:10 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	bcac0033a2e77bcf6c858c768cf158f0ce74f3c5

Comments

Version 2.2.0-dev.1.0

Merge commit '01da85ce7cd9c17fe27530c46534f844c74ac69a' into dev

Add flag to emit kernel immediately after invoking the CFE

Changed by	Sigmund Cherem - sigmundohnoyoudont@google.com
Changed at	Tuesday, 04-Dec-18 16:55:57 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	01da85ce7cd9c17fe27530c46534f844c74ac69a

Comments

Add flag to emit kernel immediately after invoking the CFE

This will be used initially to create the 3-way split in the compiler. Later
this will:
- include our transformation for super mixin calls
- remove the need to emit the .dill after global analysis
- eventually get replaced by a modular step that only builds a portion of the
.dill file.

Change-Id: Iebf2bd6d023716f04dc542ae9b2a85919159c4c0
Reviewed-on: https://dart-review.googlesource.com/c/85840
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>

Changed files

pkg/compiler/lib/src/commandline_options.dart
pkg/compiler/lib/src/compiler.dart
pkg/compiler/lib/src/dart2js.dart
pkg/compiler/lib/src/kernel/loader.dart
pkg/compiler/lib/src/options.dart
pkg/compiler/lib/src/serialization/strategies.dart
pkg/compiler/lib/src/serialization/task.dart
pkg/compiler/lib/src/util/sink_adapter.dart

[infra] Add support for logs to tools/test.dart.

Changed by	Jonas Termansen - sortieohnoyoudont@google.com
Changed at	Tuesday, 04-Dec-18 16:07:56 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	191a09f540ac0516c4088fb8454c693743be8b3f

Comments

[infra] Add support for logs to tools/test.dart.

Bug: https://github.com/dart-lang/sdk/issues/35307
Change-Id: I770199da3bed89d41017d806d289195b22377b4f
Reviewed-on: https://dart-review.googlesource.com/c/85741
Reviewed-by: William Hesse <whesse@google.com>

Changed files

tools/test.dart

Add --logs parameter to compare_results.dart, and output logs

Changed by	William Hesse - whesseohnoyoudont@google.com
Changed at	Tuesday, 04-Dec-18 16:07:42 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	b35aebde1cdc6335841f9e0527582b491d77c000

Comments

Add --logs parameter to compare_results.dart, and output logs

The logs of tests that start failing will be output at the end of stdout.

Change-Id: I93a85c983be278e93aaf7d7447438667c54b5185
Reviewed-on: https://dart-review.googlesource.com/c/85500
Reviewed-by: Jonas Termansen <sortie@google.com>

Changed files

tools/bots/compare_results.dart
tools/bots/results.dart

Update status file for yet another combination.

Changed by	Lasse Reichstein Holst Nielsen - lrnohnoyoudont@google.com
Changed at	Tuesday, 04-Dec-18 15:54:00 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	3000e9302443280c221fd9285a89f54b23e5617f

Comments

Update status file for yet another combination.

Change-Id: Ic5be67964e9179205cf7352a61e1e98df7778dd7
Reviewed-on: https://dart-review.googlesource.com/c/85951
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>

Changed files

tests/language_2/language_2_precompiled.status

[gardening] Mark LibTest/collection/ListMixin/ListMixin_class_A01_t02 as ExtraSlow

Changed by	Daco Harkes - dacoharkesohnoyoudont@google.com
Changed at	Tuesday, 04-Dec-18 15:12:20 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	f6852fa9c8d24e5bcea1bf70ab0842d176c6bca5

Comments

[gardening] Mark LibTest/collection/ListMixin/ListMixin_class_A01_t02 as ExtraSlow

Issue https://github.com/dart-lang/sdk/issues/35316

Change-Id: Iac3c038f9f447e52dd420ad1158cdf153aa99f3e
Reviewed-on: https://dart-review.googlesource.com/c/85943
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>

Changed files

tests/co19_2/co19_2-kernel.status

Add more tests for async*/await-for operations.

Changed by	Lasse Reichstein Holst Nielsen - lrnohnoyoudont@google.com
Changed at	Tuesday, 04-Dec-18 13:58:03 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	a0d576e6cdeab5889f2e8dda6268a5fb8aab0b53

Comments

Add more tests for async*/await-for operations.

Change-Id: I2c8ffb8a6738b8dee43cfdf85be0c54d2735b6cc
Reviewed-on: https://dart-review.googlesource.com/c/85391
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>

Changed files

tests/language_2/async_star/async_star_await_for_test.dart
tests/language_2/async_star/async_star_cancel_test.dart
tests/language_2/async_star/async_star_invalid_test.dart
tests/language_2/async_star/async_star_test.dart
tests/language_2/language_2_dart2js.status
tests/language_2/language_2_dartdevc.status
tests/language_2/language_2_kernel.status
tests/language_2/language_2_precompiled.status
tests/language_2/language_2_vm.status

[infra] Implement 3-way comparison with approved_results in compare_results.

Changed by	Jonas Termansen - sortieohnoyoudont@google.com
Changed at	Tuesday, 04-Dec-18 13:46:59 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	52183f2afa2874c2e7b57ef65362bd8c73b5b00f

Comments

[infra] Implement 3-way comparison with approved_results in compare_results.

Bug: https://github.com/dart-lang/sdk/issues/35298
Change-Id: Ie5bd1101cae8eddd65ad5aa53c8f2d97c6548b2b
Reviewed-on: https://dart-review.googlesource.com/c/85702
Reviewed-by: William Hesse <whesse@google.com>

Changed files

tools/bots/compare_results.dart

Update constant set literal tests.

Changed by	Lasse Reichstein Holst Nielsen - lrnohnoyoudont@google.com
Changed at	Tuesday, 04-Dec-18 12:34:50 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	897f15d95500c871487b4704fd1061973db188e9

Comments

Update constant set literal tests.

Fix incorrect type variable tests and don't allow multiple equal elements.

Change-Id: I793d8ac20c3435f5e2a2db8cb9137057e4ba6a17
Reviewed-on: https://dart-review.googlesource.com/c/85920
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>

Changed files

tests/language_2/set_literals/const_set_literal_test.dart

Integrated subtyping.md into dartLangSpec.tex

Changed by	Erik Ernst - eernstohnoyoudont@google.com
Changed at	Tuesday, 04-Dec-18 10:23:30 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	00cec998f5ebde1dc9787663b3d6b04e83371d39

Comments

Integrated subtyping.md into dartLangSpec.tex

Change-Id: Ie0beb59e83f14f0786ea91e0039b96d3d8cd2968
Reviewed-on: https://dart-review.googlesource.com/c/84027
Reviewed-by: Leaf Petersen <leafp@google.com>

Changed files

docs/language/dart.sty
docs/language/dartLangSpec.tex

Make constructors private

Changed by	Peter von der Ahé - aheohnoyoudont@google.com
Changed at	Tuesday, 04-Dec-18 09:11:02 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	e7a048d12e64e7ab4ccb08d82f9ce9f0246698eb

Comments

Make constructors private

Change-Id: Idf2775e07aca1db9e3fa856723e658306f51df37
Reviewed-on: https://dart-review.googlesource.com/c/85762
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>

Changed files

pkg/front_end/lib/src/fasta/kernel/body_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_ast_api.dart
pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator_impl.dart
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

Wrap various synthetic kernel nodes

Changed by	Peter von der Ahé - aheohnoyoudont@google.com
Changed at	Tuesday, 04-Dec-18 08:47:47 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	7ba67a0a7465d9510f6bdd9d807f8baf5394a781

Comments

Wrap various synthetic kernel nodes

Change-Id: I51172dee3fc6f19166bab22f5aabf83a13864e31
Reviewed-on: https://dart-review.googlesource.com/c/85742
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>

Changed files

pkg/front_end/lib/src/fasta/kernel/body_builder.dart
pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
pkg/front_end/lib/src/fasta/kernel/expression_generator_helper.dart
pkg/front_end/lib/src/fasta/kernel/kernel_ast_api.dart
pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator_impl.dart

Use helper methods to handle SyntheticExpressionJudgment

Changed by	Peter von der Ahé - aheohnoyoudont@google.com
Changed at	Tuesday, 04-Dec-18 08:16:48 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	e3793d866187134a0dffd6302009205ed7155ba2

Comments

Use helper methods to handle SyntheticExpressionJudgment

Change-Id: If4f0deef1e0aea630257d6c35c5e771db65ba474
Reviewed-on: https://dart-review.googlesource.com/c/85761
Commit-Queue: Peter von der Ahé <ahe@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

Changed files

pkg/front_end/lib/src/fasta/kernel/body_builder.dart
pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
pkg/front_end/lib/src/fasta/kernel/expression_generator_helper.dart
pkg/front_end/lib/src/fasta/kernel/inference_visitor.dart
pkg/front_end/lib/src/fasta/kernel/kernel_ast_api.dart
pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator_impl.dart
pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
pkg/front_end/lib/src/fasta/type_inference/inference_helper.dart
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
pkg/front_end/testcases/rasta/issue_000042.dart.strong.expect
pkg/front_end/testcases/rasta/issue_000042.dart.strong.transformed.expect
pkg/front_end/testcases/rasta/unresolved_for_in.dart.legacy.expect
pkg/front_end/testcases/rasta/unresolved_for_in.dart.legacy.transformed.expect

[vm/kernel] Move functionality of Fuchsia's compiler.dart into pkg/vm

Changed by	Alexander Markov - alexmarkovohnoyoudont@google.com
Changed at	Tuesday, 04-Dec-18 01:08:03 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	170d5578c716028c23081ea0aced4e84c5e424dd

Comments

[vm/kernel] Move functionality of Fuchsia's compiler.dart into pkg/vm

This includes:
* Selecting front-end target.
* Support for multi-root virtual file system.
* Not linking platform into resulting kernel file.
* Specifying input as URI (instead of file path) on command line.
* Automatically converting input script URI to package URI.
* Writing ninja dependencies file.
* Writing package-split kernel binaries.

After this change Fuchsia's compiler.dart will become a small wrapper
over pkg/vm, sharing most logic and even most command line options
with pkg/vm gen_kernel tool.

Also, this CL attempts to share some pieces of code between frontend
server and gen_kernel.

In addition, seperate bytecode generation for package-split binaries
is implemented (needed for https://dart-review.googlesource.com/c/sdk/+/85469).

Corresponding Fuchsia CL: https://fuchsia-review.googlesource.com/c/topaz/+/229964

Change-Id: I12d7b2f6401357b3c9df2e31bc736af5a9dc5fd2
Reviewed-on: https://dart-review.googlesource.com/c/85721
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>

Changed files

pkg/vm/bin/gen_kernel.dart
pkg/vm/lib/bytecode/gen_bytecode.dart
pkg/vm/lib/frontend_server.dart
pkg/vm/lib/kernel_front_end.dart
tools/bots/test_matrix.json

Bring in the latest dart_style.

Changed by	Bob Nystrom - rnystromohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 22:47:12 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	f9ed759843e1112b8b0dee93a5409ff7cd731099

Comments

Bring in the latest dart_style.

There are no formatting changes, so this is safe to do without also
updating the pre-built SDK.

Change-Id: I78c961acc181bb8d4456dc49fecf485d33a93582
Reviewed-on: https://dart-review.googlesource.com/c/85820
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>

Changed files

DEPS

Add KPI::bytecode_component_ to raw_object_fields.cc

Changed by	Samir Jindel - sjindelohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 19:59:07 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	5ad8bf78e25810682c9ebf3b9375b95278097ace

Comments

Add KPI::bytecode_component_ to raw_object_fields.cc

Change-Id: I4db32b38291d5494d9c5acf80aca295c3a90f9b6
Reviewed-on: https://dart-review.googlesource.com/c/85772
Reviewed-by: Samir Jindel <sjindel@google.com>

Changed files

runtime/vm/raw_object_fields.cc

Re-land "[vm/aot] Fill in names of properties in snapshot profile."

Changed by	Samir Jindel - sjindelohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 19:11:42 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	96dda6a516ddec75e758449aad1815e592d601de

Comments

Re-land "[vm/aot] Fill in names of properties in snapshot profile."

This reverts commit dc346e6fdd89663388f8ae4e6767d6ece597c278.

Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-mac-release-simarm64-try, vm-kernel-precomp-win-release-x64-try
Change-Id: I1b9181683757cf47f917274d21c8fc1c463218c7
Reviewed-on: https://dart-review.googlesource.com/c/85709
Commit-Queue: Samir Jindel <sjindel@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

Changed files

runtime/tests/vm/dart/v8_snapshot_profile_writer_test.dart
runtime/vm/clustered_snapshot.cc
runtime/vm/clustered_snapshot.h
runtime/vm/image_snapshot.cc
runtime/vm/image_snapshot.h
runtime/vm/raw_object.h
runtime/vm/raw_object_fields.cc
runtime/vm/raw_object_fields.h
runtime/vm/v8_snapshot_writer.cc
runtime/vm/v8_snapshot_writer.h
runtime/vm/vm_sources.gni

[vm/bytecode] Revise representation of objects and strings in bytecode

Changed by	Alexander Markov - alexmarkovohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 19:08:42 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	9f49b47823b99d01214f96917d6352c0a560fccb

Comments

[vm/bytecode] Revise representation of objects and strings in bytecode

This is a major revamp of bytecode metadata format. Now bytecode has
its own serialization mechanisms.

This CL adds 'bytecode component' metadata, which contains bytecode
object table and string table. All references from bytecode (constant
pools) to libraries, classes, members, types and strings now have a new
format. References to frequently used objects are represented as indices
in object table, while rarely used objects are written inline.
This allows VM to cache frequently used objects while reading bytecode.

Representation of strings is aligned with VM - string characters are
stored in separate pools of one-byte and two-byte strings. This allows
VM to avoid UTF-8 decoding and extra copying.

Closure declarations are now explicit. Type parameters no longer require
enslosing scopes when reading/writing them.

Benchmarks:
GenKernelKernelReadAllBytecode (Intel Core i5) +29.84%
GenKernelKernelReadAllBytecode (Intel Xeon) +28.74%
Change-Id: I4b80009733a8f8c038264af74f97c4e094b9e311
Reviewed-on: https://dart-review.googlesource.com/c/85469
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Zach Anderson <zra@google.com>

Changed files

pkg/kernel/lib/binary/ast_from_binary.dart
pkg/kernel/lib/text/ast_to_text.dart
pkg/vm/lib/bytecode/bytecode_serialization.dart
pkg/vm/lib/bytecode/constant_pool.dart
pkg/vm/lib/bytecode/dbc.dart
pkg/vm/lib/bytecode/exceptions.dart
pkg/vm/lib/bytecode/gen_bytecode.dart
pkg/vm/lib/bytecode/object_table.dart
pkg/vm/lib/bytecode/source_positions.dart
pkg/vm/lib/metadata/bytecode.dart
pkg/vm/test/bytecode/gen_bytecode_test.dart
pkg/vm/test/common_test_utils.dart
pkg/vm/testcases/bytecode/asserts.dart.expect
pkg/vm/testcases/bytecode/async.dart.expect
pkg/vm/testcases/bytecode/bootstrapping.dart.expect
pkg/vm/testcases/bytecode/closures.dart.expect
pkg/vm/testcases/bytecode/deferred_lib.dart.expect
pkg/vm/testcases/bytecode/field_initializers.dart.expect
pkg/vm/testcases/bytecode/hello.dart.expect
pkg/vm/testcases/bytecode/instance_creation.dart.expect
pkg/vm/testcases/bytecode/literals.dart.expect
pkg/vm/testcases/bytecode/loops.dart.expect
pkg/vm/testcases/bytecode/optional_params.dart.expect
pkg/vm/testcases/bytecode/super_calls.dart.expect
pkg/vm/testcases/bytecode/switch.dart.expect
pkg/vm/testcases/bytecode/try_blocks.dart.expect
pkg/vm/testcases/bytecode/type_ops.dart.expect
runtime/vm/compiler/frontend/bytecode_reader.cc
runtime/vm/compiler/frontend/bytecode_reader.h
runtime/vm/compiler/frontend/kernel_translation_helper.cc
runtime/vm/compiler/frontend/kernel_translation_helper.h
runtime/vm/kernel_loader.cc
runtime/vm/object.cc
runtime/vm/object.h
runtime/vm/raw_object.h

[vm/compiler] Express control dependence as data dependence.

Changed by	Aart Bik - ajcbikohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 18:07:39 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	aae0f7997de4d06df22766a089bc2eb18cb24e2d

Comments

[vm/compiler] Express control dependence as data dependence.

Rationale:
This provides a more robust way of expressing control
dependences between bounds checks and their uses, while
still allowing for CSE and LICM where possible.
This also fixes the original bug that started this
whole redesign: invalid LICM of checkbound.

Note:
Deals with bounds check, null check still TBD.

Reland of:
https://dart-review.googlesource.com/c/sdk/+/85470

Mini design doc:
runtime/docs/compiler/data_dep_for_control_dep.md

https://github.com/dart-lang/sdk/issues/35139
https://github.com/dart-lang/sdk/issues/34684
https://github.com/dart-lang/sdk/issues/30633

Change-Id: I24b994344ed28c9f5fbf0ed033698be75448df1c
Reviewed-on: https://dart-review.googlesource.com/c/85720
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

Changed files

runtime/docs/compiler/data_dep_for_control_dep.md
runtime/vm/compiler/aot/aot_call_specializer.cc
runtime/vm/compiler/aot/aot_call_specializer.h
runtime/vm/compiler/backend/constant_propagator.cc
runtime/vm/compiler/backend/flow_graph.cc
runtime/vm/compiler/backend/flow_graph.h
runtime/vm/compiler/backend/il.cc
runtime/vm/compiler/backend/il.h
runtime/vm/compiler/backend/inliner.cc
runtime/vm/compiler/backend/loops.cc
runtime/vm/compiler/backend/range_analysis.cc
runtime/vm/compiler/backend/redundancy_elimination.cc
runtime/vm/compiler/compiler_pass.cc
runtime/vm/compiler/compiler_pass.h
runtime/vm/compiler/intrinsifier.cc
tests/language_2/vm/regress_34684_test.dart

[vm] Adjust concurrent marker to re-enable code W^X.

Changed by	Ryan Macnak - rmacnakohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 17:24:58 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	0b66d91cd478d92655929e1eba636bd649dbe3c2

Comments

[vm] Adjust concurrent marker to re-enable code W^X.

Bug: https://github.com/dart-lang/sdk/issues/34002
Change-Id: I53081e8a19b21804bee776ecab0779c723907008
Reviewed-on: https://dart-review.googlesource.com/c/85624
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>

Changed files

runtime/vm/code_patcher.cc
runtime/vm/heap/marker.cc
runtime/vm/heap/pages.cc

[hhh] Patch flutter so it is compatible with latest analyzer

Changed by	Alexander Aprelev - aamohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 17:10:46 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	4eeebc46cff4e47e6265e86f4774da103d060aa1

Comments

[hhh] Patch flutter so it is compatible with latest analyzer

Change-Id: I70b9cdb0609e063fa9b0ce1e4a89dac24f87fad9
Reviewed-on: https://dart-review.googlesource.com/c/85730
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>

Changed files

tools/patches/flutter-engine/f9ebf2129732fd2b606286fdf58e500384b8a0bc.flutter.patch

[infra] Make --keep-generated-files work with -n option

Changed by	Martin Kustermann - kustermannohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 15:35:40 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	2260758ffe4235b47b30540d5e358be764999ab7

Comments

[infra] Make --keep-generated-files work with -n option

Makes the --keep-generated-files flag an option for the test.py command
only, not part of a named configuration passed in with the -n flag
and defined in tools/bots/test_matrix.json.

Change-Id: If67c2848cf6fc15e4cb7167ce23eeb3eb9bd1684
Reviewed-on: https://dart-review.googlesource.com/c/85705
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: William Hesse <whesse@google.com>

Changed files

pkg/smith/lib/configuration.dart
tools/testing/dart/configuration.dart
tools/testing/dart/options.dart

Simplify control flow in ICData::FindFreeIndex.

Changed by	Stevie Strickland - sstricklohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 15:34:39 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	64718ea36920b1efd37e4f1c84c8e0d1c77bdf9a

Comments

Simplify control flow in ICData::FindFreeIndex.

Change-Id: Icb8111b7d4f202ce72c47fad4e0b3c769c41bc45
Reviewed-on: https://dart-review.googlesource.com/c/85763
Auto-Submit: Stevie Strickland <sstrickl@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>

Changed files

runtime/vm/object.cc

Prepare for a future breaking change to the UriResolver class.

Changed by	Paul Berry - paulberryohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 14:29:30 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	be529425d24e6c7c0cbf6965456da1f2a3a96adf

Comments

Prepare for a future breaking change to the UriResolver class.

See https://dart-review.googlesource.com/c/sdk/+/85726 for the
breaking change that is anticipated.

Change-Id: I4ba84a0e70bf5b3c62191c053ba9de7aee71ac93
Reviewed-on: https://dart-review.googlesource.com/c/85728
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>

Changed files

pkg/analyzer/CHANGELOG.md
pkg/analyzer/lib/src/generated/source.dart
pkg/analyzer/pubspec.yaml

Remove invalid tests from set literal tests.

Changed by	Lasse R.H. Nielsen - lrnohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 14:07:12 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	7be1d77423f0588faf14a928f26df7a239484f62

Comments

Remove invalid tests from set literal tests.

See #35300

Bug: http://dartbug.com/35300
Change-Id: I00610ce9eadc51499fc5f35d43095dbf29d07543
Reviewed-on: https://dart-review.googlesource.com/c/85740
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>

Changed files

tests/language_2/set_literals/invalid_set_literal_test.dart
tests/language_2/set_literals/set_literal_test.dart

Remove TypeInferrerDisabled

Changed by	Peter von der Ahé - aheohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 13:32:58 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	16cfb6c922f5fccfc273187888c5a6469a5a0062

Comments

Remove TypeInferrerDisabled

Change-Id: I9ff7f3723c3acb05bc2649cda47b8c516f6523d9
Reviewed-on: https://dart-review.googlesource.com/c/85760
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

Changed files

pkg/front_end/lib/src/fasta/kernel/body_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_body_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
pkg/front_end/lib/src/fasta/source/diet_listener.dart
pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart

Add BodyBuilder.legacyMode getter

Changed by	Peter von der Ahé - aheohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 13:20:27 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	f9ee5da8f8a91faef8b54c846180137ebfbf923f

Comments

Add BodyBuilder.legacyMode getter

Change-Id: Ica42e03aed4a0789811bd0d654e1ac9f9a8251c8
Reviewed-on: https://dart-review.googlesource.com/c/85712
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

Changed files

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

Clone metadata in BodyBuilder instead of type inference

Changed by	Peter von der Ahé - aheohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 13:18:08 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	cd6ecf19fa4593604119b8736406e65b071290f1

Comments

Clone metadata in BodyBuilder instead of type inference

Change-Id: Iaf1344455c45693902d89c866c93395670e56251
Reviewed-on: https://dart-review.googlesource.com/c/85711
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>

Changed files

pkg/front_end/lib/src/fasta/kernel/body_builder.dart
pkg/front_end/lib/src/fasta/kernel/inference_visitor.dart
pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

Remove prepareTopLevelInference from base builder API

Changed by	Peter von der Ahé - aheohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 12:33:21 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	4088bb1302cebbb6922e1292037bc60127f1f852

Comments

Remove prepareTopLevelInference from base builder API

Change-Id: I87fd423c30c184e4775291a0a45176cba618d8e6
Reviewed-on: https://dart-review.googlesource.com/c/85710
Auto-Submit: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

Changed files

pkg/front_end/lib/src/fasta/builder/class_builder.dart
pkg/front_end/lib/src/fasta/builder/field_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart
pkg/front_end/lib/src/fasta/source/source_class_builder.dart
pkg/front_end/lib/src/fasta/source/source_loader.dart

Use modifiers to store some flags

Changed by	Peter von der Ahé - aheohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 12:27:39 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	cc003934fcef2c58e095eb93c481a4b58879803e

Comments

Use modifiers to store some flags

Change-Id: I1848186917d5538266e4eb5d6a76e07435d2d871
Reviewed-on: https://dart-review.googlesource.com/c/85707
Commit-Queue: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

Changed files

pkg/front_end/lib/src/fasta/builder/formal_parameter_builder.dart
pkg/front_end/lib/src/fasta/builder/modifier_builder.dart
pkg/front_end/lib/src/fasta/builder/procedure_builder.dart
pkg/front_end/lib/src/fasta/kernel/body_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart
pkg/front_end/lib/src/fasta/kernel/type_algorithms.dart
pkg/front_end/lib/src/fasta/modifier.dart

Enable uploads from Dart SDK swarming builders

Changed by	William Hesse - whesseohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 11:26:30 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	7abe99943735a082ca0b78dc4325d969067f5a23

Comments

Enable uploads from Dart SDK swarming builders

Switch the Dart SDK builders to use the dart_sdk.py script to build
and upload the SDK.

Change-Id: I8d8fc41e8d90d14507d5337bd6dcc573ee09bb6a
Reviewed-on: https://dart-review.googlesource.com/c/85701
Reviewed-by: Jonas Termansen <sortie@google.com>

Changed files

tools/bots/test_matrix.json

Improve handling of duplicated declarations

Changed by	Peter von der Ahé - aheohnoyoudont@google.com
Changed at	Monday, 03-Dec-18 10:11:36 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	0fe6f76ffbcaf81ae9793a2f7caf0a531ff533e6

Comments

Improve handling of duplicated declarations

Change-Id: Ib13a14908c8c6a1fc8e78c1bf5b031317945a344
Reviewed-on: https://dart-review.googlesource.com/c/85682
Commit-Queue: Peter von der Ahé <ahe@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>

Changed files

pkg/front_end/lib/src/fasta/builder/builder.dart
pkg/front_end/lib/src/fasta/builder/library_builder.dart
pkg/front_end/lib/src/fasta/builder/name_iterator.dart
pkg/front_end/lib/src/fasta/import.dart
pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
pkg/front_end/lib/src/fasta/scope.dart
pkg/front_end/lib/src/fasta/source/diet_listener.dart
pkg/front_end/lib/src/fasta/source/source_library_builder.dart
pkg/front_end/lib/src/fasta/source/source_loader.dart
pkg/front_end/testcases/bug31124.dart.strong.expect
pkg/front_end/testcases/bug31124.dart.strong.transformed.expect
pkg/front_end/testcases/duplicated_bad_prefix.dart.legacy.expect
pkg/front_end/testcases/duplicated_bad_prefix.dart.legacy.transformed.expect
pkg/front_end/testcases/duplicated_bad_prefix.dart.outline.expect
pkg/front_end/testcases/duplicated_bad_prefix.dart.strong.expect
pkg/front_end/testcases/duplicated_bad_prefix.dart.strong.transformed.expect
pkg/front_end/testcases/duplicated_declarations.dart
pkg/front_end/testcases/duplicated_declarations.dart.legacy.expect
pkg/front_end/testcases/duplicated_declarations.dart.legacy.transformed.expect
pkg/front_end/testcases/duplicated_declarations.dart.outline.expect
pkg/front_end/testcases/duplicated_declarations.dart.strong.expect
pkg/front_end/testcases/duplicated_declarations_lib.dart
pkg/front_end/testcases/duplicated_declarations_part.dart

Cherry-pick analyzer CHANGELOG and pubspec from analyzer-0.33 branch.

Changed by	Paul Berry - paulberryohnoyoudont@google.com
Changed at	Saturday, 01-Dec-18 17:23:47 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	6f5d6db9c237c3d52c65af4be59c0a631eaf2ff3

Comments

Cherry-pick analyzer CHANGELOG and pubspec from analyzer-0.33 branch.

Also includes changes to the kernel and front_end pubspecs, since
those packages are tightly coupled to the analyzer.

These changes were made on the analyzer-0.33 branch in preparation for
previous releases of the analyzer.  Merging them to the master branch
makes it easier to keep the pubspec and CHANGELOG files up to date on
that branch.

Change-Id: I08a7bdcd49b6b2396166953131927656eca2c563
Reviewed-on: https://dart-review.googlesource.com/c/85727
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

Changed files

pkg/analyzer/CHANGELOG.md
pkg/analyzer/pubspec.yaml
pkg/front_end/pubspec.yaml
pkg/kernel/pubspec.yaml

Revert "[vm/aot] Fill in names of properties in snapshot profile."

Changed by	Alexander Aprelev - aamohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 19:52:23 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	dc346e6fdd89663388f8ae4e6767d6ece597c278

Comments

Revert "[vm/aot] Fill in names of properties in snapshot profile."

This reverts commit 465f8595ec1bd455edc7e91fd220db4be06cca6e as it
breaks windows and mac bots.

Change-Id: I94a939d711f69a28f405ee32680315ad6677b09e
Reviewed-on: https://dart-review.googlesource.com/c/85722
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>

Changed files

runtime/tests/vm/dart/v8_snapshot_profile_writer_test.dart
runtime/vm/clustered_snapshot.cc
runtime/vm/clustered_snapshot.h
runtime/vm/image_snapshot.cc
runtime/vm/image_snapshot.h
runtime/vm/raw_object.h
runtime/vm/raw_object_fields.cc
runtime/vm/raw_object_fields.h
runtime/vm/v8_snapshot_writer.cc
runtime/vm/v8_snapshot_writer.h
runtime/vm/vm_sources.gni

[vm/aot] Fill in names of properties in snapshot profile.

Changed by	Samir Jindel - sjindelohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 18:38:05 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	465f8595ec1bd455edc7e91fd220db4be06cca6e

Comments

[vm/aot] Fill in names of properties in snapshot profile.

Change-Id: Ic709a3dc40390463ffb5fd76fd8eb63ebd87acc0
Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-mac-release-simarm64-try
Reviewed-on: https://dart-review.googlesource.com/c/85292
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

Changed files

runtime/tests/vm/dart/v8_snapshot_profile_writer_test.dart
runtime/vm/clustered_snapshot.cc
runtime/vm/clustered_snapshot.h
runtime/vm/image_snapshot.cc
runtime/vm/image_snapshot.h
runtime/vm/raw_object.h
runtime/vm/raw_object_fields.cc
runtime/vm/raw_object_fields.h
runtime/vm/v8_snapshot_writer.cc
runtime/vm/v8_snapshot_writer.h
runtime/vm/vm_sources.gni

[infra] Implement preapproval of failing tests in approve_results.

Changed by	Jonas Termansen - sortieohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 17:08:04 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	2ca08ef2e1697edc3a0e99e21121f9de12ae79e3

Comments

[infra] Implement preapproval of failing tests in approve_results.

This change lets committers preapprove new failing tests based on commit
queue / dry run results for CQ builders, such that the CQ builder stays
green when the change is submitted.

The current implementation does not support changing one test from a failing
mode to another failing mode. It will work, but if the corresponding CI
builder cycles before the changelist is submitted, it will become red until
the changelist is submitted. This will be addressed in the future.

Likewise approving a builder after a preapproval will undo the preapproval
unless the changelist has been submitted and the corresponding CI builder
has cycled.

Bug: https://github.com/dart-lang/sdk/issues/35289
Change-Id: Ie43df4439a27a3472c5178cb7c6af69292cf70e4
Reviewed-on: https://dart-review.googlesource.com/c/85601
Reviewed-by: William Hesse <whesse@google.com>

Changed files

tools/approve_results.dart

Handle null initializer, this is being hit internally when compiling large

Changed by	Jacob MacDonald - jakemacohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 17:07:41 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	f72f07793bc78c2217ba2c613cbc25f5fe2f201d

Comments

Handle null initializer, this is being hit internally when compiling large
projects.

I don't know the exact situation that is being hit here and if something else
is going on, or continuing here is sane. It does appear to work though.

Change-Id: I7cbdf59f954ed80e0a9c71430b5661a335e21d9b
Reviewed-on: https://dart-review.googlesource.com/c/85402
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>

Changed files

pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart

Update more analyzer error codes to be generated

Changed by	danrubel - danrubelohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 15:00:36 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	80c23f87a3e3123d7e337c1fc8bc3b5ec49b34a0

Comments

Update more analyzer error codes to be generated

This updates more analyzer error codes to be generated
from the corresponding CFE error code.

Several of these analyzer error codes had multiple CFE error
codes mapped to them. In these situations, new analyzer error
codes were added to match the existing CFE error codes:

* EXTERNAL_FACTORY_WITH_BODY
* EXTERNAL_FACTORY_REDIRECTION
* CATCH_SYNTAX_EXTRA_PARAMETERS

Change-Id: Ib1cbb9e04d2092e4859e2cfadbcc85e03093f808
Reviewed-on: https://dart-review.googlesource.com/c/85431
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>

Changed files

pkg/analyzer/lib/error/error.dart
pkg/analyzer/lib/src/dart/error/syntactic_errors.dart
pkg/analyzer/lib/src/dart/error/syntactic_errors.g.dart
pkg/analyzer/lib/src/fasta/error_converter.dart
pkg/analyzer/test/generated/parser_test.dart
pkg/analyzer/test/src/fasta/recovery/partial_code/try_statement_test.dart
pkg/front_end/lib/src/fasta/fasta_codes_generated.dart
pkg/front_end/messages.yaml

Be more verbose in loops etc in kernel

Changed by	Jens Johansen - jensjohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 13:15:47 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	7f8e6f8bb6f9b4063cf12e936853d4c598bbe287

Comments

Be more verbose in loops etc in kernel

Benchmarks have shown that old-style for-loops are faster than for-in
for instance.

Golem says

ia32

whole stack (i.e. including utf8 and change to VariableIndexer)

AstToBinaryP90 (Intel Core i5)	6.617% (0.4 noise)
AstToBinary (Intel Xeon)	5.158% (0.4 noise)
AstToBinaryP90 (Intel Xeon)	5.104% (0.4 noise)
AstToBinaryP50 (Intel Xeon)	5.148% (0.4 noise)
AstToBinary (Intel Core i5)	6.579% (0.4 noise)
AstToBinaryP50 (Intel Core i5)	6.741% (0.4 noise)

by itself (i.e. compared to a build with utf8 and change to VariableIndexer)

AstToBinaryP90 (Intel Core i5)	0.7724% (0.0 noise)
AstToBinaryP50 (Intel Core i5)	0.7848% (0.0 noise)
AstToBinary (Intel Core i5)	0.8559% (0.0 noise)
AstToBinaryP90 (Intel Xeon)	0.7730% (0.1 noise)
AstToBinaryP50 (Intel Xeon)	0.8195% (0.1 noise)
AstToBinary (Intel Xeon)	0.9319% (0.1 noise)



x64

whole stack (i.e. including utf8 and change to VariableIndexer)

AstToBinaryP90 (Intel Core i5)	5.555% (0.2 noise)
AstToBinaryP50 (Intel Xeon)	6.352% (0.4 noise)
AstToBinaryP50 (Intel Core i5)	5.395% (0.5 noise)
AstToBinary (Intel Xeon)	6.928% (0.5 noise)
AstToBinaryP90 (Intel Xeon)	7.180% (0.5 noise)
AstToBinary (Intel Core i5)	5.824% (0.5 noise)

by itself  (i.e. compared to a build with utf8 and change to VariableIndexer)

AstToBinaryP90 (Intel Core i5)	0.1039% (0.0 noise)
AstToBinaryP50 (Intel Core i5)	0.6154% (0.0 noise)
AstToBinary (Intel Core i5)	0.7640% (0.1 noise)
AstToBinaryP50 (Intel Xeon)	1.268% (0.1 noise)
AstToBinary (Intel Xeon)	1.457% (0.1 noise)
AstToBinaryP90 (Intel Xeon)	1.512% (0.1 noise)



Change-Id: If091a3a01f2fe6574712946a01644413033739b6
Reviewed-on: https://dart-review.googlesource.com/c/85341
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>

Changed files

pkg/kernel/lib/ast.dart
pkg/kernel/lib/binary/ast_from_binary.dart
pkg/kernel/lib/binary/ast_to_binary.dart
pkg/kernel/lib/binary/limited_ast_to_binary.dart
pkg/kernel/lib/canonical_name.dart

[gardening] Mark LibTest/io/FileSystemCreateEvent/isDirectory_A01_t06 flaky

Changed by	Daco Harkes - dacoharkesohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 13:08:17 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	20e819cbbecaca74a261671d117a13574d877a54

Comments

[gardening] Mark LibTest/io/FileSystemCreateEvent/isDirectory_A01_t06 flaky

The test makes assumptions about file system events firing synchronously with file system operations

Issue https://github.com/dart-lang/co19/issues/186

Change-Id: Ic54782662e453c240d92113d25f7a6897b268130
Reviewed-on: https://dart-review.googlesource.com/c/85684
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>

Changed files

tests/co19_2/co19_2-kernel.status

Handle AmbiguousBuilder in computeRedirecteeType

Changed by	Jens Johansen - jensjohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 12:58:07 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	17d322b62a66b2b5a6d32b03bf14c4c7806716ca

Comments

Handle AmbiguousBuilder in computeRedirecteeType

We get an AmbiguousBuilder if there are more than one redirecting
factory with the same name. We shouldn't crash though.

Fixes #35266.

Bug: 35266
Change-Id: I1ac0babdde49c4ca3966e6af5c580191baac0873
Reviewed-on: https://dart-review.googlesource.com/c/85390
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>

Changed files

pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
pkg/front_end/testcases/legacy.status
pkg/front_end/testcases/regress/issue_35266.dart
pkg/front_end/testcases/regress/issue_35266.dart.legacy.expect
pkg/front_end/testcases/regress/issue_35266.dart.legacy.transformed.expect
pkg/front_end/testcases/regress/issue_35266.dart.outline.expect
pkg/front_end/testcases/regress/issue_35266.dart.strong.expect
pkg/front_end/testcases/regress/issue_35266.dart.strong.transformed.expect
pkg/front_end/testcases/strong.status
tests/language_2/regress_35266_test.dart

Fix rare crash in type inference engine

Changed by	Jens Johansen - jensjohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 12:57:17 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	5410bc40982138226a96c0b9a01035e121016ea2

Comments

Fix rare crash in type inference engine

Before this CL, running fasta compile on these 3 tests would make it
crash in type inference because the enclosingClass on a constrcutor
is null:

tests/language_2/const_error_multiply_initialized_test.dart
tests/language_2/constructor_duplicate_final_test.dart
tests/language_2/field3_test.dart

Note that these tests are all multi-tests and they are here run
unprocessed. The compiler crashes only after issuing errors.
The crash likely happens because of multiple definitions of
constructors with the same name.

This is a cut-down version that crashed prior to this CL:

```
class C {
  final d;

  C() {}
  C(this.d) {}
}
```

Fixes #35258.

Change-Id: I350c55428932ef0ae76f78875177b08acf95cdfc
Reviewed-on: https://dart-review.googlesource.com/c/85363
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>

Changed files

pkg/front_end/lib/src/fasta/source/source_class_builder.dart
pkg/front_end/testcases/legacy.status
pkg/front_end/testcases/regress/issue_35258.dart
pkg/front_end/testcases/regress/issue_35258.dart.legacy.expect
pkg/front_end/testcases/regress/issue_35258.dart.legacy.transformed.expect
pkg/front_end/testcases/regress/issue_35258.dart.outline.expect
pkg/front_end/testcases/regress/issue_35258.dart.strong.expect
pkg/front_end/testcases/regress/issue_35258.dart.strong.transformed.expect
pkg/front_end/testcases/strong.status
tests/language_2/regress_35258_test.dart

Lazy VariableIndexer in ast_to_binary.dart

Changed by	Jens Johansen - jensjohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 12:39:27 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	8db293ed70ecdcc9d1f57e2be7297b3b2fba0232

Comments

Lazy VariableIndexer in ast_to_binary.dart

Often a VariableIndexer was initialized with no use.
This CL eliminates that by creating it as needed.

Golem says:

ia32

whole stack (i.e. together with the utf8 stuff)

AstToBinary (Intel Xeon)	4.265% (0.3 noise)
AstToBinaryP50 (Intel Xeon)	4.364% (0.3 noise)
AstToBinaryP90 (Intel Xeon)	4.365% (0.3 noise)
AstToBinaryP90 (Intel Core i5)	5.890% (0.3 noise)
AstToBinary (Intel Core i5)	5.772% (0.3 noise)
AstToBinaryP50 (Intel Core i5)	6.004% (0.4 noise)

by itself (i.e. compared to the one with hte utf8 stuff)

AstToBinary (Intel Xeon)	0.4910% (0.0 noise)
AstToBinaryP50 (Intel Xeon)	0.6186% (0.0 noise)
AstToBinaryP90 (Intel Xeon)	0.6415% (0.0 noise)
AstToBinaryP90 (Intel Core i5)	1.974% (0.1 noise)
AstToBinary (Intel Core i5)	1.854% (0.1 noise)
AstToBinaryP50 (Intel Core i5)	2.072% (0.1 noise)


whole stack (i.e. together with the utf8 stuff)

whole stack

AstToBinaryP90 (Intel Core i5)	5.457% (0.2 noise)
AstToBinaryP50 (Intel Xeon)	5.150% (0.4 noise)
AstToBinary (Intel Xeon)	5.552% (0.4 noise)
AstToBinaryP90 (Intel Xeon)	5.756% (0.4 noise)
AstToBinaryP50 (Intel Core i5)	4.809% (0.4 noise)
AstToBinary (Intel Core i5)	5.099% (0.5 noise)

by itself (i.e. compared to the one with hte utf8 stuff)

AstToBinaryP50 (Intel Core i5)	-0.6758% (-0.1 noise)
AstToBinary (Intel Core i5)	-0.0593% (-0.0 noise)
AstToBinaryP90 (Intel Core i5)	1.292% (0.0 noise)
AstToBinaryP50 (Intel Xeon)	0.6355% (0.0 noise)
AstToBinaryP90 (Intel Xeon)	0.9089% (0.1 noise)
AstToBinary (Intel Xeon)	0.9836% (0.1 noise)

Change-Id: Ia9a86958f9a9280c6ee40695fe3020debb8312a5
Reviewed-on: https://dart-review.googlesource.com/c/85340
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>

Changed files

pkg/kernel/lib/binary/ast_to_binary.dart

Get rid of double colons in override error messages.

Changed by	Aske Simon Christensen - askescohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 11:36:23 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	c45abca64887e6b3784950cc4e972d16858666e3

Comments

Get rid of double colons in override error messages.

Change-Id: Ice49347ab20fcf02971abe724b7233ca5fdf03e5
Reviewed-on: https://dart-review.googlesource.com/c/85582
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

Changed files

pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
pkg/front_end/testcases/inference/generic_methods_do_not_infer_invalid_override_of_generic_method.dart.strong.expect
pkg/front_end/testcases/inference/generic_methods_handle_override_of_non_generic_with_generic.dart.legacy.expect
pkg/front_end/testcases/inference/generic_methods_handle_override_of_non_generic_with_generic.dart.strong.expect
pkg/front_end/testcases/inference/infer_method_missing_params.dart.legacy.expect
pkg/front_end/testcases/inference/infer_method_missing_params.dart.outline.expect
pkg/front_end/testcases/inference/infer_method_missing_params.dart.strong.expect
pkg/front_end/testcases/mixin_application_override.dart.legacy.expect
pkg/front_end/testcases/mixin_application_override.dart.outline.expect
pkg/front_end/testcases/mixin_application_override.dart.strong.expect
pkg/front_end/testcases/regress/issue_32660.dart.strong.expect
pkg/front_end/testcases/regress/issue_32660.dart.strong.transformed.expect

Use new type printer for bound errors on method calls.

Changed by	Aske Simon Christensen - askescohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 11:36:23 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	8ab76a521a2d980900e9ee64ec91fbbad5460d5e

Comments

Use new type printer for bound errors on method calls.

Change-Id: I3b098a1fd1d52718e19c37816dd1a19680bdf0f6
Reviewed-on: https://dart-review.googlesource.com/c/85581
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

Changed files

pkg/front_end/lib/src/fasta/fasta_codes_generated.dart
pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
pkg/front_end/messages.yaml
pkg/front_end/testcases/inference/generic_methods_correctly_recognize_generic_upper_bound.dart.strong.expect
pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart.strong.expect
pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart.strong.transformed.expect

Do UTF8 encoding slightly differently when serializing kernel

Changed by	Jens Johansen - jensjohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 11:27:03 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	e520f2480a898a4570362c41b6d2f6896bc3822e

Comments

Do UTF8 encoding slightly differently when serializing kernel

Instead of creating two small-ish utf8lists for every string we encode,
do fewer bigger allocations and convert to utf8 via a (new) method that
will hopefully eventually be moved into String.

Golem says:

ia32

AstToBinaryP90 (Intel Core i5)	3.995% (0.2 noise)
AstToBinary (Intel Core i5)	3.992% (0.2 noise)
AstToBinaryP50 (Intel Core i5)	4.015% (0.2 noise)
AstToBinary (Intel Xeon)	3.793% (0.3 noise)
AstToBinaryP90 (Intel Xeon)	3.748% (0.3 noise)
AstToBinaryP50 (Intel Xeon)	3.769% (0.3 noise)


x64


AstToBinaryP90 (Intel Core i5)	4.220% (0.1 noise)
AstToBinaryP50 (Intel Xeon)	4.543% (0.3 noise)
AstToBinary (Intel Xeon)	4.614% (0.3 noise)
AstToBinaryP90 (Intel Xeon)	4.891% (0.3 noise)
AstToBinaryP50 (Intel Core i5)	5.448% (0.5 noise)
AstToBinary (Intel Core i5)	5.155% (0.5 noise)

Change-Id: I0532778d69205a7a187342d3bdfe503c660b1004
Reviewed-on: https://dart-review.googlesource.com/c/84413
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>

Changed files

pkg/kernel/lib/binary/ast_to_binary.dart

[gardening] Lower core rlimit to 0 if test is expected to crash.

Changed by	Vyacheslav Egorov - vegorovohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 11:15:06 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	040ef6aabb9476a676ec8868f7fef5895dc314f9

Comments

[gardening] Lower core rlimit to 0 if test is expected to crash.

We do not archive core dumps generated by tests that are expected
to crash - so there is no need to generate those dumps.

It seems that generating core dumps is very slow on Mac and causes
timeouts.

Fixes #35275

Remove Timeout expectations from Crashing tests

Change-Id: I36c89fd583a6a94521560544163f02414cbbf41a
Reviewed-on: https://dart-review.googlesource.com/c/85680
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>

Changed files

runtime/bin/main.cc
runtime/bin/main_options.h
runtime/bin/platform.h
runtime/bin/platform_android.cc
runtime/bin/platform_fuchsia.cc
runtime/bin/platform_linux.cc
runtime/bin/platform_macos.cc
runtime/bin/platform_win.cc
runtime/bin/run_vm_tests.cc
runtime/tests/vm/vm.status
tools/testing/dart/runtime_configuration.dart
tools/testing/dart/test_suite.dart

[gardening] Mark LibTest/io/RawDatagramSocket/singleWhere_A03_t01 failing

Changed by	Daco Harkes - dacoharkesohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 10:49:03 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	40dd503b3aff80fa05ffc1690a24f30ef9121d38

Comments

[gardening] Mark LibTest/io/RawDatagramSocket/singleWhere_A03_t01 failing

The test make assumptions about delivery order which UDP does not
provide

Issue https://github.com/dart-lang/co19/issues/195

Change-Id: I1c1ed618a68ea9e7a96e2733ed78095451aa5d89
Reviewed-on: https://dart-review.googlesource.com/c/85700
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>

Changed files

tests/co19_2/co19_2-kernel.status

Avoid copying result arrays for nested types in type labeler.

Changed by	Aske Simon Christensen - askescohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 10:45:23 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	3a52e7bc3188015b3f1660d4063345e5bc98a23c

Comments

Avoid copying result arrays for nested types in type labeler.

Change-Id: Iab38c942d00c0c5d530b12e3c320cee39daeab5c
Reviewed-on: https://dart-review.googlesource.com/c/85583
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>

Changed files

pkg/front_end/lib/src/fasta/kernel/type_labeler.dart

Fix crash with multiple same-named redirecting constructors

Changed by	Jens Johansen - jensjohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 08:53:10 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	ad62f21e5b2966a121c45d05f93a304d282c1cfd

Comments

Fix crash with multiple same-named redirecting constructors

Without this CL we end up putting a null-reference in the tree because
the parent is never set on the redirecting constructor we try pointing
to.

Fixes #35259, #35260.

Change-Id: I8ad520453742ff1de8dd9ca5e619f9edbff9971c
Reviewed-on: https://dart-review.googlesource.com/c/85384
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>

Changed files

pkg/front_end/lib/src/fasta/dill/dill_class_builder.dart
pkg/front_end/lib/src/fasta/kernel/body_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
pkg/front_end/lib/src/fasta/scope.dart
pkg/front_end/testcases/legacy.status
pkg/front_end/testcases/regress/issue_35259.dart
pkg/front_end/testcases/regress/issue_35259.dart.legacy.expect
pkg/front_end/testcases/regress/issue_35259.dart.legacy.transformed.expect
pkg/front_end/testcases/regress/issue_35259.dart.outline.expect
pkg/front_end/testcases/regress/issue_35259.dart.strong.expect
pkg/front_end/testcases/regress/issue_35259.dart.strong.transformed.expect
pkg/front_end/testcases/regress/issue_35260.dart
pkg/front_end/testcases/regress/issue_35260.dart.legacy.expect
pkg/front_end/testcases/regress/issue_35260.dart.legacy.transformed.expect
pkg/front_end/testcases/regress/issue_35260.dart.outline.expect
pkg/front_end/testcases/regress/issue_35260.dart.strong.expect
pkg/front_end/testcases/regress/issue_35260.dart.strong.transformed.expect
pkg/front_end/testcases/strong.status
tests/language_2/regress_35259_test.dart
tests/language_2/regress_35260_test.dart

[Gardening] Attempt to make socket_bind test more robust by ignoring unrelated clients

Changed by	Martin Kustermann - kustermannohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 08:52:13 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	85a6da121370b6dfe8e2c3ceee0fe0af63f470f6

Comments

[Gardening] Attempt to make socket_bind test more robust by ignoring unrelated clients

Change-Id: Ie9ea8806e27ff3186716daf21b09ae7009bb50cc
Reviewed-on: https://dart-review.googlesource.com/c/85563
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>

Changed files

tests/standalone_2/io/socket_bind_test.dart

Infer general flow through && and ||

Changed by	Johnni Winther - johnniwintherohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 08:32:11 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	0a2ed86935bb2eed452f90b1be092649cca4cdc4

Comments

Infer general flow through && and ||

Closes #34993

Change-Id: Ifb849e4525ba9e5518932b8fba2ae556fb49acb3
Reviewed-on: https://dart-review.googlesource.com/c/85502
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>

Changed files

pkg/compiler/lib/src/inferrer/builder_kernel.dart
pkg/compiler/lib/src/inferrer/locals_handler.dart
pkg/compiler/lib/src/inferrer/type_graph_nodes.dart
tests/compiler/dart2js/inference/data/general.dart
tests/compiler/dart2js/inference/data/logical_if.dart
tests/compiler/dart2js/inference/data/null.dart

Add version information to SDK changes that have happened after 2.0.

Changed by	Lasse Reichstein Holst Nielsen - lrnohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 07:55:26 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	1231244edeeee39dd1d6aeec744159d6be3c0b2f

Comments

Add version information to SDK changes that have happened after 2.0.

Change-Id: I4f49731c446d49e8b49e5c1c29ebcab85e085864
Reviewed-on: https://dart-review.googlesource.com/c/84430
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>

Changed files

sdk/lib/_http/http.dart
sdk/lib/async/async.dart
sdk/lib/async/stream.dart
sdk/lib/collection/hash_map.dart
sdk/lib/collection/linked_hash_map.dart
sdk/lib/core/bool.dart
sdk/lib/core/core.dart
sdk/lib/core/errors.dart
sdk/lib/internal/internal.dart

Add --omit_platform as option to fasta.

Changed by	Jens Johansen - jensjohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 07:48:15 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	c2bd36e94df53981384ccad7238bcca5ac454dfe

Comments

Add --omit_platform as option to fasta.

Change-Id: I9f8b7b89a0440bbff8b466ed2e4f2af73c72c023
Reviewed-on: https://dart-review.googlesource.com/c/84428
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>

Changed files

pkg/front_end/lib/src/api_prototype/compiler_options.dart
pkg/front_end/lib/src/base/processed_options.dart
pkg/front_end/lib/src/fasta/fasta_codes_generated.dart
pkg/front_end/messages.yaml
pkg/front_end/tool/_fasta/command_line.dart
pkg/front_end/tool/_fasta/entry_points.dart

[vm] Remove dead pre-Observatory debugger code.

Changed by	Ryan Macnak - rmacnakohnoyoudont@google.com
Changed at	Friday, 30-Nov-18 00:01:19 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	31e4c9de6e6d56e2940c1304da19ed11b08b4c1f

Comments

[vm] Remove dead pre-Observatory debugger code.

Change-Id: I13779b9a4878f84aa3995043a99fab9253e8e093
Reviewed-on: https://dart-review.googlesource.com/c/85641
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

Changed files

runtime/vm/debugger.cc
runtime/vm/debugger.h
runtime/vm/debugger_api_impl_test.cc
runtime/vm/debugger_api_impl_test.h
runtime/vm/isolate.cc

Fix up pubspec for pkg:compiler

Changed by	Kevin Moore - kevmooohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 23:33:39 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	17a7f513c3e6be35dca53906b79a7be58369e260

Comments

Fix up pubspec for pkg:compiler

Removed unused dependencies
Correctly reference repo packages via dependency_overrides
Fix pubspecs for pkg: js_ast, js_runtime, sdk_library_metadata

Change-Id: I2077814f733c299dca7afe3f5ab4b380c2c886e4
Reviewed-on: https://dart-review.googlesource.com/c/85660
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>

Changed files

pkg/compiler/.gitignore
pkg/compiler/README.md
pkg/compiler/pubspec.yaml
pkg/js_ast/pubspec.yaml
sdk/lib/_internal/js_runtime/pubspec.yaml
sdk/lib/_internal/sdk_library_metadata/pubspec.yaml

Cleanup CompilerTask

Changed by	Kevin Moore - kevmooohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 22:43:09 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	440f190a344a8cb7dc9852a4c0cdec4004d3bf6a

Comments

Cleanup CompilerTask

make a number of fields private

Change-Id: Ib44aa3459e5d286004de7cb08e07039dc115894a
Reviewed-on: https://dart-review.googlesource.com/c/85645
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>

Changed files

pkg/compiler/lib/src/apiimpl.dart
pkg/compiler/lib/src/common/tasks.dart
pkg/compiler/lib/src/dump_info.dart

[vm] Use decimal thread ids to match gdb and eu-stack.

Changed by	Ryan Macnak - rmacnakohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 22:06:20 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	bfcbd2510230edf250684e281526f0debbc54f48

Comments

[vm] Use decimal thread ids to match gdb and eu-stack.

Makes it easier to match things up between the bot test failure output and core dumps.

Change-Id: I8ed89dc67b0c46716d4bfed3ec1a7cdbc5411eea
Reviewed-on: https://dart-review.googlesource.com/c/85466
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

Changed files

runtime/vm/profiler.cc
runtime/vm/timeline.cc
runtime/vm/timeline_analysis.cc

[vm] Remove source-based loading APIs.

Changed by	Ryan Macnak - rmacnakohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 21:58:14 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	6fbc7d27c47f49002cc6bfb141ab3ef5e84f09b3

Comments

[vm] Remove source-based loading APIs.

Change-Id: I07cd591bd6162a743770d221e48d491597a1b7c1
Reviewed-on: https://dart-review.googlesource.com/c/85545
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

Changed files

runtime/include/dart_api.h
runtime/vm/dart_api_impl.cc

[vm] Make profiler bailout counters available over the VM service.

Changed by	Ryan Macnak - rmacnakohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 21:53:24 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	488d1f375c0faac589c4017be1edb4e6067d8631

Comments

[vm] Make profiler bailout counters available over the VM service.

Change-Id: I4c0d30b21371e33f66ab142636aa669a46f8a799
Reviewed-on: https://dart-review.googlesource.com/c/85547
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

Changed files

runtime/observatory/lib/sample_profile.dart
runtime/observatory/lib/src/elements/sample_buffer_control.dart
runtime/observatory/lib/src/sample_profile/sample_profile.dart
runtime/vm/profiler.cc
runtime/vm/profiler.h
runtime/vm/profiler_service.cc

Improvements to verbose timing data printing.

Changed by	Sigmund Cherem - sigmundohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 18:09:20 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	d9c6bc0316ada094335419d4c3a4a627f5881f4b

Comments

Improvements to verbose timing data printing.

- format is padded and includes  %
- measure explicitly subtasks of deferred load
- use shorter names for other tasks


Sample output on swarm:

Info: Timings:
    kernel loader:                                 1.407s (17.1%)
    Front end:                                     0.736s  (8.9%)
    Front end > closures:                          0.102s  (1.2%)
    Front end > worldImpact:                       0.586s  (7.1%)
    Type inference:                                1.143s (13.9%)
    Deferred Loading:                              0.002s  (0.0%)
    Deferred Loading > prepare:                    0.002s  (0.0%)
    Enqueue:                                       0.455s  (5.5%)
    self:                                          0.914s (11.1%)
   *self > impl.run:                               0.034s  (0.4%)
    self > run:                                    0.206s  (2.5%)
    self > compileFromKernel:                      0.012s  (0.1%)
    self > computeClosedWorld:                     0.364s  (4.4%)
    self > processQueue:                           0.033s  (0.4%)
    self > emptyQueue:                             0.040s  (0.5%)
    self > applyImpact:                            0.146s  (1.8%)
    self > work.run:                               0.076s  (0.9%)
    SSA builder:                                   1.002s (12.2%)
    SSA optimizer:                                 1.302s (15.8%)
    SSA optimizer > SsaInstructionSimplifier:      0.421s  (5.1%)
    SSA optimizer > SsaTypeconversionInserter:     0.036s  (0.4%)
    SSA optimizer > SsaRedundantPhiEliminator:     0.012s  (0.1%)
    SSA optimizer > SsaDeadPhiEliminator:          0.010s  (0.1%)
    SSA optimizer > SsaTypePropagator:             0.261s  (3.2%)
    SSA optimizer > SsaCheckInserter:              0.030s  (0.4%)
    SSA optimizer > SsaDeadCodeEliminator:         0.067s  (0.8%)
    SSA optimizer > SsaGlobalValueNumberer:        0.071s  (0.9%)
    SSA optimizer > SsaCodeMotion:                 0.024s  (0.3%)
    SSA optimizer > SsaLoadElimination:            0.083s  (1.0%)
    SSA optimizer > SSA value range builder:       0.099s  (1.2%)
    SSA optimizer > SsaSimplifyInterceptors:       0.048s  (0.6%)
    SSA code generator:                            0.623s  (7.6%)
    Code emitter:                                  0.586s  (7.1%)
    Diagnostic handler:                            0.001s  (0.0%)
Change-Id: I4af3ff04954b28ee12354bc79eae517169a3b96e
Reviewed-on: https://dart-review.googlesource.com/c/85550
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>

Changed files

pkg/compiler/lib/src/apiimpl.dart
pkg/compiler/lib/src/compiler.dart
pkg/compiler/lib/src/deferred_load.dart
pkg/compiler/lib/src/kernel/deferred_load.dart
pkg/compiler/lib/src/kernel/loader.dart

Fix analyzer CHANGELOG.

Changed by	Paul Berry - paulberryohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 17:26:57 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	c7dea39faa76ec1544d3fb0dab27868cba612c3f

Comments

Fix analyzer CHANGELOG.

The changelog entry for analyzer version 0.33.5 actually won't be
released until analyzer 0.33.6.

Change-Id: Iab4f2924ef9c8f43b5e81f9cf3ab316f7fc96918
Reviewed-on: https://dart-review.googlesource.com/c/85549
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

Changed files

pkg/analyzer/CHANGELOG.md

[infra] Update Clang toolchain and GN

Changed by	Zach Anderson - zraohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 15:37:40 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	031e77eea11a16a5e486a3673549adbd68862c8e

Comments

[infra] Update Clang toolchain and GN

We no longer rely on Fuchsia's buildtools, instead we directly fetch
Clang and GN packages from CIPD using gclient support.

Change-Id: I8995d89babf9c3c6b30214a1133e7b0a1cb9a796
Reviewed-on: https://dart-review.googlesource.com/c/85416
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>

Changed files

DEPS
build/config/android/BUILD.gn
build/config/android/config.gni
build/config/compiler/BUILD.gn
build/config/sysroot.gni
tools/android/VERSION_LINUX_NDK
tools/android/VERSION_MACOSX_NDK
tools/buildtools/README.md
tools/buildtools/update.py
tools/gn.py

Re-formulation of type bound violation error messages

Changed by	Aske Simon Christensen - askescohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 13:27:16 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	c9aaa7a654b1cac1307c854ba38f4dc995c86f09

Comments

Re-formulation of type bound violation error messages

Change-Id: I7f0b99c184b02f6910da054b877b5b5bee86f6bc
Reviewed-on: https://dart-review.googlesource.com/c/85346
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

Changed files

pkg/front_end/lib/src/fasta/fasta_codes_generated.dart
pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
pkg/front_end/messages.yaml
pkg/front_end/testcases/clone_function_type.dart.strong.expect
pkg/front_end/testcases/clone_function_type.dart.strong.transformed.expect
pkg/front_end/testcases/expression/class_type_param_bound_illegal.expression.yaml.expect
pkg/front_end/testcases/expression/type_param_bound.expression.yaml.expect
pkg/front_end/testcases/inference/constructors_infer_from_arguments_argument_not_assignable.dart.strong.expect
pkg/front_end/testcases/inference/constructors_inference_f_bounded.dart.strong.expect
pkg/front_end/testcases/inference/constructors_inference_f_bounded.dart.strong.transformed.expect
pkg/front_end/testcases/inference/downward_inference_fixes_no_upwards_errors.dart.strong.expect
pkg/front_end/testcases/inference/downward_inference_fixes_no_upwards_errors.dart.strong.transformed.expect
pkg/front_end/testcases/inference/generic_methods_correctly_recognize_generic_upper_bound.dart.strong.expect
pkg/front_end/testcases/inference/mixin_inference_instantiate_to_bounds_3.dart.strong.expect
pkg/front_end/testcases/inference/mixin_inference_instantiate_to_bounds_3.dart.strong.transformed.expect
pkg/front_end/testcases/instantiate_to_bound/inference_super_bounded_rejected.dart.strong.expect
pkg/front_end/testcases/instantiate_to_bound/inference_super_bounded_rejected.dart.strong.transformed.expect
pkg/front_end/testcases/instantiate_to_bound/non_simple_from_compiled.dart.strong.expect
pkg/front_end/testcases/instantiate_to_bound/non_simple_from_compiled.dart.strong.transformed.expect
pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart.strong.expect
pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart.strong.transformed.expect
pkg/front_end/tool/_fasta/generate_messages.dart

De-duplicate some bound check code.

Changed by	Aske Simon Christensen - askescohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 13:27:16 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	03a1fe30f52b3afb57f6f63d9eaa0c1028c4a55f

Comments

De-duplicate some bound check code.

Change-Id: I75cb1b31f8b47525ee18c8d01a3fe534512ad579
Reviewed-on: https://dart-review.googlesource.com/c/85293
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

Changed files

pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart

Get rid of double colon notation for class members in messages.

Changed by	Aske Simon Christensen - askescohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 13:27:16 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	4427bb70bcc330567380f1fb9602947af83ca33c

Comments

Get rid of double colon notation for class members in messages.

Type variable bound violations on constructor/factory invocations
now mention just the class name (which is the one that has the type
variables) instead of the constructor/factory name.

Change-Id: I65330f1921451fef0157be01b4a5086855d80439
Reviewed-on: https://dart-review.googlesource.com/c/85291
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

Changed files

pkg/front_end/lib/src/fasta/builder/library_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
pkg/front_end/testcases/inference/conflicts_can_happen.dart.strong.expect
pkg/front_end/testcases/inference/conflicts_can_happen2.dart.strong.expect
pkg/front_end/testcases/inference/constructors_infer_from_arguments_argument_not_assignable.dart.strong.expect
pkg/front_end/testcases/inference/constructors_inference_f_bounded.dart.strong.expect
pkg/front_end/testcases/inference/constructors_inference_f_bounded.dart.strong.transformed.expect
pkg/front_end/testcases/inference/do_not_infer_overridden_fields_that_explicitly_say_dynamic_infer.dart.strong.expect
pkg/front_end/testcases/inference/generic_methods_correctly_recognize_generic_upper_bound.dart.strong.expect
pkg/front_end/testcases/inference/generic_methods_do_not_infer_invalid_override_of_generic_method.dart.strong.expect
pkg/front_end/testcases/inference/generic_methods_handle_override_of_non_generic_with_generic.dart.strong.expect
pkg/front_end/testcases/inference/infer_field_override_multiple.dart.strong.expect
pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_infer.dart.strong.expect
pkg/front_end/testcases/inference_new/infer_field_getter_setter_mismatch.dart.strong.expect
pkg/front_end/testcases/inference_new/infer_field_override_getter_overrides_setter.dart.strong.expect
pkg/front_end/testcases/instantiate_to_bound/inference_super_bounded_rejected.dart.strong.expect
pkg/front_end/testcases/instantiate_to_bound/inference_super_bounded_rejected.dart.strong.transformed.expect
pkg/front_end/testcases/override_check_accessor_after_inference.dart.strong.expect
pkg/front_end/testcases/override_check_accessor_basic.dart.strong.expect
pkg/front_end/testcases/override_check_accessor_with_covariant_modifier.dart.strong.expect
pkg/front_end/testcases/override_check_after_inference.dart.strong.expect
pkg/front_end/testcases/override_check_basic.dart.strong.expect
pkg/front_end/testcases/override_check_with_covariant_modifier.dart.strong.expect
pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart.strong.expect
pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart.strong.transformed.expect
pkg/front_end/testcases/runtime_checks_new/mixin_forwarding_stub_field.dart.strong.expect
pkg/front_end/testcases/runtime_checks_new/mixin_forwarding_stub_getter.dart.strong.expect
pkg/front_end/testcases/runtime_checks_new/mixin_forwarding_stub_setter.dart.strong.expect

Test of type variable bound printing

Changed by	Aske Simon Christensen - askescohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 13:27:16 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	820af6ba9ec190261e98179cc4a8b5af4fa9a7af

Comments

Test of type variable bound printing

Tests that bounds are printed when printing a generic function type,
and that the printer correctly distinguishes between no specified bound
(no bound printed) and explicit Object bound (Object printed as bound).

Change-Id: I747743d902a9eaf66cf65c579051175216960c63
Reviewed-on: https://dart-review.googlesource.com/c/84606
Reviewed-by: Peter von der Ahé <ahe@google.com>

Changed files

pkg/front_end/testcases/function_type_assignments.dart
pkg/front_end/testcases/function_type_assignments.dart.legacy.expect
pkg/front_end/testcases/function_type_assignments.dart.legacy.transformed.expect
pkg/front_end/testcases/function_type_assignments.dart.outline.expect
pkg/front_end/testcases/function_type_assignments.dart.strong.expect
pkg/front_end/testcases/function_type_assignments.dart.strong.transformed.expect

Print origins of types in bullet points below error messages.

Changed by	Aske Simon Christensen - askescohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 13:27:16 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	c959bd98afb1d24cd944388040fa913a19021620

Comments

Print origins of types in bullet points below error messages.

This gets rid of the useless '#lib1::' prefixes on types in error
messages and instead adds a line to the error message for each
interface type appearing in the message stating where that type
originates.

Name clashes are disambiguated by appending markers like '/*1*/' and
'/*2*/' to the types whenever two interface types with the same name
appear in the same message.

The commonly used core types 'bool', 'num', 'int', 'double', 'String'
and 'Null' are excluded from the origin list unless they take part in a
name clash.

Change-Id: I017ea376d4f6ff2d4f3b36487774463f03bb3301
Reviewed-on: https://dart-review.googlesource.com/c/84604
Reviewed-by: Peter von der Ahé <ahe@google.com>

Changed files

pkg/front_end/lib/src/fasta/fasta_codes.dart
pkg/front_end/lib/src/fasta/fasta_codes_generated.dart
pkg/front_end/lib/src/fasta/kernel/dummy_type_labeler.dart
pkg/front_end/testcases/accessors.dart.strong.expect
pkg/front_end/testcases/accessors.dart.strong.transformed.expect
pkg/front_end/testcases/bug21938.dart.strong.expect
pkg/front_end/testcases/bug32414a.dart.strong.expect
pkg/front_end/testcases/bug32414a.dart.strong.transformed.expect
pkg/front_end/testcases/bug33298.dart.strong.expect
pkg/front_end/testcases/bug33298.dart.strong.transformed.expect
pkg/front_end/testcases/call.dart.strong.expect
pkg/front_end/testcases/cascade.dart.strong.expect
pkg/front_end/testcases/cascade.dart.strong.transformed.expect
pkg/front_end/testcases/check_deferred_as_check.dart.legacy.expect
pkg/front_end/testcases/check_deferred_as_check.dart.strong.expect
pkg/front_end/testcases/check_deferred_as_check.dart.strong.transformed.expect
pkg/front_end/testcases/check_deferred_is_check.dart.legacy.expect
pkg/front_end/testcases/check_deferred_is_check.dart.strong.expect
pkg/front_end/testcases/check_deferred_is_check.dart.strong.transformed.expect
pkg/front_end/testcases/check_deferred_type_declaration.dart.legacy.expect
pkg/front_end/testcases/check_deferred_type_declaration.dart.strong.expect
pkg/front_end/testcases/check_deferred_type_declaration.dart.strong.transformed.expect
pkg/front_end/testcases/clone_function_type.dart.strong.expect
pkg/front_end/testcases/clone_function_type.dart.strong.transformed.expect
pkg/front_end/testcases/continue_inference_after_error.dart.strong.expect
pkg/front_end/testcases/continue_inference_after_error.dart.strong.transformed.expect
pkg/front_end/testcases/deferred_type_annotation.dart.legacy.expect
pkg/front_end/testcases/deferred_type_annotation.dart.strong.expect
pkg/front_end/testcases/deferred_type_annotation.dart.strong.transformed.expect
pkg/front_end/testcases/expression/class_type_param_bound_illegal.expression.yaml.expect
pkg/front_end/testcases/expression/type_param_shadow_arg_ctor_inferred.expression.yaml.expect
pkg/front_end/testcases/inference/block_bodied_lambdas_downwards_incompatible_with_upwards_inference.dart.strong.expect
pkg/front_end/testcases/inference/block_bodied_lambdas_downwards_incompatible_with_upwards_inference.dart.strong.transformed.expect
pkg/front_end/testcases/inference/conflicts_can_happen.dart.strong.expect
pkg/front_end/testcases/inference/conflicts_can_happen2.dart.strong.expect
pkg/front_end/testcases/inference/constructors_infer_from_arguments.dart.strong.expect
pkg/front_end/testcases/inference/constructors_infer_from_arguments.dart.strong.transformed.expect
pkg/front_end/testcases/inference/constructors_infer_from_arguments_argument_not_assignable.dart.strong.expect
pkg/front_end/testcases/inference/constructors_infer_from_arguments_factory.dart.strong.expect
pkg/front_end/testcases/inference/constructors_infer_from_arguments_factory.dart.strong.transformed.expect
pkg/front_end/testcases/inference/constructors_inference_f_bounded.dart.strong.expect
pkg/front_end/testcases/inference/constructors_inference_f_bounded.dart.strong.transformed.expect
pkg/front_end/testcases/inference/do_not_infer_overridden_fields_that_explicitly_say_dynamic_infer.dart.strong.expect
pkg/front_end/testcases/inference/downwards_inference_assignment_statements.dart.strong.expect
pkg/front_end/testcases/inference/downwards_inference_assignment_statements.dart.strong.transformed.expect
pkg/front_end/testcases/inference/downwards_inference_on_constructor_arguments_infer_downwards.dart.strong.expect
pkg/front_end/testcases/inference/downwards_inference_on_constructor_arguments_infer_downwards.dart.strong.transformed.expect
pkg/front_end/testcases/inference/downwards_inference_on_function_arguments_infer_downwards.dart.strong.expect
pkg/front_end/testcases/inference/downwards_inference_on_function_arguments_infer_downwards.dart.strong.transformed.expect
pkg/front_end/testcases/inference/downwards_inference_on_function_expressions.dart.strong.expect
pkg/front_end/testcases/inference/downwards_inference_on_function_expressions.dart.strong.transformed.expect
pkg/front_end/testcases/inference/downwards_inference_on_generic_constructor_arguments_infer_downwards.dart.strong.expect
pkg/front_end/testcases/inference/downwards_inference_on_generic_constructor_arguments_infer_downwards.dart.strong.transformed.expect
pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart.strong.expect
pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart.strong.transformed.expect
pkg/front_end/testcases/inference/downwards_inference_on_instance_creations_infer_downwards.dart.strong.expect
pkg/front_end/testcases/inference/downwards_inference_on_instance_creations_infer_downwards.dart.strong.transformed.expect
pkg/front_end/testcases/inference/downwards_inference_on_list_literals_infer_downwards.dart.strong.expect
pkg/front_end/testcases/inference/downwards_inference_on_list_literals_infer_downwards.dart.strong.transformed.expect
pkg/front_end/testcases/inference/downwards_inference_on_map_literals.dart.strong.expect
pkg/front_end/testcases/inference/downwards_inference_on_map_literals.dart.strong.transformed.expect
pkg/front_end/testcases/inference/downwards_inference_yield_yield_star.dart.strong.expect
pkg/front_end/testcases/inference/downwards_inference_yield_yield_star.dart.strong.transformed.expect
pkg/front_end/testcases/inference/future_then_upwards.dart.strong.expect
pkg/front_end/testcases/inference/future_then_upwards.dart.strong.transformed.expect
pkg/front_end/testcases/inference/future_then_upwards_2.dart.strong.expect
pkg/front_end/testcases/inference/future_then_upwards_2.dart.strong.transformed.expect
pkg/front_end/testcases/inference/future_then_upwards_3.dart.strong.expect
pkg/front_end/testcases/inference/future_then_upwards_3.dart.strong.transformed.expect
pkg/front_end/testcases/inference/future_union_downwards.dart.strong.expect
pkg/front_end/testcases/inference/future_union_downwards.dart.strong.transformed.expect
pkg/front_end/testcases/inference/future_union_downwards_3.dart.strong.expect
pkg/front_end/testcases/inference/future_union_downwards_3.dart.strong.transformed.expect
pkg/front_end/testcases/inference/generic_methods_correctly_recognize_generic_upper_bound.dart.strong.expect
pkg/front_end/testcases/inference/generic_methods_dart_math_min_max.dart.strong.expect
pkg/front_end/testcases/inference/generic_methods_dart_math_min_max.dart.strong.transformed.expect
pkg/front_end/testcases/inference/generic_methods_do_not_infer_invalid_override_of_generic_method.dart.strong.expect
pkg/front_end/testcases/inference/generic_methods_downwards_inference_affects_arguments.dart.strong.expect
pkg/front_end/testcases/inference/generic_methods_downwards_inference_affects_arguments.dart.strong.transformed.expect
pkg/front_end/testcases/inference/generic_methods_handle_override_of_non_generic_with_generic.dart.strong.expect
pkg/front_end/testcases/inference/generic_methods_infer_generic_instantiation.dart.strong.expect
pkg/front_end/testcases/inference/generic_methods_infer_generic_instantiation.dart.strong.transformed.expect
pkg/front_end/testcases/inference/generic_methods_inference_error.dart.strong.expect
pkg/front_end/testcases/inference/generic_methods_inference_error.dart.strong.transformed.expect
pkg/front_end/testcases/inference/generic_methods_iterable_and_future.dart.strong.expect
pkg/front_end/testcases/inference/generic_methods_iterable_and_future.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_correctly_on_multiple_variables_declared_together.dart.strong.expect
pkg/front_end/testcases/inference/infer_correctly_on_multiple_variables_declared_together.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_field_override_multiple.dart.strong.expect
pkg/front_end/testcases/inference/infer_from_complex_expressions_if_outer_most_value_is_precise.dart.strong.expect
pkg/front_end/testcases/inference/infer_from_complex_expressions_if_outer_most_value_is_precise.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_from_variables_in_non_cycle_imports_with_flag.dart.strong.expect
pkg/front_end/testcases/inference/infer_from_variables_in_non_cycle_imports_with_flag.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_from_variables_in_non_cycle_imports_with_flag2.dart.strong.expect
pkg/front_end/testcases/inference/infer_from_variables_in_non_cycle_imports_with_flag2.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_type_on_overridden_fields2.dart.strong.expect
pkg/front_end/testcases/inference/infer_type_on_overridden_fields2.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_type_on_overridden_fields4.dart.strong.expect
pkg/front_end/testcases/inference/infer_type_on_overridden_fields4.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_type_on_var.dart.strong.expect
pkg/front_end/testcases/inference/infer_type_on_var.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_type_on_var2.dart.strong.expect
pkg/front_end/testcases/inference/infer_type_on_var2.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_type_on_var_from_field.dart.strong.expect
pkg/front_end/testcases/inference/infer_type_on_var_from_field.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_type_on_var_from_top_level.dart.strong.expect
pkg/front_end/testcases/inference/infer_type_on_var_from_top_level.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_type_regardless_of_declaration_order_or_cycles.dart.strong.expect
pkg/front_end/testcases/inference/infer_type_regardless_of_declaration_order_or_cycles.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_type_regardless_of_declaration_order_or_cycles_b.dart.strong.expect
pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_3.dart.strong.expect
pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_3.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_4.dart.strong.expect
pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_4.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_5.dart.strong.expect
pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_5.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_in_library_cycle.dart.strong.expect
pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_in_library_cycle.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_in_library_cycle_a.dart.strong.expect
pkg/front_end/testcases/inference/infer_types_on_generic_instantiations_infer.dart.strong.expect
pkg/front_end/testcases/inference/infer_types_on_loop_indices_for_each_loop.dart.strong.expect
pkg/front_end/testcases/inference/infer_types_on_loop_indices_for_each_loop.dart.strong.transformed.expect
pkg/front_end/testcases/inference/infer_types_on_loop_indices_for_each_loop_async.dart.strong.expect
pkg/front_end/testcases/inference/infer_types_on_loop_indices_for_each_loop_async.dart.strong.transformed.expect
pkg/front_end/testcases/inference/inferred_initializing_formal_checks_default_value.dart.strong.expect
pkg/front_end/testcases/inference/inferred_initializing_formal_checks_default_value.dart.strong.transformed.expect
pkg/front_end/testcases/inference/instantiate_tearoff_of_call.dart.strong.expect
pkg/front_end/testcases/inference/list_literals.dart.strong.expect
pkg/front_end/testcases/inference/list_literals.dart.strong.transformed.expect
pkg/front_end/testcases/inference/list_literals_top_level.dart.strong.expect
pkg/front_end/testcases/inference/list_literals_top_level.dart.strong.transformed.expect
pkg/front_end/testcases/inference/local_return_and_yield.dart.strong.expect
pkg/front_end/testcases/inference/local_return_and_yield.dart.strong.transformed.expect
pkg/front_end/testcases/inference/map_literals.dart.strong.expect
pkg/front_end/testcases/inference/map_literals.dart.strong.transformed.expect
pkg/front_end/testcases/inference/map_literals_top_level.dart.strong.expect
pkg/front_end/testcases/inference/map_literals_top_level.dart.strong.transformed.expect
pkg/front_end/testcases/inference/mixin_inference_instantiate_to_bounds_1.dart.legacy.expect
pkg/front_end/testcases/inference/mixin_inference_instantiate_to_bounds_1.dart.legacy.transformed.expect
pkg/front_end/testcases/inference/mixin_inference_instantiate_to_bounds_1.dart.outline.expect
pkg/front_end/testcases/inference/mixin_inference_instantiate_to_bounds_2.dart.legacy.expect
pkg/front_end/testcases/inference/mixin_inference_instantiate_to_bounds_2.dart.legacy.transformed.expect
pkg/front_end/testcases/inference/mixin_inference_instantiate_to_bounds_2.dart.outline.expect
pkg/front_end/testcases/inference/mixin_inference_instantiate_to_bounds_3.dart.legacy.expect
pkg/front_end/testcases/inference/mixin_inference_instantiate_to_bounds_3.dart.legacy.transformed.expect
pkg/front_end/testcases/inference/mixin_inference_instantiate_to_bounds_3.dart.outline.expect
pkg/front_end/testcases/inference/mixin_inference_instantiate_to_bounds_3.dart.strong.expect
pkg/front_end/testcases/inference/mixin_inference_instantiate_to_bounds_3.dart.strong.transformed.expect
pkg/front_end/testcases/inference/mixin_inference_multiple_constraints.dart.legacy.expect
pkg/front_end/testcases/inference/mixin_inference_multiple_constraints.dart.legacy.transformed.expect
pkg/front_end/testcases/inference/mixin_inference_multiple_constraints.dart.outline.expect
pkg/front_end/testcases/inference/mixin_inference_non_trivial_constraints.dart.legacy.expect
pkg/front_end/testcases/inference/mixin_inference_non_trivial_constraints.dart.legacy.transformed.expect
pkg/front_end/testcases/inference/mixin_inference_non_trivial_constraints.dart.outline.expect
pkg/front_end/testcases/inference/mixin_inference_outwards_1.dart.legacy.expect
pkg/front_end/testcases/inference/mixin_inference_outwards_1.dart.legacy.transformed.expect
pkg/front_end/testcases/inference/mixin_inference_outwards_1.dart.outline.expect
pkg/front_end/testcases/inference/mixin_inference_outwards_2.dart.legacy.expect
pkg/front_end/testcases/inference/mixin_inference_outwards_2.dart.legacy.transformed.expect
pkg/front_end/testcases/inference/mixin_inference_outwards_2.dart.outline.expect
pkg/front_end/testcases/inference/mixin_inference_outwards_3.dart.legacy.expect
pkg/front_end/testcases/inference/mixin_inference_outwards_3.dart.legacy.transformed.expect
pkg/front_end/testcases/inference/mixin_inference_outwards_3.dart.outline.expect
pkg/front_end/testcases/inference/mixin_inference_outwards_3.dart.strong.expect
pkg/front_end/testcases/inference/mixin_inference_outwards_4.dart.legacy.expect
pkg/front_end/testcases/inference/mixin_inference_outwards_4.dart.legacy.transformed.expect
pkg/front_end/testcases/inference/mixin_inference_outwards_4.dart.outline.expect
pkg/front_end/testcases/inference/mixin_inference_outwards_4.dart.strong.expect
pkg/front_end/testcases/inference/mixin_inference_unification_1.dart.legacy.expect
pkg/front_end/testcases/inference/mixin_inference_unification_1.dart.legacy.transformed.expect
pkg/front_end/testcases/inference/mixin_inference_unification_1.dart.outline.expect
pkg/front_end/testcases/inference/mixin_inference_unification_1.dart.strong.expect
pkg/front_end/testcases/inference/mixin_inference_unification_2.dart.legacy.expect
pkg/front_end/testcases/inference/mixin_inference_unification_2.dart.legacy.transformed.expect
pkg/front_end/testcases/inference/mixin_inference_unification_2.dart.outline.expect
pkg/front_end/testcases/inference/mixin_inference_unification_2.dart.strong.expect
pkg/front_end/testcases/inference/propagate_inference_transitively.dart.strong.expect
pkg/front_end/testcases/inference/propagate_inference_transitively.dart.strong.transformed.expect
pkg/front_end/testcases/inference/top_level_return_and_yield.dart.strong.expect
pkg/front_end/testcases/inference/top_level_return_and_yield.dart.strong.transformed.expect
pkg/front_end/testcases/inference_new/for_each_invalid_iterable.dart.strong.expect
pkg/front_end/testcases/inference_new/for_each_invalid_iterable.dart.strong.transformed.expect
pkg/front_end/testcases/inference_new/for_each_outer_var_type.dart.strong.expect
pkg/front_end/testcases/inference_new/for_each_outer_var_type.dart.strong.transformed.expect
pkg/front_end/testcases/inference_new/infer_assign_to_index_super_upwards.dart.strong.expect
pkg/front_end/testcases/inference_new/infer_assign_to_index_this_upwards.dart.strong.expect
pkg/front_end/testcases/inference_new/infer_assign_to_index_upwards.dart.strong.expect
pkg/front_end/testcases/inference_new/infer_assign_to_property_custom.dart.strong.expect
pkg/front_end/testcases/inference_new/infer_field_getter_setter_mismatch.dart.strong.expect
pkg/front_end/testcases/inference_new/infer_field_override_getter_overrides_setter.dart.strong.expect
pkg/front_end/testcases/inference_new/invalid_assignment_during_toplevel_inference.dart.strong.expect
pkg/front_end/testcases/instantiate_to_bound/inference_super_bounded_rejected.dart.strong.expect
pkg/front_end/testcases/instantiate_to_bound/inference_super_bounded_rejected.dart.strong.transformed.expect
pkg/front_end/testcases/instantiate_to_bound/non_simple_from_compiled.dart.strong.expect
pkg/front_end/testcases/instantiate_to_bound/non_simple_from_compiled.dart.strong.transformed.expect
pkg/front_end/testcases/invalid_assignment.dart.strong.expect
pkg/front_end/testcases/invalid_assignment.dart.strong.transformed.expect
pkg/front_end/testcases/invalid_cast.dart.strong.expect
pkg/front_end/testcases/invalid_cast.dart.strong.transformed.expect
pkg/front_end/testcases/invalid_type.dart.strong.expect
pkg/front_end/testcases/optional.dart.strong.expect
pkg/front_end/testcases/override_check_accessor_after_inference.dart.strong.expect
pkg/front_end/testcases/override_check_accessor_basic.dart.strong.expect
pkg/front_end/testcases/override_check_accessor_with_covariant_modifier.dart.strong.expect
pkg/front_end/testcases/override_check_after_inference.dart.strong.expect
pkg/front_end/testcases/override_check_basic.dart.strong.expect
pkg/front_end/testcases/override_check_with_covariant_modifier.dart.strong.expect
pkg/front_end/testcases/rasta/constant_get_and_invoke.dart.strong.expect
pkg/front_end/testcases/rasta/constant_get_and_invoke.dart.strong.transformed.expect
pkg/front_end/testcases/rasta/generic_factory.dart.strong.expect
pkg/front_end/testcases/rasta/generic_factory.dart.strong.transformed.expect
pkg/front_end/testcases/rasta/issue_000032.dart.strong.expect
pkg/front_end/testcases/rasta/issue_000032.dart.strong.transformed.expect
pkg/front_end/testcases/rasta/issue_000044.dart.strong.expect
pkg/front_end/testcases/rasta/issue_000044.dart.strong.transformed.expect
pkg/front_end/testcases/rasta/issue_000046.dart.strong.expect
pkg/front_end/testcases/rasta/issue_000046.dart.strong.transformed.expect
pkg/front_end/testcases/rasta/static.dart.strong.expect
pkg/front_end/testcases/rasta/static.dart.strong.transformed.expect
pkg/front_end/testcases/rasta/super.dart.strong.expect
pkg/front_end/testcases/redirecting_factory.dart.strong.expect
pkg/front_end/testcases/redirecting_factory.dart.strong.transformed.expect
pkg/front_end/testcases/redirecting_initializer_arguments_test.dart.strong.expect
pkg/front_end/testcases/redirecting_initializer_arguments_test.dart.strong.transformed.expect
pkg/front_end/testcases/regress/issue_31155.dart.strong.expect
pkg/front_end/testcases/regress/issue_31155.dart.strong.transformed.expect
pkg/front_end/testcases/regress/issue_31188.dart.strong.expect
pkg/front_end/testcases/regress/issue_31188.dart.strong.transformed.expect
pkg/front_end/testcases/regress/issue_32200.dart.strong.expect
pkg/front_end/testcases/regress/issue_32200.dart.strong.transformed.expect
pkg/front_end/testcases/regress/issue_34225.dart.strong.expect
pkg/front_end/testcases/regress/issue_34225.dart.strong.transformed.expect
pkg/front_end/testcases/regress/issue_34563.dart.strong.expect
pkg/front_end/testcases/regress/issue_34563.dart.strong.transformed.expect
pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart.strong.expect
pkg/front_end/testcases/runtime_checks/covariant_generic_method_type_parameter.dart.strong.transformed.expect
pkg/front_end/testcases/runtime_checks_new/contravariant_generic_return_with_compound_assign_implicit_downcast.dart.strong.expect
pkg/front_end/testcases/runtime_checks_new/contravariant_generic_return_with_compound_assign_implicit_downcast.dart.strong.transformed.expect
pkg/front_end/testcases/runtime_checks_new/contravariant_getter_return_compound_assign.dart.strong.expect
pkg/front_end/testcases/runtime_checks_new/contravariant_getter_return_compound_assign.dart.strong.transformed.expect
pkg/front_end/testcases/runtime_checks_new/mixin_forwarding_stub_field.dart.strong.expect
pkg/front_end/testcases/runtime_checks_new/mixin_forwarding_stub_getter.dart.strong.expect
pkg/front_end/testcases/runtime_checks_new/mixin_forwarding_stub_setter.dart.strong.expect
pkg/front_end/testcases/statements.dart.strong.expect
pkg/front_end/testcases/type_variable_prefix.dart.strong.expect
pkg/front_end/testcases/type_variable_prefix.dart.strong.transformed.expect
pkg/front_end/testcases/undefined.dart.strong.expect
pkg/front_end/testcases/undefined.dart.strong.transformed.expect
pkg/front_end/testcases/undefined_getter_in_compound_assignment.dart.strong.expect
pkg/front_end/testcases/undefined_getter_in_compound_assignment.dart.strong.transformed.expect
pkg/front_end/tool/_fasta/generate_messages.dart

Use new type labeler API in message generation.

Changed by	Aske Simon Christensen - askescohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 13:27:16 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	5198e49ffdeaf93e45e04e338becf509ac43a663

Comments

Use new type labeler API in message generation.

For now, it uses a dummy implementation that retains the old behavior.

Change-Id: Iab358b73af470b99d5bd0ed59028d96d26bae47f
Reviewed-on: https://dart-review.googlesource.com/c/84603
Reviewed-by: Peter von der Ahé <ahe@google.com>

Changed files

pkg/front_end/lib/src/fasta/fasta_codes.dart
pkg/front_end/lib/src/fasta/fasta_codes_generated.dart
pkg/front_end/lib/src/fasta/kernel/dummy_type_labeler.dart
pkg/front_end/tool/_fasta/generate_messages.dart

New printer for types and constants

Changed by	Aske Simon Christensen - askescohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 13:27:16 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	aed186ad1094f6b62e7e833fdcfadc3f1d331edd

Comments

New printer for types and constants

Adds labels to ambiguous types and generates a bullet list of the
origins of all raw types contained in printed types.

Change-Id: I9b8a46aa8b1f463c6cd02b9df042075fc1c46404
Reviewed-on: https://dart-review.googlesource.com/c/84602
Reviewed-by: Peter von der Ahé <ahe@google.com>

Changed files

pkg/front_end/lib/src/fasta/fasta_codes_generated.dart
pkg/front_end/lib/src/fasta/kernel/type_labeler.dart
pkg/front_end/messages.yaml
pkg/front_end/test/type_labeler_test.dart

Separate names of blacklisted core classes into their own file.

Changed by	Aske Simon Christensen - askescohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 13:27:16 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	c632e7cc6d3c2bc7769ea29127901af946e37997

Comments

Separate names of blacklisted core classes into their own file.

Change-Id: Idcb3a5f2179ef2e87e9ad17dbb38bac596218b8d
Reviewed-on: https://dart-review.googlesource.com/c/84601
Reviewed-by: Peter von der Ahé <ahe@google.com>

Changed files

pkg/front_end/lib/src/fasta/blacklisted_classes.dart
pkg/front_end/lib/src/fasta/source/source_loader.dart

[VM] Free the current working directory string if we happen to re-initialize the VM

Changed by	Martin Kustermann - kustermannohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 11:44:10 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	44f7295195d2532017bb11f4287f8942c6b1bce2

Comments

[VM] Free the current working directory string if we happen to re-initialize the VM

This is an attempt to fix a flakily reported ASAN leak of the form:

  Direct leak of 28 byte(s) in 1 object(s) allocated from:
      #0 0x55827f0dacf2 in __interceptor_realloc /b/s/w/ir/kitchen-workdir/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cc:107:3
      #1 0x7f52fe7a41ca in getcwd (/lib/x86_64-linux-gnu/libc.so.6+0xf01ca)

  SUMMARY: AddressSanitizer: 28 byte(s) leaked in 1 allocation(s).
Change-Id: I7c76be43eecd2c445631af22a93c710df93379f4
Reviewed-on: https://dart-review.googlesource.com/c/85562
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>

Changed files

runtime/bin/dartutils.cc

[Gardening] Update status file to extend test markers from Crash to Timeout (on MacOS)

Changed by	Martin Kustermann - kustermannohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 11:12:54 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	d93c19acb901615d58f16e0bfb69ae29a4f5608c

Comments

[Gardening] Update status file to extend test markers from Crash to Timeout (on MacOS)

Issue https://github.com/dart-lang/sdk/issues/35275

Change-Id: I95f72ab6eb2736c90c1b6bfe193f3c6410c8b83a
Reviewed-on: https://dart-review.googlesource.com/c/85560
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

Changed files

runtime/tests/vm/vm.status

Remove unused kernel/lib/application_root.dart

Changed by	Jens Johansen - jensjohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 08:08:33 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	56bccac775e4eb2d03cf3ea0c68725dbc80f3dc1

Comments

Remove unused kernel/lib/application_root.dart

Change-Id: If02becd542935c9e9db6cbfdf8a40b47a712cd7c
Reviewed-on: https://dart-review.googlesource.com/c/85481
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>

Changed files

pkg/kernel/lib/application_root.dart

Remove unused dependencies on logging and package_config

Changed by	Jens Johansen - jensjohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 08:08:23 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	9c7bdf4aaeb125f4aa4a1b8ec9cd3132abd2804d

Comments

Remove unused dependencies on logging and package_config

package_config was not used at all.
logging was only used by kernel/lib/log.dart which in turn was not used
at all.

Change-Id: If57f084661c5cc1c361fb38555e903ec3f724904
Reviewed-on: https://dart-review.googlesource.com/c/85480
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>

Changed files

pkg/kernel/lib/log.dart
pkg/kernel/pubspec.yaml

Add LocalState to KernelTypeGraphBuilder

Changed by	Johnni Winther - johnniwintherohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 07:33:18 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	b52182ee142bfa3a5202df13d65f4d9ace0e3328

Comments

Add LocalState to KernelTypeGraphBuilder

Move LocalsHandler.seenBreakOrContinue/seenReturnOrThrow/_tryBlock to LocalState
Move KernelTypeGraphBuilder._locals and KernelTypeGraphBuilder._fieldScope from visitor to LocalState

Change-Id: I712558ab3d18c6196fb5b96a4f8084d44848b83b
Reviewed-on: https://dart-review.googlesource.com/c/85444
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>

Changed files

pkg/compiler/lib/src/inferrer/builder_kernel.dart
pkg/compiler/lib/src/inferrer/locals_handler.dart

Remove sha1 impl from dart2js

Changed by	Kevin Moore - kevmooohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 04:28:02 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	be5d0cca5cc5af59394c52a1e120f85f11dc7291

Comments

Remove sha1 impl from dart2js

pkg:crypto has a fine implementation
Change-Id: Ibefd6c294259c58cd4eb3ac8f5718a078894a39b
Reviewed-on: https://dart-review.googlesource.com/c/85415
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>

Changed files

pkg/compiler/lib/src/hash/sha1.dart
pkg/compiler/pubspec.yaml
tests/compiler/dart2js/analyses/dart2js_allowed.json
tests/compiler/dart2js/model/sha1_long_test_vectors.dart
tests/compiler/dart2js/model/sha1_short_test_vectors.dart
tests/compiler/dart2js/model/sha1_test.dart

Revert "[vm/compiler] Express control dependence as data dependence."

Changed by	Aart Bik - ajcbikohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 03:02:17 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	ef419f68f92460792156c68e3f41e7246ed4ccf9

Comments

Revert "[vm/compiler] Express control dependence as data dependence."

This reverts commit 41f3d4326ee7fa7a075e96ab95f8f943a0cb1bcc.

Reason for revert: I hit +2 by accident when I wanted to submit do a dry run

Original change's description:
> [vm/compiler] Express control dependence as data dependence.
> 
> Rationale:
> This provides a more robust way of expressing control
> dependences between bounds checks and their uses, while
> still allowing for CSE and LICM where possible.
> This also fixes the original bug that started this
> whole redesign: invalid LICM of checkbound.
> 
> Note:
> Deals with bounds check, null check still TBD.
> 
> Mini design doc:
> runtime/docs/compiler/data_dep_for_control_dep.md
> 
> https://github.com/dart-lang/sdk/issues/35139
> https://github.com/dart-lang/sdk/issues/34684
> https://github.com/dart-lang/sdk/issues/30633
> 
> Change-Id: Icfbd3ca60662e37046e48b95be7f81d05d94af88
> Reviewed-on: https://dart-review.googlesource.com/c/85470
> Commit-Queue: Aart Bik <ajcbik@google.com>
> Reviewed-by: Alexander Markov <alexmarkov@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

TBR=vegorov@google.com,kustermann@google.com,rmacnak@google.com,alexmarkov@google.com,asiva@google.com,ajcbik@google.com

Change-Id: Id20699f957681c248851b37d545b330fd4972d7a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/85522
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>

Changed files

runtime/docs/compiler/data_dep_for_control_dep.md
runtime/vm/compiler/aot/aot_call_specializer.cc
runtime/vm/compiler/aot/aot_call_specializer.h
runtime/vm/compiler/backend/constant_propagator.cc
runtime/vm/compiler/backend/flow_graph.cc
runtime/vm/compiler/backend/flow_graph.h
runtime/vm/compiler/backend/il.cc
runtime/vm/compiler/backend/il.h
runtime/vm/compiler/backend/inliner.cc
runtime/vm/compiler/backend/loops.cc
runtime/vm/compiler/backend/range_analysis.cc
runtime/vm/compiler/backend/redundancy_elimination.cc
runtime/vm/compiler/compiler_pass.cc
runtime/vm/compiler/compiler_pass.h
runtime/vm/compiler/intrinsifier.cc
tests/language_2/vm/regress_34684_test.dart

[vm/compiler] Express control dependence as data dependence.

Changed by	Aart Bik - ajcbikohnoyoudont@google.com
Changed at	Thursday, 29-Nov-18 01:47:18 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	41f3d4326ee7fa7a075e96ab95f8f943a0cb1bcc

Comments

[vm/compiler] Express control dependence as data dependence.

Rationale:
This provides a more robust way of expressing control
dependences between bounds checks and their uses, while
still allowing for CSE and LICM where possible.
This also fixes the original bug that started this
whole redesign: invalid LICM of checkbound.

Note:
Deals with bounds check, null check still TBD.

Mini design doc:
runtime/docs/compiler/data_dep_for_control_dep.md

https://github.com/dart-lang/sdk/issues/35139
https://github.com/dart-lang/sdk/issues/34684
https://github.com/dart-lang/sdk/issues/30633

Change-Id: Icfbd3ca60662e37046e48b95be7f81d05d94af88
Reviewed-on: https://dart-review.googlesource.com/c/85470
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

Changed files

runtime/docs/compiler/data_dep_for_control_dep.md
runtime/vm/compiler/aot/aot_call_specializer.cc
runtime/vm/compiler/aot/aot_call_specializer.h
runtime/vm/compiler/backend/constant_propagator.cc
runtime/vm/compiler/backend/flow_graph.cc
runtime/vm/compiler/backend/flow_graph.h
runtime/vm/compiler/backend/il.cc
runtime/vm/compiler/backend/il.h
runtime/vm/compiler/backend/inliner.cc
runtime/vm/compiler/backend/loops.cc
runtime/vm/compiler/backend/range_analysis.cc
runtime/vm/compiler/backend/redundancy_elimination.cc
runtime/vm/compiler/compiler_pass.cc
runtime/vm/compiler/compiler_pass.h
runtime/vm/compiler/intrinsifier.cc
tests/language_2/vm/regress_34684_test.dart

Relax front_end's pubspec SDK requirement

Changed by	Paul Berry - paulberryohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 22:02:22 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	03b7ade6b733a2e49d0ea58dc189aa48a12df958

Comments

Relax front_end's pubspec SDK requirement

This is necessary in order for the latest version of the front_end to
be used with Flutter, since Flutter is currently pinned to version
2.1.0-dev.9.4.flutter-f9ebf21297.

Change-Id: Ic556ca900c2e839d9e5c36d199bf30779a323623
Reviewed-on: https://dart-review.googlesource.com/c/85544
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>

Changed files

pkg/front_end/pubspec.yaml

Introduce replacement for AstNode.getAncestor (master)

Changed by	Brian Wilkerson - brianwilkersonohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 20:59:03 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	5bff334f84f5ce08cd7d10f9185ea150621aba1f

Comments

Introduce replacement for AstNode.getAncestor (master)

Change-Id: Ib93cf9b9c19b3db2b971f83ae871442db244ec38
Reviewed-on: https://dart-review.googlesource.com/c/85541
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>

Changed files

pkg/analyzer/CHANGELOG.md
pkg/analyzer/lib/dart/ast/ast.dart
pkg/analyzer/lib/src/dart/ast/ast.dart

Fix set literal optimization

Changed by	danrubel - danrubelohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 19:24:58 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	80c4d3e3c70ba8d0dfcc3fd038f29a388652cf3b

Comments

Fix set literal optimization

This fixes a bug in the parsing set literal optimization
https://dart-review.googlesource.com/c/sdk/+/84661

and the additional tests are on the analyzer branch in
https://dart-review.googlesource.com/c/sdk/+/85429

Change-Id: I518352a131bf444ff3536ee1fc9a27ad4e5bb114
Reviewed-on: https://dart-review.googlesource.com/c/85430
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

Changed files

pkg/front_end/lib/src/fasta/parser/parser.dart

[vm] Fix gcc build.

Changed by	Ryan Macnak - rmacnakohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 17:53:13 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	581468fa63f5877825bd9032219557052ff8da82

Comments

[vm] Fix gcc build.

Change-Id: I16b29aa813956c7235307e2c811a9bc457ead4ae
Reviewed-on: https://dart-review.googlesource.com/c/85468
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

Changed files

runtime/vm/isolate_reload.cc
runtime/vm/object.cc
runtime/vm/raw_object_snapshot.cc
runtime/vm/stack_frame.cc

Reduce dependency on library spec from dart2js

Changed by	Sigmund Cherem - sigmundohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 17:12:11 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	e9e70f0922fec4cd9d93e16153b4b13897c3c944

Comments

Reduce dependency on library spec from dart2js

Change-Id: I0d55b380f135d2e45a0dd112336bd87085e38c76
Reviewed-on: https://dart-review.googlesource.com/c/85471
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>

Changed files

pkg/compiler/lib/src/apiimpl.dart
pkg/front_end/lib/src/api_unstable/dart2js.dart
pkg/front_end/lib/src/base/libraries_specification.dart

[infra] Add --keep-files flag to tools/test.py

Changed by	Martin Kustermann - kustermannohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 16:44:15 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	5d7786948cca6b292f6d26313f745e786a910761

Comments

[infra] Add --keep-files flag to tools/test.py

This allows one to actually run the commands which are printed in a
failure.

Change-Id: I62c8a387c37d3563ea3c0f803c107e2e9d8262bb
Reviewed-on: https://dart-review.googlesource.com/c/85483
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>

Changed files

pkg/smith/lib/configuration.dart
tools/testing/dart/compiler_configuration.dart
tools/testing/dart/configuration.dart
tools/testing/dart/options.dart
tools/testing/dart/test_configurations.dart

Use readAsBytesSync in standard_file_system.dart as it is faster

Changed by	Jens Johansen - jensjohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 12:02:21 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	43113760f2ea114c183f8965b0d48fbb7469dc7f

Comments

Use readAsBytesSync in standard_file_system.dart as it is faster

Timing how long fasta spends on *reading* files when compiling dart2js
(when compiling via the VM) I get a good speedup:

Difference at 95.0% confidence
        -84031.2 +/- 10333.7
        -47.4004% +/- 5.82904%
        (Student's t, pooled s = 7085.44)

Change-Id: I0bb1a1fe6f9d430b47515b9b319069bf810d0aeb
Reviewed-on: https://dart-review.googlesource.com/c/85442
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>

Changed files

pkg/front_end/lib/src/api_prototype/standard_file_system.dart

[infra] Fix approve_results reporting wrong number of changed tests

Changed by	Jonas Termansen - sortieohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 11:28:37 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	25f0c21c81201046436d44d011bfb3f1913c5cfe

Comments

[infra] Fix approve_results reporting wrong number of changed tests

Change-Id: I70afb4319dfd83a38897582b4d3e93113953fdba
Reviewed-on: https://dart-review.googlesource.com/c/85447
Reviewed-by: Alexander Thomas <athom@google.com>

Changed files

tools/approve_results.dart

Remove obsolete log types from test.py

Changed by	William Hesse - whesseohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 11:15:04 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	f780b6ea84bfcacba433bcab81bfa8e587e77901

Comments

Remove obsolete log types from test.py

Removes the flaky log, result.log result format, test outcome log,
and --append-logs option from test.py. They are replaced by the
new --write-results and --write-logs options.

The debug log is now always appended to, if it is written to a file.

Change-Id: I20dbbc1db86ef23a19ac4ea02067f18ae4906b3d
Reviewed-on: https://dart-review.googlesource.com/c/85440
Reviewed-by: Jonas Termansen <sortie@google.com>

Changed files

tools/testing/dart/configuration.dart
tools/testing/dart/options.dart
tools/testing/dart/test_configurations.dart
tools/testing/dart/test_progress.dart
tools/testing/dart/utils.dart

Cleanup of ast_to_binary

Changed by	Jens Johansen - jensjohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 10:57:01 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	498994487bcfebca0859918eb7e3e45ddb09cd07

Comments

Cleanup of ast_to_binary

Change-Id: Ib065dd32c23c88f64b668a6b9bcefbdb4a8e038d
Reviewed-on: https://dart-review.googlesource.com/c/85241
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>

Changed files

pkg/kernel/lib/binary/ast_to_binary.dart
pkg/kernel/lib/binary/limited_ast_to_binary.dart

Only one source of truth for uriToSource

Changed by	Jens Johansen - jensjohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 10:57:01 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	1ec63ec7d50fe7c73a9569b1002317d1427a0632

Comments

Only one source of truth for uriToSource

Previously we had several places where different uriToSource was used.
This was both weird and led to errors when something refering to
some state was used to look up in another state.
This CL makes it so we only have one source of truth.

To not include sdk sources when serializing a component that only mixes
something from the sdk in, (or extends it or...), the serialization is
changed slightly to keep track of which uris come from actual
implementation. Before the sdk sources was explicitly removed in the
incremental compiler, but we want to limit those kinds of things,
which is why we're doing it differently here.

Fixes #35215.

Bug: 35215
Change-Id: Iaa5618fcb0ea42b13aba7720f34a87a85144e047
Reviewed-on: https://dart-review.googlesource.com/c/85175
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>

Changed files

pkg/front_end/lib/src/fasta/dill/dill_loader.dart
pkg/front_end/lib/src/fasta/get_dependencies.dart
pkg/front_end/lib/src/fasta/incremental_compiler.dart
pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
pkg/front_end/lib/src/fasta/testing/kernel_chain.dart
pkg/front_end/test/incremental_dart2js_load_from_dill_test.dart
pkg/front_end/testcases/incremental_initialize_from_dill/regress_35215.yaml
pkg/front_end/tool/_fasta/entry_points.dart
pkg/kernel/lib/ast.dart
pkg/kernel/lib/binary/ast_to_binary.dart

Fix invalidating part specified via package uri via file uri

Changed by	Jens Johansen - jensjohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 10:53:21 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	89936a2a0f977a2aef58b9ef4692bac2b1640020

Comments

Fix invalidating part specified via package uri via file uri

In the incremental compiler, if asking to invalidate a file via a file
uri, where the corresponding file is a part that has been used via its
package uri (as in "part 'package:foo/whatever.dart'"), we should still
invalidate it.

Before we didn't because we 'translated' the part uri to a 'file uri'
except it was still a package uri.
Now we do.

Change-Id: I276c6e7c772d6167178fa8b6594417d37d1dd1c4
Reviewed-on: https://dart-review.googlesource.com/c/85344
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>

Changed files

pkg/front_end/lib/src/fasta/incremental_compiler.dart
pkg/front_end/testcases/incremental_initialize_from_dill/invalidate_package_part_from_package_url_as_file.yaml
pkg/front_end/testcases/incremental_initialize_from_dill/invalidate_package_part_from_package_url_as_package.yaml

Reland "[VM] Inline ClassID.getID() eagerly, extend pattern matching logic to recognize it, use it to special case ascii decoding"

Changed by	Martin Kustermann - kustermannohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 10:43:32 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	f5d122908101ede85c58998b07d55a2a5db09572

Comments

Reland "[VM] Inline ClassID.getID() eagerly, extend pattern matching logic to recognize it, use it to special case ascii decoding"

This change extends/fixes the exiting "pattern recognition" which tries
to recognize the pattern

  v2 <- LoadClassIdInstr(v1)
  BranchIf v2 == IntegerConstant(cid)

Furthermore we start inlining the recognized `ClassID.getID` method very
early in the pipeline.  This allows the VM to recognize the above
pattern and insert redefinitions before the actual inlining pass.

Furthermore we special-case two very hot methods in utf8 decoding by
manually having two loops, one of which is guarded by a class-id check
against the _Uint8ArrayView class, which is most common.  (In the future
we would like to unify the typed data layouts so we no longer need to
use `ClassId.getID`, thereby also allowing non core library code to use
this).

This improves dart-aot by
  * 31%+ for a protobuf decoding benchmark we care about

Issue https://github.com/dart-lang/sdk/issues/31954

Change-Id: I7181bbf096aabe303634fd3b2bff9cc96d69719c
Reviewed-on: https://dart-review.googlesource.com/c/85443
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>

Changed files

pkg/dev_compiler/tool/input_sdk/patch/convert_patch.dart
runtime/bin/BUILD.gn
runtime/bin/process_fuchsia.cc
runtime/lib/class_id.dart
runtime/lib/class_id_fasta.dart
runtime/lib/convert_patch.dart
runtime/lib/string_patch.dart
runtime/vm/compiler/backend/inliner.cc
runtime/vm/object.cc
runtime/vm/symbols.h
sdk/lib/_internal/js_runtime/lib/convert_patch.dart
sdk/lib/convert/utf.dart

[VM] Remove dead code in precompiler

Changed by	Martin Kustermann - kustermannohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 10:36:09 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	c9a8589ba6e842db4fea87a02133de7fcfe29d5a

Comments

[VM] Remove dead code in precompiler

Our precompiler uses the kernel2kernel constant evaluator. It no longer
execute code during AOT compilation.

Change-Id: Ic70d4d4ebb9ff036fdcb2f4027f28872913ba556
Reviewed-on: https://dart-review.googlesource.com/c/85446
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>

Changed files

runtime/vm/compiler/aot/precompiler.cc
runtime/vm/compiler/aot/precompiler.h
runtime/vm/compiler/jit/compiler.cc

[VM] Ensure we handle devirtualized calls inside ApplyClassIds() as well

Changed by	Martin Kustermann - kustermannohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 09:21:00 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	4aff8f93fb85c19f53cf4a4e54208ece4bd4011c

Comments

[VM] Ensure we handle devirtualized calls inside ApplyClassIds() as well

After recent changes to pragmas, TFA devirtualizes more calls, which has
regressed a Prime

This gets rid of the 5% regression in PrimeNumber/PrimeNumberTyped in
dart-aot (which 0ef66e0f5 introduced). Furthermore it improves MD5/SHA
by double digits percent.

Change-Id: Ia4d1fb62512495dec7111efc53c4d7a4de5ef3af
Reviewed-on: https://dart-review.googlesource.com/c/85398
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>

Changed files

runtime/vm/compiler/call_specializer.cc

Clarify doc for Duration equals

Changed by	Nate Bosch - nboschohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 08:29:57 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	e25c7441381a27344246b27bcb0ebb5af8fd9e72

Comments

Clarify doc for Duration equals

Fixes #35273

Previous wording made it seem like the behavior was the same as
`identical`.

Change-Id: Ib7fdb183a26a4e2b3c849dd72cb515aa1652028d
Reviewed-on: https://dart-review.googlesource.com/c/85465
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>

Changed files

sdk/lib/core/duration.dart

[gardening] Restrict timeout status to MacOS.

Changed by	Régis Crelier - regisohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 00:47:52 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	a3874044e7bb7211327143f66c77cf9a702a0576

Comments

[gardening] Restrict timeout status to MacOS.

This modifies recent commit 25262fe9.

Change-Id: I19f8bc5bcefacbf761479869f79140702c37305b
Reviewed-on: https://dart-review.googlesource.com/c/85464
Auto-Submit: Régis Crelier <regis@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>

Changed files

runtime/tests/vm/vm.status

linter 0.1.73

Changed by	pq - pquitslundohnoyoudont@google.com
Changed at	Wednesday, 28-Nov-18 00:19:52 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	801cea545df3bb00b138ff1f22d6b26ed67aaa25

Comments

linter 0.1.73

# 0.1.73

* deprecated `prefer_bool_in_asserts` (redundant w/ Dart 2 checks)
* improved doc generation to highlight deprecated and experimental lints
* bumped analyzer lower-bound to `0.33.4`
* bumped SDK lower-bound to `2.1.0`
* new lint: `unnecessary_await_in_return`


Change-Id: I00bf626029d8e1290193e3e83a9894f175046048
Reviewed-on: https://dart-review.googlesource.com/c/85425
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>

Changed files

CHANGELOG.md
DEPS

Revert "Reland: [infra] Roll buildtools to c72a1c5aadde06505b7bb4641720880f3db28ff9"

Changed by	Zach Anderson - zraohnoyoudont@google.com
Changed at	Tuesday, 27-Nov-18 23:35:08 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	44a9d0a0d66d83a20d3ff672a4ec1d7fdaf8fc95

Comments

Revert "Reland: [infra] Roll buildtools to c72a1c5aadde06505b7bb4641720880f3db28ff9"

This reverts commit ad69aaef6232957087fff0815c591c18b0adeb8f.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland: [infra] Roll buildtools to c72a1c5aadde06505b7bb4641720880f3db28ff9
> 
> Tries to work around update.py race by setting up symlinks for 'git cl format'
> instead of copying.
> 
> Change-Id: I4ed9b99254803feea5ea0e8d30db23fc982e9562
> Reviewed-on: https://dart-review.googlesource.com/c/85427
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
> Commit-Queue: Zach Anderson <zra@google.com>

TBR=rmacnak@google.com,zra@google.com

Change-Id: Ida584adda37cd3e2dac16654eb1e81e92f123f88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/85467
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>

Changed files

DEPS
build/config/android/config.gni
build/config/compiler/BUILD.gn
tools/buildtools/update.py

Reland: [infra] Roll buildtools to c72a1c5aadde06505b7bb4641720880f3db28ff9

Changed by	Zach Anderson - zraohnoyoudont@google.com
Changed at	Tuesday, 27-Nov-18 23:02:59 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	ad69aaef6232957087fff0815c591c18b0adeb8f

Comments

Reland: [infra] Roll buildtools to c72a1c5aadde06505b7bb4641720880f3db28ff9

Tries to work around update.py race by setting up symlinks for 'git cl format'
instead of copying.

Change-Id: I4ed9b99254803feea5ea0e8d30db23fc982e9562
Reviewed-on: https://dart-review.googlesource.com/c/85427
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>

Changed files

DEPS
build/config/android/config.gni
build/config/compiler/BUILD.gn
tools/buildtools/update.py

Backport AnalysisSession.getResolvedLibrary()/ByElement().

Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
Changed at	Tuesday, 27-Nov-18 22:53:24 UTC
Repository	https://dart.googlesource.com/sdk
Branch
Revision	232aa553fb97dbc2790b19363d85e2a7b74e6e27

Comments

Backport AnalysisSession.getResolvedLibrary()/ByElement().

Change-Id: I83c1dbe9d758be12212fcd892bb57ae69407d8be
Reviewed-on: https://dart-review.googlesource.com/c/85147
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>

Changed files

pkg/analyzer/lib/dart/analysis/session.dart
pkg/analyzer/lib/src/dart/analysis/driver.dart
pkg/analyzer/lib/src/dart/analysis/file_state.dart
pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
pkg/analyzer/lib/src/dart/analysis/results.dart
pkg/analyzer/lib/src/dart/analysis/session.dart
pkg/analyzer/test/src/dart/analysis/driver_test.dart
pkg/analyzer/test/src/dart/analysis/session_test.dart

<blame list capped at 100 commits>

Changed by	<blame list capped at 100 commits> -
Changed at	N/A
Repository
Branch
Revision

Comments

<blame list capped at 100 commits>