Builder vm-kernel-precomp-linux-release-simarm-dev Build 49

Results:

Failure approve unapproved successes

Trigger Info:

Project	dart
Revision	e7c21c2255a0294320315b58b6d1f7df30d136c5
Got Revision	e7c21c2255a0294320315b58b6d1f7df30d136c5

Execution:

• Source: Task 42d249d48f0d4910
• Bot: trusty-dart-68765ebb-us-central1-b-mdf9
• Recipe: dart/neo

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 204 ms ) setup_build

   running recipe: "dart/neo"
   • stdout
   • run_recipe
2. ( 2 secs ) gsutil find latest build
   • stdout
   • raw_io.output_text[latest]
3. ( 1 secs ) gsutil get revision for latest build
   • stdout
   • raw_io.output_text[revision]
4. ( 107 ms ) ensure_goma
   • - no logs -
   1. ( 107 ms ) ensure_installed
      • stdout
      • json.output
5. ( 32 secs ) bot_update

   [43GB/295GB used (14%)]
   • stdout
   • json.output
6. ( 432 ms ) clobber
   • stdout
7. ( 1 mins 13 secs ) gclient runhooks
   • stdout
8. ( 517 ms ) kill processes
   • stdout
9. ( 340 ms ) read test-matrix.json
   • stdout
   • json.output
10. ( 411 ms ) delete debug log
    • stdout
11. ( 450 ms ) write fileset analyzer_unit_tests to sdk root
    • stdout
12. ( 455 ms ) write fileset dart2js to sdk root
    • stdout
13. ( 453 ms ) write fileset dart2js_hostasserts to sdk root
    • stdout
14. ( 464 ms ) write fileset fuzzer to sdk root
    • stdout
15. ( 454 ms ) write fileset vm-kernel to sdk root
    • stdout
16. ( 360 ms ) gclient get checked-in SDK version
    • stdout
    • raw_io.output_text
17. ( 381 ms ) gclient get co19 version
    • stdout
    • raw_io.output_text
18. ( 103 ms ) git show
    • stdout
19. ( 525 ms ) kill processes (2)
    • stdout
20. ( 3 secs ) preprocess_for_goma
    • - no logs -
    1. ( 716 ms ) goma cache directory
       • stdout
    2. ( 881 ms ) start_goma
       • stdout
       • cloudtail
    3. ( 1 secs ) start cloudtail
       • stdout
21. ( 1 mins 31 secs ) build dart
    • stdout
22. ( 8 secs ) postprocess_for_goma
    • - no logs -
    1. ( 517 ms ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 516 ms ) goma_stat
       • stdout
    3. ( 519 ms ) stop_goma
       • stdout
    4. ( 5 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
    5. ( 1 secs ) stop cloudtail
       • stdout
23. ( 34 secs ) upload testing fileset vm-kernel

    swarming fileset hash: 40ceca6d431121376fbebcbb671ee4a2e19b3283
    • stdout
24. ( 11 secs ) trigger shards for vm tests
    • - no logs -
    1. ( 1 secs ) [trigger] vm tests_shard_1

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    2. ( 1 secs ) [trigger] vm tests_shard_2

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    3. ( 1 secs ) [trigger] vm tests_shard_3

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    4. ( 1 secs ) [trigger] vm tests_shard_4

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    5. ( 1 secs ) [trigger] vm tests_shard_5

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    6. ( 1 secs ) [trigger] vm tests_shard_6

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    7. ( 1 secs ) [trigger] vm tests_shard_7

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    8. ( 1 secs ) [trigger] vm tests_shard_8

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    9. ( 1 secs ) [trigger] vm tests_shard_9

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
25. ( 5 mins 37 secs ) vm tests_shard_10
    • stdout
    • results.json
    • run.json
    • logs.json
26. ( 146 ms ) ensure swarming
    • - no logs -
    1. ( 146 ms ) ensure_installed
       • stdout
       • json.output
27. ( 3 mins 48 secs ) vm tests_shard_1

    Run on OS: 'Linux'

    Pending time: 11s

    Shard duration: 0:09:17.844181
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • results.json
    • run.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
28. ( 2 mins 31 secs ) vm tests_shard_2

    Run on OS: 'Linux'

    Pending time: 11s

    Shard duration: 0:11:52.880017
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • results.json
    • logs.json
    • run.json
    • shard #0 isolated out
    • test stdout of shard #0
29. ( 1 secs ) vm tests_shard_3

    Run on OS: 'Linux'

    Pending time: 13s

    Shard duration: 0:06:42.970143
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • logs.json
    • results.json
    • shard #0 isolated out
    • test stdout of shard #0
30. ( 1 secs ) vm tests_shard_4

    Run on OS: 'Linux'

    Pending time: 13s

    Shard duration: 0:07:28.415876
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • logs.json
    • results.json
    • run.json
    • shard #0 isolated out
    • test stdout of shard #0
31. ( 1 mins 40 secs ) vm tests_shard_5

    Run on OS: 'Linux'

    Pending time: 17s

    Shard duration: 0:13:24.289292
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • logs.json
    • results.json
    • shard #0 isolated out
    • test stdout of shard #0
32. ( 1 secs ) vm tests_shard_6

    Run on OS: 'Linux'

    Pending time: 19s

    Shard duration: 0:10:23.981259
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
33. ( 1 secs ) vm tests_shard_7

    Run on OS: 'Linux'

    Pending time: 18s

    Shard duration: 0:07:02.088131
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • logs.json
    • results.json
    • run.json
    • shard #0 isolated out
    • test stdout of shard #0
34. ( 1 secs ) vm tests_shard_8

    Run on OS: 'Linux'

    Pending time: 18s

    Shard duration: 0:12:45.717337
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • results.json
    • run.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
35. ( 1 secs ) vm tests_shard_9

    Run on OS: 'Linux'

    Pending time: 19s

    Shard duration: 0:06:32.405441
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
36. ( 9 secs ) download previous results
    • - no logs -
    1. ( 457 ms ) ensure LATEST dir
       • stdout
    2. ( 459 ms ) ensure results.json exists
       • stdout
    3. ( 460 ms ) ensure flaky.json exists
       • stdout
    4. ( 462 ms ) ensure approved_results.json exists
       • stdout
    5. ( 2 secs ) gsutil download previous results
       • stdout
    6. ( 5 secs ) gsutil download approved results
       • stdout
37. ( 793 ms ) list tests to deflake (vm tests)
    • stdout
    • raw_io.output_text
38. ( 5 mins 53 secs ) deflake vm tests
    • stdout
    • results.json
    • run.json
    • logs.json
39. ( 720 ms ) update flakiness information
    • stdout
40. ( 728 ms ) find tests that began failing
    • stdout
    • raw_io.output_text
41. ( 789 ms ) find tests that began failing (logs)
    • stdout
    • raw_io.output_text
42. ( 790 ms ) find tests that began passing
    • stdout
    • raw_io.output_text
43. ( 784 ms ) find unapproved failing tests
    • stdout
    • raw_io.output_text
44. ( 1 secs ) find unapproved failing tests (logs)
    • stdout
    • raw_io.output_text
45. ( 1 secs ) find unapproved passing tests
    • stdout
    • raw_io.output_text
46. ( 803 ms ) find ignored flaky test failure logs
    • stdout
47. ( 1 secs ) test results
    • stdout
    • tests that began failing
    • tests that began failing (logs)
    • tests that began passing
    • unapproved failing tests
    • unapproved failing tests (logs)
    • unapproved passing tests
    • results.json
48. ( 15 secs ) upload new results
    • - no logs -
    1. ( 1 secs ) gsutil upload revision
       • stdout
       • gsutil.upload
    2. ( 1 secs ) gsutil upload logs.json
       • stdout
       • gsutil.upload
    3. ( 1 secs ) gsutil upload results.json
       • stdout
       • gsutil.upload
    4. ( 1 secs ) gsutil upload flaky.json
       • stdout
       • gsutil.upload
    5. ( 1 secs ) gsutil upload
       • stdout
       • gsutil.upload
    6. ( 1 secs ) gsutil upload runs.json
       • stdout
       • gsutil.upload
    7. ( 1 secs ) gsutil update "latest" reference
       • stdout
       • gsutil.upload
    8. ( 633 ms ) ensure_installed
       • stdout
       • json.output
    9. ( 3 secs ) upload test results to big query
       • - no logs -
       1. ( 528 ms ) upload results chunk to big query
          • stdout
       2. ( 438 ms ) upload results chunk to big query (2)
          • stdout
       3. ( 408 ms ) upload results chunk to big query (3)
          • stdout
       4. ( 442 ms ) upload results chunk to big query (4)
          • stdout
       5. ( 350 ms ) upload results chunk to big query (5)
          • stdout
       6. ( 343 ms ) upload results chunk to big query (6)
          • stdout
       7. ( 396 ms ) upload results chunk to big query (7)
          • stdout
       8. ( 352 ms ) upload results chunk to big query (8)
          • stdout
       9. ( 361 ms ) upload results chunk to big query (9)
          • stdout
49. ( 4 secs ) approve unapproved successes
    • stdout
50. ( 532 ms ) kill processes (3)
    • stdout
51. ( 7 ms ) debug log
    • stdout
52. ( 0 ) Failure reason
    • reason

Build Properties:

Name	Value	Source
$recipe_engine/buildbucket	{"build": {"builder": {"bucket": "ci.sandbox", "builder": "vm-kernel-precomp-linux-release-simarm-dev", "project": "dart"}, "createTime": "2019-02-04T17:04:54.676759Z", "createdBy": "user:luci-scheduler@appspot.gserviceaccount.com", "id": "8922435029597992080", "infra": {"buildbucket": {"serviceConfigRevision": "fac723e58b3bfb6839db07130deafc9ca5897acc"}, "recipe": {"cipdPackage": "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build", "name": "dart/neo"}, "swarming": {"hostname": "chromium-swarm.appspot.com"}}, "input": {"gitilesCommit": {"host": "dart.googlesource.com", "id": "e7c21c2255a0294320315b58b6d1f7df30d136c5", "project": "sdk", "ref": "refs/heads/dev"}}, "number": 49, "tags": [{"key": "builder", "value": "vm-kernel-precomp-linux-release-simarm-dev"}, {"key": "buildset", "value": "commit/git/e7c21c2255a0294320315b58b6d1f7df30d136c5"}, {"key": "buildset", "value": "commit/gitiles/dart.googlesource.com/sdk/+/e7c21c2255a0294320315b58b6d1f7df30d136c5"}, {"key": "scheduler_invocation_id", "value": "9087865091817503024"}, {"key": "scheduler_job_id", "value": "dart/vm-kernel-precomp-linux-release-simarm-dev"}, {"key": "user_agent", "value": "luci-scheduler"}]}}	setup_build
$recipe_engine/path	{"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"trusty-dart-68765ebb-us-central1-b-mdf9"	setup_build
branch	"refs/heads/dev"	setup_build
buildbucket	{"build": {"bucket": "luci.dart.ci.sandbox", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1549299894676759, "id": "8922435029597992080", "project": "dart", "tags": ["build_address:luci.dart.ci.sandbox/vm-kernel-precomp-linux-release-simarm-dev/49", "builder:vm-kernel-precomp-linux-release-simarm-dev", "buildset:commit/git/e7c21c2255a0294320315b58b6d1f7df30d136c5", "buildset:commit/gitiles/dart.googlesource.com/sdk/+/e7c21c2255a0294320315b58b6d1f7df30d136c5", "gitiles_ref:refs/heads/dev", "scheduler_invocation_id:9087865091817503024", "scheduler_job_id:dart/vm-kernel-precomp-linux-release-simarm-dev", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"vm-kernel-precomp-linux-release-simarm-dev"	setup_build
buildnumber	49	setup_build
clobber	"true"	setup_build
mastername	"client.dart"	setup_build
path_config	"generic"	setup_build
recipe	"dart/neo"	setup_build
repository	"https://dart.googlesource.com/sdk/"	setup_build
revision	"e7c21c2255a0294320315b58b6d1f7df30d136c5"	setup_build
got_revision	"e7c21c2255a0294320315b58b6d1f7df30d136c5"	bot_update

Blamelist:

1. William Hesse (whesseohnoyoudont@google.com)
2. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
3. Ben Konyi (bkonyiohnoyoudont@google.com)
4. Dan Rubel (danrubelohnoyoudont@google.com)
5. Dan Rubel (danrubelohnoyoudont@google.com)
6. Dan Rubel (danrubelohnoyoudont@google.com)
7. Samir Jindel (sjindelohnoyoudont@google.com)
8. Alexander Thomas (athomohnoyoudont@google.com)
9. Samir Jindel (sjindelohnoyoudont@google.com)
10. Paul Berry (paulberryohnoyoudont@google.com)
11. Alexander Thomas (athomohnoyoudont@google.com)
12. Peter von der Ahé (aheohnoyoudont@google.com)
13. Jens Johansen (jensjohnoyoudont@google.com)
14. Vijay Menon (vsmohnoyoudont@google.com)
15. Peter von der Ahé (aheohnoyoudont@google.com)
16. Peter von der Ahé (aheohnoyoudont@google.com)
17. Peter von der Ahé (aheohnoyoudont@google.com)
18. Peter von der Ahé (aheohnoyoudont@google.com)
19. Aske Simon Christensen (askescohnoyoudont@google.com)
20. Peter von der Ahé (aheohnoyoudont@google.com)
21. Peter von der Ahé (aheohnoyoudont@google.com)
22. Martin Kustermann (kustermannohnoyoudont@google.com)
23. Sam Rawlins (srawlinsohnoyoudont@google.com)
24. Alexander Markov (alexmarkovohnoyoudont@google.com)
25. Alexander Markov (alexmarkovohnoyoudont@google.com)
26. Ryan Macnak (rmacnakohnoyoudont@google.com)
27. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
28. Aart Bik (ajcbikohnoyoudont@google.com)
29. Aart Bik (ajcbikohnoyoudont@google.com)
30. Aart Bik (ajcbikohnoyoudont@google.com)
31. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
32. Paul Berry (paulberryohnoyoudont@google.com)
33. Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
34. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
35. Jens Johansen (jensjohnoyoudont@google.com)
36. Aske Simon Christensen (askescohnoyoudont@google.com)
37. Jens Johansen (jensjohnoyoudont@google.com)
38. Kevin Millikin (kmillikinohnoyoudont@google.com)
39. Peter von der Ahé (aheohnoyoudont@google.com)
40. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
41. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
42. Terry Lucas (terryohnoyoudont@google.com)
43. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
44. Alexander Aprelev (aamohnoyoudont@google.com)
45. Stephen Adams (sraohnoyoudont@google.com)
46. Paul Berry (paulberryohnoyoudont@google.com)
47. Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
48. Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
49. pq (pquitslundohnoyoudont@google.com)
50. Johnni Winther (johnniwintherohnoyoudont@google.com)
51. Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
52. Sam Rawlins (srawlinsohnoyoudont@google.com)
53. Liam Appelbe (liamaohnoyoudont@google.com)
54. Vyacheslav Egorov (vegorovohnoyoudont@google.com)
55. Ben Konyi (bkonyiohnoyoudont@google.com)
56. Paul Berry (paulberryohnoyoudont@google.com)
57. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
58. Ryan Macnak (rmacnakohnoyoudont@google.com)
59. Dan Rubel (danrubelohnoyoudont@google.com)
60. Ryan Macnak (rmacnakohnoyoudont@google.com)
61. Vyacheslav Egorov (vegorovohnoyoudont@google.com)
62. Sigmund Cherem (sigmundohnoyoudont@google.com)
63. Vyacheslav Egorov (vegorovohnoyoudont@google.com)
64. Jonas Termansen (sortieohnoyoudont@google.com)
65. Jonas Termansen (sortieohnoyoudont@google.com)
66. Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
67. Martin Kustermann (kustermannohnoyoudont@google.com)
68. Martin Kustermann (kustermannohnoyoudont@google.com)
69. Martin Kustermann (kustermannohnoyoudont@google.com)
70. Lasse R.H. Nielsen (lrnohnoyoudont@google.com)
71. asiva (asivaohnoyoudont@google.com)
72. Stephen Adams (sraohnoyoudont@google.com)
73. Aart Bik (ajcbikohnoyoudont@google.com)
74. Matthew Dempsky (mdempskyohnoyoudont@google.com)
75. Matthew Dempsky (mdempskyohnoyoudont@google.com)
76. Sigmund Cherem (sigmundohnoyoudont@google.com)
77. Ryan Macnak (rmacnakohnoyoudont@google.com)
78. asiva (asivaohnoyoudont@google.com)
79. Matthew Dempsky (mdempskyohnoyoudont@google.com)
80. Matthew Dempsky (mdempskyohnoyoudont@google.com)
81. danrubel (danrubelohnoyoudont@google.com)
82. Kevin Moore (kevmooohnoyoudont@google.com)
83. Sam Rawlins (srawlinsohnoyoudont@google.com)
84. Mike Fairhurst (mfairhurstohnoyoudont@google.com)
85. Peter von der Ahé (aheohnoyoudont@google.com)
86. Peter von der Ahé (aheohnoyoudont@google.com)
87. Peter von der Ahé (aheohnoyoudont@google.com)
88. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
89. Matthew Dempsky (mdempskyohnoyoudont@google.com)
90. Paul Berry (paulberryohnoyoudont@google.com)
91. William Hesse (whesseohnoyoudont@google.com)
92. Erik Ernst (eernstohnoyoudont@google.com)

Timing:

Create	Monday, 04-Feb-19 17:04:54 UTC
Start	Monday, 04-Feb-19 17:04:58 UTC
End	Monday, 04-Feb-19 17:29:53 UTC
Pending	3 secs
Execution	24 mins 55 secs

All Changes:

1. Version 2.1.2-dev.0.0

   Changed by	William Hesse - whesseohnoyoudont@google.com
   Changed at	Monday, 04-Feb-19 17:01:56 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	e7c21c2255a0294320315b58b6d1f7df30d136c5

   Comments

   Version 2.1.2-dev.0.0
   
   Merge commit '011a1239fc4c0ed140ddce4773cc791da1936cd4' into dev
   

2. Support for out-of-band worker in AnalysisDriverScheduler.

   Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
   Changed at	Tuesday, 29-Jan-19 20:09:47 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	011a1239fc4c0ed140ddce4773cc791da1936cd4

   Comments

   Support for out-of-band worker in AnalysisDriverScheduler.
   
   It will be used to perform work of searching for available declarations
   and sending corresponding completion libraris notifications.
   
   R=brianwilkerson@google.com
   
   Change-Id: I21b23c4fadf1dc679c16ff00a47149d62707ae51
   Reviewed-on: https://dart-review.googlesource.com/c/91581
   Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
   Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
   

   Changed files

   • pkg/analyzer/lib/src/dart/analysis/driver.dart

3. [ VM / dart:io ] Updated `Link` implementation for Windows to use actual symbolic links.

   Changed by	Ben Konyi - bkonyiohnoyoudont@google.com
   Changed at	Tuesday, 29-Jan-19 19:26:47 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	b625926038a52005cdb279adbf85a8bea334f0a9

   Comments

   [ VM / dart:io ] Updated `Link` implementation for Windows to use actual symbolic links.
   
   Change-Id: I22a598e7c1f249d9150cc5ceee96daa0291e753e
   Reviewed-on: https://dart-review.googlesource.com/c/90362
   Reviewed-by: Zach Anderson <zra@google.com>
   Reviewed-by: Siva Annamalai <asiva@google.com>
   Commit-Queue: Ben Konyi <bkonyi@google.com>
   

   Changed files

   • CHANGELOG.md
   • runtime/bin/file_win.cc
   • sdk/lib/io/link.dart
   • tests/standalone_2/io/link_test.dart

4. parse nested control flow collection entries

   Changed by	Dan Rubel - danrubelohnoyoudont@google.com
   Changed at	Tuesday, 29-Jan-19 17:53:58 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	09e6a689c2b9227e4a5924673cd715152f866138

   Comments

   parse nested control flow collection entries
   
   Change-Id: Id50c0a53a51f076dd75dd5bc13a694663449bc83
   Reviewed-on: https://dart-review.googlesource.com/c/91400
   Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
   

   Changed files

   • pkg/analysis_server/test/analysis/notification_highlights2_test.dart
   • pkg/analysis_server/test/analysis/notification_highlights_test.dart
   • pkg/analyzer/lib/src/dart/ast/ast.dart
   • pkg/analyzer/lib/src/fasta/ast_builder.dart
   • pkg/analyzer/test/generated/parser_fasta_test.dart
   • pkg/analyzer/test/src/dart/constant/evaluation_test.dart
   • pkg/front_end/lib/src/fasta/parser/literal_entry_info.dart
   • pkg/front_end/lib/src/fasta/parser/literal_entry_info_impl.dart
   • pkg/front_end/test/fasta/parser/literal_entry_info_test.dart

5. Update AstBuilder to generate new for statement structure

   Changed by	Dan Rubel - danrubelohnoyoudont@google.com
   Changed at	Tuesday, 29-Jan-19 17:53:58 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	213cfdc85ec8eadfd0ff321bbbaccca985ba4d3e

   Comments

   Update AstBuilder to generate new for statement structure
   
   ... if control flow or spread collection entries are enabled.
   
   Change-Id: I8718c1f7a649b7a2a7c9e376a6bf67c1df0542cf
   Reviewed-on: https://dart-review.googlesource.com/c/91320
   Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
   

   Changed files

   • pkg/analyzer/lib/dart/ast/ast_factory.dart
   • pkg/analyzer/lib/src/fasta/ast_builder.dart
   • pkg/analyzer/test/generated/parser_fasta_listener.dart
   • pkg/analyzer/test/generated/parser_fasta_test.dart
   • pkg/analyzer/test/generated/parser_test.dart
   • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
   • pkg/front_end/lib/src/fasta/parser/forwarding_listener.dart
   • pkg/front_end/lib/src/fasta/parser/listener.dart
   • pkg/front_end/lib/src/fasta/source/type_promotion_look_ahead_listener.dart
   • pkg/front_end/test/fasta/parser/literal_entry_info_test.dart

6. Parse simple for control flow collection entires

   Changed by	Dan Rubel - danrubelohnoyoudont@google.com
   Changed at	Tuesday, 29-Jan-19 17:53:58 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	93a56336a38eb7820d19eda0a45f436921a60a18

   Comments

   Parse simple for control flow collection entires
   
   ... and address comments in:
   https://dart-review.googlesource.com/c/sdk/+/91144
   https://dart-review.googlesource.com/c/sdk/+/90901
   
   Change-Id: I7a9288bf28e069832193bd8a196a11f9a407b20d
   Reviewed-on: https://dart-review.googlesource.com/c/91300
   Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
   

   Changed files

   • pkg/analyzer/lib/dart/ast/ast_factory.dart
   • pkg/analyzer/lib/src/fasta/ast_builder.dart
   • pkg/analyzer/test/generated/parser_fasta_listener.dart
   • pkg/analyzer/test/generated/parser_fasta_test.dart
   • pkg/analyzer/test/src/fasta/recovery/partial_code/forEach_statement_test.dart
   • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
   • pkg/front_end/lib/src/fasta/parser/forwarding_listener.dart
   • pkg/front_end/lib/src/fasta/parser/listener.dart
   • pkg/front_end/lib/src/fasta/parser/literal_entry_info.dart
   • pkg/front_end/lib/src/fasta/parser/literal_entry_info_impl.dart
   • pkg/front_end/lib/src/fasta/parser/parser.dart
   • pkg/front_end/lib/src/fasta/source/type_promotion_look_ahead_listener.dart
   • pkg/front_end/test/fasta/parser/literal_entry_info_test.dart

7. [vm] Update status file for entrypoints_verification_test.

   Changed by	Samir Jindel - sjindelohnoyoudont@google.com
   Changed at	Tuesday, 29-Jan-19 16:58:06 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	05a083a95afca9c952f2cc57be9d45141e906155

   Comments

   [vm] Update status file for entrypoints_verification_test.
   
   Change-Id: I74beff8e58ae33402ad14d6d7a281724aa44bbb4
   Reviewed-on: https://dart-review.googlesource.com/c/91561
   Reviewed-by: Daco Harkes <dacoharkes@google.com>
   Commit-Queue: Daco Harkes <dacoharkes@google.com>
   Auto-Submit: Samir Jindel <sjindel@google.com>
   

   Changed files

   • tests/standalone_2/standalone_2_kernel.status

8. [infra] Use fewer cores on Android shards

   Changed by	Alexander Thomas - athomohnoyoudont@google.com
   Changed at	Tuesday, 29-Jan-19 15:54:08 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	2bb38e62e87ead8a9424271dbf3cbee8d79a9c50

   Comments

   [infra] Use fewer cores on Android shards
   
   The shards are currently defaulting to use j4 because the docker host
   has 4 cores. 6 devices share one host and are therefore trying to run 20
   processes competing for the only 4 physical cores. The docker hosts will
   soon be upgraded to have 8 cores. j2 will result in 10 processes
   competing for those 8 cores which should result in a better balance
   between utilization and latency.
   
   Change-Id: Ieb67cb92f17317108d1a1d3da710c58400484a7c
   Reviewed-on: https://dart-review.googlesource.com/c/91540
   Reviewed-by: William Hesse <whesse@google.com>
   

   Changed files

   • tools/bots/test_matrix.json

9. Re-land "[vm] Prevent access to non-annotated members through native API."

   Changed by	Samir Jindel - sjindelohnoyoudont@google.com
   Changed at	Tuesday, 29-Jan-19 15:10:34 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	267e91a0eafdbec39a0b0b68c2015dff982ae749

   Comments

   Re-land "[vm] Prevent access to non-annotated members through native API."
   
   Two fixes:
   
     - Make entrypoints_verification_test work on configurations where CFE compilation
       is separate from execution.
     - Add missing entry-point annotation for Windows.
   
   The original revision is in patchset 1.
   
   Change-Id: I6c4b52b1bae7bc730546dad6a3e31d8625f850b1
   Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try, vm-kernel-precomp-linux-debug-x64-try, vm-kernel-precomp-linux-release-simarm-try, vm-kernel-precomp-linux-release-simarm64-try, vm-kernel-precomp-linux-release-x64-try, vm-kernel-precomp-mac-release-simarm64-try, vm-kernel-precomp-win-release-x64-try
   Reviewed-on: https://dart-review.googlesource.com/c/90942
   Commit-Queue: Samir Jindel <sjindel@google.com>
   Reviewed-by: Alexander Markov <alexmarkov@google.com>
   

   Changed files

   • BUILD.gn
   • runtime/bin/BUILD.gn
   • runtime/bin/builtin.dart
   • runtime/bin/entrypoints_verification_test_extension.cc
   • runtime/bin/entrypoints_verification_test_extension_dllmain_win.cc
   • runtime/docs/compiler/aot/entry_point_pragma.md
   • runtime/lib/growable_array.dart
   • runtime/vm/compiler/aot/precompiler.cc
   • runtime/vm/dart_api_impl.cc
   • runtime/vm/flag_list.h
   • runtime/vm/object.cc
   • runtime/vm/object.h
   • runtime/vm/object_store.cc
   • runtime/vm/object_store.h
   • tests/standalone_2/io/entrypoints_verification_test.dart
   • tests/standalone_2/standalone_2_kernel.status

10. Fix dead_code hint

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Tuesday, 29-Jan-19 14:58:54 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	d73d3183a2c58f170068d28b5d3d6a5aad9b3fcc

    Comments

    Fix dead_code hint
    
    Change-Id: I30eb074b5346f7c53997e585eda31b374445d807
    Reviewed-on: https://dart-review.googlesource.com/c/91500
    Auto-Submit: Paul Berry <paulberry@google.com>
    Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/generated/resolver.dart

11. [release] Update changelog with changes from dev branch

    Changed by	Alexander Thomas - athomohnoyoudont@google.com
    Changed at	Tuesday, 29-Jan-19 14:51:27 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	24fa01dbaeb06c05ae3c919daa30a81d559b1fd9

    Comments

    [release] Update changelog with changes from dev branch
    
    TBR=whesse@google.com
    
    Change-Id: I100edbb9169bd6b8e22769d4699118c30652adb4
    Reviewed-on: https://dart-review.googlesource.com/c/91560
    Reviewed-by: Alexander Thomas <athom@google.com>
    

    Changed files

    • CHANGELOG.md

12. Prevent unsound promoted bounds from being used as arguments

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Tuesday, 29-Jan-19 14:46:04 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	f5fd2811506cd154ff2c0cbc8165f472a47c87cd

    Comments

    Prevent unsound promoted bounds from being used as arguments
    
    Fixes https://github.com/dart-lang/sdk/issues/35100
    
    Change-Id: I65f73f40d0ea970f0631599e01b177412fc32a40
    Reviewed-on: https://dart-review.googlesource.com/c/90390
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    

    Changed files

    • pkg/front_end/lib/src/fasta/fasta_codes_generated.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
    • pkg/front_end/messages.status
    • pkg/front_end/messages.yaml
    • pkg/front_end/testcases/strong.status
    • pkg/front_end/testcases/text_serialization.status
    • pkg/front_end/testcases/unsound_promotion.dart
    • pkg/front_end/testcases/unsound_promotion.dart.hierarchy.expect
    • pkg/front_end/testcases/unsound_promotion.dart.legacy.expect
    • pkg/front_end/testcases/unsound_promotion.dart.legacy.transformed.expect
    • pkg/front_end/testcases/unsound_promotion.dart.outline.expect
    • pkg/front_end/testcases/unsound_promotion.dart.strong.expect
    • pkg/front_end/testcases/unsound_promotion.dart.strong.transformed.expect
    • pkg/front_end/testcases/unsound_promotion.dart.type_promotion.expect
    • pkg/kernel/lib/src/bounds_checks.dart

13. Garbage-collect compiled libraries

    Changed by	Jens Johansen - jensjohnoyoudont@google.com
    Changed at	Tuesday, 29-Jan-19 14:25:44 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	cf56801308f20263cbda780a80c6e60a7c03ea6e

    Comments

    Garbage-collect compiled libraries
    
    If - for instance - a file (say 'main.dart') tries to include a part
    (say 'lib.dart') that is not part of that file (i.e. doesn't state
    something like 'part of "main.dart"'), and the file ('lib.dart') is not
    otherwise used, before this change, the library ('lib.dart') would be
    included in the first comile, but on subsequent re-compiles wouldn't
    include it because it's not referenced, nor ever cleaned up
    (and would thus be re-compiled.)
    
    This change garbage-collects the library as it's not referenced.
    
    Change-Id: I8fa90b3ae6fc3d99af9fec780abe62855e653ddb
    Reviewed-on: https://dart-review.googlesource.com/c/90385
    Reviewed-by: Peter von der Ahé <ahe@google.com>
    Commit-Queue: Jens Johansen <jensj@google.com>
    

    Changed files

    • pkg/front_end/lib/src/fasta/incremental_compiler.dart
    • pkg/front_end/testcases/incremental_bulk_compiler_full.status
    • pkg/front_end/testcases/incremental_bulk_compiler_smoke.status

14. Support to run co19_2 on ddk

    Changed by	Vijay Menon - vsmohnoyoudont@google.com
    Changed at	Tuesday, 29-Jan-19 13:50:02 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	8fc9eaf06c82d3287f551a6dc47ff767c46e2d15

    Comments

    Support to run co19_2 on ddk
    
    Change-Id: I93b9752655385d0e26cdf97d0f8224a88c198657
    Reviewed-on: https://dart-review.googlesource.com/c/90781
    Commit-Queue: Vijay Menon <vsm@google.com>
    Reviewed-by: Jenny Messerly <jmesserly@google.com>
    

    Changed files

    • pkg/dev_compiler/lib/src/analyzer/code_generator.dart
    • tools/testing/dart/browser_test.dart

15. Anonymous mixin applications are abstract

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Tuesday, 29-Jan-19 13:29:32 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	812a6af41a52852a9584696ccf12c9bd22fe180b

    Comments

    Anonymous mixin applications are abstract
    
    Change-Id: Ib36a0bd243010a5b51bf49bda750d7e432017eae
    Reviewed-on: https://dart-review.googlesource.com/c/90703
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    Reviewed-by: Jenny Messerly <jmesserly@google.com>
    

    Changed files

    • pkg/dev_compiler/lib/src/kernel/analyzer_to_kernel.dart

16. Support type variables on function types and intersection types

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Tuesday, 29-Jan-19 13:29:32 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	977e5b31e2750aa5f0524f2064772d99e7da02d8

    Comments

    Support type variables on function types and intersection types
    
    Change-Id: Ic4f6f26f1e779e9fc084a06f546584f826a6e720
    Reviewed-on: https://dart-review.googlesource.com/c/90382
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    

    Changed files

    • pkg/front_end/test/fasta/types/kernel_type_parser.dart
    • pkg/front_end/test/fasta/types/kernel_type_parser_test.dart
    • pkg/front_end/test/fasta/types/shared_type_tests.dart
    • pkg/front_end/test/fasta/types/type_parser.dart
    • pkg/front_end/test/fasta/types/type_parser_test.dart

17. Make CoreType test friendly

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Tuesday, 29-Jan-19 13:29:32 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	f822d0abb8fc638c65f1ae28b9c3b3fe7bd4e7ab

    Comments

    Make CoreType test friendly
    
    The classes Future and Stream are exported by dart:core.
    By attempting to look up FutureOr in dart:core before dart:async,
    we support simple a simple test scenario where there's only one
    platform library.
    
    Change-Id: I76627f89957b91fbdb52a7772c177a769c37cecb
    Reviewed-on: https://dart-review.googlesource.com/c/90381
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    

    Changed files

    • pkg/front_end/lib/src/fasta/source/source_loader.dart
    • pkg/kernel/lib/core_types.dart
    • pkg/kernel/lib/library_index.dart

18. Copy subtype tests

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Tuesday, 29-Jan-19 13:29:32 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	d025ff53673f2f9a88088238634aef1b6327218a

    Comments

    Copy subtype tests
    
    The tests are copied from pkg/kernel/test/type_subtype_test.dart
    
    Change-Id: I1120aa7ae1928fc20982f24fab14925b9ee851c8
    Reviewed-on: https://dart-review.googlesource.com/c/90229
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    

    Changed files

    • pkg/front_end/test/fasta/types/kernel_type_parser.dart
    • pkg/front_end/test/fasta/types/kernel_type_parser_test.dart
    • pkg/front_end/test/fasta/types/shared_type_tests.dart
    • pkg/front_end/test/fasta/types/type_parser.dart
    • pkg/front_end/test/fasta/types/type_parser_test.dart

19. Revisit existing constants in the constants transformer.

    Changed by	Aske Simon Christensen - askescohnoyoudont@google.com
    Changed at	Tuesday, 29-Jan-19 10:36:12 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	219a2fcf663f127000c849585cade6b5eab5cfff

    Comments

    Revisit existing constants in the constants transformer.
    
    Unevaluated constants are re-evaluated, and evaluated constants are
    re-canonicalized.
    
    Change-Id: I241f6b5d734797101ab1168746a849713c104695
    Reviewed-on: https://dart-review.googlesource.com/c/91230
    Commit-Queue: Aske Simon Christensen <askesc@google.com>
    Reviewed-by: Kevin Millikin <kmillikin@google.com>
    

    Changed files

    • pkg/kernel/lib/transformations/constants.dart

20. Tweak the subtype rule for Null

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Tuesday, 29-Jan-19 10:04:21 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	97cb74cf63ec52a9d9c3e1163478550b1a09044a

    Comments

    Tweak the subtype rule for Null
    
    Change-Id: I3c1f1af40f5930a02355f8d986a27db606998096
    Reviewed-on: https://dart-review.googlesource.com/c/90980
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    

    Changed files

    • pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
    • pkg/front_end/lib/src/fasta/type_inference/type_schema_environment.dart
    • pkg/kernel/lib/type_environment.dart

21. Mixins have no static members

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Tuesday, 29-Jan-19 09:54:52 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	5fbf15d9c40702bfc89acc43247f36ae17dd244b

    Comments

    Mixins have no static members
    
    Change-Id: I93b43ad2d58ab2804ed7deafeadb6346eade9eab
    Reviewed-on: https://dart-review.googlesource.com/c/91481
    Reviewed-by: Jens Johansen <jensj@google.com>
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    

    Changed files

    • pkg/front_end/lib/src/fasta/kernel/class_hierarchy_builder.dart
    • pkg/front_end/lib/src/fasta/scope.dart
    • pkg/front_end/testcases/mixin_with_static_member.dart
    • pkg/front_end/testcases/mixin_with_static_member.dart.hierarchy.expect
    • pkg/front_end/testcases/mixin_with_static_member.dart.legacy.expect
    • pkg/front_end/testcases/mixin_with_static_member.dart.legacy.transformed.expect
    • pkg/front_end/testcases/mixin_with_static_member.dart.outline.expect
    • pkg/front_end/testcases/mixin_with_static_member.dart.strong.expect
    • pkg/front_end/testcases/mixin_with_static_member.dart.strong.transformed.expect
    • pkg/front_end/testcases/text_serialization.status

22. [VM/AOT] Make DartTemplateCall::Selector() work even if there is no ICData

    Changed by	Martin Kustermann - kustermannohnoyoudont@google.com
    Changed at	Tuesday, 29-Jan-19 08:21:52 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	d5a558d6c44db397d22896045e61aaeb4209d411

    Comments

    [VM/AOT] Make DartTemplateCall::Selector() work even if there is no ICData
    
    Closes https://github.com/dart-lang/sdk/issues/35703
    
    Change-Id: I59713cb2baac695786cceeb54f6d8a7a3ed4a722
    Reviewed-on: https://dart-review.googlesource.com/c/91226
    Reviewed-by: Aart Bik <ajcbik@google.com>
    Commit-Queue: Martin Kustermann <kustermann@google.com>
    

    Changed files

    • runtime/tests/vm/dart/fuzz3608420507_regression_test.dart
    • runtime/tests/vm/vm.status
    • runtime/vm/compiler/backend/il.h

23. Fix PackageBuildWorkspacePackage's contains

    Changed by	Sam Rawlins - srawlinsohnoyoudont@google.com
    Changed at	Tuesday, 29-Jan-19 02:01:51 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	c5a954794b30f89a20d02e2f19a9561bcc96333e

    Comments

    Fix PackageBuildWorkspacePackage's contains
    
    This implementation did not check whether the path was actually contained
    in the package:build workspace. It also made an assumption about how a
    resource which is a directory would be treated, which was masked by an
    unconditional-and-silenced catch.
    
    The existing test which should have caught this had a hidden exception,
    caught by the same unconditional-and-silenced catch. :(
    
    Bug: https://github.com/dart-lang/linter/issues/1393
    Change-Id: I0a6ecb584e06877463a47681830eed8f6f914030
    Reviewed-on: https://dart-review.googlesource.com/c/91441
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Samuel Rawlins <srawlins@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/workspace/package_build.dart
    • pkg/analyzer/test/src/workspace/package_build_test.dart

24. [vm/bytecode] Capture receiver if creating a closure

    Changed by	Alexander Markov - alexmarkovohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 23:41:01 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	d84851daf86b48300637cc34c38f6f9ffb5cd8a8

    Comments

    [vm/bytecode] Capture receiver if creating a closure
    
    When creating a closure, receiver is loaded in order to obtain
    instantiator type arguments. That access was not capturing
    receiver, if a closure was created inside another closure.
    
    Change-Id: I9ec6d9f2c90643e6deb9c4efde1b070a3255a387
    Reviewed-on: https://dart-review.googlesource.com/c/91442
    Commit-Queue: Régis Crelier <regis@google.com>
    Auto-Submit: Alexander Markov <alexmarkov@google.com>
    Reviewed-by: Zach Anderson <zra@google.com>
    Reviewed-by: Régis Crelier <regis@google.com>
    

    Changed files

    • pkg/vm/lib/bytecode/local_vars.dart
    • pkg/vm/testcases/bytecode/closures.dart
    • pkg/vm/testcases/bytecode/closures.dart.expect

25. [vm/bytecode] Fix max used block id when compiling from bytecode

    Changed by	Alexander Markov - alexmarkovohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 22:29:17 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	601094e3f26554a57b80382b7c32afa196484663

    Comments

    [vm/bytecode] Fix max used block id when compiling from bytecode
    
    Fixes https://github.com/dart-lang/sdk/issues/35789
    
    Change-Id: I061d8d5b709fa5469824c8f5d7490aa2038746a3
    Reviewed-on: https://dart-review.googlesource.com/c/91440
    Reviewed-by: Aart Bik <ajcbik@google.com>
    Commit-Queue: Alexander Markov <alexmarkov@google.com>
    

    Changed files

    • runtime/vm/compiler/backend/flow_graph_checker.cc
    • runtime/vm/compiler/frontend/bytecode_flow_graph_builder.cc

26. [vm, gc] Fix backwards write-barrier logic used by Object::Clone.

    Changed by	Ryan Macnak - rmacnakohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 22:28:37 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	ff2e8eb681fdf93a30f264e5b7a8623e16e73762

    Comments

    [vm, gc] Fix backwards write-barrier logic used by Object::Clone.
    
    Change-Id: Ib614c0e85a96604252a47ad81ad6a8e70509a671
    Reviewed-on: https://dart-review.googlesource.com/c/91242
    Reviewed-by: Siva Annamalai <asiva@google.com>
    Commit-Queue: Ryan Macnak <rmacnak@google.com>
    

    Changed files

    • runtime/vm/object.cc

27. Make ERROR the default severity for StaticWarningCode. Remove _StrongModeTypeErrorProcessor.

    Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 22:08:17 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	1ba59eb13df61e452cdc39a0dc8100645ced6b93

    Comments

    Make ERROR the default severity for StaticWarningCode. Remove _StrongModeTypeErrorProcessor.
    
    As a preparatory step for re-landing https://dart-review.googlesource.com/c/sdk/+/91170
    and making these two restored problems to warnings.
    
    R=brianwilkerson@google.com, paulberry@google.com
    
    Change-Id: I6266632ade84743b5725c54475fe402902576c00
    Reviewed-on: https://dart-review.googlesource.com/c/91420
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
    

    Changed files

    • pkg/analysis_server/test/edit/fixes_test.dart
    • pkg/analyzer/lib/source/error_processor.dart
    • pkg/analyzer/lib/src/error/codes.dart
    • pkg/analyzer/test/source/error_processor_test.dart

28. [vm/compiler] Disable max block id check (for now)

    Changed by	Aart Bik - ajcbikohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 20:21:07 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	fc417a73ed3488ee3e38726d097ce8f68eb33209

    Comments

    [vm/compiler] Disable max block id check (for now)
    
    https://github.com/dart-lang/sdk/issues/35789
    
    Change-Id: Id37ca8191eb78431bb9bfaf23dd982b4cc5b44df
    Reviewed-on: https://dart-review.googlesource.com/c/91421
    Reviewed-by: Aart Bik <ajcbik@google.com>
    Commit-Queue: Aart Bik <ajcbik@google.com>
    

    Changed files

    • runtime/vm/compiler/backend/flow_graph_checker.cc

29. [vm/compiler] Introduce graph checker

    Changed by	Aart Bik - ajcbikohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 18:16:47 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	e02399da33e56dca4c4abf8a53303269a9fa9a86

    Comments

    [vm/compiler] Introduce graph checker
    
    Rationale:
    This is a start with a graph checker that verifies
    the consistency of the flow graph after each compiler
    pass with the goal of detecting errors as early as
    possible. The checks add overhead, so are only run
    in debug mode. The objective is that all written
    and unwritten assumptions on the flow graph that
    are relatively easy to check will be converted
    into actual code.
    Change-Id: Iad9927d5b0fd87a43dc6a7369174d52761d89c9e
    Reviewed-on: https://dart-review.googlesource.com/c/91143
    Commit-Queue: Aart Bik <ajcbik@google.com>
    Reviewed-by: Martin Kustermann <kustermann@google.com>
    

    Changed files

    • runtime/vm/compiler/backend/flow_graph_checker.cc
    • runtime/vm/compiler/backend/flow_graph_checker.h
    • runtime/vm/compiler/compiler_pass.cc
    • runtime/vm/compiler/compiler_sources.gni

30. [vm/compiler] Fix missing incremental DOM update

    Changed by	Aart Bik - ajcbikohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 18:08:47 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	2881a92c4e494dd2238679d34cfb1706fef55055

    Comments

    [vm/compiler] Fix missing incremental DOM update
    
    Rationale:
    Found by the new graph checker! Dominance relation was
    not complete after incremental update (note that most
    passes get around this by just recomputing the full
    relation). Graph checkers are very useful to find
    such omissions.
    Change-Id: I4f2c8bfaee54b7a092aaaec04886635c86b451fa
    Reviewed-on: https://dart-review.googlesource.com/c/91244
    Commit-Queue: Aart Bik <ajcbik@google.com>
    Reviewed-by: Alexander Markov <alexmarkov@google.com>
    Reviewed-by: Martin Kustermann <kustermann@google.com>
    

    Changed files

    • runtime/vm/compiler/backend/inliner.cc

31. Implement changeFile() and recompute available libraries and declarations.

    Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 18:05:17 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	95b017a888bc29f509de06c3c64b78e0ad36bd2e

    Comments

    Implement changeFile() and recompute available libraries and declarations.
    
    Some renames in tests.
    
    R=brianwilkerson@google.com
    
    Change-Id: Ia54752c816bbc62f99a200d62658b6f4dfb26480
    Reviewed-on: https://dart-review.googlesource.com/c/91381
    Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/services/available_declarations.dart
    • pkg/analyzer/test/src/services/available_declarations_test.dart

32. Revert "Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden."

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 17:09:24 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	ec5ba8a2521a3638c39cc41a09ce736ed64cd092

    Comments

    Revert "Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden."
    
    This reverts commit 6699384dddfac8da9e4a2edfca2f6445d412358a.
    
    Reason for revert: Breakages in Flutter - see https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8923238548150736816/+/steps/analyze_flutter/0/stdout
    
    Original change's description:
    > Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
    > 
    > R=​brianwilkerson@google.com, paulberry@google.com
    > 
    > Bug: https://github.com/dart-lang/sdk/issues/34437
    > Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
    > Reviewed-on: https://dart-review.googlesource.com/c/91170
    > Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
    > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    
    TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: https://github.com/dart-lang/sdk/issues/34437
    Change-Id: I07c96c8131c16b2748a403f38d5f15b814131c63
    Reviewed-on: https://dart-review.googlesource.com/c/91360
    Reviewed-by: Paul Berry <paulberry@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
    

    Changed files

    • pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart
    • pkg/analysis_server/test/services/refactoring/rename_local_test.dart
    • pkg/analyzer/lib/src/dart/analysis/context_locator.dart
    • pkg/analyzer/lib/src/dart/analysis/driver.dart
    • pkg/analyzer/lib/src/error/inheritance_override.dart
    • pkg/analyzer/test/generated/non_error_resolver.dart
    • pkg/analyzer/test/generated/static_warning_code_test.dart
    • pkg/analyzer/test/src/dart/resolution/resolution.dart
    • pkg/analyzer/test/src/diagnostics/invalid_override_different_default_values_test.dart
    • pkg/analyzer/test/src/diagnostics/test_all.dart
    • pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator_impl.dart
    • tests/co19_2/co19_2-analyzer.status
    • tests/compiler/dart2js/end_to_end/bad_output_io_test.dart

33. Start supporting resolution of the code-as-ui constructs

    Changed by	Brian Wilkerson - brianwilkersonohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 15:12:47 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	7daa9f65fceb1ef44fb5111e05b8bdb8229adf14

    Comments

    Start supporting resolution of the code-as-ui constructs
    
    Change-Id: I8fba9bfcac2339b113de6bc2954821585e7b8ab4
    Reviewed-on: https://dart-review.googlesource.com/c/91240
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/generated/resolver.dart
    • pkg/analyzer/lib/src/generated/static_type_analyzer.dart
    • pkg/analyzer/test/src/dart/constant/evaluation_test.dart

34. Additional tests for interpolation and CONVERT_TO_MULTILINE_STRING.

    Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 15:08:06 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	69af7af70d90aba1b36f66dbecffb3a53e32e04c

    Comments

    Additional tests for interpolation and CONVERT_TO_MULTILINE_STRING.
    
    For discussion in https://dart-review.googlesource.com/c/sdk/+/91262
    
    R=brianwilkerson@google.com
    
    Change-Id: Ib25a5da32ade4d4bccef8856867761e153a6d5dc
    Reviewed-on: https://dart-review.googlesource.com/c/91263
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
    

    Changed files

    • pkg/analysis_server/test/src/services/correction/assist/convert_to_multiline_string_test.dart

35. Handle mis-included parts differently

    Changed by	Jens Johansen - jensjohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 14:20:45 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	5cf4e543b82299d60a3bd8acdc167c9b0d97d685

    Comments

    Handle mis-included parts differently
    
    If, for instance, including something that is not a part of the file
    you include it from, previously we would copy things over anyway, and
    other libraries wouldn't be able to use it
    (for instance including it would fail).
    
    Now, instead, we don't include it, structurally pretending the "part of"
    line wasn't there (that is, we don't copy things over and other libraries
    are free to include it).
    
    As before, an error is given, but errors doesn't 'cascade' into other
    libraries that (before this change) couldn't use the included file.
    
    Change-Id: Ica6225c437ea7dd66f9e8955e638f442b2df8f97
    Reviewed-on: https://dart-review.googlesource.com/c/90380
    Reviewed-by: Peter von der Ahé <ahe@google.com>
    Commit-Queue: Jens Johansen <jensj@google.com>
    

    Changed files

    • pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
    • pkg/front_end/lib/src/fasta/source/source_library_builder.dart
    • pkg/front_end/testcases/part_not_part_of.dart
    • pkg/front_end/testcases/part_not_part_of.dart.legacy.expect
    • pkg/front_end/testcases/part_not_part_of.dart.legacy.transformed.expect
    • pkg/front_end/testcases/part_not_part_of.dart.outline.expect
    • pkg/front_end/testcases/part_not_part_of.dart.strong.expect
    • pkg/front_end/testcases/part_not_part_of.dart.strong.transformed.expect
    • pkg/front_end/testcases/part_not_part_of_lib1.dart
    • pkg/front_end/testcases/part_not_part_of_lib2.dart
    • pkg/front_end/testcases/part_not_part_of_same_named_library.dart
    • pkg/front_end/testcases/part_not_part_of_same_named_library.dart.legacy.expect
    • pkg/front_end/testcases/part_not_part_of_same_named_library.dart.legacy.transformed.expect
    • pkg/front_end/testcases/part_not_part_of_same_named_library.dart.outline.expect
    • pkg/front_end/testcases/part_not_part_of_same_named_library.dart.strong.expect
    • pkg/front_end/testcases/part_not_part_of_same_named_library.dart.strong.transformed.expect
    • pkg/front_end/testcases/part_not_part_of_same_named_library_lib1.dart
    • pkg/front_end/testcases/part_not_part_of_same_named_library_lib2.dart
    • pkg/front_end/testcases/part_part_of_different_unnamed_library.dart
    • pkg/front_end/testcases/part_part_of_different_unnamed_library.dart.legacy.expect
    • pkg/front_end/testcases/part_part_of_different_unnamed_library.dart.legacy.transformed.expect
    • pkg/front_end/testcases/part_part_of_different_unnamed_library.dart.outline.expect
    • pkg/front_end/testcases/part_part_of_different_unnamed_library.dart.strong.expect
    • pkg/front_end/testcases/part_part_of_different_unnamed_library.dart.strong.transformed.expect
    • pkg/front_end/testcases/part_part_of_different_unnamed_library_lib1.dart
    • pkg/front_end/testcases/part_part_of_different_unnamed_library_lib2.dart
    • pkg/front_end/testcases/part_part_of_differently_named_library.dart
    • pkg/front_end/testcases/part_part_of_differently_named_library.dart.legacy.expect
    • pkg/front_end/testcases/part_part_of_differently_named_library.dart.legacy.transformed.expect
    • pkg/front_end/testcases/part_part_of_differently_named_library.dart.outline.expect
    • pkg/front_end/testcases/part_part_of_differently_named_library.dart.strong.expect
    • pkg/front_end/testcases/part_part_of_differently_named_library.dart.strong.transformed.expect
    • pkg/front_end/testcases/part_part_of_differently_named_library_lib1.dart
    • pkg/front_end/testcases/part_part_of_differently_named_library_lib2.dart
    • pkg/front_end/testcases/text_serialization.status

36. Rename klass getter on InstanceConstant to classNode

    Changed by	Aske Simon Christensen - askescohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 13:31:05 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	f066c053194a31a926eed1d5ac914edfe25439e9

    Comments

    Rename klass getter on InstanceConstant to classNode
    
    This achieves consistency with similar getters in the API.
    
    This is technically a breaking change, since it changes a published
    part of the Kernel API. Since the constants API is relatively new and
    so far only used internally in the AOT compiler, the change is
    expected to be unproblematic.
    
    Closes https://github.com/dart-lang/sdk/issues/35696
    
    Change-Id: I3ca30922580d226ccbdb6f77496983c21ef2102b
    Reviewed-on: https://dart-review.googlesource.com/c/90220
    Commit-Queue: Aske Simon Christensen <askesc@google.com>
    Reviewed-by: Kevin Millikin <kmillikin@google.com>
    

    Changed files

    • CHANGELOG.md
    • pkg/front_end/lib/src/fasta/kernel/type_labeler.dart
    • pkg/kernel/lib/ast.dart
    • pkg/kernel/lib/binary/ast_to_binary.dart
    • pkg/kernel/lib/external_name.dart
    • pkg/kernel/lib/text/ast_to_text.dart
    • pkg/kernel/lib/transformations/constants.dart
    • pkg/kernel/lib/transformations/treeshaker.dart
    • pkg/vm/lib/bytecode/gen_bytecode.dart
    • pkg/vm/lib/transformations/type_flow/summary_collector.dart
    • pkg/vm/lib/transformations/type_flow/transformer.dart

37. Reproduction of dartbug.com/35715

    Changed by	Jens Johansen - jensjohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 12:15:41 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	42be4083bd04550be26901cb668f2ef81c0d5ae4

    Comments

    Reproduction of dartbug.com/35715
    
    Get an error saying something like
    "The argument type 'dart.core::String' can't be assigned to
    the parameter type 'dart.core::String'"
    
    Change-Id: I327c613a2070495653e4089475a4f3edf550e9d4
    Reviewed-on: https://dart-review.googlesource.com/c/91228
    Commit-Queue: Jens Johansen <jensj@google.com>
    Reviewed-by: Peter von der Ahé <ahe@google.com>
    

    Changed files

    • pkg/front_end/test/incremental_load_from_dill_test.dart
    • pkg/front_end/testcases/incremental_initialize_from_dill/load_from_component_explicitly_import_dart_core.yaml
    • pkg/front_end/testcases/incremental_initialize_from_dill/status.status

38. [Fasta] Fix a typo in a class name

    Changed by	Kevin Millikin - kmillikinohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 11:53:41 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	e1691342030a224f688a70ef0a5767f577f3d097

    Comments

    [Fasta] Fix a typo in a class name
    
    Change-Id: Ia2bc80d7a9ba3dc7716f8052e367c7711646a839
    Reviewed-on: https://dart-review.googlesource.com/c/91145
    Auto-Submit: Kevin Millikin <kmillikin@google.com>
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    Reviewed-by: Peter von der Ahé <ahe@google.com>
    

    Changed files

    • pkg/front_end/lib/src/fasta/kernel/inference_visitor.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

39. Fix typo in omitPlatform documentation

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Monday, 28-Jan-19 08:21:36 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	591df5263f1d9dbe7d581efe87facf72d395ae23

    Comments

    Fix typo in omitPlatform documentation
    
    Change-Id: Id490a6b051b0ef74cae709157d4ae537495e9583
    Reviewed-on: https://dart-review.googlesource.com/c/90680
    Auto-Submit: Peter von der Ahé <ahe@google.com>
    Commit-Queue: Jens Johansen <jensj@google.com>
    Reviewed-by: Jens Johansen <jensj@google.com>
    

    Changed files

    • pkg/front_end/lib/src/api_prototype/compiler_options.dart

40. Add all SDK libraries, and context files belonging to the package / potions of it.

    Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
    Changed at	Sunday, 27-Jan-19 22:33:04 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	d927333c52acdc03599ea9317e35153277714ac0

    Comments

    Add all SDK libraries, and context files belonging to the package / potions of it.
    
    R=brianwilkerson@google.com
    
    Change-Id: I7e5d6cc12657c92f16d65e89f4b60eacf16c51b6
    Reviewed-on: https://dart-review.googlesource.com/c/91260
    Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/services/available_declarations.dart
    • pkg/analyzer/test/src/services/available_declarations_test.dart

41. Add 'Convert to multiline string' quick assist.

    Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
    Changed at	Sunday, 27-Jan-19 21:38:30 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	f92b816268df0675d0bef07c53cf9956756e2d79

    Comments

    Add 'Convert to multiline string' quick assist.
    
    R=brianwilkerson@google.com
    
    Change-Id: Ieaa893e6ceb64ba41d84189267e0087d042fe4e6
    Reviewed-on: https://dart-review.googlesource.com/c/91262
    Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analysis_server/lib/src/services/correction/assist.dart
    • pkg/analysis_server/lib/src/services/correction/assist_internal.dart
    • pkg/analysis_server/test/src/services/correction/assist/convert_to_multiline_string_test.dart
    • pkg/analysis_server/test/src/services/correction/assist/test_all.dart

42. Expose data member 'port' for MessageEvents and automatically pull in markupsafe for go.sh script.

    Changed by	Terry Lucas - terryohnoyoudont@google.com
    Changed at	Sunday, 27-Jan-19 20:06:58 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	c5cfdc52797ef6ae5b13fee7babe71014b56827a

    Comments

    Expose data member 'port' for MessageEvents and automatically pull in markupsafe for go.sh script.
    
    Fixes #35730
    
    R=sigmund@google.com
    
    Change-Id: I91d9622601c99bbbfaad87c24f01db2b26303744
    Reviewed-on: https://dart-review.googlesource.com/c/91165
    Commit-Queue: Terry Lucas <terry@google.com>
    Reviewed-by: Sigmund Cherem <sigmund@google.com>
    

    Changed files

    • DEPS
    • sdk/lib/html/dart2js/html_dart2js.dart
    • tools/dom/scripts/htmlrenamer.py

43. Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.

    Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
    Changed at	Saturday, 26-Jan-19 20:12:55 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	6699384dddfac8da9e4a2edfca2f6445d412358a

    Comments

    Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
    
    R=brianwilkerson@google.com, paulberry@google.com
    
    Bug: https://github.com/dart-lang/sdk/issues/34437
    Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
    Reviewed-on: https://dart-review.googlesource.com/c/91170
    Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart
    • pkg/analysis_server/test/services/refactoring/rename_local_test.dart
    • pkg/analyzer/lib/src/dart/analysis/context_locator.dart
    • pkg/analyzer/lib/src/dart/analysis/driver.dart
    • pkg/analyzer/lib/src/error/inheritance_override.dart
    • pkg/analyzer/test/generated/non_error_resolver.dart
    • pkg/analyzer/test/generated/static_warning_code_test.dart
    • pkg/analyzer/test/src/dart/resolution/resolution.dart
    • pkg/analyzer/test/src/diagnostics/invalid_override_different_default_values_test.dart
    • pkg/analyzer/test/src/diagnostics/test_all.dart
    • pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator_impl.dart
    • tests/co19_2/co19_2-analyzer.status
    • tests/compiler/dart2js/end_to_end/bad_output_io_test.dart

44. Restore TLABs.

    Changed by	Alexander Aprelev - aamohnoyoudont@google.com
    Changed at	Saturday, 26-Jan-19 06:24:18 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	df34f65d90a78b6168f0f4278595e36dff53d910

    Comments

    Restore TLABs.
    
    This reverts commit 324718fadd8664eb16053bedab49630ba5c14013 as it fixes performance issue found on Flutter benchmark.
    
    The fix is to make TLAB smaller than new heap semi-space. Original implementation had TLAB occupy whole semi-space.
    
    Change-Id: I4b5b5a3027b2d352ccb80538079a042406b5cf54
    Reviewed-on: https://dart-review.googlesource.com/c/91171
    Commit-Queue: Alexander Aprelev <aam@google.com>
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    

    Changed files

    • runtime/vm/heap/heap.cc
    • runtime/vm/heap/heap.h
    • runtime/vm/heap/heap_test.cc
    • runtime/vm/heap/scavenger.cc
    • runtime/vm/heap/scavenger.h
    • runtime/vm/heap/verifier.cc
    • runtime/vm/isolate.cc
    • runtime/vm/service.cc
    • runtime/vm/thread.h
    • runtime/vm/thread_registry.h

45. [dart2js] Don't inline direct recursion

    Changed by	Stephen Adams - sraohnoyoudont@google.com
    Changed at	Saturday, 26-Jan-19 01:32:10 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	ece54f3c4373f115d2ce65cf7540f2530d500b70

    Comments

    [dart2js] Don't inline direct recursion
    
    This avoids a bug in handling ir.Let bindings.
    
    Change-Id: I0ccd932248a550a5017dfe565209e8ef62299ff3
    Reviewed-on: https://dart-review.googlesource.com/c/91241
    Reviewed-by: Sigmund Cherem <sigmund@google.com>
    Commit-Queue: Stephen Adams <sra@google.com>
    

    Changed files

    • pkg/compiler/lib/src/ssa/builder_kernel.dart

46. Remove StrongTypeSystemImpl.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 23:31:44 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	d0f92e8cc50efcca9cf47e18fc49e35d4c69564b

    Comments

    Remove StrongTypeSystemImpl.
    
    It was deprecated in analyzer version 0.34.0, and clients are no
    longer using it.
    
    Change-Id: Ib27e9173eb57bcbec700071bd69acbcfaf96e913
    Reviewed-on: https://dart-review.googlesource.com/c/91112
    Commit-Queue: Paul Berry <paulberry@google.com>
    Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
    Auto-Submit: Paul Berry <paulberry@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analyzer/CHANGELOG.md
    • pkg/analyzer/lib/src/generated/type_system.dart

47. Update definite assignment for the code-as-ui changes

    Changed by	Brian Wilkerson - brianwilkersonohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 22:28:05 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	2f3ebf70f6cc9b5210d16abd079e5585ec9a1a67

    Comments

    Update definite assignment for the code-as-ui changes
    
    Change-Id: Id425fd6eb76402118738da13275224ae2d1905aa
    Reviewed-on: https://dart-review.googlesource.com/c/91168
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
    Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/dart/resolver/definite_assignment.dart
    • pkg/analyzer/test/src/dart/resolution/definite_assignment_test.dart

48. Update flow analysis for the code-as-ui changes

    Changed by	Brian Wilkerson - brianwilkersonohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 22:27:54 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	fe285e3e602d5ded34fb301e0ceb8f23792cedf6

    Comments

    Update flow analysis for the code-as-ui changes
    
    Change-Id: I2bf9ea0beda6bc95556d0e1e75183779433f990f
    Reviewed-on: https://dart-review.googlesource.com/c/91169
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
    Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/dart/resolver/flow_analysis.dart
    • pkg/analyzer/test/src/dart/resolution/flow_analysis_test.dart

49. bump to linter 0.1.79

    Changed by	pq - pquitslundohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 21:51:24 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	8e0bc806b906a1b7e63a1f836e4b98a1751dfd8f

    Comments

    bump to linter 0.1.79
    
    Change-Id: I3203eeab9ca3970c00113d33ec8174e4fd88d3f3
    Reviewed-on: https://dart-review.googlesource.com/c/91167
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Phil Quitslund <pquitslund@google.com>
    

    Changed files

    • CHANGELOG.md
    • DEPS

50. Fix registration of (un)provided parameters.

    Changed by	Johnni Winther - johnniwintherohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 21:20:42 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	c7f6c86128abaab5ac306058911c6d6833972f71

    Comments

    Fix registration of (un)provided parameters.
    
    Change-Id: I5cf1b7543561a728a219a62c8fa6633d4d25846a
    Reviewed-on: https://dart-review.googlesource.com/c/91223
    Reviewed-by: Sigmund Cherem <sigmund@google.com>
    Commit-Queue: Johnni Winther <johnniwinther@google.com>
    

    Changed files

    • pkg/compiler/lib/src/enqueue.dart
    • pkg/compiler/lib/src/universe/member_usage.dart
    • pkg/compiler/lib/src/universe/resolution_world_builder.dart
    • pkg/compiler/lib/src/util/enumset.dart
    • tests/compiler/dart2js/member_usage/member_usage_test.dart

51. Check exact type for set literals (issue 35742)

    Changed by	Brian Wilkerson - brianwilkersonohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 21:09:42 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	6fae43b8af4a534458991f5ef9f977bf2bf5d332

    Comments

    Check exact type for set literals (issue 35742)
    
    Change-Id: Icce758b13536171dd20201e52ecae8ecda39a336
    Reviewed-on: https://dart-review.googlesource.com/c/91166
    Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/task/strong/checker.dart
    • pkg/analyzer/test/src/diagnostics/invalid_cast_new_expr_test.dart
    • pkg/analyzer/test/src/diagnostics/test_all.dart

52. Fix #35750 by passing a real ContextBuilder to createWorkspace.

    Changed by	Sam Rawlins - srawlinsohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 21:07:03 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	eadf9679f3f7eecbf0be97956c4eea9d59cda016

    Comments

    Fix #35750 by passing a real ContextBuilder to createWorkspace.
    
    The PackageBuildWorkspace depends on its ContextBuilder to know if a
    [findFile] should return null.
    
    Bug: https://github.com/dart-lang/sdk/issues/35750
    Change-Id: Ic562314fa87d1333e8f07efbb06a461be769ea32
    Reviewed-on: https://dart-review.googlesource.com/c/91161
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Samuel Rawlins <srawlins@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/generated/resolver.dart
    • pkg/analyzer/lib/src/workspace/package_build.dart
    • pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart

53. [VM] Experimental flags in dartkp tests

    Changed by	Liam Appelbe - liamaohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 19:47:40 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	c167cd35723661c6f4bd8557043c231822e28d2d

    Comments

    [VM] Experimental flags in dartkp tests
    
    Plumb experimental flags found in a test's SharedOptions through to the
    gen_kernel command invoked in dartkp tests. Also enable a whole bunch
    of tests that are now passing.
    
    Bug: https://github.com/dart-lang/sdk/issues/35602
    Change-Id: I425f55ea6c84d28e085ab2c848376e396e68a225
    Reviewed-on: https://dart-review.googlesource.com/c/90860
    Commit-Queue: Liam Appelbe <liama@google.com>
    Reviewed-by: Siva Annamalai <asiva@google.com>
    

    Changed files

    • tests/co19_2/co19_2-kernel.status
    • tests/language_2/language_2_kernel.status
    • tests/language_2/language_2_vm.status
    • tools/testing/dart/compiler_configuration.dart

54. [vm] Fix disassembler test after f496e538f4587f29562e161ca6b06f169396f499

    Changed by	Vyacheslav Egorov - vegorovohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 19:37:24 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	759234b05aa3c6cf5e8d652266e2a45673b24897

    Comments

    [vm] Fix disassembler test after f496e538f4587f29562e161ca6b06f169396f499
    
    Allocate comment strings in old space.
    
    TBR=kustermann@google.com
    
    Change-Id: Ie670b87791d01848b9c1b12931bd932331818839
    Reviewed-on: https://dart-review.googlesource.com/c/91224
    Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
    Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
    Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
    

    Changed files

    • runtime/vm/compiler/runtime_api.cc

55. [ VM / dart:io ] Adding to a closed IOSink now throws a StateError

    Changed by	Ben Konyi - bkonyiohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 19:23:56 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	bb560bb233a3ef4714dc86a0f7882f3d4913e523

    Comments

    [ VM / dart:io ] Adding to a closed IOSink now throws a StateError
    
    Based off of these original changes:
    https://codereview.chromium.org/2857393003
    
    This is a breaking change and will require an annoucement stating such
    before landing.
    
    Fixes #29554.
    
    Change-Id: Ibb56fd49648edc6b9fd567240a3bebb05a14234d
    Reviewed-on: https://dart-review.googlesource.com/c/90120
    Commit-Queue: Ben Konyi <bkonyi@google.com>
    Reviewed-by: Siva Annamalai <asiva@google.com>
    

    Changed files

    • CHANGELOG.md
    • sdk/lib/_http/http_impl.dart
    • sdk/lib/async/stream_transformers.dart
    • sdk/lib/io/io_sink.dart
    • tests/co19_2/co19_2-kernel.status
    • tests/standalone_2/io/client_socket_exception_test.dart
    • tests/standalone_2/io/file_test.dart
    • tests/standalone_2/io/http_10_test.dart
    • tests/standalone_2/io/http_content_length_test.dart
    • tests/standalone_2/io/socket_upgrade_to_secure_test.dart

56. Remove unused argument allowNullableDereference

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 19:05:22 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	983b77dda72acd73e1616bb63bf98acd8b5fee82

    Comments

    Remove unused argument allowNullableDereference
    
    Change-Id: I921344bbfe137c376b5b2314a5c82bb2c2bde128
    Reviewed-on: https://dart-review.googlesource.com/c/91111
    Auto-Submit: Paul Berry <paulberry@google.com>
    Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
    Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/generated/error_verifier.dart

57. Authomatically add dependencies from pubspec.yaml files.

    Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 19:03:51 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	f8fef942438a470034998bba1389e1c7b0c7809e

    Comments

    Authomatically add dependencies from pubspec.yaml files.
    
    In addition to (path, modification) also cache on the content hash.
    
    Implement getLibraries().
    
    R=brianwilkerson@google.com
    
    Change-Id: I263b5479f867aa28d5e43bc0c1bb02702ab6c915
    Reviewed-on: https://dart-review.googlesource.com/c/91160
    Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/services/available_declarations.dart
    • pkg/analyzer/test/src/services/available_declarations_test.dart

58. [vm] Misc timeline tweaks.

    Changed by	Ryan Macnak - rmacnakohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 18:37:05 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	169331abb18f7dff514b198cd36d0700dd66ff75

    Comments

    [vm] Misc timeline tweaks.
    
     - Move compiler pass events to a new CompilerVerbose stream
     - Remove serialization phase events
     - Add class name to class finalization event (lost along with finalization events in recent cleanups of finalization)
     - Add event for kernel loading
    
    Change-Id: Ie72bced978400ea174c1551c961baa55c691b019
    Reviewed-on: https://dart-review.googlesource.com/c/90883
    Commit-Queue: Ryan Macnak <rmacnak@google.com>
    Reviewed-by: Zach Anderson <zra@google.com>
    Reviewed-by: Alexander Markov <alexmarkov@google.com>
    

    Changed files

    • runtime/vm/class_finalizer.cc
    • runtime/vm/clustered_snapshot.cc
    • runtime/vm/compiler/aot/precompiler.cc
    • runtime/vm/compiler/backend/type_propagator.cc
    • runtime/vm/compiler/compiler_pass.cc
    • runtime/vm/compiler/compiler_pass.h
    • runtime/vm/compiler/frontend/bytecode_reader.cc
    • runtime/vm/compiler/jit/compiler.cc
    • runtime/vm/dart.cc
    • runtime/vm/heap/marker.cc
    • runtime/vm/heap/marker.h
    • runtime/vm/heap/pages.h
    • runtime/vm/heap/sweeper.cc
    • runtime/vm/kernel_loader.cc
    • runtime/vm/timeline.cc
    • runtime/vm/timeline.h

59. Refactor for statement parsing

    Changed by	Dan Rubel - danrubelohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 18:15:00 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	874f9d0bdf91974d9d98d46a2fa2786c4b5c4c90

    Comments

    Refactor for statement parsing
    
    This CL introduces 2 new parser listener events
    in preparation for parsing for control flow structures
    in literal lists, sets, and maps.
    
    Change-Id: I230f36cded714a13e4badb401fe5b5906c93a2da
    Reviewed-on: https://dart-review.googlesource.com/c/91144
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Dan Rubel <danrubel@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/fasta/ast_builder.dart
    • pkg/analyzer/test/generated/parser_fasta_listener.dart
    • pkg/analyzer/test/src/fasta/recovery/partial_code/forEach_statement_test.dart
    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/parser/forwarding_listener.dart
    • pkg/front_end/lib/src/fasta/parser/listener.dart
    • pkg/front_end/lib/src/fasta/parser/parser.dart
    • pkg/front_end/lib/src/fasta/source/stack_listener.dart
    • pkg/front_end/lib/src/fasta/source/type_promotion_look_ahead_listener.dart

60. [vm, gc] Remove --gc_at_alloc.

    Changed by	Ryan Macnak - rmacnakohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 18:03:30 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	9043e5be449fa3fa63c378a41ae7f61638b69fbd

    Comments

    [vm, gc] Remove --gc_at_alloc.
    
    Change-Id: Ied987c5fb0389432474a6ef8ee62ed7089c9e672
    Reviewed-on: https://dart-review.googlesource.com/c/91142
    Reviewed-by: Siva Annamalai <asiva@google.com>
    Commit-Queue: Ryan Macnak <rmacnak@google.com>
    

    Changed files

    • runtime/vm/flag_list.h
    • runtime/vm/heap/scavenger.cc
    • runtime/vm/heap/scavenger.h

61. [vm] Fix build after f496e538f4587f29562e161ca6b06f169396f499

    Changed by	Vyacheslav Egorov - vegorovohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 18:01:50 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	27760001f5d36ab027b4ce1fbecb245331bd2402

    Comments

    [vm] Fix build after f496e538f4587f29562e161ca6b06f169396f499
    
    * Introduce forward declaration for RawObject;
    * Move compiler::target::ClassTable::ClassOffsetFor under ifdef PRODUCT
    
    Change-Id: Iacf5cbdaec0c2999aae7c8e0683a58e392f3e960
    Reviewed-on: https://dart-review.googlesource.com/c/91220
    Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
    Reviewed-by: Martin Kustermann <kustermann@google.com>
    Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
    

    Changed files

    • runtime/vm/compiler/runtime_api.cc
    • runtime/vm/compiler/runtime_api.h
    • runtime/vm/instructions_arm64.h
    • runtime/vm/object.cc

62. Report duplicate set entries with a different error

    Changed by	Sigmund Cherem - sigmundohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 17:12:43 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	bb4a8807777b734949802f9fb903aad292c26eed

    Comments

    Report duplicate set entries with a different error
    
    It will take some time until the CFE will take on reporting this error (and
    duplicate keys in maps).
    
    For now: detect whether a map is used as the implementation of a set literal,
    and if so report the error differently.
    
    Change-Id: I9f657189c79a4532023f615aa91bf63602f27664
    Reviewed-on: https://dart-review.googlesource.com/c/91102
    Reviewed-by: Johnni Winther <johnniwinther@google.com>
    Commit-Queue: Sigmund Cherem <sigmund@google.com>
    

    Changed files

    • pkg/compiler/lib/src/common_elements.dart
    • pkg/compiler/lib/src/constants/evaluation.dart
    • pkg/compiler/lib/src/constants/expressions.dart
    • pkg/compiler/lib/src/diagnostics/messages.dart
    • tests/compiler/dart2js/model/constant_expression_evaluate_test.dart

63. [vm] Decouple assemblers from runtime.

    Changed by	Vyacheslav Egorov - vegorovohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 16:45:13 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	f496e538f4587f29562e161ca6b06f169396f499

    Comments

    [vm] Decouple assemblers from runtime.
    
    This is the next step towards preventing compiler from directly peeking
    into runtime and instead interact with runtime through a well defined
    surface. The goal of the refactoring to locate all places where compiler
    accesses some runtime information and partion those accesses into two
    categories:
    
    - creating objects in the host runtime (e.g. allocating strings, numbers, etc)
    during compilation;
    - accessing properties of the target runtime (e.g. offsets of fields) to
    embed those into the generated code;
    
    This change introduces dart::compiler and dart::compiler::target namespaces.
    
    All code in the compiler will gradually be moved into dart::compiler namespace.
    One of the motivations for this change is to be able to prevent access to
    globally defined host constants like kWordSize by shadowing them in the
    dart::compiler namespace.
    
    The nested namespace dart::compiler::target hosts all information about
    target runtime that compiler could access, e.g. compiler::target::kWordSize
    defines word size of the target which will eventually be made different
    from the host kWordSize (defined by dart::kWordSize).
    
    The API for compiler to runtime interaction is placed into compiler_api.h.
    
    Note that we still permit runtime to access compiler internals directly -
    this is not going to be decoupled as part of this work.
    
    Issue https://github.com/dart-lang/sdk/issues/31709
    
    Change-Id: If4396d295879391becfa6c38d4802bbff81f5b20
    Reviewed-on: https://dart-review.googlesource.com/c/90242
    Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
    Reviewed-by: Martin Kustermann <kustermann@google.com>
    

    Changed files

    • runtime/vm/allocation.h
    • runtime/vm/bitfield.h
    • runtime/vm/bitmap.h
    • runtime/vm/class_id.h
    • runtime/vm/clustered_snapshot.cc
    • runtime/vm/code_entry_kind.h
    • runtime/vm/code_patcher.h
    • runtime/vm/code_patcher_x64.cc
    • runtime/vm/compiler/aot/precompiler.cc
    • runtime/vm/compiler/aot/precompiler.h
    • runtime/vm/compiler/assembler/assembler.cc
    • runtime/vm/compiler/assembler/assembler.h
    • runtime/vm/compiler/assembler/assembler_arm.cc
    • runtime/vm/compiler/assembler/assembler_arm.h
    • runtime/vm/compiler/assembler/assembler_arm64.cc
    • runtime/vm/compiler/assembler/assembler_arm64.h
    • runtime/vm/compiler/assembler/assembler_arm64_test.cc
    • runtime/vm/compiler/assembler/assembler_arm_test.cc
    • runtime/vm/compiler/assembler/assembler_dbc.cc
    • runtime/vm/compiler/assembler/assembler_dbc.h
    • runtime/vm/compiler/assembler/assembler_dbc_test.cc
    • runtime/vm/compiler/assembler/assembler_ia32.cc
    • runtime/vm/compiler/assembler/assembler_ia32.h
    • runtime/vm/compiler/assembler/assembler_ia32_test.cc
    • runtime/vm/compiler/assembler/assembler_test.cc
    • runtime/vm/compiler/assembler/assembler_x64.cc
    • runtime/vm/compiler/assembler/assembler_x64.h
    • runtime/vm/compiler/assembler/assembler_x64_test.cc
    • runtime/vm/compiler/assembler/disassembler.h
    • runtime/vm/compiler/assembler/disassembler_arm.cc
    • runtime/vm/compiler/assembler/disassembler_arm64.cc
    • runtime/vm/compiler/assembler/disassembler_kbc.cc
    • runtime/vm/compiler/assembler/disassembler_test.cc
    • runtime/vm/compiler/assembler/disassembler_x86.cc
    • runtime/vm/compiler/assembler/object_pool_builder.h
    • runtime/vm/compiler/backend/flow_graph_compiler.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_arm.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_arm64.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_dbc.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_ia32.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_x64.cc
    • runtime/vm/compiler/backend/il.cc
    • runtime/vm/compiler/backend/il_arm.cc
    • runtime/vm/compiler/backend/il_arm64.cc
    • runtime/vm/compiler/backend/il_dbc.cc
    • runtime/vm/compiler/backend/il_ia32.cc
    • runtime/vm/compiler/backend/il_x64.cc
    • runtime/vm/compiler/backend/linearscan.cc
    • runtime/vm/compiler/backend/locations.cc
    • runtime/vm/compiler/backend/locations.h
    • runtime/vm/compiler/compiler_pass.h
    • runtime/vm/compiler/compiler_sources.gni
    • runtime/vm/compiler/frontend/bytecode_flow_graph_builder.cc
    • runtime/vm/compiler/frontend/bytecode_reader.cc
    • runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc
    • runtime/vm/compiler/frontend/prologue_builder.cc
    • runtime/vm/compiler/intrinsifier.h
    • runtime/vm/compiler/intrinsifier_arm.cc
    • runtime/vm/compiler/intrinsifier_arm64.cc
    • runtime/vm/compiler/intrinsifier_ia32.cc
    • runtime/vm/compiler/intrinsifier_x64.cc
    • runtime/vm/compiler/jit/compiler.cc
    • runtime/vm/compiler/runtime_api.cc
    • runtime/vm/compiler/runtime_api.h
    • runtime/vm/constants_arm.h
    • runtime/vm/constants_arm64.h
    • runtime/vm/dart.cc
    • runtime/vm/deopt_instructions.cc
    • runtime/vm/flag_list.h
    • runtime/vm/frame_layout.h
    • runtime/vm/handle_visitor.h
    • runtime/vm/handles.cc
    • runtime/vm/handles.h
    • runtime/vm/heap/freelist.cc
    • runtime/vm/heap/heap.h
    • runtime/vm/heap/verifier.h
    • runtime/vm/instructions_arm.cc
    • runtime/vm/instructions_arm.h
    • runtime/vm/instructions_arm64.cc
    • runtime/vm/instructions_arm64.h
    • runtime/vm/instructions_dbc.cc
    • runtime/vm/instructions_ia32.h
    • runtime/vm/instructions_x64.cc
    • runtime/vm/instructions_x64.h
    • runtime/vm/isolate.cc
    • runtime/vm/isolate.h
    • runtime/vm/log.h
    • runtime/vm/megamorphic_cache_table.cc
    • runtime/vm/megamorphic_cache_table.h
    • runtime/vm/native_entry.h
    • runtime/vm/native_function.h
    • runtime/vm/object.cc
    • runtime/vm/object.h
    • runtime/vm/object_reload.cc
    • runtime/vm/object_service.cc
    • runtime/vm/object_test.cc
    • runtime/vm/os.h
    • runtime/vm/os_thread.h
    • runtime/vm/pointer_tagging.h
    • runtime/vm/raw_object.cc
    • runtime/vm/raw_object.h
    • runtime/vm/runtime_entry.h
    • runtime/vm/simulator_arm.cc
    • runtime/vm/simulator_arm64.cc
    • runtime/vm/stack_frame.cc
    • runtime/vm/stack_frame.h
    • runtime/vm/stub_code.cc
    • runtime/vm/stub_code.h
    • runtime/vm/stub_code_arm.cc
    • runtime/vm/stub_code_arm64.cc
    • runtime/vm/stub_code_arm64_test.cc
    • runtime/vm/stub_code_arm_test.cc
    • runtime/vm/stub_code_ia32.cc
    • runtime/vm/stub_code_x64.cc
    • runtime/vm/stub_code_x64_test.cc
    • runtime/vm/thread.cc
    • runtime/vm/thread.h
    • runtime/vm/thread_state.cc
    • runtime/vm/thread_state.h
    • runtime/vm/type_testing_stubs.h
    • runtime/vm/unit_test.h
    • runtime/vm/vm_sources.gni

64. [infra] Mark gclient-try as non-experimental.

    Changed by	Jonas Termansen - sortieohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 14:43:09 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	a5030ed92fc5974ad126d4e279f011e6e1409d1e

    Comments

    [infra] Mark gclient-try as non-experimental.
    
    Change-Id: Ib2f7630b3e2d45fe0ab5a7e8541dab59314817b5
    Reviewed-on: https://dart-review.googlesource.com/c/91201
    Reviewed-by: William Hesse <whesse@google.com>
    

    Changed files

    • tools/infra/config/cq.cfg

65. [infra] Fix approve_results deleting existing meta-information.

    Changed by	Jonas Termansen - sortieohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 14:38:48 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	b2a93177a014bd63313ac0e2de0e03516bdb00e2

    Comments

    [infra] Fix approve_results deleting existing meta-information.
    
    Change-Id: I585344cdf13d8cde93b0eba8e850d436a11c9200
    Reviewed-on: https://dart-review.googlesource.com/c/91200
    Reviewed-by: William Hesse <whesse@google.com>
    

    Changed files

    • tools/approve_results.dart

66. Add evaluation support for code-as-ui features

    Changed by	Brian Wilkerson - brianwilkersonohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 14:20:04 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	4f9af4cd03a765b20c448b4a635d53d2094c9e10

    Comments

    Add evaluation support for code-as-ui features
    
    Change-Id: I604d03218df8af0f405017367b906f944e877762
    Reviewed-on: https://dart-review.googlesource.com/c/91110
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
    Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/dart/ast/ast.dart
    • pkg/analyzer/lib/src/dart/constant/evaluation.dart
    • pkg/analyzer/lib/src/dart/constant/utilities.dart
    • pkg/analyzer/test/src/dart/constant/evaluation_test.dart

67. [VM] Fix use-after-free: move free after use

    Changed by	Martin Kustermann - kustermannohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 13:14:19 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	dfeee239c4bb80449fb4895f46be76f25cfc1efb

    Comments

    [VM] Fix use-after-free: move free after use
    
    Change-Id: Idcedbd8bdbd94f126846c5390c6cb8d00a21de57
    Reviewed-on: https://dart-review.googlesource.com/c/91180
    Auto-Submit: Martin Kustermann <kustermann@google.com>
    Reviewed-by: Martin Kustermann <kustermann@google.com>
    Commit-Queue: Martin Kustermann <kustermann@google.com>
    

    Changed files

    • runtime/vm/clustered_snapshot.cc

68. [VM/AOT] Ensure we set flags from snapshot very early in the VM initialization

    Changed by	Martin Kustermann - kustermannohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 10:31:48 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	51bc367806c1b8f65b8c4ae453472538c5e78e0f

    Comments

    [VM/AOT] Ensure we set flags from snapshot very early in the VM initialization
    
    There are uses of flags before the VM snapshot gets read, so we need to
    move the "snapshot sniffing" code to the very beginning of Dart::Init().
    
    Due to the fact that FullSnapshotReader/Deserializer assume there is a
    [Thread] available - and we don't have a [Thread] yet when we should
    process the flags - this CL moves version/feature logic into a new
    [SnapshotHeaderReader] class which does not depend on Thread/...
    
    Change-Id: I38a45041f0696b96e44fc2b294e3442a5fba1a81
    Reviewed-on: https://dart-review.googlesource.com/c/90941
    Commit-Queue: Martin Kustermann <kustermann@google.com>
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    

    Changed files

    • runtime/tests/vm/dart/use_bare_instructions_flag_test.dart
    • runtime/tests/vm/vm.status
    • runtime/vm/clustered_snapshot.cc
    • runtime/vm/clustered_snapshot.h
    • runtime/vm/dart.cc

69. [VM/AOT] Turn bare instructions on by default

    Changed by	Martin Kustermann - kustermannohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 10:25:18 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	8c439c7e841d04d2f05b963fe54457be526ac3d0

    Comments

    [VM/AOT] Turn bare instructions on by default
    
    Issue https://github.com/dart-lang/sdk/issues/33274
    
    Change-Id: I44850d5906143a53d6b1872eb729364c3a509f9a
    Reviewed-on: https://dart-review.googlesource.com/c/91060
    Commit-Queue: Martin Kustermann <kustermann@google.com>
    Reviewed-by: Siva Annamalai <asiva@google.com>
    

    Changed files

    • runtime/vm/flag_list.h
    • tools/bots/test_matrix.json

70. Incorporate mixin declarations in language specification.

    Changed by	Lasse R.H. Nielsen - lrnohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 09:30:51 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	89347169c715d39e5d3e6ae588cd2bdcbb875492

    Comments

    Incorporate mixin declarations in language specification.
    
    Change-Id: I41e8f558fd4c3145637a7d2f09cc261815ab2161
    Reviewed-on: https://dart-review.googlesource.com/c/84605
    Reviewed-by: Erik Ernst <eernst@google.com>
    Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
    

    Changed files

    • docs/language/dartLangSpec.tex

71. [ Test ] Remove support for flutter runtime from the test framework

    Changed by	asiva - asivaohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 04:16:43 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	0a41a2d292a0746bc9388fd473e0a4ad81a8b634

    Comments

    [ Test ] Remove support for flutter runtime from the test framework
    
    Support for the flutter runtime (sky_shell) was added to the Dart
    test framework in the hope that one could run the flutter engine
    through the Dart test suite. We never got around to running these
    tests on the build bots, the sky_shell executable has been deprecated
    and there are plans in the flutter engine team to have their own
    unit test frame work.
    
    See Issue https://github.com/flutter/flutter/issues/9115 for more
    details.
    
    Change-Id: I6ee9e8c919721dccecf4202ab0778939aeb79174
    Reviewed-on: https://dart-review.googlesource.com/c/91103
    Reviewed-by: Ben Konyi <bkonyi@google.com>
    Commit-Queue: Siva Annamalai <asiva@google.com>
    

    Changed files

    • pkg/pkg.status
    • tests/co19_2/co19_2-runtime.status
    • tests/corelib_2/corelib_2.status
    • tests/language_2/language_2_flutter.status
    • tests/lib_2/lib_2.status
    • tests/lib_2/lib_2_flutter.status
    • tests/lib_2/lib_2_precompiled.status
    • tests/standalone_2/standalone_2.status
    • tests/standalone_2/standalone_2_flutter.status
    • tools/testing/dart/configuration.dart
    • tools/testing/dart/options.dart
    • tools/testing/dart/runtime_configuration.dart
    • tools/testing/dart/status_reporter.dart
    • tools/testing/dart/test_suite.dart

72. Fix postmessage to treat it's input as a serializable value

    Changed by	Stephen Adams - sraohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 03:56:06 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	6bcb017c56e805ffc5cdf781c8fb3b9784065ee7

    Comments

    Fix postmessage to treat it's input as a serializable value
    
    Change-Id: I11744735f5e6d6a5593e6ac3f00d87813577db7e
    Reviewed-on: https://dart-review.googlesource.com/c/91141
    Reviewed-by: Stephen Adams <sra@google.com>
    Commit-Queue: Sigmund Cherem <sigmund@google.com>
    

    Changed files

    • sdk/lib/html/dart2js/html_dart2js.dart
    • tools/dom/scripts/generator.py

73. [dart/tools] Option to limit column widths in code size tool

    Changed by	Aart Bik - ajcbikohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 02:28:53 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	a851d4c3708f23262785a7a8109a8de280de9d15

    Comments

    [dart/tools] Option to limit column widths in code size tool
    
    Rationale:
    Ensures that copy-paste into gerrit yields readable code.
    
    https://github.com/dart-lang/sdk/issues/35323
    
    Change-Id: I3df2ed7712216bd67ed092ff62524785ac47ca52
    Reviewed-on: https://dart-review.googlesource.com/c/90862
    Reviewed-by: Siva Annamalai <asiva@google.com>
    Commit-Queue: Aart Bik <ajcbik@google.com>
    

    Changed files

    • pkg/vm/bin/compare_sizes.dart

74. [vm] Fix header includes

    Changed by	Matthew Dempsky - mdempskyohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 02:03:51 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	adf48e4d4b484c1b7a81583d0f7b7c9e65fba72b

    Comments

    [vm] Fix header includes
    
    In https://dart-review.googlesource.com/c/sdk/+/91104, I meant to
    delete #include <endian.h>, and accidentally removed #include
    <errno.h> instead.
    
    Change-Id: I52e55350d2817c3e6543a8bf806492f1b1dcf3db
    Reviewed-on: https://dart-review.googlesource.com/c/91109
    Auto-Submit: Matthew Dempsky <mdempsky@google.com>
    Reviewed-by: Siva Annamalai <asiva@google.com>
    Commit-Queue: Siva Annamalai <asiva@google.com>
    

    Changed files

    • runtime/vm/os_android.cc

75. [vm] Implement VirtualMemory::Allocate using AllocateAligned

    Changed by	Matthew Dempsky - mdempskyohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 01:22:20 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	b11f2d8e69005b0c7c66014f8cfe863308aee32e

    Comments

    [vm] Implement VirtualMemory::Allocate using AllocateAligned
    
    Instead of implementing separate aligned and unaligned memory
    allocation primitives for each OS, just change the unaligned allocator
    into a wrapper around the aligned primitive.
    
    While here, we can optimize the AllocateAligned logic slightly: if we
    want an N-page-aligned allocation, we only need to increase the
    allocation size by N-1 pages instead of N.
    
    Notably, this means 1-page-aligned allocations don't require any extra
    alignment pages, so the new logic behaves identically as before on
    Android, Fuchsia, Linux, and macOS.
    
    On Windows, it behaves slightly differently only in that unaligned
    requests used to be handled as a single VirtualAlloc call with
    MEM_RESERVE | MEM_COMMIT, but now they're handled as two separate
    calls (reserve *then* commit). Naively, I don't expect this matters in
    practice, but if it does, we can always add a fast path for
    alignment==page_size_ without affecting the OS-independent API.
    
    Change-Id: I42b2cf5dfc6e137546d8acfb6cc8939a01687948
    Reviewed-on: https://dart-review.googlesource.com/c/91081
    Commit-Queue: Ryan Macnak <rmacnak@google.com>
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    

    Changed files

    • runtime/vm/virtual_memory.h
    • runtime/vm/virtual_memory_fuchsia.cc
    • runtime/vm/virtual_memory_posix.cc
    • runtime/vm/virtual_memory_win.cc

76. Include MessagePort in convertions for workers

    Changed by	Sigmund Cherem - sigmundohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 01:00:35 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	60d7e8f72f4b651d1cc76795057c5ebdbca145e6

    Comments

    Include MessagePort in convertions for workers
    
    Address 2 of the 3 issues mentioned in https://github.com/dart-lang/sdk/issues/35730
    
    Change-Id: I4ad67eddf266cdfb8847a277a6d19243dce23184
    Reviewed-on: https://dart-review.googlesource.com/c/91106
    Reviewed-by: Stephen Adams <sra@google.com>
    Commit-Queue: Sigmund Cherem <sigmund@google.com>
    

    Changed files

    • sdk/lib/html/html_common/conversions_dart2js.dart

77. [vm] Check compiler flags for Dart_Save/LoadTypeFeedback.

    Changed by	Ryan Macnak - rmacnakohnoyoudont@google.com
    Changed at	Friday, 25-Jan-19 00:53:55 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	41dc546c6b1786ebd7b95245e838b6bac43fa5fe

    Comments

    [vm] Check compiler flags for Dart_Save/LoadTypeFeedback.
    
    Change-Id: Ic733591ce1cac7d69fde28a115f11d43902923bc
    Reviewed-on: https://dart-review.googlesource.com/c/90640
    Reviewed-by: Zach Anderson <zra@google.com>
    Commit-Queue: Ryan Macnak <rmacnak@google.com>
    

    Changed files

    • runtime/vm/compilation_trace.cc
    • runtime/vm/dart.cc

78. [VM / Compiler] Change some OS::PrintErr to THR_Print

    Changed by	asiva - asivaohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 23:52:02 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	fb2d829a0e53edff4a66cacec77a1edfda6716af

    Comments

    [VM / Compiler] Change some OS::PrintErr to THR_Print
    
    We still see some trace messages related to the compiler coming from the
    service isolate when debugging compilations. Chnaged some of the
    
    OS::PrintErr calls in the trace code under the compiler to THR_Print
    so traces from the service isolate can be filtered out.
    Change-Id: Ib370cb3bf4a1ce175b4ade9fafa187fecfa91cef
    Reviewed-on: https://dart-review.googlesource.com/c/91140
    Commit-Queue: Siva Annamalai <asiva@google.com>
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Reviewed-by: Aart Bik <ajcbik@google.com>
    

    Changed files

    • runtime/vm/compiler/backend/flow_graph.cc
    • runtime/vm/compiler/backend/il.cc
    • runtime/vm/compiler/jit/jit_call_specializer.cc

79. [vm] Remove unused endian-conversion code

    Changed by	Matthew Dempsky - mdempskyohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 23:32:33 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	ec6b212421096ed9ed7d0e2346c6483f4b3e8928

    Comments

    [vm] Remove unused endian-conversion code
    
    These seem to have accidentally snuck in as part of
    https://codereview.chromium.org/14299008
    
    Change-Id: I861eba1655d6f175ddfabf2a39908168b890d911
    Reviewed-on: https://dart-review.googlesource.com/c/91104
    Reviewed-by: Siva Annamalai <asiva@google.com>
    Commit-Queue: Siva Annamalai <asiva@google.com>
    

    Changed files

    • runtime/vm/os_android.cc

80. [vm] Deduplicate POSIX-based memory allocation code

    Changed by	Matthew Dempsky - mdempskyohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 22:39:50 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	0193dd58faf2bfa83a0d4602d02b42bbae01c590

    Comments

    [vm] Deduplicate POSIX-based memory allocation code
    
    The Android, Linux, and macOS VirtualMemory implementations were
    identical and using the same POSIX-standardized interfaces, so
    deduplicate them into a common virtual_memory_posix.cc implementation.
    
    Change-Id: I58a2aaa959aac69af52d9faba88865a4ef20d004
    Reviewed-on: https://dart-review.googlesource.com/c/91080
    Commit-Queue: Ryan Macnak <rmacnak@google.com>
    Reviewed-by: Siva Annamalai <asiva@google.com>
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Auto-Submit: Matthew Dempsky <mdempsky@google.com>
    

    Changed files

    • runtime/vm/virtual_memory_android.cc
    • runtime/vm/virtual_memory_linux.cc
    • runtime/vm/virtual_memory_posix.cc
    • runtime/vm/vm_sources.gni

81. Update parser to support simple if/else control flow in literal lists, sets, and maps

    Changed by	danrubel - danrubelohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 22:22:50 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	56123f08b021e6d97154219e3ff915a17c150c01

    Comments

    Update parser to support simple if/else control flow in literal lists, sets, and maps
    
    Change-Id: I740beea833ed1ad76582ad5232549bd204981808
    Reviewed-on: https://dart-review.googlesource.com/c/90901
    Commit-Queue: Dan Rubel <danrubel@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analysis_server/test/analysis/notification_highlights2_test.dart
    • pkg/analysis_server/test/analysis/notification_highlights_test.dart
    • pkg/analyzer/lib/src/fasta/ast_builder.dart
    • pkg/analyzer/test/generated/parser_fasta_listener.dart
    • pkg/analyzer/test/generated/parser_fasta_test.dart
    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/parser/forwarding_listener.dart
    • pkg/front_end/lib/src/fasta/parser/listener.dart
    • pkg/front_end/lib/src/fasta/parser/literal_entry_info_impl.dart
    • pkg/front_end/lib/src/fasta/source/type_promotion_look_ahead_listener.dart
    • pkg/front_end/test/fasta/parser/literal_entry_info_test.dart

82. Remove four packages from DEPS

    Changed by	Kevin Moore - kevmooohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 21:40:58 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	7a1e7b5fff66baf21b193c18ad8591c13c48e4a4

    Comments

    Remove four packages from DEPS
    
    pkg:platform is no longer useds. process and file were only needed by platform
    pkg:func is no longer used
    
    Also removed non-existent entries in .packages
    
    Change-Id: I927856efa0f6fc49676885616c3ecd5183250454
    Reviewed-on: https://dart-review.googlesource.com/c/91101
    Commit-Queue: Kevin Moore <kevmoo@google.com>
    Reviewed-by: Alexander Thomas <athom@google.com>
    

    Changed files

    • .packages
    • DEPS

83. Adjust dart2js notes

    Changed by	Sam Rawlins - srawlinsohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 20:22:41 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	f4afaee42274f9bfd45e63870c4620b5b03cef1a

    Comments

    Adjust dart2js notes
    
    The sentence starting with "Because" is not a third "In particular"
    bullet point.
    
    Change-Id: Icdd2bc82b3650d9595a571de459e9683a6c0a41b
    Reviewed-on: https://dart-review.googlesource.com/c/91040
    Reviewed-by: Sigmund Cherem <sigmund@google.com>
    Commit-Queue: Samuel Rawlins <srawlins@google.com>
    

    Changed files

    • CHANGELOG.md

84. Fix #35305, promoting a type that should not be promoted.

    Changed by	Mike Fairhurst - mfairhurstohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 19:10:06 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	31dc729452668ccf8eeb74add22dca468927f615

    Comments

    Fix #35305, promoting a type that should not be promoted.
    
    Bug: 35305
    Change-Id: If62e875feed1bed73ec189fa011183fd3e5b4a1b
    Reviewed-on: https://dart-review.googlesource.com/c/90881
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/generated/type_system.dart
    • pkg/analyzer/test/src/diagnostics/test_all.dart
    • pkg/analyzer/test/src/diagnostics/undefined_getter.dart

85. Prevent serialization of synthetic kernel nodes

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 18:55:44 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	15dc147226319fcec7d21618b57839f74b381d23

    Comments

    Prevent serialization of synthetic kernel nodes
    
    Change-Id: Iad2300d8fa5384b5d692c5598c9311e600427dd2
    Reviewed-on: https://dart-review.googlesource.com/c/90003
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    

    Changed files

    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
    • pkg/front_end/lib/src/fasta/problems.dart
    • pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
    • pkg/front_end/testcases/accessors.dart.strong.expect
    • pkg/front_end/testcases/accessors.dart.strong.transformed.expect
    • pkg/front_end/testcases/bug21938.dart.strong.expect
    • pkg/front_end/testcases/cascade.dart.strong.expect
    • pkg/front_end/testcases/cascade.dart.strong.transformed.expect
    • pkg/front_end/testcases/continue_inference_after_error.dart.strong.expect
    • pkg/front_end/testcases/continue_inference_after_error.dart.strong.transformed.expect
    • pkg/front_end/testcases/for_in_without_declaration.dart.strong.expect
    • pkg/front_end/testcases/for_in_without_declaration.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/downwards_inference_on_function_expressions.dart.strong.expect
    • pkg/front_end/testcases/inference/downwards_inference_on_function_expressions.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart.strong.expect
    • pkg/front_end/testcases/inference/downwards_inference_on_generic_function_expressions.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/generic_methods_iterable_and_future.dart.strong.expect
    • pkg/front_end/testcases/inference/generic_methods_iterable_and_future.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/infer_from_complex_expressions_if_outer_most_value_is_precise.dart.strong.expect
    • pkg/front_end/testcases/invalid_type.dart.strong.expect
    • pkg/front_end/testcases/many_errors.dart.legacy.expect
    • pkg/front_end/testcases/many_errors.dart.legacy.transformed.expect
    • pkg/front_end/testcases/many_errors.dart.strong.expect
    • pkg/front_end/testcases/many_errors.dart.strong.transformed.expect
    • pkg/front_end/testcases/rasta/constant_get_and_invoke.dart.strong.expect
    • pkg/front_end/testcases/rasta/constant_get_and_invoke.dart.strong.transformed.expect
    • pkg/front_end/testcases/rasta/issue_000032.dart.strong.expect
    • pkg/front_end/testcases/rasta/issue_000032.dart.strong.transformed.expect
    • pkg/front_end/testcases/rasta/issue_000044.dart.strong.expect
    • pkg/front_end/testcases/rasta/issue_000044.dart.strong.transformed.expect
    • pkg/front_end/testcases/rasta/static.dart.strong.expect
    • pkg/front_end/testcases/rasta/static.dart.strong.transformed.expect
    • pkg/front_end/testcases/rasta/super.dart.strong.expect
    • pkg/front_end/testcases/rasta/unresolved_for_in.dart.strong.expect
    • pkg/front_end/testcases/rasta/unresolved_for_in.dart.strong.transformed.expect
    • pkg/front_end/testcases/regress/issue_31155.dart.strong.expect
    • pkg/front_end/testcases/regress/issue_31155.dart.strong.transformed.expect
    • pkg/front_end/testcases/regress/issue_31188.dart.strong.expect
    • pkg/front_end/testcases/regress/issue_31188.dart.strong.transformed.expect
    • pkg/front_end/testcases/regress/issue_34225.dart.strong.expect
    • pkg/front_end/testcases/regress/issue_34225.dart.strong.transformed.expect
    • pkg/front_end/testcases/regress/issue_34563.dart.strong.expect
    • pkg/front_end/testcases/regress/issue_34563.dart.strong.transformed.expect
    • pkg/front_end/testcases/strong.status
    • pkg/front_end/testcases/text_serialization.status
    • pkg/front_end/testcases/undefined.dart.strong.expect
    • pkg/front_end/testcases/undefined.dart.strong.transformed.expect
    • pkg/front_end/testcases/undefined_getter_in_compound_assignment.dart.strong.expect
    • pkg/front_end/testcases/undefined_getter_in_compound_assignment.dart.strong.transformed.expect

86. Test that shows leaking synthetic nodes

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 18:55:44 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	53b372f5756a2b959c7b6c3c686ae26f15a1cc93

    Comments

    Test that shows leaking synthetic nodes
    
    Change-Id: I8f68795380c1d6963203f9356244d2599be6c9cb
    Reviewed-on: https://dart-review.googlesource.com/c/90002
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    

    Changed files

    • pkg/front_end/testcases/many_errors.dart
    • pkg/front_end/testcases/many_errors.dart.hierarchy.expect
    • pkg/front_end/testcases/many_errors.dart.legacy.expect
    • pkg/front_end/testcases/many_errors.dart.legacy.transformed.expect
    • pkg/front_end/testcases/many_errors.dart.outline.expect
    • pkg/front_end/testcases/strong.status
    • pkg/front_end/testcases/text_serialization.status

87. Create kernel nodes from parsed types

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 18:53:04 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	07ec31dcf1e39c7be8af3f1367621e4e6e7e4e5e

    Comments

    Create kernel nodes from parsed types
    
    Change-Id: I2f56d05c7d6639ec3e3d7848cddcc665d13086a1
    Reviewed-on: https://dart-review.googlesource.com/c/90004
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    

    Changed files

    • pkg/front_end/test/fasta/types/kernel_type_parser.dart
    • pkg/front_end/test/fasta/types/kernel_type_parser_test.dart
    • pkg/front_end/test/fasta/types/type_parser.dart

88. Revert "Revert "Issue 34152. Verify file paths and report INVALID_FILE_PATH_FORMAT.""

    Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 17:30:41 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	6de1c478c3bbdc604e3d63c633a4686622429cf3

    Comments

    Revert "Revert "Issue 34152. Verify file paths and report INVALID_FILE_PATH_FORMAT.""
    
    This reverts commit 3f8ea3f5088c47c35909d9e7da8b1ba46c0af078.
    
    Change-Id: Ib034895f4cf29492e66dd07b7da1a99ba5e94bf6
    Reviewed-on: https://dart-review.googlesource.com/c/90885
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
    

    Changed files

    • pkg/analysis_server/lib/src/analysis_server.dart
    • pkg/analysis_server/lib/src/domain_analysis.dart
    • pkg/analysis_server/lib/src/domain_completion.dart
    • pkg/analysis_server/lib/src/edit/edit_domain.dart
    • pkg/analysis_server/test/analysis/get_errors_test.dart
    • pkg/analysis_server/test/analysis/get_hover_test.dart
    • pkg/analysis_server/test/analysis/get_navigation_test.dart
    • pkg/analysis_server/test/analysis/get_signature_test.dart
    • pkg/analysis_server/test/analysis/set_priority_files_test.dart
    • pkg/analysis_server/test/analysis/update_content_test.dart
    • pkg/analysis_server/test/domain_analysis_test.dart
    • pkg/analysis_server/test/domain_completion_test.dart
    • pkg/analysis_server/test/edit/assists_test.dart
    • pkg/analysis_server/test/edit/fixes_test.dart
    • pkg/analysis_server/test/edit/organize_directives_test.dart
    • pkg/analysis_server/test/edit/postfix_completion_test.dart
    • pkg/analysis_server/test/edit/refactoring_test.dart
    • pkg/analysis_server/test/edit/sort_members_test.dart
    • pkg/analysis_server/test/edit/statement_completion_test.dart

89. [fuchsia] Always allocate executable memory in W^X mode

    Changed by	Matthew Dempsky - mdempskyohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 16:59:08 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	8e2f3ea4d643de86ef2ee42b45e682bfa43c820d

    Comments

    [fuchsia] Always allocate executable memory in W^X mode
    
    In W^X mode (i.e., FLAG_write_protect_code), the Dart VM allocates
    code memory with is_executable==false and then later makes it
    executable with Protect(kReadExecute). However, on Fuchsia, this will
    require a VMO with ZX_RIGHT_EXECUTE (which soon will not be the
    default).
    
    This CL takes the approach of always adding ZX_RIGHT_EXECUTE when in
    W^X mode. This is suboptimal because it means all VM allocated memory
    can be changed to executable, but currently the OS-independent
    VirtualMemory::Allocate API doesn't provide us a way to identify
    memory that doesn't need to be executable now but will in the future.
    (Note that ZX_RIGHT_EXECUTE only *allows* mapping the memory as
    executable; the memory is still initially mapped by
    VirtualMemory::Allocate as non-executable.)
    
    Extending the VirtualMemory::Allocate API is tracked in FL-172.
    
    Bug: SEC-42
    Change-Id: I20555c546c5ab1798c4c36b7394f6221d3993c9e
    Reviewed-on: https://dart-review.googlesource.com/c/90882
    Reviewed-by: Zach Anderson <zra@google.com>
    Commit-Queue: Zach Anderson <zra@google.com>
    

    Changed files

    • runtime/vm/virtual_memory_fuchsia.cc

90. Disable task model for clients by making WorkItem inconstructible.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 16:29:17 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	c9b1877cbf31934a57019cc67d7f62628eb69113

    Comments

    Disable task model for clients by making WorkItem inconstructible.
    
    The task model is still allowed in analyzer tests since we still have
    some unit tests of non-task-model functionality that rely on the task
    model to do their testing (see #35734).
    
    Unit tests whose sole purpose was to test the task model have been
    removed.  Test files that now empty have been removed.  Non-empty test
    files that now contain no tests of their own have had their `main`
    functions removed, and have been renamed so that the testing
    infrastructure will no longer attempt to run them.
    
    Change-Id: I8b4d0b2dde9337c4e1fe91e443a2c9da6eee8f4f
    Reviewed-on: https://dart-review.googlesource.com/c/90720
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Paul Berry <paulberry@google.com>
    

    Changed files

    • pkg/analyzer/CHANGELOG.md
    • pkg/analyzer/lib/src/task/driver.dart
    • pkg/analyzer/test/generated/all_the_rest_test.dart
    • pkg/analyzer/test/generated/checked_mode_compile_time_error_code.dart
    • pkg/analyzer/test/generated/checked_mode_compile_time_error_code_driver_test.dart
    • pkg/analyzer/test/generated/compile_time_error_code.dart
    • pkg/analyzer/test/generated/compile_time_error_code_driver_test.dart
    • pkg/analyzer/test/generated/constant_test.dart
    • pkg/analyzer/test/generated/declaration_resolver_test.dart
    • pkg/analyzer/test/generated/element_resolver_test.dart
    • pkg/analyzer/test/generated/error_suppression.dart
    • pkg/analyzer/test/generated/error_suppression_driver_test.dart
    • pkg/analyzer/test/generated/hint_code_test.dart
    • pkg/analyzer/test/generated/invalid_code.dart
    • pkg/analyzer/test/generated/invalid_code_driver_test.dart
    • pkg/analyzer/test/generated/non_error_resolver.dart
    • pkg/analyzer/test/generated/non_error_resolver_driver_test.dart
    • pkg/analyzer/test/generated/non_hint_code.dart
    • pkg/analyzer/test/generated/non_hint_code_driver_test.dart
    • pkg/analyzer/test/generated/resolver_test.dart
    • pkg/analyzer/test/generated/simple_resolver_test.dart
    • pkg/analyzer/test/generated/static_type_analyzer_test.dart
    • pkg/analyzer/test/generated/static_type_warning_code.dart
    • pkg/analyzer/test/generated/static_type_warning_code_driver_test.dart
    • pkg/analyzer/test/generated/static_warning_code_test.dart
    • pkg/analyzer/test/generated/strong_mode.dart
    • pkg/analyzer/test/generated/strong_mode_driver_test.dart
    • pkg/analyzer/test/generated/test_all.dart
    • pkg/analyzer/test/src/context/context_test.dart
    • pkg/analyzer/test/src/context/test_all.dart
    • pkg/analyzer/test/src/dart/analysis/driver_test.dart
    • pkg/analyzer/test/src/dart/constant/evaluation_test.dart
    • pkg/analyzer/test/src/dart/element/element_test.dart
    • pkg/analyzer/test/src/dart/resolution/assignment_test.dart
    • pkg/analyzer/test/src/dart/resolution/class_alias_test.dart
    • pkg/analyzer/test/src/dart/resolution/class_test.dart
    • pkg/analyzer/test/src/dart/resolution/comment_test.dart
    • pkg/analyzer/test/src/dart/resolution/constant_test.dart
    • pkg/analyzer/test/src/dart/resolution/enum_test.dart
    • pkg/analyzer/test/src/dart/resolution/for_in_test.dart
    • pkg/analyzer/test/src/dart/resolution/generic_type_alias_test.dart
    • pkg/analyzer/test/src/dart/resolution/import_prefix_test.dart
    • pkg/analyzer/test/src/dart/resolution/instance_creation_test.dart
    • pkg/analyzer/test/src/dart/resolution/instance_member_inference_class_test.dart
    • pkg/analyzer/test/src/dart/resolution/instance_member_inference_mixin_test.dart
    • pkg/analyzer/test/src/dart/resolution/mixin_test.dart
    • pkg/analyzer/test/src/dart/resolution/top_type_inference_test.dart
    • pkg/analyzer/test/src/diagnostics/argument_type_not_assignable_test.dart
    • pkg/analyzer/test/src/diagnostics/can_be_null_after_null_aware_test.dart
    • pkg/analyzer/test/src/diagnostics/const_constructor_with_mixin_with_field_test.dart
    • pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart
    • pkg/analyzer/test/src/diagnostics/division_optimization_test.dart
    • pkg/analyzer/test/src/diagnostics/invalid_assignment_test.dart
    • pkg/analyzer/test/src/diagnostics/invalid_required_param_test.dart
    • pkg/analyzer/test/src/diagnostics/unnecessary_cast_test.dart
    • pkg/analyzer/test/src/diagnostics/unused_field_test.dart
    • pkg/analyzer/test/src/diagnostics/unused_import_test.dart
    • pkg/analyzer/test/src/diagnostics/unused_label_test.dart
    • pkg/analyzer/test/src/diagnostics/unused_shown_name_test.dart
    • pkg/analyzer/test/src/diagnostics/use_of_void_result_test.dart
    • pkg/analyzer/test/src/summary/expr_builder_test.dart
    • pkg/analyzer/test/src/summary/resynthesize_ast_test.dart
    • pkg/analyzer/test/src/task/dart_test.dart
    • pkg/analyzer/test/src/task/driver_test.dart
    • pkg/analyzer/test/src/task/html_test.dart
    • pkg/analyzer/test/src/task/options_test.dart
    • pkg/analyzer/test/src/task/strong/checker_test.dart
    • pkg/analyzer/test/src/task/strong/dart2_inference_test.dart
    • pkg/analyzer/test/src/task/strong/inferred_type_test.dart
    • pkg/analyzer/test/src/task/strong_mode_test.dart
    • pkg/analyzer/test/src/task/test_all.dart
    • pkg/analyzer/test/src/task/yaml_test.dart

91. [infra] Fix expected results of multitests, drop checked-only results.

    Changed by	William Hesse - whesseohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 12:44:09 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	bd2b07cd71136057a3846fe6d1f2eef1adf7ff24

    Comments

    [infra] Fix expected results of multitests, drop checked-only results.
    
    All multitests expecting errors were just being reported as expecting "fail", not as expecting compile-time
    or runtime error.  Cleaned up legacy checked-only expectations as a side effect.
    
    Change-Id: I7785db0e094e3af3464700fbc71aac30b8bb4282
    Reviewed-on: https://dart-review.googlesource.com/c/90684
    Reviewed-by: Jonas Termansen <sortie@google.com>
    Auto-Submit: William Hesse <whesse@google.com>
    

    Changed files

    • tools/testing/dart/command_output.dart
    • tools/testing/dart/multitest.dart
    • tools/testing/dart/test_progress.dart
    • tools/testing/dart/test_runner.dart
    • tools/testing/dart/test_suite.dart

92. Performed copyedits proposed by Patrice Chalin

    Changed by	Erik Ernst - eernstohnoyoudont@google.com
    Changed at	Thursday, 24-Jan-19 12:42:13 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	33ae5f0a470b77f9f8c2ae892d6af64d10be1f6e

    Comments

    Performed copyedits proposed by Patrice Chalin
    
    .. in https://codereview.chromium.org/1217533003. Several of them were
    not applicable because the text is very different today, and many were
    already performed. This CL performs the missing ones.
    
    Cf. https://github.com/dart-lang/sdk/issues/23781.
    
    Change-Id: If356c887188368ec26755d99aa7d97fa8ea56b8c
    Reviewed-on: https://dart-review.googlesource.com/c/90223
    Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
    

    Changed files

    • docs/language/dartLangSpec.tex