Builder vm-kernel-linux-release-ia32 Build 1572

Results:

Success

Trigger Info:

Project	dart
Revision	b10f17960890b053a5c1ac9303e0f9332fc8bd17
Got Revision	b10f17960890b053a5c1ac9303e0f9332fc8bd17

Execution:

• Source: Task 4276fad0e3bd6610
• Bot: trusty-dart-68765ebb-us-central1-b-d68c
• Recipe: dart/neo

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 184 ms ) setup_build

   running recipe: "dart/neo"
   • stdout
   • run_recipe
2. ( 2 secs ) gsutil find latest build
   • stdout
   • raw_io.output_text[latest]
3. ( 1 secs ) gsutil get revision for latest build
   • stdout
   • raw_io.output_text[revision]
4. ( 149 ms ) ensure_goma
   • - no logs -
   1. ( 149 ms ) ensure_installed
      • stdout
      • json.output
5. ( 23 secs ) bot_update

   [74GB/295GB used (25%)]
   • stdout
   • json.output
6. ( 417 ms ) clobber
   • stdout
7. ( 1 mins 6 secs ) gclient runhooks
   • stdout
8. ( 522 ms ) kill processes
   • stdout
9. ( 548 ms ) read test-matrix.json
   • stdout
   • json.output
10. ( 735 ms ) delete debug log
    • stdout
11. ( 787 ms ) write fileset analyzer_unit_tests to sdk root
    • stdout
12. ( 791 ms ) write fileset dart2js to sdk root
    • stdout
13. ( 814 ms ) write fileset dart2js_hostasserts to sdk root
    • stdout
14. ( 776 ms ) write fileset fuzzer to sdk root
    • stdout
15. ( 1 secs ) write fileset vm-kernel to sdk root
    • stdout
16. ( 710 ms ) gclient get checked-in SDK version
    • stdout
    • raw_io.output_text
17. ( 390 ms ) git show
    • stdout
18. ( 512 ms ) kill processes (2)
    • stdout
19. ( 3 secs ) preprocess_for_goma
    • - no logs -
    1. ( 738 ms ) goma cache directory
       • stdout
    2. ( 849 ms ) start_goma
       • stdout
       • cloudtail
    3. ( 1 secs ) start cloudtail
       • stdout
20. ( 1 mins 45 secs ) build dart
    • stdout
21. ( 7 secs ) postprocess_for_goma
    • - no logs -
    1. ( 515 ms ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 509 ms ) goma_stat
       • stdout
    3. ( 505 ms ) stop_goma
       • stdout
    4. ( 4 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
    5. ( 1 secs ) stop cloudtail
       • stdout
22. ( 37 secs ) upload testing fileset vm-kernel

    swarming fileset hash: 7de2ea5a34660389a6317671da679b86816bdc1f
    • stdout
23. ( 9 secs ) trigger shards for vm tests
    • - no logs -
    1. ( 888 ms ) [trigger] vm tests_shard_1

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    2. ( 846 ms ) [trigger] vm tests_shard_2

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    3. ( 1 secs ) [trigger] vm tests_shard_3

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    4. ( 1 secs ) [trigger] vm tests_shard_4

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    5. ( 984 ms ) [trigger] vm tests_shard_5

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    6. ( 1 secs ) [trigger] vm tests_shard_6

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    7. ( 960 ms ) [trigger] vm tests_shard_7

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    8. ( 1 secs ) [trigger] vm tests_shard_8

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
    9. ( 1 secs ) [trigger] vm tests_shard_9

       Run on OS: 'Linux'
       • stdout
       • json.output
       • shard #0
24. ( 3 mins 32 secs ) vm tests_shard_10
    • stdout
    • results.json
    • run.json
    • logs.json
25. ( 295 ms ) ensure swarming
    • - no logs -
    1. ( 295 ms ) ensure_installed
       • stdout
       • json.output
26. ( 13 mins 28 secs ) vm tests_shard_1

    Run on OS: 'Linux'

    Pending time: 0:10:04.763823

    Shard duration: 0:06:54.548410
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
27. ( 1 secs ) vm tests_shard_2

    Run on OS: 'Linux'

    Pending time: 0:10:07.251472

    Shard duration: 0:06:20.425849
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
28. ( 1 secs ) vm tests_shard_3

    Run on OS: 'Linux'

    Pending time: 0:10:12.265519

    Shard duration: 0:05:08.458133
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
29. ( 1 secs ) vm tests_shard_4

    Run on OS: 'Linux'

    Pending time: 0:10:16.895913

    Shard duration: 0:06:03.495189
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
30. ( 1 secs ) vm tests_shard_5

    Run on OS: 'Linux'

    Pending time: 0:10:24.405381

    Shard duration: 0:05:51.475259
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
31. ( 1 secs ) vm tests_shard_6

    Run on OS: 'Linux'

    Pending time: 0:10:36.235442

    Shard duration: 0:04:37.152687
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
32. ( 1 secs ) vm tests_shard_7

    Run on OS: 'Linux'

    Pending time: 0:10:44.858336

    Shard duration: 0:04:48.229230
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
33. ( 1 secs ) vm tests_shard_8

    Run on OS: 'Linux'

    Pending time: 0:10:50.425695

    Shard duration: 0:05:58.319485
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
34. ( 1 secs ) vm tests_shard_9

    Run on OS: 'Linux'

    Pending time: 0:10:52.441646

    Shard duration: 0:04:42.016945
    • stdout
    • json.output
    • swarming.summary
    • Merge script log
    • run.json
    • results.json
    • logs.json
    • shard #0 isolated out
    • test stdout of shard #0
35. ( 5 secs ) download previous results
    • - no logs -
    1. ( 444 ms ) ensure LATEST dir
       • stdout
    2. ( 456 ms ) ensure results.json exists
       • stdout
    3. ( 445 ms ) ensure flaky.json exists
       • stdout
    4. ( 450 ms ) ensure approved_results.json exists
       • stdout
    5. ( 2 secs ) gsutil download previous results
       • stdout
    6. ( 1 secs ) gsutil download approved results
       • stdout
36. ( 800 ms ) list tests to deflake (vm tests)
    • stdout
    • raw_io.output_text
37. ( 12 secs ) deflake vm tests
    • stdout
    • results.json
    • run.json
    • logs.json
38. ( 593 ms ) update flakiness information
    • stdout
    • raw_io.output_text[flaky.json]
39. ( 802 ms ) find tests that began failing
    • stdout
40. ( 818 ms ) find tests that began failing (logs)
    • stdout
41. ( 801 ms ) find tests that began passing
    • stdout
    • raw_io.output_text
42. ( 789 ms ) find unapproved failing tests
    • stdout
    • raw_io.output_text
43. ( 827 ms ) find unapproved failing tests (logs)
    • stdout
    • raw_io.output_text
44. ( 795 ms ) find unapproved passing tests
    • stdout
    • raw_io.output_text
45. ( 1 secs ) test results
    • stdout
    • tests that began passing
    • unapproved failing tests
    • unapproved failing tests (logs)
    • unapproved passing tests
    • results.json
46. ( 16 secs ) upload new results
    • - no logs -
    1. ( 1 secs ) gsutil upload revision
       • stdout
       • gsutil.upload
    2. ( 1 secs ) gsutil upload logs.json
       • stdout
       • gsutil.upload
    3. ( 1 secs ) gsutil upload results.json
       • stdout
       • gsutil.upload
    4. ( 1 secs ) gsutil upload flaky.json
       • stdout
       • gsutil.upload
    5. ( 1 secs ) gsutil upload flaky_current_vm-kernel-linux-release-ia32.json
       • stdout
       • gsutil.upload
    6. ( 1 secs ) gsutil upload
       • stdout
       • gsutil.upload
    7. ( 1 secs ) gsutil upload runs.json
       • stdout
       • gsutil.upload
    8. ( 1 secs ) gsutil update "latest" reference
       • stdout
       • gsutil.upload
    9. ( 645 ms ) ensure_installed
       • stdout
       • json.output
    10. ( 3 secs ) upload test results to big query
        • - no logs -
        1. ( 469 ms ) upload results chunk to big query
           • stdout
        2. ( 282 ms ) upload results chunk to big query (2)
           • stdout
        3. ( 314 ms ) upload results chunk to big query (3)
           • stdout
        4. ( 325 ms ) upload results chunk to big query (4)
           • stdout
        5. ( 328 ms ) upload results chunk to big query (5)
           • stdout
        6. ( 312 ms ) upload results chunk to big query (6)
           • stdout
        7. ( 358 ms ) upload results chunk to big query (7)
           • stdout
        8. ( 344 ms ) upload results chunk to big query (8)
           • stdout
        9. ( 289 ms ) upload results chunk to big query (9)
           • stdout
        10. ( 378 ms ) upload results chunk to big query (10)
            • stdout
        11. ( 238 ms ) upload results chunk to big query (11)
            • stdout
47. ( 516 ms ) kill processes (3)
    • stdout
48. ( 9 ms ) debug log
    • stdout
49. ( 1 ms ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"trusty-dart-68765ebb-us-central1-b-d68c"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.dart.ci.sandbox", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547767989512348, "id": "8924041348587770288", "project": "dart", "tags": ["builder:vm-kernel-linux-release-ia32", "buildset:commit/git/b10f17960890b053a5c1ac9303e0f9332fc8bd17", "buildset:commit/gitiles/dart.googlesource.com/sdk/+/b10f17960890b053a5c1ac9303e0f9332fc8bd17", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089471410712985952", "scheduler_job_id:dart/vm-kernel-linux-release-ia32", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"vm-kernel-linux-release-ia32"	setup_build
buildnumber	1572	setup_build
clobber	"true"	setup_build
mastername	"client.dart"	setup_build
path_config	"generic"	setup_build
recipe	"dart/neo"	setup_build
repository	"https://dart.googlesource.com/sdk/"	setup_build
revision	"b10f17960890b053a5c1ac9303e0f9332fc8bd17"	setup_build
got_revision	"b10f17960890b053a5c1ac9303e0f9332fc8bd17"	bot_update

Blamelist:

1. Alexander Markov (alexmarkovohnoyoudont@google.com)

Timing:

Create	Thursday, 17-Jan-19 23:33:09 UTC
Start	Thursday, 17-Jan-19 23:46:28 UTC
End	Friday, 18-Jan-19 00:09:04 UTC
Pending	13 mins 19 secs
Execution	22 mins 35 secs

All Changes:

1. [vm] Cleanup Dart_Get/Set/HasStickyError API and use isolate's sticky error only as a backup for thread's sticky error

   Changed by	Alexander Markov - alexmarkovohnoyoudont@google.com
   Changed at	Thursday, 17-Jan-19 23:27:13 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	b10f17960890b053a5c1ac9303e0f9332fc8bd17

   Comments

   [vm] Cleanup Dart_Get/Set/HasStickyError API and use isolate's sticky error only as a backup for thread's sticky error
   
   Both thread and isolate have sticky error fields. Dart API was using
   isolate's sticky error, while Dart code was using thread's sticky error.
   There was a one-way move of a thread's sticky error into isolate
   when thread was unscheduled.
   
   This causes a problem as error in the isolate may go unnoticed and
   repeated unscheduling/re-scheduling might end up overwriting the error
   in the isolate (which triggers the assertion).
   
   To solve this problem, this CL:
   * Cleans up Dart API which manipulates isolate's sticky error, so
     isolate's sticky error is never set directly.
   * When sceduling an isolate to a thread, sticky error is moved back from
     isolate (if any).
   
   With this changes, thread's sticky error is always used if thread is running,
   and isolate's sticky error is only used to hold sticky error while
   isolate has no thread.
   
   Fixes https://github.com/dart-lang/sdk/issues/35590
   
   Change-Id: I99b128cac363ca2df75f6e64c083b1ec36c866ce
   Reviewed-on: https://dart-review.googlesource.com/c/89442
   Reviewed-by: Ryan Macnak <rmacnak@google.com>
   Commit-Queue: Alexander Markov <alexmarkov@google.com>
   

   Changed files

   • runtime/bin/main.cc
   • runtime/include/dart_api.h
   • runtime/vm/dart_api_impl.cc
   • runtime/vm/dart_api_impl_test.cc
   • runtime/vm/isolate.cc
   • runtime/vm/isolate.h
   • runtime/vm/object.cc
   • runtime/vm/service.cc
   • runtime/vm/service_isolate.cc
   • runtime/vm/service_test.cc
   • tests/lib_2/isolate/kill_regexp_test.dart