Builder vm-kernel-linux-release-ia32 Build 1572
Results:
Success
Trigger Info:
Project | dart |
Revision | b10f17960890b053a5c1ac9303e0f9332fc8bd17 |
Got Revision | b10f17960890b053a5c1ac9303e0f9332fc8bd17 |
Execution:
- Source: Task 4276fad0e3bd6610
- Bot: trusty-dart-68765ebb-us-central1-b-d68c
- Recipe: dart/neo
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
-
( 37 secs ) upload testing fileset vm-kernelswarming fileset hash: 7de2ea5a34660389a6317671da679b86816bdc1f
-
- - no logs -
-
- - no logs -
-
( 13 mins 28 secs ) vm tests_shard_1Run on OS: 'Linux'Pending time: 0:10:04.763823Shard duration: 0:06:54.548410
-
( 1 secs ) vm tests_shard_2Run on OS: 'Linux'Pending time: 0:10:07.251472Shard duration: 0:06:20.425849
-
( 1 secs ) vm tests_shard_3Run on OS: 'Linux'Pending time: 0:10:12.265519Shard duration: 0:05:08.458133
-
( 1 secs ) vm tests_shard_4Run on OS: 'Linux'Pending time: 0:10:16.895913Shard duration: 0:06:03.495189
-
( 1 secs ) vm tests_shard_5Run on OS: 'Linux'Pending time: 0:10:24.405381Shard duration: 0:05:51.475259
-
( 1 secs ) vm tests_shard_6Run on OS: 'Linux'Pending time: 0:10:36.235442Shard duration: 0:04:37.152687
-
( 1 secs ) vm tests_shard_7Run on OS: 'Linux'Pending time: 0:10:44.858336Shard duration: 0:04:48.229230
-
( 1 secs ) vm tests_shard_8Run on OS: 'Linux'Pending time: 0:10:50.425695Shard duration: 0:05:58.319485
-
( 1 secs ) vm tests_shard_9Run on OS: 'Linux'Pending time: 0:10:52.441646Shard duration: 0:04:42.016945
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "trusty-dart-68765ebb-us-central1-b-d68c" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.dart.ci.sandbox", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547767989512348, "id": "8924041348587770288", "project": "dart", "tags": ["builder:vm-kernel-linux-release-ia32", "buildset:commit/git/b10f17960890b053a5c1ac9303e0f9332fc8bd17", "buildset:commit/gitiles/dart.googlesource.com/sdk/+/b10f17960890b053a5c1ac9303e0f9332fc8bd17", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089471410712985952", "scheduler_job_id:dart/vm-kernel-linux-release-ia32", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "vm-kernel-linux-release-ia32" | setup_build |
buildnumber | 1572 | setup_build |
clobber | "true" | setup_build |
mastername | "client.dart" | setup_build |
path_config | "generic" | setup_build |
recipe | "dart/neo" | setup_build |
repository | "https://dart.googlesource.com/sdk/" | setup_build |
revision | "b10f17960890b053a5c1ac9303e0f9332fc8bd17" | setup_build |
got_revision | "b10f17960890b053a5c1ac9303e0f9332fc8bd17" | bot_update |
Blamelist:
- Alexander Markov (alexmarkovohnoyoudont@google.com)
Timing:
Create | Thursday, 17-Jan-19 23:33:09 UTC |
Start | Thursday, 17-Jan-19 23:46:28 UTC |
End | Friday, 18-Jan-19 00:09:04 UTC |
Pending | 13 mins 19 secs |
Execution | 22 mins 35 secs |
All Changes:
-
[vm] Cleanup Dart_Get/Set/HasStickyError API and use isolate's sticky error only as a backup for thread's sticky error
Changed by Alexander Markov - alexmarkovohnoyoudont@google.com Changed at Thursday, 17-Jan-19 23:27:13 UTC Repository https://dart.googlesource.com/sdk Branch Revision b10f17960890b053a5c1ac9303e0f9332fc8bd17 Comments
[vm] Cleanup Dart_Get/Set/HasStickyError API and use isolate's sticky error only as a backup for thread's sticky error Both thread and isolate have sticky error fields. Dart API was using isolate's sticky error, while Dart code was using thread's sticky error. There was a one-way move of a thread's sticky error into isolate when thread was unscheduled. This causes a problem as error in the isolate may go unnoticed and repeated unscheduling/re-scheduling might end up overwriting the error in the isolate (which triggers the assertion). To solve this problem, this CL: * Cleans up Dart API which manipulates isolate's sticky error, so isolate's sticky error is never set directly. * When sceduling an isolate to a thread, sticky error is moved back from isolate (if any). With this changes, thread's sticky error is always used if thread is running, and isolate's sticky error is only used to hold sticky error while isolate has no thread. Fixes https://github.com/dart-lang/sdk/issues/35590 Change-Id: I99b128cac363ca2df75f6e64c083b1ec36c866ce Reviewed-on: https://dart-review.googlesource.com/c/89442 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com>
Changed files
- runtime/bin/main.cc
- runtime/include/dart_api.h
- runtime/vm/dart_api_impl.cc
- runtime/vm/dart_api_impl_test.cc
- runtime/vm/isolate.cc
- runtime/vm/isolate.h
- runtime/vm/object.cc
- runtime/vm/service.cc
- runtime/vm/service_isolate.cc
- runtime/vm/service_test.cc
- tests/lib_2/isolate/kill_regexp_test.dart