Home | Search | dart - Builders
Login

Builder analyzer-mac-release-stable Build 2 Apple OSX

Results:

Failure analyze tests enable-asserts Failure analyze pkg tests enable-asserts Failure analyzer_cli unit tests Failure analyzer_plugin unit tests Failure analyze tests co19_2 Failure analyzer unit tests_shard_1 Failure analyzer unit tests_shard_2 Failure analysis_server unit tests_shard_1 Failure analysis_server unit tests_shard_2

Trigger Info:

Projectdart
Revisione1e89a628f0873da90447580e0ac75e04144ee2b
Got Revisione1e89a628f0873da90447580e0ac75e04144ee2b

Execution:

Steps and Logfiles:

Show:
  1. ( 266 ms ) setup_build
    running recipe: "dart/neo"
  2. ( 39 secs ) bot_update
    [180GB/232GB used (77%)]
  3. ( 635 ms ) clobber
  4. ( 3 mins 42 secs ) gclient runhooks
  5. ( 1 secs ) kill processes
  6. ( 524 ms ) read test-matrix.json
  7. ( 986 ms ) write fileset analyzer_unit_tests to sdk root
  8. ( 606 ms ) write fileset dart2js to sdk root
  9. ( 594 ms ) write fileset dart2js_hostasserts to sdk root
  10. ( 631 ms ) write fileset vm-kernel to sdk root
  11. ( 280 ms ) git show
  12. ( 867 ms ) kill processes (2)
  13. ( 506 ms ) ensure_installed
  14. ( 58 secs ) install xcode
  15. ( 93 ms ) select XCode
  16. ( 8 mins 10 secs ) build dart
  17. ( 59 ms ) reset XCode
  18. ( 57 secs ) upload testing fileset analyzer_unit_tests
    swarming fileset hash: 8357938578ca83f2711de9d0d8325e0aa6665cf5
  19. ( 2 secs ) analyze tests enable-asserts
  20. ( 2 secs ) analyze pkg tests enable-asserts
  21. ( 2 secs ) analyzer_cli unit tests
  22. ( 2 secs ) analyzer_plugin unit tests
  23. ( 2 secs ) analyze tests co19_2
  24. ( 2 mins 36 secs ) analyzer unit tests_shard_1
    Run on OS: 'Mac'
    Pending time: 0:02:12.954735
    Shard duration: 38s
  25. ( 19 secs ) analyzer unit tests_shard_2
    Run on OS: 'Mac'
    Pending time: 0:02:32.100276
    Shard duration: 37s
  26. ( 2 secs ) analysis_server unit tests_shard_1
    Run on OS: 'Mac'
    Pending time: 0:02:36.297095
    Shard duration: 35s
  27. ( 1 secs ) analysis_server unit tests_shard_2
    Run on OS: 'Mac'
    Pending time: 0:02:45.650907
    Shard duration: 24s
  28. ( 551 ms ) list tests to deflake (analyze pkg tests enable-asserts)
  29. ( 2 secs ) deflake analyze pkg tests enable-asserts
  30. ( 550 ms ) list tests to deflake (analyzer_cli unit tests)
  31. ( 2 secs ) deflake analyzer_cli unit tests
  32. ( 551 ms ) list tests to deflake (analyzer unit tests)
  33. ( 2 secs ) deflake analyzer unit tests
  34. ( 551 ms ) list tests to deflake (analyze tests enable-asserts)
  35. ( 2 secs ) deflake analyze tests enable-asserts
  36. ( 548 ms ) list tests to deflake (analysis_server unit tests)
  37. ( 2 secs ) deflake analysis_server unit tests
  38. ( 551 ms ) list tests to deflake (analyze tests co19_2)
  39. ( 2 secs ) deflake analyze tests co19_2
  40. ( 558 ms ) list tests to deflake (analyzer_plugin unit tests)
  41. ( 2 secs ) deflake analyzer_plugin unit tests
  42. ( 548 ms ) update flakiness information
  43. ( 576 ms ) test results
  44. ( 890 ms ) kill processes (3)
  45. ( 10 ms ) debug log
  46. ( 0 ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm21-m9" setup_build
branch "refs/heads/stable" setup_build
buildbucket {"build": {"bucket": "luci.dart.ci.sandbox", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542132326614122, "id": "8929950769446320768", "project": "dart", "tags": ["builder:analyzer-mac-release-stable", "buildset:commit/git/e1e89a628f0873da90447580e0ac75e04144ee2b", "buildset:commit/gitiles/dart.googlesource.com/sdk/+/e1e89a628f0873da90447580e0ac75e04144ee2b", "gitiles_ref:refs/heads/stable", "scheduler_invocation_id:9095380832050742784", "scheduler_job_id:dart/analyzer-mac-release-stable", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "analyzer-mac-release-stable" setup_build
buildnumber 2 setup_build
clobber "true" setup_build
mastername "client.dart" setup_build
path_config "generic" setup_build
recipe "dart/neo" setup_build
repository "https://dart.googlesource.com/sdk/" setup_build
revision "e1e89a628f0873da90447580e0ac75e04144ee2b" setup_build
got_revision "e1e89a628f0873da90447580e0ac75e04144ee2b" bot_update

Blamelist:

  1. Alexander Thomas (athomohnoyoudont@google.com)
  2. William Hesse (whesseohnoyoudont@google.com)
  3. Aart Bik (ajcbikohnoyoudont@google.com)
  4. Aart Bik (ajcbikohnoyoudont@google.com)
  5. asiva (asivaohnoyoudont@google.com)
  6. Samir Jindel (sjindelohnoyoudont@google.com)
  7. William Hesse (whesseohnoyoudont@google.com)
  8. Jenny Messerly (jmesserlyohnoyoudont@google.com)
  9. Sigmund Cherem (sigmundohnoyoudont@google.com)
  10. William Hesse (whesseohnoyoudont@google.com)
  11. Siva Annamalai (asivaohnoyoudont@google.com)
  12. Ben Konyi (bkonyiohnoyoudont@google.com)
  13. Jenny Messerly (jmesserlyohnoyoudont@google.com)
  14. Sigmund Cherem (sigmundohnoyoudont@google.com)
  15. Jenny Messerly (jmesserlyohnoyoudont@google.com)
  16. Peter von der Ahé (aheohnoyoudont@google.com)
  17. Ryan Macnak (rmacnakohnoyoudont@google.com)
  18. Ryan Macnak (rmacnakohnoyoudont@google.com)
  19. Dan Rubel (danrubelohnoyoudont@google.com)
  20. Ben Konyi (bkonyiohnoyoudont@google.com)
  21. William Hesse (whesseohnoyoudont@google.com)
  22. Jens Johansen (jensjohnoyoudont@google.com)
  23. Vyacheslav Egorov (vegorovohnoyoudont@google.com)
  24. Jenny Messerly (jmesserlyohnoyoudont@google.com)
  25. pq (pquitslundohnoyoudont@google.com)
  26. danrubel (danrubelohnoyoudont@google.com)
  27. William Hesse (whesseohnoyoudont@google.com)
  28. Dan Rubel (danrubelohnoyoudont@google.com)
  29. Alexander Thomas (athomohnoyoudont@google.com)
  30. Régis Crelier (regisohnoyoudont@google.com)
  31. Alexander Markov (alexmarkovohnoyoudont@google.com)
  32. Régis Crelier (regisohnoyoudont@google.com)
  33. Régis Crelier (regisohnoyoudont@google.com)
  34. Danny Tuppeny (dantupohnoyoudont@google.com)
  35. Alexander Markov (alexmarkovohnoyoudont@google.com)
  36. Nate Bosch (nboschohnoyoudont@google.com)
  37. Aart Bik (ajcbikohnoyoudont@google.com)
  38. Paul Berry (paulberryohnoyoudont@google.com)
  39. Alexander Markov (alexmarkovohnoyoudont@google.com)
  40. Aart Bik (ajcbikohnoyoudont@google.com)
  41. Devon Carew (devoncarewohnoyoudont@google.com)
  42. Vyacheslav Egorov (vegorovohnoyoudont@google.com)
  43. Alexander Thomas (athomohnoyoudont@google.com)
  44. Dan Rubel (danrubelohnoyoudont@google.com)
  45. Vyacheslav Egorov (vegorovohnoyoudont@google.com)
  46. Vyacheslav Egorov (vegorovohnoyoudont@google.com)
  47. Régis Crelier (regisohnoyoudont@google.com)
  48. Dan Rubel (danrubelohnoyoudont@google.com)
  49. Vyacheslav Egorov (vegorovohnoyoudont@google.com)
  50. Kevin Millikin (kmillikinohnoyoudont@google.com)
  51. Alexander Thomas (athomohnoyoudont@google.com)
  52. Dan Rubel (danrubelohnoyoudont@google.com)
  53. Vyacheslav Egorov (vegorovohnoyoudont@google.com)
  54. Vyacheslav Egorov (vegorovohnoyoudont@google.com)
  55. Vyacheslav Egorov (vegorovohnoyoudont@google.com)
  56. Erik Ernst (eernstohnoyoudont@google.com)
  57. Samir Jindel (sjindelohnoyoudont@google.com)
  58. Dmitry Stefantsov (dmitryasohnoyoudont@google.com)
  59. Lasse R.H. Nielsen (lrnohnoyoudont@google.com)
  60. Kevin Millikin (kmillikinohnoyoudont@google.com)
  61. Erik Ernst (eernstohnoyoudont@google.com)
  62. Dan Rubel (danrubelohnoyoudont@google.com)
  63. Paul Berry (paulberryohnoyoudont@google.com)
  64. Alexander Markov (alexmarkovohnoyoudont@google.com)
  65. Nate Bosch (nboschohnoyoudont@google.com)
  66. Dan Rubel (danrubelohnoyoudont@google.com)
  67. Alexander Markov (alexmarkovohnoyoudont@google.com)
  68. Régis Crelier (regisohnoyoudont@google.com)
  69. Alexander Markov (alexmarkovohnoyoudont@google.com)
  70. Régis Crelier (regisohnoyoudont@google.com)
  71. Danny Tuppeny (dantupohnoyoudont@google.com)
  72. Martin Kustermann (kustermannohnoyoudont@google.com)
  73. Vyacheslav Egorov (vegorovohnoyoudont@google.com)
  74. Jonas Termansen (sortieohnoyoudont@google.com)
  75. Martin Kustermann (kustermannohnoyoudont@google.com)
  76. Dmitry Stefantsov (dmitryasohnoyoudont@google.com)
  77. Lasse R.H. Nielsen (lrnohnoyoudont@google.com)
  78. Danny Tuppeny (dantupohnoyoudont@google.com)
  79. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
  80. Siva Annamalai (asivaohnoyoudont@google.com)
  81. Zach Anderson (zraohnoyoudont@google.com)
  82. asiva (asivaohnoyoudont@google.com)
  83. asiva (asivaohnoyoudont@google.com)
  84. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
  85. Alexander Markov (alexmarkovohnoyoudont@google.com)
  86. Alexander Markov (alexmarkovohnoyoudont@google.com)
  87. Aart Bik (ajcbikohnoyoudont@google.com)
  88. Alexander Thomas (athomohnoyoudont@google.com)
  89. Alexander Markov (alexmarkovohnoyoudont@google.com)
  90. danrubel (danrubelohnoyoudont@google.com)
  91. Mike Fairhurst (mfairhurstohnoyoudont@google.com)
  92. danrubel (danrubelohnoyoudont@google.com)
  93. Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
  94. Danny Tuppeny (dantupohnoyoudont@google.com)
  95. Johnni Winther (johnniwintherohnoyoudont@google.com)
  96. Danny Tuppeny (dantupohnoyoudont@google.com)
  97. Clement Skau (cskauohnoyoudont@google.com)
  98. Peter von der Ahé (aheohnoyoudont@google.com)
  99. Peter von der Ahé (aheohnoyoudont@google.com)
  100. Lasse R.H. Nielsen (lrnohnoyoudont@google.com)
  101. <blame list capped at 100 commits> ()

Timing:

Create Tuesday, 13-Nov-18 18:05:26 UTC
Start Tuesday, 13-Nov-18 18:05:59 UTC
End Tuesday, 13-Nov-18 18:27:10 UTC
Pending 32 secs
Execution 21 mins 11 secs

All Changes:

  1. Version 2.1.0

    Changed by Alexander Thomas - athomohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 17:22:02 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision e1e89a628f0873da90447580e0ac75e04144ee2b

    Comments

    Version 2.1.0

Merge commit 'f9ebf2129732fd2b606286fdf58e500384b8a0bc' into stable

  2. Version 2.1.0-dev.9.4

    Changed by William Hesse - whesseohnoyoudont@google.com
    Changed at Thursday, 08-Nov-18 22:00:07 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision f9ebf2129732fd2b606286fdf58e500384b8a0bc

    Comments

    Version 2.1.0-dev.9.4

Cherry-pick e23acaaf90996b84548ea23af14730ff1a21d826 to dev
Cherry-pick e6d3a45b6a98ea36581ac375ec5cdd63dd829004 to dev
Cherry-pick a40fd6a976d3d3bc341cd2e0f7fb290b7819a52a to dev
Cherry-pick 9eb1d748819530bb3eb2f78699e0968de8b638fe to dev

  3. Reland "[vm/compiler] Fine tune operator and phi handling."

    Changed by Aart Bik - ajcbikohnoyoudont@google.com
    Changed at Thursday, 08-Nov-18 21:54:00 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 58bb05b7c731329173111e700da0d3143965510c

    Comments

    Reland "[vm/compiler] Fine tune operator and phi handling."

This reverts commit cde479301a81f9fbaec3fb007457a4ec8e5a65a7.

Reason for revert: the real underlying bug has been fixed

Original change's description:
> Revert "[vm/compiler] Fine tune operator and phi handling."
> 
> This reverts commit 4d5b5bb5a6b46ce070437febbc1f2f4c0f6f9656.
> 
> Reason for revert: We are seeing an AOT compiler issue as a result of this change (please see https://github.com/flutter/flutter/issues/23879)
> 
> Original change's description:
> > [vm/compiler] Fine tune operator and phi handling.
> > 
> > Rationale:
> > Running an extra call specialization pass a bit later
> > in the compiler passes stream (after types are propagated)
> > recognizes more operators, which execute more efficiently.
> > In addition, unboxing phis seems useful on all archs, not
> > just 32-bit. These minor tweeks combined improve the prime
> > number benchmark 3 fold.
> > 
> > https://github.com/flutter/flutter/issues/19677
> > 
> > Change-Id: Ib2102ce807c2f0a9f801542e0c4bc6a7673f552b
> > Reviewed-on: https://dart-review.googlesource.com/69240
> > Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> > Commit-Queue: Aart Bik <ajcbik@google.com>
> 
> TBR=vegorov@google.com,alexmarkov@google.com,asiva@google.com,ajcbik@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: I46e420f9355bfc3c4a3f2fb9274f648e8a596d9a
> Reviewed-on: https://dart-review.googlesource.com/c/83229
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Reviewed-by: Aart Bik <ajcbik@google.com>
> Commit-Queue: Siva Annamalai <asiva@google.com>

TBR=vegorov@google.com,alexmarkov@google.com,asiva@google.com,ajcbik@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I7f9d892a6225c42810e7be52b6845bfee9cc017d
Reviewed-on: https://dart-review.googlesource.com/c/83800
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>

    Changed files

    • runtime/vm/compiler/backend/flow_graph.cc
    • runtime/vm/compiler/compiler_pass.cc

  4. [vm/compiler] Fix bug in unboxed constant spilling

    Changed by Aart Bik - ajcbikohnoyoudont@google.com
    Changed at Thursday, 08-Nov-18 21:51:06 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 27e98d56433fd47c2c694cdee6a783032c8854cf

    Comments

    [vm/compiler] Fix bug in unboxed constant spilling

Rationale:
Subtle but disastrous, spilling unboxed integers
in arm64 and x64 would store the value as smi,
detected as a nasty off by one error in flutter code.

https://github.com/flutter/flutter/issues/23879
https://github.com/dart-lang/sdk/issues/35091

Change-Id: I07d71727de8574ebd7d3ec3610d517d7903972f0
Reviewed-on: https://dart-review.googlesource.com/c/83565
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>

    Changed files

    • runtime/vm/compiler/backend/il_arm64.cc
    • runtime/vm/compiler/backend/il_x64.cc
    • tests/language_2/vm/regress_flutter_23879_test.dart

  5. [VM] Fix for issue 34839 Service isolate hangs during shutdown if

    Changed by asiva - asivaohnoyoudont@google.com
    Changed at Thursday, 08-Nov-18 21:49:14 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 2d7814d664e534cd7ab40156feca6cd0aa1b44bd

    Comments

    [VM] Fix for issue 34839 Service isolate hangs during shutdown if
     the VM exits before the Observatory server has a chance to
     start listening.

Bug: 34839
Change-Id: I2a5dfe69a197fe054dd041af3ea4e07da736b226
Reviewed-on: https://dart-review.googlesource.com/c/81381
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>

    Changed files

    • runtime/bin/vmservice/server.dart
    • sdk/lib/vmservice/vmservice.dart

  6. [vm/aot] Fix obfuscation.

    Changed by Samir Jindel - sjindelohnoyoudont@google.com
    Changed at Thursday, 08-Nov-18 21:47:18 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision e01a32ee0b63643aefa4d095d0afcda68f8e78f4

    Comments

    [vm/aot] Fix obfuscation.

Test Plan:

Make vm-kernel-precomp-obfuscate-linux-release-x64-try green, ensuring status file changes
reflect design gaps and not bugs.

Tested locally that obfuscated Flutter Gallery runs.

Change-Id: Ifcdc334de58f43c310e15b58dbcf6fe1597206f2
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-obfuscate-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/81009
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

    Changed files

    • pkg/vm/bin/dump_kernel.dart
    • pkg/vm/lib/kernel_front_end.dart
    • pkg/vm/lib/metadata/obfuscation_prohibitions.dart
    • pkg/vm/lib/transformations/obfuscation_prohibitions_annotator.dart
    • pkg/vm/lib/transformations/pragma.dart
    • pkg/vm/lib/transformations/type_flow/analysis.dart
    • pkg/vm/lib/transformations/type_flow/native_code.dart
    • pkg/vm/lib/transformations/type_flow/transformer.dart
    • pkg/vm/test/transformations/type_flow/annotation_matcher.dart
    • runtime/bin/file_patch.dart
    • runtime/bin/namespace_patch.dart
    • runtime/bin/secure_socket_patch.dart
    • runtime/lib/errors_patch.dart
    • runtime/tests/vm/dart/error_messages_in_null_checks_test.dart
    • runtime/tests/vm/dart/inline_stack_frame_test.dart
    • runtime/tests/vm/vm.status
    • runtime/vm/bootstrap.cc
    • runtime/vm/compiler/aot/entry_points_pragma.md
    • runtime/vm/compiler/aot/precompiler.cc
    • runtime/vm/compiler/aot/precompiler.h
    • runtime/vm/compiler/frontend/kernel_translation_helper.cc
    • runtime/vm/compiler/frontend/kernel_translation_helper.h
    • runtime/vm/dart_api_impl.cc
    • runtime/vm/dart_entry.cc
    • runtime/vm/kernel_loader.cc
    • runtime/vm/kernel_loader.h
    • sdk/lib/core/errors.dart
    • sdk/lib/io/common.dart
    • sdk/lib/io/directory.dart
    • sdk/lib/io/file.dart
    • sdk/lib/io/link.dart
    • sdk/lib/io/secure_socket.dart
    • tests/corelib_2/apply_test.dart
    • tests/corelib_2/corelib_2.status
    • tests/kernel/kernel.status
    • tests/language_2/cyclic_type_test.dart
    • tests/language_2/f_bounded_quantification5_test.dart
    • tests/language_2/full_stacktrace1_test.dart
    • tests/language_2/full_stacktrace2_test.dart
    • tests/language_2/full_stacktrace3_test.dart
    • tests/language_2/generic_function_dcall_test.dart
    • tests/language_2/language_2_dart2js.status
    • tests/language_2/language_2_kernel.status
    • tests/language_2/mixin_mixin_type_arguments_test.dart
    • tests/language_2/mock_writable_final_field_test.dart
    • tests/language_2/mock_writable_final_private_field_test.dart
    • tests/language_2/no_such_method_dispatcher_test.dart
    • tests/language_2/regress_21795_test.dart
    • tests/language_2/stack_trace_test.dart
    • tests/language_2/stacktrace_rethrow_error_test.dart
    • tests/language_2/stacktrace_rethrow_nonerror_test.dart
    • tests/language_2/symbol_literal_test.dart
    • tests/language_2/vm/tree_shake_type_args_in_constant_test.dart
    • tests/lib_2/lib_2_kernel.status

  7. Version 2.1.0-dev.9.3

    Changed by William Hesse - whesseohnoyoudont@google.com
    Changed at Thursday, 08-Nov-18 00:13:22 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 204556df67e9c4d5462c14cfb2ca5762144170c2

    Comments

    Version 2.1.0-dev.9.3

Cherry-pick 65951ef5080bcfa7d8862685e96f75c2c5d17841 to dev

Cherry-pick 6004c8a1876731e65104cf88f46af01bfe8c24c4 to dev

  8. [dartdevc] fix debugger extension console, take 2

    Changed by Jenny Messerly - jmesserlyohnoyoudont@google.com
    Changed at Thursday, 08-Nov-18 00:01:39 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 8a15a9bd7ec78d9031682dadb9e1ce6f92e9d806

    Comments

    [dartdevc] fix debugger extension console, take 2

This change fixes the (internal) debugger console test so it passes.

A few of the fixes did not make it into the previous CL
(CL https://dart-review.googlesource.com/c/sdk/+/83140).

Change-Id: I58df9024b96e73a13a5c13b801be237450cfe3cb
Reviewed-on: https://dart-review.googlesource.com/c/83522
Auto-Submit: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Alan Knight <alanknight@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>

    Changed files

    • pkg/dev_compiler/lib/src/compiler/shared_command.dart
    • pkg/dev_compiler/web/web_command.dart

  9. Ensure generatedSize takes into consideration empty fragments

    Changed by Sigmund Cherem - sigmundohnoyoudont@google.com
    Changed at Thursday, 08-Nov-18 00:00:59 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 45a74eaf271bad5c0c2f31075ac9c90de37f7624

    Comments

    Ensure generatedSize takes into consideration empty fragments

This fixes a crash in dump-info. We should investigate more closely why are we
reaching the empty output units in the first place, since we expect dump-info
wouldn't need to report data about any entity that used to be there.

Change-Id: I8c996c4ea4a86531bec28f0f294fe48086177219
Reviewed-on: https://dart-review.googlesource.com/c/82280
Reviewed-by: Harry Terkelsen <het@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>

    Changed files

    • pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart

  10. Version 2.1.0-dev.9.2

    Changed by William Hesse - whesseohnoyoudont@google.com
    Changed at Wednesday, 07-Nov-18 05:47:47 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 9c07fb64c48adb3d6fde50bab6b8b641c5b67683

    Comments

    Version 2.1.0-dev.9.2

Cherry-pick 2cf0ca381ce33d1e6597c778eb1a915eecdac109 to dev
Cherry-pick c7e6cdf81ca2f6113cc132d85d5f73a9441d3643 to dev
Cherry-pick a6518386520af63764ad40dde3b53e5e160b9bff to dev
Cherry-pick 2085277771bb91d488edb6e6e55552ba7116dd72 to dev
Cherry-pick 0fd4a51e2c805aec79d4d0e42f446f5395c6113a to dev
Cherry-pick be815e1a867d302ad2fbc8db8d7467cfe85319d2 to dev
Cherry-pick 61df5fdec81be4f8f04c18a774147856931ebbb9 to dev
Cherry-pick d8d68358498c83127e26ad1796359146772decad to dev
Cherry-pick 9c95624a6307f09f1cdc49054bdd08125acb6f53 to dev
Cherry-pick cde479301a81f9fbaec3fb007457a4ec8e5a65a7 to dev

  11. Revert "[vm/compiler] Fine tune operator and phi handling."

    Changed by Siva Annamalai - asivaohnoyoudont@google.com
    Changed at Wednesday, 07-Nov-18 05:40:51 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision a5b61caf8fca23a23880a16fbdac4bb36f17c4cf

    Comments

    Revert "[vm/compiler] Fine tune operator and phi handling."

This reverts commit 4d5b5bb5a6b46ce070437febbc1f2f4c0f6f9656.

Reason for revert: We are seeing an AOT compiler issue as a result of this change (please see https://github.com/flutter/flutter/issues/23879)

Original change's description:
> [vm/compiler] Fine tune operator and phi handling.
> 
> Rationale:
> Running an extra call specialization pass a bit later
> in the compiler passes stream (after types are propagated)
> recognizes more operators, which execute more efficiently.
> In addition, unboxing phis seems useful on all archs, not
> just 32-bit. These minor tweeks combined improve the prime
> number benchmark 3 fold.
> 
> https://github.com/flutter/flutter/issues/19677
> 
> Change-Id: Ib2102ce807c2f0a9f801542e0c4bc6a7673f552b
> Reviewed-on: https://dart-review.googlesource.com/69240
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Commit-Queue: Aart Bik <ajcbik@google.com>

TBR=vegorov@google.com,alexmarkov@google.com,asiva@google.com,ajcbik@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I46e420f9355bfc3c4a3f2fb9274f648e8a596d9a
Reviewed-on: https://dart-review.googlesource.com/c/83229
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>

    Changed files

    • runtime/vm/compiler/backend/flow_graph.cc
    • runtime/vm/compiler/compiler_pass.cc

  12. Temporary revert to fix issue #35009 for 2.1. package:rpc relies on mirrors behaviour that is not valid for Dart 2, so these type checks cause the package to crash.

    Changed by Ben Konyi - bkonyiohnoyoudont@google.com
    Changed at Wednesday, 07-Nov-18 05:38:33 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 4914fe57ea9e034b948ef3ab5a4e7e511991f845

    Comments

    Temporary revert to fix issue #35009 for 2.1. package:rpc relies on mirrors behaviour that is not valid for Dart 2, so these type checks cause the package to crash.

Revert "[ VM / Mirrors ] Added type checking to enforce strong mode semantics when using dart:mirrors"

This reverts commit 9f00eec55bc56dc7371ffcc509d4b7d6698fc51c.

Change-Id: I82ce07d388ba9402f20caf700815b39c9bc418f6
Reviewed-on: https://dart-review.googlesource.com/c/83225
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>

    Changed files

    • runtime/lib/mirrors.cc
    • runtime/vm/dart_api_impl_test.cc
    • runtime/vm/object.cc
    • runtime/vm/object.h
    • runtime/vm/service.cc
    • tests/lib_2/mirrors/bad_argument_types_test.dart

  13. [dartdevc] fix debugger extension console

    Changed by Jenny Messerly - jmesserlyohnoyoudont@google.com
    Changed at Wednesday, 07-Nov-18 05:35:45 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision f85e14e2fd4f17bf1b531081dfc79b437f3ddc77

    Comments

    [dartdevc] fix debugger extension console

This change fixes the (internal) debugger console test so it passes.

Change-Id: Iaae1ec189d6744158ebea4dd55e187146adf9039
Reviewed-on: https://dart-review.googlesource.com/c/83140
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Alan Knight <alanknight@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>

    Changed files

    • pkg/dev_compiler/lib/src/analyzer/module_compiler.dart
    • pkg/dev_compiler/web/web_command.dart

  14. Encode dart2js source-map extensions in strings.

    Changed by Sigmund Cherem - sigmundohnoyoudont@google.com
    Changed at Wednesday, 07-Nov-18 05:34:00 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 415e6395cd8b441702a42b5d217882b804bf32b3

    Comments

    Encode dart2js source-map extensions in strings.

This reduce the memory footprint and cost of parsing these extensions.  Another
advantage is a reduction on the size of the .map files.  On a large customer
app, this was a 11% reduction, and the frames section was about 1Mb (excluding
the extra names and uris added on the existing tables).

The encoding works as follows:
 - minified names are written as a list of names and indices, in pairs.

    {'n1': 1, 'n2': 2} => 'n1,1,n2,2'

 - frames are encoded using a sequence of values with markers for the different
   kind of frames. Numbers are encoded using VLQ deltas. We use VLQ because it's
   already available to any parser that deals with the mappings).

This change also uses the dart2js_tools parser implementation for all unit tests.

Change-Id: Iacc2833c6517eb473955cc618adec501c610870f
Reviewed-on: https://dart-review.googlesource.com/c/82780
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>

    Changed files

    • pkg/compiler/lib/src/io/source_map_builder.dart
    • pkg/dart2js_tools/lib/src/dart2js_mapping.dart
    • pkg/sourcemap_testing/lib/src/stacktrace_helper.dart
    • tests/compiler/dart2js/sourcemaps/minified_names_test.dart

  15. [dartdevc] fix #35013, move DDC off Analyzer task model

    Changed by Jenny Messerly - jmesserlyohnoyoudont@google.com
    Changed at Wednesday, 07-Nov-18 05:32:27 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 0137edef8948ad6c3ce722f359dd4b39c93f449d

    Comments

    [dartdevc] fix #35013, move DDC off Analyzer task model

The new file pkg/dev_compiler/lib/src/analyzer/driver.dart handles
building the linked summary for a build unit, and then is capable of
doing analysis using LibraryAnalyzer.

The algorithm is very similar to analyzer_cli's build mode. The
biggest difference is that `dartdevc` has existing support for
discovering source files from the explicit source list (rather than
requiring every source to be listed on the command line). We don't want
to break that support, so there's a bit of logic to follow imports,
exports, and parts.

After the linked summary is produced, DDC gets the analysis results
(errors and resolved AST) for each library, and compiles it into a JS
module.

Change-Id: I7bf1ce1eca73fd036002e498de5924c488b534dc
Reviewed-on: https://dart-review.googlesource.com/c/82469
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>

    Changed files

    • pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
    • pkg/dev_compiler/bin/dartdevc.dart
    • pkg/dev_compiler/lib/src/analyzer/code_generator.dart
    • pkg/dev_compiler/lib/src/analyzer/command.dart
    • pkg/dev_compiler/lib/src/analyzer/context.dart
    • pkg/dev_compiler/lib/src/analyzer/driver.dart
    • pkg/dev_compiler/lib/src/analyzer/element_helpers.dart
    • pkg/dev_compiler/lib/src/analyzer/error_helpers.dart
    • pkg/dev_compiler/lib/src/analyzer/extension_types.dart
    • pkg/dev_compiler/lib/src/analyzer/js_typerep.dart
    • pkg/dev_compiler/lib/src/analyzer/module_compiler.dart
    • pkg/dev_compiler/lib/src/analyzer/side_effect_analysis.dart
    • pkg/dev_compiler/lib/src/compiler/shared_command.dart
    • pkg/dev_compiler/lib/src/kernel/analyzer_to_kernel.dart
    • pkg/dev_compiler/lib/src/kernel/command.dart
    • pkg/dev_compiler/test/options/options_test.dart
    • pkg/dev_compiler/test/sourcemap/sourcemaps_ddc_suite.dart
    • pkg/dev_compiler/tool/build_pkgs.dart
    • pkg/dev_compiler/tool/build_sdk.dart
    • pkg/dev_compiler/web/web_command.dart
    • tests/language_2/language_2_dartdevc.status

  16. Recover from default values in function types

    Changed by Peter von der Ahé - aheohnoyoudont@google.com
    Changed at Wednesday, 07-Nov-18 05:18:41 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision e5746eafe3af5d487a0efdf1a9504be7727f05ef

    Comments

    Recover from default values in function types

Fixes https://github.com/dart-lang/sdk/issues/35035

Change-Id: I29fe0d792998c43f49877d97b61b3afc16c43cef
Reviewed-on: https://dart-review.googlesource.com/c/82984
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Peter von der Ahé <ahe@google.com>

    Changed files

    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/source/stack_listener.dart
    • pkg/front_end/testcases/function_type_default_value.dart
    • pkg/front_end/testcases/function_type_default_value.dart.direct.expect
    • pkg/front_end/testcases/function_type_default_value.dart.direct.transformed.expect
    • pkg/front_end/testcases/function_type_default_value.dart.outline.expect
    • pkg/front_end/testcases/function_type_default_value.dart.strong.expect
    • pkg/front_end/testcases/function_type_default_value.dart.strong.transformed.expect

  17. [vm, reload] On the path for no shape changes, defer freeing the old class table until the next safepoint.

    Changed by Ryan Macnak - rmacnakohnoyoudont@google.com
    Changed at Wednesday, 07-Nov-18 05:15:30 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 50188582da0ea383a792be7056e44b8195b2cc71

    Comments

    [vm, reload] On the path for no shape changes, defer freeing the old class table until the next safepoint.

Compare the reload rollback path.

Bug: https://github.com/dart-lang/sdk/issues/34888
Change-Id: I5b9e7cd8392f9c9d61df31481956a9fa67435b33
Reviewed-on: https://dart-review.googlesource.com/c/81940
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

    Changed files

    • runtime/vm/isolate_reload.cc
    • runtime/vm/isolate_reload.h
    • tests/language_2/language_2_kernel.status

  18. [vm] Fix misc printf format bugs.

    Changed by Ryan Macnak - rmacnakohnoyoudont@google.com
    Changed at Wednesday, 07-Nov-18 05:13:46 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 21ac23cb019f2a422a513b6322d0518e7a4aedaa

    Comments

    [vm] Fix misc printf format bugs.

Bug: https://github.com/dart-lang/sdk/issues/35009
Change-Id: I6b509e1eb8e76e07f60a086c67358d65d2a1fae4
Reviewed-on: https://dart-review.googlesource.com/c/82460
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

    Changed files

    • runtime/vm/compiler/assembler/disassembler.cc
    • runtime/vm/compiler/assembler/disassembler.h
    • runtime/vm/compiler/assembler/disassembler_kbc.cc
    • runtime/vm/compiler/frontend/constant_evaluator.cc
    • runtime/vm/compiler/frontend/kernel_translation_helper.h
    • runtime/vm/dwarf.cc
    • runtime/vm/dwarf.h
    • runtime/vm/json_stream.h
    • runtime/vm/log.h
    • runtime/vm/log_test.cc
    • runtime/vm/service.cc
    • runtime/vm/timeline_analysis.h

  19. Update RemoveTypeArguments priority for edit.dartfix

    Changed by Dan Rubel - danrubelohnoyoudont@google.com
    Changed at Wednesday, 07-Nov-18 05:10:27 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 6199c57b959eb24946c20a07c633838de370bea8

    Comments

    Update RemoveTypeArguments priority for edit.dartfix

Change-Id: I2b3b52916a4eb08a47f40e1adc2ce21985649ba3
Reviewed-on: https://dart-review.googlesource.com/c/82880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

    Changed files

    • pkg/analysis_server/lib/src/services/correction/fix.dart

  20. [VM] Added cleanup for Dart IO API

    Changed by Ben Konyi - bkonyiohnoyoudont@google.com
    Changed at Wednesday, 07-Nov-18 05:08:38 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 776b8c2efdcb477721b6f79f875fdadbb6619e24

    Comments

    [VM] Added cleanup for Dart IO API

Change-Id: Iab9f567ef3d4310ee9511fa5ce375b7ccf200ef5
Reviewed-on: https://dart-review.googlesource.com/c/81442
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>

    Changed files

    • runtime/bin/dart_io_api_impl.cc
    • runtime/include/bin/dart_io_api.h

  21. Version 2.1.0-dev.9.1

    Changed by William Hesse - whesseohnoyoudont@google.com
    Changed at Friday, 02-Nov-18 17:56:29 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 2f1b417c05b57141addcdbc638cfba7607877fdd

    Comments

    Version 2.1.0-dev.9.1

Cherry-pick commit 0fe448a99643e149acb2e7e32d7a30eba7dd646d to dev
Cherry-pick commit 45d070d437bb1b596516edd3717e6ee614c5f9ac to dev
Cherry-pick commit 00f27a32cf52834b3e9e1f52889b6f1c83ad338c to dev
Cherry-pick commit 523353d28017fced825581ea327509c620eed67e to dev
Cherry-pick commit db4271378f56a66528a87f2f920c678162d59a35 to dev

  22. Allow SourceReport to have duplicate URL entries if the VM scripts does

    Changed by Jens Johansen - jensjohnoyoudont@google.com
    Changed at Friday, 02-Nov-18 17:32:39 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 47ea06f0d2f3e4f0cf0909cefe69b8d1cf532b12

    Comments

    Allow SourceReport to have duplicate URL entries if the VM scripts does

When using a concatenated dill file, several scripts with the same URL
can exist. They are not the same though, and should not be treated as
such.

Bug: #34841
Change-Id: Icd46357ffcf72ed35251b2a2793e1f83c02c4a8e
Reviewed-on: https://dart-review.googlesource.com/c/80821
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

    Changed files

    • runtime/vm/source_report.cc
    • runtime/vm/source_report.h

  23. [build] Move to Jessie sysroots from Wheezy sysroots.

    Changed by Vyacheslav Egorov - vegorovohnoyoudont@google.com
    Changed at Friday, 02-Nov-18 17:31:21 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 5dcbf15c76a4a83145a6976c47f2c7c7cbf6c7f0

    Comments

    [build] Move to Jessie sysroots from Wheezy sysroots.

Wheezy is not supported anymore (EOL May 2018) and these sysroots are
really outdated, which introduces build problems whenever we try to
use recent enough features and header files.

We are already using Jessie to build Dart SDK distributions and in some cases we use
Jessie to build binaries for testing (e.g. when building on ARM64).

This CL makes it uniform.

Change-Id: Id4d165a41aa37118f5e49edb2122d905219cd377
Reviewed-on: https://dart-review.googlesource.com/c/81409
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>

    Changed files

    • build/.gitignore
    • build/config/linux/BUILD.gn
    • build/config/sysroot.gni
    • build/linux/sysroot_scripts/install-sysroot.py
    • tools/gn.py
    • tools/set_ia32_sysroot.sh
    • tools/set_x64_sysroot.sh

  24. [dartdevc] fix NSM with private field overrides and mixin declarations

    Changed by Jenny Messerly - jmesserlyohnoyoudont@google.com
    Changed at Friday, 02-Nov-18 17:29:29 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 5558d8ddde9c0f0c375156e84b2f6808cbedecdc

    Comments

    [dartdevc] fix NSM with private field overrides and mixin declarations

Analyzer does not put mixin declarations in the `.types` getter, which
broke DDC's assumption that it contained all of the class/interface
types in the compilation unit. Kernel backend was not affected.

Change-Id: I219d814766fb97ef81920d0150cb1dfbbc6087f5
Reviewed-on: https://dart-review.googlesource.com/c/82022
Auto-Submit: Jenny Messerly <jmesserly@google.com>
Commit-Queue: Alan Knight <alanknight@google.com>
Reviewed-by: Alan Knight <alanknight@google.com>

    Changed files

    • pkg/dev_compiler/lib/src/analyzer/property_model.dart
    • pkg/dev_compiler/lib/src/kernel/analyzer_to_kernel.dart
    • pkg/dev_compiler/lib/src/kernel/property_model.dart
    • tests/language_2/mixin_declaration/mixin_declaration_syntax_test.dart

  25. bump to linter 0.1.71

    Changed by pq - pquitslundohnoyoudont@google.com
    Changed at Friday, 02-Nov-18 17:26:11 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 1e4071b9d786a455fbd8eb959d4d82481e86ae11

    Comments

    bump to linter 0.1.71


* new lint: `prefer_int_literals`
* update `await_only_futures` to allow awaiting on `null`
* update `use_setters_to_change_properties` to work with `=>` short-hand

Change-Id: Iafc46bb9c02675b47bda9b4d4124a8efc76584d8
Reviewed-on: https://dart-review.googlesource.com/c/81881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>

    Changed files

    • DEPS

  26. Revise the analysis server edit.dartfix protocol

    Changed by danrubel - danrubelohnoyoudont@google.com
    Changed at Friday, 02-Nov-18 17:23:32 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 90636c298cfe09492ee9080c99a5941f322fe4fe

    Comments

    Revise the analysis server edit.dartfix protocol

This updates the edit.dartfix protocol to separate location from the text
describing the changes so that the dartfix client can choose
what location information to display and how it should be displayed.

Change-Id: Ic56a4cb187538571d60136d6de9265d879fccb53
Reviewed-on: https://dart-review.googlesource.com/c/81780
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

    Changed files

    • pkg/analysis_server/doc/api.html
    • pkg/analysis_server/lib/protocol/protocol_constants.dart
    • pkg/analysis_server/lib/protocol/protocol_generated.dart
    • pkg/analysis_server/lib/src/edit/edit_dartfix.dart
    • pkg/analysis_server/lib/src/edit/fix/prefer_int_literals_fix.dart
    • pkg/analysis_server/lib/src/edit/fix/prefer_mixin_fix.dart
    • pkg/analysis_server/test/integration/support/integration_test_methods.dart
    • pkg/analysis_server/test/integration/support/protocol_matchers.dart
    • pkg/analysis_server/tool/spec/generated/java/types/DartFixSuggestion.java
    • pkg/analysis_server/tool/spec/generated/java/types/RuntimeCompletionExpression.java
    • pkg/analysis_server/tool/spec/spec_input.html
    • pkg/analysis_server_client/lib/src/protocol/protocol_constants.dart
    • pkg/analysis_server_client/lib/src/protocol/protocol_generated.dart
    • pkg/dartfix/lib/src/driver.dart

  27. Version 2.1.0-dev.9.0

    Changed by William Hesse - whesseohnoyoudont@google.com
    Changed at Thursday, 01-Nov-18 21:46:12 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision d93e5b4f64007c84dcb01e6861a8397b51b0dce9

    Comments

    Version 2.1.0-dev.9.0

Merge commit 'bf26f760b1bb3d5fea6bda110f6a17b590364120' into dev
Cherry-pick commit '8c20adffe66ff672111aa5ab4dbbd557df097e30' into dev

  28. Increment analysis server protocol version

    Changed by Dan Rubel - danrubelohnoyoudont@google.com
    Changed at Thursday, 01-Nov-18 21:20:17 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 9946af01c16b2aa8ef63eadb1a3e0a2fe4861485

    Comments

    Increment analysis server protocol version

Change-Id: I470a51b035c765d710e920f3fe77dfa11a7aca92
Reviewed-on: https://dart-review.googlesource.com/c/82480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>

    Changed files

    • pkg/analysis_server/doc/api.html
    • pkg/analysis_server/lib/src/analysis_server.dart
    • pkg/analysis_server/tool/spec/spec_input.html

  29. [infra] Ensure that core dump upload triggers on main builders

    Changed by Alexander Thomas - athomohnoyoudont@google.com
    Changed at Thursday, 25-Oct-18 07:36:06 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision bf26f760b1bb3d5fea6bda110f6a17b590364120

    Comments

    [infra] Ensure that core dump upload triggers on main builders

https://crrev.com/c/1296514 will add --output_directory to non-shards as
well. BUILDBOT_BUILDERNAME is not set on shards and a more reliable
indication that this is a main bot that should gsutil upload core dumps.

Change-Id: Ic6cddc4937b8e83d2e15da4acd90c193e412773b
Reviewed-on: https://dart-review.googlesource.com/c/81362
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>

    Changed files

    • tools/utils.py

  30. [gardening] bigint_test may still time out when interpreted (2nd try).

    Changed by Régis Crelier - regisohnoyoudont@google.com
    Changed at Thursday, 25-Oct-18 04:49:04 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision cdf6dde807e774ae06e02398ec930f8ea73c0578

    Comments

    [gardening] bigint_test may still time out when interpreted (2nd try).

Change-Id: Ie3a7204811503d82be89d9f9555d867ef087c22f
Reviewed-on: https://dart-review.googlesource.com/c/81383
Reviewed-by: Régis Crelier <regis@google.com>

    Changed files

    • tests/corelib_2/corelib_2.status

  31. [vm] Cleanup int overflow checking

    Changed by Alexander Markov - alexmarkovohnoyoudont@google.com
    Changed at Thursday, 25-Oct-18 02:49:33 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision d3498a81be013135e919fb3c652bcd06ee809a5b

    Comments

    [vm] Cleanup int overflow checking

This corner case was needed by old VM parser.
Now that old VM parser is gone we can remove it.

Closes https://github.com/dart-lang/sdk/issues/31600

Change-Id: I59631102230156f6480a27e6d43d5e3fa5551c8b
Reviewed-on: https://dart-review.googlesource.com/c/81338
Commit-Queue: Zach Anderson <zra@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>

    Changed files

    • runtime/vm/object.cc

  32. [gardening] bigint_test may still time out when interpreted.

    Changed by Régis Crelier - regisohnoyoudont@google.com
    Changed at Thursday, 25-Oct-18 01:46:28 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 9e9746a83cd2278e958f93f9bd3e213f7175f119

    Comments

    [gardening] bigint_test may still time out when interpreted.

Change-Id: I9e8f45fb20b5148c658e98877446ca5d36de9f56
Reviewed-on: https://dart-review.googlesource.com/c/81380
Reviewed-by: Régis Crelier <regis@google.com>

    Changed files

    • tests/corelib_2/corelib_2.status

  33. [VM interpreter] Do not interpret some Bigint intrinsics (fixes #34901).

    Changed by Régis Crelier - regisohnoyoudont@google.com
    Changed at Thursday, 25-Oct-18 00:44:25 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 7de25103398461890acb164b4a8efdaa9da8c89f

    Comments

    [VM interpreter] Do not interpret some Bigint intrinsics (fixes #34901).

Update status file.

Change-Id: I43b222562488c90c9438fd792dc2505b14d5d373
Reviewed-on: https://dart-review.googlesource.com/c/81334
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>

    Changed files

    • runtime/vm/object.cc
    • tests/corelib_2/corelib_2.status

  34. Fix versions in spec titles to match the description below

    Changed by Danny Tuppeny - dantupohnoyoudont@google.com
    Changed at Thursday, 25-Oct-18 00:37:35 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 816ab3208cef147a8dd440c0fcacd6fd3bb443a9

    Comments

    Fix versions in spec titles to match the description below

Change-Id: I1c3ddadd292aedb83495fee1f90caf331c7241d7
Reviewed-on: https://dart-review.googlesource.com/c/81271
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

    Changed files

    • runtime/vm/service/service.md
    • runtime/vm/service/service_dev.md

  35. [vm/bytecode] Check for overflow of bytecode limits

    Changed by Alexander Markov - alexmarkovohnoyoudont@google.com
    Changed at Thursday, 25-Oct-18 00:10:24 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision c7c81af74e19c51e4095f126bc651fdc9789d97b

    Comments

    [vm/bytecode] Check for overflow of bytecode limits

Change-Id: I452596fb6f0fa72d76f26981adae2910ba1a179c
Reviewed-on: https://dart-review.googlesource.com/c/81336
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>

    Changed files

    • pkg/vm/lib/bytecode/constant_pool.dart
    • pkg/vm/lib/bytecode/dbc.dart
    • pkg/vm/lib/bytecode/gen_bytecode.dart
    • pkg/vm/lib/bytecode/local_vars.dart

  36. Add ArgumentError.checkNotNull utility

    Changed by Nate Bosch - nboschohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 23:34:15 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 655310ddf212cde53d0c286677c8a92506fd7a78

    Comments

    Add ArgumentError.checkNotNull utility

In the places where other utilities like `RangeError.checkNotNegative`
are used it reads nicer to call through a similar signature than to
follow a conditional with the utility.

Change-Id: Idd89b2934020fb55e57a22c39773fd7879d1c28f
Reviewed-on: https://dart-review.googlesource.com/c/81287
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>

    Changed files

    • CHANGELOG.md
    • sdk/lib/core/errors.dart

  37. Revert "[vm/compiler] Use loop framework for AOT inline heuristics"

    Changed by Aart Bik - ajcbikohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 22:49:10 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 0170b8d529a60a18c175dfe187896388621f5768

    Comments

    Revert "[vm/compiler] Use loop framework for AOT inline heuristics"

This reverts commit daae20d32e828fad298d7d12327aa30ac2927a47.

Reason for revert: 

The kernel-precomp bots are seeing this error:

../../runtime/vm/object.h: 3134: error: Handle check failed: saw 2249186640 expected Function

Not sure what that is yet, but reverting to get bots green again while I investigate.


Original change's description:
> [vm/compiler] Use loop framework for AOT inline heuristics
> 
> Rationale:
> Without proper execution counters, the inline AOT inliner
> marks every call site "cold", effectively disabling inlining
> altogether. This change introduces loop-based static heuristic
> that assumes statements nested inside loops are executed more
> frequently. This results in more inlining.
> 
> Note:
> Conservative version is used for now which yields
> more performance without increasing code size too much.
> There is still a lot of performance left at the table
> which we could exploit if we fine tune heuristics
> regarding code size.
> 
> Bug:
> https://github.com/dart-lang/sdk/issues/34473
> https://github.com/dart-lang/sdk/issues/32167
> 
> 
> Change-Id: I86ba60f93bdab363cd22ab6bdbcf6688f2042fea
> Reviewed-on: https://dart-review.googlesource.com/c/81187
> Commit-Queue: Aart Bik <ajcbik@google.com>
> Reviewed-by: Alexander Markov <alexmarkov@google.com>

TBR=vegorov@google.com,alexmarkov@google.com,ajcbik@google.com

Change-Id: If5ca82966966ebef4ec0b4e921515d23f6bd492b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/81335
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>

    Changed files

    • runtime/vm/compiler/backend/il.cc
    • runtime/vm/compiler/backend/il.h
    • runtime/vm/compiler/backend/inliner.cc

  38. Move test_methodCallTypeInference_mixinType into mixin_test.dart

    Changed by Paul Berry - paulberryohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 22:17:20 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 9aff9309248558dfa057cadc8f1517895fa8d7bc

    Comments

    Move test_methodCallTypeInference_mixinType into mixin_test.dart

Addresses code review comments on https://dart-review.googlesource.com/c/sdk/+/81322.

Change-Id: I8c8bd20f024a849042ff862f755a4187765f6201
Reviewed-on: https://dart-review.googlesource.com/c/81330
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

    Changed files

    • pkg/analyzer/test/generated/non_error_resolver_test.dart
    • pkg/analyzer/test/src/dart/resolution/mixin_test.dart

  39. [vm] Add test for certain cases of unreachable code

    Changed by Alexander Markov - alexmarkovohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 21:46:07 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 3e750a7e7920b3e9863656932a1a25006a73f8bc

    Comments

    [vm] Add test for certain cases of unreachable code

This is the follow-up for https://github.com/dart-lang/sdk/commit/1d10e037ef9e69424f4fce998b4857648a96e740.

Change-Id: Ifd35acb08904d34010ede0fe609076424d146374
Reviewed-on: https://dart-review.googlesource.com/c/81331
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>

    Changed files

    • tests/language_2/vm/unreachable_code_test.dart

  40. [vm/compiler] Use loop framework for AOT inline heuristics

    Changed by Aart Bik - ajcbikohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 21:31:36 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision daae20d32e828fad298d7d12327aa30ac2927a47

    Comments

    [vm/compiler] Use loop framework for AOT inline heuristics

Rationale:
Without proper execution counters, the inline AOT inliner
marks every call site "cold", effectively disabling inlining
altogether. This change introduces loop-based static heuristic
that assumes statements nested inside loops are executed more
frequently. This results in more inlining.

Note:
Conservative version is used for now which yields
more performance without increasing code size too much.
There is still a lot of performance left at the table
which we could exploit if we fine tune heuristics
regarding code size.

Bug:
https://github.com/dart-lang/sdk/issues/34473
https://github.com/dart-lang/sdk/issues/32167


Change-Id: I86ba60f93bdab363cd22ab6bdbcf6688f2042fea
Reviewed-on: https://dart-review.googlesource.com/c/81187
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>

    Changed files

    • runtime/vm/compiler/backend/il.cc
    • runtime/vm/compiler/backend/il.h
    • runtime/vm/compiler/backend/inliner.cc

  41. Upgrade package:http to 0.12.0.

    Changed by Devon Carew - devoncarewohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 21:23:16 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 28a8fa50f67b442ea9e17868a16a95f4c9f39204

    Comments

    Upgrade package:http to 0.12.0.

Change-Id: I621316d2eb1467ee2a403b52013ddbd7844ea02e
Reviewed-on: https://dart-review.googlesource.com/c/81328
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>

    Changed files

    • DEPS
    • pkg/telemetry/pubspec.yaml

  42. [gardening] Mark co19 LibTest/io/RawDatagramSocket/any_A01_t03 flaky

    Changed by Vyacheslav Egorov - vegorovohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 20:13:13 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision b3055a148252f1ef73a18e5a45bcf8eb1dd18652

    Comments

    [gardening] Mark co19 LibTest/io/RawDatagramSocket/any_A01_t03 flaky

TBR=kustermann@google.com

Change-Id: Ie4fa7b875989ea31370c028d07e4ca5c9be0b310
Reviewed-on: https://dart-review.googlesource.com/c/81364
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>

    Changed files

    • tests/co19_2/co19_2-kernel.status

  43. Version 2.1.0-dev.8.0

    Changed by Alexander Thomas - athomohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 19:47:12 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 413e0c8d2ce8cb9c28727d7a05a98efb36c36be1

    Comments

    Version 2.1.0-dev.8.0

Merge commit 'cf0a99a' into dev

  44. Remove dartfix dependencies on analysis server

    Changed by Dan Rubel - danrubelohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 19:26:58 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision b8fd29e0bb12035d8e0b71dca5594bba0f8aa736

    Comments

    Remove dartfix dependencies on analysis server

This replaces dartfix dependencies on ...
* analysis_server
* analyzer (except for testing)
* analyzer_plugins

... with a dependency on analysis_server_client.

Change-Id: If511de69333e925ae082fa06c5114188c3c405b1
Reviewed-on: https://dart-review.googlesource.com/c/81342
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>

    Changed files

    • pkg/analysis_server_client/lib/protocol.dart
    • pkg/dartfix/lib/src/driver.dart
    • pkg/dartfix/lib/src/options.dart
    • pkg/dartfix/pubspec.yaml

  45. [build] Add //third_party/android_tools BUILD file needed by zlib

    Changed by Vyacheslav Egorov - vegorovohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 18:39:36 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 8a5405fc40de78a69c7513a7f83cd9883729d28b

    Comments

    [build] Add //third_party/android_tools BUILD file needed by zlib

Change-Id: I4f641bcc4940ab508f38b32397455f996659784b
Reviewed-on: https://dart-review.googlesource.com/c/81363
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>

    Changed files

    • build/secondary/third_party/android_tools/BUILD.gn

  46. [vm] Eliminate dart_zlib_path from BUILD files

    Changed by Vyacheslav Egorov - vegorovohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 18:06:43 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 82c1f2aaa8c93486f76673b8308a1ca3ef3169ca

    Comments

    [vm] Eliminate dart_zlib_path from BUILD files


TBR=zra@google.com

Change-Id: I7b93a03ef958c7dcb454769be945d0e3bed90b39
Reviewed-on: https://dart-review.googlesource.com/c/81360
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>

    Changed files

    • runtime/bin/BUILD.gn
    • runtime/runtime_args.gni

  47. Reland "[VM runtime] Support Smi instances in type test cache."

    Changed by Régis Crelier - regisohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 17:54:13 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 11ad25a1c3c901b56f60972c16c98055ce8aa07b

    Comments

    Reland "[VM runtime] Support Smi instances in type test cache."

This is a reland of 6ba3e55eccf343357549f0643b2cb75ccdb53d9b

The issue was that SlowTypeTestStub used in precompiled mode did not handle a
Smi instance before calling the Subtype2TestCache stub which does not support
it. See PatchSet 2 for the fix.
Is there a more efficient solution?

Original change's description:
> [VM runtime] Support Smi instances in type test cache.
>
> This adds SubtypeTestCache-based optimizations for type tests against
>       * dst_type = FutureOr<T> (when T=int/num)
>       * dst_type = T (when T = FutureOr<int/num>)
>
> Remove dangerous LoadClass pseudo assembler instruction (does not work for Smi).
> Handle instantiated void in type tests (along with dynamic and Object).
>
> Change-Id: I0df0fc72ff173b9464d16cc971969132b055a429
> Reviewed-on: https://dart-review.googlesource.com/c/81182
> Commit-Queue: Régis Crelier <regis@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

Change-Id: I333ca47aebd7f0b663059ab6afc5d1cd8d7d5210
Reviewed-on: https://dart-review.googlesource.com/c/81320
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>

    Changed files

    • runtime/vm/compiler/aot/precompiler.cc
    • runtime/vm/compiler/assembler/assembler_arm.cc
    • runtime/vm/compiler/assembler/assembler_arm.h
    • runtime/vm/compiler/assembler/assembler_arm64.cc
    • runtime/vm/compiler/assembler/assembler_arm64.h
    • runtime/vm/compiler/assembler/assembler_ia32.cc
    • runtime/vm/compiler/assembler/assembler_ia32.h
    • runtime/vm/compiler/assembler/assembler_x64.cc
    • runtime/vm/compiler/assembler/assembler_x64.h
    • runtime/vm/compiler/backend/flow_graph_compiler_arm.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_arm64.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_ia32.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_x64.cc
    • runtime/vm/runtime_entry.cc
    • runtime/vm/stub_code_arm.cc
    • runtime/vm/stub_code_arm64.cc
    • runtime/vm/stub_code_ia32.cc
    • runtime/vm/stub_code_x64.cc

  48. Generate analysis_server_client protocol_generated.dart and related protocol files

    Changed by Dan Rubel - danrubelohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 17:09:39 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 3dc911909b39af4ffb7e59995783e1856c811bd4

    Comments

    Generate analysis_server_client protocol_generated.dart and related protocol files

Change-Id: I9a9af0ee37eab87a5c3e83cba638d855a2e1121b
Reviewed-on: https://dart-review.googlesource.com/c/81341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>

    Changed files

    • pkg/analysis_server/tool/spec/codegen_dart_protocol.dart
    • pkg/analysis_server/tool/spec/generate_all.dart
    • pkg/analysis_server_client/lib/protocol.dart
    • pkg/analysis_server_client/lib/src/protocol/protocol_base.dart
    • pkg/analysis_server_client/lib/src/protocol/protocol_common.dart
    • pkg/analysis_server_client/lib/src/protocol/protocol_generated.dart
    • pkg/analysis_server_client/lib/src/protocol/protocol_internal.dart
    • pkg/analysis_server_client/lib/src/protocol/protocol_util.dart

  49. [gardening] Mark co19 LibTest/io/Stdin/readByteSync_A02_t01 flaky

    Changed by Vyacheslav Egorov - vegorovohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 16:39:44 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision a902fc351f64829631be5282ecc0ae53e7582052

    Comments

    [gardening] Mark co19 LibTest/io/Stdin/readByteSync_A02_t01 flaky

Issue https://github.com/dart-lang/co19/issues/175

TBR=kustermann@google.com

Change-Id: I1518f7a2a63d9347e858f67733202e07e932ae22
Reviewed-on: https://dart-review.googlesource.com/c/81361
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>

    Changed files

    • tests/co19_2/co19_2-kernel.status

  50. Fix yet another cloning bug

    Changed by Kevin Millikin - kmillikinohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 16:16:59 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision cfecec5eec3f750eff84838b2a60ae668adaa420

    Comments

    Fix yet another cloning bug

All for-in loops became synchronous ones when mixed in.  This is obviously
wrong.  Fixes https://github.com/dart-lang/sdk/issues/34877

Change-Id: I26f71724ea68f37ce4813790ae003b51479874fc
Reviewed-on: https://dart-review.googlesource.com/c/81277
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

    Changed files

    • pkg/kernel/lib/clone.dart
    • tests/language_2/issue34877_test.dart

  51. [infra] Improve clone command in analyze-flutter.sh script (#34739)

    Changed by Alexander Thomas - athomohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 15:51:33 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision d8cb60d746e3d34f9ee5e6b0a08bf12104d3f8e3

    Comments

    [infra] Improve clone command in analyze-flutter.sh script (#34739)

TBR=whesse@google.com

Change-Id: I2e43da79dbb3dba85403ee0ae4dcde2e16cd3afd
Reviewed-on: https://dart-review.googlesource.com/c/81279
Reviewed-by: Alexander Thomas <athom@google.com>

    Changed files

    • tools/bots/flutter/analyze_flutter.sh

  52. Generate analysis server protocol consts in analysis_server_client

    Changed by Dan Rubel - danrubelohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 15:37:21 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 34d08010089b68039a0de8a45b21c9e01799aef2

    Comments

    Generate analysis server protocol consts in analysis_server_client

Change-Id: I86c1f7ce98d2c1424c9b77c66fa48c6fa1ba354b
Reviewed-on: https://dart-review.googlesource.com/c/81340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>

    Changed files

    • pkg/analysis_server/tool/spec/codegen_protocol_constants.dart
    • pkg/analysis_server/tool/spec/generate_all.dart
    • pkg/analysis_server_client/lib/protocol.dart
    • pkg/analysis_server_client/lib/src/protocol/protocol_constants.dart

  53. [vm] Integrate dart binary with Crashpad on Windows.

    Changed by Vyacheslav Egorov - vegorovohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 13:30:16 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 2c83eb550eeab3c6d38b8ccf2998b438e4b5c052

    Comments

    [vm] Integrate dart binary with Crashpad on Windows.

dart binary would instantiate CrashpadClient if DART_CRASHPAD_HANDLER
and DART_CRASHPAD_CRASHES_DIR environment variables are set.

- DART_CRASHPAD_HANDLER should contain the path to the crashpad_handler
binary that would handle the crash and write minidump;
- DART_CRASHPAD_CRASHES_DIR should contain the path to the crashpad database
which would be used to store minidumps.

Rewrite --copy-crash-dumps support on windows to use Crashpad integration
instead of editing Windows registry.

Embedding crashpad required to roll a new zlib version because Crashpad
depends on the zlib. This version of zlib is buildable with its own
BUILD.gn so our custom BUILD.gn is removed.

Change-Id: I048aad16b234e1d750f0a24782b04e3b6e19703d
Reviewed-on: https://dart-review.googlesource.com/c/81007
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>

    Changed files

    • DEPS
    • build/config/BUILDCONFIG.gn
    • build/config/compiler/BUILD.gn
    • build/config/win/BUILD.gn
    • build/toolchain/win/BUILD.gn
    • runtime/bin/BUILD.gn
    • runtime/bin/filter.cc
    • runtime/bin/main.cc
    • runtime/bin/zlib/BUILD.gn
    • runtime/runtime_args.gni
    • third_party/.gitignore
    • tools/gn.py
    • tools/minidump.py
    • tools/testing/dart/test_suite.dart
    • tools/utils.py

  54. [gardening] Mark co19 LibTest/io/RawDatagramSocket/lastWhere_A01_t02 flaky

    Changed by Vyacheslav Egorov - vegorovohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 13:28:55 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision b9999b6c27633b7faf35b8c83d09eabdf8836796

    Comments

    [gardening] Mark co19 LibTest/io/RawDatagramSocket/lastWhere_A01_t02 flaky

Issue https://github.com/dart-lang/co19/issues/170

TBR=kustermann@google.com

Change-Id: I7f4dbf8127a044e27773cf331c099839638f98ac
Reviewed-on: https://dart-review.googlesource.com/c/81276
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>

    Changed files

    • tests/co19_2/co19_2-kernel.status

  55. [gardening] Mark co19 LibTest/io/Link/rename_A02_t01 flaky

    Changed by Vyacheslav Egorov - vegorovohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 10:37:07 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 0b15595913ff89d8486e6677af0254dd6feab350

    Comments

    [gardening] Mark co19 LibTest/io/Link/rename_A02_t01 flaky

Issue https://github.com/dart-lang/co19/issues/174

TBR=kustermann@google.com

Change-Id: I69070d0bf6d27a7e5aed93c1fde36c1a3960178b
Reviewed-on: https://dart-review.googlesource.com/c/81273
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

    Changed files

    • tests/co19_2/co19_2-kernel.status

  56. Bounds of a generic type alias ensure the body is regular-bounded

    Changed by Erik Ernst - eernstohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 10:32:38 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 57f895c7a41ae55ce19fea403cbaec77d4671a45

    Comments

    Bounds of a generic type alias ensure the body is regular-bounded

The analyzer enforces the rule that when a generic type alias F has
formal type parameters X1..Xm with bounds B1..Bm, if we assume that
X1..Xm are types satisfying the corresponding bounds then it must be
the case that every type which occurs in the body of F must be
regular-bounded.

In other words, the bounds on the left hand side of `=` must imply
the bounds applicable to every type on the right hand side.

---------- NEW TEXT ----------

I just discovered that it is _not_ possible to skip the check on
every super-bounded parameterized type based on a generic type
alias: It is certainly possible to have a type which is correctly
super-bounded according to the type parameter bounds on the left
hand side of `=` in the type alias declaration, and still have a
right hand side where some types are not well-bounded. Consider the
following declarations:

  class B<Y1 extends Y2, Y2, Y3 extends num> {}
  typedef F<X extends num> = B<num, Object, X> Function();

According to the declarations to the left of `=`, `F<Object>`
is a correct super-bounded type, because it is not
regular-bounded (`Object <\: num`), and `F<Null>` is regular-bounded
(`Null <: num`).

Also, when the declared bound of `X` is satisfied, we are
guaranteed that each type on the right hand side is regular-bounded
(if parameterized, it receives type arguments that satisfy all
the specified bounds).

But consider the result of applying `F` to `Object`:

  B<num, Object, Object> Function();

That's not a type where all subterms which are types are
well-bounded:

  B<num, Object, Object> is not regular-bounded because
  `Object <\: num` (third type argument).

  B<num, Object, Object> is not super-bounded because
  B<num, Null, Null> is not regular-bounded because
  `num <\: Null` (violating `Y1 extends Y2`).

So there is no way we can prove that this check can be skipped,
because we have a pretty simple counter-example!

I'm currently adjusting the text to re-introduce the check.

---------- OLD TEXT, NOT VALID ----------

This must be specified, because it justifies the _removal_ of a
requirement that we had in the feature specification
super-bounded-types.md: It was required for every application of a
generic type alias F to a list of actual type arguments <T1..Tk>
such that the resulting parameterized type F<T1..Tk> was
super-bounded that both the parameterized type F<T1..Tk> and every
type in the resulting type [T1/X1..Tk/Xk]U (where U is the body of
F and X1..Xk are its formal type parameters) be well-bounded.

But when the bounds of F imply satisfaction of the bounds of all
types that occur in the body of F, it's trivially true that all
types in the resulting type are regular-bounded for the result
of substituting Null for covariant top types and Object for
contravariant Null for every super-bounded F<T1..Tk>. I'm looking
into a proof sketch for the result that this implies that any
well-bounded generic type alias application yields a type that
contains only well-bounded types.

This would be a very welcome simplification (because it was an
inconvenient complication that we had to check both the left hand
side and the right hand side of a type alias whenever we
encountered a super-bounded type expressed via a type alias), and
I believe that it will also make the tools run faster (because they
can now skip all those checks of every type that occurs in the body
for every super-bounded usage of a type alias.

Change-Id: Icd70649ebaed41b193aeb0cb6f08d06aed0ee5bd
Reviewed-on: https://dart-review.googlesource.com/c/79743
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>

    Changed files

    • docs/language/dartLangSpec.tex
    • docs/language/informal/super-bounded-types.md

  57. [vm] Pass member name as a symbol in instantiateInvocation.

    Changed by Samir Jindel - sjindelohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 10:13:13 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 6efc58f069f02b5f57209d0d66b3cd853629b32e

    Comments

    [vm] Pass member name as a symbol in instantiateInvocation.

If we use `_InvocationMirror._withoutType`, the symbol for the member name is created dynamically and escapes obfuscation.
We need to create the member name symbol statically via a `const` constructor.

Change-Id: I11c0f745187f4ef1646be6d5348780f502393043
Reviewed-on: https://dart-review.googlesource.com/c/81264
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

    Changed files

    • pkg/front_end/testcases/inference/future_then.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_2.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_2.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_2.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_2.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_2.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_3.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_3.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_3.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_3.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_3.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_4.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_4.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_4.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_4.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_4.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_5.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_5.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_5.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_5.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_5.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_6.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_6.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_6.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_6.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_6.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_conditional.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_conditional.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_conditional.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_conditional.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_conditional.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_conditional_2.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_conditional_2.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_conditional_2.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_conditional_2.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_conditional_2.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_conditional_3.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_conditional_3.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_conditional_3.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_conditional_3.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_conditional_3.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_conditional_4.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_conditional_4.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_conditional_4.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_conditional_4.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_conditional_4.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_conditional_5.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_conditional_5.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_conditional_5.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_conditional_5.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_conditional_5.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_conditional_6.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_conditional_6.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_conditional_6.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_conditional_6.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_conditional_6.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_ifNull.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_ifNull.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_ifNull.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_ifNull.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_ifNull.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_upwards.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_upwards.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_upwards.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_upwards.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_upwards.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_upwards_2.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_upwards_2.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_upwards_2.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_upwards_2.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_upwards_2.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_then_upwards_3.dart.direct.expect
    • pkg/front_end/testcases/inference/future_then_upwards_3.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_then_upwards_3.dart.outline.expect
    • pkg/front_end/testcases/inference/future_then_upwards_3.dart.strong.expect
    • pkg/front_end/testcases/inference/future_then_upwards_3.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_union_async_conditional.dart.direct.expect
    • pkg/front_end/testcases/inference/future_union_async_conditional.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_union_async_conditional.dart.outline.expect
    • pkg/front_end/testcases/inference/future_union_async_conditional.dart.strong.expect
    • pkg/front_end/testcases/inference/future_union_async_conditional.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_union_async_conditional_2.dart.direct.expect
    • pkg/front_end/testcases/inference/future_union_async_conditional_2.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_union_async_conditional_2.dart.outline.expect
    • pkg/front_end/testcases/inference/future_union_async_conditional_2.dart.strong.expect
    • pkg/front_end/testcases/inference/future_union_async_conditional_2.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_union_downwards.dart.direct.expect
    • pkg/front_end/testcases/inference/future_union_downwards.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_union_downwards.dart.outline.expect
    • pkg/front_end/testcases/inference/future_union_downwards.dart.strong.expect
    • pkg/front_end/testcases/inference/future_union_downwards.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_union_downwards_2.dart.direct.expect
    • pkg/front_end/testcases/inference/future_union_downwards_2.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_union_downwards_2.dart.outline.expect
    • pkg/front_end/testcases/inference/future_union_downwards_2.dart.strong.expect
    • pkg/front_end/testcases/inference/future_union_downwards_2.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_union_downwards_3.dart.direct.expect
    • pkg/front_end/testcases/inference/future_union_downwards_3.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_union_downwards_3.dart.outline.expect
    • pkg/front_end/testcases/inference/future_union_downwards_3.dart.strong.expect
    • pkg/front_end/testcases/inference/future_union_downwards_3.dart.strong.transformed.expect
    • pkg/front_end/testcases/inference/future_union_downwards_4.dart.direct.expect
    • pkg/front_end/testcases/inference/future_union_downwards_4.dart.direct.transformed.expect
    • pkg/front_end/testcases/inference/future_union_downwards_4.dart.outline.expect
    • pkg/front_end/testcases/inference/future_union_downwards_4.dart.strong.expect
    • pkg/front_end/testcases/inference/future_union_downwards_4.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_arent_mixed_in.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_arent_mixed_in.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_arent_mixed_in.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_arent_mixed_in.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_arent_mixed_in.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_one_defined.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_one_defined.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_one_defined.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_one_defined.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_one_defined.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_with_substitution.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_with_substitution.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_with_substitution.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_with_substitution.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_accessors_from_field_with_substitution.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_interface_nsm_inherited.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_interface_nsm_inherited.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_interface_nsm_inherited.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_interface_nsm_inherited.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/abstract_interface_nsm_inherited.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/concrete_method_over_forwarder_in_mixin_application.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/concrete_method_over_forwarder_in_mixin_application.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/concrete_method_over_forwarder_in_mixin_application.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/concrete_method_over_forwarder_in_mixin_application.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/concrete_method_over_forwarder_in_mixin_application.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/default_argument_values.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/default_argument_values.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/default_argument_values.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/default_argument_values.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/default_argument_values.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/duplicated_abstract_method.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/duplicated_abstract_method.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/duplicated_abstract_method.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/duplicated_abstract_method.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/duplicated_abstract_method.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/forwarders_not_assumed_from_mixin.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/forwarders_not_assumed_from_mixin.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/forwarders_not_assumed_from_mixin.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/forwarders_not_assumed_from_mixin.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/forwarders_not_assumed_from_mixin.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/interface_with_concrete.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/interface_with_concrete.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/interface_with_concrete.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/interface_with_concrete.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/interface_with_concrete.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/interface_with_nsm.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/interface_with_nsm.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/interface_with_nsm.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/interface_with_nsm.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/interface_with_nsm.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/no_forwarders_for_abstract_classes.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/no_forwarders_for_abstract_classes.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/no_forwarders_for_abstract_classes.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/no_forwarders_for_abstract_classes.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/no_forwarders_for_abstract_classes.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/no_forwarders_for_abstract_classes_chain.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/no_forwarders_for_abstract_classes_chain.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/no_forwarders_for_abstract_classes_chain.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/no_forwarders_for_abstract_classes_chain.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/no_forwarders_for_abstract_classes_chain.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/nsm_inherited.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/nsm_inherited.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/nsm_inherited.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/nsm_inherited.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/nsm_inherited.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/nsm_mixed_in.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/nsm_mixed_in.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/nsm_mixed_in.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/nsm_mixed_in.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/nsm_mixed_in.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/private.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/private.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/private.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/private.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/private.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/private_same.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/private_same.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/private_same.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/private_same.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/private_same.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/same.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/same.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/same.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/same.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/same.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/setter_not_shadowed_by_method.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/setter_not_shadowed_by_method.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/setter_not_shadowed_by_method.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/setter_not_shadowed_by_method.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/setter_not_shadowed_by_method.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/subst_on_forwarder.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_forwarders/subst_on_forwarder.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_forwarders/subst_on_forwarder.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_forwarders/subst_on_forwarder.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_forwarders/subst_on_forwarder.dart.strong.transformed.expect
    • pkg/front_end/testcases/no_such_method_private_setter.dart.direct.expect
    • pkg/front_end/testcases/no_such_method_private_setter.dart.direct.transformed.expect
    • pkg/front_end/testcases/no_such_method_private_setter.dart.outline.expect
    • pkg/front_end/testcases/no_such_method_private_setter.dart.strong.expect
    • pkg/front_end/testcases/no_such_method_private_setter.dart.strong.transformed.expect
    • pkg/front_end/testcases/private_method_tearoff.dart.direct.expect
    • pkg/front_end/testcases/private_method_tearoff.dart.direct.transformed.expect
    • pkg/front_end/testcases/private_method_tearoff.dart.outline.expect
    • pkg/front_end/testcases/private_method_tearoff.dart.strong.expect
    • pkg/front_end/testcases/private_method_tearoff.dart.strong.transformed.expect
    • pkg/front_end/testcases/super_nsm.dart.direct.expect
    • pkg/front_end/testcases/super_nsm.dart.direct.transformed.expect
    • pkg/front_end/testcases/super_nsm.dart.outline.expect
    • pkg/front_end/testcases/super_nsm.dart.strong.expect
    • pkg/front_end/testcases/super_nsm.dart.strong.transformed.expect
    • pkg/vm/lib/bytecode/gen_bytecode.dart
    • pkg/vm/lib/target/vm.dart
    • pkg/vm/testcases/transformations/type_flow/transformer/no_such_method.dart.expect
    • tests/language_2/mock_writable_final_private_field_test.dart

  58. [fasta] Check type arguments in method invocations while doing inference

    Changed by Dmitry Stefantsov - dmitryasohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 10:00:23 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision cf0a99a89b82ecb65241ab73c8eb66878f32a75a

    Comments

    [fasta] Check type arguments in method invocations while doing inference

Fixes #34899

Bug: http://dartbug.com/34899
Change-Id: I4db7612925d0938cc6ec381c4de8073d50d61aac
Reviewed-on: https://dart-review.googlesource.com/c/81266
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Auto-Submit: Dmitry Stefantsov <dmitryas@google.com>

    Changed files

    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/inference_visitor.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
    • pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
    • pkg/front_end/testcases/inference/generic_methods_correctly_recognize_generic_upper_bound.dart.strong.expect
    • pkg/front_end/testcases/issue34899.dart.strong.expect
    • pkg/front_end/testcases/strong.status

  59. Specify for all literals whether the object overrides `Object.==`.

    Changed by Lasse R.H. Nielsen - lrnohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 09:07:50 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision d69374264824f18453d16d1ce1d3cf56a669ff49

    Comments

    Specify for all literals whether the object overrides `Object.==`.

Also mention it in the `external const factory Symbol` constructor.

This only relevant for constant expressions that may be used as
switch case expressions or constant map keys.

See #32557.

Bug: http://dartbug.com/32557
Change-Id: Ie82799f3f0d39c21c10765338a7dfeb74a582add
Reviewed-on: https://dart-review.googlesource.com/c/81242
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>

    Changed files

    • docs/language/dartLangSpec.tex
    • sdk/lib/core/symbol.dart

  60. Change parameter 'silent' => 'instrumented'

    Changed by Kevin Millikin - kmillikinohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 08:45:40 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 5c9060283bd9b6629fa23cb58c9bc416ecdae0b9

    Comments

    Change parameter 'silent' => 'instrumented'

This requires flipping the default value from false to true.  I can
never remember what "silent" entails.  It sounds like it might
suppress some error reporting, but what it actually does is suppress
the instrumentation used for checking comments in the test input
files.

Hopefully this name is more obvious.

Change-Id: I922c7107eae32a5d4206aaa6d4507310289ca64d
Reviewed-on: https://dart-review.googlesource.com/c/81261
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

    Changed files

    • pkg/front_end/lib/src/fasta/kernel/inference_visitor.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
    • pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart

  61. Changed dartLangSpec errors to warnings

    Changed by Erik Ernst - eernstohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 07:13:32 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision e4e82da85d8b12916dcd54480b019dca76c12bc5

    Comments

    Changed dartLangSpec errors to warnings

Partially resolves issue #34349.
Also note that #34365 and #34319 are affected by this change.

Change-Id: I1d9023464090ff2c07f9dc062353202ddb82ba25
Reviewed-on: https://dart-review.googlesource.com/c/78121
Reviewed-by: Leaf Petersen <leafp@google.com>

    Changed files

    • docs/language/dartLangSpec.tex

  62. Add "convert to int literal" to dartfix

    Changed by Dan Rubel - danrubelohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 01:22:02 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 4695b5f138795b68c9a2f4b5023395bf6b63a842

    Comments

    Add "convert to int literal" to dartfix

This updates the analysis server edit.dartfix request
to find and convert double literals to int literals.
Under the covers it uses the prefer_int_literal lint
and gracefully degrades if the lint is not found
(e.g. third_party/linter needs to be rolled).

Change-Id: I0236af9c19667e543541fef18836bfeeba8c67d7
Reviewed-on: https://dart-review.googlesource.com/c/81302
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>

    Changed files

    • pkg/analysis_server/lib/src/edit/edit_dartfix.dart
    • pkg/analysis_server/lib/src/edit/fix/prefer_int_literals_fix.dart
    • pkg/analysis_server/lib/src/edit/fix/prefer_mixin_fix.dart

  63. In _matchInterfaceSubtypeOf, account for mixins having null superclass.

    Changed by Paul Berry - paulberryohnoyoudont@google.com
    Changed at Wednesday, 24-Oct-18 01:06:25 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 0009ca7b1bedf27defbd3fd539a8081fcbb72d40

    Comments

    In _matchInterfaceSubtypeOf, account for mixins having null superclass.

Fixes #34907.

Change-Id: I1ba56bf57d6ca5a7a69f262e12df801dc2cc4a4a
Reviewed-on: https://dart-review.googlesource.com/c/81322
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>

    Changed files

    • pkg/analyzer/lib/src/generated/type_system.dart
    • pkg/analyzer/test/generated/non_error_resolver_test.dart
    • tests/language_2/issue34907_test.dart

  64. [vm/bytecode] Remove unreachable bytecode

    Changed by Alexander Markov - alexmarkovohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 23:26:13 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 1d10e037ef9e69424f4fce998b4857648a96e740

    Comments

    [vm/bytecode] Remove unreachable bytecode

Change-Id: I29393604547038cf359b8e19ea48078dd0eea3b1
Reviewed-on: https://dart-review.googlesource.com/c/81201
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>

    Changed files

    • pkg/vm/lib/bytecode/assembler.dart
    • pkg/vm/lib/bytecode/gen_bytecode.dart
    • pkg/vm/testcases/bytecode/async.dart.expect
    • pkg/vm/testcases/bytecode/bootstrapping.dart.expect
    • pkg/vm/testcases/bytecode/closures.dart.expect
    • pkg/vm/testcases/bytecode/deferred_lib.dart.expect
    • pkg/vm/testcases/bytecode/instance_creation.dart.expect
    • pkg/vm/testcases/bytecode/literals.dart.expect
    • pkg/vm/testcases/bytecode/loops.dart.expect
    • pkg/vm/testcases/bytecode/super_calls.dart.expect
    • pkg/vm/testcases/bytecode/switch.dart.expect
    • pkg/vm/testcases/bytecode/try_blocks.dart.expect
    • pkg/vm/testcases/bytecode/type_ops.dart.expect
    • runtime/vm/compiler/frontend/bytecode_flow_graph_builder.cc

  65. Add fromEntries on HashMap and LinkedHashMap

    Changed by Nate Bosch - nboschohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 20:53:34 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 03eafc0b2ec07c16a19dde02c91566b2b039624d

    Comments

    Add fromEntries on HashMap and LinkedHashMap

Closes #34818

Change-Id: I77b117c16169a5c5bd5655e851256930a2ea5a28
Reviewed-on: https://dart-review.googlesource.com/c/81188
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>

    Changed files

    • CHANGELOG.md
    • sdk/lib/collection/hash_map.dart
    • sdk/lib/collection/linked_hash_map.dart
    • sdk/lib/core/map.dart
    • tests/corelib_2/map_from_entries_test.dart

  66. new convert-to-int-literal assist

    Changed by Dan Rubel - danrubelohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 20:29:27 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 4f2a4e69a88358e505d76316368795c97427e096

    Comments

    new convert-to-int-literal assist

Change-Id: I25f08d82fd4afaba485059e558536b37855bb6c9
Reviewed-on: https://dart-review.googlesource.com/c/81301
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

    Changed files

    • pkg/analysis_server/lib/src/services/correction/assist.dart
    • pkg/analysis_server/lib/src/services/correction/assist_internal.dart
    • pkg/analysis_server/test/services/correction/assist_test.dart

  67. [vm] Remove incorrect assert in Script::GetSnippet

    Changed by Alexander Markov - alexmarkovohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 20:16:07 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 58d73e08f4f5239d994f60f785f360d8946073b2

    Comments

    [vm] Remove incorrect assert in Script::GetSnippet

In Dart 2, sources could be unavailable in other kinds of snapshots
besides FullAOT, so this assertion is not correct.

Fixes https://github.com/dart-lang/sdk/issues/34872

Change-Id: I1b96b353e7a2cdf9c8247cdc7c06b08e3629c78b
Reviewed-on: https://dart-review.googlesource.com/c/81283
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>

    Changed files

    • runtime/vm/object.cc

  68. Revert "[VM runtime] Support Smi instances in type test cache."

    Changed by Régis Crelier - regisohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 19:04:18 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 6134ac86481f01ed865beb297363bb26ed61aed6

    Comments

    Revert "[VM runtime] Support Smi instances in type test cache."

This reverts commit 6ba3e55eccf343357549f0643b2cb75ccdb53d9b.

Reason for revert: unhappy kernel-precomp bots

Original change's description:
> [VM runtime] Support Smi instances in type test cache.
> 
> This adds SubtypeTestCache-based optimizations for type tests against
>       * dst_type = FutureOr<T> (when T=int/num)
>       * dst_type = T (when T = FutureOr<int/num>)
> 
> Remove dangerous LoadClass pseudo assembler instruction (does not work for Smi).
> Handle instantiated void in type tests (along with dynamic and Object).
> 
> Change-Id: I0df0fc72ff173b9464d16cc971969132b055a429
> Reviewed-on: https://dart-review.googlesource.com/c/81182
> Commit-Queue: Régis Crelier <regis@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=kustermann@google.com,alexmarkov@google.com,regis@google.com

Change-Id: I73be5fc068cd24e0a13ba0872a99a24ab5a8eeca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/81284
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>

    Changed files

    • runtime/vm/compiler/assembler/assembler_arm.cc
    • runtime/vm/compiler/assembler/assembler_arm.h
    • runtime/vm/compiler/assembler/assembler_arm64.cc
    • runtime/vm/compiler/assembler/assembler_arm64.h
    • runtime/vm/compiler/assembler/assembler_ia32.cc
    • runtime/vm/compiler/assembler/assembler_ia32.h
    • runtime/vm/compiler/assembler/assembler_x64.cc
    • runtime/vm/compiler/assembler/assembler_x64.h
    • runtime/vm/compiler/backend/flow_graph_compiler_arm.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_arm64.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_ia32.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_x64.cc
    • runtime/vm/runtime_entry.cc
    • runtime/vm/stub_code_arm.cc
    • runtime/vm/stub_code_arm64.cc
    • runtime/vm/stub_code_ia32.cc
    • runtime/vm/stub_code_x64.cc

  69. [gardening] Update status for #34901

    Changed by Alexander Markov - alexmarkovohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 18:09:02 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 4e49d19bd6c4f46acbdba59b008b7c03c1814a12

    Comments

    [gardening] Update status for #34901

Issue: https://github.com/dart-lang/sdk/issues/34901
Change-Id: Iaa0d082a0d4e0ddd034f51f49fc9b722a0ca3fd4
Reviewed-on: https://dart-review.googlesource.com/c/81281
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>

    Changed files

    • tests/corelib_2/corelib_2.status

  70. [VM runtime] Support Smi instances in type test cache.

    Changed by Régis Crelier - regisohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 18:01:40 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 6ba3e55eccf343357549f0643b2cb75ccdb53d9b

    Comments

    [VM runtime] Support Smi instances in type test cache.

This adds SubtypeTestCache-based optimizations for type tests against
      * dst_type = FutureOr<T> (when T=int/num)
      * dst_type = T (when T = FutureOr<int/num>)

Remove dangerous LoadClass pseudo assembler instruction (does not work for Smi).
Handle instantiated void in type tests (along with dynamic and Object).

Change-Id: I0df0fc72ff173b9464d16cc971969132b055a429
Reviewed-on: https://dart-review.googlesource.com/c/81182
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>

    Changed files

    • runtime/vm/compiler/assembler/assembler_arm.cc
    • runtime/vm/compiler/assembler/assembler_arm.h
    • runtime/vm/compiler/assembler/assembler_arm64.cc
    • runtime/vm/compiler/assembler/assembler_arm64.h
    • runtime/vm/compiler/assembler/assembler_ia32.cc
    • runtime/vm/compiler/assembler/assembler_ia32.h
    • runtime/vm/compiler/assembler/assembler_x64.cc
    • runtime/vm/compiler/assembler/assembler_x64.h
    • runtime/vm/compiler/backend/flow_graph_compiler_arm.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_arm64.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_ia32.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_x64.cc
    • runtime/vm/runtime_entry.cc
    • runtime/vm/stub_code_arm.cc
    • runtime/vm/stub_code_arm64.cc
    • runtime/vm/stub_code_ia32.cc
    • runtime/vm/stub_code_x64.cc

  71. LSP: Fix nulls and missing fromJson calls in unions

    Changed by Danny Tuppeny - dantupohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 17:42:19 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision e4566d3dbd61424e4cecbc83a6f00b39a13fc7ef

    Comments

    LSP: Fix nulls and missing fromJson calls in unions

Change-Id: I666d32e8a0463ba07756878b22293a7d3f55915d
Reviewed-on: https://dart-review.googlesource.com/c/81268
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>

    Changed files

    • pkg/analysis_server/lib/lsp_protocol/protocol_generated.dart
    • pkg/analysis_server/tool/lsp_spec/codegen_dart.dart

  72. [VM] Make method extractors call a stub for creation of tear-off closure

    Changed by Martin Kustermann - kustermannohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 15:51:37 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision d91e0ad3d793b43b43e069e330f9272df4ba5561

    Comments

    [VM] Make method extractors call a stub for creation of tear-off closure

Issue https://github.com/dart-lang/sdk/issues/33274

Change-Id: I7ec37a57c968baa9a3099379cbecb306cd06b464
Reviewed-on: https://dart-review.googlesource.com/c/72780
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>

    Changed files

    • runtime/vm/class_finalizer.cc
    • runtime/vm/compiler/backend/flow_graph_compiler.cc
    • runtime/vm/compiler/backend/flow_graph_compiler.h
    • runtime/vm/compiler/backend/flow_graph_compiler_arm.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_arm64.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_dbc.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_ia32.cc
    • runtime/vm/compiler/backend/flow_graph_compiler_x64.cc
    • runtime/vm/dart.cc
    • runtime/vm/image_snapshot.cc
    • runtime/vm/object.h
    • runtime/vm/object_store.h
    • runtime/vm/stub_code.cc
    • runtime/vm/stub_code.h
    • runtime/vm/stub_code_arm.cc
    • runtime/vm/stub_code_arm64.cc
    • runtime/vm/stub_code_x64.cc

  73. [vm] Ignore compilation errors in CorelibCompileAll

    Changed by Vyacheslav Egorov - vegorovohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 14:16:43 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 4c9684f7350cb16254ecc49fe2beb0f601fd3a0f

    Comments

    [vm] Ignore compilation errors in CorelibCompileAll

Change-Id: Iffb1a3a191cd8cf9e3ecd13a495a73bda5592dfb
Reviewed-on: https://dart-review.googlesource.com/c/80621
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>

    Changed files

    • runtime/vm/benchmark_test.cc
    • runtime/vm/object.cc
    • runtime/vm/object.h

  74. [infra] Add tools/bots/find_base_commit.dart

    Changed by Jonas Termansen - sortieohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 14:02:51 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision b73f7ed3d439a475e1aa971059fa1a0eb56b72e3

    Comments

    [infra] Add tools/bots/find_base_commit.dart

The find_base_commit program locates the newest commit with a full set of
test results. This is a good base for local testing when comparing with the
results from the official bots, as all the needed results are there.

Change-Id: Ie06020ca98317b82f46589ad6dede37361acf744
Reviewed-on: https://dart-review.googlesource.com/c/81040
Reviewed-by: Alexander Thomas <athom@google.com>

    Changed files

    • tools/bots/find_base_commit.dart

  75. Remove flaky markers for standalone_2/io tests, MacOS upgrade seemed to have getten rid underlying OS issue

    Changed by Martin Kustermann - kustermannohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 11:21:48 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 6443a8036d3914f28f1d1e140a108487953cd909

    Comments

    Remove flaky markers for standalone_2/io tests, MacOS upgrade seemed to have getten rid underlying OS issue

Closes https://github.com/dart-lang/sdk/issues/34760

Change-Id: Iec6c14a15ff719fb6e790ecf24a44f2d153fe271
Reviewed-on: https://dart-review.googlesource.com/c/81241
Auto-Submit: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>

    Changed files

    • tests/standalone_2/standalone_2_kernel.status

  76. [fasta] Add a test case for issue #34899

    Changed by Dmitry Stefantsov - dmitryasohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 09:29:53 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision c04215d5f68b93fd513b5f69c04abf401faf5452

    Comments

    [fasta] Add a test case for issue #34899

Bug: http://dartbug.com/34899
Change-Id: Ia7d9c0c9be711e3f9f0e07552222f1b28a140ec1
Reviewed-on: https://dart-review.googlesource.com/c/81240
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>

    Changed files

    • pkg/front_end/testcases/issue34899.dart
    • pkg/front_end/testcases/issue34899.dart.direct.expect
    • pkg/front_end/testcases/issue34899.dart.direct.transformed.expect
    • pkg/front_end/testcases/issue34899.dart.outline.expect
    • pkg/front_end/testcases/strong.status

  77. Update old mixin tests. Remove the --super-mixins flag from the tests.

    Changed by Lasse R.H. Nielsen - lrnohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 08:35:49 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 03765ed6ecd5f87a2f556bc56300bd029383f19a

    Comments

    Update old mixin tests. Remove the --super-mixins flag from the tests.

Bug: http://dartbug.com/34781
Change-Id: Ib07e1927e7de35ff0c48514b9e89da65a5f192dd
Reviewed-on: https://dart-review.googlesource.com/c/79700
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>

    Changed files

    • tests/language_2/bug32372_test.dart
    • tests/language_2/issue32353_2_test.dart
    • tests/language_2/issue32353_test.dart
    • tests/language_2/issue34404_flutter_test.dart
    • tests/language_2/language_2_analyzer.status
    • tests/language_2/language_2_dart2js.status
    • tests/language_2/language_2_dartdevc.status
    • tests/language_2/language_2_kernel.status
    • tests/language_2/mixin_of_mixin_test.dart
    • tests/language_2/mixin_super_2_test.dart
    • tests/language_2/mixin_super_test.dart
    • tests/language_2/mixin_super_use_test.dart
    • tests/language_2/mixin_superclass_test.dart
    • tests/language_2/mixin_supertype_subclass2_test.dart
    • tests/language_2/mixin_supertype_subclass3_test.dart
    • tests/language_2/mixin_supertype_subclass4_test.dart
    • tests/language_2/mixin_supertype_subclass_test.dart
    • tests/language_2/mixin_type_parameter_inference_error_test.dart
    • tests/language_2/mixin_type_parameter_inference_previous_mixin_test.dart
    • tests/language_2/mixin_type_parameter_inference_test.dart

  78. Fix handling of JSON with interfaces nested within Unions

    Changed by Danny Tuppeny - dantupohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 07:08:44 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision a394e4f492b768a96be5a1be68b5756ad8a1cdea

    Comments

    Fix handling of JSON with interfaces nested within Unions

Change-Id: I926c2374860824db3ceae6d74286474feb730676
Reviewed-on: https://dart-review.googlesource.com/c/81100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>

    Changed files

    • pkg/analysis_server/lib/lsp_protocol/protocol_generated.dart
    • pkg/analysis_server/lib/lsp_protocol/protocol_special.dart
    • pkg/analysis_server/test/tool/lsp_spec/json_test.dart
    • pkg/analysis_server/tool/lsp_spec/codegen_dart.dart

  79. Issue 34896. Verify the superconstraint signature invoked by a mixin, not the mixin's one.

    Changed by Konstantin Shcheglov - scheglovohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 06:20:59 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 2f90f8d0ef3b9a7ca8692f0ca3514940750d6e40

    Comments

    Issue 34896. Verify the superconstraint signature invoked by a mixin, not the mixin's one.

R=brianwilkerson@google.com, paulberry@google.com

Fixes: https://github.com/dart-lang/sdk/issues/34896
Change-Id: I778d572e2e2d0affb15c28d7bf2c1fbb58a8cd8a
Reviewed-on: https://dart-review.googlesource.com/c/81204
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>

    Changed files

    • pkg/analyzer/lib/src/generated/error_verifier.dart
    • pkg/analyzer/test/src/dart/resolution/mixin_test.dart
    • tests/language_2/issue34896_test.dart

  80. Revert "[VM] Fix for issue 34839 - Dart_Cleanup may hang while shutting down"

    Changed by Siva Annamalai - asivaohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 04:41:13 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision b82c1f979f0316f5b1d59b69f72fcf39931e15c4

    Comments

    Revert "[VM] Fix for issue 34839 - Dart_Cleanup may hang while shutting down"

This reverts commit 89c845eba20e1a021dbb6e3fc3372e06b8be6a24.

Reason for revert: Seems to cause ASAN failures

Original change's description:
> [VM] Fix for issue 34839 - Dart_Cleanup may hang while shutting down
>      the service isolate.
> 
>      The service isolate request for shutdown uses a Dart level message
>      for exiting the isolate, this shuts down the isolate but does not
>      completely bring the isolate down if there are some open ports. We
>      have a timer isolate started in the VM isolate and if the shutdown
>      happens soon enough this port is still open.
> 
> Change-Id: Icfa07c91b8692eb76ba8502063cf6f5cf04832a5
> Reviewed-on: https://dart-review.googlesource.com/c/81200
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
> Commit-Queue: Siva Annamalai <asiva@google.com>

TBR=rmacnak@google.com,asiva@google.com

Change-Id: I0fd4472d277a380b739e602aa3910cc1f96ed89e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/81223
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>

    Changed files

    • runtime/lib/vmservice.cc

  81. [vm] Don't re-enqueue functions after unoptimized compiles

    Changed by Zach Anderson - zraohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 04:25:23 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 289d2b003a5cb0996b3d62ff8aff74a11109946d

    Comments

    [vm] Don't re-enqueue functions after unoptimized compiles

Change-Id: I18ea0915971f073af14a99273fe75ed2ec32ed07
Reviewed-on: https://dart-review.googlesource.com/c/81161
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>

    Changed files

    • runtime/vm/compiler/jit/compiler.cc
    • runtime/vm/object.cc
    • runtime/vm/object.h

  82. [VM] : Cleanup the file modified and service stream callbacks in

    Changed by asiva - asivaohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 04:04:33 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 33accb510b563579f76cf87013cb54f1d55cf125

    Comments

    [VM] : Cleanup the file modified and service stream callbacks in
       Dart_Cleanup so that the Flutter engine can restart the VM.

Change-Id: I3ecb13859ac5731b00af3c7dfa4aa47caa929d2e
Reviewed-on: https://dart-review.googlesource.com/c/81203
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>

    Changed files

    • runtime/include/dart_tools_api.h
    • runtime/vm/dart.cc
    • runtime/vm/dart_api_impl.cc

  83. [VM] Fix for issue 34839 - Dart_Cleanup may hang while shutting down

    Changed by asiva - asivaohnoyoudont@google.com
    Changed at Tuesday, 23-Oct-18 03:00:00 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 89c845eba20e1a021dbb6e3fc3372e06b8be6a24

    Comments

    [VM] Fix for issue 34839 - Dart_Cleanup may hang while shutting down
     the service isolate.

     The service isolate request for shutdown uses a Dart level message
     for exiting the isolate, this shuts down the isolate but does not
     completely bring the isolate down if there are some open ports. We
     have a timer isolate started in the VM isolate and if the shutdown
     happens soon enough this port is still open.

Change-Id: Icfa07c91b8692eb76ba8502063cf6f5cf04832a5
Reviewed-on: https://dart-review.googlesource.com/c/81200
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>

    Changed files

    • runtime/lib/vmservice.cc

  84. Revert "Compute unlinked API signatures without unlinked summaries."

    Changed by Konstantin Shcheglov - scheglovohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 21:29:11 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision e648d63bedc2a4decb3b8cbcf0f2e1c44db960b0

    Comments

    Revert "Compute unlinked API signatures without unlinked summaries."

This reverts commit eb9687189de61c7a50bb1ad76dd10389ed428663.

Exceptions like "Element not found in summary" still happen with
2.1.0-dev.7.1 internally, and I suspect that it is caused by
discrepancies in API signatures and unlinked units. So, I think we
should revert this change.  We are not going to do one-phase link
anymore, so this CL is not strongly required anymore.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I213156942fa3257b1884b209dda0b1d0c731d9a8
Reviewed-on: https://dart-review.googlesource.com/c/81181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

    Changed files

    • pkg/analyzer/lib/src/dart/analysis/file_state.dart
    • pkg/analyzer/lib/src/dart/analysis/unlinked_api_signature.dart
    • pkg/analyzer/test/src/dart/analysis/file_state_test.dart
    • pkg/analyzer/test/src/dart/analysis/test_all.dart
    • pkg/analyzer/test/src/dart/analysis/unlinked_api_signature_test.dart

  85. Revert "[vm] Revert service isolate setup in main.cc"

    Changed by Alexander Markov - alexmarkovohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 20:51:48 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 74792f4b9cb1aba59c3ad0ea554ecbc71d5a75a3

    Comments

    Revert "[vm] Revert service isolate setup in main.cc"

This reverts commit 0eb5dbffacf22b484b9e37b49475c06c3f3b065d.

Reason for revert: the root cause of crashes is fixed, so
there is no need in the workaround anymore.

Change-Id: Ifc3b5027193c2d5db4a43f451996607b9558fe78
Reviewed-on: https://dart-review.googlesource.com/c/80540
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>

    Changed files

    • runtime/bin/main.cc

  86. [vm/bytecode] Wire up bytecode generation in kernel service

    Changed by Alexander Markov - alexmarkovohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 19:42:35 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision b4fbf1a065ac27460c2f1988525a2678c20c4ccd

    Comments

    [vm/bytecode] Wire up bytecode generation in kernel service

In order to simplify testing and performance comparison, it is useful to
be able to run a command-line VM with a Dart source and use bytecode pipeline.
The bytecode generation is turned on in kernel service if --enable-interpreter
or --use-bytecode-compiler VM option is specified.

Change-Id: I6eb222b4df1721075c08d5f48c6d299ec779cb8c
Reviewed-on: https://dart-review.googlesource.com/c/80960
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>

    Changed files

    • pkg/vm/bin/kernel_service.dart
    • runtime/vm/kernel_isolate.cc

  87. [vm/compiler] Use loop framework for register allocator

    Changed by Aart Bik - ajcbikohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 19:29:30 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 914065d80b8497c6e1044342b980e0798f903a97

    Comments

    [vm/compiler] Use loop framework for register allocator

Rationale:
Rather than relying on a separate loop detector, rely
on the new loop framework, which avoids code duplication
and ensures any improvement in loop detection/handling
will benefit this phase too. Note, most of the time, the
same loops are discovered with a few exceptions (which
is okay, since this is "just" heuristic usage). This CL
also simplifies loop detection a bit.

https://github.com/dart-lang/sdk/issues/34473

Change-Id: I1a1b19b99a698c74822473d2a1fe370287c1ade4
Reviewed-on: https://dart-review.googlesource.com/c/80523
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>

    Changed files

    • runtime/vm/compiler/backend/flow_graph.cc
    • runtime/vm/compiler/backend/flow_graph.h
    • runtime/vm/compiler/backend/il.cc
    • runtime/vm/compiler/backend/il.h
    • runtime/vm/compiler/backend/linearscan.cc
    • runtime/vm/compiler/backend/linearscan.h
    • runtime/vm/compiler/backend/loops.cc
    • runtime/vm/compiler/backend/loops.h
    • runtime/vm/compiler/compiler_pass.cc
    • runtime/vm/compiler/intrinsifier.cc
    • tests/language_2/vm/irreducible_loop_test.dart

  88. [infra] Add analyzer branch alias for flutter-analyze builder (#34739)

    Changed by Alexander Thomas - athomohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 18:22:16 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 7fd78ed5b606e64d30ec201de9adce6fdf8856ba

    Comments

    [infra] Add analyzer branch alias for flutter-analyze builder (#34739)

* Channel detection only works for -dev, -stable and -try.
* This will allow adding flutter-analyze to the analyzer branch console.

TBR=whesse@google.com

Change-Id: I0a4036d290acdfba78ba138a0e87448f6da1e878
Reviewed-on: https://dart-review.googlesource.com/c/81101
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>

    Changed files

    • tools/bots/test_matrix.json

  89. [vm/bytecode] Add versioning to bytecode format

    Changed by Alexander Markov - alexmarkovohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 18:03:20 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 9406b7b44e4c0d37e0f3b5d14331838d6f793cf2

    Comments

    [vm/bytecode] Add versioning to bytecode format

Change-Id: I35d86aec17aa0f6894a6380e4bb5ac7ca3092fac
Reviewed-on: https://dart-review.googlesource.com/c/80522
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>

    Changed files

    • pkg/vm/bin/gen_kernel.dart
    • pkg/vm/lib/bytecode/dbc.dart
    • pkg/vm/lib/bytecode/gen_bytecode.dart
    • pkg/vm/lib/kernel_front_end.dart
    • pkg/vm/lib/metadata/bytecode.dart
    • pkg/vm/testcases/bytecode/asserts.dart.expect
    • pkg/vm/testcases/bytecode/async.dart.expect
    • pkg/vm/testcases/bytecode/bootstrapping.dart.expect
    • pkg/vm/testcases/bytecode/closures.dart.expect
    • pkg/vm/testcases/bytecode/deferred_lib.dart.expect
    • pkg/vm/testcases/bytecode/field_initializers.dart.expect
    • pkg/vm/testcases/bytecode/hello.dart.expect
    • pkg/vm/testcases/bytecode/instance_creation.dart.expect
    • pkg/vm/testcases/bytecode/literals.dart.expect
    • pkg/vm/testcases/bytecode/loops.dart.expect
    • pkg/vm/testcases/bytecode/optional_params.dart.expect
    • pkg/vm/testcases/bytecode/super_calls.dart.expect
    • pkg/vm/testcases/bytecode/switch.dart.expect
    • pkg/vm/testcases/bytecode/try_blocks.dart.expect
    • pkg/vm/testcases/bytecode/type_ops.dart.expect
    • runtime/vm/compiler/frontend/bytecode_reader.cc
    • runtime/vm/constants_kbc.h

  90. Move dartfix to its own package

    Changed by danrubel - danrubelohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 17:50:25 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision a82e025739138e7cbd890d0d7ea23fe5efb91b58

    Comments

    Move dartfix to its own package

Fix https://github.com/dart-lang/sdk/issues/34765

Change-Id: I44b3ccc4861b383601fea1b006f1fd4726b11062
Reviewed-on: https://dart-review.googlesource.com/c/81080
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>

    Changed files

    • .packages
    • pkg/analyzer_cli/test/all.dart
    • pkg/dartfix/.gitignore
    • pkg/dartfix/analysis_options.yaml
    • pkg/dartfix/bin/fix.dart
    • pkg/dartfix/lib/src/context.dart
    • pkg/dartfix/lib/src/driver.dart
    • pkg/dartfix/lib/src/options.dart
    • pkg/dartfix/lib/src/server.dart
    • pkg/dartfix/pubspec.yaml
    • pkg/dartfix/test/all.dart
    • pkg/dartfix/test/src/options_test.dart
    • pkg/dartfix/test/src/test_context.dart
    • pkg/pkg.status

  91. Set to publish new analyzer_plugin.

    Changed by Mike Fairhurst - mfairhurstohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 17:31:35 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 872e90106e2fef83b3215818c34862e19e5a0014

    Comments

    Set to publish new analyzer_plugin.

Currently latest published version depends on <0.33.0 which is causing problems
for built value: https://github.com/google/built_value.dart/issues/518

Change-Id: Id5bf8e755132613cd56a631b433115efff64b120
Reviewed-on: https://dart-review.googlesource.com/c/80560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>

    Changed files

    • pkg/analyzer_plugin/pubspec.yaml

  92. Improve how dartfix finds the analysis server pkg root

    Changed by danrubel - danrubelohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 16:28:10 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 2d14d9a313e92682338248e43c500d1d9e8f9de2

    Comments

    Improve how dartfix finds the analysis server pkg root

Change-Id: Iead97b14a2eede8628ea286fedcccbafb4f3c2b7
Reviewed-on: https://dart-review.googlesource.com/c/80943
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>

    Changed files

    • pkg/analyzer_cli/lib/src/fix/server.dart

  93. Disable support for the old super mixins

    Changed by Brian Wilkerson - brianwilkersonohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 16:02:01 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision a342cecffd8b57273439fd5fb68676fed0dfe9f9

    Comments

    Disable support for the old super mixins

Change-Id: I8f8074b67ea43249fcc10deddd2325938996d529
Reviewed-on: https://dart-review.googlesource.com/c/79469
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>

    Changed files

    • pkg/analysis_server/lib/src/domain_analysis.dart
    • pkg/analysis_server/lib/src/status/diagnostics.dart
    • pkg/analysis_server/test/context_manager_test.dart
    • pkg/analyzer/lib/error/error.dart
    • pkg/analyzer/lib/src/analysis_options/error/option_codes.dart
    • pkg/analyzer/lib/src/command_line/arguments.dart
    • pkg/analyzer/lib/src/context/context.dart
    • pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
    • pkg/analyzer/lib/src/dart/element/element.dart
    • pkg/analyzer/lib/src/dart/element/type.dart
    • pkg/analyzer/lib/src/generated/engine.dart
    • pkg/analyzer/lib/src/generated/error_verifier.dart
    • pkg/analyzer/lib/src/task/dart.dart
    • pkg/analyzer/lib/src/task/options.dart
    • pkg/analyzer/test/generated/compile_time_error_code_driver_test.dart
    • pkg/analyzer/test/generated/compile_time_error_code_test.dart
    • pkg/analyzer/test/generated/engine_test.dart
    • pkg/analyzer/test/generated/non_error_resolver_test.dart
    • pkg/analyzer/test/generated/simple_resolver_test.dart
    • pkg/analyzer/test/generated/static_type_warning_code_test.dart
    • pkg/analyzer/test/generated/static_warning_code_test.dart
    • pkg/analyzer/test/src/command_line/arguments_test.dart
    • pkg/analyzer/test/src/context/builder_test.dart
    • pkg/analyzer/test/src/dart/resolution/class_test.dart
    • pkg/analyzer/test/src/dart/resolution/driver_resolution.dart
    • pkg/analyzer/test/src/dart/resolution/resolution.dart
    • pkg/analyzer/test/src/dart/resolution/task_resolution.dart
    • pkg/analyzer/test/src/task/options_test.dart
    • pkg/analyzer/test/src/task/strong/checker_test.dart
    • pkg/analyzer/test/src/task/strong/inferred_type_test.dart
    • pkg/analyzer/test/src/task/strong/strong_test_helper.dart
    • pkg/analyzer_cli/lib/src/driver.dart
    • pkg/analyzer_cli/lib/src/options.dart
    • pkg/analyzer_cli/test/all.dart
    • pkg/analyzer_cli/test/driver_test.dart
    • pkg/analyzer_cli/test/options_test.dart
    • pkg/analyzer_cli/test/super_mixin_test.dart

  94. Handle generic types in LSP spec parsing

    Changed by Danny Tuppeny - dantupohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 14:40:54 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision cddc2d42e1488e921d649b58d47fbf4c874306dc

    Comments

    Handle generic types in LSP spec parsing

The regex wasn't picking up generate type args (in interface definitions or usages in field definitions). This adds <> characters to the regex and handles them in mapping of types (as well as adds some additional tests to cover this).

Change-Id: I8187b3d2abb2b35c0d7638839e3116700cfbf9e0
Reviewed-on: https://dart-review.googlesource.com/c/81004
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>

    Changed files

    • pkg/analysis_server/lib/lsp_protocol/protocol_generated.dart
    • pkg/analysis_server/test/tool/lsp_spec/dart_test.dart
    • pkg/analysis_server/test/tool/lsp_spec/json_test.dart
    • pkg/analysis_server/test/tool/lsp_spec/typescript_test.dart
    • pkg/analysis_server/tool/lsp_spec/codegen_dart.dart
    • pkg/analysis_server/tool/lsp_spec/typescript.dart

  95. Support post-inference serialization/deserialization

    Changed by Johnni Winther - johnniwintherohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 14:37:04 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 8b6f8969a6d3367a6ad2551c290048c61941ef77

    Comments

    Support post-inference serialization/deserialization

Currently handling Swarm in-memory serialization/deserialization.

Change-Id: I4b01f70d1e42d7462ed079ece227d6c2ed4de597
Reviewed-on: https://dart-review.googlesource.com/c/80445
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Auto-Submit: Johnni Winther <johnniwinther@google.com>

    Changed files

    • pkg/compiler/lib/src/backend_strategy.dart
    • pkg/compiler/lib/src/closure.dart
    • pkg/compiler/lib/src/compiler.dart
    • pkg/compiler/lib/src/deferred_load.dart
    • pkg/compiler/lib/src/elements/entities.dart
    • pkg/compiler/lib/src/elements/indexed.dart
    • pkg/compiler/lib/src/inferrer/inferrer_engine.dart
    • pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart
    • pkg/compiler/lib/src/inferrer/typemasks/container_type_mask.dart
    • pkg/compiler/lib/src/inferrer/typemasks/dictionary_type_mask.dart
    • pkg/compiler/lib/src/inferrer/typemasks/flat_type_mask.dart
    • pkg/compiler/lib/src/inferrer/typemasks/map_type_mask.dart
    • pkg/compiler/lib/src/inferrer/typemasks/masks.dart
    • pkg/compiler/lib/src/inferrer/typemasks/type_mask.dart
    • pkg/compiler/lib/src/inferrer/typemasks/union_type_mask.dart
    • pkg/compiler/lib/src/inferrer/typemasks/value_type_mask.dart
    • pkg/compiler/lib/src/js_backend/allocator_analysis.dart
    • pkg/compiler/lib/src/js_backend/annotations.dart
    • pkg/compiler/lib/src/js_backend/backend_usage.dart
    • pkg/compiler/lib/src/js_backend/inferred_data.dart
    • pkg/compiler/lib/src/js_backend/interceptor_data.dart
    • pkg/compiler/lib/src/js_backend/native_data.dart
    • pkg/compiler/lib/src/js_backend/no_such_method_registry.dart
    • pkg/compiler/lib/src/js_backend/runtime_types.dart
    • pkg/compiler/lib/src/js_emitter/code_emitter_task.dart
    • pkg/compiler/lib/src/js_model/closure.dart
    • pkg/compiler/lib/src/js_model/element_map.dart
    • pkg/compiler/lib/src/js_model/element_map_impl.dart
    • pkg/compiler/lib/src/js_model/elements.dart
    • pkg/compiler/lib/src/js_model/env.dart
    • pkg/compiler/lib/src/js_model/js_strategy.dart
    • pkg/compiler/lib/src/js_model/locals.dart
    • pkg/compiler/lib/src/kernel/env.dart
    • pkg/compiler/lib/src/native/behavior.dart
    • pkg/compiler/lib/src/ordered_typeset.dart
    • pkg/compiler/lib/src/serialization/abstract_sink.dart
    • pkg/compiler/lib/src/serialization/abstract_source.dart
    • pkg/compiler/lib/src/serialization/binary_sink.dart
    • pkg/compiler/lib/src/serialization/binary_source.dart
    • pkg/compiler/lib/src/serialization/helpers.dart
    • pkg/compiler/lib/src/serialization/member_data.dart
    • pkg/compiler/lib/src/serialization/mixins.dart
    • pkg/compiler/lib/src/serialization/node_indexer.dart
    • pkg/compiler/lib/src/serialization/object_sink.dart
    • pkg/compiler/lib/src/serialization/object_source.dart
    • pkg/compiler/lib/src/serialization/serialization.dart
    • pkg/compiler/lib/src/types/abstract_value_domain.dart
    • pkg/compiler/lib/src/types/types.dart
    • pkg/compiler/lib/src/universe/call_structure.dart
    • pkg/compiler/lib/src/universe/class_hierarchy.dart
    • pkg/compiler/lib/src/universe/class_set.dart
    • pkg/compiler/lib/src/universe/selector.dart
    • pkg/compiler/lib/src/universe/side_effects.dart
    • pkg/compiler/lib/src/util/enumset.dart
    • pkg/compiler/lib/src/world.dart
    • tests/compiler/dart2js/analyses/dart2js_allowed.json
    • tests/compiler/dart2js/model/in_memory_split_test.dart

  96. Remove unused import that shows a warning

    Changed by Danny Tuppeny - dantupohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 14:31:34 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 9c3834d41cf5ea50012b534943a7942fc78a8310

    Comments

    Remove unused import that shows a warning

Change-Id: Icc044234df59a2e1e148a531df59e952a221c8a3
Reviewed-on: https://dart-review.googlesource.com/c/81005
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>

    Changed files

    • pkg/analysis_server/test/services/refactoring/move_file_test.dart

  97. Exposes VM and Isolate Metrics in the API.

    Changed by Clement Skau - cskauohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 13:38:16 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision a1d61371d36b289cbd19144a07b66db177d108d3

    Comments

    Exposes VM and Isolate Metrics in the API.

This change allows devs embedding the VM in e.g. a server to e.g. export VM metrics as part of their server health metrics.

Change-Id: I7a86a3ad98b900d30d9b7f5d19fa77f1705610c6
Reviewed-on: https://dart-review.googlesource.com/c/74723
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Clement Skau <cskau@google.com>

    Changed files

    • runtime/include/dart_tools_api.h
    • runtime/vm/dart_api_impl.cc
    • runtime/vm/metrics.cc
    • runtime/vm/metrics.h

  98. Compute substitution map on kernel objects instead of builders

    Changed by Peter von der Ahé - aheohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 12:41:59 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 2c6eabd3c468e1f254f5a6f0db012b561d394938

    Comments

    Compute substitution map on kernel objects instead of builders

Fixes https://github.com/dart-lang/sdk/issues/34856

Change-Id: I150a390ea19e684e7951c1354c09fd40845e4328
Reviewed-on: https://dart-review.googlesource.com/c/81006
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>

    Changed files

    • pkg/front_end/lib/src/fasta/fasta_codes_generated.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
    • pkg/front_end/messages.yaml
    • pkg/front_end/test/issue_34856_test.dart

  99. Move getSubstitutionMap to KernelClassBuilder

    Changed by Peter von der Ahé - aheohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 12:41:59 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision 704a43558de250b3ade9abe030a7116cd245680b

    Comments

    Move getSubstitutionMap to KernelClassBuilder

Also, change the signature to return a kernel substitution map.

This prepares for fixing issue https://github.com/dart-lang/sdk/issues/34856,
as DillClassBuilders don't have builder wrappers for type variables and
supertypes.

Change-Id: Ia3f2458852ffaad766c44f62fd93e68234650126
Reviewed-on: https://dart-review.googlesource.com/c/81002
Reviewed-by: Kevin Millikin <kmillikin@google.com>

    Changed files

    • pkg/front_end/lib/src/fasta/builder/class_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_target.dart

  100. Respecify where type promotion happens.

    Changed by Lasse R.H. Nielsen - lrnohnoyoudont@google.com
    Changed at Monday, 22-Oct-18 12:33:56 UTC
    Repository https://dart.googlesource.com/sdk
    Branch
    Revision af8e29142b848931ecda9ef46f6080f60ce79bb0

    Comments

    Respecify where type promotion happens.

This makes some parts of the specification explicit,
and rephrases it so that it is easier to recognize the separate cases.

Change-Id: Ifdbb5c11ec3b3fe80737642f230ee291a18a5841
Reviewed-on: https://dart-review.googlesource.com/c/80824
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>

    Changed files

    • docs/language/dartLangSpec.tex

  101. <blame list capped at 100 commits>

    Changed by <blame list capped at 100 commits> -
    Changed at N/A
    Repository
    Branch
    Revision

    Comments

    <blame list capped at 100 commits>