Builder analyzer-mac-release-dev Build 6

Results:

Success

Trigger Info:

Project	dart
Revision	2b19656a1d2700a2800a96caa6299eb14d425846
Got Revision	2b19656a1d2700a2800a96caa6299eb14d425846

Execution:

• Source: Task 3dc65b8a6cbe6810
• Bot: build3-m9

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog

   <nil> is invalid: invalid project name: "": cannot have empty name
   • - no logs -

Build Properties:

Name	Value	Source

Blamelist:

1. Alexander Thomas (athomohnoyoudont@google.com)
2. Alexander Markov (alexmarkovohnoyoudont@google.com)
3. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
4. Paul Berry (paulberryohnoyoudont@google.com)
5. danrubel (danrubelohnoyoudont@google.com)
6. Zach Anderson (zraohnoyoudont@google.com)
7. Dan Rubel (danrubelohnoyoudont@google.com)
8. Lasse R.H. Nielsen (lrnohnoyoudont@google.com)
9. Alexander Thomas (athomohnoyoudont@google.com)
10. Johnni Winther (johnniwintherohnoyoudont@google.com)
11. Dmitry Stefantsov (dmitryasohnoyoudont@google.com)
12. Peter von der Ahé (aheohnoyoudont@google.com)
13. Peter von der Ahé (aheohnoyoudont@google.com)
14. Samir Jindel (sjindelohnoyoudont@google.com)
15. Erik Ernst (eernstohnoyoudont@google.com)
16. Samir Jindel (sjindelohnoyoudont@google.com)
17. Kevin Millikin (kmillikinohnoyoudont@google.com)
18. Alexander Thomas (athomohnoyoudont@google.com)
19. Erik Ernst (eernstohnoyoudont@google.com)
20. Kevin Millikin (kmillikinohnoyoudont@google.com)
21. Johnni Winther (johnniwintherohnoyoudont@google.com)
22. Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
23. Alexander Aprelev (aamohnoyoudont@google.com)
24. danrubel (danrubelohnoyoudont@google.com)
25. danrubel (danrubelohnoyoudont@google.com)
26. Régis Crelier (regisohnoyoudont@google.com)
27. Adam Barth (abarthohnoyoudont@google.com)
28. Paul Berry (paulberryohnoyoudont@google.com)
29. Paul Berry (paulberryohnoyoudont@google.com)
30. Paul Berry (paulberryohnoyoudont@google.com)
31. Paul Berry (paulberryohnoyoudont@google.com)
32. Paul Berry (paulberryohnoyoudont@google.com)
33. Paul Berry (paulberryohnoyoudont@google.com)
34. Erik Ernst (eernstohnoyoudont@google.com)
35. Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
36. Dmitry Stefantsov (dmitryasohnoyoudont@google.com)
37. Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
38. Paul Berry (paulberryohnoyoudont@google.com)
39. Paul Berry (paulberryohnoyoudont@google.com)
40. Paul Berry (paulberryohnoyoudont@google.com)
41. Paul Berry (paulberryohnoyoudont@google.com)
42. Paul Berry (paulberryohnoyoudont@google.com)
43. Peter von der Ahé (aheohnoyoudont@google.com)
44. Peter von der Ahé (aheohnoyoudont@google.com)
45. Peter von der Ahé (aheohnoyoudont@google.com)
46. Paul Berry (paulberryohnoyoudont@google.com)
47. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
48. Paul Berry (paulberryohnoyoudont@google.com)
49. Jaime Wren (jwrenohnoyoudont@google.com)
50. asiva (asivaohnoyoudont@google.com)
51. Zach Anderson (zraohnoyoudont@google.com)
52. Emily Fortuna (efortunaohnoyoudont@google.com)
53. Paul Berry (paulberryohnoyoudont@google.com)
54. Vijay Menon (vsmohnoyoudont@google.com)
55. danrubel (danrubelohnoyoudont@google.com)
56. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
57. Ryan Macnak (rmacnakohnoyoudont@google.com)
58. Emily Fortuna (efortunaohnoyoudont@google.com)
59. Leaf Petersen (leafpohnoyoudont@google.com)
60. Ryan Macnak (rmacnakohnoyoudont@google.com)
61. Ben Konyi (bkonyiohnoyoudont@google.com)
62. Alexander Aprelev (aamohnoyoudont@google.com)
63. Mike Fairhurst (mfairhurstohnoyoudont@google.com)
64. Ryan Macnak (rmacnakohnoyoudont@google.com)
65. Konstantin Shcheglov (scheglovohnoyoudont@google.com)
66. Vyacheslav Egorov (vegorovohnoyoudont@google.com)
67. Vyacheslav Egorov (vegorovohnoyoudont@google.com)
68. Ben Konyi (bkonyiohnoyoudont@google.com)
69. Alexander Markov (alexmarkovohnoyoudont@google.com)
70. Kevin Millikin (kmillikinohnoyoudont@google.com)
71. Dan Rubel (danrubelohnoyoudont@google.com)
72. Jaime Wren (jwrenohnoyoudont@google.com)
73. Erik Ernst (eernstohnoyoudont@google.com)
74. Kevin Millikin (kmillikinohnoyoudont@google.com)
75. Samir Jindel (sjindelohnoyoudont@google.com)
76. Terry Lucas (terryohnoyoudont@google.com)
77. Samir Jindel (sjindelohnoyoudont@google.com)
78. Peter von der Ahé (aheohnoyoudont@google.com)
79. Peter von der Ahé (aheohnoyoudont@google.com)
80. Peter von der Ahé (aheohnoyoudont@google.com)
81. Peter von der Ahé (aheohnoyoudont@google.com)
82. Kevin Millikin (kmillikinohnoyoudont@google.com)
83. Martin Kustermann (kustermannohnoyoudont@google.com)
84. Peter von der Ahé (aheohnoyoudont@google.com)
85. Kevin Millikin (kmillikinohnoyoudont@google.com)
86. Johnni Winther (johnniwintherohnoyoudont@google.com)
87. Johnni Winther (johnniwintherohnoyoudont@google.com)
88. Johnni Winther (johnniwintherohnoyoudont@google.com)
89. Martin Kustermann (kustermannohnoyoudont@google.com)
90. Peter von der Ahé (aheohnoyoudont@google.com)
91. Peter von der Ahé (aheohnoyoudont@google.com)
92. Johnni Winther (johnniwintherohnoyoudont@google.com)
93. Mike Fairhurst (mfairhurstohnoyoudont@google.com)
94. Johnni Winther (johnniwintherohnoyoudont@google.com)
95. Mike Fairhurst (mfairhurstohnoyoudont@google.com)
96. Sigmund Cherem (sigmundohnoyoudont@google.com)
97. Ben Konyi (bkonyiohnoyoudont@google.com)
98. Ben Konyi (bkonyiohnoyoudont@google.com)
99. Dan Rubel (danrubelohnoyoudont@google.com)
100. Dan Rubel (danrubelohnoyoudont@google.com)
101. <blame list capped at 100 commits> ()

Timing:

Create	Tuesday, 29-May-18 20:14:52 UTC
Start	Tuesday, 29-May-18 20:14:56 UTC
End	Tuesday, 29-May-18 20:45:41 UTC
Pending	4 secs
Execution	30 mins 44 secs

All Changes:

1. Version 2.0.0-dev.59.0

   Changed by	Alexander Thomas - athomohnoyoudont@google.com
   Changed at	Tuesday, 29-May-18 20:11:36 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	2b19656a1d2700a2800a96caa6299eb14d425846

   Comments

   Version 2.0.0-dev.59.0
   
   Merge commit '1ca17b6d03d0fdf8778d45c486bb5ac617809df0' into dev
   

2. [vm/kernel] Recognize desugared mixin applications in dart:mirrors

   Changed by	Alexander Markov - alexmarkovohnoyoudont@google.com
   Changed at	Tuesday, 29-May-18 18:12:26 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	1ca17b6d03d0fdf8778d45c486bb5ac617809df0

   Comments

   [vm/kernel] Recognize desugared mixin applications in dart:mirrors
   
   Kernel mixin transformation desugars mixin applications into normal
   classes. Mixed-in type is pulled into interfaces list.
   However, dart:mirrors needs to know the original mixed-in type of
   a mixin application.
   
   This change solves this problem by propagating a 'isTransformedMixinApplication'
   attribute of a class through kernel AST, kernel binary and VM objects
   into dart:mirrors implementation.
   
   Fixes: https://github.com/dart-lang/sdk/issues/33240
   Change-Id: I98ca69294e1ad445402a5ca91d90c30447aabcb2
   Reviewed-on: https://dart-review.googlesource.com/56721
   Commit-Queue: Alexander Markov <alexmarkov@google.com>
   Reviewed-by: Ryan Macnak <rmacnak@google.com>
   Reviewed-by: Siva Annamalai <asiva@google.com>
   Reviewed-by: Kevin Millikin <kmillikin@google.com>
   

   Changed files

   • pkg/analyzer/lib/src/dart/element/element.dart
   • pkg/compiler/lib/src/kernel/env.dart
   • pkg/dev_compiler/lib/src/kernel/compiler.dart
   • pkg/dev_compiler/lib/src/kernel/kernel_helpers.dart
   • pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
   • pkg/front_end/lib/src/fasta/source/source_loader.dart
   • pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
   • pkg/front_end/test/incremental_utils.dart
   • pkg/kernel/binary.md
   • pkg/kernel/lib/ast.dart
   • pkg/kernel/lib/binary/ast_from_binary.dart
   • pkg/kernel/lib/binary/ast_to_binary.dart
   • pkg/kernel/lib/binary/tag.dart
   • pkg/kernel/lib/class_hierarchy.dart
   • pkg/kernel/lib/transformations/mixin_full_resolution.dart
   • pkg/vm/lib/transformations/mixin_deduplication.dart
   • runtime/lib/mirrors.cc
   • runtime/lib/mirrors_impl.dart
   • runtime/vm/compiler/frontend/kernel_binary_flowgraph.h
   • runtime/vm/kernel_binary.h
   • runtime/vm/kernel_loader.cc
   • runtime/vm/object.cc
   • runtime/vm/object.h
   • tests/lib_2/lib_2_kernel.status

3. Fix AstRewriteVisitor to set elements/types for instance creation nodes.

   Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
   Changed at	Tuesday, 29-May-18 18:08:07 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	8b0c1f8044f0a57e58bd8a79fd0292895e94fda4

   Comments

   Fix AstRewriteVisitor to set elements/types for instance creation nodes.
   
   R=brianwilkerson@google.com
   
   Bug: https://github.com/flutter/flutter/issues/17429
   Change-Id: I818fabb2faf1b0ffb68957a9713a22e53db25709
   Reviewed-on: https://dart-review.googlesource.com/57000
   Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
   Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
   

   Changed files

   • pkg/analyzer/lib/src/dart/analysis/driver.dart
   • pkg/analyzer/lib/src/generated/resolver.dart
   • pkg/analyzer/test/generated/non_error_resolver_test.dart

4. Bump analyzer version in preparation for publishing.

   Changed by	Paul Berry - paulberryohnoyoudont@google.com
   Changed at	Tuesday, 29-May-18 17:47:46 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	84fcf42c252d28b362da04127c299441b7444a31

   Comments

   Bump analyzer version in preparation for publishing.
   
   Change-Id: I1d794db9f086f8fb8830d7974b79653d549423c6
   Reviewed-on: https://dart-review.googlesource.com/56708
   Commit-Queue: Paul Berry <paulberry@google.com>
   Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
   Reviewed-by: Janice Collins <jcollins@google.com>
   Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
   Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
   

   Changed files

   • pkg/analyzer/CHANGELOG.md
   • pkg/analyzer/pubspec.yaml
   • pkg/front_end/pubspec.yaml
   • pkg/kernel/pubspec.yaml

5. Update Analyzer tests to pass NonExistingSource rather than null

   Changed by	danrubel - danrubelohnoyoudont@google.com
   Changed at	Tuesday, 29-May-18 17:12:26 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	96dd9d49db0715b9a28421a7ba7ac1bf1b67fe00

   Comments

   Update Analyzer tests to pass NonExistingSource rather than null
   
   Change-Id: I770d50a31230e7e3fdabecf4cbffc6fee76e1fb5
   Reviewed-on: https://dart-review.googlesource.com/57020
   Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
   Commit-Queue: Dan Rubel <danrubel@google.com>
   

   Changed files

   • pkg/analyzer/lib/src/generated/source.dart
   • pkg/analyzer/test/generated/parser_test.dart
   • pkg/analyzer/test/generated/utilities_test.dart
   • pkg/analyzer/test/src/summary/summarize_ast_test.dart

6. [Observatory] Refactor observatory build to prepare for Fuchsia prebuilt

   Changed by	Zach Anderson - zraohnoyoudont@google.com
   Changed at	Tuesday, 29-May-18 16:35:34 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	736ddd9b0e049ae966aa50f48ee618dd47418d35

   Comments

   [Observatory] Refactor observatory build to prepare for Fuchsia prebuilt
   
   This splits create_archive.py into two steps. One that creates the .tar
   and one that creates the .cc for the .tar. This way on Fuchsia, the
   second step will take the prebuilt instead of building it.
   
   Change-Id: I7f407f9e70db3135884eeeb61aa5aec3091f1fcc
   Reviewed-on: https://dart-review.googlesource.com/56291
   Reviewed-by: Ryan Macnak <rmacnak@google.com>
   

   Changed files

   • BUILD.gn
   • runtime/observatory/BUILD.gn
   • runtime/tools/create_archive.py

7. Improve field type argument recovery

   Changed by	Dan Rubel - danrubelohnoyoudont@google.com
   Changed at	Tuesday, 29-May-18 16:30:46 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	b7336ab443061cd2c0d818b77d409ad380b0678a

   Comments

   Improve field type argument recovery
   
   This CL improves recovery when parsing field type arguments
   and adds more tests for parsing type parameters and type arguments.
   
   Change-Id: Ib6ee4081f898d0421d90a66de84d686206a06a8f
   Reviewed-on: https://dart-review.googlesource.com/56682
   Commit-Queue: Dan Rubel <danrubel@google.com>
   Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
   

   Changed files

   • pkg/analyzer/test/generated/parser_fasta_test.dart
   • pkg/analyzer/test/src/fasta/recovery/paired_tokens_test.dart
   • pkg/front_end/lib/src/fasta/parser/parser.dart
   • pkg/front_end/lib/src/fasta/parser/type_info_impl.dart
   • pkg/front_end/test/fasta/parser/type_info_test.dart
   • tests/co19/co19-dart2js.status
   • tests/language/language_dart2js.status

8. Fix fused UTF-8/JSON decoding.

   Changed by	Lasse R.H. Nielsen - lrnohnoyoudont@google.com
   Changed at	Tuesday, 29-May-18 12:34:25 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	6bc7288e708f6efd48cae83ac7413188dd741de2

   Comments

   Fix fused UTF-8/JSON decoding.
   
   The VM version's parser did not allow a leading BOM, and it failed to parse a top-level integer.
   
   Added test to check this.
   
   Fixes #33251
   
   Bug: http://dartbug.com/33251
   Change-Id: I51e429082f0e9baac81e20f73b0885922b40b0b8
   Reviewed-on: https://dart-review.googlesource.com/56860
   Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
   Reviewed-by: Florian Loitsch <floitsch@google.com>
   

   Changed files

   • pkg/expect/lib/expect.dart
   • runtime/lib/convert_patch.dart
   • tests/lib_2/convert/json_test.dart
   • tests/lib_2/convert/json_utf8_test.dart

9. [vm] Prepare status for app_jitk builders (#33126)

   Changed by	Alexander Thomas - athomohnoyoudont@google.com
   Changed at	Tuesday, 29-May-18 11:43:25 UTC
   Repository	https://dart.googlesource.com/sdk
   Branch
   Revision	2a3d1dc9ed37ec87f9a34bce11590bdd7656cb26

   Comments

   [vm] Prepare status for app_jitk builders (#33126)
   
   Change-Id: Iec5347b5f091b9fd6ff3c24047b011527f8b08ee
   Reviewed-on: https://dart-review.googlesource.com/56802
   Commit-Queue: Alexander Thomas <athom@google.com>
   Reviewed-by: Martin Kustermann <kustermann@google.com>
   

   Changed files

   • runtime/observatory/tests/service/service_kernel.status
   • runtime/tests/vm/vm.status
   • tests/corelib_2/corelib_2.status
   • tests/kernel/kernel.status
   • tests/language_2/language_2.status
   • tests/language_2/language_2_kernel.status
   • tests/lib_2/lib_2_app_jit.status
   • tests/lib_2/lib_2_kernel.status
   • tests/lib_2/lib_2_vm.status
   • tests/standalone_2/standalone_2.status
   • tests/standalone_2/standalone_2_kernel.status

10. Handle Windows line ending in generate_messages_test

    Changed by	Johnni Winther - johnniwintherohnoyoudont@google.com
    Changed at	Tuesday, 29-May-18 11:03:15 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	40f61d6b0b6c4839182a4fae92d7e1527e93cf7a

    Comments

    Handle Windows line ending in generate_messages_test
    
    Change-Id: I221f421449ffc4b51916b5741b7c909a828c50cd
    Reviewed-on: https://dart-review.googlesource.com/56840
    Reviewed-by: Peter von der Ahé <ahe@google.com>
    Commit-Queue: Johnni Winther <johnniwinther@google.com>
    

    Changed files

    • pkg/front_end/tool/_fasta/generate_messages_test.dart

11. [fasta] Add support for annotations on enum values

    Changed by	Dmitry Stefantsov - dmitryasohnoyoudont@google.com
    Changed at	Tuesday, 29-May-18 10:41:55 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	7dc4fbf5a27dffd974fa4a170b213df270b2112f

    Comments

    [fasta] Add support for annotations on enum values
    
    Fixes #33083
    
    Bug: https://github.com/dart-lang/sdk/issues/33083
    Change-Id: If278ee3c59489944e2e821ae48ba3cb363dbbdd1
    Reviewed-on: https://dart-review.googlesource.com/56496
    Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
    Reviewed-by: Peter von der Ahé <ahe@google.com>
    Reviewed-by: Dan Rubel <danrubel@google.com>
    

    Changed files

    • pkg/front_end/lib/src/fasta/fasta_codes_generated.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart
    • pkg/front_end/lib/src/fasta/parser/parser.dart
    • pkg/front_end/lib/src/fasta/source/diet_listener.dart
    • pkg/front_end/lib/src/fasta/source/outline_builder.dart
    • pkg/front_end/messages.yaml
    • pkg/front_end/testcases/annotation_on_enum_values.dart
    • pkg/front_end/testcases/annotation_on_enum_values.dart.direct.expect
    • pkg/front_end/testcases/annotation_on_enum_values.dart.direct.transformed.expect
    • pkg/front_end/testcases/annotation_on_enum_values.dart.outline.expect
    • pkg/front_end/testcases/annotation_on_enum_values.dart.strong.expect
    • pkg/front_end/testcases/annotation_on_enum_values.dart.strong.transformed.expect
    • pkg/front_end/testcases/ast_builder.status

12. Import link.dart directly

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Tuesday, 29-May-18 07:40:27 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	2514a67614f4c1ac17975fe3de4f83d554040757

    Comments

    Import link.dart directly
    
    I'd like to deprecate and remove the Link class,
    as best as I can tell, it doesn't offer the same
    performance benefits as I've seen on other platforms.
    
    Fasta mostly uses "null" to represent empty lists, and
    after the old dart2js front was deleted, there are few
    uses remaining.
    
    This CL makes it easier to find the remaining uses.
    
    Change-Id: I73ac9b6b8b1bf5fed9669ae939cb3252cedbef0f
    Reviewed-on: https://dart-review.googlesource.com/56781
    Reviewed-by: Johnni Winther <johnniwinther@google.com>
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    

    Changed files

    • pkg/compiler/lib/src/constants/evaluation.dart
    • pkg/compiler/lib/src/kernel/element_map_impl.dart
    • pkg/compiler/lib/src/library_loader.dart
    • pkg/compiler/lib/src/ordered_typeset.dart
    • pkg/compiler/lib/src/ssa/codegen.dart
    • pkg/compiler/lib/src/ssa/nodes.dart
    • pkg/compiler/lib/src/universe/class_set.dart
    • pkg/compiler/lib/src/util/util.dart
    • pkg/compiler/lib/src/world.dart
    • tests/compiler/dart2js/closure/closure_test.dart
    • tests/compiler/dart2js/compiler_helper.dart
    • tests/compiler/dart2js/link_test.dart
    • tests/compiler/dart2js/model/class_set_test.dart

13. Avoid allocation and bottom-type on Link

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Tuesday, 29-May-18 07:40:27 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	990c85276bdd61bf785b75d0328ab0b7fbc39558

    Comments

    Avoid allocation and bottom-type on Link
    
    Change-Id: Ib23e596edf55285cc63e3a391da3712b2bcb1224
    Reviewed-on: https://dart-review.googlesource.com/56761
    Reviewed-by: Johnni Winther <johnniwinther@google.com>
    

    Changed files

    • pkg/compiler/lib/src/kernel/element_map_impl.dart
    • pkg/compiler/lib/src/ordered_typeset.dart
    • pkg/compiler/lib/src/util/util.dart
    • pkg/front_end/lib/src/fasta/util/link.dart
    • pkg/front_end/lib/src/fasta/util/link_implementation.dart
    • pkg/front_end/test/fasta/link_test.dart
    • tests/compiler/dart2js/link_test.dart

14. Revert "[vm] Support definition of entry-points via @pragma('vm.extern') annotations."

    Changed by	Samir Jindel - sjindelohnoyoudont@google.com
    Changed at	Monday, 28-May-18 19:23:16 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	58dc4e476d0aa83aec82151c3689a93e504afaf5

    Comments

    Revert "[vm] Support definition of entry-points via @pragma('vm.extern') annotations."
    
    This reverts commit 3e50ea32b5e8ddee3c24c7f1f0fe41e9c929cd4b.
    
    Reason for revert: Severe performance regressions on many aot-v2 benchmarks.
    
    Original change's description:
    > [vm] Support definition of entry-points via @pragma('vm.extern') annotations.
    > 
    > The `@pragma` annotations are evaluated by the constants transformation and
    > visible to TFA and the precompiler, which match on the "options" field of the
    > annotation to determine whether to mark the class/procedure as a root.
    > 
    > This required enabling the transformation of annotation constants by default.
    > 
    > # Test Plan
    > 
    > The "vmservice_io.main" entry-point is removed from `main.cc` and annotated with
    > `@pragma`. All precompiler tests will crash if "vmservice_io.main" is not
    > available at runtime.
    > 
    > Debug/release precompiler bots are visible in "cl-linux" button.
    > 
    > Change-Id: I03c5d6ba7918672ed9905fcaee8dabe675a93a5d
    > Reviewed-on: https://dart-review.googlesource.com/56660
    > Commit-Queue: Samir Jindel <sjindel@google.com>
    > Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
    
    TBR=vegorov@google.com,alexmarkov@google.com,sjindel@google.com
    
    Change-Id: I779c17d003659129a4b3fcf284423104948f60e2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://dart-review.googlesource.com/56820
    Reviewed-by: Samir Jindel <sjindel@google.com>
    Commit-Queue: Samir Jindel <sjindel@google.com>
    

    Changed files

    • pkg/kernel/binary.md
    • pkg/kernel/lib/core_types.dart
    • pkg/vm/lib/kernel_front_end.dart
    • pkg/vm/lib/transformations/type_flow/analysis.dart
    • pkg/vm/lib/transformations/type_flow/native_code.dart
    • pkg/vm/lib/transformations/type_flow/transformer.dart
    • runtime/bin/main.cc
    • runtime/bin/vmservice/vmservice_io.dart
    • runtime/vm/compiler/aot/precompiler.cc
    • runtime/vm/compiler/aot/precompiler.h
    • runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc
    • runtime/vm/kernel_loader.cc
    • runtime/vm/kernel_loader.h
    • runtime/vm/object.cc
    • runtime/vm/object.h
    • runtime/vm/object_store.cc
    • runtime/vm/object_store.h
    • runtime/vm/parser.cc
    • runtime/vm/parser.h
    • runtime/vm/symbols.h

15. Adjusted the instantiate-to-bound algorithm to break cycles at

    Changed by	Erik Ernst - eernstohnoyoudont@google.com
    Changed at	Monday, 28-May-18 16:01:45 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	e20189ecf58ef85487273ce07d8fc7c2bf925487

    Comments

    Adjusted the instantiate-to-bound algorithm to break cycles at
    every member, not just one.
    
    Note that a fresh copy of this document with rendering is available
    at https://gist.github.com/eernstg/6deffcde2cbe79f8ba499b3aac950900.
    
    Change-Id: Ia7e3d8e2c36b254102e2c1cc5dafc4572746079d
    Reviewed-on: https://dart-review.googlesource.com/43100
    Commit-Queue: Erik Ernst <eernst@google.com>
    Reviewed-by: Leaf Petersen <leafp@google.com>
    

    Changed files

    • docs/language/informal/instantiate-to-bound.md

16. [vm] Support definition of entry-points via @pragma('vm.extern') annotations.

    Changed by	Samir Jindel - sjindelohnoyoudont@google.com
    Changed at	Monday, 28-May-18 15:13:55 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	3e50ea32b5e8ddee3c24c7f1f0fe41e9c929cd4b

    Comments

    [vm] Support definition of entry-points via @pragma('vm.extern') annotations.
    
    The `@pragma` annotations are evaluated by the constants transformation and
    visible to TFA and the precompiler, which match on the "options" field of the
    annotation to determine whether to mark the class/procedure as a root.
    
    This required enabling the transformation of annotation constants by default.
    
    # Test Plan
    
    The "vmservice_io.main" entry-point is removed from `main.cc` and annotated with
    `@pragma`. All precompiler tests will crash if "vmservice_io.main" is not
    available at runtime.
    
    Debug/release precompiler bots are visible in "cl-linux" button.
    
    Change-Id: I03c5d6ba7918672ed9905fcaee8dabe675a93a5d
    Reviewed-on: https://dart-review.googlesource.com/56660
    Commit-Queue: Samir Jindel <sjindel@google.com>
    Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
    

    Changed files

    • pkg/kernel/binary.md
    • pkg/kernel/lib/core_types.dart
    • pkg/vm/lib/kernel_front_end.dart
    • pkg/vm/lib/transformations/type_flow/analysis.dart
    • pkg/vm/lib/transformations/type_flow/native_code.dart
    • pkg/vm/lib/transformations/type_flow/transformer.dart
    • runtime/bin/main.cc
    • runtime/bin/vmservice/vmservice_io.dart
    • runtime/vm/compiler/aot/precompiler.cc
    • runtime/vm/compiler/aot/precompiler.h
    • runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc
    • runtime/vm/kernel_loader.cc
    • runtime/vm/kernel_loader.h
    • runtime/vm/object.cc
    • runtime/vm/object.h
    • runtime/vm/object_store.cc
    • runtime/vm/object_store.h
    • runtime/vm/parser.cc
    • runtime/vm/parser.h
    • runtime/vm/symbols.h

17. Revert "Mark normal classes that were originally mixin applications"

    Changed by	Kevin Millikin - kmillikinohnoyoudont@google.com
    Changed at	Monday, 28-May-18 12:05:46 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	e2597dfba7dd985897451891ad1025793682e1d1

    Comments

    Revert "Mark normal classes that were originally mixin applications"
    
    This reverts commit 53cd0b4af1f0b456f2999ca806668a5af5b16da3.
    
    The commit causes failures in the VM's precompiler because its mixin
    deduplication transformation apparently needs to distinguish between
    anonymous and named mixins.
    
    Change-Id: I3861a3bf90b10f627d5fc8f0e94f117c102422d7
    Reviewed-on: https://dart-review.googlesource.com/56780
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    Commit-Queue: Kevin Millikin <kmillikin@google.com>
    

    Changed files

    • pkg/kernel/binary.md
    • pkg/kernel/lib/transformations/mixin_full_resolution.dart

18. [infra] Add support for app_jitk compiler to test.py (#33126)

    Changed by	Alexander Thomas - athomohnoyoudont@google.com
    Changed at	Monday, 28-May-18 11:54:56 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	d28c5499fc0e0800ab1c979f0d94c50c3676f30f

    Comments

    [infra] Add support for app_jitk compiler to test.py (#33126)
    
    * Add app_jitk configuration to test matrix.
    * Skip it on non-Dart 2 test suites.
    
    Change-Id: I05f75dbbd33d34a4acf4df1fe63104933d39d2fe
    Reviewed-on: https://dart-review.googlesource.com/56113
    Commit-Queue: Alexander Thomas <athom@google.com>
    Reviewed-by: Martin Kustermann <kustermann@google.com>
    

    Changed files

    • tests/co19/co19-kernel.status
    • tests/corelib/corelib.status
    • tests/language/language_kernel.status
    • tests/lib/lib.status
    • tests/standalone/standalone.status
    • tools/bots/test_matrix.json
    • tools/testing/dart/compiler_configuration.dart
    • tools/testing/dart/configuration.dart
    • tools/testing/dart/options.dart

19. Add example to docs/language/informal/super-bounded-types.md.

    Changed by	Erik Ernst - eernstohnoyoudont@google.com
    Changed at	Monday, 28-May-18 10:12:34 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	640791c92288a29f8cfff68d9643cb0218190574

    Comments

    Add example to docs/language/informal/super-bounded-types.md.
    
    This CL adds an example to super-bounded-types.md in order to motivate
    the definition of what it means for a parameterized type based on a
    type alias to be super-bounded. The definition says that we must check
    the actual type arguments relative to the formal type parameter
    list of the given `typedef` as well as the right hand side, replacing
    the formals by the given actual type arguments. The example shows that
    the right hand side can be ill-bounded even though the check that we
    apply based on the formal type parameter bounds (that is, the check
    that we apply to class types) succeeds.
    
    A rendered version of super-bounded-types.md corresponding to patchset
    6 is available here:
    https://gist.github.com/eernstg/fc12eeb23064a2578a936b443461dde4.
    
    Change-Id: I33dc6ced592f53160bc6f933558bfface46cd329
    Reviewed-on: https://dart-review.googlesource.com/56668
    Commit-Queue: Erik Ernst <eernst@google.com>
    Reviewed-by: Leaf Petersen <leafp@google.com>
    

    Changed files

    • docs/language/informal/super-bounded-types.md

20. Mark normal classes that were originally mixin applications

    Changed by	Kevin Millikin - kmillikinohnoyoudont@google.com
    Changed at	Monday, 28-May-18 09:17:34 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	53cd0b4af1f0b456f2999ca806668a5af5b16da3

    Comments

    Mark normal classes that were originally mixin applications
    
    To implement dart:mirrors correctly, a backend like the VM needs to
    know that a class was originally a mixin application.  Use the
    `isSyntheticMixinImplementation` flag which was already there and
    ignored by the VM.
    
    Now the property is:
    
    - if `isSyntheticMixinImplementation` is set on a class with a
      mixed-in type, then it was originally an anonymous mixin application
    
    - if `isSyntheticMixinImplementation` is set on a normal class then it
      was originally a mixin application of some kind and the mixed-in
      type can be found as the last impelemented type
    
    Bug: https://github.com/dart-lang/sdk/issues/33240
    Change-Id: I004adc6bfe08e583efba8e511076a6c603c0c687
    Reviewed-on: https://dart-review.googlesource.com/56760
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    Commit-Queue: Kevin Millikin <kmillikin@google.com>
    

    Changed files

    • pkg/kernel/binary.md
    • pkg/kernel/lib/transformations/mixin_full_resolution.dart

21. Share non-generic signatures through init.types

    Changed by	Johnni Winther - johnniwintherohnoyoudont@google.com
    Changed at	Monday, 28-May-18 07:40:24 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	6b7f3d5f54d16751e612650867a7d08aa479af82

    Comments

    Share non-generic signatures through init.types
    
    Change-Id: Ie132bbe805780022c91e5578c8dc4636c3c4cc8b
    Reviewed-on: https://dart-review.googlesource.com/56671
    Commit-Queue: Johnni Winther <johnniwinther@google.com>
    Reviewed-by: Stephen Adams <sra@google.com>
    

    Changed files

    • pkg/compiler/lib/src/common_elements.dart
    • pkg/compiler/lib/src/js_backend/backend_impact.dart
    • pkg/compiler/lib/src/js_backend/codegen_listener.dart
    • pkg/compiler/lib/src/js_backend/runtime_types.dart
    • pkg/compiler/lib/src/js_emitter/instantiation_stub_generator.dart
    • pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart
    • sdk/lib/_internal/js_runtime/lib/js_helper.dart
    • sdk/lib/_internal/js_runtime/lib/js_rti.dart
    • tests/compiler/dart2js_extra/deferred_function_types1_test.dart
    • tests/compiler/dart2js_extra/deferred_function_types2_test.dart
    • tests/compiler/dart2js_extra/deferred_function_types3_test.dart
    • tests/compiler/dart2js_extra/deferred_function_types4_test.dart
    • tests/compiler/dart2js_extra/deferred_function_types5_test.dart
    • tests/compiler/dart2js_extra/deferred_function_types6_test.dart
    • tests/compiler/dart2js_extra/deferred_function_types7_test.dart
    • tests/compiler/dart2js_extra/deferred_function_types8_test.dart
    • tests/compiler/dart2js_extra/deferred_function_types_lib1.dart
    • tests/compiler/dart2js_extra/deferred_function_types_lib2.dart
    • tests/corelib_2/corelib_2.status
    • tests/language_2/language_2_dart2js.status

22. Add a recovery test

    Changed by	Brian Wilkerson - brianwilkersonohnoyoudont@google.com
    Changed at	Saturday, 26-May-18 14:42:52 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	b79e06630c1ab7a3eeef28af0009a790c739da8c

    Comments

    Add a recovery test
    
    Change-Id: Ib74d61b9999ad6640afbd64b9753d76d09eee44f
    Reviewed-on: https://dart-review.googlesource.com/56711
    Reviewed-by: Dan Rubel <danrubel@google.com>
    Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analyzer/test/src/fasta/recovery/missing_code_test.dart

23. Revert "Clone annotations when cloning nodes that have them"

    Changed by	Alexander Aprelev - aamohnoyoudont@google.com
    Changed at	Saturday, 26-May-18 03:16:14 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	f981f097602ca434ce0a36b1f704723cad105fb6

    Comments

    Revert "Clone annotations when cloning nodes that have them"
    
    This reverts commit 75a75263d35d998834ebccb319f18ab7e4877e5d as it breaks Flutter
    
    Bug: https://github.com/dart-lang/sdk/issues/33242
    Change-Id: I825b0da4757f1ff9a318f8203605761d61d25e01
    Reviewed-on: https://dart-review.googlesource.com/56722
    Reviewed-by: Todd Volkert <tvolkert@google.com>
    Commit-Queue: Alexander Aprelev <aam@google.com>
    

    Changed files

    • pkg/front_end/testcases/bug33099.dart
    • pkg/front_end/testcases/bug33099.dart.direct.expect
    • pkg/front_end/testcases/bug33099.dart.direct.transformed.expect
    • pkg/front_end/testcases/bug33099.dart.outline.expect
    • pkg/front_end/testcases/bug33099.dart.strong.expect
    • pkg/front_end/testcases/bug33099.dart.strong.transformed.expect
    • pkg/kernel/lib/clone.dart

24. Improve type parameter and type argument recovery

    Changed by	danrubel - danrubelohnoyoudont@google.com
    Changed at	Saturday, 26-May-18 02:25:53 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	b4699ae795f6920248ca48ed82cb5e97c91e08f5

    Comments

    Improve type parameter and type argument recovery
    
    This improves recovery when parsing type arguments in
    * top level fields and functions
    * class members
    
    and when parsing type parameters in
    * top level functions
    * class declaration
    * class methods
    
    Change-Id: I7dbb520d6bb39c0d13b27698658dafe580f2b16c
    Reviewed-on: https://dart-review.googlesource.com/56681
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Dan Rubel <danrubel@google.com>
    

    Changed files

    • pkg/analyzer/test/generated/parser_forest_test.dart
    • pkg/analyzer/test/generated/parser_test.dart
    • pkg/analyzer/test/src/fasta/recovery/paired_tokens_test.dart
    • pkg/front_end/lib/src/fasta/parser/parser.dart
    • pkg/front_end/lib/src/fasta/parser/token_stream_rewriter.dart
    • pkg/front_end/lib/src/fasta/parser/type_info.dart
    • pkg/front_end/lib/src/fasta/parser/type_info_impl.dart
    • pkg/front_end/lib/src/fasta/parser/util.dart
    • pkg/front_end/test/fasta/parser/type_info_test.dart

25. Remove the no-op rewriter tests

    Changed by	danrubel - danrubelohnoyoudont@google.com
    Changed at	Saturday, 26-May-18 02:25:53 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	544863fe688872726696a3d1700ca1a42b2fb7f1

    Comments

    Remove the no-op rewriter tests
    
    Change-Id: I416ee350e1e7346493a3c4df3616f11d3b637d7c
    Reviewed-on: https://dart-review.googlesource.com/56680
    Reviewed-by: Peter von der Ahé <ahe@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/front_end/test/fasta/parser/type_info_test.dart

26. [VM Bigint] Fix arm64 intrinsic for _estimateQuotientDigit (loop missing jump back).

    Changed by	Régis Crelier - regisohnoyoudont@google.com
    Changed at	Saturday, 26-May-18 01:19:03 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	4d271519a18adcb06b11842ec3f6e3c1b576b531

    Comments

    [VM Bigint] Fix arm64 intrinsic for _estimateQuotientDigit (loop missing jump back).
    Add regression test.
    Fix arm64 disassembler (was printing "unknow" instructions).
    Make decoding stricter in arm64 simulator.
    This fix addresses https://github.com/a14n/dart-rational/issues/19
    
    Change-Id: I1b2ccb4bd560b588d0c4860c904cc398fba9014f
    Reviewed-on: https://dart-review.googlesource.com/56740
    Reviewed-by: Siva Annamalai <asiva@google.com>
    Commit-Queue: Régis Crelier <regis@google.com>
    

    Changed files

    • runtime/vm/compiler/assembler/disassembler_arm64.cc
    • runtime/vm/compiler/intrinsifier_arm64.cc
    • runtime/vm/constants_arm64.h
    • runtime/vm/simulator_arm64.cc
    • tests/corelib_2/bigint_test.dart

27. [fuchsia] Update for port API change

    Changed by	Adam Barth - abarthohnoyoudont@google.com
    Changed at	Friday, 25-May-18 19:43:15 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	57d256377c7ec99ada943cd2c8e5855557ea2405

    Comments

    [fuchsia] Update for port API change
    
    zx_port_wait and zx_port_queue no longer take an unused count parameter.
    
    Change-Id: I62f03871282d076638c51527603473252821d316
    Reviewed-on: https://dart-review.googlesource.com/56705
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Adam Barth <abarth@google.com>
    

    Changed files

    • runtime/bin/eventhandler_fuchsia.cc
    • runtime/bin/process_fuchsia.cc

28. Observatory strong mode fixes: add explicit downcasts to button onClick callbacks.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Friday, 25-May-18 19:38:13 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	c09e0121f78f2122e3afc64256aea945b887be91

    Comments

    Observatory strong mode fixes: add explicit downcasts to button onClick callbacks.
    
    Since the downcast is explicit (using "as") the type will be checked
    even in unchecked mode, so technically there is a slight risk of
    breakage.  But since the callback is so near the creation of the
    ButtonElement, I'm not concerned.  Also, I'm not concerned about the
    performance penalty of the explicit downcast because the cost is only
    paid once per user click.
    
    Change-Id: I64fbb442985f6ba6f745f665b36a3321498025e4
    Reviewed-on: https://dart-review.googlesource.com/56704
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Paul Berry <paulberry@google.com>
    

    Changed files

    • runtime/observatory/lib/src/elements/class_view.dart

29. Observatory strong mode fix: Avoid a String/Uri type mismatch.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Friday, 25-May-18 19:30:18 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	a5bf688622d4597e1cf1bd765a767c4045e157dd

    Comments

    Observatory strong mode fix: Avoid a String/Uri type mismatch.
    
    Change-Id: Ie4871b7467bd00e594f7df397909690461fe358a
    Reviewed-on: https://dart-review.googlesource.com/56702
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Paul Berry <paulberry@google.com>
    

    Changed files

    • runtime/observatory/lib/src/elements/script_inset.dart

30. Observatory strong mode fix: Add VM.target getter.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Friday, 25-May-18 19:30:08 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	1b0c2f45073b530255763e15707db1aa2de873b5

    Comments

    Observatory strong mode fix: Add VM.target getter.
    
    This allows code to access a VM object's target without having to
    downcast it to a more specific type.
    
    Change-Id: I42f329e205c2da0137be2440f0d3088a7137bc55
    Reviewed-on: https://dart-review.googlesource.com/56703
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Paul Berry <paulberry@google.com>
    

    Changed files

    • runtime/observatory/lib/service.dart
    • runtime/observatory/lib/src/service/object.dart

31. Observatory strong mode fix: Fix a callback parameter type using an explicit downcast.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Friday, 25-May-18 19:22:13 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	210d175cc04235dba79bb19964e4c9eb4419dd8f

    Comments

    Observatory strong mode fix: Fix a callback parameter type using an explicit downcast.
    
    For brevity we explicitly downcast the parameter type (using "as")
    rather than implicitly downcasting it (by assigning to a fresh
    variable).  Since this is test code, I'm not concerned about the
    performance penalty of the explicit downcast.
    
    Change-Id: I2bf1556ec11db124978c6631df8fcdd5adbc298d
    Reviewed-on: https://dart-review.googlesource.com/56701
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Paul Berry <paulberry@google.com>
    

    Changed files

    • runtime/observatory/tests/observatory_ui/allocation_profile/element_test.dart

32. Observatory strong mode fixes: specify some list literal types.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Friday, 25-May-18 19:22:03 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	08d0dcb4b038acb73a3fb44e258a36c688f60b7c

    Comments

    Observatory strong mode fixes: specify some list literal types.
    
    In some cases we need to specify a type because the inferred type
    would be too specific.  For example, in the code:
    
        final content = [new SampleBufferControlElement(...)];
        ...
        content.addAll([new BRElement(), ...]);
    
    Strong mode would infer a type of `List<SampleBufferControlElement>`
    for `content`, making it impossible to add other kinds of HTML
    elements to the list later.  So we have to specify explicitly that the
    list element type is meant to be `HTMLElement`.
    
    In other cases we need to specify a type because the inferred type is
    too general.  For example, in the code:
    
        Future<List<String>> complete(...) {
          var result = [];
          ...add values of type String to `result`...
          return new Future.value(result);
        }
    
    Strong mode would infer a type of `List<dynamic>` for `result`, making
    it impossible to enclose in a `Future<List<String>>`.  So we have to
    specify explicitly that the list element type is meant to be `String`.
    
    Change-Id: I1b1c884529de2775898dfff800d250cd10629811
    Reviewed-on: https://dart-review.googlesource.com/56700
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Paul Berry <paulberry@google.com>
    

    Changed files

    • runtime/observatory/lib/src/elements/class_allocation_profile.dart
    • runtime/observatory/lib/src/elements/context_ref.dart
    • runtime/observatory/lib/src/elements/debugger.dart
    • runtime/observatory/lib/src/elements/heap_snapshot.dart
    • runtime/observatory/lib/src/elements/script_inset.dart
    • runtime/observatory/tests/observatory_ui/flag_list/element_test.dart

33. Observatory strong mode fixes: Change types of InstanceMock/Instance members.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Friday, 25-May-18 19:02:03 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	462e350a6aa6cda0db625a4d45652dba957c860f

    Comments

    Observatory strong mode fixes: Change types of InstanceMock/Instance members.
    
    The types now correspond in the two classes, so we avoid invalid
    override errors.
    
    Change-Id: Iceeb324e6adf7573ae39d7250184f7eb58656498
    Reviewed-on: https://dart-review.googlesource.com/56021
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Paul Berry <paulberry@google.com>
    

    Changed files

    • runtime/observatory/lib/src/models/objects/instance.dart
    • runtime/observatory/tests/observatory_ui/mocks/objects/instance.dart

34. Added feature specification for upper/lower bounds of top/bottom types

    Changed by	Erik Ernst - eernstohnoyoudont@google.com
    Changed at	Friday, 25-May-18 16:05:20 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	6ed3b162d66a3f261ba3f5bc8ce430fefcbef4a0

    Comments

    Added feature specification for upper/lower bounds of top/bottom types
    
    A rendered version can be found here, and it was updated to match
    patch set 12:
    https://gist.github.com/eernstg/df0d69c85724e1179835a43bf9e63adc
    
    The issue where this topic was raised is
    https://github.com/dart-lang/sdk/issues/28513.
    
    Change-Id: I21e4df42348a51f482c42d1c29595e475823e5dc
    Reviewed-on: https://dart-review.googlesource.com/53211
    Commit-Queue: Erik Ernst <eernst@google.com>
    Reviewed-by: Leaf Petersen <leafp@google.com>
    

    Changed files

    • docs/language/informal/extreme-upper-lower-bounds.md

35. Make BodyBuilder.handleCatchBlock use FormalParameters as catchParameters.

    Changed by	Brian Wilkerson - brianwilkersonohnoyoudont@google.com
    Changed at	Friday, 25-May-18 15:41:03 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	abed87be085830f998644947e1c4fced9fa47a8c

    Comments

    Make BodyBuilder.handleCatchBlock use FormalParameters as catchParameters.
    
    Change-Id: Ib3523faa2a7fa122e56ecef5b9ed6c42a1a8b90d
    Reviewed-on: https://dart-review.googlesource.com/56604
    Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
    Reviewed-by: Dan Rubel <danrubel@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/fasta/ast_building_factory.dart
    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/fangorn.dart
    • pkg/front_end/lib/src/fasta/kernel/forest.dart

36. [fasta] Make lists of type arguments growable

    Changed by	Dmitry Stefantsov - dmitryasohnoyoudont@google.com
    Changed at	Friday, 25-May-18 13:38:32 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	5016f11c08b494cfe923816903292b2551564179

    Comments

    [fasta] Make lists of type arguments growable
    
    Change-Id: I0a5bc5da093ad1fecdba4fc1ec8b9325f72b021a
    Reviewed-on: https://dart-review.googlesource.com/56666
    Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
    Reviewed-by: Peter von der Ahé <ahe@google.com>
    

    Changed files

    • pkg/front_end/lib/src/fasta/dill/dill_class_builder.dart
    • pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart

37. Make Forest.forStatement take the conditionStatement rather than extracting the rightSeparator

    Changed by	Brian Wilkerson - brianwilkersonohnoyoudont@google.com
    Changed at	Friday, 25-May-18 13:34:13 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	48e8b4cdbbf8a83a7a65fc59f5e51d1f86be387c

    Comments

    Make Forest.forStatement take the conditionStatement rather than extracting the rightSeparator
    
    Change-Id: I4fc8abddfc04cdde018480d7a078c46d3241b80d
    Reviewed-on: https://dart-review.googlesource.com/56602
    Reviewed-by: Dan Rubel <danrubel@google.com>
    Reviewed-by: Peter von der Ahé <ahe@google.com>
    Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/fasta/ast_building_factory.dart
    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/fangorn.dart
    • pkg/front_end/lib/src/fasta/kernel/forest.dart

38. Observatory strong mode fixes: fix several type annotations.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Friday, 25-May-18 12:42:11 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	2d527801b2ebc81fdd085657779b605ab09c1eee

    Comments

    Observatory strong mode fixes: fix several type annotations.
    
    Change-Id: I647480f1f03be1d182afe98f6aa22c43a937aba3
    Reviewed-on: https://dart-review.googlesource.com/56028
    Commit-Queue: Paul Berry <paulberry@google.com>
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    

    Changed files

    • runtime/observatory/lib/src/allocation_profile/allocation_profile.dart
    • runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart
    • runtime/observatory/lib/src/elements/eval_box.dart
    • runtime/observatory/lib/src/service/object.dart

39. Observatory strong mode fixes: Fix callback parameter types using implicit casts.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Friday, 25-May-18 12:32:01 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	0125a5a23503ea479c2d57bb88be34d05e67184c

    Comments

    Observatory strong mode fixes: Fix callback parameter types using implicit casts.
    
    Change-Id: I0ee40677e13f82ca94238b98dcb50188063f9260
    Reviewed-on: https://dart-review.googlesource.com/56026
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Paul Berry <paulberry@google.com>
    

    Changed files

    • runtime/observatory/lib/src/elements/debugger.dart
    • runtime/observatory/lib/src/elements/script_inset.dart

40. Observatory strong mode fixes: Fix an int/double type mismatch

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Friday, 25-May-18 12:17:21 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	c85b2fc7be120966fd90a2ac8fc781ad2660e72c

    Comments

    Observatory strong mode fixes: Fix an int/double type mismatch
    
    Change-Id: I78cfc41dc328a40ba7650a492235d51663132130
    Reviewed-on: https://dart-review.googlesource.com/56027
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Paul Berry <paulberry@google.com>
    

    Changed files

    • runtime/observatory/lib/src/elements/heap_map.dart

41. Observatory strong mode fixes: make iteration types more specific.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Friday, 25-May-18 12:15:41 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	3fb22040cb9298c36a519dacef240f0355371406

    Comments

    Observatory strong mode fixes: make iteration types more specific.
    
    Change-Id: I8031625bd676aadb0bf20e3b2642f0b7e84af747
    Reviewed-on: https://dart-review.googlesource.com/56025
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Paul Berry <paulberry@google.com>
    

    Changed files

    • runtime/observatory/lib/src/elements/debugger.dart
    • runtime/observatory/lib/src/elements/script_inset.dart

42. Observatory strong mode fixes: safe uses of dynamic and covariant.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Friday, 25-May-18 11:54:20 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	2165d2d797adf288dda422863bd9103c0faff9ae

    Comments

    Observatory strong mode fixes: safe uses of dynamic and covariant.
    
    This CL makes the following changes, which should be safe since they
    don't affect Dart 1.0 semantics:
    
    - Explicitly declare the types of certain variables as `dynamic` to
      avoid strong mode inferring a type that leads to errors.
    
    - Explicitly cast certain expressions to `dynamic` to allow access to
      members that are dynamically known to be present.
    
    - Add `covariant` annotation to method parameters that are a subtype
      of the corresponding parameter in the base class.
    
    Change-Id: Ibefe4d9591f70ea954373ca4d521bc54179cca9b
    Reviewed-on: https://dart-review.googlesource.com/55900
    Commit-Queue: Paul Berry <paulberry@google.com>
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    

    Changed files

    • runtime/observatory/lib/src/elements/debugger.dart
    • runtime/observatory/lib/src/elements/script_inset.dart
    • runtime/observatory/lib/src/repositories/allocation_profile.dart
    • runtime/observatory/lib/src/repositories/sample_profile.dart
    • runtime/observatory/tests/observatory_ui/mocks/repositories/sample_profile.dart
    • runtime/observatory/tests/service/add_breakpoint_rpc_test.dart
    • runtime/observatory/tests/service/service_kernel.status

43. Use bottom type for Link constants

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Friday, 25-May-18 10:37:36 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	6a34939ba7f437ea87bc76b779567dabeb2650be

    Comments

    Use bottom type for Link constants
    
    This should make the Link implementation work in strong mode.
    
    We may find situations where Link<Null> leaks out, but I believe those should
    be fixed by passing explicitly typed tail arguments.
    
    Change-Id: I4c48769569f22e987ace586f5ec9264d75b49982
    Reviewed-on: https://dart-review.googlesource.com/56663
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
    

    Changed files

    • pkg/front_end/lib/src/fasta/util/link.dart
    • pkg/front_end/lib/src/fasta/util/link_implementation.dart
    • pkg/front_end/test/fasta/link_test.dart

44. Move ErroneousExpressionGenerator

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Friday, 25-May-18 07:45:46 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	20831b1d6f3e9e72b690ed302f58eea4c228d5aa

    Comments

    Move ErroneousExpressionGenerator
    
    This prepares for splitting its subclasses so they can
    be implemented by the analyzer.
    
    Change-Id: I0fb59b56a6d34e86e909e6ecf68a9cdf57de44d6
    Reviewed-on: https://dart-review.googlesource.com/56495
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    

    Changed files

    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator_impl.dart

45. Split LargeIntAccessGenerator

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Friday, 25-May-18 07:45:46 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	8e25851870536b89431c2c3dea1e370624a919bd

    Comments

    Split LargeIntAccessGenerator
    
    This prepares the generator to be implemented by the analyzer.
    
    Change-Id: Ida249f93ad0b80bb52bb3278a1e2949c668b0e64
    Reviewed-on: https://dart-review.googlesource.com/56493
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/fasta/ast_building_factory.dart
    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/fangorn.dart
    • pkg/front_end/lib/src/fasta/kernel/forest.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator_impl.dart
    • pkg/front_end/test/fasta/generator_to_string_test.dart

46. Observatory strong mode fixes: add implicit downcasts.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Friday, 25-May-18 05:20:25 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	7b3c3991eab436ff64a4ce0f1197d62bd124b096

    Comments

    Observatory strong mode fixes: add implicit downcasts.
    
    Change-Id: I17d10ec4c69f9d3fa1cda3ec11df3e96749ade29
    Reviewed-on: https://dart-review.googlesource.com/56022
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Paul Berry <paulberry@google.com>
    

    Changed files

    • runtime/observatory/lib/src/app/location_manager.dart
    • runtime/observatory/lib/src/elements/debugger.dart
    • runtime/observatory/lib/src/elements/script_inset.dart

47. Discover available files before searching in known files.

    Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
    Changed at	Friday, 25-May-18 01:24:35 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	de0e35829dfddb88a5bc31a2527fdaacd5069c95

    Comments

    Discover available files before searching in known files.
    
    Known files are only used for seaching top-level declarations.
    But we already get something for user from it - we can give Quick Fix
    for imports, even if the package to import is not used yet in the project.
    
    R=brianwilkerson@google.com
    
    Change-Id: Iaa6d7ad515325b1bad3e37e7c066c42df056c85c
    Reviewed-on: https://dart-review.googlesource.com/56623
    Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/dart/analysis/driver.dart
    • pkg/analyzer/test/src/dart/analysis/base.dart
    • pkg/analyzer/test/src/dart/analysis/driver_test.dart

48. Observatory strong mode fixes: make callback parameter types more general.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 23:07:55 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	d17859ca116cade68c69b1d580f5612ec162a648

    Comments

    Observatory strong mode fixes: make callback parameter types more general.
    
    This CL addresses a code pattern where a method expects its parameter
    to have a certain type, but that method is torn off and passed as a
    callback to another method expecting its parameter type to be more
    general.  For example:
    
        void f(int i) { ... }
        void g(void callback(Object o)) { ... }
        void h() {
          g(f); // Error: () -> int is not a subtype of () -> Object
        }
    
    This is a strong mode error because the type system cannot guarantee
    that the value pased to f will be an int.  The solution is to broaden
    the type of the callback parameter so that it matches the type
    expected for the callback.  In most cases, we insert an implicit
    downcast (by reassigning the parameter to a local variable with the
    expected type), which in Dart 2.0 semantics will result in a runtime
    check (similar to what happens in Dart 1.0 checked mode).
    
    Since the downcasts are implicit, the Dart 1.0 semantics are
    unchanged, so this should be a safe change.
    
    Change-Id: I9583ea194343b89b39305c9796cfad299a47943f
    Reviewed-on: https://dart-review.googlesource.com/55907
    Commit-Queue: Paul Berry <paulberry@google.com>
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    

    Changed files

    • runtime/observatory/bin/shell.dart
    • runtime/observatory/lib/src/app/application.dart
    • runtime/observatory/lib/src/app/page.dart
    • runtime/observatory/lib/src/elements/allocation_profile.dart
    • runtime/observatory/lib/src/elements/class_tree.dart
    • runtime/observatory/lib/src/elements/containers/virtual_collection.dart
    • runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart
    • runtime/observatory/lib/src/elements/cpu_profile_table.dart
    • runtime/observatory/lib/src/elements/heap_map.dart
    • runtime/observatory/lib/src/elements/heap_snapshot.dart
    • runtime/observatory/lib/src/elements/memory/allocations.dart
    • runtime/observatory/lib/src/elements/memory/snapshot.dart
    • runtime/observatory/lib/utils.dart

49. Follow up on initial fix-all fixes PR, https://dart-review.googlesource.com/c/sdk/+/56220, adding some assertions and a test.

    Changed by	Jaime Wren - jwrenohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 22:29:45 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	ca7d545df8a26c6c4514cda96d0168c41edb934a

    Comments

    Follow up on initial fix-all fixes PR, https://dart-review.googlesource.com/c/sdk/+/56220, adding some assertions and a test.
    
    Change-Id: I6e22f8537f616ce2d09247f90bb81fff17eb1b66
    Reviewed-on: https://dart-review.googlesource.com/56601
    Commit-Queue: Jaime Wren <jwren@google.com>
    Reviewed-by: Jaime Wren <jwren@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analysis_server/lib/plugin/edit/fix/fix_core.dart
    • pkg/analysis_server/test/services/correction/fix_test.dart

50. [VM] Fix for issue 32901 - Isolate.resolvePackageUri has inconsistent behavior when called from a script launched via relative path.

    Changed by	asiva - asivaohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 22:08:40 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	922f9697a021d4cfaecc49ebe4aa3f8a2f5a3720

    Comments

    [VM] Fix for issue 32901 - Isolate.resolvePackageUri has inconsistent behavior when called from a script launched via relative path.
    
    Change-Id: I6ea0868936ff972def1f66c94509f7afed7c4c87
    Reviewed-on: https://dart-review.googlesource.com/56622
    Reviewed-by: Ben Konyi <bkonyi@google.com>
    Commit-Queue: Siva Annamalai <asiva@google.com>
    

    Changed files

    • runtime/bin/main.cc

51. [vm] Roll boringssl to 189270cd190267f5bd60cfe8f8ce7a61d07ba6f4

    Changed by	Zach Anderson - zraohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 22:04:30 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	9c70462e3c65da7615b1224e62fe543c17c4ca6f

    Comments

    [vm] Roll boringssl to 189270cd190267f5bd60cfe8f8ce7a61d07ba6f4
    
    fixes #33229
    
    Change-Id: I786c2f48108a3e00b3b3ef2ae8a68ddaac256fda
    Reviewed-on: https://dart-review.googlesource.com/56628
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Zach Anderson <zra@google.com>
    

    Changed files

    • DEPS
    • build/toolchain/gcc_toolchain.gni
    • build/toolchain/mac/BUILD.gn
    • build/toolchain/win/BUILD.gn

52. Last changes to make dart2js strong mode clean when compiling itself!

    Changed by	Emily Fortuna - efortunaohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 22:00:35 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	785f36853ff0e6cd6d605471fb3aa82a1df1ffd4

    Comments

    Last changes to make dart2js strong mode clean when compiling itself!
    
    Change-Id: I43b6869cc5dccb2b2d0f41133402225e0f55e433
    Reviewed-on: https://dart-review.googlesource.com/56626
    Commit-Queue: Stephen Adams <sra@google.com>
    Reviewed-by: Stephen Adams <sra@google.com>
    

    Changed files

    • pkg/compiler/lib/src/inferrer/builder_kernel.dart
    • pkg/compiler/lib/src/util/maplet.dart

53. Make the change to ContextRoot non-breaking.

    Changed by	Paul Berry - paulberryohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 21:56:25 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	993b4caf0e0b7f094ef5bb2ce91152e8c0e1468e

    Comments

    Make the change to ContextRoot non-breaking.
    
    In 4cf51e6c1afd4d7863e1c0572a74a44b5269b106, a new argument was added
    to the ContextRoot constructor, changing its signature in a breaking
    way.
    
    In theory this should not have broken other packages, because
    ContextRoot is declared inside analyzer/lib/src.  But it turns out
    that two packages are known to import from analyzer/lib/src and
    construct ContextRoot: angular_analyzer_plugin and
    built_value_generator.  To avoid breaking these packages, we need to
    add the new constructor parameter as an optional (named) parameter.
    
    Some time after after angular_analyzer_plugin and
    built_value_generator have been updated, I'll send a later CL to mark
    the named parameter as @required.
    
    Change-Id: I5be063dd47a3dfefba08cb444687b91bf2ba3625
    Reviewed-on: https://dart-review.googlesource.com/56603
    Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
    Commit-Queue: Paul Berry <paulberry@google.com>
    

    Changed files

    • pkg/analysis_server/lib/src/context_manager.dart
    • pkg/analysis_server/test/abstract_context.dart
    • pkg/analysis_server/test/src/plugin/plugin_manager_test.dart
    • pkg/analysis_server/test/src/plugin/plugin_watcher_test.dart
    • pkg/analyzer/lib/src/context/context_root.dart
    • pkg/analyzer/lib/src/dart/analysis/context_builder.dart
    • pkg/analyzer/lib/src/dart/analysis/context_locator.dart
    • pkg/analyzer/test/src/context/builder_test.dart

54. Set DDK to run on Dart-2 VM

    Changed by	Vijay Menon - vsmohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 21:51:25 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	30ad3f66cef65f8aa37ac38faa0ab30b17b1001f

    Comments

    Set DDK to run on Dart-2 VM
    
    Change-Id: I0c0558996c5d6d6c739ded5e5c8b2554a4cd7b04
    Reviewed-on: https://dart-review.googlesource.com/53320
    Reviewed-by: Jenny Messerly <jmesserly@google.com>
    Commit-Queue: Vijay Menon <vsm@google.com>
    

    Changed files

    • pkg/build_integration/lib/file_system/multi_root.dart
    • pkg/dev_compiler/lib/src/kernel/compiler.dart
    • pkg/dev_compiler/tool/ddb
    • sdk/bin/dartdevk
    • sdk/bin/dartdevk.bat
    • sdk/bin/dartdevk_sdk
    • sdk/bin/dartdevk_sdk.bat
    • utils/dartdevc/BUILD.gn

55. Convert remaining IdentifierContext consts

    Changed by	danrubel - danrubelohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 21:45:05 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	379232a09778af058dbe9fa2ce324fd4f90a7139

    Comments

    Convert remaining IdentifierContext consts
    
    This CL converts the remaining IdentifierContext constants
    and removed now unused code from the parser.
    
    Change-Id: I3c5add811e0e5a3af082c31bc42abda62a164307
    Reviewed-on: https://dart-review.googlesource.com/56541
    Commit-Queue: Dan Rubel <danrubel@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analyzer/test/src/fasta/recovery/paired_tokens_test.dart
    • pkg/analyzer/test/src/fasta/recovery/partial_code/try_statement_test.dart
    • pkg/analyzer/test/src/fasta/recovery/partial_code/while_statement_test.dart
    • pkg/front_end/lib/src/fasta/parser/identifier_context.dart
    • pkg/front_end/lib/src/fasta/parser/identifier_context_impl.dart
    • pkg/front_end/lib/src/fasta/parser/parser.dart

56. Issue 33228. Fix Dart2 error in outline computer.

    Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 21:36:32 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	819b2123184854ded394d49bec5be0f98acaa817

    Comments

    Issue 33228. Fix Dart2 error in outline computer.
    
    R=brianwilkerson@google.com
    
    Bug: https://github.com/dart-lang/sdk/issues/33228
    Change-Id: Ifa328eee5cbc398ada9cfee0a582f169b140434e
    Reviewed-on: https://dart-review.googlesource.com/56625
    Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analysis_server/lib/src/computer/computer_outline.dart
    • pkg/analysis_server/test/src/computer/outline_computer_test.dart

57. [vm] Fix feature detection of DBC32 versus DBC64 in snapshots with code.

    Changed by	Ryan Macnak - rmacnakohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 21:26:45 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	ec19ebd6844c94aa3876587b92eeb58568a1b895

    Comments

    [vm] Fix feature detection of DBC32 versus DBC64 in snapshots with code.
    
    At a minimium, the image portion of the snapshot is sensitive to word size.
    
    Change-Id: I1056a726c7b773f3ef65608f3244aaa01a366ec4
    Reviewed-on: https://dart-review.googlesource.com/56023
    Reviewed-by: Siva Annamalai <asiva@google.com>
    Commit-Queue: Ryan Macnak <rmacnak@google.com>
    

    Changed files

    • runtime/vm/dart.cc

58. More changes to make dart2js dart 2 strong mode clean.

    Changed by	Emily Fortuna - efortunaohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 20:50:51 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	00a51975424ac4ff73fdf04888fe073601010307

    Comments

    More changes to make dart2js dart 2 strong mode clean.
    
    Change-Id: I796ac4b71ca9b91ec43ac72a02127ed87872f954
    Reviewed-on: https://dart-review.googlesource.com/56460
    Reviewed-by: Sigmund Cherem <sigmund@google.com>
    Reviewed-by: Stephen Adams <sra@google.com>
    

    Changed files

    • pkg/compiler/lib/src/inferrer/builder_kernel.dart
    • pkg/compiler/lib/src/js_backend/namer.dart
    • pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
    • pkg/compiler/lib/src/source_file_provider.dart
    • pkg/compiler/lib/src/ssa/codegen.dart
    • pkg/compiler/lib/src/ssa/nodes.dart
    • pkg/compiler/lib/src/ssa/variable_allocator.dart
    • pkg/compiler/lib/src/util/setlet.dart
    • pkg/js_ast/lib/src/builder.dart

59. CHANGELOG for invariant generic bounds

    Changed by	Leaf Petersen - leafpohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 20:23:42 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	2d8bf7751e0547fb1f6099d405646af3b430ace3

    Comments

    CHANGELOG for invariant generic bounds
    
    Change-Id: If7dcc07b9fb68e149814e8de42bbf6d9d0425a62
    Reviewed-on: https://dart-review.googlesource.com/56621
    Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
    

    Changed files

    • CHANGELOG.md

60. Revert "[mirrors] Add IsolateMirror.loadUri."

    Changed by	Ryan Macnak - rmacnakohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 20:03:40 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	de545b4079fdb4c031bb486ab5b0180a1a22f6bd

    Comments

    Revert "[mirrors] Add IsolateMirror.loadUri."
    
    This reverts commit ad4cfa0260f67f963f3db3cd7b5761258f27d114.
    
    Reason for revert: Assertion failures on DBC
    
    Original change's description:
    > [mirrors] Add IsolateMirror.loadUri.
    > 
    > This allows a programmer to dynamically load code into an isolate. The closest existing API is Isolate.spawnUri, but communication with the dynamically loaded code in that case is limited to asynchronous message passing of JSON-like objects.
    > 
    > Change-Id: Icb23e9dacfb0035622c119f11d4e0f892ba2ccd1
    > Reviewed-on: https://dart-review.googlesource.com/45363
    > Reviewed-by: Zach Anderson <zra@google.com>
    
    TBR=rmacnak@google.com,zra@google.com,asiva@google.com,kmillikin@google.com
    
    Change-Id: I80669188b9f40b3b527e8e268ade0d0d514a8753
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://dart-review.googlesource.com/56640
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    Commit-Queue: Ryan Macnak <rmacnak@google.com>
    

    Changed files

    • CHANGELOG.md
    • runtime/bin/loader.cc
    • runtime/include/dart_api.h
    • runtime/lib/mirrors.cc
    • runtime/lib/mirrors_impl.dart
    • runtime/vm/bootstrap_natives.h
    • runtime/vm/dart_api_impl.cc
    • sdk/lib/mirrors/mirrors.dart
    • tests/lib_2/mirrors/dynamic_load_error.dart
    • tests/lib_2/mirrors/dynamic_load_success.dart
    • tests/lib_2/mirrors/dynamic_load_test.dart

61. [ VM ] Addressed additional comments from CL 56461.

    Changed by	Ben Konyi - bkonyiohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 20:01:51 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	1be13871bb70bda3ae456cc269297766eb47444d

    Comments

    [ VM ] Addressed additional comments from CL 56461.
    
    Change-Id: I396a4e1038ccc7ae4f504d817ee6790aeb8d2003
    Reviewed-on: https://dart-review.googlesource.com/56620
    Reviewed-by: Zach Anderson <zra@google.com>
    Commit-Queue: Ben Konyi <bkonyi@google.com>
    

    Changed files

    • runtime/bin/directory.cc
    • runtime/bin/utils.h
    • runtime/bin/utils_android.cc
    • runtime/bin/utils_fuchsia.cc
    • runtime/bin/utils_linux.cc
    • runtime/bin/utils_macos.cc
    • runtime/bin/utils_win.cc

62. [vm/frontend-server] Include errors count into compile expression response.

    Changed by	Alexander Aprelev - aamohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 18:16:16 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	5cc373664454934ccb6a076912095c8493e5c907

    Comments

    [vm/frontend-server] Include errors count into compile expression response.
    
    Change-Id: Ifc42ff221eb5a0d95f7ed0f29f410ab18740b0e6
    Reviewed-on: https://dart-review.googlesource.com/56140
    Reviewed-by: Siva Annamalai <asiva@google.com>
    Commit-Queue: Alexander Aprelev <aam@google.com>
    

    Changed files

    • pkg/vm/lib/frontend_server.dart
    • pkg/vm/test/frontend_server_test.dart

63. Fix status file for analyzer.

    Changed by	Mike Fairhurst - mfairhurstohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 17:38:58 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	891efdca599ca5da5c993350fde64d04e0a2c16e

    Comments

    Fix status file for analyzer.
    
    It seems like the "missing" analysis error is a strong mode error, so I
    don't think the error should even appear without strong mode turned on?
    
    In any case, a "missing" error for non strong users is not something I
    would expect to be blocking. Better to fix the build
    
    Change-Id: I5f56b5847b655b501e8146200ab4b84fddbf21cc
    Reviewed-on: https://dart-review.googlesource.com/56600
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • tests/language_2/language_2_analyzer.status

64. [mirrors] Add IsolateMirror.loadUri.

    Changed by	Ryan Macnak - rmacnakohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 17:07:15 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	ad4cfa0260f67f963f3db3cd7b5761258f27d114

    Comments

    [mirrors] Add IsolateMirror.loadUri.
    
    This allows a programmer to dynamically load code into an isolate. The closest existing API is Isolate.spawnUri, but communication with the dynamically loaded code in that case is limited to asynchronous message passing of JSON-like objects.
    
    Change-Id: Icb23e9dacfb0035622c119f11d4e0f892ba2ccd1
    Reviewed-on: https://dart-review.googlesource.com/45363
    Reviewed-by: Zach Anderson <zra@google.com>
    

    Changed files

    • CHANGELOG.md
    • runtime/bin/loader.cc
    • runtime/include/dart_api.h
    • runtime/lib/mirrors.cc
    • runtime/lib/mirrors_impl.dart
    • runtime/vm/bootstrap_natives.h
    • runtime/vm/dart_api_impl.cc
    • sdk/lib/mirrors/mirrors.dart
    • tests/lib_2/mirrors/dynamic_load_error.dart
    • tests/lib_2/mirrors/dynamic_load_success.dart
    • tests/lib_2/mirrors/dynamic_load_test.dart

65. Bump to watcher 0.9.7+8.

    Changed by	Konstantin Shcheglov - scheglovohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 17:05:36 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	a64bbbf6b300f7eb1644ad9a664603027fbc263f

    Comments

    Bump to watcher 0.9.7+8.
    
    Change-Id: If1705ac18715876fc5c1325dab4c3dda42b8d2b9
    Reviewed-on: https://dart-review.googlesource.com/56580
    Reviewed-by: Kevin Moore <kevmoo@google.com>
    Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
    

    Changed files

    • DEPS

66. [vm/tool] Teach precompiler2 script to build ELF binaries.

    Changed by	Vyacheslav Egorov - vegorovohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 16:56:58 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	eb19be5ff84bd916b1e68ede93a4bb8dae31e9b4

    Comments

    [vm/tool] Teach precompiler2 script to build ELF binaries.
    
    Usage: pkg/vm/tool/precompiler2 --build-elf a.dart liba.so
    
    Change-Id: I06f673453c8fc6f103c0ccc345b8586edaf6d1a0
    Reviewed-on: https://dart-review.googlesource.com/56503
    Reviewed-by: Alexander Markov <alexmarkov@google.com>
    Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
    

    Changed files

    • pkg/vm/tool/precompiler2

67. [vm] Mark superclasses of interfaces implemented.

    Changed by	Vyacheslav Egorov - vegorovohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 16:35:13 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	7c43cfad9fdf2a6e121d93558ab3e9302eea378a

    Comments

    [vm] Mark superclasses of interfaces implemented.
    
    Previously we would only mark immediate superinterfaces
    as implemented which is not enough.
    
    Bug: b/80154489
    Change-Id: I0751d4326b1ac8930b7fdfb35e0c3fdd5d0b71dd
    Reviewed-on: https://dart-review.googlesource.com/56485
    Reviewed-by: Martin Kustermann <kustermann@google.com>
    Reviewed-by: Régis Crelier <regis@google.com>
    Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
    

    Changed files

    • runtime/vm/class_finalizer.cc
    • tests/language_2/vm/regress_b80154489_test.dart

68. [ VM ] Updated include path for typed_data_utils.h which was causing Flutter build to fail.

    Changed by	Ben Konyi - bkonyiohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 16:15:03 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	2f7874ab99ac12d69e28b48d4e458b1936d0c3f6

    Comments

    [ VM ] Updated include path for typed_data_utils.h which was causing Flutter build to fail.
    
    Change-Id: Id70533ec5237579719cfc061fab93bd659c20b1f
    Reviewed-on: https://dart-review.googlesource.com/56560
    Commit-Queue: Ben Konyi <bkonyi@google.com>
    Reviewed-by: Zach Anderson <zra@google.com>
    

    Changed files

    • runtime/bin/typed_data_utils.cc

69. [vm/kernel/aot] Approximate numerous invocations per selector in TFA

    Changed by	Alexander Markov - alexmarkovohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 16:13:22 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	3c6907ed0d28ed6f214c13738e6279785a25a72a

    Comments

    [vm/kernel/aot] Approximate numerous invocations per selector in TFA
    
    This change adds tracking of number of invocations with the same
    selector but different arguments. If this number reaches certain limit,
    all subsequent invocations with such selector are approximated.
    
    On Flutter gallery, 1 selector is approximated:
      dart.core::Object::==
    
    On Analyzer, 2 selectors are approximated:
    
      analyzer.dart.ast.ast::AstNode::visitChildren
      dart.core::List::[]=
    
    Flutter gallery Total(CodeSize): +11 K.
    
    Fixes https://github.com/dart-lang/sdk/issues/33199
    
    Change-Id: I3598555194262a4f08fe1bc207d10880a25eb432
    Reviewed-on: https://dart-review.googlesource.com/56420
    Reviewed-by: Martin Kustermann <kustermann@google.com>
    Commit-Queue: Alexander Markov <alexmarkov@google.com>
    

    Changed files

    • pkg/vm/lib/transformations/type_flow/analysis.dart
    • pkg/vm/lib/transformations/type_flow/utils.dart

70. Clone annotations when cloning nodes that have them

    Changed by	Kevin Millikin - kmillikinohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 15:59:54 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	75a75263d35d998834ebccb319f18ab7e4877e5d

    Comments

    Clone annotations when cloning nodes that have them
    
    Annotations were not cloned.
    
    Fixes https://github.com/dart-lang/sdk/issues/33099
    
    Change-Id: I2d2b2153be9efcf1be4b39815eb8ac15b7cacd38
    Reviewed-on: https://dart-review.googlesource.com/56494
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    Commit-Queue: Kevin Millikin <kmillikin@google.com>
    

    Changed files

    • pkg/front_end/testcases/bug33099.dart
    • pkg/front_end/testcases/bug33099.dart.direct.expect
    • pkg/front_end/testcases/bug33099.dart.direct.transformed.expect
    • pkg/front_end/testcases/bug33099.dart.outline.expect
    • pkg/front_end/testcases/bug33099.dart.strong.expect
    • pkg/front_end/testcases/bug33099.dart.strong.transformed.expect
    • pkg/kernel/lib/clone.dart

71. Report errors on non-synthetic tokens

    Changed by	Dan Rubel - danrubelohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 15:54:32 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	d3da30c152ef5e3e8ed99b81965554d28b9c6af7

    Comments

    Report errors on non-synthetic tokens
    
    This updates fasta parser error reporting to find a non-synthetic token
    on which to report an error. In addition, this addresses a comment in
    https://dart-review.googlesource.com/c/sdk/+/56041
    
    Change-Id: Id3415529a7b8635273221c7c2f3d36e1695a9ece
    Reviewed-on: https://dart-review.googlesource.com/56540
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Dan Rubel <danrubel@google.com>
    

    Changed files

    • pkg/analyzer/test/generated/parser_test.dart
    • pkg/analyzer/test/src/fasta/recovery/partial_code/part_of_directive_test.dart
    • pkg/front_end/lib/src/fasta/parser/parser.dart
    • pkg/front_end/lib/src/fasta/parser/util.dart

72. Initial new union of Dart Analysis Fixes, the initial fix is to remove all unused imports in a file.

    Changed by	Jaime Wren - jwrenohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 15:23:40 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	351d70674d2b9cb18c7109c9e234869ef47c3487

    Comments

    Initial new union of Dart Analysis Fixes, the initial fix is to remove all unused imports in a file.
    
    Change-Id: I259e796b2603234955a1950b2c886e6f08a697bc
    Reviewed-on: https://dart-review.googlesource.com/56220
    Commit-Queue: Jaime Wren <jwren@google.com>
    Reviewed-by: Jaime Wren <jwren@google.com>
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    

    Changed files

    • pkg/analysis_server/lib/plugin/edit/fix/fix_core.dart
    • pkg/analysis_server/lib/src/edit/edit_domain.dart
    • pkg/analysis_server/lib/src/services/correction/fix.dart
    • pkg/analysis_server/lib/src/services/correction/fix_internal.dart
    • pkg/analysis_server/test/services/correction/fix_test.dart
    • pkg/analyzer_plugin/lib/utilities/fixes/fixes.dart

73. Adjusted setter conflict specification, cf. #33077

    Changed by	Erik Ernst - eernstohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 13:54:09 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	e8bb129816f75f6e0b38f7fbff32e3b3d919027c

    Comments

    Adjusted setter conflict specification, cf. #33077
    
    Change-Id: I76b709a3ef4b7c542f83912b0bdeddb1bbf34448
    Reviewed-on: https://dart-review.googlesource.com/54410
    Commit-Queue: Erik Ernst <eernst@google.com>
    Reviewed-by: Leaf Petersen <leafp@google.com>
    Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
    

    Changed files

    • docs/language/dartLangSpec.tex

74. Fix a bug in the async transformation of let expressions

    Changed by	Kevin Millikin - kmillikinohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 13:16:09 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	0a042a270f5cd4f3ab7787cfe64934526f42f717

    Comments

    Fix a bug in the async transformation of let expressions
    
    The transformation worked as if there was never an await "to the
    right" of the body of a let expression (i.e., an expression evaluated
    after the let expression's body but before the value of the let
    expression's body is used).  This is obviously not right.
    
    Fixes https://github.com/dart-lang/sdk/issues/33206
    
    Change-Id: Idc175dc8c65f3d520de8b65f2285164d361ff38e
    Reviewed-on: https://dart-review.googlesource.com/56492
    Commit-Queue: Kevin Millikin <kmillikin@google.com>
    Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
    

    Changed files

    • pkg/front_end/testcases/bug33206.dart
    • pkg/front_end/testcases/bug33206.dart.direct.expect
    • pkg/front_end/testcases/bug33206.dart.direct.transformed.expect
    • pkg/front_end/testcases/bug33206.dart.outline.expect
    • pkg/front_end/testcases/bug33206.dart.strong.expect
    • pkg/front_end/testcases/bug33206.dart.strong.transformed.expect
    • pkg/kernel/lib/transformations/async.dart

75. [vm/kernel] Only create zone handles when necessary (e.g. in IR instructions, LocalVariable).

    Changed by	Samir Jindel - sjindelohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 13:14:29 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	6fc0c1fa4fbe369d79b31d8b7b3446470296c319

    Comments

    [vm/kernel] Only create zone handles when necessary (e.g. in IR instructions, LocalVariable).
    
    Summary:
    
    When evaluating constants for direct inspection (and not for injection into the
    FG), we store many intermediate values in ZoneHandles. This leaks memory, since
    the only need for ZoneHandles is preserving constants which are referenced by
    the FG.
    
    Test Plan:
    
    Existing coverage is sufficient since no functionality is changed.
    
    Change-Id: I33951eab762a4ad626f07ebf11118247c5a9ad3e
    Reviewed-on: https://dart-review.googlesource.com/56345
    Commit-Queue: Samir Jindel <sjindel@google.com>
    Reviewed-by: Martin Kustermann <kustermann@google.com>
    

    Changed files

    • runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc
    • runtime/vm/compiler/frontend/kernel_binary_flowgraph.h

76. Updated for expected FF failure.

    Changed by	Terry Lucas - terryohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 12:45:48 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	735f7bdcec530056fa4a8cb6754c3917f950a114

    Comments

    Updated for expected FF failure.
    
    TBR=sra@google.com
    
    Change-Id: I6eff83c4dd8f4e77a372fa5e17d0bce37c061ea4
    Reviewed-on: https://dart-review.googlesource.com/56465
    Reviewed-by: Terry Lucas <terry@google.com>
    

    Changed files

    • tests/lib_2/lib_2_dart2js.status

77. [vm/kernel] Fix partial instantiation implementation in StreamingConstantEvaluator.

    Changed by	Samir Jindel - sjindelohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 12:20:42 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	02bcbc12fa237e3157ab660a94d00650e557514e

    Comments

    [vm/kernel] Fix partial instantiation implementation in StreamingConstantEvaluator.
    
    # Summary
    
    As part of commit 772c9bb5f, we changed the representation of partially
    instantiated closures to facilitate partial instantiation of local functions.
    The compile-time constant evaluator was not updated -- this revision implements
    that update.
    
    Fixes task 33211.
    
    # Test Plan
    
    Updated `partial_tearoff_instantiation_test.dart` to test the case which caused
    incorrect behavior in task 33211.
    
    Change-Id: I7bbd4fb83a5aea86ffc85c1d9952f1202f098d6b
    Reviewed-on: https://dart-review.googlesource.com/56346
    Reviewed-by: Régis Crelier <regis@google.com>
    Commit-Queue: Samir Jindel <sjindel@google.com>
    

    Changed files

    • runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc
    • tests/language_2/partial_tearoff_instantiation_test.dart

78. Split ReadOnlyAccessGenerator

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 11:35:02 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	8d4a1ccaf6d34458ddf08f30500eadfe6715086c

    Comments

    Split ReadOnlyAccessGenerator
    
    This prepares the generator to be implemented by the analyzer.
    
    Change-Id: Idccd5af9aac79300186b3a07c636bb580bdd637c
    Reviewed-on: https://dart-review.googlesource.com/56491
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/fasta/ast_building_factory.dart
    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/fangorn.dart
    • pkg/front_end/lib/src/fasta/kernel/forest.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator_impl.dart
    • pkg/front_end/test/fasta/generator_to_string_test.dart

79. Split TypeUseGenerator

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 11:35:02 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	ee9e1c15719c392e845eeefca8f882f1da3ad819

    Comments

    Split TypeUseGenerator
    
    This prepares the generator to be implemented by the analyzer.
    
    Change-Id: I89bf0ca368308e98846c8ea8b7c765398c48ecf7
    Reviewed-on: https://dart-review.googlesource.com/56490
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/fasta/ast_building_factory.dart
    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/fangorn.dart
    • pkg/front_end/lib/src/fasta/kernel/forest.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator_impl.dart
    • pkg/front_end/test/fasta/generator_to_string_test.dart

80. Split DeferredAccessGenerator

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 11:35:02 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	9ec756b31c7b15f726dddd1d9b7c0573a9ecf5cc

    Comments

    Split DeferredAccessGenerator
    
    This prepares the generator to be implemented by the analyzer.
    
    Change-Id: I40a91e6455128fedac871eb2691197333e2cba15
    Reviewed-on: https://dart-review.googlesource.com/56489
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/fasta/ast_building_factory.dart
    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/fangorn.dart
    • pkg/front_end/lib/src/fasta/kernel/forest.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator_impl.dart
    • pkg/front_end/test/fasta/generator_to_string_test.dart

81. Split LoadLibraryGenerator

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 11:35:02 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	163807ad4065c6f2bc12e01485589fa6f3116bad

    Comments

    Split LoadLibraryGenerator
    
    This prepares the generator to be implemented by the analyzer.
    
    Change-Id: Id6e3f3935ce4bd4989b544c251b0e859f256eb19
    Reviewed-on: https://dart-review.googlesource.com/56486
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/fasta/ast_building_factory.dart
    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/fangorn.dart
    • pkg/front_end/lib/src/fasta/kernel/forest.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator_impl.dart
    • pkg/front_end/test/fasta/generator_to_string_test.dart

82. Correctly transform async functions with FutureOr return types

    Changed by	Kevin Millikin - kmillikinohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 10:54:03 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	51fa5c16628bd1789daba3f5546e43440db8c18f

    Comments

    Correctly transform async functions with FutureOr return types
    
    The async transformer did not allocate a completer with the correct
    type in the case for async functions with a FutureOr return type.
    
    Fixes https://github.com/dart-lang/sdk/issues/33196
    
    Change-Id: I72654f24576295e38e8d79dff30aae5c90cb2564
    Reviewed-on: https://dart-review.googlesource.com/56488
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    Commit-Queue: Kevin Millikin <kmillikin@google.com>
    

    Changed files

    • pkg/front_end/testcases/bug33196.dart
    • pkg/front_end/testcases/bug33196.dart.direct.expect
    • pkg/front_end/testcases/bug33196.dart.direct.transformed.expect
    • pkg/front_end/testcases/bug33196.dart.outline.expect
    • pkg/front_end/testcases/bug33196.dart.strong.expect
    • pkg/front_end/testcases/bug33196.dart.strong.transformed.expect
    • pkg/kernel/lib/transformations/continuation.dart

83. [vm/kernel] Move kernel2kenrel "constants" transformation before TFA

    Changed by	Martin Kustermann - kustermannohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 10:53:42 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	bca70073ae025a74e78a7d6f408f168b30a58c5f

    Comments

    [vm/kernel] Move kernel2kenrel "constants" transformation before TFA
    
    Change-Id: Iffa9cea655a0b731c2784a172096d450571eaf1c
    Reviewed-on: https://dart-review.googlesource.com/53220
    Commit-Queue: Martin Kustermann <kustermann@google.com>
    Reviewed-by: Alexander Markov <alexmarkov@google.com>
    

    Changed files

    • pkg/vm/lib/kernel_front_end.dart
    • pkg/vm/lib/transformations/type_flow/analysis.dart
    • pkg/vm/lib/transformations/type_flow/native_code.dart
    • pkg/vm/lib/transformations/type_flow/summary_collector.dart
    • pkg/vm/lib/transformations/type_flow/transformer.dart

84. Split StaticAccessGenerator

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 10:16:11 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	1d8a72cacdf1307f301254ca9fa66e7038597aa0

    Comments

    Split StaticAccessGenerator
    
    This prepares the generator to be implemented by the analyzer.
    
    Change-Id: I99a1e1365da67a867f6c4ed5883649f157306d92
    Reviewed-on: https://dart-review.googlesource.com/56502
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/fasta/ast_building_factory.dart
    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/fangorn.dart
    • pkg/front_end/lib/src/fasta/kernel/forest.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator_impl.dart
    • pkg/front_end/test/fasta/generator_to_string_test.dart

85. Fix Dart 2 runtime errors in the front end

    Changed by	Kevin Millikin - kmillikinohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 10:14:20 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	2d46ebd6a5c5d826ccaa6a34b00ce8564bedeaa5

    Comments

    Fix Dart 2 runtime errors in the front end
    
    Fix all the Dart 2 runtime errors revealed by compiling dart2js, the
    front end itself, the front end tests.
    
    Change-Id: Ic6e6dd9f85db845b6a351ebbcfea9a6045843fc2
    Reviewed-on: https://dart-review.googlesource.com/56322
    Commit-Queue: Kevin Millikin <kmillikin@google.com>
    Reviewed-by: Aske Simon Christensen <askesc@google.com>
    Reviewed-by: Peter von der Ahé <ahe@google.com>
    

    Changed files

    • pkg/analyzer/tool/summary/mini_ast.dart
    • pkg/front_end/lib/src/base/libraries_specification.dart
    • pkg/front_end/lib/src/fasta/builder/library_builder.dart
    • pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
    • pkg/front_end/lib/src/fasta/source/diet_listener.dart
    • pkg/front_end/lib/src/fasta/source/outline_builder.dart
    • pkg/front_end/lib/src/fasta/source/stack_listener.dart
    • pkg/front_end/test/fasta/testing/analyzer_diet_listener.dart
    • pkg/front_end/test/fasta/testing/suite.dart
    • pkg/kernel/lib/clone.dart
    • pkg/testing/lib/src/analyze.dart
    • pkg/testing/lib/src/chain.dart
    • pkg/testing/lib/src/error_handling.dart
    • pkg/testing/lib/src/expectation.dart
    • pkg/testing/lib/src/run.dart
    • pkg/testing/lib/src/run_tests.dart
    • pkg/testing/lib/src/test_dart.dart
    • pkg/testing/lib/src/test_dart/status_file_parser.dart
    • pkg/testing/lib/src/test_root.dart

86. Cleanup library_loader.

    Changed by	Johnni Winther - johnniwintherohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 09:52:50 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	89514bd8cf72a377016b4f3c52c3dab4be1880a6

    Comments

    Cleanup library_loader.
    
    Change-Id: I0255580cd9292bcd3a5997c7d97d83b25d888372
    Reviewed-on: https://dart-review.googlesource.com/55960
    Commit-Queue: Johnni Winther <johnniwinther@google.com>
    Reviewed-by: Sigmund Cherem <sigmund@google.com>
    

    Changed files

    • pkg/compiler/lib/src/compiler.dart
    • pkg/compiler/lib/src/enqueue.dart
    • pkg/compiler/lib/src/library_loader.dart
    • tests/compiler/dart2js/inference/data/field_type.dart
    • tests/compiler/dart2js/inference/data/general.dart

87. Remove unused typedef code

    Changed by	Johnni Winther - johnniwintherohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 09:52:50 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	21b65a97328a038f64d18f9e84105e152944fd0e

    Comments

    Remove unused typedef code
    
    We only use the name of typedef type literals. These are passed through
    TypeConstantExpression to TypeConstantValue and used directly as the
    nominal identity (!) of the emitted typedef type literal constant value.
    
    Note that the emitted typedef type literal has no relation to its alias.
    
    Change-Id: I1cdc5a88a9b3d75faa0786ecd07226b5075df1c4
    Reviewed-on: https://dart-review.googlesource.com/55898
    Reviewed-by: Sigmund Cherem <sigmund@google.com>
    

    Changed files

    • pkg/compiler/lib/src/common_elements.dart
    • pkg/compiler/lib/src/dump_info.dart
    • pkg/compiler/lib/src/elements/types.dart
    • pkg/compiler/lib/src/enqueue.dart
    • pkg/compiler/lib/src/js_backend/js_interop_analysis.dart
    • pkg/compiler/lib/src/js_model/elements.dart
    • pkg/compiler/lib/src/js_model/js_strategy.dart
    • pkg/compiler/lib/src/kernel/element_map_impl.dart
    • pkg/compiler/lib/src/universe/resolution_world_builder.dart
    • pkg/compiler/lib/src/world.dart

88. Split deferred load entity computation by class, member and local function

    Changed by	Johnni Winther - johnniwintherohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 09:52:50 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	18407141b7a2a36cdde58430ea4ba8f9008e27d9

    Comments

    Split deferred load entity computation by class, member and local function
    
    Change-Id: Ifb612de6ac945d2ececa96871f0eb3fc5ceb4052
    Reviewed-on: https://dart-review.googlesource.com/55896
    Reviewed-by: Sigmund Cherem <sigmund@google.com>
    

    Changed files

    • pkg/compiler/lib/src/deferred_load.dart
    • pkg/compiler/lib/src/dump_info.dart
    • pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart
    • pkg/compiler/lib/src/js_model/js_strategy.dart
    • pkg/compiler/lib/src/kernel/deferred_load.dart
    • pkg/compiler/lib/src/ssa/builder_kernel.dart
    • tests/compiler/dart2js/deferred/custom_element_test.dart
    • tests/compiler/dart2js/deferred/dont_inline_deferred_constants_test.dart
    • tests/compiler/dart2js/deferred/dont_inline_deferred_globals_test.dart
    • tests/compiler/dart2js/deferred/follow_implicit_super_regression_test.dart
    • tests/compiler/dart2js/deferred/inline_restrictions_test.dart
    • tests/compiler/dart2js/deferred/load_graph_segmentation2_test.dart
    • tests/compiler/dart2js/deferred/load_graph_segmentation_test.dart
    • tests/compiler/dart2js/deferred/not_in_main_test.dart
    • tests/compiler/dart2js/deferred_loading/deferred_loading_test.dart

89. [VM] Mark seemingly consistently failing test on windows

    Changed by	Martin Kustermann - kustermannohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 09:17:27 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	b84f18e3929688256b533e0cff065683533524f6

    Comments

    [VM] Mark seemingly consistently failing test on windows
    
    Issue https://github.com/dart-lang/sdk/issues/33224
    
    Change-Id: If9437c7791efd23dd98ad41cf3cf16173046cdaf
    Reviewed-on: https://dart-review.googlesource.com/56501
    Reviewed-by: Martin Kustermann <kustermann@google.com>
    

    Changed files

    • runtime/tests/vm/vm.status

90. Add explicit type args on generators

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 08:55:52 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	d07b9aa0e07a0480074e7c26c06db477edf620d8

    Comments

    Add explicit type args on generators
    
    Change-Id: Ia1e4c42b888d9302e23a7e832044b2f59f8c0a8f
    Reviewed-on: https://dart-review.googlesource.com/56483
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    

    Changed files

    • pkg/front_end/lib/src/fasta/kernel/body_builder.dart
    • pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator_impl.dart
    • pkg/front_end/test/fasta/generator_to_string_test.dart

91. Split SuperIndexedAccessGenerator

    Changed by	Peter von der Ahé - aheohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 08:27:59 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	b3862d5a9228cf19d4fb3a918f20d69dc9f6fabd

    Comments

    Split SuperIndexedAccessGenerator
    
    This prepares the generator to be implemented by the analyzer.
    
    Change-Id: Ia962668e1327b53af968be9efdc41ea6b124b4d0
    Reviewed-on: https://dart-review.googlesource.com/56482
    Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/fasta/ast_building_factory.dart
    • pkg/front_end/lib/src/fasta/kernel/expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/fangorn.dart
    • pkg/front_end/lib/src/fasta/kernel/forest.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
    • pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator_impl.dart
    • pkg/front_end/test/fasta/generator_to_string_test.dart

92. Avoid late creation of entities.

    Changed by	Johnni Winther - johnniwintherohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 08:01:00 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	0ec82e24ce1c34151d2113244dae6f5de78ec346

    Comments

    Avoid late creation of entities.
    
    This changes has been reviewed as part of https://dart-review.googlesource.com/c/sdk/+/55898
    
    Change-Id: I28d41110919a592499ee7b5b7605728638bd5ea2
    Reviewed-on: https://dart-review.googlesource.com/56481
    Reviewed-by: Johnni Winther <johnniwinther@google.com>
    Commit-Queue: Johnni Winther <johnniwinther@google.com>
    

    Changed files

    • pkg/compiler/lib/src/compiler.dart
    • pkg/compiler/lib/src/kernel/element_map_impl.dart
    • tests/compiler/dart2js/model/strong_mode_closed_world_test.dart

93. Fix #29014, make function type parameters invariant.

    Changed by	Mike Fairhurst - mfairhurstohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 07:56:29 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	1d59ab22ce1cea2f4275c2ada14c51be5a9a6550

    Comments

    Fix #29014, make function type parameters invariant.
    
    With the restricted behavior, some tests have been removed, modified,
    and added based on the new invariance.
    
    Bug: 29014
    Change-Id: I086749bbe40aaa723009f9ae06f58d85554cae53
    Reviewed-on: https://dart-review.googlesource.com/56029
    Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
    Reviewed-by: Paul Berry <paulberry@google.com>
    

    Changed files

    • pkg/analyzer/lib/src/dart/element/type.dart
    • pkg/analyzer/lib/src/generated/resolver.dart
    • pkg/analyzer/lib/src/generated/type_system.dart
    • pkg/analyzer/test/generated/strong_mode_kernel_test.dart
    • pkg/analyzer/test/generated/strong_mode_test.dart
    • pkg/analyzer/test/generated/type_system_test.dart
    • tests/language_2/language_2_analyzer.status
    • tests/language_2/language_2_dartdevc.status

94. Use AbstractValue in ClosedWorld

    Changed by	Johnni Winther - johnniwintherohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 07:43:39 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	4d7bbb53ab5d89925e12f09534a363ea1c7d1d42

    Comments

    Use AbstractValue in ClosedWorld
    
    Change-Id: Ib091ec1f251f9d75f9dea5cc4879ab16c9af0215
    Reviewed-on: https://dart-review.googlesource.com/55961
    Reviewed-by: Sigmund Cherem <sigmund@google.com>
    Commit-Queue: Johnni Winther <johnniwinther@google.com>
    

    Changed files

    • pkg/compiler/lib/src/dump_info.dart
    • pkg/compiler/lib/src/types/abstract_value_domain.dart
    • pkg/compiler/lib/src/types/masks.dart
    • pkg/compiler/lib/src/types/type_mask.dart
    • pkg/compiler/lib/src/world.dart

95. Fix windows bot breakage for package:build tests.

    Changed by	Mike Fairhurst - mfairhurstohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 06:57:51 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	89f37416fecfe6eadbb928ad708b19b585acfb6b

    Comments

    Fix windows bot breakage for package:build tests.
    
    Change-Id: If7c049d0c4db396c8c7ae2fd05005538c1dd1933
    Reviewed-on: https://dart-review.googlesource.com/56293
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
    

    Changed files

    • pkg/analyzer/test/generated/package_build_test.dart

96. Deprecate chaseDependencies option.

    Changed by	Sigmund Cherem - sigmundohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 04:57:01 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	9b44fc39c86551a584baded931f3dce183592134

    Comments

    Deprecate chaseDependencies option.
    
    The option is not used by any client at this time and removing it simplifies the
    next stack of changes I'll be making on how we compose file systems.
    
    I also don't believe we will necessarily add this back as an option, but instead
    it might be that clients requriing hermeticity will provide a custom file system
    that helps with that.
    
    Change-Id: I401efb042920d234382b6c041b13d40ffae5c908
    Reviewed-on: https://dart-review.googlesource.com/56462
    Commit-Queue: Peter von der Ahé <ahe@google.com>
    Reviewed-by: Peter von der Ahé <ahe@google.com>
    

    Changed files

    • pkg/analyzer/test/src/fasta/body_builder_test_helper.dart
    • pkg/dev_compiler/tool/build_pkgs.dart
    • pkg/dev_compiler/tool/kernel_sdk.dart
    • pkg/front_end/lib/src/api_prototype/compiler_options.dart
    • pkg/front_end/lib/src/api_prototype/incremental_kernel_generator.dart
    • pkg/front_end/lib/src/api_prototype/kernel_generator.dart
    • pkg/front_end/lib/src/api_prototype/summary_generator.dart
    • pkg/front_end/lib/src/api_unstable/dart2js.dart
    • pkg/front_end/lib/src/api_unstable/ddc.dart
    • pkg/front_end/lib/src/api_unstable/summary_worker.dart
    • pkg/front_end/lib/src/base/processed_options.dart
    • pkg/front_end/lib/src/fasta/get_dependencies.dart
    • pkg/front_end/test/fasta/expression_test.dart
    • pkg/front_end/test/fasta/incremental_hello_test.dart
    • pkg/front_end/test/fasta/incremental_test.dart
    • pkg/front_end/test/incremental_load_from_dill_test.dart
    • pkg/front_end/test/kernel_generator_test.dart
    • pkg/front_end/test/src/base/processed_options_test.dart
    • pkg/front_end/test/src/incremental/kernel_driver_test.dart
    • pkg/front_end/test/summary_generator_test.dart
    • pkg/front_end/tool/_fasta/bulk_compile.dart
    • pkg/front_end/tool/_fasta/command_line.dart
    • pkg/front_end/tool/_fasta/entry_points.dart
    • pkg/front_end/tool/fasta_perf.dart
    • pkg/front_end/tool/incremental_perf.dart
    • pkg/vm/bin/kernel_service.dart
    • pkg/vm/lib/kernel_front_end.dart
    • tools/patch_sdk.dart

97. [ VM ] Fix failing non-UTF8 path test on MacOS

    Changed by	Ben Konyi - bkonyiohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 02:07:49 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	05f96af05a97da4c590956b2635dff17dddf4aaf

    Comments

    [ VM ] Fix failing non-UTF8 path test on MacOS
    
    Change-Id: Ieda3661b61b993b71d4bd703e576625a354d4774
    Reviewed-on: https://dart-review.googlesource.com/56463
    Reviewed-by: Ben Konyi <bkonyi@google.com>
    Commit-Queue: Ben Konyi <bkonyi@google.com>
    

    Changed files

    • tests/standalone_2/io/non_utf8_file_test.dart

98. [ VM ] Fixed issue where error code was being clobbered by call to Dart_TypedDataReleaseData on Windows, resulting in OSError returning a 0 error instead of the true error code.

    Changed by	Ben Konyi - bkonyiohnoyoudont@google.com
    Changed at	Thursday, 24-May-18 02:07:39 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	c541cda216193478938a83b7697926f284248abf

    Comments

    [ VM ] Fixed issue where error code was being clobbered by call to Dart_TypedDataReleaseData on Windows, resulting in OSError returning a 0 error instead of the true error code.
    
    Bug: 2
    Change-Id: I33e9319f57de73d9435936ddf853968834fb5a16
    Reviewed-on: https://dart-review.googlesource.com/56461
    Commit-Queue: Ben Konyi <bkonyi@google.com>
    Reviewed-by: Ryan Macnak <rmacnak@google.com>
    

    Changed files

    • runtime/bin/directory.cc
    • runtime/bin/file.cc
    • runtime/bin/utils.h
    • runtime/bin/utils_android.cc
    • runtime/bin/utils_fuchsia.cc
    • runtime/bin/utils_linux.cc
    • runtime/bin/utils_macos.cc
    • runtime/bin/utils_win.cc

99. Update test_parseAwaitExpression_inSync

    Changed by	Dan Rubel - danrubelohnoyoudont@google.com
    Changed at	Wednesday, 23-May-18 22:47:19 UTC
    Repository	https://dart.googlesource.com/sdk
    Branch
    Revision	a00dae22601daf16245a0119df5e2c8cddf09c14

    Comments

    Update test_parseAwaitExpression_inSync
    
    Change-Id: I62796cc9c76bdfa0cfb5afacdaa8a785a3db28e8
    Reviewed-on: https://dart-review.googlesource.com/56440
    Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
    Commit-Queue: Dan Rubel <danrubel@google.com>
    

    Changed files

    • pkg/analyzer/test/generated/parser_fasta_test.dart
    • pkg/analyzer/test/generated/parser_test.dart

100. Convert more identifier contexts

     Changed by	Dan Rubel - danrubelohnoyoudont@google.com
     Changed at	Wednesday, 23-May-18 21:58:35 UTC
     Repository	https://dart.googlesource.com/sdk
     Branch
     Revision	9cd0e808db2b9f2c4eb00fd7aecef9dcd63801a6

     Comments

     Convert more identifier contexts
     
     Change-Id: I0ead9e15da9d477b26deb13c6880dbfeea4d7724
     Reviewed-on: https://dart-review.googlesource.com/56401
     Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
     Commit-Queue: Dan Rubel <danrubel@google.com>
     

     Changed files

     • pkg/front_end/lib/src/fasta/parser/identifier_context.dart
     • pkg/front_end/lib/src/fasta/parser/identifier_context_impl.dart
     • pkg/front_end/lib/src/fasta/parser/parser.dart

101. <blame list capped at 100 commits>

     Changed by	<blame list capped at 100 commits> -
     Changed at	N/A
     Repository
     Branch
     Revision

     Comments

     <blame list capped at 100 commits>