Builder analyzer-mac-release-dev
Build 14
Results:
Success
Trigger Info:
Project | dart |
Revision | 805969260f4fa92129a68f41c736bfbf6cfec096 |
Got Revision | 805969260f4fa92129a68f41c736bfbf6cfec096 |
Execution:
- Source: Task 3e54d9278e5e9f10
- Bot: vm188-m4
Steps and Logfiles:
Show:-
- - no logs -
-
- - no logs -
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "vm188-m4" | setup_build |
branch | "refs/heads/dev" | setup_build |
buildbucket | {"build": {"bucket": "luci.dart.ci.sandbox", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1530015489166786, "id": "8942656194391043664", "project": "dart", "tags": ["builder:analyzer-mac-release-dev", "buildset:commit/git/805969260f4fa92129a68f41c736bfbf6cfec096", "buildset:commit/gitiles/dart.googlesource.com/sdk/+/805969260f4fa92129a68f41c736bfbf6cfec096", "gitiles_ref:refs/heads/dev", "scheduler_invocation_id:9108086257593256608", "scheduler_job_id:dart/analyzer-mac-release-dev", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "analyzer-mac-release-dev" | setup_build |
buildnumber | 14 | setup_build |
clobber | "true" | setup_build |
mastername | "client.dart" | setup_build |
path_config | "generic" | setup_build |
recipe | "dart/neo" | setup_build |
repository | "https://dart.googlesource.com/sdk/" | setup_build |
revision | "805969260f4fa92129a68f41c736bfbf6cfec096" | setup_build |
got_revision | "805969260f4fa92129a68f41c736bfbf6cfec096" | bot_update |
Blamelist:
- Jonas Termansen (sortieohnoyoudont@google.com)
- William Hesse (whesseohnoyoudont@google.com)
- Jens Johansen (jensjohnoyoudont@google.com)
- Alexander Thomas (athomohnoyoudont@google.com)
- Jens Johansen (jensjohnoyoudont@google.com)
- Alexander Thomas (athomohnoyoudont@google.com)
- Jens Johansen (jensjohnoyoudont@google.com)
- Jens Johansen (jensjohnoyoudont@google.com)
- Dmitry Stefantsov (dmitryasohnoyoudont@google.com)
- Johnni Winther (johnniwintherohnoyoudont@google.com)
- Jens Johansen (jensjohnoyoudont@google.com)
- Johnni Winther (johnniwintherohnoyoudont@google.com)
- Jens Johansen (jensjohnoyoudont@google.com)
- Stephen Adams (sraohnoyoudont@google.com)
- Stephen Adams (sraohnoyoudont@google.com)
- Alexander Aprelev (aamohnoyoudont@google.com)
- Kevin Moore (kevmooohnoyoudont@google.com)
- Alexander Aprelev (aamohnoyoudont@google.com)
- Sam Rawlins (srawlinsohnoyoudont@google.com)
- Konstantin Shcheglov (scheglovohnoyoudont@google.com)
- Stephen Adams (sraohnoyoudont@google.com)
- Ryan Macnak (rmacnakohnoyoudont@google.com)
- Zach Anderson (zraohnoyoudont@google.com)
- Jacob MacDonald (jakemacohnoyoudont@google.com)
- Paul Berry (paulberryohnoyoudont@google.com)
- Lasse R.H. Nielsen (lrnohnoyoudont@google.com)
- Terry Lucas (terryohnoyoudont@google.com)
- Mike Fairhurst (mfairhurstohnoyoudont@google.com)
- Dan Rubel (danrubelohnoyoudont@google.com)
- Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
- Terry Lucas (terryohnoyoudont@google.com)
- Mike Fairhurst (mfairhurstohnoyoudont@google.com)
- Paul Berry (paulberryohnoyoudont@google.com)
- Dan Rubel (danrubelohnoyoudont@google.com)
- Alexander Markov (alexmarkovohnoyoudont@google.com)
- Konstantin Shcheglov (scheglovohnoyoudont@google.com)
- Paul Berry (paulberryohnoyoudont@google.com)
- Devon Carew (devoncarewohnoyoudont@google.com)
- Paul Berry (paulberryohnoyoudont@google.com)
- Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
- Dan Rubel (danrubelohnoyoudont@google.com)
- Mike Fairhurst (mfairhurstohnoyoudont@google.com)
- Devon Carew (devoncarewohnoyoudont@google.com)
- Martin Kustermann (kustermannohnoyoudont@google.com)
- Erik Ernst (eernstohnoyoudont@google.com)
- Dmitry Stefantsov (dmitryasohnoyoudont@google.com)
- Vyacheslav Egorov (vegorovohnoyoudont@google.com)
- Martin Kustermann (kustermannohnoyoudont@google.com)
- Kevin Millikin (kmillikinohnoyoudont@google.com)
- Vyacheslav Egorov (vegorovohnoyoudont@google.com)
- Jens Johansen (jensjohnoyoudont@google.com)
- Jens Johansen (jensjohnoyoudont@google.com)
- Jens Johansen (jensjohnoyoudont@google.com)
- Vyacheslav Egorov (vegorovohnoyoudont@google.com)
- Vyacheslav Egorov (vegorovohnoyoudont@google.com)
- Petr Hosek (phosekohnoyoudont@google.com)
- Devon Carew (devoncarewohnoyoudont@google.com)
- Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
- Paul Berry (paulberryohnoyoudont@google.com)
- Devon Carew (devoncarewohnoyoudont@google.com)
- Nate Bosch (nboschohnoyoudont@google.com)
- Stephen Adams (sraohnoyoudont@google.com)
- Konstantin Shcheglov (scheglovohnoyoudont@google.com)
- Konstantin Shcheglov (scheglovohnoyoudont@google.com)
- Ben Konyi (bkonyiohnoyoudont@google.com)
- Johnni Winther (johnniwintherohnoyoudont@google.com)
- Zach Anderson (zraohnoyoudont@google.com)
- Konstantin Shcheglov (scheglovohnoyoudont@google.com)
- Stephen Adams (sraohnoyoudont@google.com)
- Konstantin Shcheglov (scheglovohnoyoudont@google.com)
- Konstantin Shcheglov (scheglovohnoyoudont@google.com)
- Johnni Winther (johnniwintherohnoyoudont@google.com)
- Johnni Winther (johnniwintherohnoyoudont@google.com)
- Konstantin Shcheglov (scheglovohnoyoudont@google.com)
- danrubel (danrubelohnoyoudont@google.com)
- Paul Berry (paulberryohnoyoudont@google.com)
- Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
- Konstantin Shcheglov (scheglovohnoyoudont@google.com)
- Sam Rawlins (srawlinsohnoyoudont@google.com)
- Sam Rawlins (srawlinsohnoyoudont@google.com)
- Sigmund Cherem (sigmundohnoyoudont@google.com)
- Paul Berry (paulberryohnoyoudont@google.com)
- Paul Berry (paulberryohnoyoudont@google.com)
- Janice Collins (jcollinsohnoyoudont@google.com)
- Alexander Markov (alexmarkovohnoyoudont@google.com)
- Régis Crelier (regisohnoyoudont@google.com)
- Kevin Moore (kevmooohnoyoudont@google.com)
- Devon Carew (devoncarewohnoyoudont@google.com)
- Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
- Alexander Markov (alexmarkovohnoyoudont@google.com)
- Brian Wilkerson (brianwilkersonohnoyoudont@google.com)
- Kevin Moore (kevmooohnoyoudont@google.com)
- Dmitry Stefantsov (dmitryasohnoyoudont@google.com)
- Dmitry Stefantsov (dmitryasohnoyoudont@google.com)
- Paul Berry (paulberryohnoyoudont@google.com)
- Lasse R.H. Nielsen (lrnohnoyoudont@google.com)
- William Hesse (whesseohnoyoudont@google.com)
- Paul Berry (paulberryohnoyoudont@google.com)
- Jens Johansen (jensjohnoyoudont@google.com)
- Johnni Winther (johnniwintherohnoyoudont@google.com)
- <blame list capped at 100 commits> ()
Timing:
Create | Tuesday, 26-Jun-18 12:18:09 UTC |
Start | Tuesday, 26-Jun-18 12:18:14 UTC |
End | Tuesday, 26-Jun-18 12:53:43 UTC |
Pending | 5 secs |
Execution | 35 mins 29 secs |
All Changes:
-
Version 2.0.0-dev.65.0
Changed by Jonas Termansen - sortieohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 12:17:21 UTC Repository https://dart.googlesource.com/sdk Branch Revision 805969260f4fa92129a68f41c736bfbf6cfec096 Comments
Version 2.0.0-dev.65.0 Merge commit '12971f37a982f42c3e65e51dde4bfb9bc866f7aa' into dev
-
Update dart_style package to 1.1.0 in DEPS
Changed by William Hesse - whesseohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 11:33:24 UTC Repository https://dart.googlesource.com/sdk Branch Revision 12971f37a982f42c3e65e51dde4bfb9bc866f7aa Comments
Update dart_style package to 1.1.0 in DEPS Update Changelog to add this info, and to prepare for releasing -dev.65.0 Change-Id: Iaa6c0d917acb1132227352b422ef3939cda2a9f4 Reviewed-on: https://dart-review.googlesource.com/61926 Commit-Queue: William Hesse <whesse@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Bob Nystrom <rnystrom@google.com>
Changed files
- CHANGELOG.md
- DEPS
-
Handle invalid dill files more gracefully
Changed by Jens Johansen - jensjohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 11:16:35 UTC Repository https://dart.googlesource.com/sdk Branch Revision f67308a983a2a7d8f4645702d34fba36e41b0c56 Comments
Handle invalid dill files more gracefully Instead of bailing out with FATAL et al (which shuts down the VM), give an ApiError when the dill file is invalid. Bug: #33577 Change-Id: I8354b4e68ee95e36584284fd15b3abab3c3bf980 Reviewed-on: https://dart-review.googlesource.com/61937 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Changed files
- runtime/vm/bootstrap.cc
- runtime/vm/bootstrap_nocore.cc
- runtime/vm/dart_api_impl.cc
- runtime/vm/kernel.h
- runtime/vm/kernel_binary.cc
-
[release] Prepare changelog for 2.0.0-dev.65.0
Changed by Alexander Thomas - athomohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 10:36:46 UTC Repository https://dart.googlesource.com/sdk Branch Revision 9aa0c4ae3f05ec2c2f377f0d68f2c74f42cd5bf4 Comments
[release] Prepare changelog for 2.0.0-dev.65.0 Change-Id: Ie463e9b88a68d86e6e09d0c9e9d53f89ab1d77ed Reviewed-on: https://dart-review.googlesource.com/62149 Reviewed-by: William Hesse <whesse@google.com>
Changed files
- CHANGELOG.md
-
Update app_jitk service status
Changed by Jens Johansen - jensjohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 10:12:23 UTC Repository https://dart.googlesource.com/sdk Branch Revision 9a8b5f3bc2ae3ecc5b677ca79388152b01c53354 Comments
Update app_jitk service status New test was added in d2d47acdceff78baa1c8ca40f9cf88c4ceda8c87. It fails - as many others - in `compiler == app_jitk` mode. Change-Id: Id2ab4aec2e7f631a206490d46fefc614b4d666f5 Reviewed-on: https://dart-review.googlesource.com/62148 Reviewed-by: Jens Johansen <jensj@google.com>
Changed files
- runtime/observatory/tests/service/service_kernel.status
-
[infra] Make update_homebrew script work on Dart2
Changed by Alexander Thomas - athomohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 10:04:58 UTC Repository https://dart.googlesource.com/sdk Branch Revision a16ad6d9de64a408c8df2780b608d4b311b58af2 Comments
[infra] Make update_homebrew script work on Dart2 Change-Id: Ieb4d5131273dfe85f29b7f9916a5d3be3c7fe461 Reviewed-on: https://dart-review.googlesource.com/62146 Reviewed-by: William Hesse <whesse@google.com>
Changed files
- tools/apps/update_homebrew/lib/update_homebrew.dart
-
Replace strstr with strncmp looking for path separator
Changed by Jens Johansen - jensjohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 09:31:09 UTC Repository https://dart.googlesource.com/sdk Branch Revision 014a5bc67811136d2721252f49e81fbf6f9de56d Comments
Replace strstr with strncmp looking for path separator Using strstr in a loop is O(n^2) with n being the length of the path, whereas using strncmp is O(n*m) with n being the length of the path and m is the length of the separator (which is always 1). Effectively this turns the quadratic behavior linear. Change-Id: If60d02c33eeca92ca2ff52e0df97d0bb80fe57e0 Reviewed-on: https://dart-review.googlesource.com/62144 Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
Changed files
- runtime/bin/dfe.cc
-
[kernel] Include urls even when we have no source
Changed by Jens Johansen - jensjohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 09:23:16 UTC Repository https://dart.googlesource.com/sdk Branch Revision d2d47acdceff78baa1c8ca40f9cf88c4ceda8c87 Comments
[kernel] Include urls even when we have no source Previously, if we didn't include the source code, we wrote the url as null. This for instance made it impossible to step through mixed in code (at least when mixed in from the sdk). This CL includes all used urls. If there's no source, the source is empty, but the VM then tries to find the proper source to be able to display it (e.g. the VM already has the sdk source). This CL further more adds a service test that tests that we can actually step into mixin in code from the sdk. Change-Id: Ied9569723e23928769ebc980410aed60be6eaa22 Reviewed-on: https://dart-review.googlesource.com/51621 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Changed files
- pkg/front_end/test/summary_generator_test.dart
- pkg/kernel/lib/binary/ast_to_binary.dart
- pkg/kernel/lib/clone.dart
- runtime/observatory/tests/service/step_through_mixin_from_sdk_test.dart
- runtime/vm/kernel_loader.cc
- runtime/vm/object.cc
- runtime/vm/object.h
-
Convert ShadowMapLiteral to MapLiteralJudgment
Changed by Dmitry Stefantsov - dmitryasohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 09:23:04 UTC Repository https://dart.googlesource.com/sdk Branch Revision 5f17b0a0be54f15f7be47b3a3ee30adc3e907551 Comments
Convert ShadowMapLiteral to MapLiteralJudgment Change-Id: I06ee11f873a00d119b07a4cf7aca50257a315000 Reviewed-on: https://dart-review.googlesource.com/61562 Commit-Queue: Dmitry Stefantsov <dmitryas@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Kevin Millikin <kmillikin@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/fangorn.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
Add tests showing the async impact on function type checks
Changed by Johnni Winther - johnniwintherohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 08:11:04 UTC Repository https://dart.googlesource.com/sdk Branch Revision 2c98fb3c1d4f923ff212e46567e9500b62f35c96 Comments
Add tests showing the async impact on function type checks Change-Id: I8a59560dc18a8d491150d2c72287c2025e13beda Reviewed-on: https://dart-review.googlesource.com/62061 Commit-Queue: Johnni Winther <johnniwinther@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com>
Changed files
- tests/compiler/dart2js/equivalence/id_equivalence_helper.dart
- tests/compiler/dart2js/rti/data/async_foreach.dart
- tests/compiler/dart2js/rti/data/async_foreach_nonasync.dart
- tests/compiler/dart2js/rti/data/async_local.dart
- tests/compiler/dart2js/rti/data/async_local_nonasync.dart
- tests/compiler/dart2js/rti/data/async_local_typed.dart
-
Update formated error for nonexisting constructor
Changed by Jens Johansen - jensjohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 08:06:05 UTC Repository https://dart.googlesource.com/sdk Branch Revision 8e4d5c0a3842c3801ce9310c6322146505e58469 Comments
Update formated error for nonexisting constructor Before: ``` wrong-offset.dart:4:15: Error: Method not found: 'C.wrongOffset'. var x = new C.wrongOffset(); ^^^^^^^^^^^ ``` Now: ``` wrong-offset.dart:4:17: Error: Method not found: 'C.wrongOffset'. var x = new C.wrongOffset(); ^^^^^^^^^^^ ``` Testcase added. Closes #33452. Change-Id: I9910c9e510bbe32562df67ec0fb46060ab674e6c Reviewed-on: https://dart-review.googlesource.com/62062 Reviewed-by: Aske Simon Christensen <askesc@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/body_builder.dart
- pkg/front_end/testcases/compile.status
- pkg/front_end/testcases/regress/issue_33452.dart
- pkg/front_end/testcases/regress/issue_33452.dart.direct.expect
- pkg/front_end/testcases/regress/issue_33452.dart.direct.transformed.expect
- pkg/front_end/testcases/regress/issue_33452.dart.outline.expect
- pkg/front_end/testcases/regress/issue_33452.dart.strong.expect
- pkg/front_end/testcases/regress/issue_33452.dart.strong.transformed.expect
- pkg/front_end/testcases/strong.status
-
Add ClassHierarchy to share code between J/KClosedWorld
Changed by Johnni Winther - johnniwintherohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 07:46:24 UTC Repository https://dart.googlesource.com/sdk Branch Revision a8e930caf3ab089c867b5421d3941228733e2af1 Comments
Add ClassHierarchy to share code between J/KClosedWorld + improve the commonSubclasses implementation to support the implementation of FlatTypeMask.intersection and RuntimeEquals.equals computation. Change-Id: I51c4d229e9dc6d5de101aff33e56bb44bf93bc0d Reviewed-on: https://dart-review.googlesource.com/61927 Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Johnni Winther <johnniwinther@google.com>
Changed files
- pkg/compiler/lib/src/frontend_strategy.dart
- pkg/compiler/lib/src/inferrer/typemasks/flat_type_mask.dart
- pkg/compiler/lib/src/inferrer/typemasks/masks.dart
- pkg/compiler/lib/src/js_backend/backend.dart
- pkg/compiler/lib/src/js_backend/impact_transformer.dart
- pkg/compiler/lib/src/js_backend/runtime_types.dart
- pkg/compiler/lib/src/js_model/js_strategy.dart
- pkg/compiler/lib/src/kernel/element_map_impl.dart
- pkg/compiler/lib/src/kernel/kernel_strategy.dart
- pkg/compiler/lib/src/universe/class_hierarchy.dart
- pkg/compiler/lib/src/universe/class_hierarchy_builder.dart
- pkg/compiler/lib/src/universe/world_builder.dart
- pkg/compiler/lib/src/world.dart
- tests/compiler/dart2js/jsinterop/world_test.dart
- tests/compiler/dart2js/model/class_set_test.dart
- tests/compiler/dart2js/model/subtypeset_test.dart
- tests/compiler/dart2js/model/world_test.dart
- tests/compiler/dart2js/needs_no_such_method_test.dart
-
Document IntLiteral.value as holding a uint64 value
Changed by Jens Johansen - jensjohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 07:17:55 UTC Repository https://dart.googlesource.com/sdk Branch Revision c9bd4df21412e604b1b74a0a6ca8a4f0cbe5bbf4 Comments
Document IntLiteral.value as holding a uint64 value Bug: #33351 Change-Id: I0b84e66b56d0b0f07ebc9e1a3593b2cc8e983afa Reviewed-on: https://dart-review.googlesource.com/62063 Reviewed-by: Kevin Millikin <kmillikin@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
Changed files
- pkg/kernel/lib/ast.dart
-
Fix status for new test
Changed by Stephen Adams - sraohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 05:50:17 UTC Repository https://dart.googlesource.com/sdk Branch Revision 56d57407e1c2ba2a4c991262cc38206dc415036c Comments
Fix status for new test TBR=jensj@google.com Change-Id: I03c004685371621eb5e9a7fec0b40853d62fce1b Reviewed-on: https://dart-review.googlesource.com/62281 Reviewed-by: Stephen Adams <sra@google.com>
Changed files
- tests/language_2/language_2_kernel.status
-
Add test for rejecting inexact numbers
Changed by Stephen Adams - sraohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 04:51:44 UTC Repository https://dart.googlesource.com/sdk Branch Revision ed20faa2ed945c13cb560d465c27235a58470f8f Comments
Add test for rejecting inexact numbers Change-Id: Ic206f54096dedac9de918d3840da405a6ce1f262 Reviewed-on: https://dart-review.googlesource.com/61762 Commit-Queue: Stephen Adams <sra@google.com> Reviewed-by: Jens Johansen <jensj@google.com>
Changed files
- tests/language_2/language_2_analyzer.status
- tests/language_2/language_2_dartdevc.status
- tests/language_2/language_2_kernel.status
- tests/language_2/web_int_literals_test.dart
-
Fix directory-prefix finding logic so it works on Windows.
Changed by Alexander Aprelev - aamohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 01:13:55 UTC Repository https://dart.googlesource.com/sdk Branch Revision 31ed467871d1ea8e08c03070be25c626d66bb5d6 Comments
Fix directory-prefix finding logic so it works on Windows. When on Windows, look for '/' in addition to standard Windows file path separator. Bug: dartbug.com/33590 Change-Id: If07daea4d1eaa4e38c051304e63aa95eaf302ed6 Reviewed-on: https://dart-review.googlesource.com/62260 Commit-Queue: Alexander Aprelev <aam@google.com> Reviewed-by: Siva Annamalai <asiva@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com>
Changed files
- runtime/bin/dfe.cc
-
pkg:build_integration: clarify that' it's not planned to be published
Changed by Kevin Moore - kevmooohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 01:12:57 UTC Repository https://dart.googlesource.com/sdk Branch Revision 2d6eaba187d80456f704e7457e012570af82370c Comments
pkg:build_integration: clarify that' it's not planned to be published Update front_end and vm deps to be path dependencies Change-Id: I5cd6b80bab6ae5f2ddfa986abf2b0af5369cab1a Reviewed-on: https://dart-review.googlesource.com/61907 Reviewed-by: Sigmund Cherem <sigmund@google.com>
Changed files
- pkg/build_integration/pubspec.yaml
- pkg/front_end/pubspec.yaml
- pkg/vm/pubspec.yaml
-
[vm] Introduce kernel_multiroot options to support multiroot compilation mode in kernel service.
Changed by Alexander Aprelev - aamohnoyoudont@google.com Changed at Tuesday, 26-Jun-18 00:56:56 UTC Repository https://dart.googlesource.com/sdk Branch Revision f67cba10676e6464ed137656d04373392e6d5c03 Comments
[vm] Introduce kernel_multiroot options to support multiroot compilation mode in kernel service. This extends existing support for multiroot compilation from frontend server to kernel service. Bug: dartbug.com/33508 Change-Id: I76e49038765793b4d683869ab812dde5e6baf6c4 Reviewed-on: https://dart-review.googlesource.com/61982 Commit-Queue: Alexander Aprelev <aam@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com> Reviewed-by: Siva Annamalai <asiva@google.com>
Changed files
- pkg/vm/bin/kernel_service.dart
- runtime/include/dart_api.h
- runtime/vm/dart_api_impl.cc
- runtime/vm/dart_api_impl_test.cc
- runtime/vm/kernel_isolate.cc
- runtime/vm/kernel_isolate.h
- runtime/vm/unit_test.cc
- runtime/vm/unit_test.h
-
Doc - Fix OSError.message and errorCode doc
Changed by Sam Rawlins - srawlinsohnoyoudont@google.com Changed at Monday, 25-Jun-18 23:45:33 UTC Repository https://dart.googlesource.com/sdk Branch Revision 2876bd08fb4457c6588a52598a7c4919f2f4b785 Comments
Doc - Fix OSError.message and errorCode doc Bug: https://github.com/dart-lang/sdk/issues/30698 Change-Id: Iae4ed07171862b44d1303fe1ba33a587b04e5aa5 Reviewed-on: https://dart-review.googlesource.com/61981 Reviewed-by: Zach Anderson <zra@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
Changed files
- sdk/lib/io/common.dart
-
Issue 33518. Fix for subtypes() in parts without library.
Changed by Konstantin Shcheglov - scheglovohnoyoudont@google.com Changed at Monday, 25-Jun-18 23:31:26 UTC Repository https://dart.googlesource.com/sdk Branch Revision c97f177112656235b7e3b2268a668872bd0a3efd Comments
Issue 33518. Fix for subtypes() in parts without library. R=brianwilkerson@google.com, paulberry@google.com Bug: https://github.com/dart-lang/sdk/issues/33518 Change-Id: I368495db5dfa3d4fd64224af9860699fa313f026 Reviewed-on: https://dart-review.googlesource.com/62240 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Changed files
- pkg/analyzer/lib/src/dart/analysis/search.dart
- pkg/analyzer/test/src/dart/analysis/search_test.dart
-
Simplify 'as T' for simple T
Changed by Stephen Adams - sraohnoyoudont@google.com Changed at Monday, 25-Jun-18 23:22:23 UTC Repository https://dart.googlesource.com/sdk Branch Revision e661c9ef547a8526993947f4a4d4d9ce01b7f115 Comments
Simplify 'as T' for simple T Example change: return H.subtypeOfRuntimeTypeCast(this.$index(0, "name"), P.String); ---> return H.stringTypeCast(this.$index(0, "name")); Change-Id: I65752a3e9516c5d391cff4e7a0c4b74c877c81af Reviewed-on: https://dart-review.googlesource.com/60827 Commit-Queue: Stephen Adams <sra@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com>
Changed files
- pkg/compiler/lib/src/ssa/optimize.dart
-
[observatory] Update packages and remove dead dependencies.
Changed by Ryan Macnak - rmacnakohnoyoudont@google.com Changed at Monday, 25-Jun-18 22:09:54 UTC Repository https://dart.googlesource.com/sdk Branch Revision 65a3c4443b84561f1f3b4a4078da1b9589d46e2b Comments
[observatory] Update packages and remove dead dependencies. Change-Id: I6dbf547e30a6be9a303d7fc08c9f4c024164334e Reviewed-on: https://dart-review.googlesource.com/62200 Reviewed-by: Zach Anderson <zra@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
Changed files
- DEPS
- runtime/observatory/.packages
- runtime/observatory/BUILD.gn
- runtime/observatory/dart2js.packages
- runtime/observatory/lib/src/app/analytics.dart
- runtime/observatory/maintainers/.gitignore
- runtime/observatory/maintainers/pubspec.template
- runtime/observatory/maintainers/snapshot_dependencies.sh
- runtime/observatory/pubspec.lock
- runtime/observatory/tests/observatory_ui/allocation_profile/element_test.html
- runtime/observatory/tests/observatory_ui/class_ref/element_test.html
- runtime/observatory/tests/observatory_ui/class_tree/element_test.html
- runtime/observatory/tests/observatory_ui/code_ref/element_test.html
- runtime/observatory/tests/observatory_ui/context_ref/element_test.html
- runtime/observatory/tests/observatory_ui/context_view/element_test.html
- runtime/observatory/tests/observatory_ui/cpu_profile/element_test.html
- runtime/observatory/tests/observatory_ui/cpu_profile/virtual-tree/element_test.html
- runtime/observatory/tests/observatory_ui/cpu_profile_table/element_test.html
- runtime/observatory/tests/observatory_ui/curly_block/element_test.html
- runtime/observatory/tests/observatory_ui/error_ref/element_test.html
- runtime/observatory/tests/observatory_ui/error_view/element_test.html
- runtime/observatory/tests/observatory_ui/field_ref/element_test.html
- runtime/observatory/tests/observatory_ui/flag_list/element_test.html
- runtime/observatory/tests/observatory_ui/function_ref/element_test.html
- runtime/observatory/tests/observatory_ui/general_error/element_test.html
- runtime/observatory/tests/observatory_ui/heap_snapshot/element_test.html
- runtime/observatory/tests/observatory_ui/icdata_ref/element_test.html
- runtime/observatory/tests/observatory_ui/icdata_view/element_test.html
- runtime/observatory/tests/observatory_ui/inbound_references/element_test.html
- runtime/observatory/tests/observatory_ui/instance_ref/element_test.html
- runtime/observatory/tests/observatory_ui/isolate/counter_chart/element_test.html
- runtime/observatory/tests/observatory_ui/isolate/isolate-shared-summary/element_test.html
- runtime/observatory/tests/observatory_ui/isolate_reconnect/element_test.html
- runtime/observatory/tests/observatory_ui/isolate_ref/element_test.html
- runtime/observatory/tests/observatory_ui/library_ref/element_test.html
- runtime/observatory/tests/observatory_ui/local_var_descriptor_ref/element_test.html
- runtime/observatory/tests/observatory_ui/megamorphiccache_ref/element_test.html
- runtime/observatory/tests/observatory_ui/megamorphiccache_view/element_test.html
- runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.html
- runtime/observatory/tests/observatory_ui/nav/isolate-menu/element_test.html
- runtime/observatory/tests/observatory_ui/nav/library-menu/element_test.html
- runtime/observatory/tests/observatory_ui/nav/menu-item/element_test.html
- runtime/observatory/tests/observatory_ui/nav/notify/element_test.html
- runtime/observatory/tests/observatory_ui/nav/notify_event/element_test.html
- runtime/observatory/tests/observatory_ui/nav/notify_exception/connection_exception_test.html
- runtime/observatory/tests/observatory_ui/nav/notify_exception/exception_test.html
- runtime/observatory/tests/observatory_ui/nav/refresh/element_test.html
- runtime/observatory/tests/observatory_ui/nav/top_menu/element_test.html
- runtime/observatory/tests/observatory_ui/nav/vm_menu/element_test.html
- runtime/observatory/tests/observatory_ui/object_common/element_test.html
- runtime/observatory/tests/observatory_ui/objectpool_ref/element_test.html
- runtime/observatory/tests/observatory_ui/objectpool_view/element_test.html
- runtime/observatory/tests/observatory_ui/objectstore_view/element_test.html
- runtime/observatory/tests/observatory_ui/pc_descriptors_ref/element_test.html
- runtime/observatory/tests/observatory_ui/persistent_handles_page/element_test.html
- runtime/observatory/tests/observatory_ui/ports/element_test.html
- runtime/observatory/tests/observatory_ui/retaining_path/element_test.html
- runtime/observatory/tests/observatory_ui/sample_buffer_control/element_test.html
- runtime/observatory/tests/observatory_ui/script_ref/element_test.html
- runtime/observatory/tests/observatory_ui/sentinel_value/element_test.html
- runtime/observatory/tests/observatory_ui/source_link/element_test.html
- runtime/observatory/tests/observatory_ui/stack_trace_tree_config/element_test.html
- runtime/observatory/tests/observatory_ui/token_stream_ref/element_test.html
- runtime/observatory/tests/observatory_ui/unknown_ref/element_test.html
- runtime/observatory/tests/observatory_ui/view_footer/element_test.html
- runtime/observatory/tests/observatory_ui/virtual_tree/element_test.html
- runtime/observatory/tests/observatory_ui/vm_connect/element_test.html
- runtime/observatory/tests/observatory_ui/vm_connect_target/element_test.html
- runtime/observatory/web/index.html
-
Update checked-in Dart SDK to 2.0.0-dev.64.1
Changed by Zach Anderson - zraohnoyoudont@google.com Changed at Monday, 25-Jun-18 21:39:35 UTC Repository https://dart.googlesource.com/sdk Branch Revision b15572933d5513f2bda56f56d9190371095e4436 Comments
Update checked-in Dart SDK to 2.0.0-dev.64.1 Updated to pass --dfe to invocations of the checked-in SDK. Change-Id: I47e122422926d235f166972669c8c2cb18a89735 Reviewed-on: https://dart-review.googlesource.com/62201 Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Zach Anderson <zra@google.com>
Changed files
- build/dart/dart_action.gni
- tools/observatory_tool.py
- tools/sdks/linux/dart-sdk.tar.gz.sha1
- tools/sdks/mac/dart-sdk.tar.gz.sha1
- tools/sdks/win/dart-sdk.tar.gz.sha1
- tools/test.py
- utils/dartdevc/BUILD.gn
-
snapshot the kernel worker in dart 2 mode and fix some dart 2 errors
Changed by Jacob MacDonald - jakemacohnoyoudont@google.com Changed at Monday, 25-Jun-18 21:36:15 UTC Repository https://dart.googlesource.com/sdk Branch Revision 9d3533ff72d99da63ecc7efbd9f9328e335f7417 Comments
snapshot the kernel worker in dart 2 mode and fix some dart 2 errors Change-Id: Icf4e123e61bc265ba1d4c6620826e5f23241add0 Reviewed-on: https://dart-review.googlesource.com/62120 Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Jake Macdonald <jakemac@google.com>
Changed files
- utils/bazel/BUILD.gn
- utils/bazel/kernel_worker.dart
-
Convert ShadowSyntheticExpression to SyntheticExpressionJudgment
Changed by Paul Berry - paulberryohnoyoudont@google.com Changed at Monday, 25-Jun-18 20:16:54 UTC Repository https://dart.googlesource.com/sdk Branch Revision b29bde6232136cc13a1d621dc60ea473e8ded1df Comments
Convert ShadowSyntheticExpression to SyntheticExpressionJudgment Change-Id: I0b860415dbdf3f8fb2e3f21891259f0a6bb322f9 Reviewed-on: https://dart-review.googlesource.com/62124 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/body_builder.dart
- pkg/front_end/lib/src/fasta/kernel/fangorn.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_ast_api.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
Check function types in the correct order in runZoned.
Changed by Lasse R.H. Nielsen - lrnohnoyoudont@google.com Changed at Monday, 25-Jun-18 19:43:14 UTC Repository https://dart.googlesource.com/sdk Branch Revision 2876623654681dde5c0bd94ac91346db93aa1f1f Comments
Check function types in the correct order in runZoned. A change made it check for a unary function type before a binary, so `(o, [stack])=>...` would not get a stack trace. Fixes #33589 Bug: http://dartbug.com/33589 Change-Id: I69793eb74501c1f7fe07b6c90115b2f90f4d95df Reviewed-on: https://dart-review.googlesource.com/61936 Reviewed-by: Florian Loitsch <floitsch@google.com> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Changed files
- sdk/lib/async/zone.dart
- tests/lib_2/async/run_zoned8_test.dart
-
getStats Future should be strongly typed.
Changed by Terry Lucas - terryohnoyoudont@google.com Changed at Monday, 25-Jun-18 19:25:04 UTC Repository https://dart.googlesource.com/sdk Branch Revision 6d25212302dae1c042a728187871c4c61f4a1cc1 Comments
getStats Future should be strongly typed. TBR=kevmoo@google.com Change-Id: I4c4a6376f84b346e676245e5984136adfe3074aa Reviewed-on: https://dart-review.googlesource.com/62128 Commit-Queue: Terry Lucas <terry@google.com> Reviewed-by: Terry Lucas <terry@google.com>
Changed files
- sdk/lib/html/dart2js/html_dart2js.dart
- tools/dom/scripts/systemhtml.py
-
Remove code awaiting void results to unblock #33145
Changed by Mike Fairhurst - mfairhurstohnoyoudont@google.com Changed at Monday, 25-Jun-18 19:18:44 UTC Repository https://dart.googlesource.com/sdk Branch Revision ca99917fb6b806bf67e61829ec4caac5afa99732 Comments
Remove code awaiting void results to unblock #33145 It's possible that the code relies upon this async gap. However, I imagine it isn't, and that the await was merely added in these places because it looks like it would be an asynchronous operation. In any case, it was not waiting on anything before, and so any reliance upon any async gaps here would be strange. Change-Id: I49c3be4dcaaa18361ef60c7f9e31999db3fc090b Reviewed-on: https://dart-review.googlesource.com/60704 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Changed files
- pkg/front_end/lib/src/fasta/deprecated_problems.dart
-
Improve fasta parser expression recovery
Changed by Dan Rubel - danrubelohnoyoudont@google.com Changed at Monday, 25-Jun-18 19:06:26 UTC Repository https://dart.googlesource.com/sdk Branch Revision 19f60bfb522e365bdd11031dabf1b8945b649afd Comments
Improve fasta parser expression recovery This improves the parser's ability to distinguish between an expression and the start of a new statement. Change-Id: I07871dc0e2e6f81996bfc99a53bd3dede3db21ae Reviewed-on: https://dart-review.googlesource.com/62180 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Dan Rubel <danrubel@google.com>
Changed files
- pkg/analyzer/test/src/fasta/recovery/partial_code/assert_statement_test.dart
- pkg/analyzer/test/src/fasta/recovery/partial_code/field_declaration_test.dart
- pkg/analyzer/test/src/fasta/recovery/partial_code/local_variable_test.dart
- pkg/analyzer/test/src/fasta/recovery/partial_code/top_level_variable_test.dart
- pkg/analyzer/test/src/fasta/recovery/partial_code/yield_statement_test.dart
- pkg/front_end/lib/src/fasta/parser/identifier_context.dart
- pkg/front_end/lib/src/fasta/parser/identifier_context_impl.dart
- pkg/front_end/lib/src/fasta/parser/parser.dart
-
Add tokens to more judgements
Changed by Brian Wilkerson - brianwilkersonohnoyoudont@google.com Changed at Monday, 25-Jun-18 18:57:58 UTC Repository https://dart.googlesource.com/sdk Branch Revision d632980ee080c88aaf51aa035d807258dc84395e Comments
Add tokens to more judgements Change-Id: I9a27702e48b7f4f7600b929834644b233194982c Reviewed-on: https://dart-review.googlesource.com/62127 Commit-Queue: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/body_builder.dart
- pkg/front_end/lib/src/fasta/kernel/fangorn.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
- pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
-
- Fixed querySelectoryAll generic syntax to assert if types in list aren't of the same type T.
Changed by Terry Lucas - terryohnoyoudont@google.com Changed at Monday, 25-Jun-18 18:43:54 UTC Repository https://dart.googlesource.com/sdk Branch Revision 5721d8af6d8755fa6f70f3951de2c451c57bf12f Comments
- Fixed querySelectoryAll generic syntax to assert if types in list aren't of the same type T. - Fixes requestFullscreen to call operation webkitRequestFullscreen not requestFullscreen its only available when RuntimeEnabled=FullscreenUnprefixed. Fixes #21919 R=vsm@google.com Change-Id: Ib4c4140350d3cef096954e67010f922df9f2310a Reviewed-on: https://dart-review.googlesource.com/60702 Commit-Queue: Terry Lucas <terry@google.com> Reviewed-by: Vijay Menon <vsm@google.com>
Changed files
- sdk/lib/html/dart2js/html_dart2js.dart
- tests/lib_2/html/element_classes_svg_test.dart
- tools/dom/idl/dart/dart.idl
- tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate
- tools/dom/templates/html/impl/impl_Element.darttemplate
- tools/dom/templates/html/impl/impl_SpeechSynthesis.darttemplate
-
Fix second half on #33343: disallow generic functions as type arguments.
Changed by Mike Fairhurst - mfairhurstohnoyoudont@google.com Changed at Monday, 25-Jun-18 18:02:04 UTC Repository https://dart.googlesource.com/sdk Branch Revision 36400371646b5a3290d4dc3d1fa8ea81b28fe997 Comments
Fix second half on #33343: disallow generic functions as type arguments. There is a seeming parse error in typedefs, and an open question on the issue (33343) about what to do when a generic function type is inferred. Otherwise this seems ready to go. Bug: 33343 Change-Id: I10d2ea9b6ca26ed2c6ff6b24ffe5008fc4797ef2 Reviewed-on: https://dart-review.googlesource.com/61109 Commit-Queue: Mike Fairhurst <mfairhurst@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Changed files
- pkg/analyzer/lib/error/error.dart
- pkg/analyzer/lib/src/error/codes.dart
- pkg/analyzer/lib/src/generated/error_verifier.dart
- pkg/analyzer/lib/src/generated/type_system.dart
- pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart
- pkg/analyzer/test/generated/compile_time_error_code_test.dart
- tests/language_2/language_2_analyzer.status
- tests/language_2/language_2_dartdevc.status
-
Remove variableSet factory methods.
Changed by Paul Berry - paulberryohnoyoudont@google.com Changed at Monday, 25-Jun-18 17:59:49 UTC Repository https://dart.googlesource.com/sdk Branch Revision 97c81d668af627603922cf0bdeb2c2f10a8ee67d Comments
Remove variableSet factory methods. It turns out they aren't needed--the required functionality is already provided by the variableAssign method. Fixes #33557. Change-Id: Ieb3cfc237a6d7d6ae61f0afcd9e9bb9ead1c8fbb Reviewed-on: https://dart-review.googlesource.com/62125 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Changed files
- pkg/analyzer/lib/src/fasta/resolution_storer.dart
- pkg/front_end/lib/src/fasta/kernel/factory.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_factory.dart
- pkg/front_end/lib/src/fasta/kernel/toplevel_inference_factory.dart
- pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart
-
Improve parse assert statement recovery
Changed by Dan Rubel - danrubelohnoyoudont@google.com Changed at Monday, 25-Jun-18 17:53:59 UTC Repository https://dart.googlesource.com/sdk Branch Revision 98efc7917f3b8b3b1e394aad9d6fe38e8dd4a718 Comments
Improve parse assert statement recovery This fixes a crash when parsing assert statements and improves recovery when missing a closing ')'. Change-Id: I1495dad40208918fb93a65234f3fe7e94b2c6aae Reviewed-on: https://dart-review.googlesource.com/62160 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Dan Rubel <danrubel@google.com>
Changed files
- pkg/analyzer/test/src/fasta/recovery/partial_code/assert_statement_test.dart
- pkg/front_end/lib/src/fasta/parser/parser.dart
-
[vm/kernel/bytecode] Bytecode generation for rarely used operations
Changed by Alexander Markov - alexmarkovohnoyoudont@google.com Changed at Monday, 25-Jun-18 17:51:44 UTC Repository https://dart.googlesource.com/sdk Branch Revision a93e303f3f2f49040f1ee1671c223b89c2f4a317 Comments
[vm/kernel/bytecode] Bytecode generation for rarely used operations Change-Id: Ie5154207b4763d950707b267803a688d4b3e0487 Reviewed-on: https://dart-review.googlesource.com/62002 Reviewed-by: Régis Crelier <regis@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com>
Changed files
- pkg/vm/bin/frontend_server_starter.dart
- pkg/vm/lib/bytecode/gen_bytecode.dart
- pkg/vm/lib/bytecode/local_vars.dart
- pkg/vm/testcases/bytecode/closures.dart
- pkg/vm/testcases/bytecode/closures.dart.expect
- pkg/vm/testcases/bytecode/deferred_lib.dart
- pkg/vm/testcases/bytecode/deferred_lib.dart.expect
- pkg/vm/testcases/bytecode/literals.dart
- pkg/vm/testcases/bytecode/literals.dart.expect
-
Convert ShadowCascadeExpression to CascadeJudgment.
Changed by Konstantin Shcheglov - scheglovohnoyoudont@google.com Changed at Monday, 25-Jun-18 17:42:04 UTC Repository https://dart.googlesource.com/sdk Branch Revision a0ba81bfe78a2d81551ff929fc3ed1ddabbc3b7e Comments
Convert ShadowCascadeExpression to CascadeJudgment. Change-Id: I33d20438a9dd09e41f8db27c37b541a0efc78bd0 Reviewed-on: https://dart-review.googlesource.com/62040 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Paul Berry <paulberry@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/body_builder.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_ast_api.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
Convert ShadowSymbolLiteral to SymbolLiteralJudgment
Changed by Paul Berry - paulberryohnoyoudont@google.com Changed at Monday, 25-Jun-18 17:21:04 UTC Repository https://dart.googlesource.com/sdk Branch Revision de4d8b6cae6eeb1145259f867d2120928c597618 Comments
Convert ShadowSymbolLiteral to SymbolLiteralJudgment Change-Id: I917a68a7f91820749bb3842304f8ae875182a25b Reviewed-on: https://dart-review.googlesource.com/62123 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/fangorn.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
Count analyzer cfe integration failing tests.
Changed by Devon Carew - devoncarewohnoyoudont@google.com Changed at Monday, 25-Jun-18 17:04:29 UTC Repository https://dart.googlesource.com/sdk Branch Revision 13c3560fc6654e0c6fe15e8c2565f561a80ca637 Comments
Count analyzer cfe integration failing tests. Bug: https://github.com/dart-lang/sdk/issues/33512 Change-Id: I04f0c07484aa8b6c9baec7b764b052a06bce0c17 Reviewed-on: https://dart-review.googlesource.com/62081 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Changed files
- pkg/analyzer/tool/analyzer_cfe_progress.dart
-
Convert ShadowLogicalExpression to LogicalJudgment
Changed by Paul Berry - paulberryohnoyoudont@google.com Changed at Monday, 25-Jun-18 16:57:14 UTC Repository https://dart.googlesource.com/sdk Branch Revision 77f94ec25973365c060633c929c1a1ba64b19487 Comments
Convert ShadowLogicalExpression to LogicalJudgment Change-Id: I54982617e02b8ee3004927ded7638c98f1f4d66e Reviewed-on: https://dart-review.googlesource.com/62122 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/fangorn.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_ast_api.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
Add tokens to more judgements
Changed by Brian Wilkerson - brianwilkersonohnoyoudont@google.com Changed at Monday, 25-Jun-18 16:56:24 UTC Repository https://dart.googlesource.com/sdk Branch Revision 1a0fc733d3a469e9069b9ecf806868a9ea46b590 Comments
Add tokens to more judgements Change-Id: I39fca828e117de726907af2eacb2e42e57f33491 Reviewed-on: https://dart-review.googlesource.com/62121 Reviewed-by: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Changed files
- pkg/analyzer/lib/src/fasta/resolution_storer.dart
- pkg/front_end/lib/src/fasta/kernel/body_builder.dart
- pkg/front_end/lib/src/fasta/kernel/factory.dart
- pkg/front_end/lib/src/fasta/kernel/fangorn.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_factory.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
- pkg/front_end/lib/src/fasta/kernel/toplevel_inference_factory.dart
- pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart
-
Remove unused class
Changed by Dan Rubel - danrubelohnoyoudont@google.com Changed at Monday, 25-Jun-18 16:15:46 UTC Repository https://dart.googlesource.com/sdk Branch Revision 81191186d8673ceeb373f7b05fd9485080759c04 Comments
Remove unused class Change-Id: I5ef6354952f2cc7672aa0527cc8f1dbb28734b46 Reviewed-on: https://dart-review.googlesource.com/62100 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Dan Rubel <danrubel@google.com>
Changed files
- pkg/front_end/lib/src/fasta/parser/type_continuation.dart
-
Partial fix of #33343. Reject generic function types as bounds.
Changed by Mike Fairhurst - mfairhurstohnoyoudont@google.com Changed at Monday, 25-Jun-18 15:56:06 UTC Repository https://dart.googlesource.com/sdk Branch Revision 284b5cce55f96dad08d3402dacae5e81f1e9351a Comments
Partial fix of #33343. Reject generic function types as bounds. Does not handle the other half of #33343, rejecting generic function types as type arguments. This revealed a secondary minor issue which was easy enough to fix. Type arguments were not resolved within bounds: class C<T extends S Function<S>(S)> {} this would report 'undefined class S' for the return and parameter types `S`. I almost split this into a separate CL, but, these two CLs are tied together inherently by the tests case. Easy to solve at once. Bug: 33343 Change-Id: Ib34a04d90be08d8d6c6f21a9d485a452017585ba Reviewed-on: https://dart-review.googlesource.com/61103 Commit-Queue: Mike Fairhurst <mfairhurst@google.com> Reviewed-by: Paul Berry <paulberry@google.com>
Changed files
- pkg/analyzer/lib/error/error.dart
- pkg/analyzer/lib/src/error/codes.dart
- pkg/analyzer/lib/src/generated/error_verifier.dart
- pkg/analyzer/lib/src/generated/resolver.dart
- pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart
- pkg/analyzer/test/generated/compile_time_error_code_test.dart
- pkg/analyzer/test/generated/non_error_resolver_kernel_test.dart
- pkg/analyzer/test/generated/non_error_resolver_test.dart
- pkg/analyzer/test/generated/strong_mode_kernel_test.dart
- pkg/analyzer/test/generated/strong_mode_test.dart
-
Update pkg/pkg.status with the latest -DuseFastaParser status.
Changed by Devon Carew - devoncarewohnoyoudont@google.com Changed at Monday, 25-Jun-18 15:03:24 UTC Repository https://dart.googlesource.com/sdk Branch Revision ada8188b733fabc105110af42bbe484b3abdbf39 Comments
Update pkg/pkg.status with the latest -DuseFastaParser status. Change-Id: I0964506057defd27fc1335408a9751a0b18cb95d Reviewed-on: https://dart-review.googlesource.com/62020 Reviewed-by: Dan Rubel <danrubel@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
Changed files
- pkg/pkg.status
-
[VM] Handle [VariableGet]s for parameters/let variables differently than other const variables
Changed by Martin Kustermann - kustermannohnoyoudont@google.com Changed at Monday, 25-Jun-18 14:12:33 UTC Repository https://dart.googlesource.com/sdk Branch Revision e232ddd28c6e7368d011d37f1b3c123349a00975 Comments
[VM] Handle [VariableGet]s for parameters/let variables differently than other const variables Change-Id: I10e74b7535936a62964cc4f00aac2572552b31d7 Reviewed-on: https://dart-review.googlesource.com/62064 Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
Changed files
- pkg/kernel/lib/transformations/constants.dart
- pkg/vm/lib/kernel_front_end.dart
-
Adjust stringContentTDQ, stringContentTSQ to allow escapes.
Changed by Erik Ernst - eernstohnoyoudont@google.com Changed at Monday, 25-Jun-18 13:50:10 UTC Repository https://dart.googlesource.com/sdk Branch Revision 5d4dbdac5c096b5614982c50498c0efd651f26a6 Comments
Adjust stringContentTDQ, stringContentTSQ to allow escapes. Bug: 33090. Change-Id: Id8c0d26a4f4072a97cc71c8f3f05f0694c304491 Reviewed-on: https://dart-review.googlesource.com/61923 Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Changed files
- docs/language/dartLangSpec.tex
-
[fasta] Update .expect files for non-simple bound tests
Changed by Dmitry Stefantsov - dmitryasohnoyoudont@google.com Changed at Monday, 25-Jun-18 12:43:13 UTC Repository https://dart.googlesource.com/sdk Branch Revision b27b62e182dd501554e53530e82d6d683fb4e2d8 Comments
[fasta] Update .expect files for non-simple bound tests Change-Id: I88866d54f97455fd9b14fef7def20d6dd958b878 Reviewed-on: https://dart-review.googlesource.com/59088 Commit-Queue: Dmitry Stefantsov <dmitryas@google.com> Reviewed-by: Peter von der Ahé <ahe@google.com>
Changed files
- pkg/front_end/testcases/compile.status
- pkg/front_end/testcases/instantiate_to_bound/body_typedef_super_bounded_type.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/body_typedef_super_bounded_type.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/body_typedef_super_bounded_type.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/body_typedef_super_bounded_type.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_bound_due_to_non_simple.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_bound_due_to_non_simple.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_bound_due_to_non_simple.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_bound_due_to_non_simple.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_bound_due_to_non_simple.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_bound_due_to_variables.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_bound_due_to_variables.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_bound_due_to_variables.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_bound_due_to_variables.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_bound_due_to_variables.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_class_parametrized_typedef_cycle.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_class_parametrized_typedef_cycle.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_class_parametrized_typedef_cycle.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_class_typedef_cycle.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_class_typedef_cycle.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_class_typedef_cycle.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_class_typedef_cycle.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_class_typedef_cycle.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_folded_regress.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_folded_regress.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_folded_regress.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_folded_regress.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_folded_regress.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_for_each.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_for_each.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_for_each.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_for_each.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_for_each.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_from_compiled.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_from_compiled.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_from_compiled.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_from_compiled.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_from_compiled.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_generic_function_in_bound_regress.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_generic_function_in_bound_regress.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_generic_function_in_bound_regress.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_generic_function_in_bound_regress.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_generic_function_in_bound_regress.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_many.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_many.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_many.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_many.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_many.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_many_libs_same_name_cycle.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_many_libs_same_name_cycle.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_many_libs_same_name_cycle.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_many_libs_same_name_cycle.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_many_libs_same_name_cycle.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_no_dup.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_no_dup.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_no_dup.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_no_dup.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_no_dup.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_suppress_consequence.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_suppress_consequence.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_suppress_consequence.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_suppress_consequence.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_suppress_consequence.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_variables_from_same.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_variables_from_same.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_variables_from_same.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_variables_from_same.dart.strong.expect
- pkg/front_end/testcases/instantiate_to_bound/non_simple_variables_from_same.dart.strong.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/typedef_super_bounded_type.dart.direct.expect
- pkg/front_end/testcases/instantiate_to_bound/typedef_super_bounded_type.dart.direct.transformed.expect
- pkg/front_end/testcases/instantiate_to_bound/typedef_super_bounded_type.dart.outline.expect
- pkg/front_end/testcases/instantiate_to_bound/typedef_super_bounded_type.dart.strong.expect
- pkg/front_end/testcases/outline.status
- pkg/front_end/testcases/strong.status
-
[vm/compiler] Improve CallTargets::CreateAndExpand
Changed by Vyacheslav Egorov - vegorovohnoyoudont@google.com Changed at Monday, 25-Jun-18 12:18:33 UTC Repository https://dart.googlesource.com/sdk Branch Revision aeff1c00f248225ca6f57f45106258d55241fad1 Comments
[vm/compiler] Improve CallTargets::CreateAndExpand It should expand past abstract classes if that allows to merge two consequtive ranges with the same target into one. In Dart 2 mode cid ranges are often interrupted by abstract classes introduced by mixin transformation. This change allows to expand ranges past those classes and merge consequtive ranges that have the same target. Change-Id: Ic0f4fa956d989609bebbe6f8d275491c562aa492 Reviewed-on: https://dart-review.googlesource.com/61929 Commit-Queue: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Changed files
- runtime/vm/compiler/backend/il.cc
-
[VM] Report an error when accessing constructor parameters inside a constructor invocation
Changed by Martin Kustermann - kustermannohnoyoudont@google.com Changed at Monday, 25-Jun-18 12:05:53 UTC Repository https://dart.googlesource.com/sdk Branch Revision 2ff5f8cfcb271bbd27a76520e740944b23b99b3c Comments
[VM] Report an error when accessing constructor parameters inside a constructor invocation Closes https://github.com/dart-lang/sdk/issues/33604 Change-Id: I84034499de43ea300b278f2f922bc73c565e8bcc Reviewed-on: https://dart-review.googlesource.com/61934 Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
Changed files
- pkg/front_end/lib/src/fasta/fasta_codes_generated.dart
- pkg/front_end/messages.status
- pkg/front_end/messages.yaml
- pkg/kernel/lib/ast.dart
- pkg/kernel/lib/transformations/constants.dart
- pkg/vm/lib/kernel_front_end.dart
- tests/language_2/language_2_kernel.status
-
Change infer to return the expression instead of its type
Changed by Kevin Millikin - kmillikinohnoyoudont@google.com Changed at Monday, 25-Jun-18 11:04:15 UTC Repository https://dart.googlesource.com/sdk Branch Revision 2f474a55c11d616259f8a303963585035cd0fbca Comments
Change infer to return the expression instead of its type ExpressionJudgment.infer is the method that will compile from type inference judgments to abstract syntax. Change it to have this API. It currently returns null from all implementations. Change-Id: Id3bdac43a2783c4fda0aeeeff2963d0ccee4dd20 Reviewed-on: https://dart-review.googlesource.com/61935 Reviewed-by: Dmitry Stefantsov <dmitryas@google.com> Commit-Queue: Kevin Millikin <kmillikin@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
[vm/compiler] Fix incorrect assertion from 20ca5bbb056.
Changed by Vyacheslav Egorov - vegorovohnoyoudont@google.com Changed at Monday, 25-Jun-18 09:52:13 UTC Repository https://dart.googlesource.com/sdk Branch Revision b9f11311f8eda1af0e59416239e0086a76325a6f Comments
[vm/compiler] Fix incorrect assertion from 20ca5bbb056. Must demangle the name before checking if it is a setter name. Change-Id: I2d58b9d4d5cab319f67da045458277e9f42e2592 Reviewed-on: https://dart-review.googlesource.com/61933 Reviewed-by: Jens Johansen <jensj@google.com> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Changed files
- runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc
-
Expression compilation fix
Changed by Jens Johansen - jensjohnoyoudont@google.com Changed at Monday, 25-Jun-18 08:59:49 UTC Repository https://dart.googlesource.com/sdk Branch Revision f85fbde72733ea67d5b36253de43850e03ee8cdc Comments
Expression compilation fix Previously, when loading from a dill file and not invalidating anything compilation expression would fail. This CL introduces a forced invalidation of the entrypoint when loading for the first time, just as is done when requesting a full component. Closes #33087. Bug: 33087 Change-Id: I0d9b84393f3b046a0359e3a94bb1bcb8ab650308 Reviewed-on: https://dart-review.googlesource.com/61920 Reviewed-by: Kevin Millikin <kmillikin@google.com>
Changed files
- pkg/front_end/lib/src/fasta/incremental_compiler.dart
- pkg/front_end/test/fasta/expression_test.dart
- pkg/front_end/test/incremental_load_from_dill_test.dart
-
Make incremental_load_from_dill_test dart2 compliant
Changed by Jens Johansen - jensjohnoyoudont@google.com Changed at Monday, 25-Jun-18 08:59:49 UTC Repository https://dart.googlesource.com/sdk Branch Revision 6240dd5cc3d8ff8f9a4520d11cbe2fc7a6e11946 Comments
Make incremental_load_from_dill_test dart2 compliant Change-Id: I28a5c1738f02eda884c3aa1a396eb9386ca7728d Reviewed-on: https://dart-review.googlesource.com/61930 Reviewed-by: Aske Simon Christensen <askesc@google.com>
Changed files
- pkg/front_end/test/incremental_load_from_dill_test.dart
-
Bump kernel version after e2ce88d
Changed by Jens Johansen - jensjohnoyoudont@google.com Changed at Monday, 25-Jun-18 08:19:33 UTC Repository https://dart.googlesource.com/sdk Branch Revision 8747da838fbafcc42a507e0f991518946c59a988 Comments
Bump kernel version after e2ce88d e2ce88dfcca32b7f59807df614e0afa41fe585c1 changed the kernel format but forgot to bump the kernel version. This CL is a folow-up that bumps the kernel version. Change-Id: Ic3f150af4b022acd971e91aed3c602cd5b1782af Reviewed-on: https://dart-review.googlesource.com/61880 Reviewed-by: Kevin Millikin <kmillikin@google.com> Commit-Queue: Jens Johansen <jensj@google.com>
Changed files
- pkg/kernel/binary.md
- pkg/kernel/lib/binary/tag.dart
- runtime/vm/kernel_binary.h
-
[vm/jit] Introduce dynamic invocation forwarders that perform type checking
Changed by Vyacheslav Egorov - vegorovohnoyoudont@google.com Changed at Monday, 25-Jun-18 07:27:04 UTC Repository https://dart.googlesource.com/sdk Branch Revision 20ca5bbb056dec9980ba2e1cdfddff9aa773cba0 Comments
[vm/jit] Introduce dynamic invocation forwarders that perform type checking This forwarders are used at dynamic call-sites and perform type checking for all non-generic-covariant arguments. This allows to skip the same type checks in the actual method body. This yield on average 10% improvement in performance across the body of benchmarks including dart2js compilation times. Bug: https://github.com/dart-lang/sdk/issues/33257 Change-Id: If3fc94a2e0a6f496ec0633f0b379d053a54a40ca Reviewed-on: https://dart-review.googlesource.com/61244 Commit-Queue: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Alexander Markov <alexmarkov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Changed files
- runtime/observatory/lib/src/elements/function_view.dart
- runtime/observatory/lib/src/models/objects/function.dart
- runtime/observatory/lib/src/service/object.dart
- runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc
- runtime/vm/compiler/frontend/kernel_binary_flowgraph.h
- runtime/vm/compiler/frontend/kernel_to_il.cc
- runtime/vm/compiler/frontend/kernel_to_il.h
- runtime/vm/isolate.h
- runtime/vm/kernel_isolate.cc
- runtime/vm/log.cc
- runtime/vm/object.cc
- runtime/vm/object.h
- runtime/vm/raw_object.h
- runtime/vm/resolver.cc
- runtime/vm/runtime_entry.cc
- runtime/vm/symbols.h
-
[gardening] Mark language_2/const_constructor_nonconst_param_test/01 failing in dartkp
Changed by Vyacheslav Egorov - vegorovohnoyoudont@google.com Changed at Monday, 25-Jun-18 06:39:22 UTC Repository https://dart.googlesource.com/sdk Branch Revision f9a11ec380a47db4e8bd53a416bd860cd1296358 Comments
[gardening] Mark language_2/const_constructor_nonconst_param_test/01 failing in dartkp Bug: https://github.com/dart-lang/sdk/issues/33604 Change-Id: Ib3f5196f529ea91f6c55914cc697270a80e0b2d9 Reviewed-on: https://dart-review.googlesource.com/61928 Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Changed files
- tests/language_2/language_2_kernel.status
-
Check whether variables is set before using GN not_needed
Changed by Petr Hosek - phosekohnoyoudont@google.com Changed at Saturday, 23-Jun-18 23:59:59 UTC Repository https://dart.googlesource.com/sdk Branch Revision 212a8173227e05b48dc9e71fd8ec16e532f9017d Comments
Check whether variables is set before using GN not_needed GN not_needed functions now checks whether the variable exists and invoking not_needed on non-existent variable is considered an error. Change-Id: I45bcb0c06228920d41db3482a0e50eae3b26eb0d Reviewed-on: https://dart-review.googlesource.com/62022 Commit-Queue: Zach Anderson <zra@google.com> Reviewed-by: Zach Anderson <zra@google.com>
Changed files
- runtime/configs.gni
-
Update the status of analysis server tests.
Changed by Devon Carew - devoncarewohnoyoudont@google.com Changed at Saturday, 23-Jun-18 18:42:31 UTC Repository https://dart.googlesource.com/sdk Branch Revision f3817788678f54d85f9c4070a2a1fa0af4db7ef1 Comments
Update the status of analysis server tests. Change-Id: I12c2366209ae712e064888714dd65ce8ec9d89f7 Reviewed-on: https://dart-review.googlesource.com/62003 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
Changed files
- pkg/analysis_server/test/integration/analysis/get_navigation_test.dart
- pkg/analysis_server/test/integration/analysis/reanalyze_concurrent_test.dart
- pkg/analysis_server/test/integration/analysis/reanalyze_test.dart
- pkg/analysis_server/test/integration/analysis/set_general_subscriptions_test.dart
- pkg/analysis_server/test/integration/analysis/set_priority_files_test.dart
- pkg/analysis_server/test/integration/edit/get_fixes_test.dart
- pkg/analysis_server/test/integration/edit/list_postfix_completion_templates_test.dart
- pkg/analysis_server/test/integration/execution/delete_context_test.dart
- pkg/analysis_server/test/integration/execution/map_uri_test.dart
- pkg/analysis_server/test/integration/search/find_element_references_test.dart
- pkg/analysis_server/test/integration/search/find_member_declarations_test.dart
- pkg/analysis_server/test/integration/server/status_test.dart
-
Add tokens to judgements, part 2
Changed by Brian Wilkerson - brianwilkersonohnoyoudont@google.com Changed at Saturday, 23-Jun-18 15:26:49 UTC Repository https://dart.googlesource.com/sdk Branch Revision 8b10b1fda93090360bbe7ec21f3c66ce11c5d6fa Comments
Add tokens to judgements, part 2 Change-Id: I2442124d702f1d7728f5d63af041b073cfaa437e Reviewed-on: https://dart-review.googlesource.com/61985 Commit-Queue: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/fangorn.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
Add a binder mechanism to the Factory API for handling labels.
Changed by Paul Berry - paulberryohnoyoudont@google.com Changed at Saturday, 23-Jun-18 01:56:39 UTC Repository https://dart.googlesource.com/sdk Branch Revision 8c1591af9ea8fa525e5be6ed75b3b053d1f9f0d1 Comments
Add a binder mechanism to the Factory API for handling labels. Some work needs to be done on both sides to hook up to the API: - On the front end side, the individual labels need to be plumbed through the body builder to the judgment objects (currently the body builder discards individual label information). Follow-up work for this will be tracked in https://github.com/dart-lang/sdk/issues/33591. - On the analyzer side, the label information needs to be stored by ResolutionStorer and retrieved by ResolutionApplier (currently the ResolutionApplier has its own scope resolution mechanism; we don't want to keep this because it duplicates resolution logic in the front end). Follw-up work for this will be tracked in https://github.com/dart-lang/sdk/issues/33592. Change-Id: I75afc2be16a277581b0e2ea49b6998e72054a40d Reviewed-on: https://dart-review.googlesource.com/62000 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Changed files
- pkg/analyzer/lib/src/fasta/resolution_storer.dart
- pkg/front_end/lib/src/fasta/kernel/factory.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_factory.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
- pkg/front_end/lib/src/fasta/kernel/toplevel_inference_factory.dart
- pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart
-
Re-enable some failing analyzer_cli --use-cfe tests.
Changed by Devon Carew - devoncarewohnoyoudont@google.com Changed at Saturday, 23-Jun-18 01:17:05 UTC Repository https://dart.googlesource.com/sdk Branch Revision e132240c91096fe1ed519c326b3211e3f3e838d7 Comments
Re-enable some failing analyzer_cli --use-cfe tests. Change-Id: I1085c0dd5d8e4fa818bf82b258a3639a1d196266 Reviewed-on: https://dart-review.googlesource.com/61903 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Paul Berry <paulberry@google.com>
Changed files
- pkg/analysis_server/test/integration/analysis/update_content_list_test.dart
- pkg/analyzer_cli/test/driver_test.dart
-
Drop support for Dart 1 in pub
Changed by Nate Bosch - nboschohnoyoudont@google.com Changed at Saturday, 23-Jun-18 01:00:05 UTC Repository https://dart.googlesource.com/sdk Branch Revision f598e6933cc0c5fa8695f4fe8cc579e23a344a2a Comments
Drop support for Dart 1 in pub Closes #33187 Brings in the latest version of pub. There is still an issue with invaliding old snapshots, but this version works better than the current synced version. Change-Id: I5c98b0277ea769baa83c3fee7ebfff2034ba9920 Reviewed-on: https://dart-review.googlesource.com/61983 Commit-Queue: Nate Bosch <nbosch@google.com> Reviewed-by: Kevin Moore <kevmoo@google.com> Reviewed-by: Bob Nystrom <rnystrom@google.com>
Changed files
- CHANGELOG.md
- DEPS
- sdk/BUILD.gn
- sdk/bin/pub_sdk
- sdk/bin/pub_sdk.bat
- utils/pub/BUILD.gn
-
Print times in seconds
Changed by Stephen Adams - sraohnoyoudont@google.com Changed at Saturday, 23-Jun-18 00:50:15 UTC Repository https://dart.googlesource.com/sdk Branch Revision 9146cea63aa2e29f38f84ab3a1314675daf37a2d Comments
Print times in seconds Change-Id: I4adcb9847d7a1ce4e91f93e7c484a3fd59310f52 Reviewed-on: https://dart-review.googlesource.com/62001 Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Stephen Adams <sra@google.com>
Changed files
- pkg/compiler/lib/src/apiimpl.dart
-
Convert invocation Shadow(s) to Judgment(s).
Changed by Konstantin Shcheglov - scheglovohnoyoudont@google.com Changed at Saturday, 23-Jun-18 00:02:08 UTC Repository https://dart.googlesource.com/sdk Branch Revision ec0df457a26fd6f70d554849b7f6c2803748ac8b Comments
Convert invocation Shadow(s) to Judgment(s). Change-Id: I377edeb65f1b3b650fc7f356f07fd249a2dbdbca Reviewed-on: https://dart-review.googlesource.com/61984 Reviewed-by: Paul Berry <paulberry@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/body_builder.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_ast_api.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_expression_generator.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
- pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart
-
Workaround for issue 33559.
Changed by Konstantin Shcheglov - scheglovohnoyoudont@google.com Changed at Friday, 22-Jun-18 23:24:07 UTC Repository https://dart.googlesource.com/sdk Branch Revision 223b143167d6bb7f4365e9afe52126d878dac5a9 Comments
Workaround for issue 33559. Not a fix, just a kludge until VM is fixed. https://github.com/dart-lang/sdk/issues/33559 R=brianwilkerson@google.com, paulberry@google.com Change-Id: I4952f4fddd6ebbd46f8dfa53ea18a8bff269b0f0 Reviewed-on: https://dart-review.googlesource.com/61987 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Changed files
- pkg/front_end/lib/src/fasta/testing/kernel_chain.dart
-
[ dart:io / tests ] Fixed issue where non_utf8* tests attempted to delete the current working directory which is not allowed on Windows.
Changed by Ben Konyi - bkonyiohnoyoudont@google.com Changed at Friday, 22-Jun-18 23:18:48 UTC Repository https://dart.googlesource.com/sdk Branch Revision 091f8860c270069133a6d277ece73a7e4423fa4c Comments
[ dart:io / tests ] Fixed issue where non_utf8* tests attempted to delete the current working directory which is not allowed on Windows. Change-Id: I67801c1c544e0ee197386dd3aad82cc7507a98a1 Reviewed-on: https://dart-review.googlesource.com/61963 Reviewed-by: Zach Anderson <zra@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com>
Changed files
- tests/standalone_2/io/non_utf8_directory_test.dart
- tests/standalone_2/io/non_utf8_file_test.dart
- tests/standalone_2/io/non_utf8_link_test.dart
-
Add unittest for InferenceData
Changed by Johnni Winther - johnniwintherohnoyoudont@google.com Changed at Friday, 22-Jun-18 23:15:45 UTC Repository https://dart.googlesource.com/sdk Branch Revision 9276b27acdc61847344937991b7ba3669a43fd78 Comments
Add unittest for InferenceData Change-Id: Ic2ce5a66f2fa7227f029dfd38903bb686f0ab622 Reviewed-on: https://dart-review.googlesource.com/61925 Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Johnni Winther <johnniwinther@google.com>
Changed files
- tests/compiler/dart2js/inference/inference_data/called_in_loop.dart
- tests/compiler/dart2js/inference/inference_data/cannot_throw.dart
- tests/compiler/dart2js/inference/inference_data/function_apply.dart
- tests/compiler/dart2js/inference/inference_data_test.dart
-
Revert "Update checked-in Dart SDK to 2.0.0-dev.64.1"
Changed by Zach Anderson - zraohnoyoudont@google.com Changed at Friday, 22-Jun-18 22:28:39 UTC Repository https://dart.googlesource.com/sdk Branch Revision 70ac1f90ec74e92946e05afed2d1b75b33b5522c Comments
Revert "Update checked-in Dart SDK to 2.0.0-dev.64.1" This reverts commit 47f394d61c640d8f427eb1d8c20bdf386ecd71ac. Change-Id: I95cc7ab3cb9d112748460f793fd8906f216ac056 Reviewed-on: https://dart-review.googlesource.com/61986 Reviewed-by: Alexander Markov <alexmarkov@google.com>
Changed files
- tools/observatory_tool.py
- tools/sdks/linux/dart-sdk.tar.gz.sha1
- tools/sdks/mac/dart-sdk.tar.gz.sha1
- tools/sdks/win/dart-sdk.tar.gz.sha1
- tools/test.py
- utils/dartdevc/BUILD.gn
-
Use FunctionNodeJudgment in FunctionExpressionJudgment.
Changed by Konstantin Shcheglov - scheglovohnoyoudont@google.com Changed at Friday, 22-Jun-18 21:25:15 UTC Repository https://dart.googlesource.com/sdk Branch Revision c270576dd4b393a26ff27d9fc5438866333a76a7 Comments
Use FunctionNodeJudgment in FunctionExpressionJudgment. We don't need changes to NamedFunctionExpressionJudgment, because it is a wrapper around FunctionExpressionJudgment. Change-Id: Ia94fb3201c7a960a64af2fdeaa8d8307ba6d82c3 Reviewed-on: https://dart-review.googlesource.com/61980 Reviewed-by: Paul Berry <paulberry@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
[dart2js] Fix for issue 33572
Changed by Stephen Adams - sraohnoyoudont@google.com Changed at Friday, 22-Jun-18 20:50:45 UTC Repository https://dart.googlesource.com/sdk Branch Revision aeba82ef9a6256fae31d9e5eaf7cc2d46f1ea1fc Comments
[dart2js] Fix for issue 33572 Change-Id: If33e59880c882885b4368a8be91663298deb207c Reviewed-on: https://dart-review.googlesource.com/61965 Commit-Queue: Stephen Adams <sra@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com>
Changed files
- pkg/compiler/lib/src/js_backend/constant_emitter.dart
- pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart
- pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart
- tests/compiler/dart2js_extra/33572_test.dart
-
Convert ShadowNot to NotJudgment.
Changed by Konstantin Shcheglov - scheglovohnoyoudont@google.com Changed at Friday, 22-Jun-18 20:33:10 UTC Repository https://dart.googlesource.com/sdk Branch Revision 1416ed283ae8d38b81c4dc4e54259c7dcd707f37 Comments
Convert ShadowNot to NotJudgment. R=brianwilkerson@google.com, paulberry@google.com Change-Id: I280b65bf668bcef07c304bccd92433492e074777 Reviewed-on: https://dart-review.googlesource.com/61964 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/fangorn.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
Convert ShadowForStatement to ForJudgment.
Changed by Konstantin Shcheglov - scheglovohnoyoudont@google.com Changed at Friday, 22-Jun-18 20:33:00 UTC Repository https://dart.googlesource.com/sdk Branch Revision a1a2d90a6c8994e052be9befcabb7058b44d5256 Comments
Convert ShadowForStatement to ForJudgment. Change-Id: I95e70234be97c4d246ac93caf64958bee1cfbe83 Reviewed-on: https://dart-review.googlesource.com/61911 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Paul Berry <paulberry@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/body_builder.dart
- pkg/front_end/lib/src/fasta/kernel/fangorn.dart
- pkg/front_end/lib/src/fasta/kernel/forest.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_ast_api.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
Make unittests work with Dart 2
Changed by Johnni Winther - johnniwintherohnoyoudont@google.com Changed at Friday, 22-Jun-18 20:25:05 UTC Repository https://dart.googlesource.com/sdk Branch Revision 7c6211b1d886ec12d852afb545a527bc25bab1c6 Comments
Make unittests work with Dart 2 Change-Id: Ic2c105747dfba067464fc15e158f58417c8636a8 Reviewed-on: https://dart-review.googlesource.com/61922 Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Johnni Winther <johnniwinther@google.com>
Changed files
- pkg/compiler/lib/compiler.dart
- pkg/compiler/lib/src/helpers/stats.dart
- pkg/compiler/lib/src/inferrer/type_graph_dump.dart
- tests/compiler/dart2js/codegen/expect_annotations_test.dart
- tests/compiler/dart2js/codegen/minify_many_locals_test.dart
- tests/compiler/dart2js/deferred/closures_test.dart
- tests/compiler/dart2js/deferred/custom_element_test.dart
- tests/compiler/dart2js/deferred/dont_inline_deferred_constants_test.dart
- tests/compiler/dart2js/deferred/dont_inline_deferred_globals_test.dart
- tests/compiler/dart2js/deferred/emit_type_checks_test.dart
- tests/compiler/dart2js/deferred/follow_constant_dependencies_test.dart
- tests/compiler/dart2js/deferred/follow_implicit_super_regression_test.dart
- tests/compiler/dart2js/deferred/inline_restrictions_test.dart
- tests/compiler/dart2js/deferred/load_graph_segmentation2_test.dart
- tests/compiler/dart2js/deferred/load_graph_segmentation_test.dart
- tests/compiler/dart2js/deferred/load_mapping_test.dart
- tests/compiler/dart2js/deferred/not_in_main_test.dart
- tests/compiler/dart2js/deferred/unneeded_part_js_test.dart
- tests/compiler/dart2js/end_to_end/async_compiler_input_provider_test.dart
- tests/compiler/dart2js/end_to_end/exit_code_test.dart
- tests/compiler/dart2js/end_to_end/library_env_test.dart
- tests/compiler/dart2js/inlining/meta_annotations_test.dart
- tests/compiler/dart2js/instantiated_classes_test.dart
- tests/compiler/dart2js/model/constant_expression_evaluate_test.dart
- tests/compiler/dart2js/sha1_short_test_vectors.dart
- tests/compiler/dart2js/sha1_test.dart
- tests/compiler/dart2js/sourcemaps/helpers/sourcemap_helper.dart
- tests/compiler/dart2js/sourcemaps/location_collector_test.dart
- tests/compiler/dart2js/uri_retention_test.dart
-
Handle covariant parameters in function types
Changed by Johnni Winther - johnniwintherohnoyoudont@google.com Changed at Friday, 22-Jun-18 20:24:55 UTC Repository https://dart.googlesource.com/sdk Branch Revision a8d805055ab18b14dcaea5a5a8c5b61f66947b34 Comments
Handle covariant parameters in function types Closes #33575 Change-Id: I743a951f5864ca538b588441ecba2680eba2081f Reviewed-on: https://dart-review.googlesource.com/61924 Commit-Queue: Johnni Winther <johnniwinther@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com>
Changed files
- pkg/compiler/lib/src/kernel/element_map_impl.dart
- tests/compiler/dart2js/model/type_substitution_test.dart
- tests/compiler/dart2js/rti/data/call_typed_generic.dart
- tests/compiler/dart2js/rti/data/call_typed_generic_strong.dart
- tests/compiler/dart2js/rti/data/method_signatures.dart
- tests/compiler/dart2js/rti/data/tear_off_generic.dart
- tests/compiler/dart2js/rti/data/tear_off_generic_strong.dart
- tests/language_2/language_2_dart2js.status
-
Don't add parts without 'part of' as libraries.
Changed by Konstantin Shcheglov - scheglovohnoyoudont@google.com Changed at Friday, 22-Jun-18 19:52:25 UTC Repository https://dart.googlesource.com/sdk Branch Revision b24170259c38a5c6724d741c0cdea65a61a5e86d Comments
Don't add parts without 'part of' as libraries. See also https://github.com/dart-lang/sdk/issues/33587 R=brianwilkerson@google.com, paulberry@google.com Change-Id: I109c76c88483c6b9459fe94b372c71bec8b2d6bf Reviewed-on: https://dart-review.googlesource.com/61962 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Changed files
- pkg/analyzer/lib/src/dart/analysis/frontend_resolution.dart
- pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart
- pkg/analyzer/test/src/dart/analysis/driver_kernel_test.dart
-
Revise order of type variable declaration events
Changed by danrubel - danrubelohnoyoudont@google.com Changed at Friday, 22-Jun-18 19:47:46 UTC Repository https://dart.googlesource.com/sdk Branch Revision fea8cb147304ebda540f683ffebb689686fd82a9 Comments
Revise order of type variable declaration events As of this CL, events for type variable declarations occur in the following order: * beginTypeVariables * beginTypeVariable for each type variable in the declaration * handleTypeVariablesDefined * endTypeVariable for eah type variable in the declaration * endTypeVariables Revising the order of events facilitate removing the hack in BodyBuilder.beginTypeVariables in a future CL. This is another slice of https://dart-review.googlesource.com/c/sdk/+/57661 so that it can be landed in a more incremental fashion. Change-Id: Ief0ad766c12f1ca9d53a8ec8d3c08b41166b2897 Reviewed-on: https://dart-review.googlesource.com/61940 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Dan Rubel <danrubel@google.com>
Changed files
- pkg/analyzer/lib/src/fasta/ast_builder.dart
- pkg/analyzer/test/generated/parser_fasta_listener.dart
- pkg/front_end/lib/src/fasta/kernel/body_builder.dart
- pkg/front_end/lib/src/fasta/parser/forwarding_listener.dart
- pkg/front_end/lib/src/fasta/parser/listener.dart
- pkg/front_end/lib/src/fasta/parser/type_info_impl.dart
- pkg/front_end/lib/src/fasta/source/diet_listener.dart
- pkg/front_end/lib/src/fasta/source/outline_builder.dart
- pkg/front_end/test/fasta/parser/type_info_test.dart
-
Rename lemma to binder
Changed by Paul Berry - paulberryohnoyoudont@google.com Changed at Friday, 22-Jun-18 19:44:20 UTC Repository https://dart.googlesource.com/sdk Branch Revision 63399765674bd3e3080b6ad2fbf716a8d8012319 Comments
Rename lemma to binder Change-Id: I90e09158ef4bc6df13684d69543ea32a6cb05255 Reviewed-on: https://dart-review.googlesource.com/61960 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Changed files
- pkg/analyzer/lib/src/fasta/resolution_storer.dart
- pkg/front_end/lib/src/fasta/kernel/factory.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_factory.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
- pkg/front_end/lib/src/fasta/kernel/toplevel_inference_factory.dart
- pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart
-
Start adding tokens to judgements
Changed by Brian Wilkerson - brianwilkersonohnoyoudont@google.com Changed at Friday, 22-Jun-18 19:38:55 UTC Repository https://dart.googlesource.com/sdk Branch Revision 9d499fffe488eb1a510d3ebfeff1aa137a20550b Comments
Start adding tokens to judgements Change-Id: I938d101aef91f42e85c6263809d0ab617d299521 Reviewed-on: https://dart-review.googlesource.com/61961 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/fangorn.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
Convert ShadowFunctionDeclaration to FunctionDeclarationJudgment, add FunctionNodeJudgment.
Changed by Konstantin Shcheglov - scheglovohnoyoudont@google.com Changed at Friday, 22-Jun-18 19:36:17 UTC Repository https://dart.googlesource.com/sdk Branch Revision ff7a1255aab6873073aeed208d7c688cfd1f8279 Comments
Convert ShadowFunctionDeclaration to FunctionDeclarationJudgment, add FunctionNodeJudgment. Change-Id: Ib1edf20c22b448314cc2b1028559d3466ecfe4f8 Reviewed-on: https://dart-review.googlesource.com/61916 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/body_builder.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_ast_api.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
Docs - Update example websockets app; use idiomatic async/await in examples
Changed by Sam Rawlins - srawlinsohnoyoudont@google.com Changed at Friday, 22-Jun-18 18:52:45 UTC Repository https://dart.googlesource.com/sdk Branch Revision 5bfb70ec5b1f8a05562361db466a946917335892 Comments
Docs - Update example websockets app; use idiomatic async/await in examples Bug: https://github.com/dart-lang/sdk/issues/30686 Change-Id: Ie447c2fa095315c3d11972c24cacb67c1729796e Reviewed-on: https://dart-review.googlesource.com/61915 Reviewed-by: Zach Anderson <zra@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
Changed files
- sdk/lib/io/io.dart
-
Doc - Fix library links in analyzer docs
Changed by Sam Rawlins - srawlinsohnoyoudont@google.com Changed at Friday, 22-Jun-18 18:40:05 UTC Repository https://dart.googlesource.com/sdk Branch Revision ed0ba901e19d711e1fe3e03344b3ba153a4859d8 Comments
Doc - Fix library links in analyzer docs These new links are stil brittle; if dartdoc changes the paths of libraries, or if `element.dart` gets a `library` directive. But at least they're fixed. There doesn't appear to be a less brittle solution. Bug: https://github.com/dart-lang/sdk/issues/27994 Change-Id: Ibff7c01442d10e7133e68500219ac9a5713888b2 Reviewed-on: https://dart-review.googlesource.com/61913 Reviewed-by: Janice Collins <jcollins@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
Changed files
- pkg/analyzer/lib/dart/ast/ast.dart
- pkg/analyzer/lib/dart/element/element.dart
- pkg/analyzer/lib/dart/element/type.dart
-
dart2js: Make bazel-input-provider dart2 compliant.
Changed by Sigmund Cherem - sigmundohnoyoudont@google.com Changed at Friday, 22-Jun-18 18:26:25 UTC Repository https://dart.googlesource.com/sdk Branch Revision 4c697085bef9b91c371af3b766d18b0760787e10 Comments
dart2js: Make bazel-input-provider dart2 compliant. Change-Id: Ia832982852720c3c591621091ba15b81b922d553 Reviewed-on: https://dart-review.googlesource.com/61914 Reviewed-by: Stephen Adams <sra@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com>
Changed files
- pkg/compiler/lib/src/source_file_provider.dart
-
Use the lemma approach for NamedFunctionExpression
Changed by Paul Berry - paulberryohnoyoudont@google.com Changed at Friday, 22-Jun-18 18:17:57 UTC Repository https://dart.googlesource.com/sdk Branch Revision 9b814bdf3464f63eff0c423368d4ccf3194271b1 Comments
Use the lemma approach for NamedFunctionExpression Change-Id: Ib234bd876e9a060d035e90dfc665e3822b3a592b Reviewed-on: https://dart-review.googlesource.com/61901 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Changed files
- pkg/analyzer/lib/src/fasta/resolution_storer.dart
- pkg/front_end/lib/src/fasta/kernel/factory.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_factory.dart
- pkg/front_end/lib/src/fasta/kernel/toplevel_inference_factory.dart
- pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart
-
Rename variableLemma and variableType to clarify that they refer to the loop variable.
Changed by Paul Berry - paulberryohnoyoudont@google.com Changed at Friday, 22-Jun-18 18:16:08 UTC Repository https://dart.googlesource.com/sdk Branch Revision 7c0d31092df1ddc71638117e6be39887f470ffae Comments
Rename variableLemma and variableType to clarify that they refer to the loop variable. Addresses comment from https://dart-review.googlesource.com/c/sdk/+/61780. Change-Id: I1e697030f44184b33cf67263118791592a3c3ba1 Reviewed-on: https://dart-review.googlesource.com/61900 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com>
Changed files
- pkg/analyzer/lib/src/fasta/resolution_storer.dart
- pkg/front_end/lib/src/fasta/kernel/factory.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_factory.dart
- pkg/front_end/lib/src/fasta/kernel/toplevel_inference_factory.dart
- pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart
-
Update dartdoc to 0.20.1.
Changed by Janice Collins - jcollinsohnoyoudont@google.com Changed at Friday, 22-Jun-18 17:44:05 UTC Repository https://dart.googlesource.com/sdk Branch Revision b36f353f76d46aea75a3456d2ed7b6d1bc450692 Comments
Update dartdoc to 0.20.1. https://github.com/dart-lang/dartdoc/releases/tag/v0.20.1 Updates dartdoc and its dependency "quiver" to new versions (dartdoc ran into a type problem with the older quiver). Because of the quiver change this could affect more than just dartdoc. Change-Id: I9b0bbb3d4b222f605d7ac5cafc641b5da0c02d20 Reviewed-on: https://dart-review.googlesource.com/61912 Reviewed-by: Devon Carew <devoncarew@google.com> Commit-Queue: Janice Collins <jcollins@google.com>
Changed files
- DEPS
-
[vm/kernel] Fix StreamingConstantEvaluator to handle non-const variables
Changed by Alexander Markov - alexmarkovohnoyoudont@google.com Changed at Friday, 22-Jun-18 17:16:45 UTC Repository https://dart.googlesource.com/sdk Branch Revision eafa9ae4b6dbac420928c89b35461f2f80c9dbaa Comments
[vm/kernel] Fix StreamingConstantEvaluator to handle non-const variables Fixes https://github.com/dart-lang/sdk/issues/33214 Change-Id: I7991b537204f160b2991abf9995685e4cae69f88 Reviewed-on: https://dart-review.googlesource.com/61682 Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Changed files
- runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc
- runtime/vm/compiler/frontend/kernel_binary_flowgraph.h
- tests/language_2/const_constructor_nonconst_param_test.dart
- tests/language_2/language_2_dart2js.status
- tests/language_2/language_2_dartdevc.status
- tests/language_2/language_2_kernel.status
-
[VM interpreter] Fix broken interpreter build.
Changed by Régis Crelier - regisohnoyoudont@google.com Changed at Friday, 22-Jun-18 16:53:25 UTC Repository https://dart.googlesource.com/sdk Branch Revision 3e2708eada272e43edb884b1238b59bdbf9bda56 Comments
[VM interpreter] Fix broken interpreter build. Change-Id: I1a877f22605874c6a199e2cab53b068a54383927 Reviewed-on: https://dart-review.googlesource.com/61910 Reviewed-by: Régis Crelier <regis@google.com> Commit-Queue: Régis Crelier <regis@google.com>
Changed files
- runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc
- runtime/vm/object.cc
- runtime/vm/object.h
-
pkg:status_file misc cleanup
Changed by Kevin Moore - kevmooohnoyoudont@google.com Changed at Friday, 22-Jun-18 16:42:27 UTC Repository https://dart.googlesource.com/sdk Branch Revision 94abf948c440442b2cbfea81fe77d9bed50e877f Comments
pkg:status_file misc cleanup Clarify in the pubspec that it's not published Cleaned up hints/lints in source files Change-Id: Ifbf59ab0fb219dcdf5de99eced0a0129e6e191cb Reviewed-on: https://dart-review.googlesource.com/61909 Reviewed-by: Bob Nystrom <rnystrom@google.com>
Changed files
- pkg/status_file/bin/lint.dart
- pkg/status_file/pubspec.yaml
- pkg/status_file/test/repo_status_files_test.dart
-
Fix a committed solo test and mark it as passing now.
Changed by Devon Carew - devoncarewohnoyoudont@google.com Changed at Friday, 22-Jun-18 16:17:55 UTC Repository https://dart.googlesource.com/sdk Branch Revision 02721709c3a447289f91621bde8c114bd060ea78 Comments
Fix a committed solo test and mark it as passing now. Change-Id: Id0185d229ef84ac78bba1906ce90ad0083c9651d Reviewed-on: https://dart-review.googlesource.com/61905 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
Changed files
- pkg/analysis_server/test/integration/analysis/overrides_test.dart
-
Add parameters to Forest method to support labeled statements
Changed by Brian Wilkerson - brianwilkersonohnoyoudont@google.com Changed at Friday, 22-Jun-18 15:51:30 UTC Repository https://dart.googlesource.com/sdk Branch Revision c8a488c1ca55f07965573ea674b5d48607d31d21 Comments
Add parameters to Forest method to support labeled statements Change-Id: I6b45ba7155b10c7f6f12a203324f0cdc3ccb89f7 Reviewed-on: https://dart-review.googlesource.com/61761 Commit-Queue: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Changed files
- pkg/analyzer/lib/src/fasta/resolution_storer.dart
- pkg/front_end/lib/src/fasta/kernel/factory.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_factory.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
- pkg/front_end/lib/src/fasta/kernel/toplevel_inference_factory.dart
- pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart
-
[vm/compiler/aot] Implement non-speculative int64 shift operation
Changed by Alexander Markov - alexmarkovohnoyoudont@google.com Changed at Friday, 22-Jun-18 15:43:28 UTC Repository https://dart.googlesource.com/sdk Branch Revision c4d6ac0cbef43a5cea856dc82af6522ba67c26e1 Comments
[vm/compiler/aot] Implement non-speculative int64 shift operation Closes https://github.com/dart-lang/sdk/issues/33364 Change-Id: I9432d82a1ee58fbbdc1b54b810a71c2c7ddd8fce Reviewed-on: https://dart-review.googlesource.com/59821 Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Zach Anderson <zra@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Changed files
- runtime/vm/compiler/aot/aot_call_specializer.cc
- runtime/vm/compiler/backend/constant_propagator.cc
- runtime/vm/compiler/backend/flow_graph_compiler.cc
- runtime/vm/compiler/backend/flow_graph_compiler.h
- runtime/vm/compiler/backend/il.cc
- runtime/vm/compiler/backend/il.h
- runtime/vm/compiler/backend/il_arm.cc
- runtime/vm/compiler/backend/il_arm64.cc
- runtime/vm/compiler/backend/il_dbc.cc
- runtime/vm/compiler/backend/il_ia32.cc
- runtime/vm/compiler/backend/il_x64.cc
- runtime/vm/compiler/backend/range_analysis.cc
- runtime/vm/compiler/backend/range_analysis.h
- runtime/vm/compiler/backend/type_propagator.cc
- runtime/vm/compiler/call_specializer.cc
- runtime/vm/dart.cc
- runtime/vm/runtime_entry.cc
- runtime/vm/runtime_entry_list.h
- runtime/vm/thread.cc
- runtime/vm/thread.h
- tests/language_2/vm/shift_special_cases_test.dart
-
Rename typeContext to inferredType
Changed by Brian Wilkerson - brianwilkersonohnoyoudont@google.com Changed at Friday, 22-Jun-18 15:43:27 UTC Repository https://dart.googlesource.com/sdk Branch Revision 3af363cba0cf85d6fe4bbe7a199d4859feef4824 Comments
Rename typeContext to inferredType Change-Id: Ifde7803944a23f2682a77a5ba5c9a9dfb5ca5978 Reviewed-on: https://dart-review.googlesource.com/61906 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Changed files
- pkg/analyzer/lib/src/fasta/resolution_storer.dart
- pkg/front_end/lib/src/fasta/kernel/factory.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_factory.dart
- pkg/front_end/lib/src/fasta/kernel/toplevel_inference_factory.dart
- pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart
-
pkg:kernel - cleanup pubspec file
Changed by Kevin Moore - kevmooohnoyoudont@google.com Changed at Friday, 22-Jun-18 15:43:04 UTC Repository https://dart.googlesource.com/sdk Branch Revision 10dcad1dd2698ce64bbae44ec8a5630b4710b45e Comments
pkg:kernel - cleanup pubspec file Reference pkg:testing by path Remove dependency on pkg:ansicolor - not used Also removed outdated reference to fasta in .packages Change-Id: Iaeaa4a868e376e6cfdd5dad35d87521a18b213f2 Reviewed-on: https://dart-review.googlesource.com/61908 Reviewed-by: Kevin Millikin <kmillikin@google.com> Commit-Queue: Kevin Moore <kevmoo@google.com>
Changed files
- .packages
- pkg/kernel/pubspec.yaml
-
Convert ShadowLiteralList into LiteralListJudgment
Changed by Dmitry Stefantsov - dmitryasohnoyoudont@google.com Changed at Friday, 22-Jun-18 14:13:25 UTC Repository https://dart.googlesource.com/sdk Branch Revision 7e7fd7ffa574074a5900079925b7ef7aafaf8032 Comments
Convert ShadowLiteralList into LiteralListJudgment Change-Id: Iead84138ca0a74ae15911e6d0978d52c08f40816 Reviewed-on: https://dart-review.googlesource.com/61540 Commit-Queue: Dmitry Stefantsov <dmitryas@google.com> Reviewed-by: Paul Berry <paulberry@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/fangorn.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
[fasta] Report instantiate-to-bound failure due to non-simple bounds
Changed by Dmitry Stefantsov - dmitryasohnoyoudont@google.com Changed at Friday, 22-Jun-18 13:41:55 UTC Repository https://dart.googlesource.com/sdk Branch Revision 4fe71ec275038c091159e4dbf555c2fa2aff8a96 Comments
[fasta] Report instantiate-to-bound failure due to non-simple bounds Fixes #33208, #31810, #32416, #32417 Bug: http://dartbug.com/33208 Bug: http://dartbug.com/31810 Bug: http://dartbug.com/32416 Bug: http://dartbug.com/32417 Change-Id: Id178daf35be459fdefe04091bf929b5743d89e81 Reviewed-on: https://dart-review.googlesource.com/41264 Commit-Queue: Dmitry Stefantsov <dmitryas@google.com> Reviewed-by: Aske Simon Christensen <askesc@google.com>
Changed files
- pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart
- pkg/front_end/lib/src/fasta/fasta_codes_generated.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
- pkg/front_end/lib/src/fasta/kernel/type_algorithms.dart
- pkg/front_end/messages.yaml
- pkg/front_end/testcases/compile.status
- pkg/front_end/testcases/instantiate_to_bound/non_simple_bound_due_to_non_simple.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_bound_due_to_variables.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_class_parametrized_typedef_cycle.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_class_typedef_cycle.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_for_each.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_co_inductive_no_dup.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_folded_regress.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_for_each.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_from_compiled.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_generic_function_in_bound_regress.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_many.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_many_libs_same_name_cycle.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_many_libs_same_name_cycle_lib.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_no_dup.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_suppress_consequence.dart
- pkg/front_end/testcases/instantiate_to_bound/non_simple_variables_from_same.dart
- pkg/front_end/testcases/outline.status
- pkg/front_end/testcases/strong.status
- tests/co19/co19-kernel.status
- tests/language_2/language_2_dart2js.status
- tests/language_2/language_2_dartdevc.status
- tests/language_2/language_2_kernel.status
-
Convert ShadowDeferredCheck to DeferredCheckJudgment
Changed by Paul Berry - paulberryohnoyoudont@google.com Changed at Friday, 22-Jun-18 13:36:45 UTC Repository https://dart.googlesource.com/sdk Branch Revision 121fed2840f0edd0cf9afb23b6ebdaed15179054 Comments
Convert ShadowDeferredCheck to DeferredCheckJudgment Change-Id: I411e29c6b3f1d1d88942cfb6775d4b88908bb6a5 Reviewed-on: https://dart-review.googlesource.com/61820 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/body_builder.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_ast_api.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
Fix cascade specification.
Changed by Lasse R.H. Nielsen - lrnohnoyoudont@google.com Changed at Friday, 22-Jun-18 13:33:48 UTC Repository https://dart.googlesource.com/sdk Branch Revision e2c54e9af51ff25a834097fa8ee60e74177eb2b9 Comments
Fix cascade specification. Don't use $e$ for two different things, and specify static type. Fixes #19517. Bug: http://dartbug.com/19517 Change-Id: Ieb30fc05dc305f25526b05b2005a1a81a88e2009 Reviewed-on: https://dart-review.googlesource.com/61881 Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Changed files
- docs/language/dartLangSpec.tex
-
Make status file linter valid Dart 2 code
Changed by William Hesse - whesseohnoyoudont@google.com Changed at Friday, 22-Jun-18 13:24:09 UTC Repository https://dart.googlesource.com/sdk Branch Revision d08317b79f54e64f2fd0b703eaf791b8e79bbf91 Comments
Make status file linter valid Dart 2 code Change-Id: I14e1ca4a32022cbd9b112a02d15ad35e92824854 Reviewed-on: https://dart-review.googlesource.com/61882 Reviewed-by: Dmitry Stefantsov <dmitryas@google.com> Commit-Queue: William Hesse <whesse@google.com>
Changed files
- pkg/status_file/lib/status_file_linter.dart
-
Convert ShadowFunctionExpression to FunctionExpressionJudgment
Changed by Paul Berry - paulberryohnoyoudont@google.com Changed at Friday, 22-Jun-18 13:10:15 UTC Repository https://dart.googlesource.com/sdk Branch Revision f4d2bf313e13dfeda69e2fb6238bfeefecc6aa41 Comments
Convert ShadowFunctionExpression to FunctionExpressionJudgment Change-Id: Ibc821fc6ec982b4871bb9688f5261d5e901658bb Reviewed-on: https://dart-review.googlesource.com/61801 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Changed files
- pkg/front_end/lib/src/fasta/kernel/body_builder.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_ast_api.dart
- pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
-
Compile time error for web int literals that cannot be represented exactly
Changed by Jens Johansen - jensjohnoyoudont@google.com Changed at Friday, 22-Jun-18 10:47:54 UTC Repository https://dart.googlesource.com/sdk Branch Revision 6888bc28246b943a8b2bda73e067c6c60da78993 Comments
Compile time error for web int literals that cannot be represented exactly Bug: #33351 Change-Id: I2b99858dfc276dc70c3a36c289030e801145af86 Reviewed-on: https://dart-review.googlesource.com/61180 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Kevin Millikin <kmillikin@google.com>
Changed files
- pkg/analyzer/lib/src/dart/ast/ast.dart
- pkg/compiler/lib/src/kernel/dart2js_target.dart
- pkg/compiler/lib/src/ssa/kernel_impact.dart
- pkg/dev_compiler/lib/src/kernel/target.dart
- pkg/front_end/lib/src/fasta/fasta_codes_generated.dart
- pkg/front_end/lib/src/fasta/kernel/body_builder.dart
- pkg/front_end/messages.status
- pkg/front_end/messages.yaml
- pkg/kernel/lib/target/targets.dart
- tests/co19/co19-dart2js.status
- tests/corelib/corelib.status
- tests/corelib_2/corelib_2.status
- tests/language/language_dart2js.status
- tests/language_2/language_2_dart2js.status
- tests/language_2/language_2_dartdevc.status
- tests/lib/lib.status
- tests/lib_2/lib_2_dart2js.status
- tests/lib_2/lib_2_dartdevc.status
-
Register type arguments on inlining
Changed by Johnni Winther - johnniwintherohnoyoudont@google.com Changed at Friday, 22-Jun-18 08:24:13 UTC Repository https://dart.googlesource.com/sdk Branch Revision 075c713a93c78c1ac6159e2ea0df3015ecfed8ec Comments
Register type arguments on inlining Closes #33529 Change-Id: I992552a400199490959d10de8c838e56015159e5 Reviewed-on: https://dart-review.googlesource.com/61522 Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Johnni Winther <johnniwinther@google.com>
Changed files
- pkg/compiler/lib/src/ssa/builder_kernel.dart
- pkg/compiler/lib/src/ssa/optimize.dart
- pkg/compiler/lib/src/universe/codegen_world_builder.dart
- pkg/compiler/lib/src/universe/use.dart
- tests/compiler/dart2js/equivalence/id_equivalence_helper.dart
- tests/compiler/dart2js/rti/emission/generic_methods_dynamic_02_strong.dart
- tests/corelib_2/corelib_2.status
- tests/language_2/language_2_dart2js.status
-
<blame list capped at 100 commits>
Changed by <blame list capped at 100 commits> - Changed at N/A Repository Branch Revision Comments
<blame list capped at 100 commits>