LUCI CI Migration Comparison Console

Fix the zero state vox issue caused by nested buttons.

Bug: 924776,934565
Change-Id: Icc39b20b0fd819ef0c3551bb82cf230758a6a20b
Reviewed-on: https://chromium-review.googlesource.com/c/1481079
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634908}

Revert "Changes to include fast app reinstall in chrome://flags."

This reverts commit 5a2d490901b78a58633f0c633187bd06fe2085b3.

Reason for revert: Suspect for failing unit_tests, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/20476

Original change's description:
> Changes to include fast app reinstall in chrome://flags.
>
> Bug: 911427
> Change-Id: Ic33fd7507d36d0e847598722067ce64802718f9e
> Reviewed-on: https://chromium-review.googlesource.com/c/1484391
> Reviewed-by: Jenny Zhang <jennyz@chromium.org>
> Commit-Queue: Rob Schonberger <robsc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634884}

TBR=jennyz@chromium.org,robsc@chromium.org

Change-Id: I69637a4f4064131eedf57f18f9a27769cf70a4f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 911427
Reviewed-on: https://chromium-review.googlesource.com/c/1484587
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634907}

Introduce MessagePumpKqueue and make it the MessagePumpForIO on macOS.

MessagePumpKqueue is a WatchableIOMessagePumpPosix capable of watching
FDs, like the MessagePumpLibevent it is replacing (note that Libevent is
still used on other POSIX systems). However MessagePumpKqueue can also
watch Mach port receive rights for notification of new Mach messages,
which libevent cannot do.

The underlying wait primitive for both is a kqueue, so the performance
characteristics are expected to be similar. MessagePumpLibevent uses a
pipe as as the ScheduleWork signal source, while MessagePumpKqueue uses
a Mach port, so MessagePumpKqueue will consume two fewer FDs per
instance.

Bug: 932175
Change-Id: I84765a95865d6c9c74053b0fd291035b0bf6d2e1
Reviewed-on: https://chromium-review.googlesource.com/c/1481621
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634906}

Revert "Make GRIT not to generate const struct members"

This reverts commit b7c41be9c2235fa51c1e6e0abd3963d277cc1df2 now that we
don't need to work around the VC++ bug.

Bug: 934323
Change-Id: Id11aeb70bede1144d1ee5f6d354f65239c3e114a
Reviewed-on: https://chromium-review.googlesource.com/c/1484355
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634905}

[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint

When a chunk's effect escapes the layer's effect, abort SwitchToEffect
instead of continuing. This works around the issue and renders correct
in some cases. In other rarer cases, we just don't fail DCHECK.

CompositeAfterPaint doesn't have the issue.

Bug: 932476
Change-Id: I8792f08ccb1f84f70d317f6a560ed6b650ee466e
Reviewed-on: https://chromium-review.googlesource.com/c/1484671
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634904}

Roll src/third_party/depot_tools 298f2cf820df..d7f7a3eb92a4 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/298f2cf820df..d7f7a3eb92a4


git log 298f2cf820df..d7f7a3eb92a4 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 vadimsh@chromium.org [lucicfg] Bump lucicfg version 1.2.0 -> 1.3.2.


Created with:
gclient setdep -r src/third_party/depot_tools@d7f7a3eb92a4

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I711934823b57ae02ff4b06bc0b7836f7ca776b20
Reviewed-on: https://chromium-review.googlesource.com/c/1484612
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634903}

Fix settings change picture video icon vertical alignment

The <div> wrappers for the icon were inheriting text height properties,
which are too tall in Arabic and when "Font Size" is "Very large".

Bug: 919059
Change-Id: Ic66d3b3194ed0060f8c1695825a9796195fbf1f6
Reviewed-on: https://chromium-review.googlesource.com/c/1484499
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634902}

cc: Allow serialization failure for paths.

We currently assume that a path will always serialize to a non-zero size,
and so we should always get a valid path at deserialization. But SkPath
may return a zero size indicating that the given path can not be
serialized. Account for that and just bail out serializing this path.

R=enne@chromium.org

Bug: 924042
Change-Id: I467003ea90efd5915b24b032d079bde2c3c5cacd
Reviewed-on: https://chromium-review.googlesource.com/c/1481084
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634901}

Mark paint/invalidation/window-resize slow

They occasionally timeout (1/10 ~ 1/20) on the bots, perhaps because of
the multiple synchronized window resizes.

Bug: 919789
Change-Id: I748b7362172b0ac407242e8236ae3ef937384f07
Reviewed-on: https://chromium-review.googlesource.com/c/1484732
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634900}

Re-enable tests after fix

Fix here: https://chromium-review.googlesource.com/c/chromium/src/+/1483941


Bug: 934955
Change-Id: Ia5c8723d5fadaae39ab86d871babe17852a9a5b6
Reviewed-on: https://chromium-review.googlesource.com/c/1483875
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634899}

WebUI Dark Mode: change favicon everywhere

Screenshots: https://imgur.com/a/YU4O6hJ

Bug: 871850,926629
Change-Id: I9326518bcaca9206a509b1a8367563f56e3698d2
Reviewed-on: https://chromium-review.googlesource.com/c/1468823
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634898}

Fix DRP not retrying requests because of net errors

This CL plumbs OnComplete to DRP url loader throttle to act on the net errors.

Bug: 934293
Change-Id: I31bf231c80ab96e712f5a3e0a50314ec22cbb1d6
Reviewed-on: https://chromium-review.googlesource.com/c/1483735
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634897}

Roll src-internal d2b61f7238c1..430754bfeef4 (4 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d2b61f7238c1..430754bfeef4


Created with:
gclient setdep -r src-internal@430754bfeef4

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: If11eeb37407b3c8b6a0325674e56463e6138109f
Reviewed-on: https://chromium-review.googlesource.com/c/1484571
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634896}

[Android WebAPK] Fix First Run showing twice for Maps Go

This CL fixes a bug introduced by
http://crrev.com/95ad83cedf394b9b37a8b3ab151116918b8f64ec where the
first run experience would show twice for Maps Go -> the lightweight
FRE launched by WebappLauncherActivity and the full FRE launched by
AsyncInitializationActivity. This CL is a partial revert of the CL.

This CL is simple so that it can be potentially merged back. The
"proper" fix is at
https://chromium-review.googlesource.com/c/chromium/src/+/1478460

BUG=932505
TEST=FirstRunIntegrationUnitTest.testUserAcceptedLightweightFreLaunch


Change-Id: Ic42adfe40eeaf03349ff838d52ee1e99c59f866e
Reviewed-on: https://chromium-review.googlesource.com/c/1476321
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634895}

Suppress conformance_textures_misc_texture_npot_video on Nexus 5X.

Has recently become a bit more flaky (2-3 failures per day) for
unexplained reasons.

Bug: 934545
No-Try: True
Change-Id: I3d185481981c3840459d2d9abb385d8decb16731
Tbr: ericrk@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1483832
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634894}

[Feed] Synchronize has content between scheduler and Feed.

Both the Feed and the host have redundant tracking of several fields.
The scheduler is forced into this because it needs to know some of these
outside of when ShouldSessionRequestData() is called. However, when this
method is called, we get authoritative versions of them from the Feed
library. This change adds synchronization logic to copy the Feed's
version of has content to the scheduler.

Additionally, the synchronization logic around outstanding requests is
updated to go both ways. Previously it only copied the being set state
over, and assumed the other direction wouldn't happen. This change was
made because we're trying to reduce the number of assumptions we are
making and measure things direction.

Also added metrics around syncing these two values.

Bug: 908963
Change-Id: I47303421d656e5c714e0a4e346e27ee8168bdfb8
Reviewed-on: https://chromium-review.googlesource.com/c/1480650
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634893}

Reland "Quota: Add SequenceChecker to QuotaManager"

This is a reland of d82ad3d0eee4f2b98d6f7be7fb2489c55713da69

In the original CL, QuotaManager was modified in two ways:
1. Added SequenceChecker
2. Remove custom deleter and inherit RefCountedDeleteOnSequence

In the reland, I split out the latter into a separate CL and this CL
only adds SequenceChecker to QuotaManager. This was done to
minimize the impact of a potential revert.

RefCountedDeleteOnSequence CL: https://crrev.com/c/1481591

Original change's description:
> Quota: Add SequenceChecker to QuotaManager
>
> Change-Id: I7caa60bf82fdcd63469d58afa0e29f893795ae32
> Reviewed-on: https://chromium-review.googlesource.com/c/1457000
> Commit-Queue: Victor Costan <pwnall@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#631891}

Change-Id: Ia6076d9076e0e0f646b4286a8533ca0a964e3903
Reviewed-on: https://chromium-review.googlesource.com/c/1479302
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634892}

Revert "[Power ML] Change UserActivityPrediction flag to enabled"

This reverts commit 12c3b65c5985b37ae77fdb161e09cc21168dbf26.

Reason for revert: Suspect for failing PowerPolicy browser_tests, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/20473

Original change's description:
> [Power ML] Change UserActivityPrediction flag to enabled
>
> Bug: 862461
> Change-Id: I624d39293e50754629b3b30990828af73f57f0b3
> Reviewed-on: https://chromium-review.googlesource.com/c/1482281
> Reviewed-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Jia Meng <jiameng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634856}

TBR=derat@chromium.org,holte@chromium.org,jiameng@chromium.org

Change-Id: Ic6cee677470af06e5ef5de8d362a2978a37291c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862461, 935044
Reviewed-on: https://chromium-review.googlesource.com/c/1484821
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634891}

[AW NS] provide proper user_agent in onDownloadStart callback and add tests

The user agent is not necessarily set in the request headers
during InterceptDownload (e.g. because they are not initialized yet).

In this patch:
- make sure a user agent is set in the case of uninitialized headers.
- make sure the user agent override is used when it is set by using
WebSetting.setUserAgentString().
- add download related instrumentation tests for the user agent
setting.

Tests:
- AwContentsTest.testDownload
- AwContentsTest.testDownloaWithCustomUserAgent

BUG=893568,841556

Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Change-Id: Ifc432fd93dd68ffb7416a25b6d6d1b5d1021e327
Reviewed-on: https://chromium-review.googlesource.com/c/1477606
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634890}

Cleanup media BitReader ReadBits() calls

Initialize temporary values, check return values.
Small tweaks to solution proposed by adtolbar@microsoft.com.

Bug: 929962
Change-Id: Iaa7da7534174882d040ec7e4c353ba5cd0da5735
Reviewed-on: https://chromium-review.googlesource.com/c/1481085
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634889}

Revert "Move the known CT logs to the read-only data segment"

This reverts commit 90aef9d95d98c323811bc8ac8ae86570954c6d8c now that we
don't need to work around the VC++ bug.

The structure definition move enough that git couldn't actually do the
revert but the four remaining struct members had 'const' manually
reapplied.

Bug: 934323
Change-Id: I605de24decdf24aae4ccbe7af31a44013f21ae7e
Reviewed-on: https://chromium-review.googlesource.com/c/1483949
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634888}

Fixed a crash in AutoResumptionHandler

Bug: 931135
Change-Id: I0358a80dfd25ef009a93703663f6170160586e51
Reviewed-on: https://chromium-review.googlesource.com/c/1483359
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634887}

NetLog: Rework ConnectJob logging.

This CL makes it so that the events for nested ConnectJobs are nested
within their parent ConnectJob. This both reduces the number of top
level CONNECT_JOB events in logs, making navigation between top-level
events easier, and makes it easier to see all information related to
establishing a single connection at once.

This didn't used to be possible because there was a socket pool between
nested ConnectJob classes, which introduced a layer of late binding.
However, most of those intermediary socket pools have been removed,
so the events can now be nested directly, for the most part.

Bug: 926899
Change-Id: I7d51ae9e164560fdb0396f21b0ac85370c4b7ae7
Reviewed-on: https://chromium-review.googlesource.com/c/1478259
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634886}

Fix --force-fieldtrials= changing group of unrelated trials.

The command-line flag would turn off UMA, so as not to bias server-
side data. But this had the consequence of changing how all field
trials are randomized (causing the low entropy source to be used),
which would cause unintended side-effects and in particular make it
very hard to effectively debug trial behavior.

This change updates the logic so that specifying that flag does not
change the state of UMA consent, but instead changes the state of
UMA reporting. This way, field trials are still randomized the
same way, but UMA data is not reported.

Includes a unit test.

Bug: 932273
Change-Id: I4216bb23a9784d963f30d0e2516e1e4d31784ab7
Reviewed-on: https://chromium-review.googlesource.com/c/1479632
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634885}

Changes to include fast app reinstall in chrome://flags.

Bug: 911427
Change-Id: Ic33fd7507d36d0e847598722067ce64802718f9e
Reviewed-on: https://chromium-review.googlesource.com/c/1484391
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634884}

ScrollView: Fix ScrollToPosition() to also update the ScrollBar position.

Using ScrollToPosition() can cause the ScrollView and ScrollBar states to go out
of sync, which causes strange scrolling UX behaviour.

BUG=934013

Change-Id: I4b1518c49c87431baa9d32425f9bff7fc41b4608
Reviewed-on: https://chromium-review.googlesource.com/c/1480194
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634883}

Revert "Move some sniffer arrays to read-only data segment"

This reverts commit 40b53de7f19c627cca389d0904916ba81af58924 now that we
don't need to work around the VC++ bug.

Bug: 934323
Change-Id: I7075d80778737666a906007b73b4a53d350fa772
Reviewed-on: https://chromium-review.googlesource.com/c/1484413
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634882}

[Cros SR] Add training for Arc App Shorcuts

See here for context:

https://docs.google.com/document/d/1GTQ3vvrszK4I1pDzmTFb6krmUzAXox0V9ZIqIi_GH1E/edit?usp=sharing

We are expanding Roselle to re-rank the results returned when the user enters
a query. However, these results include Arc app shortcuts as well as apps
themselves, so they need to be ranked. This CL adds the training support for
Arc App Shortcuts and use Roselle score to update current relevance score.

Bug: 931149
Change-Id: I979ebd500504681c9b0c0e59aa0412b4cbd47315
Reviewed-on: https://chromium-review.googlesource.com/c/1481176
Commit-Queue: Thanh Nguyen <thanhdng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634881}

Let DisplayManager own DisplayConfigurator

ui::DisplayManager can be the single interface for ozone-gbm
clients by moving DisplayConfigurator under DisplayManager
which can simplify the relationship between CrOS shell and
ui/Display/Manager.

In addition, this change will allow ui::DisplayManager to
directly use ui::DisplayConfigurator without
ash::WindowTreeHostManager.

For more details, see the design document at http://bit.ly/2FBXL2c
Bug: 922182

Change-Id: I0e1284024cf89b8369bd8c322473a61a9d9fe07e
Reviewed-on: https://chromium-review.googlesource.com/c/1418315
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Joone Hur <joone.hur@intel.com>
Cr-Commit-Position: refs/heads/master@{#634880}

[fuchsia] Modify runner scripts and build files to use new symbolizer.

* Modify the stream-merging code to output to a pipe instead of a
Python generator, so that the "symbolize" tool can read both app
and kernel logs.
* Rename "build_manifest.py" to "prepare_package_inputs.py" to better
capture the broader scope of that script.
* Add ids.txt generation logic to prepare_package_inputs.py.
* Remove dead codepath for disabling symbolization. Symbolization has
been forced-on by the build scripts with no issues so far, so having
an opt-out is unnecessary.


Bug: 772252
Change-Id: I4e01d0fc5ce96521efa6d0d394e629cb5c7985ff
Reviewed-on: https://chromium-review.googlesource.com/c/1474032
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634879}

Revert "Add flag for #omnibox-deduplicate-drive-urls"

This reverts commit 703661c8155e5f1a0370fa56fa133f24c36de0d8.

Reason for revert: Suspect for failing unit_tests, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/20473

Original change's description:
> Add flag for #omnibox-deduplicate-drive-urls
>
> Change-Id: I48b82707892caa2ed85ab776b6cae73274382fde
> Reviewed-on: https://chromium-review.googlesource.com/c/1481121
> Commit-Queue: Travis Skare <skare@chromium.org>
> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634850}

TBR=jdonnelly@chromium.org,skare@chromium.org

Change-Id: I2b663fc6154ef05e860913f3023e86fc3ed16ca4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1484578
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634878}

Revert "Move seven small arrays to read-only data segment"

This reverts commit aef5c1f5d4a23b24300e2bc3e2099c14e48ce21e now that we
don't need to work around the VC++ bug.

Only the removal of const to work around the VC++ bug was reverted. The
additions of const to move data to the const data segment were retained.

Bug: 934323
Change-Id: I833f62b4b832cdbb2d07436800bc28145c388f86
Reviewed-on: https://chromium-review.googlesource.com/c/1483948
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634877}

Migrate Orientation to the @IntDef

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing @Orientation interface in the form common with Chrome @IntDef:

1. with @IntDef first, @Retention second
and related @interface third
2. with values inside @interface
3. with @Retention(RetentionPolicy.SOURCE)
4. without "static final" in the @interface

BUG=919666

Change-Id: I6e96496eedf82253687c287ea7a70b3c92f63ace
Reviewed-on: https://chromium-review.googlesource.com/c/1480450
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#634876}

Add flag to list all modes of external displays

This CL adds a flag that enables listing all display
modes in the display settings for external displays,
which can be very useful for debugging and development
purposes.

BUG=927848
TEST=Added tests, tested on device with 4k display

Change-Id: I748f2c2b645071723b94a37f759528b6437558aa
Reviewed-on: https://chromium-review.googlesource.com/c/1465682
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634875}

Revert "Enable -Wextra-semi in non-cros non-chromecast non-fuzzer linux builds that have DCHECKs enabled."

This reverts commit 5b911be859f216fe70bad5c41cc91a8684d773f6.

Reason for revert: broke linux_optional_gpu_tests_rel trybot per Issue 935033

Original change's description:
> Enable -Wextra-semi in non-cros non-chromecast non-fuzzer linux builds that have DCHECKs enabled.
>
> Only enables the warning for chromium_code.n
>
> Also fix the last few -Wextra-semi instances in sanitizer and linux/ozone builds.
>
> Getting to this state required fixing > 3000 unique warnings in 15+ different
> repositories. If this breaks some internal-only build somewhere, either consider
> using no_chromium_code for your internal code, or fix the warnings -- it's
> pretty easy. (Build with treat_warnings_as_errors=false, then open the error log
> in vim, run `:%g/warning:/t$` to copy the warnings to the end of the buffer,
> remove all but just those lines, run `:sort u` to get uniques, then save as
> `tmp.txt` and run `:cf %` and then use something like `:map m :w<cr>:cn<cr>`
> to go through them quickly.)
>
> TBR=rsesek
>
> Bug: 926235
> Change-Id: Ica629737523ff6bbd756edc44d182f35ff6cf8ac
> Reviewed-on: https://chromium-review.googlesource.com/c/1483396
> Reviewed-by: Scott Violet <sky@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634826}

TBR=sky@chromium.org,thakis@chromium.org,rsesek@chromium.org

Change-Id: I3fbcb763dbe448619b55f6dbb0cd1bf6d4eebc03
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 926235, 935033
Reviewed-on: https://chromium-review.googlesource.com/c/1484509
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634874}

Style fix In Previews code

Change-Id: I433b70e353291c952c315e0ab2805298e27840dd
Reviewed-on: https://chromium-review.googlesource.com/c/1483945
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634873}

[Sampling profiler] Make ModuleCache::Module a reference type

This is a reland of 8f219b08f98079a0fa18c760b97f13721fe7081e and
9de3faa3e56c402da4c2009c4a277bcff56ea795 merged into a single change,
with test fixes.

* Changes ModuleCache::Module from a value type to a reference type,
with ModuleCache maintaining ownership of the Module. ModuleCache
needs to own its Modules to properly support Windows, which reference
counts its modules. ModuleCache is retained as a struct to minimize
the size of this change, but will be changed to a class in a later CL.

* Moves the parallel module caching implementation for Windows into
ModuleCache. This is required to ensure the referenced modules outlive
the references to them. The parallel implementation will be merged
with the existing module caching implementation over the course of
later refactoring CLs.

Bug: 931418
Change-Id: Ic58afbf4f7bd48a91d0191a37b623b63501c8fa7
Reviewed-on: https://chromium-review.googlesource.com/c/1483393
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634872}

Chrome OS: Fix DCHECK when signing out from secondary display

The secondary display's shelf is not visible.

Bug: 934990
Change-Id: Ida72e29d3be57f0408bc3d0928bb934762bc3476
Reviewed-on: https://chromium-review.googlesource.com/c/1483939
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634871}

Make the GridTabSwitcher appear back

This was a recent regression due to the view not being attach to the
parent anymore. This is for a feature behind a flag and disabled by
default.

TBR=tedchoc@chromium.org

Change-Id: I3091765cb7a254fc489240e7b60779e5ccfa32cf
Reviewed-on: https://chromium-review.googlesource.com/c/1484511
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634870}

Add WidgetObserver methods for drag start/end.

These will be used by test code to trigger events based on dragging. Tests
can't reliably e.g. "queue event to trigger a drag and then call a particular
callback" due to the nested, filtered message loop on Windows. Using drag
observer methods is reliable, and clearer as well.

Bug: 923188
Change-Id: Id24b8150d04dc878dce543fe469994aba29694e4
Reviewed-on: https://chromium-review.googlesource.com/c/1483931
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634869}

Store test placeholders in a set rather than a vector.

Previously, test placeholders were extracted from test_locations_, a std::map,
which implicitly deduplicated the keys. After creating test_placeholders_, I
stored them in a vector. Unfortunately, this causes duplicate entries to occur
when iterations > 1. Storing them in a set returns the previous behavior.

Bug: 934996
Change-Id: I81825b1f95064ac59594b3531cfd8409c631e8f8
Reviewed-on: https://chromium-review.googlesource.com/c/1484074
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634868}

Reland "Disable NetworkChangeManagerClientBrowserTest.ReconnectToNetworkService"

This is a reland of 8af854748f226a99ddcd3b09e55e42414ec02eef

The original author is rmcelrath@chromium.org, yhirano replaced DISABLE_ with
DISABLED_.

Original change's description:
> Disable NetworkChangeManagerClientBrowserTest.ReconnectToNetworkService
>
> This test is flaky on ChromeOS when the network service is enabled.
>
> Bug: 934583
> Change-Id: Ib0a37e995a69555b5a5381bdef24f92fd19c12d9
> Reviewed-on: https://chromium-review.googlesource.com/c/1482005
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634467}

Bug: 934583
Tbr: jam@chromium.org
Change-Id: I87dc76c9e36f25d78279105b03ea9b3340e47718
Reviewed-on: https://chromium-review.googlesource.com/c/1482278
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634867}

cc/paint: Ensure MergePaintFilter serialization is bitness agnostic.

Always use uint64_t to serialize size_t since serialization and
deserialization can occur in processes with different bitness on android
webview.

TBR=enne@chromium.org

Bug: 924042
Change-Id: I54945b0eb1a60910cb9c92e25b6d57388c4aaa85
Reviewed-on: https://chromium-review.googlesource.com/c/1475047
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634866}

app_list: Do not show answer card in experiment

We do not show the answer card when we are showing the embedded
Assistant UI.

Bug: 924624
Test: manual
Change-Id: I08fe6bcfd9e3d4e6bee2fb5236a7246405ecb53f
Reviewed-on: https://chromium-review.googlesource.com/c/1481994
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634865}

Make DropTargetEvent copyable.

This is necessary for creating modified DropTargetEvents (e.g. if you need to
make a provided const event& relative to a new parent).

The primary concern here is |data_|, which is a reference member. Copying a
DropTargetEvent shallow-copies this reference rather than deep-copying it, so
the lifetime of the copied event must not extend past that of the data that was
used to construct the original event. I'm concerned that this change makes it
easier for people to cause UAFs; however, that concern already existed with the
original object, and the right fix is probably not to prevent copying but to
make DropTargetEvent not keep |data_| by reference to begin with. That's a more
involved change than I have the scope to do for now.

Bug: 923188
Change-Id: I35d475081584577cc0217f672a45b5a9e5a60a4e
Reviewed-on: https://chromium-review.googlesource.com/c/1483673
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634864}

Revert "[IndexedDB] Moving IDBDatabase's PendingConnection to use ScopesLockManager"

This reverts commit 1bc0f67478ce43813422fc180b5a8a1106887163.

Reason for revert: causing crashes & flakiness.
Bug: 934640, 934790

Original change's description:
> [IndexedDB] Moving IDBDatabase's PendingConnection to use ScopesLockManager
>
> This allows scopes to be used in the DeleteDatabase call, and cleans up
> some code in the IndexedDBDatabase class.
>
> The last part of the codebase that doesn't have locks before being used
> is the IndexedDBBackingStore::Initialize call. Since this happens on the
> opening of the database, this can probably use just the raw database +
> a WriteBatch.
>
> Bug: 862456
> Change-Id: I89c79ec89a4450e21f1ee700b007ec867b3a4f48
> Reviewed-on: https://chromium-review.googlesource.com/c/1478391
> Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> Reviewed-by: Chase Phillips <cmp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634358}

TBR=cmp@chromium.org,dmurph@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 862456
Change-Id: I30cf895d9846308c26191984f75039306acc86e4
Reviewed-on: https://chromium-review.googlesource.com/c/1484076
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634863}

Roll src/third_party/depot_tools 151c3484da58..298f2cf820df (4 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/151c3484da58..298f2cf820df


git log 151c3484da58..298f2cf820df --date=short --no-merges --format='%ad %ae %s'
2019-02-22 ehmaldonado@chromium.org git cl: Print a clear error message when we fail to find the remote url.
2019-02-22 jophba@chromium.org CppLint changes for VSCode cpplint plugin
2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-02-22 qyearsley@chromium.org [cpplint] Ignore fn_size check for macros with digits


Created with:
gclient setdep -r src/third_party/depot_tools@298f2cf820df

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:914655,chromium:83036
TBR=agable@chromium.org

Change-Id: Id13e16f7ca19ec6dde3638cf336030aecf7cb111
Reviewed-on: https://chromium-review.googlesource.com/c/1483746
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634862}

Handling previously unaddressed fallback test

When navigating to a previews URL directly, the preview code (V1) falls
back to the original URL. In this case, it should not report any
pingback metrics. It is currently DCHECKing, but in release builds it
does report the pingback.

Bug: 934865
Change-Id: I4f1749d9ddeef49e98d3d2ee041669bdce232480
Reviewed-on: https://chromium-review.googlesource.com/c/1483941
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634861}

Import wpt@f7086960db87211ada9cd1bcca3abc0334997d3d

Using wpt-import in Chromium 109f1025dabfc5f6f5ffe47cd9a0460313269bc7.
With Chromium commits locally applied on WPT:
14c111075b "Implement `Sec-CH-Lang`"
df760ab0b2 "Don't skip past auto-height flexboxes in quirks mode."
cd40220a07 "Fix as=fetch preload where preload is used before response arrives"
1d89521e35 "[LayoutNG] Force relayout when constraint spaces change."
98e7141b53 "Fix 2_tracks, 3_tracks wpt/webvtt tests"
f82f5505e7 "[LayoutNG] Fix inline-level OOFs inside a block-level context."
1a46f4bbfc "v8binding: Make PaintWorkletGlobalScope use IDL callback function"
68d5240e06 "[ChromeDriver] Set key modifiers with mouse actions"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Ie2c5645fb11da0174a692dfd8d4b5560e0646f60
Reviewed-on: https://chromium-review.googlesource.com/c/1483731
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634860}

[libxml] Switched from unsigned long to ptrdiff_t in parser.c

Using unsigned long instead of ptrdiff_t results in non-zero
pointer deltas being stored as zero delta, giving incorrect offsets
into arrays and hence out of bounds reads.

This patch fixes the issue in all places in parser.c and adds a macro
to reduce the chances of cut-and-paste errors. A chromium patch for
the libxml roll is added to apply the change to future versions.

The issue has been reported upstream to libxml2 because there are
likely other places in the code where this fails.

R=dcheng@chromium.org,palmer@chromium.org
BUG=894933

Change-Id: I13687c386231374653e499e0557838ed0ddea6af
Reviewed-on: https://chromium-review.googlesource.com/c/1483252
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634859}