LUCI CI Migration Comparison Console

Roll src-internal d712efc691b0..ede8844342e3 (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d712efc691b0..ede8844342e3


Created with:
gclient setdep -r src-internal@ede8844342e3

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=peria@google.com,poromov@google.com,eirage@google.com

Change-Id: I6af37f73761b5bb5c0ef4f72c12f7f59512fe129
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680362
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672840}

arc: Verify the service connection before passing the interface

To eliminate the flakiness, verify the connection to the camera service before returning the interface pointer to Android.

BUG=b:134935100
BUG=b:124946090
TEST=cts-tradefed run commandAndExit cts --include-filter CtsCameraApi25TestCases --include-filter CtsCameraTestCases

Change-Id: Id5b5284eaa26c1b4b082a81559689f5935c31467
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678910
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672839}

Delete pre unified consent code in browser/preferences

As unified consent is rolled out the code that existed before will be
gradually removed. This is part of a series of cls to remove them.

Bug: 978908
Change-Id: I3941ab8440681cb4d62c22d24be551ab0caaa8f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678197
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@google.com>
Cr-Commit-Position: refs/heads/master@{#672838}

Remove pre unified consent code from browser/firstrun

As unified consent is rolled out the code that existed before will be
gradually removed. This is part of a series of cls to remove them.

Bug: 978908
Change-Id: I702a7d1471dddc26d37d67062be6a509e767de4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678478
Commit-Queue: Tanmoy Mollik <triploblastic@google.com>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672837}

Disable failing VrBrowserNativeUITest.*

This CL disables following tests:
- VrBrowserNativeUiTest#testSecurityTokenOnHttp
- VrBrowserNativeUiTest#testSecurityTokenOnHttps
- VrBrowserNativeUiTest#testSecurityTokenOnHttpsBadCertificate

The tests can be re-enabled after updating golden images.

Bug: 979145
TBR: bsheedy@chromium.org
Change-Id: I2e0c398c3b99281b314567876afa54eae60d2fd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680252
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672836}

Roll Fuchsia SDK from 890954657779 to 890951895862


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I7c744db63db1a0978504fffb6b1e9326ae4325ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680359
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672835}

Fix bad placeholder string in Preload + SRI tests

R=yhirano@chromium.org

Bug: 677022
Change-Id: Iac6114a810417c115e92aaa7cfb0c2b978d563f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679139
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672834}

CSS: Remove unused CSSURLImageValue::Create() method.

This seems to have no callsites. Also remove FromCSSValue() which is
just a wrapper around MakeGarbageCollected.

Change-Id: I3fd79d58fd54606555d80f716c9ca979cc975ccf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680121
Auto-Submit: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672833}

IDL: Put [Exposed=Window] where it's not in Blink's renderer/modules/screen_orientation

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1],
many blink's IDL files have not followed it yet. So, this CL adds the keyword
to the IDL files which don't have the keyword yet in the renderer/module/screen_orientation
directory.

[1] https://github.com/heycam/webidl/issues/365

Bug: 963267
Change-Id: If6aeef6479a6d975a52e5135fa5956918f1c31ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672609
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#672832}

Speculatively remove some more WebRTC TSan suppressions

A TSan try bot run with the suppressions run seems to be clean:
https://ci.chromium.org/p/chromium/builders/try/linux_chromium_tsan_rel_ng/310919

Bug: 244774
Change-Id: I2c8ed94924fb8a45b791404a23ee52801870de4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676989
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672831}

[Passwords] Introduce FillingSource::TOUCH_TO_FILL

This change introduces a TOUCH_TO_FILL enumerator to the FillingSource
enum and gets rid of ManualFillingController::ShowTouchToFillSheet(), as
it's no longer needed.

Bug: 957532
Change-Id: Ib55a1eeff9f98e140eb6c0b16aee949f14d39a16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678370
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672830}

IDL: Put [Exposed=Window] where it's not in Blink's renderer/modules/remoteplayback

Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1],
many blink's IDL files have not followed it yet. So, this CL adds the keyword
to the IDL files which don't have the keyword yet in the renderer/module/remoteplayback
directory.

[1] https://github.com/heycam/webidl/issues/365

Bug: 963267
Change-Id: I6cdacad1e184eb2b7cc126f04a3e252cd032e463
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673405
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#672829}

Make MediaRecorderHandlerClient GarbageCollectedMixin

This is a part of moving media recorder implementation to blink and
a follow-up CL of https://crrev.com/c/1672138.
This CL makes MediaRecorderHandlerClient GarbageCollectedMixin and
MediaRecorderHandler has Member<T> instead of the raw pointer.

Bug: 960665
Change-Id: Ic80a51b8182edb433a09dbb99b84d09bfe9e5b4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672141
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672828}

[Extensions] Improve install/startup time for force-installed extensions

This CL drastically improves install and startup time for force
installed extensions on the login screen. Up until now, these were
blocked on extension cache initialization and and the extension update,
which both posted tasks with TaskPriority::BEST_EFFORT. Execution of
tasks with that priority is delayed until some startup signal was
emitted, which can take between ~5-10s. With this change, force
installed extension start on the login screen in ~1s.

Bug: 933339, 978846
Change-Id: Iba5155fc6b5cf23fe2a970a4ca66640852412b88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670898
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672827}

Extend lifetime of Media.Audio.Capture.StreamBrokerDisconnectReason

Also remove me as owner, as I haven't done anything related to the
audio service in quite a while.

Bug: 974918
Change-Id: I57ce8c9e37989d6444492a89a45c1210ccdc8504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677169
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jonas Olsson <jonasolsson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672826}

Roll src/third_party/skia 98861f69c63d..1ebcc2e1d2dc (2 commits)

https://skia.googlesource.com/skia.git/+log/98861f69c63d..1ebcc2e1d2dc


git log 98861f69c63d..1ebcc2e1d2dc --date=short --no-merges --format='%ad %ae %s'
2019-06-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-06-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6d58266ed63a..f857b5014e09 (11 commits)


Created with:
gclient setdep -r src/third_party/skia@1ebcc2e1d2dc

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=djsollen@google.com

Change-Id: I8c52be27ec9d8b6691a01922b5fb4e288156fac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680128
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672825}

Add ProfileHelper::SigninProfileHasLoginScreenExtensions()

This CL adds a helper method to ProfileHelper to check whether the
sign-in profile has force-installed login screen extensions. This
method is used in a follow-up CL to determine whether the extension
cache should be created with a higher task priority.

Bug: none
Change-Id: If9b2a2204c68a484217024d0ab549b2fc1bef837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678499
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672824}

Add ScopedDoNotUseUIDefaultQueueFromIO

In some circumstanecs you need to specify a BrowserTaskType or a priority when
posting a task from the IO theread to the UI thread or you risk inadvertant
task reordering. This patch introduces ScopedDoNotUseUIDefaultQueueFromIO an
RAII helper which causes PostTask on the UI thread's default task queue from
the IO thread to DCHECK.

The idea is to place ScopedDoNotUseUIDefaultQueueFromIO in contexts where
you're explicitly prioritizing certain tasks and it will guard against future
PostTasks which might otherwise get flakily reordered.

Bug: 863341
Change-Id: I67a56b2747b8bdd1ef35ec3652b55f1dc7ea830c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660340
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672823}

Re-enable BidirectionalStreamQuicImplTest with QUIC v99.

Change-Id: I39b4f0a1b27e901d6c97c127f34184c88e8350e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677740
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Auto-Submit: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672822}

Avoid copying dbus responses in CrostiniManager

This CL tidies the handling of dbus responses in CrostiniManager to use
the responses directly out of the base::Optional type instead of copying
these to a separate local.

Change-Id: I49061772771e702447c5d68badf7c134137df18e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679610
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672821}

Deprecate Media.Audio.Render.BrowserCallbackRegularity.* histograms.

Bug: None
Change-Id: I06204797a82a44083b04b9c6a221f784d7312c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672863
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672820}

Add test runs with BackForwardCache on linux-fieldtrial-rel.

Updating linux-fieldtrial-rel to also run some basic bf cache tests,
as a FYI for ongoing dev efforts.

Bug: 976218
Change-Id: Idc40820bccfd66622a1d4227884b0edc2c57c089
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676164
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672819}

Remove unused __gCrWeb.message.getMessageQueue.

Change-Id: Ic8369cffb6a2e5793ce4419d7981bd90f3d9346e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675355
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672818}

Allow more environment variables to enable AuraLinux accessibility

Bug: 977112
Change-Id: I18a2162d22fc06d5e1a3e6e7fef87989a1b169d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670212
Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com>
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Cr-Commit-Position: refs/heads/master@{#672817}

[Web Apps] Log WebApp install failures.

This CL adds LOG(ERROR)s for all PendingAppManager install failures, and logs
System Web Apps, Policy Web Apps and Default Installed Web Apps results to
WebApp.InstallResult.(System|Policy|Default).

Bug: 972926, 836128
Change-Id: I9e0241b23622cb1fbd4ea6b17a3cb31a50f8e3c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669027
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672816}

Move data wipes to ChromeSigninManagerDelegate JNI

This completes the Jni counterpart of the java
ChromeSigninManagerDelegate which provides access to android specific
dependencies on //chrome/browser to the componentized java
SigninManager.

This implements (moves) WipeProfileData and
WipeGoogleServiceWorkerCaches to the delegate. The
signin_manager_android_unittest are focusing on these functions and
moved to chrome_signin_manager_delegate_unittests.

This removes most of the chrome/browser dependencies from
signin_manager_android. The following remain: profile_manger,
identity_manager_factory, browser_process. A later stage of the project
will handle those.

details in document:
https://docs.google.com/document/d/18887XeZNJ9pmoTdJducssk5_yVU2CQ3EqaRFoMqWCCk/

Bug: 963402
Change-Id: Ibd8553a8c7248033f9af70a0d0dcd07df2b27d08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655451
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672815}

[modules/mediastream] fix missing dependency

mock_constraint_factory.cc includes
third_party/blink/public/platform/modules/mediastream/media_stream_audio_processor_options.h
in //third_party/blink/public:test_headers

Bug: 979097
Change-Id: I422b1fd5233de9a8faed1872d00db2411fef9345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680249
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672814}

Replace usage of CrostiniResult with a success bool where possible

This CL simplifies the public interface of CrostiniManager by changing
many of the callbacks with a CrostiniResult argument, which is a large
enum, to take a success bool. We also make various other clean ups,
like moving callback definitions to where they are used, and removing
extraneous error logging (the CrostiniManager logs when it encounters
errors, so users of it shouldn't also log the same errors).

Change-Id: I444072f79d915447b63c1e7eb0f5d49e1256bec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680115
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672813}

Extend expiry for WebRTC text logging histograms.

These are still used.

Bug: 915679,967495
Change-Id: Ibc4328bd72e91d99ac633d8b735d67fb1df459c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674020
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672812}

std-switch and std-toast: Share reflection.mjs

Move it to elements/internal.

This CL introduces a concept of private built-in modules.
Before this CL, generate_lapi_grdp.py assumed a directory with
'index.mjs' represents a built-in module.
After this CL, such directories represent web-exposed built-in
modules as ever, and a directory of which last path component is
'internal' represents a private built-in module, which can be
imported from other built-in modules. A private built-in module
have no 'index.mjs', which is mapped to a public 'std:' URL.

Bug: 972476, 972945
Change-Id: Iba571534cd608898b9a73d2bf2aa669be772f51b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675064
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672811}

Update audio delay histogram expiry.

These will be used during audio process launch.

Bug: 969921
Change-Id: Idb6e92fc646bc47e07c268fc96868198ac74268f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674016
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672810}

[WebSocket] Remove WebSocketHandleClient interface.

Since the interface is inherited only by WebSocketChannelImpl and
no mocking test for it, we should remove it for simplicity.

Bug: 977912
Change-Id: I9e1595e6cac7e57047431fc2c121fab1913fec71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660298
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672809}

Add Preload + SRI web platform tests for script + style destinations

More preload destinations will be added after this CL, as well as the
main Preload + SRI implementation, to keep the changes here minimal.

R=kouhei@chromium.org, yhirano@chromium.org, yoavweiss@chromium.org

Bug: 677022
Change-Id: I596ac006874fb02bcd330422bd6496a05d388d45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669954
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672808}

[Dolphin] Restructure predictor config protos.

Currently, we configure a RecurrencePredictor by specifying it in the
RecurrenceRanker's config. This is a problem for ensemble model
configs, which might need several predictor configs nested inside each
other.

This CL pulls out the config for a predictor into its own message, so
that they can be more easily nested. Additionally, it moves the
MakePredictor utility function to its own file accessible from both the
ranker and predictor classes, to make constructing predictors within
other predictors easier.

Note that we're already making several backwards-incompatible changes
to the config protos in this release, so changing the format isn't
an issue here.

Bug: 921444
Change-Id: Ic5d387f94db02f00712059855a76bc70231d29c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677168
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672807}

Port UploadJobImpl to take in OAuth2AccessTokenManager

UploadJobImpl currently takes in an OAuth2TokenService object, which
it uses to make access token requests. The methods called directly call
through to underlying OAuth2AccessTokenManager methods. This CL ports
UploadJobImpl to directly take in an OAuth2AccessTokenManager object
to ease the upcoming elimination of OAuth2TokenService.

Note that an alternative option would be to have UploadJobImpl take in
a DeviceOAuth2TokenService object. However, this would turn the unittest
into a real bear, as there is no trivial way to mock out the heavyweight
DeviceOAuth2TokenService class.

Bug: 967598
Change-Id: I0ce3ff0e3c6a1c75dc8748ec1197d46cfaf64fda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678040
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672806}

Roll src-internal 02daa7efc59a..d712efc691b0 (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/02daa7efc59a..d712efc691b0


Created with:
gclient setdep -r src-internal@d712efc691b0

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=reillyg@google.com,yhirano@google.com,futhark@google.com

Change-Id: I9ae2bf80cd4e77c2cf02e37b5af434e3b56d210f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680122
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672805}

[App Management] Hide more permissions for some built in apps.

Hide the more permissions button for the Files app and the Web Store.

Bug: 972989
Change-Id: I6bee705b7ad74085003677f436a4440fca4d8be9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675545
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672804}

Roll src/third_party/freetype/src 81445c034aca..7b1c7585d7ab (1 commits)

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/81445c034aca..7b1c7585d7ab


git log 81445c034aca..7b1c7585d7ab --date=short --no-merges --format='%ad %ae %s'
2019-06-27 apodtele@gmail.com * src/bdf/bdfdrivr.c (bdf_cmap_char_{index,next}): Fix inequality.


Created with:
gclient setdep -r src/third_party/freetype/src@7b1c7585d7ab

The AutoRoll server is located here: https://autoroll.skia.org/r/freetype-chromium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
TBR=bungeman@google.com,drott@google.com

Change-Id: I832160287f402c6ceb84e597c00f7207ac5d34b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679559
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672803}

Run dawn_end2end_tests with backend validation layers

Run dawn_end2end_tests with "--enable-backend-validation" to apply more
API checking from validation layers of backends.

BUG=dawn:150

Change-Id: Iae1fa050596df1d8e26425f6b7af451ef8440783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650958
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Hao Li <hao.x.li@intel.com>
Cr-Commit-Position: refs/heads/master@{#672802}

IDL Compiler: Impelement Proxy, Reference, and its Factory

In order to resolve cross references of identifiers to
IDL definitions, this CL creates a proxy and some related
class to do it.


Bug: 839389
Change-Id: Ia65f9f1310dcf3b88d702efec3d87d6b02eba7de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662981
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672801}

Roll src/third_party/skia 4e2033e84374..98861f69c63d (39 commits)

https://skia.googlesource.com/skia.git/+log/4e2033e84374..98861f69c63d


git log 4e2033e84374..98861f69c63d --date=short --no-merges --format='%ad %ae %s'
2019-06-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a7f016080642..1fffa0139440 (380 commits)
2019-06-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9770a4660fc9..522d51219054 (7 commits)
2019-06-27 egdaniel@google.com Revert "add operator "" _mask() to make Assembler clearer"
2019-06-27 egdaniel@google.com Revert "Reland "Separate compressed and uncompressed texture functions""
2019-06-27 mtklein@google.com add operator "" _mask() to make Assembler clearer
2019-06-27 egdaniel@google.com Reland "Removed made-up kSBGRA pixel config."
2019-06-27 bsalomon@google.com Reland "Separate compressed and uncompressed texture functions"
2019-06-27 bsalomon@google.com Revert "Replace GrQuadList with variable-length quad buffer"
2019-06-26 bsalomon@google.com Revert "Removed made-up kSBGRA pixel config."
2019-06-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-06-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-06-26 rmistry@google.com Increase timeout for android compile bots
2019-06-26 mtklein@google.com 128-bit load / store
2019-06-26 bsalomon@google.com SkUNREACHABLE
2019-06-26 mtklein@google.com some scalar ops
2019-06-26 egdaniel@google.com Removed made-up kSBGRA pixel config.
2019-06-26 brianosman@google.com When using cached program binaries, always get uniform locations
2019-06-26 egdaniel@google.com Disable VkTransitionExternalQueueTest.
2019-06-26 bsalomon@google.com Revert "Separate compressed and uncompressed texture functions"
2019-06-26 michaelludwig@google.com Replace GrQuadList with variable-length quad buffer
2019-06-26 bsalomon@google.com Separate compressed and uncompressed texture functions
2019-06-26 halcanary@google.com header self-sufficiency and idempotency
2019-06-26 herb@google.com Make all SkGlyph fields private
2019-06-26 halcanary@google.com experimental/editor: app layer: setTitle
2019-06-26 csmartdalton@google.com Remove "nvpr" configs
2019-06-26 rmistry@google.com [skottie-wasm-perf] Add retries when calling puppeteer
2019-06-26 brianosman@google.com Fix and update the Intel GPU string parsing
2019-06-26 mtklein@google.com disable SkVM perf dumps
2019-06-26 rmistry@google.com [skottie-wasm-perf] Catch and exit with error if browser does not open
2019-06-26 herb@google.com Remove getGlyphMetrics from the interface
2019-06-26 fmalita@chromium.org [skottie] Venetian Blinds effect
2019-06-26 borenet@google.com [infra] Make Isolate*, BundleRecipes, and BuildTaskDrivers idempotent
2019-06-26 robertphillips@google.com Update SkSurface_Gpu::Valid to take a backend format
2019-06-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-06-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-06-26 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 3b2255975f37..6d58266ed63a (7 commits)
2019-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src aab9fad64483..a7f016080642 (454 commits)
2019-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e899321b0bf7..9770a4660fc9 (2 commits)


Created with:
gclient setdep -r src/third_party/skia@98861f69c63d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:977938
TBR=djsollen@google.com

Change-Id: Ic1423a6dd18c578cbe0f6299703531dd3ca53a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680116
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672800}

heap: Temporarily disable compaction

This disable heap compaction for Oilpan.

Bug: 971424
Change-Id: I08bba868f27665dd019d87279ece2855d54d1575
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678374
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672799}

[App Management] Hide System Web Apps from App Management.

Hide System Web Apps from App Management.

Bug: 906508
Change-Id: Ic4503e8cf2d5b016a6a154abe13bcdaa1c103e36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675564
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672798}

Added a utility to dump wayland documentation.

This feature involves grabbing the documentation from the xml, and
having a template instantiate that documentation.

Mainly this is a more useful way of getting protocol docs than hunting
through large unindexed XML files on codesearch.

Bug: 961564
Change-Id: Icf4c494ed2f17aa22a5a205beb6d046f463df2e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678971
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Nic Hollingum <hollingum@google.com>
Cr-Commit-Position: refs/heads/master@{#672797}

[Web Apps InstallOptions] Rename always_update to force_reinstall.

Bug: None
Change-Id: Id0ea2f915fba450159737ff19fff26269cbe88c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675347
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672796}

CrOS Shelf: Rename AppListButton --> HomeButton

This change was created mostly with the help of sed and mv :-)

Bug: 973443
Change-Id: Id7c15d67e7be3ec20859fa26f43ad88145a16b96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679163
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672795}

[RunLoop] Ban off-thread usage of Quit*Closure()

The only reason for the fancy detach in RunLoop::RunWithTimeout() was to
enable calls to Quit*Closure() from another thread while running. But
that's not necessary as Quit*() is thread-safe (fixed the callers that
did so).

Bug: 715235, 961608
Change-Id: I3f8dca467a6ff97c87022f7c0c57ab8d4bc8df1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663382
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672794}

service worker: Run some browser_tests with disabling OTMT fetch

To have better test coverage until we fully ship
off-the-main-thread script fetch.

Bug: 967272

Change-Id: I688a8772cb54bbbcedab9a27a332f09bb067b1c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674984
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672793}

Prevent intercepting background service downloads by offline pages

This fixes a bug for uploads not getting completed as they have mime type
as text/html. The fix is to not let offline page backend intercept the
downloads if they are spawn from background service.

Bug: 976614
Change-Id: I99ebf8f0d9766baa4867ae17df470c72e2fe6c90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669878
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672792}

Roll src/third_party/swiftshader cd98c739bbc0..522d51219054 (1 commits)

https://swiftshader.googlesource.com/SwiftShader.git/+log/cd98c739bbc0..522d51219054


git log cd98c739bbc0..522d51219054 --date=short --no-merges --format='%ad %ae %s'
2019-06-27 capn@google.com Simplify Vulkan ICD loading for testing


Created with:
gclient setdep -r src/third_party/swiftshader@522d51219054

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Change-Id: I5c00ebae15eec0acf00ccb06bd85aba64e360dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680069
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#672791}