Chromium Main Console
| Legend: | Passed | Failed | Failed Again | Running | Exception |
Remove Android Lollipop workaround for software decoders
Bug: 1265606
Change-Id: I2a26d39e8d7983d7b0413e8faa435465c9ee5b7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256405
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937207}
Clean up PageLoadMetricsTimerDelay feature.
Bug: 1257238
Change-Id: I8c55b2581cba179910e8abc19bf1c1b4dba380e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3236777
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937206}
BRP: Enable PartitionAllocBackupRefPtr for FYI bots
Modifies gtest_args for BRP FYI bots.
This will be landed once the BRP FYI bots becomes green.
Bug: 1167694
Change-Id: Ieb06de695094b2e49a24f434eed5f41c3372e35e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3212279
Commit-Queue: Yuki Yamada <yukiy@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Cr-Commit-Position: refs/heads/main@{#937205}
[Copy To Clipboard] Add filename copying.
This CL adds filename copying support to copy to clipboard
and moves the shared FileSystemUrl to FilePath conversion code
to a utility file.
Bug:1244143
Change-Id: Iea7725abe33349ec4c7f2785f630cc96c3b4e892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3233712
Commit-Queue: Melissa Zhang <melzhang@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937204}
Reorganize PageInfoBubbleView code slightly.
When LayoutPermissionsLikeUiRow() was introduced, the refactor also
introduced a small bug in the "empty list" case: control did not
immediately return from SetPermissionInfo() like it had before. Fix
this by reverting that refactor, now that no one else calls this
function. This tweaks the visible padding in the "v1" page info bubble
(I didn't see any visible effect in v2).
This is also useful for an upcoming change to remove GridLayout, since
it localizes the grid setup to where objects are added to the grid. For
similar reasons, move the "chosen object" grid setup to just above the
loop that adds chosen objects.
Bug: none
Change-Id: If2dff2e73f8bf86fb1e070eeb987af0cb0fb1acd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3255326
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937203}
[Region Capture #4] Glue Viz and CC Layers Together
Overall feature:
----------------
Region Capture is a feature allowing the cropping of self-capture video
tracks to track the coordinates of an HTMLElement in the browsing
context.
Public design-doc:
https://docs.google.com/document/d/1dULARMnMZggfWqa_Ti_GrINRNYXGIli3XK9brzAKEV8/edit?usp=sharing
Spec draft (very WIP): https://eladalon1983.github.io/region-capture/
(This will be finished soon and moved to the WICG; hopefully to be
eventually adopted by the W3C.)
This CL:
--------
This patch includes the final changes to get produceCropId working end
to end, by connecting the CC changes and Viz changes landed in previous
patches through the compositor frame metadata class.
Instead of putting the capture bounds on individual render passes,
the capture bounds now reside on the CompositorFrameMetadata class and
are populated by the LayerTreeHostImpl.
Next CLs:
---------
No implementation patches, only bug fixes and cleanups from here on out!
Bug: 1247761
Change-Id: I0a7527020e239dca0aef25c1f531179ca06cf757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3229811
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937202}
Fixed failure browser test with real setTimeout 0
Currently setTimeout(..., 0) is clamped up to 1ms in Chromium
while which is not supposed to be in the spec. This CL is
intended to fix following browser tests that become flaky with
https://chromium-review.googlesource.com/c/chromium/src/+/3243793/3
- BluetoothPairingUiTestV3.All
By reusing the `flushTasks` from test_util.js file, and replacing
`flush()` with `flushTasks` to make sure flush happen.
Bug: 402694
Change-Id: If1428953dc4e7b712cd8d3ee0641cad509a0cbd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3248675
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937201}
Roll Skia from c7c49f5656ab to 15f17c057624 (1 revision)
https://skia.googlesource.com/skia.git/+log/c7c49f5656ab..15f17c057624
2021-11-02 robertphillips@google.com Revert "[graphite] Fill in basic vertex and index buffers."
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: robertphillips@google.com
Change-Id: I3ac8f88691f99372a08c14e66a1b57693747f04c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256471
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#937200}
Roll PDFium from bd93f46dfc3d to f15af61d9d2a (8 revisions)
https://pdfium.googlesource.com/pdfium.git/+log/bd93f46dfc3d..f15af61d9d2a
2021-11-02 thestig@chromium.org Remove a nullptr check in CXFA_FFDoc::BuildDoc().
2021-11-02 tsepez@chromium.org Avoid c_str() in FX_OpenFolder() calls
2021-11-02 tsepez@chromium.org Remove .c_str() from calls to SystemFontInfoIface::GetFont().
2021-11-01 thestig@chromium.org Replace CXFA_LayoutProcessor's changed containers with a bool.
2021-11-01 tsepez@chromium.org Replace c_str() with AsStringView() in FX_ParseDateUsingFormat()
2021-11-01 tsepez@chromium.org Pass ByteString by value to TT_NormalizeName().
2021-11-01 tsepez@chromium.org Avoid duplicate bytestring construction in IsValidNumericDictionaryValue()
2021-11-01 tsepez@chromium.org Revert "Remove raw wchar_t pointers from fgas/font"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in PDFium: https://bugs.chromium.org/p/pdfium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Ia6f9926097fa380c5354d151dde5f78a769b57cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256962
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#937199}
[Launcher] Add new RemoveResult() method to ranker interface.
This CL adds a skeleton of the method and wires it up to
SearchControllerImplNew. The implementation will be in a follow-up CL.
RemoveResult() is called each time a user removes a result from the
search results list. Currently we special-case the removal of Omnibox
results, which are handled by the Omnibox autocomplete controller.
Bug: 1263751
Change-Id: I56a71f7401de78e7c16293c76c5b35a3b80a52eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3253044
Reviewed-by: Tony Yeoman <tby@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Auto-Submit: Amanda Deacon <amandadeacon@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937198}
[GridNG] Separate NGGridData into placement and layout data
Previously, some information from `NGGridPlacement` and the resolved
positions for grid items were stored into the layout result with the
purpose of reusing it if the items didn't changed their placement.
For subgrid, this cached data will be very useful since placement of
grid items in a subgridded axis needs to happen before the subgrid's
parent starts its sizing algorithm. However, storing the cache in the
layout result implies that the sizing algorithm needs to finish first.
In order to break the circular dependency, this change separates the
data that we cache into two categories: placement and layout.
Placement data needs to be available before any grid container tries to
resolve its track sizes, thus, this change moves it into `LayoutNGGrid`.
On the other hand, layout data will remain stored in the layout result.
This change shouldn't have any behavioral impact.
Bug: 618969
Change-Id: If8aa762eb4140dc68a8623df7de1852165c1892a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252262
Commit-Queue: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937197}
[mparch] Remove the TODO in PaymentCredential
This CL removes the TODO generated for a conversion to
IsInPrimaryMainFrame in PaymentCredential::DidStartNavigation.
Bug: 1218946
Change-Id: I1313f237da585f76442c7915c027659cbc52e617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3223040
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937196}
[Code Health] Pass skip_shebang_check=True with PRESUBMIT.py's under
tools/json_schema_compiler, tools/json_to_struct,
tools/media_engagement_preload, tools/tracing, tools/idl_parser
Bug: 1262337, 1262338, 1262339, 1262340, 1262343
Change-Id: I3197a5ce9aad688a0b01ee74f2908abee704346f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252497
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937195}
Updating trunk VERSION from 4689.0 to 4690.0
# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
Change-Id: Ib11bb8d439f32e09de153cae5035ea4d5d7176cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3257141
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#937194}
writable_stream_default_controller.h iwyu
Stop including writable_stream_default_controller.h in
underlying_sink_base.h and fix the files that were depending on it being
exported.
Change-Id: I5a45f6a021731ca54bfc028988d2dc5cc1c1c5c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3253284
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937193}
AX: Improve CanSetFocusAttribute performance by caching the result.
This patch caches CanSetFocusAttribute result and uses it when needed.
Note that this doesn't follow the typical pattern of updating the cache
because this value can change in response to a new style update,
independently of the ax cache modification count.
Also, this is a fairly heavy function which is not always needed, so
having it be computed in the general cache update can cause a
performance degradation
Perf test results:
test: third_party/blink/perf_tests/accessibility/many-nodes-toggle-content-visibility-auto.html
no patch: 6839ms
patch: 5917ms (-13%)
test: third_party/blink/perf_tests/accessibility/many-nodes-toggle-content-visibility-hidden.html
no patch: 5139ms
patch: 4681ms (-9%)
R=aleventhal@chromium.org, chrishtr@chromium.org
Bug: 1264610
Change-Id: Ie8574ae28baa81d8d2be738560bf0a5a81fdd2bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252717
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937192}
Fixed additional failure web tests with real setTimeout 0
Currently setTimeout(..., 0) is clamped up to 1ms while which is
not supposed to be in the spec. This CL is intended to fix the tests
that become flaky with
https://chromium-review.googlesource.com/c/chromium/src/+/3243793/3
Bug: 402694
Change-Id: Ia3058131b8ea8a1b9abfa63e1e4975eebf3785ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3249730
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Cr-Commit-Position: refs/heads/main@{#937191}
Roll TFLite to Next Green Version
This also updates the Eigen3 README to match what's in DEPS
Version Changes:
tflite: bacf1d1c743fb37fbeda0e42939af2e640a2e893 to 77a0a88a0bfebad30dd8b3cc6349133fcb9567e4
Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-compile-rel
Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Cq-Include-Trybots: luci.chromium.try:android_arm64_dbg_recipe
Cq-Include-Trybots: luci.chromium.try:android_compile_x64_dbg
Cq-Include-Trybots: luci.chromium.try:android-pie-arm64-dbg
Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng
Change-Id: I77cc7053d952c80148702a92b544fbe85941c251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3254776
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937190}
[weblayer, skew tests] Refresh skew tests for M96
This CL will add skew tests for version 96.0.4664.33. See crbug.com/1041619
and crbug.com/1099017 for more information.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: None
Change-Id: I39c38b4dc0b1c578d66de71c28a129fa40257e36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256384
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#937189}
Fix a DCHECK for nodes moved during mousedown
Fixed: 747207
Change-Id: I6fcc0ddcaf94bddffc809f5822c8ae8bfdcfbf1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252278
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937188}
Updating XTBs based on .GRDs from branch main
Change-Id: Id3465782cf94658d6ae015a04045df048d6dc216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256103
Auto-Submit: Ben Mason <benmason@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#937187}
Fix DCHECK in editor FindString command
This bug and fix is very similar to crbug.com/1251072. I made the same
fix as that bug, I didn't know that there was another place in editing
that could run Editor::FindString like window.find() does for the
mentioned bug.
I verified that this change fixes the clusterfuzz test case, and I also
added a similar test case to the one I added in crbug.com/1251072.
Fixed: 1264507
Change-Id: I24067700444d9a0ea79211c4324845d453fc9d89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3253512
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937186}
Roll Open Screen from c826f69db459 to 3ea21022232b (1 revision)
https://chromium.googlesource.com/openscreen.git/+log/c826f69db459..3ea21022232b
2021-11-02 mfoltz@chromium.org [Open Screen] Remove calls to python from DEPS.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jophba@chromium.org
Change-Id: I76e4dfaadfc45fff19796e91c235e1108b2ba28e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256346
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#937185}
[dPWA Testing] Add generated tests for UninstallFromList action.
This adds the generated tests that are now supported because the
UninstallFromList action has been added.
This change also includes some CUJ list modifications that remove the
'uninstall_from_menu' action from the ChromeOS critical user journeys.
Bug: 1145224
Change-Id: I616e546b07f155bb7db8de7b6f88fe5b893c1fc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252305
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937184}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1635800135-1e612b65f97ba5a5bfa8a30ad0f8aa5cb3c71ae0.profdata to chrome-win32-main-1635811042-a2643150e1a7f3616dc66fd0a4302733969ffed5.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia48eea4cbaf42035353b6df29bbbe70148c7d015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256411
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#937183}
WATCHLISTS: fix polymer match
remove trailing '|' in last entry; since:
e7a443fb01e01 Cleanup various WebUI related paths in WATCHLISTS.
Change-Id: I20a1b670666b6f2ea858411f2b3b5d2f454f9446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256418
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/main@{#937182}
[suggested files] Add metrics for QPS calculation.
This CL adds a metric that measures QPS under new ItemSuggest query
logic. Some of this CL is copied from crrev.com/3244990, and see
go/launcher-launch for full specs for the logic.
Bug: 1263257
Change-Id: I831ba0e2f9f87f4c33997bc03ce961f28c80983f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3255062
Reviewed-by: Tony Yeoman <tby@chromium.org>
Commit-Queue: Rachel Wong <wrong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937181}
Update bulk entries in HSTS preload list
Change-Id: I7baab5d6c0435e31afc210862b7c9820f96e2b03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256091
Auto-Submit: Devon O'Brien <asymmetric@chromium.org>
Commit-Queue: Chris Thompson <cthomp@chromium.org>
Reviewed-by: Chris Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937180}
[Capture] Remove SlowWindowCapturerChromeOS
This patch removes the legacy SlowWindowCapturerChromeOS, now that the
replacement aura capturer is stable.
Bug: 1210549
Change-Id: I1b2099f0b3ce45411dddcd9d57d9bb6b978e27a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245222
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937179}
Update Media.Remoting Histograms Expiry
This patch updates all Media.Remoting histograms to expire one year
from today. Some histograms, such as VideoCodecProfile, are expiring
within a few weeks, while others are expiring in Q1 or Q2 of next year.
This patch just standardizes all Media.Remoting histograms to expire at
the same time, causing us to need to update them only once a year,
instead of the current piecemeal 4-6 times a year.
Bug: 1253420
Change-Id: Icb9bb1622f2f99b401d79b6d0588a7d7cffb8505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245878
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937178}
Fix typo
Bug: 1260491
Test: autoninja -C out/Default chromeos_components_unittests && out/Default/chromeos_components_unittests --gtest_filter="NotificationProcessorTest*"
Change-Id: I79b3abbf934523b0d9693606253703c59a16b889
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3251818
Commit-Queue: Sam Chiu <samchiu@google.com>
Reviewed-by: Jon Mann <jonmann@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937177}
Add human readable Media Session title for SWAs.
Uses the SWA's app name as the title instead of their (potentially
confusing) URL.
Bug: 1052704, b/189171964
Change-Id: I3c69683469249999c0201e4fcdcc4a989d7bd484
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3135049
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Mitchell McDermott <mcdermottm@google.com>
Cr-Commit-Position: refs/heads/main@{#937176}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1635800135-6b3f3ac54fa101cd0b40938c8baae89c6b307451.profdata to chrome-win64-main-1635811042-0fd61dc29835d398ab8cc2c59ddfafd9377c3ad8.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I122481ff36defe29038b954831612d67c9ade39d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256409
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#937175}
Update SideSearch study name to match finch
Bug: None
Change-Id: I64b636ee04aadf224f5f80aebf04a58c299c6174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256367
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937174}
arc: Split target components/arc:arc_base
components/arc:arc_base has many files from the session directory.
This CL splits those files into their separate build target.
Bug: b/204806195
Test: CL
Change-Id: Icc7b279be22adcb391e737aa8b57912106c5c29c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3253680
Commit-Queue: Yao Li <yaohuali@google.com>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937173}
[LibassistantV2] Wire up service boot up status for v2.
Previously we had a CL (crrev.com/c/3091726) wiring up the service ready
signal with |ServiceController|, the component responsible for managing
the lifecycle of the Libassistant. This CL works on the boot up signal
and makes sure it works for both v1 and v2 (as we will be using
different service readiness signals in v2).
This CL also refactors |ServiceController| to be a
|ServiceStatusObserver| itself, so it can be notified directly from the
|ServiceStatusProvider|. Previously the design was to have
|AssistantClientImpl| in the middle to convey the message, which turned
out to be unnecessary.
Test: unittested.
Bug: b/189973142
Change-Id: I1c079abffe58ae992e8c257f091af22e10f9e3bd
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3248277
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937172}
Add single-node fallback to DisplayLock range optimization
In crrev.com/932226 I made an optimization which skips doing a scoped
DisplayLock unlock when the range is collapsed. However, when merging
that change to m96, I found that this change could cause a crash:
http://crrev.com/c/3254778
This change avoids said crash by doing a single node based unlock, which
should avoid the overhead the optimization was concerned about, which is
probably the creation of a Range object.
I'm not sure why the change crashed in the release branch. The same test
doesn't crash without this patch, but I think it's still worth doing.
Change-Id: I3c108bcc69bd17160d440db0e937f29391216eb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256223
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937171}
Update V8 to version 9.7.85.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/db391a3b..d5db1cb5
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
Change-Id: I64bdd442423b7b4e1acd80183fa70607cb148a52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256163
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#937170}
Reland "[Storage management] Use Spaced service for total and free disk space"
This is a reland of 3e0d2bbeef15f645d64230df6d397b810f47287b
Change from the original CL:
Restore the rounding of the total disk space to the next power of 2.
Original change's description:
> [Storage management] Use Spaced service for total and free disk space
>
> Use the new Spaced DBus method GetRootDeviceSize that returns the size
> of the disk instead of the size of the current partition.
>
> Use GetTotalDiskSpaceBlocking (statvfs) when the Spaced method above
> fails (e.g. when the Fake client is used), and for guest profiles where
> disk spaces are not relevant (in-memory temporary filesystem).
>
> Stop rounding the total disk space to the next power of 2.
>
> Refactoring: the observer StorageHandler::OnSizeCalculated is now
> responsible for updating the map of items sizes
> (storage_items_total_bytes_) and marking the correct item as calculated
> (calculation_state_). It then calls dedicated functions to update
> the UI (UpdateSizeStat, UpdateStorageItem, UpdateSystemSize).
>
> Test: unit_tests --gtest_filter=StorageHandlerTest.*
> Bug: b:173086361, chromium:1262859
> Change-Id: I0ca5f6490bef44616ed5f743b07f010fb44c758d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216578
> Commit-Queue: Jeremie Boulic <jboulic@chromium.org>
> Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
> Reviewed-by: Jon Mann <jonmann@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#934374}
Bug: b:173086361, chromium:1262859
Change-Id: Ic6f09202bf14ba5565bf16885c965c101e47a5e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3249390
Reviewed-by: Jon Mann <jonmann@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jeremie Boulic <jboulic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937169}
[Read Later] Add reading_list_in_app_menu to fieldtrial config
Change-Id: I85cba7fd9dced8b790b1d18c83eb28f450599f86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3248434
Auto-Submit: bttk <bttk@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937168}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1635789530-f111e8c85344f105758fe25709f511dcaf4e71a1.profdata to chrome-mac-main-1635811042-326660d4d7b1fa97ad5c9365a31d40bc67fdbb70.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I5f8d3aeae8ecac519763ed81b5f635beff19139e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256139
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#937167}
arc: Create dedicated BUILD.gn file for components/arc/session
components/arc/session has enough source files to deserve a dedicated
BUILD.gn file.
This CL creates one BUILD.gn file and moves some simple targets to the
new build file.
arc_base target has a mixture of files in and out of session folder,
thus will be a target to split in future CLs.
Bug: b/204806195
Test: CI
Change-Id: Ib020b0e5f09064bee502b47fa28cae3c2c9972a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3249197
Auto-Submit: Yao Li <yaohuali@google.com>
Commit-Queue: Yao Li <yaohuali@google.com>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937166}
Clean up flag "ClipboardSuggestionContentHidden"
Remove the flag "ClipboardSuggestionContentHidden" from
chrome/browser/about_flags.cc, but keep the flags on native side since
IOS may need it later. Once IOS start the feature, they can add the
feature flag in ios/chrome/browser/flags/about_flags.mm.
Change-Id: If5b49e8fd5e7938dc532ef21fd202c72e2c18580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252550
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/main@{#937165}
Audit GPU Skip expectations
Audits the GPU test expectations with the "Skip" expected result and
changes many of them to "Failure". Expectations for failures that are
never expected to be fixed (e.g. unsupported features on a platform) or
are for failures that affect other tests (e.g. killing the test device)
were left, but expectations that should have been non-Skip to begin with
(e.g. the test was just flaky) or are so old that they are probably no
longer relevant were changed.
If this ends up causing any issues on the bots, please re-add the
correct expectation instead of reverting the entire CL.
Bug: 1264173
Change-Id: I81c9bdc32dd3532f18cbf63966cc8556da29d53e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3251712
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937164}
[weblayer, skew tests] Refresh skew tests for M95
This CL will add skew tests for version 95.0.4638.75. See crbug.com/1041619
and crbug.com/1099017 for more information.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: None
Change-Id: I1a677db5aec2b3ae09d9d0c6a620d7511ec73bc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256428
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#937163}
[AF] Extend expiring histograms
(Also fixes a couple of typos I noticed by chance.)
Fixed: 1265473, 1265474, 1265475, 1265476
Change-Id: I37d88b8b79af66c1cd62317e3751c53e6a97e2f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256092
Commit-Queue: Jared Saul <jsaul@google.com>
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Auto-Submit: Jared Saul <jsaul@google.com>
Reviewed-by: Sujie Zhu <sujiezhu@google.com>
Cr-Commit-Position: refs/heads/main@{#937162}
Const correctness fixes for cc::Layer and cc::LayerTreeHost
Bug: chromium:1255972
Change-Id: Iad71c1f22309acbb6175303288eb9578ac800e01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256031
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937161}
CCA: Hide document manual crop feature behind chrome flag
Bug: b/203028477
Test: Manually
Change-Id: I2be4591dfbebe1742f6347512ba7a961e04e1d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252630
Auto-Submit: Inker Kuo <inker@chromium.org>
Commit-Queue: Inker Kuo <inker@chromium.org>
Reviewed-by: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937160}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1635789530-7a450338c43aa27552ff3a8595fdfde770c9943a.profdata to chrome-linux-main-1635811042-10b57402b37d5e18d51db1b0bae336518216f194.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I516a2eea32f0af36b026419031a4298a14942b41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256410
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#937159}
Roll Dawn from 777cbbb22b66 to ff9a1f7b20d7 (5 revisions)
https://dawn.googlesource.com/dawn.git/+log/777cbbb22b66..ff9a1f7b20d7
2021-11-01 lokokung@google.com Adds/refactors destroy handling for Buffer and QuerySet.
2021-11-01 bclayton@google.com dawn_node: Improve error handling for run-cts
2021-11-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 98dc04329fbc to d148be4f0025 (2 revisions)
2021-11-01 lokokung@google.com Reland "Adds destroy handling for simple objects without new backend changes yet."
2021-11-01 enga@chromium.org Unmark DispatchIndirect as an unsafe API
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: rharrison@google.com
Change-Id: I2f731dd9768b93770278a0d954a178d255d40cce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3256468
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#937158}