Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
Add new method to grab current visible page from PDF renderer
This CL adds a method to get the current visible PDF page. In a follow
up CL, I'll use the new page index to grab text from the
X pages after the one the user is viewing and include it in the partial
upload request.
Bug: 387306854
Change-Id: Ibc145a5c7cb5f359614814393d671f3fea460299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6134412
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Ali Stanfield <stanfield@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Duncan Mercer <mercerd@google.com>
Cr-Commit-Position: refs/heads/main@{#1405010}
Have Renderer not consume input while hidden
Updating blink::WidgetBase to notify blink::WidgetInputHandlerManager
of visibility state. Then have this accounted for with other input
suppressions.
Bug: 382303508
Change-Id: I312b48b95371760639a6b40164925b67e677eee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6075509
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405009}
Reland "Keep glic webui alive when panel is hidden"
This reland of https://chromium-review.googlesource.com/6089728 sets the GlicWebView as the web contents delegate which
fixes the audio permissions issue.
Original description:
This makes the panel reappear much more quickly after first load. The
webui must be explicitly destroyed during profile shutdown though
(profile keepalive still depends on GlicView which is destroyed whenever
the panel is closed).
Bug: 379905714
Change-Id: Ib8aacefdff8c36a36378163f03e47e0c2be35847
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165045
Commit-Queue: Ian Wells <iwells@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405008}
Roll ANGLE from c10f5e3fbf61 to c01fb3316996 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/c10f5e3fbf61..c01fb3316996
2025-01-10 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 1fa2eb257bf0 to 58a9b6e76b58 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: solti@google.com
Change-Id: I5f052924de65e4ce68eab9d8c2a57c585c39545c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168012
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405007}
Improve shelf drag behavior on model change
Primary motivation is to address a crash which happens when an app
dragged from app list to shelf is removed (e.g. app gets uninstalled,
or unpinned). Model changes were cancelling drag, but without clearing
full drag state - in particular drag_and_drop_app_id_. So on next drag
update, drag event handler kept looking up the drag and drop app, which
was no longer present in the view model.
To fix the issue, fully clear drag state when the dragged item is
removed from the shelf model.
Cancelling drag in response to shelf model changes itself also posed a
stability risk, as it may entail changes to the model, which may be
unexpected by the next observer in line - e.g. properly cancelling
drag from app list to shelf entails removing temporarily pinned app,
which can potentially cause UAF in the next observer (given that
removing an item from a model changes the range of valid model indices,
which are passed to the observers). To address this, update model
observers not to cancel drag - the drag and drop logic should be able
to handle model changes during drag. The part of drag state that needed
to be updated in response to a model change is the drag start index, so
canceling the drag maintains the original shelf order of the dragged
item.
Note that removing the dragged item is an exception, though in this case
clearing drag state, and cancelling further drag event handling is
sufficient.
Allows drags from app list to drag over separator for unpinned running
apps so existing items do not have to be pinned when a drag from app
list starts (simplifying cancellation logic).
Includes some cleanup, where logic to clear drag state is extracted into
a separate method, and used when ending drag handling. Also, removes
some unused variables.
BUG=387520436
Change-Id: I2a70602b55913513a7759020d2170cf0a30cbac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6158572
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@google.com>
Cr-Commit-Position: refs/heads/main@{#1405006}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1736531933-0bb86366eacf9bb8b754fea33cab7b57025fa8d3-ffa032aa746954106635699e59f2cf3b356a49fe.profdata to chrome-android64-main-1736536964-b3a0f12deb64768a9d4899a8d64187f76ad8f791-a13362112800f8ead3dddc21d92f48a75babc520.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I62971c3f04525180d75c4c75ca4f0ca23cb09f87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168048
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405005}
[Data Sharing] Integrating DataSharing Manage flow options.
In this CL,
- Adding string mappings for different Manage screen options.
- Adding new param for learn more about blocked account url in
DataSharingManageConfig.
- Adding new callback in DataSharingUiConfig for opening url in CCT.
Will start using this in next set of CLs and cleanup the learnmore
callback.
Bug: b/386835161
Change-Id: Ica5d8f0d72806d51cf55271e138b4e7c333aa523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6167950
Commit-Queue: Ritika Gupta <ritikagup@google.com>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Auto-Submit: Ritika Gupta <ritikagup@google.com>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405004}
Roll Perfetto Trace Processor Win from d96c8683901c to 1799f295a91e
https://android.googlesource.com/platform/external/perfetto.git/+log/d96c8683901c..1799f295a91e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I5f8b7e7d3ec661571e072a254c138435ea531733
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166891
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405003}
Remove unused mSharedGroupTestHelper.
Change-Id: I4382e90960e6cb7e11e9d520c4a888fc893914ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168206
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405002}
Fix disabled test EdgeToEdgePTTest#fromNtpToTabSwitcher
This CL fixes the test case EdgeToEdgePTTest#fromNtpToTabSwitcher,
which previously failed and was disabled.
Bug: 388863303
Change-Id: If23d7aafb8bc4c735fda55588b3e1e8ab39003e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165326
Commit-Queue: Martin Kong <martinkong@google.com>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@google.com>
Cr-Commit-Position: refs/heads/main@{#1405001}
[Histogram]Correct the documentation
This CL was triggered by two related questions. Which value to put
into the max argument in java. And what occurs if we have more than a
hundred elements in the enum (which seems to be something that can
occurs to the AccessPoint enum soon).
A reviewer noted that the biggest enum value should be put there,
another one that the documentation noted that it should be the
greatest value + 1. Given that the implementation already add 1 to
the max argument, I believe the first reviewer was right and the
documentation should be corrected. I also add a note stating that the
max value should be at most 99 (given that the max + 1 value should be
at most 100)
In c++, I see that the implementation only check that the maximal
value should be at most kBucketCount_MAX. And there are enums with
more than 100 values. So I document that the max value in c++ should
be at most 1000, and and a comment stating that the documentation of
the linear histogram can actually be ignored and the reality is laxer
than stated in the documentation.
NO_IFTTT=This is a comment and repeating the comment in each
implementation seems pointless.
Bug: none
Change-Id: I90c1664e63f7c5b6a0b629bb9855384bc716b6ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6148989
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Arthur Milchior <arthurmilchior@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Arthur Milchior <arthurmilchior@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405000}
[Extensions] Do some more unsafe buffer use cleanup. (3)
Bug: 351564777
Change-Id: I7e69d3001b37db0cc13bbad9d3667b4250e8c5c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6161636
Reviewed-by: John Palmer <jopalmer@chromium.org>
Reviewed-by: Justin Lulejian <jlulejian@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404999}
Pass ImageModel to ImageView::SetImage() in ash/system/network
The ImageSkia version of ImageView::SetImage() is deprecated.
There's no intended behavior changes with this patch.
This CL was uploaded by git cl split.
R=khorimoto@chromium.org
Bug: 40137576
Change-Id: I1bc5fb7746d7d666d79cbd0108b0791d581e798e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166601
Commit-Queue: Jason Zhang <jiajunz@google.com>
Auto-Submit: SangWoo Ko <sangwoo108@chromium.org>
Reviewed-by: Jason Zhang <jiajunz@google.com>
Cr-Commit-Position: refs/heads/main@{#1404998}
[JM] Permit CC PrepareToDraw / DrawLayers lifecycle for TreesInViz feature
Many cc_unittests expect to be able to call PrepareToDraw and DrawLayers
directly. We won't draw layers directly in TreesInViz mode, but we still
need to run much of the Draw lifecycle. Instead of DCHECKing, update these
methods to support TreesInViz mode.
This fixes 324 out of 448 remaining cc_unittest failures.
In a follow up I think it will be good to merge LTHI::UpdateDisplayTree
with the existing Draw lifecycles.
Bug: 383016428
Change-Id: I4ee9d206ab04823f7623218812cb0653a555c114
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166217
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404997}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1736510306-0103f82fe14382268f01c4c47e097c9f26ad4428-92c2bb99b59079b19c3a40503b593091c01b9b4b.profdata to chrome-mac-main-1736531933-a6e4651d897a627c25465f08e95f146b52e25eee-ffa032aa746954106635699e59f2cf3b356a49fe.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I46673b457f1c0926cfcc30b68d4d0e7cd40cc3c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168026
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1404996}
Additional metrics for Win11 upgrade eligibility checks
Bug: 376275766
Change-Id: Icb0590d917946c16df2f27cd3117ee0d9e048182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6167052
Commit-Queue: Eshwar Stalin <estalin@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404995}
Revert "[PWA] Fix GetBrowserContextForWebApps to not consider original profile."
This reverts commit 1d1b1a9d51466a7bf2425962d6f7950e42f195b1.
Reason for revert: Suspected culprit for failures
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/2678/test-results?sortby=&groupby=
Original change's description:
> [PWA] Fix GetBrowserContextForWebApps to not consider original profile.
>
> This change modifies GetBrowserContextForWebApps on non-CrOS to make it
> so only profiles where `web_app::AreWebAppsEnabled` returns true will
> have `WebAppProvider::GetForWebApps` return a non-nullptr.
>
> Unfortunately due to the ChromeOS system web app implementation, this
> change could not be done on ChromeOS, as it relies on the system web
> apps to be available, as well as certain link capturing cases are possible from incognito browsers. However, this change should be
> enough to make sure that mistakes are not made with regards to
> accidentally leaking the installed web app state into incognito
> browser behavior.
>
> Bug: 383858627
> Change-Id: I0fedb367173d531e4f35858dab8ec720c5f3a610
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6158774
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
> Auto-Submit: Daniel Murphy <dmurph@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1404854}
Bug: 383858627
Change-Id: Ia2faa03cb3d6a2edb7edcb5dcc375ab21ae90e2e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166326
Owners-Override: Yann Dago <ydago@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404994}
Make DipsNavigationFlowDetector browsertests runnable in content/
Follow-on CL to crrev.com/c/6121689 moving DIPS code from chrome/ to content/.
Some tests were newly flaky, so I fixed the ones that I could fix quickly, and disabled the ones that I couldn't find an immediate fix for. Note that this is still a net reduction in untested production code from before this CL, as the code is live but the tests aren't being run.
Bug: 40883201
Change-Id: I96531e249bc2d521d638f87ad0d2b0dbe45262d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6138066
Auto-Submit: Svend Larsen <svend@chromium.org>
Reviewed-by: Ryan Tarpine <rtarpine@chromium.org>
Commit-Queue: Svend Larsen <svend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404993}
Remove Clipboard::RawData from Clipboard::Data variant
This CL removes the `RawData` variant of `Clipboard::Data` and passes it
as a separate parameter to `WritePortableAndPlatformRepresentations`.
This is done to allow multiple `WriteData` calls to be made on the same
OS clipboard write, which is required by the fix to crbug.com/380236323.
See crrev.com/c/6077543 for extra context
Bug: 380236323
Change-Id: Id336de6cdc80ac44ba54ac3e693540fdcd27b2b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164476
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404992}
Roll DevTools Frontend from 828469212798 to ed19c1e89852 (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/828469212798..ed19c1e89852
2025-01-10 cjamcl@chromium.org Add calibrated CPU throttling presets
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:311438112
Change-Id: I176f4dad4ddb87b9db3bd1455380a19b2744c912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6167904
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1404991}
[JM] Add TestLayerContext to satisfy LayerContext use from cc_unittests
Bug: 383016428
Change-Id: Id1b56e7fc8ca502944d68559432ea88ac9992119
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165690
Auto-Submit: Victor Miura <vmiura@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404990}
[A11y] Allow setting of selection offset past end of text
An offset equal to the length of text means its past the end of the
text. For example, it should be possible to select an entire text node
of "abc" by providing offsets of 0 to 3.
Bug: 40822761
Change-Id: I46ff2ce1bbdeb139c624e4e7f94db60baf08f8ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6163880
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404989}
Use autoninja in script updating Android RT checks allowlist version
In the script which pushes new versions of the real time URL checks
allowlist on Android, we should use autoninja instead of ninja per this
error message: https://screenshot.googleplex.com/ALpe4w6VtazSJ4h.
Verified this locally by pushing v10 using this new version of the
script.
Change-Id: I5408c654af0f84790bae3f3c1bc2a59ab0d7b079
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164203
Commit-Queue: Sarah Krakowiak <skrakowi@chromium.org>
Reviewed-by: thefrog <thefrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404988}
IPH implementation for JP fronting cards in clank.
Screenshot: https://screenshot.googleplex.com/9TSPn8wVs9wU7LX
Mock: https://screenshot.googleplex.com/SFVbQydpgYhDNiQ
Screenshot 2(without issuer id): https://screenshot.googleplex.com/438LLa6fNFD4cdG
Bug: 369472865
Change-Id: I06687acd01c46ad9fe6fb05105e4165e909a1d08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6080041
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Siyu An <siyua@chromium.org>
Reviewed-by: Vishwas Uppoor <vishwasuppoor@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Harsh Shukla <hvs@google.com>
Cr-Commit-Position: refs/heads/main@{#1404987}
[PS Survey Controller] Init controller on CCT Ads Survey feature
Tests are failing for `android-arm-tests`, due to the survey not being
shown caused by a null survey controller. The controller was returning null based on the enabled features or lack thereof.
This change updates the logic such that we initialize the controller if the CCT Ads Survey feature is enabled instead of relying on the fieldtrial to enable the sentient survey feature (it seems fieldtrial is not being applied to `android-arm-tests`).
Bug: 389017452
Change-Id: I4ea73c72d98f0c78281bf76a74cc19ee6da143ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164117
Reviewed-by: Kevin Graney <kmg@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Alvin Lam <alvingo@google.com>
Reviewed-by: Abe Boujane <boujane@google.com>
Cr-Commit-Position: refs/heads/main@{#1404986}
Fix missing pywin32 wheel version
Version 300 does not exist.
Running:
vpython3 -vpython-spec src/.vpython3 -vpython-tool verify
gives the error:
failed to resolve infra/python/wheels/pywin32/windows-386_cp311_cp311@version:300 (line 97): no such tag
Change-Id: I6c42853c285892c946f5723f36649b0eaefedf17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164608
Auto-Submit: Benjamin Joyce (Ben) <bjoyce@chromium.org>
Reviewed-by: Weizhong Xia <weizhong@google.com>
Commit-Queue: Benjamin Joyce (Ben) <bjoyce@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404985}
Add browser bound key credential parameters for SPC. (1/2)
This change defines a new property on
AuthenticationExtensionsPaymentInputs, browserBoundPubKeyCredParams, for
specifying browser bound key creation parameters during SPC credential
creation (through credential.create) and SPC payment assertion (through
PaymentRequest).
Browser bound signatures are currently behind the flag,
chrome://flags/#enable-secure-payment-confirmation-browser-bound-key
Bug: 377278827, b:388283524
Change-Id: I420ce78c090a1b13687ef225218ebc852a4c624c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6158471
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Slobodan Pejic <slobodan@chromium.org>
Reviewed-by: Darwin Yang <darwinyang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404984}
TTS Engine: Add resource path prefix to grd resources
Change-Id: I4dec954c32c20bf5b5f2f54c42328290ebf87ccb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6163894
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Lauren Winston <lwinston@google.com>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404983}
Pass ImageModel to ImageView::SetImage() in ash/system/cast
The ImageSkia version of ImageView::SetImage() is deprecated.
There's no intended behavior changes with this patch.
This CL was uploaded by git cl split.
R=muyaoxu@google.com
Bug: 40137576
Change-Id: I315c58f8de1c0f4b330773a27e2f83319f3f9241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166462
Reviewed-by: Muyao Xu <muyaoxu@google.com>
Commit-Queue: Muyao Xu <muyaoxu@google.com>
Auto-Submit: SangWoo Ko <sangwoo108@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404982}
Removing old flag metadata
Change-Id: Icbb8f63a956f41f2100e9044605ab388b93ee51c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164026
Commit-Queue: Andre Le <leandre@chromium.org>
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Andre Le <leandre@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404981}
Standardize combo button and tab divider colors
Bug: 388812325
Change-Id: I2f06a5f0e14a85ac3960adcf0aaa868b4602d317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6160575
Auto-Submit: Emily Shack <emshack@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Emily Shack <emshack@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404980}
WebUI: Remove several obsolete validateJavaScriptAllowed exceptions.
These are obsolete since these folders have been migrated to TypeScript.
Bug: b/315002705,b/245336251,b/274059668
Change-Id: Ife052183a5a8e3b1e2b225933d8152758fc4c350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166216
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404979}
[Compare] Add comparison table list item context menu
This patch adds an icon button on the right side of the comparison table
list items that displays a context menu when clicked. This menu adds
options for opening in a new tab, renaming, and deleting a table.
Context menu:
http://screen/AyAn85Vk5xCb5DB
Rename input:
http://screen/BVBkNREnjbfaLsk
Bug: 377939401
Change-Id: I60906f6f8bd83bb6dbb80a09645b400e442591eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6161297
Commit-Queue: Chase Hartsell <chazzy@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404978}
Add FET feature and config for iOS default browser banner promo
Bug: 377739224
Change-Id: Iad51137dd1676b4c83cfdbb2c6400e51414ea662
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164810
Reviewed-by: Guillaume Jenkins <gujen@google.com>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/main@{#1404977}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1736510306-f8d44044d1958f53bd711558abfe901be0b7b3cf-92c2bb99b59079b19c3a40503b593091c01b9b4b.profdata to chrome-linux-main-1736531933-a09f04b39f39d34c6c9798a93762bb71d6b667de-ffa032aa746954106635699e59f2cf3b356a49fe.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Idbe3574326013e78c72bc12424d90c84ccc9b40c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168046
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1404976}
[EducationalTip] Implement trigger scenarios for quick delete promo card
This CL implements the trigger scenarios for the quick delete promo
card:
1. The quick delete promo card in the educational tip module only
appears when a user clears their history without using the Quick Delete
feature or never clears their history in the past 30 days. Two signals,
"count_of_clearing_browsing_data" and
"count_of_clearing_browsing_data_through_quick_delete," track this. The
signals' values are the logging times of the
"Privacy.DeleteBrowsingData.Action" histogram with different enums.
2.The quick delete promo card in the educational tip module will only
appear if it has not been shown to the user in more than 10 total
sessions. A session is defined as each time Chrome is launched. If the
promo card is displayed for the first time in the session, the
preference flag "ephemeral_pref_counter.quick_delete_promo_counter" is
incremented to register one impression.
3. If the user clicks on the quick delete promo card, it will be
permanently disabled. A new preference flag,
"ephemeral_pref_interacted.quick_delete_promo_interacted", is introduced
to track user interaction with the card. Once the card is clicked, the
flag is set to true, and the promo card will no longer be displayed.
4. The quick delete promo card in the educational tip module will appear
only when the card has not been displayed to the user more than 3 times
in 24 hours. To support this, a signal called "quick_delete_shown_count"
and the uma histogram
"MagicStack.Clank.NewTabPage.Module.TopImpressionV2" are introduced to
handle this criteria.
Bug: 355015904
Change-Id: Ied7871863fcb6616effd1b131a5a61c3daaa3075
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6129129
Reviewed-by: Xi Han <hanxi@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Xinyi Ji <xinyiji@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404975}
Use defaulted comparisons and spaceship for PartitionedLockId.
Bug: 386918226
Change-Id: I50d5541eb64902f5fd5e9fecdf1db33d647f9dd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6163828
Reviewed-by: Evan Stade <estade@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404974}
Tweak Dict iterators to comply with std::ranges concept expectations.
* operator*() needs to model shallow constness.
* There needs to be a common reference type between the value and
reference types. In this case, the existing reference type was
effectively also the value type, because there doesn't exist any
separate instance of that "value" anywhere; the returned reference is
bespoke-constructed.
Bug: 386918226
Change-Id: I576f3d65e4d98dd052096caad5d54fc1aaef38ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164118
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404973}
Extend expiry milestone for APN feature flags to 138
* apn-revamp
* apn-policies
* allow-apn-modification-policy
Fixed: 388073812, 388099636, 388115425
Change-Id: I0389133c53131f89906521a188757c06f4be8ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165784
Reviewed-by: Nikhil Nayunigari <nikhilcn@google.com>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404972}
Roll Chrome Android ARM32 PGO Profile
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1736510306-cd6adbbcbcd34e23bf35589a1993b59aa1ba396c-92c2bb99b59079b19c3a40503b593091c01b9b4b.profdata to chrome-android32-main-1736531933-228bc904ebf407e6f5265665948b4adbd3bdf254-ffa032aa746954106635699e59f2cf3b356a49fe.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: If1bfe882d5bbcbd56b8b2f212d003bd065c2da4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6167587
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1404971}
Observe TabGroupSyncService as well for SharedGroupObserver.
Bug: 383266819
Change-Id: I828ba56cf80d6009a8c6e00fedddde82619053a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6160537
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404970}
Revert "Skip showing ContentAnalysisDialog on non-browser window web contents"
This reverts commit 3c755ed17fe637ac00ec7277a04190bdb24ace86.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5760764762652672
Sample build with failed test: https://ci.chromium.org/b/8726120420256812881
Affected test(s):
[ninja://chrome/test:browser_tests/ContentAnalysisDialogBehaviorBrowserTest.Test/0](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:browser_tests%2FContentAnalysisDialogBehaviorBrowserTest.Test%2F0?q=VHash%3A91b15303e2090379)
[ninja://chrome/test:browser_tests/ContentAnalysisDialogBehaviorBrowserTest.Test/1](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:browser_tests%2FContentAnalysisDialogBehaviorBrowserTest.Test%2F1?q=VHash%3A91b15303e2090379)
[ninja://chrome/test:browser_tests/ContentAnalysisDialogBehaviorBrowserTest.Test/10](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:browser_tests%2FContentAnalysisDialogBehaviorBrowserTest.Test%2F10?q=VHash%3A91b15303e2090379)
[ninja://chrome/test:browser_tests/ContentAnalysisDialogBehaviorBrowserTest.Test/11](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:browser_tests%2FContentAnalysisDialogBehaviorBrowserTest.Test%2F11?q=VHash%3A91b15303e2090379)
[ninja://chrome/test:browser_tests/ContentAnalysisDialogBehaviorBrowserTest.Test/2](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:browser_tests%2FContentAnalysisDialogBehaviorBrowserTest.Test%2F2?q=VHash%3A91b15303e2090379)
and 7 more ...
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5760764762652672&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6158104&type=BUG
Original change's description:
> Skip showing ContentAnalysisDialog on non-browser window web contents
>
> This CL fixes the crashes by properly handling web contents that don't
> have a `WebContentsModalDialogManager` attached to them.
>
> Bug: 374120523, 388049470
> Change-Id: I1a1dce6eaf475c2de70223a8fd6d457b73301a49
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6158104
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1404728}
>
Bug: 374120523, 388049470
Change-Id: Ie5fced5900677343e53df3b1429a93802bf524c0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166129
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404969}
Roll ios_internal from baf1faa8de38 to fa89054d3037
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/baf1faa8de38..fa89054d3037
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,justincohen@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I03e3a51759d3ead53ab305d0c1823d07816ebf6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6167585
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1404968}
Roll Perfetto Trace Processor Linux from c80c4256ea27 to 1799f295a91e
https://android.googlesource.com/platform/external/perfetto.git/+log/c80c4256ea27..1799f295a91e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I2ebfc27b2fc7cd473f4963483d420922e0cb4c7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6167691
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1404967}
Roll Perfetto from 1799f295a91e to 0893e2af69ca (4 revisions)
https://android.googlesource.com/platform/external/perfetto.git/+log/1799f295a91e..0893e2af69ca
2025-01-10 ddiproietto@google.com Merge "shared_lib: Fix emitting data with PerfettoDsOnStopArgsPostpone()" into main
2025-01-10 primiano@google.com Merge "ui: support long responses from QueryServiceState" into main
2025-01-10 android-test-infra-autosubmit@system.gserviceaccount.com Merge "tp: speed up query by 10x on large trace by removing window function" into main
2025-01-10 lalitm@google.com Merge "Revert "BUILD: translate gn source_sets to Bazel/Blaze as cc_library"" into main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC oksamyt@google.com,perfetto-bugs@google.com,primiano@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: oksamyt@google.com,perfetto-bugs@google.com
Change-Id: I12d7027803cd991c36798ed7e8ee36f07a0439ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166449
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1404966}
Roll Website from b2946942a27e to 939010115caa (1 revision)
https://chromium.googlesource.com/website.git/+log/b2946942a27e..939010115caa
2025-01-10 vapier@chromium.org CrOS: fix random links after pages shuffled
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/website-chromium
Please CC dpranke@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Website: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dpranke@google.com
Change-Id: I4271f431b4feb651b2c259079763f5d0779c888f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168129
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1404965}
Remove RoundedDisplay feature flag
Bug: b:346432542
Change-Id: Idf9158910b439165e393915629d959e208c83e95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6036610
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Zoraiz Naeem <zoraiznaeem@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404964}
[TabStripRefactor] Moved clearTabDragState to delegate
Change-Id: I0283a334735633e899989484d921cee52892e694
Bug: 381285152
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164804
Reviewed-by: Zhe Li <zheliooo@google.com>
Commit-Queue: Sirisha Kavuluru <skavuluru@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1404963}
Roll Fuchsia SDK from 26.20250103.4.1 to 26.20250110.4.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com,cr-fuchsia@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast-receiver-rel;luci.chrome.try:fuchsia-internal-images-roller
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Disable-Retries: true
Change-Id: Ic9d5aa7e9b5cf2aeb3f84ed99f12560e3540bafe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6167484
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1404962}
Android: Fix incorrect @Nullable in SpeechRecognitionImplJni
Bug: 388315307
Change-Id: Ibbfa057b0222965528cad07180f893d8e1719df0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164809
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Marke Hallowell <wry@chromium.org>
Reviewed-by: Marke Hallowell <wry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404961}