Chromium Main Console

jianhui.j.dai@intel.com

MessagePumpEpoll: Attempt more works only on valid epoll events.

epoll_wait will always report for EPOLLERR and EPOLLHUP, even if don't
explicitly request them in the events argument[1].

Errors in watched file descriptors cause persistent EPOLLHUP
notifications. The repeated EPOLLHUP notifications will trigger the run
loop to set `processed_events`, but lacking valid `DoWork` leads to a
deadlock.

This CL improves the disconnected file descriptor handling. Upon
detecting a disconnection, notify all associated watchers to gracefully
stop watching; If no active watchers, the file descriptor is removed
from the epoll interest list. It prevents the unconditionally epoll_wait
return.

This CL also replicates code from `MessagePumpLibevent` to attempt more
works only when triggered by valid epoll events.

[1] epoll_ctl(2) - Linux manual page
https://man7.org/linux/man-pages/man2/epoll_ctl.2.html

TESTS: Chromium Linux
./out/Default/content_browsertests --gtest_filter=\
FakeSystemTracingDevToolsProtocolTest.TracingWithFakeSystemBackend \
--single-process-tests

Bug: 1243354
Change-Id: I4923f45f41159f6d0937981501418fb06c45d472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5150583
Reviewed-by: Francois Pierre Doray <fdoray@chromium.org>
Commit-Queue: Jianhui J Dai <jianhui.j.dai@intel.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/main@{#1246821}

sophiewen@chromium.org

Reland "snap-groups: Fix split view bounce animation"

This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/5181784. The only change is
this moves the `divider_position_` update to *before* the early return
if `split_view_divider_` is not created and visible.

This fixes the animation for total_size_exceeds_work_area. This checks
if `other_window` can't fit in the allocated snap ratio, then does
the divider animation below.

We should only be doing the bounce animation when the other snapped
window can't fit, i.e. `window1` and `window2` are snapped at
1/2, `window2` has minimum size > 1/3, and `window1` is requested to
snap at 2/3 -> do the bounce animation.

UX specs: https://www.figma.com/file/mqbkvuR7RNSPqUKyHWeqyg/Window-layout-menu-error-cases?node-id=0%3A1&t=46Q46fDKkFg5ou0c-0

Also adds checks to verify we aren't incorrectly starting the divider
animation in other places.

Test: modified
Bug: b/318856124
Change-Id: Idd5aa6e33aea2753787c7b2d4e3e67c8d854b947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5193111
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sophie Wen <sophiewen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246820}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Skia from dd00933ea664 to 39bb9c35b840 (2 revisions)

https://skia.googlesource.com/skia.git/+log/dd00933ea664..39bb9c35b840

2024-01-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 698eee9385e4 to 66e8bc0a47af (3 revisions)
2024-01-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 1de9b3d66634 to 6951208d04af

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC armansito@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: armansito@google.com
Change-Id: Ia75dd27a24f2606c6cd291c8ac8724e60d469987
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194974
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246819}

chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com

Updating trunk VERSION from 6245.0 to 6246.0

* This is an automated release commit.
* Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true

Change-Id: I9e8725961b276224eeeb91683bac166bdc74edf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195783
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246818}

rmcelrath@chromium.org

iwa: Show error message if bundle is outdated or already installed

This adds two new error messages, one for outdated and another for
already installed bundles. We did not have mocks for these UIs, so I
had to come up with the strings myself, but will check with UX and
revise later.

with how dev mode currently works. Can be tested
once that's improved.

Low-Coverage-Reason: HARD_TO_TEST Hard to test 'already installed' case
Bug: 1479140
Change-Id: Ib7748c663a5b76353e86ac7d6e7dd71d36b8ceb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5187186
Reviewed-by: Zelin Liu <zelin@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246817}

rmcelrath@chromium.org

iwa: Refactor nested dialog implementation

There are two changes in this CL. First, nested dialogs are now
enumerated in the model rather than having a generic "ShowDialog"
function that takes strings. This moves most remaining string references
from the controller to the view. Second, this switches nested dialogs
over to DialogModel instead of reusing InstallerDialogView.

These changes will make it easier to support more complex dialogs
like the bundle outdated one.

Bug: 1479140
Change-Id: I6e80b47844906c39cced5163d310b848d5e09679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5182509
Reviewed-by: Zelin Liu <zelin@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246816}

3su6n15k.default@developer.gserviceaccount.com

Automated Commit: LKGM 15742.0.0 for chromeos.

Uploaded by https://ci.chromium.org/b/8759145627190899873

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-jacuzzi-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-octopus-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome

Change-Id: I9f545ec6b0b6cb7e17095639090ddd4b1e6d9440
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5192703
Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Yichen Zhou <yichenz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246815}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Chrome Win64 PGO Profile

Roll Chrome Win64 PGO profile from chrome-win64-main-1705092913-1e304d9a2d5b7c8e18175310eaf3146d2fb8f27f.profdata to chrome-win64-main-1705103968-8b975b3ebba610e5170890dd8bb031ea67724560.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I94f903355913b45be783f77eeb2e8657604d30f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195007
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246814}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Chrome Linux PGO Profile

Roll Chrome Linux PGO profile from chrome-linux-main-1705082277-2cf9eec3578bd2e7419b30cfcbd22891bb636cf3.profdata to chrome-linux-main-1705103968-1e261dc5bae22fd32ed4e7be8612970b863b2163.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ied9778676b8ecdddbae90886b942d739117b21d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195108
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246813}

jsaul@google.com

[AF] Have StrikeDatabase return an enum as its block decision

The idea originally sprang from this comment, and how certain places in
the code were using `kUnknown` to represent a null `blocked_reason`:
https://chromium-review.googlesource.com/c/chromium/src/+/5030981/comment/7e66c03b_a040fbd5/

Now that there are 2+ different reasons for a feature to be blocked,
having the StrikeDatabase be explicit about why it's blocking a feature
seems like a nice feature to have. The C++ style guide also prefers
returning an enum instead of passing it as an optional parameter:
https://google.github.io/styleguide/cppguide.html#Inputs_and_Outputs

Fixed: 1517754

Change-Id: I82e15671d5ace3f03379403177bbcd29bfc2e4ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5147425
Commit-Queue: Olivia Saul <jsaul@google.com>
Reviewed-by: Vinny Persky <vinnypersky@google.com>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246812}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Chrome Mac Arm PGO Profile

Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1705103968-dfaa91dd40cc06bff08c197d27041ca7543297af.profdata to chrome-mac-arm-main-1705111113-023514c4c4006dd32a4ce5fd8ee4e82f928b7547.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie8062dc84f5d06ce3b761b0e54c3aed5ac016d6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194855
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246811}

zequanwu@google.com

Update forbidden_fields.txt

Bug: 1517981
Change-Id: Ia28554c48a854ba2b71ce6a28dac0fe5afd0f262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195723
Reviewed-by: Peter Boström <pbos@chromium.org>
Auto-Submit: Zequan Wu <zequanwu@google.com>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246810}

hirokisato@google.com

Pre compute common prefix/suffix length in ChromeVoxEditableTextBase

ChromeVoxEditableTextBase#describeTextChangedHelper sometimes computes
the length of common prefix and suffix of new and previous text values.

For long text, this computation can be heavy, and may be needed to be
checked multiple times. The next CL will add more usage of them.

To optimize it, this change introduces pre computations of these values.

Bug: b:259379909
Test: ChromeVoxEditableTextUnitTest
Change-Id: Ia7ae7874b3be8dcc3244a01d00ba3b6b6dc6d9d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5143588
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246809}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Chrome Mac PGO Profile

Roll Chrome Mac PGO profile from chrome-mac-main-1705082277-b7c3f0f215ced12863ab03acf3d49223b8c99614.profdata to chrome-mac-main-1705103968-24451c62f602bf13a598152e5a6adaaa449bdbb0.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I98035d3d52233748b95e83adaf2bce0d3fe7ba57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195166
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246808}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll clank/internal/apps from 9b0c0bf26a0c to c7391a888bbd (1 revision)

https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/9b0c0bf26a0c..c7391a888bbd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr:
No-Try: true
Change-Id: I8a82358bb4b20bbb693582175d34f8aa424820b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194837
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246807}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Chrome Mac Arm PGO Profile

Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1705096463-90e00525414657368acdc426dd7a2d7139163c4d.profdata to chrome-mac-arm-main-1705103968-dfaa91dd40cc06bff08c197d27041ca7543297af.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I1b2bc22eae419c2ad948a20542405ae4f9261e45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195230
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246806}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll WebRTC from dc48289b46e0 to f8587da72b06 (1 revision)

https://webrtc.googlesource.com/src.git/+log/dc48289b46e0..f8587da72b06

2024-01-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e064e58728..64ac0cced7 (1246623:1246752)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com,webrtc-infra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I700686bc6c08f300a729ec31bc4bcc76e1121bf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195126
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246805}

rajendrant@chromium.org

Update compose settings UI text

Bug: b/319933886
Change-Id: I6149eaf7fddf43baae9abd2b0372f09e6593e498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194788
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Raj T <rajendrant@chromium.org>
Auto-Submit: Raj T <rajendrant@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246804}

jonathanjlee@google.com

[web-tests] Skip more WPTs for Chrome that depend on `window.internals`

It doesn't make sense to run these tests against the `chrome` binary,
which doesn't ship `window.internals`. Fixes failures [0] on trunk.

[0]: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/140205/overview

Bug: 1516468
Change-Id: I6043283e7565a4211479cb00416e6dc9249e83ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195146
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1246803}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll libc++ from d1f035a3ffb7 to 8c1e8ec34a0a (5 revisions)

https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/d1f035a3ffb7..8c1e8ec34a0a

2024-01-12 dominik.wojt@arm.com [libc++] tests with picolibc: update picolibc (#77908)
2024-01-12 rprichard@google.com [libc++][Android] Add NDK ABI lists for i686 and x86_64 (#69272)
2024-01-12 hawkinsw@obs.cr [libc++][NFC] Make AssertionInfoMatcher::CheckMessageMatches Stricter (#77721)
2024-01-12 yingcong.wu@intel.com [libc++][test] Fix a logical mistake introduced by #77058 (#77867)
2024-01-12 ldionne.2@gmail.com [libc++] Deprecate the _LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS macro (#77692)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/libcxx-chromium
Please CC hans@chromium.org,thakis@chromium.org on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: hans@chromium.org,thakis@chromium.org
Change-Id: Ief77bc8a83e6e36b9ca07ee2e341c1754bc13fa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194850
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246802}

amitrokhin@google.com

Add glanceables key field

Bug: b/315829928
Change-Id: I88bc323ee9b3a05bd9c614aac306fb9e928f3455
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194504
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Artsiom Mitrokhin <amitrokhin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246801}

feras@chromium.org

Move KeySystemsImpl class to its own file

This is a refactoring CL to follow the common pattern of separating
an interface from it's implementation.

Bug: b/267698934
Change-Id: I9768a283f5dcf3e53de009782a2740c7f4c75b35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5173626
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Feras Aldahlawi <feras@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246800}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll ANGLE from 3461be1ae882 to 572323ccbba5 (2 revisions)

https://chromium.googlesource.com/angle/angle.git/+log/3461be1ae882..572323ccbba5

2024-01-12 syoussefi@chromium.org Fix program link after backend rejects program binary
2024-01-12 mark@lunarg.com Trace/Replay: Add multi-context call grouping

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cnorthrop@google.com
Test: Test: Capture Diablo Immortal or Asphalt 9 trace and replay
Change-Id: Iee46aa530f67d4c88f83620df6ee9bc607f7d4d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195085
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246799}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Chrome Win ARM64 PGO Profile

Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1705082277-c7caed4436f56e7450e9f1f430c0595d58fbd46d.profdata to chrome-win-arm64-main-1705103968-c672253acc98c0e240e0eddd8333eaac70a46474.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: pgo-profile-sheriffs@google.com
Change-Id: I14a4e173ff6fb657be71e034a73f298518d79c98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194973
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246798}

twellington@chromium.org

Add additional logs/asserts for mismatch in assigned index

Adds several additional log statements and asserts to help debug a
mismatch between MultiInstanceManagerApi31's selected window id and
TabWindowManagerImpl's assigned tab model selector index.

Bug: 1484026
Change-Id: I78f82365340c536fff5ab87b957268640595d28f
Low-Coverage-Reason: TRIVIAL_CHANGE CL adds logging statements and asserts
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194924
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Theresa Sullivan <twellington@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246797}

laikatherine@google.com

[floss][Fast Pair] Perform SDP when GATT connected

Adds |FetchRemoteUuids| method to trigger SDP to fetch UUIDs.
Adds mitigation to call this method when we are GATT connected
due to Fast Pair so that we can perform SDP and subsequently
get the name of the device before we finish bonding so we show
the name instead of address in connection toast.

BUG=b:318028766, b:319352278, b:303899949
TEST=manually test initial, subsequent, and retroactive pair for
PixelBuds A, JBL TUNEs, and Nordic FP mouse

Change-Id: Id5e934ba7858294d77b53c79cabe0abdcbbfb5fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5193984
Commit-Queue: Katherine Lai <laikatherine@chromium.org>
Reviewed-by: Michael Sun <michaelfsun@google.com>
Cr-Commit-Position: refs/heads/main@{#1246796}

michelefan@chromium.org

snap-group: Fix crashes when divider is animating or being dragged

This cl fixed two crashes: due to the unsuccessful `EndOverview()`
when divider is animating or being resized().

http://b/315549001#comment3

Demo: http://b/313517079#comment14,
Test: Added unit tests, manual + existing
Fixed: b/313517079, b/315549001
Change-Id: I7126210f2ee2ba0d06a5c84b95e3fed16a3ceabf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5107058
Commit-Queue: Michele Fan <michelefan@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246795}

ericamlee@google.com

p13n: add images for SeaPen dogfood

Added images for the templates and the Sea Pen tile.

wallpaper subpage: https://screenshot.googleplex.com/BMD4Yk6dV6dUVrv
seapen subpage: https://screenshot.googleplex.com/7VANxBCUnuaAGZS

BUG=b:318579323
TEST=browser_tests *SeaPen*

Change-Id: I52306653b970a97faab0bde18ddbf55cc4db6c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5182032
Reviewed-by: Jerry Liu <pzliu@google.com>
Reviewed-by: Jason Thai <jasontt@chromium.org>
Commit-Queue: Erica Lee <ericamlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1246794}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Dawn from 62650e52be88 to a4f3b67789b2 (8 revisions)

https://dawn.googlesource.com/dawn.git/+log/62650e52be88..a4f3b67789b2

2024-01-12 amaiorano@google.com run/tests: apply ignore filter to glob args
2024-01-12 senorblanco@chromium.org GLSL: implement push constants.
2024-01-12 arthursonzogni@chromium.org SlabAllocator: Remove dangling pointers.
2024-01-12 bclayton@google.com [tint][ir] Validate access pointer address space and access
2024-01-12 bclayton@google.com [tint] Adjust default access control based on address space
2024-01-12 jrprice@google.com [tint][uniformity] Fix nested LValue expressions
2024-01-12 arthursonzogni@chromium.org MiraclePtr: Rewrite minor directories (linux)
2024-01-12 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e37081499e6d to 126d7b10bf4f (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64
Bug: chromium:1464560
Tbr: cwallez@google.com
Change-Id: I69f7a93795dc0d813bc3331bb8ab59657528f83d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195104
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246793}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Chrome Android ARM64 PGO Profile

Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1705082277-86dcaca30cfc7e197f7f40e38ebe4eb20ba648b6.profdata to chrome-android64-main-1705103968-1d331a33169e13f20842be843aecb5e3d12cd5b1.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: pgo-profile-sheriffs@google.com
Change-Id: If932e7244758f549668b377ed0a75d1be1baebb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195008
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246792}

magchen@chromium.org

Add a new CreateSharedImage() to SharedImageInterface

This new interface is for supporting bitmap in software composition.

Bug: 1434885
Change-Id: I23ba7d205a90581139a20dd27ea1dc52712949b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5191211
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246791}

vasilyt@chromium.org

Remove PPAPISharedImagesForVideoDecoderAllowed policy

Policy was escape hatch policy with life-time of 119-121, so we remove
it before 122 branches.

The cleanup is in a follow up.

Bug: 986480
Change-Id: Ia3da20e73008e25a0dc7a44338e5c62b023cc16e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5185863
Reviewed-by: Roland Bock <rbock@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Igor Ruvinov <igorruvinov@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246790}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Skia from 53de7d8fa378 to dd00933ea664 (3 revisions)

https://skia.googlesource.com/skia.git/+log/53de7d8fa378..dd00933ea664

2024-01-12 bungeman@google.com Add channels to SkPDFIccProfileKey
2024-01-12 brianosman@google.com Handle NaN bit patterns in several RP copy stages
2024-01-12 lovisolo@google.com [bazel] BazelBenchmarkTestRunner.cpp: Add missing newline in SkDebugPrintf statement.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC armansito@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1517545
Tbr: armansito@google.com
Change-Id: I89da8fb92f0f086bd2ab26968d7d357bf24caa26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194827
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246789}

emiliapaz@chromium.org

[Extensions c2s] Remove extra space in between extension menu items

Remove context menu button border since we are adding vertical spacing
in between menu items. This removes the extra space in between menu
items caused by the hover button border.

Screenshots:
https://drive.google.com/file/d/1SqbOwK4Z_5daVdxwUzPZgjjfvQaKPjhZ/view?usp=sharing
https://drive.google.com/file/d/1-dPK2Jen2Ie0TVIwSpNeByxDXbs1EkNl/view?usp=sharing

Bug: 1390952
Change-Id: I4012c8db12e3f3d91e9bac0d2bc74e8fe359658d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195303
Auto-Submit: Emilia Paz <emiliapaz@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246788}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Chrome Android ARM32 PGO Profile

Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1705082277-f709705642703db5bfc95caeba65fc8955ee992b.profdata to chrome-android32-main-1705103968-d6b3242e0830b20121d42e9a54308e0d1d8b53df.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: pgo-profile-sheriffs@google.com
Change-Id: I58e179a2fc72424c71749d82acfd46745b015ebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194835
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246787}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll clank/internal/apps from 32e3e5770540 to 9b0c0bf26a0c (1 revision)

https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/32e3e5770540..9b0c0bf26a0c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,thiabaud@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: thiabaud@google.com
No-Try: true
Change-Id: Ib2cecbe2c81a61c70eaa39b4a40b42395e724bab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194970
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246786}

mfacey@chromium.org

[NTP Quests] Fix sign of threshold check

Clusters are ranked by if their score is closer to -1 and not 0. This
CL updates the new threshold to account for that.

Bug: 1512158
Change-Id: Icfa7cfb87239d3c1a57b726320dc77af05b37340
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5189274
Commit-Queue: Marlon Facey <mfacey@chromium.org>
Reviewed-by: Roman Arora <romanarora@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246785}

sophiewen@chromium.org

snap-groups: Move `MaybeEndOverviewOnWindowResize()`

No functional change. This cleans up `SplitViewController` by moving
the unneeded function to `SplitViewOverviewSession`. This is needed to
remove an unnecessary reference to `divider_position_` in
`SplitViewController`.

Test: existing
Bug: b/308819668
Change-Id: Id2a688d09433b2cafeea3e030e9a0a00732359e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190826
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sophie Wen <sophiewen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246784}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll optimization-guide from dd1eb9fc0d46 to f901b26abfca

https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/dd1eb9fc0d46..f901b26abfca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/optimization-guide-chromium
Please CC chrome-intelligence-core@google.com,sophiechang@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Change-Id: I41bf986c8bdb64f17cf2bfb3c3b3273d8e80d79d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194848
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246783}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll src-internal from 88f3b828bb66 to fe7b5268a4ac (1 revision)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/88f3b828bb66..fe7b5268a4ac

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,mek@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1503192
Tbr: mek@google.com
Change-Id: I908c8a57c7e760bc79326af324f694ff0513b24b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195006
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246782}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll WebGPU CTS from 705abe536630 to f6d89c7267a6 (2 revisions)

https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/705abe536630..f6d89c7267a6

2024-01-12 shaobo.yan@intel.com Update video files to improve external_texture* related cts coverage (#3245)
2024-01-12 5031596+shrekshao@users.noreply.github.com Expand image_copy test params only for compat + r8snorm/rg8snorm (#3264)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll
Please CC cwallez@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Ic79963c61e0bed6b65def9495a053c7056888609
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194705
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246781}

iwells@chromium.org

Disable talkback announcement of player seek bar progress updates

This change specifically prevents TalkBack from repeatedly interrupting
playback with "X percent" whenever the seek bar moves by one percent.
Other a11y announcements from the seek bar can still happen.

Bug: b/319734112
Change-Id: I0c74db1774a6ccd7a7845e63d983a557775f32d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195483
Reviewed-by: Basia Zimirska <basiaz@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246780}

rtatum@google.com

hide inspiration card when empty

Bug: b/319507552
Change-Id: I00736bd6daf22f3bfdc1dec32ba28130f0129ce1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194710
Auto-Submit: Riley Tatum <rtatum@google.com>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Riley Tatum <rtatum@google.com>
Cr-Commit-Position: refs/heads/main@{#1246779}

masonf@chromium.org

Re-enable a few tests

See the links below for context, but these tests had errors that have
since been reverted. This just re-enables the tests.

https://bugzilla.mozilla.org/show_bug.cgi?id=1868364#c8
https://github.com/web-platform-tests/wpt/pull/43663/files

Fixed: 1510865
Change-Id: Ie87e93cc53620f289375e3072818089e067edcbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195145
Commit-Queue: Di Zhang <dizhangg@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246778}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll clank/internal/apps from 5fcc21561d83 to 32e3e5770540 (1 revision)

https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/5fcc21561d83..32e3e5770540

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,thiabaud@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: thiabaud@google.com
No-Try: true
Change-Id: I76940034043088a5fa999d52e6c8e9ccc9a80fef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195229
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246777}

kenrb@google.com

[WebAuthn] Remove kWebAuthnCachePaaSK flag

This was enabled by default in M117.

Bug: N/A
Change-Id: I71a90e4b21bacbe20f735f92ca46a26233d31eb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190288
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246776}

sophiechang@chromium.org

Roll TFLite to Next Green Version

Version Changes:
cpuinfo: 2f4c278f7aa3e9a451c14c3e9a02c3e091140d96 to 76cc10d627add77922dc24521b332a055a4d6d77
ruy: 690c14c441387a4ea6e07a9ed89657cec8200b92 to cd7b92695b5d3f0c9ff65b865c2a1e19b99d766d
XNNPACK: 0cbbe74a16e6ca11acf8484ccac85f620336dea4 to a68aa0a24b0d3e1c75f2f7c0915b70121cee0470
tflite: 6ecc7e35b190face7769a9eb29f21aed7ea077cc to 296f1e3cce03308c7fd5cdc7a76fbc3e41ec5214

Bug: b/201542766
Change-Id: Iec137237629105626487039aa8324ab045a4cd35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5182007
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Jiewei Qian <qjw@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1246775}

stephanie.zhang@microsoft.com

Remove SkipShadowHostWhenHoveringForTooltip runtime flag

The CL that added the flag [0] has gone through 3 Stable releases [1].
No relevant tooltip bugs have been reported during these releases, so we
are removing the flag.

[0] CL:4792060
[1] https://chromiumdash.appspot.com/commits?commit=b759823
[2] https://bugs.chromium.org/p/chromium/issues/list?q=tooltip

Bug: 1473774
Change-Id: I280c2b3515f59ae21063f58a3062543ca7e2fe7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194923
Reviewed-by: Sanket Joshi <sajos@microsoft.com>
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Stephanie Zhang <stephanie.zhang@microsoft.com>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246774}

gbeaty@chromium.org

[infra] De-orchestrate linux-wayland-rel.

try/linux-wayland-rel was removed from the CQ by
https://crrev.com/c/5020413. For builders that aren't on the CQ, we
don't use the orchestrator pattern because non-CQ try builders aren't
run nearly as often as CQ builders and so they don't benefit nearly as
much by having machines dedicated to performing compilation for them.

Bug: 1511076
Change-Id: Ib22d6af4c9ce9a0bc99e51b8c5b07fbde09cf6ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5193164
Reviewed-by: Gary Tong <gatong@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Commit-Queue: Gary Tong <gatong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246773}

rtatum@google.com

add inspiration tile click action

Bug: b/317398385
Change-Id: I11cd766afabc0450a2c1ba5bc07fca75eedd67ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195263
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Riley Tatum <rtatum@google.com>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Riley Tatum <rtatum@google.com>
Cr-Commit-Position: refs/heads/main@{#1246772}