Chromium Main Console

harringtond@chromium.org

Add new glic api boot injection code

See bug for motivation.

Updates the injected source to not use 'export', and to install
the boot function on window. This allows the client to add
the script as a new <script> element, and access the API.

This change does not break existing clients.

Bug: 382121207
Change-Id: I6cf7c5bb0edb4a4a66da321646ff60fd68ff76b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088472
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397555}

agrieve@chromium.org

fast_local_dev_server.py: Make CMD: logs copy & pastable

Bug: 370589852
Change-Id: I87a9a1115b78fa46032c2dd0973b2884a321874a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102348
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397554}

joenotcharles@google.com

Fix joenotcharles address

I've switched to my @google.com address exclusively.

Change-Id: I5835871709aa81d3bf971e2bd0a18a0405680a92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102567
Commit-Queue: Olivier Li <olivierli@chromium.org>
Reviewed-by: Olivier Li <olivierli@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Auto-Submit: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/main@{#1397553}

hchao@chromium.org

Cert Management UI V2: Refresh user cert lists when cert viewer edit
is triggered.

Bug: 40928765
Change-Id: Ic17f65f4c879ad684927dcdc9f4a8447fefbe51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097159
Reviewed-by: Joe Mason <joenotcharles@google.com>
Commit-Queue: Hubert Chao <hchao@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397552}

sophiewen@google.com

sunfish: Re-show action buttons on re-start capture session

This CL fixes the issue where the action buttons would not re-show
on exiting and re-entering default capture mode session. We will now
show the default Search button and perform text detection in default
mode, or early exit in sunfish mode as the user capture region will be
empty.

Demo: https://b.corp.google.com/issues/377569542#comment5

Test: added
Fixed: b/377569542
Change-Id: Iae8a9d541b58c40a5fb1a52470563019151c5e8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097379
Commit-Queue: Sophie Wen <sophiewen@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397551}

skavuluru@google.com

[TabStripRefactor] Refactor effectiveTabWidth to supplier and findViewAtPosition to util.

These refactors are pre-req for moving updateReorderForExternalTabDrop into ReorderDelegate.

Bug: 381285152
Change-Id: If19ad8d04900138234c0d0bde76fa049ee4ed1d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6101257
Reviewed-by: Neil Coronado <nemco@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Auto-Submit: Sirisha Kavuluru <skavuluru@google.com>
Commit-Queue: Sirisha Kavuluru <skavuluru@google.com>
Reviewed-by: Zhe Li <zheliooo@google.com>
Cr-Commit-Position: refs/heads/main@{#1397550}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll clank/internal/apps from e5f8d6b8f6c0 to 773685ed2b08 (1 revision)

https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/e5f8d6b8f6c0..773685ed2b08

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,wenyufu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: None
Tbr: wenyufu@google.com
No-Try: true
Change-Id: I5c3eea93ccbb85a154036e9f2372a198f4ecfa39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102642
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397549}

bpastene@chromium.org

infra: Change TODO bug link for builder build-dir code

The cleanup for this experiment moved to a more specific bug.

Bug: 380434968
Change-Id: Ida428813fb14bc13f301ac3340ba2ddc8705c743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102386
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Wanda Mora <morawand@google.com>
Cr-Commit-Position: refs/heads/main@{#1397548}

bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

[Frameworks roll] Roll to 707192691 piper revision

Change-Id: I3e66fbd31d65da9bd5d932ec9ae1e3e33d89359c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097901
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397547}

junzou@chromium.org

[History][Embedder] Add observer for experimental embedder target.

Bug: 383780439,383380610
Change-Id: Ic368c458e2442313f538712dde9c61133f6040b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102484
Reviewed-by: Raj T <rajendrant@chromium.org>
Auto-Submit: Jun Zou <junzou@chromium.org>
Commit-Queue: Raj T <rajendrant@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397546}

jamescscott@google.com

Fix naming of WebDXFeatures

Blink UseCounter uses a slightly different capitalization for WebDXFeatures. This scheme is documented at the top of the webdx_feature.mojom.

Corrected names:
- https://github.com/web-platform-dx/web-features/blob/main/features/writingsuggestions.yml
- https://github.com/web-platform-dx/web-features/blob/main/features/cross-document-view-transitions.yml
- https://github.com/web-platform-dx/web-features/blob/main/features/scroll-snap-events.yml
- https://github.com/web-platform-dx/web-features/blob/main/features/context-fill-stroke.yml

Change-Id: Idaea71418fc50eb80b5c388cabf0242ab8d425d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098210
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: James Scott <jamescscott@google.com>
Reviewed-by: Kyle Ju <kyleju@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397545}

tkent@chromium.org

Rebaseline of fast/ruby/text-decoration.html for mac15

It seems an Arabic font on macOS 15 was updated.
This CL has no behavior changes.

Fixed: 377802687
Change-Id: I9dfc2c4622f1f193049f7c068a23d6ed0ed83ea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097590
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397544}

bashi@chromium.org

HttpStreamPool: Remove meaningless MaybeMarkQuicBroken() call

The call in MaybeAttemptConnection() didn't take any effect since
we called it after setting `tcp_based_attempt_state_` to
kAllEndpointsFailed but MaybeMarkQuicBroken() returns early when
the state is kAllEndpointsFailed. There is another
MaybeMarkQuicBroken() call in OnInFlightAttemptComplete() so
just removing it should be fine.

Bug: 346835898
Change-Id: I7ce252a2f1c4e5db5cd3d34102e5a07de38f68f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6096545
Reviewed-by: mmenke <mmenke@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397543}

reillyg@chromium.org

webnn: Add DIR_METADATA to Web Platform Tests directory

This will ensure that issues automatically filed for WPT failures
are correctly triaged into the project's issue component.

Change-Id: I8d895dbec5a138a05ab9f2cc0da5e6456f3e05a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102569
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397542}

smaier@chromium.org

androidx: Fix roller issue where testonly is not applied to groups

If a dependency has no artifacts, it gets translated into a GN group,
which then depends directly on all its children. We need to ensure that
if such groups depend on a testonly target, they also get testonly
applied or else gn gen will not be happy.

Change-Id: Ie75ff8831a3cae08354e3b5a6aa4e680bdae08ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102438
Reviewed-by: Peter Wen <wnwen@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397541}

svenzheng@google.com

Enable FeedbackIncludeVariations test config

The experiment has been verified end-to-end.

Bug: 373470046
Change-Id: Ia1b81a2763afb2c2c05818f37283d710760a7963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6101173
Reviewed-by: Luc Nguyen <lucnguyen@google.com>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397540}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll clank/internal/apps from acc6a8eb9ac5 to e5f8d6b8f6c0 (1 revision)

https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/acc6a8eb9ac5..e5f8d6b8f6c0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,wenyufu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:379703994
Tbr: wenyufu@google.com
No-Try: true
Change-Id: If1431c629da89ebcb42adee6979582ed22d64ffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102699
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397539}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Skia from 6bc48cb8bac9 to b2f3e3f6263a (3 revisions)

https://skia.googlesource.com/skia.git/+log/6bc48cb8bac9..b2f3e3f6263a

2024-12-17 kjlubick@google.com Replace SkSharedMutex with std::shared_mutex
2024-12-17 aperez@igalia.com [base] Fix building SkDOM.cpp with Clang in C++23 mode
2024-12-17 jamesgk@google.com [ganesh] Avoid overflow when combining AAHairlineOps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC egdaniel@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: egdaniel@google.com
Change-Id: Ia561599c52272975cc541c247e7f72e0985336de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102529
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397538}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Chrome Mac PGO Profile

Roll Chrome Mac PGO profile from chrome-mac-main-1734436763-2ad4a6ea7b1e004005a4fa39fb4595d1c04a10a8-350bd3a6bf626f7a1187774fd5cad80e7a73499d.profdata to chrome-mac-main-1734458182-7df1a378564e0a02a509d893cd6f564a026ccc8d-c29f06c4a45d01eca24119097916df5f13b682ef.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Idf7647f4f98b04e39a63a2f2d09146881a42070b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102486
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397537}

wnwen@chromium.org

android: Add @NullMarked //components/browser_ui/*

Bug: 40657579
Change-Id: Iaa310f94020052b6b367a7fcd1b37d5ace1d1338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102644
Owners-Override: Peter Wen <wnwen@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397536}

bashi@chromium.org

HttpStreamPool: Allow using slow-attempting endpoints

Some browser_tests are flaky (e.g. [1]) when the HappyEyeballsV3
feature is enabled. The cause is that we don't use a slow-attempting
endpoint if the endpoint is the only endpoint that hasn't been
failed. A slow-attempting endpoint is a valid endpoint so we
should use it as the last option.

This CL modifies AttemptManager to allow slow-attempting endpoints:
* Change the logic of GetIPEndPointToAttempt(). See the comment of
the method for brief summary.
* Get an IPEndPoint for each attempt. Previously, we used a single
endpoint in the loop of MaybeAttemptConnection().
* Remove redundant pending job/preconnect count checks.

The new logic of GetIPEndPointToAttempt() might be time-consuming,
but for the happy path (we find a non-slow endpoint and an attempt
to the endpoint succeeds) it should be fast enough. As a follow-up,
we could add trace events to see bottlenecks.

For a longer-term, we should have a better logic to select which
IPEndPoint (and transport protocol) to attempt. See the linked bug.

[1] https://ci.chromium.org/ui/p/chromium/builders/try/win-rel/b8728787409034283153/test-results?q=ExactID%3Aninja%3A%2F%2Fchrome%2Ftest%3Abrowser_tests%2FContextMenuBrowserTest.OpenLinkInProfile%2FAll.LinkPreviewDisabled+VHash%3Abdbee181b3e0309b&clean=&sortby=&groupby=

Bug: 383606724,384297912
Change-Id: Ic9c150d98f12a4e4808c5bf63c43a5155f84b4f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088261
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397535}

tguilbert@chromium.org

[CodeHealth] Use base::AlignedHeapArray

This CL replaces backing memory with a standardized AlignedHeapArray.

Bug: 373960632
Change-Id: Ifb20406a4d548e371a7ac9b5131b022779b81ed4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098320
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397534}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll llvm-libc from b59bffaa43a2 to 8345f5d50fb8 (1 revision)

https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/b59bffaa43a2..8345f5d50fb8

2024-12-17 tristan.ross@midstall.com [libc] Add unistd overlay (#119312)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/llvm-libc-chromium
Please CC ayzhao@google.com,lexan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: ayzhao@google.com
Change-Id: I54b2c0f45d62b3156c71ae2452403515b42a9edb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102540
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397533}

dtapuska@chromium.org

[MPArch Guest View] Add support for CreateWindow/OpenURL

This change implements create window support and open url handling.
A navigation throttle is added for pending windows that are
unattached. This mirrors the deferred navigation of pending windows
inside the WebContentsImpl for InnerWebContents guests.

BYPASS_LARGE_CHANGE_WARNING
Bug: 40202416

Change-Id: Id68897f418112d2cf4924259aebf1982703190c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6060000
Reviewed-by: James Maclean <wjmaclean@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397532}

colibie@google.com

[wv][cleanup] remove ui thread posting in browserprocess.start

This method is only called from startChromiumLocked which is
guaranteed to be called from the UI thread and some tests.

I added an assert too.

Bug: na
Test: webview javatests
Change-Id: I6f890810b2618092f6f904f4c267b62466e9b504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097576
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Commit-Queue: Richard (Torne) Coles <torne@chromium.org>
Auto-Submit: Chidera Olibie <colibie@google.com>
Cr-Commit-Position: refs/heads/main@{#1397531}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll src-internal from 23cfec0f7940 to 988e04e61c5f (1 revision)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/23cfec0f7940..988e04e61c5f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,hmare@google.com,reillyg@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: hmare@google.com,reillyg@google.com
Change-Id: I5cf7924d0b394fa46220b3d854b50cc5a481b8d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102496
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397530}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll DevTools Frontend from ec445a739b07 to de2be85f2be6 (1 revision)

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ec445a739b07..de2be85f2be6

2024-12-17 asraine@chromium.org [LiveMetrics] Release objects to prevent memory leaks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:376777343
Change-Id: Ife415b52a9566df7accc612e48bd0d4cc8df0864
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102533
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397529}

guidou@chromium.org

Add WebRtcIPHandlingUrl policy

The policy allows to select how WebRTC chooses which IP addresses
and network interfaces when attempting to find the best available
connection per domain using a pattern matching on the security origin.
It takes precedence over the policy WebRtcIPHandling.

The existing policy WebRtcIPHandling should be set by the same source as
the new WebRTCIPHandlingUrl policy and they have been moved to a new
policy category.
Other WebRTC policies may be later unified into the new category.

Bug: 333325017
Change-Id: Iee95916d5c3cc5779867a338bce84271a2590e8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5873208
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397528}

ayui@chromium.org

WebSQL: Add feature flag for WebView

This change adds a flag to enable/disable WebSQL on WebView.
This is enabled by default as per guidelines[1].

[1] https://chromium.googlesource.com/chromium/src/+/HEAD/android_webview/docs/web-platform-compatibility.md#apply-the-change-to-all-apps_but-use-a-finch-experiment-for-rollout

Bug: 333756088
Change-Id: I287c13a647e1e45e989c9e08dd259c674b360105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6099571
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Scott Haseley <shaseley@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397527}

linnan@chromium.org

[Code Health] Remove stale feature MetricsServiceDeltaSnapshotInBg

Bug: 362246957
Change-Id: I11a6685db2a7a9ee818aeb4fc8ccc7a0066d6afb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098236
Reviewed-by: Luc Nguyen <lucnguyen@google.com>
Commit-Queue: Nan Lin <linnan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397526}

dmangal@microsoft.com

[a11y] Restricting Root View Name Change Event for Mac

Issue: When a link is pasted in a chat on chat.google.com and
opened using VoiceOver on a Mac, VoiceOver stalls with the message
“Chrome not responding.”

Solution: The issue stems from CL:5910905, part of the ViewsAX
project, which involved migrating the kname attribute in the root
view. The complexity arose because the virtual function
`GetAccessibleWindowTitle` was overridden by 27 subclasses,
making the migration challenging.
Although the migration is complete, it introduced a new problem
for VoiceOver.

Whenever the root view name changes,
we trigger an accessible name change event
(`ax::mojom::Event::kTextChanged`), which assistive technologies
(ATs) detect and process. However, it appears that VoiceOver
cannot process this event for the root view/window.

In this CL, we stop triggering this event for Mac when the
feature flag kBlockAccessibleNameChangeEvent is enabled.
We restrict the event only when root view's name changes.

This is a workaround which can optionally be removed once the
VoiceOver starts processing the event correctly.

Bug: 380927771
Change-Id: I8cb03e87b292b1509081c81ef138101a80b7e15b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6085797
Reviewed-by: Jayson Adams <shrike@chromium.org>
Commit-Queue: Divyansh Mangal <dmangal@microsoft.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Javier Contreras <javiercon@microsoft.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397525}

courtneywong@chromium.org

graduation: Add ChromeWebView to Graduation webview user agent string

This allows the Graduation app to load the embedded Takeout Transfer
endpoint (takeout.com/embedded/transfer).

Bug: b:383177535
Change-Id: I44222918f14c14045593ae3256b9b86ede953eb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6092246
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Courtney Wong <courtneywong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397524}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Chrome Linux PGO Profile

Roll Chrome Linux PGO profile from chrome-linux-main-1734436763-cef16ee09c0afcad62fec21fb28c63522c3af4cf-350bd3a6bf626f7a1187774fd5cad80e7a73499d.profdata to chrome-linux-main-1734458182-ac4b6c7b3bf9b6dfac9a01c9706d2dd993d812d8-c29f06c4a45d01eca24119097916df5f13b682ef.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I4fda5d5619d5083a692079f412a91ba6afbf064e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102532
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397523}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Depot Tools from ab3bfa4f96be to 138f15432a69 (1 revision)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ab3bfa4f96be..138f15432a69

2024-12-17 sokcevic@chromium.org [gclient] Never download non-git-sources in Cog

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC chops-source-team@google.com,ddoman@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:382202082
Tbr: ddoman@google.com,sokcevic@google.com
Change-Id: I3db0968ac34fcf6ba7cd7745858053a71ec2a86b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102321
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397522}

chazzy@chromium.org

[Compare] Add comparison table list element

This patch adds the comparison table list element to be displayed next
to the empty table.

Bug: 377939401
Change-Id: Id05d0fd9c4dfcb601d5f865bb314468d23405e3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6090116
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Chase Hartsell <chazzy@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397521}

lukasza@chromium.org

Roll prost: 0.13.3 => 0.13.4 in //third_party/rust.

This CL has been created semi-automatically. The expected review
process and other details can be found at
//tools/crates/create_update_cl.md

Updated crates:

* prost: 0.13.3 => 0.13.4

Chromium `supply-chain/config.toml` policy requires that the following
audit criteria are met (note that these are the *minimum* required
criteria and `supply-chain/audits.toml` can and should record a stricter
certification if possible; see also //docs/rust-unsafe.md):

* prost@0.13.4: crypto-safe, safe-to-run

Bug: None
Change-Id: I9e59115a46c0886cdd17738a21c484d372ab539a
Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
Cq-Include-Trybots: chromium/try:win-rust-x64-rel
Disable-Rts: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6099062
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Adrian Taylor <adetaylor@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397520}

ganesh@chromium.org

updater: fix flaky integration test IntegrationTest.MigrateLegacyUpdater

Added retries to the deletion, assuming that anti-virus is
intermittently locking the file.

Fixed: 384547469
Change-Id: I77ac907f456da119e939cec625747c1fe5f0e80b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6096985
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: S Ganesh <ganesh@chromium.org>
Auto-Submit: S Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397519}

tangm@microsoft.com

win: Add DumpWithoutCrashing on SWAP_FAILED in DCompPresenter

This change adds error codes to DCLayerTree::CommitAndClearPendingFrames
and calls DumpWithoutCrashing when they are populated.

With delegated compositing, we are sometimes seeing crashes on
retrieving the availability fence on subsequent writes to the
SharedImage (in DCHECK, we crash on end overlay access). From the
crashes, we've learned this happens when
DCLayerTree::CommitAndClearPendingFrames fails, which can possibly
leave the DComp tree in a invalid state. We're adding these error
messages to better understand what is happening.

Change-Id: Iafdd242ed4022d932b51ffa03348cc0a767bd187
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6081996
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Michael Tang <tangm@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1397518}

hiramahmood@google.com

[iOS] Fix Set Up List duration when kSetUpListInFirstRun is enabled

The max duration of the Set Up List is currently calculated in
reference to how many days have passed since the FRE. This doesn't
work as expected when the Set Up List is shown in the FRE. For example,
setting the duration to 3 days would end up showing the SUL for 4 days
(including the FRE day).

This CL fixes this by updating the feature parameters and renaming
functions for more clarity.

Bug: 379305809
Change-Id: Idf5730025b96c03e7f2841be72b993d449207675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098920
Reviewed-by: Scott Yoder <scottyoder@google.com>
Commit-Queue: Hira Mahmood <hiramahmood@google.com>
Cr-Commit-Position: refs/heads/main@{#1397517}

etiennep@chromium.org

[v8] Update external memory accounter provided by v8

This is a no-op and replaces the blink implementation with the v8 one.
Also migrates test usage of AdjustAmountOfExternalAllocatedMemory(0).

Change-Id: I5c48593b06fa7d0d4d937af8c89bdc34db3baec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6085381
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397516}

lukasza@chromium.org

Roll semver: 1.0.23 => 1.0.24 in //third_party/rust.

This CL has been created semi-automatically. The expected review
process and other details can be found at
//tools/crates/create_update_cl.md

Updated crates:

* semver: 1.0.23 => 1.0.24

Chromium `supply-chain/config.toml` policy requires that the following
audit criteria are met (note that these are the *minimum* required
criteria and `supply-chain/audits.toml` can and should record a stricter
certification if possible; see also //docs/rust-unsafe.md):

* semver@1.0.24: crypto-safe, safe-to-run

Bug: None
Change-Id: I06ce49088cefa93a3ab383987bc722d81461156b
Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
Cq-Include-Trybots: chromium/try:win-rust-x64-rel
Disable-Rts: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098569
Reviewed-by: Adrian Taylor <adetaylor@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397515}

kevers@google.com

Fix memory leak with canceled animations.

Once an animation is canceled, and there are no references from
JavaScript it should be eligible for garbage collection. We keep
animations alive until the finished promise (if any) is resolved
and any pending events have been processed. Canceling an animation
rejects the finished promise and creates a new one per spec, but the
new finished promise is in prep for resuming via a web-animation API
call. While canceled the animation will not finish and can no longer
be discovered via a getAnimations() call. Failure to mark these
animations as having no pending activity has been the source of
memory leaks in Blink.

Bug: 383016426
Change-Id: Ieeb1ca90c3c757c9bb21c2832f53dce0051bc5d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6101787
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1397514}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll BoringSSL from 57c6e688fa05 to 4a82464f4a66 (3 revisions)

https://boringssl.googlesource.com/boringssl.git/+log/57c6e688fa05..4a82464f4a66

2024-12-17 davidben@google.com Don't check for __has_include
2024-12-17 davidben@google.com Use std::optional in one place in bssl_shim
2024-12-17 davidben@google.com Replace OPENSSL_FALLTHROUGH with [[fallthrough]]

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/boringssl-chromium
Please CC boringssl-cabal@google.com,boringssl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in BoringSSL: https://crbug.com/boringssl/new
To file a bug in Chromium: https://crbug.com/new

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: boringssl-cabal@google.com
Change-Id: I2b8b463f02014f4d40851cd75b820aa3e7a1304b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102320
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397513}

lukasza@chromium.org

Roll prost-derive: 0.13.3 => 0.13.4 in //third_party/rust.

This CL has been created semi-automatically. The expected review
process and other details can be found at
//tools/crates/create_update_cl.md

Updated crates:

* prost-derive: 0.13.3 => 0.13.4

Chromium `supply-chain/config.toml` policy requires that the following
audit criteria are met (note that these are the *minimum* required
criteria and `supply-chain/audits.toml` can and should record a stricter
certification if possible; see also //docs/rust-unsafe.md):

* prost-derive@0.13.4: crypto-safe, safe-to-run

Bug: None
Change-Id: I1ec868f4c484e96a731b801886c2513678b7372e
Cq-Include-Trybots: chromium/try:android-rust-arm32-rel
Cq-Include-Trybots: chromium/try:android-rust-arm64-dbg
Cq-Include-Trybots: chromium/try:android-rust-arm64-rel
Cq-Include-Trybots: chromium/try:linux-rust-x64-dbg
Cq-Include-Trybots: chromium/try:linux-rust-x64-rel
Cq-Include-Trybots: chromium/try:win-rust-x64-dbg
Cq-Include-Trybots: chromium/try:win-rust-x64-rel
Disable-Rts: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098350
Reviewed-by: Dustin Mitchell <djmitche@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397512}

ioanap@chromium.org

[UPMLoginDbSunset] Process deprecation export success

Write to a pref whether the pre-deprecation export succeeded.
This pref will be checked prior to cleaning up the db and switching
to an empty backend or to the Android backend if a compatible
Google Play Service version is installed.

Bug: 378650395
Change-Id: I6bcbc9a165817925e30ecbe9a56723da43145734
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6074671
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397511}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll Chrome Android ARM64 PGO Profile

Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1734452735-fd664d10145fce9f80d8d3e271981514e61b603f-2fc66f9ead0532c2b2eb05bd99d16259a6976e09.profdata to chrome-android64-main-1734458424-2522aad25b2d98d244ed7efc7856a82ec104f9a0-203e6415abbb0491519e33d58969e3e78c6513a7.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: pgo-profile-sheriffs@google.com
Change-Id: Iec6658c4101c9e454ffb6ddfa9cca4bf5338fed0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102686
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397510}

bjfong@google.com

[Code Health] Deprecate TabGroupTitleEditor usages to use filter methods

Change all the TabGroupTitleEditor usages to the TabGroupModelFilter
methods for centralized callsites and logic patterns.

Bug: 326109755
Change-Id: Ic49cf525ad5c90c7af76a7e181029d27fa4d4641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098061
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Brandon Fong <bjfong@google.com>
Cr-Commit-Position: refs/heads/main@{#1397509}

dpapad@chromium.org

WebUI: Make Lit CSS vars files compatible with iOS v16.0-16.3.

The CSSStyleSheet constructor as well as the document.adoptedStyleSheets
API are not supported in versions prior to iOS 16.4, which ends up
breaking any WebUI pages that use them, for example chrome://flags
which uses <cr-button>.

Fixing by injecting a <style> tag in the <header> element as a
workaround, only for iOS and only for the versions that are affected
using rutmime detection with a try-catch clause.

Bug: 383745785
Change-Id: Ic10ac00ed207804d6a7f04206e443115538341e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6091935
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397508}

baranerf@google.com

Crash fix caused by calling StartAnimation() while having an ongoing animation

- Replaced CHECK with DumpWithoutCrash and early return in case of
having an ongoing animation already.

Bug: 384676805
Change-Id: Ibac88f8d06b2bd6fe997356629fdb9e428a8cef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098916
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Baran Erfani <baranerf@google.com>
Reviewed-by: William Liu <liuwilliam@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397507}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll gn from 468c6128db7f to 7296b601ea80

https://gn.googlesource.com/gn.git/+log/468c6128db7f..7296b601ea80

2024-12-17 grt@chromium.org Fix crash when NinjaBuildWriter::RunAndWriteFile fails

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/gn-chromium-autoroll
Please CC dpranke@chromium.org,dpranke@google.com,thakis@chromium.org on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dpranke@chromium.org,thakis@chromium.org
Change-Id: Idfd5b39722b567629543b4b544eec445374bff83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102528
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397506}