Chromium Main Console
| Legend: | Passed | Failed | Failed Again | Running | Exception |
Take clipping into account when computing damage
* The original attempt (crrev.com/c/2302774) which used
visible_drawable_content_rect had arounding issue (crbug.com/1156166)
* Attempt to fix above (crrev.com/c/2690989) caused performance issue
because it also make pixel size larger.
* This CL instead round the visible_layer_rect to the target space
and use it only for damage calculation.
Bug: 1106412, 1195315, 1195456
Test: unit tests, run pin-point,
Test: manually confirmed that https://jsfiddle.net/jxL7tayz/1/ does not exhibit the issue.
Change-Id: Iabaa83886d13862656ad43542c3b6590b1265f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2805672
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874114}
[ozone/drm] Use GpuFenceHandle instead of GpuFence in OnSubmission.
Also, rename out fence and gpu fence to release fence for clarity (with
reference to 'acquire fence'), in some areas.
Bug: 1149641, 1120244
Test: cq
Change-Id: I805b633141414b816e9b0a3acccac0941dab634f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2822287
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874113}
Revert "infra: Temporarily disable all CQ experiments while traffic is high."
This reverts commit da91a7747491c2e3dd8b170482ae952048dd1bef.
Reason for revert: pending times back down; revert to allow further //infra/config changes
Original change's description:
> infra: Temporarily disable all CQ experiments while traffic is high.
>
> ~4k+ pending tasks:
> https://chromium-swarm.appspot.com/tasklist?f=os%3AUbuntu-16.04&f=cpu%3Ax86-64&f=pool%3Achromium.tests&f=state%3APENDING
>
> Disable CQ experiments to reduce load.
>
> Bug: 1200502
> Change-Id: I998fbb097386d831194ecb880fa4a1fd627e66ae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837467
> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#873996}
Bug: 1200502
Change-Id: I7d4029fc1ca057a10fe861d77d8dbd459d08ff38
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838408
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874112}
Roll Depot Tools from 4c67f856f066 to bc8802fd819e (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c67f856f066..bc8802fd819e
2021-04-20 lkchen@google.com Switch download_from_google_storage to py3
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: chromium:1199969
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: I4b187d88e1cb1a915f5eab67e1edb502597b2e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837330
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874111}
[weblayer, skew tests] Refresh skew tests for M91
This CL will add skew tests for version 91.0.4472.16. See crbug.com/1041619
and crbug.com/1099017 for more information.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: None
Change-Id: I2074d2f8b94795e071114af0fe9b0b6c44c6a0c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838468
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874110}
Roll Perfetto Trace Processor Win from e41cbcb97d08 to 671be8888eb6
https://android.googlesource.com/platform/external/perfetto.git/+log/e41cbcb97d08..671be8888eb6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I354c45cfa6ed8dbf90fc75cc6813f7358ae38df5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837491
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874109}
[weblayer, skew tests] Refresh skew tests for M90
This CL will add skew tests for version 90.0.4430.86. See crbug.com/1041619
and crbug.com/1099017 for more information.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: None
Change-Id: I7b2be158ece06b516a16333345801bee05542f4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838665
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874108}
Consolidate duplicate conditionals in chrome/browser/BUILD.gn.
Merge multiple "if (is_chromeos_ash)" blocks together. Merge 2
"if (is_mac)" blocks together.
Change-Id: I1eb5e685907a0bb458f75de65101c598566ff91b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2836830
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874107}
Updating trunk VERSION from 4483.0 to 4484.0
# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
Change-Id: Iff3490b048139273598eb1db947515eb406160b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2839223
Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874106}
Move test filter to the browser_tests section.
From mistakenly applied to blink web tests.
Bug: 1158588
Change-Id: Ice71404ff75d83dce52d3040378b636df48057ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838085
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874105}
[CrOS Cellular] Update 'Add cellular' tray button based on inhibit state.
Update the 'Add cellular network' Quick Settings button to have its
enabled state updated based on the whether the device is inhibited or
not.
Add DeviceStateListChanged to TrayNetworkStateObserver in order
for the MobileSectionHeaderView to be able to observe the device's
inhibited state.
Bug: 1199855
Change-Id: I19e486d22ba14897e61d8e7cdf656b8677a03e61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838232
Commit-Queue: Gordon Seto <gordonseto@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874104}
Add locale to both GetHintsRequest and GetModelsRequest
Bug: 1200635
Change-Id: I2069b31ecb08610cd509ff1f2d26dd287aec5772
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838865
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874103}
Roll Fuchsia AEMU from aoQ0ao0Ga... to cgsZ4Tlh3...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: Ia02e463a5f7be58786d7a2a39ada636da5419003
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837329
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874102}
[memories] Makes chrome://memories resilient to slow backend
If the backend is too slow to keep up with the pace of queries issued in
succession, unresolved Promises returned by |QueryMemories| can break
the mojo connection to the browser. Instead of returning a Promise, the
browser will now inform the page whenever the results from the last call
to |QueryMemories| are available.
To avoid race conditions, it is crucial to cancel any pending requests.
Currently, there is no need to cancel requests to the MemoriesService as
the MemoriesRemoteModelHelper already stops pending requests. In the
future, a CancelableTaskTracker should be supplied to MemoriesService
in order to cancel pending DB operations.
Bug: 1173908
Change-Id: If7d3c1bb77eef3fdd7e6a804770ed9152d85e7d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2831996
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874101}
Rstructure SetPrimaryAccount() to take ConsentLevel in IdentityManager
code
SetPrimaryAccount() will take ConsentLevel as parameter and replace
the usage of SetUnconsentedPrimaryAccount(). This cl introduces the new
method signature for SetPrimaryAccount() in PrimaryAccountMutator
and replaces the old usages of SetPrimaryAccount().
Usage of SetUnconsentedPrimaryAccount() will be replaced in future cls.
Bug: 1176695
Change-Id: I15767a552643461f0efe2ba91ac450afa7c20444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2682524
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874100}
[Perf] Python 3 conversion: csv
Fix CSV file creation code in core/perf_data_generator.py so it uses
the recommended flags to open output file on both Python 2 and 3.
* Python 2 uses open(..., 'wb'), as documented by
https://docs.python.org/2/library/csv.html#csv.writer
* Python 3 uses open(..., 'w', newline=''), as documented by
https://docs.python.org/3/library/csv.html#csv.writer
Bug: 1199156
Change-Id: Iadafc32ebc9d63310b3ccc547d0cb2a799ff23d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838230
Auto-Submit: John Chen <johnchen@chromium.org>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#874099}
[composite-bgcolor-animation] Handle non-replace keyframes
Currently we check whether the animation's composite mode is replace
nor not, if not, we fallback to run the animation on the main thread.
But we should actually check whether there is any keyframe that
is non-replace. This CL fixes that.
Bug: 1200450
Change-Id: Ic58f37bb4e94f1ca06cc4ff2a86f8a73f394d06b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2836907
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874098}
Reland "wtf: Reinstate thread check in DEFINE_STATIC_LOCAL."
This reverts commit 6deb0c2bfdbe571bd215b0bd2b6049fbaa213451.
Reason for revert:
The cause of the breakage is now fixed. crrev.com/c/2830066
Original change's description:
> Revert "wtf: Reinstate thread check in DEFINE_STATIC_LOCAL."
>
> This reverts commit 0eb4dfcd81ee47b38d3c878d6c5056256034c3fe.
>
> Reason for revert: broke tests by several assertion hits on Mac
>
> The right approach would be to fix the callsite and reland this as enabling this assertion itself is great.
>
> Tests:
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests%20(dbg)/303/test-results?q=
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests%20(dbg)/306/test-results?q=
> https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests%20(dbg)/307/test-results?q=
>
> Original change's description:
> > wtf: Reinstate thread check in DEFINE_STATIC_LOCAL.
> >
> > DEFINE_STATIC_LOCAL() has a built-in assert that makes sure the variable
> > is created on a non-racy manner. Unfortunately, this has not been
> > working since the required WTF::WillCreateThread() call was accidentally
> > removed.
> >
> > This CL reenables the check by reintroducing a call to
> > WillCreateThread() when a child thread is about to be created.
> >
> > Bug: 1074302
> > Change-Id: Ia2ce3d344d885eca32300b36aa23586af06f242e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2777626
> > Commit-Queue: Kentaro Hara <haraken@chromium.org>
> > Auto-Submit: Yuta Kitamura <yutak@chromium.org>
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#872293}
>
> Bug: 1074302
> Change-Id: If318ffdf505e2db1c8d47f8b36e80d0035a6b461
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2830181
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuta Kitamura <yutak@chromium.org>
> Owners-Override: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#873224}
Bug: 1074302
Change-Id: Ie19dee628b229f86eea2820533adc358a7a6aa24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838326
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874097}
Projector: Add stub button for selfie cam to toolbar
This CL adds a stub button for the selfie cam to the Projector
toolbar. This button currently doesn't do anything except for toggle
between the "on" and "off" icons when clicked.
Bug: 1199396
Change-Id: I233fafc497ef46dd3d92e4011ad35b56577de537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2832114
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yilkal Abe <yilkal@chromium.org>
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874096}
SVG Text NG: Implement NGSVGTextLayoutAttributesBuilder::Build()
It implements "3. Resolve character positioning" with NGInlineItem
traversal, not with LayoutObject / DOM tree traversal.
The Build() doesn't work yet because dependent LayoutAttributesStack
class is not implemented yet.
* Add NGSVGCharacterData
* Add LayoutObject::IsSVGTSpan().
Bug: 1196576
Change-Id: I3ccd421761a4354c09b19caeef82539db04f2f9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2834553
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#874095}
Convert ExtensionHostMsg_OnWatchedPageChange to Mojo
This CL migrates ExtensionHostMsg_OnWatchedPageChange
IPC message to WatchedPageChange Mojo method in
extensions.mojom.LocalFrameHost interface.
This CL attaches PerWebContentsTracker object to WebContents
as a user data in order to use WebContentsFrameReceiverSet.
The existing implementation couldn't use WebContentsFrameReceiverSet
because it has created multiple PerWebContentsTracker objects
with the same WebContents.
Bug: 1183882
Change-Id: Icd74fea45fe2bbb5991c9cad403e9594633883b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2793642
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874094}
WebUI Apps: show app context menu when shift+f10 pressed
Bug: 1200595
Change-Id: I5e2edadb9420bdcee59fa7dfdf8281fe61a20374
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838585
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874093}
Roll Skia from 8ced56f05f2c to 9d11cbdef854 (1 revision)
https://skia.googlesource.com/skia.git/+log/8ced56f05f2c..9d11cbdef854
2021-04-19 brianosman@google.com Fix soft merge conflict in SkRuntimeEffect
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jvanverth@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jvanverth@google.com
Change-Id: I75204508d94d540e8846bee12743f4f8a184cf3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837328
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874092}
Roll PDFium from 50a73b1d147e to 870eda9ec902 (5 revisions)
https://pdfium.googlesource.com/pdfium.git/+log/50a73b1d147e..870eda9ec902
2021-04-20 thestig@chromium.org Initialize various class members in the headers.
2021-04-19 thestig@chromium.org Simplify CFX_FontMapper::IsStandardFontName().
2021-04-19 thestig@chromium.org Merge 2 identical standard font name constants.
2021-04-19 thestig@chromium.org Add a test case for FPDFAnnot_SetBorder() to test rendering.
2021-04-19 thestig@chromium.org Change FPDFAnnot_IsSupportedSubtype() to use a switch statement.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Icba8574fd2795584a05400c5dabbbfb9d7bccbe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837889
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874091}
Enable AXTreeSerializer to support partial serialization.
Previously AXTreeSerializer already supported the idea of
stopping after a certain amount of time or a certain
number of nodes had been serialized, but it was only
intended to be used for a one-time tree snapshot.
This change enables AXTreeSerializer to return the
list of incomplete nodes, so that you can follow up and
finish serializing the tree.
This is a useful building block in reducing accessibility
jankiness.
Bug: 1200437
AX-Relnotes: N/A
Change-Id: I6857fe1957418ddbd47fa75c3409e2ac12117e62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2832493
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874090}
Roll src-internal from 04c91dfb0652 to d99e5f566f9e (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/04c91dfb0652..d99e5f566f9e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC fergal@google.com,msw@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1199923
Tbr: fergal@google.com,msw@google.com
Change-Id: I28f90ebd5d4a63625ede9f9bd707c6c569909de3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838425
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874089}
Ensure EnableHighDPISupport is always called for tests (behind a switch)
Currently, browser_tests calls EnableHighDPISupport only of the
Interactive flag is passed at the command line and interactive_ui_tests
doesn't call it at all. This works fine in the lab where VMs are always
running at 100% DPI, but when developers try to run tests locally on
non-100% DPI screens it can cause issues. In addition, since the browser
itself always runs with this enabled, it is more correct to have the
tests do it as well.
The first version of this change adds the call behind a command-line
switch. This enables a developer to use it locally. We will then run
the tests using that switch in the full waterfall to validate the
impact. If we determine no impact, we can enable this and remove the
switch.
Bug: 1190303
Change-Id: I8bfa1e17eaa8d33058a1ce0cd6220c6174ca098b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2776359
Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874088}
Add more JSON modules tests
Add JSON modules tests to validate the following:
- Cross-origin imports fail without the
Access-Control-Allow-Origin response header.
- The crossOrigin CORS policy is respected
- referrerPolicy is respected.
These tests aren't as fully comprehensive as the corresponding tests
for JS modules under
external/wpt/html/semantics/scripting-1/the-script-element/json-module.
That level of redundancy is probably not particularly valuable, since
JSON modules and JS modules should share the same codepaths for these
features. The intent of these tests is to validate that implementations
are indeed using the same codepaths for JSON modules as for JS modules,
so that these features work the same for both module types.
Bug: 1132413
Change-Id: I07e2ad2e1afc14070ddef5f95ff2f65e147ec9a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2824897
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#874087}
Add a dedicated feature for Merchant Viewer
This CL adds a new feature for merchant viewer and creates MerchantViewerConfig will host the various config values for the experience.
Change-Id: I924b18675bbf9d3580d1dfb99e31c7a04c8881f8
Bug: 1199990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2831084
Commit-Queue: Ayman Almadhoun <ayman@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874086}
Remove [NoAllocDirectCall] from the 2d context reset()
The OfsscreenCanvas flavor of reset had [NoAllocDirectCall] by mistake.
This change removes it along with associated test failure expectations,
and it cleans up a few extraneous expectations.
Bug: 1194226
Change-Id: I3cca4bbcf3fa2b139db79e301e2c0974c24ed69e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837266
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874085}
[Intl] Update ICU to 69-1
Diary https://docs.google.com/document/d/1T60FUG62FuvZ447FNoK81uE1fgJ7bayPf_w-rPqFrFM
https://chromium.googlesource.com/chromium/deps/icu.git/+log/81d6568..7e7574bd
Bug: 1193795
Change-Id: I5651f194472f66c79f53c907f082f9f9a38b7b13
Binary-Size: Size increase is unavoidable
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2824939
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Frank Tang <ftang@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874084}
WebUI NTP: remove inline OneGoogleBar
Removed inline OneGoogleBar.
Removed modal overlays for iframed OneGoogleBar.
Consolidated OGB Javascript code.
Removed the IframeOneGoogleBar and OneGoogleBarModalOverlays feature
flags.
Bug: 1076506, 1173231
Change-Id: I514df0839c4625bd186d21adcdd677f3730a015d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2776395
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874083}
cros: Add the Move to Desks menu to `NonClientFrameViewAsh`.
This CL adds the Move to Desks menu to `NonClientFrameViewAsh`,
resulting in any header that is owned by ash to use the Move to Desks
menu as its context menu by default.
This CL implements this by making the following changes:
- Create a `MoveToDesksMenuDelegate` class in ash/public/cpp/.
- Move the `MoveToDesksMenuModel` class to chromeos/ui/frame/.
- Move the strings for the menu to chromeos/strings/.
- Make `NonClientFrameViewAsh` a `views::ContextMenuController`.
For more context, visit go/cros-move-to-desks-menu.
Bug: 1163997
Change-Id: Ic3325f26b8779c15ddfea5bbc59cb32e6b2ac839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2832053
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874082}
Don't split gtest test suites into unit and non-unit.
Only the instrumentation tests need to be split
Launched swarming task: https://chromium-swarm.appspot.com/task?id=53051419dad90010
LUCI UI: https://ci.chromium.org/swarming/task/53051419dad90010?server=chromium-swarm.appspot.com
---------
Bug: 1180360, 1056099
Change-Id: I8cf0bca8fb7c06ecaf3a282fe6f3ad1f7f23fcc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837245
Auto-Submit: Prakhar Asthana <pasthana@google.com>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: benjamin joyce <bjoyce@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874081}
Fix nits in UnifiedSystemInfoViewTest.
- Stop using DISALLOW_COPY_AND_ASSIGN().
- Reset `scoped_feature_list_` in TearDown().
- Add a helper method to get the EnterpriseDomainModel.
- Inline some constants.
- Fix wrong variable names in UnifiedSystemInfoViewNoSessionTest.
- Use auto keyword in UnifiedSystemInfoViewNoSessionTest.
Change-Id: I7c4bd001630af5de88650c5ba656178807d2c85e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2832928
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874080}
Roll Perfetto Trace Processor Linux from e41cbcb97d08 to 671be8888eb6
https://android.googlesource.com/platform/external/perfetto.git/+log/e41cbcb97d08..671be8888eb6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: Ia7042f44a1f740928b398c6d8ed669f787192605
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837524
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874079}
[CrOS Cellular] Show 'Add cellular' button only during user session.
Update network_section_header_view to show the 'Add cellular network'
button in Quick Settings only if the user is in an active session.
No unit tests were added as NetworkSectionHeaderView currently does not
have a test suite.
Bug: 1199939
Change-Id: Ie332b4adaadc790db150a42dd467ed5e723a5aef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837074
Commit-Queue: Gordon Seto <gordonseto@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874078}
Roll Fuchsia AEMU from RHTOD0RSg... to aoQ0ao0Ga...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: Iaab9f9099cc19927ed0a18d2cd1476b7ded607db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837327
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874077}
[ntp] Turn shortcut title wrapper into pill
If a third-party theme is installed NTP shortcut titles were wrapped
into a rounded rect. This CL changes this shape to a pill.
Before: screenshot/6eai2j6dnkEDEqK
After: screenshot/8EC5CKS6CKZHiNH
Fixed: 1200579
Change-Id: Ief627184282ac7987048a4eab823b85deca61454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837519
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874076}
Use hasKeyModifiers() in History/NTP JS code.
Use the utility function instead of reimplementing it.
Change-Id: I22751c5c940b46ac3cd51693059007cf996a0dcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837513
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874075}
Roll src/net/third_party/quiche/src/ fa47a6d70..2a62c5169 (8 commits)
https://quiche.googlesource.com/quiche.git/+log/fa47a6d70eb6..2a62c516984f
$ git log fa47a6d70..2a62c5169 --date=short --no-merges --format='%ad %ae %s'
2021-04-19 wub Deprecate --gfe2_reloadable_flag_quic_tls_use_per_handshaker_proof_source.
2021-04-19 haoyuewang Use new connection ID in connection migration on the client side.
2021-04-19 fayang Do not crash if time wait list tries to send or queue null packets.
2021-04-19 fayang Internal QUICHE change
2021-04-19 bnc Remove Http2StringPrintf.
2021-04-19 bnc Remove SpdyHexEncode, SpdyHexDecode, Http2HexEncode, Http2HexDecode.
2021-04-16 quiche-dev Adds simple decoder event handling to OgHttp2Session.
2021-04-16 dschinazi Improve logging in QuicPacketCreator
Created with:
roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src
R=renjietang@chromium.org
Change-Id: I747f57e28ecb24dbca084d23a4ebd1cd8b94479c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837520
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Reviewed-by: Renjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874074}
Roll Depot Tools from b88488523d62 to 4c67f856f066 (2 revisions)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b88488523d62..4c67f856f066
2021-04-19 ehmaldonado@google.com git-cache: Add option to fetch commits.
2021-04-19 vapier@chromium.org repo: update to v2.14
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: None
Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com
Change-Id: I0ebcde14e4f7e63dc72de6e5c8ee865f8b945b5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837887
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874073}
Enable CupsIppPrintingBackend feature by default
This is the last step before rolling out the feature to 100% stable.
Bug: 226176
Change-Id: Ie7d6494d6a02f2512a5edcde0bd3d49545d35240
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838071
Auto-Submit: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874072}
Use base::StringTokenizer::token_piece() when std::string is not needed.
base::StringTokenizer::token() creates a new std::string each time. Many
callers do not even need a std::string, so just update them to use
token_piece() instead.
This CL was uploaded by git cl split.
R=drubery@chromium.org
Bug: 1199547
Change-Id: I5eb15124dcdbf3c374c9083adaf302078cc71535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2833271
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874071}
[webid] Expose a navigator.id.logout() API with an no-op implementation.
Bug: 1200581
Change-Id: Id2fd556026fe6ae08aee005f2ff7578db1d6e72a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2832137
Commit-Queue: Sam Goto <goto@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874070}
Roll ANGLE from 3691797ac790 to b574643ef28c (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/3691797ac790..b574643ef28c
2021-04-19 geofflang@chromium.org D3D11: Skip blits if there is no intersection of dest areas
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1199402
Tbr: ynovikov@google.com
Change-Id: I47f41ef3c4d2ad46034b432e9242f3a36830147f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838126
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874069}
Roll Perfetto Trace Processor Mac from 0367ce4051dc to 671be8888eb6
https://android.googlesource.com/platform/external/perfetto.git/+log/0367ce4051dc..671be8888eb6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: Ib485b64d263f87217bc1de1b086d67420ad9ad12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837291
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874068}
Roll Catapult from 6beee70e2310 to eb5af39fe4eb (1 revision)
https://chromium.googlesource.com/catapult.git/+log/6beee70e2310..eb5af39fe4eb
2021-04-19 johnchen@chromium.org [Catapult] Python 3: Update print statement in common
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC skyostil@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1199455
Tbr: skyostil@google.com
Change-Id: I05d2f4038067a7d6716b2d50fa7dc5851590378e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837533
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874067}
Use base::StringTokenizer::token_piece() when std::string is not needed.
base::StringTokenizer::token() creates a new std::string each time. Many
callers do not even need a std::string, so just update them to use
token_piece() instead.
This CL was uploaded by git cl split.
R=rdevlin.cronin@chromium.org
Bug: 1199547
Change-Id: I296ab74ba854eab2e3f70a5d01a706f9da743236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2832863
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874066}
[docs] Fix sub-list indentation.
Markdown appearance before:
Define a new unique name in a pref_names.cc file. Either in: a.
chrome/common/pref_names.cc -- being careful to put it in the right
section (LOCAL STATE versus PROFILE PREFS) and alongside similar prefs
(existing ifdefs and/or pref namespaces); or, ideally in: a. a
pref_names.cc local to your component (typically inside a prefs:: C++
namespace nested in your component's namespace)
Markdown appearance after:
Define a new unique name in a pref_names.cc file. Either in:
* chrome/common/pref_names.cc -- being careful to put it in the
right section (LOCAL STATE versus PROFILE PREFS) and alongside
similar prefs (existing ifdefs and/or pref namespaces); or,
ideally in:
* a pref_names.cc local to your component (typically inside a
prefs:: C++ namespace nested in your component's namespace)
Bug: none
Change-Id: Iec22057fc86873fed651d9000cd82519dddffeb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2834052
Commit-Queue: Amanda Deacon <amandadeacon@chromium.org>
Auto-Submit: Amanda Deacon <amandadeacon@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874065}