Chromium Main Console
| Legend: | Passed | Failed | Failed Again | Running | Exception |
Increase linux-rel remove_src_checkout_experiment to 40
Bug: 1287228
Change-Id: I5776653b74af36cca1f46f8627a902bff3781bd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600202
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Cr-Commit-Position: refs/heads/main@{#994796}
Roll Chromite from 3c63c1630a74 to b3e9c77c5304 (55 revisions)
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3c63c1630a74..b3e9c77c5304
2022-04-21 ttylenda@chromium.org cros-ide: test boards_packages.ts
2022-04-21 oka@google.com cros-ide: small refactoring in doubles.ts
2022-04-21 oka@google.com cros-ide: Fix a bug in useLegacy check
2022-04-21 ttylenda@chromium.org cros-ide: test opening current file in CodeSearch.
2022-04-21 oka@google.com cros-ide: Test generation of compdb is invoked at right timing
2022-04-21 oka@google.com cros-ide: reduce duplication in doubles.ts
2022-04-21 oka@google.com cros-ide: adding a flag for faster compile commands generation
2022-04-21 oka@google.com cros-ide: Extract method to generate compilation database
2022-04-21 oka@google.com cros-ide: Refine the code to look up ebuild packages
2022-04-21 oka@google.com cros-ide: Split functions for cpp xrefs
2022-04-21 hscham@chromium.org cros-ide: clarify metrics consent pop-up language is for CrOS IDE
2022-04-20 vapier@chromium.org eval_binpkg_compression: add brotli for comparison
2022-04-20 vapier@chromium.org gs: List: add option to extract generation info
2022-04-20 saklein@chromium.org api/metrics_unittest: Fix imports.
2022-04-20 saklein@chromium.org api/metrics_unittest: YAPF
2022-04-20 saklein@chromium.org utils/metrics: Change MetricEvent to NamedTuple
2022-04-20 oka@google.com cros-ide: Move the file for cpp xrefs under a directory
2022-04-20 nya@chromium.org cros-ide: Enable eslint-plugin-import
2022-04-20 nya@chromium.org cros-ide: Drop many unnecessary files from vsix package
2022-04-20 nya@chromium.org cros-ide: Automate checking dependency licenses
2022-04-20 nya@chromium.org cros-ide: Update recommended settings and documentation about style
2022-04-20 rchandrasekar@google.com build_packages: remove the new goma and remoteexec arguments
2022-04-20 rchandrasekar@google.com sysroot: Add remote execution context manager
2022-04-20 rchandrasekar@google.com goma_lib: Add goma restart interface
2022-04-20 rchandrasekar@google.com goma_lib: Move goma interface to chromite lib
2022-04-20 rchandrasekar@google.com remoteexec: Add support for starting and stopping remoteexec
2022-04-20 oka@google.com cros-ide: Fix warning
2022-04-20 oka@google.com cros-ide: Rename ide_utilities -> ide_util
2022-04-20 nya@chromium.org cros-ide: Reformat comments in webpack.config.js
2022-04-20 nya@chromium.org cros-ide: Remove no longer used eslint comments
2022-04-20 nya@chromium.org cros-ide: Automatically fix lint errors
2022-04-20 nya@chromium.org cros-ide: Set up Google TypeScript linter/formatter
2022-04-20 oka@google.com cros-ide: Add installVscodeDouble and tests use it
2022-04-20 oka@google.com cros-ide: Update npm test to remove old JS output
2022-04-20 nya@chromium.org cros-ide: Manually fix some potential lint errors
2022-04-20 nya@chromium.org cros-ide: Relax max-len lint rule
2022-04-20 dbeckett@chromium.org Build API TestService: add logging to container build failing
2022-04-19 chrome-bot@chromium.org Automated Commit: Updated config generated by config-updater builder.
2022-04-19 shouchieh@google.com corsola: sign factory install shim
2022-04-19 shouchieh@google.com nissa: sign factory install shim
2022-04-19 vapier@chromium.org cros_sdk: stop resetting SDK version to 0 when unpacking
2022-04-19 ttylenda@chromium.org cros-ide: support errors in fake exec.
2022-04-19 ryanbeltran@chromium.org toolchain: rm build caches in linting endpoints
2022-04-19 dbeckett@chromium.org Build API TestService: Adding a new service container
2022-04-19 ttylenda@chromium.org cros-ide: use Jasmine to capture Uri in CodeSearch tests
2022-04-19 hscham@chromium.org metrics: send metrics when an action is performed
2022-04-19 yoshiki@google.com Use TypeScript version of "no-unsed-vars"
2022-04-19 xcl@google.com sysroot: Migrate regen cache and eclean binpkgs
2022-04-18 engeg@google.com config: remove veyron entirely
2022-04-18 saklein@chromium.org depgraph: Remove cros_event usages.
2022-04-18 saklein@chromium.org api: Compile test.proto changes.
2022-04-18 ryanbeltran@chromium.org api/toolchain: Make filters optional for linting
2022-04-18 chrome-bot@chromium.org Automated Commit: Updated config generated by config-updater builder.
2022-04-18 jefferymiller@google.com cros flash: Check HOTPLUG for removable usb: targets
2022-04-18 saklein@chromium.org Build API: refresh compiled proto
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I3873934061b1de9229eb1dbecbf5308c9c791931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600316
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#994795}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1650542075-6ad048ed81fff6f018b00ea6fa6be883f4bdf3ad.profdata to chrome-win64-main-1650552850-9e15034eb0e4c740a030d9c23d3551da94e0b6b1.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ic8c96341d1d1abd20fe88677451285b134b69c55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600325
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#994794}
Re-enable autohide smoke tast test as it is no longer flaky.
Bug: 1269075
Change-Id: I844c1e386ff999bdc6f80c0d28a5cabbbb59eab3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600749
Auto-Submit: Yulun Wu <yulunwu@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994793}
Break down metrics by report type.
SafeBrowsing.RT.Network.Result.{SamplePing/NormalPing}
SafeBrowsing.RT.IsLookupSuccessful.{SamplePing/NormalPing}
Fixed: 1314091;
Change-Id: I47492d553cae8832d3b32535587a7bb134c7c9ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3579127
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Auto-Submit: Zack Han <zackhan@chromium.org>
Commit-Queue: Zack Han <zackhan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994792}
Roll Media App from ZTCzFxeM0... to QKkWQPLye...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202204210800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/QKkWQPLyeYhU7cPTorLWSKdZZqhVpiL1CwNPSA2PEeQC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: b/154430508,b/191414801,b/202200585,b/207802971,b/210066419,b/218753388
Tbr: media-app@grotations.appspotmail.com
Change-Id: Iab10f9ecda81b3f082d8aa78b609159ffed99d5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600318
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#994791}
[side search] Eliminate grey flash when opening Side Search
This CL eliminates the grey flash that can be seen when side search
is first opened.
This is done by setting the default background color of the
WebContents to be transparent and setting the hosting WebView's
background color to the toolbar background color.
Before:
https://screencast.googleplex.com/cast/NTQxMzQ3MzE1NzY0NDI4OHw1ZTRhOTEwMS1kOQ
After:
https://screencast.googleplex.com/cast/NjQ4MjY1MDQ3OTk4NDY0MHwwNDZhMmY5MS0wYg
Bug: 1315412
Change-Id: I86a8879ddae422a3c1355924af012bd41d2adf3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3598181
Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994790}
Roll Perfetto Trace Processor Mac from 623889d7dbd7 to 4c54e4e3e942
https://android.googlesource.com/platform/external/perfetto.git/+log/623889d7dbd7..4c54e4e3e942
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I806b7865a3a794f0afc15f2ab2cd099b478539d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600435
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#994789}
Re-enable datagrid-editable-longtext.js
Follow-up for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3586197
This updates datagrid-editable-longtext.js to account for the changes
to the data grid component and re-enables the test.
Bug: 1316147
Change-Id: I326d90c4f00997338e251d19bacf995c4f034c9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3597101
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Brandon Walderman <brwalder@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#994788}
Revert "Add switch for logging to AnnotateDom"
This reverts commit a25642ba9262aa2da419bae7e18cb0c042a718ac.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified this CL at revision a25642ba9262aa2da419bae7e18cb0c042a718ac as
the culprit for failures in the continuous build including:
Sample Failed Build: https://ci.chromium.org/b/8816263051354067233
Sample Failed Step: compile
If it is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?status=Available&comment=Datastore+key+for+the+culprit+entity%3A+chromium.googlesource.com%2Fchromium%2Fsrc%2Frefs%2Fheads%2Fmain%2Fa25642ba9262aa2da419bae7e18cb0c042a718ac&labels=Test-Findit-Wrong&components=Tools%3ETest%3EFindIt&summary=Wrongly+blame+a25642ba9262aa2da419bae7e18cb0c042a718ac
Original change's description:
> Add switch for logging to AnnotateDom
>
> If the switch is present, Autofill Assistant's
> AnnotateDom feature will log its extracted signals
> to the console.
>
> Bug: b:228953382
> Change-Id: I29005f1f6137af292c16536f22fdba80245f1c86
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3584164
> Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
> Commit-Queue: Sandro Maggi <sandromaggi@google.com>
> Cr-Commit-Position: refs/heads/main@{#994655}
Change-Id: I160db93f2d6eb58db4e1603a9145b6eaf34324bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:228953382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600199
Owners-Override: Ian Clelland <iclelland@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994787}
[Extensions] Ensure deleted/unreadable content script files are verified
ExtensionUserScriptLoader/LoadScriptContent logs warning when it
encounters a deleted / unreadable content script file, and skips
"content verification (CV)" for it. This CL propagates the info
to CV in those cases too (as it does for "regular" files), so
files that were tampered with can be detected.
This CL adds regression tests for crbug/1296310
Bug: 1296310
Change-Id: Iebcf9ddd40839cebf77dd479197086eaff0b49ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3587139
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994786}
Roll DevTools Frontend from 2d5482ab236e to 81477453b5ff (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d5482ab236e..81477453b5ff
2022-04-21 wolfi@chromium.org Fix local override filename handling for special characters
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1308257
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib71acf4a67ce49c6cd3a7a1c4d6d679db1cfe66c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600323
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#994785}
Correct error string on policy blocking page
A M99 change to improve the error page text when URLBlocklist policy
blocks non-standard URL schemes was incorrectly shown for error cases
where the url was not blocked by policy. This CL restricts the text
change to only the case where the url was blocked by policy.
Bug: 1317790
Change-Id: Iaecf7fc13930e607113363fa94761b72ccbf5038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3597951
Reviewed-by: Edward Jung <edwardjung@chromium.org>
Commit-Queue: Eric Lawrence <ericlaw@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#994784}
Add WebGLRenderingContextBase::TexImageSkImage
Delete the class ImagePixelLocker and inline its functionality
of exposing an SkImage's pixels as an SkPixmap into
WebGLRenderingContextBase::TexImageSkImage.
With ImagePixelLocker rolled into common code, the only reason to use
WebGLImageConversion::ImageExtractor is for image elements. Move its
usage to WebGLRenderingContextBase::TexImageHelperHTMLImageElement, and
make WebGLRenderingContextBase::TexImageImpl operate directly on its
Image's cc::PaintImage (and its SkImage).
Make WebGLRenderingContextBase::TexImageHelperHTMLImageElement and
WebGLRenderingContextBase::TexImageImpl both use the new
WebGLRenderingContextBase::TexImageSkImage function directly.
Move the population of TexImageParams::width/height/depth to inside
WebGLRenderingContextBase::TexImageSkPixmap (since having all callers
set those parameters would be redundant).
Bug: 1310815
Change-Id: I041c99d568b8c624142cb6235d0b25f48d11d095
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3595321
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994783}
[zlib][aosp] Add option to disable crc32c hashing for compression
This change will allow Chromium's zlib to use the portable hash
function provided by canonical zlib (i.e. Rabin-Karp).
This switch is available during compiling time, but it will regress
compression performance.
Bug: 1316541
Change-Id: Ie2f3662c60221a7a0cc4d8d7b65745994a797e96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3587609
Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994782}
[Read Anything] Create views on demand.
The coordinator is created when the browser is created and shares its
lifetime. Before this change, the coordinator created the views in its
constructor. However, it failed to consider the fact that the views
have a different lifetime from the coordinator: while the coordinator
shares its lifetime with the browser, the views share their lifetime
with the side panel view, which is created and destroyed when its
visibility is toggled. This led to a bug in which the side panel would
re-open after being closed and request a new view from Read Anything,
and we would return a stale view, resulting in a crash.
In this change, we create the views whenever the side panel requests
them to be created.
Class descriptions are added in crrev.com/c/3593497 to clarify this.
Bug: 1266555
Change-Id: I55489a7e3140f4eefe9c8bc289e61ea02591c3b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3593929
Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/main@{#994781}
Change Set Chrome as Default Browser pedal to use English JSON triggers
This CL gets more triggers working in en and en-GB locales by using the
JSON trigger data with extra optional groups instead of the single grit
localization string. The en-GB data is filled with data from en.
Bug: 893183, 1315623
Change-Id: I3b4e5ced401d22658abb01daa3ce4e9ffeead65d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3591175
Reviewed-by: Angela Yoeurng <yoangela@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994780}
[fuchsia] Disable DevTools* & HeadlessBrowser* tests
Remove the following fuchsia.headless_browsertests.filter entries:
-DevtoolsInterceptionWithAuthProxyTest.RunAsyncTest
-HeadlessBrowserTest.ServerWantsClientCertificate
-HeadlessBrowserTestWithProxy.SetProxyConfig
And change them to DISABLED_* on Fuchsia.
Bug: 1090933
Change-Id: I68de23b6d4585347e88d2794e02e2ca27db6961f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3594358
Reviewed-by: Fabrice de Gans <fdegans@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Mason Bendixen <masonben@chromium.org>
Auto-Submit: Mason Bendixen <masonben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994779}
[iOS] Enterprise settings for Enhanced Safe Browsing UI
In the event that an account's preferences are controlled by an
enterprise, the UI should reflect that a user does not have the
functionality to choose between Safe Browsing protection options.
Highlighting and selecting a cell have been disabled, but the
accessibility button can still be clicked to look at the Enhanced and
Standard protection subpages which will still display it's intended
behavior based on the selection chosen. Also, note that first two rows
currently do not follow enterprise standards (Being greyed out if
not chosen) since we plan to make changes to use TableViewInfoButtonItem
instead of SettingsImageDetailTextItem in a follow up CL.
UI Changes:
https://drive.google.com/file/d/1RM43Z4WnsvBnuqZaHg0EcxW5swMZJM-1/view?
usp=sharing&resourcekey=0-r5ZVrPrQGS5BggqtH6QSiA
Bug: 1295870
Change-Id: Ib3e681455d7fb907bae0d82907acd2143724fdef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3575267
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Joemer Ramos <joemerramos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994778}
Roll RTS model from zTyZpolZp... to M6yKuxCtr...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-windows-amd64-chromium-autoroll
Please CC guterman@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: guterman@google.com
Change-Id: I67226f568929c176888c7dc175651fe2f4e6e717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600320
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#994777}
Convert SHOUTY_CASE Mojo union tags to kCamelCase in //components/url_rewrite.
This CL was uploaded by git cl split.
R=kmarshall@chromium.org
Bug: 1148486
Change-Id: I61632d4dc853847a4c800e9b62291d06d1d2e7ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3598825
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994776}
[fuchsia] Disable URLRequestQuicPerfTest.TestGetRequest test
Remove the following fuchsia.net_perftests.filter entries:
-URLRequestQuicPerfTest.TestGetRequest
And change them to DISABLED_* on Fuchsia.
Bug: 852937
Change-Id: If5a29d2050c4e7e0d0a47faee0e935ed27e430c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3597082
Reviewed-by: Fabrice de Gans <fdegans@chromium.org>
Auto-Submit: Mason Bendixen <masonben@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994775}
[fuchsia] Disable SimpleIndexPerfTest.EvictionPerformance test
Remove the following fuchsia.net_perftests.filter entries:
-SimpleIndexPerfTest.EvictionPerformance
And change them to DISABLED_* on Fuchsia.
Bug: 1318120
Change-Id: I50ffd7a75494a3ef87b6240b74fcca0563608acd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3597085
Reviewed-by: Fabrice de Gans <fdegans@chromium.org>
Auto-Submit: Mason Bendixen <masonben@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994774}
Avoid calling MarkAncestorChainForFlagsUpdate() if NeedsLayout is true
This is a change in PaintLayer::StyleDidChange().
Right now if diff.NeedsLayout() is true
we're calling MarkAncestorChainForFlagsUpdate().
This patch will avoid doing such call, as it doesn't seem to be needed.
Change-Id: I5612ae677e6a7c199f8050e89ac84c6fd6b5fdef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3592832
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/main@{#994773}
Several fixes related to the phone number merging logic.
The merging logic for phone numbers constructs a complete number from
it's components. This CL fixes two problems related to it:
- It assumes the countries codes are the same. When merging
"0 1578 7912345" (stored in a German profile) and "+41 015787912345"
(entered in a form without country information), the region defaults
to DE. But the latter number is recognized as Swiss due to the calling
code. This currently makes
|DCHECK_EQ(n1.country_code(), n2.country_code())| fail.
It is fixed by preferring parsed country codes over the region. This
way, an update prompt for the newly entered number is shown.
- Formatting is inconsistent with the way phone_number_i18n formats
numbers, which is used for the PhoneNumber implementation. In
particular, the number is internationally formatted when the region
is not empty, while phone_number_i18n relies on the |country_code|.
This way, when e.g. "0 1578 7912345" is stored and autofilled, the
import will suggest to change the number to "+49 1578 7912345".
This is fixed by checking the country code's source.
See https://screenshot.googleplex.com/8t9wMVREov4Ugbc.
This bug can in fact be seen by the expected values in the unit tests.
Currently, it is expected that merging "8005550199" and
"800-555-0199 #321" yields "+1 800-555-0199 ext. 321". The unit tests
are updated accordingly. Because national formatting is slightly
different, the format of some expected values is tweaked too.
Moreover, |ProfilesHaveDifferentSettingsVisibleValues()| is updated to
use |GetInfo()| instead of |GetRawInfo()|, because:
- It guarantees consistent formatting.
- |GetSettingVisibleProfileDifference()| uses |GetInfo()| to determine
the actual difference. This can cause empty update dialogs, when
|ProfilesHaveDifferentSettingsVisibleValues()| detects a difference
only due to formatting. For example, store a profile with
"+4915787912345" and Autofill it:
https://screenshot.googleplex.com/7oHLufe7JxQsDB2.
Bug: 1311937
Change-Id: I162b398c1fe0e9534bf80ebb8ce632679473859f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3548858
Reviewed-by: Christoph Schwering <schwering@google.com>
Reviewed-by: Matthias Körber <koerber@google.com>
Commit-Queue: Florian Leimgruber <fleimgruber@google.com>
Cr-Commit-Position: refs/heads/main@{#994772}
shimless: Repair Completed > Update RMA logs icon
* Replace RMA logs icon SVG with correct SVG
Before: https://screenshot.googleplex.com/8PzgvYTHxibfnJd
After: https://screenshot.googleplex.com/4T8LcHAeBHb8RzC
standalone shimless config.
Test: I tested this locally by running Chrome in my VM using the
Bug: 1198187
Change-Id: Ib1faa55168a4c1ab4b22468dc45c20efe63b491b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3594710
Reviewed-by: Michael Checo <michaelcheco@google.com>
Reviewed-by: Gavin Williams <gavinwill@chromium.org>
Commit-Queue: Camden Bickel <cambickel@google.com>
Cr-Commit-Position: refs/heads/main@{#994771}
[i18n DevTool Deprecation Issue] (8) Migrate DeprecationInfo::WithDetails {CHROMIUM}
This is the simplest type to migrate as the text we need is fully
included inline. The next CL on the DEVTOOLS side will implement the
translated issues. This CL is required first, as it adds the types to
browser_protocol that the DEVTOOLS side needs.
This CL is part of a series:
(1) Remove legacy info
(2) Translate issue title
(3) Translate demo Issue {CHROMIUM}
(4) Translate demo Issue {DEVTOOLS}
(5) Document new deprecation process
(6) Add milestone and status links
(7) Document milestone and status links
(8) Migrate DeprecationInfo::WithDetails {CHROMIUM}
(9) Migrate DeprecationInfo::WithDetails {DEVTOOLS}
(10) Translate more Issues ...
Bug: 1264960
Change-Id: I5358ead272f8adc66f5df16dc5db2ece20023888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3597476
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Quick-Run: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994770}
Roll Fuchsia Internal Images from 8.20220421.0.1 to 8.20220421.1.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/fuchsia-internal-images-chromium
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:fuchsia-fyi-astro
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Disable-Retries: true
Change-Id: Icb5128fe8e190466dd952197b4035dd4843b75fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600493
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#994769}
enterprise: Add method to distinguish Kiosk license
Sync proto with server side: http://go/cl/441592421
Bug: 1308403
Change-Id: I8486beb8d3ba0725b9d736b14209beff9812261b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3584098
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/main@{#994768}
Update V8 to version 10.3.28.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7d931e20..e022059f
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
Change-Id: If1fc5360f1c851984e92efea3ed1a2efe41fdef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3599107
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#994767}
shimless: Repair Completed > Update diagnostics icon
* Add diagnostics icon SVG to Repair Completed page
* Remove existing diagnostics icon image
* Remove "hidden" property on icons in this page
Before: https://screenshot.googleplex.com/8PzgvYTHxibfnJd
After: https://screenshot.googleplex.com/6H5DkinnJDPmybW
Bug: 1198187
Test: I tested this locally by running Chrome in my VM using the
standalone shimless config.
Change-Id: Ie3a302dc30d20206e91d6849131f60600f87924e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3594383
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Gavin Williams <gavinwill@chromium.org>
Commit-Queue: Camden Bickel <cambickel@google.com>
Cr-Commit-Position: refs/heads/main@{#994766}
Revert "[iOS] Disable QRCode on iPhone simulator"
This reverts commit 3470c9243b3188b887e3287ffd9618a4e75d2c73.
Reason for revert: header layout fixes have landed
Original change's description:
> [iOS] Disable QRCode on iPhone simulator
>
> The tests are failing on small iPhone.
>
> Bug: 1315524
> Change-Id: Ie0b6e995ede567b17a058bdbbde63a2fc0c33804
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3581870
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Auto-Submit: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#991450}
Bug: 1315524
Change-Id: I431703bfc491b2ca298528e3da396a02fa7d6988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600258
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994765}
ipcz: Implement basic portal I/O
Split out from the ipcz uber-CL: https://crrev.com/c/3570271
Implements primitive Put() and Get() APIs on top of portals. Still only
supports portals local to the same node.
Bug: 1299283
Change-Id: Ibacf5eb1170a58c2397f6337dc662223a56d5386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3587135
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/main@{#994764}
Automatic update from google3
Automatic update for 2022-04-21 UTC
Change-Id: I21f08b5c818f0a0b1375452bbb0dfb63a77fa29f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600395
Commit-Queue: CT Log list updates bot <mdb.chrome-pki-metadata@google.com>
Bot-Commit: CT Log list updates bot <mdb.chrome-pki-metadata@google.com>
Cr-Commit-Position: refs/heads/main@{#994763}
[Passwords] Update bubble shown upon updating a compromised credential
This CL updates the bubble shown upon updating a compromised credential
to reflect the Google Password Manager branding.
Mocks: https://docs.google.com/presentation/d/1lDlG2iyXfcvkcXimycd0u6iCHmK46l_LjCIicuedh-A/edit#slide=id.g122c6d4e183_1_116
Screenshots:
Safe: http://screen/5ZzDqVqck65fwF6
More to fix: http://screen/9UTFLKndkzCk6nd
Bug: 1309480
Change-Id: Ic8e826c84cd7fa484ff8f156bf47fc0792340bb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3599415
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994762}
[Passwords] Update the Move Password to Account bubble
This CL update the move password to account bubble to reflect the
Google Password Manager branding.
Screenshot: http://screen/3RAL8f2rvjPJWFJ
Bug: 1309480
Change-Id: I48491537a7cc4511d4cc248541ec7f1748ba9d6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3599077
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994761}
Roll Help App from FTiDkSM95... to 9oXvHWZSz...
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202204210800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/9oXvHWZSzgq3VfRZiGQOy8NgciC1Nvi7STNVzH5CrXYC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: help-app@grotations.appspotmail.com
Change-Id: Ibdc1627e15be6b89e50cef840e9178f2f32e2b52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600322
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#994760}
Speed up ScriptResource::SourceText by decoding on a worker thread
While investigating some traces, I noticed that
ClassicPendingScript::GetSource could be very slow (>10ms for larger
scripts). There were two main operations that were taking a long time:
1) Decoding the script data
2) Hashing the script source for ParkableString
This patch performs that expensive work on a worker thread as we receive
the data, which should significantly speed up this call.
Bug: 1317462
Change-Id: I2fff1d92448ef54252692682790707bfc1c82c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3591535
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994759}
Roll RTS model from 04EehTsok... to NzPgdacNP...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-linux-amd64-chromium-autoroll
Please CC guterman@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: guterman@google.com
Change-Id: I52b3828b1487aab467be7802fdfacaf868b1297e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600319
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#994758}
Remove use of MojoUnion::New() in //chrome/browser/media/router.
mojom::ProviderState::New() has a generic-sounding name but actually
creates a union containing the first declared subtype. In general, this
behavior is non-intuitive and is slated for removal from the generated
Mojo bindings.
Bug: 1261169
Change-Id: I5c19bf3c3edfe761b30f0959e54b01d805c22741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3597642
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994757}
Add context menu item to hide productivity launcher continue section
Allow the user to choose to hide the continue section and recent apps.
Per UX, a single context menu command hides both section. See mocks
linked in bug.
This CL only adds the context menu item to the continue task context
menu. A future CL will add it to the recent apps context menu.
The text is not localized because the text isn't final yet. Likewise
the icon is not final.
Screenshots:
https://screenshot.googleplex.com/9oQpyQQki86PCqM
https://screenshot.googleplex.com/AUiEjVbajmSBHFR
Bug: 1317428
Test: added to ash_unittests
Change-Id: I2a1a0124801e1c915e4ab38ea9013b75d9d22f73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3591876
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994756}
lacros: Fix crash due to unpinned ash-chrome app.
If the ash-chrome app is not available in the listed of pinned apps,
then ash will crash. It's not immediately clear how this can happen as
it is always pinned at startup. Regardless of the cause, the existing
logic should be robust to either lacros or ash as the pinned app.
Bug: 1316653
Change-Id: I50045d1b4162068bd627f918dcf5a65b43324c21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3597518
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994755}
Roll RTS model from 5K2gTFMZo... to wxbih7Jef...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/rts-mac-amd64-chromium-autoroll
Please CC guterman@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: guterman@google.com
Change-Id: Ide96deff66d7316634f4cc2d451427e0742b9bbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600321
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#994754}
[iOS] Error page refactoring, fix error page restoration
The LoadSimulatedRequest API was not handle by the restoration as
expected. It always creates a new navigation item when there is no
currently committed item, so if the first navigation after restoration
triggers an error page, it would create a new item instead of using the
existing one.
To avoid that, when it is a restoration, we use loadHTMLString instead
of loadSimulatedRequest.
See result video:
https://drive.google.com/file/d/1AOlZ-xzI-NkJhcMMlMjBQ6jFfs3UQLXt/view?usp=sharing
Change-Id: I25eaac2da0a8e8ad619febca178fc6ab86a507d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3599073
Reviewed-by: Ali Juma <ajuma@chromium.org>
Commit-Queue: Aliona Dangla <alionadangla@chromium.org>
Auto-Submit: Aliona Dangla <alionadangla@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994753}
Roll Skia from bd8f8686cc01 to 9af6e97e6a95 (4 revisions)
https://skia.googlesource.com/skia.git/+log/bd8f8686cc01..9af6e97e6a95
2022-04-21 michaelludwig@google.com Replicate stroked line endpoints when converting to cubics
2022-04-21 jvanverth@google.com [graphite] More steps towards a shared DrawAtlas class.
2022-04-21 kjlubick@google.com Roll Dawn from 93a2bed032a9 to 4091e0fa9c1e (18 revisions)
2022-04-21 kjlubick@google.com [bazel] Move skcms and vulkanmemoryalloctor to subdirs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC wrightgeorge@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: wrightgeorge@google.com
Change-Id: I2736d9c7f71e397aef2fcd3c56c0f6705f7e387a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3600014
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#994752}
Fixes the position of the delegate layer of shelf navigation widget.
Originally, the bounds of the delegate view layer of shelf navigation
widget wasn't calculated for RTL mode. This worked because the delegate
view and all its children were symmetric. With the new launcher nudge
with label view, the statement won't necessarily be true anymore, and
we want to put the delegate view and the buttons on the right corner of
the screen.
With this cl, we assume that the navigation widget delegate locates at
the corner of the screen, which is bottom left in LTR and bottom right
in RTL.
Bug: 1308733
Change-Id: I03a2a1f55a2220b31ee1e12e5be7fcdc5bcffb08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3596909
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Wen-Chien Wang <wcwang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994751}
Convert SHOUTY_CASE Mojo union tags to kCamelCase in //chrome/browser/ash/system_logs.
This CL was uploaded by git cl split.
R=zentaro@chromium.org
Bug: 1148486
Change-Id: I4c4f37379a9ec9a8acb110f719d3b139cff7e531
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3599220
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994750}
[iOS] Error page refactoring, fix WebStateObserver tests
This CL enables kUseLoadSimulatedRequestForErrorPageNavigation flag and
correct tests accordingly to the new error page flow.
Change-Id: I574c7caed696b537005d573834d08df07e842792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3593198
Auto-Submit: Aliona Dangla <alionadangla@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994749}
Move STGButton to its own file in preparation for code split of BBV
1/4
We are going to split the functionality of BookmarkBarViews Tab Group
implementation out into its own view for testability and code clarity.
First we will start with what is already implemented in BBV, the
buttons for the Saved Tab Groups.
We also create a new AX node description for the saved tab group buttons.
Change-Id: I1bece0fe44ab6f79a0827afa9071ce1bc2b75332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561503
Reviewed-by: Darryl James <dljames@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994748}
Fenced Frames: Fix ad size test that fails on screens with width 600
This test case expects (screen width)x90 to be coerced to (screen width)x100. But on Nexus 7, the screen width is 600, and the closer size 600x93 is available due to the 32/5 aspect ratio flexible size. We can fix this by using 99 rather than 90. (I verified it manually with the dev tools mobile screen simulator.)
Bug: 1317720, 1123606
Change-Id: If0352b2afe04c36a739984dfc510aed223484d2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3597054
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Garrett Tanzer <gtanzer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994747}