Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
Roll Chrome Win ARM64 PGO Profile
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1749729434-b19bc68d27adad7328b96ba38bf6c54369944bbb-ea6e80c17deabbd235a4d48d9ad4d3315117a73b.profdata to chrome-win-arm64-main-1749793413-625369a899ac3e84be48ece80628bd5b5533497e-cdfe1f2e8a7f0dda65e5575431ff3103b4984cc6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Id5d3afcc142e5b2f524b1b2f49c7edbc53d0331f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6642914
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1473450}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1749793413-1f41321f13e06e4f1df47c44fd9a998d16f3492c-cdfe1f2e8a7f0dda65e5575431ff3103b4984cc6.profdata to chrome-android64-main-1749800482-7ee5aa6a69e9f1ec688041c4eb490ba276fa38c6-25ce2152f5b35ab136f3143b94ae9ce36bca004c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I0b2b441d4a39b8b9a253b170bbebe17e5514c3b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6642912
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1473449}
Disable ScreenMagnifierChromeVoxFollowingPref due to flakiness
Bug: 417555323
Change-Id: Ibb9a7a55aa2474b7d7d55eaf0ca413782dc5f169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6642958
Auto-Submit: Jan Keitel <jkeitel@google.com>
Owners-Override: Jan Keitel <jkeitel@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1473448}
Roll ANGLE from fdff117046ce to db0c266c0a08 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/fdff117046ce..db0c266c0a08
2025-06-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3d57e475d87b to 5d8e5baf56fe (514 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: solti@google.com
Change-Id: I8a2610360485bd6a2aa92191ae41f78faaf680f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6642905
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1473447}
Add more detailed test expectations to TabSearch browser tests
The test is flaky on Windows. Failure traces indicate a nullptr
dereference.
This CL adds a more careful assertion that will give information
about which part of the expression has become null.
Bug: 414839512
Change-Id: I44788360863fcee97ff3458757af770e6bd7be23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6633383
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1473446}
Add Crossbench loading benchmark to WV Perf waterfall
Change-Id: I78f4885d0638df4ed7f91098011c98f72ab86792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6641218
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Mateusz Zbikowski <zbikowski@google.com>
Cr-Commit-Position: refs/heads/main@{#1473445}
Roll SearchEnginesData from b07b9e19ca1e to 09fd22f3a4fb (1 revision)
https://chromium.googlesource.com/external/search_engines_data.git/+log/b07b9e19ca1e..09fd22f3a4fb
2025-06-13 noreply@google.com Propagate Search Engines assets.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/search-engines-data-chromium
Please CC chrome-search@google.com,dgn@google.com,ender@google.com,jdonnelly@google.com,orinj@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://b.corp.google.com/issues/new?component=1495064&template=0
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: dgn@google.com,ender@google.com,jdonnelly@google.com,orinj@google.com
Change-Id: I48883650ec8f77a6e50b1348c74dc774731e4631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6641789
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473444}
[Blink] Introduce and use GetResourceProviderForWebGPU()
Replaces ResourceProviderDEPRECATED() for callsites where the context is
WebGPU.
Bug: 352263194
Change-Id: I30b8c219a07f0fdd890876409f0dc084521d843a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6641537
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473443}
[iOS]ConsistencyAccountChooserCoordinator uses start
This ensure that this follows the usual Coordinator protocol.
Bug: None
Change-Id: I2c912a53cbffe742b49e3e50b9f26913328853dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6625575
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Arthur Milchior <arthurmilchior@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473442}
[Blink] Deprecate CanvasResourceHost::ResourceProvider()
Adds a DEPRECATED suffix to make it self-evident where method calls
still need to be transitioned.
Note: This CL doesn't in of itself change any calls to non-deprecated
variants; followup work will do so.
Bug: 352263194
Change-Id: I03534b03d8b1f00158aa9f59281e150b0ecf190f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6633983
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473441}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1749793413-48a663bb2389887e2a6fa380bde73143736c390c-cdfe1f2e8a7f0dda65e5575431ff3103b4984cc6.profdata to chrome-mac-arm-main-1749801283-264de11ad91d8cc0161d9415063fc2081921a433-6fe878cf0099e154f497034d6f87be027bbb7636.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I5da1101dab5a6bab10a6aa91ed0d7c10da5daeeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6642913
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1473440}
[Blink] Eliminate CanvasRenderingContext::DrawsViaGpu()
Inline into its one callsite.
Bug: 352263194
Change-Id: Ic29d917275a9b5a265319d71d2ce0432fcbec60c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6633378
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473439}
[Blink] Remove unneeded check in HTMLCanvasElement::UpdateMemoryUsage()
This conditional checks for the existence of `context_`. However, due to
the conditional just above we know that IsRenderingContext2D() is true
or IsWebGL() is true. Either of these being true means that `context_`
is present, since both methods return false if `context_` is null.
Bug: 352263194
Change-Id: I757d1fc483ccb23665306f0f1461e5197074f5cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632981
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473438}
[Blink] Simplify HTMLCanvasElement::UpdateMemoryUsage()
The two types of buffers being counted here have their memory usage
computed exactly the same way. Merge them into just one variable and
do the computation once. This simplifies a followup CL that will
eliminate CanvasRenderingContext::DrawsViaGpu().
Note: This entire computation is kind of wonky and should at some point
be rethought at a higher level, but that's outside the scope of my work
here.
Bug: 352263194
Change-Id: I92bc7482381f69b590c813d9eca06cff7ac8c231
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632918
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473437}
[Blink] Eliminate OffscreenCanvasRC2D constructor ResourceProvider calls
The OffscreenCanvas cannot have a ResourceProvider at this point, as
the OffscreenCanvas' resource provider will get created only via calls
from OffscreenCanvasRenderingContext2D itself that happen
post-construction of the latter object (this is verified by the fact
that OffscreenCanvas::GetOrCreateResourceProviderForCanvas2D() CHECKs
that the context type is 2D, which is a CHECK that will succeed only
after the context object is returned from construction and installed in
the host).
The DidDraw() call that the checks are guarding seems to have lost
relevance in any case; at some point in the past we cleared the canvas
in the OffScreenCanvasRC2D constructor (e.g., [1] shows this, although
the clearing code predates that CL), but we no longer do so.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1915284
Bug: 352263194
Change-Id: Ifa4082329db7178ab0070817688bca374ac05dc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6633610
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473436}
[Blink] Fix ImageBitmapRC::PaintRenderingResultsToSnapshot()
The current implementation is broken: ImageBitmapRenderingContext
doesn't populate the canvas' ResourceProvider other than for offscreen
canvas, and thus this method will return nullptr if called in
HTMLCanvasElement flows (e.g., if called for printing here [1]).
This CL changes it to call through to GetImage().
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/canvas/html_canvas_element.cc;l=1269-1270;drc=5e74ac5d42bce00b534d992272e7fa09b53b300f
Bug: 352263194
Change-Id: I088bf5e67902a90d8f426b68202cdaa86622b2b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6633573
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473435}
[invalidation] Remove invalidation_topics_only field
Remove the unused legacy flag from PolicyFetchRequest. It's been
deprecated for a long time and now the topic invalidations are migrated
to direct messages.
Bug: b:341377023
Change-Id: I6f83aafe3111aedb1c45edb83ab23fda5bb3e64b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632942
Auto-Submit: Artem Sumaneev <asumaneev@google.com>
Reviewed-by: Igor <igorcov@chromium.org>
Commit-Queue: Artem Sumaneev <asumaneev@google.com>
Cr-Commit-Position: refs/heads/main@{#1473434}
[Blink] Merge WebGLRC's PaintRenderingResultsToCanvas{Internal}
These methods are both private now, and thus there's no reason for them
to be distinct.
Bug: 352263194
Change-Id: I58b614751f926f7cbbf2e34aca0e984582d6b4ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6633340
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473433}
[Blink] Streamline PaintRenderingResultsToCanvas() impls
This method no longer needs to be on CanvasRenderingContext. This CL
moves it to be private in the various contexts, inlining it in the
contexts for which the implementation is trivial.
Bug: 352263194
Change-Id: Ifb08073b5f2c822aee19503d726ee3fa2a7071d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6633572
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473432}
[Blink] Implement CRC::PaintRenderingResultsToSnapshot() in subclasses
Rather than providing a default implementation, make this method pure
virtual. This will allow for moving the non-2D implementations away
from using the canvas' CanvasResourceProvider (or potentially *any*
CanvasResourceProvider) in followup.
Bug: 352263194
Change-Id: I562bebfcb8b887f23bea2be11a5ab49dabf6fdb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6633970
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473431}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1749772766-f6e6315167c6d1562f8c977b47bb36e1681dd71e-08fdea4fb1d4d6c2753e0aaf17cdf7767ce3ab59.profdata to chrome-linux-main-1749793413-51a80ee7b88ffe8d73f1c96f006df2e20a8f5e99-cdfe1f2e8a7f0dda65e5575431ff3103b4984cc6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I96a3ecdbbe27ca9f53551bb55030f6653a60d55a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6642734
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1473430}
Fix flakes in resource test
The test was flaky on some test runners. This test changes the wait
condition to a postback from the web page itself, which is triggered
once the cross-origin resource has been requested, and load failed
because we return an invalid image.
Fixed: 424621656
Change-Id: If5a0fade3a1019a9c81be647f741741f5a75160a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632985
Auto-Submit: Peter Pakkenberg <pbirk@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Pakkenberg <pbirk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473429}
Reland "Add bookmark batch upload card render tests"
Fixed how the activity gets accessed on tablets.
This is a reland of commit 1a28f29d27f91a19159be28a8222767566d9e4a2
Original change's description:
> Add bookmark batch upload card render tests
>
> Fixed: 392557405
> Change-Id: Ic58f6c45a7efd25f0232a879a339aa95c7046fda
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6621553
> Reviewed-by: Brandon Wylie <wylieb@google.com>
> Commit-Queue: Mahmoud Rashad <mmrashad@google.com>
> Cr-Commit-Position: refs/heads/main@{#1470809}
Fixed: 392557405
Change-Id: I92409878add6d10c60938b97df7db941137a322f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6624823
Commit-Queue: Mahmoud Rashad <mmrashad@google.com>
Reviewed-by: Brandon Wylie <wylieb@google.com>
Cr-Commit-Position: refs/heads/main@{#1473428}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1749772766-34b693e588f5503f77e375782d7d90468bd0e60f-08fdea4fb1d4d6c2753e0aaf17cdf7767ce3ab59.profdata to chrome-mac-main-1749793413-f7e678c1187b199f8985972ee0f371d469f15f01-cdfe1f2e8a7f0dda65e5575431ff3103b4984cc6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: If626fc3d7d9882d73c1cb48e6205c09f09d44cd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6642900
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1473427}
spanify: Introduce base::SpanificationSizeofForStdArray to improve the rewritten code
Introduces SpanificationSizeofForStdArray utility function so that
the auto-spanified code will be more readable.
[Example]
Before spanification:
int buf[] = ...;
size_t size = sizeof(buf)
After spanification without this patch:
auto buf = std::to_array<int>({...});
size_t size = (buf.size() * sizeof(decltype(buf)::value_type));
After spanification with this patch:
auto buf = std::to_array<int>({...});
size_t size = base::SpanificationSizeofForStdArray(buf);
Change-Id: Ic05e037d893f4d2165fdafb8ccac62adeec7f165
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6636331
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473426}
[PasswordChange] Update leak dialog strings
Bug: 417388947
Change-Id: Ied118382c735bd1a7f631987cd346eb2a22ea6cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6634590
Commit-Queue: Rafał Godlewski <rgod@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473425}
Add a DCHECK for null graphite::Context in GraphiteSharedContext Ctor
Bug: Bug:407874799
Change-Id: I317505f02f4fc8064937a7b172a07bdef644b459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6641108
Auto-Submit: Maggie Chen <magchen@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473424}
Set menu presentation in autofill example app.
The autofill example app sets dialog and inline presentations but not
menu presentation. Menu presentation is required for results to show
at all under certain configurations such as a Pixel 8 phone connected
to a bluetooth keyboard (i.e. in the absence of an onscreen keyboard).
Change-Id: Ifca3f3bd7c2841f02fa7125991427258343a27fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6641981
Commit-Queue: Ivana Žužić <izuzic@google.com>
Reviewed-by: Ivana Žužić <izuzic@google.com>
Auto-Submit: Bryce Thomas <bryct@meta.com>
Reviewed-by: Friedrich Hauser <friedrichh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473423}
Rudimentary testing that reciever getParameters does header extensions
Bug: chromium:423460792
Change-Id: I2ed0e27a455b07d8e674f567bc2d069927311e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6641542
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473422}
Roll clank/internal/apps from 7b8208f412e5 to 6106b86610a6 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/7b8208f412e5..6106b86610a6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC anthie@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: anthie@google.com
No-Try: true
Change-Id: Iae189bcbe4f8a5f8938d5a34b218b339dd48f6d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6642909
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1473421}
Roll DevTools Frontend from 59ef2610ba7c to 89ad8f4cc85c (3 revisions)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/59ef2610ba7c..89ad8f4cc85c
2025-06-13 alexrudenko@chromium.org Revert "Move focus to data grid when a node is selected"
2025-06-13 bmeurer@chromium.org [settings] Fix focus ring of User agent client hints.
2025-06-13 bmeurer@chromium.org [settings] Refresh Sync settings when user is logging in.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I4b931008ee8c93b188e65134ace5dc27d360a60a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6642921
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1473420}
Replace open_{pwa/app}_if_possible with service_worker_open_window
This field is only used in tests and for service worker navigations;
make this distinction more explicit.
Bug: 382542907
Change-Id: Ibc3a5bafadd423f8038b6e306198c2b5e9f760f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6618987
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Mike Wasserman <msw@chromium.org>
Commit-Queue: Andrew Rayskiy <greengrape@google.com>
Reviewed-by: Dibyajyoti Pal <dibyapal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473419}
HttpStreamPool: Tweak NetLog events
- Add service endpoints in GetInfoAsValue().
- Stop using ErrorToString() since string fields are omitted when netlog
events are converted to trace events and trace recording is privacy
sensitive.
- Add IPEndPoint to TcpBasedAttempt start.
Bug: 346835898
Change-Id: I18d8335e9a5e641a6bfa8d7d18b544b344b7e495
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6636692
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473418}
Reland "Conditionally include base/logging.h in base/feature_list.h"
This is a reland of commit 64b33935a2d6965357b5c616eb7a95ac7fba57e6
Some //base header cleanups collided and the original CL revealed yet
another missing include, which https://crrev.com/c/6628957 fixes.
With all the //base header cleanups, do more IWYU to fix the build.
Original change's description:
> Conditionally include base/logging.h in base/feature_list.h
>
> In base/feature_list.h, base/logging.h is effectively only needed on
> Chrome OS. Make this include conditional, and then do IWYU to fix the
> build.
>
> Change-Id: I02371f4873a62d7bf66d5460fa731a652cb0ac9a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6626024
> Owners-Override: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1470949}
Change-Id: I8432c2080e482e79d7e16b68511ed963887e46cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6629437
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Owners-Override: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473417}
Do IWYU for thread_pool_instance.h
Bug: 40318405
Change-Id: Id303320291436495674794a115a158d2534a17fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6642077
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473416}
net: Avoid unnecessary string construction
Fix a few places in //net where std::strings were constructed
unnecessarily.
Also inline the string constants in //net/http/http_auth_scheme.h so the
compiler can optimize them more easily.
Also wrap all of url_request_http_job.cc in namespace net and remove
unnecessary namespace qualifiers from that file.
Also use base::flat_set instead of std::set for sets that are always
small.
Change-Id: Id2ffa42ac058c9bcd1f11ddc662034b0caacf254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6622734
Auto-Submit: Adam Rice <ricea@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473415}
wpt for DCHECK in WebSocketChannelImpl::OnWritable()
Add a repro for a DCHECK failure in WebSocketChannelImpl::OnWritable()
which was fixed by https://crrev.com/c/6588148.
Test originally authored by Andrey Kosyakov caseq@chromium.org in
https://crrev.com/c/6548340.
BUG=417804939
Change-Id: I78eb9382451f8550ca0535157634a0f21de87b88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6637954
Auto-Submit: Adam Rice <ricea@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473414}
Roll ChromeOS Bigcore AFDO profile from 139-7204.8-1749436445-benchmark-139.0.7230.0-r1 to 139-7204.8-1749436445-benchmark-139.0.7234.0-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-bigcore-chromium
Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: mobiletc-prebuild@google.com
Change-Id: Iff60f148ee64e85e73702ee1f25dba1e4edb29a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6642735
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1473413}
Adjust expectation for RelativeOrientationSensor.https.html WPT on Win11
Bug: 424691821
Change-Id: I2697004e711a99c71dc2ca8c9db99d5eb2ed38cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632798
Auto-Submit: Jan Keitel <jkeitel@google.com>
Commit-Queue: Andrii Natiahlyi <natiahlyi@google.com>
Commit-Queue: Jan Keitel <jkeitel@google.com>
Reviewed-by: Andrii Natiahlyi <natiahlyi@google.com>
Owners-Override: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1473412}
Roll androidx from 8yk3nGtlqZGx48ZgV... to oyu2fpTO_0piy3yAZ...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC clank-build@google.com,clank-library-failures@google.com,wnwen@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel;luci.chrome.try:test-o-emulator
Tbr: clank-library-failures@google.com
Change-Id: Ia9056ee16aa755954a548338ef3ed49053887710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6639912
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1473411}
Favor heuristics over UNKNOWN_TYPE server prediction for loyalty cards.
Screenshots with fix:
- https://screenshot.googleplex.com/4FNr3fC3hFHstKB
- https://screenshot.googleplex.com/873482m7VjsqeRA
Bug: 424378427
Change-Id: I81684b31656a424b48e355f0ae647ea5f365c6e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6641216
Reviewed-by: Norge Vizcay <vizcay@google.com>
Auto-Submit: Piotr Wrótniak <piotrwrotniak@google.com>
Commit-Queue: Norge Vizcay <vizcay@google.com>
Cr-Commit-Position: refs/heads/main@{#1473410}
Allow chrome.windows.create() to only open IWAs at start_url
Using chrome.windows.create(), extensions can arbitrarily deep-link into
Isolated Web Apps. As a mitigation, this CL forces all such navigations
to open the app at a well-defined entry point while keeping the intended
URL accessible via launchQueue.
Bug: 424128443
Change-Id: I768080fec61f3ad165917564afc3b26ec889a3e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6632789
Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Commit-Queue: Andrew Rayskiy <greengrape@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473409}
Roll ChromeOS Atom AFDO profile from 139-7204.17-1749436011-benchmark-139.0.7230.0-r1 to 139-7204.17-1749436011-benchmark-139.0.7234.0-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-atom-chromium
Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: mobiletc-prebuild@google.com
Change-Id: I810e06e70bc0d3454d48be2443a82c2d852eb304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6642732
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1473408}
Caret-shape: Add basic caret-shape tests to check that care-shape can be set in textarea.
Check the CSS property can be set and the caret shapes are displayed as expected.
Bug: 353713061
Change-Id: I873db04f1f90154410089ba71083af250f43918f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6633619
Commit-Queue: Ziran Sun <zsun@igalia.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473407}
spanify: Support casts in macro expansions
Mostly just adds test cases for cast expressions in macro
expansions, but also fixes reinterpret_cast expressions in
macro expansions.
Change-Id: Ia99e2bbf8860b8fb1e1225c1aecd1e269abb722b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6626247
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473406}
Speed up HttpRequestHeaders::ToString()
net::HttpRequestHeaders::ToString() is used to assemble the request
headers for HTTP/1.1 requests. It was unnecessarily using
base::StringAppendF() in a loop. Switch to a single call to
base::StrCat() to reduce memory allocations and copies.
Also add benchmark for HttpRequestHeaders::ToString
Time to run the benchmark on a low-end Android ARM32 device:
Before: mean 11691 ns
After: mean 4290 ns
No functional change.
Change-Id: Iaaa9da0addb683dd793bcf2383fe96e0e2296f82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6638833
Reviewed-by: Nidhi Jaju <nidhijaju@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473405}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1749787720-70e6f99a8974f8db99cce9d5784f73daec7017f9-4729d86ee2e5d5ee017f49fe503e823076c43f1e.profdata to chrome-android64-main-1749793413-1f41321f13e06e4f1df47c44fd9a998d16f3492c-cdfe1f2e8a7f0dda65e5575431ff3103b4984cc6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I9194291583e3f7017b1abc25cc5fc24c308534f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6641792
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1473404}
Disable testOpeningIncognitoTabsDoNotLeak on Simulator
It appears that
FallbackCoordinatorTestCase/testOpeningIncognitoTabsDoNotLeak is still
breaking on Simulator.
Bug: 40776865
Change-Id: I07218c5b6aefb328d26c4c1376a56b31f68519b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6633308
Reviewed-by: Vincent Boisselle <vincb@google.com>
Auto-Submit: Louis Romero <lpromero@google.com>
Commit-Queue: Louis Romero <lpromero@google.com>
Cr-Commit-Position: refs/heads/main@{#1473403}
Roll Chrome Android ARM32 PGO Profile
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1749772766-d96a6ef25da30737887d72f09c24435d691e8e4a-08fdea4fb1d4d6c2753e0aaf17cdf7767ce3ab59.profdata to chrome-android32-main-1749793413-7daf7a2fc3724b067ec30357f24238042c6b45b4-cdfe1f2e8a7f0dda65e5575431ff3103b4984cc6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I06de60c7d65ee5728a75964313a2c91849606ee4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6642920
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1473402}
chrome/smb_client: migrate to new crypto/hash API
Migrate smbfs_share in chrome/browser/ash/smb_client from crypto/sha2 to
crypto/hash. The new interfaces are a bit more efficient due to making
fewer heap allocations and a bit more resistant to misuse. They are also
not deprecated.
Bug: 374310081
Change-Id: Ifac52282a2f5da4a46a0eb456d167eb74346cc4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6634150
Reviewed-by: François Degros <fdegros@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1473401}