Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
HttpStreamPool: Add histogram for QuicTask completion
The HEv3 code path seems to create TCP attempts more aggressively
than the non-HEv3 code path when QUIC session is established.
We want to reduce such wasteful attempts. This CL adds a histogram
to record time to complete a QUIC attempt. The histogram would be
useful to adjust the TCP delay timer.
Bug: 384759483
Change-Id: Ie1386c47c4a2168bd067c5d4bd5698a2b095fe57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166685
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405071}
Fix spelling of Collboration.
Change-Id: I3c24ce854069ad2400d1f6fd3047d8eeff471f9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168632
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Auto-Submit: Sky Malice <skym@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405070}
Switch StorageKey to C++20 comparisons: <=> and ==, not <, ==, and !=
Allows more std::ranges use with StorageKey.
Bug: 386918226
Change-Id: If8bfc72625959f7e3eb28ca9744eafd03a460c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6163829
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Ari Chivukula <arichiv@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405069}
Add NetLog event for SSLClientSocket::Connect()
In some cases we doesn't seem to pass ECH config list to BoringSSL
even when the DNS stack provides the list. Add a NetLog event in
the ConnectJob layer to check if the ConnectJob layer actually
passes ECH config list, if enabled.
Bug: 384394707
Change-Id: I6edb71716d4eaccb8552b6a4e6370990cb74ea83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164424
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405068}
[TreesInViz] Skip copy output request cc_unittests
Skip copy output request tests when TreesInViz is enabled until
issue 389147356 is resolved.
Bug: 383016428, 389148369
Change-Id: I599f159d5913417e61d3795cab79e4f35efc3b5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168253
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405067}
[TreesInViz] Skip single threaded cc_unittests
Skip single threaded tests when TreesInViz is enabled until
issue 389147356 is resolved.
Bug: 383016428, 389147356
Change-Id: I9f97902ca06c65900b19baa67b9c42a02d276ffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168448
Commit-Queue: Victor Miura <vmiura@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405066}
Roll Perfetto Trace Processor Linux from 0893e2af69ca to e324242074e2
https://android.googlesource.com/platform/external/perfetto.git/+log/0893e2af69ca..e324242074e2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I7c07352d22d7827f7042d17e93debe726a1dd911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168886
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405065}
Android: Dismiss text magnifier on RWHVA change
Due to stale states and early returns, `handleDragStopped()` was not
called after certain cross-process navigations. This meant text
magnifier did not always dismiss when renderer process changed.
See bug for more details.
To fix this, we call `handleDragStopped()` when
`SPC::UpdateRenderProcessConnection()` is called to dismiss the text
magnifier. This ensures dismissal after renderer process changes.
Fixed: 384033062
Change-Id: I158529d40dba86f21b275c7031531797498635dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6093444
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Alesandro Ortiz <alesandro@alesandroortiz.com>
Reviewed-by: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405064}
Roll clank/internal/apps from a86bfaca1a57 to b55a76c3e05e (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/a86bfaca1a57..b55a76c3e05e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,clhager@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: clhager@google.com
No-Try: true
Change-Id: Ic439ec36d7bda3d8e0bcfdf18fc4e177c550689d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168494
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405063}
[Phone Hub][Eche] Remove OWNERS no longer working on Chromium/OS
Change-Id: Ic24c17b7a17c500ddf5cee673a37f5458d9d1c79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168607
Reviewed-by: Abbas Nayebi <nayebi@google.com>
Commit-Queue: Abbas Nayebi <nayebi@google.com>
Auto-Submit: Crisrael Lucero <crisrael@google.com>
Cr-Commit-Position: refs/heads/main@{#1405062}
Clean up MeterDevolveAppearance feature flag
Bug: 365953514
Change-Id: I363a112151d1addd8bbd8b9d23c96ab7d9ddcf9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165345
Commit-Queue: Traian Captan <tcaptan@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405061}
[Anchor] Expose stacker method for recalculating height w/o pushing update
On its own this change is no-op, but it will enable us to correctly
animate toolbar position changes in future CLs. The problem being solved
is this: there can only be a single pending change to browser controls
params at any given point in time. If BottomControlsStacker "wins" this
race, subsequent param changes (e.g. from setControlsPosition) will
be unable to robustly enable animation because the call to
shouldAnimateBrowserControlsHeightChanges will come in a subsequent
stack frame.
Bug: 369134461
Change-Id: I6c5b6caa3f755827a78d7294ef9afbfc6543fb8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166128
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405060}
Remove and extend histograms
Remove SBClientDownload.SafeDownloadOpenedLatency2*. This histogram was
originally added to inform whether a second ping at download open time
is useful. This is not prioritized.
The remaining histograms are still useful.
OBSOLETE_HISTOGRAMS=data is no longer useful.
Fixed: 386793004,384509441,383123186,383122968,383123044,383123400,383122911
Change-Id: I59ce4f89545cfd8b0cd88c8c31576606f2d932bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168447
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405059}
Add equalized prompt buttons to field trial config
Bug: 389115996
Change-Id: Ib60c9a35e54a06ab087c617fb6488ef03ad2f39d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6163912
Commit-Queue: Kevin Graney <kmg@google.com>
Auto-Submit: Kevin Graney <kmg@google.com>
Reviewed-by: Jacob Stanley <jacobstanley@google.com>
Cr-Commit-Position: refs/heads/main@{#1405058}
Migrate shortcut handling suspension to base accelerator listener
We will need the suspend logic in the version in //ui/base so I'm
working to move the rest of the GlobalShortcutListener logic over
there. The steps are:
1. Move shortcut handling suspension (this CL)
2. Have GlobalShortcutListener::Get instance return the //base one
3. Fully delete GlobalShortcutListener and update references
Bug: 388341014
Change-Id: I733601ddac5f3f804b92c224bb378cd772c2da58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6158027
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405057}
CrOS Settings: Revise languages page imports in lazy_load.js
Subpages should only be imported in lazy_load.js. Additionally,
components used within subpages should be imported in the components
they are used in.
Bug: b:263414034
Test: browser_tests
Change-Id: I37e98ac6787f6c8a49b997e34c1bc70dfe43bf0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6167586
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Wes Okuhara <wesokuhara@google.com>
Cr-Commit-Position: refs/heads/main@{#1405056}
Roll clank/internal/apps from de102b699470 to a86bfaca1a57 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/de102b699470..a86bfaca1a57
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,clhager@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: clhager@google.com
No-Try: true
Change-Id: I59b357f8716f7576ea76d8f32b8cf70289e969ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168492
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405055}
Remove katzz from OWNERS.
Change-Id: I196062aaac964c0b9e97503faf076b441a63350e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168553
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Auto-Submit: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405054}
Remove WeakReference from WebContentsObserver.
The GC root issue should be solved by the WebContentsInternal as
well as the WeakReference to the AwContents held by the Webview
created Observer.
Bug: None
Change-Id: Ic1b90d0d61da7f9214e623239304650d65c4fb5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165785
Reviewed-by: Bo Liu <boliu@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405053}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1736539187-cf0408e8384cfe780b58ec5f3957803abdca93b9-0c8740fe00e049887087558ff326da6621865054.profdata to chrome-mac-arm-main-1736546271-1c0a9015d56b86f0d62b46aad71f84a4375480ab-4ee9966cb57c1de89f9ca191f8b507e46e3d302c.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I0c485e8174a6ef4c0f564d626fb0ef209a29b280
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168491
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405052}
CrOS Settings: Revise reset page imports in lazy_load.js
Subpages should only be imported in lazy_load.js. Additionally,
components used within subpages should be imported in the components
they are used in.
Bug: b:263414034
Test: browser_tests
Change-Id: I9889fbafae19af794c359ed5f9c5bba1c9909046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164289
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Wes Okuhara <wesokuhara@google.com>
Cr-Commit-Position: refs/heads/main@{#1405051}
Roll llvm-libc from 9ee890194fe9 to cf32ae379c89 (1 revision)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/9ee890194fe9..cf32ae379c89
2025-01-10 nickdesaulniers@users.noreply.github.com [libc][docs] update docs on how to build linux kernel headers from src (#122381)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/llvm-libc-chromium
Please CC aeubanks@google.com,lexan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: aeubanks@google.com
Change-Id: I4dbcfb92919786fd122a7371a9ced0d2873157b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168250
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405050}
Roll ios_internal from fa89054d3037 to 5d2fd8e76328
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/fa89054d3037..5d2fd8e76328
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,justincohen@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I7221f122ac1b0c5405d1cbd2a0aa8cda4e1508ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168249
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405049}
Set default of GlicLauncherEnabled to true
This will make testing easier. Will be updated back to false when FRE
is implemented.
Bug: 379163913, 379166397
Change-Id: I369377d6baabdb15aaa63edac8e1c13e7db4b893
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6167948
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405048}
Remove StringPrintfNonConstexpr().
No longer used.
Bug: none
Change-Id: I850646befd88791afcb111ac68c3830b4813d454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6149778
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405047}
Roll src-internal from 7cf9e93279ad to 3ce4702c33df (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7cf9e93279ad..3ce4702c33df
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC agale@google.com,chrome-browser-infra-team,ydago@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:381903275,chromium:388299761
Tbr: agale@google.com,ydago@google.com
Change-Id: I8a85bf71d1426321bd81d5496d86a53df9a62207
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6167920
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405046}
Add DozeModePowerScheduler to field trial testing config
BUG=383393328
Change-Id: If14f319e98ad5bd2ea59a4f631f36fa0062033af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165763
Reviewed-by: Alexandre Marciano Gimenez <raging@google.com>
Commit-Queue: Yichen Zhou <yichenz@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405045}
CrOS Settings: Remove miscellaneous component imports in lazy_load.js
Subpages should only be imported in lazy_load.js. Additionally,
components used within subpages should be imported in the components
they are used in.
Bug: b:263414034
Test: browser_tests
Change-Id: I26df2d8b455f6558cd8f036c22aff289bc8b9432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166225
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Wes Okuhara <wesokuhara@google.com>
Cr-Commit-Position: refs/heads/main@{#1405044}
Extend Network.Cellular and Network.Ash.Cellular histograms.
Fixed: 388023421, 388023086, 388023776, 388023836
Change-Id: I57bfa890cd000520dd79b094acb899f8b36ff4d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6166185
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Jason Zhang <jiajunz@google.com>
Cr-Commit-Position: refs/heads/main@{#1405043}
Move some customizable select tests
These customizable select tests belong in the customizable-select
subdirectory of the-select-element, so this patch moves them there.
Change-Id: Ic5c8257a601d35f77d5ed09d97466878764d466b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6093890
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Traian Captan <tcaptan@chromium.org>
Commit-Queue: Traian Captan <tcaptan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405042}
Roll Skia from dba7f46122ba to 1398cbd6b7f9 (1 revision)
https://skia.googlesource.com/skia.git/+log/dba7f46122ba..1398cbd6b7f9
2025-01-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e264c58f9b0f to 199e36d15635 (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jmbetancourt@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jmbetancourt@google.com
Change-Id: If1e4dd05c51287b75a50d63062e9301ccebba51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168067
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405041}
Add metric for tracking overview based usage of screenshot shortcuts
Adds a metric for the source of overview based shortcuts of screenshot
actions. Differentiates based on ChromeOS keyboard with or without
screenshot key and non-ChromeOS keyboards.
Fixed: 388925350
Change-Id: Ia376ac069697d4d9d1bfb7debb656f3cea793b5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165348
Commit-Queue: David Padlipsky <dpad@google.com>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405040}
[Braille IME] Add flag to switch to extension v3 manifest
Adds flag `--enable-features=AccessibilityManifestV3BrailleIme`
to use a v3 manifest file for this extension.
Bug: 384675323
Change-Id: Ia464f3133647aafb5c42c846240d57af3bd922b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6161597
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Valerie Young <spectranaut@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1405039}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1736536964-b3a0f12deb64768a9d4899a8d64187f76ad8f791-a13362112800f8ead3dddc21d92f48a75babc520.profdata to chrome-android64-main-1736542176-d4f600c4f7f896af9221c5f0c2973cf23e4a9e49-ede332eecec44578a89e5e85b5a4af6fe4bd71b2.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia3e3504a6b1bd508581b1f0352f4062a124c6d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168486
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405038}
[Compare] Implement add tab to comparison table submenu
This patch implements the "Add tab to comparison table" submenu, which
displays a list of a user's existing comparison tables to add the
current tab to. This patch also modifies the product specifications page
action controller to support getting the URL for the most recent
comparison table the page was added to, since the confirmation toast may
now be shown even if the page was not added to the recommended set for
the product group.
http://go/scrcast/Njc0ODMyMjYwNDc3NzQ3Mnw5MzA5YzRiNi0wNA
Bug: 377939909
Change-Id: Ib3f4a5f66cc056e4b09ed6bd7915987c4ca76186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6094825
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Chase Hartsell <chazzy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405037}
Roll Perfetto from 0893e2af69caf8592f6e38f34ccdd4ad6615de9d to e324242074e2 (3 revisions)
Cannot build log URL because revision "0893e2af69caf8592f6e38f34ccdd4ad6615de9d" is invalid: Failed to retrieve revision.
2025-01-10 lalitm@google.com Reland "tp: speed up query by 10x on large trace by removing window function"
2025-01-10 stevegolton@google.com Merge "Revert "ui: Store track selection synchronously without waiting for details"" into main
2025-01-10 lalitm@google.com Merge "Revert "tp: speed up query by 10x on large trace by removing window function"" into main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC oksamyt@google.com,perfetto-bugs@google.com,primiano@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: oksamyt@google.com,perfetto-bugs@google.com
Change-Id: Id60574dd14e225247cd287f7a5f229d4d79f0432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168049
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405036}
Reland "Skip showing ContentAnalysisDialog on non-browser window web contents"
This is a reland of commit 3c755ed17fe637ac00ec7277a04190bdb24ace86
The memory leak was caused by `TestWebDialogDelegate` never being
deleted. This is fixed by calling its `SetDeleteOnClosedAndObserve`
method.
Original change's description:
> Skip showing ContentAnalysisDialog on non-browser window web contents
>
> This CL fixes the crashes by properly handling web contents that don't
> have a `WebContentsModalDialogManager` attached to them.
>
> Bug: 374120523, 388049470
> Change-Id: I1a1dce6eaf475c2de70223a8fd6d457b73301a49
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6158104
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1404728}
Bug: 374120523, 388049470
Change-Id: Ia99106099922dfe548910b153f4c9b98daa58f74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6163913
Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405035}
Spanification: Fix CompositorFrameReporter
Required multiple replacements of C-style arrays with std::array in
CompositorFrameReporter. Also fixed STATIC_HISTOGRAM_POINTER_GROUP
due to its use in CompositorFrameReporter.
Bug: 351564777
Change-Id: I6ef93ddc97c8fb38f396811b1236bd8658fcb9e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114862
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Sam Fortiner <samfort@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1405034}
Remove reference to LACROS bug that's been closed.
Disable flaky metrics browser_tests
Bug: 385580803,385392162,384792246,382573509,376032466
Change-Id: I8612864ccfdedf9254bbc7109b271becf47fe599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165657
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Michal Mocny <mmocny@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405033}
Roll FuzzTest from 032f0bdd8c0a to c99c121225fc (1 revision)
https://chromium.googlesource.com/external/github.com/google/fuzztest.git/+log/032f0bdd8c0a..c99c121225fc
2025-01-10 xinhaoyuan@google.com Update the Bazel quickstart to use `MODULE.bazel` instead of `WORKSPACE`.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuzztest-chromium
Please CC chrome-fuzzing-core@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-centipede-asan-rel;luci.chromium.try:linux-libfuzzer-asan-rel;luci.chromium.try:win-libfuzzer-asan-rel
Bug: None
Tbr: chrome-fuzzing-core@google.com
Change-Id: Ia4168815e2198de30e283b5e9553098bcd89008e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168016
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405032}
Pass ImageModel to ImageView::SetImage() in ash/system/phonehub
The ImageSkia version of ImageView::SetImage() is deprecated.
There's no intended behavior changes with this patch.
This CL was uploaded by git cl split.
R=dhnishi@chromium.org
Bug: 40137576
Change-Id: I8d6824f4d3da61a5ca78bedcb31f7bba0cbed04c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164429
Reviewed-by: Crisrael Lucero <crisrael@google.com>
Commit-Queue: Crisrael Lucero <crisrael@google.com>
Auto-Submit: SangWoo Ko <sangwoo108@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405031}
Set SiteForCookies in CheckClientDownloadRequestBase::SendRequest
ResourceRequest.site_for_cookies defaults to an empty SiteForCookies.
When UCC launches, when users opt to restrict 3P cookies a request
with an empty SFC will have its cookies blocked by 3PC blocking.
This CL sets the SiteForCookies to the site of the request URL. This
will send cookies when 3PC blocking is enabled. It will also send
SameSite cookies.
If this request is meant to be cross-site or we do not want to send
cookies in this context, the change should be ignored.
Bug: 324879760
Change-Id: Icdf39136dff8394a474306220457ee1324ac98a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164104
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405030}
Use vector icon for Glic status icon
Will hold off on integrating this into StatusTray::CreateStatusIcon
until we have time to explore how to solve this on Mac/Win
Bug: 388817604
Change-Id: I2622d53506d1dc2297a6729e2440f7e34521ab4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165046
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Reviewed-by: Andrea Gomez <andreaxg@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405029}
Remove a use of StringPrintfNonConstexpr().
This is discouraged due to unsafety.
This is a behavior change: bools values will now be stringified as
"true"/"false" instead of "1"/"0". Given that this is documented as used
for logging and thus intended to be human-readable, this seems like an
improvement.
Bug: none
Change-Id: I78fb4820279477b6d69184cab3fd329eafba0f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6141637
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405028}
[headless] Honor `window.resizeTo()`
Replace the default no-op `//content` implementation with the code
backing the `Browser.setWindowBounds` DevTools method, which is
respected.
Bug: None
Change-Id: Ibe9ea1ade27457d8059385d19323c59f5713ced6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164470
Reviewed-by: Peter Kvitek <kvitekp@chromium.org>
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1405027}
Reland "[SharedTabGroups] Add leave group button in editor bubble"
This reverts commit 78eabe322c764c6f1e25f2035bdd9b10876915c4.
Reason for revert: Fixed test failures by adding an additional check
in IsOwnerOfSharedGroup to verify the user is signed in. Also updates
tests to specify if they need the user to be signed in or not for
each test.
Original change's description:
> Revert "[SharedTabGroups] Add leave group button in editor bubble"
>
> This reverts commit 015b6a804b69e6737449a9d39a2474abdc0236ca.
>
> Reason for revert: Breaks interactive_ui_tests on various platforms,
> specifically SharedTabGroupInteractiveUiTest.RecordMetricWhenManagedGroupPressed
>
> See example failures:
> https://ci.chromium.org/ui/p/chrome/builders/ci/win-arm64-rel-ready/49513/test-results?sortby=&groupby=
> https://ci.chromium.org/ui/p/chrome/builders/ci/linux64-rel-ready/40652/overview
>
> Original change's description:
> > [SharedTabGroups] Add leave group button in editor bubble
> >
> > Adds the Leave Group button to the TabGroupEditorBubbleView which allows
> > members of a shared tab group to leave a group without deleting the
> > group for other users.
> >
> > This button replaces the Delete Group button, meaning members are now no
> > longer allowed to delete a shared tab group for all users unless they
> > are the owner of the group.
> >
> > When the Leave Group button is pressed an interstitial dialog is
> > displayed asking the user to confirm their decision to leave the
> > group.
> >
> > Adds a test that verifies the Leave Group button is displayed for
> > members and that confirming the deletion of the group removes it from
> > the tabstrip if it is open.
> >
> > but the majority of the code is held within a callback which is not
> > being reported for some reason.
> >
> > Low-Coverage-Reason: COVERAGE_UNDERREPORTED A test is added in this CL
> > Change-Id: I40a829bbb50deef9cf197c4d0e80a5ea227e5bc8
> > Bug: 380515575
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098819
> > Reviewed-by: David Pennington <dpenning@chromium.org>
> > Commit-Queue: Darryl James <dljames@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1403845}
>
> Bug: 380515575
> Change-Id: I54c419d1fa2369f04ee1a6c64b3dfe42c1d94409
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6161334
> Auto-Submit: Rebekah Potter <rbpotter@chromium.org>
> Commit-Queue: Darryl James <dljames@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Owners-Override: Rebekah Potter <rbpotter@google.com>
> Reviewed-by: Darryl James <dljames@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1403931}
Bug: 380515575, 388614630
Change-Id: Ic253ec1724a3ad5aa1caf44f73fda6cd7afd8228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164073
Commit-Queue: Darryl James <dljames@chromium.org>
Reviewed-by: David Pennington <dpenning@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405026}
Data sharing: update clearcut with metricsReportEnabled flag
Clearcut is the logging framework for DataSharing SDK. The CL
enable/disable it with the metricsReportEnabled flag in Chrome
Bug: 388559949
Change-Id: I54ae904ded496bb49fd4129a8875901fbde497b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6159147
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405025}
Roll Perfetto Trace Processor Linux from 1799f295a91e to 0893e2af69ca
https://android.googlesource.com/platform/external/perfetto.git/+log/1799f295a91e..0893e2af69ca
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I988f4e795862d336beb3c724631e46409479f9c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6167989
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405024}
Reland "[Ads CCT Notice] Launch the control surveys"
Tests were failing for `android-arm-tests` that was resolved with https://chromium-review.googlesource.com/c/chromium/src/+/6164117.
Note that this CL is the exact same change submitted prior to the revert.
UTR run results: https://ci.chromium.org/ui/inv/u-alvingo-2025-01-10-21-51-00-81da17623ac07f31/test-results?sortby=&groupby=
UTR command ran:
```
vpython3 tools/utr -p chrome -B ci -b android-arm-tests -t "chrome_public_test_apk on Android device Pixel 4" compile-and-test -- --gtest_filter=org.chromium.chrome.browser.privacy_sandbox.PrivacySandboxSurveyControllerIntegrationTest*
```
This is a reland of commit 7a69db2f55d7472bf5648f1a6158366c01b917f8
Original change's description:
> [Ads CCT Notice] Launch the control surveys
>
> Bug: 379930582
> Change-Id: I04384ead2e842a6e0197520ea29d96fb77293031
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6149813
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
> Reviewed-by: Abe Boujane <boujane@google.com>
> Reviewed-by: Jacob Stanley <jacobstanley@google.com>
> Reviewed-by: Kevin Graney <kmg@google.com>
> Commit-Queue: Alvin Lam <alvingo@google.com>
> Cr-Commit-Position: refs/heads/main@{#1404269}
Bug: 379930582
Fixed: 389017452
Change-Id: I623f36864c14a9973168cf7575736fc4c84344de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164813
Auto-Submit: Alvin Lam <alvingo@google.com>
Commit-Queue: Alvin Lam <alvingo@google.com>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1405023}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1736531933-6709b71c5ca7f5d7d4cb8ad775a7cd6c6d680236-ffa032aa746954106635699e59f2cf3b356a49fe.profdata to chrome-mac-arm-main-1736539187-cf0408e8384cfe780b58ec5f3957803abdca93b9-0c8740fe00e049887087558ff326da6621865054.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie43535c8e05a67434b95469f45e34fb6bdb70b9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168074
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1405022}