Chromium Main Console

testing/buildbot: Add fake Win ANGLE try bots.

These bots will be used to trigger tests on the ANGLE CQ.
Mirrors the design used in the existing files and in
http://crrev.com/c/1326157 .

Only tackles Windows for now. Will be extended to other platforms.

Also adds a few NVIDIA dEQP tests and cleans up some ANGLE test naming.

Bug: 822310
Change-Id: I5638bdc8588bdf3a4716fd45380ad25cc35ee121
Reviewed-on: https://chromium-review.googlesource.com/c/1333995
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607911}

Roll src-internal 357df2f5f824..890400d12a0a (3 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/357df2f5f824..890400d12a0a


Created with:
gclient setdep -r src-internal@890400d12a0a

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ib4bf25554f57a769ee8351475619b229e98b7394
Reviewed-on: https://chromium-review.googlesource.com/c/1335092
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607910}

[clang-tidy] Fix use-after-move typo for BrowsingHistoryService

Bug: <none>
Change-Id: Ic73229f3d4c4137f84194fe3db7287308f37fa2d
Reviewed-on: https://chromium-review.googlesource.com/c/1329675
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607909}

Only add new crostini shared path to prefs if it does not already exist.

Bug: 878324
Change-Id: I2d738bb3f980d200b946f0b6cf7522b830f4d5ac
Reviewed-on: https://chromium-review.googlesource.com/c/1334669
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607908}

Use uncanonicalized StartOfWordPosition() in visible selection start adjuster

This patch hoists the creation of VisiblePosition from StartOfWord
to its caller ComputeStartRespectingGranularityAlgorithm to reduce
the usage of VisiblePosition.

Bug: 657237
Change-Id: If1489b363717d751f6e0d8ebc323f6e80045c8af
Reviewed-on: https://chromium-review.googlesource.com/c/1330760
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607907}

layout tests: Fix some flakes with --enable-display-compositor-pixel-dump

A number of layout tests requests a testRunner.capturePixelsAsyncThen().
When not using the display-compositor for pixel-dumps, this triggers a
complete composition (i.e. this triggers a commit, raster, frame
submission, and processing in the display compositor). The tests that
use the testRunner.capturePixelsAsyncThen(callback) API expects these
steps to be completed before the callback is run. However, when using the
display-compositor for pixel-dumps, it immediately triggers the callback
without doing any of these steps. This caused a bunch of tests to fail,
or become flaky, when --enable-display-compositor-pixel-dump became the
default.

This patch fixes the flakiness, by making sure the callback is run only
after all the required steps have been performed. This is done by forcing
a redraw, and requesting a presentation-timestamp from viz. This does not
actually fix the readback itself, i.e. the pixels returned to the
callback is still invalid. However, this does fix the timing of running
the callback. That is sufficient to fix a number of the existing flaky
tests.

Bug: 891427
Change-Id: Ic09db1c3a0a410b2d5687999d7144260df7ea272
Reviewed-on: https://chromium-review.googlesource.com/c/1322364
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607906}

[ChromeDriver] Disable a test causing flakiness on Mac

Disable test case ChromeDriverSiteIsolation.testCanClickOOPIF on Mac.
It appears to occasionally put the test HTTP server into a bad state,
causing large number of failures in subsequent test cases.

TBR=crouleau@chromium.org

Bug: 904061
Change-Id: I230b445dd701a1c894fb65a51a60933ab586bc23
Reviewed-on: https://chromium-review.googlesource.com/c/1335271
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607905}

Sort build rules in chrome/browser/BUILD.gn.

Keep the enable_foo conditionals in alphabetical order.

Change-Id: I63712cae90f46901602d480311c3ef565e8e6ca1
Reviewed-on: https://chromium-review.googlesource.com/c/1330904
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607904}

Set joelhockey as OWNER for crostini_share_path*

Change-Id: I42a6b49cc52dfc2a085c1b6ffad6b72ab6e34a11
Reviewed-on: https://chromium-review.googlesource.com/c/1335053
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607903}

[DevTools] Guard DOM.setFileInputFiles under MayAffectLocalFiles

Bug: 805557
Change-Id: Ib6f37ec6e1d091ee54621cc0c5c44f1a6beab10f
Reviewed-on: https://chromium-review.googlesource.com/c/1334847
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607902}

Fix background image painting of very small images

The background image fast path painting rounds the image src rect
to integer sizes assuming sprite maps and/or reasonably large images.
When a very small image is used scaled up to a large size (such as
constant color images scaled up to form progress bars by animating
background size) the src rect may be 1 x [small number] which gets
rounded to zero size.

This patch changes the code to detect this situation and not round
in such cases.

It's worth recording that an alternate approach is to detect when
the rounding results in a significant change in src rect and always
switch to unrounded in that case. But it would be more expensive for
a relatively uncommon case.

R=fmalita
BUG=904042

Change-Id: I24657a5d087c0dda0fd8a5e3c3d08e1e4eb02473
Reviewed-on: https://chromium-review.googlesource.com/c/1334291
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607901}

Settings WebUI: password-export-dialog, fire close when closing dialogs

Bug: 903212
Change-Id: I2963b22bb55a0a3459331303887c6697e973489d
Reviewed-on: https://chromium-review.googlesource.com/c/1334830
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607900}

Expose default state for submit buttons in HTML

Bug: 904428
Change-Id: I944fe959a6eb8ac00a4226e879a22a09a22a40c2
Reviewed-on: https://chromium-review.googlesource.com/c/1331144
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607899}

Re-enable performance_browser_tests on all platforms.

Fixes were made to restore the functioning of the tests in commit
c9cee7e5db8b778279bf39c3a249ab1140616b83.

Bug: 789192
Change-Id: I3ec2b8a2dd3a04f24dbcc3998ca3f7f138cc281f
Reviewed-on: https://chromium-review.googlesource.com/c/1334852
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#607898}

Updating trunk VERSION from 3610.0 to 3611.0

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I39ef32ef3bbd394f306b2a1408ecb5eb9fb4bc67
Reviewed-on: https://chromium-review.googlesource.com/c/1335347
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607897}

Print Preview Refresh: Enable change button while destination loads

In some cases (e.g. kiosk apps with no default printer configured), the
print destination may never load. Enable the "Change" button while
destination capabilities are loading so that the user can switch
destinations in this case.

Bug: 901115
Change-Id: I53eec9332e0d7f075e461226290d408ae6d6ef49
Reviewed-on: https://chromium-review.googlesource.com/c/1332703
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607896}

Roll src/third_party/skia 6c242459120d..1e00aebd9a45 (7 commits)

https://skia.googlesource.com/skia.git/+log/6c242459120d..1e00aebd9a45


git log 6c242459120d..1e00aebd9a45 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 caryclark@skia.org fix pathops fuzz
2018-11-13 reed@google.com cubicmap should pin its input -- I guess
2018-11-13 reed@google.com change SkTextEncoding to enum class
2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b3c4d88a647a..02ce5830e7db (1 commits)
2018-11-13 brianosman@google.com Move new WriteVertexData utility to a GrVertexWriter helper struct
2018-11-13 mtklein@google.com refactor SkBitmapProcState_opts_SSSE3
2018-11-13 csmartdalton@google.com sksl: Support fwidth()


Created with:
gclient setdep -r src/third_party/skia@1e00aebd9a45

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@chromium.org

Change-Id: Ie7495c6edc214e5237d0c7f8fc72ed4f587039e8
Reviewed-on: https://chromium-review.googlesource.com/c/1335088
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607895}

[service-manager] Migrate things to ServiceFilter

With the exception of Service Manager internals, which will be migrated
in a follow-up CL, this makes the following changes across the tree:

- Any valid use of Identity is updated to use complete Identity values
with no fields absent. This is for stuff like manual service instance
registration, or using concrete Identity values from the Service
Manager.

- All other uses of Identity are switched to ServiceFilter.

Bug: 902590
Change-Id: I112d501e04ec22461635654ebd3f597bb2bbf396
Reviewed-on: https://chromium-review.googlesource.com/c/1331869
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#607894}

Roll src/third_party/pdfium f28410e9eb26..d20b521f5864 (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/f28410e9eb26..d20b521f5864


git log f28410e9eb26..d20b521f5864 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 thestig@chromium.org Roll v8/ a4f6a37da..d5f263024 (409 commits)


Created with:
gclient setdep -r src/third_party/pdfium@d20b521f5864

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I954f1dba59ca3d766cedead3309cd6a672d7b8e8
Reviewed-on: https://chromium-review.googlesource.com/c/1335091
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607893}

Worklet: Modernize service worker interception tests for worklets using async/await

This is just a cleanup CL, and there're no functional changes.

Bug: n/a
Change-Id: I60820045469eed4a0903b37af9e4f8927bcc884d
Reviewed-on: https://chromium-review.googlesource.com/c/1335047
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607892}

Update WebGL2 conformance expectations

Remove following suppressions for Intel:
deqp/functional/gles3/framebufferblit/conversion_07.html

BUG=598902

Change-Id: Ia1be2d893438d43a571838eff571427093bef145
Reviewed-on: https://chromium-review.googlesource.com/c/1317349
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Lin Sun <lin.sun@intel.com>
Cr-Commit-Position: refs/heads/master@{#607891}

MojoVideoDecoder: Add histogram to track initialization and error.

The autotest video_ChromeHWDecodeUsed verifies Chrome used the HW
decoding when playing a video stream by checking the histogram value,
which is reported from GpuVideoDecoder.
In order to keep the test pass during switching from GpuVideoDecoder
to MojoVideoDecoder, we have to report the same histogram value
temporarily from MojoVideoDecoder.

With this CL, we can enable MojoVideoDecoder at ChromeOS platform.

BUG=chromium:902968
TEST=Pass video_ChromeHWDecodeUsed autotest on Eve
TEST=Play video at Youtube on Eve and confirm the successfull option
of Media.GpuVideoDecoderInitializeStatus are increased.

Change-Id: I26fc53704843e9b153bbee304e8f60ab3a7b0417
Reviewed-on: https://chromium-review.googlesource.com/c/1328634
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607890}

Roll Fuchsia SDK from cb9dddc4477a to 95394b4e05ae


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I2a01274b3caf78d0d714aab391783b554bc4a16e
Reviewed-on: https://chromium-review.googlesource.com/c/1335090
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607889}

Roll src-internal def2885f901d..357df2f5f824 (2 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/def2885f901d..357df2f5f824


Created with:
gclient setdep -r src-internal@357df2f5f824

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I8ce36da709dc52d9193694e75671578cffb1ea1e
Reviewed-on: https://chromium-review.googlesource.com/c/1335087
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607888}

Implement base::bits functions for MSVC 32-bit targets

Currently, base::bits::Count{Leading,Trailing}ZeroBits fail to link
when used with 64-bit inputs on 32-bit MSVC builds because MSVC only
implements the _BitScan{Forward,Reverse}64 intrinsics for 64-bit
builds. Fix this by implementing equivalent support using 32-bit
intrinsics.

Change-Id: I9b9095abd03587c29dd642df65cf9783bd9b202d
Reviewed-on: https://chromium-review.googlesource.com/c/1321253
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607887}

Provide app session id to CAOS

Creates a mapping between the audio group ids and the application
session id. When the CAOS is created, it uses the group id in the audio
params to look up the session id and uses that to retrieve the proper
MultiroomInfo.

Bug: b/111669896
Test: Cast to a MZ group, cast_media_unittests, cast_base_unittests, cast_shell_unittests
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6979bbb2bfc118e4d135bfd354ce1ad956503182
Reviewed-on: https://chromium-review.googlesource.com/c/1221067
Commit-Queue: Aidan Wolter <awolter@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607886}

Update WebGL conformance expectations

Remove following suppressions for Intel on Linux:

conformance/renderbuffers/depth-renderbuffer-initialization.html
conformance/renderbuffers/stencil-renderbuffer-initialization.html

BUG=794339

Change-Id: Ibf3cd5a96a22b7318730fb981dbbe7ce063f4f2e
Reviewed-on: https://chromium-review.googlesource.com/c/1309429
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Lin Sun <lin.sun@intel.com>
Cr-Commit-Position: refs/heads/master@{#607885}

Disable two system health smoke tests.

Tbr: crouleau@chromium.org,nednguyen@google.com,perezju@chromium.org
Bug: 903849
Change-Id: I2821fc28f5c63a036d563a6350db4659c4fb5440
Reviewed-on: https://chromium-review.googlesource.com/c/1334831
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607884}

Fix browser with print dialog animation issue

Background:
When dragging home launcher down to show a window, the window will be
shown on drag start and will slide down on drag update. However, this
does not work for window with modal dialog because the dialog's
visibility change cancels the touches for all other windows.

Changes:
Avoid cancel touches on windows that are not in the same transient
window tree of the modal dialog.

Bug: 900321
Change-Id: I2047224de2f6fac9e892376477b7bf9c938cc2c0
Reviewed-on: https://chromium-review.googlesource.com/c/1316434
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607883}

Revert "Variations service now checks explicitely if previous attempt was HTTP."

This reverts commit 91d246885ead6155c131e027d99be1aa79b9ae3c.

Reason for revert: This CL made ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange flaky (crbug.com/904108) reverting while investigating why.

Original change's description:
> Variations service now checks explicitely if previous attempt was HTTP.
>
> Variations service now sets a flag if the last request was an HTTP
> retry, and uses it to decide whether to retry again, instead of
> relying on the scheme of the final URL. Also, retries are now disabled
> if the fallback url is HTTPS.
>
> Bug: 902727
> Change-Id: Ibd6df4a22bc6302b231aff0ae32f8e1c8a1f277c
> Reviewed-on: https://chromium-review.googlesource.com/c/1325035
> Commit-Queue: Carlos IL <carlosil@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607022}

TBR=asvitkine@chromium.org,carlosil@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 902727
Change-Id: I67036ea20097f889e71de5179a2e4510a201388d
Reviewed-on: https://chromium-review.googlesource.com/c/1334421
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607882}

[Autofill] Added browser tests for local card migration dialog.

Relanding browser tests for local migration flow. Commented out flaky tests that were causing issues earlier.

Bug: 897998
Change-Id: I7dd0fdb5f71587bddc236732c6d3725dc6411818
Reviewed-on: https://chromium-review.googlesource.com/c/1332704
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#607881}

[On-device adaptive brightness] Global curve can be configured by experiment.

If experiment param is valid, a global curve will be constructed from it.
Otherwise a default value will be used.

Bug: 881215
Change-Id: I0986a145bc943d190fbc9609630e9d21ef5d57e7
Reviewed-on: https://chromium-review.googlesource.com/c/1333097
Commit-Queue: Jia Meng <jiameng@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607880}

[ModalDialog] Add icon support on title for modal dialog

Bug: 903858
Change-Id: Ie4e05d6d19fb03c08e9dc1f1e2b0d6108f33eaaf
Reviewed-on: https://chromium-review.googlesource.com/c/1333782
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607879}

[CrOS Tether] Add chromeos switch for ignoring wired connections

This adds a chromeos switch to allow tether host scans to occur in
spite of ethernet connections. This is a followup to CL 1332693.

-----

TESTING:

I confirmed manually that turning off the switch prevented a host scan
when ethernet is plugged in while turning it on allowed the 'tether
host found' notification.


Bug: 904609
Change-Id: If0938796841228415c72fb6ccc9b0a52c3d64786
Reviewed-on: https://chromium-review.googlesource.com/c/1334206
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607878}

Should clamp the scrolloffset during scroll animation.

Currently, once we decide to animate a scroll to an offset, we update
the scroll a little bit each frame until it reaches the specified
offset.

However, during the animation, the scroller's maximum scroll offset
might become smaller than the specified offset. For example, on an
android device, a user wants to find a string in a page. After tapping
the 'search' icon on the virtual keyboard, the smooth scroll is
initialized but the window's size becomes larger as the virtual
keyboard disappears. In such cases, if we still decide to animate to
the originally specified offset, the page won't be rendered correctly.
We should always clamp the scroll offset during the animation.

Bug: 902905
Change-Id: I3a3117be0aff40bc012206d741f5142d12de2a7b
Reviewed-on: https://chromium-review.googlesource.com/c/1329542
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607877}

cc: Invalidate for needs_prepare_tiles

Problem is when CanDraw is false but needs_prepare_tiles is true
Scheduler will keep requesting begin frames but do nothing in a
begin frame since invalidate is blocked on CanDraw.

We already have an efficient shortcut that does not involve actually
producing a frame if invalidate is only requested for
needs_prepare_tiles. So the simple fix is simply allow invalidates for
this case.

Bug: 900557
Change-Id: Ib3c3e213e2e2461d7aa1b8dd8d2e91ab64042feb
Reviewed-on: https://chromium-review.googlesource.com/c/1334550
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607876}

Allow SharedArrayBuffer with FlexibleArrayBufferView.

Assertions fail when running multithreaded WebAssembly code which uses
WebGL.

Bug: 905000
Change-Id: Ic45df5f43aa859a5f9225586f4836919ef31b54a
Reviewed-on: https://chromium-review.googlesource.com/c/1334844
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607875}

Remove old *_scroll_200_layer_grid rendering stories.

These stories are superceded by newer stories such as
infinite_scroll_root_n_layers_99 and css_opacity_plus_n_layers_99.

Now that we have had overlapping data from the new stories for some
time, the old stories can be removed.

BUG=878951

Change-Id: Idb146ed7d9f5420bac1d5217e86c6547a772efe5
Reviewed-on: https://chromium-review.googlesource.com/c/1334929
Commit-Queue: Victor Miura <vmiura@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607874}

Roll src/third_party/pdfium f768692bdef0..f28410e9eb26 (16 commits)

https://pdfium.googlesource.com/pdfium.git/+log/f768692bdef0..f28410e9eb26


git log f768692bdef0..f28410e9eb26 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 tsepez@chromium.org Use {{include}} directive in more tests.
2018-11-14 tsepez@chromium.org Introduce {{include}} directive for PDF file fixup.
2018-11-14 tsepez@chromium.org Add CPDF_IndirectObjectHolder::New<T>()
2018-11-13 thestig@chromium.org Add more tests for transfer function creation and usage.
2018-11-12 tsepez@chromium.org Test pushbutton specific field properties.
2018-11-10 thestig@chromium.org Roll tools/clang/ 3041f30dd..31f2d265b (4 commits)
2018-11-10 thestig@chromium.org Roll build/ a09219387..81ffd0040 (178 commits)
2018-11-10 thestig@chromium.org Roll buildtools/ 2dff9c9c7..fdce2ad26 (2 commits)
2018-11-10 thestig@chromium.org Roll DEPS for catapult to 5d509166
2018-11-10 thestig@chromium.org Roll third_party/googletest/src/ d52663267..2e68926a9 (68 commits)
2018-11-10 thestig@chromium.org Roll third_party/instrumented_libraries/ 323cf3219..a959e4f0c (4 commits)
2018-11-10 thestig@chromium.org Roll third_party/zlib/ dcf1d0f8c..dde5ce526 (6 commits)
2018-11-10 thestig@chromium.org Roll third_party/depot_tools/ 71e3be7a5..ddbeac1c0 (78 commits; 12 trivial rolls)
2018-11-10 thestig@chromium.org Roll third_party/icu/ c56c67199..45f655f2f (11 commits)
2018-11-10 thestig@chromium.org Roll third_party/skia/ fa7df23d8..36b85be49 (158 commits; 11 trivial rolls)
2018-11-10 thestig@chromium.org Roll third_party/freetype/src/ f56830ed4..fb0d66d04 (20 commits)


Created with:
gclient setdep -r src/third_party/pdfium@f28410e9eb26

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I532bd42f0153e67d50628395705ccd33a1350831
Reviewed-on: https://chromium-review.googlesource.com/c/1334572
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607873}

[heap] Fix GC forbidden scopes for mixin construction

Mixin construction relies on the fact that no garbage collection can be
triggered.

When moving to the new MakeGarbageCollected bottleneck the hook for
mixin construction was dropped. This restores previous behavior.

In a followup GarabgeCollectedMixin::operator new() should be inlined in
the construct trait, creating the invariant that all operator new()
methods are deleted for Oilpan.

Bug: 904546, 757708
Change-Id: I47e672f1cb3035d8a4bea72d90bfceb2a31c5d89
Reviewed-on: https://chromium-review.googlesource.com/c/1333761
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607872}

Revise Assistant strings for Related Info.

Per request, modifying Assistant strings for Related Info. These
strings occur in Chrome Settings and Assistant OOBE.

See bug for screenshots.

Bug: b:119503388
Change-Id: I9219c59dceac4207061e978efe68633f89d7034b
Reviewed-on: https://chromium-review.googlesource.com/c/1334279
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#607871}

Sort flag descriptions.

Move some out of place flag descriptions to the right sections.

Change-Id: I61569c122d8b5c93adcad002661a13fc33dcd14a
Reviewed-on: https://chromium-review.googlesource.com/c/1330893
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607870}

Reland: Disable Android IMEs according to given ImeInfo.

The original CL is crrev.com/c/1331294 and it was reverted due to
MSan failure. The failure should be fixed by adding initialization for
|is_removing_imm_entry_|.

Android IMEs can be disabled in Android side by using 'ime' command.
This CL ensures that disabled IMEs are also disabled in Chrome OS's
InputMethodManager.

Bug: b/119274469
Change-Id: I4f9067cabf96fcb28d594a72856df1e34d469114
Reviewed-on: https://chromium-review.googlesource.com/c/1334672
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607869}

cc: Make sure a CompletionEvent is always signaled.

It looks like there is a CompletionEvent that is never getting signaled
from the compositor thread, and the main-thread stays blocked on it.
This causes a fair number of hangs in the renderers (~30% of all hangs
or crashes in cc/ code in stable channel on Windows). Try using a
ScopedCompletionEvent to make sure all CompletionEvents are always
signaled, and see if that helps.

BUG=622080

Change-Id: Ic25089f0e4f671182b18c1b44e278196eeb040c2
Reviewed-on: https://chromium-review.googlesource.com/c/1332726
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607868}

Roll src/third_party/catapult 6d64a5e5e40b..6ce627d2b73d (1 commits)

https://chromium.googlesource.com/catapult.git/+log/6d64a5e5e40b..6ce627d2b73d


git log 6d64a5e5e40b..6ce627d2b73d --date=short --no-merges --format='%ad %ae %s'
2018-11-13 benjhayden@chromium.org Add place-holder for v2spa.


Created with:
gclient setdep -r src/third_party/catapult@6ce627d2b73d

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib7d97fbe1d8d8c99104429375797b359ca00350d
Reviewed-on: https://chromium-review.googlesource.com/c/1334587
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607867}

Follow up on histograms added in CL:1313550

This CL updates the histogram metadata.

Bug: 890502
Change-Id: I20fa1f69a3b7fc720fc314d2be98bff6fd175415
Reviewed-on: https://chromium-review.googlesource.com/c/1333781
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607866}

Update V8 to version 7.2.320.

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9d32daac..dd90e943

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iaa8537cab02e312ed8ee99a20c6bc64ed446c2b3
Reviewed-on: https://chromium-review.googlesource.com/c/1334562
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607865}

cros: Fix long emails messing up Remove User button placement

The email label now uses the same layout rule as the user name label, which
fixes the same bug, but for long emails rather than long user names.

Bug: 902362
Change-Id: Icfde3129078ffd6a5977b388210bf2773e0ee405
Reviewed-on: https://chromium-review.googlesource.com/c/1334827
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607864}

Roll src/third_party/skia 9d958b54af30..6c242459120d (5 commits)

https://skia.googlesource.com/skia.git/+log/9d958b54af30..6c242459120d


git log 9d958b54af30..6c242459120d --date=short --no-merges --format='%ad %ae %s'
2018-11-13 brianosman@google.com Remove SK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS from Skia's Chromium GN
2018-11-13 scroggo@google.com Remove unused SkPath::unique()
2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6ed398b46847..b3c4d88a647a (1 commits)
2018-11-13 scroggo@google.com Build custom empty SkFontMgr for Android Framework
2018-11-13 jvanverth@google.com Avoid overflow in bufferOffset calculations


Created with:
gclient setdep -r src/third_party/skia@6c242459120d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:b/118742766
TBR=rmistry@chromium.org

Change-Id: Ife94330d4007392c300980f4c387e0fd8267bcb7
Reviewed-on: https://chromium-review.googlesource.com/c/1334249
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607863}

Roll src/third_party/angle f9143725470b..d1a55e393e65 (1 commits)

https://chromium.googlesource.com/angle/angle.git/+log/f9143725470b..d1a55e393e65


git log f9143725470b..d1a55e393e65 --date=short --no-merges --format='%ad %ae %s'
2018-11-14 jmadill@chromium.org Expand dEQP-GLES3 suppressions.


Created with:
gclient setdep -r src/third_party/angle@d1a55e393e65

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:822310
TBR=cwallez@chromium.org

Change-Id: I707d1a122db30dcf53255adc0ee1a749552ffe02
Reviewed-on: https://chromium-review.googlesource.com/c/1334570
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607862}