Chromium Main Console

Move MediaDevices C++ and Mojo interfaces to blink/public/common and blink/public/mojom

The Mojo interface was defined in public/platform/ and the C++ interface was defined in
content/common.

This is part of onion souping the mediastream module.

Bug: 704136
Change-Id: I06cb202e791e445779b533ecc4896d086638300e
Reviewed-on: https://chromium-review.googlesource.com/c/1405314
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623218}

Delete unused ProfileSyncServiceTestHelper

Bug: none
Change-Id: I40d7e737c56de65d5ccae9196d7a3171a9fda2a7
Reviewed-on: https://chromium-review.googlesource.com/c/1414893
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623217}

[Autofill Assistant] Fixed AA crash on startup.

This crash was probably introduced in http://crrev/c/1382496. Because the custom tab is now not immediately available, we register as listener and wait for the CCT to be available instead.

Bug: 806868
Change-Id: I81d6ca44e5996fbeaa7b63a6297a4fbd8fc09208
Reviewed-on: https://chromium-review.googlesource.com/c/1412027
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#623216}

Remove thread checks in OperationsController

There is no need to perform those checks in this class. It should be up
to the user to determine what the threading requirements are. In
particular there are use cases where StartAcceptingOperations and
ShutdownAndWaitForZeroOperations are called from different threads.

Bug: 901345

Change-Id: I15be7eddd49d490bff398f2a06b029c66c3bc8f9
Reviewed-on: https://chromium-review.googlesource.com/c/1407191
Commit-Queue: Carlos Caballero <carlscab@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623215}

Remove reference to media::AudioDeviceDescription from content::MediaDeviceInfo

Types in media/audio, such as media::AudioDeviceDescription should not be accessed
from the renderer process.
The constructor in MediaDeviceInfo that uses AudioDeviceDescription is
currently used only on the browser, but since MediaDeviceInfo is defined
in content/common, it is also available in the renderer process.
This CL removes the reference to media::AudioDeviceDescription in a
MediaDeviceInfo constructor and replaces the call with another
constructor passing fields more explicitly.

This CL is preparation work for moving MediaDeviceInfo to Blink.

Bug: 704136

MediaDeviceInfo will be moved to Blink

Change-Id: I7da4bb4cee30aa0f6a26da5a7a5fc9516f618a9d
Reviewed-on: https://chromium-review.googlesource.com/c/1405048
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623214}

[unified-consent] Convert subpage link to a row in privacy section

- Convert the "Sync and Google services" link in the privacy
section to a cr-link-row.
- Move the row to the top of the privacy section.
- Remove unneeded strings.

Screenshot before:
https://drive.google.com/file/d/1vHcdTDmlY86WeCQo7gsUnzSjDZU6S29C/view?usp=sharing
Screenshot after:
https://drive.google.com/file/d/1qbhC8F0fSmCuAIAl7KIzg6IpPrVggxJu/view?usp=sharing

Bug: 919738
Change-Id: Ie81173ea008bb9e7f5cbaca010ed1d9bfd807c85
Reviewed-on: https://chromium-review.googlesource.com/c/1409284
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623213}

[Password Manager] Add PasswordManager.LinuxBackendMigration.AttemptResult

This metric is reported at the end of an attempt to migrate away from the
Linux native backends and into LoginDatabase.

This complements the PasswordManager.LinuxBackendMigration.Adoption, which
is reported on the next run and can see crashed migrations but can't
contribute successful migration pings to the finch experiment histograms.

Bug: 571003
Change-Id: I6255ffdd129be423dadaad3ba00e3751e9fea81b
Reviewed-on: https://chromium-review.googlesource.com/c/1412932
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623212}

Roll src/third_party/skia a8694cc150a1..2c379d8e27e6 (1 commits)

https://skia.googlesource.com/skia.git/+log/a8694cc150a1..2c379d8e27e6


git log a8694cc150a1..2c379d8e27e6 --date=short --no-merges --format='%ad %ae %s'
2019-01-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c8be560bbabe..ab2bfa814cee (3 commits)


Created with:
gclient setdep -r src/third_party/skia@2c379d8e27e6

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: I36bccced8738ba377befe58558ceea70eb1d0b4a
Reviewed-on: https://chromium-review.googlesource.com/c/1414700
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623211}

Simplify LayoutBox::ComputeLogicalWidth's replaced logical width setup

No need to create a temporary Length here, just use a LayoutUnit. We
can also fold the call to ComputeReplacedLogicalWidth() into the two
points that use it.

Change-Id: I0f5ca8c02ab79f3fb126c77acee83751f06202a1
Reviewed-on: https://chromium-review.googlesource.com/c/1414890
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623210}

Avoid copying Lengths (non-layout uses)

Copying/assigning a Length is not just a trivial copy, so when possible,
use a const Length& to avoid making a copy (saving some small bit of
footprint and hopefully a few CPU cycles too).

Change-Id: I8bcf5c6e6b99027110a20b1ef95d5f6607673ddc
Reviewed-on: https://chromium-review.googlesource.com/c/1411919
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623209}

[ios] Adds Browser and supporting infrastructure.

Browser is a new core iOS class that is intended to map to a single
browser "window". It wraps a TabModel (WebStateList) and
ios::ChromeBrowserState and will be passed around to coordinators and
other objects that need access to the ChromeBrowserState and
WebStateList.

BUG=None

Change-Id: Ic44c389fd856b46fbb996461bcdc537bec321cd2
Reviewed-on: https://chromium-review.googlesource.com/c/1323654
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623208}

Eliminate oauth2_token_service_observer_bridge*

This is no longer used for the iOS build and can be safely removed.

Bug: 921615
Change-Id: Iccc65ed6ce63f081f0a76d9d3d59786c898cdc7d
Reviewed-on: https://chromium-review.googlesource.com/c/1414891
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623207}

Roll src-internal 8b326e1c2f3d..5ab7028d455c (3 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b326e1c2f3d..5ab7028d455c


Created with:
gclient setdep -r src-internal@5ab7028d455c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I5a7b5aac7acc83c28a1d0814675ba552978ae48b
Reviewed-on: https://chromium-review.googlesource.com/c/1414701
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623206}

drawText is deprecated, use drawSimpleText or drawTextBlob

Bug: skia:2664
Change-Id: Iaf60f02455f530031fecfefc1d022b448643302a
Reviewed-on: https://chromium-review.googlesource.com/c/1413635
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623205}

Fix sleeping lag in Chrome/ChromeOS relaunch-to-update timer

Migrate RelaunchNotificationController from using OneShotTimer to WallClockTimer
which based on real time. Refactor all surroundings to use base::Time instead of
base::TimeTicks as well.

Bug: 906689
Change-Id: If65cd37ac8d7e1848a2a6c0dfa1f7a50b6aeca0f
Reviewed-on: https://chromium-review.googlesource.com/c/1397633
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623204}

Perf tests changing available size for fit-content child.

Change-Id: I7098bd765b0b1ea6e272c4472b0598d1da95dbe2
Reviewed-on: https://chromium-review.googlesource.com/c/1411599
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623203}

[ios] Add js injection for password generation

Bug: 886583

Change-Id: I557d7204102f4a28cfb1f6d91a37df50e117e3bd
Reviewed-on: https://chromium-review.googlesource.com/c/1379898
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623202}

Import wpt@344e01763afe4e707286188ce6c1b4584cb1b864

Using wpt-import in Chromium 893c068d35a42afd462e3caebc35ef3814af99f8.
With Chromium commits locally applied on WPT:
1c633d483b "Snap the snapped_dest_rect for backgrounds"
1061788dd2 "Reland "Add quota usage details tests for all other storage backends.""
bcd3934d05 "Add a test for ServiceWorker and AppCache interaction with claim()"
4836c563b1 "Change web platform test with mouse inputs under "pinterevents/""
33a49f0de5 "[WebLocks]: Modifying weblocks algos to be O(1)"
66a94294e7 "Verify getContributingSources() does not return any CSRCs."
8e4e5d7297 "Fix preload tests failing on wpt.fyi dashboard"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: I4f69c20aac42b9131c9886f8f2bef1e7f93b0536
Reviewed-on: https://chromium-review.googlesource.com/c/1414870
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623201}

Roll src-internal f2c8fe4e24b3..8b326e1c2f3d (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2c8fe4e24b3..8b326e1c2f3d


Created with:
gclient setdep -r src-internal@8b326e1c2f3d

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ie1cf5ccd165b57597acebc1db00091fffbc07d52
Reviewed-on: https://chromium-review.googlesource.com/c/1414699
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623200}

Reland "Enable unique font matching matching by default"

This reverts commit f6c717eb8b60f311b6357b3ddace4c79b1a2e64e.

Reason for revert: Crash has been addressed in
https://chromium-review.googlesource.com/c/chromium/src/+/1414852

Original change's description:
> Revert "Enable unique font matching matching by default"
>
> This reverts commit 2e8e7c130cbb432732e973fd8c266a0608727b5f.
>
> Reason for revert: Crashes observed in Windows Canary
>
> Bug: 922183
>
> Original change's description:
> > Enable unique font matching matching by default
> >
> > Now that all implementations for Android, Windows, Linux/CrOS and Mac
> > are in place, enable the feature globally. Chrome will match fonts
> > references in @font-face { src: local(<font-name>) } correctly by
> > postscript name or full font name. This addresses a long standing,
> > highly starred font matching issue in Chrome.
> >
> > Bug: 828317, 627143, 921029
> > Change-Id: I348855fdca817a4cd279f4d938e6d5ffe91ee004
> > Reviewed-on: https://chromium-review.googlesource.com/c/1400695
> > Commit-Queue: Dominik Röttsches <drott@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Reviewed-by: Emil A Eklund <eae@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#622456}
>
> TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 828317, 627143, 921029
> Change-Id: I6a89f36923abb7d87de712c9ac0852da06a66d37
> Reviewed-on: https://chromium-review.googlesource.com/c/1412824
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622898}

TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org

Change-Id: I915e1bb20ee51325befa5ef7eab07f78eaa8c974
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 922183, 828317, 627143, 921029, 922183
Reviewed-on: https://chromium-review.googlesource.com/c/1413603
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623199}

[CSS] Support ::part with ::before/::after

This enables it for ::before, ::after and ::placeholder and adds a
test for all 3 but for reasons I haven't dug into yet, ::placeholder
doesn't work with ::part, so this includes a failing expectation.

Bug: 921908
Change-Id: I60a859ede98f8284cb3a1e44c81a33230b490239
Reviewed-on: https://chromium-review.googlesource.com/c/1414536
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623198}

pdf: Use chrome.fileSystem.chooseFile when saving PDF from extension

This matches the save behavior of the plugin, where a file picker
is opened rather than the file being immediately downloaded.

Bug: 61248
Change-Id: I2481ffcb8fe1ba346acadb8106d786ee09fc8a94
Reviewed-on: https://chromium-review.googlesource.com/c/1356161
Commit-Queue: dstockwell <dstockwell@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623197}

Fixed IPC memory leak of prerender alias urls messages.

This patch fixes minor leak of prerender IPC messages that are
broadcasted to all renderers to inform that alias url is added or
removed. Added check that target renderer is initialized and not dead.
More details for reasons of leaks are described in
https://bugs.chromium.org/p/chromium/issues/detail?id=813045

Bug: 813045
Change-Id: Ida6ea0eae4fbfd0e89ede9863449168d95d93fd2
Reviewed-on: https://chromium-review.googlesource.com/c/1406629
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Alexander Semashko <ahest@yandex-team.ru>
Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#623196}

[Custom passphrase] Moving ScopedFeatureList out of the test body

This CL addresses a TSan failure that occurs when the global
g_feature_list_instance is changed after some parts of Chrome has been
initialized (and have accessed the previous g_feature_list_instance via
FeatureList::IsEnabled()). Thus, this CL removed the use of
ScopedFeatureList from the test body (where possible).

Bug: 915219
Change-Id: I8c442c1c7dcbc7e7086daa41fc4dcc4919e84339
Reviewed-on: https://chromium-review.googlesource.com/c/1411930
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623195}

Partial cleanup use of base::Value in printing backend.

Bug: 660612
Change-Id: I75404c19cf794abee8eff74e78005226139682b9
Reviewed-on: https://chromium-review.googlesource.com/c/1387467
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623194}

Make Font Table construction resilient to lack of font pathname

If we were unable to retrieve a path for a font registered in the system
font collection, continue with the next font in the system font
collection, instead of hitting the assertion. Speculative fix for such
cases seen in the wild, unable to reproduce locally as it probably is
hit for corrupt fonts or an invalid font registration in the registry.

Bug: 922183
Change-Id: Ic071cee9a16ef0cb3a6fe095474348e437d65459
Reviewed-on: https://chromium-review.googlesource.com/c/1414852
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623193}

Clang: the tip-of-tree version is now 9

TBR=thakis

Bug: 922386
Change-Id: I14856f18ea5025fd9f1fd813e3fe87bdb787a656
Reviewed-on: https://chromium-review.googlesource.com/c/1412828
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623192}

Port signin_ui_util.cc away from ListAccounts()

The CL removes the dependency on GaiaCookieManagerService

Bug: 921501
Change-Id: I948d868c437d99399050192f6efd4667cf0e12ac
Reviewed-on: https://chromium-review.googlesource.com/c/1411922
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623191}

SyncService::GetActiveDataTypes: return "none" if there is a persistent auth error

This seems like the safer (and more accurate) interpretation of "active".
In particular, this will affect the "Sync paused" state, for which we previously
claimed that all data types were active.

Bug: 913984
Change-Id: Iea5b0fd113cfc2d12b7173205302abb8fa862cc7
Reviewed-on: https://chromium-review.googlesource.com/c/1402877
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623190}

[scheduling] Use ScopedTaskEnvironment instead of MessageLoop in drive_backend

MessageLoop will go away, eventually.

BUG=891670

Change-Id: Ia64f78ea238b99b0599cfec331ffaa764742399b
Reviewed-on: https://chromium-review.googlesource.com/c/1377853
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#623189}

Make secondary account sync tests share a single TestURLLoaderFactory.

Before this change, these tests had multiple TestURLLoaderFactory
instances. One, which is declared in SyncTest, plus an additional
instance each time BuildFakeGaiaCookieManagerServiceWithOptions was
invoked.

Eventually, FakeGCMS will be eliminated entirely in these tests. This
change separates out one of the logical side effects of eliminating
FakeGCMS, which that there will be a single TestURLLoaderFactory
instance.

We are splitting out this change to be able to verify whether the switch
to a single shared factory was the cause of the flake in
https://chromium-review.googlesource.com/c/chromium/src/+/1396148. Our
suspicion is that the flake was rather caused by the fact that in that
CL, the TestURLLoaderFactory was *not* used by the main profile, whereas
prior to that CL FakeGCMS instances had been installed for all Profiles.

Assuming that this change sticks, we will follow it up by hiding the
usage of |test_url_loader_factory_| inside a new SecondarySyncTest
class, thus eliminating the passing of the raw pointer.

This is part of step 1a of the plan to eliminate FakeGCMS entirely:
TBR=rkaplow@chromium.org

https: //docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit
Change-Id: I86837090af84e94bdd9887ac9ee5e9c96bbef8da
Bug: 907782
Reviewed-on: https://chromium-review.googlesource.com/c/1411877
Commit-Queue: Lowell Manners <lowell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623188}

Port AvatarToolbarButton away from GaiaCookieManagerService callbacks

It was observing the gaia cookie manager service to know whether the
list of gaia accounts in the cookie jar has changed. That can be
achieved observing IdentityManager as well.

Bug: 921008
Change-Id: Icad5a14f1288346b97d4d8ccc1eb4c0a901eae3b
Reviewed-on: https://chromium-review.googlesource.com/c/1408928
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623187}

Roll src/third_party/perfetto 4a0ee4e0ef36..e2f79261ed5f (11 commits)

https://android.googlesource.com/platform/external/perfetto.git/+log/4a0ee4e0ef36..e2f79261ed5f


git log 4a0ee4e0ef36..e2f79261ed5f --date=short --no-merges --format='%ad %ae %s'
2019-01-16 primiano@google.com Disable heap profiling e2e tests
2019-01-15 oysteine@google.com Fix integer sign mismatch error preventing Chrome autoroll
2019-01-15 rsavitski@google.com heapprofd: minimally-functioning fork mode
2019-01-15 treehugger-gerrit@google.com Merge "base: add missing PERFETTO_EXPORT to ThreadChecker"
2019-01-15 hjd@google.com Merge "perfetto-ui: Refactor high frequancy state"
2019-01-15 primiano@google.com Ftrace: fall back on set_event interface if /enable fails
2019-01-15 eseckler@google.com Merge "Add PERFETTO_EXPORT onto the ScatteredHeapBuffer and sub class SLICE"
2019-01-15 eseckler@google.com Merge "Add two additional stats (rewritten & out-of-order) related to writing chunks."
2019-01-15 eseckler@google.com Merge "gn: Make it more convenient for embedders to enable DLOG"
2019-01-15 ilkos@google.com Allow arbitrary config in tmux tool
2019-01-15 lalitm@google.com Merge "trace_processor: add userspace LMK events to the instants table"


Created with:
gclient setdep -r src/third_party/perfetto@e2f79261ed5f

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:121352331,chromium:78791178,chromium:120185246,chromium:122609457
TBR=perfetto-bugs@google.com

Change-Id: I1d8dae96d1532c2bdc1f5971d8a639fe1c0eaf08
Reviewed-on: https://chromium-review.googlesource.com/c/1414698
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623186}

Migrate PeopleHandler to the IdentityManager

Use the APIs from IdentityManager and PrimaryAccountsMutator to migrate
calls previously depending on SigninManager and ProfileOAuth2TokenService.

Bug: 898810, 920236, 920237, 921445
Change-Id: I22b046bae82e2539d165d95573c27d47affa6a06
Reviewed-on: https://chromium-review.googlesource.com/c/1298994
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623185}

Keep the StreamBrokerDisconnectReason histograms a bit longer.

Bug: chromium:919650 chromium:919651
Change-Id: I15130a3f0e179532dc90fb7ae2ac8f142de1a641
Reviewed-on: https://chromium-review.googlesource.com/c/1412457
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jonas Olsson <jonasolsson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623184}

Remove check for client registration in StatusUploader ctor

StatusUploader's work makes sence only if working on managed device with
resitered client, but due to some missynchonizations we may not know
if it's registered client when creating StatusUploader. That's why there
is an extra registered check before submitting status. See more in:
https://bugs.chromium.org/p/chromium/issues/detail?id=705607

Therefore check in StatusUploader constructor is redundant and causes
only problems when dchecks are enabled:
https://bugs.chromium.org/p/chromium/issues/detail?id=912770

Bug: 912770
Change-Id: Ib9c4001b87834286a36cbe3ca123f1c456844ad9
Reviewed-on: https://chromium-review.googlesource.com/c/1400664
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Oleg Davydov <burunduk@google.com>
Cr-Commit-Position: refs/heads/master@{#623183}

[Password Manager] More precise errors for failure on LinuxPasswordsMigrationToEncryptionStatus

When migrating away from the native backend, the most common cause of
failure are operations on the temporary database. I've split the error
code for further insight.

Bug: 571003
Change-Id: I382e62ebeb9c85306526bcd6978a1aa41a5e79fc
Reviewed-on: https://chromium-review.googlesource.com/c/1411609
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623182}

[iOS][MF] Restore original keyboard for pickers

When the keyboard changes to a picker restore it, so the user can select
one of the options from the site. The user is still able to go back into
the manual fallback menu for consultation, touching the options won't
work though.

Bug: 914766
Change-Id: I23b4d91bc2833705fe5cec8250e5eac27c5083d4
Reviewed-on: https://chromium-review.googlesource.com/c/1411931
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: David Jean <djean@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623181}

Add a factory method to create a FakeGCMS with a TestURLLoaderFactory.

This new factory method is meant to replace
BuildFakeGaiaCookieManagerServiceWithOptions in the cases where
create_fake_url_loader_factory_for_cookie_requests is set to true.

Callers of BuildFakeGaiaCookieManagerServiceWithOptions will be migrated
to use this new factory method in a future CL.

This is part of step 1a of the plan to eliminate FakeGCMS entirely:

https: //docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit
Change-Id: Ia26dbe429743e30b86130106d3909a3320e4ba2d
Bug: 907782
Reviewed-on: https://chromium-review.googlesource.com/c/1412456
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623180}

[aw] Add proxy override integration tests

Bug: 902215
Change-Id: Ibac9527580253aa924ed8c553bb5f01f47e368aa
Reviewed-on: https://chromium-review.googlesource.com/c/1391561
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623179}

Convert from base::{LazyInstance,Singleton} to base::NoDestructor

The class base::NoDestructor is a simpler way to define a static
global value (aka a singleton) than base::{LazyInstance,Singleton}
and is the recommended pattern to use.

The changes were automated using a custom one-shot script, then
fine tuned by hand (to remove unnecessary classes, ...).

This fixes usages in src/ios/chrome/browser/ui/webui.

This CL was uploaded by git cl split.

Bug: none
Change-Id: I0f2864e73cf4e99a07384d29dfd0c5c705a9dc85
Reviewed-on: https://chromium-review.googlesource.com/c/1411785
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623178}

unified-heap: Provide names for internal classes in heap snapshot

Provide a name for internal nodes in non-production builds.

This is very useful for manual debugging builds but may confuse people
without providing better DevTools integration.

Bug: 843903
Change-Id: Ifd7359575beb3c916a86fc6091abfc20c76e6b64
Reviewed-on: https://chromium-review.googlesource.com/c/1412472
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623177}

Roll src-internal 5631ed218f7e..f2c8fe4e24b3 (7 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5631ed218f7e..f2c8fe4e24b3


Created with:
gclient setdep -r src-internal@f2c8fe4e24b3

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ic38853d87d4b9222be558da9bb752c0703afa66b
Reviewed-on: https://chromium-review.googlesource.com/c/1414697
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623176}

Download Home : Fixed padding on empty view on Articles for You section

This CL improves the UI (attached screenshot) as per mocks :
https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZa-WKS_VfBWp/files/MCHtA7U1iMGr6yF79JTTnBdi9vOmcRvRxmM

Bug: 902403
Change-Id: I7fd6b64a70531f28e5ba6fc8428198bf5c771c58
Reviewed-on: https://chromium-review.googlesource.com/c/1412822
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623175}

Remove click handler for the link in the password generation popup

The link has already been removed, both on desktop and Android, but
the click handler was not.

Note: On Android, the popup is now used only to display the help text.

Bug: 862269
Change-Id: Ie6fbe83c45b029fccb4fd32d228a53bdd527d5f0
Reviewed-on: https://chromium-review.googlesource.com/c/1409451
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623174}

s13n: Remove SigninManager-related includes from identity_apitest.cc

This CL cleans up the unnecessary includes related to SigninManager.

Bug: 920210
Change-Id: I67b9505ad35270ca50356dade8e02fb478557000
Reviewed-on: https://chromium-review.googlesource.com/c/1414730
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#623173}

Use bigger tab view under accessibility font size.

This CL adjusts the size of tab views and height of their titles in tab
grid under accessibility font size. Title will be displayed in 2 lines
when accessibility font size is chosen.

Screen shots:
iPhoneXR: https://drive.google.com/open?id=1anVBsA3cOBumUqt38OpM6FtprLBFfup5

iPad landscape:
50%: https://drive.google.com/open?id=1E9m9Viqhval_l9Est8U1-sQktI7c_38l
66%: https://drive.google.com/open?id=1GuXD-miJgBPL3FnhlSRLoDrKMFa9xv0w
100%: https://drive.google.com/open?id=1jiAutUdf-wcACcckxtFbJFmS_S-2f7t2

iPad Portrait:
40%: https://drive.google.com/open?id=1A9WsE-_vT0kdzuAhEDNQH-UQtVqLGF53
60%: https://drive.google.com/open?id=1CR-holR-9JcuvMBjadrzWjcoDFuaJU4i
100%: https://drive.google.com/open?id=1k8BCFtqKavozdpoihA7tYg3PT7ho7Eo7

Bug: 893540
Change-Id: I314d081439909cf6f3711d06df579c73a9685e99
Reviewed-on: https://chromium-review.googlesource.com/c/1409546
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623172}

Implement accessible SetValue action for contenteditable

Bug: 917817
Change-Id: Id1586493b47f74ca960fdf934fb099ec79225519
Reviewed-on: https://chromium-review.googlesource.com/c/1411292
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623171}

Enable PreloadImageSrcSet feature by default

This enables imagesrcset and imagesizes attributes on <link>.

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/07CbItWfA4M/CG1qF8IoEAAJ

Bug: 813452
Change-Id: I9396fe35729069ef56b461aa99cf85e9b1e51302
Reviewed-on: https://chromium-review.googlesource.com/c/1414513
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623170}

Roll src/third_party/skia 47b7cd9a6baf..a8694cc150a1 (1 commits)

https://skia.googlesource.com/skia.git/+log/47b7cd9a6baf..a8694cc150a1


git log 47b7cd9a6baf..a8694cc150a1 --date=short --no-merges --format='%ad %ae %s'
2019-01-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset


Created with:
gclient setdep -r src/third_party/skia@a8694cc150a1

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: Ifbb52591de504e87cbe0f3452022f2085f41d315
Reviewed-on: https://chromium-review.googlesource.com/c/1414692
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623169}