Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
Fix VariationsSession creating std::string from nullptr.
Multiple early returns in GetVariationsCountry() call return a nullptr,
which is implicitly casted to const char*, causing std::string
constructor to crash.
The change slightly rearranges the internal logic to ensure RVO kicks
in.
Change-Id: I3947ced79a413f5f6dbf3e07db4647bc5fac59a6
Fixed: b:384763025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6101909
Auto-Submit: Tomasz Wiszkowski <ender@google.com>
Commit-Queue: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397580}
Cert Management UI V2: set baseline for row to align items properly
Before: https://screenshot.googleplex.com/AR2B2TVhoY54eXo
After: https://screenshot.googleplex.com/9nYtevngeaJ3Wgo
Bug: 379097469
Change-Id: I8c1787daafe3d64dada2faaff925f34dbd79e51c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6096694
Commit-Queue: Hubert Chao <hchao@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397579}
[MPArch Guest View] Enable Accessibility tests
Avoid the ForEachGuest call which is not necessary because the guests
will be visited via the FrameTreeNode walk.
Bug: 40202416
Change-Id: Ic71cad64ce1b1d89f3625282e1589ac4dd16fe81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6091890
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: James Maclean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397578}
Cert Management UI V2: Guard cert editing on policy check
Bug: 40928765
Change-Id: I1aacc43309a8bdb8afbedc8f074984c8526901de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102347
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Hubert Chao <hchao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397577}
Cert Management UI V2: Fix CSS styling on cert viewer modifications tab
* heading to normal font weight
* use standard error color for error divs
before: https://screenshot.googleplex.com/AYkqR35yspGgNS9
after: https://screenshot.googleplex.com/9THFwtV2NXaCTh3
Bug: 379097469
Change-Id: Ifafaa68ccaa68b1ff4912dbeca944da94ec441e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6096611
Commit-Queue: Hubert Chao <hchao@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397576}
[TabGroupReorder] Move group indicator layer to separate class
Move group indicator layer to separate class.
-Foreground group indicator layer.
Bug: 383958147
Change-Id: Ibee6faff8ca337455bbdce135b05e6cd8ea7c40f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6093666
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Reviewed-by: Sirisha Kavuluru <skavuluru@google.com>
Commit-Queue: Neil Coronado <nemco@google.com>
Reviewed-by: Zhe Li <zheliooo@google.com>
Cr-Commit-Position: refs/heads/main@{#1397575}
[TabGroupReorder] Foreground the reordering tabs
Foreground the reordering tabs.
-The group indicator is not yet foregrounded. This will be done in a
followup where we'll also add the bg shape.
Bug: 376068489
Change-Id: I49b933d3559e2c3154f1d6a79f949100bffc1e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6092911
Reviewed-by: Zhe Li <zheliooo@google.com>
Commit-Queue: Neil Coronado <nemco@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Sirisha Kavuluru <skavuluru@google.com>
Cr-Commit-Position: refs/heads/main@{#1397574}
[lensoverlay] Send partial page content
This request is used to provide suggest signals prior to the full
page being ready. This is a fire and forget request to provide context
to the server, so we are not expecting a response. We only use the
response to measure latency.
This CL also rewrites the query controller unit tests to separate out
tests that need mock time. Mock time causes RunUntil to run forever,
so separating it out makes tests that don't rely on them simpler.
Bug: 379344946
Change-Id: If73b1bf1459436b5fef021079765daca7c78d7f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6092593
Reviewed-by: Jason Hu <hujasonx@google.com>
Commit-Queue: Duncan Mercer <mercerd@google.com>
Cr-Commit-Position: refs/heads/main@{#1397573}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1734458424-2522aad25b2d98d244ed7efc7856a82ec104f9a0-203e6415abbb0491519e33d58969e3e78c6513a7.profdata to chrome-android64-main-1734466479-15885baf4ab41144dfa1f888efc1a60c4a1670c8-873b217c626667c93b3984d8e5b112eabd67a98f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ie543ad23101805c75154f2ff0af91498c734c5a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102979
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397572}
Revert "[TabStripComboButton] Fix TabStripRegionViewBrowserTest class."
This reverts commit 7f71ccb7f703b62ee184cebb7b8fbda84a13fade.
Reason for revert: Failing on MSan: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/52626/test-results?q=ExactID%3Aninja%3A%2F%2Fchrome%2Ftest%3Ainteractive_ui_tests%2FTabSearchForcedPositionTest.DefaultTestSearchContainerIsEndAligned%2FAll.0+VHash%3A0b7dea373e451e6a
Original change's description:
> [TabStripComboButton] Fix TabStripRegionViewBrowserTest class.
>
> This CL adds coverage for TabStripRegionViewBrowserTest for combobutton feature to ensure field trial config works. This parametrizes the test to run with and without the combobutton.
>
> With the combo-button the tab search should exist after the last tab instead of start and end of the tabstrip irrespective of tabs::kTabSearchPositionSetting.
>
> Additionally, tabs::GetTabSearchTrailingTabstrip() should not be applicable with combobutton as the tab search will always exist after the last tab.
>
> Bug: 384569726
> Change-Id: I55fefd1ce28dcfa3472d5a802ae88ce7a964610e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098171
> Reviewed-by: Emily Shack <emshack@chromium.org>
> Commit-Queue: Shibalik Mohapatra <shibalik@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1397438}
Bug: 384569726
Change-Id: I8b3d3506007d9edee32ed9f0e70cc08f8026993a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6103116
Owners-Override: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397571}
Clean up stale base::Feature LensSearchOptimizations
This feature was mostly cleaned up in crrev.com/c/6073024, but the declaration in the header file was missed.
Bug: 356236695
Change-Id: I14776e81eaae9f78f82a7b35b9ba16a5105145af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6096492
Reviewed-by: Juan Mojica <juanmojica@google.com>
Commit-Queue: Svend Larsen <svend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397570}
Roll BoringSSL from 4a82464f4a66 to 9338cc251292 (2 revisions)
https://boringssl.googlesource.com/boringssl.git/+log/4a82464f4a66..9338cc251292
2024-12-17 davidben@google.com Remove uses of OPENSSL_INLINE and OPENSSL_UNUSED except for public headers
2024-12-17 davidben@google.com Make ec/make_tables.go run cleanly again
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/boringssl-chromium
Please CC boringssl-cabal@google.com,boringssl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in BoringSSL: https://crbug.com/boringssl/new
To file a bug in Chromium: https://crbug.com/new
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: boringssl-cabal@google.com
Change-Id: Ic771b27dad8db51c6d973c171e64693f2a966107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102636
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397569}
Roll Dawn from 0c4e4be34220 to 9c149a580bd4 (4 revisions)
https://dawn.googlesource.com/dawn.git/+log/0c4e4be34220..9c149a580bd4
2024-12-17 senorblanco@chromium.org Compat CTS: add a test failing on Intel GL.
2024-12-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from d39324e06351 to 5b75d5d64ec2 (1 revision)
2024-12-17 jrprice@google.com [ir] Use IsCompute/IsFragment/IsVertex in more places
2024-12-17 jrprice@google.com [ir] Use Function::IsEntryPoint() where possible
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com,senorblanco@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64
Bug: chromium:383595386
Tbr: senorblanco@google.com
Change-Id: I404713ac05c28875c2c7692eab92891285711a4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6101643
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397568}
Adding red path support for CardInfoRetrieval enrolled cards by displaying autofill error dialogs for temporary and permanents failure messages.
Design doc:go/jp-ewallet-fronting-card-chrome-design
Bug: 369472865
Change-Id: I36698b9c19bc9bfe06a44a49966f0ac8c4182c38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6027097
Reviewed-by: Jiali Huang <jialihuang@google.com>
Reviewed-by: Siyu An <siyua@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Vinny Persky <vinnypersky@google.com>
Commit-Queue: Harsh Shukla <hvs@google.com>
Cr-Commit-Position: refs/heads/main@{#1397567}
Clarify expected values in JSON parsing tests
The UTF-8 encoded, C-string-escaped version of U+FFFD was not
particularly readable.
Bug: 373620353
Change-Id: I85a36e4476bf3a0553b31152ef610826fc49828e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6096839
Commit-Queue: Dustin Mitchell <djmitche@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397566}
Revert "Sync feature protos."
This reverts commit 1fe3c86699e54515101bcb4a5d9b062415b90fb0.
Reason for revert: b/384090989 Breaks compatibility with current on-device feature configs. See https://chromium-review.googlesource.com/c/chromium/src/+/6100523
Original change's description:
> Sync feature protos.
>
> This CL was generated by a Copybara workflow. See the attached bug for more details.
>
> BbcpOrigin-RevId: 706773675
> Change-Id: Iab1dda6a75048e68608dfe1afaeb42c61996783d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6093897
> Reviewed-by: Max Curran <curranmax@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Auto-Submit: Copybara Service <copybara-worker-blackhole@google.com>
> Commit-Queue: Ilya Sherman <isherman@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1397013}
Change-Id: I3a905dc70ad411d2af84e5935d349d985007a199
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6103075
Commit-Queue: Max Curran <curranmax@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397565}
Bring backgroundless combo button up to spec
* Adds leading margin
* Adds space between the two buttons
* Doesn't hide the separator when a button is highlighted
* Makes all four corners of each button rounded
Bug: 383780001
Change-Id: I9611faeb74091f3ea21c596fcbd66bea6676100a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6100543
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Shibalik Mohapatra <shibalik@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Emily Shack <emshack@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397564}
Update menus on bookmark model changes (1/N)
This CL is a refactor with no expected changes in behaviour.
It updates UpdateMenuArtifacts to return a list of menus that were
updated, giving the caller the responsibility of invoking
"ChildrenChanged" on them. This will be needed by the last CL in the
chain, where the delegate may make further updates to the parent menus.
It also simplifies some logic for building/removing the "other"
bookmarks folder header.
Bug: 40868588
Change-Id: Ifc80c3958ea4004814433453efc7def4d6d1782d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6090842
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Kaan Alsan <alsan@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397563}
[Collaboration] Give GroupToken when showing join dialog
The GroupToken is needed to add a member to the collaboration group.
Change-Id: I2cc84b8181302fc0a735684b3c51076da0668367
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6094352
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Hailey Wang <haileywang@google.com>
Cr-Commit-Position: refs/heads/main@{#1397562}
Set textAppearance to textAppearanceListItem for the tab menu
Currently the tab menu uses layout android.R.layout.simple_list_item_1
with textAppearanceListItemSmall.
In the recent Material3 theme migration, textAppearanceListItemSmall has
changed to a smaller text size.
https://chromium-review.googlesource.com/c/chromium/src/+/5262950/10/chrome/android/java/res/layout/sync_passphrase_types.xml#26
This CL created a new layout with textAppearanceListItem for the tab
menu.
Bug: 338929740
Change-Id: Idb152d2e7c1e77de6c62a164f219eefe0d2b1523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6101159
Commit-Queue: Shu Yang <shuyng@google.com>
Reviewed-by: Sirisha Kavuluru <skavuluru@google.com>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/main@{#1397561}
[Win Caption Buttons] Fix RTL mode tooltip
This CL addresses an issue in RTL languages where the window caption
buttons display incorrect tooltips.
The issue was caused by using `bounds()` for hit testing, which does not account for RTL layouts. The fix replaces `bounds()` with `GetMirroredBounds()`, ensuring that hit testing works correctly in both LTR and RTL contexts. Additionally, a regression test has been added to verify the fix and prevent future regressions.
Please find the attached screencast below after the fix:
https://drive.google.com/file/d/1rQPrbaSMW6NOTrPBszYzv5XDuEsONAyu/view?usp=sharing
Bug: 41487893,40790302
Change-Id: I84e24d7fd3bdae1406b21152aab73d1dd50ad51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098828
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397560}
[self_freeze] Record metrics for self freeze
Bug: 375387638
Change-Id: I5600cbd7746b711691c3352b4c5de6762b60c923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6053697
Reviewed-by: Benoit Lize <lizeb@chromium.org>
Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com>
Cr-Commit-Position: refs/heads/main@{#1397559}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1734458182-14ef44fce264a6c41104dead226004abdfb8b05e-c29f06c4a45d01eca24119097916df5f13b682ef.profdata to chrome-mac-arm-main-1734465536-3a15132f4c31bee536bd8f633123d45337a99b26-61cd175f0ff07ffdec8c680904680d8f98b92aac.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I6fc02301bac7535a3b36a7657c83fcd114558420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102113
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397558}
Add a way to add --skip-javadoc-formatting when running git cl format
This is often desirable for large scale changes since most JavaDoc is
not currently formatted correctly.
Bug: None
Change-Id: Ie9da1186029b6d3973514c48b3d19ebcff289a6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6096699
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397557}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1734436763-acde1c8249d5a8e776f0a311aaf984b460ba9e50-350bd3a6bf626f7a1187774fd5cad80e7a73499d.profdata to chrome-win32-main-1734447042-a2b2a7db02b089a0b8425312081412707f0d030a-aec661770742e09205cfcdcbf03dbd1ac8cf777b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Idb94a53429d24c5123912de66771e5348ae69362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102305
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397556}
Add new glic api boot injection code
See bug for motivation.
Updates the injected source to not use 'export', and to install
the boot function on window. This allows the client to add
the script as a new <script> element, and access the API.
This change does not break existing clients.
Bug: 382121207
Change-Id: I6cf7c5bb0edb4a4a66da321646ff60fd68ff76b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088472
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397555}
fast_local_dev_server.py: Make CMD: logs copy & pastable
Bug: 370589852
Change-Id: I87a9a1115b78fa46032c2dd0973b2884a321874a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102348
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397554}
Fix joenotcharles address
I've switched to my @google.com address exclusively.
Change-Id: I5835871709aa81d3bf971e2bd0a18a0405680a92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102567
Commit-Queue: Olivier Li <olivierli@chromium.org>
Reviewed-by: Olivier Li <olivierli@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Auto-Submit: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/main@{#1397553}
Cert Management UI V2: Refresh user cert lists when cert viewer edit
is triggered.
Bug: 40928765
Change-Id: Ic17f65f4c879ad684927dcdc9f4a8447fefbe51f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097159
Reviewed-by: Joe Mason <joenotcharles@google.com>
Commit-Queue: Hubert Chao <hchao@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397552}
sunfish: Re-show action buttons on re-start capture session
This CL fixes the issue where the action buttons would not re-show
on exiting and re-entering default capture mode session. We will now
show the default Search button and perform text detection in default
mode, or early exit in sunfish mode as the user capture region will be
empty.
Demo: https://b.corp.google.com/issues/377569542#comment5
Test: added
Fixed: b/377569542
Change-Id: Iae8a9d541b58c40a5fb1a52470563019151c5e8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097379
Commit-Queue: Sophie Wen <sophiewen@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397551}
[TabStripRefactor] Refactor effectiveTabWidth to supplier and findViewAtPosition to util.
These refactors are pre-req for moving updateReorderForExternalTabDrop into ReorderDelegate.
Bug: 381285152
Change-Id: If19ad8d04900138234c0d0bde76fa049ee4ed1d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6101257
Reviewed-by: Neil Coronado <nemco@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Auto-Submit: Sirisha Kavuluru <skavuluru@google.com>
Commit-Queue: Sirisha Kavuluru <skavuluru@google.com>
Reviewed-by: Zhe Li <zheliooo@google.com>
Cr-Commit-Position: refs/heads/main@{#1397550}
Roll clank/internal/apps from e5f8d6b8f6c0 to 773685ed2b08 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/e5f8d6b8f6c0..773685ed2b08
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,wenyufu@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: wenyufu@google.com
No-Try: true
Change-Id: I5c3eea93ccbb85a154036e9f2372a198f4ecfa39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102642
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397549}
infra: Change TODO bug link for builder build-dir code
The cleanup for this experiment moved to a more specific bug.
Bug: 380434968
Change-Id: Ida428813fb14bc13f301ac3340ba2ddc8705c743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102386
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Wanda Mora <morawand@google.com>
Cr-Commit-Position: refs/heads/main@{#1397548}
[Frameworks roll] Roll to 707192691 piper revision
Change-Id: I3e66fbd31d65da9bd5d932ec9ae1e3e33d89359c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097901
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397547}
[History][Embedder] Add observer for experimental embedder target.
Bug: 383780439,383380610
Change-Id: Ic368c458e2442313f538712dde9c61133f6040b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102484
Reviewed-by: Raj T <rajendrant@chromium.org>
Auto-Submit: Jun Zou <junzou@chromium.org>
Commit-Queue: Raj T <rajendrant@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397546}
Fix naming of WebDXFeatures
Blink UseCounter uses a slightly different capitalization for WebDXFeatures. This scheme is documented at the top of the webdx_feature.mojom.
Corrected names:
- https://github.com/web-platform-dx/web-features/blob/main/features/writingsuggestions.yml
- https://github.com/web-platform-dx/web-features/blob/main/features/cross-document-view-transitions.yml
- https://github.com/web-platform-dx/web-features/blob/main/features/scroll-snap-events.yml
- https://github.com/web-platform-dx/web-features/blob/main/features/context-fill-stroke.yml
Change-Id: Idaea71418fc50eb80b5c388cabf0242ab8d425d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098210
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: James Scott <jamescscott@google.com>
Reviewed-by: Kyle Ju <kyleju@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397545}
Rebaseline of fast/ruby/text-decoration.html for mac15
It seems an Arabic font on macOS 15 was updated.
This CL has no behavior changes.
Fixed: 377802687
Change-Id: I9dfc2c4622f1f193049f7c068a23d6ed0ed83ea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097590
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397544}
HttpStreamPool: Remove meaningless MaybeMarkQuicBroken() call
The call in MaybeAttemptConnection() didn't take any effect since
we called it after setting `tcp_based_attempt_state_` to
kAllEndpointsFailed but MaybeMarkQuicBroken() returns early when
the state is kAllEndpointsFailed. There is another
MaybeMarkQuicBroken() call in OnInFlightAttemptComplete() so
just removing it should be fine.
Bug: 346835898
Change-Id: I7ce252a2f1c4e5db5cd3d34102e5a07de38f68f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6096545
Reviewed-by: mmenke <mmenke@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397543}
webnn: Add DIR_METADATA to Web Platform Tests directory
This will ensure that issues automatically filed for WPT failures
are correctly triaged into the project's issue component.
Change-Id: I8d895dbec5a138a05ab9f2cc0da5e6456f3e05a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102569
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397542}
androidx: Fix roller issue where testonly is not applied to groups
If a dependency has no artifacts, it gets translated into a GN group,
which then depends directly on all its children. We need to ensure that
if such groups depend on a testonly target, they also get testonly
applied or else gn gen will not be happy.
Change-Id: Ie75ff8831a3cae08354e3b5a6aa4e680bdae08ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102438
Reviewed-by: Peter Wen <wnwen@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397541}
Enable FeedbackIncludeVariations test config
The experiment has been verified end-to-end.
Bug: 373470046
Change-Id: Ia1b81a2763afb2c2c05818f37283d710760a7963
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6101173
Reviewed-by: Luc Nguyen <lucnguyen@google.com>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397540}
Roll clank/internal/apps from acc6a8eb9ac5 to e5f8d6b8f6c0 (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/acc6a8eb9ac5..e5f8d6b8f6c0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,wenyufu@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:379703994
Tbr: wenyufu@google.com
No-Try: true
Change-Id: If1431c629da89ebcb42adee6979582ed22d64ffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102699
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397539}
Roll Skia from 6bc48cb8bac9 to b2f3e3f6263a (3 revisions)
https://skia.googlesource.com/skia.git/+log/6bc48cb8bac9..b2f3e3f6263a
2024-12-17 kjlubick@google.com Replace SkSharedMutex with std::shared_mutex
2024-12-17 aperez@igalia.com [base] Fix building SkDOM.cpp with Clang in C++23 mode
2024-12-17 jamesgk@google.com [ganesh] Avoid overflow when combining AAHairlineOps
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC egdaniel@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: egdaniel@google.com
Change-Id: Ia561599c52272975cc541c247e7f72e0985336de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102529
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397538}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1734436763-2ad4a6ea7b1e004005a4fa39fb4595d1c04a10a8-350bd3a6bf626f7a1187774fd5cad80e7a73499d.profdata to chrome-mac-main-1734458182-7df1a378564e0a02a509d893cd6f564a026ccc8d-c29f06c4a45d01eca24119097916df5f13b682ef.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Idf7647f4f98b04e39a63a2f2d09146881a42070b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102486
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397537}
android: Add @NullMarked //components/browser_ui/*
Bug: 40657579
Change-Id: Iaa310f94020052b6b367a7fcd1b37d5ace1d1338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102644
Owners-Override: Peter Wen <wnwen@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397536}
HttpStreamPool: Allow using slow-attempting endpoints
Some browser_tests are flaky (e.g. [1]) when the HappyEyeballsV3
feature is enabled. The cause is that we don't use a slow-attempting
endpoint if the endpoint is the only endpoint that hasn't been
failed. A slow-attempting endpoint is a valid endpoint so we
should use it as the last option.
This CL modifies AttemptManager to allow slow-attempting endpoints:
* Change the logic of GetIPEndPointToAttempt(). See the comment of
the method for brief summary.
* Get an IPEndPoint for each attempt. Previously, we used a single
endpoint in the loop of MaybeAttemptConnection().
* Remove redundant pending job/preconnect count checks.
The new logic of GetIPEndPointToAttempt() might be time-consuming,
but for the happy path (we find a non-slow endpoint and an attempt
to the endpoint succeeds) it should be fast enough. As a follow-up,
we could add trace events to see bottlenecks.
For a longer-term, we should have a better logic to select which
IPEndPoint (and transport protocol) to attempt. See the linked bug.
[1] https://ci.chromium.org/ui/p/chromium/builders/try/win-rel/b8728787409034283153/test-results?q=ExactID%3Aninja%3A%2F%2Fchrome%2Ftest%3Abrowser_tests%2FContextMenuBrowserTest.OpenLinkInProfile%2FAll.LinkPreviewDisabled+VHash%3Abdbee181b3e0309b&clean=&sortby=&groupby=
Bug: 383606724,384297912
Change-Id: Ic9c150d98f12a4e4808c5bf63c43a5155f84b4f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088261
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: mmenke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397535}
[CodeHealth] Use base::AlignedHeapArray
This CL replaces backing memory with a standardized AlignedHeapArray.
Bug: 373960632
Change-Id: Ifb20406a4d548e371a7ac9b5131b022779b81ed4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098320
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397534}
Roll llvm-libc from b59bffaa43a2 to 8345f5d50fb8 (1 revision)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/b59bffaa43a2..8345f5d50fb8
2024-12-17 tristan.ross@midstall.com [libc] Add unistd overlay (#119312)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/llvm-libc-chromium
Please CC ayzhao@google.com,lexan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: ayzhao@google.com
Change-Id: I54b2c0f45d62b3156c71ae2452403515b42a9edb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6102540
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1397533}
[MPArch Guest View] Add support for CreateWindow/OpenURL
This change implements create window support and open url handling.
A navigation throttle is added for pending windows that are
unattached. This mirrors the deferred navigation of pending windows
inside the WebContentsImpl for InnerWebContents guests.
BYPASS_LARGE_CHANGE_WARNING
Bug: 40202416
Change-Id: Id68897f418112d2cf4924259aebf1982703190c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6060000
Reviewed-by: James Maclean <wjmaclean@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1397532}
[wv][cleanup] remove ui thread posting in browserprocess.start
This method is only called from startChromiumLocked which is
guaranteed to be called from the UI thread and some tests.
I added an assert too.
Bug: na
Test: webview javatests
Change-Id: I6f890810b2618092f6f904f4c267b62466e9b504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097576
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Commit-Queue: Richard (Torne) Coles <torne@chromium.org>
Auto-Submit: Chidera Olibie <colibie@google.com>
Cr-Commit-Position: refs/heads/main@{#1397531}