Chromium Main Console

CrOS FilesApp: Fix UI tests BUILD outputs

Bug: 888026
Change-Id: Ia5524831cba189f390b650950112e86450c9bcd2
Reviewed-on: https://chromium-review.googlesource.com/1240133
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593459}

memlog: Add task contexts from allocation context to native mode

The task context is useful to debug mojo memory leaks since IPC messages
are tagged with contexts

BUG=874530

Change-Id: Id59d016f963f41fdeda6af69b3c470f0101dbfe7
Reviewed-on: https://chromium-review.googlesource.com/1232683
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593458}

mac: Delete the Cocoa version of the one-click signin dialog.

Bug: 832676
Change-Id: I1c9874f3f0f80bdef3a6cd7351a0504e8c7ad36c
Reviewed-on: https://chromium-review.googlesource.com/1239634
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593457}

Change type of AXTreeID from int to string.

There was a pervasive assumption throughout the code that
AXTreeID was a 32-bit int. This patch switches AXTreeID
to a std::string but doesn't otherwise change the
functionality, with a goal of cleaning up that assumption
everywhere.

As an ultimate goal I'd like to explore using
base::UnguessableToken for AXTreeID, and this is just
the first step. See bug for motivation and details.
Even if we decide not to go that route, I think this
is a worthwhile refactoring either way, to give
us the flexibility to change AXTreeID into any
type later.

Bug: 881986

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic2c45d19ada492fa9c96222fb0666abd750ce1d1
Reviewed-on: https://chromium-review.googlesource.com/1212484
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593456}

Roll src/third_party/freetype/src/ dfddc2d97..abd997aa7 (9 commits)

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/dfddc2d97596..abd997aa7cf2

$ git log dfddc2d97..abd997aa7 --date=short --no-merges --format='%ad %ae %s'
2018-09-21 wl Improve documentation of `FT_LOAD_NO_RECURSE'.
2018-09-21 bungeman Improve auto-hinter handling of bitmap fonts (#54681).
2018-09-21 wl [raster] Fix disappearing vertical lines (#54589).
2018-09-21 wl [base] Some comments.
2018-09-20 apodtele * src/base/ftobjs.c (ft_glyphslot_reset_bimap): Tiny rounding tweak.
2018-09-20 apodtele [pcf] Replace charmap implementation.
2018-09-20 wl [base] Remove unused function `FT_GlyphLoader_CopyPoints'.
2018-09-19 apodtele [pcf] Prepare to replace charmap implementation.
2018-09-18 apodtele Remove unused fields.

Created with:
roll-dep src/third_party/freetype/src
R=bungeman@chromium.org,drott@chromium.org

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng

PDFium-Issue: pdfium:1159
Change-Id: I5640bef8565d2ce1eb1b199245fee8e4e979873c
Reviewed-on: https://chromium-review.googlesource.com/1238775
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593455}

Canvas: Improve CanvasResourceDispatcherTest

This CL adds a new test case to CanvasResourceDispatcherTest, generating
a CompositorFrame and inspecting its contents, specially regarding its
expected opacity, size and |damage_rect|.

For that, it moves the Mock classes landed in crrev.com/c/1228859 to
one level deeper renderer/platform/graphics/test/ so it can be used
from where CanvasResourceDispatcherTest lives. At the same time, it
extracts the hardcoded ASSERT/EXPECT out of it, to be run in the test
cases themselves and finally renames the file to mock_compositor_frame_sink
to better reflect what it does now.

This CL only touches webkit_unit_tests stuff.

Bug: 788439
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6af472f0cc6e80c17bd707f0734ad83a4688d021
Reviewed-on: https://chromium-review.googlesource.com/1238798
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593454}

SuperSize: Fix crash when a class has the same name as a package

This happens for:
com.google.android.play.core.splitcompat.c

TBR=wnwen # Fixing official bots

Bug: 887876
Change-Id: I37ce1fbc6f282228a33311136980aba509ad1eb8
Reviewed-on: https://chromium-review.googlesource.com/1240015
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593453}

mac: Remove views-browser-windows from about:flags

The feature still exists beacuse tests toggle it, but this removes it
from the flags UI.

Bug: 832676
Change-Id: I6971276883e19792f962f9e17d4fa50e8265a1d0
Reviewed-on: https://chromium-review.googlesource.com/1239766
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593452}

mac: Delete Cocoa version of the avatar menu and user manager.

Bug: 832676
Change-Id: I631e54fef31ed42828aabbe674cb67c1e2165763
Reviewed-on: https://chromium-review.googlesource.com/1239764
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593451}

mac: Delete cocoa version of FindBarPlatformHelperMacTest.

Like the uitest change in https://chromium-review.googlesource.com/c/chromium/src/+/1237454

For some reason the CQ didn't catch this issue.

TBR=rsesek

Bug: 832676
Change-Id: Ie58e701f0f7d231432c1636366545ee211c5e712
Reviewed-on: https://chromium-review.googlesource.com/1239761
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593450}

Use URL instead of title in request text

Bug: 326740
Change-Id: I6cbb658b6fed6bdc7bf48700f60d17a02176f65a
Reviewed-on: https://chromium-review.googlesource.com/1239513
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593449}

mac: Remove unused cocoa infobars code.

(NOPRESUBMIT because crbug.com/875886)

NOPRESUBMIT=true
TBR=blundell

Bug: 832676
Change-Id: I94367d0813b7721c6bee355343f17b0f19073a74
Reviewed-on: https://chromium-review.googlesource.com/1239021
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593448}

Updated component for smoothness.ToughPinchZoomCases

Change-Id: I35e9c2a9998d9c648c5eef4d29ad19ab24398e84
Reviewed-on: https://chromium-review.googlesource.com/1239719
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#593447}

Cleanup Certificate Transparency OWNERS files

In line with docs/code_reviews.md, remove the "emeritus" reviewers.

Bug: none
Change-Id: Iea5d729f112faa2648ca207ca912890c271612de
Reviewed-on: https://chromium-review.googlesource.com/1238787
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593446}

mac: Remove unused GradientButtonCell.

Unused now that the cocoa find_bar code is deleted.

Bug: 832676
Change-Id: I9a29167cde164656f6e51182e50ba300fd93419d
Reviewed-on: https://chromium-review.googlesource.com/1239633
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593445}

[blink] Re-enable small script streaming heuristic

Currently, the small script streaming disabled heuristic is disabled for
the scheduled script streaming flag. Remove this for now, so that we can
test the scheduling perf impact independently from heuristic changes.

Bug: chromium:865098
Bug: chromium:866868
Change-Id: Ib3974ebe6d28dadb8421e75fd13801e0d916de24
Reviewed-on: https://chromium-review.googlesource.com/1238435
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593444}

[Dice] Update settings when account image is updated

When the account image is updated in the background,
settings is now notified to make changes accordingly.

Bug: 882384
Change-Id: I05000533de1205fc5b9d9a9500b4c05f088e8923
Reviewed-on: https://chromium-review.googlesource.com/1238501
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593443}

Add missing scrollable attribute to automation.idl

At runtime, the actual list of available attributes
on an AutomationNode can be found at:
chrome/renderer/resources/extensions/automation/automation_node.js

'scrollable' was previously missing from automation.idl.
Its inclusion in the idl correctly matches what is available
at runtime and makes it included in externs.

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I1b78d883cd256d8bbe48272baec5f8fa8ff88423
Reviewed-on: https://chromium-review.googlesource.com/1238821
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593442}

Roll src-internal 738aa56a10f9..fe48d54568d2 (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/738aa56a10f9..fe48d54568d2


Created with:
gclient setdep -r src-internal@fe48d54568d2

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I915347fc46e4c24779b4e2ba852c20ea36ac43b7
Reviewed-on: https://chromium-review.googlesource.com/1239893
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593441}

Revert "Perfetto: Fix trace buffer memory size"

This reverts commit c2747b15b2ba943737eb077e0f6783b3d0710633.

Reason for revert: breaking many loading perf tests

BUG:888222

Original change's description:
> Perfetto: Fix trace buffer memory size
>
> Some unnoticed debug sizing caused the host-side tracing buffer
> to be a bit larger than necessary.
>
> R=​ssid@chromium.org
>
> Bug: 886685
> Change-Id: I56f3ed15952d7f0d6382b6e939c5386169f672b8
> Reviewed-on: https://chromium-review.googlesource.com/1236663
> Reviewed-by: Siddhartha S <ssid@chromium.org>
> Commit-Queue: oysteine <oysteine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593257}

TBR=oysteine@chromium.org,ssid@chromium.org

Change-Id: I6a19cad20042d06bc6ac8406cb1f8ac9d3fa79ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 886685
Reviewed-on: https://chromium-review.googlesource.com/1239077
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#593440}

Roll src-internal de8b7f52c072..738aa56a10f9 (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de8b7f52c072..738aa56a10f9


Created with:
gclient setdep -r src-internal@738aa56a10f9

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ie370693d9e1f4689c7b9892c54d4debc5ffb5ba8
Reviewed-on: https://chromium-review.googlesource.com/1238991
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593439}

Use StyleColor for the flood-color and lighting-color properties

This changes the _interface_ to these properties in ComputedStyle
(and SVGComputedStyle) to use StyleColor - storage is changed to
a <Color, bool> (separated) pair. Usage is updated accordingly.
This is needed in order to support "better" tainting on 'feFlood'
and other filter primitive elements to which these properties apply.
The actual tainting functions will be updated in a follow-up CL.

Bug: 792518
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I705ee38219615c4c691e4a5fbc73799a72b604da
Reviewed-on: https://chromium-review.googlesource.com/797271
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593438}

Revert "[Sherrif] Disable worklet-animation-responsive-to-zoom.html"

This reverts commit 1f654b07812cf771043806cdb4b5e1c0aa7cda64.

Reason for revert:

This test was reverted by https://chromium-review.googlesource.com/c/chromium/src/+/1239773 causing presubmits to fail.

Original change's description:
> [Sherrif] Disable worklet-animation-responsive-to-zoom.html
>
> It wasn't included in TestExpectations by
>
> https://chromium-review.googlesource.com/c/chromium/src/+/1237235
>
> but it looks like it failed all the same.
>
> NOTRY=true
> TBR=majidvp@chromium.org
>
> Bug: 887659
> Change-Id: Iabb8204a4b4b05515838cf20378e61d07062ea51
> Reviewed-on: https://chromium-review.googlesource.com/1239446
> Reviewed-by: Frank Liberato <liberato@chromium.org>
> Commit-Queue: Frank Liberato <liberato@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593345}

TBR=majidvp@chromium.org,liberato@chromium.org

Change-Id: I6bb03b3d8d78f3c7c66132656f00f32ee36e9a21
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 887659
Reviewed-on: https://chromium-review.googlesource.com/1238916
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#593437}

Fix use of deprecated 'Set' method

R=mmenke@chromium.org

Bug: v8:7283, v8:8015
Change-Id: I8f97518eba7a6cc07c91ae4c7763d24b907a6120
Reviewed-on: https://chromium-review.googlesource.com/1238533
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Simon Zünd <szuend@google.com>
Cr-Commit-Position: refs/heads/master@{#593436}

Remove use of deprecated 'Set' method

Bug: v8:7283, v8:8015
Change-Id: I21d6e81d273fb6f321788a6f3e7122d7d63dbf28
Reviewed-on: https://chromium-review.googlesource.com/1238434
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Simon Zünd <szuend@google.com>
Cr-Commit-Position: refs/heads/master@{#593435}

Merge PDF printing paths.

Make PDFiumPrint::PrintPagesAsRasterPdf() and PrintPagesAsPdf()
consistent. Now they both call CreatePrintPdf() to generate a PDF for
printing. The only difference is PrintPagesAsPdf() does an extra
rasterization step.

BUG=887825

Change-Id: I1f02f6acfa5833d33bf999933fa681c10b67ccf9
Reviewed-on: https://chromium-review.googlesource.com/1238077
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593434}

Add PDFiumPrint::CreatePrintPdf() method.

Split most of the code in PDFiumPrint::PrintPagesAsPdf() into a separate
method. CreatePrintPdf() will be reused in an upcoming CL.

BUG=887825

Change-Id: I0e6fee3a6908cee038a45e5a7f62182559f33df4
Reviewed-on: https://chromium-review.googlesource.com/1238076
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593433}

Reorganize some PDFiumPrint code and fix nits.

Reorganize:
- Move NupPdfToPdf() into the anonymous namespace.
- Make NupPdfToPdf() return a PDF instead of the PDF data.
- Return earlier in PrintPagesAsRasterPDF().

- Make CreateSinglePageRasterPdf() return a ScopedFPDFDocument.
- Put |scale_factor| in the smallest possible scope.
- Group static methods together in the header.
- Use "Pdf" consistently in method names.
- Mark some methods const.

Nits:
Change-Id: I25ac995d2041990eab42391915a6736044ad6b63
Reviewed-on: https://chromium-review.googlesource.com/1238075
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593432}

rebaseline pixel tests for enable zoom-for-dsf

remove expectations for rebaseline

Bug: 737777
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If1ba264a039086ca91a4872519e5f34e1fae9591
Reviewed-on: https://chromium-review.googlesource.com/1234996
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593431}

Roll src-internal dc4ede78306c..de8b7f52c072 (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc4ede78306c..de8b7f52c072


Created with:
gclient setdep -r src-internal@de8b7f52c072

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ia51e7b833c254edc7e4ca5150e2b0097805ed765
Reviewed-on: https://chromium-review.googlesource.com/1239739
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593430}

Add UMA for autocomplete

To understand the usage of autocomplete, add metrics for
- if the autocomplete is disabled in WebView by application.
- if the query is triggered for the field.
- if the suggestion exists for the query.

Bug: 873795

Change-Id: If58836c02a78a3fe85b5d264f29417d9a7509969
Reviewed-on: https://chromium-review.googlesource.com/1187824
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593429}

Roll src/third_party/angle 799da6d18c5a..55e57f96fbf8 (2 commits)

https://chromium.googlesource.com/angle/angle.git/+log/799da6d18c5a..55e57f96fbf8


git log 799da6d18c5a..55e57f96fbf8 --date=short --no-merges --format='%ad %ae %s'
2018-09-22 jmadill@chromium.org Remove some redundant dirty bits notifications.
2018-09-21 bryan.bernhart@intel.com ES31: Support atomic functions on D3D11 - Part III


Created with:
gclient setdep -r src/third_party/angle@55e57f96fbf8

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ifbb4d1e192b68d3761a69e7cf6632ca04eda7570
Reviewed-on: https://chromium-review.googlesource.com/1239735
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593428}

Increase one pixel test revision number

missed Pixel_WebGLTransparentGreenTriangle_NoAlpha_ImplicitClear
when rebaselining pixel tests for zoom-for-dsf

TBR=kbr@chromium.org

Change-Id: I439e2e3d389735e2add7a993a4b5a67df517c1a1
Reviewed-on: https://chromium-review.googlesource.com/1239476
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593427}

Roll src/third_party/SPIRV-Tools/src 575af7ecfc21..90a12b3d4d1d (2 commits)

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/575af7ecfc21..90a12b3d4d1d


git log 575af7ecfc21..90a12b3d4d1d --date=short --no-merges --format='%ad %ae %s'
2018-09-22 alanbaker@google.com Decoration validation for Vulkan memory model
2018-09-22 alanbaker@google.com Validate vulkan mem model capabilty


Created with:
gclient setdep -r src/third_party/SPIRV-Tools/src@90a12b3d4d1d

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ida46ddd3a867db7a96ad07046f0a9937f34ecca1
Reviewed-on: https://chromium-review.googlesource.com/1238990
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593426}

Roll src/third_party/depot_tools 0dc1fa046374..baf09271514c (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0dc1fa046374..baf09271514c


git log 0dc1fa046374..baf09271514c --date=short --no-merges --format='%ad %ae %s'
2018-09-21 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
gclient setdep -r src/third_party/depot_tools@baf09271514c

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I21a9cc3df3f0b41b8ca7939e203dd6661fef7ac5
Reviewed-on: https://chromium-review.googlesource.com/1239655
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593425}

Update V8 to version 7.1.163.

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8994403e..2f22d111

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I33f96a3637ec00461294c67acb3a34a06ef7c3bb
Reviewed-on: https://chromium-review.googlesource.com/1239723
Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593424}

Roll src-internal 80aef02c3e0f..dc4ede78306c (2 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80aef02c3e0f..dc4ede78306c


Created with:
gclient setdep -r src-internal@dc4ede78306c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:888064
TBR=mmoss@chromium.org

Change-Id: I90a010aa42ca43fcd267d8ba6aa516e18f2a66da
Reviewed-on: https://chromium-review.googlesource.com/1239738
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593423}

Updating trunk VERSION from 3559.0 to 3560.0

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: I5dbd53b4addb170c9971034bb125363e0be6e678
Reviewed-on: https://chromium-review.googlesource.com/1239754
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593422}

[Android WebAPK Refactor] Minimize code in MainActivity.java 5/X

This CL:
- Makes code in MainActivity.java more modular.
- Splits HostBrowserLauncher into:
- a part for selecting the host browser
- a part for launching the host browser

This CL is in preparation for:
- Introducing a version of MainActivity.java for NewSplashWebApk.apk
- Implementing the logic to determine whether to show the splash screen
inside of the WebAPK or inside of Chrome. The host browser must be known
in order to make this decision.

BUG=817263

Change-Id: I024e390c57b4da09fe0e4e2fcbaf616c6bad2e8b
Reviewed-on: https://chromium-review.googlesource.com/1220054
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593421}

Remove unused Chrome automation api

The Chrome channel was once used by ChromeVox to disable ChromeVox Classic (use ChromeVox Next) when in dev channel. Since ChromeVox/ChromeVox Next now ships by default everywhere, this is no longer necessary.

Original change
https://codereview.chromium.org/2640503002

TBR=dcheng@chromium.org

Change-Id: I0b9b4f844ec5d3b40171027da5e04e0fb248eb49
Reviewed-on: https://chromium-review.googlesource.com/1239439
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593420}

Add field to TLSClientSocketOptions to request SSLInfo.

The only previous way to get it was to disable cert verification.

Bug: 848078
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ic14d5273a803cb53e92bbc370a16f045c86bdcca
Reviewed-on: https://chromium-review.googlesource.com/1235173
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593419}

Roll src/third_party/catapult 32261ee689fe..218f46686f2f (1 commits)

https://chromium.googlesource.com/catapult.git/+log/32261ee689fe..218f46686f2f


git log 32261ee689fe..218f46686f2f --date=short --no-merges --format='%ad %ae %s'
2018-09-21 benjhayden@chromium.org Fix a bug in v2spa's setImmutable()


Created with:
gclient setdep -r src/third_party/catapult@218f46686f2f

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia6435354eb716e7ec8d26a3324c9f77d6b33cd87
Reviewed-on: https://chromium-review.googlesource.com/1238872
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593418}

v8binding: Do not invoke FrameRequestCallback when iframe is detached.

Crash issue 887661 is happening because an iframe is detached, but
the iframe is still invoking FrameRequestCallback without performing
wrapper-tracing.

In the repro case, callback function's realm = the parent's one, and
the incumbent realm = the parent's one, however, the callback is
registered on the iframe that will be detached. Thus, any check
against callback function's realm and the incumbent realm does not
work well in this case.

This patch fixes the crash issue by checking the execution context
on the call sites.

Bug: 887661
Change-Id: I1fa784add95424c9ff2c2b27ed3d2edbb920068e
Reviewed-on: https://chromium-review.googlesource.com/1237839
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593417}

[Android WebAPK] Treat "false" GN parameter as False in pystache

This CL changes the manifest_processor GN build rule to treat
'false' as a boolean value instead of as a string literal. This
change is needed for the manifest_processor build rule to omit the
'section_name' section for the following input:

BUILD.gn:
manifest_processor_template(_manifest_target_name) {
...
extra_variables = [ "section_name=false" ]
}

AndroidManifest.xml:
{{#section_name}}
Never shown!
{{/section_name}}

BUG=1220054

Change-Id: I9bf0740e0cfb8115788ec3bf8d6d0640d2c495c7
Reviewed-on: https://chromium-review.googlesource.com/1238354
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593416}

Add support for UpgradeToTLS to TCPBoundSockets.

Previously it would just fail. Also fix a bug in the
ERR_NOT_IMPLEMENTED failure when trying to upgrade accepted client
sockets to TLS.

Add tests for both cases.

Bug: 848078
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia908a7da077a14c69ae990afe19339dfa440b9a5
Reviewed-on: https://chromium-review.googlesource.com/1234226
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593415}

Revert "[animation-worklet] Transfrom related worklet animations should respond to zoom"

This reverts commit dec72e86b3c1d8dd4de2bb033fc551cc25b63ce8.

Reason for revert:
virtual/threaded/fast/animationworklet/worklet-animation-responsive-to-zoom.html seems to be failing most of the time on all platforms.

Sample failures:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/91172
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/146546
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/193114

Original change's description:
> [animation-worklet] Transfrom related worklet animations should respond to zoom
>
> Worklet animation compositing state should be updated when a zoom or viewport
> resize changes css pixel to dip ratio.
>
> The fix is to simply match what we already do for regular animations for worklet
> animations.
>
> TEST=virtual/threaded/fast/animationworklet/worklet-animation-responsive-to-zoom.html
>
> Bug: 879107
> Change-Id: I0b74bd8297e83b18afd087247f09339aedcc618b
> Reviewed-on: https://chromium-review.googlesource.com/1237133
> Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Commit-Queue: Majid Valipour <majidvp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593171}

TBR=majidvp@chromium.org,smcgruer@chromium.org

Change-Id: I9eaf621c931ad9003fd7413aeea9f2ec3a7824a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 879107
Reviewed-on: https://chromium-review.googlesource.com/1239773
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593414}

Remove support for obscure containers and codecs from WebView.

Usage is low, WebView now has a policy of unifying with Chrome,
and this path represents a security risk since it provides a
direct route Android MediaPlayer in the browser process instead
of using the renderer sandboxed media player.

Removing per discussion with webview-leads@.

BUG=881997
TEST=none

Change-Id: I244277eb26a7de780b61dd92c945379d800ed514
Reviewed-on: https://chromium-review.googlesource.com/1213968
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593413}

Roll src-internal 0d9c87bf4dc0..80aef02c3e0f (2 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d9c87bf4dc0..80aef02c3e0f


Created with:
gclient setdep -r src-internal@80aef02c3e0f

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I6adad6e0b4307ae70b231c7b54e94f0f60206c83
Reviewed-on: https://chromium-review.googlesource.com/1239656
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593412}

Assistant: Add UMA for container view animation

This patch adds UMA to measure assistant container view's animation
smoothness.

Bug: b/113942916, 887583
Test: see UMA in histograms.
Change-Id: I83da71c4c0003061f5ca852a6128534a681646d3
Reviewed-on: https://chromium-review.googlesource.com/1234956
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593411}

cc: Set shader id when reading PaintShader

This doesn't really matter, but for consistency we should set this, so
that writing out the PaintShader yields the same PaintShader when
reading it back. This fixes a fuzzer bug.

Bug: 883217
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I25488ce92fa8259c4be9974d0fdf4422e65b60ac
Reviewed-on: https://chromium-review.googlesource.com/1239544
Commit-Queue: enne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593410}