Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
Add `kMaxNumberOfLogs` constant to replace inline value
Bug: none
Change-Id: I79b753407833093dcfcb9e1bee1f4881aeb15f11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6333555
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Louis Romero <lpromero@google.com>
Commit-Queue: Louis Romero <lpromero@google.com>
Cr-Commit-Position: refs/heads/main@{#1429425}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1741336433-6a2a960977fee52408df57305860e89b52895162-ecd5e9a3e0a0ef601cfca820d5ced0e4b18b4b09.profdata to chrome-android64-main-1741340924-7523b92db596a516cb6aa935256f7f1a05d06312-e0cc64d87c01fd9843f967e4ddbaa2a82e4084f6.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I15c381019ba3f327fb426cb69e7d55efbf52a15b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6334607
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429424}
[UPMLoginDbSunset] Wire dialogs to the GPM entrypoint in settings
There are 4 types of dialogs wired as follows:
1. No Google Play Services and no auto-exported passwords (PasswordManagerUnavailableDialog)
2. No Google Play Services, but auto-exported passwords exist (PasswordsDownloadCsvFlow)
3. Outdated Google Play Services and no auto-exported passwords(PasswordManagerUnavailableDialog with update option).
4. Outdated or up-to-date Google Play Services and auto-exported passwords (PasswordsDownloadCsvFlow different text than 2)>
If the auto-export is ongoing, no UI will be shown.
Bug: 378653267
Change-Id: Ifdd556f707088c14ecbada2affe602ae929d7729
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6326695
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich Hauser <friedrichh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429423}
updater: use a secure temp directory as the backup directory in setup
Fixed: 400740865
Change-Id: Icf2135265e40818354c595a0a90c304b87f156a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330882
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Auto-Submit: S Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429422}
Roll Projector App from loo9tq5NBW1gSz0lp... to P96kvRfO660NoVOto...
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_202503070100_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/P96kvRfO660NoVOtorfWGNgZ4lqB1WIV_VahAGg0jhkC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll
Please CC cros-projector-oncall@grotations.appspotmail.com,cros-projector@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: cros-projector-oncall@grotations.appspotmail.com
Change-Id: I4555c10ba8a868f4e8c802ae3a580c27b7830daa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6334723
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429421}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1741305580-8f99533dd339a33dd9defea2c29868857f95d346-078d124163d5c675c22d45b06cc78aa60aaef9f7.profdata to chrome-win64-main-1741316299-23a198c7604c63a69c17d001c4c726a867eedbed-cc50c5a3f4f70e23c7ff534acf28dac549955775.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ide1c5ef719ba7512f5a81a0e708e33f38206df06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6335223
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429420}
Roll ios_internal from 855885155b3c to cfe781f65286
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/855885155b3c..cfe781f65286
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC cheickcisse@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I7073acdf1e674d65df2062c5c2be0909c166308e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6334725
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429419}
[Permissions AI] Let PermissionsAiHandler unsubscribe
Because we set a member variable in a wrong way, we do not unsubscribe
from the OnDeviceModelServiceController in the destructor. This commit
fixes this by only setting the respective member to false after we
unsubscribe.
Bug: 399860232
Change-Id: Id39038a2eb76d339466a6a9708450f20822fc209
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330750
Reviewed-by: Elias Klim <elklm@chromium.org>
Commit-Queue: Judith Hemp <hempjudith@google.com>
Cr-Commit-Position: refs/heads/main@{#1429418}
[PA] Add EnsureThreadCache() for blocking thread cache creation
`GetOrCreateThreadCache()` may return `nullptr` if another thread is
creating a thread cache instance.
This patch adds `EnsureThreadCache()` to create and get an instance
more reliably, by blocking the execution till other threads complete
thread cache creation.
To achieve that synchronization/reentrancy detection mechanism is
changed from `std::atomic` to `PartitionLock`. Its "try_lock` can be
slightly more costly, however, given thread cache creation happens
at most once per thread it should not be performance-impacting.
Bug: 351974425
Change-Id: I9149960e34260c8bfc40eb00813e7da016cf3265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6210815
Commit-Queue: Mikihito Matsuura <mikt@google.com>
Reviewed-by: Benoit Lize <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429417}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1741334182-ca085755f70097038db3b14a97fc1653d569c359-d3e1fd3a8cecbc53b08ef9e19a2e2153528dad42.profdata to chrome-mac-arm-main-1741341472-f0a17e0c96721f6894dbde19f4f919133cc3eaf4-ab1d7e35afb28681483b5e628c1ab18df95aed09.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Id5b8445a24d21a2df68b3e9c2527dd241e73e247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6335492
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429416}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1741305580-d3fb557df0e390eff6668d64b23bd2cd354e4b53-078d124163d5c675c22d45b06cc78aa60aaef9f7.profdata to chrome-win32-main-1741316299-5c544e097521a169526df2165a8377145aad013b-cc50c5a3f4f70e23c7ff534acf28dac549955775.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I752c4079021b22eb091456abe0b288f35dda7341
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6334815
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429415}
recorder: Provide language options for large gen ai model
Based on feature release decision, we need to hide language options
since it's new feature. Devices with large gen ai model are exception.
Bug: b:401440675
Test: manually - disable conch-expand-transcription-language
Change-Id: Ie49b65083524fd6f58b96eccc2bc706fb378a250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6335185
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>
Commit-Queue: Jennifer Ling <hsuanling@google.com>
Cr-Commit-Position: refs/heads/main@{#1429414}
Delete absl internal if_constexpr
to match abseil at head
Bug: chromium:398801447
Change-Id: Id5f80e850aacac666de7dcccac15d6b694e1c119
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6333170
Auto-Submit: Danil Chapovalov <danilchap@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429413}
[enrollment] Remove legacy code from AutoEnrollmentTypeChecker
Unified State Determination (USD) fully replaces legacy state
determination since M131.
As a result, enrollment state determination is to be expected during
OOBE irrespective of FWMP or VPD. It will run unless disabled by command
line switch.
This CL therefore
- removes legacy code for determining the enrollment type
- migrates the TPM firmware update code from using the obsolete
AutoEnrollmentTypeChecker::GetFRERequirementAccordingToVPD() to
policy::AutoEnrollmentTypeChecker::IsEnabled().
Cq-Include-Trybots: luci.chromium.try:linux-chromeos-rel
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: 383047722
Change-Id: Id821ed90f32e5d75ce5b48bcea73b716470f737a
Tests: Remaining, new, and refactored unit tests
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330676
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Roland Bock <rbock@google.com>
Reviewed-by: Artem Sumaneev <asumaneev@google.com>
Cr-Commit-Position: refs/heads/main@{#1429412}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1741334095-ae0802471837aeb83f2c3acccde1947edb83d731-c76fe2e0a42c4c63be6aae44d94cc98d7796c987.profdata to chrome-android64-main-1741336433-6a2a960977fee52408df57305860e89b52895162-ecd5e9a3e0a0ef601cfca820d5ced0e4b18b4b09.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I2b468eb70de3e428c3accbfe45e31776d7c85c78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6335337
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429411}
[extensions] less strict CT in verifyTLSServerCertificate
This fix is related to
https://chromium-review.googlesource.com/c/chromium/src/+/6196859
In the cl above I have renamed VerifyCertForSignedExchange -> VerifyCert
thinking that the behavior has nothing specific to SignedExchange (SGX).
As mattm@chromium.org pointed out SGX have stricter CT verification.
Compare the following almost identical code:
https://crsrc.org/c/net/socket/ssl_client_socket_impl.cc;drc=20799f4c32d950ce93d495f44eec648400f38a19;l=1175
https://source.chromium.org/chromium/chromium/src/+/main:services/network/network_context.cc;drc=58fb75d86a0ad2642beec2d6c16b1e6c008e33cd;bpv=1;bpt=1;l=1732?gsn=CheckCTRequirements&gs=KYTHE%3A%2F%2Fkythe%3A%2F%2Fchromium.googlesource.com%2Fcodesearch%2Fchromium%2Fsrc%2F%2Fmain%3Flang%3Dc%252B%252B%3Fpath%3Dservices%2Fnetwork%2Fnetwork_context.cc%231BS5z2OmuEs-qsnFGg_csnxBM8OxwZDyDv74cEaGHm4
They have difference that in SGX mode if CT verifier returns
net::TransportSecurityState::CT_NOT_REQUIRED then failure might happen
in certain conditions.
For platformKeys.verifyTLSServerCertificate we don't need such strict
CT, we would like to have it as usual WebSite https verification.
Design doc is updated accordingly for history
https://docs.google.com/document/d/1jiX_rQf352WWmtkteZFqNxjoNgVDXntVWSHsZlpp5Ts/edit?tab=t.0
Low-Coverage-Reason: OTHER
Bug: 399859278
Change-Id: Ia5ae90fd4927d3f2a9f19c6aa879aa5a384e41c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6308831
Reviewed-by: Andrew Rayskiy <greengrape@google.com>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Vlad Krot <vkrot@google.com>
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429410}
Devtools protocol for DirectSocket #1
Changes are behind experimental runtime flag. This is first out of many
future CL's.
The CDP implemented only for TCPSocket (UDPSocket will be in future).
Individual messages are TBD also. This allows us to display Connection
Info, Initiator, Timing tabs and the connection itself. Error state is
also included.
The dependency of Chromium -> devtools_frontend will be updated in the
future CL's.
The related CL in devtools
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6316791
The design doc go/chrome-devtools:directsockets-design
I will explore adding tests in the next CL's. Current plan for test is
to only check if DirectSocket connection is added. For the most part,
the feature will be tested manually.
Low-Coverage-Reason: TESTS_IN_SEPARATE_CL
Bug: 358327120
Change-Id: I8322a06bd0d643b5a4db4eb513d32d4326428abb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6308994
Commit-Queue: Vlad Krot <vkrot@google.com>
Reviewed-by: Andrew Rayskiy <greengrape@google.com>
Cr-Commit-Position: refs/heads/main@{#1429409}
bluetooth: Update Bluetooth Device Emulation APIs in CDP
This CL updates Bluetooth Device Emulation APIs in CDP:
- Adding a new parameter of leSupported to BluetoothEmulation.enable for configuring low-energy support.
- Adding a new API to update the simulated central state.
Bug: 398026399
Change-Id: I212072f63c337a0347e54b071c8f99d55b6d6f95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6305026
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Jack Hsieh <chengweih@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429408}
volume_manager_unittest: Make Event fields optional
Turn LoggingObserver::Event fields into optional. That prevents them
from being used by mistake when they are not set.
Also modernise two for loops.
Bug: None
Change-Id: I80375924f829dc123eaef4b82133deadf4bac4c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6328605
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Commit-Queue: Ivan Å andrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429407}
Roll DevTools Frontend from 01bd06c67340 to cd948cc43950 (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/01bd06c67340..cd948cc43950
2025-03-07 alexrudenko@chromium.org [AI Assistance] restrict how many changes can be made
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: Ib4339bbb2718bb62211f18e0376718dd58cd0ee0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6335328
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429406}
Roll WebGPU CTS from fe6ac50b9764 to b9f6db2a2a2b (11 revisions)
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/fe6ac50b9764..b9f6db2a2a2b
2025-03-07 github@greggman.com Make selectDeviceXXX unreachable on AllFeaturesMaxLimitsGPUTest (#4270)
2025-03-07 github@greggman.com Add labels to command encoders (#4271)
2025-03-07 github@greggman.com Refactor shader/validation/expression/overload_resolution.spec.ts (#4269)
2025-03-07 github@greggman.com Refactor webgpu/examples (#4268)
2025-03-07 github@greggman.com Refactor shader/execution/* (#4266)
2025-03-07 github@greggman.com Refactor shader/execution/expression/call/builtin/texture* (#4267)
2025-03-07 github@greggman.com Refactor api/operation (#4265)
2025-03-06 github@greggman.com Return mismatched device holder to the mismatched device pool (#4264)
2025-03-06 github@greggman.com Add comment case to WGSL enable test. (#4262)
2025-03-06 github@greggman.com Fix shader/validation/types/textures (#4261)
2025-03-06 github@greggman.com Fix shader/execution/expression/call/builtin/textureSampleBias (#4263)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll
Please CC dsinclair@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel
Bug: None
Tbr: dsinclair@google.com
Change-Id: I02199f267a1dcfac58c6187249cd35ee5cc394de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6334024
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429405}
kiosk: Remove kiosk_enterprise_browsertest.cc
The two remaining tests in this file are already covered in
splash_screen_browsertest.cc.
HittingNetworkAcceleratorShouldShowNetworkScreen
==> SplashScreenTest.NetworkShortcutWorksOnline
LaunchingAppThatRequiresNetworkWhilstOfflineShouldShowNetworkScreen
==> SplashScreenTest.DisplaysNetworkScreenUntilOnline
Bug: 379246208
Change-Id: I65a4337d7d34d0232f25871ecbae33be7c21bbcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6329629
Reviewed-by: Polina Bondarenko <pbond@chromium.org>
Commit-Queue: Edman Anjos <edman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429404}
Fix database issue with credentials
Before: When updating log in if there was no change, leaked credentials and password notes table was not updated.
Now: When updating log in even if there is no change, if leaked credentials or password notes changed database is updated
Change-Id: I9fbfed4363b315aed1162e2981613113634a6d9a
Bug: 397626486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6309382
Commit-Queue: Fiorella Barrientos Villalta <fiorellab@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/main@{#1429403}
[Extensions UNO] Don't require improved signin flag for signout dialog (account ext)
Forgot to "override" the "isImprovedSigninUIEnabled" flag check if there
are account extensions...
Bug: 400891059
Change-Id: I68b367307c9ce4ca6803e5aaed0a2eab3d26cac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6334099
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429402}
[iOS] Cancel search when switching TabGrid panel
It shouldn't be possible, but it is doable with the right timing
(swiping while opening the search).
Fixed: 399429863
Change-Id: Ie3539c7321842553ac14e331a226987afec7541e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6333182
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Aliona Dangla <alionadangla@chromium.org>
Commit-Queue: Aliona Dangla <alionadangla@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429401}
Shrink the corpus for net_pickle_fuzzer
The size of the seed corpus for net_pickle_fuzzer seems to be causing
disk full problems on the chromeos-amd64-generic-rel-gtest bot. In
practice the fuzzer should only need a subset of these files to be able
to reconstruct the rest.
Delete the largest 50% of the files. This reduces the size of the corpus
by about 1MB.
BUG=399562754,382394774
Change-Id: Iaaff484af58322232fe398045b28a0ff97168119
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6332877
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429400}
Remove `clear-undecryptable-passwords` flag from UI
Bug: 400504644
Change-Id: Ifd4c30f53e912640e5c0f6a48a4a6906b15747ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330142
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Karol Sygiet <sygiet@google.com>
Cr-Commit-Position: refs/heads/main@{#1429399}
Add null pointer checks in blink::RTCStatsToIDL
I've not been able to reproduce the crash in crbug.com/398077421 with a custom build. But it was reproducible with Chrome Canary. The crash log indicate that there was a null pointer reference in blink::RTCStatsToIDL. I add null pointer checks to avoid the crash.
Since I couldn't reproduce the issue with a custom build, I can't verify this fix. We will check Google Canary builds if the issue remains or not.
Bug: 398077421
Change-Id: I6854fb896e5a6453bed961f434efab84b6867ee6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330298
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Olov Brändström <brandstrom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429398}
Roll Boca App from kKa9wOil7YliEcrsz... to w8wLY2wMulR3_GSkp...
Release_Notes: http://go/boca_app-x20/relnotes/Main/boca_app_202503070100_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/boca_app/app/+/w8wLY2wMulR3_GSkpzuuM_9c318XGQAb8DnSS51XuK4C
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/boca-app-chromium
Please CC aprilzhou@google.com,bzielinski@google.com,cros-edu-eng@google.com,dorianbrandon@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Boca App: https://b.corp.google.com/issues?q=status:open%20componentid:1568002
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: b/397716014
Tbr: aprilzhou@google.com,bzielinski@google.com,dorianbrandon@google.com
Change-Id: Iede33355209436c7324f0548ab60e6d8f9524055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6334025
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429397}
[iOS][OR] Add omnibox mutator and controller delegate
Add OmniboxMutator and OmniboxTextControllerDelegate in preparation for
logic move between classes.
Bug: 400330673
Change-Id: I67643326135ec012addcf34afc4278fcd50c632b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6320734
Commit-Queue: Ameur Hosni <ameurhosni@google.com>
Auto-Submit: Christian Xu <christianxu@chromium.org>
Reviewed-by: Ameur Hosni <ameurhosni@google.com>
Cr-Commit-Position: refs/heads/main@{#1429396}
Roll clank/internal/apps from 062deb0b14dc to 7f702118e51d (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/062deb0b14dc..7f702118e51d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,rubindl@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: rubindl@google.com
No-Try: true
Change-Id: If569a5ac9fb374fe8bbc3692f0b3dd97352c5a9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6334605
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429395}
Remove speculative RFH CHECK when recording wasted RFH metrics
Apparently it's possible for the AssociatedRFHType to be SPECULATIVE but
the speculative RFH is gone. This CL makes it so that we don't CHECK
for the existence and gate some recording of metrics that needs the
speculative RFH's SiteInstance with an existence check.
Bug: 401175298
Change-Id: Ib92104cc8c9f5541314344e6275ad5ec55b0324a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6332453
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Auto-Submit: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429394}
Avoid sync paused when "Clear Cookies on Exist" in enabled
The explanation text for "Clear Cookies on Exist" setting states that
the user will not be signed out of their Google account when they are
signed in to Chrome:
https://drive.google.com/file/d/1RQOwCPggxAxl5GyG9ZDQG9pM31Uo0lP1/view?usp=sharing
Syncing users are also signed in to Chrome, so the string above
applies to them as well. The current behavior to invalidate the refresh
token for the primary account and put the profile in a Sync Paused state
does not match the subtitle.
This CL changes the behavior and ensures that the refresh token of the
primary account is not revoke on restart when "Clear Cookies on Exist"
is enabled.
Bug: 397937746
Change-Id: I1e1948d1a0dd275e226562764d20b9931f0e6adb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6322210
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429393}
Roll ANGLE from 3daf60f752b9 to d7538152f59d (2 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/3daf60f752b9..d7538152f59d
2025-03-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7cf51f2bf4b0 to c86846c05457 (554 revisions)
2025-03-07 mpdenton@chromium.org WGSL: Output samplers, including samplers from structs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,solti@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: solti@google.com
Change-Id: I340b95f7d971b0db77f68b5e72b7be149572fc01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6335129
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429392}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1741331462-50334eb7cc74df32c0adf22e8d1fdb4aa6637742-57231475cc116c8bf30d2590da43471ce248609c.profdata to chrome-android64-main-1741334095-ae0802471837aeb83f2c3acccde1947edb83d731-c76fe2e0a42c4c63be6aae44d94cc98d7796c987.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ic8fd750670ab7644e0e80e5f80d31fe553b020db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6333396
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429391}
webrtc uma: add enum value for opus CBR munging
repurposing the unused value of 67. WebRTC CL:
https://webrtc-review.googlesource.com/c/src/+/379460
BUG=webrtc:40567530
Change-Id: I63006a8a317a9441549a8c1e87ced9119657ad50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330118
Reviewed-by: Johannes Kron <kron@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/main@{#1429390}
[ios] Prevent re-entrancy crash in AccountProfileMapper::Assigner
Deleting a profile will modify the ProfileAttributesStorageIOS.
Prevent re-entrancy issue in AccountProfileMapper::Assigner by
setting `is_updating_profile_attributes_storage_` to true when
marking the profile for deletion.
Fixed: 400903555
Change-Id: I0cf0f94a6258522a0ea5b22904a8078e3f4c126d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330684
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429389}
Roll Skia from cc74d34e7e68 to 79f8af105a61 (2 revisions)
https://skia.googlesource.com/skia.git/+log/cc74d34e7e68..79f8af105a61
2025-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9bdc6763a131 to 0cdbc7814e59 (7 revisions)
2025-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 95322781656f to ef26b90ad02e (17 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: michaelludwig@google.com
Change-Id: Ib22b866ec36d1d53ee6ccf5b975ddc369e9db4e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6334822
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429388}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1741305580-52790d1fac1d1ca5c81ff7ea0ac5f20b06ef960e-078d124163d5c675c22d45b06cc78aa60aaef9f7.profdata to chrome-mac-main-1741326576-e07cef443d50281061947456fce7bc4ee2ef35be-554089b8bc0e9093ff04575bad7f1e82aa1bc84d.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I3bccb488ec3bf4c201ead119bb7dcebbf1b733b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6334549
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429387}
MediaApp: Fix clipboard failures.
The copy feature of remove background tool in Gallery app is not working on device.
The error message suggests it is about Clipboard API permission so added 'clipboard-write' to the allow attribute of the iframe.
Bug: b/399372320
Change-Id: I0f904c240c8bd0df24841103af996c461c3fe97c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6326051
Reviewed-by: Patti Lor <patricialor@chromium.org>
Commit-Queue: Jason Chang <jasonccchang@google.com>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429386}
[ios] Fix a use-after-free when deleting a profile
Unexpectedly, base::BindOnce(...) allow binding an std::string_view
which is unlikely to be valid when the callback is invoked. This
resulted in use-after-free and a crash when invoking the callback.
Change the type of the parameter of the bound method to a const
reference to an std::string to ensure that a copy of the string
is captured.
See https://crbug.com/376675478 for a bug about this flaw in the
base::BindOnce(...) API.
Bug: 400903555
Change-Id: Ie60aff50c7235c8e11e821ede781efc5edffcd5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330164
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429385}
[Frameworks roll] Roll to 734435959 piper revision
Change-Id: Ia3bf69bc64cba4d2368cf5f8e4212d84059fd84e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6335146
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1429384}
recorder: Remove conch flags from chrome://flags
Remove by-default enabled `ConchExpandTranscriptionLanguage` and
`ConchGenAi` from chrome://flags, and remove `ConchLargeModel` since
letting users change its value will lead Recorder to request unavailable
model.
Bug: b:401440675
Test: manually - Flags are removed in chrome://flags
Change-Id: I6a18c293657d3152cdf71deb17804b617473328e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6332875
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>
Commit-Queue: Jennifer Ling <hsuanling@google.com>
Cr-Commit-Position: refs/heads/main@{#1429383}
[iOS][SK] Fix recent activity cells
This CL fixes the Recent Activity in the TabGroup by storing the tab
group and not adding the avatar if there is no user related to the
activity.
Also, the avatar would come from either the triggering_user or the
affected_user.
Bug: 401205488
Change-Id: Ie1a03bef140dfc86e05b7e883571216f02523fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6333608
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Louis Romero <lpromero@google.com>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429382}
heap: HeapLinkedStack -> GCedHeapLinkedStack
The collection was only ever used as GCed type. Adjust naming to fit
with the other collections.
Bug: 392817527
Change-Id: Ie60746f0ce426795557ef3bb9e3fafc3a9a2d3c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330261
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429381}
heap: HeapLinkedHashSet: Separate GCed from DISALLOW_NEW type
This separates HeapHashCountedSet into two separate types:
- HeapLinkedHashSet: For use on stack and in-object fields.
- GCedHeapLinkedHashSet: For dynamically allocating with
MakeGarbageCollected().
Bug: 392817527
Change-Id: Ia864b65889f0188fc0a17c5c998e593a2892b3d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330397
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429380}
[A11yPerformance] Add load_accessibility:tech:codesearch:2025 system health story
This CL was created automatically with tools/perf/update_wpr script
R=johnchen@chromium.org
Change-Id: Ifc3080dc5e873a6b6690f7837e0f0c72786fe048
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6310038
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429379}
Prefetch: Bump net::RequestPriority for embedder triggers
Since embedder triggers are typically started by the strong signal
(e.g., the browser's decision) we can consider giving higher request
priority by default.
Later we can introduce an interface to allow custom the priority value
for each triggers, depending on their needs or situation.
Bug: 353628437
Change-Id: Id6122b43f8bbec7d95c6ba11dd489363a16cd7aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6328798
Auto-Submit: Taiyo Mizuhashi <taiyo@chromium.org>
Commit-Queue: Taiyo Mizuhashi <taiyo@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429378}
[iOS] PolicyUI: Fix incognito crash
PolicyUI::ShouldLoadTestPage() uses the AuthenticationService, which is
null for incognito profiles. This CL changes it to use the original
profile for fetching the AuthenticationService.
Bug: 399731102, 399878534
Change-Id: I8b4de09d22e015be8bfa959423b70c0584078ab2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330680
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429377}
Enable PageMarginBoxes runtime feature forever.
Remove the feature flag.
Bug: 40341678
Change-Id: I883d06941fe0c6e9a2dabdea66aed5615d55ce47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6333416
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1429376}