Chromium Main Console Console

pmeuleman@chromium.org

Remove unused method GetSecondaryAccountsForSignedInProfile
Follow up of https://crrev.com/c/1569716

Bug: 953251
Change-Id: I6b441d72c673381236dbef1b0794a3a56c49da26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575579
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652537}

michaelpg@chromium.org

Fix more AppListController checks

When using Kiosk Next Shell, AppListController might not exist.
Also adds tests for these cases.

Bug: 954317
Change-Id: I5da308b5be540f56d11136c0456b455654f6da98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574952
Auto-Submit: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652536}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll src/third_party/swiftshader 7dd3889f2cf7..97035bde89e6 (2 commits)

https://swiftshader.googlesource.com/SwiftShader.git/+log/7dd3889f2cf7..97035bde89e6

git log 7dd3889f2cf7..97035bde89e6 --date=short --no-merges --format='%ad %ae %s'
2019-04-19 bclayton@google.com Switch SIMD::Pointer::base from a Float* to Byte*
2019-04-19 bclayton@google.com SpirvRoutine: Use SIMD::Pointers for pointers map.

Created with:
gclient setdep -r src/third_party/swiftshader@97035bde89e6

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@chromium.org

Change-Id: Ie4c274226844bec100f5bc5b77f09635f4bc69b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575642
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652535}

ellyjones@chromium.org

flags: remove enable-webrtc-srtp-encrypted-headers

Per email discussion, we aren't interested in shipping this feature any time
soon.

Bug: 954201
Change-Id: I28b4701d1f7fd9e56f1ced71d6eb3fb1d886ed57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572706
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652534}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll src-internal f9096e11484e..3126b113b51e (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9096e11484e..3126b113b51e

Created with:
gclient setdep -r src-internal@3126b113b51e

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org

Change-Id: I4a33e042acf212c977cc4b3788740efcdab2d557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575638
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652533}

manukh@chromium.org

[omnibox]: Dedupe zeroSuggest provider classification.

This is the 11th refactoring CL aimed at reducing duplication and
inconsistency for classifying omnibox results.

ZeroSuggest suggestions to not match user text or bold their texts.
Their contents are styled URL; their descriptions are styled NONE.
Previously, `ClassifyLocationInString` was invoked with trivial
parameters in order to create these length 1 (or length 0 for empty
text) classifications.

With this CL, we instead use the recent `ClassifyTermMatches` method.
This doesn't reduce complexity but helps moves towards using the same
methods for all providers' classifications.

Bug: 366623
Change-Id: Ie91c6b595776c5d46bb4f6700a938216dea2bbd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573811
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652532}

fkastenholz@chromium.org

Roll src/net/third_party/quiche/src/ 2c5386eab..3f0f67930 (15 commits)

https://quiche.googlesource.com/quiche.git/+log/2c5386eab92a..3f0f679307af

$ git log 2c5386eab..3f0f67930 --date=short --no-merges --format='%ad %ae %s'
2019-04-18 dschinazi Fix compilation of QUIC transport_parameter_test on Windows
2019-04-18 ianswett Override << for QUIC's LostPacket Struct to make failing tests easier to debug. No functional change, not flag protected.
2019-04-18 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_set_transmission_type_for_next_frame.
2019-04-18 fkastenholz Make a number unsigned in order to compile in Chromium
2019-04-18 fkastenholz Make test target unsigned so that it compiles on chromium.
2019-04-18 wub gfe-relnote: (n/a) Stop including unused quic_flags.h in quic_packet_number.h. Cleanup only.
2019-04-17 dschinazi Fix iOS compilation of transport parameters
2019-04-17 quiche-dev Send a PING frame at the start of QuartcPeer tests so that probing works.
2019-04-17 dschinazi Make TLS encryption levels match the QUIC ones
2019-04-17 dschinazi Update QUIC TLS transport parameters to IETF draft 18
2019-04-17 quiche-dev Create a RandomDelayLink (and symmetric version) and use it in QuartcBidiTest.
2019-04-17 quiche-dev Create a PacketFilter for random loss and use it in QuartcBidiTest.
2019-04-17 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_always_reset_short_header_packets.
2019-04-17 danzh gfe-relnote: n/a(code clean-up) Remove un-used #include.
2019-04-17 danzh gfe-relnote: n/a(code clean-up) Remove unused #include.

Created with:
roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Update flags file to remove flag that has been deleted.

R=rch@chromium.org

Change-Id: Ide594ef9da61cd8dcb612b47e82c7e5336215af2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574150
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652531}

findit-for-me@appspot.gserviceaccount.com

Revert "DevTools: aXe core linting for main Elements tools"

This reverts commit cb019fe81baf6392d3df8f643e57effb383b61c9.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 652424 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2IwMTlmZTgxYmFmNjM5MmQzZGY4ZjY0M2U1N2VmZmIzODNiNjFjOQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/WebKit%20Linux%20Trusty%20MSAN/14010

Sample Failed Step: webkit_layout_tests

Sample Flaky Test: http/tests/devtools/a11y-axe-core/elements/main-tool-test.js

Original change's description:
> DevTools: aXe core linting for main Elements tools
>
> This change adds aXe Core linting to the following components of
> the main Elements tool:
>
> - DOM tree
> - Breadcrumbs
> - Styles pane
> - Computed Styles pane
>
> Change-Id: I247d9a4d4883db936f09c4d252a0558e63295edf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566689
> Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
> Reviewed-by: Joel Einbinder <einbinder@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#652424}

Change-Id: Ie703a128289530af6313a7c61f09216fd4e6bb7f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574280
Cr-Commit-Position: refs/heads/master@{#652530}

chlily@chromium.org

Parsing cookie SameSite: add None & Extended options, change default

This CL changes the default net::CookieSameSite value to UNSPECIFIED
(it was previously NO_RESTRICTION). The default is used when the cookie
does not specify a SameSite attribute, or if the given SameSite
attribute does not specify a valid value.

Support is added for the new `SameSite=None` option, which parses as
CookieSameSite::NO_RESTRICTION. Support is also added for the new
`SameSite=Extended` option, which for now is identical to Lax mode.

Bug: 953306, 953995
Change-Id: I96ee07f5e626a2f99e65e9c27260a8f6e5b6b9f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573081
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652529}

javierrobles@chromium.org

[iOS][Alert] Remove background view

As mentioned by kkhorimoto@ the background view is not needed. And the
chrome shouldn't be constraint to the safe areas, but cover the
presenting view controller.

Bug: 951300
Change-Id: I3097c8dc6ceaaf60c1d0f6ad817a87ef910e5991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574799
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652528}

javierrobles@chromium.org

[iOS][Alert] Make init available

Making init available again so it can compile with xcode clang.
UIAlertAction also has this method available.

Bug: 951301, 951300, 954134
Change-Id: Ie5b5e9d5f95694a38277ba25a1bed03bfdf1e355
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573621
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652527}

minggang.wang@intel.com

TaskManger: Invalidate the weak pointers after stopping updating

Currently, the operation of getting service worker infos is
asynchronous, during which the task manager may have stopped updating.
In this case we have to invalidate the weak pointers to avoid the
invoking of the callbacks.

BUG=953432

Change-Id: I7f5bc3c0203008175264eb5a8f31ab5236d40d27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572648
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Minggang Wang <minggang.wang@intel.com>
Cr-Commit-Position: refs/heads/master@{#652526}

javierrobles@chromium.org

[iOS][Alert] Support action handler blocks

Bug: 951361, 951300
Change-Id: Ic653d533b927774f0d78de10c7fb4d5ab8dfa3c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565006
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652525}

sebsg@chromium.org

Make iOS ConfirmInforBars close if delegate LinkClicked returns true.

The delegate's documentation mentions that returning true should close
the infobar.

Bug: 954339
Change-Id: Ibbe75f180f828afebd72c4c7953045da9249b7c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574443
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652524}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll src-internal f2976d2e4dec..f9096e11484e (2 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2976d2e4dec..f9096e11484e

Created with:
gclient setdep -r src-internal@f9096e11484e

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org

Change-Id: I2d83e8b1e52cb00c894efa9f568ec407c441cf46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575417
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652523}

altimin@chromium.org

[bfcache] Track service worker-controlled pages in metrics

Track pages controlled by service workers.

R=haraken@chromium.org,kinuko@chromium.org
CC=falken@chromium.org
BUG=933147

Change-Id: I27c2665bf6c484df7748a97ea5260c7407bbae90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571693
Commit-Queue: Alexander Timin <altimin@chromium.org>
Auto-Submit: Alexander Timin <altimin@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652522}

rhalavati@chromium.org

Update incognito toolbar button's accessible title.

Accessible name of incognito menu is updated to tell the number of open
incognito windows when incognito window counter is active.

Bug: 896235
Change-Id: I16deed985d9cf8170d6739f083f0c352df44c435
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569932
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652521}

pmeuleman@chromium.org

Return CoreAccountInfo in IdentityManager::GetAccountsWithRefreshToken

In the scope of the AccountInfo Split, Bug: 926204, we are evolving the
identity manager API.
This specific CL aims to change the return type of
GetAccountsWithRefreshToken from vector<AccountInfo> to
vector<CoreAccountInfo>.
Two cases are using the extended Account Information and will use
GetExtendedAccountInfoForAccountsWithRefreshToken instead.

Bug: 953251
Change-Id: Ib7f39129bb0da7572c3975d34add98aa16abdac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569716
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652520}

horo@chromium.org

Update flag-metadata.json for allow-sxg-certs-without-extension

Bug: 851778,862003
Change-Id: If6667d8b8f4813748fdd1bceb40850bdfd5da36f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573431
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652519}

chlily@chromium.org

Mark stored cookies without SameSite attribute as "unspecified"

The SQLitePersistentCookieStore is upgraded to Version 11, which
renames the firstpartyonly column to samesite, and adds support for two
new values for that column (kCookieSameSiteUnspecified and
kCookieSameSiteExtended). Upon migration from Version 10 to Version 11,
any stored cookies which have a value of kCookieSameSiteNoRestriction,
indicating that they were set without a SameSite attribute, are marked
instead with kCookieSameSiteUnspecified to reflect the fact that their
SameSite attribute was unspecified.

Bug: 953306
Change-Id: I88a3fa7e4771d07716d9cc6c260e4fe67a19e3f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570416
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652518}

ellyjones@chromium.org

flags: remove enable-recurrent-interstitial

Bug: 953972
Change-Id: Iaee80ccefd6bd3a23744994e016caf4a2cf7b4e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573641
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652517}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll src/third_party/angle 51386f4a5e8b..fcc3ec31b83b (2 commits)

https://chromium.googlesource.com/angle/angle.git/+log/51386f4a5e8b..fcc3ec31b83b

git log 51386f4a5e8b..fcc3ec31b83b --date=short --no-merges --format='%ad %ae %s'
2019-04-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 805b09f92203..0e5d1bb66ad3 (1 commits)
2019-04-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src ac878fcbdd64..7aad9653f9a3 (2 commits)

Created with:
gclient setdep -r src/third_party/angle@fcc3ec31b83b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I424672334fcc228fdba8af717abea738c8f466e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575415
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652516}

nektar@chromium.org

Introduced an enum that lists the text boundaries that are exposed on all supported platforms

Different platforms have different ways of handling text boundaries, both
while navigating, as well as when being asked to return a particular text unit
surrounding the current position.
On Windows, navigating by word always goes to the start of the word.
When announcing the current word however, a screen reader whill not
include anything that comes between the current word and the next one.
On Linux and Mac, navigating by the same unit will stop at the start of the word when moving in the backward direction,
but at the end of the word when navigating in the forward direction.
Also, various platforms have text boundaries that are
unsupported on others.
For example, UI Automation can return text ranges based on style changes.
This patch creates an enum that is a superset of all the text boundaries supported on all platforms
and a set of functions to convert to the various platform specific text boundaries.
R=dmazzoni@chromium.org

Change-Id: I5fbc116a5f6dc9bc4e1ee3ab4cb46d5009003e0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567953
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#652515}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll src/third_party/glslang/src 0e5d1bb66ad3..86c72c9486a9 (3 commits)

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0e5d1bb66ad3..86c72c9486a9

git log 0e5d1bb66ad3..86c72c9486a9 --date=short --no-merges --format='%ad %ae %s'
2019-04-19 cepheus@frii.com Bump revision.
2019-04-19 cepheus@frii.com GLSL: Add error check for an argument dropping the 'restrict' qualifier
2019-04-19 cepheus@frii.com Fix #1720: Give an error for parameter mismatched image format.

Created with:
gclient setdep -r src/third_party/glslang/src@86c72c9486a9

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=dsinclair@chromium.org

Change-Id: I81fd92cdb12b4ef210c952f23261f5862b981220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575416
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652514}

lizeb@chromium.org

blink/bindings: Check that decompression is correct, and add UTF-16 testing.

There are crashes in ParkableString decompression, which are assumed to be OOM
conditions. Add a check to make sure this is the case, and add testing for UTF16
strings to make sure that this doesn't instead come from such strings.

Bug: 946203
Change-Id: Iaafde8c3c7b9c79bf87de67e6c5de5b71e1a310a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575499
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652513}

keishi@chromium.org

Modify frameset console to use postMessage

To introduce EventLoop concept we can't have AllowUniversalAccessFromFileURLs changing midway, and so we will be making AllowUniversalAccessFromFileURLs false for web_tests by default.

Tests using frameset, write in the frame to show text. Without AllowUniversalAccessFromFileURLs, you cannot write directly into it, so this CL changes them to use postMessage.

Bug=804661

Change-Id: I22a48a6a856f4cb2b14bcc956a2fa2cf47cea3f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573521
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652512}

blundell@chromium.org

Update //components/OWNERS to properly allow trivial changes

Followup to
https://chromium-review.googlesource.com/c/chromium/src/+/1470974 to
realize the intent of that CL.

Credit to thakis@, who noticed the error.

Change-Id: Ia0c8d02603713097566e8788e0e36083acbffeec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575498
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652511}

altimin@chromium.org

[bfcache] Track the presence of network requests for metrics

R=kinuko@chromium.org,haraken@chromium.org
BUG=933147

Change-Id: Ie6590bebb11e70e024f829045e1f8717d83e9af1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572128
Commit-Queue: Alexander Timin <altimin@chromium.org>
Auto-Submit: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652510}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll src-internal b2e2edfd0377..f2976d2e4dec (4 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2e2edfd0377..f2976d2e4dec

Created with:
gclient setdep -r src-internal@f2976d2e4dec

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org

Change-Id: Ic96debf4aceeed51852615f445c2783e01db56ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575413
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652509}

clamy@chromium.org

Add support for custom PageState in NavigationSimulator

This CL allows to set a custom PageState in the NavigationSimulator and
converst one unit test that needed this functionality to using
NavigationSimulator.

Bug: 728571
Change-Id: Ie62b87f328f52e6ae51357a3ebfa9f295ea7ac80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569017
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652508}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll AFDO from 75.0.3769.0_rc-r1-merged to 75.0.3770.0_rc-r1-merged

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=gbiv@chromium.org

Change-Id: Ie75dc6d6262e968994c6bb2a72281c12fe8b4178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575414
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652507}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll src/third_party/chromite 641336160936..666a00adb2b3 (1 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/641336160936..666a00adb2b3

git log 641336160936..666a00adb2b3 --date=short --no-merges --format='%ad %ae %s'
2019-04-19 chrome-bot@chromium.org Update config settings by config-updater.

Created with:
gclient setdep -r src/third_party/chromite@666a00adb2b3

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I8c2b427692eaa09e3a52072a35d59f77998d10ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575412
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652506}

xiangze.zhang@intel.com

WebMediaPlayerMSCompositor cleanup

In WebMediaPlayerMSCompositor, GetCurentFrame() no longer has side effect.
This CL removes GetCurrentFrameWithoutUpdatingStatistics() and uses
GetCurrentFrame() instead. This CL also removes an outdated comment.

Bug: 948472

Change-Id: If18ccb69cfe47a8944bdb91a1a8cf72f91d34985
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542783
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652505}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll src/third_party/catapult 2ab4d326364e..92d14c28e81b (1 commits)

https://chromium.googlesource.com/catapult.git/+log/2ab4d326364e..92d14c28e81b

git log 2ab4d326364e..92d14c28e81b --date=short --no-merges --format='%ad %ae %s'
2019-04-19 benjhayden@chromium.org Migrate alerts-request.js to es6 module

Created with:
gclient setdep -r src/third_party/catapult@92d14c28e81b

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:950011
TBR=charliea@chromium.org

Change-Id: I09e7cf37cba92257bcec523e6110942d8d5b6b94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575411
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652504}

yosin@chromium.org

Clear offset mapping cache in LayoutSVGText::UpdateLayout()

This patch makes |LayoutSVGText::UpdateLayout()| to clear offset mapping cache
if needed rather than in |LayoutBlockFlow::UpdateBlockLayout()|[1] to fix
heap-use-after-free in |NGOffsetMapping|.

Unlike other derived classes of |LayoutBlockFlow|,
|LayoutSVGBlock::UpdateLayout()| doesn't call |UpdateBlockLayout()|, then
|LayoutSVGBlock| holds stale offset mapping cache.

[1] http://crrev.com/c/1488479 Make LayoutBlockFlowRareData to hold
NGOffsetMapping for legacy layout

Bug: 951218
Change-Id: Iacaa72a426cfcf9cd71495cf2c1ed6a0c6511ed9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574987
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652503}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll src/third_party/angle 145ec7fa7c81..51386f4a5e8b (1 commits)

https://chromium.googlesource.com/angle/angle.git/+log/145ec7fa7c81..51386f4a5e8b

git log 145ec7fa7c81..51386f4a5e8b --date=short --no-merges --format='%ad %ae %s'
2019-04-19 kbr@chromium.org Reland "Define and expose EGL_ANGLE_power_preference extension."

Created with:
gclient setdep -r src/third_party/angle@51386f4a5e8b

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:2813
TBR=cwallez@chromium.org

Change-Id: If1c618840fd9feca8e0ef3be05da953f1871f196
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575410
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652502}

chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Roll src-internal ecf68b73d5c9..b2e2edfd0377 (4 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ecf68b73d5c9..b2e2edfd0377

Created with:
gclient setdep -r src-internal@b2e2edfd0377

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org

Change-Id: Ieb2ee73fc3bb9f7ab7eec37490aa157ccc5cd8cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575409
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652501}

findit-for-me@appspot.gserviceaccount.com

Revert "Reland "OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth""

This reverts commit 12b303006bbd944b37ea0010904e3de88ed1bd77.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 652487 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzEyYjMwMzAwNmJiZDk0NGIzN2VhMDAxMDkwNGUzZGU4OGVkMWJkNzcM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/mac-rel/4772

Sample Failed Step: compile

Original change's description:
> Reland "OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth"
>
> This is a reland of d5b00821af44d875d6cad42ae578b999ddf9316c
>
> It updates //BUILD.gn and //content/public/common/BUILD.gn
> in addition to the previous change to fix the dependency
> problem.
>
> Original change's description:
> > OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth
> >
> > This CL moves bluetooth folder from public/platform/modules to
> > public/mojom/ to gather mojom files to mojom folder with
> > creating web_bluetooth_mojo_bindings.
> >
> > Bug: 919393
> > Change-Id: I42037e1c9738b03969e927dd00f6b24c2873b364
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530369
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > Reviewed-by: Doug Turner <dougt@chromium.org>
> > Reviewed-by: Colin Blundell <blundell@chromium.org>
> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
> > Cr-Commit-Position: refs/heads/master@{#649061}
>
> Bug: 919393
> Change-Id: I61de3e625205e54959ad8d36c84eefa95f861035
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559368
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#652487}

Change-Id: I29f9dc1cdedf6f7f6aad104a2bced4aac446b7a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 919393
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575520
Cr-Commit-Position: refs/heads/master@{#652500}

arthursonzogni@chromium.org

Revert "Make renderer-initiated navigation to about:blank to use the default path."

This reverts commit 2cd39eb02d017e6ce8db65045d6f13833505963c.

Reason for revert: The branch cut was supposed to be yesterday, but I
haven't received any confirmation is happened. To be sure revert this
commit for the moment.

Original change's description:
> Make renderer-initiated navigation to about:blank to use the default path.
>
> We used to believe renderer initiated navigation from a document to
> about:blank needed to happen sometimes "synchronously". This isn't the
> case, a PostTask is currently used. The only real requirement is when
> committing the initial empty document.
>
> This CL makes those navigation to use the default path instead.
>
> This requires a few tests to be updated:
>
> 1) The initiator and a few other properties needs to be properly set. There
> are DCHECK in BeginNavigationInternal to enforce renderer initiated
> navigation always have a defined initiator.
>
> 2) runtime-console-log-handle-navigate.js: In console-log-navigate, console.log
> can use the 'getter' of the object several times (up to 2) to print the
> object. It triggers several about:blank navigations. Since they are now going
> to the browser process, they are committed later compared to the script
> execution. The test became less reliable. The test was using
> dp.Runtime.onceExecutionContextCreated to wait for new documents to commit,
> but waiting was started potentially after the event occured. The new test is
> now creating the Promise before triggering the action that will later resolve
> it. The action is either creating the iframe or making use of the logXXX()
> function. This is now fully reliable.
>
> Bug: 936696
> Change-Id: Ibf1a87f83d2e8bfd621d067f0a29a14a069384a8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543258
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#652493}

TBR=dgozman@chromium.org,dcheng@chromium.org,nasko@chromium.org,clamy@chromium.org,alexmos@chromium.org,arthursonzogni@chromium.org

Change-Id: I6a5fe676275d59027907a1c9540dfe941fab3e18
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 936696
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574320
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652499}

hashimoto@chromium.org

chromeos: Introduce use_real_dbus_clients GN arg

use_real_dbus_clients=true will be used to avoid linking fakes to the
shipped binary.

BUG=952745
TEST=build

Change-Id: I419b9b5c2460dbc9dd66fff7490d06d34ec02c9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571329
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652498}

wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com

Import wpt@d1e0662220364b642929f5fb0b43367074c1119c

Using wpt-import in Chromium 263e7db86c6f187244392abe262d1206639b95c6.
With Chromium commits locally applied on WPT:
0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2"
4e9215207a "[Code Health] Remove unnecessary reference file for web test"
40465b7400 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope"
e28269b698 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting."

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Icb769e141e801a0e6539af98581238a677f81a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574446
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652497}

yuzus@chromium.org

Disable Perfetto for leak detection

This CL disables perfetto for leak detection for now because perfetto
changed the timing of taking memory dumps and thus leak detection is not
properly working any more.
This is meant to be a temporary fix.

Bug: 936805

Change-Id: I885e2abe074354878cae909af54c194d30e1f132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557665
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652496}

v.paturi@samsung.com

Split DarkModeImageClassifier for Bitmap and SVG images.

The classifier for SVG images is going to have to work with
layout objects. So the code for the SVG classifier cannot
reside in the current DarkModeImageClassifier in platform
as the code in platform cannot depend on core.

A separate class is implemented in core for classification
of SVG images in dark mode. The current DarkModeImageClassifier
is renamed to a more appropriate DarkModeBitmapImageClassifier.

The SVG classifier itself is a work in progress and will be
submitted in a follow-up CL.

Bug: 949943
Change-Id: I135a357c333655c11e197599466c314d2f20facf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564276
Commit-Queue: Varun Chowdhary Paturi <v.paturi@samsung.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652495}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll src/third_party/glslang/src 805b09f92203..0e5d1bb66ad3 (1 commits)

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/805b09f92203..0e5d1bb66ad3

git log 805b09f92203..0e5d1bb66ad3 --date=short --no-merges --format='%ad %ae %s'
2019-04-19 cepheus@frii.com clang-format correction and typo (clang format likely not complete)

Created with:
gclient setdep -r src/third_party/glslang/src@0e5d1bb66ad3

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

TBR=dsinclair@chromium.org

Change-Id: Ibda22dac750cf4f7b4f62068062fd2c5892528ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575405
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652494}

arthursonzogni@chromium.org

Make renderer-initiated navigation to about:blank to use the default path.

We used to believe renderer initiated navigation from a document to
about:blank needed to happen sometimes "synchronously". This isn't the
case, a PostTask is currently used. The only real requirement is when
committing the initial empty document.

This CL makes those navigation to use the default path instead.

This requires a few tests to be updated:

1) The initiator and a few other properties needs to be properly set. There
are DCHECK in BeginNavigationInternal to enforce renderer initiated
navigation always have a defined initiator.

2) runtime-console-log-handle-navigate.js: In console-log-navigate, console.log
can use the 'getter' of the object several times (up to 2) to print the
object. It triggers several about:blank navigations. Since they are now going
to the browser process, they are committed later compared to the script
execution. The test became less reliable. The test was using
dp.Runtime.onceExecutionContextCreated to wait for new documents to commit,
but waiting was started potentially after the event occured. The new test is
now creating the Promise before triggering the action that will later resolve
it. The action is either creating the iframe or making use of the logXXX()
function. This is now fully reliable.

Bug: 936696
Change-Id: Ibf1a87f83d2e8bfd621d067f0a29a14a069384a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543258
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652493}

chromium-autoroll@skia-public.iam.gserviceaccount.com

Roll src/third_party/catapult 7f8529c21699..2ab4d326364e (3 commits)

https://chromium.googlesource.com/catapult.git/+log/7f8529c21699..2ab4d326364e

git log 7f8529c21699..2ab4d326364e --date=short --no-merges --format='%ad %ae %s'
2019-04-19 benjhayden@chromium.org Migrate report-template to es6 module
2019-04-19 benjhayden@chromium.org Migrate chart-compound.js to es6 module
2019-04-19 benjhayden@chromium.org Migrate report-controls.js to es6 module

Created with:
gclient setdep -r src/third_party/catapult@2ab4d326364e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:950011,chromium:950011,chromium:950011
TBR=oysteine@chromium.org

Change-Id: Ic5cf0e87ca81eec9fe398053689824308ba5be84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575406
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652492}

yhirano@chromium.org

Remove FetchContext::ModifyPriorityForExperiment

Introduce ResourceFetcherProperties::IsSubframeDeprioritizationEnabled
instead. Move the priority modification logic to ResourceFetcher.

We need to have a IsMainFrame branch in ResourceFetcher in order to
record histograms. Once it is deprecated we should move the logic into
ResourceFetcherProperties and rename the method to something like
ShouldDeprioritizeRequest.

Bug: 914739
Change-Id: I6627ee9fd2860a257d68f64879a1cc5875685350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570961
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652491}

keishi@chromium.org

Change web_tests to work without universal access to file urls

To introduce EventLoop concept we can't have AllowUniversalAccessFromFileURLs changing midway, and so we will be making AllowUniversalAccessFromFileURLs false for web_tests by default.

This CL changes iframes with dataurl to srcdoc since srcdoc allows access without AllowUniversalAccessFromFileURLs.

Change-Id: Ic99ca1aaf33c37365caf7d1218f5847fd36c0409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531924
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652490}

ricea@chromium.org

Rename ReadableStreamDefaultReader to ReadableStreamReader

Rename the implementation of ReadableStreamDefaultReader to
ReadableStreamReader. Move the ReadableStreamReaderGeneric operations
into the class. This will help prepare for the future addition of
ReadableStreamBYOBReader.

This CL only moves and renames code. No functional changes.

BUG=902633

Change-Id: Icc42ee61886be21618ca417e1783f2a1056bc1ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573558
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652489}

tzik@chromium.org

Fix camel-case name conversion of "URLs"

name_style_converter.py used to convert "URLs" to "ur_ls", and that is
used by settings_macro.h generation.

Change-Id: I8289087219ae7ca3a31c8076160d48c39c1e3251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574983
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652488}