Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
Add expectation for devices that do not support webgpu
This is an intentional change and not a bug. This supports the
change to test webgpu without the unsafe flag:
https://chromium-review.googlesource.com/c/chromium/src/+/7047682
It will resolve these failures
https://ci.chromium.org/ui/p/chromium/builders/luci.chromium.ci/Mac%20Pro%20FYI%20Release%20%28AMD%29
Bug: 42240193
Change-Id: Ida22e079dd218ce9bb903756e57b716c20f34aa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7054887
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Peter McNeeley <petermcneeley@google.com>
Cr-Commit-Position: refs/heads/main@{#1531598}
[omnibox] Update expires_after date for LensAction.Precision metric.
Bug: b:442399887
Change-Id: I4b1ec0ecebdc1e3e7ee1c5daf3ce32e7741c8f5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7048847
Commit-Queue: Khalid Peer <khalidpeer@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531597}
Roll ANGLE from 20a72581bcb3 to 2c1ef1ca4797 (13 revisions)
https://chromium.googlesource.com/angle/angle.git/+log/20a72581bcb3..2c1ef1ca4797
2025-10-17 syoussefi@chromium.org Revert "WGSL: Introduce temporaries for written-to func params"
2025-10-17 syoussefi@chromium.org Translator: Validate case type == switch expression type earlier
2025-10-17 jisunnie.lee@samsung.com Translator: Enable OES_EGL_image_external support in ESSL3.20
2025-10-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d623c1d9d824 to 5f4499eff7b1 (6 revisions)
2025-10-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f26938c66838 to b270daa499ef (552 revisions)
2025-10-17 syoussefi@chromium.org Translator: Validate duplicate cases earlier
2025-10-17 mpdenton@chromium.org WGSL: don't ever emit + unary operator
2025-10-16 yuxinhu@google.com Ensure the address that GLshort is written to is 2 bytes aligned
2025-10-16 kbr@chromium.org PLS: Properly detect shader framebuffer fetch support.
2025-10-16 syoussefi@chromium.org Translator: Verify max function call depth during parse
2025-10-16 syoussefi@chromium.org Translator: Check for undefined functions during parse
2025-10-16 mpdenton@chromium.org WGSL: Introduce temporaries for written-to func params
2025-10-16 xwxw@google.com Disable the ANGLE selection UI when ro.hardware.egl=angle
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: cnorthrop@google.com
Test: Test: m ANGLE_settings
Change-Id: I970b2b05acd381a687b6aaaf7abd3401fd0145d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7056039
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1531596}
Record FCP and LCP for each WebUI variant
Fixed: 40485276
Change-Id: I9758de5a2354ca713d8d93926cc12defe9f63490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7023870
Reviewed-by: Tom Lukaszewicz <tluk@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Todd Reifsteck <toddreif@microsoft.com>
Commit-Queue: Todd Reifsteck <toddreif@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1531595}
Clean up IntersectionObserver scroll optimization bookkeeping
LocalFrameView keeps a running total of the magnitude of all scroll
offsets applied to a page, and applies it to all
IntersectionObservations each time the IntersectionObserver algorithm
runs. This happens in two places during a BeginMainFrame: 1)
LFV::ComputePostLayoutIntersections, which runs zero or more times
during the style/layout/prepaint loop; and 2)
LFV::UpdateViewportIntersectionsForSubtree, which runs once during
post-lifecycle steps. Both of those methods are recursive over the frame
tree, but the recursion logic is different between them (e.g. they
handle render throttling and fenced frames differently).
The upshot is that the bookkeeping of accumulated scroll offset can be
unpredictable. This CL makes it so that accumulated scroll offsets are
only applied to IntersectionObservations during the post-lifecycle frame
tree walk (which is always more complete than the post-layout version).
Bug: chromium:40914013
Change-Id: Idd89bf6bf42a19aba9641ed82f1a4e407e8268a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7034645
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531594}
Roll Chrome Android Desktop x64 PGO Profile
Roll Chrome Android Desktop x64 PGO profile from chrome-android-desktop-x64-main-1760702004-87d60591757282ac54663d94abf1a39c73f4e2ed-0b6b7a52e8b4af4c8cdeb16705e2f4aab5270618.profdata to chrome-android-desktop-x64-main-1760723784-eca21d9869637aacdbcf36208da43dab59ea0684-97f15c14312493d1efb23f93466e1f990465702e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-desktop-x64-chromium
Please CC al-clank-pgo@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I40249c2da0e605ba943debae0d02bc7aaee91ee0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7055331
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1531593}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1760716882-e925e97223214e469367189151692a0a76c91e03-ef2e5e8a2c64bfe3b5e1203c1f63e5630a68c08d.profdata to chrome-android64-main-1760720527-84c0963d6dbcfc36a9414bb7e36d17bdc5e079bb-35ddc1e2be4c641fe86eced1e7817d1ce3d78b49.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I000b19ac7c633af55cfa678cd720667b361919b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7055360
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1531592}
Roll Chrome Android ARM32 PGO Profile
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1760702004-aa4b775fb53bdef32a8aed9986f599227f251ce5-0b6b7a52e8b4af4c8cdeb16705e2f4aab5270618.profdata to chrome-android32-main-1760723784-54a36b24974d7fc98ee7fef4e27b3dda755d1192-97f15c14312493d1efb23f93466e1f990465702e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I648fa20941b2f2c40ecddf00ac4e67910698d6f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7055330
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1531591}
[BNPL][Clank] Handle BNPL issuer suggestion selection
This CL adds the logic to handle a BNPL issuer suggestion selection.
When a user selects a BNPL issuer suggestion on the bottom sheet, we
trigger a JNI call to `TouchToFillDelegateAndroidImpl`, which invokes
the `selected_issuer_callback` with the selected issuer. This callback
triggers `BnplManager::OnIssuerSelected`, which continues the BNPL flow.
Design: go/autofill-clank-bnpl
Low-Coverage-Reason: COVERAGE_UNDERREPORTED
Bug: 430575808, b:438785390
Change-Id: Ied920007f0209e2c64ea229757e1eababe993135
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7018890
Reviewed-by: Timofey Chudakov <tchudakov@google.com>
Reviewed-by: Jihad Hanna <jihadghanna@google.com>
Commit-Queue: Fernando Ramirez <ferny@google.com>
Reviewed-by: Vinny Persky <vinnypersky@google.com>
Reviewed-by: Viplav Kadam <viplavkadam@google.com>
Cr-Commit-Position: refs/heads/main@{#1531590}
Roll DevTools Frontend from ca1486a6501f to 9ac40d2b0c7d (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ca1486a6501f..9ac40d2b0c7d
2025-10-17 nharshunova@chromium.org Increase performance tests timeout
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Change-Id: I258cd9a3f3601e69283529b2d934cfed43b327e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7055349
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1531589}
Roll Skia from 832f6e513d41 to 89e82868fe3e (1 revision)
https://skia.googlesource.com/skia.git/+log/832f6e513d41..89e82868fe3e
2025-10-17 bungeman@google.com SG slides to fScene->revalidate when needed
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC skiabot@google.com,thomsmit@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:mac14.arm64-blink-rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: thomsmit@google.com
Change-Id: I860bbdcf1917d69f24e3380b4f9cad6df860f069
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7055350
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1531588}
Roll Perfetto from 4f1596e32040 to 8e03a17889cb (2 revisions)
https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/4f1596e32040..8e03a17889cb
2025-10-17 108405710+aMayzner@users.noreply.github.com exp: Styling cleanup (#3325)
2025-10-17 lalitm@google.com tp: fix parsing of protos -> args when descriptor and proto disagree (#3323)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com,petrcermak@google.com,primiano@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com,petrcermak@google.com
Change-Id: Iac8782dce7d6587faf51e96aec1ec01f1c352b8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7056041
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1531587}
[BNPL][Clank] Handle user clicking BNPL chip after AE completes
This CL handles the user flow for clicking the BNPL chip after the
transaction amount has been extracted.
When a user clicks the chip, a call is made from Java to the native
side, passing the stored amount. If the amount is valid, the native
side calls back to Java with the `BnplIssuerContext` to display the
BNPL issuer selection screen. The logic for handling invalid amounts
will be addressed in an upcoming CL.
Video:
http://screencast/cast/NjU0ODk2NzIzMDc5OTg3MnwwZTBkZTUxYi00NQ
Design: go/autofill-clank-bnpl
Bug: b:438784702, 430575808
Change-Id: Idc63d803851fc9892ddc4be35762b04e7c690001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7014892
Commit-Queue: Viplav Kadam <viplavkadam@google.com>
Reviewed-by: Vinny Persky <vinnypersky@google.com>
Reviewed-by: Norge Vizcay <vizcay@google.com>
Reviewed-by: Timofey Chudakov <tchudakov@google.com>
Cr-Commit-Position: refs/heads/main@{#1531586}
[iOS]Uses check in bookmarks folder coordinator
In crbug.com/450910124 we see the mediator was not properly
disconnected. If this was a check, we would have probably seen the issue
is with the coordinator. This CL add checks for all instance variables,
for the sake of safety.
Bug: 450910124
Change-Id: I7bcca4787731580cbb28f5643a6d2dfe38c4071e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7047046
Auto-Submit: Arthur Milchior <arthurmilchior@chromium.org>
Reviewed-by: Huiting Yu <huitingyu@google.com>
Commit-Queue: Arthur Milchior <arthurmilchior@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531585}
Fix crash when closing side panel
The side panel was crashing after the refactor because after the close
button is clicked, it triggers the header to close the side panel.
This then leads to the controller to be destroyed and causes a seg
fault when the controller later tries to close the pin promo. This
CL fixes this bug by removing the explicit call to MaybeEndPinPromo()
after closing the side panel because the anchor to the promo has
been deleted so the promo also dismisses.
Fixed: 452911460
Change-Id: I62faaa3fe09eb8ef124406df59243c605c76d2f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7056147
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Commit-Queue: Steven Luong <stluong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531584}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1760709523-e702e8941cca3f8874d0ab63ba5c84a7ddd00e06-baefb6fb6244cda74254784c74cd7ff39a3284a1.profdata to chrome-mac-arm-main-1760723784-334c377b1ddcec89ae342522781d2b18b791a9ee-97f15c14312493d1efb23f93466e1f990465702e.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I677855bcd34ba5990a2d256fd752b1272357947b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7055361
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1531583}
Roll src/third_party/libvpx/source/libvpx/ d18c34c54..84a3c9dee (5 commits)
https://chromium.googlesource.com/webm/libvpx.git/+log/d18c34c54a1b..84a3c9dee9ef
$ git log d18c34c54..84a3c9dee --date=short --no-merges --format='%ad %ae %s'
2025-10-17 davidben Fix left-shift overflow in mem_neon.h
2025-09-25 alex.davicenko Move vpx_tbl2x*_s16 to neon_sve2 bridge header
2025-09-23 alex.davicenko Remove duplicate Neon transpose_concat* helpers
2025-10-02 ysjeon741 configure: Fix x86 SIMD flags detection w/Apple cross-compile
2020-11-25 wtc Do not truncate long options in arg_show_usage()
Created with:
roll-dep src/third_party/libvpx/source/libvpx
Change-Id: I3784a76e8cf7407c64f018dce2ad06623e90aa19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7055904
Reviewed-by: Wan-Teh Chang <wtc@google.com>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Auto-Submit: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531582}
Remove obsolete GenerateTouchEvent
Bug: None
Change-Id: I7867598016e7a5d11519d18feca561c54f31bf2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7053082
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531581}
Roll WebGPU CTS from aabe8e85e5c8 to d8631014b7ea (1 revision)
https://chromium.googlesource.com/external/github.com/gpuweb/cts.git/+log/aabe8e85e5c8..d8631014b7ea
2025-10-17 dneto@google.com remove use of 'subgroup_branching' diagnostic (#4478)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webgpu-cts-chromium-autoroll
Please CC kainino@google.com,webgpu-developers@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel
Bug: None
Tbr: kainino@google.com
Change-Id: I42b0f79f4eaf089e2205174915616a363b59525e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7055982
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1531580}
Added web ui logic for showing and hiding the actor glow
Bug: 447114657
Change-Id: Ifa6f415adeccc75e53c2cc9d0c7f03569556f4b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7056082
Reviewed-by: Jacob Stanley <jacobstanley@google.com>
Commit-Queue: Abe Boujane <boujane@google.com>
Cr-Commit-Position: refs/heads/main@{#1531579}
[ClipboardChange event] Add `changeId` implementation
This adds `changeId` attribute to the implementation of the
`clipboardchange` event. It's computed by hashing the global
`SequenceNumber` against a partition-specific origin UUID to prevent
fingerprinting.
Context and more information on the design:
docs.google.com/document/d/13UciminmYLXkdPPmx56SFEYJzilNAb0nBD5ZX2GcIUw/
Future work:
- Add clearing storage key specific UUID on site data clear, in the same
way as it will be done for Bluetooth: https://crbug.com/448977643
- Add WPTs for this.
Bug: 434025175
Change-Id: Ic93dfbe9d087f95cc600d5d7f38f0497b2023448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6967742
Commit-Queue: Zgroza (Luke) Klimek <zgroza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531578}
Roll WebRTC from dba149e6c1d7 to 47ad4b691875 (11 revisions)
https://webrtc.googlesource.com/src.git/+log/dba149e6c1d7..47ad4b691875
2025-10-17 ilnik@webrtc.org Remove ::testing::Invoke usage for lambdas
2025-10-17 hta@webrtc.org Tweaks for downstream sigslot usage
2025-10-17 saza@webrtc.org Refactor to clarify band split rate is always 16k
2025-10-17 saza@webrtc.org [Bug fix] Update all state in AudioProcessing::ApplyConfig
2025-10-17 tommi@webrtc.org Introduce MediaEngineReference for managing access on the worker thread
2025-10-17 jleconte@webrtc.org First stab at adding clang-tidy bot.
2025-10-17 danilchap@google.com Add centralized implementation of the webrtc::Near gtest matcher
2025-10-17 hta@webrtc.org Add ability to re-enable header extensions in 2nd O/A
2025-10-17 brandtr@webrtc.org Stop inferring optionally wrapped type
2025-10-17 terelius@webrtc.org Add data_in_flight to RTC event log Scream event
2025-10-17 hta@webrtc.org Add Notify functions for some Port signals
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com,webrtc-infra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I4f7858f2f93e35c7eb0276ad16117621dc98dd13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7056323
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1531577}
[media-effects] Remove kVideoEffects sandbox
Bug: b:443177498
Change-Id: Id4b276bb3960bdf271b14b2f0ee6c05fc262d528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7049852
Commit-Queue: Ahmed Moussa <ahmedmoussa@google.com>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531576}
[GlicMI] Add a stable pinning delegating sharing manager.
The base delegating sharing manager can't safely delegating subscribe to
pin candidates. For the umbrella use case (e.g. tab decorations), this
is fine. But for detach/attach we want to use a delegating sharing
manager that allows subscribe to pin candidates, in exchange for not
being allowed to change the pinned tab manager instance (we will only
swap out the focus-related managers). Implements a handful of CHECKs to
avoid misuse (and potentially misreporting to users what is being
shared). Follow up CLs will plug this into the attach/detach flow for
instances.
Bug: 452150693
Change-Id: I9a8f9a5651d28c098cdaeaa7e878288a21a3f4f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7049643
Commit-Queue: Marke Hallowell <wry@chromium.org>
Reviewed-by: Dan Harrington <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531575}
Make deprecated Mojo binder_map available for Chromecast only
Make mojo::BinderMapWithContext::SetDefaultBinderDeprecated() and
related code available on Chromecast only. Chromecast is the only
remaining caller.
Change-Id: I1ae94b0e313ececf330b71e7151b677c1777edcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7051462
Reviewed-by: Fred Shih <ffred@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531574}
Add histograms for how many times ZSS requested for ineligible pages
Bug: 445280207
Change-Id: Iaf388ef0779e4c5a467551db01bf2cecafe5929f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7056142
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Zekun Jiang <zekunjiang@google.com>
Cr-Commit-Position: refs/heads/main@{#1531573}
[TabGroupsModule] Add a small gap between title and description.
Fixed: b:452952889
Change-Id: I694daa548fd86a13805122940570569739b89498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7055129
Commit-Queue: Teresa Mao <temao@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531572}
[Persist] Move the responsibility of transaction creation to caller
- Create a new holder class to hold sqlite transactions without
exposing sqlite libraries to the backend. This transaction
holder class is used as a key to database updates.
- Expose a method in the database class for transaction creation.
- Add a helper method to run a set of database operations in a
single transaction.
- Remove the integrated transaction creation from pre-existing
methods. Initialize() was not included, since we should
guarantee this is done in a single transaction.
Bug: 450577488
Change-Id: I5503e8af4bd43b25c79717c34aef922bd4aa2719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7055302
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Fiaz Muhammad <mfiaz@google.com>
Auto-Submit: Fiaz Muhammad <mfiaz@google.com>
Cr-Commit-Position: refs/heads/main@{#1531571}
[media-effects] Remove video_effects_service
Bug: b:443177498
Change-Id: I929045097684b0de2b0daf51f654384377a9874a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7050502
Commit-Queue: Ahmed Moussa <ahmedmoussa@google.com>
Reviewed-by: Fred Shih <ffred@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531570}
[media-effects] Remove all dependencies on services/video_effects/*
video_effects service is to be removed in a follow-up CL.
Bug: b:443177498
Change-Id: Ie26f3fb089face01e1cc06a3210034655bb6009c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7049850
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Ahmed Moussa <ahmedmoussa@google.com>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531569}
Add thread type to ContextualTaskSpecifics proto
This allows the ContextualTaskSpecifics to support different AiThread
types in the future, even if 2 threads has the same thead id.
Bug: 445840627
Change-Id: I0da873abf27c2e11c575f04aa47bf3583ce803ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7050686
Reviewed-by: Ankush Singh <ankushkush@google.com>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531568}
Add header text to tabs in attachment popup
Bug: 449039948
Change-Id: I934b472c0cdb50ce446eb6ac15fab7337d257b69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7038300
Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531567}
Roll Chrome Android ARM64 Orderfile from Ca-qELvzxqPhh8rdB... to SJwj9InTJA_uhg4J5...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/orderfile-android-arm64-chromium
Please CC clank-build@google.com,clank-library-failures@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: clank-library-failures@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ie7cc46a88c8002e5251ed709287e40b24eb000a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7056036
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1531566}
Adds Unit Tests for HLS Watchtime keys
This CL modifies the signature of Initialize in watch_time_keys_unittests
allowing it to accept a `media::DemuxerType`, which enables easily
adding tests for HLS (KManifestDemuxer). It also includes unit tests
covering the following scenarios:
- Audio + Video, SDR
- Audio + Video, SDR, Muted
- Audio + Video, SDR, Mute/Unmute
- Audio + Video, HDR
- Audio
Fixed: https://issues.chromium.org/issues/452009603
Change-Id: Ife4db9f7235bbdcbb8797be5c9f373732f6d4262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7050862
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Tochukwu Ibe-Ekeocha <tibeekeocha@microsoft.com>
Reviewed-by: Ted (Chromium) Meyer <tmathmeyer@chromium.org>
Reviewed-by: Fred Shih <ffred@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531565}
Remove Session logging wrapper.
Only Answerer uses it (and logging will be disabled for it anyway see b/445763981).
Inlines the current behavior there, so no functional changes in this CL.
Note that:
* Request was not populated, since it passed a dummy one.
* model_execution_info already populates model_execution_error_enum
* Partial responses don't contain model_execution_info
Bug: 445999234
Change-Id: I6a6a696474661255ff6e845553593dfd62171e9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7047358
Auto-Submit: Steven Holte <holte@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531564}
Keep the test process alive after Activity finishing for browser tests
Some Android 16+ devices seem to kill the process immediately upon
finishing the Activity, not leaving us enough time to report test
results back.
Use a service to keep the process alive after Activity finishing.
Also fixed a race in test shutdown leading to a hang if the
SharedMemoryManager is deleted after the task executor is shut down.
Bug: 40200835
Change-Id: If6daee85fef6a1f5f141eb5623a182f4fb773b38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7042740
Reviewed-by: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531563}
legion: Add Crypter for post-handshake encryption
This change introduces a `Crypter` class to handle encryption and
decryption of messages after a secure channel has been established. It
uses AES-256-GCM for authenticated encryption. Messages are padded to a
multiple of 32 bytes, with the last byte of the padded message
indicating the number of zero-padding bytes. Nonces are derived from
incrementing sequence numbers for each encryption and decryption
operation.
Bug: b:444610593
Change-Id: Ia3f0dbb566a0d691dc041863ef96d251b039f63c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7043847
Reviewed-by: Mohamad Arab <arabm@google.com>
Commit-Queue: Nikhil Jakhar <nikhiljakhar@google.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531562}
[contextual_tasks] Minor cleanups and include fixes.
This CL removes a redundant namespace qualifier in
ContextualTasksContextController and performs other minor cleanups in
the contextual_tasks directory.
The changes primarily involve adding and removing C++ Standard Library
and Chromium-specific headers to improve include hygiene, based on IWYU
analysis.
These changes are purely for code hygiene and have no functional impact.
Bug: None
Test: None
Change-Id: Iecf198f0cd96b0fd84b9e403ab59d0f4f15ef383
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7055585
Reviewed-by: Min Qin <qinmin@chromium.org>
Auto-Submit: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531561}
[SiteSettingsPage] Make title of site settings page to be multi-lined
In some languages, the title of the site settings page is too long to fit on one line, which can be confusing for users. We need to flexibly set the settings title to display on multiple lines.
Bug: 443971253
Change-Id: Ia8dd112987b36e1ef225db676848d9f7033768a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7014097
Commit-Queue: Yifan Luo <lyf@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531560}
[Extensions] Create test confirming onKeyEvent worker bug.
This test confirms the issue encountered in the linked bug. When a
worker stops due to idle timeout it no longer receives the onKeyEvent
afterwards, even though the worker is restarted to process IME events.
This prevents the IME from changing typed text.
Bug: 441317290
Change-Id: I54085a2353568e11c832224cbc2f8d69ab82d85d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7041524
Reviewed-by: Emilia Paz <emiliapaz@chromium.org>
Commit-Queue: Emilia Paz <emiliapaz@chromium.org>
Auto-Submit: Justin Lulejian <jlulejian@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531559}
Do not show cue when side panel for tab is open
Bug: 452946091
Change-Id: Ie0a5b246a28f7574974030259bc64767b15499c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7055575
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Bryant Chandler <bryantchandler@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531558}
Add try-catch for NPE in initializeThemeResourceWrapper.
Bandaid fix to wrap the call to `getActivityType()` in
`initializeThemeResourceWrapper` with a try-catch block to handle a
potential NullPointerException.
Bug: 450746738
Change-Id: Ib11b1395ee62bdf57ec427a93d7cc09e6bdff539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7055128
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531557}
Roll WebView ARM64 Orderfile from 1oTKpkIHqiLlURXVk... to D0WlHZd0RWNfP_p0o...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/orderfile-webview-arm64-chromium
Please CC woa-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I3d94891cbe73f503bc415acaadd7bc34228a2fcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7056034
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1531556}
Fix "git cl format" call in polymer reproduce.sh
The "git cl format" call was failing when reproduce.sh was being called
from //third_party/polymer directory due to the paths not being relative
to the git repository root.
Bug: 450087665
Change-Id: Iee75ea134e156e43296bc0535c5ef7f9a90ed3ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7047977
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531555}
[ProfilePicker] Simplify startup logic for multiple profiles
Remove extra condition on users with multiple profiles that have
never seen the Profile Picker, to directly open a browser. They now
see the Profile Picker.
Details for the rational for the fix in the linked bug.
ProfilePicker::Shown() static function is still used to determine
which message to show on the Profile Picker (different message
on the first run of the Picker).
Added a pixel test for the scenario of second picker run (all existing
test assumes first picker run).
Fixed: 452609632
Change-Id: I7eea5bad9b500d501dfcdcb0fa2cee409f2d549e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7046483
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Ryan Sultanem <rsult@google.com>
Cr-Commit-Position: refs/heads/main@{#1531554}
[Safe Browsing] Finish refactor of safe_browsing.ts file
In a previous bug, it was discovered that some of the types assigned to
variables and function parameters in the safe_browsing.ts file are
incorrect.
This CL refactors the file by redefining variable types, modifying
conditional checks within assert statements and adding comments where
needed.
Fixed: 450554751
Change-Id: I5ef218a6678306fda3543e1cdb53754081e73d30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7027933
Reviewed-by: thefrog <thefrog@chromium.org>
Commit-Queue: Daniel White <danieltwhite@google.com>
Cr-Commit-Position: refs/heads/main@{#1531553}
Wrap CreateImageFromVideoFrame in tests
We'll update signature and logic quite a bit, this makes it more
ergonomic.
Change-Id: Icfa7c6bea1953d99ede919b7b4da1383c2eaa144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7042581
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531552}
Add action type for adding a server stored entity.
Bug: 452437465
Change-Id: Ied1d4bb26cc4a9f89d9f5a53546bf159aed56acf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7048801
Reviewed-by: Norge Vizcay <vizcay@google.com>
Commit-Queue: Tobiasz Ciepliński <tobson@google.com>
Cr-Commit-Position: refs/heads/main@{#1531551}
Force mono capture of mono output devices
This is a workaround for a bug where some mono streams are not upmixed
to stereo in case of a mono device loopback. With the workaround enabled
we always capture mono devices in mono and upmix to stereo in
CatapAudioInputStreamSource.
The workaround can be disabled by disabling the feature
kMacCatapForceMonoCapture.
Change-Id: I21617e4c9bae4aacab2533b6f49d48d244dd12ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7037537
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Johannes Kron <kron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531550}
Roll src-internal from a25740d9a2f4 to 1170670db9e2 (1 revision)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a25740d9a2f4..1170670db9e2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,etiennep@google.com,yuhengh@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:452913298
Tbr: etiennep@google.com,yuhengh@google.com
Change-Id: I99ec262539f3fbf45d6fc17db7496457a8e40a15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7055776
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1531549}