Chromium Main Console

Update V8 to version 7.7.137.

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/aca18242..8034ecba

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I68867dc3ae72814106bfd761a6518d026469ff2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674064
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671660}

Clean-up PasswordGenerationAgent.

On bug crbug.com/866444 client-side password generation using the new
password manager architecture was implemented. This CL removes the old
client-side generation implementation. It consists:

1.Removing propagating server-side data from browser to the renderer
(starting from chrome_autifll_client.cc and till
PasswordGenerationAgent::FoundFormsEligibleForGeneration).

2.Removing all code related to processing server-side signals from
PasswordGenerationAgent.

3.PasswordGenerationAgent::FormNotBlacklisted is removed.

4.Updating tests with the new setup and removing tests that are not
applicable to the new architecture.

Bug: 949519

Change-Id: I55c1ef516475a425d0247d377b64210ab36a486b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660861
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671659}

[Sync::USS] Clean corrupted password sync metadata from login database

During experimentation phase, passwords sync metadata got corrupted
due to a bug.

This CL is pumping up the database version and clean any
potentially corrupted sync metadata.

This is safe because the corrupted version hasn't reached Stable.

This CL only clears the sync metadata and doesn't remove any password
data. Users will then automatically go through the first sync
experience!

Bug: 973053
Change-Id: Iecc604690522b22d4a419e247a65add171766879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653229
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671658}

Add dimmer between system modal and parent access widget on login screen

Bug: 977676
Change-Id: I5b4ecdc19282116f87d4e7c1afd4f116765a7aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671687
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671657}

Insert a generated item after preserved spaces following a forced break

We already had to implement a special logic to deal with leading
preserved white spaces due some optimizations we have in the line
breaking code to give always breaking opportunities before spaces.

However, the presence of forced breaks may cause some of the following
spaces becoming leading preserved spaces in the next line.

This patch applies the same logic we had for such leading spaces at
the text's first line. It also needs to define additional cases in the
function that evaluates the need of adding these generated breaking
opportunity items.

Bug: 976195
Change-Id: If39e7ba8a535c15d33d6021c6cd04da9590b1131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667305
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671656}

Roll Fuchsia SDK from 890979934473 to 890977424476


The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Iec5d771ba672fb9bd9179b454391f3ccfc8caaba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673452
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671655}

Roll src/third_party/catapult 6643ef1bddde..8d5f1ca18339 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/6643ef1bddde..8d5f1ca18339


git log 6643ef1bddde..8d5f1ca18339 --date=short --no-merges --format='%ad %ae %s'
2019-06-24 perezju@chromium.org [Telemetry] Remove benchmark metadata as input from output formatters


Created with:
gclient setdep -r src/third_party/catapult@8d5f1ca18339

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:973837
TBR=sadrul@google.com

Change-Id: Iafb74c451eff60b600010f83c4c56b76d5e9e43d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673449
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671654}

Add run_tests.py in Chromium.

We can use this script to run all the tests in e2e_test.

It will also be used by our LUCI bots.

Usage:
> vpython run_tests.py --hosts env.host.textpb --test_py_args=--cel_ctl=/celab/cel_ctl
> vpython run_tests.py --tests tests.active_directory.*

(using vpython takes care of getting all required packages, but you
can also use standard python if all required packages are installed)

Change-Id: If2d4c7c4f0a149f6cd187fea4c80054bc6d38b46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670440
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Mathieu Binette <mbinette@google.com>
Cr-Commit-Position: refs/heads/master@{#671653}

Roll src-internal fb91be137da6..ae23bd10fb20 (3 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fb91be137da6..ae23bd10fb20


Created with:
gclient setdep -r src-internal@ae23bd10fb20

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com

Change-Id: Id5dee4702c2a73bd0726b1104dbb6f30d1876f1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673448
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671652}

Add extra failing SKV Android test

Another test has shown to be flaky in the last several builds.
This CL adds that flaky test to the filter list.

Bug: 977669
Change-Id: Icb0cc0a458d42d7bfb56492ca5372e7cf2fcba82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672773
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671651}

heap: Stricter checks for compaction

Add checks to ensure that compaction doesn't get started multiple times.

Bug: 971424
Change-Id: Id764af97e743cc0092412fc193e05d26975adfd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674011
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671650}

Support remote commands over FCM

RemoteCommandsInvalidator and CloudPolicyInvalidator both use the same
InvalidationService instance, so migrate them together.

When fcm is enabled use command_invalidation_topic as topic to subscribe
to invalidations, and command_invalidation_name otherwise.

Bug: 939039
Change-Id: I4b77c60c0928dc3aa54a9e306182e2848354e1ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658790
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Ivan Šandrk <isandrk@chromium.org>
Commit-Queue: Askar Aitzhan <askaraitzhan@google.com>
Cr-Commit-Position: refs/heads/master@{#671649}

Remove kForceDisplayColorProfile from PrepareBrowserCommandLineForBrowserTests

This switch is also set in BrowserTestBase, so the call here is a
duplicate, adding the switch a second time.

R=avi@chromium.org

Bug: 961849
Change-Id: Ie29bfe1be5d3b4da4ad00df078ee6f67c1e0fe15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671070
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671648}

Fix font size for prefilled values.

This is a better way to pin the fonts than http://crrev.com/669336.
Instead of pinning the fonts to the system font, they are actually
pinned to what LayoutThemeFontProvider::SystemFont maps to
-webkit-small-control. This creates even less jank on most sites
the rely on default fonts in input elements. Also the font sizes
are now pinned.

Bug: 916838,951487
Change-Id: I2efb2eaf11276bc75052708f0c61a35ad9ae4c88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670897
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671647}

[iOS] Change toolbar button from Omnibox to NewTab

This CL changes the central button of the bottom toolbar from focusing
the omnibox to opening a new tab.
This needs to be activated through the flag toolbar-new-tab-button.

Bug: 962456
Change-Id: I8afa107ad1dc7e822eb8e899ef508857ca6c6707
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662454
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671646}

Reland "Set up NativeBrowserTestApplications in the base class."

This is a reland of a8ab3bd5e7aac5fe791620c1bbd2737f5c55825a

Original change's description:
> Set up NativeBrowserTestApplications in the base class.
>
> We move the ApplicationStatus.initialize() call up to the base class
> since they all need to do it.
>
> We also initialize the CommandLine there as it needs to be initialized
> from the Application. The ChromeTabbedActivity would crash during
> startup when it tries to use the CommandLine otherwise.
>
> Do the same in NativeTestApplication base class, instead of in
> NativeTest, for consistency. This prevents the CommandLine from being
> destroyed in NativeTest after the NativeBrowserTestApplication has
> already set it up and is running.
>
> Bug: 961849
> Change-Id: I715d91fb1b251d4dbbb51e2b60760fb1cc95bc97
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670349
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Commit-Queue: danakj <danakj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#671355}

TBR=dtrainor,tedchoc

Bug: 961849
Change-Id: If21545dfd71310eac90a40fdd0d55560683a2f2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671862
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671645}

Roll src/third_party/perfetto 764c50488ab3..da392df8222a (2 commits)

https://android.googlesource.com/platform/external/perfetto.git/+log/764c50488ab3..da392df8222a


git log 764c50488ab3..da392df8222a --date=short --no-merges --format='%ad %ae %s'
2019-06-24 lalitm@google.com trace_processor: fix process tracking for end events
2019-06-24 lalitm@google.com Merge "metrics: rework CPU metric and silently drop nulls in repeated fields"


Created with:
gclient setdep -r src/third_party/perfetto@da392df8222a

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:135846416
TBR=perfetto-bugs@google.com

Change-Id: Ibc28c94ffed909ef481348bc389c1190ef71fc07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673849
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671644}

Label inspector-protocol/page/setWebLifecycleState.js as timing out

Test times out very frequently on all platforms.

TBR=lushnikov@chromium.org
NO_TRY=true

Bug: 978000
Change-Id: Ie461bd051360b768518dc9955da262459fcad255
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672859
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671643}

cct_benchmark: Group some params in a class

This is a pure refactor: no change in functionality.

Introduce a new POD LaunchInfo with immutable parameters coming into the
benchmark. This allows reducing the list of parameters in a few
functions passing these along the way, which would reduce plumbing
efforts required to introduce more parameters.

Hopefully the separation between LaunchInfo and CustomCallback is
intuitive and easy to operate.

Bug: 929926
Change-Id: I6e58daceb7b729cafdefed329d07d1e2a159e842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667802
Commit-Queue: Egor Pasko <pasko@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671642}

Remove GetCachedTokenResponse from O2TS

This CL is a part of moving access token management to
OAuth2AccessTokenManager.

As token cache management was moved to OAuth2AccessTokenManager,
O2TS doesn't need to keep GetCachedTokenResponse.

Bug: 967598
Change-Id: Ib869cb0bafe9611031135543502436a24614e14d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673438
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671641}

Pre-Unity Sync settings: Fix non-clickable row after dashboard reset

This fixes a regression in the pre-Unity version of Sync settings that
was introduced by https://crrev.com/c/1559176: In the case where Sync
was reset from the dashboard, the "Sync" row in chrome://settings was
not clickable. The reason was that sync_ui_util::GetStatusLabels
returned SYNC_ERROR, but no corresponding ActionType.
This CL changes back to returning PRE_SYNCED in this case, specifically
for pre-Unity. (It's important that the post-Unity UI continues to
treat this case as an error.)

Bug: 977980
Change-Id: I6bfd116ee605dfbf1b673b2f8c0d9be05efb75df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674006
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671640}

Import wpt@a116572ffdfa202b4ca3534a3777795e9a9fac5e

Using wpt-import in Chromium 7fcf286c091bbe35f141f15e10e93906278d0102.
With Chromium commits locally applied on WPT:
9e3affdd55 "Ship `referer` header length limitation."
845a980aef "KV Storage: add timeout=long and reenable disabled test"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
msisov@igalia.com:
external/wpt/webvtt

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: Id38b6fc22da9767b5a05b0824afbfce6cfb14c5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672771
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671639}

Revert "Enable dSYMS in runtime_deps on official mac builds properly."

This reverts commit f090d8b6a02e69611e0d180f6e39d584d1f8aad1.

Reason for revert: Speculative revert, see crbug.com/961548#c21 for details.

Original change's description:
> Enable dSYMS in runtime_deps on official mac builds properly.
>
> It turns out isolates built on Mac builds that enable_dsyms didn't
> include the symbols in the .dSYM/ directories for frameworks, apps,
> and plugins.
>
> This CL fixes that.
>
> R=​bpastene@chromium.org, rsesek@chromium.org
> BUG=961548
>
> Change-Id: I60f27e7e51235cac6d4fa3c5b7c6de11c0b97819
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671667
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#671463}

TBR=dpranke@chromium.org,rsesek@chromium.org,bpastene@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 961548
Change-Id: I20ff71fcb4023b6e8478cb6fe4981f0a9ea02198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674015
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671638}

Delete PasswordStoreMac.

The class is replaced by the common PasswordStoreDefault.
All the corresponding histograms are also deleted.

Bug: 975634,466638
Change-Id: Ie50e748f785da3eb32ba3b7d0d66aa45d9fa4259
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670226
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671637}

Update V8 to version 7.7.135.

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fe77d58a..aca18242

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1cffee63d349a8239897722e95ab09dfa37da433
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673844
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671636}

Revert "cros: Merge part of TabletModeClient with TabletMode"

This reverts commit 5d46f946229cd775e25ad46579315e628c09c943.

Reason for revert: Speculative revert: TopControlsSlideControllerTest fails frequently after this patch.

Original change's description:
> cros: Merge part of TabletModeClient with TabletMode
>
> - Make ash::TabletMode a concrete class that holds a bool of whether
> tablet mode is enabled and notifies observers when its changed;
> - Make ash::TabletModeController an ash::TabletMode::Delegate to
> provide real state and test support;
> - Move tablet mode observing part from TabletModeClient
> into ash::TabletMode. This leaves TabletModeClient only
> to track and enable mobile behavior for tabs.
>
> Bug: 974238
> Change-Id: Ifda13f72a5016d62439bf96087a5fae3be9df50d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665553
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#671340}

TBR=xiyuan@chromium.org,sky@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 974238
Change-Id: I71d01fd8bc56c7d8e45baf8c0a974b93dcd6cb38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672855
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Reviewed-by: Huanzhong Huang <huanzhong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671635}

Prevent deadlock in CookieSettings

Prevent deadlock If a CookieSettings::Observer calls
CookieSettings::ShouldBlockThirdPartyCookies() while being updated.

Bug: 967668
Change-Id: I5b769bc737fbed53f814865561395e6d7b85c6d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667115
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671634}

Export the Blink StreamsNative feature as a Chromium feature

Prepare to do a Finch trial on the C++ implementation of Streams by
making the StreamsNative feature available as a Chromium feature. This
will enable it to be controlled by Finch.

Manually tested by running with --enable-features=StreamsNative.

BUG=977500

Change-Id: Iba43a8846f4f9a3a85f7539e86c1268b8e704c0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670847
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671633}

Add OffTheRecord histogram metrics for password manager usage.

Adds "PasswordManager.DropdownShown.OffTheRecord" and
"PasswordManager.ItemSelected.OffTheRecord" boolean histogram
metrics to record regular and off-the-record availability and usage of
password manager suggestions.

Bug: 966747
Change-Id: Iadc98505a005d020536051946980b2e94ced9870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667110
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671632}

Add initial version of tests for Agent/WindowAgent.

Agent creation is based on the origin of the page, so the test is placed
under http/tests/. I somewhat arbitrarily picked http/tests/security/ as
the home of this test, because I couldn't find a better one.

This CL contains only a simple test. More tests will be implemented
in the next CL.

This CL adds a function to Internals so we can compare the identity of
different Agents. This cannot be done with public web APIs.

Bug: 961186
Change-Id: I3dfa11b437bb7f97ca9f6f90348d264af8cd844d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663203
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671631}

Pass notification type to android.

This allows features to handle notifications in Java before waking
native code and to use NotificationDisplayService to display
notifications on Android too.

TBR=agrieve@chromium.org

Bug: None
Change-Id: I2e1cfbbe862b775280c58e30245fa7fc439bba15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670894
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671630}

Handle null ::first-letter text layout object.

Ideally, UpdateFirstLetterPseudoElement() will remove the ::first-letter
pseudo element from the DOM when there is no text which can contain the
first letter. Hence, we should not end up in a situation where we try to
AttachLayoutTree for the FirstLetterPseudoElement with a null
first_letter_text.

However, the layout tree is different in AttachLayoutTree() than in
UpdateFirstLetterPseudoElement() in the case where there already was a
::first-letter pseudo element, since we detached it right before
AttachLayoutTree. This means we may have different results for
FirstLetterTextLayoutObject() at those two points if the method has
bugs.

Such a bug was found here where a list item marker inside an anonymous
block had an out-of-flow sibling, but we were not able to traverse out
of the anonymous block to find the first letter text.

Add a DCHECK to let us trigger cases where FirstLetterTextLayoutObject()
is buggy, but also add if-tests to make sure we don't crash.

Bug: 977044
Change-Id: Id80f8aad5c04678d64927e7a7ca4d60cdb6a4b8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672845
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671629}

Move WebMediaRecorderHandlerClient out of exposed blink API

This is a part of moving media recorder implementation to blink.
This CL moves WebMediaRecorderHandlerClient from public to modules
because this class is no longer used outside of Blink, and rename
it to MediaRecorderHandlerClient.

Bug: 960665, 919392
Change-Id: If8d68221834e6822f3e63a6fefe8ea13d92ddc47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672138
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#671628}

Bounds check RefChild in AXPlatformNodeAuraLinux

This prevents an assertion failure from taking down a debug build.

Bug: 977834
Change-Id: Ieb536c63274d7f78c000451c55119b2855fe1175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672070
Reviewed-by: Joanmarie Diggs <jdiggs@igalia.com>
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Cr-Commit-Position: refs/heads/master@{#671627}

Implement the jank monitor.

The jank monitor watches janks on the browser UI and IO thread
using content::responsiveness::MetricSource. The monitor watches task
and native event on a separate sequence (i.e. the "monitor thread").
When the monitor observes task or event running for longer than a
threshold, it notifies the user class about the start and stop of the
jank through the Observer interface.

Bug: 904785
Test: unit_tests: JankMonitorTest.*
Change-Id: I0de7601e7564718e438d3063ce0bfd387bde6675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601019
Commit-Queue: Chinglin Yu <chinglinyu@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671626}

Roll src/third_party/SPIRV-Tools/src 59983a601091..df86bb44fe47 (13 commits)

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/59983a601091..df86bb44fe47


git log 59983a601091..df86bb44fe47 --date=short --no-merges --format='%ad %ae %s'
2019-06-21 kpet@free.fr Replace global static map with an array of pairs (#2691)
2019-06-20 joseph.kucia@gmail.com Basic validation for Component decorations (#2679)
2019-06-20 zoddicus@users.noreply.github.com Add infrastructure for maintaining and using DEPS (#2684)
2019-06-20 33432579+alan-baker@users.noreply.github.com Fix store to uniform Vulkan check (#2688)
2019-06-20 kpet@free.fr Add all accepted target environments to the tools' help texts (#2687)
2019-06-19 afdx@google.com Represent uniform facts via descriptor set and binding. (#2681)
2019-06-19 zoddicus@users.noreply.github.com Roll external/spirv-headers/ 8b911bd2b..de99d4d83 (8 commits) (#2682)
2019-06-19 ehsannas@gmail.com Whitelist SPV_GOOGLE_user_type. (#2673)
2019-06-18 afdx@google.com Add fuzzer pass to obfuscate constants. (#2671)
2019-06-17 33432579+alan-baker@users.noreply.github.com Handle volatile memory semantics in upgrade (#2674)
2019-06-17 33432579+alan-baker@users.noreply.github.com Validate Volatile memory semantics bit (#2672)
2019-06-17 33432579+alan-baker@users.noreply.github.com Disallow stores to UBOs (#2651)
2019-06-17 dneto@google.com Another fix uint -> uint32_t (#2676)


Also rolling transitive DEPS:
src/third_party/spirv-headers/src 8b911bd2ba37..de99d4d834ae

Created with:
gclient setdep -r src/third_party/SPIRV-Tools/src@df86bb44fe47

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng
TBR=radial-bots+chrome-roll@google.com,syoussefi@google.com

Change-Id: Ic816c55699487e253bd1a7e1692afa191df60412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673832
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671625}

Roll src-internal 4c1d7938a05d..fb91be137da6 (3 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c1d7938a05d..fb91be137da6


Created with:
gclient setdep -r src-internal@fb91be137da6

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com

Change-Id: I0585b7b8d978f223025a7f363f7dd74c49260046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673848
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671624}

Replace use of std containers with WTF's equivalents in third_party/blink/renderer/core/inspector/

This CL replaces the use of std::vector of std container and
std::string with WTF::Vector, blink::WebVector and WTF::String in
third_party/blink/renderer/core/inspector/.

Bug: 952716
Change-Id: I65ebc1cfa013c18315a39c88a0eea3bb9fcc15da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662212
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#671623}

Roll src/third_party/catapult 566ad9545799..6643ef1bddde (2 commits)

https://chromium.googlesource.com/catapult.git/+log/566ad9545799..6643ef1bddde


git log 566ad9545799..6643ef1bddde --date=short --no-merges --format='%ad %ae %s'
2019-06-24 perezju@chromium.org Reland "[Telemetry] Make benchmark metadata in CreateResults optional"
2019-06-24 dberris@chromium.org PinpointScheduler: Integrate a FIFO Scheduler


Created with:
gclient setdep -r src/third_party/catapult@6643ef1bddde

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:973837,chromium:977488
TBR=sadrul@google.com

Change-Id: Ib0928bcae6ee5e1ca811d632871205dc7d220212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672769
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671622}

Reland: "Moved last version cache from the origin-policy...

...throttle to the network service origin policy manager."

This is step 4 of:
https://docs.google.com/document/d/1heiIgNdO7kbaU9BLOPO4wZ9maHScB87cGT5lyjeBVAM/edit#heading=h.4en9va43fgfj

The original CR was reverted because of crbug.com/969624.

I was unable to directly reproduce the issue on android but I'm pretty
sure the issue is that the callback was bound using `base::Unretained`
and then it was called on a destroyed OriginPolicyThrottle. I've
addressed this by using a `WeakPtr` reference. Everything else is the same.

Since this is the only difference from the original LGTM'ed CR, I will
just wait for an LGTM from a `/content/browser/` OWNER and add everyone
else from the original CR in TBR.

TBR=dcheng@chromium.org, vogelheim@chromium.org, mmenke@chromium.org, carlosil@chromium.org

Bug: 950905
Change-Id: Iba991b7c4b51e615afb56dcab03c9221c5b38abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666038
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671621}

Freeze a page for bfcache on FrameSwapOut / Unfreeze when restoring

Currently the bfcache prototype stores the document without freezing it.
This CL adds the freezing mechanism using the existing IPC message (Set
PageFrozen) as a starting point.
This CL adds the unfreezing mechanism in the same way.

Change-Id: Ibc27fd48c1a7bf6af136c70cd51a1b30400f825c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654669
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671620}

Move Fetcher class to OAuth2AccessTokenManager

This CL is a part of moving access token management to
OAuth2AccessTokenManager.

It moves Fetcher class from OAuth2TokenService to OAuth2AccessTokenManager
and |pending_fetchers_|. OAuth2AccessTokenManager manages
|pending_fetchers_| with FetchOAuth2Token() which creates Fetcher and
CancelFetchers() which cancels Fetcher.

OAuth2TokenService still opens APIs moved to OAuth2AccessTokenManager.
They will be removed once OAuth2AccessTokenManager fully manages access
tokens independently of OAuth2TokenService.

Bug: 967598
Change-Id: I9f02e7463a83f0a209ab0e81c3d16b3314c69acf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670026
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#671619}

Let WebUIIOSImpl handle the chrome.send message

This CL moves the handler method for "chrome.send" Js message from
CRWWebController into WebUIIOSImpl.

Bug: 956516
Change-Id: I2e19447f7416ae8eb727bc47d246d03d3fdc4488
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667348
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671618}

Roll src/third_party/webrtc abf7eba8658c..9aa870a2d107 (5 commits)

https://webrtc.googlesource.com/src.git/+log/abf7eba8658c..9aa870a2d107


git log abf7eba8658c..9aa870a2d107 --date=short --no-merges --format='%ad %ae %s'
2019-06-24 chxg@google.com Fixing fuzzer by backing up and restoring `packet_info`.
2019-06-23 sprang@webrtc.org Make useful padding the default.
2019-06-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b827eec031..ec99dbf1aa (671413:671513)
2019-06-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a8f7a25b6e..b827eec031 (671303:671413)
2019-06-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ffeecb2d27..a8f7a25b6e (671198:671303)


Created with:
gclient setdep -r src/third_party/webrtc@9aa870a2d107

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:977309 chromium:977411 chromium:977421 chromium:977422 chromium:977454 chromium:977455 chromium:977477 chromium:977457,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I9d6f9a87095e59f3e96585e88460ce06e3b8983e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673836
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#671617}

[iOS] Support dark mode on the main settings page.

This CL starts implementing dark mode support for the main settings
page. The main change introduced here is replacing the custom gray
colors kTableViewSecondaryLabelLightGrayTextColor and
kSettingsCellsDetailTextColor with Apple secondaryLabelColor, which
will be slightly different in light mode, even on iOS 12.

See the bug for before/after screenshots.

Bug: 976668
Change-Id: I3bc4d8d480b01cce53bbca14d5928a80a3794941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660506
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#671616}

cct_benchmark: Fix some warnings from Android Studio

Remove unnecessary casts, fix some javadoc syntax, remove an unnecessary
initializer.

Bug: 929926
Change-Id: Iae87750c61df121364b35414de80d3a17ca635cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667312
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671615}

cct_benchmark: Target CSV more precisely in the log

We added more log messages in MainActivity.java, which would be grabbed
by the python script, but would not provide the proper line in the CSV.
To address this make a dedicated prefix: CUSTOMTABSBENCHCSV.

Bug: 929926
Change-Id: If5891931609dc89017eb163467f4d6f8dc70c43c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667582
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671614}

Add UKM use counters for device sensor events.

Bug: 947112, 968941
Change-Id: I6e1e38da02bd25940cb8ce4321d810d456e0bf7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635673
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671613}

Rename SharingService::SendMessage -> SendMessageToDevice

SendMessage is a macro in Windows and right now that macro
can be defined when parsing the header but is removed in the
implementation file. That breaks the Windows jumbo builder.

The simplest way around this mess is to not use the symbol name
SendMessage.

Bug: 966045
Change-Id: Ie61596bc78fd91cf4dafb007f774cd3472da796a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672085
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671612}

Move csv_unittest dep from test_support to unit_tests

In components/password_manager/core/browser/BUILD.gn, since
https://crrev.com/c/1660659, test_supprot target depends on
csv_unittests. This is a mistake, the csv_unittest should have become
a dependency of unit_tests in the same BUILD.gn instead. The latter is
meant to include it in the overall test build target of
components/password_manager/core/browser, without merging it in the
big unit_tests target directly.

Bug: 934326
Change-Id: I70f987445d712ffb1c028bca72f6883b22027f9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672073
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Auto-Submit: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#671611}