Chromium Main Console
| Legend: | Passed | Failed | Failed Again | Running | Exception |
Roll Skia from e05860862631 to 04c82165b1c7 (5 revisions)
https://skia.googlesource.com/skia.git/+log/e05860862631..04c82165b1c7
2021-04-20 weiyuhuang@google.com [canvaskit] Add halfLeading to TextStyle and StrutStyle
2021-04-20 johnstiles@google.com Revert "Implement statements and expressions in DSL C++ code generator."
2021-04-20 borenet@google.com [infra] Update recipe deps
2021-04-20 jcgregorio@google.com Add Debug Pixel5 bot.
2021-04-20 johnstiles@google.com Implement statements and expressions in DSL C++ code generator.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jvanverth@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jvanverth@google.com
Change-Id: I6e8f55420b34f3095eee4046bcfaf549a0e6c8fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2841906
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874451}
Mojo: Introduce [NoInterrupt] attribute
GpuChannelHost uses its own custom sync waiting logic for the few sync
IPCs it sends. The key (and intentional) difference is that -- unlike
legacy and Mojo sync IPC -- it doesn't allow for wake-ups to dispatch
other incoming sync messages on the waiting thread.
This adds mojom support for a [NoInterrupt] attribute on [Sync] messages
to convey that such messages should employ the same behavior,
effectively only waking up for the caller's expected reply, or for other
sync messages *on the same pipe only* (which in practice is much easier
to control for, generally unlikely to be used, and not relevant to the
GPU case.)
Bug: 1196476
Change-Id: Ib14197cd7107d3c9388124d436e0548a350b599c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2815833
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#874450}
Roll NaCl from abf3277f295c to b788938e4b42 (3 revisions)
https://chromium.googlesource.com/native_client/src/native_client.git/+log/abf3277f295c..b788938e4b42
2021-04-20 fabiansommer@chromium.org Compile syscalls with -fno-builtin for clang
2021-03-30 fabiansommer@chromium.org Fix compiler warning for snprintf.c test
2021-03-01 fabiansommer@chromium.org Enable compilation of libnacl for saigo
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/nacl-autoroll
Please CC mseaborn@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: chromium:1106311
Tbr: mseaborn@chromium.org
Change-Id: I596fb86a48b7c1a674c1f101ecedd61afe8a9e43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2841907
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874449}
Update minSdkVersion for generate gradle
Change-Id: Ib9897000010282cf020edbd519edb3fa05dd2fbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2832122
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874448}
[Lacros] Remove PRIMARY selection usage.
The PRIMARY selection specifies copy on highlight and paste on middle-
click. These features are inherited by Lacros from its Linux origin, but
should be removed for consistency with ChromeOS.
This CL follows "ClipboardBuffer::kSelection" usage and removes the
usage of PRIMARY selection on a case-by-case basis.
In /content and /ui, several build flag usage are replaced with
ui::Clipboard::IsSupportedClipboardBuffer() usages. To accommodate the
more frequent usage, caching is added to the function.
Also reenable PDFExtensionClipboardTest.CombinedShiftArrowPresses for
Lacros.
Bug: 1198816, 1121446
Change-Id: I6c73c00f0ad6ebeb56c7491dffc5e3315e3d5659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826851
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874447}
PaintTreeWalk: Avoid temporary allocations
PaintTreeWalk is a stack-scoped object that accumulates a significant
amount of temporary objects:
- Avoid dynamic allocation of PaintTreeWalk itself;
- Eagerly freeing the backing of context_storage_ which may accumulate
several MB floating garbage;
- Revert PaintPropertyTreeBuilderContext to an inlined object with
Trace() method to avoid another temporary allocation;
Bug: 1197697
Change-Id: I6b5abc1e63b1919b5b816791f0eec2f5db75acf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2831589
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Yuki Yamada <yukiy@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874446}
[Code health] Enable gn check for declarative_net_request:*
This CL enables gn check for
//extensions/browser/api/declarative_net_request:*. This is done by
making a single target for
//extensions/browser/api/declarative_net_request:*,
//extensions/browser/api/web_request:*,
//extensions/browser/api/activity_log and
//extensions/browser:browser_sources.
Bug: 1158944
Change-Id: I14a5685ea6e01994446a23d808c831957d13fdce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2776191
Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874445}
Fix double-callback-call crash in //components/services/quarantine/
Fix the potential crash caused by an attempt to run a OnceCallback
twice.
This issue was found by the "bugprone-use-after-move" clang-tidy
diagnostics:
components/services/quarantine/quarantine_chromeos.cc:23:
'callback' used after it was moved
components/services/quarantine/quarantine_chromeos.cc:21:
move occurred here
Bug: 1169863,1122844
Change-Id: Id7ee1959f7197d7c5137fb4d8c2ccb611f5159e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2842003
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874444}
Stabilize storage tests after on-thread destructor
After crrev.com/c/2787772 storage queue destructor is running
asynchronously on a thread, and so the caller must wait for all
threads to idle in order to be sure everything is released.
Re-enabling previously flaky tests too.
Verification: running the test as
tools/run-swarmed.py out/win components_unittests \
--gtest_filter="*/Storage*Test.*" --gtest_repeat=100
No failures detected:
https://chromium-swarm.appspot.com/task?id=5309b80d78577110
as opposed to the baseline failing:
https://chromium-swarm.appspot.com/task?id=5309d17dccfef810
Bug: 1195296, 1194943, 1194626
Change-Id: I3af8d52ff21331b8f2e153401fb4d12f0ec62068
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2841643
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Reviewed-by: Zach Trudo <zatrudo@google.com>
Cr-Commit-Position: refs/heads/master@{#874443}
cros: NonClientFrameViewAsh's context menu handles immersive fullscreen
Currently, `NonClientFrameViewAsh::ShowContextMenuForViewImpl()`
performs a NonClientHitTest using the given point. If hit test returns
HTCAPTION, then the context menu is shown. However, when a window is in
immersive fullscreen, this hit test returns HTCLIENT so the context menu
won't be shown.
This CL modifies `NonClientFrameViewAsh::ShowContextMenuForViewImpl()`
so if its window is in immersive fullscreen, it will check whether the
given point lies in `header_view_` manually.
Bug: 1163997
Change-Id: I93b39369ecd6182d2435b6c780d2dc7090364e2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2840167
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874442}
Roll DevTools Frontend from c26c9ef40be1 to ea1fa7ba7e60 (1 revision)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c26c9ef40be1..ea1fa7ba7e60
2021-04-20 kahinds@microsoft.com [Dark Mode] Remove hard-coded colors from javaScriptBreakpointsSidebarPane.css
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: chromium:1152736
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: If518e273791b47b3f78ff3d69ced418911ce7501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2841405
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874441}
Add an anchor IDL attribute to <popup>, readonly for now
This CL exposes the anchor element as an IDL property. This will be
useful with the anchor positioning proposal (which isn't out yet).
Bug: 1168738
Change-Id: Ia47514dada57c44191c7af439b0051f3e3d26622
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2832148
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#874440}
Add src-side configs for bionic CI+try mirrors of Lsan bot.
Note that the xenial CI bot has a builder tester split, while this
bionic version has both merged into a single builder. That's done to
simplify the configs a little, and shouldn't impact the results of
compile & test pass/fail.
Bug: 1200574
Change-Id: I5a298f86b0fd9d531db18a8de83499f4c596af95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2841347
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874439}
Update openscreen OWNERS
Bug: None
Change-Id: Ibcc5c23399c95107dfabfbe44e6d15f86084e855
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2841883
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874438}
Update V8 to version 9.2.64.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/916e3bba..0a9df1ea
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
Change-Id: I272715e2aef650280d70f2023695899db0a46209
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2840945
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874437}
[Extensions] Change `function` to `func` in chrome.scripting
chrome.scripting.executeScript() can take in a function (which is then
serialized and injected into the target frame). This is passed via a
`function` property on the injection details object. However, this is
incompatible with JS's object declaration shorthand.
Instead, change this property to `func`, as below:
function func() { ... }
const target = { ... }
chrome.scripting.executeScript({ target, func });
For backwards compatibility, supplying `function` will continue to
work. We'll remove support for `function` in M95.
Update all existing tests to use the `func` property, and add
additional tests for the backwards compatibility using `function`.
Bug: 1166438
Change-Id: Icb4ba909786518f44e2d8607837c92d43aab70c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2829941
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874436}
Adding myself as a reviewer after passing the test.
Change-Id: I5c27fbac3b6b9d8931799f819ebfa8a7e6260ef4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837183
Auto-Submit: Javier Flores <javierrobles@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874435}
webauthn: don't advertise phone as a security key if no screen lock.
GMSCore fails all FIDO requests if a screen lock isn't configured on the
device. Therefore a phone shouldn't advertise itself in Sync in that
case.
Since I'm not sure about the cost of checking this (i.e. it's probably
an RPC call), don't do it during startup. Instead wait until Sync is
preparing to publish device-info before checking this. Also, don't
register an FCM token until we have checked all the requirements in
order to save on traffic to the FCM service.
Lastly, because someone could remove a screen lock after Sync has
published, catch this case and show an error. For now there's not a
specific string but there probably will be in the future.
BUG=1002262
Change-Id: I001bcbc1588d2ef929946d63915c9e47306fedc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838227
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874434}
Lacros: Add all potential testing boards' sdk data as data dependencies
There is a plan to refactor Lacros VM/Device tests to specify testing
args at runtime instead of at build time, and one of the implications
is that at build time, GN doesn't know the targeted testing board
anymore, therefore, all the potential testing boards' sdk data needs to
be added as data dependencies so that they'll be isolated.
Bug: 1195415
Change-Id: I94ff179f868568b1abd6e1a76bb22105d32ca754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2832144
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874433}
[AW] ComponentUpdater: log unfinished jobs
Add UMA logging for unfinished jobs in AwComponentUpdateService.
Bug: 1171817
Change-Id: I6846aafe1d0368c962a50e1d8c65ea065990fab5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2828401
Commit-Queue: LaÃs Minchillo <laisminchillo@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874432}
If no animation is necessary after copy, just end animation.
This happens when LockWithoutAnimation is used. Ideally we should
just skip everything when the immediate type is specified, but I'll
change it in a separate CL.
For testing, TestSessionStateAnimator makes it impossible to test in the
lock_state_controller_unittest because it mocks out everything. We
should simply use the real implementation + MOCK_TIME instead, and I'll look into it as well.
Bug: 1197829
Test: covered by unittests
Change-Id: I41edc6684b13b75b18f5d510168f0a5257cb6763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838506
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874431}
Extend Stability.iOS.UTE.OSVersion expiration
Extend epiration to match some of the other Stability.iOS.UTE histograms
so they can be extended simultaneously in the future.
Bug: 1190939
Change-Id: I428be726838e67f0977d5f8b387f2dd152fedcb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2836670
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874430}
Roll Depot Tools from 4ea67bbd15c5 to ce8bb16e706e (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4ea67bbd15c5..ce8bb16e706e
2021-04-20 tikuta@chromium.org update led
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Bug: chromium:1200494
Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com
Change-Id: I2744fb55294519c75f91d1184b3b02a4b01136c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2841410
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874429}
mojo: Use =default for ctors and dtors.
Change-Id: I72e08f872db240bbf43bbb0df1493f6abe79755c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2833678
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874428}
Select to Speak correctly translates touch events' root coordinates.
Select to Speak translates touch events into mouse events in C++
to send to the extension. Root coordinates were not being calculated
correctly when the touch event had a target. This fixes the bug,
allowing Select to Speak touch to draw focus rings work on non-primary
touch screens, and work correctly as long as the primary and non-primary
monitors have the same DPI (see crbug.com/1200505).
primary display. Selecting by touch works on the correct display.
non-primary touchscreen monitor.
Test: Touch screen chromebook with external monitor which is set to
Bug: 1199966
Change-Id: Ifdeec77916114da947964c1dfce76b957f206b02
AX-Relnotes: Select to Speak can use touch to make selection on
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837347
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874427}
Rerun tests with UNKNOWN status.
Tests that are ran in a batch wont get run if a test in the batch
crashes, so retry those tests. Additionally, if a test in batch
keeps crashing, but is not recognized as a crash, then the problem
would continue, so unbatch the tests on subsequent retries.
Change the status of tests when there is crash that isn't recognized as
crash to NOTRUN. This will still get marked as flaky when it gets tried
individually on subsequent retries, but ideally shouldn't happen.
Bug: 1127935
Change-Id: Ia95f2861704a547ebb659580692034e1be6e23f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2823027
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874426}
[CrOS Settings] Check in Polymer3 version of Reset section
Note that this CL is listed as an example in
go/cros-settings-checking-in-polymer3.
Bug: 1180979
Change-Id: Ibe0e6c2cd22f35ef2228fc77aff81de15297ec17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838517
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874425}
Remove CullRectUpdate variant of unit tests
Now CullRectUpdate is implied by CompositeAfterPaint, and we are
unlikely to launch CullRectUpdate in pre-CAP.
This removes 961 blink_unittest cases.
Change-Id: Ifb881ddc13826f7c3b3407f2332f7d385b8deb22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838075
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874424}
Enable bilinear blur optimization in Skia
Reduces number of texture samples required per pass of a blur by ~1/2.
Bug: skia:11796
Change-Id: I0778862cf262f6d8e81652c9efccab47919552c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2831811
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#874423}
Roll Skia from 94df572a1374 to e05860862631 (2 revisions)
https://skia.googlesource.com/skia.git/+log/94df572a1374..e05860862631
2021-04-20 kjlubick@google.com [canvaskit] Fix transform() call in test
2021-04-20 kjlubick@google.com [canvaskit] Split paragraph_bindings into two files for generation POC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jvanverth@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jvanverth@google.com
Change-Id: Ia1ec20a8e6d37d45c0a8819b6602dafd4cb0ba73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2841406
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874422}
Delay expiry of histograms causing alerts.
Updates the expires_after attribute for 47 histograms that have
been used to generate alerts in the past 180 days and do not already have
a date later than or within 60 days of 2021-07-19.
TBR=chromium-metrics-reviews@google.com
Change-Id: I3cfea2f046a40a014a5587bbf7794f82e0592bfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837371
Bot-Commit: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874421}
[Nearby] Measure time from Accept to payload transfer
This CL adds a metric to measure the time between a receiving
device acceptig a share and the first payload byte being processed.
Bug: 1199152
Change-Id: Ib233a583cea5046b39edaa5a0c8040a94767438e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2827271
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Commit-Queue: Claude van der Merwe <cvandermerwe@google.com>
Cr-Commit-Position: refs/heads/master@{#874420}
[memories] Cast longs to string instead of double for JSON request.
JSON doesn't support long integers (or at least base::Value doesn't).
Currently, the visit ID and timestamp are therefore cast to doubles when
forming the request. However, this results in rounding (e.g.
10,000,000,001 is represented as 1e10).
This CL instead casts those fields to string.
Also, moves the functions in memories_remote_model_helper.cc's anon
namespace to an anon namespace nested inside the history_clusters
namespace to avoid repeating the history_clusters::.
Bug: 1179068, 1171352
Change-Id: I19dd976ab6654be9298f2e544422e9abb81c9b19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2832150
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874419}
drm/ozone: Change modeset interface to pass planes list
Change the modeset interfaces to take an overlay planes list instead of
a single primary plane to modeset with.
This allows us to extend it later to modeset with multiple planes
(Primary + Overlay).
BUG=b:185899132
TEST=HardwareDisplayControllerTest.*
Change-Id: Ia5e37b7f3ac8ee02c8d06687a78561a265e29e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2840166
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874418}
Roll Perfetto Trace Processor Mac from 7c32f5298377 to 3ff228ffc070
https://android.googlesource.com/platform/external/perfetto.git/+log/7c32f5298377..3ff228ffc070
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: Ie5c1e02ddfc4a6bcc78580a22ed48b8747863daf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2840986
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#874417}
Update default CSD model to version 8
We're about to launch v25 to Stable 100%, so update the default behavior
Change-Id: If53d60f9ca8787ba25a9d09d125b31f2ed0800a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838325
Commit-Queue: Bettina Dea <bdea@chromium.org>
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874416}
Fix message center access to GetNativeTheme()
This CL adds checks for the Views' Widget on operations that require
system theme colors obtained via View::GetNativeTheme(). This prevents
fallthrough to the global NativeTheme instance.
In all cases the methods are called during OnThemeChanged() allowing
the view to source the correct colors when actually needed.
Bug: 1056916
Change-Id: I2cab8455c0d437d4ee2b82e1d3711f0543e58960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2838238
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874415}
Change Namespace of CastRuntimeService
Change the namespace to better align with internal Chromecast code
Change-Id: I0144c16946814e83baacf0e87b62afeb0776f97d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837254
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Ryan Keane <rwkeane@google.com>
Cr-Commit-Position: refs/heads/master@{#874414}
Implement imperative slotting API changes
The original implementation of the imperative slot distribution
API was done before the final spec PRs landed. In the process of
landing those PRs, several changes were made to the way the API
works. Primarily, there are two changes:
1. The "auto" slotAssignment mode was renamed to "named".
2. The "linkage" that is created by HTMLSlotElement.assign() was
made more permanent. Previously, moving either the <slot> or
the assigned node around in the tree (or across documents)
would "break" the linkage. Now, the linkage is more permanent,
and the only way to break it is through another call to .assign().
See [1] for the chromestatus entry, [2] for the intent to ship,
[3], [4], and [5] for the spec PRs, and [6]/[7] for the landed spec.
[1] https://chromestatus.com/feature/4979822998585344
[2] https://groups.google.com/a/chromium.org/g/blink-dev/c/6U78F3KWJ78
[3] https://github.com/whatwg/html/pull/6561
[4] https://github.com/whatwg/html/pull/6585
[5] https://github.com/whatwg/dom/pull/966
[6] https://dom.spec.whatwg.org/#find-slotables
[7] https://html.spec.whatwg.org/#dom-slot-assign
Fixed: 1196842
Fixed: 1067153
Bug: 1067157
Change-Id: I0ee71043c23f3b49a1461296d722045f06eca540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2824763
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874413}
Initialize CSSGlobalRuleSet for documents with a Frame
There was a bug with custom scrollbars which caused a crash when
querying style for scrollbars on a detached document. That issue was
fixed in [1]. Try to re-introduce creating CSSGlobalRuleSet for
documents with a Frame only.
[1] https://crrev.com/3bbc1bdc810dc0f9a37226443b60eb6bf20c05b2
Bug: 1198601
Change-Id: I453ca3a3643abe693b48e7e8bb7cb0286cd6c46a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837973
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874412}
Delay expiry of frequently used histograms.
Updates the expires_after attribute for 195 histograms that show
frequent access in the past 180 days. These are the 99% most
frequently used histograms over that time that do not already
have a date later than or within 60 days of 2021-07-19.
TBR=chromium-metrics-reviews@google.com
Change-Id: I257d678cb851ed9a9880086e92497b80e6234e68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837372
Bot-Commit: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874411}
[iOS FRE] Add support for dynamically changing button text
Adds a setter for the primary button text in the FRE screen shared view
controller that updates the primary button's label text when called.
This is needed for certain scenarios in the new FRE, such as the sign-in
screen.
Also updates one of the fake FRE screens in the Showcase project to use
this setter to dynamically change the primary button text at runtime.
Bug: 1186762
Change-Id: I15983467d6dd6fbdc7a0234a6c615110b17635a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2830940
Commit-Queue: Guillaume Jenkins <gujen@google.com>
Reviewed-by: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874410}
Deflake percentage-mousewheel-scroll test
Issues:
* Test did not check if a wheel event was received
* Wheel event not always dispatched the scroll element being checked
* Tests do not clean up after themselves
Bug: 1200880
Change-Id: Ia53105822da12607528e7205e5faf8bd7a4ae61b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2841243
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874409}
Fix JS console errors in post oobe multidevice setup
This CL fixes console errors in post oobe multidevice setup
caused by calling i18n on variables that are initially undefined.
Bug: 1188332, 1188322, 1023691
Change-Id: I6521fa068b8e634bcd7ef1b07d5dfcbae271e6dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2832595
Commit-Queue: Claude van der Merwe <cvandermerwe@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874408}
Remove no-longer-needed use counter
Bug: 703053
Change-Id: I76ea8bd4553b1b4de92f0036c6413f8afd23d477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837477
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874407}
Reland "Enable AXTreeSerializer to support partial serialization."
This is a reland of 7874d936230c5fced15b0fd6e931eba9e6de21b7
Original change's description:
> Enable AXTreeSerializer to support partial serialization.
>
> Previously AXTreeSerializer already supported the idea of
> stopping after a certain amount of time or a certain
> number of nodes had been serialized, but it was only
> intended to be used for a one-time tree snapshot.
>
> This change enables AXTreeSerializer to return the
> list of incomplete nodes, so that you can follow up and
> finish serializing the tree.
>
> This is a useful building block in reducing accessibility
> jankiness.
>
> Bug: 1200437
> AX-Relnotes: N/A
> Change-Id: I6857fe1957418ddbd47fa75c3409e2ac12117e62
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2832493
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#874090}
Bug: 1200437
Change-Id: I9c2a0ab07f3c0bc23ee23468220e10bcde5b160f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2840884
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874406}
Remove UnignoredSelection from caret event firing on Windows
Now that focused nodes are never ignored (http://crbug.com/1144707), we
no longer need to do expensive GetUnignoredSelection calls in cases
where we know the node in question will have focus. We're seeing a
number of hangs in these UnignoredSelection calls, which this will
mitigate.
No behavior should change as a result of this, and we have lots of
existing tests for event firing, so no additional tests were added.
Bug: 1045761
Change-Id: Ic547dc7ef32f0773ac47bf77fdbb7551c95ad2bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2828478
Reviewed-by: Ian Prest <iapres@microsoft.com>
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#874405}
[omnibox] Optimize Pedals concept matching by eliminating vector copies
This CL eliminates frequent vector allocations by reusing a
resident TokenSequence on OmniboxPedalProvider. Call structure is
improved for more efficient processing. Code and tests are cleaned up.
Bug: 893183
Change-Id: I453bba239870b7ff445d84a80ae253cd30fb31a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2837206
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874404}
Remove unused ShadowMultiDex reference from ApplicationStatusTest
It's unused and caused the test to fail locally for me with:
Caused by: java.lang.ClassNotFoundException: android.support.multidex.MultiDex
Bug: None
Change-Id: I6663a9f723911f8ac8929bf876f097f73438fe5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2841085
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: benjamin joyce <bjoyce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874403}
Document User Actions NavEntryCommitted*
Bug: 1196082
Change-Id: Ic8189f58f9e5a5375774faf54b493607af1a6d7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2808313
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#874402}