Chromium Main Console

Simplify candidate selection in HTMLImageElement::SelectSourceURL

Rather than using the |found_url| local, recognize that it is equivalent
to !candidate.IsEmpty(), and use regular control flow instead.

Change-Id: I5f28a4099bc4252ec9ea5b9ed616116f64b97ace
Reviewed-on: https://chromium-review.googlesource.com/1196383
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#588048}

Collect UMA data for SiteIsolatedCodeCache

Adds SiteIsolatedCodeCache.Behavour histogram. This collects the
behaviour of site isolated code cache for each request received.
It records if the request was serviced and if serviced how it was
serviced for ex: hit, miss, update.

Bug: chromium:812168
Change-Id: Ie9e45af8e72dee6fafc1b088c139b7b87fcc0851
Reviewed-on: https://chromium-review.googlesource.com/1196430
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588047}

webauthn: fix to transport selection when no internal credential is available

This addresses an issue with GetAssertion requests for a credential in
the Touch ID authenticator that does not/no longer exist on the current
machine. Currently in this case, the UI will never consider kInternal as
a candidate transport. It follows that if there is only one other
transport available, the UI will advance straight to that transport. It
should instead proceed to transport selection (unless there is a last
used transport preference that would take precedence).

Bug: 879525,849323
Change-Id: I9602fdc7c68f4dc0ba391b6e3b6a007edbb9c6de
Reviewed-on: https://chromium-review.googlesource.com/1199324
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588046}

Remove many Viz testing configs

VizDisplayCompositor was already in field trials on Linux and Windows. It has
now entered trials on Android and Mac.

This change removes viz_content_browsertests from both Android and Mac. It also
removes viz_browser_tests and viz_content_unittests from Mac (these don't run on
Android anyways.)

This leaves viz_* specific test variants on ChromeOS, as well as a series of FYI
bots we maintain.

While I was cleaning this up I also removed linux_viz_isolated_scripts, as the
telemetry suites are covered by the field trials. I also removed main of the
exceptions we had, as the viz_* variant no longer runs on those bots.

TEST= viz_browser_tests, viz_content_browsertests, viz_content_unittests,
telemetry_perf_unittests_viz, telemetry_unittests_viz

Bug: 787097
Change-Id: I2257f1eaeb06139588e1dcf6b9448c2749e2a59f
Reviewed-on: https://chromium-review.googlesource.com/1199682
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588045}

[UnifiedConsent] Don't show consent bump when logged out

If ForceUnifiedConsentBump flag is on, the consent bump should not be
shown if the user is logged out.

Change-Id: I6a28e6ad5da1b0f12828810abeb06b83f5007c31
Reviewed-on: https://chromium-review.googlesource.com/1199342
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588044}

cronet: treat cronet_test_instrumentation_apk as a test in gn_isolate_map.

Bug: 861983
Change-Id: I745b67a04cbd5186faee655e9e42d8afd5486999
Reviewed-on: https://chromium-review.googlesource.com/1198526
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588043}

[LayoutNG] Fix when 'vertical-align: top' is nested

The 'vertical-align: top' and 'bottom' require the size of
the ancestor line box and thus are put into pending queue
while applying the baseline shift.

When they are nested, processing all pending queue at the
root line box applies the shift multiple times. This patch
puts into the queue of the nearest ancestor that has 'top'
or 'bottom' if exists.

Bug: 877977
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I6541d138267a6e42658b601901b673352e625440
Reviewed-on: https://chromium-review.googlesource.com/1198887
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588042}

Move Autoplay feature policy tests to html dir

Change-Id: I2b60a751ad4c3ad87e6a9e75d55e2f96698e88b9
Reviewed-on: https://chromium-review.googlesource.com/1198571
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588041}

Reland "Reland "Convert tcp_device_provider.cc to mojo host resolver""

This reverts commit da9bf1cfbf2322a851c57d03a81984bbc54da873.

Reason for revert: Looks like I may have reverted this due to
crashes that this CL was already reworked to fix.

Original change's description:
> Revert "Reland "Convert tcp_device_provider.cc to mojo host resolver""
>
> This reverts commit 6493250fe611b19a614864d8040446066f0134c0.
>
> Reason for revert: This is a top crasher on Canary. See
> https://crash.corp.google.com/browse?q=product_name%3D%27Chrome%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27canary%27+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27content%3A%3A%60anonymous+namespace%5C%27%3A%3AGetStoragePartitionMap%27&stbtiq=&reportid=&index=0
>
> Original change's description:
> > Reland "Convert tcp_device_provider.cc to mojo host resolver"
> >
> > This is a reland of ac880b3ad00b2f206ff8a9fddaff004763370b03
> >
> > Switched to using
> > ChromeDevToolsManagerDelegate::GetDefaultBrowserContext() which
> > outlives TCPDeviceProvider. The original was reverted because of a
> > crash when TCPDeviceProvider tried to access a destroyed
> > BrowserContext, see http://crbug.com/879060.
> >
> > Original change's description:
> > > Convert tcp_device_provider.cc to mojo host resolver
> > >
> > > Bug: 874653
> > > Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd
> > > Reviewed-on: https://chromium-review.googlesource.com/1185626
> > > Commit-Queue: Clark DuVall <cduvall@chromium.org>
> > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#586738}
> >
> > Bug: 874653
> > Change-Id: Ia6c00ba51020473f820add8c4257f3bf16fd5b24
> > Reviewed-on: https://chromium-review.googlesource.com/1197265
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Commit-Queue: Clark DuVall <cduvall@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#587750}
>
> TBR=caseq@chromium.org,ericorth@chromium.org,cduvall@chromium.org
>
> Change-Id: I10a1bc2d22694a2f11be28bc5acb925610a7a017
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 874653
> Reviewed-on: https://chromium-review.googlesource.com/1199565
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588028}

TBR=caseq@chromium.org,mmenke@chromium.org,ericorth@chromium.org,cduvall@chromium.org

Change-Id: I584f46586aaef26203dddbcdbfdf0fd7e2be0741
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 874653
Reviewed-on: https://chromium-review.googlesource.com/1199566
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588040}

Revert "Remove SeparateTaskcustomTabActivity for Android version > L."

This reverts commit aa76bac1230fc0b510d0299a5b51b6c2bdc86682.

Reason for revert: https://crbug.com/879587

Original change's description:
> Remove SeparateTaskcustomTabActivity for Android version > L.
>
> Make SeparateTaskcustomTabActivity to be used only for Android version
> pre L. The part used for Android version >= L is merged into
> CustomTabActivity.
>
> This is a prerequisite for skipping the ChromeLauncherActivity and
> directly launch the CustomTabActivity.
>
> Bug: 681559
> Change-Id: Ifc33e25486bf70cb4fb25c15e6c33e16d6683157
> Reviewed-on: https://chromium-review.googlesource.com/1188565
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587995}

TBR=tedchoc@chromium.org,lizeb@chromium.org,arthursonzogni@chromium.org

Change-Id: Iea4eb59149d1562edb021e01571c28d01b158f11
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 681559
Reviewed-on: https://chromium-review.googlesource.com/1199346
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588039}

Handle non-image backgrounds in BoxModelObjectPainter::PaintTextClipMask

When we paint a background color for a line, we don't adjust the paint
offset based on the logical offset on the "virtual line", so we mustn't
try to undo the adjustment in BoxModelObjectPainter::PaintTextClipMask
when we're generating the mask for "(-webkit-)background-clip: text".

Check the |object_has_multiple_boxes| and don't undo the adjustment if
it is false.

Bug: 879292
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9ec9c5cdfeb675803e54407f2e98e39b2dc1bc6b
Reviewed-on: https://chromium-review.googlesource.com/1199343
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#588038}

Roll src/third_party/angle fd1621076a74..064458a8f818 (1 commits)

https://chromium.googlesource.com/angle/angle.git/+log/fd1621076a74..064458a8f818


git log fd1621076a74..064458a8f818 --date=short --no-merges --format='%ad %ae %s'
2018-08-31 oetuaho@nvidia.com Remove separate ANGLE_texture_multisample_array


Created with:
gclient setdep -r src/third_party/angle@064458a8f818

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I9c2ff80b7fd311d5f886eecd82fd64d25dfc1e11
Reviewed-on: https://chromium-review.googlesource.com/1199702
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#588037}

Add an item to media router context menu for media remoting

Add an item labelled "Optimize fullscreen videos" to the context menu
of the Cast toolbar icon behind the ViewsCastDialog flag. Toggling
this enables/disables media remoting.

Bug: 878540
Change-Id: Ic1003d6ee9e38bd87d9807aa69e5ef5d23e9b637
Reviewed-on: https://chromium-review.googlesource.com/1194972
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588036}

Modernize InstallUtil::GetCriticalUpdateVersion.

- Migrate from BrowserDistribution to install_static.
- Treat base::Version as a value type.

BUG=879568
R=huangs@chromium.org

Change-Id: I4bf2cf5558945d09d3f73acaf015ace3ce7f1c68
Reviewed-on: https://chromium-review.googlesource.com/1195094
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588035}

[iOS] Increase visibility of OpenIn for pdfs

This CL increases the visibility of the OpenIn toolbar in the pdf pages.
The toolbar is now visible when the page is loaded and stays visible
until the user interacts with the page (tap, scroll...).
It is also appearing when the user scrolls up (same as the bottom
toolbar behavior).

Bug: 845563
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I27b2018288c11cc4500a5f48ed47be4bad1d3848
Reviewed-on: https://chromium-review.googlesource.com/1198770
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588034}

[TaskScheduler]: Use ScopedBlockingCall to mark blocking tasks.

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/profiles.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
- ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
If this is not the case, ScopedBlockingCall should be instantiated
closer to the blocking call. See scoped_blocking_call.h for more
info. Please let me know when/where the blocking call happens if this needs
to be changed.
- Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
BlockingType for more info. While I assumed MAY_BLOCK by default, that might
not be the best fit if we know that this callsite is guaranteed to block.
- The ScopedBlockingCall's scope covers the entirety of the blocking operation
previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=mmenke@chromium.org

Bug: 874080
Change-Id: I21475ba8f80e505e7310d6b6689cc2a40f047583
Reviewed-on: https://chromium-review.googlesource.com/1191798
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588033}

Add WebFrame CallJavaScriptFunction API with callback support.

Bug: 851636
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia38941b0cea3fc093dd04d14e9514dcb34823746
Reviewed-on: https://chromium-review.googlesource.com/1192424
Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588032}

Reland "Convert fast/scrolling layouttests to use gpu benchmarking."

This is a reland of 53107676c317d047f726c6172b8649f5fd564522

The reland excludes the following tests from conversion since using gpu
benchmarking makes them flaky:
-fractional-scroll-height-chaining.html
-scrollbar-mousedown-mouseup.html
-subpixel-overflow-mouse-drag.html

Original change's description:
> Convert fast/scrolling layouttests to use gpu benchmarking.
>
> This cl converts all tests in fast/scrolling that are using event sender
> other than the following two keyboard tests:
> keyboard-scroll-before-layout.html
> keyboard-scroll-page-scale.html
>
> Bug: 846424
> Change-Id: Id6c10046d591724c347bf931ae877e1cb8b7d3c2
> Reviewed-on: https://chromium-review.googlesource.com/1196826
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587687}

TBR=bokan@chromium.org

Bug: 846424
Change-Id: Idc192917017424c64a2f9b0cc2a3a32e49eb3817
Reviewed-on: https://chromium-review.googlesource.com/1199605
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588031}

Delete password force-saving feature.

It's not gonna be launched as there is manual saving via the omnibox icon.

Bug: 484891
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ic78db57f9028573f227b154e4099d10b5088411a
Reviewed-on: https://chromium-review.googlesource.com/1196345
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588030}

Clean up Performance placeholder API for translate.

performance.now() is in WKWebView now.

Bug: 877709
Change-Id: I2717df09894049105e159e50b62a91bf12faf929
Reviewed-on: https://chromium-review.googlesource.com/1188491
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588029}

Revert "Reland "Convert tcp_device_provider.cc to mojo host resolver""

This reverts commit 6493250fe611b19a614864d8040446066f0134c0.

Reason for revert: This is a top crasher on Canary. See
https://crash.corp.google.com/browse?q=product_name%3D%27Chrome%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27canary%27+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27content%3A%3A%60anonymous+namespace%5C%27%3A%3AGetStoragePartitionMap%27&stbtiq=&reportid=&index=0

Original change's description:
> Reland "Convert tcp_device_provider.cc to mojo host resolver"
>
> This is a reland of ac880b3ad00b2f206ff8a9fddaff004763370b03
>
> Switched to using
> ChromeDevToolsManagerDelegate::GetDefaultBrowserContext() which
> outlives TCPDeviceProvider. The original was reverted because of a
> crash when TCPDeviceProvider tried to access a destroyed
> BrowserContext, see http://crbug.com/879060.
>
> Original change's description:
> > Convert tcp_device_provider.cc to mojo host resolver
> >
> > Bug: 874653
> > Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd
> > Reviewed-on: https://chromium-review.googlesource.com/1185626
> > Commit-Queue: Clark DuVall <cduvall@chromium.org>
> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#586738}
>
> Bug: 874653
> Change-Id: Ia6c00ba51020473f820add8c4257f3bf16fd5b24
> Reviewed-on: https://chromium-review.googlesource.com/1197265
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587750}

TBR=caseq@chromium.org,ericorth@chromium.org,cduvall@chromium.org

Change-Id: I10a1bc2d22694a2f11be28bc5acb925610a7a017
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 874653
Reviewed-on: https://chromium-review.googlesource.com/1199565
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588028}

[TaskScheduler]: Use ScopedBlockingCall to mark blocking tasks.

This CL uses ScopedBlockingCall to mark blocking calls in /components/arc.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
- ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
If this is not the case, ScopedBlockingCall should be instantiated
closer to the blocking call. See scoped_blocking_call.h for more
info. Please let me know when/where the blocking call happens if this needs
to be changed.
- Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
BlockingType for more info. While I assumed MAY_BLOCK by default, that might
not be the best fit if we know that this callsite is guaranteed to block.
- The ScopedBlockingCall's scope covers the entirety of the blocking operation
previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=hidehiko@chromium.org

Bug: 874080
Change-Id: Ia1f51ac98e70110b6c405a8a56e792b6a0ff1aca
Reviewed-on: https://chromium-review.googlesource.com/1190928
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588027}

views: make AccessiblePaneView not restore focus in some cases

Specifically if the View is still valid, but not in the same widget, then
it should be ignored.

BUG=871899
TEST=covered by test

Change-Id: I4d219df773c47113f4038a2163174d3041e684c5
Reviewed-on: https://chromium-review.googlesource.com/1195840
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588026}

[TaskScheduler]: Update doc for assertBlockingAllowed().

Using ScopedBlockingCall is preferred to assertBlockingAllowed as it also serves
as annotation. This CL updates documentation on assertBlockingAllowed() to
describe that.

TBR=gab@chromium.org

Bug: 874080
Change-Id: I1e5b8e85c2defb9a87e2b1784f2ea86cb69019c1
Reviewed-on: https://chromium-review.googlesource.com/1197286
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588025}

Add Android settings OWNERS for passwords

Java code for password settings on Android has its own OWNERS file, but
for the tests, only the higher-level settings OWNERS file applies.

This CL introduces the corresponding password-specific OWNERS file for
the tests as well, to allow distribute reviewer load and cover more
timezones by potential reviewers.

Bug: None
Change-Id: I599cfb6b25bab26f95935f1a7fe103ff565f5338
Reviewed-on: https://chromium-review.googlesource.com/1199062
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588024}

IDL compiler: Fix IDL compiler to install conditional methods on instance

Before this CL, IDL compiler tried to install all conditional methods
on a prototype object or an interface object (=prototype chain).
However, in some cases, we have to install them on an instance object.
(e.g. Operations defined on a [Global] interface.)
https://heycam.github.io/webidl/#es-operations

This CL fixes IDL compiler behavior as expected.


Bug: 878566
Change-Id: I7efa6df6e6f452d87da82180b21d046b994c5e67
Reviewed-on: https://chromium-review.googlesource.com/1198884
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588023}

Rename WPT_BASE_MANIFEST.json to WPT_BASE_MANIFEST_4.json

Gerrit has trouble with very large diffs and
https://chromium-review.googlesource.com/c/chromium/src/+/1183425 has
not been possible to land for over a week.

As a workaround, put the manifest version in the base manifest file
name. When the manifest version changes, at least this time, we'll add
WPT_BASE_MANIFEST_5.json, update the code to use that, and then later
remove WPT_BASE_MANIFEST_4.json.

Bug: 876717
Change-Id: I98c5cae3bb650daae347d20fc2c83817e91e726b
Reviewed-on: https://chromium-review.googlesource.com/1196405
Reviewed-by: Luke Bj <lukebjerring@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588022}

Remove background_view from MessageView.

MessageView had |background_view_| in order to just change paint
ordering of Background and Border. It caused focus painter not to be
painted in the right order. We no longer have shadow borders so we
don't have to change the paint ordering.

TEST=manual
BUG=877939

Change-Id: I226701e680b38920edc5ff34fa1cb6b19ef93ad3
Reviewed-on: https://chromium-review.googlesource.com/1195297
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588021}

[TaskScheduler]: Use ScopedBlockingCall to mark blocking tasks.

This CL uses ScopedBlockingCall to mark blocking calls in /ios/chrome/browser/share_extension.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
- ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
If this is not the case, ScopedBlockingCall should be instantiated
closer to the blocking call. See scoped_blocking_call.h for more
info. Please let me know when/where the blocking call happens if this needs
to be changed.
- Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
BlockingType for more info. While I assumed MAY_BLOCK by default, that might
not be the best fit if we know that this callsite is guaranteed to block.
- The ScopedBlockingCall's scope covers the entirety of the blocking operation
previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=gambard@chromium.org

Bug: 874080
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I346d55b3d32ce570cbff62031d82a5888c3c7372
Reviewed-on: https://chromium-review.googlesource.com/1191530
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588020}

Enable notificaiton swipe control by default.

Bug: 840497
Change-Id: I20c7a9043bd859c8ef8e025774040491b15d18a4
Reviewed-on: https://chromium-review.googlesource.com/1189762
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588019}

[ios] Use the NTP's HeaderViewController traitCollection.

CSHVC isn't a typical child view controller because it's loaded inside a
UICollectionView header. Perhaps due to this, in some situations the CSHVC.view
traitCollections appear to be UIUserInterfaceSizeClassUnspecified. Instead
use CSHVC directly.

Bug: 869262
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ide7b1ecea10f056ef83004055122a91e08fd2fd9
Reviewed-on: https://chromium-review.googlesource.com/1196966
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588018}

Remove 'eventSender' from vertical-scroll tests

The vertical scroll tests use wheel and touch gestures. The wheel
gesture uses window.eventSender which is a deprecated and non-realistic
API.

This CL will remove the dependency by using
chrome.gpuBenchmarking.smoothScrollBy API instead. In addition to this
change, the current API for touch scrolling is also changed into using
the smoothScrollBy method.

Bug: 611982
Change-Id: I6f3d65756dcba74be0e5dc7a7fa053d88ecbdef9
Reviewed-on: https://chromium-review.googlesource.com/1197042
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588017}

Use ImageFetchTabHelper for Save Image

Now that ImageFetchTabHelper supports both fetching image data by JavaScript
and by downloading via image_fetcher::IOSImageDataFetcherWrapper, we can use
that to improve ImageSaver.

Here is the doc about CopyImage where ImageFetchTabHelper is introduced:
http://go/ios-chrome-copy-image

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ie879ea1910aebb46fd409b1e48865d3cca314801
Reviewed-on: https://chromium-review.googlesource.com/1193365
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588016}

Use ScopedMachSendRight in media::NumberOfPhysicalProcessors().

This is not leaking, but it is easier to audit for leaks when using
the scoper.

Bug: 879307
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I3d0fa36922feb1a4c1ffef293b97d030c8793e14
Reviewed-on: https://chromium-review.googlesource.com/1196967
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588015}

Integration tests for Sync standalone transport

This CL adds some simple integration tests for starting up Sync in
standalone transport mode, and for switching between standalone
transport and full Sync-the-feature mode.

Bug: 856179
Change-Id: I772adac7e362755d34a8ab68f783b28b05e5d2c3
Reviewed-on: https://chromium-review.googlesource.com/1198423
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588014}

Revert "Add method to rewrite a LevelDB instance"

This reverts commit 061ac2e7b143a840d1399b56b508fe28436ed144.

Reason for revert: Broke windows dbg compilation on an FYI bot:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20FYI%20Win%20x64%20Builder%20%28dbg%29/4448

Original change's description:
> Add method to rewrite a LevelDB instance
>
> Add the infrastructure to remove expired data by rewriting LevelDB
> instances.
> The integration with actual storage implementation will be added in
> followup Cls.
>
> Bug: 823071
> Change-Id: Iff1b93481468423d292266f16a45f6ef4ac6e7f2
> Reviewed-on: https://chromium-review.googlesource.com/1152917
> Commit-Queue: Christian Dullweber <dullweber@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587980}

TBR=pwnall@chromium.org,dullweber@chromium.org

Change-Id: Ieda2131f323f9042e339219cde9d3488e9f13e0e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 823071
Reviewed-on: https://chromium-review.googlesource.com/1199663
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588013}

Revert "Do not build chrome/service on POSIX if CUPS is disabled."

This reverts commit af6a592750ca823d5fef05e5bc8795145ecc22ba.

Reason for revert: Likely culprit of https://crbug.com/879564

Original change's description:
> Do not build chrome/service on POSIX if CUPS is disabled.
>
> The code, used for the Cloud Print Proxy, is useless without CUPS.
>
> BUG=793801
>
> Change-Id: Icb4605ae15d758366c5c0b1e52a56afcfe5334a1
> Reviewed-on: https://chromium-review.googlesource.com/961862
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Sean Kau <skau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587921}

TBR=thestig@chromium.org,skau@chromium.org

Change-Id: Ia285e5ae6b9f72d8773bea5118fcfe4bff1d922a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 793801
Reviewed-on: https://chromium-review.googlesource.com/1199582
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588012}

[Autofill] Add validity field to votes

Part of the profile validation pipeline:
Previously, we were sending votes for each possible type of
a field we fill regardless of the validity of the data in the
user profile.
Here, we add validity states for each possible autofill type
we are voting for in the AutofillUploadContents message and
AutofillField. Server can use these "rich votes" for better
field type detection.

Change-Id: I7613c521009cc0db493aadf729369983d9b9f087
Reviewed-on: https://chromium-review.googlesource.com/1188887
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#588011}

[LayoutNG] Hook up with the scroll anchoring machinery.

Similar code for legacy layout can be found in

LayoutBlock: :UpdateLayout().
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I980ff54c7152c44f8cd806b545b761228d6bfa36
Reviewed-on: https://chromium-review.googlesource.com/1199242
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588010}

[iOS] Fix TabStrip PopupMenu on launch

This CL makes sure that the PopupMenu displayed on the TabGrid button in
the TabStrip has a correct positioning on the first launch of the app.

Bug: 876982
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
Change-Id: I5eb288baae93ce9df8e5e7fc5f21f4eb3c4b7060
Reviewed-on: https://chromium-review.googlesource.com/1199045
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588009}

Fixed Android WebView fling jump.

On Android WebView ui::compositor is not available and the fling progress
happens by setting needs begin frame and calling progressFling on beginFrame.
In this case calling ProgressFling right after processing fling start
casues a jump in the beginning of fling since on the first frame after GFS
two GSUs are sent: One on beginframe and another one on ProcessGestureFlingStart.
On all other platforms this is not an issue since the GSU generated in
onAnimationStep of frame n gets handled in frame n+1. So during the first
frame after GFS only the GSU generated in ProcessGestureFlingStart causes
scrolling.

This cl checks to see if SetNeedsBeginFrame is used for scheduling fling
progress calls and if that is the case, it skips calling ProgressFling after
processing the GSF to make sure that only one GSU is sent in the first frame
after processing of GFS.

Bug: 868867
Change-Id: I690c066034013faa62acbe740b574c5c40fe6bfa
Tests: FlingControllerTest.*/1
Reviewed-on: https://chromium-review.googlesource.com/1181521
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588008}

Generify authentication during enrollment.

Add DMAuth class, that would be used during enrollment
instead of individual tokens.

TBR: oshima@chromium.org
Bug: 854101
Change-Id: I150b9dd5a91c7ba37b14f6dffbaf62f8f00dbb8b
Reviewed-on: https://chromium-review.googlesource.com/1194233
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588007}

Add myself to owners

Change-Id: I1f3c8b2fd04d6dc53176c62a5a48bc9adc7b5167
Reviewed-on: https://chromium-review.googlesource.com/1197482
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588006}

[iOS][MF] Password view controller

Creates a view controller where the user can pick a password or an
username.

Bug: 878388
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Icb837075007c36ca85d12215b446f0ce57391779
Reviewed-on: https://chromium-review.googlesource.com/1194027
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588005}

Reland of "Add swipe control buttons."

Description of the original change:
> Shows buttons when swipe control is opened by horizontal scroll of a
> notification box. The buttons triggers same action just like the
> existing control buttons inside MessageView for mouse.
> Reviewed-on: https://chromium-review.googlesource.com/1188044

The original change was reverted once for reverting the breaking change
on which this is based on. 16ab50cc3 crrev.com/c/1184724

Test: ash_unittests --gtest_filter=MessageCenterViewTest.*:MessageListViewTest.*
Test: manual
Bug: 840497,877983
Change-Id: I3a03f7a1386c1a7f484a2442e0e39dfdb9a8840b
Reviewed-on: https://chromium-review.googlesource.com/1193082
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588004}

[Autofill] Test against only the relevant detected_values in each test

Change-Id: I4f73b868b586616234340b77bcd727726ce3cfe4
Reviewed-on: https://chromium-review.googlesource.com/1197983
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588003}

android: crazy_linker: Minor simplifications.

- Remove the RDebug::readonly_entries_ field because it
is no longer used.

- Allow LineReader class constructor to accept a buffer
capacity. A large value helps speed up parsing of large
input files.

- Simplify ProcMaps implementation, by simply exposing the
vector of entries to callers.

- Remove FindProtectionFlagsForAddress() since it is no
longer used.

BUG=NONE
R=pasko@chromium.org, rmcilroy@chromium.org, agrieve@chromium.org

Change-Id: I6f6dcc11f10adca660475dab9b5c701ab0e48a60
Reviewed-on: https://chromium-review.googlesource.com/1196514
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588002}

[css-properties-values-api] Typify CSSStyleValue.parse/All.

Passing the PropertyRegistration makes StyleValueFactory::FromString
find the typed value, and create appropriate and corresponding TypedOM
types.

Note: the check on property_id==CSSPropertyVariable isn't strictly
required, but it's nice to avoid the AtomicString creation if we know it's
not needed.

R=futhark@chromium.org

Bug: 641877
Change-Id: Id7f7f8c754f8aab7f64a92efd896243858d03757
Reviewed-on: https://chromium-review.googlesource.com/1199182
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588001}

Allow deletion of entries from the translate site blacklist

The translate site blacklist contains urls that currently can't be
deleted with Clear Browsing Data. This blacklist is similar to a
content setting so it should be deleted with the Content Settings
option.
To allow deletion of blacklist entries by time, the List is migrated
to a Dictionary that maps sites to timestamps. To keep compatibility
with older syncing Chrome instances, the old list is kept for a few
releases.

Bug: 867409

Change-Id: I046af82ba133d209c119f9d44423d02b3a1c499c
Reviewed-on: https://chromium-review.googlesource.com/1150141
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588000}

Roll src/third_party/depot_tools 05cd7b2f0e8c..e7f930294830 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/05cd7b2f0e8c..e7f930294830


git log 05cd7b2f0e8c..e7f930294830 --date=short --no-merges --format='%ad %ae %s'
2018-08-31 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
gclient setdep -r src/third_party/depot_tools@e7f930294830

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I4371abd5b864f4017fe6cef900eee103f3881c56
Reviewed-on: https://chromium-review.googlesource.com/1198408
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587999}