Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1686887847-40bca04050520a04989a89436ff5908f6f163c33.profdata to chrome-mac-arm-main-1686895138-5b1e1b17d7afcab4594fc08f91fd13a83504d607.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia9fc872806fcdb70ea31e214eadd8d793721cf84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619975
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158703}
Update IOTask Progress with blocked files
Updated IOTask Progress upon completion to State::kError and set the PolicyError if there's any file blocked by DLP or Enterprise Connectors so that FileOperationHandler and file_manager::SystemNotificationManager can show the block panel item or the block desktop notification for both DLP & Enterprise Connectors.
Bug: b/279029167
Change-Id: Ia478dd146b865715e42a29fc75aced04c23cff14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615026
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Aya Elsayed <ayaelattar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158702}
[iOS] EnterprisePromptCoordinator dealloc checks stop was called
Bug: None
Change-Id: I1aed3f789939b0cb7cac77065c39b0a3f3ffa27e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608404
Reviewed-by: Arthur Milchior <arthurmilchior@chromium.org>
Commit-Queue: Arthur Milchior <arthurmilchior@chromium.org>
Auto-Submit: Arthur Milchior <arthurmilchior@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158701}
[Fontations-backend] Build rules for fontations backend in Chromium
Define a build flag for conditional compilation of the Fontations
SkTypeface backend in Chromium. When the flag is on, on Linux route all
web font creation through Fontations for testing.
Bug: 1446251
Change-Id: Ica4e2abdbe8b4a8f9a9c0fdbdbf1f1f8d1918bde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608308
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158700}
Move kSetClientEncryptionKeysJsApi feature flag to //components/trusted_vault
Bug: 1223853
Change-Id: I01a359eabf5786ffb2d1e216c1cb4607a3e94e4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616397
Reviewed-by: Marc Treib <treib@chromium.org>
Auto-Submit: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158699}
[BestEffortServiceWorker] Dedupe main resource
This CL is a part of efforts that achieve the dedupe function to
BestEffortServiceWorker.
At a high-level, the dedupe is achieved by reusing the
RaceNetworkRequest response as a response of the corresponding request
in the fetch handler, and do not send a new fetch request.
We can split into some smaller steps to implement this.
1. Generates a token of RaceNetworkRequest, and pass it to the
blink side to make the corresponding request in the fetch handler
discoverable.
2. Adds a map of the token and URLLoaderFactory in
ServiceWorkerGlobalScope, and replaces the default URLLoader when the
fetch request is same as the one called in RaceNetworkRequest which is
outside of the fetch handler.
3. (This CL) Fuses two message pipes into one in a custom
URLLoaderClient so that we can reuse the RaceNetworkRequest result and
don't dispatch duplicated requests in the fetch handler.
This CL introduces one new class.
`ServiceWorkerForwardedRaceNetworkRequestURLLoaderFactory` is the
URLLoaderFactory that fuses the RaceNetworkRequest URLLoaderClient mojo
message pipe and the other URLLoaderClient pipe for the corresponding
fetch request in the ServiceWorker fetch handler in blink side. By
fusing them into one message pipe, the request in the fetch handler
never creates a new URLLoader and thus no duplicated request, and reuses
the response of RaceNetworkRequest.
`ServiceWorkerRaceNetworkRequestDataPipeManager` is the class managing
the dedicated data pipe and buffering data from RaceNetworkRequset. We
use this class to create new data pipes and pass the response of
original RaceNetworkRequset to the RaceNetworkRequest itself and the
fetch handler, respectively.
`ServiceWorkerRaceNetworkRequestURLLoaderClient` is changed to send the
response data to newly created two mojo data pipes, one is for the
RaceNetworkRequest itself, and the other one is for the fetch handler.
This CL adds the dedupe feature to the main resource only. For
subresoureces, we don't support it at least for now due to the
complexity of redirect case, but the ActiveEntry in net layer would
dedupe requests in most cases in reality.
Here is a design doc including diagram how mojo pipes work.
https://docs.google.com/document/d/1eotFetBW9RUE2sYjCnVl7P8rbvIsWBJcy3NOswC5kek/edit#bookmark=id.umdo7cpwavad
Change-Id: Ia524f69a81335528a66db5df2488a1f8190f2024
Bug: 1420517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4560732
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158698}
Disable multipart-formdata.window.html on all platforms
The above mentioned test is marked as timing out on Linux and Mac11
platforms. However, the test also fails due to a "NotImplemented" being
hit in "WriteResourceRequestBody" and this failure occurs on all
platforms, not just Linux and Mac11. See:
https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fhtml%2Fsemantics%2Fforms%2Fform-submission-0%2Fmultipart-formdata.window.html
This CL expands the expectations entry for this test to all platforms
and also adds a failure expectation.
Please let me know if this additional failure type should have a
separate bug, instead of reusing crbug.com/626703. I don't have access
to crbug.com/626703, therefore I cannot see what all it covers.
Bug: 626703
Change-Id: I1c90b75c832ca061cc37ef813be1cd80b0638244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617579
Commit-Queue: Sanket Joshi <sajos@microsoft.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158697}
Roll WebRTC from 816dc3b6081d to 0b86253c1511 (1 revision)
https://webrtc.googlesource.com/src.git/+log/816dc3b6081d..0b86253c1511
2023-06-16 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2023-06-16T04:04:20).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com,webrtc-infra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I0e5f8c45835f1866a113d970f50848f244590044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619340
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158696}
Web Apps: Remove redundant observe_media_requests PublisherHelper option
This parameter is always true in production and can be removed.
Bug: b/270212284
Change-Id: Id5a7f9985d695b4b6ba43de4c090a00f335beb76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619947
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Auto-Submit: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158695}
Add horizontal deletion metrics for site settings
This CL adds a horizontal metric to various browsing data deletion
surfaces on desktop:
- Site settings - clear all data
Histogram: "Privacy.ClearBrowsingData.Action"
Platform: Desktop
Bug: b/274063408
Change-Id: I41a2abc712b8a85bad1c1fc7b7b396e8654ad101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4584558
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Mohamad Arab <arabm@google.com>
Cr-Commit-Position: refs/heads/main@{#1158694}
[Viz] Allow MultiplanarSI in RenderableGMBVideoFramePool beyond Mac
This CL removes the IS_MAC restriction from using MultiplanarSI in
RenderableGMBVideoFramePool, instead just using the guard of whether
MultiplanarSI is enabled. From discussion, there shouldn't be any
logic needed here for other platforms beyond that which was added to
get the flow working on Mac.
Bug: 1429004
Change-Id: I1159689f4b27ec43513dd93758f46bf1bd315847
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4607381
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Saifuddin Hitawala <hitawala@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158693}
[iOS] Fix bubble frame LeadingDistance computation
This CL fixes the computation of the LeadingDistance() method.
In some cases `leadingDistance` could be a bit lower than 0.
Using round() instead of floor() returns 0 instead of -1.
Fixed: 1454071
Change-Id: I2e4e7b08e6994926cdcce416874f77a258d650e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618107
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158692}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1686851973-6e9f8a281a96374b2bdf985258af96ca60ab3947.profdata to chrome-linux-main-1686895138-563f8b073abc7300eb45545d285cd1b7b40e1e23.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I8a610c8989d9cc0626b4b103cb3527a3ec30ba26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618739
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158691}
Roll devtools-internal from 250b420bb8f5 to d9caa21acca2 (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/250b420bb8f5..d9caa21acca2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I513eec36c83f4544b76d9b7c5f81800c6064bb53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619971
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158690}
Roll ANGLE from 46ff02f8a2b1 to edf58105d695 (1 revision)
https://chromium.googlesource.com/angle/angle.git/+log/46ff02f8a2b1..edf58105d695
2023-06-16 amy@amyspark.me Validate GL backend after dispatch table initialization
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC angle-team@google.com,syoussefi@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: syoussefi@google.com
Change-Id: Ie28c9bdcf2f99756cc4119596cdc22dff753e5ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619707
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158689}
Revert "Reland "[PolicyLogs] Adding chrome://policy/logs on Desktop""
This reverts commit d650fb99b98799805b8011aea96a0aa2fc1b3cc4.
Reason for revert: Causes iphone and ipad devices failures.
Like https://luci-milo.appspot.com/ui/inv/task-chrome-swarming.appspot.com-62d99c2b8da1e511/test-results?sortby=&groupby=
Original change's description:
> Reland "[PolicyLogs] Adding chrome://policy/logs on Desktop"
>
> chrome://policy/logs is already available on Android and enabled by default. This CL brings chrome://policy/logs to desktop behind a feature flag that is enabled by default.
>
> The CL also adds a reference to the sequence that created the logger to always post `AddLog()` to it if a different sequence adds a log. Some code paths previously tried to add a log from a different sequence, causing the DCHECKs to fail. This solution fixes the issue.
>
> A POLICY_EXPORT is added for the LogHelper class to avoid dll linkage errors on Windows.
>
> The ASAN Crash that caused the revert in crrev.com/c/4559846
> was due to the last_dm_status_ being logged in "cloud_policy_client.cc" which has already been freed from the `NotifyClientError()` call.
>
> Bug: b/282733597
> Change-Id: Icb75e4cbb069eefea86958b65b3f957db295cdf3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4567744
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
> Commit-Queue: Salma Elmahallawy <esalma@google.com>
> Cr-Commit-Position: refs/heads/main@{#1158355}
Bug: b/282733597
Change-Id: I3e991148214869ad635455b4e3d7f6786252efb9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616067
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Quentin Pubert <qpubert@google.com>
Reviewed-by: David Jean <djean@chromium.org>
Owners-Override: David Jean <djean@chromium.org>
Owners-Override: Quentin Pubert <qpubert@google.com>
Cr-Commit-Position: refs/heads/main@{#1158688}
DestroyRegularProfileBeforeOTRs waits for profiles to be destroyed.
The test expects that the off-the-record profiles would be destroyed
immediately after calling `DestroyOriginalProfileWhenAppropriate` which
is wrong as the OTR profiles are sometimes given a bit of time to
close all their dependencies.
Bug: 1454090
Change-Id: Ia50c269fbec88cc08844f4cb290078961764ac05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614511
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158687}
[lacros skew tests] Refresh skew tests for M116 M116
This CL updates the ash version ['116.0.5835.0', '116.0.5830.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: None
Change-Id: I889a2bd19a3c240bfa252fba961990b2fd5c4cc9
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618135
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158686}
Update V8 to version 11.6.176.
Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e7c25ca2..114cd478
Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues
Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
Change-Id: I9ee742f085d8df71435cbd089cc524e7dc98833c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620007
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158685}
Shorten the name of SharedDictionaryStorageIsolationKey
This CL just renames SharedDictionaryStorageIsolationKey to
SharedDictionaryIsolationKey.
Bug: 1413922
Change-Id: I94d6dc1718085a7d338217fc2039448a7641610b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619791
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158684}
Automated Commit: LKGM 15502.0.0 for chromeos.
Uploaded by https://ci.chromium.org/b/8778261585564755601
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-octopus-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome
Change-Id: Ifc782f642c1f564ef44648c7e3ddef0c975e991c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616271
Commit-Queue: Andre Le <leandre@chromium.org>
Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158683}
[Office upload] Only show Connect To OneDrive dialog if ODFS not mounted
Only show Connect To OneDrive dialog if there is not already a ODFS
mounted. Previously this would be shown if the "Sign in" button
is clicked in the "You've been logged out" screen of an unauthenticated
ODFS mount. This is confusing as the user would expect to see the
authentication pop up instead.
Before:
- Dialog shown:
https://screencast.googleplex.com/cast/NDYyNTk4ODgxMDk2NDk5Mnw1NzE0Y2IyNi0zNQ
After:
- Authentication pop up shown:
https://screencast.googleplex.com/cast/NTU3NjMzODE3MDcwNzk2OHw0YTg3YzdkMy0xNA
Bug: b/287539168
Change-Id: Ie1607f9fcbc79403ca4e2936fc5a6ab02764663e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615471
Commit-Queue: Cassy Chun-Crogan <cassycc@google.com>
Auto-Submit: Cassy Chun-Crogan <cassycc@google.com>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158682}
ambient: Add enabled metric for managed screensaver
This CL adds a new class to record metrics related to the managed
screensaver feature. More metrics will be added to support trusted
testers.
Bug: b:278066909
Test: ./ash_unittests --gtest_filter=AmbientControllerForManaged*
Change-Id: I45d6497378f1852fe3176c4f4580d50728702891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4597570
Reviewed-by: Igor Ruvinov <igorruvinov@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Emmanuel Arias Soto <eariassoto@google.com>
Cr-Commit-Position: refs/heads/main@{#1158681}
Roll Catapult from 10aab97228d8 to c8efd30d90fc (1 revision)
https://chromium.googlesource.com/catapult.git/+log/10aab97228d8..c8efd30d90fc
2023-06-16 ashwinpv@google.com Initial code to generate skia perf links for bugs filed in chromeperf
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC chrome-speed-operations@google.com,dberris@chromium.org,haowoo@google.com,jbudorick@chromium.org,johnchen@chromium.org,sullivan@chromium.org,wenbinzhang@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: haowoo@google.com
Change-Id: I54db28d7e2a53610d677e4d70e74e83d770fc6d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4618704
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158680}
Add V8 GC finch experiments to field trial config
This CL enables features for code flushing and sechduling a single
memory reducer GC in field trial configs.
Bug: v8:13842
Change-Id: I92122b5ca2c026ca4c9bf76dd29a071642b44c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615072
Auto-Submit: Dominik Inführ <dinfuehr@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158679}
CSSStartingStyleRule inherits grouping rule
There is no conditionText, which means we can inherit directly from
CSSGroupingRule instead of CSSConditionRule.
Result of spec PR review:
https://github.com/w3c/csswg-drafts/pull/8876#discussion_r1207246849
Bug: 1412851
Change-Id: Idbd174813b8894154a283885c3cfbdb35c6c9fcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4571598
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158678}
arc: Allow vmm swap ghost window for PlayStore
Previously exclude PlayStore since ARC-on-demond use PlayStore as
the launch signal.
Now vmm manager already use PlayStore ready as one of the allow
condition, which means when IsArcVmAndSwappedOut is true, the
PlayStore app state must be "ready". It's fine for enable swap out
ghost window on PlayStore.
Bug: b:283356494
TEST=manually test
Change-Id: Id837e4ad063f61d56e252ff18acef5bdb51658c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615845
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Shengsong Tan <sstan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158677}
viz: merge render pass if rounded corners are contained by dest pass'
... rounded corners.
Do not create a render pass if rounded corners of pass
pass are within rounded corners of the dest pass.
Based on petermcneeley@'s draft patch - https://crrev.com/c/3987982
One of the issues that this CL fixes is creation of aggregated render
pass in Meet that results in LaCros compositing that pass.
Bug: 1382038
Change-Id: I2ddd78d0c43ad3b5054bcb0973c1722ac7c2f02f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4588849
Reviewed-by: Peter McNeeley <petermcneeley@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Auto-Submit: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1158676}
Migrate autosharder to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: 1412588
Change-Id: I61906baa08b220ebc0460686de149cadf6cc66ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617035
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158675}
[//viz] Get GL texture storage for format from ContextProvider
This CL eliminates direct usage of TextureStorageFormat(ResourceFormat),
replacing it with a wrapper function on ContextProvider that takes in
SharedImageFormat. A followup CL will change the utility function to
operate directly on SharedImageFormat and hide it so that it is not
directly used by clients.
Change-Id: I5e737c80244f119acbd41a4c3645a471d1a41851
Bug: 1378708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614964
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158674}
Speculative fix of flaky editing/selection/inactive-selection.html
The test sometimes finishes without printing neither PASS nor FAIL.
Probably we should make sure the test finishes after printing it.
This CL converts the test to a testharness async test.
Bug: 1455247
Change-Id: I477fd167ec8db7f0548bdb59a18274b3124f4b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617473
Reviewed-by: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158673}
Support large size surrounding text in Lacros.
We hit an issue that large surrounding text size is truncated
because of wayland wire protocol field size.
This CL introduces a new API using memfd to pass the large data
so we should not hit the limit.
This is lacros side change, which will be in effect once
ash side change is landed/deployed.
BUG=1402906, 1451324
TEST=Ran manually, locally.
Change-Id: Iae672d84603a1420f7493a678b1486c517c1ffda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4612411
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158672}
Fix flaky editing\selection\4402375.html test
The above mentioned test is flaky on Mac platforms. The flakiness
occurs because sometimes the test window is inactive, leading to an
inactive selection color (gray) versus the expected active selection
color (blue). Since there is no deterministic way to set the window as
active from JS, the test is being fixed by setting the color and
background-color for active and inactive selection to be the same. This
will ensure that the selection colors will always align with the
baseline, regardless of whether the window is active or not.
Bug: 1425544
Change-Id: Ib99c7a52aaa42f2abfe060732c5a8afef99c9008
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616620
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Sanket Joshi <sajos@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1158671}
Migrate flakiness-data-packager to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: 1412588
Change-Id: I938559f6132066f9f95a6f0a5e2e530d89d009a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617034
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158670}
mojo-js: Finish implementing the WebUIJsBridge generator
This CL finishes implementing the WebUIJsBridge generator. It's based
off a test implementation[1]
[1] https://chromium-review.googlesource.com/c/chromium/src/+/4568468/8/content/browser/webui/test_web_ui_js_bridge_impl.h
Bug: 1407936
Change-Id: I879f0351a3834ebd6af7878416c90c74ac055ead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568468
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Giovanni Ortuno Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158669}
[DevTools] Rebaseline and reenable test after https://crrev.com/c/4577779
Bug: chromium:1318590
Change-Id: I1031df28667d3cbcdb57e00ec8b8187bbbcd73be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615893
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Quick-Run: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158668}
Choose to append .exe based on host_os not on the target.
When building on Linux for Windows, host tools will be built for linux
and thus will not have a .exe on the end.
R=adetaylor@chromium.org
Bug: 1271215
Change-Id: I508086ef681dfb0cf7fdf91250f134b9d4802052
Cq-Include-Trybots: luci.chromium.try:android-rust-arm32-rel,android-rust-arm64-rel,android-rust-arm64-dbg,linux-rust-x64-dbg,linux-rust-x64-rel,win-rust-x64-dbg,mac-rust-x64-dbg,win-rust-x64-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615732
Commit-Queue: Adrian Taylor <adetaylor@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Reviewed-by: Adrian Taylor <adetaylor@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158667}
Revert "DeskButton: Make button responsive to shelf overflow"
This reverts commit 9d5499f1cbca9a4adaee957ef2b83ff6b1eb82a2.
Reason for revert: The new test is flake in multiple bots:
https://ci.chromium.org/ui/test/chrome/ninja%3A%2F%2Fash%3Aash_unittests%2FScrollableShelfViewDeskButtonTest.ButtonRespondsToOverflowStateChange?q=V%3Atest_suite%3Dash_unittests+
https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2Fash%3Aash_unittests%2FScrollableShelfViewDeskButtonTest.ButtonRespondsToOverflowStateChange?q=+V%3Atest_suite%3Dash_unittests+
Original change's description:
> DeskButton: Make button responsive to shelf overflow
>
> This CL makes the desk button responsive to shelf overflow. Previously,
> when the shelf was horizontal we would just force it to stay in expanded
> state no matter what. This CL changes this behavior by adding a
> condition where if the shelf will overflow in horizontal alignment with
> the button in the expanded state, then we shrink the button, and vice
> versa. It also adds and updates some tests to account for the changes.
>
> Bug: b/272383056
> Change-Id: I4ef107aa5b702a542ae7ec7818e945f568c8b92d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4606119
> Reviewed-by: Yongshun Liu <yongshun@chromium.org>
> Reviewed-by: Daniel Andersson <dandersson@chromium.org>
> Commit-Queue: Ben Becker <benbecker@chromium.org>
> Reviewed-by: Toni Barzic <tbarzic@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1158439}
Bug: b/272383056
Change-Id: Id6398589a222ae327659e35e1724fb0813c60eb6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619948
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Owners-Override: Luciano Pacheco <lucmult@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158666}
media/V4l2VideoDecoder: add V4L2 UMA for V4l2VideoDecoder
This CL adds "Media.V4l2VideoDecoder.Error" UMA. It records which
one of the following V4l2VideoDecoder class member function failed.
Note that these functions are shared between v4l2 stateless/stateful
apis.
- InitializeBackend()
- SetupInputFormat()
- SetupOutputFormat()
- StartStreamV4L2Queue()
- StopStreamV4L2Queue()
A new V4l2VideoDecoderFunctions enumeration (with a matching UMA enum)
is added to v4l2_video_decoder.cc to identify which V4l2VideoDecoder
class member function failed, and is logged to UMA.
Bug: b:273973858
Change-Id: I732ac8d2aba21448ec91f7b328958ec48219df93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4553205
Auto-Submit: Steve Cho <stevecho@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Miguel Casas-Sanchez <mcasas@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158665}
Fix dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
The above mentioned test is flaky on Mac platforms. The flakiness
occurs because sometimes the test window is inactive, leading to an
inactive selection color (gray) versus the expected active selection
color (blue). Since there is no deterministic way to set the window as
active from JS, the test is being fixed by setting the color and
background-color for active and inactive selection to be the same. This
will ensure that the selection colors will always align with the
baseline, regardless of whether the window is active or not.
There are few other similar tests that may encounter the same issue.
Those are also being updated herewith.
Bug: 1421120
Change-Id: I226e4d479eb38f29bb32ee07c77ea0831174da1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619310
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Sanket Joshi <sajos@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1158664}
Migrate Linux Builder reclient test untrusted to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: 1412588
Change-Id: Ia6602941faba684d6514ee2e9457aa8121121328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620027
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158663}
Shared Storage: Update tests to support settings v4 & attestation
We update the chrome/ layer browser tests for shared storage to
support `privacy_sandbox::kPrivacySandboxSettings4` and
`privacy_sandbox::kEnforcePrivacySandboxAttestations`.
Bug: 1455135,1218540,1396748,1378703
Change-Id: I7de8a430412eaefc42258bddac06cf507462d1a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616965
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158662}
Migrate Linux Builder reclient test to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: 1412588
Change-Id: I7dde8f850abb816334f51d44bb494f8cbf1c83cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616421
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158661}
Migrate Linux Builder reclient staging untrusted to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: 1412588
Change-Id: Iaf2df39dc6fe89dd66f15e35009ab11810b79ce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619529
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158660}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1686862750-64c913bb16dbf84d78f82669bcff96f2ae29c7f7.profdata to chrome-win32-main-1686884165-c945ce575cd58732376d15a851f9806dac28b2cd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I78f24b1125a16c44501e7bee780d415209b47d95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619208
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158659}
Revert "welcome tour: Disable welcome tour during tablet mode"
This reverts commit 883bbae2322f4e6e607debfa3798389787d472f7.
Reason for revert: The new tests are failing on chromium/ci/Linux Chromium OS ASan LSan
Original change's description:
> welcome tour: Disable welcome tour during tablet mode
>
> Welcome Tour will not be supported in tablet mode. This CL makes it not
> start if in tablet mode, and abort if tablet mode is entered while it is
> in progress.
>
> Bug: b:285628471
> Change-Id: Ic596a57ca79c541511435cd681e3d1c5f4cc13db
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4608634
> Commit-Queue: Angus McLean <angusmclean@google.com>
> Reviewed-by: David Black <dmblack@google.com>
> Cr-Commit-Position: refs/heads/main@{#1158517}
Bug: b:285628471, chromium:1455300
Change-Id: I427271b94354134899462fe9699781a1ff711018
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614695
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158658}
[text-wrap-pretty] Fix incorrect rounding in `NGLineWidths`
This patch fixes `NGLineWidths` to `ceil` more accurately by
using the float division than `LayoutUnit::operator/`. For
example, "Ceil(46.25 / 23)" should be 3 but `LayoutUnit`
computes it to 2 due to its 1/64 precision.
This patch has no behavior changes because changes are under
a runtime flag.
Bug: 1432798, 1451205
Change-Id: I6f135d7caa074e76b3ab049e5256d763f23f7c32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4615145
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158657}
Migrate Comparison Linux (reclient vs reclient remote links) to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: 1412588
Change-Id: Ie51fa44800c64981b7fd49bb6679c2a693916428
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4616419
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158656}
Roll Skia from f0410a265d2b to 504a26e85fc6 (1 revision)
https://skia.googlesource.com/skia.git/+log/f0410a265d2b..504a26e85fc6
2023-06-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 894306cf4c91 to d044984a01de (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: herb@google.com
Change-Id: Ibb4d93752dcfb565f1f819ef2acdb9c01d25c490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4619232
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158655}
Migrate Linux Builder reclient test (unified uploads) to jammy
Note: this CL was automatically generated.
If this is suspected to have caused regressions on the affected
builder, please feel free to revert.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: 1412588
Change-Id: Id3e0c690448b219213fad328d103ff6ea9dd7f08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617032
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1158654}