Chromium Main Console
| Legend: | Passed | Failed | Failed Again | Running | Exception |
Roll DevTools Frontend from 2086be5df61e to 50aada3bf286 (2 revisions)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2086be5df61e..50aada3bf286
2021-07-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS.
2021-07-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Iae8927897c1f3efc4706ac2f560c92f26f11ac23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004615
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898451}
Fix more deprecated uses of rowsPerImage in tests
This use of deprecated defaults prevent the deprecated behavior from
being removed in https://dawn-review.googlesource.com/c/dawn/+/56803
Bug: dawn:520
Change-Id: Ic6a492b345dcc0c0c3e9f43865eeb6958604fd1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003994
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898450}
Roll Perfetto Trace Processor Mac from b0345c864e4a to f4ffdc1c0d10
https://android.googlesource.com/platform/external/perfetto.git/+log/b0345c864e4a..f4ffdc1c0d10
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: Ie9d04ee9dbdf2a707755459d4ef0defeb4af53e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004147
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898449}
viz/transitions: Ensure correct transformation for shared elements.
This fixes the following edge cases when the src or dest render pass's
output rect's origin is not (0, 0) :
1) For the src texture, the render pass's origin already maps to the
copied texture's origin. Account for that in the transform to root
target when drawing this texture during the transition.
2) For the dest pass, the render pass's origin is mapped to it's direct
target pass's origin. Account for this correctly when this draw is done
on the destination pass vs an intermediate transition pass.
Bug: 1224784
Change-Id: I674ac8fb9d6a4c3017698e891d325efcb76197da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992348
Auto-Submit: Khushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898448}
[weblayer, skew tests] Refresh skew tests for M92
This CL will add skew tests for version 92.0.4515.84. See crbug.com/1041619
and crbug.com/1099017 for more information.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: None
Change-Id: I4d8dd2601d4765d9875d857600ea65678046fcc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004270
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898447}
[weblayer, skew tests] Refresh skew tests for M91
This CL will add skew tests for version 91.0.4472.152. See crbug.com/1041619
and crbug.com/1099017 for more information.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: None
Change-Id: I9f6be790523dc54c6f7de38c8352417ee7dad04a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004269
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898446}
Convert /content/browser/screen_enumeration to ScopedDisplayObserver
This is a refactoring to make it easier for future changes to
DisplayObserver, and to clean up manual Add/Remove calls with RAII.
ScopedDisplayObserver is an RAII class that directly replaces
display::Screen::Add/RemoveObserver.
ScopedOptionalDisplayObserver is the same thing, but handles the case
where display::Screen::GetScreen() is null. This can happen in tests.
This is a non-functional change, intending to replicate existing
behavior exactly.
This CL was uploaded by git cl split.
R=msw@chromium.org
Bug: 1225463
Change-Id: I113baacbf91435af408ed59604906e7159cc658a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004170
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Mike Wasserman <msw@chromium.org>
Commit-Queue: Mike Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898445}
Roll DevTools Frontend from d662bdf64b7d to 2086be5df61e (6 revisions)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d662bdf64b7d..2086be5df61e
2021-07-02 chenleihu@google.com [OriginTrial] Implement Devtools Front-End
2021-07-02 kritisapra@google.com [CSS]: IssueCounter
2021-07-02 kritisapra@google.com [CSS Migration]: Migrated ReportView.ts
2021-07-02 andoli@chromium.org Delete duplicate Events enum
2021-07-02 changhaohan@chromium.org Componentize CSS Query display in the Styles pane
2021-07-02 sigurds@chromium.org Remove spotlight experiment
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1106746,chromium:1146422,chromium:607555,chromium:934031
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Icab06985d752357842e45cf4bcb208d28959c156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003453
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898444}
ChromeOS: Disable RearrangeVisibleWindowOnHideOrRemove.
The window rearrangement went against user's will of keeping
window out of center. For now we will count all windows remaining
to determine if we need to rearrange the auto managed window.
Bug: 1196324
Change-Id: I4fa7c51492c560bf52377e565c21caf282c091dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992179
Commit-Queue: Judy Wang <shidi@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898443}
Roll PDFium from 8b1e03ff43b4 to 0e2676091765 (5 revisions)
https://pdfium.googlesource.com/pdfium.git/+log/8b1e03ff43b4..0e2676091765
2021-07-02 thestig@chromium.org Remove redundant checks in CPDF_Dictionary::SetNewFor().
2021-07-02 thestig@chromium.org Disallow non-ASCII keys in dicts when parsing with CPDF_SyntaxParser.
2021-07-02 thestig@chromium.org Add a test case for FPDFPage_GenerateContent() not applying color.
2021-07-02 tsepez@chromium.org Remove fx_system.h from fx_safe_types.h
2021-07-02 tsepez@chromium.org Make everything in fx_system.h start with FXSYS_
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Ib24426a5cf3a7004c738c8a755e22ea92b2ef2c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004104
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898442}
Roll src-internal from 1e4e6269e94b to 7020066d2014 (3 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e4e6269e94b..7020066d2014
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC xiaochengh@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1220372,chromium:1221369
Tbr: xiaochengh@google.com
Change-Id: Icbe3da4e805dfd05942ca1f481347880351ebea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003999
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898441}
Roll Dawn from 551e7a1cc342 to 49a4c68a80d1 (2 revisions)
https://dawn.googlesource.com/dawn.git/+log/551e7a1cc342..49a4c68a80d1
2021-07-02 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 9bf951eee520 to 3124d43fda3f (6 revisions)
2021-07-02 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 37cabbb46828 to 9bf951eee520 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC sarahmashay@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: sarahmashay@google.com
Change-Id: Ie6746a361bd8c66b62fbdc4d6a26ac433002c912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003990
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898440}
Extend lifetime of AddIceCandidate histogram by 6 months
This histogram still shows worrying levels of "no remote description",
so it's useful to track.
Bug: 1224571
Change-Id: I39200b4a8319f3d1369c262b77d676c615db5944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2998463
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898439}
[privacy_budget] Remove media query instrumentation and sampling code.
The instrumentation was generating too much noise to be useful. So it's
no longer used for analysis. In addition, also removes the subsampling
infrastructure that was in place to reduce the performance impact of the
instrumentation.
This CL is the equivalent of a revert of the following two changes with
the exception that ShouldSample() method introduced in the first CL
stays.
Revert "Add per-surface and per-type sampling parameters for the Identifiability"
This partially reverts commit 828932702391775d9b4696c8a5f67f749690fd39.
Revert "Instrument media query evaluation for identifiability study."
This reverts commit 75a3c8f07678571480cc5d19f1f9be4540263e3d.
R=fserb@chromium.org, morlovich@chromium.org
Bug: 1170527
Change-Id: Id42bcfc1769fcddb685cca4f1d850dd5210d9b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2647958
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898438}
Plumb the rest of the SupportSessionParams values
There are three SupportSessionParams members which I left out of the
initial implementation as they are only used for commercial use cases.
Now that the consumer impl is in good shape, I want to finish plumbing
the values through so this codepath is ready for use by the commercial
team when they decide to switch from using the NMH approach to Mojo.
Bug: 1181824
Change-Id: I3d31428c6b704f589e6f368106b1c943af5c09a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003802
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898437}
Share InterestGroup validation of blink and non-blink mojom structs.
In blink, AdAuction validates InterestGroup data passed in from
Javscript, throwing an error on bad data. In content/,
RestrictedInterestGroup then validates the received struct. We need
the blink checks to throw an error to help in debugging, and we need
the browser-side checks to protect against a compromised renderer, so
we can't just remove one set of checks.
These two instances of validation logic should be largely the same,
but currently aren't. Unfortunately, one has a mojom-blink struct to
validate, while the other has a mojom struct to validate, both
generated by the same mojom file.
This CL introduces matching validation functions for each Mojo struct,
placing both in blink/, and introduces a single set of unit tests that
run all tests against both validation functions.
BUG=1218284
Change-Id: I868b5c3c011de69fe5634a9c9db390d8fbf4d666
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992210
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898436}
Dedup the path in runtime_deps
BUG=1172129
TEST=mb_unittest.py
Change-Id: I548a2a1df82f47cc34344a7cdb5127468b939c6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3002336
Commit-Queue: Xinan Lin <linxinan@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898435}
Ensure upload retry on failure
This fixes a subtle problem: for IMMEDIATE and MANUAL queues if upload
fails for whatever reason, we are not redoing it until the next event is
enqueued or next Flush is called (for other queues we just do next
periodic upload, but these two have none).
Also fixes a minor inefficiency in non-encrypted storage (which is now
only used in tests).
Bug: b:192666219
Change-Id: I380a0d30df1dee3d773d9aae81826fd194633932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003991
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Reviewed-by: Zach Trudo <zatrudo@google.com>
Cr-Commit-Position: refs/heads/master@{#898434}
Roll Media App from d_dtMSh01... to sE1KC8jVG...
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202107030800_RC00.html
https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/sE1KC8jVGPXbLODBKUrgZhGU5T983TjgEy0D7t0YuawC
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: media-app@grotations.appspotmail.com
Change-Id: Id6b180d73dbfc8f4262063810db01134ea982e98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003626
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898433}
media: Add unit tests for VideoDecoderPipeline transcrypt
This adds unit tests which cover the transcryption process that can be
invoked by the VideoDecoderPipeline. The tests are run on the pipeline,
but also cover specific behaviors in the DecoderBufferTranscryptor. All
the tests rely on pipeline behavior except for the two relating to
missing keys. Rather than duplicate a lot of the test code into unit
tests for the DecoderBufferTranscryptor for just two tests, those are
exercised at the pipeline level as well.
This also contains a fix for a bug found by the unit tests.
BUG=b:191381812
TEST=Unit tests pass
Change-Id: Ibd78315313b3c51190ea521161be75f84db4136a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2997155
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#898432}
Odd-size video: Replace OddSize with OddHeight
GpuMemoryBufferVideoFramePool does not support odd widths and DCHECKs
against them, so don't allow that. The main consumers of odd-size video
produce odd-height video (e.g, 240x135), not odd-width video.
Reduce the scope of the fix to just add support for odd-height video.
Also, the IOSurface allocation code rounded down the UV plane size
instead of rounding up(!). Fix that and add tests.
Bug: 1224781
Change-Id: I5f1f9e5a211b36f8e47a75d7b2f3b7b8fee87750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003807
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898431}
[privacy_budget] Introduce RepresentativeSurface.
A "representative" surface is a strong alias for an IdentifiableSurface
that's used by the surface valuation system.
Bug: 1224752
Change-Id: Ia02c07aba68caa321dda46f3b6ebbb498cc40d41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2997206
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Russ Hamilton <behamilton@google.com>
Cr-Commit-Position: refs/heads/master@{#898430}
Roll Perfetto Trace Processor Win from 1de765c9f44b to f4ffdc1c0d10
https://android.googlesource.com/platform/external/perfetto.git/+log/1de765c9f44b..f4ffdc1c0d10
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I746d0bdd3579857edbf459cdae61ad4cb3b473e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004530
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898429}
Automated Commit: LKGM 14067.0.0 for chromeos.
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:lacros-amd64-generic-chrome
R=chrome-os-gardeners-reviews@google.com
Change-Id: Id69f71da7fb40006975462e8fa5cb9fb852781e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004471
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898428}
[Autofill] Update comments on the autofill server proto
Change-Id: I02f341b8d1496e304bc6671f05298c0ecfd27c57
BUG: 1225446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003263
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898427}
Track various URLs involved in navigation in RenderFrameHostImpl
There are various URLs involved in navigations that are not the URL
set in CommonNavigationParams/DidCommitProvisionalLoadParams:
"document URL", "history URL", "loading URL", etc. Some of these are
not currently tracked in the browser, but are used for various decisions
in the renderer.
This CL calculates & saves the "history URL" as `last_history_url` and
the "document URL" as `last_document_url` (replacing the less accurate
`last_url_in_renderer`) in RenderFrameHostImpl's RendererURLInfo along
with other information related to the renderer URLs, and also adds a
way to calculate the "loading URL".
The URLs above are updated on certain events (navigation commit,
document.open(), renderer crash) and are used for:
- Simulating the
DidCommitParams calculations that was done in the renderer more
accurately
- Preserving old behavior of the same-URL check that recently got moved
from the renderer to the browser.
See doc: https://docs.google.com/document/d/1n_1uJktx-AfavP0IB-RbQ5p5jEolq2_b0VMEXnH5UQQ/edit
Bug: 1131832
Change-Id: Ibe396b5ba00138cc31fb836c803b354f1fd5d2ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2949868
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898426}
Roll WebRTC from d45f9300b7bf to 92fc02161e85 (1 revision)
https://webrtc.googlesource.com/src.git/+log/d45f9300b7bf..92fc02161e85
2021-07-02 terelius@webrtc.org Replace PacketView by vector of pointers in a wrapper class.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: If93ff1a40930797dc7c3df96e4d4683b8177f388
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3002209
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898425}
Updating XTBs based on .GRDs from branch main
Change-Id: Id4d0857e17d73c4f5dfbce34f1b01c1db3faf005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004469
Auto-Submit: Ben Mason <benmason@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898424}
[Frameworks roll] Roll to 382873971 piper revision
Change-Id: Ia85942d5bb0b05fdf11ea103362fed7d5e24c404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004271
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898423}
Add D3D_FEATURE_LEVEL_12_2 to Windows GPU info collection
The current info collection function can only query D3D12 feature
level up to 12.1. This CL addes the new feature level 12.2 to the
info collection function.
This CL does not update the D3D11 info collection function. The
support for D3D_FEATURE_LEVEL_12_2 on Windows has not been surfaced
through D3D11 API. Calling a D3D11 function with
D3D_FEATURE_LEVEL_12_2 will fail now.
Bug: 1222429
Change-Id: I2a3a2e3453c95f5698f21b3611b51ea6f5912bb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004188
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898422}
Convert /components/remote_cocoa to ScopedDisplayObserver
This is a refactoring to make it easier for future changes to
DisplayObserver, and to clean up manual Add/Remove calls with RAII.
ScopedDisplayObserver is an RAII class that directly replaces
display::Screen::Add/RemoveObserver.
ScopedOptionalDisplayObserver is the same thing, but handles the case
where display::Screen::GetScreen() is null. This can happen in tests.
This is a non-functional change, intending to replicate existing
behavior exactly.
This CL was uploaded by git cl split.
R=avi@chromium.org
Bug: 1225463
Change-Id: I4b76f131bc6989109600a0f219fa466c4ea606bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004169
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898421}
[D-Bus] Refactor: Extract common ChromeOS init code to //chromeos/dbus/init.
As prerequisite refactoring to crrev.com/c/2983066, this CL creates
//chromeos/dbus/init for D-Bus initialization code that will be shared
with Lacros, and do NOT depend on //chromeos/dbus. Details:
* Add chromeos::DBusThreadManagerBase, which is extracted from
chromeos::DBusThreadManager and set as its base class.
* Own D-Bus thread and D-Bus connection and control their lifetime.
* Take |use_real_client_| logic, which is now privately assigned at
construction instead of being injected via constructor param (a
flexibility that was not exercised) for simplicity.
* Static functions in chromeos::DBusThreadManager (to manage singleton)
are left as-is. Lacros will need to duplicate some code.
* Move initialize_dbus_client.h to //chromeos/dbus/init.
Additional changes:
* Move the 3 functions in ash_dbus_helper.* from chromeos:: to ash::,
and update callers.
Bug: 1195247, 1195248, 1217124, 1223456
Change-Id: I066bdac0667329c263ebb6967b9ac7888950b154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003584
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898420}
Swap from base/stl_util.h to base/containers/cxx20_erase.h in ui/.
base::Erase() and base::EraseIf() have been moved to
base/containers/cxx20_erase.h, so .cc files that use these functions,
but no other function from base/stl_util.h, can directly include
cxx20_erase.h and not stl_util.h.
Bug: 1211125
Change-Id: I1ba4d41a35a683aae751ae9921179a7cf3bc2fbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2995490
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898419}
Roll Open Screen from 223797e8b6f8 to 9d6aade8df44 (1 revision)
https://chromium.googlesource.com/openscreen.git/+log/223797e8b6f8..9d6aade8df44
2021-07-03 abrahamcd@google.com Rename Device to Receiver
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: jophba@chromium.org
Change-Id: If3b1b62ea143a8938a8a13e0e0767a7726285319
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004388
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898418}
Address flakiness in import-css-module-basic.html
The logs from the failures are not helpful in diagnosing the issue,
and I'm unable to reproduce any failure locally.
My best guess is that the issue is related to the test's use of 5
iframes that are injected in async_tests. There's probably some
strange timing issue that happens if things happen to load in a
particular order.
This change attempts to address the flakiness by simplifying the test.
4 of the iframes are removed and the modules are just loaded in order
at the top level instead.
The 5th test remains in an iframe because the test is supposed to
cause an error; this one is converted to promise_test.
Bug: 1225913
Change-Id: If1870af360ba6812689c03e87ce4d21d91faabe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003700
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898417}
[GMNext][TabSwitcher] Change favicon size
Increase the favicon size to 18dp, and change the corner radius to 4dp
globally. This change is intended to be available through waterfall so
it is not flag guarded.
Bug: 1217141
Change-Id: Ib52b30a698f34a410e583ff63cb8a36fa752e5bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003845
Reviewed-by: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898416}
Convert /chrome/browser/media/router to ScopedDisplayObserver
This is a refactoring to make it easier for future changes to
DisplayObserver, and to clean up manual Add/Remove calls with RAII.
ScopedDisplayObserver is an RAII class that directly replaces
display::Screen::Add/RemoveObserver.
ScopedOptionalDisplayObserver is the same thing, but handles the case
where display::Screen::GetScreen() is null. This can happen in tests.
This is a non-functional change, intending to replicate existing
behavior exactly.
This CL was uploaded by git cl split.
R=takumif@chromium.org
Bug: 1225463
Change-Id: I7112817f0c17470ab429a08421c54ae179d1083a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003780
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898415}
Window Placement: Implement internal display heuristic for Linux
Set the singleton internal display id from BuildDisplaysFromXRandRInfo.
Assume a display is internal if its name starts with `eDP` or `LVDS`.
Resources used to determine this heuristic:
https://unix.stackexchange.com/questions/515787
https://en.wikipedia.org/wiki/DisplayPort#eDP
xrandr output from my dev device, stackexchange, askubuntu, etc.
Note: We should support multiple internal displays: crbug.com/1078903
Note: Setting a global singleton value here is a bit presumptive.
Bug: 1077361, 1225412, 1225684
Test: Linux laptop screens show "isInternal:true" with: $ chrome --enable-blink-features=WindowPlacement https://michaelwasserman.github.io/window-placement-demo/
Change-Id: I0c1085ee409f20db26bbb47b3d5aba777b5daf38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004000
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Mike Wasserman <msw@chromium.org>
Auto-Submit: Mike Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898414}
[unseasoned-pdf] Add unit tests for DocumentLoadComplete().
Add unit tests for PdfViewPluginBase::DocumentLoadComplete(), which
exercises multiple private methods: DidStopLoading(), SendAttachments(),
SendBookmarks(), SendMetadata(), SendLoadingProgress() and
LoadAccessibility().
Also make `AccessibilityState` and `kMaximumSavedFileSize` public so
that they can be used in unit tests.
Change-Id: I8d548dd1f2eb5f9e6d860b0d8f1e1fe4fb329389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2986560
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898413}
Convert /chrome/browser/ash/crosapi to ScopedDisplayObserver
This is a refactoring to make it easier for future changes to
DisplayObserver, and to clean up manual Add/Remove calls with RAII.
ScopedDisplayObserver is an RAII class that directly replaces
display::Screen::Add/RemoveObserver.
ScopedOptionalDisplayObserver is the same thing, but handles the case
where display::Screen::GetScreen() is null. This can happen in tests.
This is a non-functional change, intending to replicate existing
behavior exactly.
This CL was uploaded by git cl split.
R=erikchen@chromium.org
Bug: 1225463
Change-Id: I469ca2770f91d1eb4e2927120ea8c3ab865b9e5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004096
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898412}
*Scan: Update histograms.xml to cover mutator events
UMA hists currently only display events performed by the Scanner thread.
This CL fixes it. In addition, it adds the stack scanning event.
Bug: 1129751
Change-Id: I7b970fd6aa7d93fc878b7c8dbced63f37a9f5002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2988316
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Auto-Submit: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898411}
Roll Fuchsia SDK from 5.20210702.1.1 to 5.20210702.3.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Disable-Retries: true
Change-Id: I5909e7260b0d6d3cdae7f0aa1719480e53daa200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004093
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898410}
back_gesture: Add a test to guard destroying window during drag
Adding a test to make sure no crash happens if the window being
destroyed while dragging the back gesture affordance from the left.
OnTouchEvent(ui::TouchEvent* event) should always been triggered with a
valid event target.
SendBackEvent(const gfx::Point& screen_location) is able to handle the
case if the window has been destroyed.
Bug: 1159634
Change-Id: I4cf9612642f53c930b6570724565e2c6c6b637f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004171
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898409}
Fix the composited cursor size
In Ash, the composited cursor size changes with the display size and
doesn't match the hardware cursor. This CL fixes that and adds a test to
make sure the cursors's size match each other.
Bug: 1220826
Change-Id: I31c0aa26f5e08af0614483703d579efd6c02c246
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2949017
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Mitsuru Oshima (OOO back on July 12)) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898408}
[GridNG] |GridChildIterator| deletion
In this change, |GridChildIterator| is deleted due to several reasons:
1. It was creating an extra call to iterate over grid's children, which
resulted in being redundant given that |ConstructAndAppendGridItems|
also does that.
2. Stored grid's children in a vector, only to move those elements to
|grid_items|.
3. It was only called once.
Instead, the logic was moved to |ConstructAndAppendGridItems|. There, we
iterate over the grid's children and sort them (if necessary) directly
in the vector |item_data|. No new tests were added given that
grid-inline-order-property-auto-placement-*.html,
grid-inline-order-property-painting-*.html,
grid-order-property-auto-placement-*.html, and
grid-order-property-painting-*.html already test this behavior.
Perf deltas:
fixed-grid-lots-of-data.html
avg 83.60192376722262 runs/s -> 86.51449763477322 runs/s (3.48% better)
fixed-grid-lots-of-stretched-data.html
avg 81.30339558654433 runs/s -> 86.34667687450617 runs/s (6.2% better)
auto-grid-lots-of-spanning-data.html
avg 169.05416025775412 runs/s -> 176.64471239176206 runs/s (4.49% better)
nested-grid.html
avg 571.8424931622051 runs/s -> 635.0586262416913 runs/s (11.05% better)
large-grid.html
avg 2.1408513903127084 runs/s -> 2.2210431921964147 runs/s (3.74% better)
Bug: 1045599, 1218290
Change-Id: I3a0fdabdbd3d850543c44ac4cdadaf86b7a74215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2992737
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898407}
[Sheriff] Disable flaky DeclarativeNetRequestBackForwardCacheBrowserTest.BackForwardCacheClearedOnUpdatingSessionRules on Mac
The test also fails on non-arm Mac. See
https://ci.chromium.org/p/chromium/builders/ci/Mac11%20Tests/1756
Bug: 1223379
Change-Id: Ia04abe056622069a432b3010461d881712edcd7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3004094
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898406}
Update Assistant.QueryResponseType histogram expiry.
This CL extends the expiry for above histogram for another year to avoid
losing data.
Bug: 1224454
Change-Id: Id3690929b8ae8fe2cf2109f6d1bf74c6edf9e888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3000734
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898405}
Avoid deadlocks in CallbackController.
The previous implementation used a ReentrantReadWriteLock and a mix of
read and write locks. This is problematic because you cannot upgrade
from a read lock to a write lock. This is done to prevent deadlocking
between threads, but the implementation deadlocks the current thread if
we ever attempt this.
This change switches to a single lock with exclusive access, but because
current usage of CallbackController is primarily on the UI thread there
should be no performance impact.
Existing callers have tried to call #makeCancelable() and #destroy()
while in the middle of #run() from a cancelable callback. It isn't clear
that #destroy() is a valid use case, and ReentrantLock + assert is used
to detect and crash when this happens.
Bug: 1201279
Change-Id: Iee14559961c447fb37d807106096380edde99b8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2994141
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898404}
webfeed: Add more UMA
Add several histograms for WebFeed, and a couple associated
histograms for the For-You feed.
New WebFeed histograms:
ContentSuggestions.Feed.WebFeed.LoadStreamStatus.Initial
ContentSuggestions.Feed.WebFeed.LoadStreamStatus.InitialFromStore
ContentSuggestions.Feed.WebFeed.FollowByIdResult
ContentSuggestions.Feed.WebFeed.FollowUriResult
ContentSuggestions.Feed.WebFeed.UnfollowResult
ContentSuggestions.Feed.WebFeed.RefreshRecommendedFeeds
ContentSuggestions.Feed.WebFeed.RefreshSubscribedFeeds
ContentSuggestions.Feed.WebFeed.ReachedEndOfFeed
ContentSuggestions.Feed.WebFeed.LoadedCardCount
New Feed histograms:
ContentSuggestions.Feed.LoadedCardCount
ContentSuggestions.Feed.ReachedEndOfFeed
Bug: 1152592
Change-Id: If0d36c00562d1c34edab91cb13a4db463ba3b9e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2976107
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898403}
Roll androidx from vkahwUbk9... to wMIw6roM8...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: mheikal@google.com,clank-library-failures@google.com
Change-Id: Ibce0d32bce78eb8939a8020cd7b1a22bc8c1dcb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3003989
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#898402}