Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
[infra] Add more compile targets to __use_large_b289968566 for ci/Linux MSan Builder
Some local fallback compiles cause build failures for OOM on
the builder.
This CL runs those large compiles on a large worker to avoid
the remote/local OOM.
This CL also increases the timeout to 4m because the clang/cxx/b289968566/exit-137 actions sometimes fail for remote
timeout. (exit code 142)
Bug: 329698344
Cq-Include-Trybots: luci.chromium.try:linux_chromium_asan_siso_rel_ng
Cq-Include-Trybots: luci.chromium.try:linux_chromium_tsan_siso_rel_ng
Change-Id: I3a9f9c3d16a762350e2b38e5507d910cf63715b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372769
Commit-Queue: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273296}
Add test to //content against webview blink extension
The javascript interfaces in
//third_party/blink/renderer/extensions/webview should never be exposed
by default.
This test is expected to fail if the interfaces are enabled by default
on any platform.
The feature should only be compiled into Android build targets, and
unlike the web_exposed tests, this test will also run on Android test
runners.
Bug: 327186031
Change-Id: I43e131c7eb4435c852ea48449a0cce4432be41c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5371882
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Peter Pakkenberg <pbirk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273295}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1710482292-48f32573db5a686277201140f9626016fad33562-a8edc7ca6f74254d2dba0d96f0f54dbf63505aed.profdata to chrome-mac-arm-main-1710489416-f2f25403f7e40d1c9220091d1736bebca6a90d61-6dec4dfb02c07d147b3e1f0b8476da50c123fa96.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I41cae2626a2943ce5392b2b29e0bbb74f57df2b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373711
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273294}
[histograms] Extend WebCore.Scripts.V8CompileHintsStatus
The histogram was recently fixed in https://chromium-review.googlesource.com/c/chromium/src/+/5344415
Bug: b/40286622
Change-Id: If07ed6108b640e792f418f6fb872b630ed3d892f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5361438
Commit-Queue: Marja Hölttä <marja@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273293}
Remove FormData::FillData
Autofill flattens forms across frames and routes all iframe forms into
their enclosing main frame form (as detailed in form_forest.h).
In case of iframes with multiple forms (multiple <form> elements or both
form and formless elements), this causes a preview problem because we
currently route every single filling call by itself, and every filling
call clears the preview of anything that could've happened before, which
means that in the described case only the last form that is sent to the
renderer for filling will actually be previewed.
To overcome this, we make the agent fill a list of fields
instead, so that we can pass all concerned fields of a single frame in a
single function call.
Precisely, this CL:
- Removes FormData::FillData
- Adds FormFieldData::FillData::host_form_id
- Updates AutofillAgent::ApplyFormAction to take a list of fields
instead of a form and updates its implementation accordingly.
- Renames [AutofillAgent|form_util]::ApplyFormAction to
ApplyFieldsAction, reflecting the shift in perspective.
A follow-up CL will ensure that every frame gets a single fill call per
autofill operation.
Bug: 40943206, 41489087
Change-Id: I5ddcba8c014fca4a3bfec9b20b97fd47301c7524
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5331893
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Jihad Hanna <jihadghanna@google.com>
Reviewed-by: Christoph Schwering <schwering@google.com>
Cr-Commit-Position: refs/heads/main@{#1273292}
Roll Perfetto from d8a17b3639b4 to c709ee6421ca (1 revision)
https://android.googlesource.com/platform/external/perfetto.git/+log/d8a17b3639b4..c709ee6421ca
2024-03-15 mayzner@google.com Merge "tp: Fix interval intersect taking empty tables" into main
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com,primiano@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I35a3a75868c303046b6ee6212cabcb03fb6950a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374125
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273291}
Bundz: support custom parameters for model execution session creation
Integrating with the updated optimization guide
(https://crrev.com/c/5346730) to pass the top_k and temperature for
model execution session creation.
Bug: 324165372
Change-Id: I55e18062092d07067a8f49679ca866af2f138c24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5359219
Reviewed-by: Fergal Daly <fergal@chromium.org>
Commit-Queue: Mingyu Lei <leimy@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273290}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1710460785-6afc19f68882a9ec68c52dae4e408756bbda18a5-74eb4072e43151a657d48a8132a9b52f270e40f1.profdata to chrome-mac-main-1710482292-4c4f49a379e928fa997a17d4ee182282af7945a5-a8edc7ca6f74254d2dba0d96f0f54dbf63505aed.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I990c2c6e82495a8f658e439a5b0a656247259616
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373675
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273289}
cryptohome: Add UMA event when Downloads folder is already migrated
BUG=b:329533315
Change-Id: Ib8ce45c5f0c0d7ed68dcb97a849ab3787c15e7f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366737
Commit-Queue: Howard Yang <hcyang@google.com>
Auto-Submit: François Degros <fdegros@chromium.org>
Reviewed-by: Howard Yang <hcyang@google.com>
Cr-Commit-Position: refs/heads/main@{#1273288}
Avoid some descendant checks in HTMLFormElement::CollectListedElements.
Bug: 327318196
Change-Id: I4069a8a63ae642bd4cdd3092190d277a97454090
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366402
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1273287}
[css-anchor-position] Stop passing @position-fallback rules
As part of fully removing support for @position-fallback, don't pass any
@position-fallback rules over the devtools protocol. The protocol is not
modified, but the list of rules is never passed. This removes
dependencies on the @position-fallback code in css/ to make it possible
to remove the css/ part of the code.
Bug: 40279608
Change-Id: I03bdc44f8e7fce6c10878316ab7f55fd90f02214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5369919
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273286}
[ios] Add feature flag to adopt a unified BookmarkModel instance
The flag represents a technical rollout including a data migration for
pre-existing users (non-empty bookmark JSON files).
Change-Id: I66aa148e7b6d490410b9d108c65f3fef8fa093ba
Bug: 326185948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366308
Reviewed-by: Arthur Milchior <arthurmilchior@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273285}
gardening: Disable drivefs related tests on betty-pi-arc builders
We disabled the following tests on the reven builder as they were flaky:
- filemanager.DrivefsUI.fieldtrial_testing_config_on
- filemanager.DrivefsUI.fieldtrial_testing_config_off
- platform.Drivefs
This CL disables these tests on betty-pi-arc builders too.
Bug: 314004675
Change-Id: I761ecbc5772db858e35f08ba2dc7ca7547886091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366479
Reviewed-by: Eriko Kurimoto <elkurin@chromium.org>
Owners-Override: Eriko Kurimoto <elkurin@chromium.org>
Commit-Queue: Jun Ishiguro <junis@google.com>
Cr-Commit-Position: refs/heads/main@{#1273284}
IWYU: usage of WebNNBufferImpl requires include in context_impl.cc
Bug: 40939315
Change-Id: I3a87b4f021281668f8083fedca7be0b9e06562ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5369297
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1273283}
[Signin][Android] Remove outdated DisableIf.Build
Android O is the lowest supported SDK now, so
`sdk_is_less_than = Build.VERSION_CODES.O` is redundant.
Bug: 40919259
Change-Id: I1eb952a3187595c22fbbb2e41d8d467e3af62eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366594
Commit-Queue: Samar Chehade-Lepleux <samarchehade@google.com>
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Samar Chehade-Lepleux <samarchehade@google.com>
Cr-Commit-Position: refs/heads/main@{#1273282}
Add new print scaling option: kCenterShrinkToFitPaper
When printing HTML (using Blink), we'd use kSourceSize when printing to
PDF, and kFitToPrintableArea when printing to a printer. The latter
doesn't really match what we do. We actually ignore the printable area,
and instead use the entire paper. As such, kFitToPaper would be slightly
more correct, but that option, just like kFitToPrintableArea, expects
the page to be scaled up if it's smaller than the paper.
What printing (to a printer) with Blink actually does, is to center the
page on paper. If the page size is larger than the paper, it's scaled
down and centered. If it's smaller, it's just centered.
Therefore, add kCenterShrinkToFitPaper, to avoid confusion (and to
allow for adding support for the other options in the future, if that
ever becomes a priority).
No behavior changes intended.
Change-Id: I4e86b492c8330e173535d97eaa6dc931f3e52b7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5349263
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Alan Screen <awscreen@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273281}
Roll Chrome Linux PGO Profile
Roll Chrome Linux PGO profile from chrome-linux-main-1710460785-7b0677c8e3d81c39bab548dfbbd5197c66fe01a9-74eb4072e43151a657d48a8132a9b52f270e40f1.profdata to chrome-linux-main-1710482292-575a6a3923a92153b3a9aa6fb79dbe0456f908d3-a8edc7ca6f74254d2dba0d96f0f54dbf63505aed.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I2b01d761a401f415931aeb3d430d2bd4b012412e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373709
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273280}
Revert "[pdf-a11y]: move PluginAXTreeSource|Serializer to AXObject"
This reverts commit d9760566d4317197151b7bac1cc1a606f239ada3.
Reason for revert: Breaking arc.Print.container_p. See b/326733014
Original change's description:
> [pdf-a11y]: move PluginAXTreeSource|Serializer to AXObject
>
> This change continues the work described in
> go/chrome-pdf-a11y-stabilization:
> - moves (most) plugin tree state and logic into Blink AXObject
> - simplifies dependency into and out of RenderAccessibilityImpl
> - makes the plugin tree a pure AXTreeSource
> - revamps RenderAccessibilityImpl -> plugin tree relationship as purely one for actions (via a new adapter interface)
> - numerous cleanups, simplifications
>
> Bug: 326131114
> Test: cq
>
> Change-Id: Ifa4f7a94cd7e259948873cff7606be3f336ffe96
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5302041
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1264786}
Bug: 326131114, 326733014
Change-Id: Icc1b035e59d2418f947d65aec52ee754e1056d51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5369604
Owners-Override: Eriko Kurimoto <elkurin@chromium.org>
Reviewed-by: Jun Ishiguro <junis@google.com>
Commit-Queue: Eriko Kurimoto <elkurin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273279}
Revert "[NTP XDTR] Preredesign Dismiss Button not working"
This reverts commit 75c4a29668fe9bbdf4e2a6b649daedc262064c0d.
Reason for revert: NewTabPageModulesTabResumptionModuleTest.Core is failing on linux-chromeos-chrome and linux-lacros-chrome
Original change's description:
> [NTP XDTR] Preredesign Dismiss Button not working
>
> The dismiss button was wired to use post redesign event handler. Now
> it conditionally uses the pre redesign modules event handler.
>
> Bug: 329724353
> Change-Id: I283fa0e244415e1fcc225d69dac9ca4f8b0ec277
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373483
> Commit-Queue: Roman Arora <romanarora@chromium.org>
> Reviewed-by: Roman Arora <romanarora@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1273220}
Bug: 329724353
Change-Id: I685f40159cf8963f8eb0ce9df2b0ed024b93552e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5370447
Auto-Submit: Jun Ishiguro <junis@google.com>
Owners-Override: Jun Ishiguro <junis@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jun Ishiguro <junis@google.com>
Cr-Commit-Position: refs/heads/main@{#1273278}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1710431931-8cffff4da0fe2a2fda875baae12cee5d6fae6880-f122c7fc24a8d5b293af784b9bc6fe8953a266cf.profdata to chrome-android64-main-1710482292-9e12507b625ef958473689d1e65005199af70d6c-a8edc7ca6f74254d2dba0d96f0f54dbf63505aed.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ibcfc47c6804cf8a2c34b8122529b7e90458ce1d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373582
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273277}
Roll androidx from 4vW4qxSSNnCeC_jZh... to yUsx7roAiMXjsHKK_...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/androidx-chromium
Please CC clank-build@google.com,clank-library-failures@google.com,wnwen@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel
Tbr: clank-library-failures@google.com
Change-Id: I63f5fca97ee524b0086631cf3e3c066b7d5df20c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373677
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273276}
Roll Skia from 3ca00032d71a to ad5bed0f3a57 (1 revision)
https://skia.googlesource.com/skia.git/+log/3ca00032d71a..ad5bed0f3a57
2024-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9bae58594634 to 7220307bb2fb (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC fmalita@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: fmalita@google.com
Change-Id: I2ece40d95859533bc1e9547c1b160a6a19241ccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372158
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273275}
Revert "[pdf-a11y]: allow for null/detached AXObject(s) backing the PDF plugin container"
This reverts commit 930c28574493194eb48b9e1372449155a66e4e93.
Reason for revert: Breaking arc.Print.container_p. See b/326733014
Original change's description:
> [pdf-a11y]: allow for null/detached AXObject(s) backing the PDF plugin container
>
> In
> https://crrev.com/c/5302041
>
> we attach the plugin a11y tree directly using the WebAXObject for the
> PDF's plugin container element through UpdateDependentObjects.
>
> This method may be called even when accessibility is off, so it is
> reasonable to have a null/detached WebAXObject in production.
>
> Example calltsack
> pdf::PdfAccessibilityTree::UpdateDependentObjects
> pdf::PdfAccessibilityTree::MaybeHandleAccessibilityChange
> pdf::PdfAccessibilityTree::PdfAccessibilityTree
> pdf::PdfViewWebPluginClient::CreateAccessibilityDataHandler
>
> R=thestig@chromium.org
>
> Fixed: 326720339
> Test: cq
> Change-Id: Ic99aadbf037964297587fa0ae843b34ec8ba45f1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5322522
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1264906}
Bug: 326733014
Change-Id: I9d02963662d33adde24f80f940d57f03ffed4eb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5369603
Commit-Queue: Eriko Kurimoto <elkurin@chromium.org>
Owners-Override: Eriko Kurimoto <elkurin@chromium.org>
Reviewed-by: Jun Ishiguro <junis@google.com>
Cr-Commit-Position: refs/heads/main@{#1273274}
Revert "[pdf-a11y]: further simplify PluginAXTreeActionTargetAdapter"
This reverts commit 7503f7541656328fcaca10d75002ecb2882e0624.
Reason for revert: Breaking arc.Print.container_p. See b/326733014
Original change's description:
> [pdf-a11y]: further simplify PluginAXTreeActionTargetAdapter
>
> Following comments from
> https://crrev.com/c/5302041
> - simplify the PluginAXTreeActionTargetAdapter interface by combining
> the two methods. GetFromId is not strictly needed as the only
> production callsite used it immediately before calling the other
> method, CreateActionTarget.
> - addresses one nit
>
> Bug: 326131114
> Test: cq
> Change-Id: I4bbf1cf5365c4857422bb46b0d6cf56ba28fbd57
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5322047
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1265511}
Bug: 326131114, 326733014
Change-Id: I455da818a6a540413a2b43cda66e53ce90184cdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5369301
Owners-Override: Eriko Kurimoto <elkurin@chromium.org>
Reviewed-by: Jun Ishiguro <junis@google.com>
Commit-Queue: Eriko Kurimoto <elkurin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273273}
[//media] Rename variables to match names of base::Features
Followup to [1]. Has no functional impact, but eliminates chance that
someone in the future incorrectly renames either of the base::Features
back to the variable name.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/5349219
Bug: 328540028
Change-Id: Ib179cd81890ca8b8ccd75ad1805d29ab8cac80fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372043
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273272}
Roll devtools-internal from 422f3d5a3d07 to 5359a8dddc8d (1 revision)
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/422f3d5a3d07..5359a8dddc8d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/devtools-internal-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: devtools-waterfall-sheriff-onduty@rotations.google.com
Change-Id: I0a3c3c658d8f8a55b3685962f780dc705a0b2070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373672
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273271}
[local compile hints] Generate local compile hints multiple times
Previously, we generated local compile hints only when the page turned
interactive. It's possible that the user navigates away before that, so
in that case we didn't get any compile hints.
This CL makes us compile hints earlier, and when the page turns
interactive, we generate them again and replace the data.
We also add a histogram for observing how many navigations now
create compile hints data vs. how many would have created it in
the original version.
Bug: 40286622
Change-Id: Iec1bd1ec26a5fe870c456d1977109912cc560482
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5344969
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273270}
Unify Fake{,Chrome}UserManager::UserLoggedIn.
Specifically, FakeChromeUserManager currently looks up User by
username_hash, which is different from the production behavior.
This CL gives it a try to slightly unify into the production
behavior, while FakeUserManager::UserLoggedIn still has
difference from the real production.
BUG=b:278643115
TEST=Tryjob
Change-Id: Iee530b45829509d2bf09012206186d2018503820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366221
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273269}
Gardening: mark canvas-blend-image.html as slow on Win
A wrong test was marked as slow in https://crrev.com/c/5371650, this CL
fixes that.
Bug: 1081534
Change-Id: I42502a2d3057fc3e20ce060b14e9335fc40bd517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5371656
Auto-Submit: Mingyu Lei <leimy@chromium.org>
Commit-Queue: Mingyu Lei <leimy@chromium.org>
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Owners-Override: Mingyu Lei <leimy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273268}
Revert "[pdf-a11y]: enable tree consistency checks for plugin tree"
This reverts commit a6f948e7126bcb0d99e93a2347d3c9fa647adfa6.
Reason for revert: Breaking arc.Print.container_p. See b/326733014
Original change's description:
> [pdf-a11y]: enable tree consistency checks for plugin tree
>
> R=aleventhal@chromium.org
>
> Bug: 326131114
> Test: cq
> Change-Id: I03720dea3d63c9afc7ea5089d90d30676c3a161c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5323727
> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1266161}
Bug: 326131114, 326733014
Change-Id: I520295122fb9ed00ccd16b10ccf866513ee3242b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5371655
Reviewed-by: Jun Ishiguro <junis@google.com>
Owners-Override: Eriko Kurimoto <elkurin@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273267}
[rbe] Rebase //build/config/unsafe_buffers_paths.txt with rbe_exec_root
Rewrapper's -inputs flag is based on -exec_root.
When `rbe_exec_root` GN arg is specified, `-inputs=build/config/unsafe_buffers_paths.txt` doesn't work as expected.
This CL rebases the rewrapper inputs path with rbe_exec_root.
Bug: b/329458056
Fixed: b/329458056
Change-Id: I08772dbe5ae9e3a9e50cb8cd4f7e7e9c06bad18d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367053
Reviewed-by: Michael Savigny <msavigny@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#1273266}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1710460785-4f4a9adfdaa3672abecaa7718838611678da7354-74eb4072e43151a657d48a8132a9b52f270e40f1.profdata to chrome-win32-main-1710471462-789114a3e0b1f00dc41c5db9b355de9637427df6-696ad6e923adfe1bf8447d07202e0f31bb54ff98.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I345513e520a7e3e4d2656787cb87d38bbf387a97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372154
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273265}
Revert "[pdf-a11y]: be more assertive in resetting the plugin serializer"
This reverts commit 3c23a932f1cbd5f0a88f5a206a83ea8d3ced0fee.
Reason for revert: Breaking arc.Print.container_p. See b/326733014
Original change's description:
> [pdf-a11y]: be more assertive in resetting the plugin serializer
>
> The PDF a11y tree and serializer have a tenuous stitch to the ancestor
> nodes. In particular, any subtree clears in the ancestry nodes require
> the serializer to be cleared. If not, potential bugs like the one
> referenced occur where descendants in PDF are not re-sent.
>
> In the past, we dealt with this by always serializing the entire PDF
> a11y tree i.e.
> https://crrev.com/c/5274721
>
> Though this "works", it always means shoving a lot of data into an IPC
> to the browser. Consider a 200 page PDF.
>
> This change attempts to cover more of the cases that may arise in which
> we want to reset the plugin serializer:
> - calls to AXObjectCacheImpl::Reset. These come from requests from the
> browser to re-send all data.
> - update->node_id_to_clear > 0 during
> AXObjectCacheImpl::SerializeDirtyObjectsAndEvents. THis change makes
> it so that we reset the plugin serializer for *any* node clearing (its
> subtree) even if the update contains no embedded objects.
>
> R=aleventhal@chromium.org
>
> Bug: 326733014
> Test: cq
> Change-Id: I8adaae9456ddc134ad8204154bf711b5dfaef387
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5347803
> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1269165}
Bug: 326733014, 326733014
Change-Id: I1d5dc79618e678e1a567f5babd082557d705fe50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372768
Commit-Queue: Eriko Kurimoto <elkurin@chromium.org>
Owners-Override: Eriko Kurimoto <elkurin@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273264}
Roll Chrome Win ARM64 PGO Profile
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1710460785-cd62f58db9c48a595190a1c141a727e0d15d574f-74eb4072e43151a657d48a8132a9b52f270e40f1.profdata to chrome-win-arm64-main-1710482292-bd7939a90bce50866fc54d2f893f1b2154e372c7-a8edc7ca6f74254d2dba0d96f0f54dbf63505aed.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I48cade192a4a755c3e83eb6aa102797bee6a3749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374070
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273263}
environment_provider: Remove dependency from BrowserManager/Launcher
This CL makes EnvironmentProvider singleton and remove the dependency
from BrowserManager and BrowserLauncher. It also moves some APIs in
EnvironmentProvider to crosapi_util anonymous space for APIs which are
independent from chrome/*.
This is a preparation to move EnvironmentProvider APIs to chromeos/*.
This does not change the behavior.
Bug: 328682979
Change-Id: I03820bd74d378788861831486d8b0fdd6397b40a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5355055
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273262}
Roll Depot Tools from 79e1a7174c79 to 43bedd368b14 (1 revision)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/79e1a7174c79..43bedd368b14
2024-03-15 philwo@google.com reclient_helper.py: Simplify workspace_is_on_slow_filesystem
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,aravindvasudev@google.com,gavinmak@google.com,sokcevic@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ajp@google.com,aravindvasudev@google.com,gavinmak@google.com,sokcevic@chromium.org
Change-Id: Ie8f9a9dca0f2a01b36f38fa457578887de782623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373705
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273261}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1710474654-04221e5daaf9687a83f66bcb22d530d606f31b49-a52e68a35886619d8b4109fbebb12169555618c6.profdata to chrome-mac-arm-main-1710482292-48f32573db5a686277201140f9626016fad33562-a8edc7ca6f74254d2dba0d96f0f54dbf63505aed.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I6ccb8aa61a107c1c6473edd9773bca90cea3c570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374068
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273260}
environment_provider: Remove fields from EnvironmentProvider
This CL removes fields from EnvironemtnProvider.
This is a part of the work to resolve the dependency with
EnvironmentProvider.
Bug: 328682979
Change-Id: Icd525370fb7854c4c045256ce995e73e20459516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5355411
Commit-Queue: Eriko Kurimoto <elkurin@chromium.org>
Reviewed-by: Igor <igorcov@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273259}
Use strict script src directives instead of hash
Based on feedback from Security team changing this to use strict
security policy directive instead of using strict-dynamic with hash
or naunce. #HATS
Change-Id: Ic7180d145f22866b08d17a9581011278effc6d95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372266
Reviewed-by: Florian Jacky <fjacky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mohamad Arab <arabm@google.com>
Cr-Commit-Position: refs/heads/main@{#1273258}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1710460785-15fe65a7685afb8a0ad524fce6d98c65bef44353-74eb4072e43151a657d48a8132a9b52f270e40f1.profdata to chrome-win64-main-1710471462-ff1d27670dc6b4fff129d57a95bc5874c3ee8a33-696ad6e923adfe1bf8447d07202e0f31bb54ff98.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ibb36c6230b3db4433dadca7ce6243cf0f2cacfee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373665
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273257}
Roll Skia from 11b1a958c2ac to 3ca00032d71a (1 revision)
https://skia.googlesource.com/skia.git/+log/11b1a958c2ac..3ca00032d71a
2024-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 50284718beca to decb591ea60d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC fmalita@google.com,skiabot@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: fmalita@google.com
Change-Id: I2701f8153d5c6273ee4dcea5a8a7467cf14a09bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374064
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273256}
siso: Add more actions to large compile list for asan builds
Bug: b/311312613
Change-Id: I9954b48974741dcb9a20d22aa6f7f1d9a620dff4
Cq-Include-Trybots: luci.chromium.try:linux_chromium_asan_siso_rel_ng
Cq-Include-Trybots: luci.chromium.try:linux_chromium_tsan_siso_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5373983
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Cr-Commit-Position: refs/heads/main@{#1273255}
text-box-trim: remove the logic of trimming leading from inline boxes
Trimming inline boxes will be determined by line-box-edge but we are
focusing on "text-box-trim" + "text-box-edge" first.
So, this CL removes the logic of trimming inline boxes for now.
Bug: 40254880
Change-Id: Ib7effb57cd9927996ed33f746bdf8d273334fde9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366784
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Lingqi Chi <lingqi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273254}
Roll Chrome Android ARM32 PGO Profile
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1710460785-e0fc246bab2a9db7127e2c04942b5c1baf61b637-74eb4072e43151a657d48a8132a9b52f270e40f1.profdata to chrome-android32-main-1710482292-2de59f4f1947a445dedcd97a8c16a10150c4aebf-a8edc7ca6f74254d2dba0d96f0f54dbf63505aed.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I12cbc2c7eb78a45356a08cddfb8443c1b697e278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372157
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273253}
[lacros skew tests] Refresh skew tests for M124
This CL updates the ash version ['124.0.6359.0'] for Lacros version skew testing.
This cl only affect linux-lacros config builders like
linux-lacros-tester-rel, linux-lacros-rel.
This cl will certainly NOT affect Lacros on-device builders
(lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab,
etc) or any other platforms.
If this CL caused regressions, please revert and stop the autoroller
at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller
Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org.
R=rubber-stamper@appspot.gserviceaccount.com
Bug: None
Change-Id: I01be0c6c121f73f3fd7281ce4235777dd7e42e2a
Requires-Testing: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5372905
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1273252}
Gardening: disable flaky test on Linux MSAN
Bug: 329174385
Change-Id: I62fad4b7ce376eb76cf7c234ca45142671b58ce0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367786
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Mingyu Lei <leimy@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Auto-Submit: Mingyu Lei <leimy@chromium.org>
Owners-Override: Mingyu Lei <leimy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273251}
Reland "Reland "Load QuickOffice manifest from cros rootfs""
This reverts commit 9d571b2d7905fe48fafee1eabeb83e9a24f5a551.
Reason for revert: tests fixed
PS1: revert/reland
PS2: rebase
PS3: Added //chrome/test/data version of quickoffice manifest.json
Loading manifest and contents from rootfs will ensure that
QO always has the correct manifest for contents, especially for
lacros.
Original change's description:
> Revert "Reland "Load QuickOffice manifest from cros rootfs""
>
> This reverts commit 336415fa902298ba2f5e0da9d962fd61dedff5d8.
>
> Reason for revert: suspect causing browser_tests failure on linux-chromeos-chrome
>
> browser_tests failed because of:
> All/FileTasksBrowserTest.FallbackSucceedsWithQuickOffice/Guest
> All/FileTasksBrowserTest.FallbackSucceedsWithQuickOffice/Regular
> All/FileTasksBrowserTest.QuickOffice/Guest
> All/FileTasksBrowserTest.QuickOffice/Incognito
> ...6 more failure(s) (10 total)...
>
> The first build failure:
> https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/37099/overview
>
> Original change's description:
> > Reland "Load QuickOffice manifest from cros rootfs"
> >
> > This reverts commit 05780297d2cd6230f32d3671022366447da79f73.
> >
> > Reason for revert: Fixed compile error
> >
> > Original change's description:
> > > Revert "Load QuickOffice manifest from cros rootfs"
> > >
> > > This reverts commit a1b9a2a855e11df2b04d6643c459e3fec2a8ebe6.
> > >
> > > Reason for revert: suspect causing compile failure on lacros-arm32-rel-ready bot.
> > >
> > > First build failure:
> > > https://ci.chromium.org/ui/p/chrome/builders/ci/lacros-arm32-rel-ready/17628/overview
> > >
> > > Sample log:
> > > ../../chrome/browser/extensions/component_loader.cc:550:7: error: use of undeclared identifier 'AddComponentFromDirWithManifestFilename'
> > > AddComponentFromDirWithManifestFilename(
> > > ^
> > > 1 error generated.
> > >
> > > Original change's description:
> > > > Load QuickOffice manifest from cros rootfs
> > > >
> > > > QuickOffice will change in crrev.com/c/5014644 to load all files
> > > > including manifest.json into rootfs at
> > > > /usr/share/chromeos-assets/quickoffice.
> > > >
> > > > CrOS will load all files directly from gcs rather than using the
> > > > chromium repo submodule. There will be no need to keep
> > > > chrome/browser/resources/chromeos/quickoffice.
> > > >
> > > > Bug: 1491571
> > > > Change-Id: I1f1de7cc1c4950b4fd30d1bab8300faf6b7e8494
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5013290
> > > > Commit-Queue: Joel Hockey <joelhockey@chromium.org>
> > > > Reviewed-by: Dominick Ng <dominickn@chromium.org>
> > > > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> > > > Cr-Commit-Position: refs/heads/main@{#1222566}
> > >
> > > Bug: 1491571
> > > Change-Id: Ifdc07c1b1b21caf0bf5ad35913bb1c2a12dd3f51
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5017114
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Owners-Override: Takashi Sakamoto <tasak@google.com>
> > > Commit-Queue: Takashi Sakamoto <tasak@google.com>
> > > Cr-Commit-Position: refs/heads/main@{#1222647}
> >
> > Bug: 1491571
> > Change-Id: Ifed4ad16a0e646a23a2da62e06483cf47af1ea2b
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018558
> > Reviewed-by: Takashi Sakamoto <tasak@google.com>
> > Commit-Queue: Joel Hockey <joelhockey@chromium.org>
> > Reviewed-by: Dominick Ng <dominickn@chromium.org>
> > Owners-Override: Takashi Sakamoto <tasak@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1222715}
>
> Bug: 1491571
> Change-Id: I771e0ccc0e1e9e1213c494746345085338e9868d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5017601
> Owners-Override: Takashi Sakamoto <tasak@google.com>
> Commit-Queue: Takashi Sakamoto <tasak@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1222771}
Bug: 1491571
Change-Id: I51ba69366039ff06837b837ae47ede71a7957990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5369299
Owners-Override: Eriko Kurimoto <elkurin@chromium.org>
Reviewed-by: Alexander Bolodurin <alexbn@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Eriko Kurimoto <elkurin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273250}
Shared Storage: Pass FrameTreeNodeId to DevTools Shared Storage events
We recently changed Shared Storage event notifications sent to
DevTools so that they would pass a `GlobalRenderFrameHostId ` to the
DevTools `content::StorageHandler` instead of the DevTools frame
token (https://crrev.com/c/5357793).
But this inadvertently introduced a behavior change, as the the
`GlobalRenderFrameHostId` currently changes on certain navigations,
unlike the DevTools frame token, and moreover the former should
eventually change on every navigation with the new "RenderDocument"
feature.
The end result would still be the same for the current use case of
Shared Storage event notifications, as DevTools would still recover
the same frame token despite the changed routing id, but this new
behavior makes testing more difficult.
Hence, we switch to passing `FrameTreeNodeId` instead, as this id
will not change upon navigation.
Bug: 328823983
Change-Id: I13a9b61f37fb2a4bb38af908ba7809ae0f9be483
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5370400
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273249}
Add NotCondition support to ServiceWorkerRouterEvaluator
This CL adds evaluation logic on the not condition to ServiceWorker
router evaluator.
Explainer: https://github.com/WICG/service-worker-static-routing-api/blob/main/final-form.md
Design Doc: https://docs.google.com/document/d/1B2D8w_2M4j9CZC1VccBOAhfCdiRP3yPCSV5UKKDhU70/
Change-Id: Ie281a2b099beb50ad75b8cdb223a5414c49161a0
Bug: 328565554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5368785
Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Shunya Shishido <sisidovski@chromium.org>
Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273248}
Notify FSP Service observers on shutdown
- file_system_provider::Service is a keyed service while
OneDriveIntegrationServiceAsh isn't.
On OneDriveIntegrationServiceAsh destruction, the observer
tries to remove itself from the FSP service which
is no longer there, so it crashes.
- Changed file_system_provider::Service to notify its
observer when the shutting down starts.
Bug: b:329305132
Change-Id: Ifeee5be1e7591c5c1c32d8a7e2711c1c4d85d6b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5366056
Auto-Submit: Aya Elsayed <ayaelattar@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273247}