Chromium Main Console
| Legend: | Passed | Failed | Running | Exception |
Warmup GetUserDefaultLCID for CsrssLockdown
Enabling CsrssLockdown causes crashes in Windows dlls that
call GetUserDefaultLCID(). Warm this function up before
closing the ALPC port.
Bug: 384336650
Change-Id: I342ea5a1183d1b29e3fc98121147e29418a1c1df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168717
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408049}
Move watermark test utility functions to enterprise owned directories
Bug: 390169141
Change-Id: I7a21700cb26bf0c1bb41bfa24cdfd69a3f1d4859
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6177156
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nasser Al-shawwa <alshawwa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408048}
Don't show memory saver iph on high-memory devices
Bug: 40928271
Change-Id: Ib1adc1a3437f7e9adb80adaaf35393e63d3bc94b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6173295
Reviewed-by: Alison Gale <agale@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Emily Shack <emshack@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408047}
[Extensions] Fix some unsafe buffer access issues.
This CL fixes unsafe buffer issues in the ChromeOS native message host
code.
Bug: 351564777
Change-Id: I07bf270fb391abfed4969d16cbb0b9aa95776518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180745
Reviewed-by: Timothy Loh <timloh@chromium.org>
Auto-Submit: David Bertoni <dbertoni@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Emilia Paz <emiliapaz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408046}
Roll Chrome Win ARM64 PGO Profile
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1737115005-27a96aefc900efe8f0fcb81a754e4faa7675a8a2-623d6c39e745b0364b5e0878f07acda7defaa7b9.profdata to chrome-win-arm64-main-1737136754-25e26133ca72705eeeea0b076b82527747fcce10-df4518b150c1be94e9cf81d4cec18313497d1fc0.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I73a376b43b4b9dfeba4255e8bd47b48e29796d22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6182470
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408045}
sunfish: Enforce browser enterprise policy
This CL enforces sunfish behind the browser policy in accordance with
https://docs.google.com/document/d/1sHRNp2WsVwjaGOkwByx9tfqSGxwqP5VLBfEB9Y_gExY/edit?usp=sharing.
This CL was originally authored by sophiewen@.
SunfishBrowserTest.BrowserPolicy
Fixed: b:384797828
Test: SunfishTest.CheckSearchPolicy,
Change-Id: I53ab99e86eb64eb09c9c8bd4c5477fd1a0d5d1e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6174815
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Elijah Hewer <hewer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408044}
Reland "[iOS] Update the Magic Stack card for dynamic font sizes."
This is a reland of commit b9f8131bcde0ff21d4a7cdfd36b53d66169195fe
that removes static initializers.
Original change's description:
> [iOS] Update the Magic Stack card for dynamic font sizes.
>
> Update the Magic Stack to dynamically adjust the card height based on
> the user's font size.
>
> Updated Magic Stack: go/magic-stack-polish
>
> Fixed: 378773890
> Change-Id: I79f0e99f44fc69a24f8d9d522ad9e3ad471ff929
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6065038
> Auto-Submit: Briana McClure <bmcclure@google.com>
> Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
> Reviewed-by: Scott Yoder <scottyoder@google.com>
> Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1407515}
Change-Id: Ia786c8032e7387741c5e5eb4f26e29ff116c0254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180669
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Briana McClure <bmcclure@google.com>
Reviewed-by: Scott Yoder <scottyoder@google.com>
Cr-Commit-Position: refs/heads/main@{#1408043}
Remove SharedBitmapManager and ServerSharedBitmapManager
These classes are no longer needed after converting SharedBitmap to
SharedImage
Bug: 40064122
Change-Id: I3905b0b2fe5c9c7a230acb3cfef033221417b6e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164697
Reviewed-by: Mike Wasserman <msw@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408042}
[CrOS Cellular] Deprecating create custom apn result histogram
In an earlier CL, we changed the enum for this histogram from
BooleanSuccess to CreateCustomApnResult. We should have deprecated the
old histogram and created a new one along with that change.
Change-Id: I9c2d2cdade158ee61651311712326317b78e2bed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179076
Commit-Queue: Nikhil Nayunigari <nikhilcn@google.com>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408041}
Move FrameSinkManagerImpl::InitParams away from SharedBitmapManager
SharedBitmapManager is no longer used after converting SharedBitmap to
SharedImage.
Bug: 40064122
Change-Id: I3e56a10f3ff968038312fb7f1c6439d60ea4a9d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180026
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408040}
[TabCollection] Inherit group to not break group contiguity while replacing restored tab.
Bug: 390650656
Change-Id: I7dfc7be8f8417ec5606f022bad1437e4aa56ee65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6182501
Reviewed-by: Darryl James <dljames@chromium.org>
Commit-Queue: Shibalik Mohapatra <shibalik@chromium.org>
Reviewed-by: Eshwar Stalin <estalin@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408039}
[Code Health] Clean up stale base::Feature "NewEvSignalsEnabled"
Bug: 356236229
Change-Id: I1b49acab6225b88ef5ec5cead0bd8c84c09e7b52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6109731
Auto-Submit: Muyao Xu <muyaoxu@google.com>
Commit-Queue: Muyao Xu <muyaoxu@google.com>
Reviewed-by: Sébastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408038}
Roll Chromium Variations from ecd1b2bcb2bc to 187d83f8ee5f (15 revisions)
https://chromium.googlesource.com/chromium-variations.git/+log/ecd1b2bcb2bc..187d83f8ee5f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-variations-chromium
Please CC chrome-metrics-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Variations: https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: chrome-metrics-team@google.com
Change-Id: Iac4acc9a39391b15173bdc05fd3d249073084143
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6182408
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408037}
Fix rust_bindgen header lib anchor module name
We decided to use a different name for this module. See
https://r.android.com/3413202.
Bug: 373864033, b:381421702
Cq-Include-Trybots: luci.chromium.try:android-cronet-arm64-gn2bp-dbg
Change-Id: Ie390a1cd115c0832e70defb11f3e2cb75ab0dabb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6097451
Reviewed-by: Stefano Duo <stefanoduo@google.com>
Reviewed-by: Etienne Dechamps <edechamps@google.com>
Commit-Queue: Stefano Duo <stefanoduo@google.com>
Auto-Submit: Mohannad Farrag <aymanm@google.com>
Cr-Commit-Position: refs/heads/main@{#1408036}
Use RemoveEntryById to erase the entry when restore recent closed tabs
This CL will use the method RemoveEntryById to remove the entry from
entries list of tab restore. Because the iterator may be invaild after
the time-consuming operation.
Change-Id: I70fc581f41fea1a9f88d496b92d367458b77f865
Bug: 390075226
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6176858
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408035}
disable CookiePolicyStorageBrowserTest.NestedThirdPartyIFrameStorage/1
test is consistently flaky on ASAN builds.
Bug: 390648566
Change-Id: I6572d84c5c82eefcd05dbe2dab043f5629184aff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6172586
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: David Pennington <dpenning@chromium.org>
Reviewed-by: Darryl James <dljames@chromium.org>
Owners-Override: David Pennington <dpenning@google.com>
Cr-Commit-Position: refs/heads/main@{#1408034}
Revert "Create Open Attached Animation for Glic Window widget."
This reverts commit e048fcf27702ac75af743964d1f484f5a39bb117.
Reason for revert: Causes nullptr dereference.
Original change's description:
> Create Open Attached Animation for Glic Window widget.
>
> Updated demo:
> https://drive.google.com/file/d/1fVza4T0ejskxvDeiM4TAHXOjXp0H-gX9/view?usp=sharing&resourcekey=0-UfXM_FU_veDhJkRJloVnwg
>
> This approach runs the animation before we know if the web contents are ready - this gives room for the case that the web contents take too long to load or never load so we can display the error/loading state inside the glic window.
>
> Bug: 385205427
> Change-Id: I7dfb66e7d947c68069857e93ce69fef0e5f2774a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6173926
> Reviewed-by: Ian Wells <iwells@chromium.org>
> Commit-Queue: Sana Akbani <sanaakbani@google.com>
> Cr-Commit-Position: refs/heads/main@{#1407647}
Bug: 385205427
Change-Id: I393630af0917f17e4deaf3cfb07c411e9cb7c85f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6181792
Auto-Submit: Erik Chen <erikchen@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408033}
Roll llvm-libc from 3fec72bd5608 to 6fff3df5f281 (1 revision)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/3fec72bd5608..6fff3df5f281
2025-01-17 TheStarOne01@proton.me [libc][docs] Add termios page to the status of implementations docs (#123004)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/llvm-libc-chromium
Please CC lexan@google.com,thakis@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: thakis@google.com
Change-Id: Id1ae7702d99c8accdd488086409023c45abf3d2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6181384
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408032}
Roll clank/internal/apps from 327a12f72fb1 to 1e55d45f129b (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/327a12f72fb1..1e55d45f129b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,ntfschr@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: ntfschr@google.com
No-Try: true
Change-Id: Ic0cc24d5bde266fa541cfcbdaa5c2d58e6d74565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6182466
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408031}
[AppIntegration] Add testing config for auxiliary search.
Add two experiments for AndroidAppIntegrationV2:
1) Enabled: is launch candidate. However, this config will be no op if
the device isn't ready for testing;
2) To allow the feature enabled on testing bots, I also add
"Enabled_SkipSchemaCheck" and listed as the first one for testing.
Bug: 370478696
Change-Id: Idc38096076e49e4c9b193b34425253664da1b99a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179659
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408030}
webview: Add test to verify that storage access does not exist across all frames
Even if we grant the storage access permission, it should still be
per frame. Adding a test to ensure this behavior does not change.
Bug: 390205872
Change-Id: Ibdaf71867ea6603a351a432f7273d2c576dd2d5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180628
Reviewed-by: Chris Fredrickson <cfredric@chromium.org>
Commit-Queue: Rupert Wiser <bewise@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408029}
Disable the allocator shim in AOSP Cronet
Otherwise we end up with the following in AOSP Cronet:
//base:base --[public]-->
//base/allocator/partition_allocator:allocator_shim --[public]-->
//base/allocator/partition_allocator/src/partition_alloc:allocator_shim --[private]-->
//base/allocator/partition_allocator/src/partition_alloc:allocator_core
Which then blows up because partition_alloc:allocator_core doesn't
build in AOSP.
Bug: b:381421702
Change-Id: Id7dd88d79b6478d2d9450ca226c5ad96b04a0498
Cq-Include-Trybots: luci.chromium.try:android-cronet-arm64-gn2bp-dbg
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179216
Auto-Submit: Etienne Dechamps <edechamps@google.com>
Commit-Queue: Etienne Dechamps <edechamps@google.com>
Reviewed-by: Stefano Duo <stefanoduo@google.com>
Cr-Commit-Position: refs/heads/main@{#1408028}
[Data Sharing] Fix missing title for leave/delete
A recent refactor of leave/delete resulted in skipping the fallback
title when leaving/deleting the group for the dialogs. Fix this by
computing the fallback title and update the tests.
Fixed: 389973212
Change-Id: I2f2a2f9a1494c19769750265b80515812930b085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6171635
Commit-Queue: Sky Malice <skym@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408027}
Reland: Inherit service worker controller for srcdoc iframe
This is a reland of http://crrev.com/c/6054691 with changes from
http://crrev.com/c/6081248 for fixing the DCHECK/DwC from the original
change.
Same origin srcdoc iframes should be controlled by the same service
worker that controls the parent frame.
To achieve this, expanded ServiceWorkerClient::InheritControllerFrom to
also support srcdoc iframes and used it to setup service worker client
for srcdoc frames when NavigationRequests for them start.
To allow these clients to show up in clients.matchAll, we update same
origin check in GetWindowClients to use GetLastCommittedOrigin instead
of GetLastCommittedURL from the frames.
As the url for srcdoc iframe is about:srcdoc, when we use origin of that
url for access check, it will fail and hit DCHECK/DwC. So, we switch to
use its creator url, which is captured as url for scope match, when
performing access checks.
As the srcdoc frame test in about-blank-replacement.https.html now
passes, updated expectation to reflect that.
Also added wpt tests to ensure that service worker features work as
expected in srcdoc iframes.
The new behavior is behind the ServiceWorkerSrcdocSupport feature which
is enabled by default.
Bug: 41411856,382895651,382895896
Change-Id: I5d7e96b4838c666842315fce6795a9221e19f61b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6085871
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Liang Zhao <lzhao@microsoft.com>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408026}
Auto-format files ahead of code changes
This applies standard formatting (per git cl format) to the bookmark
HTML writer ahead of subsequent code changes. This will make later diffs
easier to review.
Bug: 390643468
Change-Id: I00f55759c90a217ad0c813e60b0b2278d641bd73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6175134
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: James Lee <ljjlee@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408025}
[wv] Introduce ChromiumStartedGlobals inner class
This makes it less error-prone to use WebViewChromiumAwInit global
variables and tries to ensurethat `startChromiumLocked` must be
called before they can be accessed.
Bug: 389871700, 41442181
Change-Id: Ic1de915c17a1a4ae1e26e15339f7b6e137ea276e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6177270
Commit-Queue: Chidera Olibie <colibie@google.com>
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408024}
Add metadata proto for glic cueing
Bug: 389764666
Change-Id: I23754c95d00ee15ba5535a89dd7926776ef7efe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6182620
Reviewed-by: Raj T <rajendrant@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408023}
Roll Chrome Win64 PGO Profile
Roll Chrome Win64 PGO profile from chrome-win64-main-1737103675-37144d3f5279fbc49c2f576567ba1a1f21eaa6cc-c19fabb3b4ddf650867ee9d59c91fbef047c018a.profdata to chrome-win64-main-1737115005-ad942bc09e91e593cae09fd98db0f9fd8ffc894f-623d6c39e745b0364b5e0878f07acda7defaa7b9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I8b7270612d5e64c0251149eae7c6157d278c7472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6182171
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408022}
Roll DevTools Frontend from d023fd41cb61 to 2b89e974e8cd (2 revisions)
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d023fd41cb61..2b89e974e8cd
2025-01-17 dsv@chromium.org Port filters from the Lit-based datagrid to the ViewportDataGrid
2025-01-17 jacktfranklin@chromium.org RPP-AI: remove `requiresNewConversation` flag
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:390346490,chromium:390371494
Change-Id: Iee9ca762162b0884940852d8d75f5f9f0653c82b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6181862
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408021}
browser: Extend HW mirror mode flag and transfer ownership
enable-hardware_mirror-mode flag expires in M134.
This CL extends the enable-hardware_mirror-mode flag in chrome
browser until M150 and transfers ownership to vincentchiang@. This will
give the Calcium team sufficient time to properly retire the feature.
Bug: 388073815
Test: None
Change-Id: I51f90e491c5aa3d202c25be82b944f376be18433
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164236
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Gil Dekel <gildekel@chromium.org>
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Reviewed-by: Vincent Chiang <vincentchiang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408020}
Share Linux DBus session and system connections
This cuts down on file descriptor usage and bus initialization time by
sharing DBus connections where possible. This is similar to how ChromeOS
has DBusThreadManager to use one D-Bus thread and Bus object for
everything.
R=thestig
Bug: None
Change-Id: I2877d97b01d8359c9f503cdb3d8db1c58a08bd1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180523
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408019}
Roll WebRTC from 88833e6d2258 to b0038dd14a1c (3 revisions)
https://webrtc.googlesource.com/src.git/+log/88833e6d2258..b0038dd14a1c
2025-01-17 eshr@webrtc.org Replace gunit.h macros with WaitUntil in P2P
2025-01-17 eshr@webrtc.org Replace gunit.h macros with WaitUntil in rtc_base/
2025-01-17 tommi@webrtc.org Slight restriction of access to ContentInfo and prefer mid to name.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com,webrtc-infra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I9a0888714b94bd83e5569ade9cb6355b7b687de3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6181857
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408018}
Expose folderType and syncing attributes in extension bookmark API docs
Bug: 383970322, 384024391
Change-Id: I88f2ebcbfcb70b898f9746e52e9bbe766e82b8eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6171729
Reviewed-by: Tim <tjudkins@chromium.org>
Auto-Submit: James Lee <ljjlee@google.com>
Commit-Queue: Tim <tjudkins@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408017}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1737103675-4468051c31afb340fbe369b56ccd4c70c30fce44-c19fabb3b4ddf650867ee9d59c91fbef047c018a.profdata to chrome-win32-main-1737115005-0b019089d8915b27dbbb4c122333197018700b92-623d6c39e745b0364b5e0878f07acda7defaa7b9.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I069271e9a84005c695a4eb4401cc85daed21b7c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180913
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408016}
DOM: Fix moveBefore() disconnected iframe CHECK crash
This CL updates the iframe insertion/removal bookkeeping specific to
moveBefore() that was written with the assumption that all moved nodes
are always connected to the DOM. This code was not updated since
changes to moveBefore() preconditions were made. This CL fixes that,
and adds a test.
R=masonf, nrosenthal
Bug: 40150299, 389339248
Change-Id: I31f23d13f78af3eaa87d03ee7d5703ea97f363c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6182440
Reviewed-by: Noam Rosenthal <nrosenthal@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408015}
Updater: Upload CRURegistrationPaths.m in updater_zip.
This file was added to the registration library in
https://chromium-review.googlesource.com/c/chromium/src/+/6169049
Bug: 341790927
Change-Id: Ic4fab9df3a004383332e145058465b4755508408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180081
Reviewed-by: Adam Norberg <norberg@google.com>
Commit-Queue: Adam Norberg <norberg@google.com>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408014}
[PIX] AutofillImageFetcher refactor - Phase 4
Modularize image treatment code. Create a method to add border.
The new method is created by breaking up treatPixAccountImage so it can
be used by other payment methods. This patch does not change existing
code behavior.
go/autofill-image-fetcher-refactor
Pix icon before refactor: https://screenshot.googleplex.com/7Q8uBLoySLUAmg9.png
Pix icon after refactor: https://screenshot.googleplex.com/ku5mQVk76BMNLhk.png
The new API also works for the cards(it's not used for cards yet):
Old API: https://screenshot.googleplex.com/5CPFk5zo69qjbUN.png
New API: https://screenshot.googleplex.com/BZxuUkSKpBCHNjW.png
Bug: 388216550, 388217006
Change-Id: I16963e70cfa3b3d9b59e86d63a410a5a91970433
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6172310
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Vishwas Uppoor <vishwasuppoor@google.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408013}
[PIX] AutofillImageFetcher refactor - Phase 3
Modularize image treatment code. Create a method to add a center aligned
background.
The new method is created by breaking up treatPixAccountImage so it can
be used by other payment methods. This patch does not change existing
code behavior.
go/autofill-image-fetcher-refactor
Bug: 388216550, 388217006
Change-Id: I25fe9fd16f665659e3b8cb6eae8da0f5b6d13f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6171103
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Vishwas Uppoor <vishwasuppoor@google.com>
Cr-Commit-Position: refs/heads/main@{#1408012}
[PIX] AutofillImageFetcher refactor - Phase 2
Modularize image treatment code. Create a method to add corner radius to
a given bitmap.
The new method is created by breaking up treatPixAccountImage so it can
be used by other payment methods. It's a no-op.
go/autofill-image-fetcher-refactor
Bug: 388216550, 388217006
Change-Id: I7125355910545f5a662c567c1822f492d42ecff9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6158565
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Vishwas Uppoor <vishwasuppoor@google.com>
Cr-Commit-Position: refs/heads/main@{#1408011}
Delete ThirdPartyCookieAccessWarning/Error deprecation config
The feature reporting these was not launched and got removed in
https://crrev.com/c/6170641
Bug: 355308337
Change-Id: I57be6d5701fea63945d4659857250896ab092a37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180886
Reviewed-by: Ari Chivukula <arichiv@chromium.org>
Auto-Submit: Sandor «Alex» Major <sandormajor@chromium.org>
Commit-Queue: Sandor «Alex» Major <sandormajor@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408010}
Automated Commit: LKGM 16164.0.0-1066163 for chromeos.
CrOS Changes (16163.0.0-1066150 -> 16164.0.0-1066163):
- External: http://go/cros-changes/74052..74065?ext=true
- Internal: http://go/cros-changes/107556..107569
Uploaded by https://ci.chromium.org/b/8725510660105888481
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-brya-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-jacuzzi-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-volteer-chrome-skylab
CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-octopus-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-jacuzzi-rel
Change-Id: Icabfa9ff98a11b3f4aa3b2bf17a15778806b9ecf
CrOS-LKGM: 16164.0.0-1066163
Cr-Original-Build-Id: 8725510660105888481
CrOS-External-Manifest-Position: 74065
CrOS-Internal-Manifest-Position: 107569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180912
Bot-Commit: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408009}
Roll Perfetto Trace Processor Linux from 5cac0a369729 to b98946cf49fb
https://android.googlesource.com/platform/external/perfetto.git/+log/5cac0a369729..b98946cf49fb
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: perfetto-bugs@google.com
Change-Id: I3082bdb273c59cce9b9a575c76cdff33d9315399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6182175
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408008}
task_environment: Fix usage of `SingleThreadTaskExecutor` in comment
`SingleThreadTaskExecutor` does not exist - presumably, this comment
should be `SingleThreadTaskEnvironment`.
Bug: None
Change-Id: I6a6a21005f263fc2c71fa9f760cb7164344f74aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6176643
Auto-Submit: Michael Cui <mlcui@google.com>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408007}
Using a shader to draw the border
We used to draw the border by setting different features of a
PaintFlags. This CL moves all those logic to a SkSL command which draws
the border given some uniforms.
Bug: 388568973
Change-Id: I69a546aad6da7efb3e2bc11b2bb5b8d190f7dbd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6179759
Reviewed-by: Ian Wells <iwells@chromium.org>
Reviewed-by: William Liu <liuwilliam@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Baran Erfani <baranerf@google.com>
Cr-Commit-Position: refs/heads/main@{#1408006}
[Hub] Fix Tab Pane interaction with Bottom Toolbar for non-NTP pages
Improve interaction between the tab switcher and the bottom toolbar by
animating the shrinking/expanding tab to the top of the screen
subtracting the toolbar space if bottom toolbar is in use.
The bottom toolbar area still has a somewhat unpolished transition
because the area where the bottom toolbar is remains blank during the
animation rather than something nicer like a crossfade. For now this is
still significantly better than the previous state. However, there is
probably room to improve this with help from UX. Unfortunately, the fact
Hub is layered over the rest of the UI and we are using LayoutManager to
handle the transition makes this somewhat more difficult than it might
otherwise seem.
See demo on bug.
Fixed: 385704998
Change-Id: Id22ec322a89126e319c9a5f5a5bae575eac206f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180002
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408005}
[PDF Ink Signatures] Enable toolbar buttons disabled by Ink1 on CrOS
The original Ink1 annotation mode disables the sidenav toggle, rotate,
and two page view buttons. This is due to a limitation in the Ink1
implementation. Ink2 does not have the same limitation, so it should be
enabled to match the behavior on other platforms.
Fixed: 390329794
Change-Id: I85c708b824e67aadc81faebfd7fd3364aac5030c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180139
Commit-Queue: Andy Phan <andyphan@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408004}
Report offline related net errors as NO_CARDS_REQUEST_ERROR_NO_INTERNET
Bug: 390459316
Change-Id: Ie29c956e5ff9319eb494bb87220a3eeeb39890a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6181507
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1408003}
[PDF Ink Signatures] Hide the original Ink annotation bar on CrOS
The original Ink annotation bar should not be displayed when in Ink2
annotation mode. Hide it when Ink2 is enabled.
Fixed: 389737047
Change-Id: I4704fff224aa205a3ee98016ce90c42cf0c41654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6174842
Commit-Queue: Andy Phan <andyphan@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408002}
Roll ios_internal from 16eff5cb2fb2 to 46e2e655940e
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/16eff5cb2fb2..46e2e655940e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll
Please CC chrome-brapp-engprod@google.com,olivierrobin@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:375605622,chromium:390519785
Change-Id: I13233711998d6633e96322e45020c4629193c06a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6182520
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408001}
Roll Dawn from 827105c30a7d to 42451fad80b2 (3 revisions)
https://dawn.googlesource.com/dawn.git/+log/827105c30a7d..42451fad80b2
2025-01-17 lehoangquyen@chromium.org D3D11: Disallow creating adapter if fences are not supported.
2025-01-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ab7457dbcd09 to bf18d7365db8 (3 revisions)
2025-01-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from e52b6bc1d9bc to e4636f06383f (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com,kainino@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64
Bug: chromium:390441217
Tbr: kainino@google.com
Change-Id: I3cbd1e19ad50f2bd29acde62084b3a1d6bb4c5fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6182173
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1408000}