| Legend: | Passed | Failed | Failed Again | Running | Exception |
Roll src-internal 99a2bf5facef..b9b4c88672fd (2 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99a2bf5facef..b9b4c88672fd
Created with:
gclient setdep -r src-internal@b9b4c88672fd
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com
Change-Id: I77a613bc7d669d3375dc4496681b85b3a41049a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663873
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#669973}
MacPWAs: Trust content::NativeWebKeyboardEvent serialization to be wrong
A number of bugs have come out of the fact that
content::NativeWebKeyboardEvent appears to provide a mechanism to pass
an NSEvent across processes via
NSEvent -> content::NativeWebKeyboardEvent -> (mojo) ->
content::NativeWebKeyboardEvent -> NSEvent
In practice, the NSEvent reconstructed after the
content::NativeWebKeyboardEvent was passed over mojo is not even
remotely accurate.
Add helper functions to serialize NSEvents using the OS-provided
CGEventCreateData and CGEventCreateFromData functions. When passing a
content::NativeWebKeyboardEvent over mojo, pass the serialization
alongside it, and replace the result's os_event.
Use this approach instead of updating the mojo serialization for
content::NativeWebKeyboardEvent because we don't want to be calling
CGEventCreateFromData on data sent from the renderer process.
Remove the accumulated workarounds for these issues.
R=dominickn
TBR=avi (content/ OWNERship)
Bug: 919167, 943197, 964052, 942690
Change-Id: Ie7321229daf34629ddc9037ab733b40828bc62c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659662
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669972}
[System Web Apps] Migrate Settings app list and launcher data.
This CL adds code to migrate the Settings internal app's app list and
launcher positions to the Settings System Web App.
TBR=jamescook@chromium.org
Bug: 836128
Change-Id: I5be900672689c80dd243bd5d30699c1039a13d94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644881
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669971}
Make AppBannerManagerDesktop listen to web app install events
This CL makes AppBannerManagerDesktop listen for web app installs
to determine whether to fire the appinstalled event to the renderer.
Previously it depended on every install UI flow to call OnInstall
because we didn't have this event to listen to internally.
Bug: 956810
Change-Id: If78c86c8c407a8777f59236685c388276ef0f724
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657083
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669970}
Keep Resource::link_preload_ true even when served from the preload
cache
When a blink::Resource is put into the preload cache by a link preload
request, its `link_preload_` member is set to true.
Before this CL, when a blink::Resource in the preload cache is matched
with a request that itself is not a link preload, we reset the
`link_preload_` member to false, obscuring the fact that the Resource
was served from the preload cache to the consumer.
After this CL, we stop resetting this member, so that when a
non-link-preload request is matched with a blink::Resource from the
preload cache, it can determine whether it was originally a preloaded
resource or not. This is a preparation CL for implementing Preload + SRI
to work with each other. The reason that a non-link-preload benefits
from knowing whether it was served from the preload cache can be found
here [1].
[1]: https://docs.google.com/document/d/1l8y_T3z-nb0smR9EVoZ3TeEI6rGzLw74vvzWzODsnDQ/edit#heading=h.rocm6cm98uhw
R=kouhei@chromium.org, yhirano@chromium.org
Bug: 677022
Change-Id: I890ee44cdd650b8459e5220f10a48d1d1192210b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661314
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669969}
[LayoutNG] Fix DCHECK failure for table cell width quirk
This patch fixes a DCHECK failure when table cell width
calculation quirk logic[1] found an out-of-flow image.
The logic was in |BreakLine| because it may need to change
|can_break_after| of the last item. By calling
|HandleAtomicInline| in trailing item phase, the logic can
be moved to |HandleAtomicInline|.
With this change, |HandleAtomicInline| may choose to break
before the item, similar to |HandleText|.
[1] https://quirks.spec.whatwg.org/#the-table-cell-width-calculation-quirk
Bug: 968317
Change-Id: Ib4a71ca62107d2601449ba589bb2771b378ab38b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660296
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669968}
Enable encoding through DMA-buf on V4L2 JEA
This CL enables DMA-buf encoding on V4L2 JEA to optimize the
performance and reduce the CPU consumption.
Bug: 944705, b/130850474, b/123057922
Test: Manually
Test: ./jpeg_encode_accelerator_unittest
Change-Id: Ic6a9929014db5422bfc07c832dc9b402a8a465d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534592
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Commit-Queue: Wei Lee <wtlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669967}
Remove the usage of banned function std::to_string.
Quote form the presubmit checks of std::to_string [1]:
> std::to_string is locale dependent and slower than alternatives. For
> locale-independent strings, e.g. writing numbers to and from disk
> profiles, use base::NumberToString(). For user-visible strings, use
> base::FormatNumber() and the related functions in
> base/i18n/number_formatting.h.
[1] https://cs.chromium.org/chromium/src/PRESUBMIT.py?l=719&rcl=fdd20c8546766e53c8369523080e79b9e60cac7b
Bug: None
Test: Passes capture_unittests.
Change-Id: Iaad9cfdedd5efb55c0a2f411ca505be127dedffa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660389
Reviewed-by: Wei Lee <wtlee@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669966}
Revert "Roll clang 362913:363450."
This reverts commit 76c3585fa2089a363737b6d6c763e81b74d279da.
Reason for revert: The clang roll is causing a lot of test failures from interactions with Skia, and causing reduced test coverage/red bots.
Original change's description:
> Roll clang 362913:363450.
>
> Ran `tools/clang/scripts/upload_revision.py 49b965079b18f8aa485dd1156dd088d40b7ee465`.
>
> TBR=hans
>
> Bug: 974267
> Change-Id: If292a3e2317da54558f02275a84aefead03aad9d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660964
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#669515}
TBR=thakis@chromium.org,hans@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 974542
Change-Id: I0feae2b830dfada03388d77f366934825497516a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663740
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669965}
media/gpu/test: Fix dumping video frames to file in video decoder tests.
The VideoFrameFileWriter can be used in tests to dump decoded frames to disk in
various formats. CL crrev.com/c/1573311 introduced a small bug breaking the
VideoFrameFileWriter, which this CL fixes.
TEST=ran VDA tests on eve
BUG=None
Change-Id: I116cd683f9f5b0777160009343b0826fc141dcea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663772
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669964}
Roll src-internal 1d05fadfb4fa..99a2bf5facef (3 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d05fadfb4fa..99a2bf5facef
Created with:
gclient setdep -r src-internal@99a2bf5facef
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com
Change-Id: I91f4899ccc669aa1da72fe7f3c39a3dadf4896ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663584
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#669963}
[Chromecast] Remove unreachable code for kLoadTypeCommunication
BUG: internal b/135083912
TEST: Make a Duo call on Nest Hub
Change-Id: I57ea17e68fcfc185f417dbb837379b5465353b20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654740
Auto-Submit: Chih-Hsuan Kuo <chkuo@google.com>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com>
Cr-Commit-Position: refs/heads/master@{#669962}
Unmount DriveFS on suspend and remount (if enabled) on resume.
FUSE doesn't cope well with attempting to freeze while an operation is
in flight. Avoid this by unmounting on suspend and remounting after
resuming.
Bug: b:134792837
Change-Id: I4fa836b33f8a5b486e458f10228ae111d9dd1d32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662208
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669961}
Replace use of std container with WTF's equivalent in security_context.h
This CL replaces the use of std::vector of std containers with
Blink::WebVector in security_context.h and related codes.
Bug: 952716
Change-Id: I82ee19f4ea79ea81dd7f187a8cd618c89945dc50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661323
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#669960}
Replace use of std container with WTF's equivalent in third_party/blink/renderer/core/frame/csp/
This CL replaces the use of std::vector with WTF::Vector and
access a blink:WebVector member of struct directly in
third_party/blink/renderer/core/frame/csp/.
Bug: 952716
Change-Id: Ia94053b4f29b2637ef8a4a6fcac09306a96f05f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661326
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#669959}
Roll src/third_party/pdfium 79b2847f611f..f0f9a8f1fd94 (7 commits)
https://pdfium.googlesource.com/pdfium.git/+log/79b2847f611f..f0f9a8f1fd94
git log 79b2847f611f..f0f9a8f1fd94 --date=short --no-merges --format='%ad %ae %s'
2019-06-18 chinsenj@google.com Split PDF_DataDecode() in two
2019-06-17 tsepez@chromium.org Remove CFX_FontMgr::InitFTLibrary.
2019-06-17 thestig@chromium.org Roll third_party/libjpeg_turbo/ 2a34770be..e1669e370 (3 commits)
2019-06-17 thestig@chromium.org Simplify font code.
2019-06-17 tsepez@chromium.org Introduce enum CFX_FontMapper::StandardFont.
2019-06-17 tsepez@chromium.org Speculative follow-up for bug_974091.
2019-06-17 tsepez@chromium.org Remove unimplemented CFX_FontMgr::ReleaseFace().
Created with:
gclient setdep -r src/third_party/pdfium@f0f9a8f1fd94
The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
BUG=chromium:922430,chromium:974091
TBR=pdfium-deps-rolls@chromium.org
Change-Id: I0d2299f2f36d81551ed3a2e81689923b6fe2bc66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663583
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#669958}
Switch PdfCompositor UMAs to use kMaxValue enumerator value.
Enums in Mojo have |kMaxValue| automatically defined. Switch
PdfCompositor UMAs to use the 2-parameter UMA_HISTOGRAM_ENUMERATION
macro, which uses |kMaxValue|, and avoid the need for static_casts with
the 3-parameter UMA_HISTOGRAM_ENUMERATION variant.
Along the way, switch the PdfCompositor enum to kFoo style, and fix a
typo to stop referring to composting.
BUG=742517
Change-Id: Id9664371d3b2d7b0fe1203069d96c37b3e4b41de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661490
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669957}
Roll src/third_party/angle 3f8975e121c5..c211c2f5b59d (1 commits)
https://chromium.googlesource.com/angle/angle.git/+log/3f8975e121c5..c211c2f5b59d
git log 3f8975e121c5..c211c2f5b59d --date=short --no-merges --format='%ad %ae %s'
2019-06-17 clemendeng@google.com Make proc table autogen use gl.xml data
Created with:
gclient setdep -r src/third_party/angle@c211c2f5b59d
The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jonahr@google.com
Change-Id: I246104397b81e9be519f2f3e70f1966959eddc5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663044
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#669956}
Updating trunk VERSION from 3829.0 to 3830.0
# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=kariah@chromium.org
Change-Id: Ic19b7821cc8db661dfd576dc5032277e87faf919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663832
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669955}
[LayoutNG] Fix "body fills html" quirks.
We had a few issues related to quirky body elements. We were
stretching the body when it was OOF-positioned, float, or an atomic
inline when we weren't supposed to.
Bug: 967215
Change-Id: I640b1a2f6c2ab30d071e04c245a34dd1e30b19fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662839
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669954}
[testing] switch to use xenial for chromeos tests
xenial bots are added in
https://chrome-internal-review.googlesource.com/c/infradata/config/+/1397331
Bug: 954450
Change-Id: Ia283aed3263b9d15b8cf1881fb811c117e191a97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662250
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669953}
Extend expiry for some NTP histograms
Bug: 975412
Change-Id: I399fd91b8f5cb0e7bb8822bcf0a1869ffafdc512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663309
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669952}
Keep SXG script resource after execution
Bug: 942433
Change-Id: Ie63b184a09bc4e28f92387057439f8a0b8dcd6d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657518
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669951}
Roll src/third_party/catapult 9e5dbd8b462b..f6c289da452c (1 commits)
https://chromium.googlesource.com/catapult.git/+log/9e5dbd8b462b..f6c289da452c
git log 9e5dbd8b462b..f6c289da452c --date=short --no-merges --format='%ad %ae %s'
2019-06-18 jbudorick@chromium.org devil: work around new wait-for-device timeout in adb root.
Created with:
gclient setdep -r src/third_party/catapult@f6c289da452c
The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:790202
TBR=eyaich@google.com
Change-Id: I970f1abbbb64606df2b4e296e966b3228a44c212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663579
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#669950}
android: work around new adb root timeouts in with_asan.py.
Pairs w/ crrev.com/c/1663473
Bug: 790202
Change-Id: Ic40cc9485fccd5b92105560f490db9582b28302e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663171
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669949}
Convert WebSocket perf result unit from time to speed
This patch changes result unit from time to finish to
download speed (MB/s) so that we can understand the result well.
Output example:
Running 6 times
Ignoring warm-up run (105.78372516974459 MB/s)
106.68316700291037 MB/s
109.1619636011486 MB/s
105.88901771616635 MB/s
108.31713089383285 MB/s
109.41697166423853 MB/s
112.31033591831871 MB/s
Description: Measure performance of receiving 1MB array 100 times.
Time:
values 106.68316700291037, 109.1619636011486, 105.88901771616635, 108.31713089383285, 109.41697166423853, 112.31033591831871 MB/s
avg 108.62976446610257 MB/s
median 108.73954724749072 MB/s
stdev 2.2736847401744864 MB/s
min 105.88901771616635 MB/s
max 112.31033591831871 MB/s
Bug: 954000
Change-Id: If737b6d92b7c04b30a264bea1e5552c0fafda7a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654679
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669948}
Revert "Convert PromiseResolver and FocusOutlineManager to ES6 class syntax."
This reverts commit 0bd3cb69e215506d742bed205ea2d8dee3056815.
Reason for revert:
Broke closure compiler bot
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8910374524264371136/+/steps/run_tests/0/stdout
Original change's description:
> Convert PromiseResolver and FocusOutlineManager to ES6 class syntax.
>
> Also replace a few usages of bind(this) with arrow functions.
>
> Bug: 747596
> Change-Id: Icbbe4425e5ddd7b8861fb01fe4b7f9fa093d08be
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658638
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#669792}
TBR=dpapad@chromium.org,rbpotter@chromium.org
Change-Id: I399c066ee883da844bcd8af7dbef37e770243802
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 747596
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663742
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669947}
cros: Hide title while released drag icon animates to final position.
Bug: 973713
Change-Id: I650acdec495b079f826d115d97bddab9357499cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659022
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669946}
media/gpu/vaapi: Adapt video decoder tests to use correct visible rectangle.
This CL changes the video_decode_accelerator(_perf)_tests to use the correct
visible rectangle. The checksums for the switch_1080p_720p_240frames.h264 video
have been updated as these were incorrect.
TEST=ran new VDA tests on eve
BUG=974075
Change-Id: I81d584c66b3aebd02ee193c6e068748e65dc96ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659651
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669945}
media/gpu/vaapi: Implement VaapiVideoDecoder.
This CL introduces the VaapiVideoDecoder, based on the media::VideoDecoder
interface. This decoder is a complete rewrite of the VaapiVideoDecodeAccelerator
which is based on the deprecated media::VideoDecodeAccelerator interface.
TEST=ran new VDA tests on eve
BUG=920058
Cq-Depend: chromium:1535514
Change-Id: Ib11f22afbd06c9469275aa26a3cebd04e0a4e03f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634030
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669944}
Add "CertVerifierBuiltin" feature flag to enable the builtin verifier.
The flag is only available on Linux and macOS, as those are currently
the platforms where trust store integration is completed.
Bug: 973650
Change-Id: Id7273acedc88deebe1aaa80d2dcaed0f6e4fbb96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660797
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669943}
Disable MSE_Widevine/EncryptedMediaTest.* browser_tests on linux-chromeos-google-rel.
Bug: 932269
Change-Id: I4bb696dd9caa2004b8108cd56e4a7d9f73248563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663023
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669942}
Remove unneeded DEPS entry from public/web/modules/mediastream
BUG=704136
R=haraken@chromium.org
Change-Id: I5aa59e43448703eb743e40a9fc0bad2b5666140d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659106
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669941}
Roll src-internal 468585d96747..1d05fadfb4fa (5 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/468585d96747..1d05fadfb4fa
Created with:
gclient setdep -r src-internal@1d05fadfb4fa
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com
Change-Id: I8dc821c86f2e05477391a6a9edc3bb6234ab986c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663575
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#669940}
Import wpt@4be1e7e7b78712303076819ef8a6b3f055ebbb3c
Using wpt-import in Chromium 29e350f6a3418973be2fb988432127d1379b63f0.
With Chromium commits locally applied on WPT:
9e3affdd55 "Ship `referer` header length limitation."
723f9a7899 "Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects."
3d4f72a808 "Worker: Add service worker interception tests for shared workers"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
external/wpt/tools
NOAUTOREVERT=true
TBR=lpz
No-Export: true
Change-Id: Ie291f2cc64ba01de1b9586c08321c6fe0108e1af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663326
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#669939}
Onion soup webrtc_local_audio_source_provider.cc|h
This CL is part of the phase 3 on the document [1].
It includes moving to Blink files and content/renderer/media/stream
dependencies from media/audio or media/webrtc that block Onion souping
more entangled files.
[1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/edit#
As a follow up to the CL, this class will be renamed to
WebAudioMediaStreamAudioSink.
BUG=704136
R=guidou@chromium.org, haraken@chromium.org
Change-Id: Id86386441212d7909e20cb2be90b2ca8c4c1f409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659474
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669938}
WebUI Dark Mode: remove querying and notification C++/JS
Instead, the code has been updated to use:
* @media (prefers-color-scheme: light/dark) {...} in CSS
* window.matchMedia(...).matches in JS
for querying and
* window.matchMedia(...).{addListener,removeListener} in JS
for notifications. \o/
Bug: 965811
Change-Id: I6bbb1b548bdb3919977f9f18f414bd193dffd129
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654279
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669937}
Reland "[WebSocket] Add --websocket-renderer-receive-quota-max command line flag."
Reason for reland: the culprit was not this patch.
This patch was reverted because of compile failure on android:
https://chromium-review.googlesource.com/c/chromium/src/+/1660391
However, relanding this don't cause compile failure.
Bug: 865001
Change-Id: Ia64a440525791fe67fb9d8a3882b91bc41af262c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661316
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669936}
fido/bio: clean/const-ify bio enrollment
Just cleaning up some bio enrollment-related code and reducing copying.
Bug: 974046
Change-Id: If0f30989ee06097717abd0f62887ed7ba00d4ec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659851
Commit-Queue: Matthew Webb <noviv@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669935}
Revert "Reland "Add ability to drag tabs between pinned and unpinned tabs to modify the""
This reverts commit 2af55fab9aee20187d92fe04d706874d3794dc6e.
Reason for revert: Still flaky
Original change's description:
> Reland "Add ability to drag tabs between pinned and unpinned tabs to modify the"
>
> This reverts commit 1158f5ef2506560df4b9daf4f3a654a9ee09ab73.
>
> Reason for revert: This is an experimental reland since this broke older
> mac waterfall bots. This was fixed with https://chromium-review.googlesource.com/c/chromium/src/+/1649313
>
> Original change's description:
> > Revert "Add ability to drag tabs between pinned and unpinned tabs to modify the"
> >
> > This reverts commit 9194856034fd992f91a115e2cf0fd408568542bf.
> >
> > Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/38757, consistent failures on mac of the following tests:
> > TabDragging/DetachToBrowserTabDragControllerTest.DragToPinEnabled_DragToUnpinInNewWindow/0
> > TabDragging/DetachToBrowserTabDragControllerTest.DragToPinInNewWindow/0
> >
> > Original change's description:
> > > Add ability to drag tabs between pinned and unpinned tabs to modify the
> > > pinned state.
> > >
> > > Bug: 965681
> > > Change-Id: I4cebf850839a1fdbee702ab2cd3c2fccbdba811e
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637045
> > > Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> > > Commit-Queue: Charlene Yan <cyan@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#666796}
> >
> > TBR=bsep@chromium.org,cyan@chromium.org
> >
> > Change-Id: I0a68811b31c718fcdccba6058ab6bdf664a1547a
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 965681
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649316
> > Reviewed-by: Armando Miraglia <armax@chromium.org>
> > Commit-Queue: Armando Miraglia <armax@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#667042}
>
> TBR=bsep@chromium.org,armax@chromium.org,cyan@chromium.org
>
> Change-Id: Ia1521f2c2443c40a3b2ac55be079c6e1be91dea2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 965681
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648899
> Commit-Queue: Charlene Yan <cyan@chromium.org>
> Reviewed-by: Charlene Yan <cyan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#669906}
TBR=bsep@chromium.org,armax@chromium.org,cyan@chromium.org
Change-Id: I8ab3f943b2aed204f318c329fca88a0459f2255b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 965681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663582
Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669934}
Roll src/third_party/dawn 8f4046b0b667..872c1d7fe98a (1 commits)
https://dawn.googlesource.com/dawn.git/+log/8f4046b0b667..872c1d7fe98a
git log 8f4046b0b667..872c1d7fe98a --date=short --no-merges --format='%ad %ae %s'
2019-06-18 jiawei.shao@intel.com Add validations to the texture copies with BC formats
Created with:
gclient setdep -r src/third_party/dawn@872c1d7fe98a
The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com
Change-Id: Ib620e34aee94df1ef4a3556f6de3541da5b56bd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663677
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#669933}
Extend expiration of many histograms
Bug: 975917, 975554, 969994, 967482, 967480, 967475, 967473
Change-Id: Ibffc2a210357fd74cc81bc9ec9f7708caa2d98d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663015
Auto-Submit: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669932}
Animation changes for FeaturePods pagination
Collapse Animation has been changed.
Buttons below the second row now move downwards and fade out.
Similarly, buttons on the second page or later also move
downwards and fade out.
If the tray is collapsed when not on the first page, there is a smooth
back and forth transition between the selected page and the first page while
collapsing or expanding back from a partially collapsed state.
Add transition durations for page switching.
Animation Example Video:
https://screencast.googleplex.com/cast/NTg4NTIyMDQ3OTgyNzk2OHw2NWUxZDkwMy05NQ
Bug: 914077
Change-Id: I81cdd01f61b5a902f530829a3488db3723271f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610641
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669931}
Extend preload histograms
Extend preload histograms to M82 because these are
important when updating the preload list.
BUG=975372
Change-Id: Id88067c761b79c59d2b89cf1bc564b1683bd3b5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663073
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669930}
Stop context menu radio button from changing color on hover.
Bug: 877567
Change-Id: Ieabdd88c52daf2bdea0f07dd419f72d193e48832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652690
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669929}
Fixed rename updates for offline content provider backend
This CL fixes the renames to be reflected on the download home UI
correctly without triggering notifications.
1 - Added an observer method OnDownloadRenamed to DownloadItem::Observer
2 - DownloadOfflineContentProvider observes the renames through an
AllDownloadEventNotifier::Observer
3 - Fixed the ignore update logic at OfflineContentAggregatorNotificationBridgeUi
Change-Id: I82f3415f8e70814c00037890c400165eedbf23b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661353
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669928}
Fix threading issue in Previews Offline Helper
This PostTask should be using the UI thread, see bug.
Bug: 974829
Change-Id: Ic437d92ab542969a50bbcfc08b83171ad4bf6f88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661401
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669927}
Add shared library support
Implement platform support for loading shared library in decoder.
This feature will be disabled by default and only compiled when flag
enable_cros_ime_decoder in chromeos/services/ime/public/features.gni
is turned on.
Bug: 837156
Change-Id: Iaec701361f50061ded08a1998975a521701b0387
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659553
Reviewed-by: Marti Wong <martiw@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669926}
[ios] Adds CFBundleShortVersionString to the plist for unittests.
Xcode11 now requires this plist key to be present for all apps.
BUG=None
Change-Id: I9d88f9da68e096d5f852a6f644a23ac3db1bd132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663358
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669925}
Restrict setting some network headers through URLLoader interface.
The restricted headers potentially give Chrome and the server its
talking different views of what's going on for the rest of a
transaction, so it isn't a great idea to allow setting them.
Proxy headers are also restricted.
Bug: 973103
Change-Id: Id014181a332252d908c6255cc7c2593a4be781f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659194
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669924}