| Legend: | Passed | Failed | Failed Again | Running | Exception |
DevTools: fix Page.frameRequestedNavigation to report proper frame id when another frame is being navigated
- Replace FrameLoadRequest::SetClientRedirect() with SetClientRedirectReason()
that implies the request is for client redirect and provides the reason;
- Move probe::frameRequestedNavigation to FrameLoader::StartNavigation()
and as late there as possible, so we only fire it when we actually
request browser to navigate;
- Pass Frame* target_frame to probe::frameRequestedNavigation() and report
target frame as frameId if present, so that when a frame requests another
frame to navigate, the id of the latter is reported.
Bug: b/130664370
Change-Id: Ia424542edc90d39977abf49335bb1a89345233a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570424
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652240}
[blinkpy] Suppress stderr of git-cl by default
Bug: 953499
Change-Id: I0f7dfc4317b2de9bc92ef9900dd6888143133a84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573879
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652239}
Roll src/third_party/swiftshader f45b3881ebc6..ac07ed82c3b7 (2 commits)
https://swiftshader.googlesource.com/SwiftShader.git/+log/f45b3881ebc6..ac07ed82c3b7
git log f45b3881ebc6..ac07ed82c3b7 --date=short --no-merges --format='%ad %ae %s'
2019-04-18 bclayton@google.com Reactor: Implement debug info generation
2019-04-18 bclayton@google.com Add libbacktrace submodule.
Created with:
gclient setdep -r src/third_party/swiftshader@ac07ed82c3b7
The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@chromium.org
Change-Id: Ibaead0064a914769667caf55fdaa2625faf88505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573821
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652238}
chromium.android: run resource_sizes on swarming.
Not sure this'll work, but if it does, it'll ensure that resource_sizes
runs with the perf merge script.
Bug: 861983
Change-Id: I8e62c92b5be4cdd429bdca00b05c98246e195f1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573861
Commit-Queue: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652237}
[DevTools] Application>Cache Storage: show query of urls and tooltip
Bug: 951414
Change-Id: I2c52dfeead4963868154ffc8ea9394f6d7bd7221
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566120
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Haihong Li (Harley) <hhli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652236}
Roll src/third_party/SPIRV-Tools/src ac878fcbdd64..d754b70592ca (1 commits)
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ac878fcbdd64..d754b70592ca
git log ac878fcbdd64..d754b70592ca --date=short --no-merges --format='%ad %ae %s'
2019-04-18 stevenperron@google.com Shorten names of cmake targets (#2531)
Created with:
gclient setdep -r src/third_party/SPIRV-Tools/src@d754b70592ca
The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
TBR=dsinclair@chromium.org
Change-Id: I74b72a77fae01f636e795907fea0fedc31f27f3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573824
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652235}
Import wpt@604d57f8e21ffdea19f36ab01471b84425867d97
Using wpt-import in Chromium 313ab2379047d44ea646cd5794a3432f8c9c634c.
With Chromium commits locally applied on WPT:
0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2"
4e9215207a "[Code Health] Remove unnecessary reference file for web test"
c1940432ee "[WPT/common/security-features] Merge subresource path construction"
40465b7400 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope"
Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
NOAUTOREVERT=true
TBR=raphael.kubo.da.costa
No-Export: true
Change-Id: Ie6bcaca1ec2243b90ec18135cb6c125cd094fd56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573804
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652234}
[xr] Added wait state and extra buttons to permission page
Added a wait state (hour glass) to the UI so that when the user
clicks on a permission button but the callbacks are yet to fire
because of delay in the system, users do not perceive it as an
issue with the XR stack.
Also, added buttons for MIDI and screen-share.
midi-button.png is created by snapshotting src/components/vector_icons/midi.icon icon loaded into views_examples_exe. GIMP is used to edit/export
screen-share-button.png is sourced from src/chrome/android/java/res/drawable-xxxhdpi/infobar_screen_share.png, resized and colored black
hourglass-button.png is essentially resized and colorized version of src/third_party/material_design_icons/src/action/ios/ic_hourglass_empty.imageset/ic_hourglass_empty_3x.png
Bug: 952040, 951425
Change-Id: Ia51c0324d1c3864c1930868a9a66d4324fc1bc1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569968
Commit-Queue: Suman Kancherla <sumankancherla@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652233}
Update bulk entries in HSTS preload list
Change-Id: I2474df7f0e5f339f656811682be84ff4a67b8b32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557791
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652232}
[LayoutNG] Fragment caching interaction with FlexNG appears to be fixed
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Flayout_ng_experimental%2Fcss3%2Fflexbox%2Fflexbox-width-with-overflow-auto.html
So we can remove this failure line from TestExpectations.
Change-Id: Id2934204139eaa9c55807256f31d0ffa45a11e36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573809
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652231}
[heap profiler] Remove profiling_fuzzer target
A followup after r651916
BUG=954129,923459
Change-Id: I15e862e4b7cfe6f8ad59d42ad877f2c2d17b9083
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573656
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652230}
Add Skia/Metal to the Chromium build
Keep it behind a skia_use_metal flag for the moment.
Put the Metal sources in a separate place from skia_util_mac.mm, because
Metal uses ARC and skia_util_mac.mm uses explicit reference counting.
Bug: 952063
Change-Id: I601b3c9814b4beaf6a091871ba4dc2592c2fc498
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565387
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652229}
Use unique_ptr for BrowserWithTestWindowTest::CreateBrowserWindow().
Bug: 948877
Change-Id: If2dee43b18c4e537ff25433918afae9b35268970
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564563
Commit-Queue: Alan Screen <awscreen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652228}
Restore reverse order when parsing UploadList.
Before crrev/c/1460065, TextLogUploadList::ParseLogEntries returned a
list of entries in reverse order.
After this cl it is in the normal order.
Because new crash upload are appended to the log file, the order in the
source is oldest report first.
The result is that crash reports were displayed in older first order,
at least on iOS and Android.
This CL restores the correct order of chrome://crashes which is
showing newer crash uploaded first.
Bug: 825994, 951449
Change-Id: Ib00d1f491773fbb3675e3a1927d36b75588c9401
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571406
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Auto-Submit: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652227}
SpdySessionPool: Don't use IP pooling for requests that don't want it.
This CL prevents the SpdySession pool from returning an IP pooled
session to a request that does not want one.
Bug: 912727
Change-Id: I06938adae3e1eca07e36d33f154a9bc473517785
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572584
Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652226}
Remove Profile from SupervisedUserSettingsService and SupervisedUserPrefStore.
In this CL, we remove the registration of
chrome::NOTIFICATION_PROFILE_DESTROYED event from SupervisedUserPrefStore.
Instead, it will listens to the Shutdown() event from the
SupervisedUserSettingsService. This is the same event that is sent from the
KeyedServiceShutdownNotifier during Profile shutdown, and it is
recommended to replace chrome::NOTIFICATION_PROFILE_DESTROYED event.
Therefore, we can remove cached Profile* pointer from both classes.
This is a precursor CL for: https://crrev.com/c/1532361/.
Bug: 953716
Change-Id: Idde8a94d7d5f7c635b6dddb234416735abe6d635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535706
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652225}
DNR: Evaluate "removeHeaders" rules.
This CL implements evaluation of "removeHeaders" rules. Currently removing
cookie, set-cookie and referer headers is supported.
BUG=947591
Change-Id: I90c9ca9dabfa3e97c4e9c1633c1ff8687e29a3d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559242
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652224}
Disabling v8.runtime_stats.top_25/Ads* on Mac due to perf bot failures
NOTRY=true
TBR=crouleau@chromium.org
CC=mythria@chromium.org
Bug: 954229
Change-Id: I1641cb1b8781c8236ce6a1eede4a2217b21dad54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574138
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652223}
Convert Callbacks to OnceCallbacks for BluetookAgentServiceProvider.
This will allow us to convert more Callbacks in the bluetooth component
over to OnceCallbacks, which will let us convert Callbacks in content
eventually.
R=reillyg@chromium.org
Bug: 953861
Change-Id: I21555216157c1d56249c6ec93c910ce19a68f8a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572368
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652222}
[scheduler] Rename DisableBackForwardCache scheduling policy.
Rename DisableBackForwardCache to RecordMetricsForBackForwardCache as we
don't yet have a back-forward cache to opt out from.
R=kinuko@chromium.org
CC=​haraken@chromium.org
BUG=933147
Change-Id: Ia189926bcf24790cb5c055fce48d4d2b91362fc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571697
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652221}
Create ProfileKey early
We remove the parameter of PrefService* from ProfileKey's constructor. This is
because some KeyedService are created using ProfileKey* before the PrefService
is created in the Profile. For example, SuperviseUserSettingService and
InProcessPrefServiceFactoryFactory.
Bug: 937469
Change-Id: I45c4b849e229a34ec6f465e428a7a514e9f77118
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568793
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652220}
[iOS] Mark flaky ios_web_inttests as FLAKY_.
Affected tests:
- ErrorPageTest.BackForwardErrorPage
- WebStateObserverTest.FailedLoad
TBR: eugenebut@chromium.org
Bug: 954231, 954232
Change-Id: I1783732aa37b3ce7db3f9878a5342d1a5bc12271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574018
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652219}
Roll src-internal fd816f4d5722..c8ee49fcfce8 (8 commits)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd816f4d5722..c8ee49fcfce8
Created with:
gclient setdep -r src-internal@c8ee49fcfce8
The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org
Change-Id: I3abd802d306f433a8d3d8c2d44694e99a6826f3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573669
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652218}
ksv: Move ChromeVox focus with Tab
This patch fixes a bug that ChromeVox orange focus highlight does not
follow the "Tab" to the shortcut list.
Bug: 953874
Test: manual
Change-Id: I649560519a7bc8bc53eabd67bc41508ef1207c27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572867
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652217}
[fuchsia] Update local-sdk script for fx set command.
Change-Id: I1ca0b592a9620d85e204302b6f0ce53cf915b588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573095
Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652216}
java: Add a choreographer frame task trait
This is useful if you need to guarantee something like a layout pass has
occurred before your task runs. Tasks posted with TaskTraits.CHOREOGRAPHER_FRAME
will run next time there's a vsync and after all other ready tasks on the thread
have run.
I put the trait under base because from what I understand there is some ui/ code
that needs it but ui/ can't depend on content/.
Bug: 863341
Change-Id: Ibcb7a843866c2b2c4f4394ebd18c8ef7aa33b5bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549114
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Karolina Soltys <ksolt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652215}
[iOS] Adds plumbing for DSE favicon and answer icons in the omnibox.
Plumbs the url of the favicon and the answer type from OPVI to
OmniboxMediator.
Bug: 945313, 945324
Change-Id: I759c5d83d7a677bb6be9e5aedf3ddd8666989fec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572354
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#652214}
Roll src/third_party/catapult 4e967e7e447d..f76561176b6c (1 commits)
https://chromium.googlesource.com/catapult.git/+log/4e967e7e447d..f76561176b6c
git log 4e967e7e447d..f76561176b6c --date=short --no-merges --format='%ad %ae %s'
2019-04-18 rmhasan@google.com [Typ] Make tags in test expectations files case insensitive
Created with:
gclient setdep -r src/third_party/catapult@f76561176b6c
The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
BUG=chromium:698902
TBR=oysteine@chromium.org
Change-Id: If3d7983bdbcfd7d8508709c2a2ff9be4880a0191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573667
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#652213}
[omnibox] Add and load Pedal concept data for de, en, fr, ja, zh-CN
Previously, Pedal concept data was a singular resource in English but
this CL restructures the resources to load localized data from a
pak depending on selected language. Data for the first four non-English
languages localized by the translation team is included.
Bug: 893183
Change-Id: I0e88d23de65038720a4f3543613ff8bd83dc5444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572526
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652212}
Add tests to check fingerprint state, UI, and ability to login before/after policy timeout.
Bug: 949707
Change-Id: I7767a632c895286858ebde9afe8473dca3ce0a5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566723
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652211}
QuicStreamHost copy updated to a move.
Fixing a small bug - the WriteData function should use a move instead of
a copy for the data.
Bug: 874296
Change-Id: I8b572a9d492d6fcea0e238b49bb72b0ed9273baf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573805
Reviewed-by: Seth Hampson <shampson@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Auto-Submit: Seth Hampson <shampson@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652210}
SpdySessionPool: Don't give non-WebSocket sessions to WebSocket requests
When sessions are returned to SpdySessionRequests, there was previously
no filter preventing sessions that don't support WebSockets to requests
that only wanted WebSocket-supporting sessions.
Bug: 912727
Change-Id: I20ade246dc5a8a4e7581c49801747723b8d36a87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572705
Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652209}
chromeos: Restructure test runner args a bit.
This makes the "test_type" arg the very first arg. Previously, anything
that came before it couldn't be passed in from the generated test script.
eg: running `./$out/bin/run_gtest --device $DUT_IP` would have no effect
since "--device" came before the "test_type" arg (which itself was
set in the generated script).
Bug: 866062
Change-Id: I7712f11b23f78f28e9831fe506b9467db8c217e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572959
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652208}
Set Trichrome min SDK properly
Make the minimum SDK version for all components of Trichrome be Q, if
we're building with the Q SDK.
SDK28 builds of Trichrome are only for temporary testing and can be left
alone until they're removed.
Bug: 952383
Change-Id: I8e9bac555456868ccf414a56f499d03fd2d1ef34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566372
Auto-Submit: Richard Coles <torne@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652207}
Print Preview: Change the behavior for empty PIN value.
* Allow to save empty PIN in sticky settings.
* Show the error if the PIN field is empty.
Bug: 848942
Change-Id: If7c4f3af6b9d6a5ade041c06d4732903ce780ff9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570011
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
Cr-Commit-Position: refs/heads/master@{#652206}
[Sync::USS] Implement NigoriModelTypeProcessor::NudgeForCommitIfNeeded
Bug: 922900
Change-Id: Idde575a3f4ba559811ab98373f6fb3e30bef0ea7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572406
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652205}
Changed ContentBrowserClient::CreateQuotaPermissionContext() to return scoped_refptr.
QuotaPermissionContext is a base::RefCountedThreadSafe class.
The method should return scoped_refptr instead of the raw pointer.
Bug: 951154
Change-Id: Ida5c64b6b5ce9eea6d3b42b49c0ab25b0263778e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569376
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Yeol Park <peary2@gmail.com>
Cr-Commit-Position: refs/heads/master@{#652204}
Revert "[Signin][Android] Add Java side of ConsistencyCookieManager"
This reverts commit e646c056f825e05d7cc80984009a750fa0143dc7.
Reason for revert: Broke UBSan vptr and Boris is OOO till early May.
Original change's description:
> [Signin][Android] Add Java side of ConsistencyCookieManager
>
> Adds ConsistencyCookieManager Java class that listens to
> AccountManagerFacade.isUpdatePending and exposes it to the C++ code.
>
> Bug: 949562
> Change-Id: Ifc375bed3d0d878d89d106807f44f4e7807db999
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565880
> Commit-Queue: David Roger <droger@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#652073}
TBR=droger@chromium.org,bsazonov@chromium.org
Change-Id: Id672685a05ecea8dcd2bee210369faa9a207c35d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 949562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573860
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652203}
WebGPU: Always pick the discrete GPU if it is available
This will be replaced when we implement the GPUAdapterOptions
to select high/low power.
Bug: chromium:852089
Change-Id: If698c1edd3c1cb8f6d10377133f276351d05dc2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572533
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652202}
flags: assign wallet-service-use-sandbox
This flag never expires since it is used by TE to validate Payments
features.
Bug: None
Change-Id: If0bfbfce132ef1f979c277c3e9ed6987598ba53d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570921
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#652201}
Centralize setting FrameLoadRequest::input_start_time_ in the constructor
Both FrameLoadRequest and the current input event from which the input
start time is determined are stack allocated. So even if we
reconstructed a FrameLoadRequest without using a copy constructor,
it should still get the same input_start_time_.
Change-Id: I3bd1213d6f8dfea518b687d5464c6a383be017f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572228
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652200}
[LayoutNG] Fix inline layout without |CollectInlines()|
This is a follow up fixes for r651389 (CL:1554210) which
reduced |CollectInlines()| where possible.
Before this change, |CollectInlines()| is responsible for
|ClearNeedsLayout()| for the objects in an inline formatting
context. By r651389 not requiring |CollectInlines()| for all
layout, we started failing to |ClearNeedsLayout()| in some
cases. Over 300 tests started to fail by reducing
|CollectInlines()| further in WIP CL:1567555.
In order to layout without running |CollectInlines()|, this
patch changes |NGInlineItemsBuilder| to include text that are
fully collapsed. They are not needed for the layout purposes,
but |NGLineBreaker| calls |ClearNeedsLayout()| for them.
The previous patch passed all tests means that we're not
saving much |CollectInlines()| yet. Expect to save more in
WIP CL:1567555, but this fix is needed for that.
Bug: 636993
Change-Id: I6c543991208980cbb880a21d306b912e3b29affe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571113
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652199}
[Media Controls] Separate hide timer for overlay and bottom progress bar
Since there are situations where bottom pregress bar shows and mid overlay hides,
we are going to have different hide timer for them. This CL add a hide timer logic
into touchless element base class so that all sub element can have the hide timer
(This is also a preparation for volume indicator hide timer).
Bug: 942153
Change-Id: I980f1ec4439cad233a321a98bf1f2e6a535338eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570128
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652198}
Management WebUI: Update strings
Apply all strings changes.
Bug: 879146
Change-Id: I14487919651070a1f91a461d66a4a2243a267b7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565009
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#652197}
Move loading of data URLs out of the network process.
For subresources the renderer was already loading it in-process. Now for navigations and downloads, we keep them in the browser process. This avoids:
1) sending GURLs bigger than 2MB to a different process, which strips them as they're bigger than url::kMaxURLChars
2) having the network process deal with a scheme that's not going over the network, which we avoid
Bug: 937146, 939871
Change-Id: I8ca8225308b2a5f1f90594ab06943f0641a5c551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570805
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652196}
Remove accidental debug logging
In a previous CL [1] some debug logging was added which shouldn't have
been committed.
This CL removes those accidental debug logs.
[1] Add SharedImage thread safe flag
https://chromium-review.googlesource.com/c/chromium/src/+/1504894
Bug: 938594
Change-Id: I938a8fd021823bde0b5017c3ac758ea78fccbf8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572602
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652195}
Revert "[IntersectionObserver] Handle hidden OOPIF's correctly"
This reverts commit f9b9495ccdbf5d13b7c19d922a184e4139fb4ea8.
Reason for revert: https://crbug.com/954217
Original change's description:
> [IntersectionObserver] Handle hidden OOPIF's correctly
>
> When an OOPIF is hidden, by scrolling it outside the parent
> document's viewport, or by setting display:none or visibility:hidden,
> then the iframe process stops running lifecycle updates, and
> IntersectionObserver notifications are not generated. That means that
> an IntersectionObserver running in the iframe process will not get a
> "not intersecting" notification until lifecycle updates resume.
>
> With this change, IntersectionObservers are forced to run when an
> OOPIF is hidden, so that the "not intersecting" notifications will be
> generated without waiting for a lifecycle update.
>
> Adding LocalFrame::WasShown and LocalFrame::WasHidden revealed another
> latent bug -- LocalFrameView::visibility_observer_ was not turned off
> in LocalFrameView::Dispose. As a result, it continued generating
> notifications and sending IPC's to the browser, even after the
> LocalFrameView was disposed. This is a problem with OOPIF's, because
> all iframe's are initially created as a LocalFrameView and later
> converted to a RemoteFrameView. The initial, temporary LFV would
> start up its visibility_observer_, which would continue pumping out
> notifications that were redundant -- and sometimes conflicting --
> with IPC's sent from the RemoteFrameView. This bug only became
> apparent when writing the test included in this patch, which was
> flaky until LFV::visibility_observer_ was properly shut down in
> LFV::Dispose().
>
> BUG=941231
> R=​dtapuska@chromium.org,kenrb@chromium.org,chrishtr@chromium.org
>
> Change-Id: I9c78742930c1829c49998b6f0212d58292fda57f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568200
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Commit-Queue: Stefan Zager <szager@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#652155}
TBR=kenrb@chromium.org,szager@chromium.org,chrishtr@chromium.org,dtapuska@chromium.org
Change-Id: I63555267638e7da6ac73ec85f526f5e1721c98d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 941231, 954217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572707
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652194}
Update inactivity tracker so that the pref is always stored on stop.
This also changes the behavior of onStart - it previously cleared the
timestamp too soon for other code to read the pref. Now the timestamp
is stored in memory in the ChromeInactivityTracker even after the pref
is cleared.
Bug: 951874
Change-Id: Ic2c128e899749aac055e3fd2487f6024fb1fbdba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565278
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652193}
[SendTabToSelf] Add a STTS receiving infobar on iOS.
Display an infobar on iOS when a tab is received via Sync.
The infobar is only shown if the user has an active and visible
WebState. The other cases will be handled in a future CL.
The infobar includes an open button which opens the tab.
Bug: 944602
Change-Id: I88e593dc77a7301a8b0aa20a8fc74afa1c106270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540061
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#652192}
Disable broken unit tests to enable android tests in presubmit.
Bug: internal 120282030
Change-Id: Ifa68f10107c0195683ec794f44220e1c80bc9aa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573161
Auto-Submit: Nate Steinbock <steinbock@google.com>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Nate Steinbock <steinbock@google.com>
Cr-Commit-Position: refs/heads/master@{#652191}