chromium.fyi

[LayoutNG] -webkit-fill-available isn't resolvable during min/max.

Block sizes are also not resolvable if the available block size is
indefinite.

There was no test coverage for this in the block directions, so added
a couple of tests. They are not exportable to WPT, since we're using
-webkit-fill-available.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I1020503de9e8d66ebf9d89a499937b0d58ef4c3a
Reviewed-on: https://chromium-review.googlesource.com/c/1278993
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599915}

[LayoutNG] Rebaseline fast/forms/placeholder-position.html

Just update the render tree dump (it's closer to legacy now, than what
it used to be). The screenshot matches anyway.

TBR=kojii@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ibd3815ac650375ebf7a684eea44e00e4bf70e022
Reviewed-on: https://chromium-review.googlesource.com/c/1282408
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599914}

IDL: Fix IDL grammar in CSSStyleDeclaration

[TreatNullAs] is applicable on DOMString, so the previous declaration
[TreatNullAs] optional DOMString
violates WebIDL grammer.
This CL fixes it.
Its spec also needs to be updated.


Bug: 819112
Change-Id: Ifabca102c3969f3421817e41ad0d3f726643d047
Reviewed-on: https://chromium-review.googlesource.com/c/1281462
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599913}

Report layout jank fractions to the WebLocalFrameClient.

This will allow the page_load_metrics component to observe the jank.

Also address nits in JankTracker::NotifyPrePaintFinished (empty viewport
check, DCHECK for non-zero jank fraction).

Bug: 581518
Change-Id: I22eab226dac31bd1b0ce284240bbca019ce49868
Reviewed-on: https://chromium-review.googlesource.com/c/1280616
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599912}

Remove MemoryCoordinator from content/child

Bug: 888904
Change-Id: I7f6cda10647b4a14fb6b1de821603f99d1cc8008
Reviewed-on: https://chromium-review.googlesource.com/c/1282085
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#599911}

Add web-platform-test for Signed Exchange

This patch adds only one basic test (sxg-location.tentative.html); more
tests will be converted from layout tests in following CLs.

For now, Signed Exchange and certificate are checked-in as static files,
assuming that UAs are configured to ignore signature expiration errors.

The test is marked as tentative as this is an experimental feature.

Bug: 895723
Change-Id: If762a0bf9c498ab3339b4aa09461d37d302e0210
Reviewed-on: https://chromium-review.googlesource.com/c/1282763
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599910}

[async-await] Ship await optimization behind a flag

This adds both finch and about:flags flag.

Intent to ship discussions:
https://groups.google.com/forum/#!topic/v8-users/ML7gOgK8Dsg
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/74QxqINq4g0

Bug: v8:8267, chromium:893469
Change-Id: Ib5a84519d48b9b82604875ff269f0e04977914d5
Reviewed-on: https://chromium-review.googlesource.com/c/1268200
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599909}

Plumb ElementTiming entries to the correct frames

Currently, the element timing is provided to the frame that owns the
<img> element. In particular, no origin checks are being made. This CL
fixes this by doing the following:
* Checking the image origin matches the hosting frame's origin before
performing the computations in ImageElementTiming::NotifyImagePainted.
* Plumbing the information to parent frames for as long as they exist
and are same origin as the current frame.

Bug: 879270
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If744dbc0448e3024ca5d16b59b2b1dc0f436ee58
Reviewed-on: https://chromium-review.googlesource.com/c/1277675
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599908}

Fix presubmit complaints in drive-internals

Don't call javascript unsafely, delegate to a callback instead.
Group related methods.

BUG=chromium:883637

Change-Id: I0beefd27f5304947092f41929f6911a7b9b98a67
Reviewed-on: https://chromium-review.googlesource.com/c/1282485
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599907}

Add upload_url param to OOPHeapProfiling feature

Add optional upload_url param to OOPHeapProfiling feature. It could be
convenient to upload heap profiling traces accumulated from feature turned on
to different upload URL than those that are triggered by another reasons -
chrome://tracing for example.

Change-Id: I91fb0281398c9d2b86fd908e0d9c1b5dd1aaeeda
Reviewed-on: https://chromium-review.googlesource.com/c/1278866
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#599906}

benchmarks/startup.mobile: disable on upstream bots

Currently we are investigating some noisy characteristics of the
benchmark (http://crbug.com/891797), for that we enabled systrace.

Unfortunately, on upstream bots running Android K the trace merging
fails (reasons are unknown). After the investigation is done the
systrace will be turned off anyways because it noticeably affects the
metrics (in non-representative ways).

Disabling the benchmark upstream. This. Is. Temporary. Yes.

Bug: 894744
Change-Id: I9f607e4da1e10727cd2b31b30d0ad15d53ab37c8
Reviewed-on: https://chromium-review.googlesource.com/c/1278214
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599905}

Remove Channel ID from QUIC chromium code

Bug: 875053
Change-Id: I89a955d0eb9bb735e780d33e63fb7d428f93da67
Reviewed-on: https://chromium-review.googlesource.com/c/1279298
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599904}

Roll src/third_party/pdfium 1929d6e1d44e..6ea4d08b905d (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/1929d6e1d44e..6ea4d08b905d


git log 1929d6e1d44e..6ea4d08b905d --date=short --no-merges --format='%ad %ae %s'
2018-10-16 thestig@chromium.org Use unique_ptr and span in CPDF_Image::SetImage().


Created with:
gclient setdep -r src/third_party/pdfium@6ea4d08b905d

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I1162cc3cb18f6f9cb2d0d05af5a5e2d70bbb7f87
Reviewed-on: https://chromium-review.googlesource.com/c/1282348
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599903}

ServiceWorker: Fetch installed scripts from the service worker's script
storage.

The goal is to import and evaluate as a module script at ServiceWorker.
Users can use it by adding type 'module' when register a service
worker script.

This CL allows to fetch installed scripts from the service worker's
script storage. I will add WPT tests and browser tests to make sure to
fetch installed scripts from the service worker's script storage in
the following CLs.

Bug: 824647
Change-Id: I73bcac6ebb9298063fbc13f9dcc31011ae183cef
Reviewed-on: https://chromium-review.googlesource.com/c/1270502
Commit-Queue: Asami Doi <asamidoi@google.com>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599902}

Document how to dump asm code from a binary.

Change-Id: Ia8619be0f295445db3cfe8d3ca2466c2873db2d5
Reviewed-on: https://chromium-review.googlesource.com/c/1275486
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599901}

WebNavigationApi: Remove unused function.

Remove FrameNavigationState::UpdateFrame. This function is not used.

Bug: None.
Change-Id: I59eb69494add5a3e0845a266bbff0af09475f9b4
Reviewed-on: https://chromium-review.googlesource.com/c/1280423
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599900}

Roll src/third_party/depot_tools feec80e97144..642641d03012 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/feec80e97144..642641d03012


git log feec80e97144..642641d03012 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 tandrii@chromium.org git cl comments: remove Rietveld support.


Created with:
gclient setdep -r src/third_party/depot_tools@642641d03012

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:770408
TBR=agable@chromium.org

Change-Id: I75683978717cf07b9ec40131dbec4a525168fdbb
Reviewed-on: https://chromium-review.googlesource.com/c/1282349
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599899}

Roll src-internal a97ee638d858..3f73b9a1f180 (2 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a97ee638d858..3f73b9a1f180


Created with:
gclient setdep -r src-internal@3f73b9a1f180

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I6449b84849a85ba55b9350ef0dfd2a6446cd15b6
Reviewed-on: https://chromium-review.googlesource.com/c/1282325
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599898}

Revert "Fix MessageListView crash on update during close."

This reverts commit 987d8bc9ecb65c60f8ebec3527546e9a9d35d2ca.

Reason for revert: Incomplete fix

Original change's description:
> Fix MessageListView crash on update during close.
>
> MessageListView crashes when a notification is updated during the
> UnifiedSystemTray is closing. Like other views::Widget methods,
> SynthesizeMouseMoveEvent() should not be called during the widget is
> closing.
>
> See the bug for the asan trace.
>
> TEST=manual
> BUG=894070
>
> Change-Id: I9ffba0f73260542ebf21b2aef572af1f68e5c40b
> Reviewed-on: https://chromium-review.googlesource.com/c/1276225
> Commit-Queue: James Cook <jamescook@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598768}

TBR=jamescook@chromium.org,tetsui@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 894070
Change-Id: Ia953fbdc294027179dd85c92d70c8288afa13bbc
Reviewed-on: https://chromium-review.googlesource.com/c/1282488
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599897}

Fix header guards in partition_allocator.

Change-Id: Ie14ad5fb36936e4dd940d22211e5cf77615ca886
Reviewed-on: https://chromium-review.googlesource.com/c/1282385
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599896}

Do IWYU in base/allocator/partition_allocator/.

- When DCHECK is on, memset() gets called in partition_page.h.
- Files that call (D)CHECK() should include base/logging.h.

Change-Id: Iacb0fdea0fba809fcc3f1fd421ba9d0a2427bcbd
Reviewed-on: https://chromium-review.googlesource.com/c/1282384
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599895}

Sync cleanup: Remove handling/wiring for implicit passphrase

Follow-up to https://crrev.com/c/1280268: Setting an implicit passphrase
has not been supported for a long time. This CL removes a bunch of code
to handle that case, and removes the accompanying tests.

Bug: 865936
Change-Id: I3a7ff70b06ebebde8a684dfa5343b3dba563099b
Reviewed-on: https://chromium-review.googlesource.com/c/1280724
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599894}

[ozone/common] Make planar import work with 0x5505 and 0x5504.

This is first step to migrate minigbm to use
GBM_BO_IMPORT_FD_MODIFIER instead of GBM_BO_IMPORT_FD_PLANAR.

Ones ChromeOS will start using the newest chrome, we can
finally add GBM_BO_IMPORT_FD_MODIFIER 0x5504 to minigbm and
get rid of GBM_BO_IMPORT_FD_PLANAR.

See comment from Tomasz in https://crrev.com/c/1273455

Bug: 869206, 578890, 820047
Change-Id: Ibac5c0c874c523e845675ff944561d3e2a3ec530
Reviewed-on: https://chromium-review.googlesource.com/c/1278400
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599893}

Remove chromium.webrtc.fyi buildbot bots from luci-milo.

LUCI is prod now for this master and the buildbot master is being
turned down.

Bug: chromium:877018
Change-Id: I7e71f0da927e1f2d8f79857814f2fbce831894b8
Reviewed-on: https://chromium-review.googlesource.com/c/1280267
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599892}

Remove PassphraseType param from SyncService::SetEncryptionPassphrase

The passphrase type had two possible values, EXPLICIT and IMPLICIT.
IMPLICIT is an ancient legacy concept that hasn't been used in many
years, apart from tests: ProfileSyncServiceHarness did use it in some
circumstances. It's a bad idea to have tests go through an
otherwise-dead code path, so this CL removes those calls.

Bug: 865936
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib91570265eccbe8831e4c831ad9d5dc3c7a6cc18
Reviewed-on: https://chromium-review.googlesource.com/c/1280268
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599891}

Updating trunk VERSION from 3582.0 to 3583.0

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: Iacbffc166a5c02a6ef682a512dc07257f09dcb55
Reviewed-on: https://chromium-review.googlesource.com/c/1282663
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599890}

Revert "[css-layout-api] Add LayoutEdges."

This reverts commit 980bc9b6532b0980721c123fa29fa561bc503f91.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 599680 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTgwYmM5YjY1MzJiMDk4MDcyMWMxMjNmYTI5ZmE1NjFiYzUwM2Y5MQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.10%20Tests/35414

Sample Failed Step: webkit_layout_tests on (none) GPU on Mac on Mac-10.10.5

Sample Flaky Test: external/wpt/css/css-layout-api/edges/scrollbar.https.html

Original change's description:
> [css-layout-api] Add LayoutEdges.
>
> This allows web developers to access pre-computed sizes for the border,
> scrollbar, and padding "edges".
>
> This adds two types of tests:
> 1) Uses the standard "green box" approach of testing the script values
> match what is expected.
> 2) Positions four children at each corner (using edges) are positioned
> the same as using an abs-pos technique.
>
> Bug: 726125
> Change-Id: I3b53be9b44989d919cb657d4eabc6d3a1a79181b
> Reviewed-on: https://chromium-review.googlesource.com/c/1252776
> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
> Reviewed-by: Aleks Totic <atotic@chromium.org>
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599680}

Change-Id: Ib4f9cb3e51daa57412d31cff71cbf0a3fe15cab9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 726125, 895731
Reviewed-on: https://chromium-review.googlesource.com/c/1282724
Cr-Commit-Position: refs/heads/master@{#599889}

Roll src/third_party/SPIRV-Tools/src 339d23275d07..eea449a1e82a (1 commits)

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/339d23275d07..eea449a1e82a


git log 339d23275d07..eea449a1e82a --date=short --no-merges --format='%ad %ae %s'
2018-10-15 dneto@google.com validator: FPRoundingMode can apply to vector conversions


Created with:
gclient setdep -r src/third_party/SPIRV-Tools/src@eea449a1e82a

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I2baa0857a558deec0c7d9f65099bb3ed28691ce1
Reviewed-on: https://chromium-review.googlesource.com/c/1281864
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599888}

WebApp: Introduce WebApp, WebAppRegistrar and InstallManager entities.

Introduce DesktopPWAsWithoutExtensions command line switch.

A WebApp represents single web app.
WebApp objects are owned by WebAppRegistrar.

WebAppRegistrar is a root entity which is able to add/remove new apps.
Later WebAppRegistrar will be able:
- to iterate over all the registered apps.
- to iterate over various subsets of all registered apps (shortcut apps)
- to survive the browser (and ChromeOS) relaunch (persistence)

InstallManager is an abstract manager to plumb 3-dot menu user installation.
We will evolve its WebAppInstallManager implementation
into comprehensive install manager later.

--enable-features=DesktopPWAsWithoutExtensions will enable off-extensions
implementation for Desktop PWAs.

Bug: 891172, 871116
Change-Id: Iebcbd93cf08eec0f11c7c22dce57ded81a2a2e94
Reviewed-on: https://chromium-review.googlesource.com/c/1275468
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599887}

Roll src/third_party/webrtc f7fee39547d8..c9e6b969a452 (42 commits)

https://webrtc.googlesource.com/src.git/+log/f7fee39547d8..c9e6b969a452


git log f7fee39547d8..c9e6b969a452 --date=short --no-merges --format='%ad %ae %s'
2018-10-15 ouj@fb.com Add necessary frameworks to sdk objc audio targets.
2018-10-15 mbonadei@webrtc.org Export symbols needed by the Chromium component build (part 2).
2018-10-15 benwright@webrtc.org Formatting and style guide improvements for opensslstreamadapter.cc
2018-10-15 mbonadei@webrtc.org Revert "Deprecates legacy transport feedback adapter."
2018-10-15 srte@webrtc.org Deprecates legacy transport feedback adapter.
2018-10-15 srte@webrtc.org Removes analyzer dependency on legacy congestion controller.
2018-10-15 niklas.enbom@webrtc.org Revert "Modernize rtc::SSLCertificate"
2018-10-15 eladalon@webrtc.org Fix force_fieldtrials documentation in video_loopback
2018-10-15 srte@webrtc.org Removing forward declarations in paced_sender.h.
2018-10-15 srte@webrtc.org Adds unit test for RTT based backoff.
2018-10-15 srte@webrtc.org Merges ControlHandler and PacerController.
2018-10-15 srte@webrtc.org Moves functionality to TransportFeedbackAdapter.
2018-10-15 ivoc@webrtc.org Stop simulations when a LOG_END event is reached.
2018-10-15 henrik.lundin@webrtc.org NetEq fuzzer: Restrict fuzzer input to 90000 bytes
2018-10-15 ivoc@webrtc.org Make ivoc owner of audio_coding.
2018-10-15 mbonadei@webrtc.org Revert "Reland: Use unique_ptr and ArrayView in SSLFingerprint"
2018-10-15 titovartem@webrtc.org Extract functionality of test_main into separate library.
2018-10-15 ivoc@webrtc.org Add command-line flag for setting the max number of packets in the buffer.
2018-10-15 sprang@webrtc.org Move MockVideoDecoder to api/test.
2018-10-15 gustaf@webrtc.org AEC3: Simplify render buffering
2018-10-15 srte@webrtc.org Moves rtc::SentPacket to separate target.
2018-10-15 crodbro@webrtc.org New method for precise packet reception time measurement.
2018-10-15 asapersson@webrtc.org Add field trial to disable unsignalled video.
2018-10-15 ilnik@webrtc.org Fix FakeEncoder to produce correct bitrate for several temporal layers
2018-10-15 ssilkin@webrtc.org Set frame duration per spatial layer.
2018-10-15 kron@webrtc.org Refactor of extmap-allow-mixed in SessionDescription
2018-10-15 phoglund@webrtc.org Delete force_mic_volume_max.
2018-10-15 jakobi@webrtc.org Add field trials for configuring Opus encoder packet loss rate.
2018-10-15 danilchap@webrtc.org in RtpPacketizers separate case 'frame fits into single packet'.
2018-10-15 asapersson@webrtc.org Add field trial for normalized simulcast size.
2018-10-15 mbonadei@webrtc.org Remove ios32_sim_ios9_dbg from CQ.
2018-10-15 oprypin@webrtc.org cq: explicitly mark presubmit tryjob as not re-usable in CQ.
2018-10-15 mbonadei@webrtc.org Remove rtc_base/Dummy.java.
2018-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 03013c95df..0df2607f98 (599460:599562)
2018-10-14 oprypin@webrtc.org Revert "Propagate media transport to media channel."
2018-10-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3b54b6aa8b..03013c95df (599343:599460)
2018-10-12 sukhanov@google.com Propagate media transport to media channel.
2018-10-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c12ec9eedc..3b54b6aa8b (599188:599343)
2018-10-12 steveanton@webrtc.org Modernize rtc::SSLCertificate
2018-10-12 steveanton@webrtc.org Reland: Use unique_ptr and ArrayView in SSLFingerprint
2018-10-12 benwright@webrtc.org Removes backwards compatability CryptoOptions support.
2018-10-12 terelius@webrtc.org Move expectations from eventlog unittests to helper functions.


Created with:
gclient setdep -r src/third_party/webrtc@c9e6b969a452

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:895082,chromium:None,chromium:895338,chromium:none,chromium:880074,chromium:none,chromium:893955,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I91bb7f65d2d749ab95ddcc51e5391973e6c6deca
Reviewed-on: https://chromium-review.googlesource.com/c/1282323
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599886}

Adding CHECK macro to debug crash.

Moving a DCHCEK to CHECK and adding a new CHECK macro to debug crash
which are hard to reproduce on local devices. This CHECK will soon
be moved back to DCHECK.

Bug: 892354
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I44e237db73cec5259b90bb312e7940b41553d332
Reviewed-on: https://chromium-review.googlesource.com/c/1282104
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599885}

apk_operations.py: Minor bugfixes to disk-usage command

* Fix exception when not using a wrapper script
* Fix stripping "Hidden system packages" (does not always come last)
* Fix error message when package does not exist (on newer OS's)
* Add a warning when measuring a system apks

Change-Id: I0b43993e3b28f723899d236f43365e2d954607bb
Reviewed-on: https://chromium-review.googlesource.com/c/1281104
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599884}

Roll src-internal b4ed4fd40624..a97ee638d858 (4 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b4ed4fd40624..a97ee638d858


Created with:
gclient setdep -r src-internal@a97ee638d858

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=mmoss@chromium.org

Change-Id: I807793eef453e86ab3e5076b0bb77360efd1ca98
Reviewed-on: https://chromium-review.googlesource.com/c/1282343
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599883}

[media] Clarify PipelineImpl locking comments.

Bug: 893739
Change-Id: Icb19a36549d9f877f5b32a5a10b05f1420f812a8
Reviewed-on: https://chromium-review.googlesource.com/c/1279292
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599882}

Reland: Add footnote support to top-level menus

Adds a function to |MenuDelegate| that can be overloaded to create a
footnote View for a top-level menu.

The footnote view is rendered at the bottom of the menu, with a
different background color, similar to
|BubbleFrameView::SetFootnoteView()|.

Bug: 889229, 894193
Change-Id: Icb67740fddfe03a7a2d9bae7c70b383cfe6a9845
Reviewed-on: https://chromium-review.googlesource.com/c/1277573
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599881}

Reland "[testing/scripts] Add base adapter class that enables more code reuse for all isolated script test"

This is a reland of 18e40bdceea9a7a147d99e35cf138c7872d9d229


It also includes the fix to only generate filter file for isolated_script_test if --isolated-script-test-filter flag is passed

This will make the behavior of testing/scripts/run_isolated_script_test.py matches
with what happened before the refactoring in https://chromium-review.googlesource.com/c/chromium/src/+/1278156

The bug happened because when --isolated-script-test-filter is not passed,
TypUnittestAdapter.generate_test_filter_args() isn't called, which means the _temp_filter_file file
handle is not closed. Hence attempting to remove the file will cause a crash on Windows platform
(removing a file whose file handle opened).

In this fix, we create _temp_filter_file within TypUnittestAdapter.generate_test_filter_args() and
only clean up the file if it was created.

This also fix generate_test_filter_args to generate flags with self._temp_filter_file.name (used to beself._temp_filter_file)

TBR=kbr@chromium.org, dpranke@chromium.org, dtrainor@chromium.org

Bug: 894261, 895586, 895601
Change-Id: I74255ba2bc7598db9df18cff4bff4407c2a927f8
Reviewed-on: https://chromium-review.googlesource.com/c/1281902
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#599880}

Revise TLS 1.3 downgrade feature and metrics.

Due to non-compliant middleboxes, it is possible we'll need to do some
surgery to this mechanism. Fix the double-negative on the base::Feature
so it is less confusing and gather more extensive metrics when
enforcement is disabled. Also flip the default in trunk to disabled and
connect it to about:flags.

Finally, add a bunch of machinery to test this stuff.

Bug: boringssl:226
Change-Id: Ib910328c9733b47db16b4cb811e8f2cb09b69d0c
Reviewed-on: https://chromium-review.googlesource.com/c/1274605
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599879}

Roll src/third_party/catapult 2be20fdd2d70..88afab4ff0f0 (4 commits)

https://chromium.googlesource.com/catapult.git/+log/2be20fdd2d70..88afab4ff0f0


git log 2be20fdd2d70..88afab4ff0f0 --date=short --no-merges --format='%ad %ae %s'
2018-10-15 benjhayden@chromium.org Add ReportCacheRequest for v2spa service worker
2018-10-15 pasko@chromium.org event_finder_util: skip renderer events when no mainThread
2018-10-15 chiniforooshan@chromium.org Telemetry: fix a bug in percentage_smooth
2018-10-15 dproy@chromium.org Fix top level scheduler task title


Created with:
gclient setdep -r src/third_party/catapult@88afab4ff0f0

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:891797,chromium:895096,chromium:871204,chromium:832651
TBR=sullivan@chromium.org

Change-Id: I2a5a1b05066c3c5f10bbec768c0bd430c80e5fa4
Reviewed-on: https://chromium-review.googlesource.com/c/1282342
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599878}

Roll src/third_party/skia be7450b6c635..198b87e5be20 (5 commits)

https://skia.googlesource.com/skia.git/+log/be7450b6c635..198b87e5be20


git log be7450b6c635..198b87e5be20 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 bbd532d164f0..a1ac3fe80647 (1 commits)
2018-10-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-10-15 egdaniel@google.com Revert "Have GrAtlasManager use legacy behavior"
2018-10-15 herb@google.com Have GrAtlasManager use legacy behavior
2018-10-15 reed@google.com remove noisy gm


Created with:
gclient setdep -r src/third_party/skia@198b87e5be20

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@chromium.org

Change-Id: I7ca32feb9b943f90ba7ee1ad6f9614ddde1417ad
Reviewed-on: https://chromium-review.googlesource.com/c/1282324
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599877}

[LayoutNG] Fix MarkLineBoxesDirtyFor for form controls

This patch fixes |MarkLineBoxesDirtyFor()| when the object is
an atomic inline that is not LayoutNGBlockFlow; e.g., form
controls.

It fails because |EnclosingNGBlockFlow()| returns itself if
the given object is LayoutBox, and if the atomic inline is
in legacy, it returns nullptr.

This problem keeps occuring, and there are two fixes done
independently. To avoid this happening again, this patch
also removes |EnclosingNGBlockFlow()| and add
|ContainingNGBlockFlow()| instead.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia01a197697b1d4b3da3efde18154e33ece289529
Reviewed-on: https://chromium-review.googlesource.com/c/1278667
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599876}

Update LocalFrameView traces to reflect functions being called.

This patch updates the trace names to be Run*LifecyclePhase for each
lifecycle phase, making it easier to track via telemetry.

It also inlines a function called only from one spot.

R=schenney@chromium.org, chrishtr@chromium.org

Bug: 892861
Change-Id: I4224844532235d89671d79ed0408618b6203ed63
Reviewed-on: https://chromium-review.googlesource.com/c/1272258
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599875}

Enable MD dynamic refresh on ChromeOS

BUG=881371
R=robliao

Change-Id: Ic4a06e4e98cf93339ee9038d25ee6cc7b945037b
Reviewed-on: https://chromium-review.googlesource.com/c/1277684
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599874}

ws: Refactor views::EventMonitor to use ui::EventObserver

EventObserver has support for Window Service clients.
EventObserver prevents changes to events and dispatch.

Encapsulate FullscreenControlHost's EventMonitor; destroy with widget.
Move Mac's dispatch changes to the one user, MenuPreTargetHandlerMac.

Bug: 887725, 799428
Change-Id: I1dcb9f7786885210ea56b0c3c3f7134e21228de1
Reviewed-on: https://chromium-review.googlesource.com/c/1258217
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599873}

OOBE refactor: Let individual screens determine the visibility

This is the refactor portion of https://crrev.com/c/1272085.

The logic in wizard_controller.cc is very complex. We should try to
move the screen specific logic out of it.

Bug: NONE
Change-Id: Id89479b4b145b2a80333bbbadd1e51472fb8ab49
Reviewed-on: https://chromium-review.googlesource.com/c/1281171
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599872}

Don't send events to windows that don't have TARGET event-targeting policy.

There are non-targeting windows that can still submit CompositorFrame,
set a flag when creating HitTestDataProviderDrawQuad to indicate
whether that window has TARGET event-targeting policy or not to
decide whether we should set Mine (accept events) or Ignore (reject
events) flag.

This is a speculative fix to bug 877762, with tests to show the
expected behavior.

Bug: 877762
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6f9971daccffb3065abb984e1166eb266c5a9db2
Reviewed-on: https://chromium-review.googlesource.com/c/1260511
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599871}

gpu: Add UMA metric for measuring total raster task duration.

Add an UMA metric which reports the accumulated time for a raster task
including the time from raster worker thread and the GPU main thread.
The GPU side timer takes care of only measuring time slices when the
decoder is processing commands.

R=vmiura@chromium.org, piman@chromium.org

BUG: 894200
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If02a76420dbdf5ffb5041b8290412d144d787fb4
Reviewed-on: https://chromium-review.googlesource.com/c/1267235
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599870}

Revert "Run browser_tests as a 25% experiment on Mac10.13 Tests & mac_chromium_rel_ng."

This reverts commit b20ba21cddf5bd37aeaf36e4056cb019ea912635.

Reason for revert: Added capacity isn't finding bot deaths as fast as manual, targeted swarming invocations. Will reland this after having some confidence that the 10.13 bot-killer tests are identified.

Original change's description:
> Run browser_tests as a 25% experiment on Mac10.13 Tests & mac_chromium_rel_ng.
>
> Bug: 828031
> Change-Id: I1d4bdb235ad9d93df0653215c7c5928c471b6c16
> Reviewed-on: https://chromium-review.googlesource.com/c/1277693
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599364}

TBR=rsesek@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 828031
Change-Id: I38c447f53d533eeff40abfd462c3bb1f09eac75f
Reviewed-on: https://chromium-review.googlesource.com/c/1282283
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599869}

Roll src/third_party/chromite 3871bde5c505..079a94f7aec0 (6 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3871bde5c505..079a94f7aec0


git log 3871bde5c505..079a94f7aec0 --date=short --no-merges --format='%ad %ae %s'
2018-10-16 dgarrett@google.com chromeos_config: Enable all firmwarebranch builders.
2018-10-15 dgarrett@google.com chromeos_config: Move nyan_blaze-paladin to swarming.
2018-10-15 shapiroc@chromium.org Remove model details from chromeos version string
2018-10-15 vapier@chromium.org cros_test_lib: drop mox support
2018-10-15 dgarrett@google.com WorkspaceBuildPackages: Adjust --withdebugsymbols cutoff.
2018-10-15 derat@chromium.org chromeos_config: Set warn_only for chrome-informational.


Created with:
gclient setdep -r src/third_party/chromite@079a94f7aec0

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ieb4124355375ef34707d143448dc512b1e5a9b75
Reviewed-on: https://chromium-review.googlesource.com/c/1282346
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599868}

Worker: Remove unused WorkerClassicScriptLoader::CachedMetadata()

Bug: n/a
Change-Id: Id609b13a2bc3dbe67652a18f3d8344e52d24ae12
TBR: nhiroki@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1282502
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599867}

Remove the usage of std::wstring in ui/shell_dialogs/

Bug: 884075
Change-Id: I7fba4358da8876c591490dd15263f3b669abdaf7
Reviewed-on: https://chromium-review.googlesource.com/c/1277950
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599866}