Home | Search | chromium - Builders
Login

Builder WebRTC Chromium Win8 Tester Build 288 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision28d424ea311f180535b9a5aceb6facfc61c9b59e
Got Revision28d424ea311f180535b9a5aceb6facfc61c9b59e

Execution:

Steps and Logfiles:

Show:
  1. ( 451 ms ) setup_build
    running recipe: "chromium"
  2. ( 2 secs ) report builders
     
    running tester 'WebRTC Chromium Win8 Tester' on master 'chromium.webrtc'
  3. ( 5 secs ) taskkill
  4. ( 9 mins 3 secs ) bot_update
    [76GB/465GB used (16%)]
  5. ( 2 secs ) swarming.py --version
    0.14
  6. ( 3 mins 20 secs ) gclient runhooks
  7. ( 205 ms ) read test spec (chromium.webrtc.json)
    path: c:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.webrtc.json
  8. ( 398 ms ) lookup builder GN args
     
    com_init_check_hook_disabled = true
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "c:\\b\\s\\w\\ir\\cache\\goma\\client"
  9. ( 4 secs ) build directory
  10. ( 1 mins 51 secs ) extract build
  11. ( 275 ms ) find isolated tests
  12. ( 31 secs ) browser_tests_apprtc
    browser_tests_apprtc
    879 disabled
  13. ( 11 secs ) capture_unittests
    capture_unittests
    28 disabled
  14. ( 24 mins 47 secs ) browser_tests
    browser_tests
    <div class="BuildResultInfo">
    Compositor Picking Frame Latency Max: 10.3k
    Compositor Picking Frame Latency Max: 13.7k
    Compositor Picking Frame Latency Max: 14.6k
    Compositor Picking Frame Latency Max: 16.9k
    Compositor Picking Frame Latency Max: 17.4k
    Compositor Picking Frame Latency Max: 17.6k
    Compositor Picking Frame Latency Max: 17.8k
    Compositor Picking Frame Latency Max: 19.0k
    Compositor Picking Frame Latency Max: 31.2k
    Compositor Picking Frame Latency Max: 31.7k
    Compositor Picking Frame Latency Max: 32.0k
    Compositor Picking Frame Latency Max: 7.07k
    Compositor Picking Frame Latency Max: 7.14k
    Compositor Picking Frame Latency Max: 8.22k
    Compositor Picking Frame Latency Max: 8.92k
    Compositor Picking Frame Latency Max: 9.91k
    Compositor Picking Frame Latency Mean: 182
    Compositor Picking Frame Latency Mean: 291
    Compositor Picking Frame Latency Mean: 311
    Compositor Picking Frame Latency Mean: 341
    Compositor Picking Frame Latency Mean: 440
    Compositor Picking Frame Latency Mean: 457
    Compositor Picking Frame Latency Mean: 559
    Compositor Picking Frame Latency Mean: 6.9k
    Compositor Picking Frame Latency Mean: 635
    Compositor Picking Frame Latency Mean: 7.38k
    Compositor Picking Frame Latency Mean: 7.62k
    Compositor Picking Frame Latency Mean: 8.12k
    Compositor Picking Frame Latency Mean: 8.14k
    Compositor Picking Frame Latency Mean: 8.34k
    Compositor Picking Frame Latency Mean: 9.46k
    Compositor Picking Frame Latency Mean: 9.4k
    Compositor Resource Preparation Latency Max: 1.17k
    Compositor Resource Preparation Latency Max: 1.24k
    Compositor Resource Preparation Latency Max: 1.25k
    Compositor Resource Preparation Latency Max: 1.3k
    Compositor Resource Preparation Latency Max: 1.83k
    Compositor Resource Preparation Latency Max: 1.92k
    Compositor Resource Preparation Latency Max: 2.16k
    Compositor Resource Preparation Latency Max: 2.51k
    Compositor Resource Preparation Latency Max: 4.09k
    Compositor Resource Preparation Latency Max: 4.24k
    Compositor Resource Preparation Latency Max: 465
    Compositor Resource Preparation Latency Max: 553
    Compositor Resource Preparation Latency Max: 597
    Compositor Resource Preparation Latency Max: 605
    Compositor Resource Preparation Latency Max: 682
    Compositor Resource Preparation Latency Max: 691
    Compositor Resource Preparation Latency Mean: 1.06k
    Compositor Resource Preparation Latency Mean: 1.11k
    Compositor Resource Preparation Latency Mean: 222
    Compositor Resource Preparation Latency Mean: 225
    Compositor Resource Preparation Latency Mean: 225
    Compositor Resource Preparation Latency Mean: 241
    Compositor Resource Preparation Latency Mean: 337
    Compositor Resource Preparation Latency Mean: 364
    Compositor Resource Preparation Latency Mean: 398
    Compositor Resource Preparation Latency Mean: 405
    Compositor Resource Preparation Latency Mean: 461
    Compositor Resource Preparation Latency Mean: 491
    Compositor Resource Preparation Latency Mean: 550
    Compositor Resource Preparation Latency Mean: 581
    Compositor Resource Preparation Latency Mean: 810
    Compositor Resource Preparation Latency Mean: 942
    Passing to Render Algorithm Latency Max: 1.18k
    Passing to Render Algorithm Latency Max: 1.59k
    Passing to Render Algorithm Latency Max: 1.65k
    Passing to Render Algorithm Latency Max: 1.73k
    Passing to Render Algorithm Latency Max: 2.84k
    Passing to Render Algorithm Latency Max: 2.8k
    Passing to Render Algorithm Latency Max: 255
    Passing to Render Algorithm Latency Max: 3.08k
    Passing to Render Algorithm Latency Max: 3.58k
    Passing to Render Algorithm Latency Max: 333
    Passing to Render Algorithm Latency Max: 5.52k
    Passing to Render Algorithm Latency Max: 5.64k
    Passing to Render Algorithm Latency Max: 6.45k
    Passing to Render Algorithm Latency Max: 7.48k
    Passing to Render Algorithm Latency Max: 793
    Passing to Render Algorithm Latency Max: 832
    Passing to Render Algorithm Latency Mean: 102
    Passing to Render Algorithm Latency Mean: 107
    Passing to Render Algorithm Latency Mean: 128
    Passing to Render Algorithm Latency Mean: 175
    Passing to Render Algorithm Latency Mean: 321
    Passing to Render Algorithm Latency Mean: 338
    Passing to Render Algorithm Latency Mean: 41.0
    Passing to Render Algorithm Latency Mean: 416
    Passing to Render Algorithm Latency Mean: 48.0
    Passing to Render Algorithm Latency Mean: 498
    Passing to Render Algorithm Latency Mean: 56.0
    Passing to Render Algorithm Latency Mean: 77.0
    Passing to Render Algorithm Latency Mean: 85.0
    Passing to Render Algorithm Latency Mean: 86.0
    Passing to Render Algorithm Latency Mean: 98.0
    Passing to Render Algorithm Latency Mean: 99.0
    Render Algorithm Latency Max: 1.27k
    Render Algorithm Latency Max: 1.56k
    Render Algorithm Latency Max: 16.2k
    Render Algorithm Latency Max: 19.7k
    Render Algorithm Latency Max: 2.53k
    Render Algorithm Latency Max: 2.7k
    Render Algorithm Latency Max: 20.5k
    Render Algorithm Latency Max: 20.6k
    Render Algorithm Latency Max: 21.9k
    Render Algorithm Latency Max: 28.6k
    Render Algorithm Latency Max: 286
    Render Algorithm Latency Max: 31.3k
    Render Algorithm Latency Max: 32.9k
    Render Algorithm Latency Max: 4.06k
    Render Algorithm Latency Max: 4.31k
    Render Algorithm Latency Max: 566
    Render Algorithm Latency Mean: 150
    Render Algorithm Latency Mean: 152
    Render Algorithm Latency Mean: 20.0
    Render Algorithm Latency Mean: 25.0
    Render Algorithm Latency Mean: 28.0
    Render Algorithm Latency Mean: 6.09k
    Render Algorithm Latency Mean: 6.2k
    Render Algorithm Latency Mean: 6.63k
    Render Algorithm Latency Mean: 6.69k
    Render Algorithm Latency Mean: 6.86k
    Render Algorithm Latency Mean: 6.94k
    Render Algorithm Latency Mean: 7.02k
    Render Algorithm Latency Mean: 7.85k
    Render Algorithm Latency Mean: 81.0
    Render Algorithm Latency Mean: 84.0
    Render Algorithm Latency Mean: 88.0
    Skipped frames: 0.0
    Skipped frames: 0.0
    Skipped frames: 1.33
    Skipped frames: 1.33
    Skipped frames: 2.0
    Skipped frames: 2.0
    Skipped frames: 2.5
    Skipped frames: 2.65
    Skipped frames: 32.3
    Skipped frames: 32.3
    Skipped frames: 34.5
    Skipped frames: 36.1
    Skipped frames: 36.8
    Skipped frames: 37.0
    Skipped frames: 37.3
    Skipped frames: 38.7
    Total Controlled Latency Max: 11.6k
    Total Controlled Latency Max: 11.9k
    Total Controlled Latency Max: 17.8k
    Total Controlled Latency Max: 18.2k
    Total Controlled Latency Max: 18.4k
    Total Controlled Latency Max: 19.1k
    Total Controlled Latency Max: 28.1k
    Total Controlled Latency Max: 30.0k
    Total Controlled Latency Max: 30.3k
    Total Controlled Latency Max: 33.0k
    Total Controlled Latency Max: 33.0k
    Total Controlled Latency Max: 39.3k
    Total Controlled Latency Max: 43.6k
    Total Controlled Latency Max: 49.8k
    Total Controlled Latency Max: 7.88k
    Total Controlled Latency Max: 9.54k
    Total Controlled Latency Mean: 1.01k
    Total Controlled Latency Mean: 1.11k
    Total Controlled Latency Mean: 1.77k
    Total Controlled Latency Mean: 1.89k
    Total Controlled Latency Mean: 10.6k
    Total Controlled Latency Mean: 10.7k
    Total Controlled Latency Mean: 10.9k
    Total Controlled Latency Mean: 12.4k
    Total Controlled Latency Mean: 2.07k
    Total Controlled Latency Mean: 2.51k
    Total Controlled Latency Mean: 2.7k
    Total Controlled Latency Mean: 3.3k
    Total Controlled Latency Mean: 7.74k
    Total Controlled Latency Mean: 8.37k
    Total Controlled Latency Mean: 8.78k
    Total Controlled Latency Mean: 9.08k
    Total Latency Max: 16.9k
    Total Latency Max: 17.8k
    Total Latency Max: 18.2k
    Total Latency Max: 18.4k
    Total Latency Max: 21.7k
    Total Latency Max: 24.5k
    Total Latency Max: 28.2k
    Total Latency Max: 31.0k
    Total Latency Max: 32.1k
    Total Latency Max: 32.2k
    Total Latency Max: 33.1k
    Total Latency Max: 39.3k
    Total Latency Max: 43.6k
    Total Latency Max: 47.1k
    Total Latency Max: 48.1k
    Total Latency Max: 49.8k
    Total Latency Mean: 10.6k
    Total Latency Mean: 10.8k
    Total Latency Mean: 10.9k
    Total Latency Mean: 12.6k
    Total Latency Mean: 7.82k
    Total Latency Mean: 7.86k
    Total Latency Mean: 8.27k
    Total Latency Mean: 8.39k
    Total Latency Mean: 8.39k
    Total Latency Mean: 8.83k
    Total Latency Mean: 8.87k
    Total Latency Mean: 8.97k
    Total Latency Mean: 9.16k
    Total Latency Mean: 9.39k
    Total Latency Mean: 9.39k
    Total Latency Mean: 9.53k
    Vsync Latency Max: 11.1k
    Vsync Latency Max: 12.8k
    Vsync Latency Max: 2.53k
    Vsync Latency Max: 2.59k
    Vsync Latency Max: 2.71k
    Vsync Latency Max: 26.4k
    Vsync Latency Max: 29.0k
    Vsync Latency Max: 29.3k
    Vsync Latency Max: 29.5k
    Vsync Latency Max: 29.9k
    Vsync Latency Max: 3.55k
    Vsync Latency Max: 31.4k
    Vsync Latency Max: 32.6k
    Vsync Latency Max: 4.28k
    Vsync Latency Max: 6.33k
    Vsync Latency Max: 7.02k
    Vsync Latency Mean: 1.04k
    Vsync Latency Mean: 1.16k
    Vsync Latency Mean: 1.19k
    Vsync Latency Mean: 1.22k
    Vsync Latency Mean: 1.33k
    Vsync Latency Mean: 1.66k
    Vsync Latency Mean: 1.69k
    Vsync Latency Mean: 438
    Vsync Latency Mean: 471
    Vsync Latency Mean: 487
    Vsync Latency Mean: 544
    Vsync Latency Mean: 671
    Vsync Latency Mean: 680
    Vsync Latency Mean: 753
    Vsync Latency Mean: 895
    Vsync Latency Mean: 968
    </div>
  15. ( 1 secs ) wait for tasks
  16. ( 2 secs ) browser_tests_functional
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:31.540612
  17. ( 1 secs ) remoting_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 27s
  18. ( 1 secs ) jingle_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 19s
  19. ( 1 secs ) content_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:35.537846
  20. ( 2 secs ) content_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 35s
  21. ( 1 secs ) content_browsertests_sequential
    Run on OS: 'Windows-7-SP1'
    Shard duration: 38s
  22. ( 1 secs ) content_browsertests_stress
    Run on OS: 'Windows-7-SP1'
    Shard duration: 45s
  23. ( 148 ms ) Tests statistics
     
    Stats
    Total shards: 7
    Total runtime: 0:02:43.527000
     
  24. ( 359 ms ) process_dumps

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "c:\\b\\s\\w\\ir\\cache", "temp_dir": "c:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build14-b9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.webrtc", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544164749623530, "id": "8927819619457903888", "project": "chromium", "tags": ["builder:WebRTC Chromium Win8 Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/28d424ea311f180535b9a5aceb6facfc61c9b59e", "gitiles_ref:refs/heads/master", "parent_buildername:WebRTC Chromium Win Builder", "parent_buildnumber:670", "scheduler_invocation_id:9093249681539505440", "scheduler_job_id:chromium/WebRTC Chromium Win8 Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "WebRTC Chromium Win8 Tester" setup_build
buildnumber 288 setup_build
mastername "chromium.webrtc" setup_build
parent_buildername "WebRTC Chromium Win Builder" setup_build
parent_got_angle_revision "c3e3731cd3b2a3044f1bdec906c8557cc3edae77" setup_build
parent_got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" setup_build
parent_got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" setup_build
parent_got_nacl_revision "8e13fe5e85640b063aefcb88a3ccb52abf6e28e8" setup_build
parent_got_revision "28d424ea311f180535b9a5aceb6facfc61c9b59e" setup_build
parent_got_revision_cp "refs/heads/master@{#614622}" setup_build
parent_got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" setup_build
parent_got_v8_revision "fd3bdfdac02db5d3ab67b707cfe9ca814947d18e" setup_build
parent_got_v8_revision_cp "refs/heads/7.3.56@{#1}" setup_build
parent_got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25919}" setup_build
parent_mastername "chromium.webrtc" setup_build
path_config "generic" setup_build
perf_dashboard_machine_group "ChromiumWebRTC" setup_build
recipe "chromium" setup_build
revision "28d424ea311f180535b9a5aceb6facfc61c9b59e" setup_build
swarm_hashes {"browser_tests": "799da5660c5c4a67edd4648c41f147261153001e", "content_browsertests": "9e11c8a4c49ad8913b976475602f6aa52a8e7560", "content_unittests": "e2293a50e665d05df5f8f86eb7eb7ffed5f1777d", "jingle_unittests": "5f47f2dd0afb37a23e86ac1cb82f58735cee7974", "remoting_unittests": "65dd0702bff69ce96926069d2e9c9a29c740afcc"} setup_build
got_angle_revision "c3e3731cd3b2a3044f1bdec906c8557cc3edae77" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" bot_update
got_nacl_revision "8e13fe5e85640b063aefcb88a3ccb52abf6e28e8" bot_update
got_revision "28d424ea311f180535b9a5aceb6facfc61c9b59e" bot_update
got_revision_cp "refs/heads/master@{#614622}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "fd3bdfdac02db5d3ab67b707cfe9ca814947d18e" bot_update
got_v8_revision_cp "refs/heads/7.3.56@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
swarm_hashes {"browser_tests": "799da5660c5c4a67edd4648c41f147261153001e", "content_browsertests": "9e11c8a4c49ad8913b976475602f6aa52a8e7560", "content_unittests": "e2293a50e665d05df5f8f86eb7eb7ffed5f1777d", "jingle_unittests": "5f47f2dd0afb37a23e86ac1cb82f58735cee7974", "remoting_unittests": "65dd0702bff69ce96926069d2e9c9a29c740afcc"} find isolated tests

Blamelist:

  1. Alan Cutter (alancutterohnoyoudont@chromium.org)
  2. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  3. Kinuko Yasuda (kinukoohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 06:39:09 UTC
Start Friday, 07-Dec-18 06:41:50 UTC
End Friday, 07-Dec-18 07:26:00 UTC
Pending 2 mins 41 secs
Execution 44 mins 9 secs

All Changes:

  1. Revert "Timer notification UI improvement:"

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:18:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 28d424ea311f180535b9a5aceb6facfc61c9b59e

    Comments

    Revert "Timer notification UI improvement:"
    
    This reverts commit d710a7b3ef59302c00c2e3fe1b00c788310801c6.
    
    Reason for revert: Broke compile:
    https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59395
    ../../chromeos/services/assistant/assistant_manager_service_impl.cc:33:10: fatal error: 'libassistant/shared/internal_api/alarm_timer_types.h' file not found
    #include "libassistant/shared/internal_api/alarm_timer_types.h"
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 error generated.
    
    Original change's description:
    > Timer notification UI improvement:
    > 
    > * Add timer deeplinks for:
    >   - Stop timer
    >   - Add time to timer
    > * Add "add 1 min to timer" button to timer notification.
    > 
    > Using a feature flag to guard the usage of the deeplink as
    > AlarmTimerManager is not fully available yet.
    > 
    > Bug: b:119116816
    > Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
    > Reviewed-on: https://chromium-review.googlesource.com/c/1340786
    > Commit-Queue: Li Lin <llin@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > Reviewed-by: Tao Wu <wutao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614618}
    
    TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,wutao@chromium.org,llin@chromium.org
    
    Change-Id: I8ece5ad7361e379880921e2abc55085d1de6cd88
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:119116816
    Reviewed-on: https://chromium-review.googlesource.com/c/1367081
    Reviewed-by: Alan Cutter <alancutter@chromium.org>
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614622}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  2. Report PreviewsEligibilityReason as offline when device is offline

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:11:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01c4f97005f6f162b3df6953b8f2a4efce338ec1

    Comments

    Report PreviewsEligibilityReason as offline when device is offline
    
    Currently, if the device is offline, PreviewsEligibilityReason
    records the reason for not showing previews as network quality
    unavailable.
    
    This CL changes it to record the reason as device offline.
    Network quality unavailable reason is now used for only the cases where
    NQE (network quality estimator) reports ECT as Unknown.
    
    Bug: 912725
    Change-Id: I0af0977770e2123f6ccd0317f8ebbfaed1aac9b2
    Reviewed-on: https://chromium-review.googlesource.com/c/1366835
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614621}

    Changed files

    • components/previews/content/previews_decider_impl.cc
    • components/previews/content/previews_decider_impl_unittest.cc
    • components/previews/core/previews_black_list.h
    • components/previews/core/previews_logger.cc
    • tools/metrics/histograms/enums.xml
  3. Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused

    Changed by Kinuko Yasuda - kinukoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:09:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1eb8373104f00c0ca44780a28d621dd6cf2f603

    Comments

    Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused
    
    This field was added before to keep the copy of the bundle around in
    RFHI but not really used any more.
    
    Bug: N/A
    Change-Id: Ib007ee7dc941b980bab3ad92a1de016ad14d155c
    Reviewed-on: https://chromium-review.googlesource.com/c/1365052
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614620}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h