Builder WebRTC Chromium Win8 Tester
Build 2634
Results:
Success
Trigger Info:
Project | chromium |
Revision | 09172250ca38c52d53b8592502eceea012d50329 |
Got Revision | 09172250ca38c52d53b8592502eceea012d50329 |
Execution:
- Source: Task 42f81071683c8010
- Bot: build14-b9
- Recipe: chromium
Steps and Logfiles:
Show:-
- - no logs -
-
( 186 ms ) read test spec (chromium.webrtc.json)path: c:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.webrtc.json
-
( 336 ms ) lookup builder GN argscom_init_check_hook_disabled = trueffmpeg_branding = "Chrome"is_component_build = falseis_debug = falseproprietary_codecs = truestrip_absolute_paths_from_debug_symbols = truesymbol_level = 1target_cpu = "x86"use_goma = truegoma_dir = "c:\\b\\s\\w\\ir\\cache\\goma\\client"
-
- - no logs -
-
( 27 mins 29 secs ) browser_testsbrowser_tests<div class="BuildResultInfo">Compositor Picking Frame Latency Max: 11.0kCompositor Picking Frame Latency Max: 13.7kCompositor Picking Frame Latency Max: 15.7kCompositor Picking Frame Latency Max: 16.6kCompositor Picking Frame Latency Max: 17.7kCompositor Picking Frame Latency Max: 18.6kCompositor Picking Frame Latency Max: 18.9kCompositor Picking Frame Latency Max: 19.1kCompositor Picking Frame Latency Max: 19.3kCompositor Picking Frame Latency Max: 22.7kCompositor Picking Frame Latency Max: 27.0kCompositor Picking Frame Latency Max: 31.0kCompositor Picking Frame Latency Max: 4.35kCompositor Picking Frame Latency Max: 7.61kCompositor Picking Frame Latency Max: 7.61kCompositor Picking Frame Latency Max: 8.22kCompositor Picking Frame Latency Mean: 1.58kCompositor Picking Frame Latency Mean: 231Compositor Picking Frame Latency Mean: 294Compositor Picking Frame Latency Mean: 316Compositor Picking Frame Latency Mean: 324Compositor Picking Frame Latency Mean: 339Compositor Picking Frame Latency Mean: 6.76kCompositor Picking Frame Latency Mean: 625Compositor Picking Frame Latency Mean: 698Compositor Picking Frame Latency Mean: 7.1kCompositor Picking Frame Latency Mean: 7.28kCompositor Picking Frame Latency Mean: 7.2kCompositor Picking Frame Latency Mean: 7.39kCompositor Picking Frame Latency Mean: 7.54kCompositor Picking Frame Latency Mean: 7.55kCompositor Picking Frame Latency Mean: 8.58kCompositor Resource Preparation Latency Max: 1.01kCompositor Resource Preparation Latency Max: 1.02kCompositor Resource Preparation Latency Max: 1.05kCompositor Resource Preparation Latency Max: 1.42kCompositor Resource Preparation Latency Max: 1.49kCompositor Resource Preparation Latency Max: 1.52kCompositor Resource Preparation Latency Max: 1.67kCompositor Resource Preparation Latency Max: 1.77kCompositor Resource Preparation Latency Max: 2.68kCompositor Resource Preparation Latency Max: 2.94kCompositor Resource Preparation Latency Max: 3.99kCompositor Resource Preparation Latency Max: 471Compositor Resource Preparation Latency Max: 759Compositor Resource Preparation Latency Max: 8.97kCompositor Resource Preparation Latency Max: 856Compositor Resource Preparation Latency Max: 972Compositor Resource Preparation Latency Mean: 1.11kCompositor Resource Preparation Latency Mean: 1.14kCompositor Resource Preparation Latency Mean: 231Compositor Resource Preparation Latency Mean: 231Compositor Resource Preparation Latency Mean: 273Compositor Resource Preparation Latency Mean: 274Compositor Resource Preparation Latency Mean: 373Compositor Resource Preparation Latency Mean: 378Compositor Resource Preparation Latency Mean: 416Compositor Resource Preparation Latency Mean: 434Compositor Resource Preparation Latency Mean: 463Compositor Resource Preparation Latency Mean: 494Compositor Resource Preparation Latency Mean: 562Compositor Resource Preparation Latency Mean: 589Compositor Resource Preparation Latency Mean: 893Compositor Resource Preparation Latency Mean: 911Passing to Render Algorithm Latency Max: 1.15kPassing to Render Algorithm Latency Max: 1.29kPassing to Render Algorithm Latency Max: 1.2kPassing to Render Algorithm Latency Max: 1.47kPassing to Render Algorithm Latency Max: 1.63kPassing to Render Algorithm Latency Max: 15.6kPassing to Render Algorithm Latency Max: 2.63kPassing to Render Algorithm Latency Max: 2.72kPassing to Render Algorithm Latency Max: 281Passing to Render Algorithm Latency Max: 3.23kPassing to Render Algorithm Latency Max: 4.03kPassing to Render Algorithm Latency Max: 4.25kPassing to Render Algorithm Latency Max: 4.83kPassing to Render Algorithm Latency Max: 671Passing to Render Algorithm Latency Max: 7.19kPassing to Render Algorithm Latency Max: 8.31kPassing to Render Algorithm Latency Mean: 112Passing to Render Algorithm Latency Mean: 137Passing to Render Algorithm Latency Mean: 200Passing to Render Algorithm Latency Mean: 250Passing to Render Algorithm Latency Mean: 334Passing to Render Algorithm Latency Mean: 43.0Passing to Render Algorithm Latency Mean: 43.0Passing to Render Algorithm Latency Mean: 45.0Passing to Render Algorithm Latency Mean: 505Passing to Render Algorithm Latency Mean: 796Passing to Render Algorithm Latency Mean: 81.0Passing to Render Algorithm Latency Mean: 81.0Passing to Render Algorithm Latency Mean: 82.0Passing to Render Algorithm Latency Mean: 905Passing to Render Algorithm Latency Mean: 93.0Passing to Render Algorithm Latency Mean: 93.0Render Algorithm Latency Max: 1.58kRender Algorithm Latency Max: 1.83kRender Algorithm Latency Max: 16.5kRender Algorithm Latency Max: 16.9kRender Algorithm Latency Max: 2.98kRender Algorithm Latency Max: 21.1kRender Algorithm Latency Max: 21.6kRender Algorithm Latency Max: 22.0kRender Algorithm Latency Max: 22.3kRender Algorithm Latency Max: 24.0kRender Algorithm Latency Max: 3.74kRender Algorithm Latency Max: 33.4kRender Algorithm Latency Max: 4.96kRender Algorithm Latency Max: 592Render Algorithm Latency Max: 6.75kRender Algorithm Latency Max: 787Render Algorithm Latency Mean: 190Render Algorithm Latency Mean: 27.0Render Algorithm Latency Mean: 281Render Algorithm Latency Mean: 42.0Render Algorithm Latency Mean: 5.14kRender Algorithm Latency Mean: 6.08kRender Algorithm Latency Mean: 6.0kRender Algorithm Latency Mean: 6.3kRender Algorithm Latency Mean: 6.48kRender Algorithm Latency Mean: 6.96kRender Algorithm Latency Mean: 7.56kRender Algorithm Latency Mean: 7.68kRender Algorithm Latency Mean: 71.0Render Algorithm Latency Mean: 74.0Render Algorithm Latency Mean: 76.0Render Algorithm Latency Mean: 91.0Skipped frames: 0.0Skipped frames: 0.0Skipped frames: 0.0Skipped frames: 2.0Skipped frames: 3.33Skipped frames: 31.2Skipped frames: 33.8Skipped frames: 34.1Skipped frames: 34.8Skipped frames: 35.0Skipped frames: 35.3Skipped frames: 39.1Skipped frames: 42.3Skipped frames: 670mSkipped frames: 670mSkipped frames: 670mTotal Controlled Latency Max: 11.6kTotal Controlled Latency Max: 16.6kTotal Controlled Latency Max: 18.0kTotal Controlled Latency Max: 20.9kTotal Controlled Latency Max: 23.5kTotal Controlled Latency Max: 27.7kTotal Controlled Latency Max: 31.6kTotal Controlled Latency Max: 32.6kTotal Controlled Latency Max: 35.4kTotal Controlled Latency Max: 37.4kTotal Controlled Latency Max: 37.6kTotal Controlled Latency Max: 42.5kTotal Controlled Latency Max: 43.3kTotal Controlled Latency Max: 5.78kTotal Controlled Latency Max: 8.46kTotal Controlled Latency Max: 8.77kTotal Controlled Latency Mean: 1.1kTotal Controlled Latency Mean: 1.24kTotal Controlled Latency Mean: 1.37kTotal Controlled Latency Mean: 1.46kTotal Controlled Latency Mean: 12.5kTotal Controlled Latency Mean: 2.13kTotal Controlled Latency Mean: 2.54kTotal Controlled Latency Mean: 2.66kTotal Controlled Latency Mean: 5.68kTotal Controlled Latency Mean: 7.6kTotal Controlled Latency Mean: 7.84kTotal Controlled Latency Mean: 8.37kTotal Controlled Latency Mean: 8.65kTotal Controlled Latency Mean: 8.89kTotal Controlled Latency Mean: 9.19kTotal Controlled Latency Mean: 9.29kTotal Latency Max: 17.5kTotal Latency Max: 18.1kTotal Latency Max: 18.3kTotal Latency Max: 20.9kTotal Latency Max: 22.1kTotal Latency Max: 23.6kTotal Latency Max: 25.0kTotal Latency Max: 25.4kTotal Latency Max: 27.7kTotal Latency Max: 31.6kTotal Latency Max: 37.1kTotal Latency Max: 37.5kTotal Latency Max: 37.6kTotal Latency Max: 42.6kTotal Latency Max: 43.3kTotal Latency Max: 46.3kTotal Latency Mean: 10.1kTotal Latency Mean: 10.8kTotal Latency Mean: 12.8kTotal Latency Mean: 7.18kTotal Latency Mean: 7.62kTotal Latency Mean: 7.72kTotal Latency Mean: 7.76kTotal Latency Mean: 7.88kTotal Latency Mean: 8.12kTotal Latency Mean: 8.56kTotal Latency Mean: 8.72kTotal Latency Mean: 8.96kTotal Latency Mean: 9.05kTotal Latency Mean: 9.28kTotal Latency Mean: 9.36kTotal Latency Mean: 9.62kVsync Latency Max: 16.9kVsync Latency Max: 2.78kVsync Latency Max: 2.81kVsync Latency Max: 2.99kVsync Latency Max: 28.9kVsync Latency Max: 29.8kVsync Latency Max: 3.11kVsync Latency Max: 3.22kVsync Latency Max: 31.1kVsync Latency Max: 31.1kVsync Latency Max: 31.8kVsync Latency Max: 36.0kVsync Latency Max: 4.13kVsync Latency Max: 4.13kVsync Latency Max: 5.2kVsync Latency Max: 6.75kVsync Latency Mean: 1.01kVsync Latency Mean: 1.04kVsync Latency Mean: 2.02kVsync Latency Mean: 2.06kVsync Latency Mean: 415Vsync Latency Mean: 445Vsync Latency Mean: 459Vsync Latency Mean: 476Vsync Latency Mean: 505Vsync Latency Mean: 550Vsync Latency Mean: 741Vsync Latency Mean: 776Vsync Latency Mean: 803Vsync Latency Mean: 863Vsync Latency Mean: 961Vsync Latency Mean: 986</div>
- stdout
- video_cpu_usage_H264-summary.dat
- video_rx_H264-summary.dat
- audio_PCMU-summary.dat
- getStats_promise-summary.dat
- video_rx_VP8-summary.dat
- audio_PCMA-summary.dat
- TestVideoDisplayPerfVP9_720p60f-summary.dat
- audio_misc-summary.dat
- getStats_callback-summary.dat
- TestVideoDisplayPerfVP9_1080p30f-summary.dat
- TestVideoDisplayPerfVP9_720p30f_DisableSmoothness-summary.dat
- video_resolution_VP9p2-summary.dat
- Max_skipped-summary.dat
- TestVideoDisplayPerfH264_720p60f-summary.dat
- TestVideoDisplayPerfH264_1080p60f-summary.dat
- audio_ISAC-summary.dat
- bwe_stats_H264-summary.dat
- bwe_stats_recvonly-summary.dat
- TestVideoDisplayPerfVP9_1080p60f_DisableSmoothness-summary.dat
- video_cpu_usage_VP9-summary.dat
- bwe_stats_recvonly_with_opus_dtx-summary.dat
- TestVideoDisplayPerfH264_1080p60f_DisableSmoothness-summary.dat
- video_VP9-summary.dat
- video_VP9p2-summary.dat
- TestVideoDisplayPerfH264_1080p30f_DisableSmoothness-summary.dat
- Decode_errors_test-summary.dat
- audio_rates-summary.dat
- video_cpu_usage_VP8-summary.dat
- TestVideoDisplayPerfH264_720p30f-summary.dat
- TestVideoDisplayPerfVP9_1080p30f_DisableSmoothness-summary.dat
- TestVideoDisplayPerfVP9_720p30f-summary.dat
- audio_opus-summary.dat
- Total_skipped-summary.dat
- video_misc_VP9p2-summary.dat
- TestVideoDisplayPerfVP9_1080p60f-summary.dat
- bwe_stats_sendonly_with_opus_dtx-summary.dat
- Unique_frames_count-summary.dat
- video_fps_VP9p2-summary.dat
- video_resolution_H264-summary.dat
- bwe_stats_sendonly-summary.dat
- video_tx_VP8-summary.dat
- TestVideoDisplayPerfH264_1080p30f-summary.dat
- Decode_errors_reference-summary.dat
- video_fps_H264-summary.dat
- TestVideoDisplayPerfH264_720p60f_DisableSmoothness-summary.dat
- video_H264-summary.dat
- video_VP8-summary.dat
- video_fps_VP8-summary.dat
- TestVideoDisplayPerfH264_720p30f_DisableSmoothness-summary.dat
- TestVideoDisplayPerfVP9_720p60f_DisableSmoothness-summary.dat
- bwe_stats_VP9-summary.dat
- video_tx_VP9-summary.dat
- bwe_stats_VP9p2-summary.dat
- video_tx_H264-summary.dat
- PSNR-summary.dat
- video_resolution_VP8-summary.dat
- video_cpu_usage_VP9p2-summary.dat
- bwe_stats_VP8-summary.dat
- audio_tx-summary.dat
- SSIM-summary.dat
- video_misc_VP9-summary.dat
- video_tx_VP9p2-summary.dat
- audio_G722-summary.dat
- video_misc_H264-summary.dat
- graphs.dat
- video_rx_VP9p2-summary.dat
- video_resolution_VP9-summary.dat
- video_fps_VP9-summary.dat
- audio_rx-summary.dat
- video-summary.dat
- video_misc_VP8-summary.dat
- Max_repeated-summary.dat
- video_rx_VP9-summary.dat
-
- - no logs -
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/buildbucket | {"build": {"builder": {"bucket": "webrtc", "builder": "WebRTC Chromium Win8 Tester", "project": "chromium"}, "createTime": "2019-02-12T01:07:48.312503Z", "createdBy": "user:luci-scheduler@appspot.gserviceaccount.com", "id": "8921770469774342832", "infra": {"buildbucket": {"serviceConfigRevision": "ef156230f5cd7f8c23f689fa4dc7f92742cd904d"}, "recipe": {"cipdPackage": "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build", "name": "chromium"}, "swarming": {"hostname": "chromium-swarm.appspot.com"}}, "input": {"gitilesCommit": {"host": "chromium.googlesource.com", "id": "09172250ca38c52d53b8592502eceea012d50329", "project": "chromium/src", "ref": "refs/heads/master"}}, "number": 2634, "tags": [{"key": "builder", "value": "WebRTC Chromium Win8 Tester"}, {"key": "buildset", "value": "commit/gitiles/chromium.googlesource.com/chromium/src/+/09172250ca38c52d53b8592502eceea012d50329"}, {"key": "parent_buildername", "value": "WebRTC Chromium Win Builder"}, {"key": "parent_buildnumber", "value": "5946"}, {"key": "scheduler_invocation_id", "value": "9087200532539551696"}, {"key": "scheduler_job_id", "value": "chromium/WebRTC Chromium Win8 Tester"}, {"key": "user_agent", "value": "luci-scheduler"}, {"key": "user_agent", "value": "recipe"}]}} | setup_build |
$recipe_engine/path | {"cache_dir": "c:\\b\\s\\w\\ir\\cache", "temp_dir": "c:\\b\\s\\w\\ir\\tmp\\rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "build14-b9" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.webrtc", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1549933668312503, "id": "8921770469774342832", "project": "chromium", "tags": ["build_address:luci.chromium.webrtc/WebRTC Chromium Win8 Tester/2634", "builder:WebRTC Chromium Win8 Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/09172250ca38c52d53b8592502eceea012d50329", "gitiles_ref:refs/heads/master", "parent_buildername:WebRTC Chromium Win Builder", "parent_buildnumber:5946", "scheduler_invocation_id:9087200532539551696", "scheduler_job_id:chromium/WebRTC Chromium Win8 Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "WebRTC Chromium Win8 Tester" | setup_build |
buildnumber | 2634 | setup_build |
mastername | "chromium.webrtc" | setup_build |
parent_buildername | "WebRTC Chromium Win Builder" | setup_build |
parent_got_angle_revision | "6b695c3ffb27ad1df71f4f1682dc7a1d8adc9f31" | setup_build |
parent_got_dawn_revision | "62e83971caa1099bdbc334817efa035047c90ddf" | setup_build |
parent_got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | setup_build |
parent_got_revision | "09172250ca38c52d53b8592502eceea012d50329" | setup_build |
parent_got_revision_cp | "refs/heads/master@{#631016}" | setup_build |
parent_got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | setup_build |
parent_got_v8_revision | "872455b5fe0cf1f09eb5550fb1e0bdd259523e8b" | setup_build |
parent_got_v8_revision_cp | "refs/heads/7.4.138@{#1}" | setup_build |
parent_got_webrtc_revision | "f13c2cd9ee41f4ca572232a4e397b05449474632" | setup_build |
parent_got_webrtc_revision_cp | "refs/heads/master@{#26626}" | setup_build |
parent_mastername | "chromium.webrtc" | setup_build |
path_config | "generic" | setup_build |
perf_dashboard_machine_group | "ChromiumWebRTC" | setup_build |
recipe | "chromium" | setup_build |
revision | "09172250ca38c52d53b8592502eceea012d50329" | setup_build |
swarm_hashes | {"browser_tests": "92d286a67c630ed4c32fd74e6fcd80c60414b662", "browser_tests_apprtc": "fb2897198eafa8d6dc84eac8624113caa919e0f3", "content_browsertests": "7dc9be5a541f69353752a9677266dcc58f1a30a8", "content_unittests": "0cce03a315e4e6ecb27050d536b0643f192ae539", "jingle_unittests": "ceb14d962749f8f6ec832950befc644f22b258ce", "remoting_unittests": "25a15ddf7805641949859419ae4f18be5f9fedd2"} | setup_build |
got_angle_revision | "6b695c3ffb27ad1df71f4f1682dc7a1d8adc9f31" | bot_update |
got_dawn_revision | "62e83971caa1099bdbc334817efa035047c90ddf" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "09172250ca38c52d53b8592502eceea012d50329" | bot_update |
got_revision_cp | "refs/heads/master@{#631016}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "872455b5fe0cf1f09eb5550fb1e0bdd259523e8b" | bot_update |
got_v8_revision_cp | "refs/heads/7.4.138@{#1}" | bot_update |
got_webrtc_revision | "f13c2cd9ee41f4ca572232a4e397b05449474632" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26626}" | bot_update |
swarm_hashes | {"browser_tests": "92d286a67c630ed4c32fd74e6fcd80c60414b662", "browser_tests_apprtc": "fb2897198eafa8d6dc84eac8624113caa919e0f3", "content_browsertests": "7dc9be5a541f69353752a9677266dcc58f1a30a8", "content_unittests": "0cce03a315e4e6ecb27050d536b0643f192ae539", "jingle_unittests": "ceb14d962749f8f6ec832950befc644f22b258ce", "remoting_unittests": "25a15ddf7805641949859419ae4f18be5f9fedd2"} | find isolated tests |
Blamelist:
- Rob Buis (rbuisohnoyoudont@igalia.com)
- Aga Wronska (agawronskaohnoyoudont@chromium.org)
- Brandon Wylie (wyliebohnoyoudont@chromium.org)
- Scott Violet (skyohnoyoudont@chromium.org)
- jdoerrie (jdoerrieohnoyoudont@chromium.org)
- Robbie McElrath (rmcelrathohnoyoudont@chromium.org)
- Zhongyi Shi (zhongyiohnoyoudont@chromium.org)
- Jazz Xu (jazzhsuohnoyoudont@chromium.org)
- Ken Rockot (rockotohnoyoudont@google.com)
- v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- Andrey Kosyakov (caseqohnoyoudont@chromium.org)
- Peter Mayo (petermayoohnoyoudont@chromium.org)
- Jun Cai (juncaiohnoyoudont@chromium.org)
- Nick Harper (nharperohnoyoudont@chromium.org)
- Dominic Farolino (domfarolinoohnoyoudont@gmail.com)
- Sammie Quon (sammiequonohnoyoudont@google.com)
- Daniel Rubery (druberyohnoyoudont@chromium.org)
- Suman Kancherla (sumankancherlaohnoyoudont@chromium.org)
Timing:
Create | Tuesday, 12-Feb-19 01:07:48 UTC |
Start | Tuesday, 12-Feb-19 01:07:52 UTC |
End | Tuesday, 12-Feb-19 01:41:21 UTC |
Pending | 4 secs |
Execution | 33 mins 29 secs |
All Changes:
-
Fix spec reference
Changed by Rob Buis - rbuisohnoyoudont@igalia.com Changed at Tuesday, 12-Feb-19 00:45:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 09172250ca38c52d53b8592502eceea012d50329 Comments
Fix spec reference The reference changed to be version neutral. Bug: 803774 Change-Id: Ia42664ef48867f1e4eace73b1cb787a6bd4250fa Reviewed-on: https://chromium-review.googlesource.com/c/1461880 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#631016}
Changed files
- content/browser/web_package/signed_exchange_envelope.cc
-
child user: Add parent_access namespace and rename objects inside it.
Changed by Aga Wronska - agawronskaohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:44:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision dadc56a8e7575345feed8a24e6a62616068693e2 Comments
child user: Add parent_access namespace and rename objects inside it. Prefixing class names with ParentAccessCode led to too much verbosity in the code and file names. Addning new namspace fixes that. Name changes made: ParentAccessCode -> parent_access::AccessCode ParentAccessCodeConfig -> parent_access::AccessCodeConfig ParentAccessCodeAuthenticator -> parent_access::Authenticator Change-Id: I186e2c12c5b555845c97b27838cbd17da62c6f1c Reviewed-on: https://chromium-review.googlesource.com/c/1461347 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#631015}
Changed files
- chrome/browser/chromeos/BUILD.gn
- chrome/browser/chromeos/child_accounts/parent_access_code/authenticator.cc
- chrome/browser/chromeos/child_accounts/parent_access_code/authenticator.h
- chrome/browser/chromeos/child_accounts/parent_access_code/authenticator_unittest.cc
- chrome/browser/chromeos/child_accounts/parent_access_code/parent_access_code_authenticator.h
-
[Image Fetcher] Add feature-specific metrics reporting
Changed by Brandon Wylie - wyliebohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:43:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f8a51e47b971ecec47b44fcf85dca912d4b0e52a Comments
[Image Fetcher] Add feature-specific metrics reporting Adds a required client name for ImageFetcher calls. The client name is used to report to client-specific histograms. These will be used to determine how much each feature contributes to: - Disk usage - Cache utilization - Fetch/decode times These factors will be used to make informed decisions about which features benefit from caching. Bug: 916722 Change-Id: I22101ebc973eb5f58e8794345065b1983c95b2d7 Reviewed-on: https://chromium-review.googlesource.com/c/1393671 Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Kyle Milka <kmilka@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Ganggui Tang <gogerald@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#631014}
Changed files
- chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedImageLoader.java
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/details/AssistantDetailsViewBinder.java
- chrome/android/java/src/org/chromium/chrome/browser/cached_image_fetcher/CachedImageFetcher.java
- chrome/android/java/src/org/chromium/chrome/browser/cached_image_fetcher/CachedImageFetcherBridge.java
- chrome/android/java/src/org/chromium/chrome/browser/cached_image_fetcher/CachedImageFetcherImpl.java
- chrome/android/java/src/org/chromium/chrome/browser/cached_image_fetcher/InMemoryCachedImageFetcher.java
- chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsSourceImpl.java
- chrome/android/junit/src/org/chromium/chrome/browser/cached_image_fetcher/CachedImageFetcherImplTest.java
- chrome/android/junit/src/org/chromium/chrome/browser/cached_image_fetcher/InMemoryCachedImageFetcherTest.java
- chrome/android/junit/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsSourceImplTest.java
- chrome/browser/android/cached_image_fetcher/cached_image_fetcher_bridge.cc
- chrome/browser/android/cached_image_fetcher/cached_image_fetcher_bridge.h
- chrome/browser/android/explore_sites/explore_sites_bridge_experimental.cc
- chrome/browser/search/ntp_icon_source.cc
- chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc
- components/favicon/core/large_icon_service_impl.cc
- components/feed/core/feed_image_manager.cc
- components/image_fetcher/core/cache/BUILD.gn
- components/image_fetcher/core/cache/cached_image_fetcher_metrics_reporter.cc
- components/image_fetcher/core/cache/cached_image_fetcher_metrics_reporter.h
- components/image_fetcher/core/cache/cached_image_fetcher_metrics_reporter_unittest.cc
- components/image_fetcher/core/cache/image_cache.cc
- components/image_fetcher/core/cached_image_fetcher.cc
- components/image_fetcher/core/cached_image_fetcher.h
- components/image_fetcher/core/cached_image_fetcher_unittest.cc
- components/image_fetcher/core/image_fetcher.cc
- components/image_fetcher/core/image_fetcher.h
- components/image_fetcher/core/image_fetcher_impl_unittest.cc
- components/image_fetcher/core/mock_image_fetcher.h
- components/ntp_snippets/remote/cached_image_fetcher.cc
- components/ntp_tiles/icon_cacher_impl.cc
- components/offline_pages/core/prefetch/thumbnail_fetch_by_url.cc
- components/signin/core/browser/account_fetcher_service.cc
- ios/chrome/browser/passwords/notify_auto_signin_view_controller.mm
- tools/metrics/histograms/histograms.xml
-
chromeos: removes quick_launch
Changed by Scott Violet - skyohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:39:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1e6329e9a5e04d4921947c7c27dcee252452a406 Comments
chromeos: removes quick_launch And the mash directory. These aren't useful, and having these around means we need some unnecessary complexity. I converted the one that test that was using these to instead launch shortcut_viewer. BUG=none TEST=none Change-Id: I6aff493bfd560c8c93dba496690313c715a8cf06 Reviewed-on: https://chromium-review.googlesource.com/c/1462116 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#631013}
Changed files
- ash/BUILD.gn
- ash/DEPS
- ash/accelerators/accelerator_controller.cc
- ash/accelerators/accelerator_table.cc
- ash/accelerators/accelerator_table_unittest.cc
- ash/accelerators/debug_commands.cc
- ash/app_launch_unittest.cc
- ash/components/quick_launch/BUILD.gn
- ash/components/quick_launch/DEPS
- ash/components/quick_launch/main.cc
- ash/components/quick_launch/public/cpp/BUILD.gn
- ash/components/quick_launch/public/cpp/OWNERS
- ash/components/quick_launch/public/cpp/manifest.cc
- ash/components/quick_launch/public/cpp/manifest.h
- ash/components/quick_launch/public/mojom/BUILD.gn
- ash/components/quick_launch/public/mojom/OWNERS
- ash/components/quick_launch/public/mojom/constants.mojom
- ash/components/quick_launch/quick_launch_application.cc
- ash/components/quick_launch/quick_launch_application.h
- ash/public/cpp/BUILD.gn
- ash/public/cpp/DEPS
- ash/public/cpp/accelerators.h
- ash/public/cpp/manifest.cc
- ash/shell/content/client/DEPS
- ash/shell/content/client/shell_browser_main_parts.cc
- ash/shell/content/client/shell_content_browser_client.cc
- ash/shell/content/client/shell_main_delegate.cc
- ash/system/flag_warning/flag_warning_tray.cc
- chrome/app/BUILD.gn
- chrome/app/DEPS
- chrome/app/chrome_packaged_service_manifests.cc
- chrome/app/chromeos_strings.grdp
- chrome/browser/BUILD.gn
- chrome/browser/DEPS
- chrome/browser/ash_service_registry.cc
- chrome/browser/chrome_service.cc
- chrome/browser/chromeos/BUILD.gn
- chrome/browser/chromeos/accessibility/accessibility_manager.cc
- chrome/browser/chromeos/launchable.cc
- chrome/browser/chromeos/launchable.h
- chrome/browser/ui/BUILD.gn
- chrome/browser/ui/ash/DEPS
- chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_metadata_unittest.cc
- chrome/browser/ui/ash/shortcut_viewer_browsertest.cc
- chrome/test/BUILD.gn
- chrome/test/base/in_process_browser_test.h
- chrome/utility/BUILD.gn
- chrome/utility/DEPS
- chrome/utility/mash_service_factory.cc
- mash/OWNERS
- mash/public/mojom/BUILD.gn
- mash/public/mojom/OWNERS
- mash/public/mojom/launchable.mojom
-
[Passwords] Add Field Trial Testing Config for HTTP FOAS Experiment
Changed by jdoerrie - jdoerrieohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:39:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 59c19d8e9f26e2ec065e56d188432be131f6cb4f Comments
[Passwords] Add Field Trial Testing Config for HTTP FOAS Experiment This change adds a Field Trial Testing Configuration for the Fill On Account Select over HTTP Experiment. Bug: 914765 Change-Id: I4271c3c4c5cdec403e52815a077f384de7042957 Reviewed-on: https://chromium-review.googlesource.com/c/1463445 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#631012}
Changed files
- chrome/browser/password_manager/password_manager_browsertest.cc
- testing/variations/fieldtrial_testing_config.json
-
Deflake ZipFiles/FilesAppBrowserTest.Test/zipFileOpenDownloads_GuestMode
Changed by Robbie McElrath - rmcelrathohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:38:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d755a8cf625f40b2b2a4c7e96adb8337b135aa68 Comments
Deflake ZipFiles/FilesAppBrowserTest.Test/zipFileOpenDownloads_GuestMode The issue with this test is a bit hard to explain, so I'll start by giving some background on FileSystemContext/FileSystemOperationRunner, then on FileSystemFileURLLoader, and then on their racy interaction that causes the test to be flaky. StoragePartitionImpl contains a scoped_refptr to a FileSystemContext, which contains helpers and information about the file system. One of these helpers is a unique_ptr to a FileSystemOperationRunner, which as the name implies, manages running operations on the file system (create, delete, write, etc..). When you ask the FileSystemOperationRunner to perform an operation, you give it a callback and whatever else it needs, and then it starts the operation and keeps some metadata about it keyed by an OperationId. This metadata contains a scoped_refptr to the FileSystemContext that owns the FileSystemOperationRunner. This reference ensures that while the operation is running, the FileSystemContext won't be deleted, which in turn keeps the runner alive until the operation is complete. When the underlying operation is done, the FileSystemOperationRunner will call the callback, and then clean up the metadata about the operation, removing the reference to the FileSystemContext in the process. This could potentially delete the FileSystemContext, but only after any pending work is complete. Meanwhile, when the network service is enabled, it installs a FileSystemFileURLLoader to handle requests to local files. This class's constructor takes a scoped_refptr to a FileSystemContext, which it uses to access the file system. When the FileSystemFileURLLoader serves a file, it will call GetMetadata on the FileSystemOperationRunner associated with the FileSystemContext it has a reference to, with its DidGetMetadata method as the callback. DidGetMetadata checks the error code and does something unimportant (for this CL) on success; however, on error it will tell the client the request is complete, delete the client ptr, and then delete itself. The last thing to know is that when a StoragePartitionImpl is being deleted, it calls FileSystemContext::Shutdown, which calls FileSystemOperationRunner::Shutdown, which clears the metadata map that contained the scoped_refptrs keeping the FileSystemContext alive during pending operations. In this test, the following sequence of events can happen: 1. Something requests a resource from disk, resulting in a FileSystemFileURLLoader being created, which starts a GetMetadata call on the StoragePartition's FileSystemOperationRunner. FileSystemOperationRunner will start the operation and add it to its map of pending operations. 2. The StoragePartition gets deleted, which calls FileSystemOperationRunner::Shutdown, which clears the pending operations map. Both the map and StoragePartitions' scoped_refptr to the FileSystemContext are now deleted. The only thing keeping the FileSystemContext alive is the FileSystemFileURLLoader. 3. The underlying GetMetadata operation completes (was aborted) and calls FileSystemOperationRunner::DidGetMetadata. This will call the completion callback, FileSystemFileURLLoader::DidGetMetadata, which will complete the request, and then delete itself, taking the last FileSystemContext reference with it. After the callback is called, FileSystemOperationRunner calls FinishOperation to clean up the GetMetadata operation, but the callback already deleted the runner, so FinishOperation segfaults. My initial thought was that callbacks shouldn't ever delete the object they were passed to, but I felt that this issue was subtle enough (to me at least) that it could come again even if we fixed this case. Instead, this CL makes the Did* completion callback methods in FileSystemOperationRunner take a reference to the FileSystemContext to make sure it won't be deleted until after it's done handling the operation. Bug: 930807 Change-Id: Ie35348697c4145aad73cbada3da604f878c1cf00 Reviewed-on: https://chromium-review.googlesource.com/c/1464647 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#631011}
Changed files
- storage/browser/fileapi/file_system_operation_runner.cc
-
Add an idle migration period to QuicChromiumClientSession.
Changed by Zhongyi Shi - zhongyiohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:37:40 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c16b410d1da4d55592c17f0ac4a0d109f4f6e796 Comments
Add an idle migration period to QuicChromiumClientSession. Sessions will only be migrated if its idle period is within this period. Bug: 929351 Change-Id: I18b919f679ee8ed06b40b832685a0e10b9c02a77 Reviewed-on: https://chromium-review.googlesource.com/c/1459072 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#631010}
Changed files
- net/http/http_network_session.cc
- net/http/http_network_session.h
- net/http/http_proxy_client_socket_wrapper_unittest.cc
- net/quic/bidirectional_stream_quic_impl_unittest.cc
- net/quic/quic_chromium_client_session.cc
- net/quic/quic_chromium_client_session.h
- net/quic/quic_chromium_client_session_test.cc
- net/quic/quic_http_stream_test.cc
- net/quic/quic_proxy_client_socket_unittest.cc
- net/quic/quic_stream_factory.cc
- net/quic/quic_stream_factory.h
- net/quic/quic_stream_factory_fuzzer.cc
- net/quic/quic_stream_factory_peer.cc
- net/quic/quic_stream_factory_peer.h
- net/quic/quic_stream_factory_test.cc
-
[CrOS Video Player] Search subtitle when loading video
Changed by Jazz Xu - jazzhsuohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:36:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 30b15dab03cc0048cd1780be12677a592a165011 Comments
[CrOS Video Player] Search subtitle when loading video Search .vtt subtitle with same name as video source, and attach to video in native controls. Bug: 909963 Change-Id: Ib4431de16e8a7ba78c0d9ea9e880884c5641047e Reviewed-on: https://chromium-review.googlesource.com/c/1418320 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#631009}
Changed files
- chrome/browser/chromeos/file_manager/video_player_browsertest.cc
- chrome/test/data/chromeos/file_manager/video.vtt
- ui/file_manager/integration_tests/test_util.js
- ui/file_manager/integration_tests/video_player/background.js
- ui/file_manager/integration_tests/video_player/open_video_files.js
- ui/file_manager/video_player/js/test_util.js
- ui/file_manager/video_player/js/video_player_native_controls.js
-
[SM] Use maps for Manifest capability data
Changed by Ken Rockot - rockotohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 00:36:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6cdde4d7f7f512864aa5dabde5327707e9a02bf3 Comments
[SM] Use maps for Manifest capability data This changes the service Manifest type to use maps and sets for underlying capability data storage rather than flat vectors of structures. This makes the type more useful to the Service Manager at runtime, and avoids having to build additional data structures from the manifests. Bug: 895616 Change-Id: I4e9354fd51a3a1e466c26a34b86a3358a31de7ab Reviewed-on: https://chromium-review.googlesource.com/c/1462140 Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#631008}
Changed files
- chrome/app/chrome_content_browser_overlay_manifest.cc
- services/catalog/entry_cache.cc
- services/service_manager/public/cpp/manifest.cc
- services/service_manager/public/cpp/manifest.h
- services/service_manager/public/cpp/manifest_builder.h
- services/service_manager/public/cpp/manifest_unittest.cc
-
Update V8 to version 7.4.138.
Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Tuesday, 12-Feb-19 00:35:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a57ea829912da80aa2ad3a6db61c384d7007cf6f Comments
Update V8 to version 7.4.138. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0e223be0..872455b5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3b3d615fb35fe50e85d1d5af38bc488bee0340bb Reviewed-on: https://chromium-review.googlesource.com/c/1464333 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#631007}
Changed files
- DEPS
-
DevTools: support binary protocol framing
Changed by Andrey Kosyakov - caseqohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:34:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 182039e1f62d2cdbb5ce2afe3fcf98dba20e29a1 Comments
DevTools: support binary protocol framing BUG=929862 This adds an optional parameter to --remote-debugging-pipe that lets caller specify cbor to use CBOR-compatible binary, as opposed to 0-terminated, framing for passing DevTools messages over the pipe. Change-Id: Iedadb66d14bb5e7a2c3cea855d4ff4bf4f5b88be Reviewed-on: https://chromium-review.googlesource.com/c/1460182 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#631006}
Changed files
- content/browser/devtools/devtools_pipe_handler.cc
- content/browser/devtools/devtools_pipe_handler.h
- content/public/common/content_switches.cc
-
[Sheriff] Ignore failing WPT target_blank_implicit_noopener.html
Changed by Peter Mayo - petermayoohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:33:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5c3a4fe24c1a01e8804cfa7024a6b64889000180 Comments
[Sheriff] Ignore failing WPT target_blank_implicit_noopener.html Updated WPT state from roll has different failures and passes from previous expectations TBR=foolip Bug: 930873 Change-Id: I2a5bb4a5c30225b1970c165b5b6e92fb7c9159a0 Reviewed-on: https://chromium-review.googlesource.com/c/1465059 Reviewed-by: Peter Mayo <petermayo@chromium.org> Reviewed-by: Katie Dektar <katie@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#631005}
Changed files
- third_party/blink/web_tests/TestExpectations
-
Network Service: Fix linux-perf-fyi perf histogam metrics' name issue
Changed by Jun Cai - juncaiohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:33:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision feeccd78af9d3bb162771ba973868379f64651b0 Comments
Network Service: Fix linux-perf-fyi perf histogam metrics' name issue Currently the histogram metrics' name all start with cold@@ or warm@@, This CL removes these prefixes so that the linux-perf-fyi dashboard can correctly parse these metrics. Bug: 930764 Change-Id: I12e8c14a841f327c0f094988186b5e8c73a73b12 Reviewed-on: https://chromium-review.googlesource.com/c/1464640 Reviewed-by: Simon Hatch <simonhatch@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#631004}
Changed files
- tools/perf/contrib/network_service/loading.py
-
Update bulk entries in HSTS preload list
Changed by Nick Harper - nharperohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:30:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 556a4c6185ea6868d054944dac44945db40ffa59 Comments
Update bulk entries in HSTS preload list TBR=bnc@chromium.org Change-Id: I16df7002e113f587d27e71cbd0a5c198976b0bb7 Reviewed-on: https://chromium-review.googlesource.com/c/1464203 Reviewed-by: Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#631003}
Changed files
- net/http/transport_security_state_static.json
-
Implement TextEncoder()'s encodeInto method
Changed by Dominic Farolino - domfarolinoohnoyoudont@gmail.com Changed at Tuesday, 12-Feb-19 00:23:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision aeb9424e0834afbd96b136974805e34dc39b1e66 Comments
Implement TextEncoder()'s encodeInto method This CL implements the encodeInto method on the TextEncoder interface, which encodes a string into a given pre-allocated Uint8Array. This CL introduces an EncodeInto() method to TextCodecUTF8, which acts similar to EncodeCommon(), however is bound by a given capacity, and also outputs the number of converted UTF16 code units. EncodeInto() is called via an overloaded TextCodec::Encode() method, which is meant only to be implemented in TextCodecUTF8 (since that is only where EncodeInto() is used). Intent to Implement and Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/vTNMrsScW1g R=jsbell@chromium.org, kinuko@chromium.org, ricea@chromium.org Bug: 920107 Change-Id: I178f927e837833731049c4867c0eb71e90d369cc Reviewed-on: https://chromium-review.googlesource.com/c/1456637 Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#631002}
Changed files
- third_party/blink/public/platform/web_feature.mojom
- third_party/blink/renderer/modules/encoding/text_encoder.cc
- third_party/blink/renderer/modules/encoding/text_encoder.h
- third_party/blink/renderer/modules/encoding/text_encoder.idl
- third_party/blink/renderer/modules/encoding/text_encoder_encode_into_result.idl
- third_party/blink/renderer/modules/modules_idl_files.gni
- third_party/blink/renderer/platform/wtf/text/text_codec.h
- third_party/blink/renderer/platform/wtf/text/text_codec_utf8.cc
- third_party/blink/renderer/platform/wtf/text/text_codec_utf8.h
- third_party/blink/web_tests/external/wpt/encoding/encodeInto.any-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/encodeInto.any.worker-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/idlharness.any-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/idlharness.any.serviceworker-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/idlharness.any.sharedworker-expected.txt
- third_party/blink/web_tests/external/wpt/encoding/idlharness.any.worker-expected.txt
- third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
- third_party/blink/web_tests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
- third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
- third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
- third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
- third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
- third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
- third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt
- tools/metrics/histograms/enums.xml
-
overview: Introduce OverviewObserver.
Changed by Sammie Quon - sammiequonohnoyoudont@google.com Changed at Tuesday, 12-Feb-19 00:22:03 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c7d27a2942d2d3d8c018ee254dfb6dd43725a2f5 Comments
overview: Introduce OverviewObserver. Move overview ShellObserver methods to new class OverviewObserver. Test: none Bug: 914147 Change-Id: Ic0290fc9bd7e3144fc6939cc7833e008198a8ec1 Reviewed-on: https://chromium-review.googlesource.com/c/1461678 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#631001}
Changed files
- ash/BUILD.gn
- ash/accelerators/accelerator_unittest.cc
- ash/app_list/app_list_controller_impl.cc
- ash/app_list/app_list_controller_impl.h
- ash/frame/non_client_frame_view_ash.cc
- ash/frame/non_client_frame_view_ash.h
- ash/frame/wide_frame_view.cc
- ash/frame/wide_frame_view.h
- ash/shelf/shelf_layout_manager.cc
- ash/shelf/shelf_layout_manager.h
- ash/shell.cc
- ash/shell.h
- ash/shell_observer.h
- ash/system/overview/overview_button_tray.cc
- ash/system/overview/overview_button_tray.h
- ash/wm/overview/overview_controller.cc
- ash/wm/overview/overview_controller.h
- ash/wm/overview/overview_controller_unittest.cc
- ash/wm/overview/overview_observer.h
- ash/wm/overview/overview_session_unittest.cc
- ash/wm/splitview/split_view_controller.cc
- ash/wm/splitview/split_view_controller.h
- ash/wm/splitview/split_view_controller_unittest.cc
- ash/wm/tablet_mode/tablet_mode_observer.h
- ash/wm/tablet_mode/tablet_mode_window_manager.cc
- ash/wm/tablet_mode/tablet_mode_window_manager.h
- ash/wm/workspace/backdrop_controller.cc
- ash/wm/workspace/backdrop_controller.h
-
Reland "Don't send download pings if the download is cancelled"
Changed by Daniel Rubery - druberyohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:18:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 15338196c4b927b1c6f01f214f27873bbd137040 Comments
Reland "Don't send download pings if the download is cancelled" This reverts commit bb4a37675c5397ed15e27b9e2cafbc4b45e21b96. The previous version had the problem that RunUntilIdle() was running inconsistent amounts of tasks, which led to failed EXPECT_CALLs. I've removed the RunUntilIdle() by ensuring the CheckClientDownload always runs its callback, even when the download is destroyed. This is a minor behavior change, but doesn't seem to break anything (the download code doesn't assume the download item exists, so it handles the download destroyed case correctly). Change-Id: Ic036eefa5e1ad97be7bef72b172296112b077e11 Bug: 930372 Reviewed-on: https://chromium-review.googlesource.com/c/1460177 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#631000}
Changed files
- chrome/browser/safe_browsing/download_protection/check_client_download_request.cc
- chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
-
[ui/vr] Add timeout for in-head permissions prompt.
Changed by Suman Kancherla - sumankancherlaohnoyoudont@chromium.org Changed at Tuesday, 12-Feb-19 00:18:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 46e73c59ce5470b3b429f4b1b43376c91d419329 Comments
[ui/vr] Add timeout for in-head permissions prompt. Bug: 912759 Change-Id: I55b69f673d61a0ffa90127ea4e379407a7f9bf87 Reviewed-on: https://chromium-review.googlesource.com/c/1459325 Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#630999}
Changed files
- chrome/browser/vr/ui_host/vr_ui_host_impl.cc
- chrome/browser/vr/ui_host/vr_ui_host_impl.h