Builder WebRTC Chromium Mac Tester Build 2906

Overview

Results:

Failure browser_tests

Trigger Info:

Project	chromium
Revision	c7b902f044650dd46bc03f9b888bc818204b94f2
Got Revision	c7b902f044650dd46bc03f9b888bc818204b94f2

Execution:

Steps and Logfiles:

Show: Expanded Default Non-Green

( 437 ms ) setup_build
running recipe: "chromium"
- stdout
- run_recipe
( 364 ms ) report builders

running tester 'WebRTC Chromium Mac Tester' on master 'chromium.webrtc'
- stdout
- bots.json
( 2 mins 16 secs ) bot_update
[58GB/232GB used (25%)]
- stdout
- json.output
( 402 ms ) ensure_goma
- - no logs -
1. ( 402 ms ) ensure_installed
  - stdout
  - json.output
( 1 secs ) swarming.py --version
0.14
- stdout
( 219 ms ) ensure_installed
- stdout
- json.output
( 19 secs ) gclient runhooks
- stdout
( 3 secs ) get compile targets for scripts
- stdout
- json.output
( 323 ms ) read test spec (chromium.webrtc.json)
path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.webrtc.json
- stdout
- json.output
( 535 ms ) lookup builder GN args

ffmpeg_branding = "Chrome"
is_component_build = false
is_debug = false
proprietary_codecs = true
strip_absolute_paths_from_debug_symbols = true
use_goma = true
goma_dir = "/b/s/w/ir/cache/goma/client"
- stdout
( 1 secs ) build directory
- stdout
( 47 secs ) extract build
- stdout
( 270 ms ) explain extract build
- stdout
- why is this running?
( 489 ms ) find isolated tests
- stdout
- json.output
( 9 secs ) test_pre_run
- - no logs -
1. ( 1 secs ) [trigger] browser_tests_functional
  Run on OS: 'Mac-10.13'
2. ( 1 secs ) [trigger] browser_tests_apprtc
  Run on OS: 'Mac-10.13'
3. ( 1 secs ) [trigger] content_browsertests
  Run on OS: 'Mac-10.13'
4. ( 1 secs ) [trigger] content_browsertests_sequential
  Run on OS: 'Mac-10.13'
5. ( 1 secs ) [trigger] content_browsertests_stress
  Run on OS: 'Mac-10.13'
6. ( 1 secs ) [trigger] content_unittests
  Run on OS: 'Mac-10.13'
7. ( 1 secs ) [trigger] jingle_unittests
  Run on OS: 'Mac-10.13'
8. ( 1 secs ) [trigger] remoting_unittests
  Run on OS: 'Mac-10.13'
( 23 secs ) capture_unittests
capture_unittests
12 disabled
- stdout
( 2 secs ) Upload to test-results [capture_unittests]
- stdout
( 7 mins 9 secs ) browser_tests
browser_tests
<div class="BuildResultInfo">
Compositor Picking Frame Latency Max: 104k
Compositor Picking Frame Latency Max: 106k
Compositor Picking Frame Latency Max: 108k
Compositor Picking Frame Latency Max: 117k
Compositor Picking Frame Latency Max: 117k
Compositor Picking Frame Latency Max: 117k
Compositor Picking Frame Latency Max: 118k
Compositor Picking Frame Latency Max: 130k
Compositor Picking Frame Latency Max: 135k
Compositor Picking Frame Latency Max: 138k
Compositor Picking Frame Latency Max: 144k
Compositor Picking Frame Latency Max: 62.1k
Compositor Picking Frame Latency Max: 81.0k
Compositor Picking Frame Latency Max: 83.8k
Compositor Picking Frame Latency Max: 87.5k
Compositor Picking Frame Latency Max: 88.2k
Compositor Picking Frame Latency Mean: 19.1k
Compositor Picking Frame Latency Mean: 23.5k
Compositor Picking Frame Latency Mean: 24.4k
Compositor Picking Frame Latency Mean: 25.5k
Compositor Picking Frame Latency Mean: 25.9k
Compositor Picking Frame Latency Mean: 30.8k
Compositor Picking Frame Latency Mean: 30.9k
Compositor Picking Frame Latency Mean: 31.3k
Compositor Picking Frame Latency Mean: 31.7k
Compositor Picking Frame Latency Mean: 32.2k
Compositor Picking Frame Latency Mean: 32.5k
Compositor Picking Frame Latency Mean: 35.5k
Compositor Picking Frame Latency Mean: 36.2k
Compositor Picking Frame Latency Mean: 37.3k
Compositor Picking Frame Latency Mean: 41.6k
Compositor Picking Frame Latency Mean: 42.7k
Compositor Resource Preparation Latency Max: 127
Compositor Resource Preparation Latency Max: 130
Compositor Resource Preparation Latency Max: 134
Compositor Resource Preparation Latency Max: 138
Compositor Resource Preparation Latency Max: 152
Compositor Resource Preparation Latency Max: 154
Compositor Resource Preparation Latency Max: 169
Compositor Resource Preparation Latency Max: 172
Compositor Resource Preparation Latency Max: 173
Compositor Resource Preparation Latency Max: 180
Compositor Resource Preparation Latency Max: 184
Compositor Resource Preparation Latency Max: 184
Compositor Resource Preparation Latency Max: 187
Compositor Resource Preparation Latency Max: 192
Compositor Resource Preparation Latency Max: 235
Compositor Resource Preparation Latency Max: 475
Compositor Resource Preparation Latency Mean: 75.0
Compositor Resource Preparation Latency Mean: 77.0
Compositor Resource Preparation Latency Mean: 78.0
Compositor Resource Preparation Latency Mean: 78.0
Compositor Resource Preparation Latency Mean: 79.0
Compositor Resource Preparation Latency Mean: 82.0
Compositor Resource Preparation Latency Mean: 82.0
Compositor Resource Preparation Latency Mean: 83.0
Compositor Resource Preparation Latency Mean: 83.0
Compositor Resource Preparation Latency Mean: 84.0
Compositor Resource Preparation Latency Mean: 84.0
Compositor Resource Preparation Latency Mean: 87.0
Compositor Resource Preparation Latency Mean: 89.0
Compositor Resource Preparation Latency Mean: 90.0
Compositor Resource Preparation Latency Mean: 95.0
Compositor Resource Preparation Latency Mean: 95.0
Passing to Render Algorithm Latency Max: 1.27k
Passing to Render Algorithm Latency Max: 1.29k
Passing to Render Algorithm Latency Max: 2.89k
Passing to Render Algorithm Latency Max: 243
Passing to Render Algorithm Latency Max: 280
Passing to Render Algorithm Latency Max: 303
Passing to Render Algorithm Latency Max: 319
Passing to Render Algorithm Latency Max: 325
Passing to Render Algorithm Latency Max: 362
Passing to Render Algorithm Latency Max: 383
Passing to Render Algorithm Latency Max: 403
Passing to Render Algorithm Latency Max: 746
Passing to Render Algorithm Latency Max: 776
Passing to Render Algorithm Latency Max: 794
Passing to Render Algorithm Latency Max: 875
Passing to Render Algorithm Latency Max: 895
Passing to Render Algorithm Latency Mean: 173
Passing to Render Algorithm Latency Mean: 196
Passing to Render Algorithm Latency Mean: 205
Passing to Render Algorithm Latency Mean: 210
Passing to Render Algorithm Latency Mean: 212
Passing to Render Algorithm Latency Mean: 215
Passing to Render Algorithm Latency Mean: 217
Passing to Render Algorithm Latency Mean: 220
Passing to Render Algorithm Latency Mean: 553
Passing to Render Algorithm Latency Mean: 556
Passing to Render Algorithm Latency Mean: 581
Passing to Render Algorithm Latency Mean: 617
Passing to Render Algorithm Latency Mean: 717
Passing to Render Algorithm Latency Mean: 730
Passing to Render Algorithm Latency Mean: 803
Passing to Render Algorithm Latency Mean: 885
Render Algorithm Latency Max: 104k
Render Algorithm Latency Max: 104k
Render Algorithm Latency Max: 36.0
Render Algorithm Latency Max: 37.2k
Render Algorithm Latency Max: 40.1k
Render Algorithm Latency Max: 45.0
Render Algorithm Latency Max: 470
Render Algorithm Latency Max: 51.9k
Render Algorithm Latency Max: 55.8k
Render Algorithm Latency Max: 55.9k
Render Algorithm Latency Max: 60.0
Render Algorithm Latency Max: 69.0
Render Algorithm Latency Max: 73.0
Render Algorithm Latency Max: 77.0
Render Algorithm Latency Max: 86.5k
Render Algorithm Latency Max: 96.0
Render Algorithm Latency Mean: 2.03k
Render Algorithm Latency Mean: 2.34k
Render Algorithm Latency Mean: 2.47k
Render Algorithm Latency Mean: 2.61k
Render Algorithm Latency Mean: 2.79k
Render Algorithm Latency Mean: 29.0
Render Algorithm Latency Mean: 29.0
Render Algorithm Latency Mean: 33.0
Render Algorithm Latency Mean: 35.0
Render Algorithm Latency Mean: 35.0
Render Algorithm Latency Mean: 35.0
Render Algorithm Latency Mean: 37.0
Render Algorithm Latency Mean: 40.0
Render Algorithm Latency Mean: 7.22k
Render Algorithm Latency Mean: 7.93k
Render Algorithm Latency Mean: 8.59k
Skipped frames: 0.0
Skipped frames: 0.0
Skipped frames: 0.0
Skipped frames: 0.0
Skipped frames: 0.0
Skipped frames: 0.0
Skipped frames: 0.0
Skipped frames: 10.2
Skipped frames: 10.4
Skipped frames: 2.38
Skipped frames: 23.7
Skipped frames: 3.57
Skipped frames: 35.1
Skipped frames: 4.65
Skipped frames: 6.0
Skipped frames: 9.62
Total Controlled Latency Max: 105k
Total Controlled Latency Max: 108k
Total Controlled Latency Max: 109k
Total Controlled Latency Max: 117k
Total Controlled Latency Max: 117k
Total Controlled Latency Max: 118k
Total Controlled Latency Max: 121k
Total Controlled Latency Max: 131k
Total Controlled Latency Max: 136k
Total Controlled Latency Max: 140k
Total Controlled Latency Max: 145k
Total Controlled Latency Max: 64.0k
Total Controlled Latency Max: 83.4k
Total Controlled Latency Max: 84.7k
Total Controlled Latency Max: 89.6k
Total Controlled Latency Max: 90.1k
Total Controlled Latency Mean: 21.0k
Total Controlled Latency Mean: 24.4k
Total Controlled Latency Mean: 26.1k
Total Controlled Latency Mean: 27.2k
Total Controlled Latency Mean: 27.7k
Total Controlled Latency Mean: 31.8k
Total Controlled Latency Mean: 32.5k
Total Controlled Latency Mean: 32.7k
Total Controlled Latency Mean: 32.9k
Total Controlled Latency Mean: 33.0k
Total Controlled Latency Mean: 34.1k
Total Controlled Latency Mean: 37.1k
Total Controlled Latency Mean: 37.2k
Total Controlled Latency Mean: 38.3k
Total Controlled Latency Mean: 42.5k
Total Controlled Latency Mean: 43.6k
Total Latency Max: 105k
Total Latency Max: 105k
Total Latency Max: 108k
Total Latency Max: 109k
Total Latency Max: 117k
Total Latency Max: 117k
Total Latency Max: 118k
Total Latency Max: 121k
Total Latency Max: 131k
Total Latency Max: 136k
Total Latency Max: 140k
Total Latency Max: 145k
Total Latency Max: 64.0k
Total Latency Max: 83.5k
Total Latency Max: 89.7k
Total Latency Max: 90.2k
Total Latency Mean: 23.5k
Total Latency Mean: 27.7k
Total Latency Mean: 29.8k
Total Latency Mean: 32.6k
Total Latency Mean: 32.7k
Total Latency Mean: 33.0k
Total Latency Mean: 33.1k
Total Latency Mean: 33.3k
Total Latency Mean: 34.1k
Total Latency Mean: 34.6k
Total Latency Mean: 35.2k
Total Latency Mean: 37.2k
Total Latency Mean: 38.3k
Total Latency Mean: 43.6k
Total Latency Mean: 44.5k
Total Latency Mean: 45.0k
Vsync Latency Max: 1.09k
Vsync Latency Max: 1.11k
Vsync Latency Max: 1.14k
Vsync Latency Max: 1.19k
Vsync Latency Max: 1.27k
Vsync Latency Max: 1.32k
Vsync Latency Max: 1.33k
Vsync Latency Max: 1.53k
Vsync Latency Max: 1.67k
Vsync Latency Max: 2.31k
Vsync Latency Max: 2.4k
Vsync Latency Max: 874
Vsync Latency Max: 898
Vsync Latency Max: 900
Vsync Latency Max: 909
Vsync Latency Max: 992
Vsync Latency Mean: 569
Vsync Latency Mean: 599
Vsync Latency Mean: 606
Vsync Latency Mean: 607
Vsync Latency Mean: 627
Vsync Latency Mean: 640
Vsync Latency Mean: 667
Vsync Latency Mean: 676
Vsync Latency Mean: 860
Vsync Latency Mean: 867
Vsync Latency Mean: 890
Vsync Latency Mean: 892
Vsync Latency Mean: 958
Vsync Latency Mean: 976
Vsync Latency Mean: 984
Vsync Latency Mean: 989
</div>
- stdout
- TestVideoDisplayPerfVP9_720p30f_DisableSmoothness-summary.dat
- TestVideoDisplayPerfVP9_1080p30f_DisableSmoothness-summary.dat
- TestVideoDisplayPerfH264_1080p60f_DisableSmoothness-summary.dat
- TestVideoDisplayPerfVP9_720p60f_DisableSmoothness-summary.dat
- TestVideoDisplayPerfVP9_720p30f-summary.dat
- TestVideoDisplayPerfH264_720p60f_DisableSmoothness-summary.dat
- TestVideoDisplayPerfH264_1080p60f-summary.dat
- TestVideoDisplayPerfVP9_720p60f-summary.dat
- TestVideoDisplayPerfH264_720p30f-summary.dat
- graphs.dat
- TestVideoDisplayPerfH264_1080p30f_DisableSmoothness-summary.dat
- TestVideoDisplayPerfH264_720p60f-summary.dat
- TestVideoDisplayPerfH264_720p30f_DisableSmoothness-summary.dat
- video-summary.dat
- TestVideoDisplayPerfVP9_1080p60f-summary.dat
- TestVideoDisplayPerfH264_1080p30f-summary.dat
- TestVideoDisplayPerfVP9_1080p30f-summary.dat
- TestVideoDisplayPerfVP9_1080p60f_DisableSmoothness-summary.dat
( 2 secs ) Upload to test-results [browser_tests]
- stdout
( 1 secs ) wait for tasks
- stdout
- json.output
( 184 ms ) ensure swarming
- - no logs -
1. ( 184 ms ) ensure_installed
  - stdout
  - json.output
( 1 secs ) content_browsertests
Run on OS: 'Mac-10.13'
Shard duration: 0:01:14.076073
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (52.7 sec)
( 1 secs ) Upload to test-results [content_browsertests]
- stdout
( 1 secs ) jingle_unittests
Run on OS: 'Mac-10.13'
Shard duration: 12s
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (1.0 sec)
( 2 secs ) Upload to test-results [jingle_unittests]
- stdout
( 1 secs ) content_browsertests_stress
Run on OS: 'Mac-10.13'
Shard duration: 41s
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (15.5 sec)
( 2 secs ) Upload to test-results [content_browsertests_stress]
- stdout
( 1 secs ) remoting_unittests
Run on OS: 'Mac-10.13'
Shard duration: 17s
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (5.7 sec)
( 1 secs ) Upload to test-results [remoting_unittests]
- stdout
( 1 secs ) browser_tests_apprtc
Run on OS: 'Mac-10.13'
Shard duration: 0:01:16.104329
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (17.4 sec)
( 1 secs ) Upload to test-results [browser_tests_apprtc]
- stdout
( 2 secs ) content_unittests
Run on OS: 'Mac-10.13'
Shard duration: 41s
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (20.4 sec)
( 5 secs ) Upload to test-results [content_unittests]
- stdout
( 1 secs ) content_browsertests_sequential
Run on OS: 'Mac-10.13'
Shard duration: 31s
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (10.3 sec)
( 2 secs ) Upload to test-results [content_browsertests_sequential]
- stdout
( 1 secs ) browser_tests_functional
Run on OS: 'Mac-10.13'
Shard duration: 0:02:00.366593
- stdout
- swarming.summary
- Merge script log
- step_metadata
- shard #0 isolated out
- shard #0 (73.7 sec)
( 2 secs ) Upload to test-results [browser_tests_functional]
- stdout
( 270 ms ) Tests statistics

Stats
Total shards: 8
Total runtime: 0:03:16.751898
- stdout
- detailed stats
( 0 ) Failure reason
- reason

Build Properties:

Name	Value	Source
$recipe_engine/buildbucket	{"build": {"builder": {"bucket": "webrtc", "builder": "WebRTC Chromium Mac Tester", "project": "chromium"}, "createTime": "2019-02-12T01:39:55.997953Z", "createdBy": "user:luci-scheduler@appspot.gserviceaccount.com", "id": "8921768448450202880", "infra": {"buildbucket": {"serviceConfigRevision": "2acf9ddf085124300131f0a719a64564504c97a6"}, "recipe": {"cipdPackage": "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build", "name": "chromium"}, "swarming": {"hostname": "chromium-swarm.appspot.com"}}, "input": {"gitilesCommit": {"host": "chromium.googlesource.com", "id": "c7b902f044650dd46bc03f9b888bc818204b94f2", "project": "chromium/src", "ref": "refs/heads/master"}}, "number": 2906, "tags": [{"key": "builder", "value": "WebRTC Chromium Mac Tester"}, {"key": "buildset", "value": "commit/gitiles/chromium.googlesource.com/chromium/src/+/c7b902f044650dd46bc03f9b888bc818204b94f2"}, {"key": "parent_buildername", "value": "WebRTC Chromium Mac Builder"}, {"key": "parent_buildnumber", "value": "4484"}, {"key": "scheduler_invocation_id", "value": "9087198511085884672"}, {"key": "scheduler_job_id", "value": "chromium/WebRTC Chromium Mac Tester"}, {"key": "user_agent", "value": "luci-scheduler"}, {"key": "user_agent", "value": "recipe"}]}}	setup_build
$recipe_engine/path	{"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"build15-b9"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.webrtc", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1549935595997953, "id": "8921768448450202880", "project": "chromium", "tags": ["build_address:luci.chromium.webrtc/WebRTC Chromium Mac Tester/2906", "builder:WebRTC Chromium Mac Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/c7b902f044650dd46bc03f9b888bc818204b94f2", "gitiles_ref:refs/heads/master", "parent_buildername:WebRTC Chromium Mac Builder", "parent_buildnumber:4484", "scheduler_invocation_id:9087198511085884672", "scheduler_job_id:chromium/WebRTC Chromium Mac Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"WebRTC Chromium Mac Tester"	setup_build
buildnumber	2906	setup_build
mastername	"chromium.webrtc"	setup_build
parent_buildername	"WebRTC Chromium Mac Builder"	setup_build
parent_got_angle_revision	"6b695c3ffb27ad1df71f4f1682dc7a1d8adc9f31"	setup_build
parent_got_dawn_revision	"62e83971caa1099bdbc334817efa035047c90ddf"	setup_build
parent_got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	setup_build
parent_got_revision	"c7b902f044650dd46bc03f9b888bc818204b94f2"	setup_build
parent_got_revision_cp	"refs/heads/master@{#631022}"	setup_build
parent_got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	setup_build
parent_got_v8_revision	"872455b5fe0cf1f09eb5550fb1e0bdd259523e8b"	setup_build
parent_got_v8_revision_cp	"refs/heads/7.4.138@{#1}"	setup_build
parent_got_webrtc_revision	"f13c2cd9ee41f4ca572232a4e397b05449474632"	setup_build
parent_got_webrtc_revision_cp	"refs/heads/master@{#26626}"	setup_build
parent_mastername	"chromium.webrtc"	setup_build
path_config	"generic"	setup_build
perf_dashboard_machine_group	"ChromiumWebRTC"	setup_build
recipe	"chromium"	setup_build
revision	"c7b902f044650dd46bc03f9b888bc818204b94f2"	setup_build
swarm_hashes	{"browser_tests": "5840190cbe7dfd2bbe889878767aec8e6739aa41", "browser_tests_apprtc": "5b8b59d720cc330c4cb97876300d6d4bd060bf00", "content_browsertests": "8599b4ae591e2ebc7d20575eb88492632f814dca", "content_unittests": "c5f04d1965fa16c64837aab1c93726b97a51343a", "jingle_unittests": "7071cd40424592785b6542af8348773cb6f5c558", "remoting_unittests": "535877339145ff682c770fa585b56a55db01efff"}	setup_build
got_angle_revision	"6b695c3ffb27ad1df71f4f1682dc7a1d8adc9f31"	bot_update
got_dawn_revision	"62e83971caa1099bdbc334817efa035047c90ddf"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"c7b902f044650dd46bc03f9b888bc818204b94f2"	bot_update
got_revision_cp	"refs/heads/master@{#631022}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"872455b5fe0cf1f09eb5550fb1e0bdd259523e8b"	bot_update
got_v8_revision_cp	"refs/heads/7.4.138@{#1}"	bot_update
got_webrtc_revision	"f13c2cd9ee41f4ca572232a4e397b05449474632"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26626}"	bot_update
swarm_hashes	{"browser_tests": "5840190cbe7dfd2bbe889878767aec8e6739aa41", "browser_tests_apprtc": "5b8b59d720cc330c4cb97876300d6d4bd060bf00", "content_browsertests": "8599b4ae591e2ebc7d20575eb88492632f814dca", "content_unittests": "c5f04d1965fa16c64837aab1c93726b97a51343a", "jingle_unittests": "7071cd40424592785b6542af8348773cb6f5c558", "remoting_unittests": "535877339145ff682c770fa585b56a55db01efff"}	find isolated tests

Blamelist:

Andrew Luo (aluoohnoyoudont@chromium.org)
Raymond Toy (rtoyohnoyoudont@chromium.org)
Rune Lillesveen (futharkohnoyoudont@chromium.org)
Donn Denman (donndohnoyoudont@chromium.org)
Alli Murray (alliemurrayohnoyoudont@google.com)
Sam Goto (gotoohnoyoudont@chromium.org)
Rob Buis (rbuisohnoyoudont@igalia.com)
Aga Wronska (agawronskaohnoyoudont@chromium.org)
Brandon Wylie (wyliebohnoyoudont@chromium.org)
Scott Violet (skyohnoyoudont@chromium.org)
jdoerrie (jdoerrieohnoyoudont@chromium.org)
Robbie McElrath (rmcelrathohnoyoudont@chromium.org)
Zhongyi Shi (zhongyiohnoyoudont@chromium.org)
Jazz Xu (jazzhsuohnoyoudont@chromium.org)
Ken Rockot (rockotohnoyoudont@google.com)
v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
Andrey Kosyakov (caseqohnoyoudont@chromium.org)
Peter Mayo (petermayoohnoyoudont@chromium.org)
Jun Cai (juncaiohnoyoudont@chromium.org)
Nick Harper (nharperohnoyoudont@chromium.org)

Timing:

Create	Tuesday, 12-Feb-19 01:39:55 UTC
Start	Tuesday, 12-Feb-19 01:40:30 UTC
End	Tuesday, 12-Feb-19 01:53:24 UTC
Pending	34 secs
Execution	12 mins 54 secs

All Changes:

use-webview-provider for cts tests

Changed by	Andrew Luo - aluoohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:57:18 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	c7b902f044650dd46bc03f9b888bc818204b94f2

Comments

use-webview-provider for cts tests

Bug: 814405
Change-Id: I8365f21c0c4d02245229fe4fd88f991577fa5977
Reviewed-on: https://chromium-review.googlesource.com/c/1461685
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631022}

Changed files

testing/buildbot/gn_isolate_map.pyl

Move realtime methods from BaseAudioContext to AudioContext

Changed by	Raymond Toy - rtoyohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:54:52 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	d29f3c4332172172be9ac459cfffaa1fa6207007

Comments

Move realtime methods from BaseAudioContext to AudioContext

Several changes here:
- make HandlePreRenderTasks and HandlePostRenderTasks virtual to
remove the distinction between AudioContext and OfflineAudioContext.  This
allows moving most of the autoplay stuff to an AudioContext since they're not
relevant to an OfflineAudioContext.

- DefaultAudioDestination only accepts AudioContexts since the default
destination is for realtime contexts.

This must not affect any tests.

Bug: 872412
Change-Id: Iafee57529621b542634093e23d3697aa0caeeee8
Reviewed-on: https://chromium-review.googlesource.com/c/1416710
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631021}

Changed files

third_party/blink/renderer/modules/webaudio/audio_context.cc
third_party/blink/renderer/modules/webaudio/audio_context.h
third_party/blink/renderer/modules/webaudio/base_audio_context.cc
third_party/blink/renderer/modules/webaudio/base_audio_context.h
third_party/blink/renderer/modules/webaudio/default_audio_destination_node.cc
third_party/blink/renderer/modules/webaudio/default_audio_destination_node.h
third_party/blink/renderer/modules/webaudio/offline_audio_context.cc
third_party/blink/renderer/modules/webaudio/offline_audio_context.h
third_party/blink/renderer/modules/webaudio/offline_audio_destination_node.cc

Make sure to clean up line tree properly on detach.

Changed by	Rune Lillesveen - futharkohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:54:33 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	b613fc077e5df751a7eb9e33bc1c393531fa0ef7

Comments

Make sure to clean up line tree properly on detach.

In [1] we changed from NeedsAttach() to NeedsReattachLayoutTree() for an
optimization to skip cleaning up the line tree for newly created layout
objects. NeedsReattachLayoutTree() is also true for an element being
detached. Instead use !EverHadLayout() to skip line tree cleanup.

[1] https://crrev.com/3e610731bc6f24b929249d336835a865a791a69b

Bug: 930474, 927438, 929643
Change-Id: Ib45a8afc17930eb63a8cbedeb4b2d6af1f3c5149
Reviewed-on: https://chromium-review.googlesource.com/c/1463860
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631020}

Changed files

third_party/blink/renderer/core/layout/api/line_layout_item.h
third_party/blink/renderer/core/layout/line/line_box_list.cc
third_party/blink/web_tests/fast/layout/detach-line-layout-item-crash.html

[TTS] Fix a crash recently introduced.

Changed by	Donn Denman - donndohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:51:01 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	149172a63e0b725d2a34dc8c87218588b6ec7d43

Comments

[TTS] Fix a crash recently introduced.

Protect against a null ContextualSearchManager when an Overlay
Panel is shown.  The ContextualSearchTabHelper needs to check
for a null CSM before asking if it is active. If there's no CSM
then we don't need to update the hooks even though it can't be active.

BUG=930615

Change-Id: I1fe106a29978a007d80e908590a40526b696a73f
Reviewed-on: https://chromium-review.googlesource.com/c/1465164
Commit-Queue: Donn Denman <donnd@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631019}

Changed files

chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java

Reland: Add quick view test for removable usb partitions.

Changed by	Alli Murray - alliemurrayohnoyoudont@google.com
Changed at	Tuesday, 12-Feb-19 00:50:31 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	df938b958bad530ce3bfc3d4acccb897b30b5bec

Comments

Reland: Add quick view test for removable usb partitions.

Bug: 918795
Change-Id: Id158154b74b9ee45cf799584630bedbcfde526ea
Reviewed-on: https://chromium-review.googlesource.com/c/1459870
Commit-Queue: Alli Murray <alliemurray@google.com>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631018}

Changed files

chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
ui/file_manager/integration_tests/file_manager/quick_view.js

Testing editing markdown in gerrit.

Changed by	Sam Goto - gotoohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:49:16 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	1c5787d058c4f31ece6429da1394b73295a30123

Comments

Testing editing markdown in gerrit.

Change-Id: I883e19b8f9f702337579fa6605ee1ca7bfc188cc
Reviewed-on: https://chromium-review.googlesource.com/c/1464979
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Sam Goto <goto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631017}

Changed files

docs/linux_eclipse_dev.md

Fix spec reference

Changed by	Rob Buis - rbuisohnoyoudont@igalia.com
Changed at	Tuesday, 12-Feb-19 00:45:16 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	09172250ca38c52d53b8592502eceea012d50329

Comments

Fix spec reference

The reference changed to be version neutral.

Bug: 803774
Change-Id: Ia42664ef48867f1e4eace73b1cb787a6bd4250fa
Reviewed-on: https://chromium-review.googlesource.com/c/1461880
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631016}

Changed files

content/browser/web_package/signed_exchange_envelope.cc

child user: Add parent_access namespace and rename objects inside it.

Changed by	Aga Wronska - agawronskaohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:44:30 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	dadc56a8e7575345feed8a24e6a62616068693e2

Comments

child user: Add parent_access namespace and rename objects inside it.

Prefixing class names with ParentAccessCode led to too much verbosity
in the code and file names. Addning new namspace fixes that.
Name changes made:
ParentAccessCode -> parent_access::AccessCode
ParentAccessCodeConfig -> parent_access::AccessCodeConfig
ParentAccessCodeAuthenticator -> parent_access::Authenticator

Change-Id: I186e2c12c5b555845c97b27838cbd17da62c6f1c
Reviewed-on: https://chromium-review.googlesource.com/c/1461347
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631015}

Changed files

chrome/browser/chromeos/BUILD.gn
chrome/browser/chromeos/child_accounts/parent_access_code/authenticator.cc
chrome/browser/chromeos/child_accounts/parent_access_code/authenticator.h
chrome/browser/chromeos/child_accounts/parent_access_code/authenticator_unittest.cc
chrome/browser/chromeos/child_accounts/parent_access_code/parent_access_code_authenticator.h

[Image Fetcher] Add feature-specific metrics reporting

Changed by	Brandon Wylie - wyliebohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:43:10 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	f8a51e47b971ecec47b44fcf85dca912d4b0e52a

Comments

[Image Fetcher] Add feature-specific metrics reporting

Adds a required client name for ImageFetcher calls. The client name
is used to report to client-specific histograms. These will be used
to determine how much each feature contributes to:
- Disk usage
- Cache utilization
- Fetch/decode times

These factors will be used to make informed decisions about which
features benefit from caching.

Bug: 916722
Change-Id: I22101ebc973eb5f58e8794345065b1983c95b2d7
Reviewed-on: https://chromium-review.googlesource.com/c/1393671
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631014}

Changed files

chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedImageLoader.java
chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/details/AssistantDetailsViewBinder.java
chrome/android/java/src/org/chromium/chrome/browser/cached_image_fetcher/CachedImageFetcher.java
chrome/android/java/src/org/chromium/chrome/browser/cached_image_fetcher/CachedImageFetcherBridge.java
chrome/android/java/src/org/chromium/chrome/browser/cached_image_fetcher/CachedImageFetcherImpl.java
chrome/android/java/src/org/chromium/chrome/browser/cached_image_fetcher/InMemoryCachedImageFetcher.java
chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsSourceImpl.java
chrome/android/junit/src/org/chromium/chrome/browser/cached_image_fetcher/CachedImageFetcherImplTest.java
chrome/android/junit/src/org/chromium/chrome/browser/cached_image_fetcher/InMemoryCachedImageFetcherTest.java
chrome/android/junit/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsSourceImplTest.java
chrome/browser/android/cached_image_fetcher/cached_image_fetcher_bridge.cc
chrome/browser/android/cached_image_fetcher/cached_image_fetcher_bridge.h
chrome/browser/android/explore_sites/explore_sites_bridge_experimental.cc
chrome/browser/search/ntp_icon_source.cc
chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc
components/favicon/core/large_icon_service_impl.cc
components/feed/core/feed_image_manager.cc
components/image_fetcher/core/cache/BUILD.gn
components/image_fetcher/core/cache/cached_image_fetcher_metrics_reporter.cc
components/image_fetcher/core/cache/cached_image_fetcher_metrics_reporter.h
components/image_fetcher/core/cache/cached_image_fetcher_metrics_reporter_unittest.cc
components/image_fetcher/core/cache/image_cache.cc
components/image_fetcher/core/cached_image_fetcher.cc
components/image_fetcher/core/cached_image_fetcher.h
components/image_fetcher/core/cached_image_fetcher_unittest.cc
components/image_fetcher/core/image_fetcher.cc
components/image_fetcher/core/image_fetcher.h
components/image_fetcher/core/image_fetcher_impl_unittest.cc
components/image_fetcher/core/mock_image_fetcher.h
components/ntp_snippets/remote/cached_image_fetcher.cc
components/ntp_tiles/icon_cacher_impl.cc
components/offline_pages/core/prefetch/thumbnail_fetch_by_url.cc
components/signin/core/browser/account_fetcher_service.cc
ios/chrome/browser/passwords/notify_auto_signin_view_controller.mm
tools/metrics/histograms/histograms.xml

chromeos: removes quick_launch

Changed by	Scott Violet - skyohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:39:39 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	1e6329e9a5e04d4921947c7c27dcee252452a406

Comments

chromeos: removes quick_launch

And the mash directory. These aren't useful, and having these around means we
need some unnecessary complexity. I converted the one that test that was using
these to instead launch shortcut_viewer.

BUG=none
TEST=none

Change-Id: I6aff493bfd560c8c93dba496690313c715a8cf06
Reviewed-on: https://chromium-review.googlesource.com/c/1462116
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631013}

Changed files

ash/BUILD.gn
ash/DEPS
ash/accelerators/accelerator_controller.cc
ash/accelerators/accelerator_table.cc
ash/accelerators/accelerator_table_unittest.cc
ash/accelerators/debug_commands.cc
ash/app_launch_unittest.cc
ash/components/quick_launch/BUILD.gn
ash/components/quick_launch/DEPS
ash/components/quick_launch/main.cc
ash/components/quick_launch/public/cpp/BUILD.gn
ash/components/quick_launch/public/cpp/OWNERS
ash/components/quick_launch/public/cpp/manifest.cc
ash/components/quick_launch/public/cpp/manifest.h
ash/components/quick_launch/public/mojom/BUILD.gn
ash/components/quick_launch/public/mojom/OWNERS
ash/components/quick_launch/public/mojom/constants.mojom
ash/components/quick_launch/quick_launch_application.cc
ash/components/quick_launch/quick_launch_application.h
ash/public/cpp/BUILD.gn
ash/public/cpp/DEPS
ash/public/cpp/accelerators.h
ash/public/cpp/manifest.cc
ash/shell/content/client/DEPS
ash/shell/content/client/shell_browser_main_parts.cc
ash/shell/content/client/shell_content_browser_client.cc
ash/shell/content/client/shell_main_delegate.cc
ash/system/flag_warning/flag_warning_tray.cc
chrome/app/BUILD.gn
chrome/app/DEPS
chrome/app/chrome_packaged_service_manifests.cc
chrome/app/chromeos_strings.grdp
chrome/browser/BUILD.gn
chrome/browser/DEPS
chrome/browser/ash_service_registry.cc
chrome/browser/chrome_service.cc
chrome/browser/chromeos/BUILD.gn
chrome/browser/chromeos/accessibility/accessibility_manager.cc
chrome/browser/chromeos/launchable.cc
chrome/browser/chromeos/launchable.h
chrome/browser/ui/BUILD.gn
chrome/browser/ui/ash/DEPS
chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_metadata_unittest.cc
chrome/browser/ui/ash/shortcut_viewer_browsertest.cc
chrome/test/BUILD.gn
chrome/test/base/in_process_browser_test.h
chrome/utility/BUILD.gn
chrome/utility/DEPS
chrome/utility/mash_service_factory.cc
mash/OWNERS
mash/public/mojom/BUILD.gn
mash/public/mojom/OWNERS
mash/public/mojom/launchable.mojom

[Passwords] Add Field Trial Testing Config for HTTP FOAS Experiment

Changed by	jdoerrie - jdoerrieohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:39:19 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	59c19d8e9f26e2ec065e56d188432be131f6cb4f

Comments

[Passwords] Add Field Trial Testing Config for HTTP FOAS Experiment

This change adds a Field Trial Testing Configuration for the Fill On
Account Select over HTTP Experiment.

Bug: 914765
Change-Id: I4271c3c4c5cdec403e52815a077f384de7042957
Reviewed-on: https://chromium-review.googlesource.com/c/1463445
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631012}

Changed files

chrome/browser/password_manager/password_manager_browsertest.cc
testing/variations/fieldtrial_testing_config.json

Deflake ZipFiles/FilesAppBrowserTest.Test/zipFileOpenDownloads_GuestMode

Changed by	Robbie McElrath - rmcelrathohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:38:34 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	d755a8cf625f40b2b2a4c7e96adb8337b135aa68

Comments

Deflake ZipFiles/FilesAppBrowserTest.Test/zipFileOpenDownloads_GuestMode

The issue with this test is a bit hard to explain, so I'll start by
giving some background on FileSystemContext/FileSystemOperationRunner,
then on FileSystemFileURLLoader, and then on their racy interaction that
causes the test to be flaky.

StoragePartitionImpl contains a scoped_refptr to a FileSystemContext,
which contains helpers and information about the file system. One of
these helpers is a unique_ptr to a FileSystemOperationRunner, which as
the name implies, manages running operations on the file system (create,
delete, write, etc..).  When you ask the FileSystemOperationRunner to
perform an operation, you give it a callback and whatever else it needs,
and then it starts the operation and keeps some metadata about it keyed
by an OperationId. This metadata contains a scoped_refptr to the
FileSystemContext that owns the FileSystemOperationRunner.  This
reference ensures that while the operation is running, the
FileSystemContext won't be deleted, which in turn keeps the runner alive
until the operation is complete. When the underlying operation is done,
the FileSystemOperationRunner will call the callback, and then clean up
the metadata about the operation, removing the reference to the
FileSystemContext in the process. This could potentially delete the
FileSystemContext, but only after any pending work is complete.

Meanwhile, when the network service is enabled, it installs a
FileSystemFileURLLoader to handle requests to local files. This class's
constructor takes a scoped_refptr to a FileSystemContext, which it uses
to access the file system. When the FileSystemFileURLLoader serves a
file, it will call GetMetadata on the FileSystemOperationRunner
associated with the FileSystemContext it has a reference to, with its
DidGetMetadata method as the callback. DidGetMetadata checks the error
code and does something unimportant (for this CL) on success; however,
on error it will tell the client the request is complete, delete the
client ptr, and then delete itself.

The last thing to know is that when a StoragePartitionImpl is being
deleted, it calls FileSystemContext::Shutdown, which calls
FileSystemOperationRunner::Shutdown, which clears the metadata map that
contained the scoped_refptrs keeping the FileSystemContext alive during
pending operations.

In this test, the following sequence of events can happen:
1. Something requests a resource from disk, resulting in a
   FileSystemFileURLLoader being created, which starts a GetMetadata
   call on the StoragePartition's FileSystemOperationRunner.
   FileSystemOperationRunner will start the operation and add it to its
   map of pending operations.
2. The StoragePartition gets deleted, which calls
   FileSystemOperationRunner::Shutdown, which clears the pending
   operations map. Both the map and StoragePartitions' scoped_refptr to
   the FileSystemContext are now deleted. The only thing keeping the
   FileSystemContext alive is the FileSystemFileURLLoader.
3. The underlying GetMetadata operation completes (was aborted) and
   calls FileSystemOperationRunner::DidGetMetadata. This will call the
   completion callback, FileSystemFileURLLoader::DidGetMetadata, which
   will complete the request, and then delete itself, taking the last
   FileSystemContext reference with it. After the callback is called,
   FileSystemOperationRunner calls FinishOperation to clean up the
   GetMetadata operation, but the callback already deleted the runner,
   so FinishOperation segfaults.

My initial thought was that callbacks shouldn't ever delete the object
they were passed to, but I felt that this issue was subtle enough (to me
at least) that it could come again even if we fixed this case. Instead,
this CL makes the Did* completion callback methods in
FileSystemOperationRunner take a reference to the FileSystemContext to
make sure it won't be deleted until after it's done handling the
operation.

Bug: 930807
Change-Id: Ie35348697c4145aad73cbada3da604f878c1cf00
Reviewed-on: https://chromium-review.googlesource.com/c/1464647
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631011}

Changed files

storage/browser/fileapi/file_system_operation_runner.cc

Add an idle migration period to QuicChromiumClientSession.

Changed by	Zhongyi Shi - zhongyiohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:37:40 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	c16b410d1da4d55592c17f0ac4a0d109f4f6e796

Comments

Add an idle migration period to QuicChromiumClientSession.

Sessions will only be migrated if its idle period is within this period.

Bug: 929351
Change-Id: I18b919f679ee8ed06b40b832685a0e10b9c02a77
Reviewed-on: https://chromium-review.googlesource.com/c/1459072
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631010}

Changed files

net/http/http_network_session.cc
net/http/http_network_session.h
net/http/http_proxy_client_socket_wrapper_unittest.cc
net/quic/bidirectional_stream_quic_impl_unittest.cc
net/quic/quic_chromium_client_session.cc
net/quic/quic_chromium_client_session.h
net/quic/quic_chromium_client_session_test.cc
net/quic/quic_http_stream_test.cc
net/quic/quic_proxy_client_socket_unittest.cc
net/quic/quic_stream_factory.cc
net/quic/quic_stream_factory.h
net/quic/quic_stream_factory_fuzzer.cc
net/quic/quic_stream_factory_peer.cc
net/quic/quic_stream_factory_peer.h
net/quic/quic_stream_factory_test.cc

[CrOS Video Player] Search subtitle when loading video

Changed by	Jazz Xu - jazzhsuohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:36:25 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	30b15dab03cc0048cd1780be12677a592a165011

Comments

[CrOS Video Player] Search subtitle when loading video

Search .vtt subtitle with same name as video source,
and attach to video in native controls.

Bug: 909963
Change-Id: Ib4431de16e8a7ba78c0d9ea9e880884c5641047e
Reviewed-on: https://chromium-review.googlesource.com/c/1418320
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631009}

Changed files

chrome/browser/chromeos/file_manager/video_player_browsertest.cc
chrome/test/data/chromeos/file_manager/video.vtt
ui/file_manager/integration_tests/test_util.js
ui/file_manager/integration_tests/video_player/background.js
ui/file_manager/integration_tests/video_player/open_video_files.js
ui/file_manager/video_player/js/test_util.js
ui/file_manager/video_player/js/video_player_native_controls.js

[SM] Use maps for Manifest capability data

Changed by	Ken Rockot - rockotohnoyoudont@google.com
Changed at	Tuesday, 12-Feb-19 00:36:00 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	6cdde4d7f7f512864aa5dabde5327707e9a02bf3

Comments

[SM] Use maps for Manifest capability data

This changes the service Manifest type to use maps and sets for
underlying capability data storage rather than flat vectors of
structures.

This makes the type more useful to the Service Manager at runtime, and
avoids having to build additional data structures from the manifests.

Bug: 895616
Change-Id: I4e9354fd51a3a1e466c26a34b86a3358a31de7ab
Reviewed-on: https://chromium-review.googlesource.com/c/1462140
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#631008}

Changed files

chrome/app/chrome_content_browser_overlay_manifest.cc
services/catalog/entry_cache.cc
services/service_manager/public/cpp/manifest.cc
services/service_manager/public/cpp/manifest.h
services/service_manager/public/cpp/manifest_builder.h
services/service_manager/public/cpp/manifest_unittest.cc

Update V8 to version 7.4.138.

Changed by	v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
Changed at	Tuesday, 12-Feb-19 00:35:16 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	a57ea829912da80aa2ad3a6db61c384d7007cf6f

Comments

Update V8 to version 7.4.138.

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0e223be0..872455b5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I3b3d615fb35fe50e85d1d5af38bc488bee0340bb
Reviewed-on: https://chromium-review.googlesource.com/c/1464333
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#631007}

Changed files

DEPS

DevTools: support binary protocol framing

Changed by	Andrey Kosyakov - caseqohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:34:52 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	182039e1f62d2cdbb5ce2afe3fcf98dba20e29a1

Comments

DevTools: support binary protocol framing

BUG=929862

This adds an optional parameter to --remote-debugging-pipe that lets
caller specify cbor to use CBOR-compatible binary, as opposed to 0-terminated, framing for
passing DevTools messages over the pipe.

Change-Id: Iedadb66d14bb5e7a2c3cea855d4ff4bf4f5b88be
Reviewed-on: https://chromium-review.googlesource.com/c/1460182
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631006}

Changed files

content/browser/devtools/devtools_pipe_handler.cc
content/browser/devtools/devtools_pipe_handler.h
content/public/common/content_switches.cc

[Sheriff] Ignore failing WPT target_blank_implicit_noopener.html

Changed by	Peter Mayo - petermayoohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:33:51 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	5c3a4fe24c1a01e8804cfa7024a6b64889000180

Comments

[Sheriff] Ignore failing WPT target_blank_implicit_noopener.html

Updated WPT state from roll has different failures and passes from
previous expectations

TBR=foolip

Bug: 930873
Change-Id: I2a5bb4a5c30225b1970c165b5b6e92fb7c9159a0
Reviewed-on: https://chromium-review.googlesource.com/c/1465059
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631005}

Changed files

third_party/blink/web_tests/TestExpectations

Network Service: Fix linux-perf-fyi perf histogam metrics' name issue

Changed by	Jun Cai - juncaiohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:33:45 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	feeccd78af9d3bb162771ba973868379f64651b0

Comments

Network Service: Fix linux-perf-fyi perf histogam metrics' name issue

Currently the histogram metrics' name all start with cold@@ or warm@@,
This CL removes these prefixes so that the linux-perf-fyi dashboard
can correctly parse these metrics.

Bug: 930764
Change-Id: I12e8c14a841f327c0f094988186b5e8c73a73b12
Reviewed-on: https://chromium-review.googlesource.com/c/1464640
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631004}

Changed files

tools/perf/contrib/network_service/loading.py

Update bulk entries in HSTS preload list

Changed by	Nick Harper - nharperohnoyoudont@chromium.org
Changed at	Tuesday, 12-Feb-19 00:30:52 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	556a4c6185ea6868d054944dac44945db40ffa59

Comments

Update bulk entries in HSTS preload list

TBR=bnc@chromium.org

Change-Id: I16df7002e113f587d27e71cbd0a5c198976b0bb7
Reviewed-on: https://chromium-review.googlesource.com/c/1464203
Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631003}

Changed files

net/http/transport_security_state_static.json