Home | Search | chromium - Builders
Login

Builder WebRTC Chromium FYI Win Builder (dbg) Build 1202 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revisiond644feb81fe1bfbf6642469319b31b3944697631
Got Revisiond644feb81fe1bfbf6642469319b31b3944697631

Execution:

Steps and Logfiles:

Show:
  1. ( 840 ms ) setup_build
    running recipe: "chromium"
  2. ( 1 secs ) report builders
     
    running builder/tester 'WebRTC Chromium FYI Win Builder (dbg)' on master 'chromium.webrtc.fyi'
  3. ( 7 secs ) taskkill
  4. ( 8 mins 14 secs ) bot_update
    [64GB/299GB used (21%)]
  5. ( 4 secs ) swarming.py --version
    0.14
  6. ( 34 secs ) gclient runhooks
  7. ( 316 ms ) read test spec (chromium.webrtc.fyi.json)
    path: C:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.webrtc.fyi.json
  8. ( 707 ms ) lookup GN args
     
    com_init_check_hook_disabled = true
    ffmpeg_branding = "Chrome"
    is_component_build = true
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\s\\w\\ir\\cache\\goma\\client"
  9. ( 3 mins 39 secs ) generate_build_files
  10. ( 12 mins 36 secs ) compile
  11. ( 10 secs ) compile confirm no-op

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\s\\w\\ir\\cache", "temp_dir": "C:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "win10-webrtc-8983f7d1-us-central1-c-vxmm" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.webrtc.fyi", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544119921226455, "id": "8927866625438287104", "project": "chromium", "tags": ["builder:WebRTC Chromium FYI Win Builder (dbg)", "buildset:commit/git/d644feb81fe1bfbf6642469319b31b3944697631", "buildset:commit/gitiles/webrtc.googlesource.com/src/+/d644feb81fe1bfbf6642469319b31b3944697631", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093296688166155216", "scheduler_job_id:chromium/WebRTC Chromium FYI Win Builder (dbg)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "WebRTC Chromium FYI Win Builder (dbg)" setup_build
buildnumber 1202 setup_build
mastername "chromium.webrtc.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://webrtc.googlesource.com/src/" setup_build
revision "d644feb81fe1bfbf6642469319b31b3944697631" setup_build
got_angle_revision "d300548fcc2858fab34b7a744a000c48be845d06" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_cr_revision "e908ae1d722150daddb6a3074842d564e29b6694" bot_update
got_cr_revision_cp "refs/heads/master@{#614419}" bot_update
got_dawn_revision "5aacd29d5e7ed44d3cb0d1c690fbd0fc5152978f" bot_update
got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" bot_update
got_revision "d644feb81fe1bfbf6642469319b31b3944697631" bot_update
got_revision_cp "refs/heads/master@{#25926}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "f5137533bdfac762e980b17eb7b4a2433dd07d1d" bot_update
got_v8_revision_cp "refs/heads/7.3.39@{#1}" bot_update
got_webrtc_revision "d644feb81fe1bfbf6642469319b31b3944697631" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25926}" bot_update

Blamelist:

  1. Anton Sukhanov (sukhanovohnoyoudont@webrtc.org)

Timing:

Create Thursday, 06-Dec-18 18:12:01 UTC
Start Thursday, 06-Dec-18 18:13:02 UTC
End Thursday, 06-Dec-18 18:44:37 UTC
Pending 1 mins 1 secs
Execution 31 mins 35 secs

All Changes:

  1. Make sure media transport is deleted before ICE.

    Changed by Anton Sukhanov - sukhanovohnoyoudont@webrtc.org
    Changed at Thursday, 06-Dec-18 18:11:28 UTC
    Repository https://webrtc.googlesource.com/src
    Branch
    Revision d644feb81fe1bfbf6642469319b31b3944697631

    Comments

    Make sure media transport is deleted before ICE.
    
    This was regression due to
    https://webrtc-review.googlesource.com/c/src/+/111920
    
    which broke downstream projects. The break was not caught in
    unit tests, because unit tests use loopback and fake media
    transports that do not use ICE.
    
    Bug: None
    Change-Id: If95935afed430d62d5ff9a2ee01d8eaccadc198d
    Reviewed-on: https://webrtc-review.googlesource.com/c/113440
    Commit-Queue: Steve Anton <steveanton@webrtc.org>
    Reviewed-by: Peter Slatala <psla@webrtc.org>
    Reviewed-by: Steve Anton <steveanton@webrtc.org>
    Cr-Commit-Position: refs/heads/master@{#25926}

    Changed files

    • pc/jseptransport.cc