Home | Search | chromium - Builders
Login

Builder win32-rel Build 4336 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision0edf161ea086a970d14c9946ded919743e693731
Got Revision0edf161ea086a970d14c9946ded919743e693731

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Sergey Kuznetsov (kuznetsovsohnoyoudont@yandex-team.ru)
  2. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  3. Matthew Cary (mattcaryohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 14:31:20 UTC
Start Friday, 12-Oct-18 14:31:25 UTC
End Friday, 12-Oct-18 14:48:31 UTC
Pending 5 secs
Execution 17 mins 6 secs

All Changes:

  1. Fix possible crash when |change_dispatcher_| gone.

    Changed by Sergey Kuznetsov - kuznetsovsohnoyoudont@yandex-team.ru
    Changed at Friday, 12-Oct-18 14:29:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0edf161ea086a970d14c9946ded919743e693731

    Comments

    Fix possible crash when |change_dispatcher_| gone.
    
    Nothing prevents CookieMonsterChangeDispatcher::Subscription to
    outlive CookieMonsterChangeDispatcher.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Ifa2cd0c8def9ae1c63a0a3d37bd469bbbc78e5ca
    Reviewed-on: https://chromium-review.googlesource.com/c/1242460
    Commit-Queue: Maks Orlovich <morlovich@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Reviewed-by: Maks Orlovich <morlovich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599203}

    Changed files

    • ios/net/cookies/cookie_store_ios.h
    • ios/net/cookies/cookie_store_ios.mm
    • net/cookies/cookie_monster_change_dispatcher.cc
    • net/cookies/cookie_store_change_unittest.h
    • net/cookies/cookie_store_unittest.h
  2. Rename method in token service diagnostic observer for clarity

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:27:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 466b727ac3cd8f967fed05a86562c01616824627

    Comments

    Rename method in token service diagnostic observer for clarity
    
    Bug: NONE
    Change-Id: I18d05d59ba0be38d7598396fab2cef8b44647fcf
    Reviewed-on: https://chromium-review.googlesource.com/c/1278754
    Reviewed-by: Thomas Tangl <tangltom@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599202}

    Changed files

    • components/signin/core/browser/about_signin_internals.cc
    • components/signin/core/browser/about_signin_internals.h
    • google_apis/gaia/oauth2_token_service.cc
    • google_apis/gaia/oauth2_token_service.h
  3. Orderfile: skip madvise if ordering has not been done.

    Changed by Matthew Cary - mattcaryohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:19:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ea3132cbbc836b398e523438627cc27349505196

    Comments

    Orderfile: skip madvise if ordering has not been done.
    
    Change a CHECK to an logged warning if madvise is attempted when code
    ordering has not been performed. This happens on upstream builds
    including arm64 builds.
    
    Bug: 894748
    Change-Id: Icdb7ae0c94cfad5beec0215c6186e29135c1079a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278746
    Reviewed-by: Egor Pasko <pasko@chromium.org>
    Reviewed-by: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599201}

    Changed files

    • base/android/library_loader/library_prefetcher.cc