Home | Search | chromium - Builders
Login

Builder win-rel Build 4288 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision466b727ac3cd8f967fed05a86562c01616824627
Got Revision466b727ac3cd8f967fed05a86562c01616824627

Execution:

Steps and Logfiles:

Show:
  1. ( 623 ms ) setup_build
    running recipe: "chromium"
  2. ( 260 ms ) report builders
     
    running builder/tester 'win-rel' on master 'chromium'
  3. ( 5 secs ) taskkill
  4. ( 54 secs ) bot_update
    [93GB/299GB used (31%)]
  5. ( 608 ms ) swarming.py --version
    0.13
  6. ( 23 secs ) clobber
  7. ( 18 secs ) gclient runhooks
  8. ( 215 ms ) read test spec (chromium.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.json
  9. ( 425 ms ) lookup GN args
     
    is_component_build = false
    is_debug = false
    skip_archive_compression = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  10. ( 24 secs ) generate_build_files
  11. ( 11 mins 50 secs ) compile
  12. ( 14 secs ) compile confirm no-op
  13. ( 35 secs ) archive_build
  14. ( 0 ) test_pre_run
  15. ( 1 secs ) checkbins
  16. ( 467 ms ) process_dumps

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm777-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539354580583625, "id": "8932863447268535712", "project": "chromium", "tags": ["builder:win-rel", "buildset:commit/git/466b727ac3cd8f967fed05a86562c01616824627", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/466b727ac3cd8f967fed05a86562c01616824627", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9098293509314964464", "scheduler_job_id:chromium/win-rel", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "win-rel" setup_build
buildnumber 4288 setup_build
mastername "chromium" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "466b727ac3cd8f967fed05a86562c01616824627" setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "466b727ac3cd8f967fed05a86562c01616824627" bot_update
got_revision_cp "refs/heads/master@{#599202}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "c34cf71d601759149a79cd9d59293397009f7b0e" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25140}" bot_update

Blamelist:

  1. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  2. Matthew Cary (mattcaryohnoyoudont@chromium.org)
  3. Jaeyong Bae (jdragon.baeohnoyoudont@gmail.com)

Timing:

Create Friday, 12-Oct-18 14:29:40 UTC
Start Friday, 12-Oct-18 14:29:42 UTC
End Friday, 12-Oct-18 14:47:34 UTC
Pending 1 secs
Execution 17 mins 52 secs

All Changes:

  1. Rename method in token service diagnostic observer for clarity

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:27:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 466b727ac3cd8f967fed05a86562c01616824627

    Comments

    Rename method in token service diagnostic observer for clarity
    
    Bug: NONE
    Change-Id: I18d05d59ba0be38d7598396fab2cef8b44647fcf
    Reviewed-on: https://chromium-review.googlesource.com/c/1278754
    Reviewed-by: Thomas Tangl <tangltom@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599202}

    Changed files

    • components/signin/core/browser/about_signin_internals.cc
    • components/signin/core/browser/about_signin_internals.h
    • google_apis/gaia/oauth2_token_service.cc
    • google_apis/gaia/oauth2_token_service.h
  2. Orderfile: skip madvise if ordering has not been done.

    Changed by Matthew Cary - mattcaryohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:19:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ea3132cbbc836b398e523438627cc27349505196

    Comments

    Orderfile: skip madvise if ordering has not been done.
    
    Change a CHECK to an logged warning if madvise is attempted when code
    ordering has not been performed. This happens on upstream builds
    including arm64 builds.
    
    Bug: 894748
    Change-Id: Icdb7ae0c94cfad5beec0215c6186e29135c1079a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278746
    Reviewed-by: Egor Pasko <pasko@chromium.org>
    Reviewed-by: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599201}

    Changed files

    • base/android/library_loader/library_prefetcher.cc
  3. Remove prefs::kReverseAutologinEnabled & DisableOneClickSignIn

    Changed by Jaeyong Bae - jdragon.baeohnoyoudont@gmail.com
    Changed at Friday, 12-Oct-18 14:12:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6e7d226c7a576e4b90de8460df4f11cff2e3cd0a

    Comments

    Remove prefs::kReverseAutologinEnabled & DisableOneClickSignIn
    
    This patch means removing the preference and functions
    that reference it.
    Because preference is set but never read, that is indeed obsolete.
    
    Bug: 889908
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I22a80bed2387b08480dae9c930bb1d329dd8c45d
    Reviewed-on: https://chromium-review.googlesource.com/c/1264343
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599200}

    Changed files

    • chrome/browser/prefs/browser_prefs.cc
    • chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
    • components/signin/core/browser/signin_manager.cc
    • components/signin/core/browser/signin_manager.h
    • components/signin/core/browser/signin_manager_base.cc
    • components/signin/core/browser/signin_pref_names.cc
    • components/signin/core/browser/signin_pref_names.h
    • ios/chrome/browser/prefs/browser_prefs.mm