Home | Search | chromium - Builders
Login

Builder win-rel Build 4288 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision466b727ac3cd8f967fed05a86562c01616824627
Got Revision466b727ac3cd8f967fed05a86562c01616824627

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  2. Matthew Cary (mattcaryohnoyoudont@chromium.org)
  3. Jaeyong Bae (jdragon.baeohnoyoudont@gmail.com)

Timing:

Create Friday, 12-Oct-18 14:29:40 UTC
Start Friday, 12-Oct-18 14:29:42 UTC
End Friday, 12-Oct-18 14:47:34 UTC
Pending 1 secs
Execution 17 mins 52 secs

All Changes:

  1. Rename method in token service diagnostic observer for clarity

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:27:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 466b727ac3cd8f967fed05a86562c01616824627

    Comments

    Rename method in token service diagnostic observer for clarity
    
    Bug: NONE
    Change-Id: I18d05d59ba0be38d7598396fab2cef8b44647fcf
    Reviewed-on: https://chromium-review.googlesource.com/c/1278754
    Reviewed-by: Thomas Tangl <tangltom@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599202}

    Changed files

    • components/signin/core/browser/about_signin_internals.cc
    • components/signin/core/browser/about_signin_internals.h
    • google_apis/gaia/oauth2_token_service.cc
    • google_apis/gaia/oauth2_token_service.h
  2. Orderfile: skip madvise if ordering has not been done.

    Changed by Matthew Cary - mattcaryohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:19:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ea3132cbbc836b398e523438627cc27349505196

    Comments

    Orderfile: skip madvise if ordering has not been done.
    
    Change a CHECK to an logged warning if madvise is attempted when code
    ordering has not been performed. This happens on upstream builds
    including arm64 builds.
    
    Bug: 894748
    Change-Id: Icdb7ae0c94cfad5beec0215c6186e29135c1079a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278746
    Reviewed-by: Egor Pasko <pasko@chromium.org>
    Reviewed-by: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599201}

    Changed files

    • base/android/library_loader/library_prefetcher.cc
  3. Remove prefs::kReverseAutologinEnabled & DisableOneClickSignIn

    Changed by Jaeyong Bae - jdragon.baeohnoyoudont@gmail.com
    Changed at Friday, 12-Oct-18 14:12:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6e7d226c7a576e4b90de8460df4f11cff2e3cd0a

    Comments

    Remove prefs::kReverseAutologinEnabled & DisableOneClickSignIn
    
    This patch means removing the preference and functions
    that reference it.
    Because preference is set but never read, that is indeed obsolete.
    
    Bug: 889908
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I22a80bed2387b08480dae9c930bb1d329dd8c45d
    Reviewed-on: https://chromium-review.googlesource.com/c/1264343
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599200}

    Changed files

    • chrome/browser/prefs/browser_prefs.cc
    • chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
    • components/signin/core/browser/signin_manager.cc
    • components/signin/core/browser/signin_manager.h
    • components/signin/core/browser/signin_manager_base.cc
    • components/signin/core/browser/signin_pref_names.cc
    • components/signin/core/browser/signin_pref_names.h
    • ios/chrome/browser/prefs/browser_prefs.mm