Home | Search | chromium - Builders
Login

Builder win-asan Build 2466 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revisione324812251510778815829c1b07043b6d53f8414
Got Revisione324812251510778815829c1b07043b6d53f8414

Execution:

Steps and Logfiles:

Show:
  1. ( 781 ms ) setup_build
    running recipe: "chromium"
  2. ( 312 ms ) report builders
     
    running builder/tester 'win-asan' on master 'chromium.memory'
  3. ( 5 secs ) taskkill
  4. ( 10 mins 53 secs ) bot_update
    [111GB/299GB used (37%)]
  5. ( 826 ms ) swarming.py --version
    0.14
  6. ( 36 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.memory.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.memory.json
  8. ( 547 ms ) lookup GN args
     
    enable_ipc_fuzzer = true
    is_asan = true
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    v8_enable_verify_heap = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  9. ( 2 mins 8 secs ) generate_build_files
  10. ( 792 ms ) clang_revision
  11. ( 25 mins 3 secs ) compile
  12. ( 4 mins 10 secs ) compile confirm no-op
  13. ( 9 mins 34 secs ) isolate tests
  14. ( 3 secs ) find isolated tests
  15. ( 2 secs ) wait for tasks
  16. ( 2 secs ) filesystem_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  17. ( 1 secs ) setup_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  18. ( 2 secs ) mojo_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 39s
  19. ( 1 secs ) url_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  20. ( 1 secs ) ipc_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  21. ( 2 secs ) components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 56s
  22. ( 1 secs ) sbox_validation_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  23. ( 1 secs ) gcm_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  24. ( 1 secs ) chrome_elf_import_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 43s
  25. ( 1 secs ) elevation_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  26. ( 1 secs ) chrome_app_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
  27. ( 1 secs ) blink_fuzzer_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  28. ( 1 secs ) libjingle_xmpp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  29. ( 2 secs ) cronet_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  30. ( 1 secs ) courgette_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:41.259844
  31. ( 2 secs ) blink_platform_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:01.219135
  32. ( 1 secs ) capture_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  33. ( 1 secs ) notification_helper_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  34. ( 1 secs ) display_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  35. ( 1 secs ) service_manager_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 30s
  36. ( 1 secs ) latency_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  37. ( 1 secs ) network_service_components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:15.571952
  38. ( 1 secs ) ui_touch_selection_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  39. ( 1 secs ) cast_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  40. ( 1 secs ) accessibility_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 47s
  41. ( 2 secs ) zucchini_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  42. ( 1 secs ) sbox_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  43. ( 2 secs ) app_shell_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 41s
  44. ( 1 secs ) pdf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  45. ( 2 secs ) printing_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  46. ( 1 secs ) sql_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  47. ( 1 secs ) crashpad_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  48. ( 1 secs ) native_theme_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  49. ( 1 secs ) webui_polymer2_interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 51s
  50. ( 2 secs ) chromedriver_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  51. ( 1 secs ) wtf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  52. ( 1 secs ) gcp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 47s
  53. ( 1 secs ) sbox_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  54. ( 2 secs ) device_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 38s
  55. ( 1 secs ) cronet_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  56. ( 1 secs ) traffic_annotation_auditor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  57. ( 1 secs ) nacl_loader_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  58. ( 1 secs ) cacheinvalidation_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  59. ( 1 secs ) perfetto_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:28.438341
  60. ( 1 secs ) crypto_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  61. ( 1 secs ) compositor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 33s
  62. ( 2 secs ) google_apis_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  63. ( 2 secs ) aura_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  64. ( 3 secs ) base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:51.858301
  65. ( 1 secs ) blink_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  66. ( 1 secs ) headless_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  67. ( 4 secs ) angle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:10:23.028039
  68. ( 1 secs ) blink_heap_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 47s
  69. ( 1 secs ) events_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 28s
  70. ( 2 secs ) chrome_cleaner_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:20.876794
  71. ( 1 secs ) installer_util_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  72. ( 1 secs ) boringssl_ssl_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  73. ( 2 secs ) webui_polymer2_browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:01:33.313742 (shard #0)
    Min shard duration: 0:01:13.566881 (shard #3)
  74. ( 1 secs ) midi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  75. ( 1 secs ) mojo_core_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  76. ( 1 secs ) chrome_elf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  77. ( 14 secs ) net_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:45:52.181025
  78. ( 1 secs ) leveldb_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  79. ( 1 secs ) boringssl_crypto_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 44s
  80. ( 1 secs ) install_static_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  81. ( 1 secs ) message_center_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  82. ( 1 secs ) snapshot_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  83. ( 1 secs ) jingle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  84. ( 1 secs ) skia_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  85. ( 2 secs ) media_blink_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 41s
  86. ( 1 secs ) ppapi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  87. ( 1 secs ) gin_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  88. ( 1 secs ) media_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
  89. ( 1 secs ) wait for tasks (2)
  90. ( 1 secs ) vr_pixeltests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  91. ( 2 secs ) ui_base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  92. ( 2 secs ) gfx_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:46.225577
  93. ( 3 secs ) extensions_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:42.747449
  94. ( 1 secs ) extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:15.290235
  95. ( 2 secs ) storage_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  96. ( 3 secs ) content_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:03:36.002428
  97. ( 2 secs ) network_service_extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:42.125747
  98. ( 1 secs ) wm_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  99. ( 4 secs ) gpu_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:34.234566
  100. ( 1 secs ) headless_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:04.279159
  101. ( 2 secs ) viz_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:05:00.924760
  102. ( 2 secs ) cc_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:06:51.479289
  103. ( 5 secs ) media_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:01.713247
  104. ( 2 secs ) vr_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
  105. ( 2 secs ) remoting_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 41s
  106. ( 2 secs ) views_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 36s
  107. ( 2 secs ) services_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:58.498664
  108. ( 1 secs ) wait for tasks (3)
  109. ( 6 secs ) webkit_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:06:52.287764
  110. ( 4 mins 14 secs ) wait for tasks (4)
  111. ( 2 secs ) network_service_interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:13:05.870020 (shard #2)
    Min shard duration: 0:11:11.017052 (shard #1)
  112. ( 10 secs ) components_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:12:48.458401
  113. ( 2 secs ) interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:13:07.287395 (shard #2)
    Min shard duration: 0:11:18.807902 (shard #1)
  114. ( 6 mins 4 secs ) wait for tasks (5)
  115. ( 5 secs ) unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:17:34.577747
  116. ( 2 mins 2 secs ) wait for tasks (6)
  117. ( 2 secs ) sync_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:20:33.224682
  118. ( 4 mins 2 secs ) wait for tasks (7)
  119. ( 1 secs ) shell_dialogs_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:25:04.155463
  120. ( 5 secs ) network_service_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:26:30.184580 (shard #1)
    Min shard duration: 0:24:11.227907 (shard #0)
  121. ( 2 mins 2 secs ) wait for tasks (8)
  122. ( 8 secs ) network_service_browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:29:23.782975 (shard #5)
    Min shard duration: 0:23:26.803690 (shard #9)
  123. ( 8 mins 4 secs ) wait for tasks (9)
  124. ( 10 secs ) browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:37:58.681045 (shard #0)
    Min shard duration: 0:30:31.291089 (shard #4)
  125. ( 3 mins 27 secs ) content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:42:57.216997
  126. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 133
    Total runtime: 17:27:45.434001
     
  127. ( 2 secs ) process_dumps
  128. ( 3 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2923-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544156839547273, "id": "8927827913773357920", "project": "chromium", "tags": ["builder:win-asan", "buildset:commit/git/e324812251510778815829c1b07043b6d53f8414", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/e324812251510778815829c1b07043b6d53f8414", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093257975833074368", "scheduler_job_id:chromium/win-asan", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "win-asan" setup_build
buildnumber 2466 setup_build
mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "e324812251510778815829c1b07043b6d53f8414" setup_build
got_angle_revision "132d15c217e0363626a5d789861b75122f718b5d" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" bot_update
got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" bot_update
got_revision "e324812251510778815829c1b07043b6d53f8414" bot_update
got_revision_cp "refs/heads/master@{#614580}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "2192eb7f7ea45e3a7ee625cf3156f1469abed8b8" bot_update
got_v8_revision_cp "refs/heads/7.3.55@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
got_clang_revision "346388-5" clang_revision
swarm_hashes_refs/heads/master(at){#614580}_without_patch {"accessibility_unittests": "2d9e9097a308b84ab1332409f5dbf5da39516f60", "angle_unittests": "cc69e69430b5bd981b8aec52927e95be3e1de997", "app_shell_unittests": "0ddce8f2b1aef1e2bfa1d6efe257a7b81f91aad1", "aura_unittests": "4d6f274fb67ecd0d7d2397122b8f08f7340851be", "base_unittests": "ea33f1ed0ce76e751bae1ee1754555f67cdee6a4", "blink_common_unittests": "44d15ca0529a7bc0b50cf68993ae9e48038d79dd", "blink_fuzzer_unittests": "4be26f1e6e749049127576b9f5caac22b42a1f02", "blink_heap_unittests": "fedee553f38f3a9d8ed4d2f788344208f9d1b545", "blink_platform_unittests": "667651949a53792b784fd88aa073c77db7aa15c1", "boringssl_crypto_tests": "d10762596698bf828dae0c0903c494f8c15ef429", "boringssl_ssl_tests": "c3e1c2fb6fb67f7e51ba98159a56c5c8f22ef0ba", "browser_tests": "69c2c35781ef1da21c78dd406c4539be9e917441", "cacheinvalidation_unittests": "53278b85961e568b5d2838d3415157bdfcea0159", "capture_unittests": "6fc12182042f09cc23aa9440acafdecd691868b4", "cast_unittests": "f7b52d8ccf5232b1df7e70ac444b6ff07b07ce0d", "cc_unittests": "12dd4cf6236aff3d051ae4e16464ea9f6b41cc16", "chrome_app_unittests": "b4e0bf2b67c07c75d96e1e38ba245e573668169a", "chrome_cleaner_unittests": "6de2fac7a67e1bb2c5c98e7ea681a38441dd7858", "chrome_elf_import_unittests": "9fb94ccc4aa306224a2de48be237605d0b98e445", "chrome_elf_unittests": "e544f94dbff0b33be7edf011b77dcc3cd4cdcb2c", "chromedriver_unittests": "3bb7fbe435f0692e4dd6841dc179d37416d606cb", "components_browsertests": "f19f8ea49f7a9b419463eff204281e9e72b80e78", "components_unittests": "54f360045b1ee4790ae0b277f8096c290a779d90", "compositor_unittests": "1321922d1188e664e15ac0d216c8f2b7dcea10f9", "content_browsertests": "b5f4cf647891b10a769e02c0590451cca7380ada", "content_unittests": "071d8566405fdb7f347b5235595496884c7d0ab6", "courgette_unittests": "fcfa241cf46a731225665c191ea5314900024261", "crashpad_tests": "97a74ff20119c6df59bf5ecd76a1edaa112ab3e0", "cronet_tests": "d1353d0dc54e9009be6bb17688f020d7383e1a44", "cronet_unittests": "9a210a18d7122266cf4c5003a2c7144f29f41375", "crypto_unittests": "f53d14bf20815401919969593eb4f49142a320d8", "device_unittests": "2e009fb5c3e9d8d608409f089dad4714ee32dd1c", "display_unittests": "685cdd196f84709a55d98162dadd9798570fd4a1", "elevation_service_unittests": "b6bd2c8003ad2b974e68cb39549cf7ce82395797", "events_unittests": "78ba4f7817facb096efd204b57aff316d8ca32f0", "extensions_browsertests": "5a884b98bb05a91d9f0c15f29fbddd1fcbe7ffde", "extensions_unittests": "bb5cc1a63a3d02b5f68071f4fe8eefbbaad02d85", "filesystem_service_unittests": "dc20528f47aa01d577b9395d5de91b03421ccdf7", "gcm_unit_tests": "8d26beb93c3bd71367aa4dbfe91b71fd127bd692", "gcp_unittests": "46a1ff0f668a3edefcc7cfa23d291cac68e27225", "gfx_unittests": "5d5e487d90a5245152ec0950f79c369c34418762", "gin_unittests": "5a2c2cd09a906f4d51190711d5575ce5962406ef", "google_apis_unittests": "a5c0c37648704f1f89afcc25b644340ad21b9467", "gpu_unittests": "d1080fea27366527bde25ea07f631489408a673a", "headless_browsertests": "ddb1d5880cd16d6fa8ea89d779bf04e596434782", "headless_unittests": "ad0c19a05ed04f47ee0b31d828f1b64567679433", "install_static_unittests": "3aa745200a220cba0dcc0e0894d8f8f4d9f053bd", "installer_util_unittests": "fea81b4b48746afbae43b7d8e31b73d0b3c51ac6", "interactive_ui_tests": "e004abb0b7d5437ebbb3b54de65b2b026ccaafbf", "ipc_tests": "ea1bd71fb214854ff2dc90ccc2dcedb61610b6a1", "jingle_unittests": "242af379bb7da76e1f9bb1febe804032973c88d9", "latency_unittests": "59de4b6630e37c958589c1e04776ed77180d4166", "leveldb_service_unittests": "acb94071b17b8e52e55b3edaf753a46604f6fa38", "libjingle_xmpp_unittests": "9004ed8669287178283a79d99f1ad753c948431d", "media_blink_unittests": "71fa34f525176dfea58fcd45517c84d1666a6360", "media_service_unittests": "bb2a6b668d47ba75f95ca4d2b6c2d19c8596457e", "media_unittests": "63415ee6090acada60967b64520312b8dc21f58d", "message_center_unittests": "32584b4795886b29edf2c64c9ee8b40bc30d09bc", "midi_unittests": "be219ccb1bb970413e1e5335bcf0a94fd223d839", "mojo_core_unittests": "4d009001e99057c6c1e4eb2ee5b60148e3394c9c", "mojo_unittests": "77862e5bede24e1f40cd7ee14a16cc1cc0146adc", "nacl_loader_unittests": "c76c35bf8509e63e70ecf3d4e1add6d8ca0556c1", "native_theme_unittests": "06e8a16276b5925a5202b64d6072a6a1937f886f", "net_unittests": "1961f83d13c3b983829b98c75200bd5eb773edfa", "notification_helper_unittests": "4f3e1ebe7ec6c9e8653811fab6505d242ae57965", "pdf_unittests": "3f2af2930e5aa370a68b23641e86980b8e66a34e", "ppapi_unittests": "714e642d512d1194cf48e6beacd0fb5c40c0d1e7", "printing_unittests": "93b1718bb2e7f4e1aa61cb30a388a36c9bcdb551", "remoting_unittests": "d31836292797a31b1b7838bb4691d83c69329af7", "sbox_integration_tests": "290dae441aef05cf7a04959672d6558d2860110f", "sbox_unittests": "bdeabe22732c9a94ab455a82b83274db15cb4ec6", "sbox_validation_tests": "8289edbb9e592fb0d8ad21d64119dcde3090a6d4", "service_manager_unittests": "87a863dc6eb77b22bbe586e51086429656306a38", "services_unittests": "d8523dcc21cbab347ad4902c8c194153f845893b", "setup_unittests": "3889a7adc2af9718c13702586d7910a595375019", "shell_dialogs_unittests": "025a4910e7c578411a5b0cfd1e7c6f39c3bcf856", "skia_unittests": "b7efb82b647029058d4d785275d41f0521404009", "snapshot_unittests": "93f7eb3eb41a6fd17947fce996fa1b0067544f46", "sql_unittests": "069d6145876ee9b75511482c3adcb07a7d61c05d", "storage_unittests": "c0ff49f049f491d87c695fec82fbf5808d7464d7", "sync_integration_tests": "3e7081ef8e42230823ca74a4b5fd51cd4390c3a2", "traffic_annotation_auditor_unittests": "a1c5711e51422601b44a65ee0e23b2f10795caf1", "ui_base_unittests": "e65e19fe6e153b1c4a751f3ddc9cba2d5431ca0b", "ui_touch_selection_unittests": "100825768665abc46b0a173884d8db4a010c48b5", "unit_tests": "bc266186af6c5901e6c7b2f2882130db4a73e168", "url_unittests": "1e8617f6c975f933e0286d51c7523bacfd98e739", "views_unittests": "96e434a6a9be55cd0f51646168eeb17c27d74ef5", "viz_unittests": "a1847c71f43bcc382b9bb03952968ab7c873fd3f", "vr_common_unittests": "a38156c8d9c4b60f26bf5d810b7b0816922160c5", "vr_pixeltests": "4cb4b5f019d609f81b21f765adc51b0419a94f3b", "webkit_unit_tests": "522b933130fa3bf032aa8f42bb4b2287261eb29a", "wm_unittests": "5e4224ed8f646be7e164e46e09e715ac71b9af90", "wtf_unittests": "d46e14c8a519b78515d0fe289a86b98d0bb15be8", "zucchini_unittests": "cc3d2abcba8eee3929839acc488fdf2d8738e8cb"} isolate tests
swarm_hashes {"accessibility_unittests": "2d9e9097a308b84ab1332409f5dbf5da39516f60", "angle_unittests": "cc69e69430b5bd981b8aec52927e95be3e1de997", "app_shell_unittests": "0ddce8f2b1aef1e2bfa1d6efe257a7b81f91aad1", "aura_unittests": "4d6f274fb67ecd0d7d2397122b8f08f7340851be", "base_unittests": "ea33f1ed0ce76e751bae1ee1754555f67cdee6a4", "blink_common_unittests": "44d15ca0529a7bc0b50cf68993ae9e48038d79dd", "blink_fuzzer_unittests": "4be26f1e6e749049127576b9f5caac22b42a1f02", "blink_heap_unittests": "fedee553f38f3a9d8ed4d2f788344208f9d1b545", "blink_platform_unittests": "667651949a53792b784fd88aa073c77db7aa15c1", "boringssl_crypto_tests": "d10762596698bf828dae0c0903c494f8c15ef429", "boringssl_ssl_tests": "c3e1c2fb6fb67f7e51ba98159a56c5c8f22ef0ba", "browser_tests": "69c2c35781ef1da21c78dd406c4539be9e917441", "cacheinvalidation_unittests": "53278b85961e568b5d2838d3415157bdfcea0159", "capture_unittests": "6fc12182042f09cc23aa9440acafdecd691868b4", "cast_unittests": "f7b52d8ccf5232b1df7e70ac444b6ff07b07ce0d", "cc_unittests": "12dd4cf6236aff3d051ae4e16464ea9f6b41cc16", "chrome_app_unittests": "b4e0bf2b67c07c75d96e1e38ba245e573668169a", "chrome_cleaner_unittests": "6de2fac7a67e1bb2c5c98e7ea681a38441dd7858", "chrome_elf_import_unittests": "9fb94ccc4aa306224a2de48be237605d0b98e445", "chrome_elf_unittests": "e544f94dbff0b33be7edf011b77dcc3cd4cdcb2c", "chromedriver_unittests": "3bb7fbe435f0692e4dd6841dc179d37416d606cb", "components_browsertests": "f19f8ea49f7a9b419463eff204281e9e72b80e78", "components_unittests": "54f360045b1ee4790ae0b277f8096c290a779d90", "compositor_unittests": "1321922d1188e664e15ac0d216c8f2b7dcea10f9", "content_browsertests": "b5f4cf647891b10a769e02c0590451cca7380ada", "content_unittests": "071d8566405fdb7f347b5235595496884c7d0ab6", "courgette_unittests": "fcfa241cf46a731225665c191ea5314900024261", "crashpad_tests": "97a74ff20119c6df59bf5ecd76a1edaa112ab3e0", "cronet_tests": "d1353d0dc54e9009be6bb17688f020d7383e1a44", "cronet_unittests": "9a210a18d7122266cf4c5003a2c7144f29f41375", "crypto_unittests": "f53d14bf20815401919969593eb4f49142a320d8", "device_unittests": "2e009fb5c3e9d8d608409f089dad4714ee32dd1c", "display_unittests": "685cdd196f84709a55d98162dadd9798570fd4a1", "elevation_service_unittests": "b6bd2c8003ad2b974e68cb39549cf7ce82395797", "events_unittests": "78ba4f7817facb096efd204b57aff316d8ca32f0", "extensions_browsertests": "5a884b98bb05a91d9f0c15f29fbddd1fcbe7ffde", "extensions_unittests": "bb5cc1a63a3d02b5f68071f4fe8eefbbaad02d85", "filesystem_service_unittests": "dc20528f47aa01d577b9395d5de91b03421ccdf7", "gcm_unit_tests": "8d26beb93c3bd71367aa4dbfe91b71fd127bd692", "gcp_unittests": "46a1ff0f668a3edefcc7cfa23d291cac68e27225", "gfx_unittests": "5d5e487d90a5245152ec0950f79c369c34418762", "gin_unittests": "5a2c2cd09a906f4d51190711d5575ce5962406ef", "google_apis_unittests": "a5c0c37648704f1f89afcc25b644340ad21b9467", "gpu_unittests": "d1080fea27366527bde25ea07f631489408a673a", "headless_browsertests": "ddb1d5880cd16d6fa8ea89d779bf04e596434782", "headless_unittests": "ad0c19a05ed04f47ee0b31d828f1b64567679433", "install_static_unittests": "3aa745200a220cba0dcc0e0894d8f8f4d9f053bd", "installer_util_unittests": "fea81b4b48746afbae43b7d8e31b73d0b3c51ac6", "interactive_ui_tests": "e004abb0b7d5437ebbb3b54de65b2b026ccaafbf", "ipc_tests": "ea1bd71fb214854ff2dc90ccc2dcedb61610b6a1", "jingle_unittests": "242af379bb7da76e1f9bb1febe804032973c88d9", "latency_unittests": "59de4b6630e37c958589c1e04776ed77180d4166", "leveldb_service_unittests": "acb94071b17b8e52e55b3edaf753a46604f6fa38", "libjingle_xmpp_unittests": "9004ed8669287178283a79d99f1ad753c948431d", "media_blink_unittests": "71fa34f525176dfea58fcd45517c84d1666a6360", "media_service_unittests": "bb2a6b668d47ba75f95ca4d2b6c2d19c8596457e", "media_unittests": "63415ee6090acada60967b64520312b8dc21f58d", "message_center_unittests": "32584b4795886b29edf2c64c9ee8b40bc30d09bc", "midi_unittests": "be219ccb1bb970413e1e5335bcf0a94fd223d839", "mojo_core_unittests": "4d009001e99057c6c1e4eb2ee5b60148e3394c9c", "mojo_unittests": "77862e5bede24e1f40cd7ee14a16cc1cc0146adc", "nacl_loader_unittests": "c76c35bf8509e63e70ecf3d4e1add6d8ca0556c1", "native_theme_unittests": "06e8a16276b5925a5202b64d6072a6a1937f886f", "net_unittests": "1961f83d13c3b983829b98c75200bd5eb773edfa", "notification_helper_unittests": "4f3e1ebe7ec6c9e8653811fab6505d242ae57965", "pdf_unittests": "3f2af2930e5aa370a68b23641e86980b8e66a34e", "ppapi_unittests": "714e642d512d1194cf48e6beacd0fb5c40c0d1e7", "printing_unittests": "93b1718bb2e7f4e1aa61cb30a388a36c9bcdb551", "remoting_unittests": "d31836292797a31b1b7838bb4691d83c69329af7", "sbox_integration_tests": "290dae441aef05cf7a04959672d6558d2860110f", "sbox_unittests": "bdeabe22732c9a94ab455a82b83274db15cb4ec6", "sbox_validation_tests": "8289edbb9e592fb0d8ad21d64119dcde3090a6d4", "service_manager_unittests": "87a863dc6eb77b22bbe586e51086429656306a38", "services_unittests": "d8523dcc21cbab347ad4902c8c194153f845893b", "setup_unittests": "3889a7adc2af9718c13702586d7910a595375019", "shell_dialogs_unittests": "025a4910e7c578411a5b0cfd1e7c6f39c3bcf856", "skia_unittests": "b7efb82b647029058d4d785275d41f0521404009", "snapshot_unittests": "93f7eb3eb41a6fd17947fce996fa1b0067544f46", "sql_unittests": "069d6145876ee9b75511482c3adcb07a7d61c05d", "storage_unittests": "c0ff49f049f491d87c695fec82fbf5808d7464d7", "sync_integration_tests": "3e7081ef8e42230823ca74a4b5fd51cd4390c3a2", "traffic_annotation_auditor_unittests": "a1c5711e51422601b44a65ee0e23b2f10795caf1", "ui_base_unittests": "e65e19fe6e153b1c4a751f3ddc9cba2d5431ca0b", "ui_touch_selection_unittests": "100825768665abc46b0a173884d8db4a010c48b5", "unit_tests": "bc266186af6c5901e6c7b2f2882130db4a73e168", "url_unittests": "1e8617f6c975f933e0286d51c7523bacfd98e739", "views_unittests": "96e434a6a9be55cd0f51646168eeb17c27d74ef5", "viz_unittests": "a1847c71f43bcc382b9bb03952968ab7c873fd3f", "vr_common_unittests": "a38156c8d9c4b60f26bf5d810b7b0816922160c5", "vr_pixeltests": "4cb4b5f019d609f81b21f765adc51b0419a94f3b", "webkit_unit_tests": "522b933130fa3bf032aa8f42bb4b2287261eb29a", "wm_unittests": "5e4224ed8f646be7e164e46e09e715ac71b9af90", "wtf_unittests": "d46e14c8a519b78515d0fe289a86b98d0bb15be8", "zucchini_unittests": "cc3d2abcba8eee3929839acc488fdf2d8738e8cb"} find isolated tests

Blamelist:

  1. chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
  2. Takashi Sakamoto (tasakohnoyoudont@google.com)
  3. Takashi Sakamoto (tasakohnoyoudont@google.com)
  4. Dan Beam (dbeamohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 04:27:19 UTC
Start Friday, 07-Dec-18 04:27:21 UTC
End Friday, 07-Dec-18 06:17:46 UTC
Pending 2 secs
Execution 1 hrs 50 mins

All Changes:

  1. Updating trunk VERSION from 3633.0 to 3634.0

    Changed by chrome-release-bot - chrome-release-botohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:11:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e324812251510778815829c1b07043b6d53f8414

    Comments

    Updating trunk VERSION from 3633.0 to 3634.0
    
    # This is an automated release commit.
    # Do not revert without consulting chrome-pmo@google.com.
    NOAUTOREVERT=true
    TBR=mmoss@chromium.org
    
    Change-Id: I042e2caf928b9a12422f14eccec3e8f33ead12d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1366874
    Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614580}

    Changed files

    • chrome/VERSION
  2. Revert "cros: Move most event/widget handling logic out of LoginBubble"

    Changed by Takashi Sakamoto - tasakohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 03:49:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bb9ca465cac1a3ec4d0670844865b40efb003c11

    Comments

    Revert "cros: Move most event/widget handling logic out of LoginBubble"
    
    This reverts commit a61287973e8f4522ed673ac1a77de0dc56eb1bc8.
    
    Reason for revert: Suspect Failure single_process_mash_ash_unittests Failure ash_unittests:
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/16943
    https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927839167159249024/+/steps/single_process_mash_ash_unittests/0/logs/LoginExpandedPublicAccountViewTest.ChangeMenuSelection/0
    ---
    [ RUN      ] LoginExpandedPublicAccountViewTest.ChangeMenuSelection
    Received signal 11 SEGV_MAPERR ffffe03f000008fe
    #0 0x5631a3caedbf base::debug::StackTrace::StackTrace()
    #1 0x5631a3cae941 base::debug::(anonymous namespace)::StackDumpSignalHandler()
    #2 0x7faa9920f330 <unknown>
    #3 0x5631a3aafbbf ash::LoginBubble::~LoginBubble()
    #4 0x5631a3ab806c ash::RightPaneView::~RightPaneView()
    #5 0x5631a3ab810e ash::RightPaneView::~RightPaneView()
    #6 0x5631a40385d4 views::View::~View()
    #7 0x5631a3ab6df9 ash::LoginExpandedPublicAccountView::~LoginExpandedPublicAccountView()
    #8 0x5631a40385d4 views::View::~View()
    #9 0x5631a300afce ash::(anonymous namespace)::DragTestView::~DragTestView()
    #10 0x5631a4039b42 views::View::DoRemoveChildView()
    #11 0x5631a403a175 views::View::RemoveAllChildViews()
    #12 0x5631a4043b81 views::internal::RootView::~RootView()
    #13 0x5631a400ef0e views::MenuHostRootView::~MenuHostRootView()
    #14 0x5631a404615f views::Widget::~Widget()
    #15 0x5631a34d645e exo::(anonymous namespace)::ShellSurfaceWidget::~ShellSurfaceWidget()
    #16 0x5631a30c36f0 ash::LoginTestBase::TearDown()
    
    Original change's description:
    > cros: Move most event/widget handling logic out of LoginBubble
    > 
    > Changes made:
    > - Move the (keyboard/click/tap) event handling logic into a
    >   LoginBubbleHandler class.
    > - Move the widget handling into LoginBaseBubbleView itself
    > 
    > Bug: 912658
    > Change-Id: Ia1a9bf4b8d847ef74ef1716e73dfe1b16b8d19b2
    > Reviewed-on: https://chromium-review.googlesource.com/c/1366516
    > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    > Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614544}
    
    TBR=jdufault@chromium.org,qnnguyen@chromium.org
    
    Change-Id: Ia9b9059f24f6aa6a8551c5c6bc5c76caafe592df
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 912658
    Reviewed-on: https://chromium-review.googlesource.com/c/1367070
    Reviewed-by: Takashi Sakamoto <tasak@google.com>
    Commit-Queue: Takashi Sakamoto <tasak@google.com>
    Cr-Commit-Position: refs/heads/master@{#614579}

    Changed files

    • ash/login/ui/login_base_bubble_view.cc
    • ash/login/ui/login_base_bubble_view.h
    • ash/login/ui/login_bubble.cc
    • ash/login/ui/login_bubble.h
  3. Revert "Updating XTBs based on .GRDs from branch master"

    Changed by Takashi Sakamoto - tasakohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 03:43:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df02e792b693ed5007b5c8c4866203219bedfd20

    Comments

    Revert "Updating XTBs based on .GRDs from branch master"
    
    This reverts commit c7424053a784c4d07dcd4617d68a1f2ac7f9657b.
    
    Reason for revert: suspect Android compile failure:
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel
    https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927834375124899248/+/steps/compile/0/stdout
    ---
    ../resource_zips/chrome/android/chrome_strings_grd.resources.zip/values-fr/android_chrome_strings.xml:364 Inconsistent number of arguments in formatting string `data_reduction_benefits_description`; found both 0 and 1: StringFormatCount [warning]
    <string name="data_reduction_benefits_description">"En mode simplifié, Chrome charge les pages plus rapidement et consomme jusqu\'à 60 % de données en moins."</string>
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../resource_zips/chrome/android/chrome_strings_grd.resources.zip/values-fr/android_chrome_strings.xml:389 Inconsistent number of arguments in formatting string `data_reduction_promo_summary`; found both 0 and 1: StringFormatCount [warning]
    <string name="data_reduction_promo_summary">"En mode simplifié, Chrome charge les pages plus rapidement et consomme jusqu\'à 60 % de données en moins. La technologie cloud de Google optimise les pages que vous consultez."</string>
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    Original change's description:
    > Updating XTBs based on .GRDs from branch master
    > 
    > R=​abdulsyed@chromium.org
    > 
    > Change-Id: Ibc94ee5be9db75306313d34881e4026a681eec1d
    > Reviewed-on: https://chromium-review.googlesource.com/c/1366870
    > Reviewed-by: Krishna Govind <govind@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614569}
    
    TBR=govind@chromium.org,abdulsyed@chromium.org
    
    Change-Id: I4dfd803c9c148e5d6e3335d11e06fd61728fe548
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1366465
    Reviewed-by: Takashi Sakamoto <tasak@google.com>
    Commit-Queue: Takashi Sakamoto <tasak@google.com>
    Cr-Commit-Position: refs/heads/master@{#614578}

    Changed files

    • ash/components/strings/ash_components_strings_te.xtb
    • ash/strings/ash_strings_am.xtb
    • ash/strings/ash_strings_ar.xtb
    • ash/strings/ash_strings_bn.xtb
    • ash/strings/ash_strings_ca.xtb
    • ash/strings/ash_strings_cs.xtb
    • ash/strings/ash_strings_de.xtb
    • ash/strings/ash_strings_el.xtb
    • ash/strings/ash_strings_en-GB.xtb
    • ash/strings/ash_strings_fa.xtb
    • ash/strings/ash_strings_fi.xtb
    • ash/strings/ash_strings_fr.xtb
    • ash/strings/ash_strings_gu.xtb
    • ash/strings/ash_strings_hr.xtb
    • ash/strings/ash_strings_hu.xtb
    • ash/strings/ash_strings_id.xtb
    • ash/strings/ash_strings_it.xtb
    • ash/strings/ash_strings_kn.xtb
    • ash/strings/ash_strings_lt.xtb
    • ash/strings/ash_strings_lv.xtb
    • ash/strings/ash_strings_ml.xtb
    • ash/strings/ash_strings_nl.xtb
    • ash/strings/ash_strings_pl.xtb
    • ash/strings/ash_strings_pt-BR.xtb
    • ash/strings/ash_strings_pt-PT.xtb
    • ash/strings/ash_strings_ru.xtb
    • ash/strings/ash_strings_sk.xtb
    • ash/strings/ash_strings_sl.xtb
    • ash/strings/ash_strings_sr.xtb
    • ash/strings/ash_strings_sv.xtb
    • ash/strings/ash_strings_sw.xtb
    • ash/strings/ash_strings_te.xtb
    • ash/strings/ash_strings_th.xtb
    • ash/strings/ash_strings_tr.xtb
    • ash/strings/ash_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_am.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ar.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bg.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bn.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ca.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_cs.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_da.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_de.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_el.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_en-GB.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es-419.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fa.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fil.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_gu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_id.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_it.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_iw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ja.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_kn.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lt.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ml.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_nl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pt-BR.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pt-PT.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ru.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ta.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_te.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_th.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_tr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-CN.xtb
    • chrome/app/resources/chromium_strings_te.xtb
    • chrome/app/resources/generated_resources_am.xtb
    • chrome/app/resources/generated_resources_ar.xtb
    • chrome/app/resources/generated_resources_bg.xtb
    • chrome/app/resources/generated_resources_bn.xtb
    • chrome/app/resources/generated_resources_ca.xtb
    • chrome/app/resources/generated_resources_cs.xtb
    • chrome/app/resources/generated_resources_da.xtb
    • chrome/app/resources/generated_resources_de.xtb
    • chrome/app/resources/generated_resources_el.xtb
    • chrome/app/resources/generated_resources_en-GB.xtb
    • chrome/app/resources/generated_resources_es-419.xtb
    • chrome/app/resources/generated_resources_es.xtb
    • chrome/app/resources/generated_resources_et.xtb
    • chrome/app/resources/generated_resources_fa.xtb
    • chrome/app/resources/generated_resources_fi.xtb
    • chrome/app/resources/generated_resources_fil.xtb
    • chrome/app/resources/generated_resources_fr.xtb
    • chrome/app/resources/generated_resources_gu.xtb
    • chrome/app/resources/generated_resources_hi.xtb
    • chrome/app/resources/generated_resources_hr.xtb
    • chrome/app/resources/generated_resources_hu.xtb
    • chrome/app/resources/generated_resources_id.xtb
    • chrome/app/resources/generated_resources_it.xtb
    • chrome/app/resources/generated_resources_iw.xtb
    • chrome/app/resources/generated_resources_ja.xtb
    • chrome/app/resources/generated_resources_kn.xtb
    • chrome/app/resources/generated_resources_ko.xtb
    • chrome/app/resources/generated_resources_lt.xtb
    • chrome/app/resources/generated_resources_lv.xtb
    • chrome/app/resources/generated_resources_ml.xtb
    • chrome/app/resources/generated_resources_mr.xtb
    • chrome/app/resources/generated_resources_ms.xtb
    • chrome/app/resources/generated_resources_nl.xtb
    • chrome/app/resources/generated_resources_no.xtb
    • chrome/app/resources/generated_resources_pl.xtb
    • chrome/app/resources/generated_resources_pt-BR.xtb
    • chrome/app/resources/generated_resources_pt-PT.xtb
    • chrome/app/resources/generated_resources_ro.xtb
    • chrome/app/resources/generated_resources_ru.xtb
    • chrome/app/resources/generated_resources_sk.xtb
    • chrome/app/resources/generated_resources_sl.xtb
    • chrome/app/resources/generated_resources_sr.xtb
    • chrome/app/resources/generated_resources_sv.xtb
    • chrome/app/resources/generated_resources_sw.xtb
    • chrome/app/resources/generated_resources_ta.xtb
    • chrome/app/resources/generated_resources_te.xtb
    • chrome/app/resources/generated_resources_th.xtb
    • chrome/app/resources/generated_resources_tr.xtb
    • chrome/app/resources/generated_resources_uk.xtb
    • chrome/app/resources/generated_resources_vi.xtb
    • chrome/app/resources/generated_resources_zh-CN.xtb
    • chrome/app/resources/generated_resources_zh-TW.xtb
    • chrome/app/resources/google_chrome_strings_te.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_am.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ar.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_bg.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ca.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_cs.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_da.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_de.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_el.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_en-GB.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es-419.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_et.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fa.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fil.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hu.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_id.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_it.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ja.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ko.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lt.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lv.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ms.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_nl.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_no.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pl.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-BR.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-PT.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ro.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ru.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sk.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sv.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sw.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ta.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_th.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_tr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_uk.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_vi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-CN.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-TW.xtb
    • components/policy/resources/policy_templates_am.xtb
    • components/policy/resources/policy_templates_ar.xtb
    • components/policy/resources/policy_templates_bn.xtb
    • components/policy/resources/policy_templates_ca.xtb
    • components/policy/resources/policy_templates_cs.xtb
    • components/policy/resources/policy_templates_de.xtb
    • components/policy/resources/policy_templates_el.xtb
    • components/policy/resources/policy_templates_en-GB.xtb
    • components/policy/resources/policy_templates_es-419.xtb
    • components/policy/resources/policy_templates_fa.xtb
    • components/policy/resources/policy_templates_fi.xtb
    • components/policy/resources/policy_templates_fr.xtb
    • components/policy/resources/policy_templates_hr.xtb
    • components/policy/resources/policy_templates_id.xtb
    • components/policy/resources/policy_templates_it.xtb
    • components/policy/resources/policy_templates_kn.xtb
    • components/policy/resources/policy_templates_ml.xtb
    • components/policy/resources/policy_templates_nl.xtb
    • components/policy/resources/policy_templates_pl.xtb
    • components/policy/resources/policy_templates_pt-BR.xtb
    • components/policy/resources/policy_templates_pt-PT.xtb
    • components/policy/resources/policy_templates_ru.xtb
    • components/policy/resources/policy_templates_sk.xtb
    • components/policy/resources/policy_templates_sr.xtb
    • components/policy/resources/policy_templates_sv.xtb
    • components/policy/resources/policy_templates_sw.xtb
    • components/policy/resources/policy_templates_ta.xtb
    • components/policy/resources/policy_templates_te.xtb
    • components/policy/resources/policy_templates_th.xtb
    • components/policy/resources/policy_templates_tr.xtb
    • components/policy/resources/policy_templates_uk.xtb
    • components/policy/resources/policy_templates_vi.xtb
    • components/strings/components_strings_am.xtb
    • components/strings/components_strings_ar.xtb
    • components/strings/components_strings_bg.xtb
    • components/strings/components_strings_bn.xtb
    • components/strings/components_strings_ca.xtb
    • components/strings/components_strings_cs.xtb
    • components/strings/components_strings_da.xtb
    • components/strings/components_strings_de.xtb
    • components/strings/components_strings_el.xtb
    • components/strings/components_strings_en-GB.xtb
    • components/strings/components_strings_es-419.xtb
    • components/strings/components_strings_es.xtb
    • components/strings/components_strings_et.xtb
    • components/strings/components_strings_fa.xtb
    • components/strings/components_strings_fi.xtb
    • components/strings/components_strings_fil.xtb
    • components/strings/components_strings_fr.xtb
    • components/strings/components_strings_gu.xtb
    • components/strings/components_strings_hi.xtb
    • components/strings/components_strings_hr.xtb
    • components/strings/components_strings_hu.xtb
    • components/strings/components_strings_id.xtb
    • components/strings/components_strings_it.xtb
    • components/strings/components_strings_iw.xtb
    • components/strings/components_strings_ja.xtb
    • components/strings/components_strings_kn.xtb
    • components/strings/components_strings_ko.xtb
    • components/strings/components_strings_lt.xtb
    • components/strings/components_strings_lv.xtb
    • components/strings/components_strings_ml.xtb
    • components/strings/components_strings_mr.xtb
    • components/strings/components_strings_ms.xtb
    • components/strings/components_strings_nl.xtb
    • components/strings/components_strings_no.xtb
    • components/strings/components_strings_pl.xtb
    • components/strings/components_strings_pt-BR.xtb
    • components/strings/components_strings_pt-PT.xtb
    • components/strings/components_strings_ro.xtb
    • components/strings/components_strings_ru.xtb
    • components/strings/components_strings_sk.xtb
    • components/strings/components_strings_sl.xtb
    • components/strings/components_strings_sr.xtb
    • components/strings/components_strings_sv.xtb
    • components/strings/components_strings_sw.xtb
    • components/strings/components_strings_ta.xtb
    • components/strings/components_strings_te.xtb
    • components/strings/components_strings_th.xtb
    • components/strings/components_strings_tr.xtb
    • components/strings/components_strings_uk.xtb
    • components/strings/components_strings_vi.xtb
    • components/strings/components_strings_zh-CN.xtb
    • components/strings/components_strings_zh-TW.xtb
    • content/app/strings/translations/content_strings_te.xtb
    • extensions/strings/extensions_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_google_chrome_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_am.xtb
    • ios/chrome/app/strings/resources/ios_strings_ar.xtb
    • ios/chrome/app/strings/resources/ios_strings_bn.xtb
    • ios/chrome/app/strings/resources/ios_strings_ca.xtb
    • ios/chrome/app/strings/resources/ios_strings_cs.xtb
    • ios/chrome/app/strings/resources/ios_strings_de.xtb
    • ios/chrome/app/strings/resources/ios_strings_el.xtb
    • ios/chrome/app/strings/resources/ios_strings_en-GB.xtb
    • ios/chrome/app/strings/resources/ios_strings_fa.xtb
    • ios/chrome/app/strings/resources/ios_strings_fi.xtb
    • ios/chrome/app/strings/resources/ios_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_strings_fr.xtb
    • ios/chrome/app/strings/resources/ios_strings_gu.xtb
    • ios/chrome/app/strings/resources/ios_strings_hr.xtb
    • ios/chrome/app/strings/resources/ios_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_strings_id.xtb
    • ios/chrome/app/strings/resources/ios_strings_it.xtb
    • ios/chrome/app/strings/resources/ios_strings_ja.xtb
    • ios/chrome/app/strings/resources/ios_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_strings_lv.xtb
    • ios/chrome/app/strings/resources/ios_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_strings_nl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-BR.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-PT.xtb
    • ios/chrome/app/strings/resources/ios_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_strings_sk.xtb
    • ios/chrome/app/strings/resources/ios_strings_sl.xtb
    • ios/chrome/app/strings/resources/ios_strings_sr.xtb
    • ios/chrome/app/strings/resources/ios_strings_sv.xtb
    • ios/chrome/app/strings/resources/ios_strings_sw.xtb
    • ios/chrome/app/strings/resources/ios_strings_ta.xtb
    • ios/chrome/app/strings/resources/ios_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_strings_tr.xtb
    • ios/chrome/app/strings/resources/ios_strings_uk.xtb
    • remoting/resources/remoting_strings_am.xtb
    • remoting/resources/remoting_strings_ar.xtb
    • remoting/resources/remoting_strings_bn.xtb
    • remoting/resources/remoting_strings_es.xtb
    • remoting/resources/remoting_strings_gu.xtb
    • remoting/resources/remoting_strings_hu.xtb
    • remoting/resources/remoting_strings_id.xtb
    • remoting/resources/remoting_strings_kn.xtb
    • remoting/resources/remoting_strings_lt.xtb
    • remoting/resources/remoting_strings_lv.xtb
    • remoting/resources/remoting_strings_ml.xtb
    • remoting/resources/remoting_strings_ru.xtb
    • remoting/resources/remoting_strings_sl.xtb
    • remoting/resources/remoting_strings_sr.xtb
    • remoting/resources/remoting_strings_te.xtb
    • remoting/resources/remoting_strings_th.xtb
    • remoting/resources/remoting_strings_tr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_am.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ar.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_bg.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_bn.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ca.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_cs.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_da.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_de.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_el.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_en-GB.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_es-419.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_es.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_et.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fa.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fil.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_gu.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hu.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_id.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_it.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_iw.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ja.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_kn.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ko.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_lt.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_lv.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ml.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_mr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ms.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_nl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_no.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pt-BR.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pt-PT.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ru.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sk.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sv.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sw.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ta.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_th.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_tr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_uk.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_vi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_zh-CN.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_zh-TW.xtb
    • ui/chromeos/translations/ui_chromeos_strings_te.xtb
  4. Revert "Enable warmer welcome during Assistant launch."

    Changed by Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 02:41:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c71812f1007dae45bce45b451c384bf9c0dbd356

    Comments

    Revert "Enable warmer welcome during Assistant launch."
    
    This reverts commit 29dca9fe6ae866266c976809adc33c09a2ca1088.
    
    Reason for revert:
      ../../chromeos/services/assistant/assistant_manager_service_impl.cc:27:10: fatal error: 'chromeos/services/assistant/assistant_warmer_welcome_log.pb.h' file not found
      #include "chromeos/services/assistant/assistant_warmer_welcome_log.pb.h"
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      1 error generated.
    
    https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_ChromeOS/59389/+/recipes/steps/compile/0/stdout
    
    Original change's description:
    > Enable warmer welcome during Assistant launch.
    > 
    > 1. It is guarded by a finch flag AssistantWarmerWelcome.
    > 2. WW only shows 3 times.
    > 
    > Bug: b:112495005
    > Test: Manual
    > 
    > Change-Id: I80cbcfd4104c17172939d36b986be65077bf0bb3
    > Reviewed-on: https://chromium-review.googlesource.com/c/1355174
    > Reviewed-by: Will Harris <wfh@chromium.org>
    > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Commit-Queue: Yilei Li <yileili@google.com>
    > Cr-Commit-Position: refs/heads/master@{#614553}
    
    TBR=xiyuan@chromium.org,xiaohuic@chromium.org,wfh@chromium.org,dmblack@google.com,wutao@chromium.org,yileili@google.com
    
    Change-Id: Ib5749ef1c003be49d4923c364d8499b43a2abcf5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:112495005
    Reviewed-on: https://chromium-review.googlesource.com/c/1366873
    Reviewed-by: Dan Beam <dbeam@chromium.org>
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614577}

    Changed files

    • ash/BUILD.gn
    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_controller.h
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/public/cpp/ash_pref_names.cc
    • ash/public/cpp/ash_pref_names.h
    • ash/shell.cc
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h