Home | Search | chromium - Builders
Login

Builder win-asan Build 1789 Microsoft Windows

Results:

Failure network_service_interactive_ui_tests on Windows-10-15063

Trigger Info:

Projectchromium
Revision369b6fca37d5b416775fd7fafdbc6bde78a18bf8
Got Revision369b6fca37d5b416775fd7fafdbc6bde78a18bf8

Execution:

Steps and Logfiles:

Show:
  1. ( 616 ms ) setup_build
    running recipe: "chromium"
  2. ( 283 ms ) report builders
     
    running builder/tester 'win-asan' on master 'chromium.memory'
  3. ( 5 secs ) taskkill
  4. ( 5 mins 7 secs ) bot_update
    [106GB/299GB used (35%)]
  5. ( 653 ms ) swarming.py --version
    0.13
  6. ( 36 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.memory.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.memory.json
  8. ( 513 ms ) lookup GN args
     
    enable_ipc_fuzzer = true
    is_asan = true
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    v8_enable_verify_heap = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  9. ( 1 mins 47 secs ) generate_build_files
  10. ( 619 ms ) clang_revision
  11. ( 21 mins 51 secs ) compile
  12. ( 4 mins 30 secs ) compile confirm no-op
  13. ( 8 mins 22 secs ) isolate tests
  14. ( 1 secs ) find isolated tests
  15. ( 2 secs ) accessibility_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 48s
  16. ( 3 secs ) angle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:09:15.071362
  17. ( 2 secs ) app_shell_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 39s
  18. ( 2 secs ) aura_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  19. ( 2 secs ) base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:17.275201
  20. ( 1 secs ) blink_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  21. ( 1 secs ) blink_fuzzer_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  22. ( 2 secs ) blink_heap_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 39s
  23. ( 2 secs ) blink_platform_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 54s
  24. ( 1 secs ) boringssl_crypto_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:08.227702
  25. ( 1 secs ) boringssl_ssl_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  26. ( 1 secs ) cacheinvalidation_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  27. ( 1 secs ) capture_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  28. ( 1 secs ) cast_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  29. ( 3 secs ) cc_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:07:13.971235
  30. ( 2 secs ) chrome_app_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 30s
  31. ( 2 secs ) chrome_cleaner_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:20.138536
  32. ( 1 secs ) chrome_elf_import_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 44s
  33. ( 1 secs ) chrome_elf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  34. ( 1 secs ) chromedriver_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  35. ( 1 secs ) components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:05.296033
  36. ( 1 secs ) network_service_components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:08.282619
  37. ( 7 mins 58 secs ) components_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:12:15.116115
  38. ( 1 secs ) compositor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 28s
  39. ( 29 mins 37 secs ) content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:42:00.180569
  40. ( 1 secs ) perfetto_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 37s
  41. ( 5 secs ) content_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:03:05.827552
  42. ( 1 secs ) courgette_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:42.979121
  43. ( 1 secs ) crashpad_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 31s
  44. ( 1 secs ) cronet_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  45. ( 2 secs ) cronet_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  46. ( 1 secs ) crypto_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  47. ( 2 secs ) device_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  48. ( 1 secs ) display_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  49. ( 1 secs ) elevation_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  50. ( 2 secs ) events_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
  51. ( 1 secs ) extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:36.059209
  52. ( 2 secs ) network_service_extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:30.478589
  53. ( 2 secs ) extensions_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:34.657098
  54. ( 1 secs ) filesystem_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  55. ( 1 secs ) gcm_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  56. ( 3 secs ) gfx_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:45.143749
  57. ( 1 secs ) gin_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  58. ( 1 secs ) google_apis_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  59. ( 4 secs ) gpu_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:30.116157
  60. ( 1 secs ) headless_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:53.132750
  61. ( 2 secs ) headless_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  62. ( 1 secs ) install_static_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  63. ( 2 secs ) installer_util_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  64. ( 1 secs ) webui_polymer2_interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 53s
  65. ( 1 secs ) ipc_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  66. ( 1 secs ) jingle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  67. ( 1 secs ) latency_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  68. ( 1 secs ) leveldb_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  69. ( 1 secs ) libjingle_xmpp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  70. ( 2 secs ) media_blink_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 40s
  71. ( 1 secs ) media_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  72. ( 3 secs ) media_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:02.979066
  73. ( 1 secs ) message_center_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  74. ( 1 secs ) midi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  75. ( 1 secs ) mojo_core_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 11s
  76. ( 3 secs ) mojo_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 37s
  77. ( 2 secs ) nacl_loader_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  78. ( 1 secs ) native_theme_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  79. ( 13 secs ) net_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:38:57.738919
  80. ( 1 secs ) notification_helper_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  81. ( 1 secs ) pdf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  82. ( 1 secs ) ppapi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  83. ( 2 secs ) printing_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  84. ( 2 secs ) remoting_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 39s
  85. ( 1 secs ) sbox_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  86. ( 1 secs ) sbox_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  87. ( 1 secs ) sbox_validation_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  88. ( 1 secs ) service_manager_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  89. ( 4 secs ) services_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:41.386260
  90. ( 1 secs ) setup_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  91. ( 1 secs ) shell_dialogs_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  92. ( 1 secs ) skia_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  93. ( 1 secs ) snapshot_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  94. ( 1 secs ) sql_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  95. ( 1 secs ) storage_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  96. ( 2 secs ) sync_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:18:22.957500
  97. ( 1 secs ) traffic_annotation_auditor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  98. ( 1 secs ) ui_base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  99. ( 1 secs ) ui_touch_selection_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  100. ( 7 secs ) unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:17:48.702840
  101. ( 1 secs ) url_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  102. ( 2 secs ) views_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 35s
  103. ( 2 secs ) viz_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:15.195840
  104. ( 2 secs ) vr_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
  105. ( 2 secs ) vr_pixeltests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
  106. ( 5 secs ) webkit_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:06:07.013677
  107. ( 1 secs ) wm_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  108. ( 1 secs ) wtf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  109. ( 1 secs ) zucchini_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  110. ( 5 secs ) network_service_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:24:27.588259 (shard #0)
    Min shard duration: 0:23:57.543369 (shard #1)
  111. ( 2 secs ) interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:14:05.140804 (shard #2)
    Min shard duration: 0:10:26.306508 (shard #1)
  112. ( 2 secs ) network_service_interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:25:36.710583 (shard #1)
    Min shard duration: 0:12:32.355303 (shard #0)
  113. ( 2 secs ) webui_polymer2_browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:01:26.789816 (shard #0)
    Min shard duration: 0:01:09.294217 (shard #2)
  114. ( 7 secs ) browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:34:54.094186 (shard #3)
    Min shard duration: 0:30:10.939416 (shard #4)
  115. ( 11 secs ) network_service_browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:25:07.894154 (shard #12)
    Min shard duration: 0:20:47.121861 (shard #9)
  116. ( 500 ms ) Tests statistics
     
    Stats
    Total shards: 132
    Total runtime: 15:54:53.423002
     
  117. ( 611 ms ) process_dumps
  118. ( 4 ms ) Failure reason

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2923-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539346691584331, "id": "8932871719483565504", "project": "chromium", "tags": ["builder:win-asan", "buildset:commit/git/369b6fca37d5b416775fd7fafdbc6bde78a18bf8", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/369b6fca37d5b416775fd7fafdbc6bde78a18bf8", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9098301781624907440", "scheduler_job_id:chromium/win-asan", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "win-asan" setup_build
buildnumber 1789 setup_build
mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "369b6fca37d5b416775fd7fafdbc6bde78a18bf8" setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "369b6fca37d5b416775fd7fafdbc6bde78a18bf8" bot_update
got_revision_cp "refs/heads/master@{#599181}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "28d200c24624f0f2ce3013e33effc4ffc123cc2c" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25136}" bot_update
got_clang_revision "344066-1" clang_revision
swarm_hashes_refs/heads/master(at){#599181}_without_patch {"accessibility_unittests": "a1f2350e531118de0310eff663bf25ec0deb904d", "angle_unittests": "b69baf1c1a2d52ed786497d172224b31232a3ffd", "app_shell_unittests": "c75b6b67c921b941679f44f46120bcd53ca471a3", "aura_unittests": "977d36295e8643c2982469976c27ac469cd42942", "base_unittests": "5211cc586f507ca12e6057f27b9b88d18f0cb90c", "blink_common_unittests": "37ab9d8c79f8a2155f21e0b06cfcb5fe43353be5", "blink_fuzzer_unittests": "f999fc0cf8dd2d5f35f64259fee70550934152a8", "blink_heap_unittests": "ad13a687bdad248f714bbd5e5f91b054665c8d66", "blink_platform_unittests": "147d521c960905f909ccee7c5198414877d161bf", "boringssl_crypto_tests": "e9e56df4f609ec5eba31c38aa90f8ef22a77339a", "boringssl_ssl_tests": "1584e6790e4882c3c7a96b27752434fa17272d32", "browser_tests": "422a34dafaa0739bdb785c267f41f9d11691d684", "cacheinvalidation_unittests": "4c6f9c9c339c5eaf53555e0d5e4e9bb9c328845b", "capture_unittests": "d760359a51152e073a029a0f5a5c6fd88faf1bc8", "cast_unittests": "ce40fac0f77fd9055c877bc7c925a937eb031307", "cc_unittests": "9d690269b3125e44bdca74c5cd0f29b16112e6f6", "chrome_app_unittests": "b4404783c80e37c9e83fc43ed6ddfc0999de9395", "chrome_cleaner_unittests": "24d93f7f2b9ad04f02a4d9fd1b0a1052c841e3d6", "chrome_elf_import_unittests": "ea215523adec029f65b8735d26b3de003b2797bb", "chrome_elf_unittests": "8bc8a1c485e0e1bf30eebdaf27b9797b704f105a", "chromedriver_unittests": "535947d6529892c027b2e81f932f221e5ff31be9", "components_browsertests": "483f9fcdf301c9ac005cb645c8bb3759f6c7105e", "components_unittests": "f223904775643f74d99a9f6aaedbe430be53d970", "compositor_unittests": "0ba63a0cd54171a7123f116f8298d46b3f90ac72", "content_browsertests": "311f93bb15726fa4cbed71c85dbb22ad2fd992f8", "content_unittests": "7a7691d2e4e7a9847d44d4b3e487860ca4ebce7a", "courgette_unittests": "0d577b18b3c566b97e82309d839e390daab67f78", "crashpad_tests": "e78c25c03a03d20b3e820db17a3a61478ada5bb3", "cronet_tests": "bbc29c191c30256b3e50351fb67d8f1a062e62f4", "cronet_unittests": "ca158bda8dcde2f471d0b3567e4e5a79086ab488", "crypto_unittests": "2902a4d1a1854b81c6d82b133263aaf55f52b692", "device_unittests": "2d66df1ca1fafd6f6a083b2a8623775aace5abb9", "display_unittests": "0d6dfaa6305f45cbd716978ed49290137888d151", "elevation_service_unittests": "5b72716dfe1702fd1da4c70c45cd5dc9b251a4e0", "events_unittests": "9b0bcf79ef9f8227f501f7e943701be8b1ce652c", "extensions_browsertests": "df030a3da0fca524704b38a6b1ea8367f1fd6da4", "extensions_unittests": "106886d7f64e3b4ea3c558e7417bd50be1cb8e5a", "filesystem_service_unittests": "b266648d00be88608e72bb5c6fbe1552e05b10c9", "gcm_unit_tests": "a99f513e5adc33a4d18a406f724c060cbcab7a1a", "gfx_unittests": "02c6f9ed3a4ac5f428a9850de360a757ffd9c667", "gin_unittests": "41c8351d2d44484ee29ee748b0f4eccd48cc6694", "google_apis_unittests": "ed54f7fc1e4ce9f3eb8db4d7b43b5c8e6fbf226c", "gpu_unittests": "09d373b884689a4af71c5d94204669eaa4f5e2fe", "headless_browsertests": "e3c97180510b5a84079f66f8d069f7d964dd8ce5", "headless_unittests": "cfdd1932ec26150e634f114b3f5a57e8e1560913", "install_static_unittests": "5a23699db4c03a237021977b3d653652eff31e16", "installer_util_unittests": "0e40cff48571adcdf90bbc144a6a493b4c81e4dd", "interactive_ui_tests": "6006844a665376190382e2e22a120e4573a48096", "ipc_tests": "cfba1ecab2c8ba9836dc5303a14a692645de7ccf", "jingle_unittests": "fa5e94bf8609fe6c0a91f4ebae1a4730d0be8593", "latency_unittests": "df44ffdc1aa76d71901c475b10f65da7b4da527c", "leveldb_service_unittests": "0eb7575bf56b015cf13128ca2a544175bd2d462e", "libjingle_xmpp_unittests": "30bf8004785823a9a33733ac69a4b33114614b2f", "media_blink_unittests": "a4a4759497b6aea3f00029fe4125eadaee3c45e8", "media_service_unittests": "d165ddbf933c40ed4d36c46fac024966bc3cc878", "media_unittests": "ea91447abd61e0fad4b249171a89ffd02ee94bd1", "message_center_unittests": "1d14b231b96b2a51fcd6ad87f99985ba7356d601", "midi_unittests": "8e6ebb49a59aebab18fafb3a2505a8050849f18e", "mojo_core_unittests": "1fc1042417ccf93222e434ba07bc4b8b5677e4b6", "mojo_unittests": "8825cf10d298e6d402969f556759f42e9b3e95d3", "nacl_loader_unittests": "23b0db011fc36bf489262af71b1f8a49dd1526b8", "native_theme_unittests": "7b161f30163632d28375949d027a9498e0aa9173", "net_unittests": "89b19dc0e50b7cb256ca1d89d515ec7cdcd62b6d", "notification_helper_unittests": "d799f9f4947cd66a1a3fdc4051af288e1e6f889e", "pdf_unittests": "c6b47cf734db832a94daa44463c50d34fff95a6d", "ppapi_unittests": "b6572f6135bf75e0d34652912bbc0fd9073d43c2", "printing_unittests": "96c13b1f3328cf79d4c687ea1184d00802d685b6", "remoting_unittests": "a41f37ad4170b48ebc690d1ddf804f0f567abce8", "sbox_integration_tests": "3e7b41172c2f1c16e08b6546f6a4d58af4c20ded", "sbox_unittests": "e19645af4084d8989ae34913d8cc5a7d56ee5ab8", "sbox_validation_tests": "edae0e1bbb17ae52e71c29c6da16c46ca842c02e", "service_manager_unittests": "4cf92dd98e56db304b34a4946c62d8f0c504631a", "services_unittests": "36397c09d5d23c180a3a7023e3cf06d417ad1d9a", "setup_unittests": "eb7ae0d9023acf6add4b60c7474259faac13716a", "shell_dialogs_unittests": "72b0efee2de1203faaf622294a0822c60f789560", "skia_unittests": "fd3598211cddfd453817912cb9add0b35262ec09", "snapshot_unittests": "ac3185eb7d915a8081dfbcd7a52938aff9b238e6", "sql_unittests": "678b68c42715c7a6ee483dfe1dccfa58d4cb0b9c", "storage_unittests": "edac539be318cea7ab101cd399b2e49b856801cd", "sync_integration_tests": "24614467d9b3876541c87d86dccd7c2c1f134fc7", "traffic_annotation_auditor_unittests": "b5aa032a86ad9b12e5b13fedb694121e5aa08265", "ui_base_unittests": "1b56b3a9be8907902a8ed320f4382f774a0d6025", "ui_touch_selection_unittests": "78c2ede207b94b51c36903ce7906b661ff35d3a5", "unit_tests": "c58d9585c113fc93c886d2e9b3d39d815ed55797", "url_unittests": "92f0c32e4acffa72ba0b9c87cd1812826c303cfb", "views_unittests": "c3c9aa90450f7028fdc4393fa82fc7c354cdbbf5", "viz_unittests": "4a382e7afa8afb71cfa2442b5cfbb395b50ef4ad", "vr_common_unittests": "e74b08a86c405e0918a1c978747ae03978ffb132", "vr_pixeltests": "d5540b5cbedd2a18e4be9e56d70ace2d269c3f22", "webkit_unit_tests": "d7fe0112cdddff5f5e4847aea5d20abea47120a8", "wm_unittests": "8b4b508d840a0956f6000a0efe925ad99e4163f9", "wtf_unittests": "b0d35e65947d1cfd06cece95bc4894c2dffdd5fd", "zucchini_unittests": "d82862057d3dcc999ca4e20b786b1ec8c762d571"} isolate tests
swarm_hashes {"accessibility_unittests": "a1f2350e531118de0310eff663bf25ec0deb904d", "angle_unittests": "b69baf1c1a2d52ed786497d172224b31232a3ffd", "app_shell_unittests": "c75b6b67c921b941679f44f46120bcd53ca471a3", "aura_unittests": "977d36295e8643c2982469976c27ac469cd42942", "base_unittests": "5211cc586f507ca12e6057f27b9b88d18f0cb90c", "blink_common_unittests": "37ab9d8c79f8a2155f21e0b06cfcb5fe43353be5", "blink_fuzzer_unittests": "f999fc0cf8dd2d5f35f64259fee70550934152a8", "blink_heap_unittests": "ad13a687bdad248f714bbd5e5f91b054665c8d66", "blink_platform_unittests": "147d521c960905f909ccee7c5198414877d161bf", "boringssl_crypto_tests": "e9e56df4f609ec5eba31c38aa90f8ef22a77339a", "boringssl_ssl_tests": "1584e6790e4882c3c7a96b27752434fa17272d32", "browser_tests": "422a34dafaa0739bdb785c267f41f9d11691d684", "cacheinvalidation_unittests": "4c6f9c9c339c5eaf53555e0d5e4e9bb9c328845b", "capture_unittests": "d760359a51152e073a029a0f5a5c6fd88faf1bc8", "cast_unittests": "ce40fac0f77fd9055c877bc7c925a937eb031307", "cc_unittests": "9d690269b3125e44bdca74c5cd0f29b16112e6f6", "chrome_app_unittests": "b4404783c80e37c9e83fc43ed6ddfc0999de9395", "chrome_cleaner_unittests": "24d93f7f2b9ad04f02a4d9fd1b0a1052c841e3d6", "chrome_elf_import_unittests": "ea215523adec029f65b8735d26b3de003b2797bb", "chrome_elf_unittests": "8bc8a1c485e0e1bf30eebdaf27b9797b704f105a", "chromedriver_unittests": "535947d6529892c027b2e81f932f221e5ff31be9", "components_browsertests": "483f9fcdf301c9ac005cb645c8bb3759f6c7105e", "components_unittests": "f223904775643f74d99a9f6aaedbe430be53d970", "compositor_unittests": "0ba63a0cd54171a7123f116f8298d46b3f90ac72", "content_browsertests": "311f93bb15726fa4cbed71c85dbb22ad2fd992f8", "content_unittests": "7a7691d2e4e7a9847d44d4b3e487860ca4ebce7a", "courgette_unittests": "0d577b18b3c566b97e82309d839e390daab67f78", "crashpad_tests": "e78c25c03a03d20b3e820db17a3a61478ada5bb3", "cronet_tests": "bbc29c191c30256b3e50351fb67d8f1a062e62f4", "cronet_unittests": "ca158bda8dcde2f471d0b3567e4e5a79086ab488", "crypto_unittests": "2902a4d1a1854b81c6d82b133263aaf55f52b692", "device_unittests": "2d66df1ca1fafd6f6a083b2a8623775aace5abb9", "display_unittests": "0d6dfaa6305f45cbd716978ed49290137888d151", "elevation_service_unittests": "5b72716dfe1702fd1da4c70c45cd5dc9b251a4e0", "events_unittests": "9b0bcf79ef9f8227f501f7e943701be8b1ce652c", "extensions_browsertests": "df030a3da0fca524704b38a6b1ea8367f1fd6da4", "extensions_unittests": "106886d7f64e3b4ea3c558e7417bd50be1cb8e5a", "filesystem_service_unittests": "b266648d00be88608e72bb5c6fbe1552e05b10c9", "gcm_unit_tests": "a99f513e5adc33a4d18a406f724c060cbcab7a1a", "gfx_unittests": "02c6f9ed3a4ac5f428a9850de360a757ffd9c667", "gin_unittests": "41c8351d2d44484ee29ee748b0f4eccd48cc6694", "google_apis_unittests": "ed54f7fc1e4ce9f3eb8db4d7b43b5c8e6fbf226c", "gpu_unittests": "09d373b884689a4af71c5d94204669eaa4f5e2fe", "headless_browsertests": "e3c97180510b5a84079f66f8d069f7d964dd8ce5", "headless_unittests": "cfdd1932ec26150e634f114b3f5a57e8e1560913", "install_static_unittests": "5a23699db4c03a237021977b3d653652eff31e16", "installer_util_unittests": "0e40cff48571adcdf90bbc144a6a493b4c81e4dd", "interactive_ui_tests": "6006844a665376190382e2e22a120e4573a48096", "ipc_tests": "cfba1ecab2c8ba9836dc5303a14a692645de7ccf", "jingle_unittests": "fa5e94bf8609fe6c0a91f4ebae1a4730d0be8593", "latency_unittests": "df44ffdc1aa76d71901c475b10f65da7b4da527c", "leveldb_service_unittests": "0eb7575bf56b015cf13128ca2a544175bd2d462e", "libjingle_xmpp_unittests": "30bf8004785823a9a33733ac69a4b33114614b2f", "media_blink_unittests": "a4a4759497b6aea3f00029fe4125eadaee3c45e8", "media_service_unittests": "d165ddbf933c40ed4d36c46fac024966bc3cc878", "media_unittests": "ea91447abd61e0fad4b249171a89ffd02ee94bd1", "message_center_unittests": "1d14b231b96b2a51fcd6ad87f99985ba7356d601", "midi_unittests": "8e6ebb49a59aebab18fafb3a2505a8050849f18e", "mojo_core_unittests": "1fc1042417ccf93222e434ba07bc4b8b5677e4b6", "mojo_unittests": "8825cf10d298e6d402969f556759f42e9b3e95d3", "nacl_loader_unittests": "23b0db011fc36bf489262af71b1f8a49dd1526b8", "native_theme_unittests": "7b161f30163632d28375949d027a9498e0aa9173", "net_unittests": "89b19dc0e50b7cb256ca1d89d515ec7cdcd62b6d", "notification_helper_unittests": "d799f9f4947cd66a1a3fdc4051af288e1e6f889e", "pdf_unittests": "c6b47cf734db832a94daa44463c50d34fff95a6d", "ppapi_unittests": "b6572f6135bf75e0d34652912bbc0fd9073d43c2", "printing_unittests": "96c13b1f3328cf79d4c687ea1184d00802d685b6", "remoting_unittests": "a41f37ad4170b48ebc690d1ddf804f0f567abce8", "sbox_integration_tests": "3e7b41172c2f1c16e08b6546f6a4d58af4c20ded", "sbox_unittests": "e19645af4084d8989ae34913d8cc5a7d56ee5ab8", "sbox_validation_tests": "edae0e1bbb17ae52e71c29c6da16c46ca842c02e", "service_manager_unittests": "4cf92dd98e56db304b34a4946c62d8f0c504631a", "services_unittests": "36397c09d5d23c180a3a7023e3cf06d417ad1d9a", "setup_unittests": "eb7ae0d9023acf6add4b60c7474259faac13716a", "shell_dialogs_unittests": "72b0efee2de1203faaf622294a0822c60f789560", "skia_unittests": "fd3598211cddfd453817912cb9add0b35262ec09", "snapshot_unittests": "ac3185eb7d915a8081dfbcd7a52938aff9b238e6", "sql_unittests": "678b68c42715c7a6ee483dfe1dccfa58d4cb0b9c", "storage_unittests": "edac539be318cea7ab101cd399b2e49b856801cd", "sync_integration_tests": "24614467d9b3876541c87d86dccd7c2c1f134fc7", "traffic_annotation_auditor_unittests": "b5aa032a86ad9b12e5b13fedb694121e5aa08265", "ui_base_unittests": "1b56b3a9be8907902a8ed320f4382f774a0d6025", "ui_touch_selection_unittests": "78c2ede207b94b51c36903ce7906b661ff35d3a5", "unit_tests": "c58d9585c113fc93c886d2e9b3d39d815ed55797", "url_unittests": "92f0c32e4acffa72ba0b9c87cd1812826c303cfb", "views_unittests": "c3c9aa90450f7028fdc4393fa82fc7c354cdbbf5", "viz_unittests": "4a382e7afa8afb71cfa2442b5cfbb395b50ef4ad", "vr_common_unittests": "e74b08a86c405e0918a1c978747ae03978ffb132", "vr_pixeltests": "d5540b5cbedd2a18e4be9e56d70ace2d269c3f22", "webkit_unit_tests": "d7fe0112cdddff5f5e4847aea5d20abea47120a8", "wm_unittests": "8b4b508d840a0956f6000a0efe925ad99e4163f9", "wtf_unittests": "b0d35e65947d1cfd06cece95bc4894c2dffdd5fd", "zucchini_unittests": "d82862057d3dcc999ca4e20b786b1ec8c762d571"} find isolated tests

Blamelist:

  1. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  2. Florent Castelli (orphisohnoyoudont@chromium.org)
  3. Florent Castelli (orphisohnoyoudont@chromium.org)
  4. Colin Blundell (blundellohnoyoudont@chromium.org)
  5. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  6. Camille Lamy (clamyohnoyoudont@chromium.org)
  7. stkhapugin@chromium.org (stkhapuginohnoyoudont@chromium.org)
  8. Nico Weber (thakisohnoyoudont@chromium.org)
  9. Sergio Villar Senin (svillarohnoyoudont@igalia.com)
  10. Eliot Courtney (edcourtneyohnoyoudont@google.com)
  11. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  12. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  13. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  14. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  15. Scott Wu (scottwuohnoyoudont@chromium.org)
  16. Laís Minchillo (laisminchilloohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 12:18:11 UTC
Start Friday, 12-Oct-18 12:18:16 UTC
End Friday, 12-Oct-18 14:01:35 UTC
Pending 5 secs
Execution 1 hrs 43 mins

All Changes:

  1. Don't update style for focusability when render-blocking.

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:16:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 369b6fca37d5b416775fd7fafdbc6bde78a18bf8

    Comments

    Don't update style for focusability when render-blocking.
    
    WebNode::IsFocusable() updated style and layout tree, without ignoring
    pending stylesheets, which meant generating a display:none placeholder
    style for the root node. Instead, early return from IsFocusable() when
    we are blocking rendering.
    
    Bug: 521692
    
    Change-Id: Idd6cfcf800e4173cfc1bdcb916728c7a0186edf9
    Reviewed-on: https://chromium-review.googlesource.com/c/1245787
    Reviewed-by: Stefan Zager <szager@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599181}

    Changed files

    • third_party/blink/renderer/core/exported/web_node.cc
    • third_party/blink/renderer/core/exported/web_node_test.cc
  2. Revert "[blink] Control ScriptStreamer with ScriptResource"

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:16:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7590d68012b9cf52c14e3f44e019ea36ecc2d9e

    Comments

    Revert "[blink] Control ScriptStreamer with ScriptResource"
    
    This reverts commit 7bd9163502462762e58d8010577dbf36aeef6c13.
    
    Reason for revert: fast/css-grid-layout/grid-columns-rows-get-set.html is flaky
    Bug: 894792, 894795
    
    Original change's description:
    > [blink] Control ScriptStreamer with ScriptResource
    > 
    > Move the ScriptStreamer control logic from ClassicPendingScript to
    > ScriptResource. In the future, this will allow us to start streaming
    > a ScriptResource before the ClassicPendingScript is available, e.g on
    > preload.
    > 
    > The ClassicPendingScript now only sends one "finished" callback, from
    > ScriptResource. This callback is either when the streaming completes,
    > or when there is no streaming and the ClassicPendingScript has told
    > the ScriptResource that it doesn't intend to start streaming. In the
    > long run, we want all scripts to go through the streaming interface,
    > and we want ScriptResource to control when streaming starts, so the
    > "no more streaming" call will disappear -- however it is necessary to
    > maintain the current behaviour, and be able to control it with a
    > runtime flag.
    > 
    > Bug: chromium:865098
    > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
    > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599148}
    
    TBR=kinuko@chromium.org,rmcilroy@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
    
    Change-Id: Id8e8df8f960c60c88762cdf837e7ba9eb74944d6
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:865098
    Reviewed-on: https://chromium-review.googlesource.com/c/1278758
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599180}

    Changed files

    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
    • third_party/blink/renderer/bindings/core/v8/script_streamer.cc
    • third_party/blink/renderer/bindings/core/v8/script_streamer.h
    • third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
    • third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
    • third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.h
    • third_party/blink/renderer/core/script/classic_pending_script.cc
    • third_party/blink/renderer/core/script/classic_pending_script.h
    • third_party/blink/renderer/core/script/document_write_intervention.cc
    • third_party/blink/renderer/core/script/pending_script.h
    • third_party/blink/renderer/platform/loader/fetch/resource.cc
    • third_party/blink/renderer/platform/loader/fetch/resource.h
    • tools/metrics/histograms/enums.xml
  3. Revert "Make DriveFS opt-out in FilesApp tests."

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:11:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 70d0138d92d063b4d3032ffae54c950cf7c13f41

    Comments

    Revert "Make DriveFS opt-out in FilesApp tests."
    
    This reverts commit e9c79d562d8d3b789cca95b6909aa600a1dd39d2.
    
    Reason for revert: single_process_mash_browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests
    Bug: 894799
    
    Original change's description:
    > Make DriveFS opt-out in FilesApp tests.
    > 
    > Bug: 891197
    > Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
    > Reviewed-on: https://chromium-review.googlesource.com/c/1277133
    > Reviewed-by: Noel Gordon <noel@chromium.org>
    > Commit-Queue: Sam McNally <sammc@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599117}
    
    TBR=noel@chromium.org,sammc@chromium.org
    
    Change-Id: If9140eb468d1e27aeb217a3202b638aa0f4e20f7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 891197
    Reviewed-on: https://chromium-review.googlesource.com/c/1278757
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599179}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
  4. Enable IdentityTestEnvironment to take in IdentityManager's dependencies

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:09:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b64e54c9a221efad82a4a60956cd3b58ac371059

    Comments

    Enable IdentityTestEnvironment to take in IdentityManager's dependencies
    
    Currently, IdentityTestEnvironment internally constructs all the
    dependencies of IdentityManager as well as the IdentityManager object
    itself. This behavior is nice for hiding the fact that IdentityManager
    has these dependencies from consumers, but doesn't allow for
    usage of IdentityTestEnviroment in incremental conversion of tests that
    have broad direct usage of these dependencies. Concretely,
    profile_sync_test_util.h provides one such problematic case: it
    constructs and directly exposes these dependencies, which are then
    broadly used by a set of tests that consume this utility class.
    Converting all these tests in one go is not practical.
    
    This CL adds an alternate IdentityTestEnvironment constructor that
    takes in the dependencies and constructs IdentityManager via those
    passed-in dependencies. To enable this constructor, the CL also
    encapsulates the fact that IdentityTestEnvironment otherwise obtains
    these dependencies from an internal object within the current
    IdentityTestEnvironment constructor.  It also moves ownership of
    IdentityManager from that internal object to IdentityTestEnvironment
    itself so that it can be created/owned independent of that internal
    object.
    
    A followup CL will use this new constructor.
    
    Bug: 886599
    Change-Id: I4c6a503dcc11c327193f80bc7d7c48e467c6919b
    Reviewed-on: https://chromium-review.googlesource.com/c/1273298
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599178}

    Changed files

    • services/identity/public/cpp/identity_test_environment.cc
    • services/identity/public/cpp/identity_test_environment.h
  5. [css-properties-values-api] Support StylePropertyMap.append.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:05:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84056b7e0dee6cb71b889254c2f33c0b338002fb

    Comments

    [css-properties-values-api] Support StylePropertyMap.append.
    
    This CL makes it possible to append values to list-valued properties.
    
    To do this, we must produce a CSSStyleValueVector which holds the final
    value produced by the append (i.e. the concatenation of the existing
    values and the incoming values). Then (like for StylePropertyMap.set),
    a CSSVariableReferenceValue with equivalent tokens is created from that
    vector.
    
    Bonus: Fix names of some tests to make it easier to read the output.
    
    R=chrishtr@chromium.org
    
    Bug: 641877
    Change-Id: I0d58f66255a9ff7e14c1ee8f4d243353b9a4a0da
    Reviewed-on: https://chromium-review.googlesource.com/c/1270967
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599177}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/typedom.tentative.html
    • third_party/blink/renderer/core/css/cssom/style_property_map.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only.h
  6. Create NavigationRequest from LoadURLParams

    Changed by Camille Lamy - clamyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:59:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5193caa162249e66ecec99fbf1e94fd38557b672

    Comments

    Create NavigationRequest from LoadURLParams
    
    This CL allows to create the NavigationRequest directly from
    LoadURLParams for new navigations.
    
    Bug: 803859
    Change-Id: Ic0f3f368ade86fe57bb549ae6c1d5711f1b58d0e
    Reviewed-on: https://chromium-review.googlesource.com/c/1097407
    Commit-Queue: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599176}

    Changed files

    • content/browser/frame_host/navigation_controller_impl.cc
    • content/browser/frame_host/navigation_controller_impl.h
    • content/browser/frame_host/navigation_entry_impl.cc
    • content/browser/frame_host/navigation_request.cc
    • content/browser/frame_host/navigation_request.h
    • content/browser/frame_host/navigator_impl.cc
    • content/browser/frame_host/render_frame_host_manager_unittest.cc
  7. Rename FaviconViewNew to FaviconView.

    Changed by stkhapugin@chromium.org - stkhapuginohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:48:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0363f71cf67554f24b21b299db6f9fcd11a33bf3

    Comments

    Rename FaviconViewNew to FaviconView.
    
    Since FaviconView name is not used anymore, it makes sense now.
    
    Bug: none
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I0549111a1ade2f8cc61664d1de07160c8687b6de
    Reviewed-on: https://chromium-review.googlesource.com/c/1278807
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599175}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.h
    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm
    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.h
    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.mm
    • ios/chrome/browser/ui/table_view/cells/table_view_url_item.h
    • ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm
    • ios/chrome/common/favicon/favicon_view.h
    • ios/chrome/common/favicon/favicon_view.mm
    • ios/chrome/content_widget_extension/most_visited_tile_view.h
    • ios/chrome/content_widget_extension/most_visited_tile_view.mm
  8. win: Update deterministic build whitelist.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:47:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f097036d16ea6c259ef01ddd6967895ca5a28d04

    Comments

    win: Update deterministic build whitelist.
    
    symbol_level=1 builds seem to work now and the bot builds with it, so the
    entries for crashpad_snapshot_test_image_reader and
    crashpad_snapshot_test_image_reader_module.dll are no longer needed.
    
    mini_installer.exe now has a corresponding .pdb that's also non-deterministic
    (since the exe itself isn't, the pdb can't be), so add an entry for that.
    
    TBR=erikchen
    
    Bug: 330260
    Change-Id: Ic1cde1f5a52a953d74285e4bd6a02e74c70e75b5
    Reviewed-on: https://chromium-review.googlesource.com/c/1278306
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599174}

    Changed files

    • tools/determinism/deterministic_build_whitelist.pyl
  9. Convert chrome/browser/signin/signin_global_error.cc to IdentityManager

    Changed by Sergio Villar Senin - svillarohnoyoudont@igalia.com
    Changed at Friday, 12-Oct-18 11:46:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 557d4cfd2336cc35f91ec95bb9ef4b1290e6d491

    Comments

    Convert chrome/browser/signin/signin_global_error.cc to IdentityManager
    
    It was using SigninManagerBase API to get the primary (authenticated)
    account id. It's now using the IdentityManager API.
    
    Bug: 890792
    Change-Id: Ia8cdd8e491f29256af2c015a9127b0766e81b99e
    Reviewed-on: https://chromium-review.googlesource.com/c/1276965
    Commit-Queue: Sergio Villar <svillar@igalia.com>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599173}

    Changed files

    • chrome/browser/signin/signin_global_error.cc
  10. Add Picture-in-picture specific window resizer.

    Changed by Eliot Courtney - edcourtneyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 11:38:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1454ad1f261d1089f2ac20cdc6e7e3d2562d731c

    Comments

    Add Picture-in-picture specific window resizer.
    
    Currently, this does essentially nothing apart from providing basic
    resizing and moving functionality. In a follow-up CL, we can add
    snap-to-edge, swipe-to-dismiss, and interaction with system ui regions
    like the virtual keyboard.
    
    Bug: 841886
    Bug: b/115291749
    Test: Able to move and resize an Android PIP window.
    Change-Id: Iaecc43154fd38dc5f9d3b83549e97dc44a89d749
    Reviewed-on: https://chromium-review.googlesource.com/c/1219428
    Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599172}

    Changed files

    • ash/BUILD.gn
    • ash/wm/pip/pip_window_resizer.cc
    • ash/wm/pip/pip_window_resizer.h
    • ash/wm/pip/pip_window_resizer_unittest.cc
    • ash/wm/workspace/workspace_window_resizer.cc
    • components/exo/client_controlled_shell_surface.cc
    • components/exo/client_controlled_shell_surface_unittest.cc
  11. Run layout to avoid stale layout during SetIsInert()

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:26:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fe6fcbb2751d80b3a9c41b734d1d1c16e93d46b

    Comments

    Run layout to avoid stale layout during SetIsInert()
    
    Speculative fix for crbug.com/789094
    
    Bug: 789094
    Change-Id: I1ea9215d049d84b4117f8836754f467c3d8ec9bc
    Reviewed-on: https://chromium-review.googlesource.com/c/823582
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599171}

    Changed files

    • third_party/WebKit/LayoutTests/html/dialog/dialog-show-modal-inert-crash.html
    • third_party/blink/renderer/core/html/html_dialog_element.cc
  12. Remove MediaStreamRegistry.

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:20:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7422130d3da18b70d4cc81951feda2ab615edef9

    Comments

    Remove MediaStreamRegistry.
    
    This class is useless now that URL.createObjectURL(MediaStream) has
    been removed from the Web platform.
    
    Bug: 591719
    Change-Id: I4a56bd8c0cbb86dacab8dafa6acb807509a86367
    Reviewed-on: https://chromium-review.googlesource.com/c/1221320
    Reviewed-by: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599170}

    Changed files

    • chrome/renderer/extensions/cast_streaming_native_handler.cc
    • chrome/renderer/extensions/cast_streaming_native_handler.h
    • chrome/renderer/resources/extensions/cast_streaming_receiver_session_custom_bindings.js
    • content/public/renderer/media_stream_utils.cc
    • content/renderer/media/web_media_element_source_utils.cc
    • content/renderer/render_frame_impl.cc
    • content/shell/renderer/layout_test/test_media_stream_renderer_factory.cc
    • third_party/blink/public/BUILD.gn
    • third_party/blink/public/web/web_media_stream_registry.h
    • third_party/blink/renderer/core/html/media/html_media_element.cc
    • third_party/blink/renderer/core/html/media/html_media_element.h
    • third_party/blink/renderer/modules/exported/BUILD.gn
    • third_party/blink/renderer/modules/exported/web_media_stream_registry.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_play_button_element.cc
    • third_party/blink/renderer/modules/mediacapturefromelement/html_media_element_capture.cc
    • third_party/blink/renderer/modules/mediastream/BUILD.gn
    • third_party/blink/renderer/modules/mediastream/media_stream.cc
    • third_party/blink/renderer/modules/mediastream/media_stream.h
    • third_party/blink/renderer/modules/mediastream/media_stream_registry.cc
    • third_party/blink/renderer/modules/mediastream/media_stream_registry.h
  13. Import wpt@a69af5481cdd976c9696f97d9c6547ac87ba83d0

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:49:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68550e484d7eecf6bd1d39fca300644ab2c21f5d

    Comments

    Import wpt@a69af5481cdd976c9696f97d9c6547ac87ba83d0
    
    Using wpt-import in Chromium afc97ac06f5d3677c1016d1530c1e196844e2432.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25973
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    binji@chromium.org:
      external/wpt/wasm
    jsbell@chromium.org:
      external/wpt/resources
    
    NOAUTOREVERT=true
    TBR=lukebjerring
    
    No-Export: true
    Change-Id: I02e2714a05f60a13999e2efa76ad5039324ed566
    Reviewed-on: https://chromium-review.googlesource.com/c/1278537
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599169}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/css/geometry/interfaces-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/dom/interfaces_exclude=Node-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/resources/idlharness.js
    • third_party/WebKit/LayoutTests/external/wpt/shape-detection/idlharness.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/idlharness.any.js
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any.js
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any.worker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/resources/load_wasm.js
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
  14. Reland "Remove IDC_SHOW_SYNC_SETUP"

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:48:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 290bc882fa0022afd17118d11949266c86fa631b

    Comments

    Reland "Remove IDC_SHOW_SYNC_SETUP"
    
    This reverts commit 2ec520568c51bcd167a1ed24baa3a6f45023f02b.
    
    Reason for revert: This original CL was reverted as in emergency for M70 as it was in the CL dependency chain for the signin allowed pref CL.
    
    Original change's description:
    > Revert "Remove IDC_SHOW_SYNC_SETUP"
    > 
    > This reverts commit eafee2dc30fa6fdb34e07c664fd858a361cb5424.
    > 
    > Reason for revert: Still needed for http://crbug.com/888776
    > 
    > Original change's description:
    > > Remove IDC_SHOW_SYNC_SETUP
    > > 
    > > IDC_SHOW_SYNC_SETUP and IDC_SHOW_SIGNIN have the same integer value. This
    > > CL removes IDC_SHOW_SYNC_SETUP to avoid confusion. It also cleans up
    > > the code in browser_command_controller that was setting both IDC_SHOW_SYNC_SETUP
    > > and IDC_SHOW_SIGNIN without knowing that they are in fact the same thing.
    > > 
    > > Bug: 870239
    > > Change-Id: I3b1ac005d3230fc581e6163a53ad20a84d124402
    > > Reviewed-on: https://chromium-review.googlesource.com/1236263
    > > Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    > > Reviewed-by: Scott Violet <sky@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#593138}
    > 
    > TBR=sky@chromium.org,msarda@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: 870239
    > Change-Id: I50cd0042f2630dca0bafe4540c2c32411acf0338
    > Reviewed-on: https://chromium-review.googlesource.com/1245381
    > Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    > Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#594261}
    
    TBR=sky@chromium.org,msarda@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 870239
    Change-Id: Icde4e75988dd24b5bb2add35be055177708c7bfe
    Reviewed-on: https://chromium-review.googlesource.com/c/1278745
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599168}

    Changed files

    • chrome/app/chrome_command_ids.h
    • chrome/browser/ui/browser_command_controller.cc
    • chrome/browser/ui/browser_command_controller_unittest.cc
    • chrome/browser/ui/toolbar/app_menu_model.cc
  15. Rename PasswordControllerHelper to PasswordFormHelper

    Changed by Scott Wu - scottwuohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:44:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 830919bab9ae548252386c0e0b2bb97b4a22152e

    Comments

    Rename PasswordControllerHelper to PasswordFormHelper
    
    Bug: 865114
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: If08aa34d7c17e9f5a6dabb818669012275443587
    Reviewed-on: https://chromium-review.googlesource.com/c/1278670
    Commit-Queue: Scott Wu <scottwu@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599167}

    Changed files

    • components/password_manager/ios/BUILD.gn
    • components/password_manager/ios/password_form_helper.h
    • components/password_manager/ios/password_form_helper.mm
    • components/password_manager/ios/password_form_helper_unittest.mm
    • components/password_manager/ios/password_suggestion_helper.h
    • ios/chrome/browser/passwords/password_controller.h
    • ios/chrome/browser/passwords/password_controller.mm
    • ios/chrome/browser/passwords/password_controller_unittest.mm
    • ios/web_view/internal/passwords/cwv_password_controller.mm
  16. [aw] Add callback to proxy override methods

    Changed by Laís Minchillo - laisminchilloohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:36:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e2dd9b16afe9c2808aaa11566aa54fa854282db2

    Comments

    [aw] Add callback to proxy override methods
    
    Add an optional callback to proxy override methods introduced in change
    https://chromium-review.googlesource.com/c/chromium/src/+/1148384
    
    This adds an optional callback developers can use to know when the
    changes have been made to the network settings, since the methods are
    not synchronous with the UI thread.
    
    Bug: 851995
    Change-Id: I08dc7cc87c57d213b67774d3391562ca07fd0217
    Reviewed-on: https://chromium-review.googlesource.com/c/1258770
    Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
    Reviewed-by: Eric Roman <eroman@chromium.org>
    Reviewed-by: Richard Coles <torne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599166}

    Changed files

    • android_webview/browser/aw_contents_statics.cc
    • android_webview/browser/net/aw_url_request_context_getter.cc
    • android_webview/browser/net/aw_url_request_context_getter.h
    • android_webview/glue/java/src/com/android/webview/chromium/SharedStatics.java
    • android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java
    • android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/StaticsBoundaryInterface.java
    • android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
    • android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
    • net/proxy_resolution/proxy_config_service_android.cc
    • net/proxy_resolution/proxy_config_service_android.h
    • net/proxy_resolution/proxy_config_service_android_unittest.cc