Home | Search | chromium - Builders
Login

Builder win-asan Build 1786 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision13767a51fd778bba049621a733ac7fbe6221922b
Got Revision13767a51fd778bba049621a733ac7fbe6221922b

Execution:

Steps and Logfiles:

Show:
  1. ( 605 ms ) setup_build
    running recipe: "chromium"
  2. ( 269 ms ) report builders
     
    running builder/tester 'win-asan' on master 'chromium.memory'
  3. ( 5 secs ) taskkill
  4. ( 7 mins 56 secs ) bot_update
    [106GB/299GB used (35%)]
  5. ( 904 ms ) swarming.py --version
    0.13
  6. ( 35 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.memory.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.memory.json
  8. ( 499 ms ) lookup GN args
     
    enable_ipc_fuzzer = true
    is_asan = true
    is_component_build = false
    is_debug = false
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    v8_enable_verify_heap = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  9. ( 1 mins 54 secs ) generate_build_files
  10. ( 667 ms ) clang_revision
  11. ( 28 mins ) compile
  12. ( 3 mins 55 secs ) compile confirm no-op
  13. ( 8 mins 35 secs ) isolate tests
  14. ( 3 secs ) find isolated tests
  15. ( 2 secs ) accessibility_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 53s
  16. ( 6 mins 31 secs ) angle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:09:15.071362
  17. ( 1 secs ) app_shell_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 35s
  18. ( 1 secs ) aura_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 36s
  19. ( 3 secs ) base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:16.308283
  20. ( 2 secs ) blink_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  21. ( 1 secs ) blink_fuzzer_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  22. ( 1 secs ) blink_heap_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:01.523348
  23. ( 3 secs ) blink_platform_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:20.606098
  24. ( 2 secs ) boringssl_crypto_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:08.227702
  25. ( 1 secs ) boringssl_ssl_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  26. ( 1 secs ) cacheinvalidation_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  27. ( 2 secs ) capture_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  28. ( 1 secs ) cast_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  29. ( 3 secs ) cc_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:06:55.109712
  30. ( 1 secs ) chrome_app_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 33s
  31. ( 2 secs ) chrome_cleaner_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:15.720649
  32. ( 1 secs ) chrome_elf_import_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 48s
  33. ( 1 secs ) chrome_elf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  34. ( 2 secs ) chromedriver_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  35. ( 1 secs ) components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:08.361265
  36. ( 1 secs ) network_service_components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:11.566941
  37. ( 1 mins 35 secs ) components_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:12:04.509711
  38. ( 1 secs ) compositor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 29s
  39. ( 29 mins 52 secs ) content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:42:14.876253
  40. ( 1 secs ) perfetto_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 42s
  41. ( 4 secs ) content_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:03:07.246781
  42. ( 1 secs ) courgette_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:42.979121
  43. ( 2 secs ) crashpad_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 31s
  44. ( 1 secs ) cronet_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  45. ( 1 secs ) cronet_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  46. ( 1 secs ) crypto_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  47. ( 2 secs ) device_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  48. ( 2 secs ) display_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  49. ( 1 secs ) elevation_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 12s
  50. ( 1 secs ) events_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  51. ( 1 secs ) extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:20.696814
  52. ( 1 secs ) network_service_extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:30.666166
  53. ( 2 secs ) extensions_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:38.475767
  54. ( 1 secs ) filesystem_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  55. ( 2 secs ) gcm_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  56. ( 4 secs ) gfx_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:44.881526
  57. ( 1 secs ) gin_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  58. ( 1 secs ) google_apis_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  59. ( 4 secs ) gpu_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:30.898375
  60. ( 1 secs ) headless_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:00.661461
  61. ( 1 secs ) headless_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  62. ( 1 secs ) install_static_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  63. ( 1 secs ) installer_util_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 30s
  64. ( 1 secs ) webui_polymer2_interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 51s
  65. ( 2 secs ) ipc_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  66. ( 1 secs ) jingle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  67. ( 2 secs ) latency_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  68. ( 1 secs ) leveldb_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  69. ( 1 secs ) libjingle_xmpp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  70. ( 2 secs ) media_blink_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 39s
  71. ( 1 secs ) media_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 43s
  72. ( 3 secs ) media_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:03.071415
  73. ( 1 secs ) message_center_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  74. ( 2 secs ) midi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  75. ( 1 secs ) mojo_core_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 11s
  76. ( 3 secs ) mojo_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 37s
  77. ( 1 secs ) nacl_loader_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 28s
  78. ( 1 secs ) native_theme_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 12s
  79. ( 13 secs ) net_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:36:14.163012
  80. ( 2 secs ) notification_helper_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 40s
  81. ( 1 secs ) pdf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  82. ( 1 secs ) ppapi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  83. ( 1 secs ) printing_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  84. ( 2 secs ) remoting_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 48s
  85. ( 2 secs ) sbox_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  86. ( 1 secs ) sbox_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  87. ( 1 secs ) sbox_validation_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  88. ( 2 secs ) service_manager_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 31s
  89. ( 4 secs ) services_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:39.926692
  90. ( 1 secs ) setup_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  91. ( 1 secs ) shell_dialogs_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  92. ( 1 secs ) skia_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  93. ( 1 secs ) snapshot_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  94. ( 1 secs ) sql_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  95. ( 2 secs ) storage_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  96. ( 2 secs ) sync_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:18:29.139125
  97. ( 1 secs ) traffic_annotation_auditor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  98. ( 2 secs ) ui_base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  99. ( 2 secs ) ui_touch_selection_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  100. ( 7 secs ) unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:16:17.422442
  101. ( 1 secs ) url_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  102. ( 2 secs ) views_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 58s
  103. ( 2 secs ) viz_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:17.818702
  104. ( 1 secs ) vr_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 32s
  105. ( 1 secs ) vr_pixeltests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 57s
  106. ( 4 secs ) webkit_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:05:47.278635
  107. ( 1 secs ) wm_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  108. ( 1 secs ) wtf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  109. ( 2 secs ) zucchini_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  110. ( 5 secs ) network_service_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:23:20.533149 (shard #0)
    Min shard duration: 0:21:47.570828 (shard #1)
  111. ( 2 secs ) interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:13:22.523957 (shard #2)
    Min shard duration: 0:10:49.050917 (shard #1)
  112. ( 2 secs ) network_service_interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:12:58.098744 (shard #2)
    Min shard duration: 0:11:54.742522 (shard #1)
  113. ( 3 secs ) webui_polymer2_browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:01:31.196885 (shard #2)
    Min shard duration: 0:01:11.497553 (shard #3)
  114. ( 10 secs ) browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:33:14.351749 (shard #0)
    Min shard duration: 0:27:25.956610 (shard #4)
  115. ( 11 secs ) network_service_browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:29:43.379962 (shard #7)
    Min shard duration: 0:20:26.079533 (shard #9)
  116. ( 901 ms ) Tests statistics
     
    Stats
    Total shards: 132
    Total runtime: 15:26:09.219999
     
  117. ( 1 secs ) process_dumps
  118. ( 6 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2923-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539327393590109, "id": "8932891954896956080", "project": "chromium", "tags": ["builder:win-asan", "buildset:commit/git/13767a51fd778bba049621a733ac7fbe6221922b", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/13767a51fd778bba049621a733ac7fbe6221922b", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9098322017025754656", "scheduler_job_id:chromium/win-asan", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "win-asan" setup_build
buildnumber 1786 setup_build
mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "13767a51fd778bba049621a733ac7fbe6221922b" setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "13767a51fd778bba049621a733ac7fbe6221922b" bot_update
got_revision_cp "refs/heads/master@{#599122}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25135}" bot_update
got_clang_revision "344066-1" clang_revision
swarm_hashes_refs/heads/master(at){#599122}_without_patch {"accessibility_unittests": "cb84c7bafadde1d8a1b366b8420a661d2ebd1444", "angle_unittests": "b69baf1c1a2d52ed786497d172224b31232a3ffd", "app_shell_unittests": "8656db4e4163c2f15b965c0069157eb2d5181780", "aura_unittests": "f821566dbe83015d006c600bcb39f04b790617a1", "base_unittests": "990d8b4273e816a1e0927bc750b95e195af58d1a", "blink_common_unittests": "b796f27fc3ce7af9e04915a8714d65cab7b2527c", "blink_fuzzer_unittests": "9fea43629318315961615e464f2ffa3e10e19f94", "blink_heap_unittests": "38e8bc0ec2f6ece2d7c9a96e3fccdadb3175f89e", "blink_platform_unittests": "bf64fa1bc6989878034ad5852f7d11db7c02c531", "boringssl_crypto_tests": "e9e56df4f609ec5eba31c38aa90f8ef22a77339a", "boringssl_ssl_tests": "1584e6790e4882c3c7a96b27752434fa17272d32", "browser_tests": "3db5eb0d8d917ee49f4c49efdb4b8ec0462ca511", "cacheinvalidation_unittests": "4c6f9c9c339c5eaf53555e0d5e4e9bb9c328845b", "capture_unittests": "f9b4df90f23ce31ef066318afe9925392b041d6d", "cast_unittests": "189c0471cc559c441621bd0af54c218565d96c25", "cc_unittests": "f28baf5b034c30be58285ab3fdbec7dc3518685d", "chrome_app_unittests": "e80ca9617476244b5c70ed4d6cd4a6ce855ff841", "chrome_cleaner_unittests": "503e41bd91e9b5be31adfe0688da08ffa1eead72", "chrome_elf_import_unittests": "02c9652614d6034bf77b5a4228fde86936362aa4", "chrome_elf_unittests": "aefe49f19bebed439a9e37334abe2dd68f342e08", "chromedriver_unittests": "2efd84a4db0078911eec338146382a727b86bc1d", "components_browsertests": "a1c6a1411048b8ed1e81c23973a37a3e624a1566", "components_unittests": "035028dc8c9d314147b7476259d4c63c86baa572", "compositor_unittests": "678fda09e289cd00ff51192f06f5358e1cb38561", "content_browsertests": "e3eb1cb63a5ea8f19348b31997719cdd450db863", "content_unittests": "1271674c7a7601542eabd40274a1724ae43a04c5", "courgette_unittests": "0d577b18b3c566b97e82309d839e390daab67f78", "crashpad_tests": "e78c25c03a03d20b3e820db17a3a61478ada5bb3", "cronet_tests": "95367bbf2756f6d209bb80502987446e64a5c079", "cronet_unittests": "77aa0c221e9a982981d1efd570df496438e8d306", "crypto_unittests": "2902a4d1a1854b81c6d82b133263aaf55f52b692", "device_unittests": "1214cff0a1c7f9366ed90c6e9f8a48443f449391", "display_unittests": "a8aa9e53c4446fe59179564c83f60e62f47edb18", "elevation_service_unittests": "d4e5e0b479b28fb0e81773b8f986ef2bf5f4366e", "events_unittests": "0bccfad41cf0e68527113d36bdc85e64ba8219c3", "extensions_browsertests": "7ae10958496101f6facf486d618f6535f0c615c9", "extensions_unittests": "d9cdf0720d937bacba3eabd275862766e3a291ad", "filesystem_service_unittests": "b266648d00be88608e72bb5c6fbe1552e05b10c9", "gcm_unit_tests": "7ee25dffa730d10c3386f247c57f0158d00c0d86", "gfx_unittests": "c60fbf0a9a417f5bfad0f1ee022688a8b3c68729", "gin_unittests": "1d47344cd3098a36e8f17cc55475dde1654220b8", "google_apis_unittests": "d9721aea2471dd7de3c8001dce5078f8d4eb2a35", "gpu_unittests": "a579e111dc7686b9708cbd3d1cc7031e7af08fb2", "headless_browsertests": "0c4ee4166ee780a8515e2b80abb0169f1d2748f6", "headless_unittests": "d7eef1cc5910ff6bc3d5647c233f3069a4d91ed8", "install_static_unittests": "5a23699db4c03a237021977b3d653652eff31e16", "installer_util_unittests": "6c8a07f6af616f5ab8fe1eb7715b0bd791092d4a", "interactive_ui_tests": "120cf7133b5ab74a4fbec801d8e3de28926f49db", "ipc_tests": "cfba1ecab2c8ba9836dc5303a14a692645de7ccf", "jingle_unittests": "70b62b42038ea4ed454c761a898a7af67c14ae8b", "latency_unittests": "df44ffdc1aa76d71901c475b10f65da7b4da527c", "leveldb_service_unittests": "0eb7575bf56b015cf13128ca2a544175bd2d462e", "libjingle_xmpp_unittests": "96ac763e64b1307915bfca0338b698f83cb45bdb", "media_blink_unittests": "6e5134f5043a7c382713ad4006a358778dc65330", "media_service_unittests": "9d37eeac5f3a9888a100f30ed2aa0fbd0761c3b6", "media_unittests": "3562ce0731f6798320797cbf8de58a32b66cf243", "message_center_unittests": "217632571668cfc342a9eb56613d4bd611985e51", "midi_unittests": "8e6ebb49a59aebab18fafb3a2505a8050849f18e", "mojo_core_unittests": "1fc1042417ccf93222e434ba07bc4b8b5677e4b6", "mojo_unittests": "8825cf10d298e6d402969f556759f42e9b3e95d3", "nacl_loader_unittests": "bb91afc60a5d8dbfd5b6b8ee6b57698a7f4eb59c", "native_theme_unittests": "b1ee3bb0540778ec2c1af17460657e78975a3118", "net_unittests": "0cd27503b30547155235490a30ab07525e81489a", "notification_helper_unittests": "a7ab5c0c51cffa4b92abde3a53d133b1f2a936ca", "pdf_unittests": "7d9e002222bf19fdefdb13c45fc42922ba458522", "ppapi_unittests": "9cd49bbd3c583c5cfc48bfae0a415f2d8205ade9", "printing_unittests": "f11018375fadb0e700e3fa5c3f5b373643b2b1f5", "remoting_unittests": "eaa0023717c1de11c5780296285001763ed03345", "sbox_integration_tests": "3e7b41172c2f1c16e08b6546f6a4d58af4c20ded", "sbox_unittests": "e19645af4084d8989ae34913d8cc5a7d56ee5ab8", "sbox_validation_tests": "edae0e1bbb17ae52e71c29c6da16c46ca842c02e", "service_manager_unittests": "abab1c61ea8fb50391c3ad1e97472ce5a83d4e77", "services_unittests": "21054f42c02a227cd5ea9e5c9bc29568362296bc", "setup_unittests": "10f71505dd6470e32c8586b4e9ffbd9a64296677", "shell_dialogs_unittests": "c90889bf7ec43803760767250fd6a5fb1171fa89", "skia_unittests": "bcd28908abeaad4adbde40ca3d6a3fe40c2f439e", "snapshot_unittests": "658626597bda67d245ca219b0d797964efbfd8f0", "sql_unittests": "678b68c42715c7a6ee483dfe1dccfa58d4cb0b9c", "storage_unittests": "1445aca1a82cc4f47ac6df67b80b4ad94151aa61", "sync_integration_tests": "52e0369dc2daf1d4ad9f35f62ba697583a81d21f", "traffic_annotation_auditor_unittests": "b5aa032a86ad9b12e5b13fedb694121e5aa08265", "ui_base_unittests": "81d63013a63fd90e5d44942f248093775b0eccf5", "ui_touch_selection_unittests": "8713bce131e3cdde9e3a4e6e2a7bb9ae72e0cfb7", "unit_tests": "186d720ceec9f38c7a5c3ed958537045f60a7a3a", "url_unittests": "92f0c32e4acffa72ba0b9c87cd1812826c303cfb", "views_unittests": "2c16e0505387d1eda2f07e52953cdf198f23c5c1", "viz_unittests": "ed5753d53df053f300967eb0ea3643fa108f3f46", "vr_common_unittests": "b85e19b9d89f96a69eecf541d1cb9e176ebde7b0", "vr_pixeltests": "ae4aaaca89bd3d7daabe498167afa26bfaf08ec3", "webkit_unit_tests": "5e749771ec445466475a169d4f006f911c7aed22", "wm_unittests": "939f3116520ab85525193dd759a90bbfdd0c63c0", "wtf_unittests": "b0d35e65947d1cfd06cece95bc4894c2dffdd5fd", "zucchini_unittests": "d82862057d3dcc999ca4e20b786b1ec8c762d571"} isolate tests
swarm_hashes {"accessibility_unittests": "cb84c7bafadde1d8a1b366b8420a661d2ebd1444", "angle_unittests": "b69baf1c1a2d52ed786497d172224b31232a3ffd", "app_shell_unittests": "8656db4e4163c2f15b965c0069157eb2d5181780", "aura_unittests": "f821566dbe83015d006c600bcb39f04b790617a1", "base_unittests": "990d8b4273e816a1e0927bc750b95e195af58d1a", "blink_common_unittests": "b796f27fc3ce7af9e04915a8714d65cab7b2527c", "blink_fuzzer_unittests": "9fea43629318315961615e464f2ffa3e10e19f94", "blink_heap_unittests": "38e8bc0ec2f6ece2d7c9a96e3fccdadb3175f89e", "blink_platform_unittests": "bf64fa1bc6989878034ad5852f7d11db7c02c531", "boringssl_crypto_tests": "e9e56df4f609ec5eba31c38aa90f8ef22a77339a", "boringssl_ssl_tests": "1584e6790e4882c3c7a96b27752434fa17272d32", "browser_tests": "3db5eb0d8d917ee49f4c49efdb4b8ec0462ca511", "cacheinvalidation_unittests": "4c6f9c9c339c5eaf53555e0d5e4e9bb9c328845b", "capture_unittests": "f9b4df90f23ce31ef066318afe9925392b041d6d", "cast_unittests": "189c0471cc559c441621bd0af54c218565d96c25", "cc_unittests": "f28baf5b034c30be58285ab3fdbec7dc3518685d", "chrome_app_unittests": "e80ca9617476244b5c70ed4d6cd4a6ce855ff841", "chrome_cleaner_unittests": "503e41bd91e9b5be31adfe0688da08ffa1eead72", "chrome_elf_import_unittests": "02c9652614d6034bf77b5a4228fde86936362aa4", "chrome_elf_unittests": "aefe49f19bebed439a9e37334abe2dd68f342e08", "chromedriver_unittests": "2efd84a4db0078911eec338146382a727b86bc1d", "components_browsertests": "a1c6a1411048b8ed1e81c23973a37a3e624a1566", "components_unittests": "035028dc8c9d314147b7476259d4c63c86baa572", "compositor_unittests": "678fda09e289cd00ff51192f06f5358e1cb38561", "content_browsertests": "e3eb1cb63a5ea8f19348b31997719cdd450db863", "content_unittests": "1271674c7a7601542eabd40274a1724ae43a04c5", "courgette_unittests": "0d577b18b3c566b97e82309d839e390daab67f78", "crashpad_tests": "e78c25c03a03d20b3e820db17a3a61478ada5bb3", "cronet_tests": "95367bbf2756f6d209bb80502987446e64a5c079", "cronet_unittests": "77aa0c221e9a982981d1efd570df496438e8d306", "crypto_unittests": "2902a4d1a1854b81c6d82b133263aaf55f52b692", "device_unittests": "1214cff0a1c7f9366ed90c6e9f8a48443f449391", "display_unittests": "a8aa9e53c4446fe59179564c83f60e62f47edb18", "elevation_service_unittests": "d4e5e0b479b28fb0e81773b8f986ef2bf5f4366e", "events_unittests": "0bccfad41cf0e68527113d36bdc85e64ba8219c3", "extensions_browsertests": "7ae10958496101f6facf486d618f6535f0c615c9", "extensions_unittests": "d9cdf0720d937bacba3eabd275862766e3a291ad", "filesystem_service_unittests": "b266648d00be88608e72bb5c6fbe1552e05b10c9", "gcm_unit_tests": "7ee25dffa730d10c3386f247c57f0158d00c0d86", "gfx_unittests": "c60fbf0a9a417f5bfad0f1ee022688a8b3c68729", "gin_unittests": "1d47344cd3098a36e8f17cc55475dde1654220b8", "google_apis_unittests": "d9721aea2471dd7de3c8001dce5078f8d4eb2a35", "gpu_unittests": "a579e111dc7686b9708cbd3d1cc7031e7af08fb2", "headless_browsertests": "0c4ee4166ee780a8515e2b80abb0169f1d2748f6", "headless_unittests": "d7eef1cc5910ff6bc3d5647c233f3069a4d91ed8", "install_static_unittests": "5a23699db4c03a237021977b3d653652eff31e16", "installer_util_unittests": "6c8a07f6af616f5ab8fe1eb7715b0bd791092d4a", "interactive_ui_tests": "120cf7133b5ab74a4fbec801d8e3de28926f49db", "ipc_tests": "cfba1ecab2c8ba9836dc5303a14a692645de7ccf", "jingle_unittests": "70b62b42038ea4ed454c761a898a7af67c14ae8b", "latency_unittests": "df44ffdc1aa76d71901c475b10f65da7b4da527c", "leveldb_service_unittests": "0eb7575bf56b015cf13128ca2a544175bd2d462e", "libjingle_xmpp_unittests": "96ac763e64b1307915bfca0338b698f83cb45bdb", "media_blink_unittests": "6e5134f5043a7c382713ad4006a358778dc65330", "media_service_unittests": "9d37eeac5f3a9888a100f30ed2aa0fbd0761c3b6", "media_unittests": "3562ce0731f6798320797cbf8de58a32b66cf243", "message_center_unittests": "217632571668cfc342a9eb56613d4bd611985e51", "midi_unittests": "8e6ebb49a59aebab18fafb3a2505a8050849f18e", "mojo_core_unittests": "1fc1042417ccf93222e434ba07bc4b8b5677e4b6", "mojo_unittests": "8825cf10d298e6d402969f556759f42e9b3e95d3", "nacl_loader_unittests": "bb91afc60a5d8dbfd5b6b8ee6b57698a7f4eb59c", "native_theme_unittests": "b1ee3bb0540778ec2c1af17460657e78975a3118", "net_unittests": "0cd27503b30547155235490a30ab07525e81489a", "notification_helper_unittests": "a7ab5c0c51cffa4b92abde3a53d133b1f2a936ca", "pdf_unittests": "7d9e002222bf19fdefdb13c45fc42922ba458522", "ppapi_unittests": "9cd49bbd3c583c5cfc48bfae0a415f2d8205ade9", "printing_unittests": "f11018375fadb0e700e3fa5c3f5b373643b2b1f5", "remoting_unittests": "eaa0023717c1de11c5780296285001763ed03345", "sbox_integration_tests": "3e7b41172c2f1c16e08b6546f6a4d58af4c20ded", "sbox_unittests": "e19645af4084d8989ae34913d8cc5a7d56ee5ab8", "sbox_validation_tests": "edae0e1bbb17ae52e71c29c6da16c46ca842c02e", "service_manager_unittests": "abab1c61ea8fb50391c3ad1e97472ce5a83d4e77", "services_unittests": "21054f42c02a227cd5ea9e5c9bc29568362296bc", "setup_unittests": "10f71505dd6470e32c8586b4e9ffbd9a64296677", "shell_dialogs_unittests": "c90889bf7ec43803760767250fd6a5fb1171fa89", "skia_unittests": "bcd28908abeaad4adbde40ca3d6a3fe40c2f439e", "snapshot_unittests": "658626597bda67d245ca219b0d797964efbfd8f0", "sql_unittests": "678b68c42715c7a6ee483dfe1dccfa58d4cb0b9c", "storage_unittests": "1445aca1a82cc4f47ac6df67b80b4ad94151aa61", "sync_integration_tests": "52e0369dc2daf1d4ad9f35f62ba697583a81d21f", "traffic_annotation_auditor_unittests": "b5aa032a86ad9b12e5b13fedb694121e5aa08265", "ui_base_unittests": "81d63013a63fd90e5d44942f248093775b0eccf5", "ui_touch_selection_unittests": "8713bce131e3cdde9e3a4e6e2a7bb9ae72e0cfb7", "unit_tests": "186d720ceec9f38c7a5c3ed958537045f60a7a3a", "url_unittests": "92f0c32e4acffa72ba0b9c87cd1812826c303cfb", "views_unittests": "2c16e0505387d1eda2f07e52953cdf198f23c5c1", "viz_unittests": "ed5753d53df053f300967eb0ea3643fa108f3f46", "vr_common_unittests": "b85e19b9d89f96a69eecf541d1cb9e176ebde7b0", "vr_pixeltests": "ae4aaaca89bd3d7daabe498167afa26bfaf08ec3", "webkit_unit_tests": "5e749771ec445466475a169d4f006f911c7aed22", "wm_unittests": "939f3116520ab85525193dd759a90bbfdd0c63c0", "wtf_unittests": "b0d35e65947d1cfd06cece95bc4894c2dffdd5fd", "zucchini_unittests": "d82862057d3dcc999ca4e20b786b1ec8c762d571"} find isolated tests

Blamelist:

  1. Jochen Eisinger (jochenohnoyoudont@chromium.org)
  2. yiyix (yiyixohnoyoudont@chromium.org)
  3. Maksim Sisov (msisovohnoyoudont@igalia.com)
  4. Christopher Cameron (ccameronohnoyoudont@chromium.org)
  5. Trent Apted (taptedohnoyoudont@chromium.org)
  6. Sam McNally (sammcohnoyoudont@chromium.org)
  7. Alexandre Courbot (acourbotohnoyoudont@chromium.org)
  8. Trent Apted (taptedohnoyoudont@chromium.org)
  9. Yuki Yamada (yukiyohnoyoudont@google.com)
  10. rajendrant (rajendrantohnoyoudont@chromium.org)
  11. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  12. Patti (patricialorohnoyoudont@chromium.org)
  13. Yuki Yamada (yukiyohnoyoudont@google.com)
  14. Jinsuk Kim (jinsukkimohnoyoudont@chromium.org)
  15. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  16. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  17. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
  18. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
  19. Yuki Yamada (yukiyohnoyoudont@google.com)
  20. Kouhei Ueno (kouheiohnoyoudont@chromium.org)
  21. Justin Cohen (justincohenohnoyoudont@google.com)
  22. John Z Wu (jzwohnoyoudont@chromium.org)
  23. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)

Timing:

Create Friday, 12-Oct-18 06:56:33 UTC
Start Friday, 12-Oct-18 06:56:38 UTC
End Friday, 12-Oct-18 08:50:41 UTC
Pending 4 secs
Execution 1 hrs 54 mins

All Changes:

  1. Remove the round-robin list for third-party additions

    Changed by Jochen Eisinger - jochenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:51:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 13767a51fd778bba049621a733ac7fbe6221922b

    Comments

    Remove the round-robin list for third-party additions
    
    Instead, require an email to opensource-licensing@ again until we
    figured out the new process.
    
    R=jam@chromium.org
    
    Change-Id: I352bd17e42cc1500994ba39368d25a0d91271f9c
    Reviewed-on: https://chromium-review.googlesource.com/c/1275846
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599122}

    Changed files

    • docs/adding_to_third_party.md
    • third_party/OWNERS
  2. GPU_Tests: Remove expectations after rebaseline

    Changed by yiyix - yiyixohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:49:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c30443b0e8a01efd448efc72829fb96584f0db0

    Comments

    GPU_Tests: Remove expectations after rebaseline
    
    Bug: 879379
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I43e957955103e5b2d6e4ae80b296655f1b2aa5b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1277953
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Yi Xu <yiyix@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599121}

    Changed files

    • content/test/gpu/gpu_tests/pixel_expectations.py
  3. [ozone/wayland] Fix kiosk mode.

    Changed by Maksim Sisov - msisovohnoyoudont@igalia.com
    Changed at Friday, 12-Oct-18 06:36:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f154daab631433d3d9706af7f3512aa6b196e52f

    Comments

    [ozone/wayland] Fix kiosk mode.
    
    This CL fixes a fullscreen state changes before the surface is
    activated.
    
    That is, Wayland may ignore fullscreen changes before the surface
    is activated. Thus, store a pending state, and once the surface
    is activated, trigger the change.
    
    Change-Id: I8c0b995eb9f282f6be16e82d094d9dd93821a60a
    Bug: 843018
    Reviewed-on: https://chromium-review.googlesource.com/c/1275885
    Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
    Commit-Queue: Maksim Sisov <msisov@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#599120}

    Changed files

    • ui/ozone/platform/wayland/wayland_window.cc
    • ui/ozone/platform/wayland/wayland_window.h
    • ui/ozone/platform/wayland/wayland_window_unittest.cc
  4. RemoteMacViews: Make fullscreen mode not crash

    Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:34:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 800a927eb503828f5cf6f489739e1a6efc444429

    Comments

    RemoteMacViews: Make fullscreen mode not crash
    
    Fix a few places where we would dereference a BridgedNativeWidgetImpl
    which is null when out-of-process. This doesn't guarantee correct
    behavior, but avoids a crash.
    
    Make WebContentsNSViewBridge::Show resize the web contents view and
    also all of its children.
    
    Bug: 859152
    Change-Id: I948de1e4f79db4a51c5b86e7960356133eff4342
    Reviewed-on: https://chromium-review.googlesource.com/c/1278533
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: ccameron <ccameron@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599119}

    Changed files

    • chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_views.mm
    • content/browser/web_contents/web_contents_ns_view_bridge.mm
  5. Migrate base::AtomicFlag to std::atomic

    Changed by Trent Apted - taptedohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:34:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d64bfc8e330fea105de74137e6e176763dc546a4

    Comments

    Migrate base::AtomicFlag to std::atomic
    
    atomicops.h uses `volatile` which inhibits some compiler optimisations
    without contributing to threading correctness.
    
    Define AtomicFlag::IsSet() in the header, rather than out-of-line.
    Without this, WeakPtr overheads in ObserverListPerfTest_*.CheckedObserver
    in base_perftests are up to 70% greater.
    
    Bug: 891536
    Change-Id: Ibc733042bf0027738b49c70ccbbcefc4cde3289d
    Reviewed-on: https://chromium-review.googlesource.com/c/1278425
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Reviewed-by: Albert J. Wong <ajwong@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599118}

    Changed files

    • base/synchronization/atomic_flag.cc
    • base/synchronization/atomic_flag.h
  6. Make DriveFS opt-out in FilesApp tests.

    Changed by Sam McNally - sammcohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:33:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e9c79d562d8d3b789cca95b6909aa600a1dd39d2

    Comments

    Make DriveFS opt-out in FilesApp tests.
    
    Bug: 891197
    Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
    Reviewed-on: https://chromium-review.googlesource.com/c/1277133
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599117}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
  7. media/gpu/v4l2: use actual number of planes in ioctls

    Changed by Alexandre Courbot - acourbotohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:30:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cec52397f2ea0fb8ac322378d229f1a454edf972

    Comments

    media/gpu/v4l2: use actual number of planes in ioctls
    
    The Tegra V4L2 library has a bug in its handling of VIDIOC_QUERYBUF that
    makes it fail if the number of planes of the passed v4l2_buffer does not
    exactly match the number of planes of the currently set format. This CL
    implements a workaround by first running a VIDIOC_G_FMT ioctl in
    AllocateBuffers(), and then passing the returned number of planes to the
    buffer constructor so the correct value can be passed to
    VIDIOC_QUERYBUF.
    
    And since we have this value, we also use it in VIDIOC_DQBUF.
    
    BUG=893661
    TEST=Checked that VDA unittest was passing on hana (Tegra devices have
    another bug that is fixed in the next CL).
    
    Change-Id: I830334de1cf322302fd476ac5535313ebc65900d
    Reviewed-on: https://chromium-review.googlesource.com/c/1275726
    Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
    Reviewed-by: Pawel Osciak <posciak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599116}

    Changed files

    • media/gpu/v4l2/v4l2_device.cc
    • media/gpu/v4l2/v4l2_device.h
  8. Files App: Move reportPromise,waitUntil to //ui/file_manager/base/js/test_error_reporting.js

    Changed by Trent Apted - taptedohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:29:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4

    Comments

    Files App: Move reportPromise,waitUntil to //ui/file_manager/base/js/test_error_reporting.js
    
    These functions are currently in file_manager/file_manager/common/js/unittest_util.js
    which has a lot of files-app specific stuff that media apps shouldn't
    depend on.
    
     - Move MockAPIEvent to the only unittest (in gallery) that uses it.
     - Delete the redundant copy of waitUntil in list_thumbnail_loader_unittest.js
     - Updates the remaining handcrafted foo_unittest.html files in the files app
       * combination sed-script and manual edit.
    
    Bug: 879035
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I7d54cec253384b46d1cdb7c51f8ff0eb9596ebf1
    Reviewed-on: https://chromium-review.googlesource.com/c/1275545
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599115}

    Changed files

    • ui/file_manager/base/js/BUILD.gn
    • ui/file_manager/base/js/test_error_reporting.js
    • ui/file_manager/file_manager/background/js/device_handler_unittest.html
    • ui/file_manager/file_manager/background/js/duplicate_finder_unittest.html
    • ui/file_manager/file_manager/background/js/file_operation_manager_unittest.html
    • ui/file_manager/file_manager/background/js/import_history_unittest.html
    • ui/file_manager/file_manager/background/js/media_import_handler_unittest.html
    • ui/file_manager/file_manager/background/js/media_scanner_unittest.html
    • ui/file_manager/file_manager/background/js/task_queue_unittest.html
    • ui/file_manager/file_manager/background/js/volume_manager_unittest.html
    • ui/file_manager/file_manager/common/js/BUILD.gn
    • ui/file_manager/file_manager/common/js/metrics_unittest.html
    • ui/file_manager/file_manager/common/js/unittest_util.js
    • ui/file_manager/file_manager/foreground/elements/files_tooltip_unittest.html
    • ui/file_manager/file_manager/foreground/js/BUILD.gn
    • ui/file_manager/file_manager/foreground/js/actions_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/file_tasks_unittest.html
    • ui/file_manager/file_manager/foreground/js/import_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.html
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js
    • ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/multi_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/providers_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/spinner_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
    • ui/file_manager/file_manager/foreground/js/ui/file_tap_handler_unittest.html
    • ui/file_manager/gallery/js/BUILD.gn
    • ui/file_manager/gallery/js/entry_list_watcher_unittest.js
    • ui/file_manager/gallery/js/image_editor/BUILD.gn
    • ui/file_manager/image_loader/BUILD.gn
  9. Rename scopes and context in JSBasedEventListener::handleEvent()

    Changed by Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 06:29:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7d87839234fceb435e01ca49cf72096ef6691599

    Comments

    Rename scopes and context in JSBasedEventListener::handleEvent()
    
    This CL renames some ambiguous name of scope and context in
    JSBasedEventListener::handleEvent().
    
    Split from another one:
    https://chromium-review.googlesource.com/c/chromium/src/+/1270300
    
    Bug: 872138
    Change-Id: I8e772ecdc283fd1585566cf56a52170b777f4608
    Reviewed-on: https://chromium-review.googlesource.com/c/1277135
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Cr-Commit-Position: refs/heads/master@{#599114}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc
  10. Remove service name and refactor data use update to metrics service

    Changed by rajendrant - rajendrantohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:24:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dce70a031f697342a52b900211aa0ba7eceab082

    Comments

    Remove service name and refactor data use update to metrics service
    
    This CL does a bunch of steps to make the servicification easy to do.
    1. Removes the usage of ServiceName in data_use_measurement
    2. Refactors the data use update to metrics service to not take service
    name and instead send if the data use is from metrics component.
    3. To remove the UpdateUsagePrefCallback from DataUseMeasurement(),
    ChromeDataUseMeasurement is introduced that does the posting to UI thread
    (from io_thread.cc). This helps in servicification since there won't be
    thread hop. This also helps when CDUA classes are removed, and
    ChromeDataUseMeasurement can be there without dependency.
    
    Bug: 808498
    Change-Id: I7a4421c9798447c1ca4d39698f69b227cc773d48
    Reviewed-on: https://chromium-review.googlesource.com/c/1272256
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Roger Tawa <rogerta@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599113}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
    • chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
    • chrome/browser/data_use_measurement/chrome_data_use_measurement.cc
    • chrome/browser/data_use_measurement/chrome_data_use_measurement.h
    • chrome/browser/io_thread.cc
    • chrome/browser/io_thread.h
    • chrome/browser/net/system_network_context_manager.cc
    • chrome/browser/net/system_network_context_manager.h
    • chrome/browser/profiles/profile_impl_io_data.cc
    • components/data_use_measurement/core/BUILD.gn
    • components/data_use_measurement/core/DEPS
    • components/data_use_measurement/core/data_use_ascriber.cc
    • components/data_use_measurement/core/data_use_ascriber.h
    • components/data_use_measurement/core/data_use_measurement.cc
    • components/data_use_measurement/core/data_use_measurement.h
    • components/data_use_measurement/core/data_use_measurement_unittest.cc
    • components/data_use_measurement/core/data_use_network_delegate.cc
    • components/data_use_measurement/core/data_use_network_delegate.h
    • components/data_use_measurement/core/data_use_network_delegate_unittest.cc
    • components/data_use_measurement/core/data_use_user_data.cc
    • components/data_use_measurement/core/data_use_user_data.h
    • components/domain_reliability/uploader.cc
    • components/domain_reliability/uploader.h
    • components/metrics/data_use_tracker.cc
    • components/metrics/data_use_tracker.h
    • components/metrics/data_use_tracker_unittest.cc
    • components/metrics/metrics_service.cc
    • components/metrics/metrics_service.h
    • components/metrics/reporting_service.cc
    • components/metrics/reporting_service.h
    • google_apis/gaia/gaia_auth_util.cc
    • google_apis/gaia/gaia_auth_util.h
    • google_apis/gaia/gaia_oauth_client.cc
    • google_apis/gaia/oauth2_api_call_flow.cc
    • tools/metrics/histograms/histograms.xml
  11. Roll src/third_party/chromite 89e4bf93b1a1..e2727ef6f5dc (3 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 06:12:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 028fceebebe0743ddd7bb16dc8b753ae0f41a3f2

    Comments

    Roll src/third_party/chromite 89e4bf93b1a1..e2727ef6f5dc (3 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/89e4bf93b1a1..e2727ef6f5dc
    
    
    git log 89e4bf93b1a1..e2727ef6f5dc --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 dgarrett@google.com builder_status_lib: Fix logging lint error.
    2018-10-12 vapier@chromium.org paygen: paygen_payload_lib: convert to gs.LS
    2018-10-12 vapier@chromium.org paygen: urilib_unittest: convert mox to mock
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@e2727ef6f5dc
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I2f3527661843ab9aafccf5f4f58b19fdde879453
    Reviewed-on: https://chromium-review.googlesource.com/c/1278301
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599112}

    Changed files

    • DEPS
  12. Revert "[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering."

    Changed by Patti - patricialorohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:10:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c2893ee9102687d16f2f65fa96651d8bd1fdab7

    Comments

    Revert "[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering."
    
    This reverts commit 86da6573944f302cf9df04d59a7e35bba895d059.
    
    Reason for revert: This patch may be causing failures in browser_tests, on chromium.win/Win7 Tests (dbg)(1)
      https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29
    
    Findit found culprit 598844 with 75% confidence, so reverting this to try and fix.
    
    Original change's description:
    > [Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.
    > 
    > * The service shouldn't unregister from the topics, when handler
    > the Handler is unregistering from topic (as stated in the documentation
    > for for UnregisterHandler).
    > * Sync shouldn't unregister on browser shutdown
    > 
    > Bug: 801985, 876274
    > Change-Id: I857da7b0fbfa0a0f2e1ad05708cc24cdc9386a76
    > Reviewed-on: https://chromium-review.googlesource.com/c/1196522
    > Commit-Queue: Tatiana Gornak <melandory@chromium.org>
    > Reviewed-by: Gabriel Charette <gab@chromium.org>
    > Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598844}
    
    TBR=gab@chromium.org,pavely@chromium.org,melandory@chromium.org
    
    Change-Id: I70fa87c3476925814408665644acb23c3c1f1614
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 801985, 876274, 894715
    Reviewed-on: https://chromium-review.googlesource.com/c/1278273
    Reviewed-by: Patti <patricialor@chromium.org>
    Commit-Queue: Patti <patricialor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599111}

    Changed files

    • chrome/browser/prefs/browser_prefs.cc
    • components/invalidation/impl/BUILD.gn
    • components/invalidation/impl/fcm_fake_invalidator.cc
    • components/invalidation/impl/fcm_invalidation_listener.cc
    • components/invalidation/impl/fcm_invalidation_listener.h
    • components/invalidation/impl/fcm_invalidation_service.cc
    • components/invalidation/impl/fcm_invalidation_service.h
    • components/invalidation/impl/fcm_invalidation_service_unittest.cc
    • components/invalidation/impl/invalidator_registrar.cc
    • components/invalidation/impl/invalidator_registrar.h
    • components/invalidation/impl/invalidator_registrar_with_memory.cc
    • components/invalidation/impl/invalidator_registrar_with_memory.h
    • components/sync/driver/glue/sync_backend_host_impl.cc
  13. Create v8::HandleScope in JSBasedEventListener::GetSourceLocation()

    Changed by Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 06:08:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f93617e5eb9f06935b07002223f33d164f517909

    Comments

    Create v8::HandleScope in JSBasedEventListener::GetSourceLocation()
    
    This is the bug fixing for previous CL:
    https://chromium-review.googlesource.com/c/chromium/src/+/1253317
    
    v8::HandleScope was not named.
    
    Bug: 894069
    Change-Id: Ib9111275bad434b1968a4bd674a0b8932b8c1533
    Reviewed-on: https://chromium-review.googlesource.com/c/1278548
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599110}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc
  14. Android: Ensure single TabWebContentsObserver per Tab

    Changed by Jinsuk Kim - jinsukkimohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:07:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e0a45684f1cc9e125daed78cb74c7939415ebadc

    Comments

    Android: Ensure single TabWebContentsObserver per Tab
    
    TabWebContentsObserver is TabWebContentsUserData which is created
    for the first active WebContents for a given Tab, and finally
    destroyed together with the Tab. There was a bug creating
    multiple instances of the observer for every new active WebContents.
    This left an instance for old WebContents undestroyed, and caused
    a reported bug for already nulled out WebContents references
    while handling an event that should not have been triggered.
    
    This CL makes sure there will be a single TabWebContentsObserver
    for Tab.
    
    Bug: 894353
    Change-Id: Ie2cbe5c79b4d1e9f68d1be045c4d7e88d91c5312
    Reviewed-on: https://chromium-review.googlesource.com/c/1278426
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599109}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
  15. Roll src/third_party/webrtc 8f4bc41c4231..a54daf162fac (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 06:05:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d4f9a68490476ebc67a19242ed76606d57aa853

    Comments

    Roll src/third_party/webrtc 8f4bc41c4231..a54daf162fac (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/8f4bc41c4231..a54daf162fac
    
    
    git log 8f4bc41c4231..a54daf162fac --date=short --no-merges --format='%ad %ae %s'
    2018-10-11 benwright@webrtc.org Reland "Move CryptoOptions to api/crypto from rtc_base/sslstreamadapter.h"
    2018-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9d052f4b6f..37b6d53f02 (598839:598967)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@a54daf162fac
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I3d22153c1dd390398aa7dda8a0f8a00d032fc627
    Reviewed-on: https://chromium-review.googlesource.com/c/1278298
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599108}

    Changed files

    • DEPS
  16. Roll src-internal 09c355ef00f4..aebffd21b13f (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 05:52:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b8143822153ed2373d843fd588593070ed59894c

    Comments

    Roll src-internal 09c355ef00f4..aebffd21b13f (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09c355ef00f4..aebffd21b13f
    
    
    Created with:
      gclient setdep -r src-internal@aebffd21b13f
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I816f02425f0557bf4030f14078bb453721cca6fe
    Reviewed-on: https://chromium-review.googlesource.com/c/1278300
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599107}

    Changed files

    • DEPS
  17. Signed Exchange: Populate completion time for inner response

    Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 05:49:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cb0dee4694e580a614f5d380e0c60526cdfd2b90

    Comments

    Signed Exchange: Populate completion time for inner response
    
    This fixes a bug where Resource Timing for prefetched Signed Exchange
    had negative duration value.
    
    Bug: 803774
    Change-Id: I77006c803c12a6f645f2d5145a4e37e9321757f8
    Reviewed-on: https://chromium-review.googlesource.com/c/1278546
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599106}

    Changed files

    • content/browser/web_package/signed_exchange_loader.cc
    • third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-prefetch-resource-timing.html
  18. [Sync::USS] Handle corrupted bookmarks metadata

    Changed by Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 05:42:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fb7986d88b0b8f174020916003d6939d2d928b83

    Comments

    [Sync::USS] Handle corrupted bookmarks metadata
    
    At startup, the persisted sync metadata (if available) are loaded
    and tracked.
    
    This CL adds some integrity checks and makes sure that corrupted
    metadata are ignored, and that Sync starts clean in such case.
    
    
    Bug: 516866
    Change-Id: Idf42cce2306f18a94941d40caa1816f737732156
    Reviewed-on: https://chromium-review.googlesource.com/c/1274106
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599105}

    Changed files

    • components/sync_bookmarks/BUILD.gn
    • components/sync_bookmarks/DEPS
    • components/sync_bookmarks/bookmark_model_type_processor.cc
    • components/sync_bookmarks/bookmark_model_type_processor.h
    • components/sync_bookmarks/bookmark_model_type_processor_unittest.cc
    • components/sync_bookmarks/synced_bookmark_tracker.cc
    • components/sync_bookmarks/synced_bookmark_tracker.h
    • components/sync_bookmarks/synced_bookmark_tracker_unittest.cc
  19. Add a comment for backup_incumbent_scope in JSEventHandler::SetCompiledHandler()

    Changed by Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 05:38:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e151e38b3dabf71057cd3f303490937fbc24bad

    Comments

    Add a comment for backup_incumbent_scope in JSEventHandler::SetCompiledHandler()
    
    This adds a comment for the previous change:
    https://chromium-review.googlesource.com/c/chromium/src/+/1276406
    
    Bug: 893951
    Change-Id: Ib7a14eedb9922a03c0f6121205c55a9924a5fd7c
    Reviewed-on: https://chromium-review.googlesource.com/c/1278070
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599104}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_event_handler.cc
  20. Implement SignedExchange.Prefetch UMAs

    Changed by Kouhei Ueno - kouheiohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 05:30:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 97df84454db873390762a20012a30407d6bd1ed5

    Comments

    Implement SignedExchange.Prefetch UMAs
    
    Bug: 890180
    Change-Id: I5de8d5b1bdb154455a59e5106ebcefd4973d5bcd
    Reviewed-on: https://chromium-review.googlesource.com/c/1275746
    Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599103}

    Changed files

    • content/browser/loader/prefetch_url_loader_service.cc
    • content/browser/web_package/signed_exchange_loader.cc
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder.cc
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder.h
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder_unittest.cc
    • content/browser/web_package/signed_exchange_request_handler_browsertest.cc
    • content/test/BUILD.gn
    • tools/metrics/histograms/histograms.xml
  21. [ios] Move FYI xcode-clang bot back to Xcode 10.

    Changed by Justin Cohen - justincohenohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 05:20:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1af4ddc196ec7424ff808b37f3ec67aa36577a0c

    Comments

    [ios] Move FYI xcode-clang bot back to Xcode 10.
    
    This bot was erronously moved from Xcode 10 beta 4 all the way to Xcode 10.1
    beta.  Now that Xcode 10 GM is in goma, roll to Xcode 10.
    
    Note: This rolls to 10a254a, which is slightly different than the package
    goma installed, but it has the same compiler (clang-1000.11.45.2) so it should
    work the same.  If not, we'll have to investigate why and upload a new package
    to CIPD.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I46e90d60eb562f69d1848df3ff48db3d82cf1cc1
    Reviewed-on: https://chromium-review.googlesource.com/c/1278331
    Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
    Commit-Queue: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599102}

    Changed files

    • ios/build/bots/chromium.fyi/ios12-sdk-xcode-clang.json
  22. Some fixes for sync:

    Changed by John Z Wu - jzwohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 05:16:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 877046da44d232fb9de9bcbaee249c83ff8b0d1e

    Comments

    Some fixes for sync:
    
    1. Disable feature SyncUserConsentSeparateType for now.
    2. Use ReloadCredentials since LoadCredentials DCHECKs and fix up the tests.
    
    Bug: 867548
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I3a9af1b353b3138b411ee9fdab6cc67c447ee109
    Reviewed-on: https://chromium-review.googlesource.com/c/1278471
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: John Wu <jzw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599101}

    Changed files

    • ios/web_view/BUILD.gn
    • ios/web_view/internal/sync/cwv_sync_controller.mm
    • ios/web_view/internal/sync/cwv_sync_controller_unittest.mm
    • ios/web_view/internal/web_view_web_main_parts.mm
  23. Roll src/third_party/angle c4533eae082f..671809e62e80 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 05:16:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 155a1c23d2f8953f50fcff84366cfaea19f0691e

    Comments

    Roll src/third_party/angle c4533eae082f..671809e62e80 (2 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/c4533eae082f..671809e62e80
    
    
    git log c4533eae082f..671809e62e80 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 jiajia.qin@intel.com ES31: Add vector and matrix support in SSBO for D3D
    2018-10-12 jiajia.qin@intel.com ES31: Collect shader storage blocks info for d3d.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@671809e62e80
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=fjhenigman@chromium.org
    
    Change-Id: Ie918b1391ee226eb39be833dc7768cec9bdbee65
    Reviewed-on: https://chromium-review.googlesource.com/c/1278299
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599100}

    Changed files

    • DEPS